Re: [PR] Fixed: Accounts Payable Past Due Invoices doesn't show outstanding amount (OFBIZ-13068) [ofbiz-framework]

2024-04-24 Thread via GitHub


sonarcloud[bot] commented on PR #786:
URL: https://github.com/apache/ofbiz-framework/pull/786#issuecomment-2076498211

   ## [![Quality Gate 
Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png
 'Quality Gate 
Passed')](https://sonarcloud.io/dashboard?id=apache_ofbiz-framework&pullRequest=786)
 **Quality Gate passed**  
   Issues  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png
 '') [0 New 
issues](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=786&resolved=false&inNewCodePeriod=true)
  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/accepted-16px.png
 '') [0 Accepted 
issues](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework&pullRequest=786&metric=new_accepted_issues&view=list)
   
   Measures  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png
 '') [0 Security 
Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework&pullRequest=786&resolved=false&inNewCodePeriod=true)
  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/no-data-16px.png
 '') No data about Coverage  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png
 '') [0.0% Duplication on New 
Code](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework&pullRequest=786&metric=new_duplicated_lines_density&view=list)
  
 
   [See analysis details on 
SonarCloud](https://sonarcloud.io/dashboard?id=apache_ofbiz-framework&pullRequest=786)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@ofbiz.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[PR] Fixed: Accounts Payable Past Due Invoices doesn't show outstanding amount (OFBIZ-13068) [ofbiz-framework]

2024-04-24 Thread via GitHub


PierreSmits opened a new pull request, #786:
URL: https://github.com/apache/ofbiz-framework/pull/786

   With recent changes via commit ec0adc02f102d75be15e1ee04062b75621219f0d 
[ec0adc02f1] the field outstanding got replaced with amountToApply in grid 
ListApReport.
   
   modified: InvoiceForms.xml
   - replaced field amountToApply with outstanding in grid ListApReport
   - corrected style of fields total and outstanding in grid ListArReport
   - corrected style of fields total and outstanding in grid ListApReport


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@ofbiz.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Created] (OFBIZ-13068) Accounts Payable Past Due Invoices doesn't show outstanding amount

2024-04-24 Thread Pierre Smits (Jira)
Pierre Smits created OFBIZ-13068:


 Summary: Accounts Payable Past Due Invoices doesn't show 
outstanding amount
 Key: OFBIZ-13068
 URL: https://issues.apache.org/jira/browse/OFBIZ-13068
 Project: OFBiz
  Issue Type: Improvement
  Components: accounting
Reporter: Pierre Smits


With recent changes via commit ec0adc02f102d75be15e1ee04062b75621219f0d 
[ec0adc02f1] the field outstanding got replaced with amountToApply in grid 
ListApReport.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Closed] (OFBIZ-3373) Adding menu merging feature

2024-04-24 Thread Jacques Le Roux (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-3373?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux closed OFBIZ-3373.
--
Resolution: Abandoned

> Adding menu merging feature
> ---
>
> Key: OFBIZ-3373
> URL: https://issues.apache.org/jira/browse/OFBIZ-3373
> Project: OFBiz
>  Issue Type: Wish
>  Components: framework
>Reporter: Bruno Busco
>Priority: Minor
> Attachments: googlebase-inject.patch, injections.patch, 
> injections.patch, links.jpg, partymenu.JPG
>
>
> Hi devs,
> while discussing in the ML about modules and framework separation I thought 
> to this new feature that I would like to discuss here with you.
> We have now the possibility to extend a menu from one other. This is great in 
> order to have an high level of code reuse and great consistency all over 
> OFBiz.
> I was thinking to a sort of "merges-to" property for the menu widget.
> This would allow a new module to specify an already exixting menu name (in 
> the framework core or in a lower level module) that should be somewhat 
> changed by the actual menu.
> For instance, in the attached image partymenu.jpg there is a a tipical use of 
> this feature:
> in the party module there are lot of links that co to order application, 
> account etc. Those menu link could be used defining a simple menu (say it 
> partylinks_menu) in the party application that contains only party or 
> framework related links (i.e. profile); additional components like order or 
> accounting could define more menus that merges-to the partylinks_manu so that 
> when the menu is rendered IN THE PARTY APPLICATION the new menu items added 
> in the order and accounting applications are also rendered.
> This would allow us to dramatically reduce the component dependence and help 
> us to have the framework-only distribution.
> To eventually implement this I think there should be an entity that defines 
> such mergin menus and the menu rendered should lookup the entity to check if 
> one or more merges to the actually rendering menu is defined.
> I would appreciate to hear from you if this idea can help.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Closed] (OFBIZ-3807) Application name localizations should not be defined in the CommonUiLabels framework file

2024-04-24 Thread Jacques Le Roux (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-3807?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux closed OFBIZ-3807.
--
Resolution: Abandoned

> Application name localizations should not be defined in the CommonUiLabels 
> framework file
> -
>
> Key: OFBIZ-3807
> URL: https://issues.apache.org/jira/browse/OFBIZ-3807
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL COMPONENTS
>Affects Versions: Trunk, Upcoming Branch
>Reporter: Bruno Busco
>Priority: Minor
> Attachments: POC_InjectedMainMenu.patch
>
>
> There is a weak dependence from the framework to ALL applications because the 
> application name localization for the application menu is defined in 
> CommonUiLabels.xml file.
> Whenever a user wants to add an application and localize its name, a new 
> entry in CommonUiLabels.xml framework file needs to be created.
> How could we have the application menu use the application specific labels 
> file to get the localitazion?
> The injectable menu we are speaking about could be the solution.
> A simple main menu could be defined in the framework with only the Webtools 
> and Example menu entries.
> Every application could inject its own application menu entries.
> An application could also inject menu entries in several different menus so 
> that, for example all application's administrations could be placed in one 
> unique high level "admin" menu entry.
> This could also allow a party/content binding component to inject menu 
> entries into otherwise stand-alone party and content applications.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Closed] (OFBIZ-13035) Fix cross-app menu location issues

2024-04-24 Thread Jacques Le Roux (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-13035?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux closed OFBIZ-13035.
---
  Assignee: Jacques Le Roux
Resolution: Incomplete

I close as incomplete even if that is not proved because it's now a mess. 
Better create a new clear one

> Fix cross-app menu location issues
> --
>
> Key: OFBIZ-13035
> URL: https://issues.apache.org/jira/browse/OFBIZ-13035
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: ALL APPLICATIONS
>Affects Versions: Upcoming Branch
>Reporter: Pierre Smits
>Assignee: Jacques Le Roux
>Priority: Major
> Fix For: Upcoming Branch
>
>
> address cross application menu-location issues.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


Re: [PR] Improved: Marketing-Main page (OFBIZ-13054) [ofbiz-framework]

2024-04-24 Thread via GitHub


sonarcloud[bot] commented on PR #785:
URL: https://github.com/apache/ofbiz-framework/pull/785#issuecomment-2076478498

   ## [![Quality Gate 
Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png
 'Quality Gate 
Passed')](https://sonarcloud.io/dashboard?id=apache_ofbiz-framework&pullRequest=785)
 **Quality Gate passed**  
   Issues  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png
 '') [0 New 
issues](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=785&resolved=false&inNewCodePeriod=true)
  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/accepted-16px.png
 '') [0 Accepted 
issues](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework&pullRequest=785&metric=new_accepted_issues&view=list)
   
   Measures  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png
 '') [0 Security 
Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework&pullRequest=785&resolved=false&inNewCodePeriod=true)
  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/no-data-16px.png
 '') No data about Coverage  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png
 '') [0.0% Duplication on New 
Code](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework&pullRequest=785&metric=new_duplicated_lines_density&view=list)
  
 
   [See analysis details on 
SonarCloud](https://sonarcloud.io/dashboard?id=apache_ofbiz-framework&pullRequest=785)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@ofbiz.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Closed] (OFBIZ-5802) Contact.ftl generates errors when accessed anonymously

2024-04-24 Thread Jacques Le Roux (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-5802?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux closed OFBIZ-5802.
--
Resolution: Won't Fix

> Contact.ftl generates errors when accessed anonymously
> --
>
> Key: OFBIZ-5802
> URL: https://issues.apache.org/jira/browse/OFBIZ-5802
> Project: OFBiz
>  Issue Type: Bug
>  Components: party
>Affects Versions: Release Branch 11.04, Release Branch 12.04, Release 
> Branch 13.07, Trunk, Upcoming Branch
>Reporter: Pierre Smits
>Priority: Major
>  Labels: portal, portalPage, portlet, profile
>
> When accessing a screen that delivers the PartyProfile portalpage as an 
> anonymous user, the Contact portlet (which renders contact.ftl) shows a lot 
> of errors.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[PR] Improved: Marketing-Main page (OFBIZ-13054) [ofbiz-framework]

2024-04-24 Thread via GitHub


PierreSmits opened a new pull request, #785:
URL: https://github.com/apache/ofbiz-framework/pull/785

   Currently the 'main' view-map points to a screen showing a label
   In order to improve the user experience the main request-map and view-map 
should show what is most pressing in marketing to address: active campaigns and 
contact list communication events.
   
   added:
   - MarketingPortletData.xml, having record definitions for PortalPage, 
Portlet, etc
   
   modified::
   - ofbiz-component.xml: added data loader for MarketingPortletData.xml
   - controller.xml: changed view-map 'main' to point to screen Main in 
CommonScreens.xml
   - CommonScreens.xml: screen Main displaying a PortalPage
   - MarketingCampaignScreens.xml: adding screen Campaigns for active campaigns
   - MarketingCampaignForms.xml: adding grid Campaigns to list active campaigns
   - ContactListScreens.xml: adding screen CommEvents for active communication 
events
   - ContactListForms.xml: adding grid Campaigns to list active communication 
events
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@ofbiz.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Closed] (OFBIZ-5573) Implementation of VENDOR MANAGEMENT software in Ofbiz in ecommerce component

2024-04-24 Thread Jacques Le Roux (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-5573?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux closed OFBIZ-5573.
--
Resolution: Abandoned

> Implementation  of VENDOR MANAGEMENT software in Ofbiz in ecommerce component
> -
>
> Key: OFBIZ-5573
> URL: https://issues.apache.org/jira/browse/OFBIZ-5573
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ecommerce
> Environment: Software platform, Ecommerce component, Party Component,
> Catalog Component
>Reporter: Heidi Dehaes
>Priority: Trivial
> Attachments: Apache Ofbiz Marketplace - Vendor Approval Flow.png, 
> vendor_spec-1.pdf, vendor_spec.doc, vendor_spec.doc, 
> vendor_specifications_17_Oktober_2014-2B.doc, 
> vendor_specifications_17_Oktober_2014.doc, 
> vendor_specifications_17_Oktober_2014.doc, 
> vendor_specifications_20_March_2015.doc, vendor_specifications_2_july_2014.doc
>
>
> Wants to initiate the development of a VENDOR ENVIRONMENT AND MANAGEMENT for 
> ofbiz in the ecommerce component as exists also in the Amazon ecommerce 
> websites. An external vendor must be able to put products and sell the 
> products on the ecommerce platform of the owner.
> Involved: 
> - ioannis ntantis 
> - Heidi & Eric 
> Requirements:
> - ... to be added.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Created] (OFBIZ-13067) Error while rendering content [APACHE_OFBIZ_HTML]

2024-04-24 Thread Jacques Le Roux (Jira)
Jacques Le Roux created OFBIZ-13067:
---

 Summary: Error while rendering content [APACHE_OFBIZ_HTML]
 Key: OFBIZ-13067
 URL: https://issues.apache.org/jira/browse/OFBIZ-13067
 Project: OFBiz
  Issue Type: Bug
  Components: content
Affects Versions: 18.12.12
Reporter: Jacques Le Roux
 Fix For: 18.12.13


This error exists only in R18.12 and it clutters the logs a bit. 
I have yet no idea how to reproduce it.

It seems related to CmsEvents.java and a "XSLT" template. It's the only place 
where "runtime/tempfiles/docbook.css" is created:
{code:java}
} else if ("XSLT".equals(dataTemplateTypeId)) {
File targetFileLocation = new 
File(System.getProperty("ofbiz.home")+"/runtime/tempfiles/docbook.css");
{code}
That's in DataResourceWorker.java[725]

 

But the error appears elsewhere (see end of log below):

 
{noformat}
(No such file or directory))
at org.apache.ofbiz.content.cms.CmsEvents.cms(CmsEvents.java:327) ~[ofbiz.jar:?]
{noformat}
 

 Here the complete log error:
{noformat}
2024-04-24 10:25:31,020 |0.0.0.0-8009-exec-20 |RequestHandler |E| Request cms 
caused an error with the following message: Erreur lors de l'appel de 
l'événement: org.apache.ofbiz.webapp.event.EventHandlerException: Problems 
processing event: org.apache.ofbiz.base.util.GeneralRuntimeException: Error in 
the response writer/output stream while rendering content [APACHE_OFBIZ_HTML] 
with path alias [APACHE_OFBIZ_HTML] (/ofbiz/runtime/tempfiles/docbook.css (No 
such file or directory)) (Error in the response writer/output stream while 
rendering content [APACHE_OFBIZ_HTML] with path alias [APACHE_OFBIZ_HTML] 
(/ofbiz/runtime/tempfiles/docbook.css (No such file or directory)))
2024-04-24 10:25:31,025 |0.0.0.0-8009-exec-20 |JavaEventHandler |E| Problems 
Processing Event
org.apache.ofbiz.base.util.GeneralRuntimeException: Error in the response 
writer/output stream while rendering content [APACHE_OFBIZ_HTML] with path 
alias [APACHE_OFBIZ_HTML] (/ofbiz/runtime/tempfiles/docbook.css (No such file 
or directory))
at org.apache.ofbiz.content.cms.CmsEvents.cms(CmsEvents.java:327) ~[ofbiz.jar:?]
{noformat}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


Re: [PR] Improved: Manufacturing-Main page (OFBIZ-13053) [ofbiz-framework]

2024-04-24 Thread via GitHub


sonarcloud[bot] commented on PR #784:
URL: https://github.com/apache/ofbiz-framework/pull/784#issuecomment-2075300805

   ## [![Quality Gate 
Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png
 'Quality Gate 
Passed')](https://sonarcloud.io/dashboard?id=apache_ofbiz-framework&pullRequest=784)
 **Quality Gate passed**  
   Issues  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png
 '') [0 New 
issues](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=784&resolved=false&inNewCodePeriod=true)
  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/accepted-16px.png
 '') [0 Accepted 
issues](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework&pullRequest=784&metric=new_accepted_issues&view=list)
   
   Measures  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png
 '') [0 Security 
Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework&pullRequest=784&resolved=false&inNewCodePeriod=true)
  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/no-data-16px.png
 '') No data about Coverage  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png
 '') [0.0% Duplication on New 
Code](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework&pullRequest=784&metric=new_duplicated_lines_density&view=list)
  
 
   [See analysis details on 
SonarCloud](https://sonarcloud.io/dashboard?id=apache_ofbiz-framework&pullRequest=784)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@ofbiz.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[PR] Improved: Manufacturing-Main page (OFBIZ-13053) [ofbiz-framework]

2024-04-24 Thread via GitHub


PierreSmits opened a new pull request, #784:
URL: https://github.com/apache/ofbiz-framework/pull/784

   Currently the 'main' view-map points to the 'FindProductionRun' screen. In 
order to improve the user experience, the main request-map and view-map should 
show what is most pressing in manufacturing to address: the production runs in 
progress.
   
   added:
   - ManufacturingPortletData.xml, having record definitions for PortalPage, 
Portlet, etc
   
   modified::
   - ofbiz-component.xml: added data loader for ManufacturingPortletData.xml
   - controller.xml: changed view-map 'main' to point to screen Main in 
CommonScreens.xml
   - CommonScreens.xml: adding screen Main displaying a PortalPage
   - JobShopScreens.xml: adding screen ProdRun for production runs to process
   - ProductionRunForms.xml: adding grid ProdRun to list production runs to 
process


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@ofbiz.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Created] (OFBIZ-13066) Remove duplicated menu main buttons

2024-04-24 Thread Jacques Le Roux (Jira)
Jacques Le Roux created OFBIZ-13066:
---

 Summary: Remove duplicated menu main buttons
 Key: OFBIZ-13066
 URL: https://issues.apache.org/jira/browse/OFBIZ-13066
 Project: OFBiz
  Issue Type: Improvement
  Components: ALL APPLICATIONS, ALL PLUGINS
Affects Versions: Upcoming Branch
Reporter: Jacques Le Roux


Since the almost generalised use of portal and portlet, and maybe before, some 
apps show duplicated menu main buttons.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Updated] (OFBIZ-13054) Marketing-Main page

2024-04-24 Thread Pierre Smits (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-13054?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pierre Smits updated OFBIZ-13054:
-
Description: 
Currently the 'main' view-map points to a screen showing a label

In order to improve the user experience the main request-map and view-map 
should show what is most pressing in marketing to address: active campaigns and 
contact list communication events.

> Marketing-Main page
> ---
>
> Key: OFBIZ-13054
> URL: https://issues.apache.org/jira/browse/OFBIZ-13054
> Project: OFBiz
>  Issue Type: Sub-task
>Reporter: Pierre Smits
>Priority: Major
>
> Currently the 'main' view-map points to a screen showing a label
> In order to improve the user experience the main request-map and view-map 
> should show what is most pressing in marketing to address: active campaigns 
> and contact list communication events.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Updated] (OFBIZ-13053) Manufacturing-Main page

2024-04-24 Thread Pierre Smits (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-13053?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pierre Smits updated OFBIZ-13053:
-
Description: 
Currently the 'main' view-map points to the 'FindProductionRun' screen.

In order to improve the user experience the main request-map and view-map 
should show what is most pressing in manufacturing to address: the production 
runs in progress.

> Manufacturing-Main page
> ---
>
> Key: OFBIZ-13053
> URL: https://issues.apache.org/jira/browse/OFBIZ-13053
> Project: OFBiz
>  Issue Type: Sub-task
>Reporter: Pierre Smits
>Priority: Major
>
> Currently the 'main' view-map points to the 'FindProductionRun' screen.
> In order to improve the user experience the main request-map and view-map 
> should show what is most pressing in manufacturing to address: the production 
> runs in progress.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


Re: [PR] Improved: Facility-Main page (OFBIZ-13051) [ofbiz-framework]

2024-04-24 Thread via GitHub


sonarcloud[bot] commented on PR #783:
URL: https://github.com/apache/ofbiz-framework/pull/783#issuecomment-2074533549

   ## [![Quality Gate 
Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png
 'Quality Gate 
Passed')](https://sonarcloud.io/dashboard?id=apache_ofbiz-framework&pullRequest=783)
 **Quality Gate passed**  
   Issues  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png
 '') [0 New 
issues](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=783&resolved=false&inNewCodePeriod=true)
  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/accepted-16px.png
 '') [0 Accepted 
issues](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework&pullRequest=783&metric=new_accepted_issues&view=list)
   
   Measures  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png
 '') [0 Security 
Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework&pullRequest=783&resolved=false&inNewCodePeriod=true)
  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/no-data-16px.png
 '') No data about Coverage  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png
 '') [0.0% Duplication on New 
Code](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework&pullRequest=783&metric=new_duplicated_lines_density&view=list)
  
 
   [See analysis details on 
SonarCloud](https://sonarcloud.io/dashboard?id=apache_ofbiz-framework&pullRequest=783)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@ofbiz.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Commented] (OFBIZ-13049) Configurable Main page

2024-04-24 Thread Pierre Smits (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-13049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17840353#comment-17840353
 ] 

Pierre Smits commented on OFBIZ-13049:
--

I can imagine that a lot of developers (and their employers) could be angry 
with their customization experience.  

If only they would come forward and would make actionable suggestions (e.g. in 
the form of Jira ticket), the project (and its contributors) would have 
something to work with.

> Configurable Main page
> --
>
> Key: OFBIZ-13049
> URL: https://issues.apache.org/jira/browse/OFBIZ-13049
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL APPLICATIONS
>Reporter: Pierre Smits
>Priority: Major
>
> Currently the OFBiz product has configurable Main pages in applications 
> Accounting, Order, SFA, and plugin MyPortal. Unfortunately, none in the 
> community felt the urge to implement the concept further in other 
> applications.
> Having a configurable Main page of an application improves both the appeal of 
> OFBiz to (potential) adopters and their users, and to developers.
> With a configurable Main page, developers have less screens to consider when 
> doing customisation, while at the same time trying to stay in sync with 
> changes from the project.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (OFBIZ-13049) Configurable Main page

2024-04-24 Thread Michael Brohl (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-13049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17840348#comment-17840348
 ] 

Michael Brohl commented on OFBIZ-13049:
---

If there are solutions present which are problematic, we should not go this way 
further with new implementations.

We should stop merging those solutions until those issues are discussed and we 
agreed to go this way.

 

> Configurable Main page
> --
>
> Key: OFBIZ-13049
> URL: https://issues.apache.org/jira/browse/OFBIZ-13049
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL APPLICATIONS
>Reporter: Pierre Smits
>Priority: Major
>
> Currently the OFBiz product has configurable Main pages in applications 
> Accounting, Order, SFA, and plugin MyPortal. Unfortunately, none in the 
> community felt the urge to implement the concept further in other 
> applications.
> Having a configurable Main page of an application improves both the appeal of 
> OFBiz to (potential) adopters and their users, and to developers.
> With a configurable Main page, developers have less screens to consider when 
> doing customisation, while at the same time trying to stay in sync with 
> changes from the project.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


Re: [PR] Improved: Facility-Main page (OFBIZ-13051) [ofbiz-framework]

2024-04-24 Thread via GitHub


sonarcloud[bot] commented on PR #783:
URL: https://github.com/apache/ofbiz-framework/pull/783#issuecomment-2074438614

   ## [![Quality Gate 
Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png
 'Quality Gate 
Passed')](https://sonarcloud.io/dashboard?id=apache_ofbiz-framework&pullRequest=783)
 **Quality Gate passed**  
   Issues  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png
 '') [0 New 
issues](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=783&resolved=false&inNewCodePeriod=true)
  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/accepted-16px.png
 '') [0 Accepted 
issues](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework&pullRequest=783&metric=new_accepted_issues&view=list)
   
   Measures  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png
 '') [0 Security 
Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework&pullRequest=783&resolved=false&inNewCodePeriod=true)
  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/no-data-16px.png
 '') No data about Coverage  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png
 '') [0.0% Duplication on New 
Code](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework&pullRequest=783&metric=new_duplicated_lines_density&view=list)
  
 
   [See analysis details on 
SonarCloud](https://sonarcloud.io/dashboard?id=apache_ofbiz-framework&pullRequest=783)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@ofbiz.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[PR] Improved: Facility-Main page (OFBIZ-13051) [ofbiz-framework]

2024-04-24 Thread via GitHub


PierreSmits opened a new pull request, #783:
URL: https://github.com/apache/ofbiz-framework/pull/783

   Currently the 'main' view-map points to the 'FindFacility' screen. In order 
to improve the user experience the main request-map and view-map should show 
what is most pressing in warehousing to address: incoming and outgoing 
shipments to process.
   
   modfified:
   - controller.xml: changed view-map 'main' to point to screen Main in 
CommonScreens.xml
   - CommonScreens.xml: adding screen Main displaying a PortalPage
   - ProductPortletData.xml: adding PortalPage facility_MAIN, portlets for 
incoming and outgoing shipments, etc
   - ShipmentScreens.xml: adding screens ShipmentIn and ShipmentOut for 
shipments to process
   - ShipmentForms.xml: adding grids ShipmentIn and ShipmentOut to list 
shipments to process


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@ofbiz.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Updated] (OFBIZ-13051) Facility-Main page

2024-04-24 Thread Pierre Smits (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-13051?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pierre Smits updated OFBIZ-13051:
-
Component/s: product/facility

> Facility-Main page
> --
>
> Key: OFBIZ-13051
> URL: https://issues.apache.org/jira/browse/OFBIZ-13051
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: product/facility
>Reporter: Pierre Smits
>Priority: Major
>
> Currently the 'main' view-map points to the 'FindFacility' screen.
> In order to improve the user experience the main request-map and view-map 
> should show what is most pressing in warehousing to address: incoming and 
> outgoing shipments to process.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Updated] (OFBIZ-13051) Facility-Main page

2024-04-24 Thread Pierre Smits (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-13051?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pierre Smits updated OFBIZ-13051:
-
Description: 
Currently the 'main' view-map points to the 'FindFacility' screen.

In order to improve the user experience the main request-map and view-map 
should show what is most pressing in warehousing to address: incoming and 
outgoing shipments to process.

  was:Currently the main request-map point main page shows the OrgTree screen 
in a hard-coded way for about 50% of the available screen.


> Facility-Main page
> --
>
> Key: OFBIZ-13051
> URL: https://issues.apache.org/jira/browse/OFBIZ-13051
> Project: OFBiz
>  Issue Type: Sub-task
>Reporter: Pierre Smits
>Priority: Major
>
> Currently the 'main' view-map points to the 'FindFacility' screen.
> In order to improve the user experience the main request-map and view-map 
> should show what is most pressing in warehousing to address: incoming and 
> outgoing shipments to process.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Updated] (OFBIZ-13051) Facility-Main page

2024-04-24 Thread Pierre Smits (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-13051?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pierre Smits updated OFBIZ-13051:
-
Description: Currently the main request-map point main page shows the 
OrgTree screen in a hard-coded way for about 50% of the available screen.

> Facility-Main page
> --
>
> Key: OFBIZ-13051
> URL: https://issues.apache.org/jira/browse/OFBIZ-13051
> Project: OFBiz
>  Issue Type: Sub-task
>Reporter: Pierre Smits
>Priority: Major
>
> Currently the main request-map point main page shows the OrgTree screen in a 
> hard-coded way for about 50% of the available screen.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (OFBIZ-13049) Configurable Main page

2024-04-24 Thread Jacques Le Roux (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-13049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17840340#comment-17840340
 ] 

Jacques Le Roux commented on OFBIZ-13049:
-

Hi,

IMO, as long as we don't get too far with portlets I think it's OK. This was 
discussed in this thread by Nereides people who had a deep experience with: 
https://lists.apache.org/thread/wk0q5m409mm96kqsgymq6fhrsy7j7xvo

I remember [~nmalin] being almost angry up with the experience they underwent. 
He may say a word about it :)

> Configurable Main page
> --
>
> Key: OFBIZ-13049
> URL: https://issues.apache.org/jira/browse/OFBIZ-13049
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL APPLICATIONS
>Reporter: Pierre Smits
>Priority: Major
>
> Currently the OFBiz product has configurable Main pages in applications 
> Accounting, Order, SFA, and plugin MyPortal. Unfortunately, none in the 
> community felt the urge to implement the concept further in other 
> applications.
> Having a configurable Main page of an application improves both the appeal of 
> OFBiz to (potential) adopters and their users, and to developers.
> With a configurable Main page, developers have less screens to consider when 
> doing customisation, while at the same time trying to stay in sync with 
> changes from the project.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Created] (OFBIZ-13065) userLogin null or missing in customer/ViewProfile.ftl

2024-04-24 Thread Jacques Le Roux (Jira)
Jacques Le Roux created OFBIZ-13065:
---

 Summary: userLogin  null or missing in customer/ViewProfile.ftl
 Key: OFBIZ-13065
 URL: https://issues.apache.org/jira/browse/OFBIZ-13065
 Project: OFBiz
  Issue Type: Bug
Reporter: Jacques Le Roux


The complete error is

freemarker.core.InvalidReferenceException: The following has evaluated to null 
or missing:
==> userLogin  [in template 
"component://ecommerce/template/customer/ViewProfile.ftl" at line 637, column 
57]

A rare case I guess (party does not exist too)





--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (OFBIZ-13035) Fix cross-app menu location issues

2024-04-24 Thread Jacques Le Roux (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-13035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17840333#comment-17840333
 ] 

Jacques Le Roux commented on OFBIZ-13035:
-

Actually I reported the same or similar 2 days ago. I'll have a look...

> Fix cross-app menu location issues
> --
>
> Key: OFBIZ-13035
> URL: https://issues.apache.org/jira/browse/OFBIZ-13035
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: ALL APPLICATIONS
>Affects Versions: Upcoming Branch
>Reporter: Pierre Smits
>Priority: Major
> Fix For: Upcoming Branch
>
>
> address cross application menu-location issues.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (OFBIZ-13065) userLogin null or missing in customer/ViewProfile.ftl

2024-04-24 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-13065?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17840337#comment-17840337
 ] 

ASF subversion and git services commented on OFBIZ-13065:
-

Commit 5eea336a62fa302aab3765bd756d0ee896230171 in ofbiz-plugins's branch 
refs/heads/trunk from Jacques Le Roux
[ https://gitbox.apache.org/repos/asf?p=ofbiz-plugins.git;h=5eea336a6 ]

Fixed: userLogin  null or missing in customer/ViewProfile.ftl (OFBIZ-13065)

This was found trunk demo error.log. A rare case I guess (party does not exist 
too)

I also globally indented the code from start to make it more legible.
It makes the commit a bit hard to read. That's only once...


> userLogin  null or missing in customer/ViewProfile.ftl
> --
>
> Key: OFBIZ-13065
> URL: https://issues.apache.org/jira/browse/OFBIZ-13065
> Project: OFBiz
>  Issue Type: Bug
>Reporter: Jacques Le Roux
>Priority: Minor
>
> The complete error is
> freemarker.core.InvalidReferenceException: The following has evaluated to 
> null or missing:
> ==> userLogin  [in template 
> "component://ecommerce/template/customer/ViewProfile.ftl" at line 637, column 
> 57]
> A rare case I guess (party does not exist too)



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (OFBIZ-13035) Fix cross-app menu location issues

2024-04-24 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-13035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17840330#comment-17840330
 ] 

ASF subversion and git services commented on OFBIZ-13035:
-

Commit b376ddfb7ca1702f20b665737aa084ae278d60a6 in ofbiz-plugins's branch 
refs/heads/trunk from Jacques Le Roux
[ https://gitbox.apache.org/repos/asf?p=ofbiz-plugins.git;h=b376ddfb7 ]

Fixed: Fix cross-app menu location issues (OFBIZ-13035)

Fixes
Error rendering included menu named [ExampleAppBar] at location
[component://exampleext/widget/example/ExampleMenus.xml]:
java.lang.IllegalArgumentException: Could not find menu with name 
[ExampleAppBar]
 in location [component://exampleext/widget/example/ExampleMenus.xml]


> Fix cross-app menu location issues
> --
>
> Key: OFBIZ-13035
> URL: https://issues.apache.org/jira/browse/OFBIZ-13035
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: ALL APPLICATIONS
>Affects Versions: Upcoming Branch
>Reporter: Pierre Smits
>Priority: Major
> Fix For: Upcoming Branch
>
>
> address cross application menu-location issues.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)