[jira] [Commented] (OFBIZ-13092) [SECURITY] (CVE-2024-36104) Path traversal leading to RCE
[ https://issues.apache.org/jira/browse/OFBIZ-13092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17851533#comment-17851533 ] ASF subversion and git services commented on OFBIZ-13092: - Commit 997ae230701670320349a703ce9df301e64ee6ea in ofbiz-site's branch refs/heads/master from Jacques Le Roux [ https://gitbox.apache.org/repos/asf?p=ofbiz-site.git;h=997ae23 ] [SECURITY] (CVE-2024-36104) Path traversal leading to RCE (OFBIZ-13092) Also removes remaining commented out social networks information > [SECURITY] (CVE-2024-36104) Path traversal leading to RCE > - > > Key: OFBIZ-13092 > URL: https://issues.apache.org/jira/browse/OFBIZ-13092 > Project: OFBiz > Issue Type: Sub-task > Components: framework/webapp >Affects Versions: 18.12.14 >Reporter: Jacques Le Roux >Assignee: Jacques Le Roux >Priority: Major > Fix For: 18.12.14 > > > Better avoid special encoded characters sequences -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OFBIZ-13113) Upgrade to 2.3.33 FreeMarker release
[ https://issues.apache.org/jira/browse/OFBIZ-13113?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17851528#comment-17851528 ] ASF subversion and git services commented on OFBIZ-13113: - Commit 7b8f14978105c6d48f2735eb551b3ebb5ba663c4 in ofbiz-framework's branch refs/heads/trunk from Jacques Le Roux [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=7b8f149781 ] Implemented: Upgrade to 2.3.33 FreeMarker release (OFBIZ-13113) This follows OFBIZ-12935 after https://lists.apache.org/thread/bx41zsbyc8prccol8fkgpkqhsd3293so > Upgrade to 2.3.33 FreeMarker release > > > Key: OFBIZ-13113 > URL: https://issues.apache.org/jira/browse/OFBIZ-13113 > Project: OFBiz > Issue Type: Improvement > Components: ALL COMPONENTS >Affects Versions: Upcoming Branch >Reporter: Jacques Le Roux >Assignee: Jacques Le Roux >Priority: Major > Fix For: Upcoming Branch > > > This follows OFBIZ-12935 after > https://lists.apache.org/thread/bx41zsbyc8prccol8fkgpkqhsd3293so -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OFBIZ-12935) Test 2.3.33 FreeMarker release
[ https://issues.apache.org/jira/browse/OFBIZ-12935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17851529#comment-17851529 ] ASF subversion and git services commented on OFBIZ-12935: - Commit 7b8f14978105c6d48f2735eb551b3ebb5ba663c4 in ofbiz-framework's branch refs/heads/trunk from Jacques Le Roux [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=7b8f149781 ] Implemented: Upgrade to 2.3.33 FreeMarker release (OFBIZ-13113) This follows OFBIZ-12935 after https://lists.apache.org/thread/bx41zsbyc8prccol8fkgpkqhsd3293so > Test 2.3.33 FreeMarker release > --- > > Key: OFBIZ-12935 > URL: https://issues.apache.org/jira/browse/OFBIZ-12935 > Project: OFBiz > Issue Type: Sub-task > Components: Freemarker >Affects Versions: Upcoming Branch >Reporter: Jacques Le Roux >Assignee: Jacques Le Roux >Priority: Minor > Fix For: Upcoming Branch > > Attachments: OFBIZ-12935-StringModel.patch, OFBIZ-12935.patch, > OFBIZ-12935.txt > > > It's intended to test the 2.3.33 FreeMarker releases [as requested by the > FreeMarker > team|https://lists.apache.org/thread/t4c9z7wkcp3dbdokmnjd32fcptq8h9tz] > I attach a patch based on the test requested above: [^OFBIZ-12935.patch] -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OFBIZ-13068) Accounts Payable Past Due Invoices doesn't show outstanding amount
[ https://issues.apache.org/jira/browse/OFBIZ-13068?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17850721#comment-17850721 ] ASF subversion and git services commented on OFBIZ-13068: - Commit a7afe3ccbd2ce69253fcacca0d8a34c1ec14b4bf in ofbiz-framework's branch refs/heads/trunk from Jacques Le Roux [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=a7afe3ccbd ] Fixed: PartyFinancialHistory shows parentTypeId of invoice, not invoiceTypeId (OFBIZ-13068) Thanks to Deepak's review (much appreciated see https://lists.apache.org/thread/94xw3rpdr0o44n6sd2s7m250joy4c7q6) this improves previous commit (6718c46) This also removes few trailing blanks (Eclipse automation) > Accounts Payable Past Due Invoices doesn't show outstanding amount > -- > > Key: OFBIZ-13068 > URL: https://issues.apache.org/jira/browse/OFBIZ-13068 > Project: OFBiz > Issue Type: Bug > Components: accounting >Affects Versions: Upcoming Branch >Reporter: Pierre Smits >Assignee: Jacques Le Roux >Priority: Trivial > Fix For: Upcoming Branch > > Attachments: Image 016.png, Screenshot 2024-04-29 at 11.52.07.png, > image-2024-04-29-09-05-28-760.png > > > With recent changes via commit ec0adc02f102d75be15e1ee04062b75621219f0d > [ec0adc02f1] the field outstanding got replaced with amountToApply in grid > ListApReport. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OFBIZ-13068) Accounts Payable Past Due Invoices doesn't show outstanding amount
[ https://issues.apache.org/jira/browse/OFBIZ-13068?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17850659#comment-17850659 ] ASF subversion and git services commented on OFBIZ-13068: - Commit 6718c4645dba7195317de3084cf2a24116f7dfdc in ofbiz-framework's branch refs/heads/trunk from Jacques Le Roux [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=6718c4645d ] Fixed: PartyFinancialHistory shows parentTypeId of invoice, not invoiceTypeId (OFBIZ-13068) This fixes an old bug (at least 8 years) > Accounts Payable Past Due Invoices doesn't show outstanding amount > -- > > Key: OFBIZ-13068 > URL: https://issues.apache.org/jira/browse/OFBIZ-13068 > Project: OFBiz > Issue Type: Bug > Components: accounting >Affects Versions: Upcoming Branch >Reporter: Pierre Smits >Assignee: Jacques Le Roux >Priority: Trivial > Fix For: Upcoming Branch > > Attachments: Image 016.png, Screenshot 2024-04-29 at 11.52.07.png, > image-2024-04-29-09-05-28-760.png > > > With recent changes via commit ec0adc02f102d75be15e1ee04062b75621219f0d > [ec0adc02f1] the field outstanding got replaced with amountToApply in grid > ListApReport. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OFBIZ-13100) LInk to supplier in Accounting Main does not show PartyFinancialHistory
[ https://issues.apache.org/jira/browse/OFBIZ-13100?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17850650#comment-17850650 ] ASF subversion and git services commented on OFBIZ-13100: - Commit 68062ae6d30ff9e55ec867f3ff3400c307811d9f in ofbiz-framework's branch refs/heads/trunk from Jacques Le Roux [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=68062ae6d3 ] Fixed: Link to supplier in Accounting Main does not show PartyFinancialHistory (OFBIZ-13100) Fixes a missing from-field in a hyperlink > LInk to supplier in Accounting Main does not show PartyFinancialHistory > --- > > Key: OFBIZ-13100 > URL: https://issues.apache.org/jira/browse/OFBIZ-13100 > Project: OFBiz > Issue Type: Bug >Reporter: Pierre Smits >Priority: Major > > When accessing the link to the PartyFinancialHistory screen of the supplier > in > [https://demo-trunk.ofbiz.apache.org/accounting/control/main|https://demo-trunk.ofbiz.apache.org/accounting/control/main,] > the resulting PartyFinancialHistory in partymgr shows no data. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OFBIZ-12984) CreateFacilityLocation throws an error
[
https://issues.apache.org/jira/browse/OFBIZ-12984?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17850640#comment-17850640
]
ASF subversion and git services commented on OFBIZ-12984:
-
Commit e583d221f96f16a25c971a816def92a8e4aecea9 in ofbiz-framework's branch
refs/heads/trunk from Jacques Le Roux
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=e583d221f9 ]
Fixed: CreateFacilityLocation throws an error (OFBIZ-12984)
Unlike Java Groovy does not support multi-lines with "+" ad head. You need to
put it at end of previous line
> CreateFacilityLocation throws an error
> --
>
> Key: OFBIZ-12984
> URL: https://issues.apache.org/jira/browse/OFBIZ-12984
> Project: OFBiz
> Issue Type: Bug
> Components: product/facility
>Reporter: Pierre Smits
>Priority: Major
> Attachments: Screenshot 2024-04-01 at 12.27.37.png, Screenshot
> 2024-04-01 at 12.27.50.png
>
>
> Creating a new facility location throws following error:
> {code:java}The Following Errors Occurred:
> Error calling event: org.apache.ofbiz.webapp.event.EventHandlerException:
> Service invocation error (groovy.lang.MissingMethodException: No signature of
> method: java.lang.String.positive() is applicable for argument types: ()
> values: []Possible solutions: notify(), tokenize(), size())
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (OFBIZ-13107) MainActionMenu not shown on findreturn screen
[ https://issues.apache.org/jira/browse/OFBIZ-13107?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17850263#comment-17850263 ] ASF subversion and git services commented on OFBIZ-13107: - Commit 8184dc3902a7c1f01a39526094b1dcf94daf5198 in ofbiz-framework's branch refs/heads/trunk from Pierre Smits [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=8184dc3902 ] Fixed: MainActionMenu not shown on findreturn screen (OFBIZ-13107) (#810) The MainActionMenu of the order component is shown on various screens, but not on the findreturn screen. modified: OrderReturnScreens,xml - added pre-body decorator section having MainActionMenu to screen CommonOrderReturnDecorator and screen OrderFindReturn > MainActionMenu not shown on findreturn screen > - > > Key: OFBIZ-13107 > URL: https://issues.apache.org/jira/browse/OFBIZ-13107 > Project: OFBiz > Issue Type: Bug > Components: order >Reporter: Pierre Smits >Priority: Major > > The MainActionMenu of the order component is shown on various screens, but > not on the findreturn screen. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OFBIZ-13099) PartyFinancialHistory throws a warning
[
https://issues.apache.org/jira/browse/OFBIZ-13099?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17849385#comment-17849385
]
ASF subversion and git services commented on OFBIZ-13099:
-
Commit 6b57e35dbc25d32fdaff8b956fe8eb22a3ed5bf7 in ofbiz-framework's branch
refs/heads/trunk from Jacques Le Roux
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=6b57e35dbc ]
fixed: PartyFinancialHistory throws an error (OFBIZ-13099)
This is a rewrite for different reasons.
The queryIterators were called twice, for instance
while (invIterator.next()) {
invoice = nvIterator.next()
They are now called only once, else an instance would be lost
while (invoice = invIterator.next()) {
The expression above raises the CodeNarc rule AssignmentInConditional
So I had to locally bypass it using comments
I have added a warning in EntityListIterator::hasNext about that.
Also the queryIterators must be closed as documented in
EntityQuery::queryIterator:
NOTE: THAT THIS MUST BE CLOSED (preferably in a finally block) WHEN YOU ARE DONE
WITH IT, AND DON'T LEAVE IT OPEN TOO LONG BEACUSE IT WILL MAINTAIN A DATABASE
CONNECTION.
It could be possible to implements AutoCloseable in the call stack but not
evident... EntityListIterator implements it...
> PartyFinancialHistory throws a warning
> --
>
> Key: OFBIZ-13099
> URL: https://issues.apache.org/jira/browse/OFBIZ-13099
> Project: OFBiz
> Issue Type: Improvement
> Components: party
>Affects Versions: Upcoming Branch
>Reporter: Pierre Smits
>Assignee: Jacques Le Roux
>Priority: Minor
> Fix For: Upcoming Branch
>
>
> When accessing the financial history screen in the partymgr application (e.g.
> via
> [https://localhost:8443/partymgr/control/PartyFinancialHistory?partyId=EuroSupplier]
> following error multiple times are thrown:
> {code:java}
> 2024-05-24 10:17:35,821 |jsse-nio-8443-exec-2 |EntityListIterator
> |W| For performance reasons do not use the EntityListIterator.hasNext()
> method, just call next() until it returns null; see JavaDoc comments in the
> EntityListIterator class for details and an example
> java.lang.Exception: null
> at
> org.apache.ofbiz.entity.util.EntityListIterator.hasNext(EntityListIterator.java:283)
> [main/:?]
> at java_util_ListIterator$hasNext.call(Unknown Source) [?:?]
> at
> org.codehaus.groovy.runtime.callsite.CallSiteArray.defaultCall(CallSiteArray.java:47)
> [groovy-3.0.21.jar:3.0.21]
> at
> org.codehaus.groovy.runtime.callsite.AbstractCallSite.call(AbstractCallSite.java:125)
> [groovy-3.0.21.jar:3.0.21]
> at
> org.codehaus.groovy.runtime.callsite.AbstractCallSite.call(AbstractCallSite.java:130)
> [groovy-3.0.21.jar:3.0.21]
> at
> org.apache.ofbiz.party.party.UnAppliedInvoicesForParty.run(UnAppliedInvoicesForParty.groovy:49)
> [script:?]
> at
> org.apache.ofbiz.base.util.GroovyUtil.runScriptAtLocation(GroovyUtil.java:213)
> [main/:?]
> at
> org.apache.ofbiz.base.util.ScriptUtil.executeScript(ScriptUtil.java:312)
> [main/:?]
> at
> org.apache.ofbiz.base.util.ScriptUtil.executeScript(ScriptUtil.java:295)
> [main/:?]
> at
> org.apache.ofbiz.widget.model.AbstractModelAction$Script.runAction(AbstractModelAction.java:716)
> [main/:?]
> at
> org.apache.ofbiz.widget.model.AbstractModelAction.runSubActions(AbstractModelAction.java:138)
> [main/:?]
> at
> org.apache.ofbiz.widget.model.ModelForm.runFormActions(ModelForm.java:1816)
> [main/:?]
> at
> org.apache.ofbiz.widget.renderer.FormRenderer.render(FormRenderer.java:265)
> [main/:?]
> at
> org.apache.ofbiz.widget.model.ModelScreenWidget$Grid.renderWidgetString(ModelScreenWidget.java:1188)
> [main/:?]
> at
> org.apache.ofbiz.widget.renderer.macro.MacroScreenRenderer.renderScreenletSubWidget(MacroScreenRenderer.java:736)
> [main/:?]
> at
> org.apache.ofbiz.widget.model.ModelScreenWidget$Screenlet.renderWidgetString(ModelScreenWidget.java:631)
> [main/:?]
> at
> org.apache.ofbiz.widget.model.ModelScreenWidget.renderSubWidgetsString(ModelScreenWidget.java:109)
> [main/:?]
> at
> org.apache.ofbiz.widget.model.ModelScreenWidget$Section.renderWidgetString(ModelScreenWidget.java:297)
> [main/:?]
> at
> org.apache.ofbiz.widget.model.ModelScreenWidget.renderSubWidgetsString(ModelScreenWidget.java:109)
> [main/:?]
> at
> org.apache.ofbiz.widget.model.ModelScreenWidget$DecoratorSection.renderWidgetString(ModelScreenWidget.java:947)
> [main/:?]
> at
> org.apache.ofbiz.widget.model.ModelScreenWidget$SectionsRenderer.render(ModelScreenWidget.java:142)
> [main/:?]
> at
>
[jira] [Commented] (OFBIZ-13099) PartyFinancialHistory throws an error
[
https://issues.apache.org/jira/browse/OFBIZ-13099?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17849339#comment-17849339
]
ASF subversion and git services commented on OFBIZ-13099:
-
Commit f6e6eb602d6dad04a6f12b36073aa7f86d30449d in ofbiz-framework's branch
refs/heads/trunk from Jacques Le Roux
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=f6e6eb602d ]
Fixed: Replace deprecated BigDecimal.ROUND_HALF by RoundingMode.HALF
(OFBIZ-13103)
RoundingMode.HALF_UP is not returning an int.
This, at least, prevents integration tests to pass. Maybe more due to
OFBIZ-13099 that need to be fixed anyway.
> PartyFinancialHistory throws an error
> -
>
> Key: OFBIZ-13099
> URL: https://issues.apache.org/jira/browse/OFBIZ-13099
> Project: OFBiz
> Issue Type: Improvement
> Components: party
>Affects Versions: Upcoming Branch
>Reporter: Pierre Smits
>Assignee: Jacques Le Roux
>Priority: Minor
> Fix For: Upcoming Branch
>
>
> When accessing the financial history screen in the partymgr application (e.g.
> via
> [https://localhost:8443/partymgr/control/PartyFinancialHistory?partyId=EuroSupplier]
> following error multiple times are thrown:
> {code:java}
> 2024-05-24 10:17:35,821 |jsse-nio-8443-exec-2 |EntityListIterator
> |W| For performance reasons do not use the EntityListIterator.hasNext()
> method, just call next() until it returns null; see JavaDoc comments in the
> EntityListIterator class for details and an example
> java.lang.Exception: null
> at
> org.apache.ofbiz.entity.util.EntityListIterator.hasNext(EntityListIterator.java:283)
> [main/:?]
> at java_util_ListIterator$hasNext.call(Unknown Source) [?:?]
> at
> org.codehaus.groovy.runtime.callsite.CallSiteArray.defaultCall(CallSiteArray.java:47)
> [groovy-3.0.21.jar:3.0.21]
> at
> org.codehaus.groovy.runtime.callsite.AbstractCallSite.call(AbstractCallSite.java:125)
> [groovy-3.0.21.jar:3.0.21]
> at
> org.codehaus.groovy.runtime.callsite.AbstractCallSite.call(AbstractCallSite.java:130)
> [groovy-3.0.21.jar:3.0.21]
> at
> org.apache.ofbiz.party.party.UnAppliedInvoicesForParty.run(UnAppliedInvoicesForParty.groovy:49)
> [script:?]
> at
> org.apache.ofbiz.base.util.GroovyUtil.runScriptAtLocation(GroovyUtil.java:213)
> [main/:?]
> at
> org.apache.ofbiz.base.util.ScriptUtil.executeScript(ScriptUtil.java:312)
> [main/:?]
> at
> org.apache.ofbiz.base.util.ScriptUtil.executeScript(ScriptUtil.java:295)
> [main/:?]
> at
> org.apache.ofbiz.widget.model.AbstractModelAction$Script.runAction(AbstractModelAction.java:716)
> [main/:?]
> at
> org.apache.ofbiz.widget.model.AbstractModelAction.runSubActions(AbstractModelAction.java:138)
> [main/:?]
> at
> org.apache.ofbiz.widget.model.ModelForm.runFormActions(ModelForm.java:1816)
> [main/:?]
> at
> org.apache.ofbiz.widget.renderer.FormRenderer.render(FormRenderer.java:265)
> [main/:?]
> at
> org.apache.ofbiz.widget.model.ModelScreenWidget$Grid.renderWidgetString(ModelScreenWidget.java:1188)
> [main/:?]
> at
> org.apache.ofbiz.widget.renderer.macro.MacroScreenRenderer.renderScreenletSubWidget(MacroScreenRenderer.java:736)
> [main/:?]
> at
> org.apache.ofbiz.widget.model.ModelScreenWidget$Screenlet.renderWidgetString(ModelScreenWidget.java:631)
> [main/:?]
> at
> org.apache.ofbiz.widget.model.ModelScreenWidget.renderSubWidgetsString(ModelScreenWidget.java:109)
> [main/:?]
> at
> org.apache.ofbiz.widget.model.ModelScreenWidget$Section.renderWidgetString(ModelScreenWidget.java:297)
> [main/:?]
> at
> org.apache.ofbiz.widget.model.ModelScreenWidget.renderSubWidgetsString(ModelScreenWidget.java:109)
> [main/:?]
> at
> org.apache.ofbiz.widget.model.ModelScreenWidget$DecoratorSection.renderWidgetString(ModelScreenWidget.java:947)
> [main/:?]
> at
> org.apache.ofbiz.widget.model.ModelScreenWidget$SectionsRenderer.render(ModelScreenWidget.java:142)
> [main/:?]
> at
> org.apache.ofbiz.widget.model.ModelScreenWidget$DecoratorSectionInclude.renderWidgetString(ModelScreenWidget.java:986)
> [main/:?]
> at
> org.apache.ofbiz.widget.model.ModelScreenWidget.renderSubWidgetsString(ModelScreenWidget.java:109)
> [main/:?]
> at
> org.apache.ofbiz.widget.model.ModelScreenWidget$Section.renderWidgetString(ModelScreenWidget.java:297)
> [main/:?]
> at
> org.apache.ofbiz.widget.model.ModelScreenWidget.renderSubWidgetsString(ModelScreenWidget.java:109)
> [main/:?]
> at
> org.apache.ofbiz.widget.model.ModelScreenWidget$DecoratorSection.renderWidgetString(ModelScreenWidget.java:947)
> [main/:?]
> at
>
[jira] [Commented] (OFBIZ-13101) Duplicate action trigger in Manufacturing
[ https://issues.apache.org/jira/browse/OFBIZ-13101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17849326#comment-17849326 ] ASF subversion and git services commented on OFBIZ-13101: - Commit 0fc9a06435aa6f5d8d8aad806315295d63055b9f in ofbiz-framework's branch refs/heads/trunk from Pierre Smits [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=0fc9a06435 ] improved: Duplicate action trigger in Manufacturing (OFBIZ-13101) (#806) On the 'FndProductionRun' an action trigger to create something is shown. This links to CreateProductionRun. This action trigger is already available via the MainActionMenu. Removing this duplicate also improves the experience for users with only VIEW permissions, like auditor in the demo site. modified: JopshopScreens.xml - removed decorator-section having action trigger > Duplicate action trigger in Manufacturing > - > > Key: OFBIZ-13101 > URL: https://issues.apache.org/jira/browse/OFBIZ-13101 > Project: OFBiz > Issue Type: Improvement > Components: manufacturing >Reporter: Pierre Smits >Assignee: Jacques Le Roux >Priority: Major > > On the 'FndProductionRun' an action trigger to create something is shown. > This links to CreateProductionRun. This action trigger is already available > via the MainActionMenu. > Removing this duplicate also improves the experience for users with only VIEW > permissions, like auditor in the demo site. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OFBIZ-13099) PartyFinancialHistory throws an error
[
https://issues.apache.org/jira/browse/OFBIZ-13099?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17849274#comment-17849274
]
ASF subversion and git services commented on OFBIZ-13099:
-
Commit bc384fd978a36a51bad71a63135165f40f3676b3 in ofbiz-framework's branch
refs/heads/trunk from Pierre Smits
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=bc384fd978 ]
fixed: PartyFinancialHistory throws an error (OFBIZ-13099) (#804)
* fixed: PartyFinancialHistory throws an error (OFBIZ-13099)
When accessing the financial history screen in the partymgr application (e.g.
via
https://localhost:8443/partymgr/control/PartyFinancialHistory?partyId=EuroSupplier),
following error multiple times are thrown:
modified:
- replaced .hasNext() in PartyFinancialHistory.groovy,
UnAppliedInvoicesForParty.groovy, UnAppliedPaymentsForParty.groovy
* cleanup
* fixed: PartyFinancialHistory throws an error (OFBIZ-13099)
fixed while issue
* fixed: PartyFinancialHistory throws an error (OFBIZ-13099)
removed iterator .close()
* Update UnAppliedInvoicesForParty.groovy
Fixes:
C:\projectsASF\Git\ofbiz-framework>git apply 804.patch
804.patch:69: trailing whitespace.
warning: 1 line adds whitespace errors.
-
Co-authored-by: Jacques Le Roux
> PartyFinancialHistory throws an error
> -
>
> Key: OFBIZ-13099
> URL: https://issues.apache.org/jira/browse/OFBIZ-13099
> Project: OFBiz
> Issue Type: Improvement
> Components: party
>Affects Versions: Upcoming Branch
>Reporter: Pierre Smits
>Priority: Minor
>
> When accessing the financial history screen in the partymgr application (e.g.
> via
> [https://localhost:8443/partymgr/control/PartyFinancialHistory?partyId=EuroSupplier]
> following error multiple times are thrown:
> {code:java}
> 2024-05-24 10:17:35,821 |jsse-nio-8443-exec-2 |EntityListIterator
> |W| For performance reasons do not use the EntityListIterator.hasNext()
> method, just call next() until it returns null; see JavaDoc comments in the
> EntityListIterator class for details and an example
> java.lang.Exception: null
> at
> org.apache.ofbiz.entity.util.EntityListIterator.hasNext(EntityListIterator.java:283)
> [main/:?]
> at java_util_ListIterator$hasNext.call(Unknown Source) [?:?]
> at
> org.codehaus.groovy.runtime.callsite.CallSiteArray.defaultCall(CallSiteArray.java:47)
> [groovy-3.0.21.jar:3.0.21]
> at
> org.codehaus.groovy.runtime.callsite.AbstractCallSite.call(AbstractCallSite.java:125)
> [groovy-3.0.21.jar:3.0.21]
> at
> org.codehaus.groovy.runtime.callsite.AbstractCallSite.call(AbstractCallSite.java:130)
> [groovy-3.0.21.jar:3.0.21]
> at
> org.apache.ofbiz.party.party.UnAppliedInvoicesForParty.run(UnAppliedInvoicesForParty.groovy:49)
> [script:?]
> at
> org.apache.ofbiz.base.util.GroovyUtil.runScriptAtLocation(GroovyUtil.java:213)
> [main/:?]
> at
> org.apache.ofbiz.base.util.ScriptUtil.executeScript(ScriptUtil.java:312)
> [main/:?]
> at
> org.apache.ofbiz.base.util.ScriptUtil.executeScript(ScriptUtil.java:295)
> [main/:?]
> at
> org.apache.ofbiz.widget.model.AbstractModelAction$Script.runAction(AbstractModelAction.java:716)
> [main/:?]
> at
> org.apache.ofbiz.widget.model.AbstractModelAction.runSubActions(AbstractModelAction.java:138)
> [main/:?]
> at
> org.apache.ofbiz.widget.model.ModelForm.runFormActions(ModelForm.java:1816)
> [main/:?]
> at
> org.apache.ofbiz.widget.renderer.FormRenderer.render(FormRenderer.java:265)
> [main/:?]
> at
> org.apache.ofbiz.widget.model.ModelScreenWidget$Grid.renderWidgetString(ModelScreenWidget.java:1188)
> [main/:?]
> at
> org.apache.ofbiz.widget.renderer.macro.MacroScreenRenderer.renderScreenletSubWidget(MacroScreenRenderer.java:736)
> [main/:?]
> at
> org.apache.ofbiz.widget.model.ModelScreenWidget$Screenlet.renderWidgetString(ModelScreenWidget.java:631)
> [main/:?]
> at
> org.apache.ofbiz.widget.model.ModelScreenWidget.renderSubWidgetsString(ModelScreenWidget.java:109)
> [main/:?]
> at
> org.apache.ofbiz.widget.model.ModelScreenWidget$Section.renderWidgetString(ModelScreenWidget.java:297)
> [main/:?]
> at
> org.apache.ofbiz.widget.model.ModelScreenWidget.renderSubWidgetsString(ModelScreenWidget.java:109)
> [main/:?]
> at
> org.apache.ofbiz.widget.model.ModelScreenWidget$DecoratorSection.renderWidgetString(ModelScreenWidget.java:947)
> [main/:?]
> at
> org.apache.ofbiz.widget.model.ModelScreenWidget$SectionsRenderer.render(ModelScreenWidget.java:142)
> [main/:?]
> at
> org.apache.ofbiz.widget.model.ModelScreenWidget$DecoratorSectionInclude.renderWidgetString(ModelScreenWidget.java:986)
> [main/:?]
> at
>
[jira] [Commented] (OFBIZ-13092) Prevent special encoded characters sequences in URLs
[ https://issues.apache.org/jira/browse/OFBIZ-13092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17849204#comment-17849204 ] ASF subversion and git services commented on OFBIZ-13092: - Commit 474e806816e4a1d0c16667972e5044ce2ded9d13 in ofbiz-framework's branch refs/heads/release18.12 from Jacques Le Roux [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=474e806816 ] Improved: Prevent special encoded characters sequences in URLs (OFBIZ-13092) Removes now redundant calls to URI::normalize in ControlFilter and LoginWorker classes Also removes few trailing blanks when needed (automatically done by Eclipse) > Prevent special encoded characters sequences in URLs > > > Key: OFBIZ-13092 > URL: https://issues.apache.org/jira/browse/OFBIZ-13092 > Project: OFBiz > Issue Type: Sub-task > Components: framework/webapp >Affects Versions: 18.12.14 >Reporter: Jacques Le Roux >Assignee: Jacques Le Roux >Priority: Major > Fix For: 18.12.14 > > > Better avoid special encoded characters sequences -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OFBIZ-12691) Extend HTML Sanitizer - style attribute
[ https://issues.apache.org/jira/browse/OFBIZ-12691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17849198#comment-17849198 ] ASF subversion and git services commented on OFBIZ-12691: - Commit 98febce8c3594d0f8bb5e1fc7a6c09dadffd113d in ofbiz-framework's branch refs/heads/trunk from Jacques Le Roux [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=98febce8c3 ] Improved: Extend HTML Sanitizer - style attribute (OFBIZ-12691) Like we allowed ' and \ this allows @ to be used in email addresses. There is no risk with that. If someone try to add something risky beside like it will be rejected anyway > Extend HTML Sanitizer - style attribute > --- > > Key: OFBIZ-12691 > URL: https://issues.apache.org/jira/browse/OFBIZ-12691 > Project: OFBiz > Issue Type: Bug > Components: content >Affects Versions: Upcoming Branch >Reporter: Ingo Wolfmayr >Assignee: Jacques Le Roux >Priority: Major > Fix For: 22.01.01 > > Attachments: SanitizerStyle.patch > > > Right now it is not possible to assign inline style to html content. > Trumbowyg Editor uses such tags for align paragraphs. > style="text-align:right" > It is necessary to remove space within the attribute and remove the trailing > semicolon in order to apply with OWASP filter rules. > Create or open content with "Long text". Goto dataresource and edit HTML. Put > in some text and use the align icons (right, center ...) to format the text. > Save. You will get a security info. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OFBIZ-12829) Improvements for ContentWorker methods and view-entities
[ https://issues.apache.org/jira/browse/OFBIZ-12829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17849106#comment-17849106 ] ASF subversion and git services commented on OFBIZ-12829: - Commit e7420fe4cf40f21e03bba3566d9b99d63a6e79a5 in ofbiz-framework's branch refs/heads/trunk from Cheng Hu Shan [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=e7420fe4cf ] Improvements for ContentWorker methods and view-entities (OFBIZ-12829) > Improvements for ContentWorker methods and view-entities > > > Key: OFBIZ-12829 > URL: https://issues.apache.org/jira/browse/OFBIZ-12829 > Project: OFBiz > Issue Type: Improvement > Components: content >Affects Versions: Upcoming Branch >Reporter: Chenghu Shan >Assignee: Michael Brohl >Priority: Minor > > Adds additional methods to ContentWorker: > * New method findAlternateLocalContents to find all alternate locale > contents instead of just one specific. > * Overloaded methods of findAlternateLocalContents and > findAlternateLocalContent to enable/disable cache use. > * These methods are no longer case sensitive when comparing localeStrings > Changes to view-entites ProductContentAndInfo and > ProductCategoryContentAndInfo: > * Both now use an outer join instead of inner join between DataResource and > Content, because there may be a Content object without a DataResource for its > locale but with alternate locale content objects associated to it. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OFBIZ-12843) Refactoring WebSiteProperties.java
[ https://issues.apache.org/jira/browse/OFBIZ-12843?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17849104#comment-17849104 ] ASF subversion and git services commented on OFBIZ-12843: - Commit a1e700b7d2d801d0c74298ca22c28c2e373281d9 in ofbiz-framework's branch refs/heads/trunk from Cheng Hu Shan [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=a1e700b7d2 ] Improved: Refactoring WebSiteProperties.java (OFBIZ-12843) > Refactoring WebSiteProperties.java > -- > > Key: OFBIZ-12843 > URL: https://issues.apache.org/jira/browse/OFBIZ-12843 > Project: OFBiz > Issue Type: Improvement > Components: framework/webapp >Reporter: Chenghu Shan >Assignee: Michael Brohl >Priority: Trivial > > Class WebSiteProperties.java contains some duplicate code and should be > refactored. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OFBIZ-12886) Apply orderItemAttributes when adding to Shoppingcart from addToCartFromOrder
[ https://issues.apache.org/jira/browse/OFBIZ-12886?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17849041#comment-17849041 ] ASF subversion and git services commented on OFBIZ-12886: - Commit da3e353e51ac270c328c1f307d4c77ed356a8c75 in ofbiz-framework's branch refs/heads/trunk from Elaheh Lolaki [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=da3e353e51 ] Fixed: Apply orderItemAttributes when adding to Shoppingcart from addToCartFromOrder. (OFBIZ-12886) > Apply orderItemAttributes when adding to Shoppingcart from addToCartFromOrder > - > > Key: OFBIZ-12886 > URL: https://issues.apache.org/jira/browse/OFBIZ-12886 > Project: OFBiz > Issue Type: Bug >Affects Versions: Upcoming Branch >Reporter: Elaheh Lolaki >Assignee: Michael Brohl >Priority: Minor > > When adding products with an attribute, these are not transferred via the > addToCartFromOrder function -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OFBIZ-12262) Execute a callback with parameters from the request
[
https://issues.apache.org/jira/browse/OFBIZ-12262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17848843#comment-17848843
]
ASF subversion and git services commented on OFBIZ-12262:
-
Commit e4bb0757a43e1194d82354b218ff2816741a420a in ofbiz-framework's branch
refs/heads/trunk from Jacques Le Roux
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=e4bb0757a4 ]
Fixed: createTimesheetForThisWeek as admin fails (OFBIZ-13098)
At least the below block of controller request-maps was removed by OFBIZ-12262
Maybe more there are a log of changes in the controller
> Execute a callback with parameters from the request
> ---
>
> Key: OFBIZ-12262
> URL: https://issues.apache.org/jira/browse/OFBIZ-12262
> Project: OFBiz
> Issue Type: Sub-task
> Components: framework/widget
>Affects Versions: Trunk
>Reporter: Nicolas Malin
>Assignee: Gil Portenseigne
>Priority: Minor
> Attachments:
> 0001-Execute-a-callback-with-parameters-from-the-request-.patch
>
>
> With the new element set-callback (OFBIZ-11812) we have the possibility to
> call a request with event and wait the success/error before continue and
> update an area.
> If the event generate a new value (createProduct, createPerson, ...) where we
> need it for update the area, we can't generate the call.
> A possible idea would be add a new parameter type when we define a callback
> to indicate that we will wait the event return to resolve the value. Like
> {code:java}
>
>
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (OFBIZ-13098) createTimesheetForThisWeek as admin fails
[ https://issues.apache.org/jira/browse/OFBIZ-13098?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17848842#comment-17848842 ] ASF subversion and git services commented on OFBIZ-13098: - Commit e4bb0757a43e1194d82354b218ff2816741a420a in ofbiz-framework's branch refs/heads/trunk from Jacques Le Roux [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=e4bb0757a4 ] Fixed: createTimesheetForThisWeek as admin fails (OFBIZ-13098) At least the below block of controller request-maps was removed by OFBIZ-12262 Maybe more there are a log of changes in the controller > createTimesheetForThisWeek as admin fails > - > > Key: OFBIZ-13098 > URL: https://issues.apache.org/jira/browse/OFBIZ-13098 > Project: OFBiz > Issue Type: Bug > Components: workeffort/workeffort >Affects Versions: Upcoming Branch >Reporter: Jacques Le Roux >Priority: Major > > It works in 18.12 > Here is the error in UI: > org.apache.ofbiz.webapp.control.RequestHandlerException: Unknown request > [createTimesheetForThisWeek]; this request does not exist or cannot be called > directly. > In log: > 2024-05-23 08:40:43,872 |jsse-nio-8443-exec-3 |ControlServlet > |E| Error in request handler: > org.apache.ofbiz.webapp.control.RequestHandlerException: Unknown request > [createTimesheetForThisWeek]; this request does not exist or cannot be called > directly. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OFBIZ-13092) Prevent special encoded characters sequences in URLs
[ https://issues.apache.org/jira/browse/OFBIZ-13092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17847799#comment-17847799 ] ASF subversion and git services commented on OFBIZ-13092: - Commit d33ce31012c97056f6e755261905e0950c96489d in ofbiz-framework's branch refs/heads/release18.12 from Jacques Le Roux [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=d33ce31012 ] Improved: Prevent special encoded characters sequences in URLs (OFBIZ-13092) Better avoid special encoded characters sequences Improves deniedWebShellTokens in security.properties > Prevent special encoded characters sequences in URLs > > > Key: OFBIZ-13092 > URL: https://issues.apache.org/jira/browse/OFBIZ-13092 > Project: OFBiz > Issue Type: Improvement > Components: framework/webapp >Affects Versions: 18.12.14 >Reporter: Jacques Le Roux >Assignee: Jacques Le Roux >Priority: Major > Fix For: 18.12.14 > > > Better avoid special encoded characters sequences -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OFBIZ-13095) The non ASCII language in UiLabels.xml are not correctly handled during plugin creation
[ https://issues.apache.org/jira/browse/OFBIZ-13095?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17847800#comment-17847800 ] ASF subversion and git services commented on OFBIZ-13095: - Commit cb8c65124bca100b109f3cd1f7008a32239f3255 in ofbiz-framework's branch refs/heads/release18.12 from Jacques Le Roux [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=cb8c65124b ] Fixed: The non ASCII language in UiLabels.xml are not correctly handled during plugin creation (OFBIZ-13095) You get this error: 2024-05-19 09:52:41,314 |jsse-nio-8443-exec-3 |UtilProperties |W| XML file for locale could not be loaded. org.xml.sax.SAXParseException: Invalid byte 3 of 3-byte UTF-8 sequence. When removing ZH labels it works. We should keep only English languages or amend the createPlugin Gradle task. In this commit I remove all non English labels and put a comment as documentation about that for developers in framework/resources/templates/UiLabels.xml > The non ASCII language in UiLabels.xml are not correctly handled during > plugin creation > --- > > Key: OFBIZ-13095 > URL: https://issues.apache.org/jira/browse/OFBIZ-13095 > Project: OFBiz > Issue Type: Sub-task > Components: Gradle >Affects Versions: 18.12.14 >Reporter: Jacques Le Roux >Assignee: Jacques Le Roux >Priority: Major > > You get this error: > 2024-05-19 09:52:41,314 |jsse-nio-8443-exec-3 |UtilProperties > |W| XML file for locale could not be loaded. > org.xml.sax.SAXParseException: Invalid byte 3 of 3-byte UTF-8 sequence. > When removing ZH labels it works. We should keep only English languages or > amend the createPlugin Gradle task. In this issue I'll remove ZH labels and > put a comment as documentation about that for developers in > framework/resources/templates/UiLabels.xml -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OFBIZ-13092) Prevent special encoded characters sequences in URLs
[ https://issues.apache.org/jira/browse/OFBIZ-13092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17847804#comment-17847804 ] ASF subversion and git services commented on OFBIZ-13092: - Commit bc856f46f87435e986f98c75460a57c182e7e5d4 in ofbiz-framework's branch refs/heads/trunk from Jacques Le Roux [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=bc856f46f8 ] Improved: Prevent special encoded characters sequences in URLs (OFBIZ-13092) Removes no longer needed check in LoginWorker class. It's now handled before by ControlFilter class. Fixes imported indentation from 18.12 in ControlFilter.java > Prevent special encoded characters sequences in URLs > > > Key: OFBIZ-13092 > URL: https://issues.apache.org/jira/browse/OFBIZ-13092 > Project: OFBiz > Issue Type: Improvement > Components: framework/webapp >Affects Versions: 18.12.14 >Reporter: Jacques Le Roux >Assignee: Jacques Le Roux >Priority: Major > Fix For: 18.12.14 > > > Better avoid special encoded characters sequences -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OFBIZ-13092) Prevent special encoded characters sequences in URLs
[ https://issues.apache.org/jira/browse/OFBIZ-13092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17847801#comment-17847801 ] ASF subversion and git services commented on OFBIZ-13092: - Commit 11986593b668661d748789154a6052ef4e1ab1c6 in ofbiz-framework's branch refs/heads/trunk from Jacques Le Roux [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=11986593b6 ] Improved: Prevent special encoded characters sequences in URLs (OFBIZ-13092) Better avoid special encoded characters sequences Improves deniedWebShellTokens in security.properties > Prevent special encoded characters sequences in URLs > > > Key: OFBIZ-13092 > URL: https://issues.apache.org/jira/browse/OFBIZ-13092 > Project: OFBiz > Issue Type: Improvement > Components: framework/webapp >Affects Versions: 18.12.14 >Reporter: Jacques Le Roux >Assignee: Jacques Le Roux >Priority: Major > Fix For: 18.12.14 > > > Better avoid special encoded characters sequences -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OFBIZ-13062) Error in PayGradeForms.xml Line: 65
[ https://issues.apache.org/jira/browse/OFBIZ-13062?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17847798#comment-17847798 ] ASF subversion and git services commented on OFBIZ-13062: - Commit e72a4a946116f0303f61d5b060bcb7ce281634b5 in ofbiz-framework's branch refs/heads/release18.12 from Jacques Le Roux [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=e72a4a9461 ] Fixed: Error in PayGradeForms.xml Line: 65 (OFBIZ-13062) Forgot to backport that > Error in PayGradeForms.xml Line: 65 > --- > > Key: OFBIZ-13062 > URL: https://issues.apache.org/jira/browse/OFBIZ-13062 > Project: OFBiz > Issue Type: Bug > Components: humanres >Affects Versions: 18.12.13 >Reporter: Jacques Le Roux >Assignee: Jacques Le Roux >Priority: Trivial > Fix For: Upcoming Branch > > > XmlFileLoader: File > file:/ofbiz/applications/humanres/widget/forms/PayGradeForms.xml process > error. Line: 65. Error message: cvc-complex-type.4: Attribute 'value-field' > must appear on element 'entity-one'. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OFBIZ-13095) The non ASCII language in UiLabels.xml are not correctly handled during plugin creation
[ https://issues.apache.org/jira/browse/OFBIZ-13095?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17847803#comment-17847803 ] ASF subversion and git services commented on OFBIZ-13095: - Commit 2d2e197b499939569d38d6979355efd85693e4ce in ofbiz-framework's branch refs/heads/trunk from Jacques Le Roux [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=2d2e197b49 ] Fixed: The non ASCII language in UiLabels.xml are not correctly handled during plugin creation (OFBIZ-13095) You get this error: 2024-05-19 09:52:41,314 |jsse-nio-8443-exec-3 |UtilProperties |W| XML file for locale could not be loaded. org.xml.sax.SAXParseException: Invalid byte 3 of 3-byte UTF-8 sequence. When removing ZH labels it works. We should keep only English languages or amend the createPlugin Gradle task. In this commit I remove all non English labels and put a comment as documentation about that for developers in framework/resources/templates/UiLabels.xml > The non ASCII language in UiLabels.xml are not correctly handled during > plugin creation > --- > > Key: OFBIZ-13095 > URL: https://issues.apache.org/jira/browse/OFBIZ-13095 > Project: OFBiz > Issue Type: Sub-task > Components: Gradle >Affects Versions: 18.12.14 >Reporter: Jacques Le Roux >Assignee: Jacques Le Roux >Priority: Major > > You get this error: > 2024-05-19 09:52:41,314 |jsse-nio-8443-exec-3 |UtilProperties > |W| XML file for locale could not be loaded. > org.xml.sax.SAXParseException: Invalid byte 3 of 3-byte UTF-8 sequence. > When removing ZH labels it works. We should keep only English languages or > amend the createPlugin Gradle task. In this issue I'll remove ZH labels and > put a comment as documentation about that for developers in > framework/resources/templates/UiLabels.xml -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OFBIZ-13092) Prevent special encoded characters sequences in URLs
[ https://issues.apache.org/jira/browse/OFBIZ-13092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17847802#comment-17847802 ] ASF subversion and git services commented on OFBIZ-13092: - Commit 7e7b7c4266d85fdcf2ad9216349424abd7138615 in ofbiz-framework's branch refs/heads/trunk from Jacques Le Roux [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=7e7b7c4266 ] Improved: Prevent special encoded characters sequences in URLs (OFBIZ-13092) Better avoid special encoded characters sequences Improves deniedWebShellTokens in security.properties > Prevent special encoded characters sequences in URLs > > > Key: OFBIZ-13092 > URL: https://issues.apache.org/jira/browse/OFBIZ-13092 > Project: OFBiz > Issue Type: Improvement > Components: framework/webapp >Affects Versions: 18.12.14 >Reporter: Jacques Le Roux >Assignee: Jacques Le Roux >Priority: Major > Fix For: 18.12.14 > > > Better avoid special encoded characters sequences -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OFBIZ-13080) Duplicate main menu button after plugin creation
[ https://issues.apache.org/jira/browse/OFBIZ-13080?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17847649#comment-17847649 ] ASF subversion and git services commented on OFBIZ-13080: - Commit 3aba9e9dc7b1e67a417bc3d7111d4b38706bf6c4 in ofbiz-framework's branch refs/heads/trunk from Sebastian Tschikin [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=3aba9e9dc7 ] Fixed: Duplicate main menu button after plugin creation (OFBIZ-13080) (#794) The 'main' menu-item is no longer necessary as there is a default main menu button for every plugin. > Duplicate main menu button after plugin creation > > > Key: OFBIZ-13080 > URL: https://issues.apache.org/jira/browse/OFBIZ-13080 > Project: OFBiz > Issue Type: Sub-task >Reporter: Sebastian Tschikin >Assignee: Sebastian Tschikin >Priority: Minor > > After creating a plugin with 'gradlew createPlugin -PpluginId=myplugin' there > is a duplicate main menu button in the backend menu of the new plugin. > I am going to provide a fix for that. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OFBIZ-12951) CommonExt - Move from hard-code menu location to parameterized
[ https://issues.apache.org/jira/browse/OFBIZ-12951?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17847635#comment-17847635 ] ASF subversion and git services commented on OFBIZ-12951: - Commit 24d42f3be2913b33543c77ae8323dc5a98d9cbe7 in ofbiz-framework's branch refs/heads/trunk from Pierre Smits [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=24d42f3be2 ] Improved: CommonExt - Move from hard-code menu location to parameterized (OFBIZ-12951) (#795) * Improved: CommonExt - Move from hard-code menu location to parameterized (OFBIZ-12951) ofbizsetup uses profile screens from partymgr. modified web.xml - added profileMenuLocation * OFBIZ-12951 Fix dependency on party ofbizsetup is dependent on party elements modified: commonext - web.xml: added new context-param for createNewParty menu modified: party - web.xml: added new context-param for createNewParty menu - PartyScreens.xml: changed location createNewParty menu reference * Improved: CommonExt - Move from hard-code menu location to parameterized (OFBIZ-12951) modified: Menus.xml - added MainActionMenu extending MainActionMenu in PartyMenus.xml > CommonExt - Move from hard-code menu location to parameterized > -- > > Key: OFBIZ-12951 > URL: https://issues.apache.org/jira/browse/OFBIZ-12951 > Project: OFBiz > Issue Type: Sub-task > Components: commonext >Affects Versions: Upcoming Branch >Reporter: Pierre Smits >Assignee: Jacques Le Roux >Priority: Major > Fix For: Upcoming Branch > > Attachments: Screenshot 2024-05-05 at 20.32.11.png, Screenshot > 2024-05-13 at 12.18.38.png > > > Move the menu location in the various commonest screens from hard-coded to > parameterized. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OFBIZ-13091) Convert PortalPageServices.xml from mini-lang to Groovy
[ https://issues.apache.org/jira/browse/OFBIZ-13091?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17846335#comment-17846335 ] ASF subversion and git services commented on OFBIZ-13091: - Commit b7e0eac21660e3c158777a69095cfb3a4f58eba1 in ofbiz-plugins's branch refs/heads/trunk from Nicolas Malin [ https://gitbox.apache.org/repos/asf?p=ofbiz-plugins.git;h=b7e0eac21 ] Improved: Convert PortalPageMethods.xml from mini-lang to Groovy (OFBIZ-13091) Convert event call to duplicatePortalPage from simple to groovy > Convert PortalPageServices.xml from mini-lang to Groovy > --- > > Key: OFBIZ-13091 > URL: https://issues.apache.org/jira/browse/OFBIZ-13091 > Project: OFBiz > Issue Type: Sub-task >Reporter: Nicolas Malin >Assignee: Nicolas Malin >Priority: Minor > Labels: groovy, migration, mini-lang > > Convert following services : > * createPortalPagePortlet > * deletePortalPagePortlet > * movePortletToPortalPage > * deletePortalPage > * updatePortalPageSeq > * addPortalPageColumn > * deletePortalPageColumn > * updatePortletSeqDragDrop > * getPortletAttributes > Due to inter dependancy, introduce new service : > * duplicatePortalPageDetails > And by the way migrate PortalPageMethods.xml to PortalMethods.grrovy -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OFBIZ-13091) Convert PortalPageServices.xml from mini-lang to Groovy
[ https://issues.apache.org/jira/browse/OFBIZ-13091?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17846331#comment-17846331 ] ASF subversion and git services commented on OFBIZ-13091: - Commit eee3a464d0396b23081d150b940338752619d30c in ofbiz-framework's branch refs/heads/trunk from Nicolas Malin [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=eee3a464d0 ] Improved: Convert PortalPageServices.xml from mini-lang to Groovy (OFBIZ-13091) Convert following services : * createPortalPagePortlet * deletePortalPagePortlet * movePortletToPortalPage * deletePortalPage * updatePortalPageSeq * addPortalPageColumn * deletePortalPageColumn * updatePortletSeqDragDrop * getPortletAttributes Due to interdependency, introduce new service : * duplicatePortalPageDetails And by the way migrate PortalPageMethods.xml to PortalMethods.groovy > Convert PortalPageServices.xml from mini-lang to Groovy > --- > > Key: OFBIZ-13091 > URL: https://issues.apache.org/jira/browse/OFBIZ-13091 > Project: OFBiz > Issue Type: Sub-task >Reporter: Nicolas Malin >Assignee: Nicolas Malin >Priority: Minor > Labels: groovy, migration, mini-lang > > Convert following services : > * createPortalPagePortlet > * deletePortalPagePortlet > * movePortletToPortalPage > * deletePortalPage > * updatePortalPageSeq > * addPortalPageColumn > * deletePortalPageColumn > * updatePortletSeqDragDrop > * getPortletAttributes > Due to inter dependancy, introduce new service : > * duplicatePortalPageDetails > And by the way migrate PortalPageMethods.xml to PortalMethods.grrovy -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OFBIZ-13077) Error when calling EntityQuery.from() with a dynamicView via groovy DSL
[ https://issues.apache.org/jira/browse/OFBIZ-13077?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17845999#comment-17845999 ] ASF subversion and git services commented on OFBIZ-13077: - Commit 8aa27e3b4d08c0471c201fc83fd494399b1586d7 in ofbiz-framework's branch refs/heads/trunk from Mekika Leila [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=8aa27e3b4d ] Fixed: Error when calling EntityQuery.from() with a dve via groovy DSL (OFBIZ-13077) This add the Groovy DSL for EntityQuery.from(DynamicViewEntity dve) > Error when calling EntityQuery.from() with a dynamicView via groovy DSL > --- > > Key: OFBIZ-13077 > URL: https://issues.apache.org/jira/browse/OFBIZ-13077 > Project: OFBiz > Issue Type: Bug > Components: ALL COMPONENTS >Affects Versions: Upcoming Branch >Reporter: Mekika Leila >Assignee: Mekika Leila >Priority: Minor > Attachments: DemoDataOFBIZ-13077.xml > > > There is a "No signature of method " error when executing the script > FindInventoryItemsByLabels.groovy which use Groovy DSL syntax to call method > EntityQuery.from(DynamicViewEntity dve) > This is due to the fact that the from() DSL is currently only defined for > calling the method with an entityName String. > The purpose of this Jira is to add the Groovy DSL for > EntityQuery.from(DynamicViewEntity dve) so the FindInventoryItemsByLabels > will not fail and the dsl will be extended for other scripts > *To reproduce* > In a trunk ofbiz with demo data loaded, load file attached and go to > [SearchInventoryItemsByLabels > page|[https://localhost:8443/facility/control/SearchInventoryItemsByLabels?facilityId=WebStoreWarehouse]]. > > Then select 'Label test' and submit the search form -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OFBIZ-13089) Tomcat access_log has 2 dots
[ https://issues.apache.org/jira/browse/OFBIZ-13089?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17845850#comment-17845850 ] ASF subversion and git services commented on OFBIZ-13089: - Commit 8cd452753791649a17d774ad935153ac78744d46 in ofbiz-framework's branch refs/heads/trunk from Jacques Le Roux [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=8cd4527537 ] Fixed: Tomcat access_log has 2 dots (OFBIZ-13089) Between Tomcat 7 and Tomcat 8 the access_log default value of fileDateFormat has changed: https://tomcat.apache.org/tomcat-7.0-doc/config/valve.html#Access_Log_Valve/Attributes https://tomcat.apache.org/tomcat-8.0-doc/config/valve.html#Access_Log_Valve/Attributes I did not find any notice about that. We did not change OFBiz access-log-prefix value. Not a big deal but better keep a simple file format with only one dot. As we use the defaul format value we could also remove this OOTB value. I believe it's better to keep it in order to allow users to decide about it. Without this OOTB value they may miss this opportunity. > Tomcat access_log has 2 dots > > > Key: OFBIZ-13089 > URL: https://issues.apache.org/jira/browse/OFBIZ-13089 > Project: OFBiz > Issue Type: Improvement > Components: tomcat >Affects Versions: Upcoming Branch >Reporter: Jacques Le Roux >Assignee: Jacques Le Roux >Priority: Trivial > Fix For: Upcoming Branch > > > I noticed that between Tomcat 7 and Tomcat 8 the access_log default value of > fileDateFormat has changed: > https://tomcat.apache.org/tomcat-7.0-doc/config/valve.html#Access_Log_Valve/Attributes > https://tomcat.apache.org/tomcat-8.0-doc/config/valve.html#Access_Log_Valve/Attributes > I did not find any notice about that. We did not change OFBiz > access-log-prefix value. > Not a big deal but better keep a simple file format with only one dot. > As we use the defaul format value we could also remove this OOTB value. I > believe it's better to keep it in order to allow users to decide about it. > Without this OOTB value they may miss this opportunity. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OFBIZ-13054) Marketing-Main page
[ https://issues.apache.org/jira/browse/OFBIZ-13054?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17845553#comment-17845553 ] ASF subversion and git services commented on OFBIZ-13054: - Commit f5aad6669e03fde5963eab2d2791403bed29da51 in ofbiz-framework's branch refs/heads/trunk from Pierre Smits [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=f5aad6669e ] Improved: Marketing-Main page (OFBIZ-13054) (#785) * Improved: Marketing-Main page (OFBIZ-13054) Currently the 'main' view-map points to a screen showing a label In order to improve the user experience the main request-map and view-map should show what is most pressing in marketing to address: active campaigns and contact list communication events. added: - MarketingPortletData.xml, having record definitions for PortalPage, Portlet, etc modified:: - ofbiz-component.xml: added data loader for MarketingPortletData.xml - controller.xml: changed view-map 'main' to point to screen Main in CommonScreens.xml - CommonScreens.xml: screen Main displaying a PortalPage - MarketingCampaignScreens.xml: adding screen Campaigns for active campaigns - MarketingCampaignForms.xml: adding grid Campaigns to list active campaigns - ContactListScreens.xml: adding screen CommEvents for active communication events - ContactListForms.xml: adding grid Campaigns to list active communication events * Improved: Marketing-Main page (OFBIZ-13054) Currently the 'main' view-map points to a screen showing a label In order to improve the user experience the main request-map and view-map should show what is most pressing in marketing to address: active campaigns and contact list communication events. modified: - CommonScreens.xml: clean-up - MarketingCampaignForms: added ref.data elements * OFBIZ-13054 cleanup * Imrproved: Marketing Main Page (OFBIZ-13054) removed trailing spaces * Update ofbiz-component.xml Fixes a typo - Co-authored-by: Jacques Le Roux > Marketing-Main page > --- > > Key: OFBIZ-13054 > URL: https://issues.apache.org/jira/browse/OFBIZ-13054 > Project: OFBiz > Issue Type: Sub-task >Reporter: Pierre Smits >Priority: Major > Attachments: Screenshot 2024-05-08 at 08.41.28.png, Screenshot > 2024-05-08 at 08.47.24.png > > > Currently the 'main' view-map points to a screen showing a label, see the > first attached image. > > In order to improve the user experience the main request-map and view-map > should show what is most pressing in marketing to address: active campaigns > and contact list communication events. See the second attached image -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OFBIZ-13042) Ecommerce-parameterized menu location
[ https://issues.apache.org/jira/browse/OFBIZ-13042?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17845451#comment-17845451 ] ASF subversion and git services commented on OFBIZ-13042: - Commit 6b73cf1f065b9fdfb2b205bb04cad585cad4f737 in ofbiz-plugins's branch refs/heads/trunk from Pierre Smits [ https://gitbox.apache.org/repos/asf?p=ofbiz-plugins.git;h=6b73cf1f0 ] Improved: Ecommerce - parameterized menu location (OFBIZ-13042) (#115) * Improved: Ecommerce - move to parameterized menu location modified: web.xml - add mainMenuLocation * Improved: Ecommerce - move to parameterized menu location (OFBIZ-13042) added EcommerceMenus.xml * Improved: Ecommerce - move to parameterized menu location (OFBIZ-13042) BlogScreens.xml: changed menu location * Improved: Ecommerce - move to parameterized menu location (OFBIZ-13042) ecomseo/web.xml added mainMenuLocation * Improved: Ecommerce parameterized menu location (OFBIZ-13042) modified: - BlogScreens.xml: corrected menu location - added missing } removed: BlogMenus.xml > Ecommerce-parameterized menu location > - > > Key: OFBIZ-13042 > URL: https://issues.apache.org/jira/browse/OFBIZ-13042 > Project: OFBiz > Issue Type: Sub-task > Components: ecommerce >Reporter: Pierre Smits >Priority: Major > > Move to parameterized menu locations -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OFBIZ-13039) dateType parameter not existing in "renderDateTimeField" Macro
[
https://issues.apache.org/jira/browse/OFBIZ-13039?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17845431#comment-17845431
]
ASF subversion and git services commented on OFBIZ-13039:
-
Commit c223de1a4dfae4fdd3702d765ebfef9fe887e6b7 in ofbiz-plugins's branch
refs/heads/trunk from Jacques Le Roux
[ https://gitbox.apache.org/repos/asf?p=ofbiz-plugins.git;h=c223de1a4 ]
Fixed: dateType parameter not existing in "renderDateTimeField" Macro
(OFBIZ-13039)
Previous commit (4de5d7bf7e3f077cc81bd1d62bb1848c83c9392b) was wrong. I put back
dateType="date" parameter when isDateType=true should have been used.
It was put in with OFBIZ-12126 but then not changed in templates plugins
It also fixes commit ba1b753ef6d653e6e7aeeca4add330c627cabf91 of OFBIZ-7949
So this replaces dateType="date" by isDateType=true in "renderDateTimeField"
Macro in:
ProductDetail.ftl
EditShoppingList.ftl
EditTaskAndAssoc.ftl
ListSurveys.ftl
> dateType parameter not existing in "renderDateTimeField" Macro
> ---
>
> Key: OFBIZ-13039
> URL: https://issues.apache.org/jira/browse/OFBIZ-13039
> Project: OFBiz
> Issue Type: Bug
> Components: ecommerce
>Affects Versions: 18.12.13
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Major
> Fix For: 18.12.13
>
>
> freemarker.core._MiscTemplateException: Macro "renderDateTimeField" has no
> parameter with name "dateType". Valid parameter names are: name, className,
> timeDropdownParamName, defaultDateTimeString, localizedIconTitle,
> timeHourName, timeMinutesName, ampmName, compositeType, alert, isTimeType,
> isDateType, amSelected, pmSelected, timeDropdown, classString, isTwelveHour,
> hour1, hour2, minutes, shortDateInput, title, value, size, maxlength, id,
> formName, mask, event, action, step, timeValues, tabindex, disabled,
> isXMLHttpRequest
>
> FTL stack trace ("~" means nesting-related):
> - Failed at: @htmlTemplate.renderDateTimeField eve... [in template
> "component://ecommerce/template/catalog/ProductDetail.ftl" at line 726,
> column 17]
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (OFBIZ-7949) E-commerce : FTL formatting
[ https://issues.apache.org/jira/browse/OFBIZ-7949?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17845430#comment-17845430 ] ASF subversion and git services commented on OFBIZ-7949: Commit 7a709d6de39e8fdd6f5c374fecd2fc3945647797 in ofbiz-plugins's branch refs/heads/release18.12 from Jacques Le Roux [ https://gitbox.apache.org/repos/asf?p=ofbiz-plugins.git;h=7a709d6de ] Fixed: dateType parameter not existing in "renderDateTimeField" Macro (OFBIZ-13039) Previous commit (4de5d7bf7e3f077cc81bd1d62bb1848c83c9392b) was wrong. I put back dateType="date" parameter when isDateType=true should have been used. It was put in with OFBIZ-12126 but then not changed in templates plugins It also fixes commit ba1b753ef6d653e6e7aeeca4add330c627cabf91 of OFBIZ-7949 So this replaces dateType="date" by isDateType=true in "renderDateTimeField" Macro in: ProductDetail.ftl EditShoppingList.ftl EditTaskAndAssoc.ftl ListSurveys.ftl > E-commerce : FTL formatting > --- > > Key: OFBIZ-7949 > URL: https://issues.apache.org/jira/browse/OFBIZ-7949 > Project: OFBiz > Issue Type: Sub-task > Components: ecommerce >Affects Versions: 18.12.13 >Reporter: Vaibhav Jain >Assignee: Jacques Le Roux >Priority: Major > Fix For: 18.12.14 > > Attachments: OFBIZ-7949.patch, OFBIZ-7949.patch > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OFBIZ-12126) Refactor MacroFormRenderer to use RenderableFtlElements for datetime fields
[ https://issues.apache.org/jira/browse/OFBIZ-12126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17845432#comment-17845432 ] ASF subversion and git services commented on OFBIZ-12126: - Commit c223de1a4dfae4fdd3702d765ebfef9fe887e6b7 in ofbiz-plugins's branch refs/heads/trunk from Jacques Le Roux [ https://gitbox.apache.org/repos/asf?p=ofbiz-plugins.git;h=c223de1a4 ] Fixed: dateType parameter not existing in "renderDateTimeField" Macro (OFBIZ-13039) Previous commit (4de5d7bf7e3f077cc81bd1d62bb1848c83c9392b) was wrong. I put back dateType="date" parameter when isDateType=true should have been used. It was put in with OFBIZ-12126 but then not changed in templates plugins It also fixes commit ba1b753ef6d653e6e7aeeca4add330c627cabf91 of OFBIZ-7949 So this replaces dateType="date" by isDateType=true in "renderDateTimeField" Macro in: ProductDetail.ftl EditShoppingList.ftl EditTaskAndAssoc.ftl ListSurveys.ftl > Refactor MacroFormRenderer to use RenderableFtlElements for datetime fields > --- > > Key: OFBIZ-12126 > URL: https://issues.apache.org/jira/browse/OFBIZ-12126 > Project: OFBiz > Issue Type: Sub-task > Components: framework/widget >Affects Versions: Trunk, Upcoming Branch >Reporter: Daniel Watford >Assignee: Daniel Watford >Priority: Minor > Fix For: Upcoming Branch > > > As part of refactoring MacroFormRenderer (OFBIZ-11456), the > renderDateTimeField method should be refactored to create > RenderableFtlElements and pass them to an FtlWriter. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OFBIZ-7949) E-commerce : FTL formatting
[ https://issues.apache.org/jira/browse/OFBIZ-7949?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17845433#comment-17845433 ] ASF subversion and git services commented on OFBIZ-7949: Commit c223de1a4dfae4fdd3702d765ebfef9fe887e6b7 in ofbiz-plugins's branch refs/heads/trunk from Jacques Le Roux [ https://gitbox.apache.org/repos/asf?p=ofbiz-plugins.git;h=c223de1a4 ] Fixed: dateType parameter not existing in "renderDateTimeField" Macro (OFBIZ-13039) Previous commit (4de5d7bf7e3f077cc81bd1d62bb1848c83c9392b) was wrong. I put back dateType="date" parameter when isDateType=true should have been used. It was put in with OFBIZ-12126 but then not changed in templates plugins It also fixes commit ba1b753ef6d653e6e7aeeca4add330c627cabf91 of OFBIZ-7949 So this replaces dateType="date" by isDateType=true in "renderDateTimeField" Macro in: ProductDetail.ftl EditShoppingList.ftl EditTaskAndAssoc.ftl ListSurveys.ftl > E-commerce : FTL formatting > --- > > Key: OFBIZ-7949 > URL: https://issues.apache.org/jira/browse/OFBIZ-7949 > Project: OFBiz > Issue Type: Sub-task > Components: ecommerce >Affects Versions: 18.12.13 >Reporter: Vaibhav Jain >Assignee: Jacques Le Roux >Priority: Major > Fix For: 18.12.14 > > Attachments: OFBIZ-7949.patch, OFBIZ-7949.patch > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OFBIZ-12126) Refactor MacroFormRenderer to use RenderableFtlElements for datetime fields
[ https://issues.apache.org/jira/browse/OFBIZ-12126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17845429#comment-17845429 ] ASF subversion and git services commented on OFBIZ-12126: - Commit 7a709d6de39e8fdd6f5c374fecd2fc3945647797 in ofbiz-plugins's branch refs/heads/release18.12 from Jacques Le Roux [ https://gitbox.apache.org/repos/asf?p=ofbiz-plugins.git;h=7a709d6de ] Fixed: dateType parameter not existing in "renderDateTimeField" Macro (OFBIZ-13039) Previous commit (4de5d7bf7e3f077cc81bd1d62bb1848c83c9392b) was wrong. I put back dateType="date" parameter when isDateType=true should have been used. It was put in with OFBIZ-12126 but then not changed in templates plugins It also fixes commit ba1b753ef6d653e6e7aeeca4add330c627cabf91 of OFBIZ-7949 So this replaces dateType="date" by isDateType=true in "renderDateTimeField" Macro in: ProductDetail.ftl EditShoppingList.ftl EditTaskAndAssoc.ftl ListSurveys.ftl > Refactor MacroFormRenderer to use RenderableFtlElements for datetime fields > --- > > Key: OFBIZ-12126 > URL: https://issues.apache.org/jira/browse/OFBIZ-12126 > Project: OFBiz > Issue Type: Sub-task > Components: framework/widget >Affects Versions: Trunk, Upcoming Branch >Reporter: Daniel Watford >Assignee: Daniel Watford >Priority: Minor > Fix For: Upcoming Branch > > > As part of refactoring MacroFormRenderer (OFBIZ-11456), the > renderDateTimeField method should be refactored to create > RenderableFtlElements and pass them to an FtlWriter. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OFBIZ-13039) dateType parameter not existing in "renderDateTimeField" Macro
[
https://issues.apache.org/jira/browse/OFBIZ-13039?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17845428#comment-17845428
]
ASF subversion and git services commented on OFBIZ-13039:
-
Commit 7a709d6de39e8fdd6f5c374fecd2fc3945647797 in ofbiz-plugins's branch
refs/heads/release18.12 from Jacques Le Roux
[ https://gitbox.apache.org/repos/asf?p=ofbiz-plugins.git;h=7a709d6de ]
Fixed: dateType parameter not existing in "renderDateTimeField" Macro
(OFBIZ-13039)
Previous commit (4de5d7bf7e3f077cc81bd1d62bb1848c83c9392b) was wrong. I put back
dateType="date" parameter when isDateType=true should have been used.
It was put in with OFBIZ-12126 but then not changed in templates plugins
It also fixes commit ba1b753ef6d653e6e7aeeca4add330c627cabf91 of OFBIZ-7949
So this replaces dateType="date" by isDateType=true in "renderDateTimeField"
Macro in:
ProductDetail.ftl
EditShoppingList.ftl
EditTaskAndAssoc.ftl
ListSurveys.ftl
> dateType parameter not existing in "renderDateTimeField" Macro
> ---
>
> Key: OFBIZ-13039
> URL: https://issues.apache.org/jira/browse/OFBIZ-13039
> Project: OFBiz
> Issue Type: Bug
> Components: ecommerce
>Affects Versions: 18.12.13
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Major
> Fix For: 18.12.13
>
>
> freemarker.core._MiscTemplateException: Macro "renderDateTimeField" has no
> parameter with name "dateType". Valid parameter names are: name, className,
> timeDropdownParamName, defaultDateTimeString, localizedIconTitle,
> timeHourName, timeMinutesName, ampmName, compositeType, alert, isTimeType,
> isDateType, amSelected, pmSelected, timeDropdown, classString, isTwelveHour,
> hour1, hour2, minutes, shortDateInput, title, value, size, maxlength, id,
> formName, mask, event, action, step, timeValues, tabindex, disabled,
> isXMLHttpRequest
>
> FTL stack trace ("~" means nesting-related):
> - Failed at: @htmlTemplate.renderDateTimeField eve... [in template
> "component://ecommerce/template/catalog/ProductDetail.ftl" at line 726,
> column 17]
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (OFBIZ-12126) Refactor MacroFormRenderer to use RenderableFtlElements for datetime fields
[ https://issues.apache.org/jira/browse/OFBIZ-12126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17845425#comment-17845425 ] ASF subversion and git services commented on OFBIZ-12126: - Commit ff16d94669f6f6a3cc5f41df24bc5227ddf82bbe in ofbiz-framework's branch refs/heads/trunk from Jacques Le Roux [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=ff16d94669 ] Fixed: dateType parameter not existing in "renderDateTimeField" Macro (OFBIZ-13039) This replaces dateType="date" by isDateType=true in "renderDateTimeField" Macro in CommonMacros.ftl isDateType=true was put in with OFBIZ-12126 but then not changed in this template > Refactor MacroFormRenderer to use RenderableFtlElements for datetime fields > --- > > Key: OFBIZ-12126 > URL: https://issues.apache.org/jira/browse/OFBIZ-12126 > Project: OFBiz > Issue Type: Sub-task > Components: framework/widget >Affects Versions: Trunk, Upcoming Branch >Reporter: Daniel Watford >Assignee: Daniel Watford >Priority: Minor > Fix For: Upcoming Branch > > > As part of refactoring MacroFormRenderer (OFBIZ-11456), the > renderDateTimeField method should be refactored to create > RenderableFtlElements and pass them to an FtlWriter. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OFBIZ-13039) dateType parameter not existing in "renderDateTimeField" Macro
[
https://issues.apache.org/jira/browse/OFBIZ-13039?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17845424#comment-17845424
]
ASF subversion and git services commented on OFBIZ-13039:
-
Commit ff16d94669f6f6a3cc5f41df24bc5227ddf82bbe in ofbiz-framework's branch
refs/heads/trunk from Jacques Le Roux
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=ff16d94669 ]
Fixed: dateType parameter not existing in "renderDateTimeField" Macro
(OFBIZ-13039)
This replaces dateType="date" by isDateType=true in "renderDateTimeField"
Macro in CommonMacros.ftl
isDateType=true was put in with OFBIZ-12126 but then not changed in this
template
> dateType parameter not existing in "renderDateTimeField" Macro
> ---
>
> Key: OFBIZ-13039
> URL: https://issues.apache.org/jira/browse/OFBIZ-13039
> Project: OFBiz
> Issue Type: Bug
> Components: ecommerce
>Affects Versions: 18.12.13
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Major
> Fix For: 18.12.13
>
>
> freemarker.core._MiscTemplateException: Macro "renderDateTimeField" has no
> parameter with name "dateType". Valid parameter names are: name, className,
> timeDropdownParamName, defaultDateTimeString, localizedIconTitle,
> timeHourName, timeMinutesName, ampmName, compositeType, alert, isTimeType,
> isDateType, amSelected, pmSelected, timeDropdown, classString, isTwelveHour,
> hour1, hour2, minutes, shortDateInput, title, value, size, maxlength, id,
> formName, mask, event, action, step, timeValues, tabindex, disabled,
> isXMLHttpRequest
>
> FTL stack trace ("~" means nesting-related):
> - Failed at: @htmlTemplate.renderDateTimeField eve... [in template
> "component://ecommerce/template/catalog/ProductDetail.ftl" at line 726,
> column 17]
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (OFBIZ-12126) Refactor MacroFormRenderer to use RenderableFtlElements for datetime fields
[ https://issues.apache.org/jira/browse/OFBIZ-12126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17845423#comment-17845423 ] ASF subversion and git services commented on OFBIZ-12126: - Commit 35b4b89f285d92445d6ade017c72b20fa4aa0a89 in ofbiz-framework's branch refs/heads/release18.12 from Jacques Le Roux [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=35b4b89f28 ] Fixed: dateType parameter not existing in "renderDateTimeField" Macro (OFBIZ-13039) This replaces dateType="date" by isDateType=true in "renderDateTimeField" Macro in CommonMacros.ftl isDateType=true was put in with OFBIZ-12126 but then not changed in this template Conflicts handled by hand > Refactor MacroFormRenderer to use RenderableFtlElements for datetime fields > --- > > Key: OFBIZ-12126 > URL: https://issues.apache.org/jira/browse/OFBIZ-12126 > Project: OFBiz > Issue Type: Sub-task > Components: framework/widget >Affects Versions: Trunk, Upcoming Branch >Reporter: Daniel Watford >Assignee: Daniel Watford >Priority: Minor > Fix For: Upcoming Branch > > > As part of refactoring MacroFormRenderer (OFBIZ-11456), the > renderDateTimeField method should be refactored to create > RenderableFtlElements and pass them to an FtlWriter. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OFBIZ-13039) dateType parameter not existing in "renderDateTimeField" Macro
[
https://issues.apache.org/jira/browse/OFBIZ-13039?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17845422#comment-17845422
]
ASF subversion and git services commented on OFBIZ-13039:
-
Commit 35b4b89f285d92445d6ade017c72b20fa4aa0a89 in ofbiz-framework's branch
refs/heads/release18.12 from Jacques Le Roux
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=35b4b89f28 ]
Fixed: dateType parameter not existing in "renderDateTimeField" Macro
(OFBIZ-13039)
This replaces dateType="date" by isDateType=true in "renderDateTimeField"
Macro in CommonMacros.ftl
isDateType=true was put in with OFBIZ-12126 but then not changed in this
template
Conflicts handled by hand
> dateType parameter not existing in "renderDateTimeField" Macro
> ---
>
> Key: OFBIZ-13039
> URL: https://issues.apache.org/jira/browse/OFBIZ-13039
> Project: OFBiz
> Issue Type: Bug
> Components: ecommerce
>Affects Versions: 18.12.13
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Major
> Fix For: 18.12.13
>
>
> freemarker.core._MiscTemplateException: Macro "renderDateTimeField" has no
> parameter with name "dateType". Valid parameter names are: name, className,
> timeDropdownParamName, defaultDateTimeString, localizedIconTitle,
> timeHourName, timeMinutesName, ampmName, compositeType, alert, isTimeType,
> isDateType, amSelected, pmSelected, timeDropdown, classString, isTwelveHour,
> hour1, hour2, minutes, shortDateInput, title, value, size, maxlength, id,
> formName, mask, event, action, step, timeValues, tabindex, disabled,
> isXMLHttpRequest
>
> FTL stack trace ("~" means nesting-related):
> - Failed at: @htmlTemplate.renderDateTimeField eve... [in template
> "component://ecommerce/template/catalog/ProductDetail.ftl" at line 726,
> column 17]
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (OFBIZ-13086) Convert SampleCommissionServices.xml from mini-lang to Groovy
[ https://issues.apache.org/jira/browse/OFBIZ-13086?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17845329#comment-17845329 ] ASF subversion and git services commented on OFBIZ-13086: - Commit 86f89cdd855d45248493d1397ce7dcee232ef6da in ofbiz-framework's branch refs/heads/trunk from Nicolas Malin [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=86f89cdd85 ] Improved: Convert SampleCommissionServices.xml from mini-lang to Groovy (OFBIZ-13086) Convert the service sampleInvoiceAffiliateCommission from minilang to groovy. As is a sample service for example, I moved it to a dedicate file definition > Convert SampleCommissionServices.xml from mini-lang to Groovy > - > > Key: OFBIZ-13086 > URL: https://issues.apache.org/jira/browse/OFBIZ-13086 > Project: OFBiz > Issue Type: Sub-task > Components: accounting >Reporter: Nicolas Malin >Assignee: Nicolas Malin >Priority: Trivial > Labels: groovy, migration, mini-lang > > Convert the service sampleInvoiceAffiliateCommission, move it on dedicate > definition service file -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OFBIZ-13084) In main accounting page, replace invoice type by description
[ https://issues.apache.org/jira/browse/OFBIZ-13084?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17845074#comment-17845074 ] ASF subversion and git services commented on OFBIZ-13084: - Commit 4ad9397b9b7f6bc1b817f604485c97d25fa04e6b in ofbiz-framework's branch refs/heads/trunk from Jacques Le Roux [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=4ad9397b9b ] Improved: In main accounting page, replace invoice type by description (OFBIZ-13084) The invoice type is hardcoded in the 4 related screens in InvoiceScreens.xml by invoiceTypeId. This replaces that by the description in InvoiceForms.xml > In main accounting page, replace invoice type by description > > > Key: OFBIZ-13084 > URL: https://issues.apache.org/jira/browse/OFBIZ-13084 > Project: OFBiz > Issue Type: Improvement > Components: accounting/invoice >Affects Versions: Upcoming Branch >Reporter: Jacques Le Roux >Assignee: Jacques Le Roux >Priority: Trivial > Fix For: Upcoming Branch > > > The invoice type is hardcoded in the 4 related screens in InvoiceScreens.xml > by invoiceTypeId. I'll replace that by the description -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OFBIZ-13006) [SECURITY] (CVE-2024-32113) Path traversal leading to RCE
[ https://issues.apache.org/jira/browse/OFBIZ-13006?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17844688#comment-17844688 ] ASF subversion and git services commented on OFBIZ-13006: - Commit 2c2dd4f2714d275c76ab064fcc1b559e9a06721c in ofbiz-site's branch refs/heads/master from Jacques Le Roux [ https://gitbox.apache.org/repos/asf?p=ofbiz-site.git;h=2c2dd4f ] [SECURITY] (CVE-2024-32113) Path traversal leading to RCE (OFBIZ-13006) > [SECURITY] (CVE-2024-32113) Path traversal leading to RCE > - > > Key: OFBIZ-13006 > URL: https://issues.apache.org/jira/browse/OFBIZ-13006 > Project: OFBiz > Issue Type: Sub-task > Components: framework/webapp >Affects Versions: 18.12.13 >Reporter: Jacques Le Roux >Assignee: Jacques Le Roux >Priority: Critical > Fix For: 18.12.13 > > > Some URLs need to be rejected before they create problems -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OFBIZ-13087) Corrections/updates to DOCKER.adoc
[ https://issues.apache.org/jira/browse/OFBIZ-13087?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17844645#comment-17844645 ] ASF subversion and git services commented on OFBIZ-13087: - Commit a73f65e50a970151d91d035fc79968867ebbc02d in ofbiz-framework's branch refs/heads/trunk from Daniel Watford [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=a73f65e50a ] Improved: DOCKER.adoc corrections (OFBIZ-13087) Correct the example command lines used to build docker images. Remove use of redundant DOCKER_BUILDKIT environment variable. > Corrections/updates to DOCKER.adoc > -- > > Key: OFBIZ-13087 > URL: https://issues.apache.org/jira/browse/OFBIZ-13087 > Project: OFBiz > Issue Type: Improvement > Components: Docker >Affects Versions: Upcoming Branch >Reporter: Daniel Watford >Assignee: Daniel Watford >Priority: Trivial > Fix For: Upcoming Branch > > > A few updates should be made to file, DOCKER.adoc: > * The example docker-build commands are missing the period (.) at the end of > the line that refers to the current directory as the docker context. User > running the example will see an error if the period (or some other directory) > is not stated on the command line. > * Since docker v23.0.0 setting the environment variable, DOCKER_BUILDKIT, to > 1 has no effect. Setting this environment variable can be removed from the > examples. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OFBIZ-13085) Convert InvoiceServices.xml from mini-lang to Groovy
[ https://issues.apache.org/jira/browse/OFBIZ-13085?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17844292#comment-17844292 ] ASF subversion and git services commented on OFBIZ-13085: - Commit a380a7846ec95f293052014b30de935ee6fc4b00 in ofbiz-framework's branch refs/heads/trunk from Nicolas Malin [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=a380a7846e ] Improved: Convert InvoiceServices.xml from mini-lang to Groovy (OFBIZ-13085) Convert following services to groovy : * createInvoice * copyInvoice * getInvoice * updateInvoice * setInvoiceStatus * copyInvoiceToTemplate * checkInvoiceStatusInProgress * createInvoiceItem * updateInvoiceItem * removeInvoiceItem * sendInvoicePerEmail * autoGenerateInvoiceFromExistingInvoice * cancelInvoice * getInvoiceRunningTotal * addTaxOnInvoice * getInvoicesFilterByAssocType * removeInvoiceItemAssocOnCancelInvoice * resetOrderItemBillingAndOrderAdjustmentBillingOnCancelInvoice * massChangeInvoiceStatus * createInvoiceFromOrder * isInvoiceInForeignCurrency * removePaymentApplication (move to payment package) These services to entity-auto : * createInvoiceRole * removeInvoiceRole * createInvoiceTerm * createInvoiceContent * updateInvoiceContent Introduce new services : * checkInvoiceStatusInProgress * createInvoiceContentAndUpdateContent * updateInvoiceContentAndContent checkInvoiceStatusInProgress have been added as permission service to autorize or not edit service on invoice. createInvoiceContentAndUpdateContent and updateInvoiceContentAndContent have be added to manage both entity InvoiceContent and Content, and let createInvoiceContent and updateInvoiceContent as crud service > Convert InvoiceServices.xml from mini-lang to Groovy > > > Key: OFBIZ-13085 > URL: https://issues.apache.org/jira/browse/OFBIZ-13085 > Project: OFBiz > Issue Type: Sub-task > Components: accounting/invoice >Reporter: Nicolas Malin >Assignee: Nicolas Malin >Priority: Minor > Labels: Minilang, groovy, migration > > Convert following services to groovy : > * createInvoice > * copyInvoice > * getInvoice > * updateInvoice > * setInvoiceStatus > * copyInvoiceToTemplate > * checkInvoiceStatusInProgress > * createInvoiceItem > * updateInvoiceItem > * removeInvoiceItem > * sendInvoicePerEmail > * autoGenerateInvoiceFromExistingInvoice > * cancelInvoice > * getInvoiceRunningTotal > * addTaxOnInvoice > * getInvoicesFilterByAssocType > * removeInvoiceItemAssocOnCancelInvoice > * resetOrderItemBillingAndOrderAdjustmentBillingOnCancelInvoice > * massChangeInvoiceStatus > * createInvoiceFromOrder > * isInvoiceInForeignCurrency > * removePaymentApplication (move to payment package) > These services to entity-auto : > * createInvoiceRole > * removeInvoiceRole > * createInvoiceTerm > * createInvoiceContent > * updateInvoiceContent > Introduce new services : > * checkInvoiceStatusInProgress > * createInvoiceContentAndUpdateContent > * updateInvoiceContentAndContent > checkInvoiceStatusInProgress have been added as permission service to > autorize or not edit service on invoice. > createInvoiceContentAndUpdateContent and updateInvoiceContentAndContent have > be added to manage both entity InvoiceContent and Content, and let > createInvoiceContent and updateInvoiceContent as crud service -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OFBIZ-7949) E-commerce : FTL formatting
[ https://issues.apache.org/jira/browse/OFBIZ-7949?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17844242#comment-17844242 ] ASF subversion and git services commented on OFBIZ-7949: Commit ba1b753ef6d653e6e7aeeca4add330c627cabf91 in ofbiz-plugins's branch refs/heads/trunk from Jacques Le Roux [ https://gitbox.apache.org/repos/asf?p=ofbiz-plugins.git;h=ba1b753ef ] Fixed: E-commerce : FTL formatting (OFBIZ-7949) Fixes a missing dateType found in stable demo error.log > E-commerce : FTL formatting > --- > > Key: OFBIZ-7949 > URL: https://issues.apache.org/jira/browse/OFBIZ-7949 > Project: OFBiz > Issue Type: Sub-task > Components: ecommerce >Reporter: Vaibhav Jain >Assignee: Vaibhav Jain >Priority: Major > Attachments: OFBIZ-7949.patch, OFBIZ-7949.patch > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OFBIZ-7949) E-commerce : FTL formatting
[ https://issues.apache.org/jira/browse/OFBIZ-7949?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17844241#comment-17844241 ] ASF subversion and git services commented on OFBIZ-7949: Commit 2abe8cab363aa09b4ec13ab8f77ad24df119995b in ofbiz-plugins's branch refs/heads/release18.12 from Jacques Le Roux [ https://gitbox.apache.org/repos/asf?p=ofbiz-plugins.git;h=2abe8cab3 ] Fixed: E-commerce : FTL formatting (OFBIZ-7949) Fixes a missing dateType found in stable demo error.log > E-commerce : FTL formatting > --- > > Key: OFBIZ-7949 > URL: https://issues.apache.org/jira/browse/OFBIZ-7949 > Project: OFBiz > Issue Type: Sub-task > Components: ecommerce >Reporter: Vaibhav Jain >Assignee: Vaibhav Jain >Priority: Major > Attachments: OFBIZ-7949.patch, OFBIZ-7949.patch > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OFBIZ-13083) Find Record buttons not working in Entity Data Maintenance
[ https://issues.apache.org/jira/browse/OFBIZ-13083?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17843747#comment-17843747 ] ASF subversion and git services commented on OFBIZ-13083: - Commit fd97e48434b4696d3122f54a976cc038b071c6b1 in ofbiz-framework's branch refs/heads/trunk from Sebastian Tschikin [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=fd97e48434 ] Fixed: Find Record buttons not working in EDM (OFBIZ-13083) (#796) Fixes Find Record Buttons A - Z in Entity Data Maintenance (EDM) > Find Record buttons not working in Entity Data Maintenance > -- > > Key: OFBIZ-13083 > URL: https://issues.apache.org/jira/browse/OFBIZ-13083 > Project: OFBiz > Issue Type: Bug >Reporter: Sebastian Tschikin >Assignee: Sebastian Tschikin >Priority: Minor > > The Find Record buttons A - Z to jump to specific entities are not working > right now. > I am going to provide a pull request for a fix. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OFBIZ-13082) Convert TaxAuthority services mini-lang to groovyDSL
[ https://issues.apache.org/jira/browse/OFBIZ-13082?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17843242#comment-17843242 ] ASF subversion and git services commented on OFBIZ-13082: - Commit fd554682d8420bee7c127d09d6a73579123e2e53 in ofbiz-framework's branch refs/heads/trunk from Nicolas Malin [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=fd554682d8 ] Improved: Convert TaxAuthority services mini-lang to groovyDSL (OFBIZ-13082) Convert the following services: * createPartyTaxAuthInfo * updatePartyTaxAuthInfo * createCustomerTaxAuthInfo > Convert TaxAuthority services mini-lang to groovyDSL > > > Key: OFBIZ-13082 > URL: https://issues.apache.org/jira/browse/OFBIZ-13082 > Project: OFBiz > Issue Type: Sub-task > Components: accounting >Reporter: Nicolas Malin >Priority: Minor > > Convert the following services : > * createPartyTaxAuthInfo > * updatePartyTaxAuthInfo > * createCustomerTaxAuthInfo -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OFBIZ-13079) Error in ProductServicesScript.groovy: Cannot execute null+1
[ https://issues.apache.org/jira/browse/OFBIZ-13079?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17843218#comment-17843218 ] ASF subversion and git services commented on OFBIZ-13079: - Commit bb3a69ee1a75befc28a6a46ca2568e7a75b46184 in ofbiz-framework's branch refs/heads/trunk from Jacques Le Roux [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=bb3a69ee1a ] Fixed: Error in ProductServicesScript.groovy]:(Cannot execute null+1) (OFBIZ-13079) Fixes an error in countProductView service. There is still an error reproducible in 18.12 (summarised) Error running Groovy method ProductServicesScript::countProductView : org.apache.ofbiz.entity.GenericEntityException: Error while inserting: [GenericEntity:ProductCalculatedInfo](INSERT on table 'PRODUCT_CALCULATED_INFO' caused a violation of foreign key constraint 'PRODCI_PROD' for key (GS-1000). The statement has been rolled back. So another Jira is needed. > Error in ProductServicesScript.groovy: Cannot execute null+1 > - > > Key: OFBIZ-13079 > URL: https://issues.apache.org/jira/browse/OFBIZ-13079 > Project: OFBiz > Issue Type: Bug > Components: product/catalog >Affects Versions: Upcoming Branch >Reporter: Jacques Le Roux >Assignee: Jacques Le Roux >Priority: Major > Fix For: Upcoming Branch > > > Easy fix: > 2024-05-02 13:36:26,779 |OFBiz-JobQueue-1 |GenericServiceJob > |E| Async-Service failed. > org.apache.ofbiz.service.GenericServiceException: Error running Groovy method > [countProductView] in Groovy file > [component://product/src/main/groovy/org/apache/ofbiz/product/product/product/ProductServicesScript.groovy]: > (Cannot execute null+1) > at > org.apache.ofbiz.service.engine.GroovyEngine.runSync(GroovyEngine.java:138) > ~[ofbiz.jar:?] > at > org.apache.ofbiz.service.ServiceDispatcher.runSync(ServiceDispatcher.java:429) > ~[ofbiz.jar:?] > at > org.apache.ofbiz.service.ServiceDispatcher.runSync(ServiceDispatcher.java:244) > ~[ofbiz.jar:?] > at > org.apache.ofbiz.service.GenericDispatcherFactory$GenericDispatcher.runSync(GenericDispatcherFactory.java:93) > ~[ofbiz.jar:?] > at > org.apache.ofbiz.service.job.GenericServiceJob.exec(GenericServiceJob.java:77) > [ofbiz.jar:?] > at org.apache.ofbiz.service.job.AbstractJob.run(AbstractJob.java:106) > [ofbiz.jar:?] > at > java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1136) > [?:?] > at > java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:635) > [?:?] > at java.lang.Thread.run(Thread.java:840) [?:?] > Caused by: java.lang.NullPointerException: Cannot execute null+1 > at org.codehaus.groovy.runtime.NullObject.plus(NullObject.java:159) > ~[groovy-3.0.21.jar:3.0.21] > at org.codehaus.groovy.runtime.NullObject$plus$0.call(Unknown Source) > ~[?:?] > at > org.codehaus.groovy.runtime.callsite.CallSiteArray.defaultCall(CallSiteArray.java:47) > ~[groovy-3.0.21.jar:3.0.21] > at > org.codehaus.groovy.runtime.callsite.NullCallSite.call(NullCallSite.java:34) > ~[groovy-3.0.21.jar:3.0.21] > at > org.codehaus.groovy.runtime.callsite.CallSiteArray.defaultCall(CallSiteArray.java:47) > ~[groovy-3.0.21.jar:3.0.21] > at > org.codehaus.groovy.runtime.callsite.AbstractCallSite.call(AbstractCallSite.java:125) > ~[groovy-3.0.21.jar:3.0.21] > at > org.codehaus.groovy.runtime.callsite.AbstractCallSite.call(AbstractCallSite.java:139) > ~[groovy-3.0.21.jar:3.0.21] > at > org.apache.ofbiz.product.product.product.ProductServicesScript.countProductView(ProductServicesScript.groovy:373) > ~[ofbiz.jar:?] -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OFBIZ-13035) Fix cross-app menu location issues
[ https://issues.apache.org/jira/browse/OFBIZ-13035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17843194#comment-17843194 ] ASF subversion and git services commented on OFBIZ-13035: - Commit e8b6d41e29ec2052da426c786912deffaca06691 in ofbiz-framework's branch refs/heads/trunk from Jacques Le Roux [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=e8b6d41e29 ] Fixed: Fix cross-app menu location issues (OFBIZ-13035) Fixes mainMenuLocation missing in AR and AP web.xml files hence error java.lang.RuntimeException: Error rendering included menu named [MainActionMenu] at location []: java.lang.IllegalArgumentException: Could not find menu file in location [] > Fix cross-app menu location issues > -- > > Key: OFBIZ-13035 > URL: https://issues.apache.org/jira/browse/OFBIZ-13035 > Project: OFBiz > Issue Type: Sub-task > Components: ALL APPLICATIONS >Affects Versions: Upcoming Branch >Reporter: Pierre Smits >Assignee: Jacques Le Roux >Priority: Major > Fix For: Upcoming Branch > > > address cross application menu-location issues. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OFBIZ-13078) Convert ProjectServices.xml mini-lang to groovyDSL
[ https://issues.apache.org/jira/browse/OFBIZ-13078?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17843165#comment-17843165 ] ASF subversion and git services commented on OFBIZ-13078: - Commit 46fcbd31614be4b99106452c8e0118d274572bd4 in ofbiz-plugins's branch refs/heads/trunk from Nicolas Malin [ https://gitbox.apache.org/repos/asf?p=ofbiz-plugins.git;h=46fcbd316 ] Improved: Convert ProjectServices.xml mini-lang to groovyDSL (OFBIZ-13078) Convert following services : * createTimeEntryInTimesheet * updateTimeEntryByWorkEffort * getProject * createProject * updateProject * updateProjectRole * createProjectTask * copyProject * copyProjectToTemplate * scheduleProject * getProjectPhaseList * getProjectTaskList * getProjectTask * getProjectsByParties * getTasksByParties * updateTaskAndRelatedInfo * updateTaskAssigment * addProjectTimeToNewInvoice * addProjectTimeToInvoice * addValidationPartiesToTask > Convert ProjectServices.xml mini-lang to groovyDSL > -- > > Key: OFBIZ-13078 > URL: https://issues.apache.org/jira/browse/OFBIZ-13078 > Project: OFBiz > Issue Type: Sub-task > Components: projectmgr >Reporter: Nicolas Malin >Assignee: Nicolas Malin >Priority: Minor > Labels: mini-lang > > Convert the following services : > * createTimeEntryInTimesheet > * updateTimeEntryByWorkEffort > * getProject > * createProject > * updateProject > * updateProjectRole > * createProjectTask > * copyProject > * copyProjectToTemplate > * scheduleProject > * getProjectPhaseList > * getProjectTaskList > * getProjectTask > * getProjectsByParties > * getTasksByParties > * updateTaskAndRelatedInfo > * updateTaskAssigment > * addProjectTimeToNewInvoice > * addProjectTimeToInvoice > * addValidationPartiesToTask -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OFBIZ-13061) Prevents to uselessly clutter the logs up with SetTimeZoneFromBrowser errors
[ https://issues.apache.org/jira/browse/OFBIZ-13061?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17843162#comment-17843162 ] ASF subversion and git services commented on OFBIZ-13061: - Commit 04f41f90322c5972317e4760cb3cdb3e45c9d8f3 in ofbiz-framework's branch refs/heads/release18.12 from Jacques Le Roux [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=04f41f9032 ] Fixed: Prevents to uselessly clutter the logs up with SetTimeZoneFromBrowser errors (OFBIZ-13061) Fixes the name of the invoked method for the SetTimeZoneFromBrowser service to setTimeZoneFromBrowser instead of SetTimeZoneFromBrowser It has been automatically changed because of the use of Map instead of def in commmit ea54ceba47cceaec95b720995c269f2d5827125c Few trailing blanks automatically removed also > Prevents to uselessly clutter the logs up with SetTimeZoneFromBrowser errors > > > Key: OFBIZ-13061 > URL: https://issues.apache.org/jira/browse/OFBIZ-13061 > Project: OFBiz > Issue Type: Improvement > Components: framework/common >Affects Versions: Upcoming Branch >Reporter: Jacques Le Roux >Assignee: Jacques Le Roux >Priority: Trivial > Fix For: Upcoming Branch, 18.12.14 > > > Currently the demo logs, and I guess the users production logs, are cluttered > up with very common and unique SetTimeZoneFromBrowser errors. > We can easily prevent that by not returning an error from > SetTimeZoneFromBrowser.groovy, and so the never ending > bq. < message: User authorization is required for this service: > SetTimeZoneFromBrowser>> > from RequestHandler.java -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OFBIZ-13061) Prevents to uselessly clutter the logs up with SetTimeZoneFromBrowser errors
[ https://issues.apache.org/jira/browse/OFBIZ-13061?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17843016#comment-17843016 ] ASF subversion and git services commented on OFBIZ-13061: - Commit 9443359e73a97bd2562265658332e1a097e805d9 in ofbiz-framework's branch refs/heads/release18.12 from Jacques Le Roux [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=9443359e73 ] Fixed: Prevents to uselessly clutter the logs up with SetTimeZoneFromBrowser errors (OFBIZ-13061) Fixes a bug put in with last commit. -String uri = requestMap.getUri(); +String uri = requestMap.uri; Also automatically (Eclipse) removes trailing blanks > Prevents to uselessly clutter the logs up with SetTimeZoneFromBrowser errors > > > Key: OFBIZ-13061 > URL: https://issues.apache.org/jira/browse/OFBIZ-13061 > Project: OFBiz > Issue Type: Improvement > Components: framework/common >Affects Versions: Upcoming Branch >Reporter: Jacques Le Roux >Assignee: Jacques Le Roux >Priority: Trivial > Fix For: Upcoming Branch > > > Currently the demo logs, and I guess the users production logs, are cluttered > up with very common and unique SetTimeZoneFromBrowser errors. > We can easily prevent that by not returning an error from > SetTimeZoneFromBrowser.groovy, and so the never ending > bq. < message: User authorization is required for this service: > SetTimeZoneFromBrowser>> > from RequestHandler.java -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OFBIZ-13061) Prevents to uselessly clutter the logs up with SetTimeZoneFromBrowser errors
[ https://issues.apache.org/jira/browse/OFBIZ-13061?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17842990#comment-17842990 ] ASF subversion and git services commented on OFBIZ-13061: - Commit 486f2727316f659a4a659b97a3d323655f811685 in ofbiz-framework's branch refs/heads/release18.12 from Jacques Le Roux [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=486f272731 ] Fixed: Prevents to uselessly clutter the logs up with SetTimeZoneFromBrowser errors (OFBIZ-13061) The previous commit was not enough as I feared. It still shows in trunk demo error.log today. So here comes the ugly but sure fix. Conflicts handled by hand > Prevents to uselessly clutter the logs up with SetTimeZoneFromBrowser errors > > > Key: OFBIZ-13061 > URL: https://issues.apache.org/jira/browse/OFBIZ-13061 > Project: OFBiz > Issue Type: Improvement > Components: framework/common >Affects Versions: Upcoming Branch >Reporter: Jacques Le Roux >Assignee: Jacques Le Roux >Priority: Trivial > Fix For: Upcoming Branch > > > Currently the demo logs, and I guess the users production logs, are cluttered > up with very common and unique SetTimeZoneFromBrowser errors. > We can easily prevent that by not returning an error from > SetTimeZoneFromBrowser.groovy, and so the never ending > bq. < message: User authorization is required for this service: > SetTimeZoneFromBrowser>> > from RequestHandler.java -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OFBIZ-13061) Prevents to uselessly clutter the logs up with SetTimeZoneFromBrowser errors
[ https://issues.apache.org/jira/browse/OFBIZ-13061?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17842991#comment-17842991 ] ASF subversion and git services commented on OFBIZ-13061: - Commit ea54ceba47cceaec95b720995c269f2d5827125c in ofbiz-framework's branch refs/heads/release18.12 from Jacques Le Roux [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=ea54ceba47 ] Fixed: Prevents to uselessly clutter the logs up with SetTimeZoneFromBrowser errors (OFBIZ-13061) Fixes this error found in trunk demo log. SetTimeZoneFromBrowser.groovy]: (Cannot get property 'userLoginId' on null object) It happens, at least with webpos/control/SetTimeZoneFromBrowser It's just to prevents cluttering the logs. Conflicts handled by hand > Prevents to uselessly clutter the logs up with SetTimeZoneFromBrowser errors > > > Key: OFBIZ-13061 > URL: https://issues.apache.org/jira/browse/OFBIZ-13061 > Project: OFBiz > Issue Type: Improvement > Components: framework/common >Affects Versions: Upcoming Branch >Reporter: Jacques Le Roux >Assignee: Jacques Le Roux >Priority: Trivial > Fix For: Upcoming Branch > > > Currently the demo logs, and I guess the users production logs, are cluttered > up with very common and unique SetTimeZoneFromBrowser errors. > We can easily prevent that by not returning an error from > SetTimeZoneFromBrowser.groovy, and so the never ending > bq. < message: User authorization is required for this service: > SetTimeZoneFromBrowser>> > from RequestHandler.java -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OFBIZ-13061) Prevents to uselessly clutter the logs up with SetTimeZoneFromBrowser errors
[ https://issues.apache.org/jira/browse/OFBIZ-13061?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17842989#comment-17842989 ] ASF subversion and git services commented on OFBIZ-13061: - Commit 183a9a222c694c6dff53e43c6194641744d160bb in ofbiz-framework's branch refs/heads/release18.12 from Jacques Le Roux [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=183a9a222c ] Fixed: Prevents to uselessly clutter the logs up with SetTimeZoneFromBrowser errors (OFBIZ-13061) Currently the demo logs, and I guess users production logs, are cluttered up with very common and unique SetTimeZoneFromBrowser error. We can easily prevent that by not returning an error from SetTimeZoneFromBrowser.groovy, and so the never ending <> from RequestHandler.java > Prevents to uselessly clutter the logs up with SetTimeZoneFromBrowser errors > > > Key: OFBIZ-13061 > URL: https://issues.apache.org/jira/browse/OFBIZ-13061 > Project: OFBiz > Issue Type: Improvement > Components: framework/common >Affects Versions: Upcoming Branch >Reporter: Jacques Le Roux >Assignee: Jacques Le Roux >Priority: Trivial > Fix For: Upcoming Branch > > > Currently the demo logs, and I guess the users production logs, are cluttered > up with very common and unique SetTimeZoneFromBrowser errors. > We can easily prevent that by not returning an error from > SetTimeZoneFromBrowser.groovy, and so the never ending > bq. < message: User authorization is required for this service: > SetTimeZoneFromBrowser>> > from RequestHandler.java -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OFBIZ-13061) Prevents to uselessly clutter the logs up with SetTimeZoneFromBrowser errors
[ https://issues.apache.org/jira/browse/OFBIZ-13061?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17842926#comment-17842926 ] ASF subversion and git services commented on OFBIZ-13061: - Commit 3d0a1331e8ae75ae42f154df28c249721d481de3 in ofbiz-framework's branch refs/heads/trunk from Jacques Le Roux [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=3d0a1331e8 ] Fixed: Prevents to uselessly clutter the logs up with SetTimeZoneFromBrowser errors (OFBIZ-13061) Fixes this error found in trunk demo log. SetTimeZoneFromBrowser.groovy]: (Cannot get property 'userLoginId' on null object) It happens, at least with webpos/control/SetTimeZoneFromBrowser It's just to prevents cluttering the logs. > Prevents to uselessly clutter the logs up with SetTimeZoneFromBrowser errors > > > Key: OFBIZ-13061 > URL: https://issues.apache.org/jira/browse/OFBIZ-13061 > Project: OFBiz > Issue Type: Improvement > Components: framework/common >Affects Versions: Upcoming Branch >Reporter: Jacques Le Roux >Assignee: Jacques Le Roux >Priority: Trivial > Fix For: Upcoming Branch > > > Currently the demo logs, and I guess the users production logs, are cluttered > up with very common and unique SetTimeZoneFromBrowser errors. > We can easily prevent that by not returning an error from > SetTimeZoneFromBrowser.groovy, and so the never ending > bq. < message: User authorization is required for this service: > SetTimeZoneFromBrowser>> > from RequestHandler.java -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OFBIZ-13072) Issue when caching a query with a selectField
[ https://issues.apache.org/jira/browse/OFBIZ-13072?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17842866#comment-17842866 ] ASF subversion and git services commented on OFBIZ-13072: - Commit 0748e67e5eee689425bcb08f73024d659b7007a2 in ofbiz-framework's branch refs/heads/trunk from Mekika Leila [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=0748e67e5e ] Fixed: Issue when caching a query with a selectField (OFBIZ-13072) (#787) When a query with a field selection and a cache() option is done, the result is put in cache with the incomplete genericValue (I mean without all the fields). Then when an other query with the same condition and cache option is done, even whitout the field selection, the result returned is the incomplete version of the GenericValue that has been stored in cache. This prevent from adding in cache an incomplete genericValue and filter the cached value when necessary > Issue when caching a query with a selectField > - > > Key: OFBIZ-13072 > URL: https://issues.apache.org/jira/browse/OFBIZ-13072 > Project: OFBiz > Issue Type: Bug > Components: framework >Affects Versions: Upcoming Branch >Reporter: Mekika Leila >Priority: Minor > > When a query with a field selection and a cache() option is done, the result > is put in cache with the incomplete genericValue (I mean without all the > fields). > Then when an other query with the same condition and cache option is done, > even whitout the field selection, the result returned is the incomplete > version of the GenericValue that has been stored in cache. > The code in the PR prevent from adding in cache an incomplete genericValue > and filter the cached value when necessary > *To test:* > testCache has been added to entity-query-tests test case. It can be launched > with > ./gradlew 'ofbiz -t component=entity' > or > ./gradlew 'ofbiz -t component=entity -t suitename=entitytests -t > case=entity-query-tests' -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OFBIZ-13071) Could not find PortalPage with portalPageId []
[
https://issues.apache.org/jira/browse/OFBIZ-13071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17842652#comment-17842652
]
ASF subversion and git services commented on OFBIZ-13071:
-
Commit 9ec6a618bc4dfac5fc2b7031d6c7805a4900b775 in ofbiz-framework's branch
refs/heads/release18.12 from Jacques Le Roux
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=9ec6a618bc ]
Fixed: Could not find PortalPage with portalPageId [] (OFBIZ-13071)
Fixes a bug put in during backporting. MODULE is not used in this class module
is
> Could not find PortalPage with portalPageId []
> ---
>
> Key: OFBIZ-13071
> URL: https://issues.apache.org/jira/browse/OFBIZ-13071
> Project: OFBiz
> Issue Type: Bug
> Components: sfa
>Affects Versions: 18.12.12
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Major
> Fix For: 18.12.13
>
>
> This is a weird behaviour. Yet it's not really a bug but something that
> spider bots do. They get to ListTimezones while not being signed in (hard for
> spider bot). Here are 2 cases:
> {noformat}
> 18.224.149.242 - - [26/Apr/2024:03:20:05 +] "GET
> /sfa/control/setSessionTimeZone?tzId=Australia/Melbourne HTTP/1.1" 200 42716
> "-" "Mozilla/5.0 AppleWebKit/537.36 (KHTML, like Gecko; compatible;
> ClaudeBot/1.0; +claude...@anthropic.com)"
> 2024-04-26 03:20:05,254 |-0.0.0.0-8009-exec-4 |ModelScreenWidget
> |E| Could not find PortalPage with portalPageId []
> 3.144.172.115 - - [26/Apr/2024:03:32:22 +] "GET
> /sfa/control/setSessionTimeZone?tzId=Asia/Kuwait HTTP/1.1" 200 42716 "-"
> "Mozilla/5.0 AppleWebKit/537.36 (KHTML, like Gecko; compatible;
> ClaudeBot/1.0; +claude...@anthropic.com)"
> 2024-04-26 03:32:22,395 |-0.0.0.0-8009-exec-7 |ModelScreenWidget
> |E| Could not find PortalPage with portalPageId []
> {noformat}
> It happens only for SFA. [All the others| https://s.apache.org/gwyw2 ] are
> not concerned
> Why only SFA is concerned is unclear but not really a problem. Because once
> signed in the problem dissapears. The only problem is that if a spider bot
> gets to your production server it will clutter the log. There is 636 possible
> hours...
> Now that I know the reason, I'll try to find a workaround.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (OFBIZ-13061) Prevents to uselessly clutter the logs up with SetTimeZoneFromBrowser errors
[ https://issues.apache.org/jira/browse/OFBIZ-13061?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17842646#comment-17842646 ] ASF subversion and git services commented on OFBIZ-13061: - Commit 9869bed35a9851d5574fd7df395f56c36713e84b in ofbiz-framework's branch refs/heads/release18.12 from Jacques Le Roux [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=9869bed35a ] Revert "Fixed: Prevents to uselessly clutter the logs up with SetTimeZoneFromBrowser errors (OFBIZ-13061)" This reverts commit 135d137a2483f94fe8e95fcdb39a18f1c0b95963. This change should not have been backported > Prevents to uselessly clutter the logs up with SetTimeZoneFromBrowser errors > > > Key: OFBIZ-13061 > URL: https://issues.apache.org/jira/browse/OFBIZ-13061 > Project: OFBiz > Issue Type: Improvement > Components: framework/common >Affects Versions: Upcoming Branch >Reporter: Jacques Le Roux >Assignee: Jacques Le Roux >Priority: Trivial > Fix For: Upcoming Branch > > > Currently the demo logs, and I guess the users production logs, are cluttered > up with very common and unique SetTimeZoneFromBrowser errors. > We can easily prevent that by not returning an error from > SetTimeZoneFromBrowser.groovy, and so the never ending > bq. < message: User authorization is required for this service: > SetTimeZoneFromBrowser>> > from RequestHandler.java -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OFBIZ-9804) Link in verification email for Newsletter gives security error
[
https://issues.apache.org/jira/browse/OFBIZ-9804?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17842644#comment-17842644
]
ASF subversion and git services commented on OFBIZ-9804:
Commit 48534da103151f9858120e1438743bd5ed8516d1 in ofbiz-plugins's branch
refs/heads/trunk from Jacques Le Roux
[ https://gitbox.apache.org/repos/asf?p=ofbiz-plugins.git;h=48534da10 ]
Fixed: Link in verification email for Newsletter gives security error
(OFBIZ-9804)
It's a bit abused to reuse this Jira issue but as it's a really trivial fix...
> Link in verification email for Newsletter gives security error
> --
>
> Key: OFBIZ-9804
> URL: https://issues.apache.org/jira/browse/OFBIZ-9804
> Project: OFBiz
> Issue Type: Sub-task
> Components: ecommerce
>Affects Versions: Release Branch 16.11, Trunk
>Reporter: Aditya Sharma
>Assignee: Jacques Le Roux
>Priority: Major
> Fix For: 17.12.01, 18.12.01
>
> Attachments: screenshot-1.png
>
>
> Steps to generate:
> 1. Go to Ecommerce store https://localhost:8443/ecommerce/control/main
> 2. In "Sign Up For Contact List" panel from the left menu, select Newsletter,
> provide email and click on subscribe button.(Here you should have email
> configuration to receive email)
> 3. Click on the verification link in the email.
> It gives following error message
> {quote}The Following Errors Occurred:
> Error calling event: org.apache.ofbiz.webapp.event.EventHandlerException:
> Found URL parameter [contactListId] passed to secure (https) request-map with
> uri [updateContactListPartyNoUserLogin] with an event that calls service
> [updateContactListPartyNoUserLogin]; this is not allowed for security
> reasons! The data should be encrypted by making it part of the request body
> (a form field) instead of the request URL. Moreover it would be kind if you
> could create a Jira sub-task of
> https://issues.apache.org/jira/browse/OFBIZ-2330 (check before if a sub-task
> for this error does not exist). If you are not sure how to create a Jira
> issue please have a look before at
> https://cwiki.apache.org/confluence/display/OFBIZ/OFBiz+Contributors+Best+Practices
> Thank you in advance for your help.{quote}
> Try with the trunk link:
> https://demo-trunk.ofbiz.apache.org/ecommerce/control/updateContactListPartyNoUserLogin?contactListId=9000=_NA_=2017-10-04%2010:48:46.531=CLPT_ACCEPTED=9084207171=/ecommerce=10010
> Stable 16 link:
> https://demo-stable.ofbiz.apache.org/ecommerce/control/updateContactListPartyNoUserLogin?contactListId=9000=_NA_=2017-10-04%2010:48:46.531=CLPT_ACCEPTED=9084207171=/ecommerce=10010
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (OFBIZ-9804) Link in verification email for Newsletter gives security error
[
https://issues.apache.org/jira/browse/OFBIZ-9804?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17842643#comment-17842643
]
ASF subversion and git services commented on OFBIZ-9804:
Commit 2b08b865bce25cde5d55d1762d89c96bcaa92e95 in ofbiz-plugins's branch
refs/heads/release18.12 from Jacques Le Roux
[ https://gitbox.apache.org/repos/asf?p=ofbiz-plugins.git;h=2b08b865b ]
Fixed: Link in verification email for Newsletter gives security error
(OFBIZ-9804)
It's a bit abused to reuse this Jira issue but as it's a really trivial fix...
> Link in verification email for Newsletter gives security error
> --
>
> Key: OFBIZ-9804
> URL: https://issues.apache.org/jira/browse/OFBIZ-9804
> Project: OFBiz
> Issue Type: Sub-task
> Components: ecommerce
>Affects Versions: Release Branch 16.11, Trunk
>Reporter: Aditya Sharma
>Assignee: Jacques Le Roux
>Priority: Major
> Fix For: 17.12.01, 18.12.01
>
> Attachments: screenshot-1.png
>
>
> Steps to generate:
> 1. Go to Ecommerce store https://localhost:8443/ecommerce/control/main
> 2. In "Sign Up For Contact List" panel from the left menu, select Newsletter,
> provide email and click on subscribe button.(Here you should have email
> configuration to receive email)
> 3. Click on the verification link in the email.
> It gives following error message
> {quote}The Following Errors Occurred:
> Error calling event: org.apache.ofbiz.webapp.event.EventHandlerException:
> Found URL parameter [contactListId] passed to secure (https) request-map with
> uri [updateContactListPartyNoUserLogin] with an event that calls service
> [updateContactListPartyNoUserLogin]; this is not allowed for security
> reasons! The data should be encrypted by making it part of the request body
> (a form field) instead of the request URL. Moreover it would be kind if you
> could create a Jira sub-task of
> https://issues.apache.org/jira/browse/OFBIZ-2330 (check before if a sub-task
> for this error does not exist). If you are not sure how to create a Jira
> issue please have a look before at
> https://cwiki.apache.org/confluence/display/OFBIZ/OFBiz+Contributors+Best+Practices
> Thank you in advance for your help.{quote}
> Try with the trunk link:
> https://demo-trunk.ofbiz.apache.org/ecommerce/control/updateContactListPartyNoUserLogin?contactListId=9000=_NA_=2017-10-04%2010:48:46.531=CLPT_ACCEPTED=9084207171=/ecommerce=10010
> Stable 16 link:
> https://demo-stable.ofbiz.apache.org/ecommerce/control/updateContactListPartyNoUserLogin?contactListId=9000=_NA_=2017-10-04%2010:48:46.531=CLPT_ACCEPTED=9084207171=/ecommerce=10010
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (OFBIZ-13061) Prevents to uselessly clutter the logs up with SetTimeZoneFromBrowser errors
[ https://issues.apache.org/jira/browse/OFBIZ-13061?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17842637#comment-17842637 ] ASF subversion and git services commented on OFBIZ-13061: - Commit 650284168de5976a502fa5e7af8a4685ded50ce9 in ofbiz-framework's branch refs/heads/trunk from Jacques Le Roux [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=650284168d ] Fixed: Prevents to uselessly clutter the logs up with SetTimeZoneFromBrowser errors (OFBIZ-13061) The previous commits were not enough as I feared. This time we should not see useless "error" information while running services. > Prevents to uselessly clutter the logs up with SetTimeZoneFromBrowser errors > > > Key: OFBIZ-13061 > URL: https://issues.apache.org/jira/browse/OFBIZ-13061 > Project: OFBiz > Issue Type: Improvement > Components: framework/common >Affects Versions: Upcoming Branch >Reporter: Jacques Le Roux >Assignee: Jacques Le Roux >Priority: Trivial > Fix For: Upcoming Branch > > > Currently the demo logs, and I guess the users production logs, are cluttered > up with very common and unique SetTimeZoneFromBrowser errors. > We can easily prevent that by not returning an error from > SetTimeZoneFromBrowser.groovy, and so the never ending > bq. < message: User authorization is required for this service: > SetTimeZoneFromBrowser>> > from RequestHandler.java -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OFBIZ-13061) Prevents to uselessly clutter the logs up with SetTimeZoneFromBrowser errors
[ https://issues.apache.org/jira/browse/OFBIZ-13061?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17842636#comment-17842636 ] ASF subversion and git services commented on OFBIZ-13061: - Commit 135d137a2483f94fe8e95fcdb39a18f1c0b95963 in ofbiz-framework's branch refs/heads/release18.12 from Jacques Le Roux [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=135d137a24 ] Fixed: Prevents to uselessly clutter the logs up with SetTimeZoneFromBrowser errors (OFBIZ-13061) The previous commits were not enough as I feared. This time we should not see useless "error" information while running services. Conflicts hanled by hands > Prevents to uselessly clutter the logs up with SetTimeZoneFromBrowser errors > > > Key: OFBIZ-13061 > URL: https://issues.apache.org/jira/browse/OFBIZ-13061 > Project: OFBiz > Issue Type: Improvement > Components: framework/common >Affects Versions: Upcoming Branch >Reporter: Jacques Le Roux >Assignee: Jacques Le Roux >Priority: Trivial > Fix For: Upcoming Branch > > > Currently the demo logs, and I guess the users production logs, are cluttered > up with very common and unique SetTimeZoneFromBrowser errors. > We can easily prevent that by not returning an error from > SetTimeZoneFromBrowser.groovy, and so the never ending > bq. < message: User authorization is required for this service: > SetTimeZoneFromBrowser>> > from RequestHandler.java -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OFBIZ-13071) Could not find PortalPage with portalPageId []
[
https://issues.apache.org/jira/browse/OFBIZ-13071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17842571#comment-17842571
]
ASF subversion and git services commented on OFBIZ-13071:
-
Commit 4fcccdb8208c9130c07bb16d8f3c63d7c2a6d26e in ofbiz-framework's branch
refs/heads/release18.12 from Jacques Le Roux
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=4fcccdb820 ]
Improved: Could not find PortalPage with portalPageId [] (OFBIZ-13071)
No need to try to render a PortalPage when there is no PortalPage
Conflicts handled by hand in ModelScreenWidget.java
> Could not find PortalPage with portalPageId []
> ---
>
> Key: OFBIZ-13071
> URL: https://issues.apache.org/jira/browse/OFBIZ-13071
> Project: OFBiz
> Issue Type: Bug
> Components: sfa
>Affects Versions: 18.12.12
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Major
> Fix For: 18.12.13
>
>
> This is a weird behaviour. Yet it's not really a bug but something that
> spider bots do. They get to ListTimezones while not being signed in (hard for
> spider bot). Here are 2 cases:
> {noformat}
> 18.224.149.242 - - [26/Apr/2024:03:20:05 +] "GET
> /sfa/control/setSessionTimeZone?tzId=Australia/Melbourne HTTP/1.1" 200 42716
> "-" "Mozilla/5.0 AppleWebKit/537.36 (KHTML, like Gecko; compatible;
> ClaudeBot/1.0; +claude...@anthropic.com)"
> 2024-04-26 03:20:05,254 |-0.0.0.0-8009-exec-4 |ModelScreenWidget
> |E| Could not find PortalPage with portalPageId []
> 3.144.172.115 - - [26/Apr/2024:03:32:22 +] "GET
> /sfa/control/setSessionTimeZone?tzId=Asia/Kuwait HTTP/1.1" 200 42716 "-"
> "Mozilla/5.0 AppleWebKit/537.36 (KHTML, like Gecko; compatible;
> ClaudeBot/1.0; +claude...@anthropic.com)"
> 2024-04-26 03:32:22,395 |-0.0.0.0-8009-exec-7 |ModelScreenWidget
> |E| Could not find PortalPage with portalPageId []
> {noformat}
> It happens only for SFA. [All the others| https://s.apache.org/gwyw2 ] are
> not concerned
> Why only SFA is concerned is unclear but not really a problem. Because once
> signed in the problem dissapears. The only problem is that if a spider bot
> gets to your production server it will clutter the log. There is 636 possible
> hours...
> Now that I know the reason, I'll try to find a workaround.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (OFBIZ-13071) Could not find PortalPage with portalPageId []
[
https://issues.apache.org/jira/browse/OFBIZ-13071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17842572#comment-17842572
]
ASF subversion and git services commented on OFBIZ-13071:
-
Commit 03291be883cb72315f1e93384ee4013392bc09c5 in ofbiz-framework's branch
refs/heads/trunk from Jacques Le Roux
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=03291be883 ]
Improved: Could not find PortalPage with portalPageId [] (OFBIZ-13071)
No need to try to render a PortalPage when there is no PortalPage
> Could not find PortalPage with portalPageId []
> ---
>
> Key: OFBIZ-13071
> URL: https://issues.apache.org/jira/browse/OFBIZ-13071
> Project: OFBiz
> Issue Type: Bug
> Components: sfa
>Affects Versions: 18.12.12
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Major
> Fix For: 18.12.13
>
>
> This is a weird behaviour. Yet it's not really a bug but something that
> spider bots do. They get to ListTimezones while not being signed in (hard for
> spider bot). Here are 2 cases:
> {noformat}
> 18.224.149.242 - - [26/Apr/2024:03:20:05 +] "GET
> /sfa/control/setSessionTimeZone?tzId=Australia/Melbourne HTTP/1.1" 200 42716
> "-" "Mozilla/5.0 AppleWebKit/537.36 (KHTML, like Gecko; compatible;
> ClaudeBot/1.0; +claude...@anthropic.com)"
> 2024-04-26 03:20:05,254 |-0.0.0.0-8009-exec-4 |ModelScreenWidget
> |E| Could not find PortalPage with portalPageId []
> 3.144.172.115 - - [26/Apr/2024:03:32:22 +] "GET
> /sfa/control/setSessionTimeZone?tzId=Asia/Kuwait HTTP/1.1" 200 42716 "-"
> "Mozilla/5.0 AppleWebKit/537.36 (KHTML, like Gecko; compatible;
> ClaudeBot/1.0; +claude...@anthropic.com)"
> 2024-04-26 03:32:22,395 |-0.0.0.0-8009-exec-7 |ModelScreenWidget
> |E| Could not find PortalPage with portalPageId []
> {noformat}
> It happens only for SFA. [All the others| https://s.apache.org/gwyw2 ] are
> not concerned
> Why only SFA is concerned is unclear but not really a problem. Because once
> signed in the problem dissapears. The only problem is that if a spider bot
> gets to your production server it will clutter the log. There is 636 possible
> hours...
> Now that I know the reason, I'll try to find a workaround.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (OFBIZ-13075) ${parameters.SEARCH_STRING} Failed in TagSearch.ftl[at line 20]
[
https://issues.apache.org/jira/browse/OFBIZ-13075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17842436#comment-17842436
]
ASF subversion and git services commented on OFBIZ-13075:
-
Commit 01a3277d7882e5c4c033ef5048d1bfe0405745b5 in ofbiz-framework's branch
refs/heads/trunk from Jacques Le Roux
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=01a3277d78 ]
Fixed: ${parameters.SEARCH_STRING} Failed in TagSearch.ftl[at line 20]
(OFBIZ-13075)
The error appears when no products have been tagged (did not check how the
products are tagged )
> ${parameters.SEARCH_STRING} Failed in TagSearch.ftl[at line 20]
>
>
> Key: OFBIZ-13075
> URL: https://issues.apache.org/jira/browse/OFBIZ-13075
> Project: OFBiz
> Issue Type: Bug
> Components: ecommerce
>Affects Versions: 18.12.14
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Trivial
> Fix For: 18.12.14
>
>
> Here is the error in log:
>
> 2024-04-30 15:28:23,692 |-0.0.0.0-8009-exec-8 |FreeMarkerWorker
> |E| null
> freemarker.core.InvalidReferenceException: The following has evaluated to
> null or missing:
> ==> parameters.SEARCH_STRING [in template
> "component://order/template/entry/catalog/TagSearch.ftl" at line 20, column
> 47]
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (OFBIZ-13075) ${parameters.SEARCH_STRING} Failed in TagSearch.ftl[at line 20]
[
https://issues.apache.org/jira/browse/OFBIZ-13075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17842435#comment-17842435
]
ASF subversion and git services commented on OFBIZ-13075:
-
Commit 25f5692d10ffc47ad34168708490e651822dda8c in ofbiz-framework's branch
refs/heads/release18.12 from Jacques Le Roux
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=25f5692d10 ]
Fixed: ${parameters.SEARCH_STRING} Failed in TagSearch.ftl[at line 20]
(OFBIZ-13075)
The error appears when no products have been tagged (did not check how the
products are tagged )
> ${parameters.SEARCH_STRING} Failed in TagSearch.ftl[at line 20]
>
>
> Key: OFBIZ-13075
> URL: https://issues.apache.org/jira/browse/OFBIZ-13075
> Project: OFBiz
> Issue Type: Bug
> Components: ecommerce
>Affects Versions: 18.12.14
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Trivial
> Fix For: 18.12.14
>
>
> Here is the error in log:
>
> 2024-04-30 15:28:23,692 |-0.0.0.0-8009-exec-8 |FreeMarkerWorker
> |E| null
> freemarker.core.InvalidReferenceException: The following has evaluated to
> null or missing:
> ==> parameters.SEARCH_STRING [in template
> "component://order/template/entry/catalog/TagSearch.ftl" at line 20, column
> 47]
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (OFBIZ-869) French translation for Accounting module
[ https://issues.apache.org/jira/browse/OFBIZ-869?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17841606#comment-17841606 ] ASF subversion and git services commented on OFBIZ-869: --- Commit bb325bdd106feb59520f06615b4e43d47ab1f4d8 in ofbiz-framework's branch refs/heads/trunk from Jacques Le Roux [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=bb325bdd10 ] Improved: French translation for Accounting module (OFBIZ-869) Replaces "Montant à enregistrer" by "Solde dû" > French translation for Accounting module > > > Key: OFBIZ-869 > URL: https://issues.apache.org/jira/browse/OFBIZ-869 > Project: OFBiz > Issue Type: Improvement > Components: accounting >Affects Versions: Trunk >Reporter: Eric Jacolin >Assignee: Jacques Le Roux >Priority: Minor > Fix For: Trunk > > Attachments: AccountingEntityLabels_fr.properties, > AccountingUiLabels_fr.properties > > > French translation for Accounting module -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OFBIZ-13073) Use new Tomcat 9 maxDays Access_Log_Valve Attribute
[ https://issues.apache.org/jira/browse/OFBIZ-13073?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17841589#comment-17841589 ] ASF subversion and git services commented on OFBIZ-13073: - Commit b6e87fcfb4649b189f960ed7661eb57dedf65a29 in ofbiz-framework's branch refs/heads/trunk from Jacques Le Roux [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=b6e87fcfb4 ] Improved: Use new Tomcat 9 maxDays Access_Log_Valve Attribute (OFBIZ-13073) https://tomcat.apache.org/tomcat-9.0-doc/config/valve.html#Access_Log_Valve > Use new Tomcat 9 maxDays Access_Log_Valve Attribute > --- > > Key: OFBIZ-13073 > URL: https://issues.apache.org/jira/browse/OFBIZ-13073 > Project: OFBiz > Issue Type: Improvement > Components: tomcat >Affects Versions: Upcoming Branch, 18.12.12 >Reporter: Jacques Le Roux >Assignee: Jacques Le Roux >Priority: Minor > Fix For: 18.12.13 > > > https://tomcat.apache.org/tomcat-9.0-doc/config/valve.html#Access_Log_Valve -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OFBIZ-13059) Old error in showPortalPage screen
[ https://issues.apache.org/jira/browse/OFBIZ-13059?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17841584#comment-17841584 ] ASF subversion and git services commented on OFBIZ-13059: - Commit 97564381288f0e6995b40fce01539d4083fea473 in ofbiz-framework's branch refs/heads/release18.12 from Jacques Le Roux [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=9756438128 ] Fixed: Old error in showPortalPage screen (OFBIZ-13059) There is no place where showPortalPage is used where parameters.confMode and parameters.usePrivate have values, no need to keep this commented out. > Old error in showPortalPage screen > -- > > Key: OFBIZ-13059 > URL: https://issues.apache.org/jira/browse/OFBIZ-13059 > Project: OFBiz > Issue Type: Bug > Components: framework/common >Affects Versions: Upcoming Branch, 18.12.12 >Reporter: Jacques Le Roux >Assignee: Jacques Le Roux >Priority: Minor > Fix For: 18.12.13 > > > I spotted this error in demo stable and trunk error.log. It's due to an old > commit: https://svn.apache.org/repos/asf/ofbiz/trunk@1023286 > I tried a bit to understand what's the problem was but as it's a 13,5 years > old bug I eventually decided to simply remove the wrong parts. I'll not > backport. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OFBIZ-12897) Rework the log4j2.xml configuration to limit the number of log files generated
[ https://issues.apache.org/jira/browse/OFBIZ-12897?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17841585#comment-17841585 ] ASF subversion and git services commented on OFBIZ-12897: - Commit f3a07162d4a3327287085dc235facc612b46e7ec in ofbiz-framework's branch refs/heads/release18.12 from Jacques Le Roux [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=f3a07162d4 ] Improved: Rework the log4j2.xml configuration to limit the number of log files generated (OFBIZ-12897) Changes the log4j2 config to allow 30 rollover ofbiz and 10 error log files. We have enough space and it's the same for any OFBIz user now. >From my experience that can be useful to have a such backup sometimes. > Rework the log4j2.xml configuration to limit the number of log files generated > -- > > Key: OFBIZ-12897 > URL: https://issues.apache.org/jira/browse/OFBIZ-12897 > Project: OFBiz > Issue Type: Task > Components: framework >Affects Versions: Upcoming Branch, 18.12.11 >Reporter: Daniel Watford >Assignee: Daniel Watford >Priority: Minor > > File lo4j2.xml configure log file rolling, but it does not appear to function > as perhaps intended. > Log file rolling is configured to keep up to 10 log files. But the log file > naming convention appears to cause a maximum of 10 logs files to be kept for > each day. > Rework the log4j2.xml configuration file to ensure that only 10 log files are > kept (for each appender) regardless of the date. > Also, a limit of 1MB is quite small these days, particularly as text editors > can easily search through larger files without a noticeable performance > penalty (YMMV). I recommend raising the log file size limit to 10MB as this > would keep more log entries around without a corresponding increase in the > number of file. > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OFBIZ-13073) Use new Tomcat 9 maxDays Access_Log_Valve Attribute
[ https://issues.apache.org/jira/browse/OFBIZ-13073?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17841586#comment-17841586 ] ASF subversion and git services commented on OFBIZ-13073: - Commit 2f4d1acdb93c274eb94ead7890b64dd383cb3dad in ofbiz-framework's branch refs/heads/release18.12 from Jacques Le Roux [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=2f4d1acdb9 ] Improved: Use new Tomcat 9 maxDays Access_Log_Valve Attribute (OFBIZ-13073) https://tomcat.apache.org/tomcat-9.0-doc/config/valve.html#Access_Log_Valve Conflict handled by hand framework/catalina/ofbiz-component.xml > Use new Tomcat 9 maxDays Access_Log_Valve Attribute > --- > > Key: OFBIZ-13073 > URL: https://issues.apache.org/jira/browse/OFBIZ-13073 > Project: OFBiz > Issue Type: Improvement > Components: tomcat >Affects Versions: Upcoming Branch, 18.12.12 >Reporter: Jacques Le Roux >Assignee: Jacques Le Roux >Priority: Minor > Fix For: 18.12.13 > > > https://tomcat.apache.org/tomcat-9.0-doc/config/valve.html#Access_Log_Valve -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OFBIZ-13059) Old error in showPortalPage screen
[ https://issues.apache.org/jira/browse/OFBIZ-13059?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17841587#comment-17841587 ] ASF subversion and git services commented on OFBIZ-13059: - Commit 8a3ba28e5a8e287c5f0fc5c0bcdc544c211e89e0 in ofbiz-framework's branch refs/heads/trunk from Jacques Le Roux [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=8a3ba28e5a ] Fixed: Old error in showPortalPage screen (OFBIZ-13059) There is no place where showPortalPage is used where parameters.confMode and parameters.usePrivate have values, no need to keep this commented out. > Old error in showPortalPage screen > -- > > Key: OFBIZ-13059 > URL: https://issues.apache.org/jira/browse/OFBIZ-13059 > Project: OFBiz > Issue Type: Bug > Components: framework/common >Affects Versions: Upcoming Branch, 18.12.12 >Reporter: Jacques Le Roux >Assignee: Jacques Le Roux >Priority: Minor > Fix For: 18.12.13 > > > I spotted this error in demo stable and trunk error.log. It's due to an old > commit: https://svn.apache.org/repos/asf/ofbiz/trunk@1023286 > I tried a bit to understand what's the problem was but as it's a 13,5 years > old bug I eventually decided to simply remove the wrong parts. I'll not > backport. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OFBIZ-13071) Could not find PortalPage with portalPageId []
[
https://issues.apache.org/jira/browse/OFBIZ-13071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17841583#comment-17841583
]
ASF subversion and git services commented on OFBIZ-13071:
-
Commit 146a20a0f109160e700f74a668c395523f1e1abe in ofbiz-framework's branch
refs/heads/release18.12 from Jacques Le Roux
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=146a20a0f1 ]
Improved: Could not find PortalPage with portalPageId [] (OFBIZ-13071)
When a spider bot gets to certain non-sense URIs under sfa app (it seems only
for sfa, did not dig further it's non-sense anyway) like discovered in
trunk demo log today: <>
the <> error shows
Then we don't need to clutter the log with useless error information.
This keeps it ASAP by simply returning the portalPage if it's null.
Conflict handled by hand ModelScreenWidget.java
> Could not find PortalPage with portalPageId []
> ---
>
> Key: OFBIZ-13071
> URL: https://issues.apache.org/jira/browse/OFBIZ-13071
> Project: OFBiz
> Issue Type: Bug
> Components: sfa
>Affects Versions: 18.12.12
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Major
> Fix For: 18.12.13
>
>
> This is a weird behaviour. Yet it's not really a bug but something that
> spider bots do. They get to ListTimezones while not being signed in (hard for
> spider bot). Here are 2 cases:
> {noformat}
> 18.224.149.242 - - [26/Apr/2024:03:20:05 +] "GET
> /sfa/control/setSessionTimeZone?tzId=Australia/Melbourne HTTP/1.1" 200 42716
> "-" "Mozilla/5.0 AppleWebKit/537.36 (KHTML, like Gecko; compatible;
> ClaudeBot/1.0; +claude...@anthropic.com)"
> 2024-04-26 03:20:05,254 |-0.0.0.0-8009-exec-4 |ModelScreenWidget
> |E| Could not find PortalPage with portalPageId []
> 3.144.172.115 - - [26/Apr/2024:03:32:22 +] "GET
> /sfa/control/setSessionTimeZone?tzId=Asia/Kuwait HTTP/1.1" 200 42716 "-"
> "Mozilla/5.0 AppleWebKit/537.36 (KHTML, like Gecko; compatible;
> ClaudeBot/1.0; +claude...@anthropic.com)"
> 2024-04-26 03:32:22,395 |-0.0.0.0-8009-exec-7 |ModelScreenWidget
> |E| Could not find PortalPage with portalPageId []
> {noformat}
> It happens only for SFA. [All the others| https://s.apache.org/gwyw2 ] are
> not concerned
> Why only SFA is concerned is unclear but not really a problem. Because once
> signed in the problem dissapears. The only problem is that if a spider bot
> gets to your production server it will clutter the log. There is 636 possible
> hours...
> Now that I know the reason, I'll try to find a workaround.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (OFBIZ-12897) Rework the log4j2.xml configuration to limit the number of log files generated
[ https://issues.apache.org/jira/browse/OFBIZ-12897?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17841588#comment-17841588 ] ASF subversion and git services commented on OFBIZ-12897: - Commit 57acd94478ccceb0477596f911ccb583360d9074 in ofbiz-framework's branch refs/heads/trunk from Jacques Le Roux [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=57acd94478 ] Improved: Rework the log4j2.xml configuration to limit the number of log files generated (OFBIZ-12897) Changes the log4j2 config to allow 30 rollover ofbiz and 10 error log files. We have enough space and it's the same for any OFBIz user now. >From my experience that can be useful to have a such backup sometimes. > Rework the log4j2.xml configuration to limit the number of log files generated > -- > > Key: OFBIZ-12897 > URL: https://issues.apache.org/jira/browse/OFBIZ-12897 > Project: OFBiz > Issue Type: Task > Components: framework >Affects Versions: Upcoming Branch, 18.12.11 >Reporter: Daniel Watford >Assignee: Daniel Watford >Priority: Minor > > File lo4j2.xml configure log file rolling, but it does not appear to function > as perhaps intended. > Log file rolling is configured to keep up to 10 log files. But the log file > naming convention appears to cause a maximum of 10 logs files to be kept for > each day. > Rework the log4j2.xml configuration file to ensure that only 10 log files are > kept (for each appender) regardless of the date. > Also, a limit of 1MB is quite small these days, particularly as text editors > can easily search through larger files without a noticeable performance > penalty (YMMV). I recommend raising the log file size limit to 10MB as this > would keep more log entries around without a corresponding increase in the > number of file. > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OFBIZ-13071) Could not find PortalPage with portalPageId []
[
https://issues.apache.org/jira/browse/OFBIZ-13071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17841516#comment-17841516
]
ASF subversion and git services commented on OFBIZ-13071:
-
Commit bc92ac06fab17186ca63b6e96adcf5037e87f796 in ofbiz-framework's branch
refs/heads/trunk from Jacques Le Roux
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=bc92ac06fa ]
Improved: Could not find PortalPage with portalPageId [] (OFBIZ-13071)
When a spider bot gets to certain non-sense URIs under sfa app (it seems only
for sfa, did not dig further it's non-sense anyway) like discovered in
trunk demo log today: <>
the <> error shows
Then we don't need to clutter the log with useless error information.
This keeps it ASAP by simply returning the portalPage if it's null.
> Could not find PortalPage with portalPageId []
> ---
>
> Key: OFBIZ-13071
> URL: https://issues.apache.org/jira/browse/OFBIZ-13071
> Project: OFBiz
> Issue Type: Bug
> Components: sfa
>Affects Versions: 18.12.12
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Major
> Fix For: 18.12.13
>
>
> This is a weird behaviour. Yet it's not really a bug but something that
> spider bots do. They get to ListTimezones while not being signed in (hard for
> spider bot). Here are 2 cases:
> {noformat}
> 18.224.149.242 - - [26/Apr/2024:03:20:05 +] "GET
> /sfa/control/setSessionTimeZone?tzId=Australia/Melbourne HTTP/1.1" 200 42716
> "-" "Mozilla/5.0 AppleWebKit/537.36 (KHTML, like Gecko; compatible;
> ClaudeBot/1.0; +claude...@anthropic.com)"
> 2024-04-26 03:20:05,254 |-0.0.0.0-8009-exec-4 |ModelScreenWidget
> |E| Could not find PortalPage with portalPageId []
> 3.144.172.115 - - [26/Apr/2024:03:32:22 +] "GET
> /sfa/control/setSessionTimeZone?tzId=Asia/Kuwait HTTP/1.1" 200 42716 "-"
> "Mozilla/5.0 AppleWebKit/537.36 (KHTML, like Gecko; compatible;
> ClaudeBot/1.0; +claude...@anthropic.com)"
> 2024-04-26 03:32:22,395 |-0.0.0.0-8009-exec-7 |ModelScreenWidget
> |E| Could not find PortalPage with portalPageId []
> {noformat}
> It happens only for SFA. [All the others| https://s.apache.org/gwyw2 ] are
> not concerned
> Why only SFA is concerned is unclear but not really a problem. Because once
> signed in the problem dissapears. The only problem is that if a spider bot
> gets to your production server it will clutter the log. There is 636 possible
> hours...
> Now that I know the reason, I'll try to find a workaround.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (OFBIZ-13071) Could not find PortalPage with portalPageId []
[
https://issues.apache.org/jira/browse/OFBIZ-13071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17841126#comment-17841126
]
ASF subversion and git services commented on OFBIZ-13071:
-
Commit 075fce1d652db3d0d8b8e6b2e07ec74cdb4659a3 in ofbiz-framework's branch
refs/heads/release18.12 from Jacques Le Roux
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=075fce1d65 ]
Fixed: Could not find PortalPage with portalPageId [] (OFBIZ-13071)
Avoids spider bots to clutter the logs by forcing auth. Does not make sense
W/o anyway
> Could not find PortalPage with portalPageId []
> ---
>
> Key: OFBIZ-13071
> URL: https://issues.apache.org/jira/browse/OFBIZ-13071
> Project: OFBiz
> Issue Type: Bug
> Components: sfa
>Affects Versions: 18.12.12
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Major
> Fix For: 18.12.13
>
>
> This is a weird behaviour. Yet it's not really a bug but something that
> spider bots do. They get to ListTimezones while not being signed in (hard for
> spider bot). Here are 2 cases:
> {noformat}
> 18.224.149.242 - - [26/Apr/2024:03:20:05 +] "GET
> /sfa/control/setSessionTimeZone?tzId=Australia/Melbourne HTTP/1.1" 200 42716
> "-" "Mozilla/5.0 AppleWebKit/537.36 (KHTML, like Gecko; compatible;
> ClaudeBot/1.0; +claude...@anthropic.com)"
> 2024-04-26 03:20:05,254 |-0.0.0.0-8009-exec-4 |ModelScreenWidget
> |E| Could not find PortalPage with portalPageId []
> 3.144.172.115 - - [26/Apr/2024:03:32:22 +] "GET
> /sfa/control/setSessionTimeZone?tzId=Asia/Kuwait HTTP/1.1" 200 42716 "-"
> "Mozilla/5.0 AppleWebKit/537.36 (KHTML, like Gecko; compatible;
> ClaudeBot/1.0; +claude...@anthropic.com)"
> 2024-04-26 03:32:22,395 |-0.0.0.0-8009-exec-7 |ModelScreenWidget
> |E| Could not find PortalPage with portalPageId []
> {noformat}
> It happens only for SFA. [All the others| https://s.apache.org/gwyw2 ] are
> not concerned
> Why only SFA is concerned is unclear but not really a problem. Because once
> signed in the problem dissapears. The only problem is that if a spider bot
> gets to your production server it will clutter the log. There is 636 possible
> hours...
> Now that I know the reason, I'll try to find a workaround.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (OFBIZ-13071) Could not find PortalPage with portalPageId []
[
https://issues.apache.org/jira/browse/OFBIZ-13071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17841123#comment-17841123
]
ASF subversion and git services commented on OFBIZ-13071:
-
Commit 6fa3a5dc27ce65375b64fa66afaf9ef6934dfdc0 in ofbiz-plugins's branch
refs/heads/release18.12 from Jacques Le Roux
[ https://gitbox.apache.org/repos/asf?p=ofbiz-plugins.git;h=6fa3a5dc2 ]
Fixed: Could not find PortalPage with portalPageId [] (OFBIZ-13071)
Avoids spider bots to clutter the logs by forcing auth. Does not make sense
W/o anyway
> Could not find PortalPage with portalPageId []
> ---
>
> Key: OFBIZ-13071
> URL: https://issues.apache.org/jira/browse/OFBIZ-13071
> Project: OFBiz
> Issue Type: Bug
> Components: sfa
>Affects Versions: 18.12.12
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Major
> Fix For: 18.12.13
>
>
> This is a weird behaviour. Yet it's not really a bug but something that
> spider bots do. They get to ListTimezones while not being signed in (hard for
> spider bot). Here are 2 cases:
> {noformat}
> 18.224.149.242 - - [26/Apr/2024:03:20:05 +] "GET
> /sfa/control/setSessionTimeZone?tzId=Australia/Melbourne HTTP/1.1" 200 42716
> "-" "Mozilla/5.0 AppleWebKit/537.36 (KHTML, like Gecko; compatible;
> ClaudeBot/1.0; +claude...@anthropic.com)"
> 2024-04-26 03:20:05,254 |-0.0.0.0-8009-exec-4 |ModelScreenWidget
> |E| Could not find PortalPage with portalPageId []
> 3.144.172.115 - - [26/Apr/2024:03:32:22 +] "GET
> /sfa/control/setSessionTimeZone?tzId=Asia/Kuwait HTTP/1.1" 200 42716 "-"
> "Mozilla/5.0 AppleWebKit/537.36 (KHTML, like Gecko; compatible;
> ClaudeBot/1.0; +claude...@anthropic.com)"
> 2024-04-26 03:32:22,395 |-0.0.0.0-8009-exec-7 |ModelScreenWidget
> |E| Could not find PortalPage with portalPageId []
> {noformat}
> It happens only for SFA. [All the others| https://s.apache.org/gwyw2 ] are
> not concerned
> Why only SFA is concerned is unclear but not really a problem. Because once
> signed in the problem dissapears. The only problem is that if a spider bot
> gets to your production server it will clutter the log. There is 636 possible
> hours...
> Now that I know the reason, I'll try to find a workaround.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (OFBIZ-13071) Could not find PortalPage with portalPageId []
[
https://issues.apache.org/jira/browse/OFBIZ-13071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17841089#comment-17841089
]
ASF subversion and git services commented on OFBIZ-13071:
-
Commit 97b499195315453d1ca00fc9b19e04fde25420f6 in ofbiz-plugins's branch
refs/heads/trunk from Jacques Le Roux
[ https://gitbox.apache.org/repos/asf?p=ofbiz-plugins.git;h=97b499195 ]
Fixed: Could not find PortalPage with portalPageId [] (OFBIZ-13071)
Avoids spider bots to clutter the logs by forcing auth. Does not make sense
W/o anyway
> Could not find PortalPage with portalPageId []
> ---
>
> Key: OFBIZ-13071
> URL: https://issues.apache.org/jira/browse/OFBIZ-13071
> Project: OFBiz
> Issue Type: Bug
> Components: sfa
>Affects Versions: Upcoming Branch
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Major
> Fix For: Upcoming Branch
>
>
> This is a weird behaviour. Yet it's not really a bug but something that
> spider bots do. They get to ListTimezones while not being signed in (hard for
> spider bot). Here are 2 cases:
> {noformat}
> 18.224.149.242 - - [26/Apr/2024:03:20:05 +] "GET
> /sfa/control/setSessionTimeZone?tzId=Australia/Melbourne HTTP/1.1" 200 42716
> "-" "Mozilla/5.0 AppleWebKit/537.36 (KHTML, like Gecko; compatible;
> ClaudeBot/1.0; +claude...@anthropic.com)"
> 2024-04-26 03:20:05,254 |-0.0.0.0-8009-exec-4 |ModelScreenWidget
> |E| Could not find PortalPage with portalPageId []
> 3.144.172.115 - - [26/Apr/2024:03:32:22 +] "GET
> /sfa/control/setSessionTimeZone?tzId=Asia/Kuwait HTTP/1.1" 200 42716 "-"
> "Mozilla/5.0 AppleWebKit/537.36 (KHTML, like Gecko; compatible;
> ClaudeBot/1.0; +claude...@anthropic.com)"
> 2024-04-26 03:32:22,395 |-0.0.0.0-8009-exec-7 |ModelScreenWidget
> |E| Could not find PortalPage with portalPageId []
> {noformat}
> It happens only for SFA. [All the others| https://s.apache.org/gwyw2 ] are
> not concerned
> Why only SFA is concerned is unclear but not really a problem. Because once
> signed in the problem dissapears. The only problem is that if a spider bot
> gets to your production server it will clutter the log. There is 636 possible
> hours...
> Now that I know the reason, I'll try to find a workaround.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (OFBIZ-13071) Could not find PortalPage with portalPageId []
[
https://issues.apache.org/jira/browse/OFBIZ-13071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17841088#comment-17841088
]
ASF subversion and git services commented on OFBIZ-13071:
-
Commit 0b9cc3b85a3aed00244e058bd2a2299a55fb9292 in ofbiz-framework's branch
refs/heads/trunk from Jacques Le Roux
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=0b9cc3b85a ]
Fixed: Could not find PortalPage with portalPageId [] (OFBIZ-13071)
Avoids spider bots to clutter the logs by forcing auth. Does not make sense
W/o anyway
> Could not find PortalPage with portalPageId []
> ---
>
> Key: OFBIZ-13071
> URL: https://issues.apache.org/jira/browse/OFBIZ-13071
> Project: OFBiz
> Issue Type: Bug
> Components: sfa
>Affects Versions: Upcoming Branch
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Major
> Fix For: Upcoming Branch
>
>
> This is a weird behaviour. Yet it's not really a bug but something that
> spider bots do. They get to ListTimezones while not being signed in (hard for
> spider bot). Here are 2 cases:
> {noformat}
> 18.224.149.242 - - [26/Apr/2024:03:20:05 +] "GET
> /sfa/control/setSessionTimeZone?tzId=Australia/Melbourne HTTP/1.1" 200 42716
> "-" "Mozilla/5.0 AppleWebKit/537.36 (KHTML, like Gecko; compatible;
> ClaudeBot/1.0; +claude...@anthropic.com)"
> 2024-04-26 03:20:05,254 |-0.0.0.0-8009-exec-4 |ModelScreenWidget
> |E| Could not find PortalPage with portalPageId []
> 3.144.172.115 - - [26/Apr/2024:03:32:22 +] "GET
> /sfa/control/setSessionTimeZone?tzId=Asia/Kuwait HTTP/1.1" 200 42716 "-"
> "Mozilla/5.0 AppleWebKit/537.36 (KHTML, like Gecko; compatible;
> ClaudeBot/1.0; +claude...@anthropic.com)"
> 2024-04-26 03:32:22,395 |-0.0.0.0-8009-exec-7 |ModelScreenWidget
> |E| Could not find PortalPage with portalPageId []
> {noformat}
> It happens only for SFA. [All the others| https://s.apache.org/gwyw2 ] are
> not concerned
> Why only SFA is concerned is unclear but not really a problem. Because once
> signed in the problem dissapears. The only problem is that if a spider bot
> gets to your production server it will clutter the log. There is 636 possible
> hours...
> Now that I know the reason, I'll try to find a workaround.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (OFBIZ-13060) quickInitDataWarehouse fails
[ https://issues.apache.org/jira/browse/OFBIZ-13060?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17840886#comment-17840886 ] ASF subversion and git services commented on OFBIZ-13060: - Commit 4511f5e6f69d0bd19df3ce3baecb8a8e23f8d54e in ofbiz-plugins's branch refs/heads/trunk from Jacques Le Roux [ https://gitbox.apache.org/repos/asf?p=ofbiz-plugins.git;h=4511f5e6f ] Fixed: quickInitDataWarehouse fails (OFBIZ-13060) There were 2 reasons. I thought initially that it was only my bad in BiSystemPropertyData.xml where I set the thruDate value for bi.property to 2133-09-01 instead of 2033-09-01 But it turned out that I had also to increase the quickInitDataWarehouse and loadInventoryFact service timeouts to 300. I picked 300, I guess it's a bit much, to follow loadDateDimension service. > quickInitDataWarehouse fails > > > Key: OFBIZ-13060 > URL: https://issues.apache.org/jira/browse/OFBIZ-13060 > Project: OFBiz > Issue Type: Bug > Components: bi >Affects Versions: Upcoming Branch >Reporter: Jacques Le Roux >Priority: Major > Fix For: Upcoming Branch > > > The error is: > org.apache.ofbiz.webapp.event.EventHandlerException: Service invocation error > (Could not commit transaction for service [quickInitDataWarehouse] call: Roll > back error (with no rollbackOnly cause found), could not commit transaction, > was rolled back instead: java.lang.Exception: Transaction has timed out > (Transaction has timed out)) > It works in next demo, so it's due to a "recent" changes. It seems the > conversion from XML of DimensionServices to groovy is the reason. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OFBIZ-1659) Improve usability of Employment Screen
[ https://issues.apache.org/jira/browse/OFBIZ-1659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17840803#comment-17840803 ] ASF subversion and git services commented on OFBIZ-1659: Commit 39c8abf135b63004981f1d4d68577cf16edd5dbf in ofbiz-framework's branch refs/heads/trunk from Jacques Le Roux [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=39c8abf135 ] Fixed: Error in PayGradeForms.xml Line: 65 (OFBIZ-13062) Remove the line 65. It was put in by OFBIZ-1659. It's useless (tested) > Improve usability of Employment Screen > -- > > Key: OFBIZ-1659 > URL: https://issues.apache.org/jira/browse/OFBIZ-1659 > Project: OFBiz > Issue Type: New Feature > Components: humanres >Reporter: Anil K Patel >Assignee: Ashish Vijaywargiya >Priority: Minor > Attachments: CreateEmployee.patch, HREmployee.patch, > HREmployee.patch, Improvements.patch, Improvements.patch, Improvements.patch, > Improvements.patch, Improvements.patch, Improvements.patch, > Improvements.patch, Improvements.patch, Improvements.patch, > Improvements.patch, Improvements.patch, Improvements.patch, > Improvements.patch, Improvements.patch, Improvements.patch, > Improvements.patch, Improvements.patch, Improvements.patch, > Improvements.patch, improvements.patch > > > Following things can be done to improve usability of Employment screen. > Rename the Employment app menu to Employees > 1) Add Find/List form to find employees in system. > 2) [Create New Employee] This should give a form where we user can input > Person and Contact details and few fields from Employment table. > 3) Employment is a Party Relationship between Party Roles FROM EMPLOYEE TO > INTERNAL ORGANIZATION. To make it easy, values of these two fields should be > Defaulted to these values and I don't see need to show these fields on form. > 4) The Employment.FromPartyId field should have a Party look up that shows > only the Person. > 5) The Employment.ToPartyId field should be a drop down of Parties in > Internal Organization role. > 6) Do not show Termination type and reason fields on Create Employment forms. > 7) Add Terminate Employment button on Update Employment form. On click of > button show a Sub Form that has fields Termination type, Reason and comments > fields. > 8) The Edit form should have FromPartyId read only. > 9) Edit employee screens should have, Summary tab, Employee tab, Employment > and other tabs defined in other jira issue. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OFBIZ-13062) Error in PayGradeForms.xml Line: 65
[ https://issues.apache.org/jira/browse/OFBIZ-13062?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17840802#comment-17840802 ] ASF subversion and git services commented on OFBIZ-13062: - Commit 39c8abf135b63004981f1d4d68577cf16edd5dbf in ofbiz-framework's branch refs/heads/trunk from Jacques Le Roux [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=39c8abf135 ] Fixed: Error in PayGradeForms.xml Line: 65 (OFBIZ-13062) Remove the line 65. It was put in by OFBIZ-1659. It's useless (tested) > Error in PayGradeForms.xml Line: 65 > --- > > Key: OFBIZ-13062 > URL: https://issues.apache.org/jira/browse/OFBIZ-13062 > Project: OFBiz > Issue Type: Bug > Components: humanres >Affects Versions: 18.12.13 >Reporter: Jacques Le Roux >Priority: Major > > XmlFileLoader: File > file:/ofbiz/applications/humanres/widget/forms/PayGradeForms.xml process > error. Line: 65. Error message: cvc-complex-type.4: Attribute 'value-field' > must appear on element 'entity-one'. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OFBIZ-13068) Accounts Payable Past Due Invoices doesn't show outstanding amount
[ https://issues.apache.org/jira/browse/OFBIZ-13068?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17840763#comment-17840763 ] ASF subversion and git services commented on OFBIZ-13068: - Commit c7230e1006ee18a8c55e8295e57725d78c355e13 in ofbiz-framework's branch refs/heads/trunk from Jacques Le Roux [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=c7230e1006 ] Improved: Accounts Payable Past Due Invoices doesn't show outstanding amount (OFBIZ-13068) There is a subtle difference between "Accounts Receivable" and "Accounts Payable" It's reflected in current AR and AP applications (currently replaced by the main accounting page, WIP) For a receivable payment we use "Outstanding amount", for payable payment we use "Amount to apply" This fixes it again and for a last time!- > Accounts Payable Past Due Invoices doesn't show outstanding amount > -- > > Key: OFBIZ-13068 > URL: https://issues.apache.org/jira/browse/OFBIZ-13068 > Project: OFBiz > Issue Type: Improvement > Components: accounting >Reporter: Pierre Smits >Priority: Major > > With recent changes via commit ec0adc02f102d75be15e1ee04062b75621219f0d > [ec0adc02f1] the field outstanding got replaced with amountToApply in grid > ListApReport. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OFBIZ-13068) Accounts Payable Past Due Invoices doesn't show outstanding amount
[ https://issues.apache.org/jira/browse/OFBIZ-13068?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17840757#comment-17840757 ] ASF subversion and git services commented on OFBIZ-13068: - Commit 0c7823c3bf0f2359f14bab5d7d574847002649f2 in ofbiz-framework's branch refs/heads/trunk from Pierre Smits [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=0c7823c3bf ] Fixed: Accounts Payable Past Due Invoices doesn't show outstanding amount (OFBIZ-13068) (#786) With recent changes via commit ec0adc02f102d75be15e1ee04062b75621219f0d [ec0adc02f1] the field outstanding got replaced with amountToApply in grid ListApReport. modified: InvoiceForms.xml - replaced field amountToApply with outstanding in grid ListApReport - corrected style of field total and outstanding in grid ListArReport - corrected style of field total and outstanding in grid ListApReport > Accounts Payable Past Due Invoices doesn't show outstanding amount > -- > > Key: OFBIZ-13068 > URL: https://issues.apache.org/jira/browse/OFBIZ-13068 > Project: OFBiz > Issue Type: Improvement > Components: accounting >Reporter: Pierre Smits >Priority: Major > > With recent changes via commit ec0adc02f102d75be15e1ee04062b75621219f0d > [ec0adc02f1] the field outstanding got replaced with amountToApply in grid > ListApReport. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OFBIZ-13065) userLogin null or missing in customer/ViewProfile.ftl
[ https://issues.apache.org/jira/browse/OFBIZ-13065?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17840337#comment-17840337 ] ASF subversion and git services commented on OFBIZ-13065: - Commit 5eea336a62fa302aab3765bd756d0ee896230171 in ofbiz-plugins's branch refs/heads/trunk from Jacques Le Roux [ https://gitbox.apache.org/repos/asf?p=ofbiz-plugins.git;h=5eea336a6 ] Fixed: userLogin null or missing in customer/ViewProfile.ftl (OFBIZ-13065) This was found trunk demo error.log. A rare case I guess (party does not exist too) I also globally indented the code from start to make it more legible. It makes the commit a bit hard to read. That's only once... > userLogin null or missing in customer/ViewProfile.ftl > -- > > Key: OFBIZ-13065 > URL: https://issues.apache.org/jira/browse/OFBIZ-13065 > Project: OFBiz > Issue Type: Bug >Reporter: Jacques Le Roux >Priority: Minor > > The complete error is > freemarker.core.InvalidReferenceException: The following has evaluated to > null or missing: > ==> userLogin [in template > "component://ecommerce/template/customer/ViewProfile.ftl" at line 637, column > 57] > A rare case I guess (party does not exist too) -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OFBIZ-13035) Fix cross-app menu location issues
[ https://issues.apache.org/jira/browse/OFBIZ-13035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17840330#comment-17840330 ] ASF subversion and git services commented on OFBIZ-13035: - Commit b376ddfb7ca1702f20b665737aa084ae278d60a6 in ofbiz-plugins's branch refs/heads/trunk from Jacques Le Roux [ https://gitbox.apache.org/repos/asf?p=ofbiz-plugins.git;h=b376ddfb7 ] Fixed: Fix cross-app menu location issues (OFBIZ-13035) Fixes Error rendering included menu named [ExampleAppBar] at location [component://exampleext/widget/example/ExampleMenus.xml]: java.lang.IllegalArgumentException: Could not find menu with name [ExampleAppBar] in location [component://exampleext/widget/example/ExampleMenus.xml] > Fix cross-app menu location issues > -- > > Key: OFBIZ-13035 > URL: https://issues.apache.org/jira/browse/OFBIZ-13035 > Project: OFBiz > Issue Type: Sub-task > Components: ALL APPLICATIONS >Affects Versions: Upcoming Branch >Reporter: Pierre Smits >Priority: Major > Fix For: Upcoming Branch > > > address cross application menu-location issues. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OFBIZ-13061) Prevents to uselessly clutter the logs up with SetTimeZoneFromBrowser errors
[ https://issues.apache.org/jira/browse/OFBIZ-13061?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17840151#comment-17840151 ] ASF subversion and git services commented on OFBIZ-13061: - Commit b12f2779e6fd90662baad3fee0f51dfb11215ee8 in ofbiz-framework's branch refs/heads/trunk from Jacques Le Roux [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=b12f2779e6 ] Fixed: Prevents to uselessly clutter the logs up with SetTimeZoneFromBrowser errors (OFBIZ-13061) The previous commit was not enough as I feared. It still shows in trunk demo error.log today. So here comes the ugly but sure fix. > Prevents to uselessly clutter the logs up with SetTimeZoneFromBrowser errors > > > Key: OFBIZ-13061 > URL: https://issues.apache.org/jira/browse/OFBIZ-13061 > Project: OFBiz > Issue Type: Improvement > Components: framework/common >Affects Versions: Upcoming Branch >Reporter: Jacques Le Roux >Assignee: Jacques Le Roux >Priority: Trivial > Fix For: Upcoming Branch > > > Currently the demo logs, and I guess the users production logs, are cluttered > up with very common and unique SetTimeZoneFromBrowser errors. > We can easily prevent that by not returning an error from > SetTimeZoneFromBrowser.groovy, and so the never ending > bq. < message: User authorization is required for this service: > SetTimeZoneFromBrowser>> > from RequestHandler.java -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OFBIZ-13063) Wrong partyId Accounts Payable
[ https://issues.apache.org/jira/browse/OFBIZ-13063?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17840138#comment-17840138 ] ASF subversion and git services commented on OFBIZ-13063: - Commit ec0adc02f102d75be15e1ee04062b75621219f0d in ofbiz-framework's branch refs/heads/trunk from Jacques Le Roux [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=ec0adc02f1 ] Fixed: Wrong partyId Accounts Payable (OFBIZ-13063) In previous commit I removed AccountingOutstanding added by Pierre (just en and nl translations) then used anywhere. Pierre contacted me and rightly mentioned that the English translation of property key="" was wrong. It should logically have been "Amount to apply" (an old wrong change of revision 775580 put in the mistake) So I changed that and re-added AccountingOutstanding though using FormFieldTitle_outstanding to replace in right places in both accounting and ar InvoiceForms.xml. Pfew... > Wrong partyId Accounts Payable > -- > > Key: OFBIZ-13063 > URL: https://issues.apache.org/jira/browse/OFBIZ-13063 > Project: OFBiz > Issue Type: Bug > Components: accounting >Affects Versions: Upcoming Branch >Reporter: Pierre Smits >Assignee: Jacques Le Roux >Priority: Major > Fix For: Upcoming Branch > > > The Accounts Payable Past Due and Due Soon overviews in the Main page shows > the wrong partyId of the creditor. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OFBIZ-13063) Wrong partyId Accounts Payable
[ https://issues.apache.org/jira/browse/OFBIZ-13063?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17840012#comment-17840012 ] ASF subversion and git services commented on OFBIZ-13063: - Commit be7231e2d5a78b1294b56c6603d7744a2eb494a9 in ofbiz-framework's branch refs/heads/trunk from Jacques Le Roux [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=be7231e2d5 ] Fixed: Wrong partyId Accounts Payable (OFBIZ-13063) Fixes partyId to partyIdFrom for the link to the creditor profile in ListApReport form Also uses FormFieldTitle_amountToApply that have foreign translations while removing AccountingOutstanding added by Pierre (just en and nl translations) then used anywhere > Wrong partyId Accounts Payable > -- > > Key: OFBIZ-13063 > URL: https://issues.apache.org/jira/browse/OFBIZ-13063 > Project: OFBiz > Issue Type: Improvement > Components: accounting >Reporter: Pierre Smits >Priority: Major > > The Accounts Payable Past Due and Due Soon overviews in the Main page shows > the wrong partyId of the creditor. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OFBIZ-13063) Wrong partyId Accounts Payable
[ https://issues.apache.org/jira/browse/OFBIZ-13063?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17839997#comment-17839997 ] ASF subversion and git services commented on OFBIZ-13063: - Commit 0863258e104c57721a6a0cf9d37564646e425ebf in ofbiz-framework's branch refs/heads/trunk from Pierre Smits [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=0863258e10 ] Improved: Wrong partyId Accounts Payable (OFBIZ-13063) (#781) The Accounts Payable Past Due and Due Soon overviews in the Main page shows the wrong partyId of the creditor. modified: InvoiceForms.xml - adjusted grid ListArReport > Wrong partyId Accounts Payable > -- > > Key: OFBIZ-13063 > URL: https://issues.apache.org/jira/browse/OFBIZ-13063 > Project: OFBiz > Issue Type: Improvement > Components: accounting >Reporter: Pierre Smits >Priority: Major > > The Accounts Payable Past Due and Due Soon overviews in the Main page shows > the wrong partyId of the creditor. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OFBIZ-12966) Integrate AR Past Due into accounting- main
[ https://issues.apache.org/jira/browse/OFBIZ-12966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17839972#comment-17839972 ] ASF subversion and git services commented on OFBIZ-12966: - Commit edcf41917c3e6fbeaa832f63cd98daf78d3fd34a in ofbiz-framework's branch refs/heads/trunk from Mekika Leila [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=edcf41917c ] Fixed: invoiceOverview generates an error (OFBIZ-13017) (#780) Update fix to combine OFBIZ-12966 and OFBIZ-13011 updates with modifications brought by jira OFBIZ-12994 It brings back the changes introduced by OFBIZ-12994 and adapt it with the change of invoiceOverview screen name > Integrate AR Past Due into accounting- main > --- > > Key: OFBIZ-12966 > URL: https://issues.apache.org/jira/browse/OFBIZ-12966 > Project: OFBiz > Issue Type: Sub-task > Components: accounting >Reporter: Pierre Smits >Assignee: Jacques Le Roux >Priority: Major > Fix For: Upcoming Branch > > > Integrate the overview of invoices past due date of accounts receivable as a > portal page into the main screen of the accounting application. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OFBIZ-13017) invoiceOverview generates an error
[ https://issues.apache.org/jira/browse/OFBIZ-13017?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17839971#comment-17839971 ] ASF subversion and git services commented on OFBIZ-13017: - Commit edcf41917c3e6fbeaa832f63cd98daf78d3fd34a in ofbiz-framework's branch refs/heads/trunk from Mekika Leila [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=edcf41917c ] Fixed: invoiceOverview generates an error (OFBIZ-13017) (#780) Update fix to combine OFBIZ-12966 and OFBIZ-13011 updates with modifications brought by jira OFBIZ-12994 It brings back the changes introduced by OFBIZ-12994 and adapt it with the change of invoiceOverview screen name > invoiceOverview generates an error > -- > > Key: OFBIZ-13017 > URL: https://issues.apache.org/jira/browse/OFBIZ-13017 > Project: OFBiz > Issue Type: Bug > Components: accounting >Reporter: Pierre Smits >Assignee: Jacques Le Roux >Priority: Major > Fix For: Upcoming Branch > > > see > https://demo-trunk.ofbiz.apache.org/accounting/control/invoiceOverview?invoiceId=demo10001 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OFBIZ-12994) Convert Invoice relation screen to dynamic Compound
[ https://issues.apache.org/jira/browse/OFBIZ-12994?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17839974#comment-17839974 ] ASF subversion and git services commented on OFBIZ-12994: - Commit edcf41917c3e6fbeaa832f63cd98daf78d3fd34a in ofbiz-framework's branch refs/heads/trunk from Mekika Leila [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=edcf41917c ] Fixed: invoiceOverview generates an error (OFBIZ-13017) (#780) Update fix to combine OFBIZ-12966 and OFBIZ-13011 updates with modifications brought by jira OFBIZ-12994 It brings back the changes introduced by OFBIZ-12994 and adapt it with the change of invoiceOverview screen name > Convert Invoice relation screen to dynamic Compound > --- > > Key: OFBIZ-12994 > URL: https://issues.apache.org/jira/browse/OFBIZ-12994 > Project: OFBiz > Issue Type: Improvement > Components: accounting/invoice >Affects Versions: Upcoming Branch >Reporter: Mekika Leila >Assignee: Mekika Leila >Priority: Minor > Fix For: Upcoming Branch > > > After the work on the task OFBIZ-11808, and the migration started for > workeffort screens on OFBIZ-12292, the purpose is to migrate all screen > linked to Invoice entity with idea to reduce the code and use widget > improvement developped last years > This migration cover invoice related screens from invoiceOverview to > managment screens and forms for each invoice sub item such as: > - Applications > - Attributes > - ContactMech > - Content > - Item > - Note > - Role > - Status > - Term > - TimeEntry > -- This message was sent by Atlassian Jira (v8.20.10#820010)
