[jira] [Assigned] (OFBIZ-13013) Improve the condition for fetching the currencyUomId while requesting to create a shipment on FedEx
[ https://issues.apache.org/jira/browse/OFBIZ-13013?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Devanshu Vyas reassigned OFBIZ-13013: - Assignee: Devanshu Vyas > Improve the condition for fetching the currencyUomId while requesting to > create a shipment on FedEx > --- > > Key: OFBIZ-13013 > URL: https://issues.apache.org/jira/browse/OFBIZ-13013 > Project: OFBiz > Issue Type: Bug > Components: product >Affects Versions: Upcoming Branch >Reporter: Sandeep Rajput >Assignee: Devanshu Vyas >Priority: Minor > > Improve the condition for fetching the currencyUomId while requesting to > create a shipment on FedEx -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OFBIZ-11236) Add shipment notes
[ https://issues.apache.org/jira/browse/OFBIZ-11236?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17449271#comment-17449271 ] Devanshu Vyas commented on OFBIZ-11236: --- If [~gpierre] is not free to continue on this, I would like to offer my assistance and I can complete all the mentioned improvements and complete the feature. > Add shipment notes > -- > > Key: OFBIZ-11236 > URL: https://issues.apache.org/jira/browse/OFBIZ-11236 > Project: OFBiz > Issue Type: New Feature > Components: product >Affects Versions: Trunk >Reporter: Gaudin Pierre >Priority: Minor > Labels: shipment > Attachments: OFBIZ-11236_shipmentNotesV3.patch, Screen Shot > 2020-02-11 at 08.53.37.png > > > Hello, > For many entities there are associated notes. However, there are no notes > associated with shipments. > The purpose of this patch is therefore to add notes to the shipments. > A new tab called "note" appears when displaying a shipment. From this tab it > is possible to add a note. From the shipment overview a section displays the > notes associated with the shipment. > For this new feature a "ShipmentNote" entity has been added. In the same way, > all the services allowing the management of notes have been associated. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Assigned] (OFBIZ-12108) Invalid Currency symbol in income statement csv export
[ https://issues.apache.org/jira/browse/OFBIZ-12108?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Devanshu Vyas reassigned OFBIZ-12108: - Assignee: Devanshu Vyas (was: Praveen Sharma) > Invalid Currency symbol in income statement csv export > -- > > Key: OFBIZ-12108 > URL: https://issues.apache.org/jira/browse/OFBIZ-12108 > Project: OFBiz > Issue Type: Bug > Components: accounting >Affects Versions: Trunk >Reporter: Lalit Dashora >Assignee: Devanshu Vyas >Priority: Major > Attachments: OFBIZ-12108.patch > > > 1. Navigate to URL: > accounting/control/IncomeStatement?organizationPartyId=Company > 2. In income statement section click on export as csv button. > 3. The exported csv has correct balance but with invalid currency symbol. > 4. On screen USD $ symbol is shown and in csv some other currency symbol is > shown. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Closed] (OFBIZ-12188) Error message is displayed when user clicks on create link after the user quick chechout and user is not logged in
[ https://issues.apache.org/jira/browse/OFBIZ-12188?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Devanshu Vyas closed OFBIZ-12188. - Fix Version/s: Upcoming Branch Resolution: Fixed > Error message is displayed when user clicks on create link after the user > quick chechout and user is not logged in > --- > > Key: OFBIZ-12188 > URL: https://issues.apache.org/jira/browse/OFBIZ-12188 > Project: OFBiz > Issue Type: Bug > Components: ecommerce >Affects Versions: Trunk >Reporter: Arpit Mor >Assignee: Devanshu Vyas >Priority: Major > Fix For: Upcoming Branch > > Attachments: 001.webm, OFBIZ-12188.patch > > > Steps to regenerate: > * Navigate to ecommerce: [https://demo-trunk.ofbiz.apache.org/ecomseo/] > * User should not be logged in > * Add product to cart > * Click on quick checkout > * Click on create link > Actual: Error message is displayed. Please refer attachment: 001 > [^001.webm] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-12188) Error message is displayed when user clicks on create link after the user quick chechout and user is not logged in
[ https://issues.apache.org/jira/browse/OFBIZ-12188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17309903#comment-17309903 ] Devanshu Vyas commented on OFBIZ-12188: --- This has already been fixed at release 18.12 and 17.12 and I have committed for the trunk at Commit c6704e90c33c577f05dedc2b41a7037e7d70f20f. Thank you [~arpit.mor] for reporting the issue and [~sourabh.punyani] for providing the fix. > Error message is displayed when user clicks on create link after the user > quick chechout and user is not logged in > --- > > Key: OFBIZ-12188 > URL: https://issues.apache.org/jira/browse/OFBIZ-12188 > Project: OFBiz > Issue Type: Bug > Components: ecommerce >Affects Versions: Trunk >Reporter: Arpit Mor >Assignee: Devanshu Vyas >Priority: Major > Attachments: 001.webm, OFBIZ-12188.patch > > > Steps to regenerate: > * Navigate to ecommerce: [https://demo-trunk.ofbiz.apache.org/ecomseo/] > * User should not be logged in > * Add product to cart > * Click on quick checkout > * Click on create link > Actual: Error message is displayed. Please refer attachment: 001 > [^001.webm] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (OFBIZ-12188) Error message is displayed when user clicks on create link after the user quick chechout and user is not logged in
[ https://issues.apache.org/jira/browse/OFBIZ-12188?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Devanshu Vyas reassigned OFBIZ-12188: - Assignee: Devanshu Vyas (was: Sourabh Punyani) > Error message is displayed when user clicks on create link after the user > quick chechout and user is not logged in > --- > > Key: OFBIZ-12188 > URL: https://issues.apache.org/jira/browse/OFBIZ-12188 > Project: OFBiz > Issue Type: Bug > Components: ecommerce >Affects Versions: Trunk >Reporter: Arpit Mor >Assignee: Devanshu Vyas >Priority: Major > Attachments: 001.webm, OFBIZ-12188.patch > > > Steps to regenerate: > * Navigate to ecommerce: [https://demo-trunk.ofbiz.apache.org/ecomseo/] > * User should not be logged in > * Add product to cart > * Click on quick checkout > * Click on create link > Actual: Error message is displayed. Please refer attachment: 001 > [^001.webm] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-10379) Exception handling for Add a new Party Role at createInvoiceRole
[ https://issues.apache.org/jira/browse/OFBIZ-10379?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17220060#comment-17220060 ] Devanshu Vyas commented on OFBIZ-10379: --- The process to remove the apps is gonna take some time and until then we should treat this as any other issue and fix it. I will verify the patch is still working or not and will commit this as I am still in favour to fix this issue. I will also commit this patch if no objections occur in next 2 weeks. > Exception handling for Add a new Party Role at createInvoiceRole > > > Key: OFBIZ-10379 > URL: https://issues.apache.org/jira/browse/OFBIZ-10379 > Project: OFBiz > Issue Type: Bug > Environment: > https://demo-trunk.ofbiz.apache.org/ap/control/createInvoiceRole >Reporter: Aayush jain >Assignee: Pierre Smits >Priority: Minor > Attachments: Error.png, OFBIZ-10379.patch > > > Steps: > 1. Open URL https://demo-trunk.ofbiz.apache.org/ap/control/createInvoiceRole > 2. Add a party Id which does not assigned as a role for accounts > 3. Enter Percentage > 4. Click on submit button > Actual Result: > Throwing an exception error for the invalid case, Kindly refer attachment for > the same > Expected Result: > We must handle exceptions with a proper error message, I don't think this is > working fine, It should be correct with proper message. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Closed] (OFBIZ-11605) Unable to change Order Status
[ https://issues.apache.org/jira/browse/OFBIZ-11605?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Devanshu Vyas closed OFBIZ-11605. - Assignee: Devanshu Vyas (was: Rahul Marjiwe) Resolution: Cannot Reproduce > Unable to change Order Status > -- > > Key: OFBIZ-11605 > URL: https://issues.apache.org/jira/browse/OFBIZ-11605 > Project: OFBiz > Issue Type: Improvement > Components: order >Affects Versions: Trunk >Reporter: Rahul Marjiwe >Assignee: Devanshu Vyas >Priority: Minor > Fix For: Trunk > > Attachments: OFBIZ-11605.patch > > > Step to generate: > # Go to the order manager and select the order entry menu. > # select the supplier for a purchase order and click on continue. > # In Create Purchase Order screen add any product Id, quantity, and click > on add to order. > # Click on Finalize order and continue. > # On Purchase Order : Order Entry Ship-To Settings click on continue. > # For order notes and additional party-id click on continue. > # In order-confirmation screen click on Create Order button. > # In orderview screen click on approve order button. > Actual: it is rendering the error message after click on approve order > button. > Expected: Change order status created to approve. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11605) Unable to change Order Status
[ https://issues.apache.org/jira/browse/OFBIZ-11605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17220035#comment-17220035 ] Devanshu Vyas commented on OFBIZ-11605: --- With no response from Rahul and I verified again today that the issue is not regenerating I am closing this ticket. > Unable to change Order Status > -- > > Key: OFBIZ-11605 > URL: https://issues.apache.org/jira/browse/OFBIZ-11605 > Project: OFBiz > Issue Type: Improvement > Components: order >Affects Versions: Trunk >Reporter: Rahul Marjiwe >Assignee: Rahul Marjiwe >Priority: Minor > Fix For: Trunk > > Attachments: OFBIZ-11605.patch > > > Step to generate: > # Go to the order manager and select the order entry menu. > # select the supplier for a purchase order and click on continue. > # In Create Purchase Order screen add any product Id, quantity, and click > on add to order. > # Click on Finalize order and continue. > # On Purchase Order : Order Entry Ship-To Settings click on continue. > # For order notes and additional party-id click on continue. > # In order-confirmation screen click on Create Order button. > # In orderview screen click on approve order button. > Actual: it is rendering the error message after click on approve order > button. > Expected: Change order status created to approve. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11605) Unable to change Order Status
[ https://issues.apache.org/jira/browse/OFBIZ-11605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17202602#comment-17202602 ] Devanshu Vyas commented on OFBIZ-11605: --- Hello [~Rahul.marjiwe], I followed all the steps shared in the ticket description. I was also not able to replicate the issue. I checked with the other order statuses as well, and all is working well. If you could share some more details and screenshots, it would be great. This could be a local machine issue as well, so if this is the case then we can close this ticket. > Unable to change Order Status > -- > > Key: OFBIZ-11605 > URL: https://issues.apache.org/jira/browse/OFBIZ-11605 > Project: OFBiz > Issue Type: Improvement > Components: order >Affects Versions: Trunk >Reporter: Rahul Marjiwe >Assignee: Rahul Marjiwe >Priority: Minor > Fix For: Trunk > > Attachments: OFBIZ-11605.patch > > > Step to generate: > # Go to the order manager and select the order entry menu. > # select the supplier for a purchase order and click on continue. > # In Create Purchase Order screen add any product Id, quantity, and click > on add to order. > # Click on Finalize order and continue. > # On Purchase Order : Order Entry Ship-To Settings click on continue. > # For order notes and additional party-id click on continue. > # In order-confirmation screen click on Create Order button. > # In orderview screen click on approve order button. > Actual: it is rendering the error message after click on approve order > button. > Expected: Change order status created to approve. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-10379) Exception handling for Add a new Party Role at createInvoiceRole
[ https://issues.apache.org/jira/browse/OFBIZ-10379?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17202562#comment-17202562 ] Devanshu Vyas commented on OFBIZ-10379: --- I believe, when the AP and AR web apps will be removed, then this would be gone along with it. But, until then we can think of it as a bug and try to fix it. > Exception handling for Add a new Party Role at createInvoiceRole > > > Key: OFBIZ-10379 > URL: https://issues.apache.org/jira/browse/OFBIZ-10379 > Project: OFBiz > Issue Type: Bug > Environment: > https://demo-trunk.ofbiz.apache.org/ap/control/createInvoiceRole >Reporter: Aayush jain >Assignee: Pierre Smits >Priority: Minor > Attachments: Error.png, OFBIZ-10379.patch > > > Steps: > 1. Open URL https://demo-trunk.ofbiz.apache.org/ap/control/createInvoiceRole > 2. Add a party Id which does not assigned as a role for accounts > 3. Enter Percentage > 4. Click on submit button > Actual Result: > Throwing an exception error for the invalid case, Kindly refer attachment for > the same > Expected Result: > We must handle exceptions with a proper error message, I don't think this is > working fine, It should be correct with proper message. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-10386) Empty field is reflecting on Contact list section on Profile Page
[ https://issues.apache.org/jira/browse/OFBIZ-10386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17202559#comment-17202559 ] Devanshu Vyas commented on OFBIZ-10386: --- Hello [~archana.asthana], I checked on the profile screen and found that there is a text box before the Verify Subscription button. Are you reporting the missing of the text box? OR as per the patch from [~praveen.patil], there should be a header/column for the text box. And in this case, I would suggest using _MarketingContactListOptInVerifyCode_ as the UiLabel instead of _FormFieldTitle_optInVerifyCode_. Let me know which is the case, so we can finalize on a solution. Cause we have both ready. > Empty field is reflecting on Contact list section on Profile Page > - > > Key: OFBIZ-10386 > URL: https://issues.apache.org/jira/browse/OFBIZ-10386 > Project: OFBiz > Issue Type: Bug > Environment: https://demo-trunk.ofbiz.apache.org/ecomseo/viewprofile >Reporter: Archana Asthana >Assignee: Devanshu Vyas >Priority: Major > Attachments: EmptyFields.png, ViewProfile.patch > > > Steps to generate: > Open https://demo-trunk.ofbiz.apache.org/ecomseo/viewprofile > On the profile page, Go down to Contact list > Empty fields are displaying before Verify Subscription button > Expected: The field should have some specifications to be filled up > Image is attached for reference -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (OFBIZ-10386) Empty field is reflecting on Contact list section on Profile Page
[ https://issues.apache.org/jira/browse/OFBIZ-10386?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Devanshu Vyas reassigned OFBIZ-10386: - Assignee: Devanshu Vyas > Empty field is reflecting on Contact list section on Profile Page > - > > Key: OFBIZ-10386 > URL: https://issues.apache.org/jira/browse/OFBIZ-10386 > Project: OFBiz > Issue Type: Bug > Environment: https://demo-trunk.ofbiz.apache.org/ecomseo/viewprofile >Reporter: Archana Asthana >Assignee: Devanshu Vyas >Priority: Major > Attachments: EmptyFields.png, ViewProfile.patch > > > Steps to generate: > Open https://demo-trunk.ofbiz.apache.org/ecomseo/viewprofile > On the profile page, Go down to Contact list > Empty fields are displaying before Verify Subscription button > Expected: The field should have some specifications to be filled up > Image is attached for reference -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11236) Add shipment notes
[ https://issues.apache.org/jira/browse/OFBIZ-11236?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17189106#comment-17189106 ] Devanshu Vyas commented on OFBIZ-11236: --- In my humble opinion, I think we should always give all the time to the contributor for the new functionality implementation if he/she is working on the task. And, if he/she is not available to work on it(maybe due to any no. of reasons) then we should as a community should help the person and pick the task up. Whenever the contributor comes back can share his/her opinion and we will honour those suggestions with consensus. Due to the unavailability of a contributor, a good feature should not be delayed in the project. We should all work together in harmony to bring any task to a closure. :) > Add shipment notes > -- > > Key: OFBIZ-11236 > URL: https://issues.apache.org/jira/browse/OFBIZ-11236 > Project: OFBiz > Issue Type: New Feature > Components: product >Affects Versions: Trunk >Reporter: Gaudin Pierre >Priority: Minor > Labels: shipment > Attachments: OFBIZ-11236_shipmentNotesV3.patch, Screen Shot > 2020-02-11 at 08.53.37.png > > > Hello, > For many entities there are associated notes. However, there are no notes > associated with shipments. > The purpose of this patch is therefore to add notes to the shipments. > A new tab called "note" appears when displaying a shipment. From this tab it > is possible to add a note. From the shipment overview a section displays the > notes associated with the shipment. > For this new feature a "ShipmentNote" entity has been added. In the same way, > all the services allowing the management of notes have been associated. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (OFBIZ-11503) Convert createInvoiceItemPayrol service from mini-lang to groovy DSL
[ https://issues.apache.org/jira/browse/OFBIZ-11503?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Devanshu Vyas reassigned OFBIZ-11503: - Assignee: Devanshu Vyas (was: Nitish Mishra) > Convert createInvoiceItemPayrol service from mini-lang to groovy DSL > > > Key: OFBIZ-11503 > URL: https://issues.apache.org/jira/browse/OFBIZ-11503 > Project: OFBiz > Issue Type: Sub-task > Components: accounting >Affects Versions: Trunk >Reporter: Devanshu Vyas >Assignee: Devanshu Vyas >Priority: Minor > Attachments: OFBIZ-11503.patch > > > Convert the createInvoiceItemPayrol service code from mini-lang to groovy DSL. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Closed] (OFBIZ-7480) Require check on Create Facility Content Screen
[ https://issues.apache.org/jira/browse/OFBIZ-7480?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Devanshu Vyas closed OFBIZ-7480. Fix Version/s: (was: Trunk) Upcoming Branch Resolution: Fixed > Require check on Create Facility Content Screen > --- > > Key: OFBIZ-7480 > URL: https://issues.apache.org/jira/browse/OFBIZ-7480 > Project: OFBiz > Issue Type: Improvement > Components: product >Affects Versions: Trunk >Reporter: Avnindra Sharma >Assignee: Jacopo Cappellato >Priority: Minor > Fix For: Upcoming Branch > > Attachments: CreateFacilityContentNote.png, OFBIZ-7480.patch > > > Navigate to Content in facilities and add Facility Content. Require check is > not there on mandatory fields. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Comment Edited] (OFBIZ-7480) Require check on Create Facility Content Screen
[ https://issues.apache.org/jira/browse/OFBIZ-7480?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17182344#comment-17182344 ] Devanshu Vyas edited comment on OFBIZ-7480 at 8/22/20, 12:55 PM: - On second thought, I am closing this ticket as the task is completed and I will create a new ticket to cover the FacilityContent screen. was (Author: devanshu.vyas): Should I create the patch and update the ticket or wait for suggestions? > Require check on Create Facility Content Screen > --- > > Key: OFBIZ-7480 > URL: https://issues.apache.org/jira/browse/OFBIZ-7480 > Project: OFBiz > Issue Type: Improvement > Components: product >Affects Versions: Trunk >Reporter: Avnindra Sharma >Assignee: Jacopo Cappellato >Priority: Minor > Fix For: Trunk > > Attachments: CreateFacilityContentNote.png, OFBIZ-7480.patch > > > Navigate to Content in facilities and add Facility Content. Require check is > not there on mandatory fields. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-7480) Require check on Create Facility Content Screen
[ https://issues.apache.org/jira/browse/OFBIZ-7480?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17182344#comment-17182344 ] Devanshu Vyas commented on OFBIZ-7480: -- Should I create the patch and update the ticket or wait for suggestions? > Require check on Create Facility Content Screen > --- > > Key: OFBIZ-7480 > URL: https://issues.apache.org/jira/browse/OFBIZ-7480 > Project: OFBiz > Issue Type: Improvement > Components: product >Affects Versions: Trunk >Reporter: Avnindra Sharma >Assignee: Jacopo Cappellato >Priority: Minor > Fix For: Trunk > > Attachments: CreateFacilityContentNote.png, OFBIZ-7480.patch > > > Navigate to Content in facilities and add Facility Content. Require check is > not there on mandatory fields. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11929) Fix Literals comparisons with variable to avoid NPE
[ https://issues.apache.org/jira/browse/OFBIZ-11929?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17170535#comment-17170535 ] Devanshu Vyas commented on OFBIZ-11929: --- I have attached 2 patch files containing the fix for some of the string comparisons I found in the current code. Please have a look. > Fix Literals comparisons with variable to avoid NPE > --- > > Key: OFBIZ-11929 > URL: https://issues.apache.org/jira/browse/OFBIZ-11929 > Project: OFBiz > Issue Type: Improvement > Components: ALL COMPONENTS >Affects Versions: Trunk >Reporter: Devanshu Vyas >Assignee: Devanshu Vyas >Priority: Minor > Attachments: OFBIZ-11929_framework.patch, OFBIZ-11929_plugins.patch > > > With respect to our previous effort to fix the inconsistent string > comparisons[OFBIZ-9254], we are now creating a new ticket to continue this > effort. > In this ticket, we will cover all the remaining constants comparison with > variable that might lead to an NPE. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-9254) Inconsistent String Comparisons
[
https://issues.apache.org/jira/browse/OFBIZ-9254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17170534#comment-17170534
]
Devanshu Vyas commented on OFBIZ-9254:
--
Thanks Pawan and Jacques.
I have created a new [ticket|https://issues.apache.org/jira/browse/OFBIZ-11929]
for the remaining points of this ticket. We can also continue our discussion on
the other type of comparisons on that one.
> Inconsistent String Comparisons
> ---
>
> Key: OFBIZ-9254
> URL: https://issues.apache.org/jira/browse/OFBIZ-9254
> Project: OFBiz
> Issue Type: Improvement
> Components: ALL COMPONENTS
>Affects Versions: Trunk
>Reporter: Devanshu Vyas
>Assignee: Pawan Verma
>Priority: Minor
> Fix For: 18.12.01, 17.12.05
>
> Attachments: OFBIZ-9251_ftl_accounting.patch,
> OFBIZ-9251_ftl_framework.patch, OFBIZ-9251_ftl_manuf_workeffrt.patch,
> OFBIZ-9251_ftl_order.patch, OFBIZ-9251_ftl_party_content.patch,
> OFBIZ-9251_ftl_plugins_ebay_ebaystore.patch,
> OFBIZ-9251_ftl_plugins_ecommerce.patch,
> OFBIZ-9251_ftl_plugins_pricat_projmgr.patch, OFBIZ-9251_ftl_product.patch,
> OFBIZ-9251_ftl_themes.patch, OFBIZ-9254.patch, OFBIZ-9254_FTL-I.patch,
> OFBIZ-9254_groovy_applications.patch, OFBIZ-9254_groovy_framework.patch,
> OFBIZ-9254_java_Party_WE_MFC.patch, OFBIZ-9254_java_accounting.patch,
> OFBIZ-9254_java_base.patch, OFBIZ-9254_java_content.patch,
> OFBIZ-9254_java_entity.patch, OFBIZ-9254_java_order.patch,
> OFBIZ-9254_java_product.patch, OFBIZ-9254_java_service.patch,
> OFBIZ-9254_java_test_entityext_common_cattalina_datafile.patch,
> OFBIZ-9254_java_webapp.patch, OFBIZ-9254_java_webtools.patch,
> OFBIZ-9254_java_widget.patch, OFBIZ-9254_plugins.patch,
> OFBIZ-9254_plugins_groovy.patch, OFBIZ-9254_plugins_java.patch
>
>
> I found an inconsistency in the code for string comparison
> statusId.equals("PRUN_COMPLETED") whereas it should be written as
> "PRUN_COMPLETED".equals(statusId)
> cause the former can throw NullPointerException if the variable found to be
> NULL.
> This pattern should be applied to
> - Java Files
> - Groovy Files
> - FTL Files
> Here is the reference for the discussion done on the dev list.
> http://markmail.org/message/iqfaab3fl3ukxchy
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (OFBIZ-11929) Fix Literals comparisons with variable to avoid NPE
[ https://issues.apache.org/jira/browse/OFBIZ-11929?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Devanshu Vyas updated OFBIZ-11929: -- Attachment: OFBIZ-11929_framework.patch OFBIZ-11929_plugins.patch > Fix Literals comparisons with variable to avoid NPE > --- > > Key: OFBIZ-11929 > URL: https://issues.apache.org/jira/browse/OFBIZ-11929 > Project: OFBiz > Issue Type: Improvement > Components: ALL COMPONENTS >Affects Versions: Trunk >Reporter: Devanshu Vyas >Assignee: Devanshu Vyas >Priority: Minor > Attachments: OFBIZ-11929_framework.patch, OFBIZ-11929_plugins.patch > > > With respect to our previous effort to fix the inconsistent string > comparisons[OFBIZ-9254], we are now creating a new ticket to continue this > effort. > In this ticket, we will cover all the remaining constants comparison with > variable that might lead to an NPE. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (OFBIZ-11929) Fix Literals comparisons with variable to avoid NPE
Devanshu Vyas created OFBIZ-11929: - Summary: Fix Literals comparisons with variable to avoid NPE Key: OFBIZ-11929 URL: https://issues.apache.org/jira/browse/OFBIZ-11929 Project: OFBiz Issue Type: Bug Components: ALL COMPONENTS Affects Versions: Trunk Reporter: Devanshu Vyas Assignee: Devanshu Vyas With respect to our previous effort to fix the [inconsistent string comparisons|[http://issues.apache.org/jira/browse/OFBIZ-9254],] we are now creating a new ticket to continue this effort. In this ticket, we will cover all the remaining constants comparison with variable that might lead to an NPE. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-9254) Inconsistent String Comparisons
[
https://issues.apache.org/jira/browse/OFBIZ-9254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17167617#comment-17167617
]
Devanshu Vyas commented on OFBIZ-9254:
--
Yes, the last 2 patches which I added in May are pending. I think we should
reopen it and commit them.
Any other improvements or points can be later covered in a new ticket.
> Inconsistent String Comparisons
> ---
>
> Key: OFBIZ-9254
> URL: https://issues.apache.org/jira/browse/OFBIZ-9254
> Project: OFBiz
> Issue Type: Improvement
> Components: ALL COMPONENTS
>Affects Versions: Trunk
>Reporter: Devanshu Vyas
>Assignee: Jacques Le Roux
>Priority: Minor
> Fix For: 18.12.01, 17.12.05
>
> Attachments: OFBIZ-9251_ftl_accounting.patch,
> OFBIZ-9251_ftl_framework.patch, OFBIZ-9251_ftl_manuf_workeffrt.patch,
> OFBIZ-9251_ftl_order.patch, OFBIZ-9251_ftl_party_content.patch,
> OFBIZ-9251_ftl_plugins_ebay_ebaystore.patch,
> OFBIZ-9251_ftl_plugins_ecommerce.patch,
> OFBIZ-9251_ftl_plugins_pricat_projmgr.patch, OFBIZ-9251_ftl_product.patch,
> OFBIZ-9251_ftl_themes.patch, OFBIZ-9254.patch, OFBIZ-9254_FTL-I.patch,
> OFBIZ-9254_groovy_applications.patch, OFBIZ-9254_groovy_framework.patch,
> OFBIZ-9254_java_Party_WE_MFC.patch, OFBIZ-9254_java_accounting.patch,
> OFBIZ-9254_java_base.patch, OFBIZ-9254_java_content.patch,
> OFBIZ-9254_java_entity.patch, OFBIZ-9254_java_order.patch,
> OFBIZ-9254_java_product.patch, OFBIZ-9254_java_service.patch,
> OFBIZ-9254_java_test_entityext_common_cattalina_datafile.patch,
> OFBIZ-9254_java_webapp.patch, OFBIZ-9254_java_webtools.patch,
> OFBIZ-9254_java_widget.patch, OFBIZ-9254_plugins.patch,
> OFBIZ-9254_plugins_groovy.patch, OFBIZ-9254_plugins_java.patch
>
>
> I found an inconsistency in the code for string comparison
> statusId.equals("PRUN_COMPLETED") whereas it should be written as
> "PRUN_COMPLETED".equals(statusId)
> cause the former can throw NullPointerException if the variable found to be
> NULL.
> This pattern should be applied to
> - Java Files
> - Groovy Files
> - FTL Files
> Here is the reference for the discussion done on the dev list.
> http://markmail.org/message/iqfaab3fl3ukxchy
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (OFBIZ-9254) Inconsistent String Comparisons
[
https://issues.apache.org/jira/browse/OFBIZ-9254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17165421#comment-17165421
]
Devanshu Vyas commented on OFBIZ-9254:
--
I feel bad for mistakenly breaking the startsWith method in the
ContentManagementServices class. I also checked that similar mistakes were done
only in ContentManagementServices.
> Inconsistent String Comparisons
> ---
>
> Key: OFBIZ-9254
> URL: https://issues.apache.org/jira/browse/OFBIZ-9254
> Project: OFBiz
> Issue Type: Improvement
> Components: ALL COMPONENTS
>Affects Versions: Trunk
>Reporter: Devanshu Vyas
>Assignee: Devanshu Vyas
>Priority: Minor
> Attachments: OFBIZ-9251_ftl_accounting.patch,
> OFBIZ-9251_ftl_framework.patch, OFBIZ-9251_ftl_manuf_workeffrt.patch,
> OFBIZ-9251_ftl_order.patch, OFBIZ-9251_ftl_party_content.patch,
> OFBIZ-9251_ftl_plugins_ebay_ebaystore.patch,
> OFBIZ-9251_ftl_plugins_ecommerce.patch,
> OFBIZ-9251_ftl_plugins_pricat_projmgr.patch, OFBIZ-9251_ftl_product.patch,
> OFBIZ-9251_ftl_themes.patch, OFBIZ-9254.patch, OFBIZ-9254_FTL-I.patch,
> OFBIZ-9254_groovy_applications.patch, OFBIZ-9254_groovy_framework.patch,
> OFBIZ-9254_java_Party_WE_MFC.patch, OFBIZ-9254_java_accounting.patch,
> OFBIZ-9254_java_base.patch, OFBIZ-9254_java_content.patch,
> OFBIZ-9254_java_entity.patch, OFBIZ-9254_java_order.patch,
> OFBIZ-9254_java_product.patch, OFBIZ-9254_java_service.patch,
> OFBIZ-9254_java_test_entityext_common_cattalina_datafile.patch,
> OFBIZ-9254_java_webapp.patch, OFBIZ-9254_java_webtools.patch,
> OFBIZ-9254_java_widget.patch, OFBIZ-9254_plugins.patch,
> OFBIZ-9254_plugins_groovy.patch, OFBIZ-9254_plugins_java.patch
>
>
> I found an inconsistency in the code for string comparison
> statusId.equals("PRUN_COMPLETED") whereas it should be written as
> "PRUN_COMPLETED".equals(statusId)
> cause the former can throw NullPointerException if the variable found to be
> NULL.
> This pattern should be applied to
> - Java Files
> - Groovy Files
> - FTL Files
> Here is the reference for the discussion done on the dev list.
> http://markmail.org/message/iqfaab3fl3ukxchy
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (OFBIZ-10379) Exception handling for Add a new Party Role at createInvoiceRole
[ https://issues.apache.org/jira/browse/OFBIZ-10379?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Devanshu Vyas updated OFBIZ-10379: -- Sprint: OFBiz Community Day (May 2020) > Exception handling for Add a new Party Role at createInvoiceRole > > > Key: OFBIZ-10379 > URL: https://issues.apache.org/jira/browse/OFBIZ-10379 > Project: OFBiz > Issue Type: Bug > Environment: > https://demo-trunk.ofbiz.apache.org/ap/control/createInvoiceRole >Reporter: Aayush jain >Assignee: Pierre Smits >Priority: Minor > Attachments: Error.png, OFBIZ-10379.patch > > > Steps: > 1. Open URL https://demo-trunk.ofbiz.apache.org/ap/control/createInvoiceRole > 2. Add a party Id which does not assigned as a role for accounts > 3. Enter Percentage > 4. Click on submit button > Actual Result: > Throwing an exception error for the invalid case, Kindly refer attachment for > the same > Expected Result: > We must handle exceptions with a proper error message, I don't think this is > working fine, It should be correct with proper message. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-10379) Exception handling for Add a new Party Role at createInvoiceRole
[ https://issues.apache.org/jira/browse/OFBIZ-10379?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17114753#comment-17114753 ] Devanshu Vyas commented on OFBIZ-10379: --- I verified the patch is working properly and it can be committed. > Exception handling for Add a new Party Role at createInvoiceRole > > > Key: OFBIZ-10379 > URL: https://issues.apache.org/jira/browse/OFBIZ-10379 > Project: OFBiz > Issue Type: Bug > Environment: > https://demo-trunk.ofbiz.apache.org/ap/control/createInvoiceRole >Reporter: Aayush jain >Priority: Minor > Attachments: Error.png, OFBIZ-10379.patch > > > Steps: > 1. Open URL https://demo-trunk.ofbiz.apache.org/ap/control/createInvoiceRole > 2. Add a party Id which does not assigned as a role for accounts > 3. Enter Percentage > 4. Click on submit button > Actual Result: > Throwing an exception error for the invalid case, Kindly refer attachment for > the same > Expected Result: > We must handle exceptions with a proper error message, I don't think this is > working fine, It should be correct with proper message. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11482) Convert setPaymentStatus service from mini-lang to groovy DSL
[ https://issues.apache.org/jira/browse/OFBIZ-11482?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17114688#comment-17114688 ] Devanshu Vyas commented on OFBIZ-11482: --- I have created a pull request for the ticket. [https://github.com/apache/ofbiz-framework/pull/159] > Convert setPaymentStatus service from mini-lang to groovy DSL > - > > Key: OFBIZ-11482 > URL: https://issues.apache.org/jira/browse/OFBIZ-11482 > Project: OFBiz > Issue Type: Sub-task > Components: accounting >Affects Versions: Trunk >Reporter: Devanshu Vyas >Assignee: Devanshu Vyas >Priority: Minor > > Convert the setPaymentStatus service code from mini-lang to groovy DSL. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OFBIZ-11365) Convert setContentStatus service from mini-lang to groovy DSL
[ https://issues.apache.org/jira/browse/OFBIZ-11365?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Devanshu Vyas updated OFBIZ-11365: -- Attachment: OFBIZ-11365.patch > Convert setContentStatus service from mini-lang to groovy DSL > - > > Key: OFBIZ-11365 > URL: https://issues.apache.org/jira/browse/OFBIZ-11365 > Project: OFBiz > Issue Type: Sub-task > Components: content >Affects Versions: Trunk >Reporter: Devanshu Vyas >Assignee: Devanshu Vyas >Priority: Minor > Labels: patch-available > Attachments: OFBIZ-11365.patch, OFBIZ-11365.patch, OFBIZ-11365.patch > > > Convert the setContentStatus service code from mini lang to groovy DSL. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OFBIZ-11365) Convert setContentStatus service from mini-lang to groovy DSL
[ https://issues.apache.org/jira/browse/OFBIZ-11365?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Devanshu Vyas updated OFBIZ-11365: -- Attachment: (was: OFBIZ-11365.patch) > Convert setContentStatus service from mini-lang to groovy DSL > - > > Key: OFBIZ-11365 > URL: https://issues.apache.org/jira/browse/OFBIZ-11365 > Project: OFBiz > Issue Type: Sub-task > Components: content >Affects Versions: Trunk >Reporter: Devanshu Vyas >Assignee: Devanshu Vyas >Priority: Minor > Labels: patch-available > Attachments: OFBIZ-11365.patch, OFBIZ-11365.patch, OFBIZ-11365.patch > > > Convert the setContentStatus service code from mini lang to groovy DSL. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11365) Convert setContentStatus service from mini-lang to groovy DSL
[ https://issues.apache.org/jira/browse/OFBIZ-11365?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17114587#comment-17114587 ] Devanshu Vyas commented on OFBIZ-11365: --- Sorry for the confusion, it was indeed a mixup. I have corrected the patch and uploaded it. > Convert setContentStatus service from mini-lang to groovy DSL > - > > Key: OFBIZ-11365 > URL: https://issues.apache.org/jira/browse/OFBIZ-11365 > Project: OFBiz > Issue Type: Sub-task > Components: content >Affects Versions: Trunk >Reporter: Devanshu Vyas >Assignee: Devanshu Vyas >Priority: Minor > Labels: patch-available > Attachments: OFBIZ-11365.patch, OFBIZ-11365.patch, OFBIZ-11365.patch > > > Convert the setContentStatus service code from mini lang to groovy DSL. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OFBIZ-11365) Convert setContentStatus service from mini-lang to groovy DSL
[ https://issues.apache.org/jira/browse/OFBIZ-11365?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Devanshu Vyas updated OFBIZ-11365: -- Attachment: OFBIZ-11365.patch > Convert setContentStatus service from mini-lang to groovy DSL > - > > Key: OFBIZ-11365 > URL: https://issues.apache.org/jira/browse/OFBIZ-11365 > Project: OFBiz > Issue Type: Sub-task > Components: content >Affects Versions: Trunk >Reporter: Devanshu Vyas >Assignee: Devanshu Vyas >Priority: Minor > Labels: patch-available > Attachments: OFBIZ-11365.patch, OFBIZ-11365.patch, OFBIZ-11365.patch > > > Convert the setContentStatus service code from mini lang to groovy DSL. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-9254) Inconsistent String Comparisons
[
https://issues.apache.org/jira/browse/OFBIZ-9254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17099520#comment-17099520
]
Devanshu Vyas commented on OFBIZ-9254:
--
Thanks [~jleroux], [~pierresmits]. I will update the patches and add here.
Along with those, I found some more string comparisons and I would include
those as well here.
> Inconsistent String Comparisons
> ---
>
> Key: OFBIZ-9254
> URL: https://issues.apache.org/jira/browse/OFBIZ-9254
> Project: OFBiz
> Issue Type: Improvement
> Components: ALL COMPONENTS
>Affects Versions: Trunk
>Reporter: Devanshu Vyas
>Assignee: Devanshu Vyas
>Priority: Minor
> Attachments: OFBIZ-9251_ftl_accounting.patch,
> OFBIZ-9251_ftl_framework.patch, OFBIZ-9251_ftl_manuf_workeffrt.patch,
> OFBIZ-9251_ftl_order.patch, OFBIZ-9251_ftl_party_content.patch,
> OFBIZ-9251_ftl_plugins_ebay_ebaystore.patch,
> OFBIZ-9251_ftl_plugins_ecommerce.patch,
> OFBIZ-9251_ftl_plugins_pricat_projmgr.patch, OFBIZ-9251_ftl_product.patch,
> OFBIZ-9251_ftl_themes.patch, OFBIZ-9254.patch, OFBIZ-9254_FTL-I.patch,
> OFBIZ-9254_groovy_applications.patch, OFBIZ-9254_groovy_framework.patch,
> OFBIZ-9254_java_Party_WE_MFC.patch, OFBIZ-9254_java_accounting.patch,
> OFBIZ-9254_java_base.patch, OFBIZ-9254_java_content.patch,
> OFBIZ-9254_java_entity.patch, OFBIZ-9254_java_order.patch,
> OFBIZ-9254_java_product.patch, OFBIZ-9254_java_service.patch,
> OFBIZ-9254_java_test_entityext_common_cattalina_datafile.patch,
> OFBIZ-9254_java_webapp.patch, OFBIZ-9254_java_webtools.patch,
> OFBIZ-9254_java_widget.patch, OFBIZ-9254_plugins.patch,
> OFBIZ-9254_plugins_groovy.patch, OFBIZ-9254_plugins_java.patch
>
>
> I found an inconsistency in the code for string comparison
> statusId.equals("PRUN_COMPLETED") whereas it should be written as
> "PRUN_COMPLETED".equals(statusId)
> cause the former can throw NullPointerException if the variable found to be
> NULL.
> This pattern should be applied to
> - Java Files
> - Groovy Files
> - FTL Files
> Here is the reference for the discussion done on the dev list.
> http://markmail.org/message/iqfaab3fl3ukxchy
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (OFBIZ-9254) Inconsistent String Comparisons
[
https://issues.apache.org/jira/browse/OFBIZ-9254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17097987#comment-17097987
]
Devanshu Vyas commented on OFBIZ-9254:
--
I have prepared 2 patches, one for the ofbiz-framework and other for plugins.
Please have a look at the patch and let me know if this looks good.
> Inconsistent String Comparisons
> ---
>
> Key: OFBIZ-9254
> URL: https://issues.apache.org/jira/browse/OFBIZ-9254
> Project: OFBiz
> Issue Type: Improvement
> Components: ALL COMPONENTS
>Affects Versions: Trunk
>Reporter: Devanshu Vyas
>Assignee: Devanshu Vyas
>Priority: Minor
> Attachments: OFBIZ-9251_ftl_accounting.patch,
> OFBIZ-9251_ftl_framework.patch, OFBIZ-9251_ftl_manuf_workeffrt.patch,
> OFBIZ-9251_ftl_order.patch, OFBIZ-9251_ftl_party_content.patch,
> OFBIZ-9251_ftl_plugins_ebay_ebaystore.patch,
> OFBIZ-9251_ftl_plugins_ecommerce.patch,
> OFBIZ-9251_ftl_plugins_pricat_projmgr.patch, OFBIZ-9251_ftl_product.patch,
> OFBIZ-9251_ftl_themes.patch, OFBIZ-9254.patch, OFBIZ-9254_FTL-I.patch,
> OFBIZ-9254_groovy_applications.patch, OFBIZ-9254_groovy_framework.patch,
> OFBIZ-9254_java_Party_WE_MFC.patch, OFBIZ-9254_java_accounting.patch,
> OFBIZ-9254_java_base.patch, OFBIZ-9254_java_content.patch,
> OFBIZ-9254_java_entity.patch, OFBIZ-9254_java_order.patch,
> OFBIZ-9254_java_product.patch, OFBIZ-9254_java_service.patch,
> OFBIZ-9254_java_test_entityext_common_cattalina_datafile.patch,
> OFBIZ-9254_java_webapp.patch, OFBIZ-9254_java_webtools.patch,
> OFBIZ-9254_java_widget.patch, OFBIZ-9254_plugins.patch,
> OFBIZ-9254_plugins_groovy.patch, OFBIZ-9254_plugins_java.patch
>
>
> I found an inconsistency in the code for string comparison
> statusId.equals("PRUN_COMPLETED") whereas it should be written as
> "PRUN_COMPLETED".equals(statusId)
> cause the former can throw NullPointerException if the variable found to be
> NULL.
> This pattern should be applied to
> - Java Files
> - Groovy Files
> - FTL Files
> Here is the reference for the discussion done on the dev list.
> http://markmail.org/message/iqfaab3fl3ukxchy
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (OFBIZ-9254) Inconsistent String Comparisons
[
https://issues.apache.org/jira/browse/OFBIZ-9254?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Devanshu Vyas updated OFBIZ-9254:
-
Attachment: OFBIZ-9254_plugins.patch
OFBIZ-9254.patch
> Inconsistent String Comparisons
> ---
>
> Key: OFBIZ-9254
> URL: https://issues.apache.org/jira/browse/OFBIZ-9254
> Project: OFBiz
> Issue Type: Improvement
> Components: ALL COMPONENTS
>Affects Versions: Trunk
>Reporter: Devanshu Vyas
>Assignee: Devanshu Vyas
>Priority: Minor
> Attachments: OFBIZ-9251_ftl_accounting.patch,
> OFBIZ-9251_ftl_framework.patch, OFBIZ-9251_ftl_manuf_workeffrt.patch,
> OFBIZ-9251_ftl_order.patch, OFBIZ-9251_ftl_party_content.patch,
> OFBIZ-9251_ftl_plugins_ebay_ebaystore.patch,
> OFBIZ-9251_ftl_plugins_ecommerce.patch,
> OFBIZ-9251_ftl_plugins_pricat_projmgr.patch, OFBIZ-9251_ftl_product.patch,
> OFBIZ-9251_ftl_themes.patch, OFBIZ-9254.patch, OFBIZ-9254_FTL-I.patch,
> OFBIZ-9254_groovy_applications.patch, OFBIZ-9254_groovy_framework.patch,
> OFBIZ-9254_java_Party_WE_MFC.patch, OFBIZ-9254_java_accounting.patch,
> OFBIZ-9254_java_base.patch, OFBIZ-9254_java_content.patch,
> OFBIZ-9254_java_entity.patch, OFBIZ-9254_java_order.patch,
> OFBIZ-9254_java_product.patch, OFBIZ-9254_java_service.patch,
> OFBIZ-9254_java_test_entityext_common_cattalina_datafile.patch,
> OFBIZ-9254_java_webapp.patch, OFBIZ-9254_java_webtools.patch,
> OFBIZ-9254_java_widget.patch, OFBIZ-9254_plugins.patch,
> OFBIZ-9254_plugins_groovy.patch, OFBIZ-9254_plugins_java.patch
>
>
> I found an inconsistency in the code for string comparison
> statusId.equals("PRUN_COMPLETED") whereas it should be written as
> "PRUN_COMPLETED".equals(statusId)
> cause the former can throw NullPointerException if the variable found to be
> NULL.
> This pattern should be applied to
> - Java Files
> - Groovy Files
> - FTL Files
> Here is the reference for the discussion done on the dev list.
> http://markmail.org/message/iqfaab3fl3ukxchy
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (OFBIZ-11369) Convert findAssocContent service from mini-lang to groovy DSL
[ https://issues.apache.org/jira/browse/OFBIZ-11369?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17092166#comment-17092166 ] Devanshu Vyas commented on OFBIZ-11369: --- [~prakhar.kumar], I did a review of your patch and the first thing I noticed is that the validations on the service input parameters were removed. I think they should remain as is. > Convert findAssocContent service from mini-lang to groovy DSL > - > > Key: OFBIZ-11369 > URL: https://issues.apache.org/jira/browse/OFBIZ-11369 > Project: OFBiz > Issue Type: Sub-task > Components: content >Affects Versions: Trunk >Reporter: Devanshu Vyas >Assignee: Prakhar Kumar >Priority: Minor > Attachments: OFBIZ-11369.patch > > > Convert findAssocContent service code from mini-lang to groovy DSL. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11488) Convert getPaymentRunningTotal service from mini-lang to groovy DSL
[ https://issues.apache.org/jira/browse/OFBIZ-11488?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17092116#comment-17092116 ] Devanshu Vyas commented on OFBIZ-11488: --- [~nitish.mishra], I did a cursory review of your patch and you have forgotten to remove the simple-method implementation of the service in this patch. > Convert getPaymentRunningTotal service from mini-lang to groovy DSL > --- > > Key: OFBIZ-11488 > URL: https://issues.apache.org/jira/browse/OFBIZ-11488 > Project: OFBiz > Issue Type: Sub-task > Components: accounting >Affects Versions: Trunk >Reporter: Devanshu Vyas >Priority: Minor > Attachments: OFBIZ-11488.patch > > > Convert the getPaymentRunningTotal service code from mini-lang to groovy DSL. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11365) Convert setContentStatus service from mini-lang to groovy DSL
[ https://issues.apache.org/jira/browse/OFBIZ-11365?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17069436#comment-17069436 ] Devanshu Vyas commented on OFBIZ-11365: --- Added updated patch to resolve conflicts. > Convert setContentStatus service from mini-lang to groovy DSL > - > > Key: OFBIZ-11365 > URL: https://issues.apache.org/jira/browse/OFBIZ-11365 > Project: OFBiz > Issue Type: Sub-task > Components: content >Affects Versions: Trunk >Reporter: Devanshu Vyas >Assignee: Devanshu Vyas >Priority: Minor > Labels: patch-available > Attachments: OFBIZ-11365.patch, OFBIZ-11365.patch > > > Convert the setContentStatus service code from mini lang to groovy DSL. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OFBIZ-11365) Convert setContentStatus service from mini-lang to groovy DSL
[ https://issues.apache.org/jira/browse/OFBIZ-11365?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Devanshu Vyas updated OFBIZ-11365: -- Attachment: OFBIZ-11365.patch > Convert setContentStatus service from mini-lang to groovy DSL > - > > Key: OFBIZ-11365 > URL: https://issues.apache.org/jira/browse/OFBIZ-11365 > Project: OFBiz > Issue Type: Sub-task > Components: content >Affects Versions: Trunk >Reporter: Devanshu Vyas >Assignee: Devanshu Vyas >Priority: Minor > Labels: patch-available > Attachments: OFBIZ-11365.patch, OFBIZ-11365.patch > > > Convert the setContentStatus service code from mini lang to groovy DSL. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11366) Convert deactivateAllContentRoles service from mini-lang to groovy DSL
[ https://issues.apache.org/jira/browse/OFBIZ-11366?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17069432#comment-17069432 ] Devanshu Vyas commented on OFBIZ-11366: --- Hello [~jleroux], I have updated the patch containing below changes * Changed the name of the service from deactivateContentRoles to deactivateContentRole. * Updated the references of the service with respect to the change in the service name * Updated the service code to not fetch & iterate list but simply expire the ContentRole record. Let me know if this looks good. > Convert deactivateAllContentRoles service from mini-lang to groovy DSL > -- > > Key: OFBIZ-11366 > URL: https://issues.apache.org/jira/browse/OFBIZ-11366 > Project: OFBiz > Issue Type: Sub-task > Components: content >Affects Versions: Trunk >Reporter: Devanshu Vyas >Assignee: Devanshu Vyas >Priority: Minor > Attachments: OFBIZ-11366.patch, OFBIZ-11366.patch > > > Convert deactivateAllContentRoles service code from mini-lang to groovy DSL. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OFBIZ-11366) Convert deactivateAllContentRoles service from mini-lang to groovy DSL
[ https://issues.apache.org/jira/browse/OFBIZ-11366?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Devanshu Vyas updated OFBIZ-11366: -- Attachment: OFBIZ-11366.patch > Convert deactivateAllContentRoles service from mini-lang to groovy DSL > -- > > Key: OFBIZ-11366 > URL: https://issues.apache.org/jira/browse/OFBIZ-11366 > Project: OFBiz > Issue Type: Sub-task > Components: content >Affects Versions: Trunk >Reporter: Devanshu Vyas >Assignee: Devanshu Vyas >Priority: Minor > Attachments: OFBIZ-11366.patch, OFBIZ-11366.patch > > > Convert deactivateAllContentRoles service code from mini-lang to groovy DSL. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (OFBIZ-11503) Convert createInvoiceItemPayrol service from mini-lang to groovy DSL
Devanshu Vyas created OFBIZ-11503: - Summary: Convert createInvoiceItemPayrol service from mini-lang to groovy DSL Key: OFBIZ-11503 URL: https://issues.apache.org/jira/browse/OFBIZ-11503 Project: OFBiz Issue Type: Sub-task Components: accounting Affects Versions: Trunk Reporter: Devanshu Vyas Assignee: Devanshu Vyas Convert the createInvoiceItemPayrol service code from mini-lang to groovy DSL. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (OFBIZ-11501) Convert createPaymentContent service from mini-lang to groovy DSL
Devanshu Vyas created OFBIZ-11501: - Summary: Convert createPaymentContent service from mini-lang to groovy DSL Key: OFBIZ-11501 URL: https://issues.apache.org/jira/browse/OFBIZ-11501 Project: OFBiz Issue Type: Sub-task Components: accounting Affects Versions: Trunk Reporter: Devanshu Vyas Assignee: Devanshu Vyas Convert the createPaymentContent service code from mini-lang to groovy DSL. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (OFBIZ-11500) Convert createMatchingPaymentApplication service from mini-lang to groovy DSL
Devanshu Vyas created OFBIZ-11500: - Summary: Convert createMatchingPaymentApplication service from mini-lang to groovy DSL Key: OFBIZ-11500 URL: https://issues.apache.org/jira/browse/OFBIZ-11500 Project: OFBiz Issue Type: Sub-task Components: accounting Affects Versions: Trunk Reporter: Devanshu Vyas Assignee: Devanshu Vyas Convert the createMatchingPaymentApplication service code from mini-lang to groovy DSL. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (OFBIZ-11502) Convert updatePaymentContent service from mini-lang to groovy DSL
Devanshu Vyas created OFBIZ-11502: - Summary: Convert updatePaymentContent service from mini-lang to groovy DSL Key: OFBIZ-11502 URL: https://issues.apache.org/jira/browse/OFBIZ-11502 Project: OFBiz Issue Type: Sub-task Components: accounting Affects Versions: Trunk Reporter: Devanshu Vyas Assignee: Devanshu Vyas Convert the updatePaymentContent service code from mini-lang to groovy DSL. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (OFBIZ-11497) Convert checkAndCreateBatchForValidPayments service from mini-lang to groovy DSL
Devanshu Vyas created OFBIZ-11497: - Summary: Convert checkAndCreateBatchForValidPayments service from mini-lang to groovy DSL Key: OFBIZ-11497 URL: https://issues.apache.org/jira/browse/OFBIZ-11497 Project: OFBiz Issue Type: Sub-task Components: accounting Affects Versions: Trunk Reporter: Devanshu Vyas Assignee: Devanshu Vyas Convert the checkAndCreateBatchForValidPayments service code from mini-lang to groovy DSL. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (OFBIZ-11498) Convert massChangePaymentStatus service from mini-lang to groovy DSL
Devanshu Vyas created OFBIZ-11498: - Summary: Convert massChangePaymentStatus service from mini-lang to groovy DSL Key: OFBIZ-11498 URL: https://issues.apache.org/jira/browse/OFBIZ-11498 Project: OFBiz Issue Type: Sub-task Components: accounting Affects Versions: Trunk Reporter: Devanshu Vyas Assignee: Devanshu Vyas Convert the massChangePaymentStatus service code from mini-lang to groovy DSL. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (OFBIZ-11499) Convert createPaymentFromOrder service from mini-lang to groovy DSL
Devanshu Vyas created OFBIZ-11499: - Summary: Convert createPaymentFromOrder service from mini-lang to groovy DSL Key: OFBIZ-11499 URL: https://issues.apache.org/jira/browse/OFBIZ-11499 Project: OFBiz Issue Type: Sub-task Components: accounting Affects Versions: Trunk Reporter: Devanshu Vyas Assignee: Devanshu Vyas Convert the createPaymentFromOrder service code from mini-lang to groovy DSL. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (OFBIZ-11495) Convert getPayments service from mini-lang to groovy DSL
Devanshu Vyas created OFBIZ-11495: - Summary: Convert getPayments service from mini-lang to groovy DSL Key: OFBIZ-11495 URL: https://issues.apache.org/jira/browse/OFBIZ-11495 Project: OFBiz Issue Type: Sub-task Components: accounting Affects Versions: Trunk Reporter: Devanshu Vyas Assignee: Devanshu Vyas Convert the getPayments service code from mini-lang to groovy DSL. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (OFBIZ-11496) Convert getPaymentGroupReconciliationId service from mini-lang to groovy DSL
Devanshu Vyas created OFBIZ-11496: - Summary: Convert getPaymentGroupReconciliationId service from mini-lang to groovy DSL Key: OFBIZ-11496 URL: https://issues.apache.org/jira/browse/OFBIZ-11496 Project: OFBiz Issue Type: Sub-task Components: accounting Affects Versions: Trunk Reporter: Devanshu Vyas Assignee: Devanshu Vyas Convert the getPaymentGroupReconciliationId service code from mini-lang to groovy DSL. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (OFBIZ-11494) Convert cancelCheckRunPayments service from mini-lang to groovy DSL
Devanshu Vyas created OFBIZ-11494: - Summary: Convert cancelCheckRunPayments service from mini-lang to groovy DSL Key: OFBIZ-11494 URL: https://issues.apache.org/jira/browse/OFBIZ-11494 Project: OFBiz Issue Type: Sub-task Components: accounting Affects Versions: Trunk Reporter: Devanshu Vyas Assignee: Devanshu Vyas Convert the cancelCheckRunPayments service code from mini-lang to groovy DSL. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (OFBIZ-11492) Convert createFinAccoutnTransFromPayment service from mini-lang to groovy DSL
Devanshu Vyas created OFBIZ-11492: - Summary: Convert createFinAccoutnTransFromPayment service from mini-lang to groovy DSL Key: OFBIZ-11492 URL: https://issues.apache.org/jira/browse/OFBIZ-11492 Project: OFBiz Issue Type: Sub-task Components: accounting Affects Versions: Trunk Reporter: Devanshu Vyas Assignee: Devanshu Vyas Convert the createFinAccoutnTransFromPayment service code from mini-lang to groovy DSL. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (OFBIZ-11493) Convert createPaymentGroupAndMember service from mini-lang to groovy DSL
Devanshu Vyas created OFBIZ-11493: - Summary: Convert createPaymentGroupAndMember service from mini-lang to groovy DSL Key: OFBIZ-11493 URL: https://issues.apache.org/jira/browse/OFBIZ-11493 Project: OFBiz Issue Type: Sub-task Components: accounting Affects Versions: Trunk Reporter: Devanshu Vyas Assignee: Devanshu Vyas Convert the createPaymentGroupAndMember service code from mini-lang to groovy DSL. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (OFBIZ-11490) Convert createPaymentAndPaymentGroupForInvoices service from mini-lang to groovy DSL
Devanshu Vyas created OFBIZ-11490: - Summary: Convert createPaymentAndPaymentGroupForInvoices service from mini-lang to groovy DSL Key: OFBIZ-11490 URL: https://issues.apache.org/jira/browse/OFBIZ-11490 Project: OFBiz Issue Type: Sub-task Components: accounting Affects Versions: Trunk Reporter: Devanshu Vyas Assignee: Devanshu Vyas Convert the createPaymentAndPaymentGroupForInvoices service code from mini-lang to groovy DSL. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (OFBIZ-11491) Convert createPaymentAndApplicationForParty service from mini-lang to groovy DSL
Devanshu Vyas created OFBIZ-11491: - Summary: Convert createPaymentAndApplicationForParty service from mini-lang to groovy DSL Key: OFBIZ-11491 URL: https://issues.apache.org/jira/browse/OFBIZ-11491 Project: OFBiz Issue Type: Sub-task Components: accounting Affects Versions: Trunk Reporter: Devanshu Vyas Assignee: Devanshu Vyas Convert the createPaymentAndApplicationForParty service code from mini-lang to groovy DSL. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (OFBIZ-11489) Convert cancelPaymentBatch service from mini-lang to groovy DSL
Devanshu Vyas created OFBIZ-11489: - Summary: Convert cancelPaymentBatch service from mini-lang to groovy DSL Key: OFBIZ-11489 URL: https://issues.apache.org/jira/browse/OFBIZ-11489 Project: OFBiz Issue Type: Sub-task Components: accounting Affects Versions: Trunk Reporter: Devanshu Vyas Assignee: Devanshu Vyas Convert the cancelPaymentBatch service code from mini-lang to groovy DSL. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (OFBIZ-11487) Convert voidPayment service from mini-lang to groovy DSL
Devanshu Vyas created OFBIZ-11487: - Summary: Convert voidPayment service from mini-lang to groovy DSL Key: OFBIZ-11487 URL: https://issues.apache.org/jira/browse/OFBIZ-11487 Project: OFBiz Issue Type: Sub-task Components: accounting Affects Versions: Trunk Reporter: Devanshu Vyas Assignee: Devanshu Vyas Convert the voidPayment service code from mini-lang to groovy DSL. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (OFBIZ-11488) Convert getPaymentRunningTotal service from mini-lang to groovy DSL
Devanshu Vyas created OFBIZ-11488: - Summary: Convert getPaymentRunningTotal service from mini-lang to groovy DSL Key: OFBIZ-11488 URL: https://issues.apache.org/jira/browse/OFBIZ-11488 Project: OFBiz Issue Type: Sub-task Components: accounting Affects Versions: Trunk Reporter: Devanshu Vyas Assignee: Devanshu Vyas Convert the getPaymentRunningTotal service code from mini-lang to groovy DSL. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (OFBIZ-11485) Convert getInvoicePaymentInfoList service from mini-lang to groovy DSL
Devanshu Vyas created OFBIZ-11485: - Summary: Convert getInvoicePaymentInfoList service from mini-lang to groovy DSL Key: OFBIZ-11485 URL: https://issues.apache.org/jira/browse/OFBIZ-11485 Project: OFBiz Issue Type: Sub-task Components: accounting Affects Versions: Trunk Reporter: Devanshu Vyas Assignee: Devanshu Vyas Convert the getInvoicePaymentInfoList service code from mini-lang to groovy DSL. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (OFBIZ-11486) Convert getInvoicePaymentInfoListByDueDateOffset service from mini-lang to groovy DSL
Devanshu Vyas created OFBIZ-11486: - Summary: Convert getInvoicePaymentInfoListByDueDateOffset service from mini-lang to groovy DSL Key: OFBIZ-11486 URL: https://issues.apache.org/jira/browse/OFBIZ-11486 Project: OFBiz Issue Type: Sub-task Components: accounting Affects Versions: Trunk Reporter: Devanshu Vyas Assignee: Devanshu Vyas Convert the getInvoicePaymentInfoListByDueDateOffset service code from mini-lang to groovy DSL. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (OFBIZ-11483) Convert quickSendPayment service from mini-lang to groovy DSL
Devanshu Vyas created OFBIZ-11483: - Summary: Convert quickSendPayment service from mini-lang to groovy DSL Key: OFBIZ-11483 URL: https://issues.apache.org/jira/browse/OFBIZ-11483 Project: OFBiz Issue Type: Sub-task Components: accounting Affects Versions: Trunk Reporter: Devanshu Vyas Assignee: Devanshu Vyas Convert the quickSendPayment service code from mini-lang to groovy DSL. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (OFBIZ-11484) Convert createPaymentAndApplication service from mini-lang to groovy DSL
Devanshu Vyas created OFBIZ-11484: - Summary: Convert createPaymentAndApplication service from mini-lang to groovy DSL Key: OFBIZ-11484 URL: https://issues.apache.org/jira/browse/OFBIZ-11484 Project: OFBiz Issue Type: Sub-task Components: accounting Affects Versions: Trunk Reporter: Devanshu Vyas Assignee: Devanshu Vyas Convert the createPaymentAndApplication service code from mini-lang to groovy DSL. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (OFBIZ-11482) Convert setPaymentStatus service from mini-lang to groovy DSL
Devanshu Vyas created OFBIZ-11482: - Summary: Convert setPaymentStatus service from mini-lang to groovy DSL Key: OFBIZ-11482 URL: https://issues.apache.org/jira/browse/OFBIZ-11482 Project: OFBiz Issue Type: Sub-task Components: accounting Affects Versions: Trunk Reporter: Devanshu Vyas Assignee: Devanshu Vyas Convert the setPaymentStatus service code from mini-lang to groovy DSL. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (OFBIZ-11480) Convert updatePayment service from mini-lang to groovy DSL
Devanshu Vyas created OFBIZ-11480: - Summary: Convert updatePayment service from mini-lang to groovy DSL Key: OFBIZ-11480 URL: https://issues.apache.org/jira/browse/OFBIZ-11480 Project: OFBiz Issue Type: Sub-task Components: accounting Affects Versions: Trunk Reporter: Devanshu Vyas Assignee: Devanshu Vyas Convert the updatePayment service code from mini-lang to groovy DSL. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (OFBIZ-11481) Convert createPaymentApplication service from mini-lang to groovy DSL
Devanshu Vyas created OFBIZ-11481: - Summary: Convert createPaymentApplication service from mini-lang to groovy DSL Key: OFBIZ-11481 URL: https://issues.apache.org/jira/browse/OFBIZ-11481 Project: OFBiz Issue Type: Sub-task Components: accounting Affects Versions: Trunk Reporter: Devanshu Vyas Assignee: Devanshu Vyas Convert the createPaymentApplication service code from mini-lang to groovy DSL. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (OFBIZ-11479) Convert createPayment service from mini-lang to groovy DSL
Devanshu Vyas created OFBIZ-11479: - Summary: Convert createPayment service from mini-lang to groovy DSL Key: OFBIZ-11479 URL: https://issues.apache.org/jira/browse/OFBIZ-11479 Project: OFBiz Issue Type: Sub-task Components: accounting Affects Versions: Trunk Reporter: Devanshu Vyas Assignee: Devanshu Vyas Convert the createPayment service code from mini-lang to groovy DSL. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11366) Convert deactivateAllContentRoles service from mini-lang to groovy DSL
[ https://issues.apache.org/jira/browse/OFBIZ-11366?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17042849#comment-17042849 ] Devanshu Vyas commented on OFBIZ-11366: --- The name of the service is not appropriate as it only deactivates a specific roleTypeId, a specific partyId for a content. My opinion is to change the name of the service to be deactivateContentRole as it deactivates only a single record. WDYGT? > Convert deactivateAllContentRoles service from mini-lang to groovy DSL > -- > > Key: OFBIZ-11366 > URL: https://issues.apache.org/jira/browse/OFBIZ-11366 > Project: OFBiz > Issue Type: Sub-task > Components: content >Affects Versions: Trunk >Reporter: Devanshu Vyas >Assignee: Devanshu Vyas >Priority: Minor > Attachments: OFBIZ-11366.patch > > > Convert deactivateAllContentRoles service code from mini-lang to groovy DSL. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11366) Convert deactivateAllContentRoles service from mini-lang to groovy DSL
[ https://issues.apache.org/jira/browse/OFBIZ-11366?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17042848#comment-17042848 ] Devanshu Vyas commented on OFBIZ-11366: --- Uploaded the patch containing conversion of deactivateAllContentRoles service code from mini lang to groovy. Also the removal of the mini lang service. > Convert deactivateAllContentRoles service from mini-lang to groovy DSL > -- > > Key: OFBIZ-11366 > URL: https://issues.apache.org/jira/browse/OFBIZ-11366 > Project: OFBiz > Issue Type: Sub-task > Components: content >Affects Versions: Trunk >Reporter: Devanshu Vyas >Assignee: Devanshu Vyas >Priority: Minor > Attachments: OFBIZ-11366.patch > > > Convert deactivateAllContentRoles service code from mini-lang to groovy DSL. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OFBIZ-11366) Convert deactivateAllContentRoles service from mini-lang to groovy DSL
[ https://issues.apache.org/jira/browse/OFBIZ-11366?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Devanshu Vyas updated OFBIZ-11366: -- Attachment: OFBIZ-11366.patch > Convert deactivateAllContentRoles service from mini-lang to groovy DSL > -- > > Key: OFBIZ-11366 > URL: https://issues.apache.org/jira/browse/OFBIZ-11366 > Project: OFBiz > Issue Type: Sub-task > Components: content >Affects Versions: Trunk >Reporter: Devanshu Vyas >Assignee: Devanshu Vyas >Priority: Minor > Attachments: OFBIZ-11366.patch > > > Convert deactivateAllContentRoles service code from mini-lang to groovy DSL. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11365) Convert setContentStatus service from mini-lang to groovy DSL
[ https://issues.apache.org/jira/browse/OFBIZ-11365?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17042836#comment-17042836 ] Devanshu Vyas commented on OFBIZ-11365: --- Added patch file containing conversion of setContentStatus service code from mini lang to groovy. It also contains the removal of the mini lang service code removal from the system. > Convert setContentStatus service from mini-lang to groovy DSL > - > > Key: OFBIZ-11365 > URL: https://issues.apache.org/jira/browse/OFBIZ-11365 > Project: OFBiz > Issue Type: Sub-task > Components: content >Affects Versions: Trunk >Reporter: Devanshu Vyas >Assignee: Devanshu Vyas >Priority: Minor > Attachments: OFBIZ-11365.patch > > > Convert the setContentStatus service code from mini lang to groovy DSL. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OFBIZ-11365) Convert setContentStatus service from mini-lang to groovy DSL
[ https://issues.apache.org/jira/browse/OFBIZ-11365?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Devanshu Vyas updated OFBIZ-11365: -- Attachment: OFBIZ-11365.patch > Convert setContentStatus service from mini-lang to groovy DSL > - > > Key: OFBIZ-11365 > URL: https://issues.apache.org/jira/browse/OFBIZ-11365 > Project: OFBiz > Issue Type: Sub-task > Components: content >Affects Versions: Trunk >Reporter: Devanshu Vyas >Assignee: Devanshu Vyas >Priority: Minor > Attachments: OFBIZ-11365.patch > > > Convert the setContentStatus service code from mini lang to groovy DSL. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OFBIZ-11400) Product Images not rendering on One Page Checkout
[ https://issues.apache.org/jira/browse/OFBIZ-11400?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Devanshu Vyas updated OFBIZ-11400: -- Sprint: OFBiz Community Day (Feb 2020) > Product Images not rendering on One Page Checkout > - > > Key: OFBIZ-11400 > URL: https://issues.apache.org/jira/browse/OFBIZ-11400 > Project: OFBiz > Issue Type: Bug > Components: ecommerce >Affects Versions: Trunk > Environment: > https://demo-trunk.ofbiz.apache.org/ecommerce/control/onePageCheckout >Reporter: Archana Asthana >Assignee: Devanshu Vyas >Priority: Major > Attachments: OFBIZ-11400.patch, ProductImagesMissing.png, > ViewCartPage.png > > > Steps to Regenerate > 1. Login to https://demotrunk.ofbiz.apache.org/ecommerce/control/view/showcart > 2. Add a few products to the cart > 3. View Cart and check the added product images. > 4. Now click One Page Checkout link. > 5. Check the product images. > Actual: > Product Images are not reflecting on the screen on one-page checkout, though > they are visible on the view cart page. > The Image is attached for reference. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11400) Product Images not rendering on One Page Checkout
[ https://issues.apache.org/jira/browse/OFBIZ-11400?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17042493#comment-17042493 ] Devanshu Vyas commented on OFBIZ-11400: --- Uploaded the patch containing the fix. > Product Images not rendering on One Page Checkout > - > > Key: OFBIZ-11400 > URL: https://issues.apache.org/jira/browse/OFBIZ-11400 > Project: OFBiz > Issue Type: Bug > Components: ecommerce >Affects Versions: Trunk > Environment: > https://demo-trunk.ofbiz.apache.org/ecommerce/control/onePageCheckout >Reporter: Archana Asthana >Assignee: Devanshu Vyas >Priority: Major > Attachments: OFBIZ-11400.patch, ProductImagesMissing.png, > ViewCartPage.png > > > Steps to Regenerate > 1. Login to https://demotrunk.ofbiz.apache.org/ecommerce/control/view/showcart > 2. Add a few products to the cart > 3. View Cart and check the added product images. > 4. Now click One Page Checkout link. > 5. Check the product images. > Actual: > Product Images are not reflecting on the screen on one-page checkout, though > they are visible on the view cart page. > The Image is attached for reference. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OFBIZ-11400) Product Images not rendering on One Page Checkout
[ https://issues.apache.org/jira/browse/OFBIZ-11400?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Devanshu Vyas updated OFBIZ-11400: -- Attachment: OFBIZ-11400.patch > Product Images not rendering on One Page Checkout > - > > Key: OFBIZ-11400 > URL: https://issues.apache.org/jira/browse/OFBIZ-11400 > Project: OFBiz > Issue Type: Bug > Components: ecommerce >Affects Versions: Trunk > Environment: > https://demo-trunk.ofbiz.apache.org/ecommerce/control/onePageCheckout >Reporter: Archana Asthana >Assignee: Devanshu Vyas >Priority: Major > Attachments: OFBIZ-11400.patch, ProductImagesMissing.png, > ViewCartPage.png > > > Steps to Regenerate > 1. Login to https://demotrunk.ofbiz.apache.org/ecommerce/control/view/showcart > 2. Add a few products to the cart > 3. View Cart and check the added product images. > 4. Now click One Page Checkout link. > 5. Check the product images. > Actual: > Product Images are not reflecting on the screen on one-page checkout, though > they are visible on the view cart page. > The Image is attached for reference. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (OFBIZ-11400) Product Images not rendering on One Page Checkout
[ https://issues.apache.org/jira/browse/OFBIZ-11400?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Devanshu Vyas reassigned OFBIZ-11400: - Assignee: Devanshu Vyas > Product Images not rendering on One Page Checkout > - > > Key: OFBIZ-11400 > URL: https://issues.apache.org/jira/browse/OFBIZ-11400 > Project: OFBiz > Issue Type: Bug > Components: ecommerce >Affects Versions: Trunk > Environment: > https://demo-trunk.ofbiz.apache.org/ecommerce/control/onePageCheckout >Reporter: Archana Asthana >Assignee: Devanshu Vyas >Priority: Major > Attachments: ProductImagesMissing.png, ViewCartPage.png > > > Steps to Regenerate > 1. Login to https://demotrunk.ofbiz.apache.org/ecommerce/control/view/showcart > 2. Add a few products to the cart > 3. View Cart and check the added product images. > 4. Now click One Page Checkout link. > 5. Check the product images. > Actual: > Product Images are not reflecting on the screen on one-page checkout, though > they are visible on the view cart page. > The Image is attached for reference. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (OFBIZ-11392) Convert forceIndexContentKeywords service from mini-lang to groovy DSL
Devanshu Vyas created OFBIZ-11392: - Summary: Convert forceIndexContentKeywords service from mini-lang to groovy DSL Key: OFBIZ-11392 URL: https://issues.apache.org/jira/browse/OFBIZ-11392 Project: OFBiz Issue Type: Sub-task Components: content Affects Versions: Trunk Reporter: Devanshu Vyas Assignee: Devanshu Vyas Convert forceIndexContentKeywords service code from mini-lang to groovy DSL. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (OFBIZ-11393) Convert getSubSubContentWithPermCheck service from mini-lang to groovy DSL
Devanshu Vyas created OFBIZ-11393: - Summary: Convert getSubSubContentWithPermCheck service from mini-lang to groovy DSL Key: OFBIZ-11393 URL: https://issues.apache.org/jira/browse/OFBIZ-11393 Project: OFBiz Issue Type: Sub-task Components: content Affects Versions: Trunk Reporter: Devanshu Vyas Assignee: Devanshu Vyas Convert getSubSubContentWithPermCheck service code from mini-lang to groovy DSL. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (OFBIZ-11394) Convert getSubContentWithPermCheck service from mini-lang to groovy DSL
Devanshu Vyas created OFBIZ-11394: - Summary: Convert getSubContentWithPermCheck service from mini-lang to groovy DSL Key: OFBIZ-11394 URL: https://issues.apache.org/jira/browse/OFBIZ-11394 Project: OFBiz Issue Type: Sub-task Components: content Affects Versions: Trunk Reporter: Devanshu Vyas Assignee: Devanshu Vyas Convert getSubContentWithPermCheck service code from mini-lang to groovy DSL. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (OFBIZ-11389) Convert createContentAlternativeUrl service from mini-lang to groovy DSL
Devanshu Vyas created OFBIZ-11389: - Summary: Convert createContentAlternativeUrl service from mini-lang to groovy DSL Key: OFBIZ-11389 URL: https://issues.apache.org/jira/browse/OFBIZ-11389 Project: OFBiz Issue Type: Sub-task Components: content Affects Versions: Trunk Reporter: Devanshu Vyas Assignee: Devanshu Vyas Convert createContentAlternativeUrl service code from mini-lang to groovy DSL. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (OFBIZ-11390) Convert indexContentKeywords service from mini-lang to groovy DSL
Devanshu Vyas created OFBIZ-11390: - Summary: Convert indexContentKeywords service from mini-lang to groovy DSL Key: OFBIZ-11390 URL: https://issues.apache.org/jira/browse/OFBIZ-11390 Project: OFBiz Issue Type: Sub-task Components: content Affects Versions: Trunk Reporter: Devanshu Vyas Assignee: Devanshu Vyas Convert indexContentKeywords service code from mini-lang to groovy DSL. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (OFBIZ-11388) Convert createMissingContentAltUrls service from mini-lang to groovy DSL
Devanshu Vyas created OFBIZ-11388: - Summary: Convert createMissingContentAltUrls service from mini-lang to groovy DSL Key: OFBIZ-11388 URL: https://issues.apache.org/jira/browse/OFBIZ-11388 Project: OFBiz Issue Type: Sub-task Components: content Affects Versions: Trunk Reporter: Devanshu Vyas Convert createMissingContentAltUrls service code from mini-lang to groovy DSL. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (OFBIZ-11387) Convert createMissingCategoryContentAltUrlInline service from mini-lang to groovy DSL
Devanshu Vyas created OFBIZ-11387: - Summary: Convert createMissingCategoryContentAltUrlInline service from mini-lang to groovy DSL Key: OFBIZ-11387 URL: https://issues.apache.org/jira/browse/OFBIZ-11387 Project: OFBiz Issue Type: Sub-task Components: content Affects Versions: Trunk Reporter: Devanshu Vyas Convert createMissingCategoryContentAltUrlInline service code from mini-lang to groovy DSL. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (OFBIZ-11391) Convert deleteContentKeywords service from mini-lang to groovy DSL
Devanshu Vyas created OFBIZ-11391: - Summary: Convert deleteContentKeywords service from mini-lang to groovy DSL Key: OFBIZ-11391 URL: https://issues.apache.org/jira/browse/OFBIZ-11391 Project: OFBiz Issue Type: Sub-task Components: content Affects Versions: Trunk Reporter: Devanshu Vyas Assignee: Devanshu Vyas Convert deleteContentKeywords service code from mini-lang to groovy DSL. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (OFBIZ-11380) Convert createCommEventContentAssoc service from mini-lang to groovy DSL
Devanshu Vyas created OFBIZ-11380: - Summary: Convert createCommEventContentAssoc service from mini-lang to groovy DSL Key: OFBIZ-11380 URL: https://issues.apache.org/jira/browse/OFBIZ-11380 Project: OFBiz Issue Type: Sub-task Components: content Affects Versions: Trunk Reporter: Devanshu Vyas Assignee: Devanshu Vyas Convert createCommEventContentAssoc service code from mini-lang to groovy DSL. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (OFBIZ-11381) Convert getDataResource service from mini-lang to groovy DSL
Devanshu Vyas created OFBIZ-11381: - Summary: Convert getDataResource service from mini-lang to groovy DSL Key: OFBIZ-11381 URL: https://issues.apache.org/jira/browse/OFBIZ-11381 Project: OFBiz Issue Type: Sub-task Components: content Affects Versions: Trunk Reporter: Devanshu Vyas Assignee: Devanshu Vyas Convert getDataResource service code from mini-lang to groovy DSL. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (OFBIZ-11382) Convert getContentAndDataResource service from mini-lang to groovy DSL
Devanshu Vyas created OFBIZ-11382: - Summary: Convert getContentAndDataResource service from mini-lang to groovy DSL Key: OFBIZ-11382 URL: https://issues.apache.org/jira/browse/OFBIZ-11382 Project: OFBiz Issue Type: Sub-task Components: content Affects Versions: Trunk Reporter: Devanshu Vyas Assignee: Devanshu Vyas Convert getContentAndDataResource service code from mini-lang to groovy DSL. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (OFBIZ-11383) Convert createArticleContent service from mini-lang to groovy DSL
Devanshu Vyas created OFBIZ-11383: - Summary: Convert createArticleContent service from mini-lang to groovy DSL Key: OFBIZ-11383 URL: https://issues.apache.org/jira/browse/OFBIZ-11383 Project: OFBiz Issue Type: Sub-task Components: content Affects Versions: Trunk Reporter: Devanshu Vyas Assignee: Devanshu Vyas Convert createArticleContent service code from mini-lang to groovy DSL. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (OFBIZ-11378) Convert createCommContentDataResource service from mini-lang to groovy DSL
Devanshu Vyas created OFBIZ-11378: - Summary: Convert createCommContentDataResource service from mini-lang to groovy DSL Key: OFBIZ-11378 URL: https://issues.apache.org/jira/browse/OFBIZ-11378 Project: OFBiz Issue Type: Sub-task Components: content Affects Versions: Trunk Reporter: Devanshu Vyas Assignee: Devanshu Vyas Convert createCommContentDataResource service code from mini-lang to groovy DSL. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (OFBIZ-11379) Convert updateCommContentDataResource service from mini-lang to groovy DSL
Devanshu Vyas created OFBIZ-11379: - Summary: Convert updateCommContentDataResource service from mini-lang to groovy DSL Key: OFBIZ-11379 URL: https://issues.apache.org/jira/browse/OFBIZ-11379 Project: OFBiz Issue Type: Sub-task Components: content Affects Versions: Trunk Reporter: Devanshu Vyas Assignee: Devanshu Vyas Convert updateCommContentDataResource service code from mini-lang to groovy DSL. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (OFBIZ-11377) Convert createContentFromDataResource service from mini-lang to groovy DSL
Devanshu Vyas created OFBIZ-11377: - Summary: Convert createContentFromDataResource service from mini-lang to groovy DSL Key: OFBIZ-11377 URL: https://issues.apache.org/jira/browse/OFBIZ-11377 Project: OFBiz Issue Type: Sub-task Components: content Affects Versions: Trunk Reporter: Devanshu Vyas Assignee: Devanshu Vyas Convert createContentFromDataResource service code from mini-lang to groovy DSL. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (OFBIZ-11376) Convert createTopic service from mini-lang to groovy DSL
Devanshu Vyas created OFBIZ-11376: - Summary: Convert createTopic service from mini-lang to groovy DSL Key: OFBIZ-11376 URL: https://issues.apache.org/jira/browse/OFBIZ-11376 Project: OFBiz Issue Type: Sub-task Components: content Affects Versions: Trunk Reporter: Devanshu Vyas Assignee: Devanshu Vyas Convert createTopic service code from mini-lang to groovy DSL. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (OFBIZ-11370) Convert createEmailContent service from mini-lang to groovy DSL
Devanshu Vyas created OFBIZ-11370: - Summary: Convert createEmailContent service from mini-lang to groovy DSL Key: OFBIZ-11370 URL: https://issues.apache.org/jira/browse/OFBIZ-11370 Project: OFBiz Issue Type: Sub-task Components: content Affects Versions: Trunk Reporter: Devanshu Vyas Assignee: Devanshu Vyas Convert createEmailContent service code from mini-lang to groovy DSL. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (OFBIZ-11374) Convert createSimpleTextContent service from mini-lang to groovy DSL
Devanshu Vyas created OFBIZ-11374: - Summary: Convert createSimpleTextContent service from mini-lang to groovy DSL Key: OFBIZ-11374 URL: https://issues.apache.org/jira/browse/OFBIZ-11374 Project: OFBiz Issue Type: Sub-task Components: content Affects Versions: Trunk Reporter: Devanshu Vyas Assignee: Devanshu Vyas Convert createSimpleTextContent service code from mini-lang to groovy DSL. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (OFBIZ-11371) Convert updateEmailContent service from mini-lang to groovy DSL
Devanshu Vyas created OFBIZ-11371: - Summary: Convert updateEmailContent service from mini-lang to groovy DSL Key: OFBIZ-11371 URL: https://issues.apache.org/jira/browse/OFBIZ-11371 Project: OFBiz Issue Type: Sub-task Components: content Affects Versions: Trunk Reporter: Devanshu Vyas Assignee: Devanshu Vyas Convert updateEmailContent service code from mini-lang to groovy DSL. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (OFBIZ-11373) Convert updateDownloadContent service from mini-lang to groovy DSL
Devanshu Vyas created OFBIZ-11373: - Summary: Convert updateDownloadContent service from mini-lang to groovy DSL Key: OFBIZ-11373 URL: https://issues.apache.org/jira/browse/OFBIZ-11373 Project: OFBiz Issue Type: Sub-task Components: content Affects Versions: Trunk Reporter: Devanshu Vyas Assignee: Devanshu Vyas Convert updateDownloadContent service code from mini-lang to groovy DSL. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (OFBIZ-11372) Convert createDownloadContent service from mini-lang to groovy DSL
Devanshu Vyas created OFBIZ-11372: - Summary: Convert createDownloadContent service from mini-lang to groovy DSL Key: OFBIZ-11372 URL: https://issues.apache.org/jira/browse/OFBIZ-11372 Project: OFBiz Issue Type: Sub-task Components: content Affects Versions: Trunk Reporter: Devanshu Vyas Assignee: Devanshu Vyas Convert createDownloadContent service code from mini-lang to groovy DSL. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (OFBIZ-11375) Convert updateSimpleTextContent service from mini-lang to groovy DSL
Devanshu Vyas created OFBIZ-11375: - Summary: Convert updateSimpleTextContent service from mini-lang to groovy DSL Key: OFBIZ-11375 URL: https://issues.apache.org/jira/browse/OFBIZ-11375 Project: OFBiz Issue Type: Sub-task Components: content Affects Versions: Trunk Reporter: Devanshu Vyas Assignee: Devanshu Vyas Convert updateSimpleTextContent service code from mini-lang to groovy DSL. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (OFBIZ-11368) Convert createTextAndUploadedContent service from mini-lang to groovy DSL
Devanshu Vyas created OFBIZ-11368: - Summary: Convert createTextAndUploadedContent service from mini-lang to groovy DSL Key: OFBIZ-11368 URL: https://issues.apache.org/jira/browse/OFBIZ-11368 Project: OFBiz Issue Type: Sub-task Components: content Affects Versions: Trunk Reporter: Devanshu Vyas Assignee: Devanshu Vyas Convert createTextAndUploadedContent service code from mini-lang to groovy DSL. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (OFBIZ-11367) Convert updateSingleContentPurpose service from mini-lang to groovy DSL
Devanshu Vyas created OFBIZ-11367: - Summary: Convert updateSingleContentPurpose service from mini-lang to groovy DSL Key: OFBIZ-11367 URL: https://issues.apache.org/jira/browse/OFBIZ-11367 Project: OFBiz Issue Type: Sub-task Components: content Affects Versions: Trunk Reporter: Devanshu Vyas Assignee: Devanshu Vyas Convert updateSingleContentPurpose service code from mini-lang to groovy DSL. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (OFBIZ-11369) Convert findAssocContent service from mini-lang to groovy DSL
Devanshu Vyas created OFBIZ-11369: - Summary: Convert findAssocContent service from mini-lang to groovy DSL Key: OFBIZ-11369 URL: https://issues.apache.org/jira/browse/OFBIZ-11369 Project: OFBiz Issue Type: Sub-task Components: content Affects Versions: Trunk Reporter: Devanshu Vyas Assignee: Devanshu Vyas Convert findAssocContent service code from mini-lang to groovy DSL. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (OFBIZ-11366) Convert deactivateAllContentRoles service from mini-lang to groovy DSL
Devanshu Vyas created OFBIZ-11366: - Summary: Convert deactivateAllContentRoles service from mini-lang to groovy DSL Key: OFBIZ-11366 URL: https://issues.apache.org/jira/browse/OFBIZ-11366 Project: OFBiz Issue Type: Sub-task Components: content Affects Versions: Trunk Reporter: Devanshu Vyas Assignee: Devanshu Vyas Convert deactivateAllContentRoles service code from mini-lang to groovy DSL. -- This message was sent by Atlassian Jira (v8.3.4#803005)
