[jira] [Comment Edited] (OFBIZ-9464) Accounting quantity transfer should not be zero while transferring inventory from one facility to another

2017-07-08 Thread Divesh Dutta (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-9464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16079199#comment-16079199
 ] 

Divesh Dutta edited comment on OFBIZ-9464 at 7/8/17 5:07 PM:
-

Fixed this issue in revision number 1801300 in ofbiz-framework/trunk. Thanks 
[~vaibhav.jain] for providing the fix


was (Author: diveshdut):
Fixed this issue in revision number 1801300. Thanks [~vaibhav.jain] for 
providing the fix

> Accounting quantity transfer should not be zero while transferring inventory 
> from one facility to another
> -
>
> Key: OFBIZ-9464
> URL: https://issues.apache.org/jira/browse/OFBIZ-9464
> Project: OFBiz
>  Issue Type: Bug
>Affects Versions: Trunk
>Reporter: Vaibhav Jain
>Assignee: Divesh Dutta
> Fix For: Upcoming Release
>
> Attachments: OFBIZ_9464.patch
>
>
> when we transfer inventory, the accountingQuantityTotal field of 
> _InventoryItem_ entity is always ZERO. There is no reflection of ATP/QOH in 
> accountingQuantityTotal.
> This will create following issues in the system.
> # Accounting quantity total will mismatch with the original quantity in the 
> facility which shows the wrong result when we calculate facility specific 
> inventory valuation.
> # Inventory reservation also throws an error in some specific case like when 
> AQT of respective product is zero in the specific facility from when 
> reservation happens.
> As we manage 5 different statuses of inventory transfer in OFBiz and 
> according to my current understanding these processes are associated with the 
> respective statuses, which are as show below
> Requested: As inventory transfer is requested for another facility. 
> a)ATP, QOH and AQT should decrease from the inventory item of From Facility 
> and QOH of To Facility should increase.
> b)ATP and AQT should be Zero in To Facility as inventory is not transferred 
> yet. But QOH should increase at To Facility because QOH shows the 
> xferquantity later. At the time of the completion of the transfer
> ATP = ATP + (QOH - ATP) (Adjustment in case of backorder)
> AQT = QOH
> b)AQT should not decrease because AQT is used for accounting purpose and as 
> of now quantity is still in From Facility as the transfer is not done yet. 
> which shows the xferQuantity later 
> Scheduled: As inventory transfer is Scheduled for another facility. ATP, QOH 
> and AQT should not affect in both From Facility and To Facility.
> En-route: As inventory is routed to reach at To Facility. Even in this case 
> ATP, QOH and AQT should not affect in both From Facility and To Facility.
> Complete: As inventory transfer is completed 
> a)ATP, QOH and AQT should not affect at From Facility. 
> b)QOH will be same but ATP and AQT should affect respectively
> ATP = ATP + (QOH - ATP)
> AQT = QOH
> Cancelled: As inventory transfer is cancelled and inventory item record is 
> already created  so 
> a) ATP, QOH and AQT should decrease from old inventory item and ATP, QOH and 
> AQT should increase in the newly created inventory item.
> Key points: 
> If the whole ATP and QOH is moved then new inventory item will not create. 
> Only Facility and location are changed for existing inventory item.
> Before Changes:-
> As I know there are following processes are associated with respective 
> statuses 
> **Note:   ATP-> Available to promiseQOH-> Quantity on handAQT-> 
> Accounting quantity total
> 1. Requested:-
> ATP =0QOH=Transferred quantity
>AQT=0
> 2. Scheduled:-
> ATP =0QOH=Transferred quantity
>AQT=0
> 3.En-Route:-
> ATP =0QOH=Transferred quantity
>AQT=0
> 4.Complete:-
> If the partial quantity of any inventory item is transferred.
> ATP =Transferred quantity   QOH=Transferred quantity   AQT=0
> If the whole quantity is transferred then only facility id and location 
> will change no new inventory item record will create. 
> 5.Cancelled:-
> No new inventory item record will create. An inventory transfer record is 
> created with whole ATP/QOH in cancelled status.
> After Changes:-
> As shown above, accounting quantity transfer will not affect in transfer 
> inventory. After the following changes, records will be updated a shown below.
> 1. Requested:-
> ATP =0QOH=Transferred quantity
>AQT=0
> 2. Scheduled:-
> ATP =0QOH=Transferred quantity
>AQT=0
> 3.En-Route:-
> ATP =0QOH=Transferred quantity
>AQT=0
> 4.Complete:-
> If the partial quantity of any in

[jira] [Updated] (OFBIZ-9464) Accounting quantity transfer should not be zero while transferring inventory from one facility to another

2017-07-08 Thread Divesh Dutta (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-9464?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Divesh Dutta updated OFBIZ-9464:

Fix Version/s: (was: Trunk)
   Upcoming Release

> Accounting quantity transfer should not be zero while transferring inventory 
> from one facility to another
> -
>
> Key: OFBIZ-9464
> URL: https://issues.apache.org/jira/browse/OFBIZ-9464
> Project: OFBiz
>  Issue Type: Bug
>Affects Versions: Trunk
>Reporter: Vaibhav Jain
>Assignee: Divesh Dutta
> Fix For: Upcoming Release
>
> Attachments: OFBIZ_9464.patch
>
>
> when we transfer inventory, the accountingQuantityTotal field of 
> _InventoryItem_ entity is always ZERO. There is no reflection of ATP/QOH in 
> accountingQuantityTotal.
> This will create following issues in the system.
> # Accounting quantity total will mismatch with the original quantity in the 
> facility which shows the wrong result when we calculate facility specific 
> inventory valuation.
> # Inventory reservation also throws an error in some specific case like when 
> AQT of respective product is zero in the specific facility from when 
> reservation happens.
> As we manage 5 different statuses of inventory transfer in OFBiz and 
> according to my current understanding these processes are associated with the 
> respective statuses, which are as show below
> Requested: As inventory transfer is requested for another facility. 
> a)ATP, QOH and AQT should decrease from the inventory item of From Facility 
> and QOH of To Facility should increase.
> b)ATP and AQT should be Zero in To Facility as inventory is not transferred 
> yet. But QOH should increase at To Facility because QOH shows the 
> xferquantity later. At the time of the completion of the transfer
> ATP = ATP + (QOH - ATP) (Adjustment in case of backorder)
> AQT = QOH
> b)AQT should not decrease because AQT is used for accounting purpose and as 
> of now quantity is still in From Facility as the transfer is not done yet. 
> which shows the xferQuantity later 
> Scheduled: As inventory transfer is Scheduled for another facility. ATP, QOH 
> and AQT should not affect in both From Facility and To Facility.
> En-route: As inventory is routed to reach at To Facility. Even in this case 
> ATP, QOH and AQT should not affect in both From Facility and To Facility.
> Complete: As inventory transfer is completed 
> a)ATP, QOH and AQT should not affect at From Facility. 
> b)QOH will be same but ATP and AQT should affect respectively
> ATP = ATP + (QOH - ATP)
> AQT = QOH
> Cancelled: As inventory transfer is cancelled and inventory item record is 
> already created  so 
> a) ATP, QOH and AQT should decrease from old inventory item and ATP, QOH and 
> AQT should increase in the newly created inventory item.
> Key points: 
> If the whole ATP and QOH is moved then new inventory item will not create. 
> Only Facility and location are changed for existing inventory item.
> Before Changes:-
> As I know there are following processes are associated with respective 
> statuses 
> **Note:   ATP-> Available to promiseQOH-> Quantity on handAQT-> 
> Accounting quantity total
> 1. Requested:-
> ATP =0QOH=Transferred quantity
>AQT=0
> 2. Scheduled:-
> ATP =0QOH=Transferred quantity
>AQT=0
> 3.En-Route:-
> ATP =0QOH=Transferred quantity
>AQT=0
> 4.Complete:-
> If the partial quantity of any inventory item is transferred.
> ATP =Transferred quantity   QOH=Transferred quantity   AQT=0
> If the whole quantity is transferred then only facility id and location 
> will change no new inventory item record will create. 
> 5.Cancelled:-
> No new inventory item record will create. An inventory transfer record is 
> created with whole ATP/QOH in cancelled status.
> After Changes:-
> As shown above, accounting quantity transfer will not affect in transfer 
> inventory. After the following changes, records will be updated a shown below.
> 1. Requested:-
> ATP =0QOH=Transferred quantity
>AQT=0
> 2. Scheduled:-
> ATP =0QOH=Transferred quantity
>AQT=0
> 3.En-Route:-
> ATP =0QOH=Transferred quantity
>AQT=0
> 4.Complete:-
> If the partial quantity of any inventory item is transferred.
> ATP =Transferred quantity   QOH=Transferred quantity   
> AQT=Transferred quantity
> If the whole quantity is transferred then only facility id and location 
> will change no new inventory item record will create. 
> 5.C

[jira] [Resolved] (OFBIZ-9464) Accounting quantity transfer should not be zero while transferring inventory from one facility to another

2017-07-08 Thread Divesh Dutta (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-9464?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Divesh Dutta resolved OFBIZ-9464.
-
Resolution: Fixed

Fixed this issue in revision number 1801300. Thanks [~vaibhav.jain] for 
providing the fix

> Accounting quantity transfer should not be zero while transferring inventory 
> from one facility to another
> -
>
> Key: OFBIZ-9464
> URL: https://issues.apache.org/jira/browse/OFBIZ-9464
> Project: OFBiz
>  Issue Type: Bug
>Affects Versions: Trunk
>Reporter: Vaibhav Jain
>Assignee: Divesh Dutta
> Fix For: Trunk
>
> Attachments: OFBIZ_9464.patch
>
>
> when we transfer inventory, the accountingQuantityTotal field of 
> _InventoryItem_ entity is always ZERO. There is no reflection of ATP/QOH in 
> accountingQuantityTotal.
> This will create following issues in the system.
> # Accounting quantity total will mismatch with the original quantity in the 
> facility which shows the wrong result when we calculate facility specific 
> inventory valuation.
> # Inventory reservation also throws an error in some specific case like when 
> AQT of respective product is zero in the specific facility from when 
> reservation happens.
> As we manage 5 different statuses of inventory transfer in OFBiz and 
> according to my current understanding these processes are associated with the 
> respective statuses, which are as show below
> Requested: As inventory transfer is requested for another facility. 
> a)ATP, QOH and AQT should decrease from the inventory item of From Facility 
> and QOH of To Facility should increase.
> b)ATP and AQT should be Zero in To Facility as inventory is not transferred 
> yet. But QOH should increase at To Facility because QOH shows the 
> xferquantity later. At the time of the completion of the transfer
> ATP = ATP + (QOH - ATP) (Adjustment in case of backorder)
> AQT = QOH
> b)AQT should not decrease because AQT is used for accounting purpose and as 
> of now quantity is still in From Facility as the transfer is not done yet. 
> which shows the xferQuantity later 
> Scheduled: As inventory transfer is Scheduled for another facility. ATP, QOH 
> and AQT should not affect in both From Facility and To Facility.
> En-route: As inventory is routed to reach at To Facility. Even in this case 
> ATP, QOH and AQT should not affect in both From Facility and To Facility.
> Complete: As inventory transfer is completed 
> a)ATP, QOH and AQT should not affect at From Facility. 
> b)QOH will be same but ATP and AQT should affect respectively
> ATP = ATP + (QOH - ATP)
> AQT = QOH
> Cancelled: As inventory transfer is cancelled and inventory item record is 
> already created  so 
> a) ATP, QOH and AQT should decrease from old inventory item and ATP, QOH and 
> AQT should increase in the newly created inventory item.
> Key points: 
> If the whole ATP and QOH is moved then new inventory item will not create. 
> Only Facility and location are changed for existing inventory item.
> Before Changes:-
> As I know there are following processes are associated with respective 
> statuses 
> **Note:   ATP-> Available to promiseQOH-> Quantity on handAQT-> 
> Accounting quantity total
> 1. Requested:-
> ATP =0QOH=Transferred quantity
>AQT=0
> 2. Scheduled:-
> ATP =0QOH=Transferred quantity
>AQT=0
> 3.En-Route:-
> ATP =0QOH=Transferred quantity
>AQT=0
> 4.Complete:-
> If the partial quantity of any inventory item is transferred.
> ATP =Transferred quantity   QOH=Transferred quantity   AQT=0
> If the whole quantity is transferred then only facility id and location 
> will change no new inventory item record will create. 
> 5.Cancelled:-
> No new inventory item record will create. An inventory transfer record is 
> created with whole ATP/QOH in cancelled status.
> After Changes:-
> As shown above, accounting quantity transfer will not affect in transfer 
> inventory. After the following changes, records will be updated a shown below.
> 1. Requested:-
> ATP =0QOH=Transferred quantity
>AQT=0
> 2. Scheduled:-
> ATP =0QOH=Transferred quantity
>AQT=0
> 3.En-Route:-
> ATP =0QOH=Transferred quantity
>AQT=0
> 4.Complete:-
> If the partial quantity of any inventory item is transferred.
> ATP =Transferred quantity   QOH=Transferred quantity   
> AQT=Transferred quantity
> If the whole quantity is transferred then only facility id and location 
> will change no new inventor

[jira] [Assigned] (OFBIZ-9464) Accounting quantity transfer should not be zero while transferring inventory from one facility to another

2017-07-08 Thread Divesh Dutta (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-9464?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Divesh Dutta reassigned OFBIZ-9464:
---

Assignee: Divesh Dutta  (was: Vaibhav Jain)

> Accounting quantity transfer should not be zero while transferring inventory 
> from one facility to another
> -
>
> Key: OFBIZ-9464
> URL: https://issues.apache.org/jira/browse/OFBIZ-9464
> Project: OFBiz
>  Issue Type: Bug
>Affects Versions: Trunk
>Reporter: Vaibhav Jain
>Assignee: Divesh Dutta
> Fix For: Trunk
>
> Attachments: OFBIZ_9464.patch
>
>
> when we transfer inventory, the accountingQuantityTotal field of 
> _InventoryItem_ entity is always ZERO. There is no reflection of ATP/QOH in 
> accountingQuantityTotal.
> This will create following issues in the system.
> # Accounting quantity total will mismatch with the original quantity in the 
> facility which shows the wrong result when we calculate facility specific 
> inventory valuation.
> # Inventory reservation also throws an error in some specific case like when 
> AQT of respective product is zero in the specific facility from when 
> reservation happens.
> As we manage 5 different statuses of inventory transfer in OFBiz and 
> according to my current understanding these processes are associated with the 
> respective statuses, which are as show below
> Requested: As inventory transfer is requested for another facility. 
> a)ATP, QOH and AQT should decrease from the inventory item of From Facility 
> and QOH of To Facility should increase.
> b)ATP and AQT should be Zero in To Facility as inventory is not transferred 
> yet. But QOH should increase at To Facility because QOH shows the 
> xferquantity later. At the time of the completion of the transfer
> ATP = ATP + (QOH - ATP) (Adjustment in case of backorder)
> AQT = QOH
> b)AQT should not decrease because AQT is used for accounting purpose and as 
> of now quantity is still in From Facility as the transfer is not done yet. 
> which shows the xferQuantity later 
> Scheduled: As inventory transfer is Scheduled for another facility. ATP, QOH 
> and AQT should not affect in both From Facility and To Facility.
> En-route: As inventory is routed to reach at To Facility. Even in this case 
> ATP, QOH and AQT should not affect in both From Facility and To Facility.
> Complete: As inventory transfer is completed 
> a)ATP, QOH and AQT should not affect at From Facility. 
> b)QOH will be same but ATP and AQT should affect respectively
> ATP = ATP + (QOH - ATP)
> AQT = QOH
> Cancelled: As inventory transfer is cancelled and inventory item record is 
> already created  so 
> a) ATP, QOH and AQT should decrease from old inventory item and ATP, QOH and 
> AQT should increase in the newly created inventory item.
> Key points: 
> If the whole ATP and QOH is moved then new inventory item will not create. 
> Only Facility and location are changed for existing inventory item.
> Before Changes:-
> As I know there are following processes are associated with respective 
> statuses 
> **Note:   ATP-> Available to promiseQOH-> Quantity on handAQT-> 
> Accounting quantity total
> 1. Requested:-
> ATP =0QOH=Transferred quantity
>AQT=0
> 2. Scheduled:-
> ATP =0QOH=Transferred quantity
>AQT=0
> 3.En-Route:-
> ATP =0QOH=Transferred quantity
>AQT=0
> 4.Complete:-
> If the partial quantity of any inventory item is transferred.
> ATP =Transferred quantity   QOH=Transferred quantity   AQT=0
> If the whole quantity is transferred then only facility id and location 
> will change no new inventory item record will create. 
> 5.Cancelled:-
> No new inventory item record will create. An inventory transfer record is 
> created with whole ATP/QOH in cancelled status.
> After Changes:-
> As shown above, accounting quantity transfer will not affect in transfer 
> inventory. After the following changes, records will be updated a shown below.
> 1. Requested:-
> ATP =0QOH=Transferred quantity
>AQT=0
> 2. Scheduled:-
> ATP =0QOH=Transferred quantity
>AQT=0
> 3.En-Route:-
> ATP =0QOH=Transferred quantity
>AQT=0
> 4.Complete:-
> If the partial quantity of any inventory item is transferred.
> ATP =Transferred quantity   QOH=Transferred quantity   
> AQT=Transferred quantity
> If the whole quantity is transferred then only facility id and location 
> will change no new inventory item record will create. 
> 5.Cancelled:-
> No new inve

[jira] [Commented] (OFBIZ-7356) OFBIZ-6964: Document finalized design to support replenishment planning through any inter-company facility

2017-07-08 Thread Divesh Dutta (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-7356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16079175#comment-16079175
 ] 

Divesh Dutta commented on OFBIZ-7356:
-

I liked the overall design. The only improvement I would suggest is to extend 
Facility tables instead of ProductStoreFacility for recording RMEI 
 (requirementhMethodEnumId)

Also from data preparation point of view, it might be a tedious job to manage 
data of ProductFacilityAssoc table for each product. For example, assume below 
given situation:

1) requirementhMethodEnumId is set to XFERRQM_STOCK_ATP  for Store 
StoreWarehouse_01 in Facility table
2) MRP engine runs for StoreWarehouse_01
3) GZ-8544 is below safety stock in StoreWarehouse_01
4) ProductFacilityAssoc record for 8544 is not created

Then system should pick parentFacilityID from Facility table and propose 
transfer request from parentFacilityID. This way if all the products of 
facility are replenished from one warehouse, then user will not have to create 
ProductFacilityAssoc records for each products. 


> OFBIZ-6964: Document finalized design to support replenishment planning 
> through any inter-company facility
> --
>
> Key: OFBIZ-7356
> URL: https://issues.apache.org/jira/browse/OFBIZ-7356
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: manufacturing, order, product
>Reporter: Swapnil Shah
>Assignee: Swapnil Shah
>
> Here are high level design notes to based on the requirement specified under 
> OFBIZ-7355 to support the product level replenishment from any inter-company 
> facility before raising the ordering from an outside vendor.
> * We could extend the MRP logic (MrpEvent,Requirenent) to honor these new 
> types and create corresponding event & requirement for Stock transfer between 
> facilities.
> * Introduce two new entities ProductFacilityAssoc & FacilityAssocType and use 
> them in conjunction with MrpEventType and corresponding RequirementType to 
> serve the requirement for replenishing the store's via Inter-facility 
> transfers mode.  The data model & UI could be extended as follows:
> {code}
> 
>  title="Define associations between Product facilities">
> 
> 
> 
> 
> 
> 
>  
> 
> 
> 
> 
> 
> 
> 
> 
>  rel-entity-name="Facility">
> 
> 
>  rel-entity-name="Facility">
> 
> 
>  rel-entity-name="FacilityAssocType">
> 
> 
> 
> 
>  title="Define associations between facilities">
> 
> 
>  
> 
> 
>  
> 
> 
>  
> 
> 
>  description="Facility that serves another facility in terms of inventory"/>
> 
>  facilityIdTo="StoreWarehouse_01" facilityAssocTypeId="BACKUP_WAREHOUSE" 
> sequenceNum="01" fromDate="2001-01-01 12:00:00"/>
>  facilityIdTo="StoreWarehouse_01" facilityAssocTypeId="BACKUP_WAREHOUSE" 
> sequenceNum="02" fromDate="2001-01-01 12:00:00"/>
>  facilityIdTo="StoreWarehouse_01" facilityAssocTypeId="BACKUP_WAREHOUSE" 
> sequenceNum="03" fromDate="2001-01-01 12:00:00"/>
>  facilityIdTo="RegionalWarehouse_01" facilityAssocTypeId="BACKUP_WAREHOUSE" 
> sequenceNum="01" fromDate="2001-01-01 12:00:00"/>
>  facilityIdTo="RegionalWarehouse_02" facilityAssocTypeId="BACKUP_WAREHOUSE" 
> sequenceNum="01" fromDate="2001-01-01 12:00:00"/>
> 
> 
> 
> 
>  requirementTypeId="TRANSFER_REQUIREMENT"/>
> 
>  enumTypeId="PROD_REQ_METHOD"/>
> 
>  checkInventory="N" oneInventoryFacility="N" requireInventory="N" 
> reserveInventory="Y" reserveOrderEnumId="INVRO_FIFO_REC" /> 
> 
>  requirementMethodEnumId="XFERRQM_STOCK_ATP" fromDate="2001-04-13 12:00:00"/>
> 
>  lastInventoryCount="20.00" minimumStock="100.00" productId="GZ-8544"/>
>  lastInventoryCount="40.00" minimumStock="200.00" productId="GZ-8544"/>
>  lastInventoryCount="60.00" minimumStock="200.00" productId="GZ-8544"/>
>  lastInventoryCount="200.00" minimumStock="300.00" 
> productId="GZ-8544"/>
> {code}
> MRP engine would start creating event beginning with store's primary facility 
> based on set RMEI under ProductStoreFacility e.g, XFERRQM_STOCK_ATP for 
> StoreWarehouse_01, In other words if MinStock < ATP , then MRP algorithm 
> would: 
> # Look up and consume the respective ATP from all the eligible "facilityIdTo" 
> (based on ProductFacilityAssoc), from where given product is transferable. 
> Based on their priorities start allocating ATP unless it meet the 
> (MinStock-ATP) requirement for a given store e.g., 'StoreWarehouse_01' .
> # Create new MRP Event with Event type "PROP_ATP_STOCK_TRANSFER" with 
> Proposed Quantity = MINIMUM STOCK - ATP from the facility (with highest 
> priority i.e.,RegionalWarehouse_01) to the destination facility.
> ## If demand for (MinStock-ATP) is still not fully met by any facility with 
> higher priority then repeat step#1 for all the associated facilities in 
> descending order 

[jira] [Commented] (OFBIZ-7111) Total Actual cost of production run need to be passed on to produced stock's unit cost for completed production run

2016-11-05 Thread Divesh Dutta (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-7111?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15639948#comment-15639948
 ] 

Divesh Dutta commented on OFBIZ-7111:
-

Patch is committed in revision number 1768243 in trunk. Thanks [~anuj.jain] for 
the patch and [~swash78] for reporting this improvement. 

> Total Actual cost of production run need to be passed on to produced stock's 
> unit cost for completed production run
> ---
>
> Key: OFBIZ-7111
> URL: https://issues.apache.org/jira/browse/OFBIZ-7111
> Project: OFBiz
>  Issue Type: New Feature
>  Components: manufacturing
>Affects Versions: Release Branch 14.12, 14.12.01, Release Branch 15.12, 
> 15.12.01
>Reporter: Swapnil Shah
>Assignee: Divesh Dutta
> Attachments: ActualCostXfer_1.png, ActualCostXfer_2.png, 
> OFBIZ-7111.patch, OFBIZ-7111_V2.patch
>
>
> Currently as soon as item is produced into inventory once production run is 
> completed then inventory get created with ZERO unit cost. 
> We could pass on the total actual cost (Material+Labor+Resource etc.) to 
> Produced Item's inventory item i.e. = Total Actual Cost/ Produced in Stock 
> Please refer to attached screenshot for reference



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Closed] (OFBIZ-7543) OFBIZ-7542: Convert search criteria on 'Status' into multi-select pattern for 'Order' component

2016-11-05 Thread Divesh Dutta (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-7543?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Divesh Dutta closed OFBIZ-7543.
---
Resolution: Fixed

Patch for Find Return screen is committed in revision number 1768240 in trunk. 

> OFBIZ-7542: Convert search criteria on 'Status' into multi-select pattern for 
> 'Order' component
> ---
>
> Key: OFBIZ-7543
> URL: https://issues.apache.org/jira/browse/OFBIZ-7543
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: order
>Affects Versions: Upcoming Branch
>Reporter: Swapnil Shah
>Assignee: Mohammad Kathawala
> Attachments: OFBIZ-7543-return.patch, OFBIZ-7543.patch
>
>
> Please refer the details provided on OFBIZ-7542



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Closed] (OFBIZ-9052) OFBIZ-7520: Consistency and Readability improvements for check-permission tag

2016-11-05 Thread Divesh Dutta (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-9052?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Divesh Dutta closed OFBIZ-9052.
---
Resolution: Not A Problem

> OFBIZ-7520: Consistency and Readability improvements for check-permission tag
> -
>
> Key: OFBIZ-9052
> URL: https://issues.apache.org/jira/browse/OFBIZ-9052
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: ALL COMPONENTS
>Reporter: Anuj Jain
>Priority: Minor
> Attachments: OFBIZ-9052.patch
>
>
> Code written in Minilang for the if-compare tag is not consistent throughout 
> the application. The correct pattern to write is
> 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (OFBIZ-9052) OFBIZ-7520: Consistency and Readability improvements for check-permission tag

2016-11-05 Thread Divesh Dutta (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-9052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15639925#comment-15639925
 ] 

Divesh Dutta commented on OFBIZ-9052:
-

In recent trunk codebase all the references are not available where changes are 
made in patch. So we can discard this ticket now. 

> OFBIZ-7520: Consistency and Readability improvements for check-permission tag
> -
>
> Key: OFBIZ-9052
> URL: https://issues.apache.org/jira/browse/OFBIZ-9052
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: ALL COMPONENTS
>Reporter: Anuj Jain
>Priority: Minor
> Attachments: OFBIZ-9052.patch
>
>
> Code written in Minilang for the if-compare tag is not consistent throughout 
> the application. The correct pattern to write is
> 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Closed] (OFBIZ-9109) OFBIZ-7520: Consistency and Readability improvements for action tag

2016-11-05 Thread Divesh Dutta (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-9109?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Divesh Dutta closed OFBIZ-9109.
---
Resolution: Fixed

Committed in revision number: 1768237

> OFBIZ-7520: Consistency and Readability improvements for action tag
> ---
>
> Key: OFBIZ-9109
> URL: https://issues.apache.org/jira/browse/OFBIZ-9109
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: ALL COMPONENTS
>Reporter: Ankush Upadhyay
>Assignee: Ankush Upadhyay
> Attachments: OFBIZ-9109.patch
>
>
> Code written in Minilang for the calcop tag is not consistent throughout the 
> application. The correct pattern to write
> 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Comment Edited] (OFBIZ-7520) Minilang code readability and consistency improvements

2016-11-05 Thread Divesh Dutta (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-7520?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15639762#comment-15639762
 ] 

Divesh Dutta edited comment on OFBIZ-7520 at 11/5/16 4:19 PM:
--

All the patches in sub tickets are committed in revision numbers 1768209, 
1768219, 1768222, 1768235, 1768237 in trunk. 


was (Author: diveshdut):
All the patches in sub tickets are committed in revision numbers 1768209, 
1768219, 1768222, 1768235 in trunk. 

> Minilang code readability and consistency improvements
> --
>
> Key: OFBIZ-7520
> URL: https://issues.apache.org/jira/browse/OFBIZ-7520
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL COMPONENTS
>Affects Versions: Upcoming Branch
>Reporter: Divesh Dutta
>Assignee: Divesh Dutta
>
> Code written in minilang is not consistent through out the application and 
> some times its hard to read. For eg:
> {code}
> 
> {code}
> should be written as :
> {code}
> 
> {code}
> There are many such examples where code for all such tags in minilang can be 
> improved, which will improve code readability and we will have consistency 
> through out the application. This is a parent/place holder ticket, I will 
> create logical sub-tickets for managing the effort. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (OFBIZ-7512) 'Issue Component' option after partial issuance against required component quantity is not accounting for already issued quantity

2016-11-05 Thread Divesh Dutta (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-7512?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15639915#comment-15639915
 ] 

Divesh Dutta commented on OFBIZ-7512:
-

Closed 

> 'Issue Component' option after partial issuance against required component 
> quantity is not accounting for already issued quantity
> -
>
> Key: OFBIZ-7512
> URL: https://issues.apache.org/jira/browse/OFBIZ-7512
> Project: OFBiz
>  Issue Type: Bug
>  Components: manufacturing
>Affects Versions: Release Branch 14.12, 14.12.01, Release Branch 15.12, 
> 15.12.01
>Reporter: Swapnil Shah
>Assignee: Divesh Dutta
> Attachments: OFBIZ-7173.png, OFBIZ-7512.patch
>
>
> Once we issue the required component partially (i.e. by producing partial 
> quantity while task is still is still running or in case full ATP against 
> required quantity is not available for issuance) then "Issue Component" is 
> not honoring the already made issuance and hence issuing the whole required 
> quantity once again. (please refer to attached screenshot)
> !https://issues.apache.org/jira/secure/attachment/12811801/OFBIZ-7173.png|width=800px!



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Closed] (OFBIZ-7512) 'Issue Component' option after partial issuance against required component quantity is not accounting for already issued quantity

2016-11-05 Thread Divesh Dutta (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-7512?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Divesh Dutta closed OFBIZ-7512.
---

> 'Issue Component' option after partial issuance against required component 
> quantity is not accounting for already issued quantity
> -
>
> Key: OFBIZ-7512
> URL: https://issues.apache.org/jira/browse/OFBIZ-7512
> Project: OFBiz
>  Issue Type: Bug
>  Components: manufacturing
>Affects Versions: Release Branch 14.12, 14.12.01, Release Branch 15.12, 
> 15.12.01
>Reporter: Swapnil Shah
>Assignee: Divesh Dutta
> Attachments: OFBIZ-7173.png, OFBIZ-7512.patch
>
>
> Once we issue the required component partially (i.e. by producing partial 
> quantity while task is still is still running or in case full ATP against 
> required quantity is not available for issuance) then "Issue Component" is 
> not honoring the already made issuance and hence issuing the whole required 
> quantity once again. (please refer to attached screenshot)
> !https://issues.apache.org/jira/secure/attachment/12811801/OFBIZ-7173.png|width=800px!



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Comment Edited] (OFBIZ-7520) Minilang code readability and consistency improvements

2016-11-05 Thread Divesh Dutta (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-7520?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15639762#comment-15639762
 ] 

Divesh Dutta edited comment on OFBIZ-7520 at 11/5/16 4:13 PM:
--

All the patches in sub tickets are committed in revision numbers 1768209, 
1768219, 1768222, 1768235 in trunk. 


was (Author: diveshdut):
All the patches in sub tickets are committed in revision numbers 1768209, 
1768219, 1768222 in trunk. 

> Minilang code readability and consistency improvements
> --
>
> Key: OFBIZ-7520
> URL: https://issues.apache.org/jira/browse/OFBIZ-7520
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL COMPONENTS
>Affects Versions: Upcoming Branch
>Reporter: Divesh Dutta
>Assignee: Divesh Dutta
>
> Code written in minilang is not consistent through out the application and 
> some times its hard to read. For eg:
> {code}
> 
> {code}
> should be written as :
> {code}
> 
> {code}
> There are many such examples where code for all such tags in minilang can be 
> improved, which will improve code readability and we will have consistency 
> through out the application. This is a parent/place holder ticket, I will 
> create logical sub-tickets for managing the effort. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Closed] (OFBIZ-8926) OFBIZ-7520: Consistency and Readability improvements for condition-expr tag

2016-11-05 Thread Divesh Dutta (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-8926?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Divesh Dutta closed OFBIZ-8926.
---
Resolution: Fixed

Code committed in revision number 1768235. 

> OFBIZ-7520: Consistency and Readability improvements for condition-expr tag
> ---
>
> Key: OFBIZ-8926
> URL: https://issues.apache.org/jira/browse/OFBIZ-8926
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: ALL COMPONENTS
>Reporter: Anuj Jain
>Priority: Minor
> Attachments: OFBIZ-8926.patch
>
>
> Code written in Minilang for the if-compare tag is not consistent throughout 
> the application. The correct pattern to write 
>  from-field="parameters.fromDate"/>



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Closed] (OFBIZ-8927) OFBIZ-7520: Consistency and Readability improvements for find-by-primary-key tag

2016-11-05 Thread Divesh Dutta (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-8927?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Divesh Dutta closed OFBIZ-8927.
---
Resolution: Fixed

Committed in revision number 1768235 in trunk

> OFBIZ-7520: Consistency and Readability improvements for find-by-primary-key 
> tag
> 
>
> Key: OFBIZ-8927
> URL: https://issues.apache.org/jira/browse/OFBIZ-8927
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: ALL COMPONENTS
>Reporter: Anuj Jain
>Priority: Minor
> Attachments: OFBIZ-8927.patch
>
>
> Code written in Minilang for the calcop tag is not consistent throughout the 
> application. The correct pattern to write 
>  value-field="findAssetMaint"/>



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Resolved] (OFBIZ-7559) Material requirements is allowed to be added against already 'Cancelled' Production Run (task)

2016-11-05 Thread Divesh Dutta (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-7559?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Divesh Dutta resolved OFBIZ-7559.
-
Resolution: Fixed

> Material requirements is allowed to be added against already 'Cancelled' 
> Production Run (task)
> --
>
> Key: OFBIZ-7559
> URL: https://issues.apache.org/jira/browse/OFBIZ-7559
> Project: OFBiz
>  Issue Type: Improvement
>  Components: manufacturing
>Affects Versions: Trunk
>Reporter: Swapnil Shah
>Assignee: Swapnil Shah
> Attachments: P1.png, P2.png, P3.png
>
>
> Currently system allows user to add/issue the new material requirement 
> against cancelled routing tasks. 
> Expected Behavior:
> System should allow user to add the new material requirement against only 
> non-cancelled tasks
> Please refer to attached screenshot for reference
> !https://issues.apache.org/jira/secure/attachment/12812788/P1.png|width=800px!
> !https://issues.apache.org/jira/secure/attachment/12812787/P2.png|width=800px!
> !https://issues.apache.org/jira/secure/attachment/12812786/P3.png|width=800px!



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (OFBIZ-7559) Material requirements is allowed to be added against already 'Cancelled' Production Run (task)

2016-11-05 Thread Divesh Dutta (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-7559?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15639802#comment-15639802
 ] 

Divesh Dutta commented on OFBIZ-7559:
-

Assigning Swapnil for verification and closure. 

> Material requirements is allowed to be added against already 'Cancelled' 
> Production Run (task)
> --
>
> Key: OFBIZ-7559
> URL: https://issues.apache.org/jira/browse/OFBIZ-7559
> Project: OFBiz
>  Issue Type: Improvement
>  Components: manufacturing
>Affects Versions: Trunk
>Reporter: Swapnil Shah
>Assignee: Swapnil Shah
> Attachments: P1.png, P2.png, P3.png
>
>
> Currently system allows user to add/issue the new material requirement 
> against cancelled routing tasks. 
> Expected Behavior:
> System should allow user to add the new material requirement against only 
> non-cancelled tasks
> Please refer to attached screenshot for reference
> !https://issues.apache.org/jira/secure/attachment/12812788/P1.png|width=800px!
> !https://issues.apache.org/jira/secure/attachment/12812787/P2.png|width=800px!
> !https://issues.apache.org/jira/secure/attachment/12812786/P3.png|width=800px!



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (OFBIZ-7559) Material requirements is allowed to be added against already 'Cancelled' Production Run (task)

2016-11-05 Thread Divesh Dutta (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-7559?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15639798#comment-15639798
 ] 

Divesh Dutta commented on OFBIZ-7559:
-

Fix is done under OFBIZ-7468 in revision number 1768228 in trunk. 

> Material requirements is allowed to be added against already 'Cancelled' 
> Production Run (task)
> --
>
> Key: OFBIZ-7559
> URL: https://issues.apache.org/jira/browse/OFBIZ-7559
> Project: OFBiz
>  Issue Type: Improvement
>  Components: manufacturing
>Affects Versions: Trunk
>Reporter: Swapnil Shah
>Assignee: Swapnil Shah
> Attachments: P1.png, P2.png, P3.png
>
>
> Currently system allows user to add/issue the new material requirement 
> against cancelled routing tasks. 
> Expected Behavior:
> System should allow user to add the new material requirement against only 
> non-cancelled tasks
> Please refer to attached screenshot for reference
> !https://issues.apache.org/jira/secure/attachment/12812788/P1.png|width=800px!
> !https://issues.apache.org/jira/secure/attachment/12812787/P2.png|width=800px!
> !https://issues.apache.org/jira/secure/attachment/12812786/P3.png|width=800px!



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (OFBIZ-7468) Define constraints while adding new material to the task which is in completed/cancel status.

2016-11-05 Thread Divesh Dutta (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-7468?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Divesh Dutta updated OFBIZ-7468:

Assignee: Swapnil Shah

> Define constraints while adding new material to the task which is in 
> completed/cancel status.
> -
>
> Key: OFBIZ-7468
> URL: https://issues.apache.org/jira/browse/OFBIZ-7468
> Project: OFBiz
>  Issue Type: Improvement
>  Components: manufacturing
>Affects Versions: Trunk
>Reporter: Anuj Jain
>Assignee: Swapnil Shah
> Attachments: OFBIZ-7468.patch
>
>
> Define actions on adding new material to the task which is in 
> completed/cancel status. 
> Actions suggested by Swapnil :-
> # We can begin with simple constraint of allowing new material against the 
> only those routing task that has not cancelled yet within a production run
> # Any completed taks for uncomplete Production Run should have WEGS created 
> in COMPLETED status and WEIA created as well by issuing the added item's qty.
> # If production is already completed (aka all its routing task also 
> completed/cancelled) then don't allow new material to be added from Actual 
> Material screen 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (OFBIZ-7468) Define constraints while adding new material to the task which is in completed/cancel status.

2016-11-05 Thread Divesh Dutta (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-7468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15639788#comment-15639788
 ] 

Divesh Dutta commented on OFBIZ-7468:
-

Thansk [~anuj.jain] for your patch. Patch is committed in revision number!: 
1768228 in trunk. 

> Define constraints while adding new material to the task which is in 
> completed/cancel status.
> -
>
> Key: OFBIZ-7468
> URL: https://issues.apache.org/jira/browse/OFBIZ-7468
> Project: OFBiz
>  Issue Type: Improvement
>  Components: manufacturing
>Affects Versions: Trunk
>Reporter: Anuj Jain
> Attachments: OFBIZ-7468.patch
>
>
> Define actions on adding new material to the task which is in 
> completed/cancel status. 
> Actions suggested by Swapnil :-
> # We can begin with simple constraint of allowing new material against the 
> only those routing task that has not cancelled yet within a production run
> # Any completed taks for uncomplete Production Run should have WEGS created 
> in COMPLETED status and WEIA created as well by issuing the added item's qty.
> # If production is already completed (aka all its routing task also 
> completed/cancelled) then don't allow new material to be added from Actual 
> Material screen 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (OFBIZ-7522) Hide user inputs for Location/Lot# for fully issued components against production run task

2016-11-05 Thread Divesh Dutta (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-7522?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15639776#comment-15639776
 ] 

Divesh Dutta commented on OFBIZ-7522:
-

[~anuj.jain] new patch is not getting applied. Please look into it. 

> Hide user inputs for Location/Lot# for fully issued components against 
> production run task
> --
>
> Key: OFBIZ-7522
> URL: https://issues.apache.org/jira/browse/OFBIZ-7522
> Project: OFBiz
>  Issue Type: Improvement
>  Components: manufacturing
>Affects Versions: 14.12.01, 15.12.01
>Reporter: Swapnil Shah
>Assignee: Anuj Jain
>Priority: Minor
> Attachments: OFBIZ-7522-A.patch, OFBIZ-7522.patch, PR_1.png
>
>
> Once any component item gets fully issued then also we allow user to enter 
> the location/lot# etc. under 'Materials Required By The Running Task' panel, 
> like we do for un-issued or partially issued components. 
> We can possible hide user selection and text entry against such fully issued 
> items and show it only if remaining to be issued qty > 0
> Please refer to attached screenshot for reference.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (OFBIZ-7520) Minilang code readability and consistency improvements

2016-11-05 Thread Divesh Dutta (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-7520?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15639762#comment-15639762
 ] 

Divesh Dutta commented on OFBIZ-7520:
-

All the patches in sub tickets are committed in revision numbers 1768209, 
1768219, 1768222 in trunk. 

> Minilang code readability and consistency improvements
> --
>
> Key: OFBIZ-7520
> URL: https://issues.apache.org/jira/browse/OFBIZ-7520
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL COMPONENTS
>Affects Versions: Upcoming Branch
>Reporter: Divesh Dutta
>Assignee: Divesh Dutta
>
> Code written in minilang is not consistent through out the application and 
> some times its hard to read. For eg:
> {code}
> 
> {code}
> should be written as :
> {code}
> 
> {code}
> There are many such examples where code for all such tags in minilang can be 
> improved, which will improve code readability and we will have consistency 
> through out the application. This is a parent/place holder ticket, I will 
> create logical sub-tickets for managing the effort. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Closed] (OFBIZ-8445) OFBIZ-7520: Consistency and Readability improvements for if-compare tag

2016-11-05 Thread Divesh Dutta (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-8445?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Divesh Dutta closed OFBIZ-8445.
---

> OFBIZ-7520: Consistency and Readability improvements for if-compare tag
> ---
>
> Key: OFBIZ-8445
> URL: https://issues.apache.org/jira/browse/OFBIZ-8445
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: ALL COMPONENTS
>Affects Versions: Upcoming Branch
>Reporter: Devanshu Vyas
>Assignee: Divesh Dutta
>Priority: Minor
> Attachments: OFBIZ-8445.patch
>
>
> Code written in Minilang for the if-compare tag is not consistent throughout 
> the application. The correct pattern to write is
> 
> I found various other ways in which this tag is written, like
>  type="Boolean">
>  type="Boolean">



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Closed] (OFBIZ-8742) OFBIZ-7520: Consistency and Readability improvements for entity-and tag

2016-11-05 Thread Divesh Dutta (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-8742?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Divesh Dutta closed OFBIZ-8742.
---

> OFBIZ-7520: Consistency and Readability improvements for entity-and tag
> ---
>
> Key: OFBIZ-8742
> URL: https://issues.apache.org/jira/browse/OFBIZ-8742
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: ALL COMPONENTS
>Reporter: Anuj Jain
> Attachments: OFBIZ-8742.patch
>
>
> Code written in Minilang for the entity-and is not consistent throughout the 
> application. The correct pattern to write is
> 
> The wrong way in which this tag is written is
> 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Closed] (OFBIZ-8740) OFBIZ-7520: Consistency and Readability improvements for field-to-result tag.

2016-11-05 Thread Divesh Dutta (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-8740?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Divesh Dutta closed OFBIZ-8740.
---

> OFBIZ-7520: Consistency and Readability improvements for field-to-result tag.
> -
>
> Key: OFBIZ-8740
> URL: https://issues.apache.org/jira/browse/OFBIZ-8740
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: ALL COMPONENTS
>Reporter: Anuj Jain
> Attachments: OFBIZ-8740.patch
>
>
> Code written in Minilang for the field-to-result  tag is not consistent 
> throughout the application. The correct pattern to write is
>  result-name="availableToPromiseTotal" />
> The wrong way in which this tag is written is
>  field="lastInventoryCount"/>



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Closed] (OFBIZ-8741) OFBIZ-7520: Consistency and Readability improvements for fail-property tag.

2016-11-05 Thread Divesh Dutta (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-8741?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Divesh Dutta closed OFBIZ-8741.
---

> OFBIZ-7520: Consistency and Readability improvements for fail-property tag.
> ---
>
> Key: OFBIZ-8741
> URL: https://issues.apache.org/jira/browse/OFBIZ-8741
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: ALL COMPONENTS
>Reporter: Anuj Jain
> Attachments: OFBIZ-8741.patch
>
>
> Code written in Minilang for the fail-property tag is not consistent 
> throughout the application. The correct pattern to write is
>  property="InvalidEmailAddress"/>
> The wrong way in which this tag is written is
>  resource="CatalogErrorUiLabels"/>



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Closed] (OFBIZ-8451) OFBIZ-7520: Consistency and Readability improvements for include-form tag

2016-11-05 Thread Divesh Dutta (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-8451?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Divesh Dutta closed OFBIZ-8451.
---

> OFBIZ-7520: Consistency and Readability improvements for include-form tag
> -
>
> Key: OFBIZ-8451
> URL: https://issues.apache.org/jira/browse/OFBIZ-8451
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: ALL COMPONENTS
>Affects Versions: Upcoming Branch
>Reporter: Devanshu Vyas
>Priority: Minor
> Attachments: OFBIZ-8451.patch
>
>
> Code written in Minilang for the include-form tag is not consistent 
> throughout the application. The correct pattern to write is
>  location="component://manufacturing/widget/manufacturing/RoutingTaskForms.xml"/>
> The wrong way in which this tag is written is
>  location="component://marketing/widget/sfa/forms/AccountForms.xml" 
> name="FindInfoStringContactMech"/>



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Closed] (OFBIZ-8448) OFBIZ-7520: Consistency and Readability improvements for field-map tag

2016-11-05 Thread Divesh Dutta (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-8448?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Divesh Dutta closed OFBIZ-8448.
---

> OFBIZ-7520: Consistency and Readability improvements for field-map tag
> --
>
> Key: OFBIZ-8448
> URL: https://issues.apache.org/jira/browse/OFBIZ-8448
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: ALL COMPONENTS
>Affects Versions: Upcoming Branch
>Reporter: Devanshu Vyas
>Priority: Minor
> Attachments: OFBIZ-8448.patch
>
>
> Code written in Minilang for the if-compare tag is not consistent throughout 
> the application. The correct pattern to write is
> 
> I found another way in which this tag is written currently,
> 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Closed] (OFBIZ-8450) OFBIZ-7520: Consistency and Readability improvements for include-screen tag

2016-11-05 Thread Divesh Dutta (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-8450?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Divesh Dutta closed OFBIZ-8450.
---

> OFBIZ-7520: Consistency and Readability improvements for include-screen tag
> ---
>
> Key: OFBIZ-8450
> URL: https://issues.apache.org/jira/browse/OFBIZ-8450
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: ALL COMPONENTS
>Affects Versions: Upcoming Branch
>Reporter: Devanshu Vyas
> Attachments: OFBIZ-8450.patch
>
>
> Code written in Minilang for the if-compare tag is not consistent throughout 
> the application. The correct pattern to write is
>  location="component://order/widget/ordermgr/OrderPrintScreens.xml"/>
> Found a wrong way in which this tag is written,
>  location="component://party/widget/partymgr/CommunicationEventScreens.xml" 
> name="commOverview"/>



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Closed] (OFBIZ-8743) OFBIZ-7520: Consistency and Readability improvements for set-nonpk-fields tag

2016-11-05 Thread Divesh Dutta (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-8743?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Divesh Dutta closed OFBIZ-8743.
---

> OFBIZ-7520: Consistency and Readability improvements for set-nonpk-fields  tag
> --
>
> Key: OFBIZ-8743
> URL: https://issues.apache.org/jira/browse/OFBIZ-8743
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: ALL COMPONENTS
>Reporter: Anuj Jain
> Attachments: OFBIZ-8743.patch
>
>
> Code written in Minilang for the set-nonpk-fields tag is not consistent 
> throughout the application. The correct pattern to write is
> 
> The wrong way in which this tag is written is
> 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Closed] (OFBIZ-8447) OFBIZ-7520: Consistency and Readability improvements for if-compare-field tag

2016-11-05 Thread Divesh Dutta (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-8447?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Divesh Dutta closed OFBIZ-8447.
---

> OFBIZ-7520: Consistency and Readability improvements for if-compare-field tag
> -
>
> Key: OFBIZ-8447
> URL: https://issues.apache.org/jira/browse/OFBIZ-8447
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: ALL COMPONENTS
>Affects Versions: Upcoming Branch
>Reporter: Devanshu Vyas
>Priority: Minor
> Attachments: OFBIZ-8447.patch
>
>
> Code written in Minilang for the if-compare tag is not consistent throughout 
> the application. The correct pattern to write is
>  to-field="parameters.statusId">
> I found various other ways in which this tag is written, like
>  operator="equals" field="orderHeader.currencyUom" />
>  to-field="payment.actualCurrencyAmount">



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Closed] (OFBIZ-8653) OFBIZ-7520: Consistency and Readability improvements for iterator tag

2016-11-05 Thread Divesh Dutta (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-8653?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Divesh Dutta closed OFBIZ-8653.
---

> OFBIZ-7520: Consistency and Readability improvements for iterator tag
> -
>
> Key: OFBIZ-8653
> URL: https://issues.apache.org/jira/browse/OFBIZ-8653
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: ALL COMPONENTS
>Reporter: Anuj Jain
> Fix For: Trunk
>
> Attachments: OFBIZ-8653.patch
>
>
> Code written in Minilang for the iterator tag is not consistent throughout 
> the application. The correct pattern to write is
> 
> I found various other ways in which this tag is written, like
> 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Closed] (OFBIZ-8930) OFBIZ-7520: Consistency and Readability improvements for option (form widget) tag

2016-11-05 Thread Divesh Dutta (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-8930?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Divesh Dutta closed OFBIZ-8930.
---
Resolution: Fixed

> OFBIZ-7520: Consistency and Readability improvements for option (form widget) 
> tag
> -
>
> Key: OFBIZ-8930
> URL: https://issues.apache.org/jira/browse/OFBIZ-8930
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: ALL COMPONENTS
>Reporter: Anuj Jain
>Priority: Minor
> Attachments: OFBIZ-8930.patch
>
>
> Code written in Minilang for the if-compare tag is not consistent throughout 
> the application. The correct pattern to write
> 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Closed] (OFBIZ-8965) OFBIZ-7520: Consistency and Readability improvements for event tag (controller.xml)

2016-11-05 Thread Divesh Dutta (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-8965?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Divesh Dutta closed OFBIZ-8965.
---
Resolution: Fixed

> OFBIZ-7520: Consistency and Readability improvements for event tag 
> (controller.xml)
> ---
>
> Key: OFBIZ-8965
> URL: https://issues.apache.org/jira/browse/OFBIZ-8965
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: ALL COMPONENTS
>Reporter: Ankush Upadhyay
>Assignee: Ankush Upadhyay
> Attachments: OFBIZ-8965.patch
>
>
> Code written in Minilang for the if-compare tag is not consistent throughout 
> the application. The correct pattern to write is
> 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Closed] (OFBIZ-8986) OFBIZ-7520: Consistency and Readability improvements for make-value tag

2016-11-05 Thread Divesh Dutta (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-8986?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Divesh Dutta closed OFBIZ-8986.
---
Resolution: Fixed

> OFBIZ-7520: Consistency and Readability improvements for make-value tag
> ---
>
> Key: OFBIZ-8986
> URL: https://issues.apache.org/jira/browse/OFBIZ-8986
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: ALL COMPONENTS
>Reporter: Ankush Upadhyay
>Assignee: Ankush Upadhyay
> Attachments: OFBIZ-8986.patch
>
>
> Code written in Minilang for the entity-one tag is not consistent throughout 
> the application. The correct pattern to write is
> 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Closed] (OFBIZ-8972) OFBIZ-7520: Consistency and Readability improvements for include-menu tag

2016-11-05 Thread Divesh Dutta (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-8972?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Divesh Dutta closed OFBIZ-8972.
---
Resolution: Fixed

> OFBIZ-7520: Consistency and Readability improvements for include-menu tag
> -
>
> Key: OFBIZ-8972
> URL: https://issues.apache.org/jira/browse/OFBIZ-8972
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: ALL COMPONENTS
>Reporter: Ankush Upadhyay
>Assignee: Ankush Upadhyay
> Attachments: OFBIZ-8972.patch
>
>
> Code written in Minilang for the if-compare tag is not consistent throughout 
> the application. The correct pattern to write is
>  location="component://marketing/widget/sfa/SfaMenus.xml"/>



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Closed] (OFBIZ-8953) OFBIZ-7520: Consistency and Readability improvements for call-service tag

2016-11-05 Thread Divesh Dutta (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-8953?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Divesh Dutta closed OFBIZ-8953.
---
Resolution: Fixed

> OFBIZ-7520: Consistency and Readability improvements for call-service tag
> -
>
> Key: OFBIZ-8953
> URL: https://issues.apache.org/jira/browse/OFBIZ-8953
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: ALL COMPONENTS
>Reporter: Ankush Upadhyay
>Assignee: Ankush Upadhyay
> Attachments: OFBIZ-8953.patch
>
>
> Code written in Minilang for the if-compare tag is not consistent throughout 
> the application. The correct pattern to write:
> 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Closed] (OFBIZ-8991) OFBIZ-7520: Consistency and Readability improvements for condition tag

2016-11-05 Thread Divesh Dutta (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-8991?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Divesh Dutta closed OFBIZ-8991.
---
Resolution: Fixed

> OFBIZ-7520: Consistency and Readability improvements for condition tag
> --
>
> Key: OFBIZ-8991
> URL: https://issues.apache.org/jira/browse/OFBIZ-8991
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: ALL COMPONENTS
>Reporter: Ankush Upadhyay
>Assignee: Ankush Upadhyay
> Attachments: OFBIZ-8991.patch
>
>
> Code written in Minilang for the entity-and is not consistent throughout the 
> application. The correct pattern to write is
>  value="FINACT_TRNS_APPROVED"/>



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Closed] (OFBIZ-8929) OFBIZ-7520: Consistency and Readability improvements for log tag

2016-11-05 Thread Divesh Dutta (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-8929?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Divesh Dutta closed OFBIZ-8929.
---
Resolution: Fixed

> OFBIZ-7520: Consistency and Readability improvements for log tag
> 
>
> Key: OFBIZ-8929
> URL: https://issues.apache.org/jira/browse/OFBIZ-8929
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: ALL COMPONENTS
>Reporter: Anuj Jain
>Priority: Minor
> Attachments: OFBIZ-8929.patch
>
>
> Code written in Minilang for the if-compare tag is not consistent throughout 
> the application. The correct pattern to write
> 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Closed] (OFBIZ-8924) OFBIZ-7520: Consistency and Readability improvements for set-service-fields tag

2016-11-05 Thread Divesh Dutta (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-8924?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Divesh Dutta closed OFBIZ-8924.
---
Resolution: Fixed

> OFBIZ-7520: Consistency and Readability improvements for set-service-fields 
> tag
> ---
>
> Key: OFBIZ-8924
> URL: https://issues.apache.org/jira/browse/OFBIZ-8924
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: ALL COMPONENTS
>Reporter: Anuj Jain
> Attachments: OFBIZ-8924.patch
>
>
> Code written in Minilang for the calcop tag is not consistent throughout the 
> application. The correct pattern to write 
>  to-map="createPhysicalInventoryMap"/>



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Closed] (OFBIZ-8925) OFBIZ-7520: Consistency and Readability improvements for hyperlink tag

2016-11-05 Thread Divesh Dutta (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-8925?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Divesh Dutta closed OFBIZ-8925.
---
Resolution: Fixed

> OFBIZ-7520: Consistency and Readability improvements for hyperlink tag
> --
>
> Key: OFBIZ-8925
> URL: https://issues.apache.org/jira/browse/OFBIZ-8925
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: ALL COMPONENTS
>Reporter: Anuj Jain
>Priority: Minor
> Attachments: OFBIZ-8925.patch
>
>
> Code written in Minilang for the if-compare tag is not consistent throughout 
> the application. The correct pattern to write 
> 

[jira] [Closed] (OFBIZ-8907) OFBIZ-7520: Consistency and Readability improvements for entity-options tag

2016-11-05 Thread Divesh Dutta (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-8907?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Divesh Dutta closed OFBIZ-8907.
---
Resolution: Fixed

> OFBIZ-7520: Consistency and Readability improvements for entity-options tag
> ---
>
> Key: OFBIZ-8907
> URL: https://issues.apache.org/jira/browse/OFBIZ-8907
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: ALL COMPONENTS
>Reporter: Ankush Upadhyay
>Assignee: Ankush Upadhyay
> Attachments: OFBIZ-8907.patch
>
>
> Code written in Minilang for the entity-condition tag is not consistent 
> throughout the application. The correct pattern to write is
>   key-field-name="surveyQuestionCategoryId" description="${description} 
> [${surveyQuestionCategoryId}]">
> The wrong way in which this tag is written is
>  description="${description} [${surveyQuestionCategoryId}]" 
> key-field-name="surveyQuestionCategoryId">



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Closed] (OFBIZ-8830) OFBIZ-7520: Consistency and Readability improvements for result-to-field tag

2016-11-05 Thread Divesh Dutta (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-8830?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Divesh Dutta closed OFBIZ-8830.
---
Resolution: Fixed

> OFBIZ-7520: Consistency and Readability improvements for result-to-field tag
> 
>
> Key: OFBIZ-8830
> URL: https://issues.apache.org/jira/browse/OFBIZ-8830
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: ALL COMPONENTS
>Reporter: Anuj Jain
> Attachments: OFBIZ-8830.patch
>
>
> Code written in Minilang for the if-compare tag is not consistent throughout 
> the application. The correct pattern to write is
> 
> I found various other ways in which this tag is written, like
> 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Closed] (OFBIZ-8746) OFBIZ-7520: Consistency and Readability improvements for first-from-list tag

2016-11-05 Thread Divesh Dutta (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-8746?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Divesh Dutta closed OFBIZ-8746.
---
Resolution: Fixed

> OFBIZ-7520: Consistency and Readability improvements for first-from-list tag
> 
>
> Key: OFBIZ-8746
> URL: https://issues.apache.org/jira/browse/OFBIZ-8746
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: ALL COMPONENTS
>Reporter: Anuj Jain
> Attachments: OFBIZ-8746.patch
>
>
> Code written in Minilang for the first-from-list tag is not consistent 
> throughout the application. The correct pattern to write is
> 
> The wrong way in which this tag is written is
> 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Closed] (OFBIZ-8744) OFBIZ-7520: Consistency and Readability improvements for entity-one tag

2016-11-05 Thread Divesh Dutta (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-8744?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Divesh Dutta closed OFBIZ-8744.
---
Resolution: Fixed

> OFBIZ-7520: Consistency and Readability improvements for entity-one tag
> ---
>
> Key: OFBIZ-8744
> URL: https://issues.apache.org/jira/browse/OFBIZ-8744
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: ALL COMPONENTS
>Reporter: Anuj Jain
> Attachments: OFBIZ-8744.patch
>
>
> Code written in Minilang for the entity-one tag is not consistent throughout 
> the application. The correct pattern to write is
> 
> The wrong way in which this tag is written is
> 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Closed] (OFBIZ-8745) OFBIZ-7520: Consistency and Readability improvements for entity-condition tag

2016-11-05 Thread Divesh Dutta (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-8745?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Divesh Dutta closed OFBIZ-8745.
---
Resolution: Fixed

> OFBIZ-7520: Consistency and Readability improvements for entity-condition tag
> -
>
> Key: OFBIZ-8745
> URL: https://issues.apache.org/jira/browse/OFBIZ-8745
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: ALL COMPONENTS
>Reporter: Anuj Jain
> Attachments: OFBIZ-8745.patch
>
>
> Code written in Minilang for the entity-condition tag is not consistent 
> throughout the application. The correct pattern to write is
> 
> The wrong way in which this tag is written is
> 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Closed] (OFBIZ-8748) OFBIZ-7520: Consistency and Readability improvements for if-has-permission tag

2016-11-05 Thread Divesh Dutta (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-8748?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Divesh Dutta closed OFBIZ-8748.
---
Resolution: Fixed

> OFBIZ-7520: Consistency and Readability improvements for if-has-permission tag
> --
>
> Key: OFBIZ-8748
> URL: https://issues.apache.org/jira/browse/OFBIZ-8748
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: ALL COMPONENTS
>Reporter: Anuj Jain
> Attachments: OFBIZ-8748.patch
>
>
> Code written in Minilang for the if-has-permission tag is not consistent 
> throughout the application. The correct pattern to write is
> 
> The wrong way in which this tag is written is
> 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Closed] (OFBIZ-8908) OFBIZ-7520: Consistency and Readability improvements for entity-constraint tag

2016-11-05 Thread Divesh Dutta (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-8908?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Divesh Dutta closed OFBIZ-8908.
---
Resolution: Fixed

> OFBIZ-7520: Consistency and Readability improvements for entity-constraint tag
> --
>
> Key: OFBIZ-8908
> URL: https://issues.apache.org/jira/browse/OFBIZ-8908
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: ALL COMPONENTS
>Reporter: Ankush Upadhyay
>Assignee: Ankush Upadhyay
> Attachments: OFBIZ-8908.patch
>
>
> Code written in Minilang for the entity-and is not consistent throughout the 
> application. The correct pattern to write is
> 
> The wrong way in which this tag is written is
> 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Closed] (OFBIZ-8829) OFBIZ-7520: Consistency and Readability improvements for calcop tag

2016-11-05 Thread Divesh Dutta (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-8829?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Divesh Dutta closed OFBIZ-8829.
---
Resolution: Fixed

> OFBIZ-7520: Consistency and Readability improvements for calcop tag
> ---
>
> Key: OFBIZ-8829
> URL: https://issues.apache.org/jira/browse/OFBIZ-8829
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: ALL COMPONENTS
>Reporter: Anuj Jain
> Attachments: OFBIZ-8829.patch
>
>
> Code written in Minilang for the calcop tag is not consistent throughout the 
> application. The correct pattern to write is
> 
> I found various other ways in which this tag is written, like
> 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (OFBIZ-9052) OFBIZ-7520: Consistency and Readability improvements for check-permission tag

2016-11-05 Thread Divesh Dutta (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-9052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15639754#comment-15639754
 ] 

Divesh Dutta commented on OFBIZ-9052:
-

This patch is not getting applied due to recent changes. Please submit new patch

> OFBIZ-7520: Consistency and Readability improvements for check-permission tag
> -
>
> Key: OFBIZ-9052
> URL: https://issues.apache.org/jira/browse/OFBIZ-9052
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: ALL COMPONENTS
>Reporter: Anuj Jain
>Priority: Minor
> Attachments: OFBIZ-9052.patch
>
>
> Code written in Minilang for the if-compare tag is not consistent throughout 
> the application. The correct pattern to write is
> 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Assigned] (OFBIZ-8445) OFBIZ-7520: Consistency and Readability improvements for if-compare tag

2016-11-05 Thread Divesh Dutta (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-8445?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Divesh Dutta reassigned OFBIZ-8445:
---

Assignee: Divesh Dutta

> OFBIZ-7520: Consistency and Readability improvements for if-compare tag
> ---
>
> Key: OFBIZ-8445
> URL: https://issues.apache.org/jira/browse/OFBIZ-8445
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: ALL COMPONENTS
>Affects Versions: Upcoming Branch
>Reporter: Devanshu Vyas
>Assignee: Divesh Dutta
>Priority: Minor
> Attachments: OFBIZ-8445.patch
>
>
> Code written in Minilang for the if-compare tag is not consistent throughout 
> the application. The correct pattern to write is
> 
> I found various other ways in which this tag is written, like
>  type="Boolean">
>  type="Boolean">



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Closed] (OFBIZ-7108) Provide an option to specify the Facility Location while producing the inventory/stock once production run gets completed

2016-11-05 Thread Divesh Dutta (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-7108?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Divesh Dutta closed OFBIZ-7108.
---

> Provide an option to specify the Facility Location while producing the 
> inventory/stock once production run gets completed
> -
>
> Key: OFBIZ-7108
> URL: https://issues.apache.org/jira/browse/OFBIZ-7108
> Project: OFBiz
>  Issue Type: New Feature
>  Components: manufacturing
>Affects Versions: Upcoming Branch
>Reporter: Swapnil Shah
>Assignee: Swapnil Shah
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-7108.patch, OFBIZ-7110-A.patch, ProduceStock.png
>
>
> Currently there is no option to specify where the produced inventory against 
> finished good would be stocked in the facility. 
> Let's try to add the option to select and specify the facility location under 
> 'Production Run Produce' or 'Production Run Declare and Produce' section. 
> Once user submit the quantity and location same should be set over produced 
> InventoryItem.locationSeqId
> Please refer the attached screenshot for reference



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (OFBIZ-7108) Provide an option to specify the Facility Location while producing the inventory/stock once production run gets completed

2016-11-05 Thread Divesh Dutta (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-7108?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15639740#comment-15639740
 ] 

Divesh Dutta commented on OFBIZ-7108:
-

We can add autocompleter in another task. Closing this one. 

> Provide an option to specify the Facility Location while producing the 
> inventory/stock once production run gets completed
> -
>
> Key: OFBIZ-7108
> URL: https://issues.apache.org/jira/browse/OFBIZ-7108
> Project: OFBiz
>  Issue Type: New Feature
>  Components: manufacturing
>Affects Versions: Upcoming Branch
>Reporter: Swapnil Shah
>Assignee: Swapnil Shah
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-7108.patch, OFBIZ-7110-A.patch, ProduceStock.png
>
>
> Currently there is no option to specify where the produced inventory against 
> finished good would be stocked in the facility. 
> Let's try to add the option to select and specify the facility location under 
> 'Production Run Produce' or 'Production Run Declare and Produce' section. 
> Once user submit the quantity and location same should be set over produced 
> InventoryItem.locationSeqId
> Please refer the attached screenshot for reference



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (OFBIZ-7108) Provide an option to specify the Facility Location while producing the inventory/stock once production run gets completed

2016-11-05 Thread Divesh Dutta (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-7108?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Divesh Dutta updated OFBIZ-7108:

Assignee: Swapnil Shah  (was: Anuj Jain)

> Provide an option to specify the Facility Location while producing the 
> inventory/stock once production run gets completed
> -
>
> Key: OFBIZ-7108
> URL: https://issues.apache.org/jira/browse/OFBIZ-7108
> Project: OFBiz
>  Issue Type: New Feature
>  Components: manufacturing
>Affects Versions: Upcoming Branch
>Reporter: Swapnil Shah
>Assignee: Swapnil Shah
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-7108.patch, OFBIZ-7110-A.patch, ProduceStock.png
>
>
> Currently there is no option to specify where the produced inventory against 
> finished good would be stocked in the facility. 
> Let's try to add the option to select and specify the facility location under 
> 'Production Run Produce' or 'Production Run Declare and Produce' section. 
> Once user submit the quantity and location same should be set over produced 
> InventoryItem.locationSeqId
> Please refer the attached screenshot for reference



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (OFBIZ-7108) Provide an option to specify the Facility Location while producing the inventory/stock once production run gets completed

2016-11-05 Thread Divesh Dutta (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-7108?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15639665#comment-15639665
 ] 

Divesh Dutta commented on OFBIZ-7108:
-

Thanks [~anuj.jain] . I have committed the work in revision number 1768215 in 
trunk. 

> Provide an option to specify the Facility Location while producing the 
> inventory/stock once production run gets completed
> -
>
> Key: OFBIZ-7108
> URL: https://issues.apache.org/jira/browse/OFBIZ-7108
> Project: OFBiz
>  Issue Type: New Feature
>  Components: manufacturing
>Affects Versions: Upcoming Branch
>Reporter: Swapnil Shah
>Assignee: Anuj Jain
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-7108.patch, OFBIZ-7110-A.patch, ProduceStock.png
>
>
> Currently there is no option to specify where the produced inventory against 
> finished good would be stocked in the facility. 
> Let's try to add the option to select and specify the facility location under 
> 'Production Run Produce' or 'Production Run Declare and Produce' section. 
> Once user submit the quantity and location same should be set over produced 
> InventoryItem.locationSeqId
> Please refer the attached screenshot for reference



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (OFBIZ-7108) Provide an option to specify the Facility Location while producing the inventory/stock once production run gets completed

2016-11-05 Thread Divesh Dutta (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-7108?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Divesh Dutta updated OFBIZ-7108:

Fix Version/s: Upcoming Branch

> Provide an option to specify the Facility Location while producing the 
> inventory/stock once production run gets completed
> -
>
> Key: OFBIZ-7108
> URL: https://issues.apache.org/jira/browse/OFBIZ-7108
> Project: OFBiz
>  Issue Type: New Feature
>  Components: manufacturing
>Affects Versions: Upcoming Branch
>Reporter: Swapnil Shah
>Assignee: Anuj Jain
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-7108.patch, OFBIZ-7110-A.patch, ProduceStock.png
>
>
> Currently there is no option to specify where the produced inventory against 
> finished good would be stocked in the facility. 
> Let's try to add the option to select and specify the facility location under 
> 'Production Run Produce' or 'Production Run Declare and Produce' section. 
> Once user submit the quantity and location same should be set over produced 
> InventoryItem.locationSeqId
> Please refer the attached screenshot for reference



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Closed] (OFBIZ-8471) Remove uneccessary call of isNotEmpty() to validate not null generic value

2016-11-05 Thread Divesh Dutta (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-8471?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Divesh Dutta closed OFBIZ-8471.
---

> Remove uneccessary call of isNotEmpty() to validate not null generic value
> --
>
> Key: OFBIZ-8471
> URL: https://issues.apache.org/jira/browse/OFBIZ-8471
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL COMPONENTS
>Affects Versions: Upcoming Branch
>Reporter: Ratnesh Upadhyay
>Assignee: Divesh Dutta
> Attachments: OFBIZ-8471.patch
>
>
> There are lots of places in code where we have used UtilValidate.isNotEmpty() 
> to validate GenericValue object. GenericValue will always be null or not 
> null, they will never empty. So instead of using utility method to validate 
> them we should be using native checks onwards.
> Example:
> Currently we are validating generic value in following ways 
> {code}
> if (UtilValidate.isNotEmpty(acctgTransEntry)) {
> {code}
> instead we will using it in this way: 
> {code}
> if (acctgTransEntry != null ) { 
> {code}
> Basically these validation methods should preferably be used on Strings or 
> Lists and normal Maps.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (OFBIZ-8471) Remove uneccessary call of isNotEmpty() to validate not null generic value

2016-11-05 Thread Divesh Dutta (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-8471?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15639381#comment-15639381
 ] 

Divesh Dutta commented on OFBIZ-8471:
-

Patch is committed in revision 1768192 in trunk. 

> Remove uneccessary call of isNotEmpty() to validate not null generic value
> --
>
> Key: OFBIZ-8471
> URL: https://issues.apache.org/jira/browse/OFBIZ-8471
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL COMPONENTS
>Affects Versions: Upcoming Branch
>Reporter: Ratnesh Upadhyay
>Assignee: Divesh Dutta
> Attachments: OFBIZ-8471.patch
>
>
> There are lots of places in code where we have used UtilValidate.isNotEmpty() 
> to validate GenericValue object. GenericValue will always be null or not 
> null, they will never empty. So instead of using utility method to validate 
> them we should be using native checks onwards.
> Example:
> Currently we are validating generic value in following ways 
> {code}
> if (UtilValidate.isNotEmpty(acctgTransEntry)) {
> {code}
> instead we will using it in this way: 
> {code}
> if (acctgTransEntry != null ) { 
> {code}
> Basically these validation methods should preferably be used on Strings or 
> Lists and normal Maps.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (OFBIZ-7012) VAT tax are not recorded as separate line items in Invoice for products with VAT tax included in their price

2016-11-05 Thread Divesh Dutta (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-7012?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15639326#comment-15639326
 ] 

Divesh Dutta commented on OFBIZ-7012:
-

Thanks [~ankush.upadhyay] for your work. It will be great if you can post the 
test cases for testing this work. Once I run test cases, I will close this 
ticket. 

> VAT tax are not recorded as separate line items in Invoice for products with 
> VAT tax included in their price
> 
>
> Key: OFBIZ-7012
> URL: https://issues.apache.org/jira/browse/OFBIZ-7012
> Project: OFBiz
>  Issue Type: New Feature
>  Components: accounting, order
>Reporter: Divesh Dutta
>Assignee: Divesh Dutta
> Attachments: OFBIZ-7012.patch
>
>
> In countries like UK VAT system works. So in VAT system, VAT taxes are 
> included in product's price. So OFBiz have support of VAT tax where you can 
> include VAT in product's price itself. Here is the example data we create to 
> enable VAT calculations:
>  {code}
> 
>  
> 
>  
> 
>  
>  taxAuthGeoId="GBR" taxAuthPartyId="GB_TA"/>
>  
>  productStoreId="9000" taxAuthGeoId="GBR" taxAuthPartyId="GB_TA" 
> taxAuthorityRateTypeId="VAT_TAX" taxPercentage="20.00" />
>  productPricePurposeId="PURCHASE" productPriceTypeId="DEFAULT_PRICE" 
> productStoreGroupId="_NA_" taxAuthGeoId="GBR" taxAuthPartyId="GB_TA" 
> taxInPrice="Y" />
>  {code}
> When invoices are created, tax amount included in product's price is not 
> separated in new invoice line item. And when general ledger postings are 
> done, then tax amount is not posted in Liability account. So due to this 
> organizations have no way to figure out how much tax is to be paid to tax 
> authority. 
> Ideally, product's actual price (without VAT) should be recorded in revenue 
> account and tax should be recorded in liability account. 
> For doing this, when invoice is created, VAT amount should be separated and 
> created as new line item. 
> Recently we have worked for one of our client where we have fixed this issue 
> and enabled invoicing in OFBiz to record vat tax amount as separate line 
> items. [~lektran] has actively worked with us to finalize the solution design 
> and completing the implementation. [~ankush.upadhyay] is the developer who 
> worked on solution design. [~ankush.upadhyay] please provide the patch for 
> this issue. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (OFBIZ-7012) VAT tax are not recorded as separate line items in Invoice for products with VAT tax included in their price

2016-11-05 Thread Divesh Dutta (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-7012?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15639323#comment-15639323
 ] 

Divesh Dutta commented on OFBIZ-7012:
-

Patch is committed in revision number: 1768186 in trunk. 

> VAT tax are not recorded as separate line items in Invoice for products with 
> VAT tax included in their price
> 
>
> Key: OFBIZ-7012
> URL: https://issues.apache.org/jira/browse/OFBIZ-7012
> Project: OFBiz
>  Issue Type: New Feature
>  Components: accounting, order
>Reporter: Divesh Dutta
>Assignee: Divesh Dutta
> Attachments: OFBIZ-7012.patch
>
>
> In countries like UK VAT system works. So in VAT system, VAT taxes are 
> included in product's price. So OFBiz have support of VAT tax where you can 
> include VAT in product's price itself. Here is the example data we create to 
> enable VAT calculations:
>  {code}
> 
>  
> 
>  
> 
>  
>  taxAuthGeoId="GBR" taxAuthPartyId="GB_TA"/>
>  
>  productStoreId="9000" taxAuthGeoId="GBR" taxAuthPartyId="GB_TA" 
> taxAuthorityRateTypeId="VAT_TAX" taxPercentage="20.00" />
>  productPricePurposeId="PURCHASE" productPriceTypeId="DEFAULT_PRICE" 
> productStoreGroupId="_NA_" taxAuthGeoId="GBR" taxAuthPartyId="GB_TA" 
> taxInPrice="Y" />
>  {code}
> When invoices are created, tax amount included in product's price is not 
> separated in new invoice line item. And when general ledger postings are 
> done, then tax amount is not posted in Liability account. So due to this 
> organizations have no way to figure out how much tax is to be paid to tax 
> authority. 
> Ideally, product's actual price (without VAT) should be recorded in revenue 
> account and tax should be recorded in liability account. 
> For doing this, when invoice is created, VAT amount should be separated and 
> created as new line item. 
> Recently we have worked for one of our client where we have fixed this issue 
> and enabled invoicing in OFBiz to record vat tax amount as separate line 
> items. [~lektran] has actively worked with us to finalize the solution design 
> and completing the implementation. [~ankush.upadhyay] is the developer who 
> worked on solution design. [~ankush.upadhyay] please provide the patch for 
> this issue. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (OFBIZ-7713) Introduce a quick way for adding Sales Price agreements with customers for any specific product from Catalog

2016-11-05 Thread Divesh Dutta (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-7713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15639153#comment-15639153
 ] 

Divesh Dutta commented on OFBIZ-7713:
-

Assigned Swapnil for verification and closure. 

> Introduce a quick way for adding Sales Price agreements with customers for 
> any specific product from Catalog
> 
>
> Key: OFBIZ-7713
> URL: https://issues.apache.org/jira/browse/OFBIZ-7713
> Project: OFBiz
>  Issue Type: New Feature
>  Components: product
>Affects Versions: 14.12.01, 15.12.01
>Reporter: Swapnil Shah
>Assignee: Swapnil Shah
> Attachments: OFBIZ-7713.patch, SPA.png
>
>
> Currently new pricing agreements creation takes user to Accounting app where 
> it is quite an long and arduous process. And many a times a catalog or sales 
> manager doesn't have accounting permission in case quick pricing agreement 
> needs to be placed with customer for specific product(s).
> We can provide a quick option from Catalog >> Product >> Agreement screen 
> over "Sales" section that could unfold as follows:
> # Have a 'Create Price Agreement' link/button on the Sales Panel and hitting 
> this link could ask user to enter following very basic parameters:
> #- Party Id From
> #- Party Id To (Default it to product store's owner party id)
> #- From Date (default it to show as now() timestamp)
> #- Through Date
> #- Description
> #- Price
> #- Currency
> # Upon successful submission of above details system should create Agreement 
> and Agreement Item between customer and organization by passing following 
> default values:
> #- Role Type Id From = 'Customer'
> #- Role Type Id To = 'Internal Organization'
> #- Agreement Type Id = 'Sales'
> #- Agreement Item Type Id = 'Pricing'
> #- Product Id= ''
> Please refer to attached screenshot for reference placeholder



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (OFBIZ-7713) Introduce a quick way for adding Sales Price agreements with customers for any specific product from Catalog

2016-11-05 Thread Divesh Dutta (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-7713?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Divesh Dutta updated OFBIZ-7713:

Assignee: Swapnil Shah  (was: Divesh Dutta)

> Introduce a quick way for adding Sales Price agreements with customers for 
> any specific product from Catalog
> 
>
> Key: OFBIZ-7713
> URL: https://issues.apache.org/jira/browse/OFBIZ-7713
> Project: OFBiz
>  Issue Type: New Feature
>  Components: product
>Affects Versions: 14.12.01, 15.12.01
>Reporter: Swapnil Shah
>Assignee: Swapnil Shah
> Attachments: OFBIZ-7713.patch, SPA.png
>
>
> Currently new pricing agreements creation takes user to Accounting app where 
> it is quite an long and arduous process. And many a times a catalog or sales 
> manager doesn't have accounting permission in case quick pricing agreement 
> needs to be placed with customer for specific product(s).
> We can provide a quick option from Catalog >> Product >> Agreement screen 
> over "Sales" section that could unfold as follows:
> # Have a 'Create Price Agreement' link/button on the Sales Panel and hitting 
> this link could ask user to enter following very basic parameters:
> #- Party Id From
> #- Party Id To (Default it to product store's owner party id)
> #- From Date (default it to show as now() timestamp)
> #- Through Date
> #- Description
> #- Price
> #- Currency
> # Upon successful submission of above details system should create Agreement 
> and Agreement Item between customer and organization by passing following 
> default values:
> #- Role Type Id From = 'Customer'
> #- Role Type Id To = 'Internal Organization'
> #- Agreement Type Id = 'Sales'
> #- Agreement Item Type Id = 'Pricing'
> #- Product Id= ''
> Please refer to attached screenshot for reference placeholder



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Assigned] (OFBIZ-7713) Introduce a quick way for adding Sales Price agreements with customers for any specific product from Catalog

2016-11-05 Thread Divesh Dutta (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-7713?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Divesh Dutta reassigned OFBIZ-7713:
---

Assignee: Divesh Dutta  (was: Mohammad Kathawala)

> Introduce a quick way for adding Sales Price agreements with customers for 
> any specific product from Catalog
> 
>
> Key: OFBIZ-7713
> URL: https://issues.apache.org/jira/browse/OFBIZ-7713
> Project: OFBiz
>  Issue Type: New Feature
>  Components: product
>Affects Versions: 14.12.01, 15.12.01
>Reporter: Swapnil Shah
>Assignee: Divesh Dutta
> Attachments: OFBIZ-7713.patch, SPA.png
>
>
> Currently new pricing agreements creation takes user to Accounting app where 
> it is quite an long and arduous process. And many a times a catalog or sales 
> manager doesn't have accounting permission in case quick pricing agreement 
> needs to be placed with customer for specific product(s).
> We can provide a quick option from Catalog >> Product >> Agreement screen 
> over "Sales" section that could unfold as follows:
> # Have a 'Create Price Agreement' link/button on the Sales Panel and hitting 
> this link could ask user to enter following very basic parameters:
> #- Party Id From
> #- Party Id To (Default it to product store's owner party id)
> #- From Date (default it to show as now() timestamp)
> #- Through Date
> #- Description
> #- Price
> #- Currency
> # Upon successful submission of above details system should create Agreement 
> and Agreement Item between customer and organization by passing following 
> default values:
> #- Role Type Id From = 'Customer'
> #- Role Type Id To = 'Internal Organization'
> #- Agreement Type Id = 'Sales'
> #- Agreement Item Type Id = 'Pricing'
> #- Product Id= ''
> Please refer to attached screenshot for reference placeholder



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Assigned] (OFBIZ-8471) Remove uneccessary call of isNotEmpty() to validate not null generic value

2016-10-27 Thread Divesh Dutta (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-8471?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Divesh Dutta reassigned OFBIZ-8471:
---

Assignee: Divesh Dutta

> Remove uneccessary call of isNotEmpty() to validate not null generic value
> --
>
> Key: OFBIZ-8471
> URL: https://issues.apache.org/jira/browse/OFBIZ-8471
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL COMPONENTS
>Affects Versions: Upcoming Branch
>Reporter: Ratnesh Upadhyay
>Assignee: Divesh Dutta
> Attachments: OFBIZ-8471.patch
>
>
> There are lots of places in code where we have used UtilValidate.isNotEmpty() 
> to validate GenericValue object. GenericValue will always be null or not 
> null, they will never empty. So instead of using utility method to validate 
> them we should be using native checks onwards.
> Example:
> Currently we are validating generic value in following ways 
> {code}
> if (UtilValidate.isNotEmpty(acctgTransEntry)) {
> {code}
> instead we will using it in this way: 
> {code}
> if (acctgTransEntry != null ) { 
> {code}
> Basically these validation methods should preferably be used on Strings or 
> Lists and normal Maps.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Closed] (OFBIZ-5130) getProductCost causes stack overflow if product has mutual variants

2016-09-17 Thread Divesh Dutta (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-5130?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Divesh Dutta closed OFBIZ-5130.
---
Resolution: Invalid

Closing this ticket as Invalid, as we could not conclude that when will we need 
to create mutual variants. So data set up used here is wrong.

> getProductCost causes stack overflow if product has mutual variants
> ---
>
> Key: OFBIZ-5130
> URL: https://issues.apache.org/jira/browse/OFBIZ-5130
> Project: OFBiz
>  Issue Type: Bug
>  Components: product
>Affects Versions: Trunk
>Reporter: Deepak Agarwal
>Assignee: Divesh Dutta
>  Labels: crash
> Attachments: OFBiz-5130.patch
>
>
> Cost of product A = 0
> Cost of product B = 0
> B is variant of A and A is variant of B.
> Now getProductCost causes a never ending recursive loop. This causes jvm to 
> exit (prior to Jdk1.6_34, atleast in my knowledge) without any crash dump.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (OFBIZ-7608) On Product>>Agreement screen rename the button label to create new agreement from "Edit Agreement" to "Create Agreement"

2016-09-17 Thread Divesh Dutta (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-7608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15498864#comment-15498864
 ] 

Divesh Dutta commented on OFBIZ-7608:
-

Swapnil , please verify and close the ticket. 

> On Product>>Agreement screen rename the button label to create new agreement 
> from "Edit Agreement" to "Create Agreement"
> 
>
> Key: OFBIZ-7608
> URL: https://issues.apache.org/jira/browse/OFBIZ-7608
> Project: OFBiz
>  Issue Type: Improvement
>Affects Versions: Trunk
>Reporter: Swapnil Shah
>Assignee: Swapnil Shah
>Priority: Minor
> Attachments: OFBIZ-7608.patch, PA.png
>
>
> Please refer to attached screenshot and change the button label to "Create 
> Agreement" as currently no agreement exists for given product



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (OFBIZ-7608) On Product>>Agreement screen rename the button label to create new agreement from "Edit Agreement" to "Create Agreement"

2016-09-17 Thread Divesh Dutta (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-7608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15498863#comment-15498863
 ] 

Divesh Dutta commented on OFBIZ-7608:
-

Patch is committed in revision number: 1761201

> On Product>>Agreement screen rename the button label to create new agreement 
> from "Edit Agreement" to "Create Agreement"
> 
>
> Key: OFBIZ-7608
> URL: https://issues.apache.org/jira/browse/OFBIZ-7608
> Project: OFBiz
>  Issue Type: Improvement
>Affects Versions: Trunk
>Reporter: Swapnil Shah
>Assignee: Divesh Dutta
>Priority: Minor
> Attachments: OFBIZ-7608.patch, PA.png
>
>
> Please refer to attached screenshot and change the button label to "Create 
> Agreement" as currently no agreement exists for given product



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Resolved] (OFBIZ-7649) Display "From Date" with default now() time-stamp and asterix sign on all forms where its part of Primary Key

2016-09-17 Thread Divesh Dutta (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-7649?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Divesh Dutta resolved OFBIZ-7649.
-
Resolution: Fixed

Swapnil please close this ticket after final verification of all the child 
tickets. 

> Display "From Date" with default now() time-stamp and asterix sign on all 
> forms where its part of Primary Key
> -
>
> Key: OFBIZ-7649
> URL: https://issues.apache.org/jira/browse/OFBIZ-7649
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL COMPONENTS
>Affects Versions: 14.12.01, 15.12.01
>Reporter: Swapnil Shah
>Assignee: Swapnil Shah
>
> Currently on many create/edit/add forms, where From Date is part of primary 
> key is shown as blank, If user leaves it as blank then system either doesn't 
> stop submitting the form but simply set it with now() timestamp implicitly or 
> errors out.
> As part of common UX practice, In all such forms/screen we could always try 
> defaulting and display From Date with now() time stamp (with asterix sign)  
> rather than showing it blank. So user is aware what would be set and its one 
> of the required fields on given form



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (OFBIZ-7649) Display "From Date" with default now() time-stamp and asterix sign on all forms where its part of Primary Key

2016-09-17 Thread Divesh Dutta (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-7649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15498795#comment-15498795
 ] 

Divesh Dutta commented on OFBIZ-7649:
-

All the patches of child tickets are committed in revision number 1761192. 

> Display "From Date" with default now() time-stamp and asterix sign on all 
> forms where its part of Primary Key
> -
>
> Key: OFBIZ-7649
> URL: https://issues.apache.org/jira/browse/OFBIZ-7649
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL COMPONENTS
>Affects Versions: 14.12.01, 15.12.01
>Reporter: Swapnil Shah
>Assignee: Swapnil Shah
>
> Currently on many create/edit/add forms, where From Date is part of primary 
> key is shown as blank, If user leaves it as blank then system either doesn't 
> stop submitting the form but simply set it with now() timestamp implicitly or 
> errors out.
> As part of common UX practice, In all such forms/screen we could always try 
> defaulting and display From Date with now() time stamp (with asterix sign)  
> rather than showing it blank. So user is aware what would be set and its one 
> of the required fields on given form



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Resolved] (OFBIZ-7542) Convert search criteria on 'Status' into multi-select pattern on all search screens

2016-09-17 Thread Divesh Dutta (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-7542?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Divesh Dutta resolved OFBIZ-7542.
-
Resolution: Fixed
  Assignee: Swapnil Shah  (was: Mohammad Kathawala)

All the child tickets are resolved. Assigning Swapnil for verification and 
closure. 

> Convert search criteria on 'Status' into multi-select pattern on all search 
> screens
> ---
>
> Key: OFBIZ-7542
> URL: https://issues.apache.org/jira/browse/OFBIZ-7542
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL COMPONENTS
>Affects Versions: Upcoming Branch
>Reporter: Swapnil Shah
>Assignee: Swapnil Shah
>
> There are many screens where search can be performed on on given status at a 
> time as its shown in form of dropdown and user can select only one value from 
> it.
> Like Order list screen, we can try using this multi-select as generic search 
> pattern starting with 'Status' and leveraging upon it for any other eligible 
> search criteria. It should behave as follows:
> # Selecting "All" (via checkbox) should auto-select all applicable statuses 
> # De-selecting "All" should remove selection from all selected statuses
> # After selecting "All" if any other status(es) are selected and "All" should 
> be de-selected automatically
> # Multiple statuses should be selectable simultaneously
> # The search result should honor the selected statuses



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (OFBIZ-7549) OFBIZ-7542: Convert search criteria on 'Status' into multi-select pattern for 'HR' component

2016-09-17 Thread Divesh Dutta (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-7549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15498765#comment-15498765
 ] 

Divesh Dutta commented on OFBIZ-7549:
-

Patch committed in revision number: 1761186

> OFBIZ-7542: Convert search criteria on 'Status' into multi-select pattern for 
> 'HR' component
> 
>
> Key: OFBIZ-7549
> URL: https://issues.apache.org/jira/browse/OFBIZ-7549
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: humanres
>Affects Versions: Trunk
>Reporter: Swapnil Shah
>Assignee: Swapnil Shah
> Attachments: OFBIZ-7549.patch
>
>
> Please refer to details shared over OFBIZ-7542



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (OFBIZ-7550) OFBIZ-7542: Convert search criteria on 'Status' into multi-select pattern for 'Project' component

2016-09-17 Thread Divesh Dutta (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-7550?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15498763#comment-15498763
 ] 

Divesh Dutta commented on OFBIZ-7550:
-

Patch committed in revision number 1761186

> OFBIZ-7542: Convert search criteria on 'Status' into multi-select pattern for 
> 'Project' component
> -
>
> Key: OFBIZ-7550
> URL: https://issues.apache.org/jira/browse/OFBIZ-7550
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: specialpurpose/projectmgr
>Affects Versions: Trunk
>Reporter: Swapnil Shah
>Assignee: Swapnil Shah
> Attachments: OFBIZ-7550.patch
>
>
> Please refer to details shared over OFBIZ-7542



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (OFBIZ-7548) OFBIZ-7542: Convert search criteria on 'Status' into multi-select pattern for 'WorkEffort' component

2016-09-17 Thread Divesh Dutta (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-7548?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15498751#comment-15498751
 ] 

Divesh Dutta commented on OFBIZ-7548:
-

Patch committed in revision number: 1761184

> OFBIZ-7542: Convert search criteria on 'Status' into multi-select pattern for 
> 'WorkEffort' component
> 
>
> Key: OFBIZ-7548
> URL: https://issues.apache.org/jira/browse/OFBIZ-7548
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: workeffort
>Affects Versions: Trunk
>Reporter: Swapnil Shah
>Assignee: Swapnil Shah
> Attachments: OFBIZ-7548.patch
>
>
> Please refer to details shared over OFBIZ-7542



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (OFBIZ-7547) OFBIZ-7542: Convert search criteria on 'Status' into multi-select pattern for 'Content' component

2016-09-17 Thread Divesh Dutta (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-7547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15498742#comment-15498742
 ] 

Divesh Dutta commented on OFBIZ-7547:
-

Committed in revision number: 1761178

> OFBIZ-7542: Convert search criteria on 'Status' into multi-select pattern for 
> 'Content' component
> -
>
> Key: OFBIZ-7547
> URL: https://issues.apache.org/jira/browse/OFBIZ-7547
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: content
>Affects Versions: Trunk
>Reporter: Swapnil Shah
>Assignee: Swapnil Shah
> Attachments: OFBIZ-7547.patch
>
>
> Please refer to details shared over OFBIZ-7542



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (OFBIZ-7546) OFBIZ-7542: Convert search criteria on 'Status' into multi-select pattern for 'Accounting' component

2016-09-17 Thread Divesh Dutta (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-7546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15498383#comment-15498383
 ] 

Divesh Dutta commented on OFBIZ-7546:
-

Patch is committed in revision number: 1761134

> OFBIZ-7542: Convert search criteria on 'Status' into multi-select pattern for 
> 'Accounting' component
> 
>
> Key: OFBIZ-7546
> URL: https://issues.apache.org/jira/browse/OFBIZ-7546
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: accounting
>Affects Versions: Trunk
>Reporter: Swapnil Shah
>Assignee: Swapnil Shah
> Attachments: OFBIZ-7546.patch
>
>
> Please refer to details shared over OFBIZ-7542



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (OFBIZ-7543) OFBIZ-7542: Convert search criteria on 'Status' into multi-select pattern for 'Order' component

2016-09-16 Thread Divesh Dutta (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-7543?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15498374#comment-15498374
 ] 

Divesh Dutta commented on OFBIZ-7543:
-

Patch is committed in revision number: 1761133. 

> OFBIZ-7542: Convert search criteria on 'Status' into multi-select pattern for 
> 'Order' component
> ---
>
> Key: OFBIZ-7543
> URL: https://issues.apache.org/jira/browse/OFBIZ-7543
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: order
>Affects Versions: Upcoming Branch
>Reporter: Swapnil Shah
>Assignee: Mohammad Kathawala
> Attachments: OFBIZ-7543.patch
>
>
> Please refer the details provided on OFBIZ-7542



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (OFBIZ-7544) OFBIZ-7542: Convert search criteria on 'Status' into multi-select pattern for 'Manufacturing' component

2016-09-16 Thread Divesh Dutta (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-7544?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15498355#comment-15498355
 ] 

Divesh Dutta commented on OFBIZ-7544:
-

I have committed the patch in revision number 1761126. 

> OFBIZ-7542: Convert search criteria on 'Status' into multi-select pattern for 
> 'Manufacturing' component
> ---
>
> Key: OFBIZ-7544
> URL: https://issues.apache.org/jira/browse/OFBIZ-7544
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: ALL COMPONENTS
>Reporter: Swapnil Shah
>Assignee: Mohammad Kathawala
> Attachments: OFBIZ-7544.patch
>
>
> Please refer to details shared over OFBIZ-7542



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (OFBIZ-7545) OFBIZ-7542: Convert search criteria on 'Status' into multi-select pattern for 'Facility' component

2016-09-16 Thread Divesh Dutta (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-7545?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15498345#comment-15498345
 ] 

Divesh Dutta commented on OFBIZ-7545:
-

Committed the patch in revision number: 1761125

> OFBIZ-7542: Convert search criteria on 'Status' into multi-select pattern for 
> 'Facility' component
> --
>
> Key: OFBIZ-7545
> URL: https://issues.apache.org/jira/browse/OFBIZ-7545
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: product
>Affects Versions: Trunk
>Reporter: Swapnil Shah
>Assignee: Swapnil Shah
> Attachments: OFBIZ-7545.patch
>
>
> Please refer to details shared over OFBIZ-7542



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Comment Edited] (OFBIZ-7108) Provide an option to specify the Facility Location while producing the inventory/stock once production run gets completed

2016-09-05 Thread Divesh Dutta (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-7108?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15338292#comment-15338292
 ] 

Divesh Dutta edited comment on OFBIZ-7108 at 9/5/16 7:02 PM:
-

Thanks [~anuj.jain]  for your patch . I have applied slightly modified patch.  
If product which is produced is not associated with facility then, 
ProductFacility record was created in service setLastInventoryCount, I skipped 
this part of the patch. I think this should be done in productionRunProduce 
service. So I am committing the main functionality to specify the facility 
location. Patch is committed in revision 1749109 in trunk

Please work on creating ProductFacility part in productionRunProduce service. 


was (Author: diveshdut):
Thanks [~anuj.jain]  for your patch . I have applied slightly modified patch.  
If product which is produced is not associated with facility then, 
ProductFacility record was created in service setLastInventoryCount, I skipped 
this part of the patch. I think this should be done in productionRunProduce 
service. So I am committing the main functionality to specify the facility 
location.

Please work on creating ProductFacility part in productionRunProduce service. 

> Provide an option to specify the Facility Location while producing the 
> inventory/stock once production run gets completed
> -
>
> Key: OFBIZ-7108
> URL: https://issues.apache.org/jira/browse/OFBIZ-7108
> Project: OFBiz
>  Issue Type: New Feature
>  Components: manufacturing
>Affects Versions: Upcoming Branch
>Reporter: Swapnil Shah
>Assignee: Anuj Jain
> Attachments: OFBIZ-7108.patch, ProduceStock.png
>
>
> Currently there is no option to specify where the produced inventory against 
> finished good would be stocked in the facility. 
> Let's try to add the option to select and specify the facility location under 
> 'Production Run Produce' or 'Production Run Declare and Produce' section. 
> Once user submit the quantity and location same should be set over produced 
> InventoryItem.locationSeqId
> Please refer the attached screenshot for reference



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (OFBIZ-7403) Allow user to select multiple options in "Purchases by Payment Method" report from basic search criterias while generating report

2016-09-05 Thread Divesh Dutta (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-7403?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Divesh Dutta updated OFBIZ-7403:

Assignee: Swapnil Shah  (was: Divesh Dutta)

> Allow user to select multiple options in "Purchases by Payment Method" report 
> from basic search criterias while generating report
> -
>
> Key: OFBIZ-7403
> URL: https://issues.apache.org/jira/browse/OFBIZ-7403
> Project: OFBiz
>  Issue Type: Improvement
>  Components: order
>Affects Versions: Trunk, 14.12.01, 15.12.01
>Reporter: Swapnil Shah
>Assignee: Swapnil Shah
> Attachments: Purchase_by_Payment_Method.png
>
>
> Currently system allow user to select any specific search criteria link and 
> hence 'Purchases by Payment Method' report is generated only based on any one 
> given selected criteria. 
> We can add the feature for generating single report based on multiple values 
> (possibly via checkbox?) within basic search criteria in this report namely:
> 1) Product Store
> 2) Origin Facility
> 3) Status
> 4) Let's convert Order type into radio button so it only work either for 
> Sales Order or for PO at one time/



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (OFBIZ-7394) Allow user to select multiple options in "Purchases by Product" report from basic search criterias while generating report

2016-09-05 Thread Divesh Dutta (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-7394?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Divesh Dutta updated OFBIZ-7394:

Assignee: Swapnil Shah  (was: Divesh Dutta)

> Allow user to select multiple options in "Purchases by Product" report from 
> basic search criterias while generating report
> --
>
> Key: OFBIZ-7394
> URL: https://issues.apache.org/jira/browse/OFBIZ-7394
> Project: OFBiz
>  Issue Type: Improvement
>  Components: order
>Affects Versions: Trunk, 14.12.01, 15.12.01
>Reporter: Swapnil Shah
>Assignee: Swapnil Shah
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-7394+OFBIZ-7403.patch, 
> OFBIZ-7394+OFBIZ-7403.patch, PurchasebyProduct.png
>
>
> Currently system allow user to select any specific search criteria link and 
> hence 'Purchases by Product' report is generated only based on any one given 
> selected criteria. 
> We can add the feature for generating single report based on multiple values 
> (possibly via checkbox?) within basic search criteria in this report namely:
> 1) Product Store
> 2) Origin Facility
> 3) Let's remove Order type and make it only work for Purchase Order type as 
> for Sales we already have similar report called "Sales by Store"



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (OFBIZ-7403) Allow user to select multiple options in "Purchases by Payment Method" report from basic search criterias while generating report

2016-09-05 Thread Divesh Dutta (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-7403?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15465586#comment-15465586
 ] 

Divesh Dutta commented on OFBIZ-7403:
-

Patch is committed in revision number : 1759343 in trunk.

> Allow user to select multiple options in "Purchases by Payment Method" report 
> from basic search criterias while generating report
> -
>
> Key: OFBIZ-7403
> URL: https://issues.apache.org/jira/browse/OFBIZ-7403
> Project: OFBiz
>  Issue Type: Improvement
>  Components: order
>Affects Versions: Trunk, 14.12.01, 15.12.01
>Reporter: Swapnil Shah
>Assignee: Swapnil Shah
> Attachments: Purchase_by_Payment_Method.png
>
>
> Currently system allow user to select any specific search criteria link and 
> hence 'Purchases by Payment Method' report is generated only based on any one 
> given selected criteria. 
> We can add the feature for generating single report based on multiple values 
> (possibly via checkbox?) within basic search criteria in this report namely:
> 1) Product Store
> 2) Origin Facility
> 3) Status
> 4) Let's convert Order type into radio button so it only work either for 
> Sales Order or for PO at one time/



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Resolved] (OFBIZ-7403) Allow user to select multiple options in "Purchases by Payment Method" report from basic search criterias while generating report

2016-09-05 Thread Divesh Dutta (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-7403?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Divesh Dutta resolved OFBIZ-7403.
-
Resolution: Fixed

> Allow user to select multiple options in "Purchases by Payment Method" report 
> from basic search criterias while generating report
> -
>
> Key: OFBIZ-7403
> URL: https://issues.apache.org/jira/browse/OFBIZ-7403
> Project: OFBiz
>  Issue Type: Improvement
>  Components: order
>Affects Versions: Trunk, 14.12.01, 15.12.01
>Reporter: Swapnil Shah
>Assignee: Divesh Dutta
> Attachments: Purchase_by_Payment_Method.png
>
>
> Currently system allow user to select any specific search criteria link and 
> hence 'Purchases by Payment Method' report is generated only based on any one 
> given selected criteria. 
> We can add the feature for generating single report based on multiple values 
> (possibly via checkbox?) within basic search criteria in this report namely:
> 1) Product Store
> 2) Origin Facility
> 3) Status
> 4) Let's convert Order type into radio button so it only work either for 
> Sales Order or for PO at one time/



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (OFBIZ-7403) Allow user to select multiple options in "Purchases by Payment Method" report from basic search criterias while generating report

2016-09-05 Thread Divesh Dutta (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-7403?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15465584#comment-15465584
 ] 

Divesh Dutta commented on OFBIZ-7403:
-

Assigning Swapnil Shah for verification and closure of this ticket.

> Allow user to select multiple options in "Purchases by Payment Method" report 
> from basic search criterias while generating report
> -
>
> Key: OFBIZ-7403
> URL: https://issues.apache.org/jira/browse/OFBIZ-7403
> Project: OFBiz
>  Issue Type: Improvement
>  Components: order
>Affects Versions: Trunk, 14.12.01, 15.12.01
>Reporter: Swapnil Shah
>Assignee: Divesh Dutta
> Attachments: Purchase_by_Payment_Method.png
>
>
> Currently system allow user to select any specific search criteria link and 
> hence 'Purchases by Payment Method' report is generated only based on any one 
> given selected criteria. 
> We can add the feature for generating single report based on multiple values 
> (possibly via checkbox?) within basic search criteria in this report namely:
> 1) Product Store
> 2) Origin Facility
> 3) Status
> 4) Let's convert Order type into radio button so it only work either for 
> Sales Order or for PO at one time/



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (OFBIZ-7394) Allow user to select multiple options in "Purchases by Product" report from basic search criterias while generating report

2016-09-05 Thread Divesh Dutta (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-7394?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Divesh Dutta updated OFBIZ-7394:

Fix Version/s: Upcoming Branch

> Allow user to select multiple options in "Purchases by Product" report from 
> basic search criterias while generating report
> --
>
> Key: OFBIZ-7394
> URL: https://issues.apache.org/jira/browse/OFBIZ-7394
> Project: OFBiz
>  Issue Type: Improvement
>  Components: order
>Affects Versions: Trunk, 14.12.01, 15.12.01
>Reporter: Swapnil Shah
>Assignee: Divesh Dutta
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-7394+OFBIZ-7403.patch, 
> OFBIZ-7394+OFBIZ-7403.patch, PurchasebyProduct.png
>
>
> Currently system allow user to select any specific search criteria link and 
> hence 'Purchases by Product' report is generated only based on any one given 
> selected criteria. 
> We can add the feature for generating single report based on multiple values 
> (possibly via checkbox?) within basic search criteria in this report namely:
> 1) Product Store
> 2) Origin Facility
> 3) Let's remove Order type and make it only work for Purchase Order type as 
> for Sales we already have similar report called "Sales by Store"



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (OFBIZ-7394) Allow user to select multiple options in "Purchases by Product" report from basic search criterias while generating report

2016-09-05 Thread Divesh Dutta (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-7394?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15465581#comment-15465581
 ] 

Divesh Dutta commented on OFBIZ-7394:
-

Patch is committed in revision number : 1759343 in trunk. 

> Allow user to select multiple options in "Purchases by Product" report from 
> basic search criterias while generating report
> --
>
> Key: OFBIZ-7394
> URL: https://issues.apache.org/jira/browse/OFBIZ-7394
> Project: OFBiz
>  Issue Type: Improvement
>  Components: order
>Affects Versions: Trunk, 14.12.01, 15.12.01
>Reporter: Swapnil Shah
>Assignee: Divesh Dutta
> Attachments: OFBIZ-7394+OFBIZ-7403.patch, 
> OFBIZ-7394+OFBIZ-7403.patch, PurchasebyProduct.png
>
>
> Currently system allow user to select any specific search criteria link and 
> hence 'Purchases by Product' report is generated only based on any one given 
> selected criteria. 
> We can add the feature for generating single report based on multiple values 
> (possibly via checkbox?) within basic search criteria in this report namely:
> 1) Product Store
> 2) Origin Facility
> 3) Let's remove Order type and make it only work for Purchase Order type as 
> for Sales we already have similar report called "Sales by Store"



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Assigned] (OFBIZ-7403) Allow user to select multiple options in "Purchases by Payment Method" report from basic search criterias while generating report

2016-09-05 Thread Divesh Dutta (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-7403?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Divesh Dutta reassigned OFBIZ-7403:
---

Assignee: Divesh Dutta  (was: Mohammad Kathawala)

> Allow user to select multiple options in "Purchases by Payment Method" report 
> from basic search criterias while generating report
> -
>
> Key: OFBIZ-7403
> URL: https://issues.apache.org/jira/browse/OFBIZ-7403
> Project: OFBiz
>  Issue Type: Improvement
>  Components: order
>Affects Versions: Trunk, 14.12.01, 15.12.01
>Reporter: Swapnil Shah
>Assignee: Divesh Dutta
> Attachments: Purchase_by_Payment_Method.png
>
>
> Currently system allow user to select any specific search criteria link and 
> hence 'Purchases by Payment Method' report is generated only based on any one 
> given selected criteria. 
> We can add the feature for generating single report based on multiple values 
> (possibly via checkbox?) within basic search criteria in this report namely:
> 1) Product Store
> 2) Origin Facility
> 3) Status
> 4) Let's convert Order type into radio button so it only work either for 
> Sales Order or for PO at one time/



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (OFBIZ-7440) Donation amount over Sales Order is getting invoiced pro-rated based on shipped qty

2016-09-05 Thread Divesh Dutta (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-7440?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Divesh Dutta updated OFBIZ-7440:

Assignee: Swapnil Shah  (was: Divesh Dutta)

> Donation amount over Sales Order is getting invoiced pro-rated based on 
> shipped qty
> ---
>
> Key: OFBIZ-7440
> URL: https://issues.apache.org/jira/browse/OFBIZ-7440
> Project: OFBiz
>  Issue Type: Improvement
>  Components: order
>Affects Versions: 14.12.01, 15.12.01
>Reporter: Swapnil Shah
>Assignee: Swapnil Shah
> Attachments: D1.png, D2.png, D3.png, OFBIZ-7440.patch
>
>
> Many a times business provide the option for customer to donate any amount 
> towards any specific purpose (like Welfare/Charity etc.) and such amount get 
> invoiced along upon sales shipment
> As per current systemic behavior its seen that donation amount gets pro-rated 
> based on shipped qty (in case of partial shipments). We could try to capture 
> donation in very first shipment for the sales order. 
> Please refer the attached screenshot for more details



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (OFBIZ-7440) Donation amount over Sales Order is getting invoiced pro-rated based on shipped qty

2016-09-05 Thread Divesh Dutta (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-7440?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15465554#comment-15465554
 ] 

Divesh Dutta commented on OFBIZ-7440:
-

Thanks [~ankush.upadhyay] for providing the patch . Your patch is committed in 
revision number 1759339 in trunk. 

> Donation amount over Sales Order is getting invoiced pro-rated based on 
> shipped qty
> ---
>
> Key: OFBIZ-7440
> URL: https://issues.apache.org/jira/browse/OFBIZ-7440
> Project: OFBiz
>  Issue Type: Improvement
>  Components: order
>Affects Versions: 14.12.01, 15.12.01
>Reporter: Swapnil Shah
>Assignee: Divesh Dutta
> Attachments: D1.png, D2.png, D3.png, OFBIZ-7440.patch
>
>
> Many a times business provide the option for customer to donate any amount 
> towards any specific purpose (like Welfare/Charity etc.) and such amount get 
> invoiced along upon sales shipment
> As per current systemic behavior its seen that donation amount gets pro-rated 
> based on shipped qty (in case of partial shipments). We could try to capture 
> donation in very first shipment for the sales order. 
> Please refer the attached screenshot for more details



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (OFBIZ-7533) Not able to set new Lot Id to existing inventory item

2016-09-05 Thread Divesh Dutta (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-7533?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15465484#comment-15465484
 ] 

Divesh Dutta commented on OFBIZ-7533:
-

Assigning Swapnil Shah for verification and closure. 

> Not able to set new Lot Id to existing inventory item
> -
>
> Key: OFBIZ-7533
> URL: https://issues.apache.org/jira/browse/OFBIZ-7533
> Project: OFBiz
>  Issue Type: Improvement
>  Components: product
>Affects Versions: Upcoming Branch
>Reporter: Swapnil Shah
>Assignee: Swapnil Shah
> Fix For: Upcoming Branch
>
> Attachments: II_LOT.png, OFBIZ-7533.patch
>
>
> When any new lot is assigned to exiting inventory item then it ends up 
> throwing foreign key constraint.
> We could allow it by creating first new lot (if its not found already 
> existent in DB) and then associate the same with given inventory item. (Also 
> currently i couldn't find any screen to create new lot in given facility)
> Please refer to attached screenshot for reference.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (OFBIZ-7533) Not able to set new Lot Id to existing inventory item

2016-09-05 Thread Divesh Dutta (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-7533?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Divesh Dutta updated OFBIZ-7533:

Assignee: Swapnil Shah  (was: Divesh Dutta)

> Not able to set new Lot Id to existing inventory item
> -
>
> Key: OFBIZ-7533
> URL: https://issues.apache.org/jira/browse/OFBIZ-7533
> Project: OFBiz
>  Issue Type: Improvement
>  Components: product
>Affects Versions: Upcoming Branch
>Reporter: Swapnil Shah
>Assignee: Swapnil Shah
> Fix For: Upcoming Branch
>
> Attachments: II_LOT.png, OFBIZ-7533.patch
>
>
> When any new lot is assigned to exiting inventory item then it ends up 
> throwing foreign key constraint.
> We could allow it by creating first new lot (if its not found already 
> existent in DB) and then associate the same with given inventory item. (Also 
> currently i couldn't find any screen to create new lot in given facility)
> Please refer to attached screenshot for reference.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (OFBIZ-7533) Not able to set new Lot Id to existing inventory item

2016-09-05 Thread Divesh Dutta (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-7533?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15465475#comment-15465475
 ] 

Divesh Dutta commented on OFBIZ-7533:
-

I have committed [~ankush.upadhyay]'s patch in revision number 1759336 in 
trunk. Thanks [~swash78] for reporting the issue and Ankush for providing the 
patch. 

> Not able to set new Lot Id to existing inventory item
> -
>
> Key: OFBIZ-7533
> URL: https://issues.apache.org/jira/browse/OFBIZ-7533
> Project: OFBiz
>  Issue Type: Improvement
>  Components: product
>Affects Versions: Upcoming Branch
>Reporter: Swapnil Shah
>Assignee: Ankush Upadhyay
> Fix For: Upcoming Branch
>
> Attachments: II_LOT.png, OFBIZ-7533.patch
>
>
> When any new lot is assigned to exiting inventory item then it ends up 
> throwing foreign key constraint.
> We could allow it by creating first new lot (if its not found already 
> existent in DB) and then associate the same with given inventory item. (Also 
> currently i couldn't find any screen to create new lot in given facility)
> Please refer to attached screenshot for reference.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (OFBIZ-7533) Not able to set new Lot Id to existing inventory item

2016-09-05 Thread Divesh Dutta (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-7533?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Divesh Dutta updated OFBIZ-7533:

Fix Version/s: Upcoming Branch

> Not able to set new Lot Id to existing inventory item
> -
>
> Key: OFBIZ-7533
> URL: https://issues.apache.org/jira/browse/OFBIZ-7533
> Project: OFBiz
>  Issue Type: Improvement
>  Components: product
>Affects Versions: Upcoming Branch
>Reporter: Swapnil Shah
>Assignee: Divesh Dutta
> Fix For: Upcoming Branch
>
> Attachments: II_LOT.png, OFBIZ-7533.patch
>
>
> When any new lot is assigned to exiting inventory item then it ends up 
> throwing foreign key constraint.
> We could allow it by creating first new lot (if its not found already 
> existent in DB) and then associate the same with given inventory item. (Also 
> currently i couldn't find any screen to create new lot in given facility)
> Please refer to attached screenshot for reference.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Assigned] (OFBIZ-7533) Not able to set new Lot Id to existing inventory item

2016-09-05 Thread Divesh Dutta (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-7533?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Divesh Dutta reassigned OFBIZ-7533:
---

Assignee: Divesh Dutta  (was: Ankush Upadhyay)

> Not able to set new Lot Id to existing inventory item
> -
>
> Key: OFBIZ-7533
> URL: https://issues.apache.org/jira/browse/OFBIZ-7533
> Project: OFBiz
>  Issue Type: Improvement
>  Components: product
>Affects Versions: Upcoming Branch
>Reporter: Swapnil Shah
>Assignee: Divesh Dutta
> Fix For: Upcoming Branch
>
> Attachments: II_LOT.png, OFBIZ-7533.patch
>
>
> When any new lot is assigned to exiting inventory item then it ends up 
> throwing foreign key constraint.
> We could allow it by creating first new lot (if its not found already 
> existent in DB) and then associate the same with given inventory item. (Also 
> currently i couldn't find any screen to create new lot in given facility)
> Please refer to attached screenshot for reference.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (OFBIZ-7721) auto-completer does not work to search Data Resource Id and owner content id

2016-09-05 Thread Divesh Dutta (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-7721?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Divesh Dutta updated OFBIZ-7721:

Fix Version/s: Upcoming Branch

> auto-completer does not work to search  Data Resource Id  and owner content id
> --
>
> Key: OFBIZ-7721
> URL: https://issues.apache.org/jira/browse/OFBIZ-7721
> Project: OFBiz
>  Issue Type: Bug
>  Components: content
>Affects Versions: Upcoming Branch
>Reporter: Ankush Upadhyay
>Assignee: Ankush Upadhyay
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-7721.patch
>
>
> Steps to reproduce:
> 1. Login to content manager.
> 2. Go to find content page.
> 3. Search data resource id or owner content id using auto-completer.
> Expected behavior: auto-completer should work and return results like lookup 
> does.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Closed] (OFBIZ-7721) auto-completer does not work to search Data Resource Id and owner content id

2016-09-05 Thread Divesh Dutta (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-7721?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Divesh Dutta closed OFBIZ-7721.
---
Resolution: Fixed

> auto-completer does not work to search  Data Resource Id  and owner content id
> --
>
> Key: OFBIZ-7721
> URL: https://issues.apache.org/jira/browse/OFBIZ-7721
> Project: OFBiz
>  Issue Type: Bug
>  Components: content
>Affects Versions: Upcoming Branch
>Reporter: Ankush Upadhyay
>Assignee: Ankush Upadhyay
> Attachments: OFBIZ-7721.patch
>
>
> Steps to reproduce:
> 1. Login to content manager.
> 2. Go to find content page.
> 3. Search data resource id or owner content id using auto-completer.
> Expected behavior: auto-completer should work and return results like lookup 
> does.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (OFBIZ-7721) auto-completer does not work to search Data Resource Id and owner content id

2016-09-05 Thread Divesh Dutta (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-7721?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15465427#comment-15465427
 ] 

Divesh Dutta commented on OFBIZ-7721:
-

Thanks [~ankush.upadhyay] for reporting the issue and providing the patch. I 
have committed your patch in revision number 1759333.  [~Florian M] please 
create the ticket as you mentioned in this ticket. 

> auto-completer does not work to search  Data Resource Id  and owner content id
> --
>
> Key: OFBIZ-7721
> URL: https://issues.apache.org/jira/browse/OFBIZ-7721
> Project: OFBiz
>  Issue Type: Bug
>  Components: content
>Affects Versions: Upcoming Branch
>Reporter: Ankush Upadhyay
>Assignee: Ankush Upadhyay
> Attachments: OFBIZ-7721.patch
>
>
> Steps to reproduce:
> 1. Login to content manager.
> 2. Go to find content page.
> 3. Search data resource id or owner content id using auto-completer.
> Expected behavior: auto-completer should work and return results like lookup 
> does.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Closed] (OFBIZ-7724) System allows to change status from cancel to empty for return and allow-empty flag of form widget does not honour to add or not empty option field in drop-down

2016-09-05 Thread Divesh Dutta (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-7724?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Divesh Dutta closed OFBIZ-7724.
---

> System allows to change status from cancel to empty for return and 
> allow-empty flag of form widget does not honour to add or not empty option 
> field in drop-down 
> -
>
> Key: OFBIZ-7724
> URL: https://issues.apache.org/jira/browse/OFBIZ-7724
> Project: OFBiz
>  Issue Type: Bug
>  Components: framework, order
>Affects Versions: Upcoming Branch
>Reporter: Ankush Upadhyay
>Assignee: Ankush Upadhyay
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-7724.patch
>
>
> Steps to replicate:
> 1. Create Return from Order Manager.
> 2. Changes status to cancelled to empty.
> Actually Result:
> System throws FreeMarker template error and system does not honour 
> allow-empty flag to display or hide empty option in drop-down.
> Expected: System should not show throw free marker template error or even it 
> should not display empty status as this is not a valid status change.
> Also system should honour allow-empty flag to render empty value in drop-down.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (OFBIZ-7724) System allows to change status from cancel to empty for return and allow-empty flag of form widget does not honour to add or not empty option field in drop-down

2016-09-05 Thread Divesh Dutta (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-7724?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Divesh Dutta updated OFBIZ-7724:

Fix Version/s: Upcoming Branch

> System allows to change status from cancel to empty for return and 
> allow-empty flag of form widget does not honour to add or not empty option 
> field in drop-down 
> -
>
> Key: OFBIZ-7724
> URL: https://issues.apache.org/jira/browse/OFBIZ-7724
> Project: OFBiz
>  Issue Type: Bug
>  Components: framework, order
>Affects Versions: Upcoming Branch
>Reporter: Ankush Upadhyay
>Assignee: Ankush Upadhyay
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-7724.patch
>
>
> Steps to replicate:
> 1. Create Return from Order Manager.
> 2. Changes status to cancelled to empty.
> Actually Result:
> System throws FreeMarker template error and system does not honour 
> allow-empty flag to display or hide empty option in drop-down.
> Expected: System should not show throw free marker template error or even it 
> should not display empty status as this is not a valid status change.
> Also system should honour allow-empty flag to render empty value in drop-down.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


  1   2   >