[jira] [Commented] (OFBIZ-9984) Convert OrderServices.xml mini-lang to groovyDSL
[ https://issues.apache.org/jira/browse/OFBIZ-9984?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17883714#comment-17883714 ] Gil Portenseigne commented on OFBIZ-9984: - Hi [~jleroux] , yes that the idea :), i had missed your message, and [~mleila] offered to take it ! > Convert OrderServices.xml mini-lang to groovyDSL > > > Key: OFBIZ-9984 > URL: https://issues.apache.org/jira/browse/OFBIZ-9984 > Project: OFBiz > Issue Type: Sub-task > Components: order >Affects Versions: Trunk, Upcoming Branch >Reporter: Julien NICOLAS >Assignee: Gil Portenseigne >Priority: Minor > Labels: groovy, mini-lang > Attachments: OFBIZ-9984-v1.patch, OFBIZ-9984.patch > > > With the purpose to deprecate mini-lang OFBIZ-9350, I tried to convert some > mini-lang service to groovy script. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Closed] (OFBIZ-11067) Migrate integration tests to unit tests when possible
[
https://issues.apache.org/jira/browse/OFBIZ-11067?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gil Portenseigne closed OFBIZ-11067.
Resolution: Fixed
Thanks Gaëtan for your catch and contribution !
> Migrate integration tests to unit tests when possible
> -
>
> Key: OFBIZ-11067
> URL: https://issues.apache.org/jira/browse/OFBIZ-11067
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
>Affects Versions: Trunk, Upcoming Branch
>Reporter: Mathieu Lirzin
>Assignee: Gil Portenseigne
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments:
> OFBIZ-11067_0001-Turn-UtilPropertiesTests-into-a-unit-test-c.patch,
> OFBIZ-11067_0002-Turn-ComparableRangeTests-into-a-unit-test-.patch,
> OFBIZ-11067_0003-Turn-DateTimeTests-into-a-unit-test-class.patch,
> OFBIZ-11067_0004-Turn-GenericMapTest-into-a-unit-test-class.patch,
> OFBIZ-11067_0005-Turn-IndentingWriterTests-into-a-unit-test-.patch,
> OFBIZ-11067_0006-Turn-MiscTests-into-a-unit-test-class.patch,
> OFBIZ-11067_0007-Turn-ObjectTypeTests-into-a-unit-test-class.patch,
> OFBIZ-11067_0008-Turn-ReferenceCleanerTests-into-a-unit-test.patch,
> OFBIZ-11067_0009-Turn-TimeDurationTests-into-a-unit-test-cla.patch,
> OFBIZ-11067_0010-Turn-UtilCacheTests-into-a-unit-test-class.patch,
> OFBIZ-11067_0011-Remove-empty-UtilHttpTests-class.patch,
> OFBIZ-11067_0012-Turn-UtilIOTests-into-a-unit-test-class.patch,
> OFBIZ-11067_0013-Turn-UtilMiscTests-into-a-unit-test-class.patch,
> OFBIZ-11067_0014-Turn-AssertTests-into-a-unit-test-class.patch,
> OFBIZ-11067_0015-Turn-BaseUnitTests-into-a-unit-test-class.patch,
> OFBIZ-11067_0016-Turn-TestBooleanConverters-into-a-unit-test.patch,
> OFBIZ-11067_0017-Turn-TestJSONConverters-into-a-unit-test-cl.patch,
> OFBIZ-11067_0018-Turn-UtilObjectTests-into-a-unit-test-class.patch,
> OFBIZ-11067_0019-Merge-UtilObjectUnitTest-into-UtilObjectTes.patch,
> OFBIZ-11067_fixes_FlexibleStringExpanderTests_and_FlexibleMapAcessor_tests-1.patch,
>
> OFBIZ-11067_fixes_FlexibleStringExpanderTests_and_FlexibleMapAcessor_tests.patch,
>
> OFBIZ-11067_turns_FlexibleMapAccessorTests_and_FlexibleStringExpanderTests_into_unit_tests-1.patch,
>
> OFBIZ-11067_turns_FlexibleMapAccessorTests_and_FlexibleStringExpanderTests_into_unit_tests.patch,
>
> Patch_with_FlexibleMapAccessorTests_included_that_was_forgotten_in_the_previous_patch.patch
>
>
> In OFBiz there are both unit tests and integration tests which are
> respectively run by {{./gradlew test}} and {{./gradlew testIntegration}}.
> However some integration tests are in fact unit tests that doesn't depend on
> the entity and service engines. Those unit tests should run on the their
> appropriate task.
> To do that it is necessary to convert them to use Junit4 instead of Junit3
> which is what is done for the integration test suite.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (OFBIZ-11067) Migrate integration tests to unit tests when possible
[
https://issues.apache.org/jira/browse/OFBIZ-11067?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17837261#comment-17837261
]
Gil Portenseigne commented on OFBIZ-11067:
--
Hi [~jleroux] , if you don't mind, i will take care of it at the same time.
There is a git move and this modification in the patch to make the
FlexibleMapAccessorTests run.
> Migrate integration tests to unit tests when possible
> -
>
> Key: OFBIZ-11067
> URL: https://issues.apache.org/jira/browse/OFBIZ-11067
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
>Affects Versions: Trunk, Upcoming Branch
>Reporter: Mathieu Lirzin
>Assignee: Gil Portenseigne
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments:
> OFBIZ-11067_0001-Turn-UtilPropertiesTests-into-a-unit-test-c.patch,
> OFBIZ-11067_0002-Turn-ComparableRangeTests-into-a-unit-test-.patch,
> OFBIZ-11067_0003-Turn-DateTimeTests-into-a-unit-test-class.patch,
> OFBIZ-11067_0004-Turn-GenericMapTest-into-a-unit-test-class.patch,
> OFBIZ-11067_0005-Turn-IndentingWriterTests-into-a-unit-test-.patch,
> OFBIZ-11067_0006-Turn-MiscTests-into-a-unit-test-class.patch,
> OFBIZ-11067_0007-Turn-ObjectTypeTests-into-a-unit-test-class.patch,
> OFBIZ-11067_0008-Turn-ReferenceCleanerTests-into-a-unit-test.patch,
> OFBIZ-11067_0009-Turn-TimeDurationTests-into-a-unit-test-cla.patch,
> OFBIZ-11067_0010-Turn-UtilCacheTests-into-a-unit-test-class.patch,
> OFBIZ-11067_0011-Remove-empty-UtilHttpTests-class.patch,
> OFBIZ-11067_0012-Turn-UtilIOTests-into-a-unit-test-class.patch,
> OFBIZ-11067_0013-Turn-UtilMiscTests-into-a-unit-test-class.patch,
> OFBIZ-11067_0014-Turn-AssertTests-into-a-unit-test-class.patch,
> OFBIZ-11067_0015-Turn-BaseUnitTests-into-a-unit-test-class.patch,
> OFBIZ-11067_0016-Turn-TestBooleanConverters-into-a-unit-test.patch,
> OFBIZ-11067_0017-Turn-TestJSONConverters-into-a-unit-test-cl.patch,
> OFBIZ-11067_0018-Turn-UtilObjectTests-into-a-unit-test-class.patch,
> OFBIZ-11067_0019-Merge-UtilObjectUnitTest-into-UtilObjectTes.patch,
> OFBIZ-11067_fixes_FlexibleStringExpanderTests_and_FlexibleMapAcessor_tests-1.patch,
>
> OFBIZ-11067_fixes_FlexibleStringExpanderTests_and_FlexibleMapAcessor_tests.patch,
>
> OFBIZ-11067_turns_FlexibleMapAccessorTests_and_FlexibleStringExpanderTests_into_unit_tests-1.patch,
>
> OFBIZ-11067_turns_FlexibleMapAccessorTests_and_FlexibleStringExpanderTests_into_unit_tests.patch,
>
> Patch_with_FlexibleMapAccessorTests_included_that_was_forgotten_in_the_previous_patch.patch
>
>
> In OFBiz there are both unit tests and integration tests which are
> respectively run by {{./gradlew test}} and {{./gradlew testIntegration}}.
> However some integration tests are in fact unit tests that doesn't depend on
> the entity and service engines. Those unit tests should run on the their
> appropriate task.
> To do that it is necessary to convert them to use Junit4 instead of Junit3
> which is what is done for the integration test suite.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Assigned] (OFBIZ-11067) Migrate integration tests to unit tests when possible
[
https://issues.apache.org/jira/browse/OFBIZ-11067?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gil Portenseigne reassigned OFBIZ-11067:
Assignee: Gil Portenseigne (was: Jacques Le Roux)
> Migrate integration tests to unit tests when possible
> -
>
> Key: OFBIZ-11067
> URL: https://issues.apache.org/jira/browse/OFBIZ-11067
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
>Affects Versions: Trunk, Upcoming Branch
>Reporter: Mathieu Lirzin
>Assignee: Gil Portenseigne
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments:
> OFBIZ-11067_0001-Turn-UtilPropertiesTests-into-a-unit-test-c.patch,
> OFBIZ-11067_0002-Turn-ComparableRangeTests-into-a-unit-test-.patch,
> OFBIZ-11067_0003-Turn-DateTimeTests-into-a-unit-test-class.patch,
> OFBIZ-11067_0004-Turn-GenericMapTest-into-a-unit-test-class.patch,
> OFBIZ-11067_0005-Turn-IndentingWriterTests-into-a-unit-test-.patch,
> OFBIZ-11067_0006-Turn-MiscTests-into-a-unit-test-class.patch,
> OFBIZ-11067_0007-Turn-ObjectTypeTests-into-a-unit-test-class.patch,
> OFBIZ-11067_0008-Turn-ReferenceCleanerTests-into-a-unit-test.patch,
> OFBIZ-11067_0009-Turn-TimeDurationTests-into-a-unit-test-cla.patch,
> OFBIZ-11067_0010-Turn-UtilCacheTests-into-a-unit-test-class.patch,
> OFBIZ-11067_0011-Remove-empty-UtilHttpTests-class.patch,
> OFBIZ-11067_0012-Turn-UtilIOTests-into-a-unit-test-class.patch,
> OFBIZ-11067_0013-Turn-UtilMiscTests-into-a-unit-test-class.patch,
> OFBIZ-11067_0014-Turn-AssertTests-into-a-unit-test-class.patch,
> OFBIZ-11067_0015-Turn-BaseUnitTests-into-a-unit-test-class.patch,
> OFBIZ-11067_0016-Turn-TestBooleanConverters-into-a-unit-test.patch,
> OFBIZ-11067_0017-Turn-TestJSONConverters-into-a-unit-test-cl.patch,
> OFBIZ-11067_0018-Turn-UtilObjectTests-into-a-unit-test-class.patch,
> OFBIZ-11067_0019-Merge-UtilObjectUnitTest-into-UtilObjectTes.patch,
> OFBIZ-11067_fixes_FlexibleStringExpanderTests_and_FlexibleMapAcessor_tests-1.patch,
>
> OFBIZ-11067_fixes_FlexibleStringExpanderTests_and_FlexibleMapAcessor_tests.patch,
>
> OFBIZ-11067_turns_FlexibleMapAccessorTests_and_FlexibleStringExpanderTests_into_unit_tests-1.patch,
>
> OFBIZ-11067_turns_FlexibleMapAccessorTests_and_FlexibleStringExpanderTests_into_unit_tests.patch
>
>
> In OFBiz there are both unit tests and integration tests which are
> respectively run by {{./gradlew test}} and {{./gradlew testIntegration}}.
> However some integration tests are in fact unit tests that doesn't depend on
> the entity and service engines. Those unit tests should run on the their
> appropriate task.
> To do that it is necessary to convert them to use Junit4 instead of Junit3
> which is what is done for the integration test suite.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (OFBIZ-11067) Migrate integration tests to unit tests when possible
[
https://issues.apache.org/jira/browse/OFBIZ-11067?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17837094#comment-17837094
]
Gil Portenseigne commented on OFBIZ-11067:
--
i do it this day :D
> Migrate integration tests to unit tests when possible
> -
>
> Key: OFBIZ-11067
> URL: https://issues.apache.org/jira/browse/OFBIZ-11067
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
>Affects Versions: Trunk, Upcoming Branch
>Reporter: Mathieu Lirzin
>Assignee: Jacques Le Roux
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments:
> OFBIZ-11067_0001-Turn-UtilPropertiesTests-into-a-unit-test-c.patch,
> OFBIZ-11067_0002-Turn-ComparableRangeTests-into-a-unit-test-.patch,
> OFBIZ-11067_0003-Turn-DateTimeTests-into-a-unit-test-class.patch,
> OFBIZ-11067_0004-Turn-GenericMapTest-into-a-unit-test-class.patch,
> OFBIZ-11067_0005-Turn-IndentingWriterTests-into-a-unit-test-.patch,
> OFBIZ-11067_0006-Turn-MiscTests-into-a-unit-test-class.patch,
> OFBIZ-11067_0007-Turn-ObjectTypeTests-into-a-unit-test-class.patch,
> OFBIZ-11067_0008-Turn-ReferenceCleanerTests-into-a-unit-test.patch,
> OFBIZ-11067_0009-Turn-TimeDurationTests-into-a-unit-test-cla.patch,
> OFBIZ-11067_0010-Turn-UtilCacheTests-into-a-unit-test-class.patch,
> OFBIZ-11067_0011-Remove-empty-UtilHttpTests-class.patch,
> OFBIZ-11067_0012-Turn-UtilIOTests-into-a-unit-test-class.patch,
> OFBIZ-11067_0013-Turn-UtilMiscTests-into-a-unit-test-class.patch,
> OFBIZ-11067_0014-Turn-AssertTests-into-a-unit-test-class.patch,
> OFBIZ-11067_0015-Turn-BaseUnitTests-into-a-unit-test-class.patch,
> OFBIZ-11067_0016-Turn-TestBooleanConverters-into-a-unit-test.patch,
> OFBIZ-11067_0017-Turn-TestJSONConverters-into-a-unit-test-cl.patch,
> OFBIZ-11067_0018-Turn-UtilObjectTests-into-a-unit-test-class.patch,
> OFBIZ-11067_0019-Merge-UtilObjectUnitTest-into-UtilObjectTes.patch,
> OFBIZ-11067_fixes_FlexibleStringExpanderTests_and_FlexibleMapAcessor_tests-1.patch,
>
> OFBIZ-11067_fixes_FlexibleStringExpanderTests_and_FlexibleMapAcessor_tests.patch,
>
> OFBIZ-11067_turns_FlexibleMapAccessorTests_and_FlexibleStringExpanderTests_into_unit_tests-1.patch,
>
> OFBIZ-11067_turns_FlexibleMapAccessorTests_and_FlexibleStringExpanderTests_into_unit_tests.patch
>
>
> In OFBiz there are both unit tests and integration tests which are
> respectively run by {{./gradlew test}} and {{./gradlew testIntegration}}.
> However some integration tests are in fact unit tests that doesn't depend on
> the entity and service engines. Those unit tests should run on the their
> appropriate task.
> To do that it is necessary to convert them to use Junit4 instead of Junit3
> which is what is done for the integration test suite.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (OFBIZ-13009) Fix Ecommerce Groovy tests
[ https://issues.apache.org/jira/browse/OFBIZ-13009?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17836265#comment-17836265 ] Gil Portenseigne commented on OFBIZ-13009: -- oops, i failed codenarc rules, that is now fixed. Closing > Fix Ecommerce Groovy tests > -- > > Key: OFBIZ-13009 > URL: https://issues.apache.org/jira/browse/OFBIZ-13009 > Project: OFBiz > Issue Type: Sub-task >Affects Versions: Upcoming Branch >Reporter: Gil Portenseigne >Assignee: Gil Portenseigne >Priority: Major > Fix For: Upcoming Branch > > > Unable to load test suite class : > org.apache.ofbiz.ecommerce.OrderNotificationTests -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Closed] (OFBIZ-13009) Fix Ecommerce Groovy tests
[ https://issues.apache.org/jira/browse/OFBIZ-13009?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gil Portenseigne closed OFBIZ-13009. Resolution: Fixed > Fix Ecommerce Groovy tests > -- > > Key: OFBIZ-13009 > URL: https://issues.apache.org/jira/browse/OFBIZ-13009 > Project: OFBiz > Issue Type: Sub-task >Affects Versions: Upcoming Branch >Reporter: Gil Portenseigne >Assignee: Gil Portenseigne >Priority: Major > Fix For: Upcoming Branch > > > Unable to load test suite class : > org.apache.ofbiz.ecommerce.OrderNotificationTests -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (OFBIZ-13009) Fix Ecommerce Groovy tests
[ https://issues.apache.org/jira/browse/OFBIZ-13009?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gil Portenseigne updated OFBIZ-13009: - Fix Version/s: Upcoming Branch > Fix Ecommerce Groovy tests > -- > > Key: OFBIZ-13009 > URL: https://issues.apache.org/jira/browse/OFBIZ-13009 > Project: OFBiz > Issue Type: Sub-task >Affects Versions: Upcoming Branch >Reporter: Gil Portenseigne >Assignee: Gil Portenseigne >Priority: Major > Fix For: Upcoming Branch > > > Unable to load test suite class : > org.apache.ofbiz.ecommerce.OrderNotificationTests -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Closed] (OFBIZ-13003) Fix Assetmain Groovy tests
[ https://issues.apache.org/jira/browse/OFBIZ-13003?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gil Portenseigne closed OFBIZ-13003. Resolution: Fixed > Fix Assetmain Groovy tests > -- > > Key: OFBIZ-13003 > URL: https://issues.apache.org/jira/browse/OFBIZ-13003 > Project: OFBiz > Issue Type: Sub-task > Components: assetmaint >Affects Versions: Upcoming Branch >Reporter: Jacques Le Roux >Priority: Major > Fix For: Upcoming Branch > > > Unable to load test suite class : > org.apache.ofbiz.assetmaint.test.FixedAssetMaintTests -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OFBIZ-13009) Fix Ecommerce Groovy tests
[ https://issues.apache.org/jira/browse/OFBIZ-13009?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17836246#comment-17836246 ] Gil Portenseigne commented on OFBIZ-13009: -- yes, seems fix, a last check before i push :) > Fix Ecommerce Groovy tests > -- > > Key: OFBIZ-13009 > URL: https://issues.apache.org/jira/browse/OFBIZ-13009 > Project: OFBiz > Issue Type: Sub-task >Reporter: Gil Portenseigne >Assignee: Gil Portenseigne >Priority: Major > > Unable to load test suite class : > org.apache.ofbiz.ecommerce.OrderNotificationTests -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (OFBIZ-13009) Fix Ecommerce Groovy tests
[ https://issues.apache.org/jira/browse/OFBIZ-13009?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gil Portenseigne updated OFBIZ-13009: - Affects Version/s: Upcoming Branch > Fix Ecommerce Groovy tests > -- > > Key: OFBIZ-13009 > URL: https://issues.apache.org/jira/browse/OFBIZ-13009 > Project: OFBiz > Issue Type: Sub-task >Affects Versions: Upcoming Branch >Reporter: Gil Portenseigne >Assignee: Gil Portenseigne >Priority: Major > > Unable to load test suite class : > org.apache.ofbiz.ecommerce.OrderNotificationTests -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OFBIZ-13003) Fix Assetmain Groovy tests
[ https://issues.apache.org/jira/browse/OFBIZ-13003?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17836247#comment-17836247 ] Gil Portenseigne commented on OFBIZ-13003: -- [https://ci2.apache.org/#/builders/46/builds/805] OK, closing. > Fix Assetmain Groovy tests > -- > > Key: OFBIZ-13003 > URL: https://issues.apache.org/jira/browse/OFBIZ-13003 > Project: OFBiz > Issue Type: Sub-task > Components: assetmaint >Affects Versions: Upcoming Branch >Reporter: Jacques Le Roux >Priority: Major > Fix For: Upcoming Branch > > > Unable to load test suite class : > org.apache.ofbiz.assetmaint.test.FixedAssetMaintTests -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (OFBIZ-13009) Fix Ecommerce Groovy tests
Gil Portenseigne created OFBIZ-13009: Summary: Fix Ecommerce Groovy tests Key: OFBIZ-13009 URL: https://issues.apache.org/jira/browse/OFBIZ-13009 Project: OFBiz Issue Type: Sub-task Reporter: Gil Portenseigne Assignee: Gil Portenseigne |E| Unable to load test suite class │aucune modification n'a été ajoutée à la validation (utilisez "git add" ou "git commit -a") : org.apache.ofbiz.ecommerce.OrderNotificationTests -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (OFBIZ-13009) Fix Ecommerce Groovy tests
[ https://issues.apache.org/jira/browse/OFBIZ-13009?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gil Portenseigne updated OFBIZ-13009: - Description: Unable to load test suite class : org.apache.ofbiz.ecommerce.OrderNotificationTests (was: |E| Unable to load test suite class │aucune modification n'a été ajoutée à la validation (utilisez "git add" ou "git commit -a") : org.apache.ofbiz.ecommerce.OrderNotificationTests) > Fix Ecommerce Groovy tests > -- > > Key: OFBIZ-13009 > URL: https://issues.apache.org/jira/browse/OFBIZ-13009 > Project: OFBiz > Issue Type: Sub-task >Reporter: Gil Portenseigne >Assignee: Gil Portenseigne >Priority: Major > > Unable to load test suite class : > org.apache.ofbiz.ecommerce.OrderNotificationTests -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OFBIZ-13006) Reject wrong URLs
[ https://issues.apache.org/jira/browse/OFBIZ-13006?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17836193#comment-17836193 ] Gil Portenseigne commented on OFBIZ-13006: -- Hello [~jleroux] , there might be an issue with the trunk commit, see [https://ci2.apache.org/#/builders/49/builds/866/steps/2/logs/stdio] > Reject wrong URLs > - > > Key: OFBIZ-13006 > URL: https://issues.apache.org/jira/browse/OFBIZ-13006 > Project: OFBiz > Issue Type: Bug > Components: framework/webapp >Affects Versions: 18.12.13 >Reporter: Jacques Le Roux >Assignee: Jacques Le Roux >Priority: Minor > Fix For: 18.12.13 > > > Some URLs need to be rejected before they create problems -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OFBIZ-13003) Fix Assetmain Groovy tests
[ https://issues.apache.org/jira/browse/OFBIZ-13003?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17836189#comment-17836189 ] Gil Portenseigne commented on OFBIZ-13003: -- Strange, the test was a success on my local, but not for buildbot... Let me check > Fix Assetmain Groovy tests > -- > > Key: OFBIZ-13003 > URL: https://issues.apache.org/jira/browse/OFBIZ-13003 > Project: OFBiz > Issue Type: Sub-task > Components: assetmaint >Affects Versions: Upcoming Branch >Reporter: Jacques Le Roux >Priority: Major > Fix For: Upcoming Branch > > > Unable to load test suite class : > org.apache.ofbiz.assetmaint.test.FixedAssetMaintTests -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OFBIZ-13003) Fix Assetmain Groovy tests
[ https://issues.apache.org/jira/browse/OFBIZ-13003?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17835799#comment-17835799 ] Gil Portenseigne commented on OFBIZ-13003: -- I am not sure about if others test already comply with F.I.R.S.T. principle, but i think we should make those test independent from each others. I'll will create a data for the failing test. > Fix Assetmain Groovy tests > -- > > Key: OFBIZ-13003 > URL: https://issues.apache.org/jira/browse/OFBIZ-13003 > Project: OFBiz > Issue Type: Sub-task > Components: assetmaint >Affects Versions: Upcoming Branch >Reporter: Jacques Le Roux >Priority: Major > Fix For: Upcoming Branch > > > Unable to load test suite class : > org.apache.ofbiz.assetmaint.test.FixedAssetMaintTests -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OFBIZ-11067) Migrate integration tests to unit tests when possible
[
https://issues.apache.org/jira/browse/OFBIZ-11067?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17835187#comment-17835187
]
Gil Portenseigne commented on OFBIZ-11067:
--
Sure, i will when i got some time :)
> Migrate integration tests to unit tests when possible
> -
>
> Key: OFBIZ-11067
> URL: https://issues.apache.org/jira/browse/OFBIZ-11067
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
>Affects Versions: Trunk, Upcoming Branch
>Reporter: Mathieu Lirzin
>Assignee: Jacques Le Roux
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments:
> OFBIZ-11067_0001-Turn-UtilPropertiesTests-into-a-unit-test-c.patch,
> OFBIZ-11067_0002-Turn-ComparableRangeTests-into-a-unit-test-.patch,
> OFBIZ-11067_0003-Turn-DateTimeTests-into-a-unit-test-class.patch,
> OFBIZ-11067_0004-Turn-GenericMapTest-into-a-unit-test-class.patch,
> OFBIZ-11067_0005-Turn-IndentingWriterTests-into-a-unit-test-.patch,
> OFBIZ-11067_0006-Turn-MiscTests-into-a-unit-test-class.patch,
> OFBIZ-11067_0007-Turn-ObjectTypeTests-into-a-unit-test-class.patch,
> OFBIZ-11067_0008-Turn-ReferenceCleanerTests-into-a-unit-test.patch,
> OFBIZ-11067_0009-Turn-TimeDurationTests-into-a-unit-test-cla.patch,
> OFBIZ-11067_0010-Turn-UtilCacheTests-into-a-unit-test-class.patch,
> OFBIZ-11067_0011-Remove-empty-UtilHttpTests-class.patch,
> OFBIZ-11067_0012-Turn-UtilIOTests-into-a-unit-test-class.patch,
> OFBIZ-11067_0013-Turn-UtilMiscTests-into-a-unit-test-class.patch,
> OFBIZ-11067_0014-Turn-AssertTests-into-a-unit-test-class.patch,
> OFBIZ-11067_0015-Turn-BaseUnitTests-into-a-unit-test-class.patch,
> OFBIZ-11067_0016-Turn-TestBooleanConverters-into-a-unit-test.patch,
> OFBIZ-11067_0017-Turn-TestJSONConverters-into-a-unit-test-cl.patch,
> OFBIZ-11067_0018-Turn-UtilObjectTests-into-a-unit-test-class.patch,
> OFBIZ-11067_0019-Merge-UtilObjectUnitTest-into-UtilObjectTes.patch,
> OFBIZ-11067_fixes_FlexibleStringExpanderTests_and_FlexibleMapAcessor_tests-1.patch,
>
> OFBIZ-11067_fixes_FlexibleStringExpanderTests_and_FlexibleMapAcessor_tests.patch,
>
> OFBIZ-11067_turns_FlexibleMapAccessorTests_and_FlexibleStringExpanderTests_into_unit_tests-1.patch,
>
> OFBIZ-11067_turns_FlexibleMapAccessorTests_and_FlexibleStringExpanderTests_into_unit_tests.patch
>
>
> In OFBiz there are both unit tests and integration tests which are
> respectively run by {{./gradlew test}} and {{./gradlew testIntegration}}.
> However some integration tests are in fact unit tests that doesn't depend on
> the entity and service engines. Those unit tests should run on the their
> appropriate task.
> To do that it is necessary to convert them to use Junit4 instead of Junit3
> which is what is done for the integration test suite.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (OFBIZ-12998) Fix Partymgr Groovy tests
[ https://issues.apache.org/jira/browse/OFBIZ-12998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17834430#comment-17834430 ] Gil Portenseigne commented on OFBIZ-12998: -- Thanks Jacques for the review, i checked in my local, but must have missed it ! Was to eager to end the mission this afternoon :) > Fix Partymgr Groovy tests > - > > Key: OFBIZ-12998 > URL: https://issues.apache.org/jira/browse/OFBIZ-12998 > Project: OFBiz > Issue Type: Sub-task > Components: party >Affects Versions: Upcoming Branch >Reporter: Gil Portenseigne >Assignee: Gil Portenseigne >Priority: Major > > This Jira intend to fix party component groovy integration tests : > 2024-04-05 14:12:56,111 |main |ModelTestSuite > |E| Unable to load test suite class : org.apache.ofbiz.party.PartyTests > 2024-04-05 14:12:56,125 |main |ModelTestSuite > |E| Unable to load test suite class : > org.apache.ofbiz.party.ContactMechWorkerTests > 2024-04-05 14:12:56,126 |main |ModelTestSuite > |E| Unable to load test suite class : > org.apache.ofbiz.party.PartyContactMechTests > 2024-04-05 14:12:56,134 |main |ModelTestSuite > |E| Unable to load test suite class : > org.apache.ofbiz.party.PartyStatusChangeTests -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OFBIZ-12985) Integration Groovy tests fail
[
https://issues.apache.org/jira/browse/OFBIZ-12985?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17834380#comment-17834380
]
Gil Portenseigne commented on OFBIZ-12985:
--
i'll stop for now it remains :
org.apache.ofbiz.base.util.UtilObjectTests >>> seems to not be integration
test, but unit. So should remove in testdef
Havent check the other yet.
org.apache.ofbiz.marketing.MarketingTests
org.apache.ofbiz.assetmaint.test.FixedAssetMaintTests
org.apache.ofbiz.ecommerce.OrderNotificationTests
> Integration Groovy tests fail
> -
>
> Key: OFBIZ-12985
> URL: https://issues.apache.org/jira/browse/OFBIZ-12985
> Project: OFBiz
> Issue Type: Bug
> Components: ALL APPLICATIONS, ALL PLUGINS
>Affects Versions: Upcoming Branch
>Reporter: Jacques Le Roux
>Priority: Blocker
> Fix For: Upcoming Branch
>
>
> Groovy testIntegration, tests suites and tests cases no longer work
> For my own help here is a simple case to test
> bq. "ofbiz --test component=accounting --test suitename=invoicetests --test
> testcase=invoice-per-shipment-tests"
> It seems testIntegrations work but when you look at the log you find a lot of
> (46, barely same than number of files: 44, did not digg more) "Unable to load
> test suite class" errors like this 1st one:
> {noformat}
> |ModelTestSuite|E|Unable to load test suite class :
> org.apache.ofbiz.party.PartyTests|
> {noformat}
> You can find that in last ofbizTrunkFrameworkPlugins BB build:
> [https://ci2.apache.org/#/builders/46/builds/777]
> The result seems successful. It's a misleading testIntegration result (not
> sure what does that) and an already old one. TestIntegrations still work in
> 18.12 and the issue is somehow related to OFBIZ-12813.
> It's a really confusing situation. Several issues prevent Groovy tests to
> work.
> The reason is due to wrong Groovy tests package names and locations due to
> OFBIZ-12813
> If we refer to our way of naming packages they are correctly referenced in
> testdef (eg org.apache.ofbiz.accounting vs org.apache.accounting.accounting)
> So it's only a simple packages names and locations changes.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Closed] (OFBIZ-12999) Fix Product Groovy tests
[ https://issues.apache.org/jira/browse/OFBIZ-12999?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gil Portenseigne closed OFBIZ-12999. Resolution: Fixed [https://ci2.apache.org/#/builders/49/builds/851] OK ! > Fix Product Groovy tests > > > Key: OFBIZ-12999 > URL: https://issues.apache.org/jira/browse/OFBIZ-12999 > Project: OFBiz > Issue Type: Sub-task > Components: product >Affects Versions: Upcoming Branch >Reporter: Gil Portenseigne >Assignee: Gil Portenseigne >Priority: Major > > This Jira intend to fix product component groovy integration tests : > 2024-04-05 10:33:05,904 |main |ModelTestSuite > |E| Unable to load test suite class : > org.apache.ofbiz.product.ProductPriceTests > 2024-04-05 10:33:05,906 |main |ModelTestSuite > |E| Unable to load test suite class : org.apache.ofbiz.product.CategoryTests > 2024-04-05 10:33:05,921 |main |ModelTestSuite > |E| Unable to load test suite class : org.apache.ofbiz.product.InventoryTests > 2024-04-05 10:33:05,923 |main |ModelTestSuite > |E| Unable to load test suite class : org.apache.ofbiz.product.ShipmentTests > 2024-04-05 10:33:05,939 |main |ModelTestSuite > |E| Unable to load test suite class : org.apache.ofbiz.product.CostTests > 2024-04-05 10:33:05,960 |main |ModelTestSuite > |E| Unable to load test suite class : org.apache.ofbiz.product.ProductTagTest > 2024-04-05 10:33:05,973 |main |ModelTestSuite > |E| Unable to load test suite class : org.apache.ofbiz.product.ProductTest > 2024-04-05 10:33:05,975 |main |ModelTestSuite > |E| Unable to load test suite class : org.apache.ofbiz.product.ProductTests > 2024-04-05 10:33:05,976 |main |ModelTestSuite > |E| Unable to load test suite class : > org.apache.ofbiz.product.ProductFeatureTypeTests > 2024-04-05 10:33:05,991 |main |ModelTestSuite > |E| Unable to load test suite class : > org.apache.ofbiz.product.ProductPromoCondTests > 2024-04-05 10:33:05,995 |main |ModelTestSuite > |E| Unable to load test suite class : > org.apache.ofbiz.product.ProductPromoActionTests > 2024-04-05 10:33:06,013 |main |ModelTestSuite > |E| Unable to load test suite class : > org.apache.ofbiz.product.ProductConfigTests -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (OFBIZ-13000) Fix Order Groovy tests
Gil Portenseigne created OFBIZ-13000: Summary: Fix Order Groovy tests Key: OFBIZ-13000 URL: https://issues.apache.org/jira/browse/OFBIZ-13000 Project: OFBiz Issue Type: Sub-task Components: order Affects Versions: Upcoming Branch Reporter: Gil Portenseigne Assignee: Gil Portenseigne This Jira intend to fix order component groovy integration tests : 2024-04-05 10:33:06,331 |main |ModelTestSuite |E| Unable to load test suite class : org.apache.ofbiz.order.OrderTests 2024-04-05 10:33:06,332 |main |ModelTestSuite |E| Unable to load test suite class : org.apache.ofbiz.order.OrderReturnTests 2024-04-05 10:33:06,334 |main |ModelTestSuite |E| Unable to load test suite class : org.apache.ofbiz.order.OrderRequirementTests 2024-04-05 10:33:06,366 |main |ModelTestSuite |E| Unable to load test suite class : org.apache.ofbiz.order.TestCustRequestPermissionCheck 2024-04-05 10:33:06,382 |main |ModelTestSuite |E| Unable to load test suite class : org.apache.ofbiz.order.QuoteTests 2024-04-05 10:33:06,400 |main |ModelTestSuite |E| Unable to load test suite class : org.apache.ofbiz.order.ShoppingListTests -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Closed] (OFBIZ-12998) Fix Partymgr Groovy tests
[ https://issues.apache.org/jira/browse/OFBIZ-12998?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gil Portenseigne closed OFBIZ-12998. Resolution: Fixed [https://ci2.apache.org/#/builders/46/builds/785] OK > Fix Partymgr Groovy tests > - > > Key: OFBIZ-12998 > URL: https://issues.apache.org/jira/browse/OFBIZ-12998 > Project: OFBiz > Issue Type: Sub-task > Components: party >Affects Versions: Upcoming Branch >Reporter: Gil Portenseigne >Assignee: Gil Portenseigne >Priority: Major > > This Jira intend to fix party component groovy integration tests : > 2024-04-05 14:12:56,111 |main |ModelTestSuite > |E| Unable to load test suite class : org.apache.ofbiz.party.PartyTests > 2024-04-05 14:12:56,125 |main |ModelTestSuite > |E| Unable to load test suite class : > org.apache.ofbiz.party.ContactMechWorkerTests > 2024-04-05 14:12:56,126 |main |ModelTestSuite > |E| Unable to load test suite class : > org.apache.ofbiz.party.PartyContactMechTests > 2024-04-05 14:12:56,134 |main |ModelTestSuite > |E| Unable to load test suite class : > org.apache.ofbiz.party.PartyStatusChangeTests -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (OFBIZ-12999) Fix Product Groovy tests
Gil Portenseigne created OFBIZ-12999: Summary: Fix Product Groovy tests Key: OFBIZ-12999 URL: https://issues.apache.org/jira/browse/OFBIZ-12999 Project: OFBiz Issue Type: Sub-task Components: product Affects Versions: Upcoming Branch Reporter: Gil Portenseigne Assignee: Gil Portenseigne This Jira intend to fix product component groovy integration tests : 2024-04-05 10:33:05,904 |main |ModelTestSuite |E| Unable to load test suite class : org.apache.ofbiz.product.ProductPriceTests 2024-04-05 10:33:05,906 |main |ModelTestSuite |E| Unable to load test suite class : org.apache.ofbiz.product.CategoryTests 2024-04-05 10:33:05,921 |main |ModelTestSuite |E| Unable to load test suite class : org.apache.ofbiz.product.InventoryTests 2024-04-05 10:33:05,923 |main |ModelTestSuite |E| Unable to load test suite class : org.apache.ofbiz.product.ShipmentTests 2024-04-05 10:33:05,939 |main |ModelTestSuite |E| Unable to load test suite class : org.apache.ofbiz.product.CostTests 2024-04-05 10:33:05,960 |main |ModelTestSuite |E| Unable to load test suite class : org.apache.ofbiz.product.ProductTagTest 2024-04-05 10:33:05,973 |main |ModelTestSuite |E| Unable to load test suite class : org.apache.ofbiz.product.ProductTest 2024-04-05 10:33:05,975 |main |ModelTestSuite |E| Unable to load test suite class : org.apache.ofbiz.product.ProductTests 2024-04-05 10:33:05,976 |main |ModelTestSuite |E| Unable to load test suite class : org.apache.ofbiz.product.ProductFeatureTypeTests 2024-04-05 10:33:05,991 |main |ModelTestSuite |E| Unable to load test suite class : org.apache.ofbiz.product.ProductPromoCondTests 2024-04-05 10:33:05,995 |main |ModelTestSuite |E| Unable to load test suite class : org.apache.ofbiz.product.ProductPromoActionTests 2024-04-05 10:33:06,013 |main |ModelTestSuite |E| Unable to load test suite class : org.apache.ofbiz.product.ProductConfigTests -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OFBIZ-12985) Integration Groovy tests fail
[
https://issues.apache.org/jira/browse/OFBIZ-12985?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17834313#comment-17834313
]
Gil Portenseigne commented on OFBIZ-12985:
--
One thing is bothering me, we are putting integration test code into
src/main/groovy, with a package name that do not contain "test" keyword. Only
the file name indicates that is is test.
I think we should if possible add test in package like it is done for some
others like : InventoryItemTransferTest.
I will test it with party tests, if ok, will continue the components like that.
> Integration Groovy tests fail
> -
>
> Key: OFBIZ-12985
> URL: https://issues.apache.org/jira/browse/OFBIZ-12985
> Project: OFBiz
> Issue Type: Bug
> Components: ALL APPLICATIONS, ALL PLUGINS
>Affects Versions: Upcoming Branch
>Reporter: Jacques Le Roux
>Priority: Blocker
> Fix For: Upcoming Branch
>
>
> Groovy testIntegration, tests suites and tests cases no longer work
> For my own help here is a simple case to test
> bq. "ofbiz --test component=accounting --test suitename=invoicetests --test
> testcase=invoice-per-shipment-tests"
> It seems testIntegrations work but when you look at the log you find a lot of
> (46, barely same than number of files: 44, did not digg more) "Unable to load
> test suite class" errors like this 1st one:
> {noformat}
> |ModelTestSuite|E|Unable to load test suite class :
> org.apache.ofbiz.party.PartyTests|
> {noformat}
> You can find that in last ofbizTrunkFrameworkPlugins BB build:
> [https://ci2.apache.org/#/builders/46/builds/777]
> The result seems successful. It's a misleading testIntegration result (not
> sure what does that) and an already old one. TestIntegrations still work in
> 18.12 and the issue is somehow related to OFBIZ-12813.
> It's a really confusing situation. Several issues prevent Groovy tests to
> work.
> The reason is due to wrong Groovy tests package names and locations due to
> OFBIZ-12813
> If we refer to our way of naming packages they are correctly referenced in
> testdef (eg org.apache.ofbiz.accounting vs org.apache.accounting.accounting)
> So it's only a simple packages names and locations changes.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Assigned] (OFBIZ-12998) Fix Partymgr Groovy tests
[ https://issues.apache.org/jira/browse/OFBIZ-12998?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gil Portenseigne reassigned OFBIZ-12998: Assignee: Gil Portenseigne > Fix Partymgr Groovy tests > - > > Key: OFBIZ-12998 > URL: https://issues.apache.org/jira/browse/OFBIZ-12998 > Project: OFBiz > Issue Type: Sub-task > Components: party >Affects Versions: Upcoming Branch >Reporter: Gil Portenseigne >Assignee: Gil Portenseigne >Priority: Major > > This Jira intend to fix party component groovy integration tests : > 2024-04-05 14:12:56,111 |main |ModelTestSuite > |E| Unable to load test suite class : org.apache.ofbiz.party.PartyTests > 2024-04-05 14:12:56,125 |main |ModelTestSuite > |E| Unable to load test suite class : > org.apache.ofbiz.party.ContactMechWorkerTests > 2024-04-05 14:12:56,126 |main |ModelTestSuite > |E| Unable to load test suite class : > org.apache.ofbiz.party.PartyContactMechTests > 2024-04-05 14:12:56,134 |main |ModelTestSuite > |E| Unable to load test suite class : > org.apache.ofbiz.party.PartyStatusChangeTests -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (OFBIZ-12998) Fix Partymgr Groovy tests
[ https://issues.apache.org/jira/browse/OFBIZ-12998?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gil Portenseigne updated OFBIZ-12998: - Priority: Major (was: Blocker) > Fix Partymgr Groovy tests > - > > Key: OFBIZ-12998 > URL: https://issues.apache.org/jira/browse/OFBIZ-12998 > Project: OFBiz > Issue Type: Sub-task > Components: party >Affects Versions: Upcoming Branch >Reporter: Gil Portenseigne >Priority: Major > > This Jira intend to fix party component groovy integration tests : > 2024-04-05 14:12:56,111 |main |ModelTestSuite > |E| Unable to load test suite class : org.apache.ofbiz.party.PartyTests > 2024-04-05 14:12:56,125 |main |ModelTestSuite > |E| Unable to load test suite class : > org.apache.ofbiz.party.ContactMechWorkerTests > 2024-04-05 14:12:56,126 |main |ModelTestSuite > |E| Unable to load test suite class : > org.apache.ofbiz.party.PartyContactMechTests > 2024-04-05 14:12:56,134 |main |ModelTestSuite > |E| Unable to load test suite class : > org.apache.ofbiz.party.PartyStatusChangeTests -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (OFBIZ-12998) Fix Partymgr Groovy tests
Gil Portenseigne created OFBIZ-12998: Summary: Fix Partymgr Groovy tests Key: OFBIZ-12998 URL: https://issues.apache.org/jira/browse/OFBIZ-12998 Project: OFBiz Issue Type: Sub-task Components: party Affects Versions: Upcoming Branch Reporter: Gil Portenseigne This Jira intend to fix party component groovy integration tests : 2024-04-05 14:12:56,111 |main |ModelTestSuite |E| Unable to load test suite class : org.apache.ofbiz.party.PartyTests 2024-04-05 14:12:56,125 |main |ModelTestSuite |E| Unable to load test suite class : org.apache.ofbiz.party.ContactMechWorkerTests 2024-04-05 14:12:56,126 |main |ModelTestSuite |E| Unable to load test suite class : org.apache.ofbiz.party.PartyContactMechTests 2024-04-05 14:12:56,134 |main |ModelTestSuite |E| Unable to load test suite class : org.apache.ofbiz.party.PartyStatusChangeTests -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OFBIZ-12985) Integration Groovy tests fail
[
https://issues.apache.org/jira/browse/OFBIZ-12985?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17834249#comment-17834249
]
Gil Portenseigne commented on OFBIZ-12985:
--
ow, sorry, i look that this afternoon
> Integration Groovy tests fail
> -
>
> Key: OFBIZ-12985
> URL: https://issues.apache.org/jira/browse/OFBIZ-12985
> Project: OFBiz
> Issue Type: Bug
> Components: ALL APPLICATIONS, ALL PLUGINS
>Affects Versions: Upcoming Branch
>Reporter: Jacques Le Roux
>Priority: Blocker
> Fix For: Upcoming Branch
>
>
> Groovy testIntegration, tests suites and tests cases no longer work
> For my own help here is a simple case to test
> bq. "ofbiz --test component=accounting --test suitename=invoicetests --test
> testcase=invoice-per-shipment-tests"
> It seems testIntegrations work but when you look at the log you find a lot of
> (46, barely same than number of files: 44, did not digg more) "Unable to load
> test suite class" errors like this 1st one:
> {noformat}
> |ModelTestSuite|E|Unable to load test suite class :
> org.apache.ofbiz.party.PartyTests|
> {noformat}
> You can find that in last ofbizTrunkFrameworkPlugins BB build:
> [https://ci2.apache.org/#/builders/46/builds/777]
> The result seems successful. It's a misleading testIntegration result (not
> sure what does that) and an already old one. TestIntegrations still work in
> 18.12 and the issue is somehow related to OFBIZ-12813.
> It's a really confusing situation. Several issues prevent Groovy tests to
> work.
> The reason is due to wrong Groovy tests package names and locations due to
> OFBIZ-12813
> If we refer to our way of naming packages they are correctly referenced in
> testdef (eg org.apache.ofbiz.accounting vs org.apache.accounting.accounting)
> So it's only a simple packages names and locations changes.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Closed] (OFBIZ-12985) Integration Groovy tests fail
[
https://issues.apache.org/jira/browse/OFBIZ-12985?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gil Portenseigne closed OFBIZ-12985.
Resolution: Fixed
Closing since last buildbot is ok. Thanks Jacques !
> Integration Groovy tests fail
> -
>
> Key: OFBIZ-12985
> URL: https://issues.apache.org/jira/browse/OFBIZ-12985
> Project: OFBiz
> Issue Type: Bug
> Components: ALL APPLICATIONS, ALL PLUGINS
>Affects Versions: Upcoming Branch
>Reporter: Jacques Le Roux
>Priority: Blocker
> Fix For: Upcoming Branch
>
>
> Groovy testIntegration, tests suites and tests cases no longer work
> For my own help here is a simple case to test
> bq. "ofbiz --test component=accounting --test suitename=invoicetests --test
> testcase=invoice-per-shipment-tests"
> It seems testIntegrations work but when you look at the log you find a lot of
> (46, barely same than number of files: 44, did not digg more) "Unable to load
> test suite class" errors like this 1st one:
> {noformat}
> |ModelTestSuite|E|Unable to load test suite class :
> org.apache.ofbiz.party.PartyTests|
> {noformat}
> You can find that in last ofbizTrunkFrameworkPlugins BB build:
> [https://ci2.apache.org/#/builders/46/builds/777]
> The result seems successful. It's a misleading testIntegration result (not
> sure what does that) and an already old one. TestIntegrations still work in
> 18.12 and the issue is somehow related to OFBIZ-12813.
> It's a really confusing situation. Several issues prevent Groovy tests to
> work.
> The reason is due to wrong Groovy tests package names and locations due to
> OFBIZ-12813
> If we refer to our way of naming packages they are correctly referenced in
> testdef (eg org.apache.ofbiz.accounting vs org.apache.accounting.accounting)
> So it's only a simple packages names and locations changes.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (OFBIZ-12995) Fix Accounting Groovy tests
[ https://issues.apache.org/jira/browse/OFBIZ-12995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17834219#comment-17834219 ] Gil Portenseigne commented on OFBIZ-12995: -- Hi Jacques, do you need some help ? I'll have a look, if that is ok for you :) > Fix Accounting Groovy tests > --- > > Key: OFBIZ-12995 > URL: https://issues.apache.org/jira/browse/OFBIZ-12995 > Project: OFBiz > Issue Type: Sub-task > Components: accounting >Affects Versions: Upcoming Branch >Reporter: Jacques Le Roux >Assignee: Jacques Le Roux >Priority: Major > Fix For: Upcoming Branch > > > As mentionned in OFBIZ-12985 after OFBIZ-12813 the Groovy tests fail. > There are severtal aspects, at least for now: > # structures (folders used and references to them); > # compilation (since OFBIZ-11165 Groovy tests must be compiled); > # migration from XML to Groovy specific errors > About point 1 and 2, it turns out to be that the folders used don't allow > compilation. > So, unlike unit tests ModelServiceTest.groovy, TestServices.groovy and > FileUtilTests.groovy put in sourcesets/test, integration tests must be in > sourcesets/main folders. Their references should be changed too. > This is a subtask for the accounting component. The only changes are to move > Groovy tests to main and to accordingly change the references in > applications/accounting/testdef/ files. > This fixes the inability to find the files where they are expected. Remains > few issues related to the point 3. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OFBIZ-12963) Fix problems with Eclipse about multi module dependencies.
[ https://issues.apache.org/jira/browse/OFBIZ-12963?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17830919#comment-17830919 ] Gil Portenseigne commented on OFBIZ-12963: -- Thanks Jacques, idea licence trolled me, so i decided to give this old fellow a try :), and indeed it seems better than in my memory. About the navigator leila gave me this link : [https://stackoverflow.com/questions/60962386/why-is-eclipse-removing-the-navigator-view/65941171#65941171] to get a 'navigator like' behavior in Project Explorer. > Fix problems with Eclipse about multi module dependencies. > -- > > Key: OFBIZ-12963 > URL: https://issues.apache.org/jira/browse/OFBIZ-12963 > Project: OFBiz > Issue Type: Bug >Affects Versions: Upcoming Branch >Reporter: Gil Portenseigne >Priority: Minor > Attachments: OFBIZ-12963.patch > > > On my journey to come back using Eclipse, i got some issues when loading > trunk : > The package xxx is accessible from more than one module. > This kind of issue appear when a project bring a dependency that is already > in another module in OFBiz > The patch avoid loading 'pull-parser' and 'xpp3' dependencies that are > already present in jdk17. > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (OFBIZ-12963) Fix problems with Eclipse about multi module dependencies.
[ https://issues.apache.org/jira/browse/OFBIZ-12963?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gil Portenseigne updated OFBIZ-12963: - Attachment: OFBIZ-12963.patch > Fix problems with Eclipse about multi module dependencies. > -- > > Key: OFBIZ-12963 > URL: https://issues.apache.org/jira/browse/OFBIZ-12963 > Project: OFBiz > Issue Type: Bug >Affects Versions: Upcoming Branch >Reporter: Gil Portenseigne >Priority: Minor > Attachments: OFBIZ-12963.patch > > > On my journey to come back using Eclipse, i got some issues when loading > trunk : > The package xxx is accessible from more than one module. > This kind of issue appear when a project bring a dependency that is already > in another module in OFBiz > The patch avoid loading 'pull-parser' and 'xpp3' dependencies that are > already present in jdk17. > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (OFBIZ-12963) Fix problems with Eclipse about multi module dependencies.
Gil Portenseigne created OFBIZ-12963: Summary: Fix problems with Eclipse about multi module dependencies. Key: OFBIZ-12963 URL: https://issues.apache.org/jira/browse/OFBIZ-12963 Project: OFBiz Issue Type: Bug Affects Versions: Upcoming Branch Reporter: Gil Portenseigne On my journey to come back using Eclipse, i got some issues when loading trunk : The package xxx is accessible from more than one module. This kind of issue appear when a project bring a dependency that is already in another module in OFBiz The patch avoid loading 'pull-parser' and 'xpp3' dependencies that are already present in jdk17. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OFBIZ-12940) Modal title not supported on hyperlink in form fields
[ https://issues.apache.org/jira/browse/OFBIZ-12940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17828921#comment-17828921 ] Gil Portenseigne commented on OFBIZ-12940: -- Hi Jacques, i got interrupted while doing it, i wanted to check for rel18 but not sure we'll do release :). So yes i close. > Modal title not supported on hyperlink in form fields > - > > Key: OFBIZ-12940 > URL: https://issues.apache.org/jira/browse/OFBIZ-12940 > Project: OFBiz > Issue Type: Bug >Affects Versions: 22.01.01, 18.12.12, 18.12.13 >Reporter: Florian Motteau >Assignee: Gil Portenseigne >Priority: Major > Fix For: Upcoming Branch > > Attachments: image-2024-03-14-08-58-13-835.png > > > Hyperlinks elements can trigger the opening of a modal window > (link-type="layered-modal"). OFBiz uses jQuery UI Dialog to achieve this, and > parameters for this library are passed through a set of data-dialog-* ** > attributes on the "a" tag, in "HtmlFormMacroLibrary::makeHyperlinkString" > Freemarker macro. Then in OfbizUtil.js, links that should open modals are > processed : data-dialog-* are used to configure jQueryUI Dialog module. > > In OfbizUtil.js, data-dialog-text attribute is used to set the title of the > modal (text in the colored top bar). The value of this attribute is set using > the "text" parameter in "makeHyperlinkString" macro. However, this macro > does not declare a "text" parameter in its signature, and > HtmlMacroFormRenderer::makeHyperlinkString does not support it. > As a result, we cannot set the modal title when using a `hyperlink` tag > with a `text` attribute in a form (although the code indicates otherwise). > !image-2024-03-14-08-58-13-835.png! -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Closed] (OFBIZ-12940) Modal title not supported on hyperlink in form fields
[ https://issues.apache.org/jira/browse/OFBIZ-12940?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gil Portenseigne closed OFBIZ-12940. Resolution: Fixed > Modal title not supported on hyperlink in form fields > - > > Key: OFBIZ-12940 > URL: https://issues.apache.org/jira/browse/OFBIZ-12940 > Project: OFBiz > Issue Type: Bug >Affects Versions: 22.01.01, 18.12.12, 18.12.13 >Reporter: Florian Motteau >Assignee: Gil Portenseigne >Priority: Major > Fix For: Upcoming Branch > > Attachments: image-2024-03-14-08-58-13-835.png > > > Hyperlinks elements can trigger the opening of a modal window > (link-type="layered-modal"). OFBiz uses jQuery UI Dialog to achieve this, and > parameters for this library are passed through a set of data-dialog-* ** > attributes on the "a" tag, in "HtmlFormMacroLibrary::makeHyperlinkString" > Freemarker macro. Then in OfbizUtil.js, links that should open modals are > processed : data-dialog-* are used to configure jQueryUI Dialog module. > > In OfbizUtil.js, data-dialog-text attribute is used to set the title of the > modal (text in the colored top bar). The value of this attribute is set using > the "text" parameter in "makeHyperlinkString" macro. However, this macro > does not declare a "text" parameter in its signature, and > HtmlMacroFormRenderer::makeHyperlinkString does not support it. > As a result, we cannot set the modal title when using a `hyperlink` tag > with a `text` attribute in a form (although the code indicates otherwise). > !image-2024-03-14-08-58-13-835.png! -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (OFBIZ-12940) Modal title not supported on hyperlink in form fields
[ https://issues.apache.org/jira/browse/OFBIZ-12940?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gil Portenseigne updated OFBIZ-12940: - Fix Version/s: Upcoming Branch > Modal title not supported on hyperlink in form fields > - > > Key: OFBIZ-12940 > URL: https://issues.apache.org/jira/browse/OFBIZ-12940 > Project: OFBiz > Issue Type: Bug >Affects Versions: 22.01.01, 18.12.12, 18.12.13 >Reporter: Florian Motteau >Assignee: Gil Portenseigne >Priority: Major > Fix For: Upcoming Branch > > Attachments: image-2024-03-14-08-58-13-835.png > > > Hyperlinks elements can trigger the opening of a modal window > (link-type="layered-modal"). OFBiz uses jQuery UI Dialog to achieve this, and > parameters for this library are passed through a set of data-dialog-* ** > attributes on the "a" tag, in "HtmlFormMacroLibrary::makeHyperlinkString" > Freemarker macro. Then in OfbizUtil.js, links that should open modals are > processed : data-dialog-* are used to configure jQueryUI Dialog module. > > In OfbizUtil.js, data-dialog-text attribute is used to set the title of the > modal (text in the colored top bar). The value of this attribute is set using > the "text" parameter in "makeHyperlinkString" macro. However, this macro > does not declare a "text" parameter in its signature, and > HtmlMacroFormRenderer::makeHyperlinkString does not support it. > As a result, we cannot set the modal title when using a `hyperlink` tag > with a `text` attribute in a form (although the code indicates otherwise). > !image-2024-03-14-08-58-13-835.png! -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Assigned] (OFBIZ-12940) Modal title not supported on hyperlink in form fields
[ https://issues.apache.org/jira/browse/OFBIZ-12940?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gil Portenseigne reassigned OFBIZ-12940: Assignee: Gil Portenseigne > Modal title not supported on hyperlink in form fields > - > > Key: OFBIZ-12940 > URL: https://issues.apache.org/jira/browse/OFBIZ-12940 > Project: OFBiz > Issue Type: Bug >Affects Versions: 22.01.01, 18.12.12, 18.12.13 >Reporter: Florian Motteau >Assignee: Gil Portenseigne >Priority: Major > Attachments: image-2024-03-14-08-58-13-835.png > > > Hyperlinks elements can trigger the opening of a modal window > (link-type="layered-modal"). OFBiz uses jQuery UI Dialog to achieve this, and > parameters for this library are passed through a set of data-dialog-* ** > attributes on the "a" tag, in "HtmlFormMacroLibrary::makeHyperlinkString" > Freemarker macro. Then in OfbizUtil.js, links that should open modals are > processed : data-dialog-* are used to configure jQueryUI Dialog module. > > In OfbizUtil.js, data-dialog-text attribute is used to set the title of the > modal (text in the colored top bar). The value of this attribute is set using > the "text" parameter in "makeHyperlinkString" macro. However, this macro > does not declare a "text" parameter in its signature, and > HtmlMacroFormRenderer::makeHyperlinkString does not support it. > As a result, we cannot set the modal title when using a `hyperlink` tag > with a `text` attribute in a form (although the code indicates otherwise). > !image-2024-03-14-08-58-13-835.png! -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OFBIZ-12726) Running integration tests under Gradle 7.6 and JDK 17 fails
[ https://issues.apache.org/jira/browse/OFBIZ-12726?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17803598#comment-17803598 ] Gil Portenseigne commented on OFBIZ-12726: -- Thanks and nice catch, I agree we can close with creating a ticket to not forget the issue with xstream. > Running integration tests under Gradle 7.6 and JDK 17 fails > --- > > Key: OFBIZ-12726 > URL: https://issues.apache.org/jira/browse/OFBIZ-12726 > Project: OFBiz > Issue Type: Sub-task > Components: ALL COMPONENTS >Affects Versions: 22.01.01 >Reporter: Jacques Le Roux >Assignee: Jacques Le Roux >Priority: Blocker > Attachments: image-2023-12-05-16-52-38-822.png, > image-2023-12-12-18-10-16-016.png, image-2024-01-04-18-27-42-512.png, > image-2024-01-04-18-28-27-910.png > > > Following our discussion at > https://lists.apache.org/thread/kr4v21lxx493byzgpdrzfbz3whhbm82m I ran the > integration tests and found that we currently have 322 errors and 190 > failures :/ > It's a blocker for releasing... -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OFBIZ-12726) Running integration tests under Gradle 7.6 and JDK 17 fails
[
https://issues.apache.org/jira/browse/OFBIZ-12726?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17795857#comment-17795857
]
Gil Portenseigne commented on OFBIZ-12726:
--
Hello Eugen, Jacques,
I just join the effort, removing
{{{}'--add-opens=java.base/java.util=ALL-UNNAMED'{}}}, i also got the errors.
But using :
{code:java}
./gradlew "ofbiz --test component=order "
./gradlew "ofbiz --test component=minilang " {code}
Make the failing tests pass... there seems to have an dependency between the
tests, with one error somewhere in test or between. I will continue to
investigate on Friday.
For accounting :
!image-2023-12-12-18-10-16-016.png!
> Running integration tests under Gradle 7.6 and JDK 17 fails
> ---
>
> Key: OFBIZ-12726
> URL: https://issues.apache.org/jira/browse/OFBIZ-12726
> Project: OFBiz
> Issue Type: Sub-task
> Components: ALL COMPONENTS
>Affects Versions: 22.01.01
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Blocker
> Attachments: image-2023-12-05-16-52-38-822.png,
> image-2023-12-12-18-10-16-016.png
>
>
> Following our discussion at
> https://lists.apache.org/thread/kr4v21lxx493byzgpdrzfbz3whhbm82m I ran the
> integration tests and found that we currently have 322 errors and 190
> failures :/
> It's a blocker for releasing...
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (OFBIZ-12726) Running integration tests under Gradle 7.6 and JDK 17 fails
[ https://issues.apache.org/jira/browse/OFBIZ-12726?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gil Portenseigne updated OFBIZ-12726: - Attachment: image-2023-12-12-18-10-16-016.png > Running integration tests under Gradle 7.6 and JDK 17 fails > --- > > Key: OFBIZ-12726 > URL: https://issues.apache.org/jira/browse/OFBIZ-12726 > Project: OFBiz > Issue Type: Sub-task > Components: ALL COMPONENTS >Affects Versions: 22.01.01 >Reporter: Jacques Le Roux >Assignee: Jacques Le Roux >Priority: Blocker > Attachments: image-2023-12-05-16-52-38-822.png, > image-2023-12-12-18-10-16-016.png > > > Following our discussion at > https://lists.apache.org/thread/kr4v21lxx493byzgpdrzfbz3whhbm82m I ran the > integration tests and found that we currently have 322 errors and 190 > failures :/ > It's a blocker for releasing... -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OFBIZ-10213) Update build.gradle to the latest dependencies
[
https://issues.apache.org/jira/browse/OFBIZ-10213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17755986#comment-17755986
]
Gil Portenseigne commented on OFBIZ-10213:
--
Hello [~jleroux] , i just made some manual updates, then discovered this jira.
I will start to generate a new patch to update dependencies.
> Update build.gradle to the latest dependencies
> --
>
> Key: OFBIZ-10213
> URL: https://issues.apache.org/jira/browse/OFBIZ-10213
> Project: OFBiz
> Issue Type: Task
> Components: Gradle
>Affects Versions: Trunk, Upcoming Branch
>Reporter: Jacques Le Roux
>Priority: Trivial
> Attachments: OFBIZ-10213.patch, OFBIZ-10213.patch, OFBIZ-10213.patch
>
>
> h2. This is an umbrella task for its action subtasks, please do not close,
> thanks.
> We want to check from time to time if we need to update the dependencies.
> It's easily done with the [gradle-versions-plugin
> |https://github.com/ben-manes/gradle-versions-plugin] which analyzes the
> dependencies and checks if there are newer versions available.
> Running the check with
> {code:java}
> gradlew -PenableDependencyUpdates dependencyUpdates -Drevision=release
> {code}
> We get a list of dependencies to update.
> We have problems with a number of libs. We keep comments in the main
> build.gradle for special updating issues. Be sure to check the main
> build.gradle. Some Java classes need internal versions update too:
> Also Solr et Lucene should use the same version, luceneMatchVersion should be
> updated in solrconfig.xml
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Closed] (OFBIZ-12844) Update zip4j to 2.11.5
[ https://issues.apache.org/jira/browse/OFBIZ-12844?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gil Portenseigne closed OFBIZ-12844. Fix Version/s: 22.01.01 Upcoming Branch Resolution: Fixed > Update zip4j to 2.11.5 > -- > > Key: OFBIZ-12844 > URL: https://issues.apache.org/jira/browse/OFBIZ-12844 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: 22.01.01 >Reporter: Gil Portenseigne >Assignee: Gil Portenseigne >Priority: Major > Fix For: 22.01.01, Upcoming Branch > > > See [https://github.com/srikanth-lingala/zip4j/releases] > Current 2.11.2 need update to fix CVE -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (OFBIZ-12845) Update commons-net to 3.9.0
Gil Portenseigne created OFBIZ-12845: Summary: Update commons-net to 3.9.0 Key: OFBIZ-12845 URL: https://issues.apache.org/jira/browse/OFBIZ-12845 Project: OFBiz Issue Type: Improvement Components: framework Affects Versions: 22.01.01 Reporter: Gil Portenseigne Fix For: Upcoming Branch Update to last current release fixing [CVE-2021-37533|https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2021-37533] https://lists.apache.org/thread/vys2q39lrkyqcyr7rhj9308c4rpq8kkm -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (OFBIZ-12844) Update zip4j to 2.11.5
Gil Portenseigne created OFBIZ-12844: Summary: Update zip4j to 2.11.5 Key: OFBIZ-12844 URL: https://issues.apache.org/jira/browse/OFBIZ-12844 Project: OFBiz Issue Type: Improvement Components: framework Affects Versions: 22.01.01 Reporter: Gil Portenseigne Assignee: Gil Portenseigne See [https://github.com/srikanth-lingala/zip4j/releases] Current 2.11.2 need update to fix CVE -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Closed] (OFBIZ-12816) Fix exception for createFuturePeriod Service
[
https://issues.apache.org/jira/browse/OFBIZ-12816?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gil Portenseigne closed OFBIZ-12816.
Resolution: Fixed
> Fix exception for createFuturePeriod Service
>
>
> Key: OFBIZ-12816
> URL: https://issues.apache.org/jira/browse/OFBIZ-12816
> Project: OFBiz
> Issue Type: Bug
>Affects Versions: Upcoming Branch
>Reporter: Gil Portenseigne
>Assignee: Gil Portenseigne
>Priority: Trivial
> Fix For: Upcoming Branch
>
>
> Exception is thrown when using createFuturePeriod service :
> {code:java}
> org.apache.ofbiz.entity.transaction.GenericTransactionException: Roll back
> error, could not commit transaction, was rolled back instead because of:
> Service [createFuturePeriod] threw an unexpected
> exception/errororg.apache.ofbiz.service.GenericServiceException: Error
> running Groovy method [createFuturePeriod] in Groovy file
> [component://common/groovyScripts/CommonServices.groovy]: (Error while
> checking to see if this is the last result (The 'isLast' method is only
> allowed on scroll cursors.)) (Error running Groovy method
> [createFuturePeriod] in Groovy file
> [component://common/groovyScripts/CommonServices.groovy]: (Error while
> checking to see if this is the last result (The 'isLast' method is only
> allowed on scroll cursors.)))
> {code}
> Indeed `hasNext` is used on `EntityListIterator`, this usage is discourage in
> its javadoc displaying a warning and leading to this exception.
> A simple fix is to not test next value presence before getting it, but after..
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Created] (OFBIZ-12816) Fix exception for createFuturePeriod Service
Gil Portenseigne created OFBIZ-12816:
Summary: Fix exception for createFuturePeriod Service
Key: OFBIZ-12816
URL: https://issues.apache.org/jira/browse/OFBIZ-12816
Project: OFBiz
Issue Type: Bug
Affects Versions: Upcoming Branch
Reporter: Gil Portenseigne
Assignee: Gil Portenseigne
Fix For: Upcoming Branch
Exception is thrown when using createFuturePeriod service :
{code:java}
org.apache.ofbiz.entity.transaction.GenericTransactionException: Roll back
error, could not commit transaction, was rolled back instead because of:
Service [createFuturePeriod] threw an unexpected
exception/errororg.apache.ofbiz.service.GenericServiceException: Error running
Groovy method [createFuturePeriod] in Groovy file
[component://common/groovyScripts/CommonServices.groovy]: (Error while
checking to see if this is the last result (The 'isLast' method is only allowed
on scroll cursors.)) (Error running Groovy method [createFuturePeriod] in
Groovy file [component://common/groovyScripts/CommonServices.groovy]: (Error
while checking to see if this is the last result (The 'isLast' method is only
allowed on scroll cursors.)))
{code}
Indeed `hasNext` is used on `EntityListIterator`, this usage is discourage in
its javadoc displaying a warning and leading to this exception.
A simple fix is to not test next value presence before getting it, but after..
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Closed] (OFBIZ-12801) Error at CommunicationEventServices.groovy:489 due to OFBIZ-11167
[
https://issues.apache.org/jira/browse/OFBIZ-12801?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gil Portenseigne closed OFBIZ-12801.
Resolution: Fixed
> Error at CommunicationEventServices.groovy:489 due to OFBIZ-11167
> --
>
> Key: OFBIZ-12801
> URL: https://issues.apache.org/jira/browse/OFBIZ-12801
> Project: OFBiz
> Issue Type: Bug
> Components: projectmgr
>Affects Versions: Upcoming Branch
> Environment:
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Major
> Fix For: Upcoming Branch
>
>
> I get this error locally:
> The Following Errors Occurred:
> Service dispatcher threw an exception:Error running Groovy method
> [sendEmailDated] in Groovy file
> [component://party/groovyScripts/communication/CommunicationEventServices.groovy]:
> (Cannot cast object '[]' with class 'java.util.ArrayList' to class
> 'java.util.Map' due to: groovy.lang.GroovyRuntimeException: Could not find
> matching constructor for: java.util.Map())
> When I replace
> Map sendEmailDated() {
> by
> def sendEmailDated() {
> The error disappears
> I guess something better can be done, but I have not yet found what :)
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (OFBIZ-12801) Error at CommunicationEventServices.groovy:489 due to OFBIZ-11167
[
https://issues.apache.org/jira/browse/OFBIZ-12801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17719844#comment-17719844
]
Gil Portenseigne commented on OFBIZ-12801:
--
Hello Jacques, Daniel,
While the discussion continue about GroovyBaseScript in dev mailing list, i
think we can agree for this case to move the return success() out of the each
block ?
Thanks,
Gil
> Error at CommunicationEventServices.groovy:489 due to OFBIZ-11167
> --
>
> Key: OFBIZ-12801
> URL: https://issues.apache.org/jira/browse/OFBIZ-12801
> Project: OFBiz
> Issue Type: Bug
> Components: projectmgr
>Affects Versions: Upcoming Branch
> Environment:
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Major
> Fix For: Upcoming Branch
>
>
> I get this error locally:
> The Following Errors Occurred:
> Service dispatcher threw an exception:Error running Groovy method
> [sendEmailDated] in Groovy file
> [component://party/groovyScripts/communication/CommunicationEventServices.groovy]:
> (Cannot cast object '[]' with class 'java.util.ArrayList' to class
> 'java.util.Map' due to: groovy.lang.GroovyRuntimeException: Could not find
> matching constructor for: java.util.Map())
> When I replace
> Map sendEmailDated() {
> by
> def sendEmailDated() {
> The error disappears
> I guess something better can be done, but I have not yet found what :)
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (OFBIZ-12801) Error at CommunicationEventServices.groovy:489 due to OFBIZ-11167
[
https://issues.apache.org/jira/browse/OFBIZ-12801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17713934#comment-17713934
]
Gil Portenseigne commented on OFBIZ-12801:
--
For this case I agree that the fix should be returning success at the end of
the service implementation.
I personally wondered about success method that can return two different types
depending of the context (request vs service), and I agree that any groovy
script implementation using this method are only of one type.
But I think that this particular implementation was intentional to avoid the
dev to think about being in service or event, and using success() in any
situation. (same with error method).
Quote of the commit message from Jacopo :
{quote}these helper methods have been enhanced in order to be used by groovy
method executed as services or events in a transparent way.
{quote}
With that intent in mind, codenarc-disable was set, i'm yet not sure that we
should remove that intent, that technically do not cause any issue apart from
having NoDef best practice not respected.
I guess that should be discussed in another Jira / mailing list :)
> Error at CommunicationEventServices.groovy:489 due to OFBIZ-11167
> --
>
> Key: OFBIZ-12801
> URL: https://issues.apache.org/jira/browse/OFBIZ-12801
> Project: OFBiz
> Issue Type: Bug
> Components: projectmgr
>Affects Versions: Upcoming Branch
> Environment:
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Major
> Fix For: Upcoming Branch
>
>
> I get this error locally:
> The Following Errors Occurred:
> Service dispatcher threw an exception:Error running Groovy method
> [sendEmailDated] in Groovy file
> [component://party/groovyScripts/communication/CommunicationEventServices.groovy]:
> (Cannot cast object '[]' with class 'java.util.ArrayList' to class
> 'java.util.Map' due to: groovy.lang.GroovyRuntimeException: Could not find
> matching constructor for: java.util.Map())
> When I replace
> Map sendEmailDated() {
> by
> def sendEmailDated() {
> The error disappears
> I guess something better can be done, but I have not yet found what :)
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Closed] (OFBIZ-11167) Use Codenarc to test Groovy code
[ https://issues.apache.org/jira/browse/OFBIZ-11167?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gil Portenseigne closed OFBIZ-11167. Fix Version/s: 22.01.01 Upcoming Branch Resolution: Implemented > Use Codenarc to test Groovy code > > > Key: OFBIZ-11167 > URL: https://issues.apache.org/jira/browse/OFBIZ-11167 > Project: OFBiz > Issue Type: New Feature > Components: framework >Reporter: Jacques Le Roux >Assignee: Gil Portenseigne >Priority: Minor > Fix For: 22.01.01, Upcoming Branch > > Attachments: OFBIZ-11167.patch, main.html, test.html > > > Thread of community discussion about the rules to implement : > https://www.mail-archive.com/search?l=dev%40ofbiz.apache.org&q=subject:%22Codenarc+integration%2C+rules+to+use.%22&o=newest&f=1 > > Now that we use Groovy more and more, I think we should really have a look a > Codenarc > [https://docs.gradle.org/current/userguide/codenarc_plugin.html] > We already discussed it at [https://markmail.org/message/uigcpnxqgizhd2oi] > and [https://markmail.org/message/rp6njoiohkkiodbe] > We know it's a crucial task but not an easy but rather a long term one > Here are some interesting links (before I delete my FF tabs group about it) > [http://codenarc.sourceforge.net/codenarc-other-tools-frameworks.html] > [http://codenarc.sourceforge.net/codenarc-creating-ruleset.html] > [https://github.com/gradle/gradle/tree/master/config] > [https://stackoverflow.com/questions/14358471/how-to-generate-codenarc-report-for-main-and-test-classes-using-different-rule-s] > [https://mrhaki.blogspot.com/2011/01/gradle-goodness-use-groovy-ruleset-file.html] -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OFBIZ-9984) Convert OrderServices.xml mini-lang to groovyDSL
[ https://issues.apache.org/jira/browse/OFBIZ-9984?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17687808#comment-17687808 ] Gil Portenseigne commented on OFBIZ-9984: - Hello Jacques, IIRW it was not complete, only partly done, as [~sberg] offers to continue the work, i stopped working on it and got on other subject. [~sberg] do you intent to continue ? Thanks Gil > Convert OrderServices.xml mini-lang to groovyDSL > > > Key: OFBIZ-9984 > URL: https://issues.apache.org/jira/browse/OFBIZ-9984 > Project: OFBiz > Issue Type: Sub-task > Components: order >Affects Versions: Trunk, Upcoming Branch >Reporter: Julien NICOLAS >Assignee: Gil Portenseigne >Priority: Minor > Labels: groovy, mini-lang > Attachments: OFBIZ-9984-v1.patch, OFBIZ-9984.patch > > > With the purpose to deprecate mini-lang OFBIZ-9350, I tried to convert some > mini-lang service to groovy script. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Closed] (OFBIZ-12732) Error in BlackList to DenyList migration service
[ https://issues.apache.org/jira/browse/OFBIZ-12732?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gil Portenseigne closed OFBIZ-12732. Resolution: Fixed > Error in BlackList to DenyList migration service > > > Key: OFBIZ-12732 > URL: https://issues.apache.org/jira/browse/OFBIZ-12732 > Project: OFBiz > Issue Type: Bug >Affects Versions: Upcoming Branch >Reporter: Gil Portenseigne >Assignee: Gil Portenseigne >Priority: Major > Fix For: 22.01.01 > > > While reviewing groovy files for codenarc integration i stumbled upon > OrderBlacklistServices.groovy that present some implementation issue. > > This Jira is about fixing the implementation of this service. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (OFBIZ-12732) Error in BlackList to DenyList migration service
[ https://issues.apache.org/jira/browse/OFBIZ-12732?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gil Portenseigne updated OFBIZ-12732: - Fix Version/s: 22.01.01 > Error in BlackList to DenyList migration service > > > Key: OFBIZ-12732 > URL: https://issues.apache.org/jira/browse/OFBIZ-12732 > Project: OFBiz > Issue Type: Bug >Affects Versions: Upcoming Branch >Reporter: Gil Portenseigne >Assignee: Gil Portenseigne >Priority: Major > Fix For: 22.01.01 > > > While reviewing groovy files for codenarc integration i stumbled upon > OrderBlacklistServices.groovy that present some implementation issue. > > This Jira is about fixing the implementation of this service. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (OFBIZ-12732) Error in BlackList to DenyList migration service
[ https://issues.apache.org/jira/browse/OFBIZ-12732?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gil Portenseigne updated OFBIZ-12732: - Affects Version/s: (was: 18.12.06) > Error in BlackList to DenyList migration service > > > Key: OFBIZ-12732 > URL: https://issues.apache.org/jira/browse/OFBIZ-12732 > Project: OFBiz > Issue Type: Bug >Affects Versions: Upcoming Branch >Reporter: Gil Portenseigne >Assignee: Gil Portenseigne >Priority: Major > > While reviewing groovy files for codenarc integration i stumbled upon > OrderBlacklistServices.groovy that present some implementation issue. > > This Jira is about fixing the implementation of this service. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (OFBIZ-12732) Error in BlackList to DenyList migration service
Gil Portenseigne created OFBIZ-12732: Summary: Error in BlackList to DenyList migration service Key: OFBIZ-12732 URL: https://issues.apache.org/jira/browse/OFBIZ-12732 Project: OFBiz Issue Type: Bug Affects Versions: 18.12.06, Upcoming Branch Reporter: Gil Portenseigne Assignee: Gil Portenseigne While reviewing groovy files for codenarc integration i stumbled upon OrderBlacklistServices.groovy that present some implementation issue. This Jira is about fixing the implementation of this service. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OFBIZ-12725) Cannot expand tree of accounts in Navigate Accounts screen with Helveticus theme
[ https://issues.apache.org/jira/browse/OFBIZ-12725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17652186#comment-17652186 ] Gil Portenseigne commented on OFBIZ-12725: -- Hello [~jleroux] , [~marine] is the person you meant to contact I guess, I transfer the info to let her know :) Thanks > Cannot expand tree of accounts in Navigate Accounts screen with Helveticus > theme > > > Key: OFBIZ-12725 > URL: https://issues.apache.org/jira/browse/OFBIZ-12725 > Project: OFBiz > Issue Type: Sub-task > Components: accounting, themes/helveticus >Affects Versions: 22.01.01 >Reporter: Daniel Watford >Assignee: Jacques Le Roux >Priority: Major > Fix For: 22.01.01 > > > Viewing [OFBiz: Accounting Manager: Navigate Accounts > (apache.org)|https://demo-next.ofbiz.apache.org/accounting/control/GlAccountNavigate?trail=null], > it is not possible to expand the chart-of-accounts tree when the Helveticus > visual theme is used. > The Helveticus theme is the default theme for new deployments. > A workaround is to switch to a non-Helveticus theme. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (OFBIZ-11167) Use Codenarc to test Groovy code
[ https://issues.apache.org/jira/browse/OFBIZ-11167?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gil Portenseigne updated OFBIZ-11167: - Description: Thread of community discussion about the rules to implement : https://www.mail-archive.com/search?l=dev%40ofbiz.apache.org&q=subject:%22Codenarc+integration%2C+rules+to+use.%22&o=newest&f=1 Now that we use Groovy more and more, I think we should really have a look a Codenarc [https://docs.gradle.org/current/userguide/codenarc_plugin.html] We already discussed it at [https://markmail.org/message/uigcpnxqgizhd2oi] and [https://markmail.org/message/rp6njoiohkkiodbe] We know it's a crucial task but not an easy but rather a long term one Here are some interesting links (before I delete my FF tabs group about it) [http://codenarc.sourceforge.net/codenarc-other-tools-frameworks.html] [http://codenarc.sourceforge.net/codenarc-creating-ruleset.html] [https://github.com/gradle/gradle/tree/master/config] [https://stackoverflow.com/questions/14358471/how-to-generate-codenarc-report-for-main-and-test-classes-using-different-rule-s] [https://mrhaki.blogspot.com/2011/01/gradle-goodness-use-groovy-ruleset-file.html] was: Now that we use Groovy more and more, I think we should really have a look a Codenarc https://docs.gradle.org/current/userguide/codenarc_plugin.html We already discussed it at https://markmail.org/message/uigcpnxqgizhd2oi and https://markmail.org/message/rp6njoiohkkiodbe We know it's a crucial task but not an easy but rather a long term one Here are some interesting links (before I delete my FF tabs group about it) http://codenarc.sourceforge.net/codenarc-other-tools-frameworks.html http://codenarc.sourceforge.net/codenarc-creating-ruleset.html https://github.com/gradle/gradle/tree/master/config https://stackoverflow.com/questions/14358471/how-to-generate-codenarc-report-for-main-and-test-classes-using-different-rule-s https://mrhaki.blogspot.com/2011/01/gradle-goodness-use-groovy-ruleset-file.html > Use Codenarc to test Groovy code > > > Key: OFBIZ-11167 > URL: https://issues.apache.org/jira/browse/OFBIZ-11167 > Project: OFBiz > Issue Type: New Feature > Components: framework >Reporter: Jacques Le Roux >Assignee: Gil Portenseigne >Priority: Minor > Attachments: OFBIZ-11167.patch, main.html, test.html > > > Thread of community discussion about the rules to implement : > https://www.mail-archive.com/search?l=dev%40ofbiz.apache.org&q=subject:%22Codenarc+integration%2C+rules+to+use.%22&o=newest&f=1 > > Now that we use Groovy more and more, I think we should really have a look a > Codenarc > [https://docs.gradle.org/current/userguide/codenarc_plugin.html] > We already discussed it at [https://markmail.org/message/uigcpnxqgizhd2oi] > and [https://markmail.org/message/rp6njoiohkkiodbe] > We know it's a crucial task but not an easy but rather a long term one > Here are some interesting links (before I delete my FF tabs group about it) > [http://codenarc.sourceforge.net/codenarc-other-tools-frameworks.html] > [http://codenarc.sourceforge.net/codenarc-creating-ruleset.html] > [https://github.com/gradle/gradle/tree/master/config] > [https://stackoverflow.com/questions/14358471/how-to-generate-codenarc-report-for-main-and-test-classes-using-different-rule-s] > [https://mrhaki.blogspot.com/2011/01/gradle-goodness-use-groovy-ruleset-file.html] -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OFBIZ-11167) Use Codenarc to test Groovy code
[ https://issues.apache.org/jira/browse/OFBIZ-11167?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17648644#comment-17648644 ] Gil Portenseigne commented on OFBIZ-11167: -- Work still ongoing, i propose to remove rule TrailingComma : Check whether list and map literals contain optional trailing comma. > Use Codenarc to test Groovy code > > > Key: OFBIZ-11167 > URL: https://issues.apache.org/jira/browse/OFBIZ-11167 > Project: OFBiz > Issue Type: New Feature > Components: framework >Reporter: Jacques Le Roux >Assignee: Gil Portenseigne >Priority: Minor > Attachments: OFBIZ-11167.patch, main.html, test.html > > > Now that we use Groovy more and more, I think we should really have a look a > Codenarc > https://docs.gradle.org/current/userguide/codenarc_plugin.html > We already discussed it at https://markmail.org/message/uigcpnxqgizhd2oi and > https://markmail.org/message/rp6njoiohkkiodbe > We know it's a crucial task but not an easy but rather a long term one > Here are some interesting links (before I delete my FF tabs group about it) > http://codenarc.sourceforge.net/codenarc-other-tools-frameworks.html > http://codenarc.sourceforge.net/codenarc-creating-ruleset.html > https://github.com/gradle/gradle/tree/master/config > https://stackoverflow.com/questions/14358471/how-to-generate-codenarc-report-for-main-and-test-classes-using-different-rule-s > https://mrhaki.blogspot.com/2011/01/gradle-goodness-use-groovy-ruleset-file.html -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OFBIZ-11167) Use Codenarc to test Groovy code
[
https://issues.apache.org/jira/browse/OFBIZ-11167?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17561935#comment-17561935
]
Gil Portenseigne commented on OFBIZ-11167:
--
I wrote a little script to extract the rules in order of occurrence. I will
launch an email to the dev list to discuss about the rules to be respected, and
the implied changes.
There are the results :
||Number of occurence||Rule name and details||
|9883|UnnecessaryGString - String objects should be created with single quotes,
and GString objects created with double quotes. Creating normal String objects
with double quotes is confusing to readers.|
|4569|DuplicateStringLiteral - Code containing duplicate String literals can
usually be improved by declaring the String as a constant field. The
ignoreStrings property () can optionally specify a comma-separated list of
Strings to ignore.|
|4209|SpaceAroundMapEntryColon - Check for configured formatting of whitespace
around colons for literal Map entries. The characterBeforeColonRegex and
characterAfterColonRegex properties specify a regular expression that must
match the character before/after the colon.|
|1448|LineLength - Checks the maximum length for each line of source code. It
checks for number of characters, so lines that include tabs may appear longer
than the allowed number when viewing the file. The maximum line length can be
configured by setting the length property, which defaults to 120.|
|885|UnnecessaryGetter - Checks for explicit calls to getter/accessor methods
which can, for the most part, be replaced by property access. A getter is
defined as a method call that matches get[A-Z] but not getClass() or
get[A-Z][A-Z] such as getURL(). Getters do not take method arguments. The
ignoreMethodNames property (null) can specify method names that should be
ignored, optionally containing wildcard characters ('*' or '?').|
|601|NoDef - def should not be used. You should replace it with concrete type.|
|485|MethodReturnTypeRequired - Checks that method return types are not
dynamic, that is they are explicitly stated and different than def.|
|484|Indentation - Check indentation for class and method declarations, and
initial statements.|
|482|UnnecessaryReturnKeyword - In Groovy, the return keyword is often
optional. If a statement is the last line in a method or closure then you do
not need to have the return keyword.|
|407|UnnecessaryObjectReferences - Violations are triggered when an excessive
set of consecutive statements all reference the same variable. This can be made
more readable by using a with or identity block.|
|345|CompileStatic - Check that classes are explicitely annotated with either
@GrailsCompileStatic, @CompileStatic or @CompileDynamic|
|320|ExplicitCallToEqualsMethod - This rule detects when the equals(Object)
method is called directly in code instead of using the == or != operator. A
groovier way to express this: a.equals(b) is this: a == b and a groovier way to
express : !a.equals(b) is : a != b|
|235|IfStatementBraces - Use braces for if statements, even for a single
statement.|
|235|SpaceAroundOperator - Check that there is at least one space (blank) or
whitespace around each binary operator.|
|211|NestedBlockDepth - Checks for blocks or closures nested more than
maxNestedBlockDepth (5) levels deep.|
|201|TrailingWhitespace - Checks that no lines of source code end with
whitespace characters.|
|190|DuplicateNumberLiteral - Code containing number String literals can
usually be improved by declaring the number as a constant field. The
ignoreNumbers property (0,1) can optionally specify a comma-separated list of
numbers to ignore.|
|190|NoWildcardImports - Wildcard imports, static or otherwise, should not be
used.|
|173|TrailingComma - Check whether list and map literals contain optional
trailing comma.|
|167|InvertedCondition - An inverted condition is one where a constant
expression is used on the left hand side of the equals comparision. Such
conditions can be confusing especially when used in assertions where the
expected value is by convention placed on the right hand side of the
comparision.|
|167|JavadocEmptyReturnTag - Checks for empty @return tags within javadoc.|
|164|UnnecessarySetter - Checks for explicit calls to setter methods which can,
for the most part, be replaced by assignment to property. A setter is defined
as a method call that matches set[A-Z] but not set[A-Z][A-Z] such as setURL().
Setters take one method argument.|
|146|CouldBeElvis - Catch an if block that could be written as an elvis
expression.|
|142|UnusedImport - Imports for a class that is never referenced within the
source file is unnecessary.|
|141|AbcMetric - Checks the ABC size metric for methods/classes. A method (or
"closure field") with an ABC score greater than the maxMethodAbcScore property
(60) causes a violation. Likewise, a class that has
[jira] [Commented] (OFBIZ-11167) Use Codenarc to test Groovy code
[ https://issues.apache.org/jira/browse/OFBIZ-11167?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17561468#comment-17561468 ] Gil Portenseigne commented on OFBIZ-11167: -- Hello Folks, i dig up this subject and started to work on it actively, i will push my progress here [https://github.com/apache/ofbiz-framework/pull/517.] The Idea is to document each rule, and make one commit by rule on the pull request to ease the review and decide if a rule is worth keeping etc. > Use Codenarc to test Groovy code > > > Key: OFBIZ-11167 > URL: https://issues.apache.org/jira/browse/OFBIZ-11167 > Project: OFBiz > Issue Type: New Feature > Components: framework >Reporter: Jacques Le Roux >Assignee: Gil Portenseigne >Priority: Minor > Attachments: OFBIZ-11167.patch, main.html, test.html > > > Now that we use Groovy more and more, I think we should really have a look a > Codenarc > https://docs.gradle.org/current/userguide/codenarc_plugin.html > We already discussed it at https://markmail.org/message/uigcpnxqgizhd2oi and > https://markmail.org/message/rp6njoiohkkiodbe > We know it's a crucial task but not an easy but rather a long term one > Here are some interesting links (before I delete my FF tabs group about it) > http://codenarc.sourceforge.net/codenarc-other-tools-frameworks.html > http://codenarc.sourceforge.net/codenarc-creating-ruleset.html > https://github.com/gradle/gradle/tree/master/config > https://stackoverflow.com/questions/14358471/how-to-generate-codenarc-report-for-main-and-test-classes-using-different-rule-s > https://mrhaki.blogspot.com/2011/01/gradle-goodness-use-groovy-ruleset-file.html -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Closed] (OFBIZ-10692) Groovy DSL runService Exception Management
[
https://issues.apache.org/jira/browse/OFBIZ-10692?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gil Portenseigne closed OFBIZ-10692.
Resolution: Fixed
Thanks [~mleila] , this is commited in trunk.
Regards,
Gil
> Groovy DSL runService Exception Management
> --
>
> Key: OFBIZ-10692
> URL: https://issues.apache.org/jira/browse/OFBIZ-10692
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
>Affects Versions: Trunk, Upcoming Branch
>Reporter: Leila Mekika
>Assignee: Gil Portenseigne
>Priority: Minor
> Labels: patch
> Attachments: OFBIZ-10692-TEST.patch, OFBIZ-10692.patch,
> Sélection_088.png, screenshot-1.png
>
>
> Like discussed in thread :
> [https://lists.apache.org/thread.html/5a8e1caed0bcf29889c6b88ec1916947cf092d6f99d7dfe27cbef8c0@%3Cdev.ofbiz.apache.org%3E]
>
> This ticket try to improve the way that errors are rendered when using {{run
> service}} groovy DSL method.
>
> To reproduce and test patch:
> apply the attached patch [^OFBIZ-10692-TEST.patch] (it adds a control on
> createUomConversionDated service) and try to create a conversion rate with a
> fromDate greater than the thruDate here:
> https://localhost:8443/accounting/control/viewFXConversions?organizationPartyId=Company
>
> You should then see the following error:
> The Following Errors Occurred: Error calling event:
> org.apache.ofbiz.webapp.event.EventHandlerException: Service invocation error
> (org.apache.ofbiz.service.ExecutionServiceException: Through date can't be
> same or smaller than from date)
>
> With [^OFBIZ-10692.patch] update, the error must be displayed like:
> The Following Errors Occurred: Through date can't be same or smaller
> than from date
>
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[jira] [Commented] (OFBIZ-10692) Groovy DSL runService Exception Management
[
https://issues.apache.org/jira/browse/OFBIZ-10692?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17542922#comment-17542922
]
Gil Portenseigne commented on OFBIZ-10692:
--
This ticket was in stand-by, we added some integration tests, i will provide a
new patch soon.
> Groovy DSL runService Exception Management
> --
>
> Key: OFBIZ-10692
> URL: https://issues.apache.org/jira/browse/OFBIZ-10692
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
>Affects Versions: Trunk, Upcoming Branch
>Reporter: Leila Mekika
>Assignee: Gil Portenseigne
>Priority: Minor
> Labels: patch
> Attachments: OFBIZ-10692-TEST.patch, OFBIZ-10692.patch,
> Sélection_088.png, screenshot-1.png
>
>
> Like discussed in thread :
> [https://lists.apache.org/thread.html/5a8e1caed0bcf29889c6b88ec1916947cf092d6f99d7dfe27cbef8c0@%3Cdev.ofbiz.apache.org%3E]
>
> This ticket try to improve the way that errors are rendered when using {{run
> service}} groovy DSL method.
>
> To reproduce and test patch:
> apply the attached patch [^OFBIZ-10692-TEST.patch] (it adds a control on
> createUomConversionDated service) and try to create a conversion rate with a
> fromDate greater than the thruDate here:
> https://localhost:8443/accounting/control/viewFXConversions?organizationPartyId=Company
>
> You should then see the following error:
> The Following Errors Occurred: Error calling event:
> org.apache.ofbiz.webapp.event.EventHandlerException: Service invocation error
> (org.apache.ofbiz.service.ExecutionServiceException: Through date can't be
> same or smaller than from date)
>
> With [^OFBIZ-10692.patch] update, the error must be displayed like:
> The Following Errors Occurred: Through date can't be same or smaller
> than from date
>
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[jira] [Closed] (OFBIZ-12183) Groovy script Product.groovy: java.util.NoSuchElementException
[ https://issues.apache.org/jira/browse/OFBIZ-12183?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gil Portenseigne closed OFBIZ-12183. Resolution: Cannot Reproduce Closing since not reproducible. Thanks > Groovy script Product.groovy: java.util.NoSuchElementException > --- > > Key: OFBIZ-12183 > URL: https://issues.apache.org/jira/browse/OFBIZ-12183 > Project: OFBiz > Issue Type: Bug > Components: ecommerce, order >Affects Versions: Release Branch 18.12, Trunk, 17.12.05, Upcoming Branch > Environment: Linux/Ubuntu 16.04, Linux/Ubuntu 18.04, OFBiz v13.07.03 >Reporter: Giulio Speri >Assignee: Nicolas Malin >Priority: Critical > Attachments: NoSuchElementException_Productgroovy.jpeg > > > Strange issue happens randomly (it seems) while loading ecommerce product > detail page and the groovy script Product.groovy > (order/webapp/ordermgr/WEB-INF/actions/entry/catalog/) is run. > The groovy script is loaded in the screen "product". > The error showed is kind of java.util.NoSuchElementException and I think that > could be something related to session/request attributes, since this could be > avoided with an incognito navigation session. > I saw this error a couple of times during local development also and I could > pass over it by manually deleting browser session cookies. > Unfortunately I was not able to reproduce it yet, so I cannot add more > details except hypothesis. > I also post here a screenshot of the error. > > !NoSuchElementException_Productgroovy.jpeg! -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Closed] (OFBIZ-12612) Update sshd dependency and implementation
[ https://issues.apache.org/jira/browse/OFBIZ-12612?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gil Portenseigne closed OFBIZ-12612. Fix Version/s: 22.01.01 Resolution: Fixed This was commited in release22 since fixed an implementation issue. > Update sshd dependency and implementation > -- > > Key: OFBIZ-12612 > URL: https://issues.apache.org/jira/browse/OFBIZ-12612 > Project: OFBiz > Issue Type: Improvement >Affects Versions: Upcoming Branch >Reporter: Gil Portenseigne >Assignee: Gil Portenseigne >Priority: Major > Fix For: 22.01.01, Upcoming Branch > > > Updating sshd library used by SshFtpClient feature. > In a customer project, we found out that the current implementation under > heavy usage leads to redundant thread creation. > This patch update the implementation using the last revision of the sshd mina > librairy. -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Updated] (OFBIZ-12612) Update sshd dependency and implementation
[ https://issues.apache.org/jira/browse/OFBIZ-12612?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gil Portenseigne updated OFBIZ-12612: - Fix Version/s: Upcoming Branch > Update sshd dependency and implementation > -- > > Key: OFBIZ-12612 > URL: https://issues.apache.org/jira/browse/OFBIZ-12612 > Project: OFBiz > Issue Type: Improvement >Affects Versions: Upcoming Branch >Reporter: Gil Portenseigne >Assignee: Gil Portenseigne >Priority: Major > Fix For: Upcoming Branch > > > Updating sshd library used by SshFtpClient feature. > In a customer project, we found out that the current implementation under > heavy usage leads to redundant thread creation. > This patch update the implementation using the last revision of the sshd mina > librairy. -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Updated] (OFBIZ-12612) Update sshd dependency and implementation
[ https://issues.apache.org/jira/browse/OFBIZ-12612?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gil Portenseigne updated OFBIZ-12612: - Affects Version/s: Upcoming Branch > Update sshd dependency and implementation > -- > > Key: OFBIZ-12612 > URL: https://issues.apache.org/jira/browse/OFBIZ-12612 > Project: OFBiz > Issue Type: Improvement >Affects Versions: Upcoming Branch >Reporter: Gil Portenseigne >Assignee: Gil Portenseigne >Priority: Major > > Updating sshd library used by SshFtpClient feature. > In a customer project, we found out that the current implementation under > heavy usage leads to redundant thread creation. > This patch update the implementation using the last revision of the sshd mina > librairy. -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Created] (OFBIZ-12612) Update sshd dependency and implementation
Gil Portenseigne created OFBIZ-12612: Summary: Update sshd dependency and implementation Key: OFBIZ-12612 URL: https://issues.apache.org/jira/browse/OFBIZ-12612 Project: OFBiz Issue Type: Improvement Reporter: Gil Portenseigne Assignee: Gil Portenseigne Updating sshd library used by SshFtpClient feature. In a customer project, we found out that the current implementation under heavy usage leads to redundant thread creation. This patch update the implementation using the last revision of the sshd mina librairy. -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Commented] (OFBIZ-9498) Improve DevOps using environment variable configuration
[ https://issues.apache.org/jira/browse/OFBIZ-9498?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17467881#comment-17467881 ] Gil Portenseigne commented on OFBIZ-9498: - I plan to complete the PR, and if no one oppose after last review, merge it. > Improve DevOps using environment variable configuration > --- > > Key: OFBIZ-9498 > URL: https://issues.apache.org/jira/browse/OFBIZ-9498 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk >Reporter: Gil Portenseigne >Assignee: Gil Portenseigne >Priority: Minor > Attachments: OFBIZ-9498.patch > > > Discussed in thread : https://s.apache.org/Mh3q > This Jira will present the improvment proposal giving a way to configure > OFBiz using environment variable. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Commented] (OFBIZ-9498) Improve DevOps using environment variable configuration
[ https://issues.apache.org/jira/browse/OFBIZ-9498?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17466789#comment-17466789 ] Gil Portenseigne commented on OFBIZ-9498: - Hello [~ieugen] , Thanks for your review, I work with [~marco_adeti] whom i gave the relay to animate the subject. He should make a first proposal about a new idea, in some times. About the current patch, no progress yet, it is usable, and used in several customer project in our side, feel free to experience. > Improve DevOps using environment variable configuration > --- > > Key: OFBIZ-9498 > URL: https://issues.apache.org/jira/browse/OFBIZ-9498 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk >Reporter: Gil Portenseigne >Assignee: Gil Portenseigne >Priority: Minor > Attachments: OFBIZ-9498.patch > > > Discussed in thread : https://s.apache.org/Mh3q > This Jira will present the improvment proposal giving a way to configure > OFBiz using environment variable. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Comment Edited] (OFBIZ-12369) Security screen in Party component doesn't allow for searching for user login
[ https://issues.apache.org/jira/browse/OFBIZ-12369?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17442681#comment-17442681 ] Gil Portenseigne edited comment on OFBIZ-12369 at 11/12/21, 11:04 AM: -- -Hello- [~pierresmits] -, i did not manage to reproduce the bug on branch 18.12 and trunk. Could you confirm ?- Ok I missread the ticket, could you provide a patch fixig the issue ? Thanks was (Author: gil portenseigne): Hello [~pierresmits] , i did not manage to reproduce the bug on branch 18.12 and trunk. Could you confirm ? Thanks > Security screen in Party component doesn't allow for searching for user login > - > > Key: OFBIZ-12369 > URL: https://issues.apache.org/jira/browse/OFBIZ-12369 > Project: OFBiz > Issue Type: Bug > Components: party >Affects Versions: Trunk, 18.12.01 >Reporter: Pierre Smits >Priority: Major > Labels: userlogin > > In [https://demo-stable.ofbiz.apache.org/partymgr/control/FindUserLogin] the > page shows the list of UserLogin records, but does not cater for searching > for such. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Commented] (OFBIZ-12369) Security screen in Party component doesn't allow for searching for user login
[ https://issues.apache.org/jira/browse/OFBIZ-12369?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17442681#comment-17442681 ] Gil Portenseigne commented on OFBIZ-12369: -- Hello [~pierresmits] , i did not manage to reproduce the bug on branch 18.12 and trunk. Could you confirm ? Thanks > Security screen in Party component doesn't allow for searching for user login > - > > Key: OFBIZ-12369 > URL: https://issues.apache.org/jira/browse/OFBIZ-12369 > Project: OFBiz > Issue Type: Bug > Components: party >Affects Versions: Trunk, 18.12.01 >Reporter: Pierre Smits >Priority: Major > Labels: userlogin > > In [https://demo-stable.ofbiz.apache.org/partymgr/control/FindUserLogin] the > page shows the list of UserLogin records, but does not cater for searching > for such. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Commented] (OFBIZ-12183) Groovy script Product.groovy: java.util.NoSuchElementException
[ https://issues.apache.org/jira/browse/OFBIZ-12183?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17442630#comment-17442630 ] Gil Portenseigne commented on OFBIZ-12183: -- Hello [~Giulio_MpStyle] , Do the patch solved your issue ? Can we close the Jira ? Thanks, Gil > Groovy script Product.groovy: java.util.NoSuchElementException > --- > > Key: OFBIZ-12183 > URL: https://issues.apache.org/jira/browse/OFBIZ-12183 > Project: OFBiz > Issue Type: Bug > Components: ecommerce, order >Affects Versions: Release Branch 18.12, Trunk, 17.12.05 > Environment: Linux/Ubuntu 16.04, Linux/Ubuntu 18.04, OFBiz v13.07.03 >Reporter: Giulio Speri >Assignee: Nicolas Malin >Priority: Critical > Attachments: NoSuchElementException_Productgroovy.jpeg > > > Strange issue happens randomly (it seems) while loading ecommerce product > detail page and the groovy script Product.groovy > (order/webapp/ordermgr/WEB-INF/actions/entry/catalog/) is run. > The groovy script is loaded in the screen "product". > The error showed is kind of java.util.NoSuchElementException and I think that > could be something related to session/request attributes, since this could be > avoided with an incognito navigation session. > I saw this error a couple of times during local development also and I could > pass over it by manually deleting browser session cookies. > Unfortunately I was not able to reproduce it yet, so I cannot add more > details except hypothesis. > I also post here a screenshot of the error. > > !NoSuchElementException_Productgroovy.jpeg! -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Commented] (OFBIZ-5980) Have the ability to revoke (expire) roles of a party
[ https://issues.apache.org/jira/browse/OFBIZ-5980?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17441568#comment-17441568 ] Gil Portenseigne commented on OFBIZ-5980: - Thank you [~jleroux] for the sum up, i will send a mail this friday to open the discussion to the community member, if no one did it before.:) > Have the ability to revoke (expire) roles of a party > > > Key: OFBIZ-5980 > URL: https://issues.apache.org/jira/browse/OFBIZ-5980 > Project: OFBiz > Issue Type: Bug > Components: party >Affects Versions: Trunk >Reporter: Pierre Smits >Assignee: Pierre Smits >Priority: Major > Labels: roles > Fix For: Upcoming Branch > > > Currently it is only possible to delete a PartyRole record from a party. > Which leads to error messages, when that particular Partyrole record is > associated with records in other entities where the PartyRole entity is set > as a relation (through which is > applied as a foreign key relation in the underlying dbms ). > Examples of such related entities that are: > * entity-name="MarketingCampaignRole" > * entity-name="BudgetRole" > In order to avoid such, it is better to revoke the PartyRole record by > setting an expiration date (end date) on the record. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Commented] (OFBIZ-5980) Have the ability to revoke (expire) roles of a party
[ https://issues.apache.org/jira/browse/OFBIZ-5980?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17440283#comment-17440283 ] Gil Portenseigne commented on OFBIZ-5980: - Hello [~pierresmits] , [~jleroux] , Indeed this bug/improvement will lead to big changes like discussed in OFBIZ-5959. This was some exchange with the community at [https://markmail.org/message/pqrmv5vpjgm6iigq#query:+page:1+mid:isaoze65bbciuytc+state:results] Maybe we should discuss it again now. [~pierresmits] would you mind discuss it with the community before continuing the dev effort ? Regards, > Have the ability to revoke (expire) roles of a party > > > Key: OFBIZ-5980 > URL: https://issues.apache.org/jira/browse/OFBIZ-5980 > Project: OFBiz > Issue Type: Bug > Components: party >Affects Versions: Trunk >Reporter: Pierre Smits >Assignee: Pierre Smits >Priority: Major > Labels: roles > Fix For: Upcoming Branch > > > Currently it is only possible to delete a PartyRole record from a party. > Which leads to error messages, when that particular Partyrole record is > associated with records in other entities where the PartyRole entity is set > as a relation (through which is > applied as a foreign key relation in the underlying dbms ). > Examples of such related entities that are: > * entity-name="MarketingCampaignRole" > * entity-name="BudgetRole" > In order to avoid such, it is better to revoke the PartyRole record by > setting an expiration date (end date) on the record. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Closed] (OFBIZ-12320) Reintroduce groovy-test-suite test case
[ https://issues.apache.org/jira/browse/OFBIZ-12320?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gil Portenseigne closed OFBIZ-12320. Fix Version/s: Upcoming Branch Resolution: Fixed > Reintroduce groovy-test-suite test case > --- > > Key: OFBIZ-12320 > URL: https://issues.apache.org/jira/browse/OFBIZ-12320 > Project: OFBiz > Issue Type: Improvement >Reporter: Gil Portenseigne >Assignee: Gil Portenseigne >Priority: Minor > Fix For: Upcoming Branch > > > Discussed in [https://markmail.org/thread/ol35dskzixqjhnys] > The goal is to allow coding tests in groovy script that do not need to be > compiled > for their execution and executing them from webtools -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (OFBIZ-12320) Reintroduce groovy-test-suite test case
Gil Portenseigne created OFBIZ-12320: Summary: Reintroduce groovy-test-suite test case Key: OFBIZ-12320 URL: https://issues.apache.org/jira/browse/OFBIZ-12320 Project: OFBiz Issue Type: Improvement Reporter: Gil Portenseigne Assignee: Gil Portenseigne Discussed in [https://markmail.org/thread/ol35dskzixqjhnys] The goal is to allow coding tests in groovy script that do not need to be compiled for their execution and executing them from webtools -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-6988) Estimated shipping cost resolution with breaks on price and quantity
[
https://issues.apache.org/jira/browse/OFBIZ-6988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17415370#comment-17415370
]
Gil Portenseigne commented on OFBIZ-6988:
-
Hello,
There was a duplicated test, so i added in test file javadoc a table that sum
up the rule, and fix the redondant test with the expected behaviour.
There was a little stream refacto also.
> Estimated shipping cost resolution with breaks on price and quantity
>
>
> Key: OFBIZ-6988
> URL: https://issues.apache.org/jira/browse/OFBIZ-6988
> Project: OFBiz
> Issue Type: Improvement
> Components: product
>Affects Versions: Trunk
>Reporter: Nicolas Malin
>Assignee: Nicolas Malin
>Priority: Minor
> Labels: shipping
> Attachments: OFBIZ-6988-1.patch, OFBIZ-6988.patch
>
>
> On the service *calcShipmentCostEstimate*, each estimated shipment cost is
> analysed to resolve which ones should be applied on the order.
> During the breakQtys block analysis, OFBiz checks if the estimate match the
> quantity with their breaks and validates if one is good
> {code}
> if (qv != null) {
> useQty = true;
> BigDecimal min = BigDecimal.ONE.movePointLeft(4);
> BigDecimal max = BigDecimal.ONE.movePointLeft(4);
> try {
> min = qv.getBigDecimal("fromQuantity");
> max = qv.getBigDecimal("thruQuantity");
> } catch (Exception e) {
> }
> if (shippableQuantity.compareTo(min) >= 0 &&
> (max.compareTo(BigDecimal.ZERO) == 0 || shippableQuantity.compareTo(max) <=
> 0)) {
> qtyValid = true;
> }
> if (Debug.infoOn()) Debug.logInfo(" # QUANTITY SHIP
> min : " + min + ", max : " + max + ", value " + shippableQuantity + "
> qtyValid " + qtyValid, module);
> }
> if (pv != null) {
> usePrice = true;
> BigDecimal min = BigDecimal.ONE.movePointLeft(4);
> BigDecimal max = BigDecimal.ONE.movePointLeft(4);
> try {
> min = pv.getBigDecimal("fromQuantity");
> max = pv.getBigDecimal("thruQuantity");
> } catch (Exception e) {
> }
> if (shippableTotal.compareTo(min) >= 0 &&
> (max.compareTo(BigDecimal.ZERO) == 0 || shippableTotal.compareTo(max) <= 0)) {
> priceValid = true;
> }
> if (Debug.infoOn()) Debug.logInfo(" # PRICE TOT SHIP
> min : " + min + ", max : " + max + ", value " + shippableTotal+ " qtyValid "
> + priceValid, module);
> }
> // Now check the tests.
> if ((useWeight && weightValid) || (useQty && qtyValid)
> || (usePrice && priceValid)) {
> estimateList.add(thisEstimate);
> }
> {code}
> I didn't understand why an estimated shippping cost that contains a no valid
> break can be applied on the order.
> On a customer project I have these rules:
> ||||Quantity Break Id|| Price Break Id|| Flat Price || Order Price
> Percent ||
> |FR000| | 0 - 1000 [FRP4] | 25|0|
> |FR001| 0 - 500,000 [FRB01]|1000 - 0 [FRP3] | |15|
> |FR004| 2,000,000 - 0 [FRB04]| 1000 - 0 [FRP3] | |2|
> |FR003| 1,000,001 - 1,999,999 [FRB03]| 1000 - 0 [FRP3] |
> |5|
> |FR002| 500,001 - 1,000,000 [FRB02]|1000 - 0 [FRP3] |
> |8|
> The problem with the previous code is that for a total price more than 300€
> OFBiz gives me a random rule between FR00[1-4] and it's wrong because I have
> also a break on total quantity shipped
> I propose to change the check like this
> {code}
> @@ -406,7 +410,9 @@
> }
> }
> // Now check the tests.
> -if ((useWeight && weightValid) || (useQty && qtyValid)
> || (usePrice && priceValid)) {
> +if ((!useWeight || useWeight && weightValid)
> +&& (!useQty || useQty && qtyValid)
> +&& (!usePrice || usePrice && priceValid)) {
> estimateList.add(thisEstimate);
> }
> }
> {code}
> To ensure that if a break is defined on the estimated shipping cost, we
> enable it only if all defined breaks are valid.
[jira] [Updated] (OFBIZ-6988) Estimated shipping cost resolution with breaks on price and quantity
[
https://issues.apache.org/jira/browse/OFBIZ-6988?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gil Portenseigne updated OFBIZ-6988:
Attachment: OFBIZ-6988-1.patch
> Estimated shipping cost resolution with breaks on price and quantity
>
>
> Key: OFBIZ-6988
> URL: https://issues.apache.org/jira/browse/OFBIZ-6988
> Project: OFBiz
> Issue Type: Improvement
> Components: product
>Affects Versions: Trunk
>Reporter: Nicolas Malin
>Assignee: Nicolas Malin
>Priority: Minor
> Labels: shipping
> Attachments: OFBIZ-6988-1.patch, OFBIZ-6988.patch
>
>
> On the service *calcShipmentCostEstimate*, each estimated shipment cost is
> analysed to resolve which ones should be applied on the order.
> During the breakQtys block analysis, OFBiz checks if the estimate match the
> quantity with their breaks and validates if one is good
> {code}
> if (qv != null) {
> useQty = true;
> BigDecimal min = BigDecimal.ONE.movePointLeft(4);
> BigDecimal max = BigDecimal.ONE.movePointLeft(4);
> try {
> min = qv.getBigDecimal("fromQuantity");
> max = qv.getBigDecimal("thruQuantity");
> } catch (Exception e) {
> }
> if (shippableQuantity.compareTo(min) >= 0 &&
> (max.compareTo(BigDecimal.ZERO) == 0 || shippableQuantity.compareTo(max) <=
> 0)) {
> qtyValid = true;
> }
> if (Debug.infoOn()) Debug.logInfo(" # QUANTITY SHIP
> min : " + min + ", max : " + max + ", value " + shippableQuantity + "
> qtyValid " + qtyValid, module);
> }
> if (pv != null) {
> usePrice = true;
> BigDecimal min = BigDecimal.ONE.movePointLeft(4);
> BigDecimal max = BigDecimal.ONE.movePointLeft(4);
> try {
> min = pv.getBigDecimal("fromQuantity");
> max = pv.getBigDecimal("thruQuantity");
> } catch (Exception e) {
> }
> if (shippableTotal.compareTo(min) >= 0 &&
> (max.compareTo(BigDecimal.ZERO) == 0 || shippableTotal.compareTo(max) <= 0)) {
> priceValid = true;
> }
> if (Debug.infoOn()) Debug.logInfo(" # PRICE TOT SHIP
> min : " + min + ", max : " + max + ", value " + shippableTotal+ " qtyValid "
> + priceValid, module);
> }
> // Now check the tests.
> if ((useWeight && weightValid) || (useQty && qtyValid)
> || (usePrice && priceValid)) {
> estimateList.add(thisEstimate);
> }
> {code}
> I didn't understand why an estimated shippping cost that contains a no valid
> break can be applied on the order.
> On a customer project I have these rules:
> ||||Quantity Break Id|| Price Break Id|| Flat Price || Order Price
> Percent ||
> |FR000| | 0 - 1000 [FRP4] | 25|0|
> |FR001| 0 - 500,000 [FRB01]|1000 - 0 [FRP3] | |15|
> |FR004| 2,000,000 - 0 [FRB04]| 1000 - 0 [FRP3] | |2|
> |FR003| 1,000,001 - 1,999,999 [FRB03]| 1000 - 0 [FRP3] |
> |5|
> |FR002| 500,001 - 1,000,000 [FRB02]|1000 - 0 [FRP3] |
> |8|
> The problem with the previous code is that for a total price more than 300€
> OFBiz gives me a random rule between FR00[1-4] and it's wrong because I have
> also a break on total quantity shipped
> I propose to change the check like this
> {code}
> @@ -406,7 +410,9 @@
> }
> }
> // Now check the tests.
> -if ((useWeight && weightValid) || (useQty && qtyValid)
> || (usePrice && priceValid)) {
> +if ((!useWeight || useWeight && weightValid)
> +&& (!useQty || useQty && qtyValid)
> +&& (!usePrice || usePrice && priceValid)) {
> estimateList.add(thisEstimate);
> }
> }
> {code}
> To ensure that if a break is defined on the estimated shipping cost, we
> enable it only if all defined breaks are valid.
> Any suggestion ?
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Closed] (OFBIZ-11808) Improve screen engine with decrease technology dependence
[ https://issues.apache.org/jira/browse/OFBIZ-11808?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gil Portenseigne closed OFBIZ-11808. Fix Version/s: Upcoming Branch Resolution: Fixed Thanks to all of you for your help ! The basis is there, let's practice ! > Improve screen engine with decrease technology dependence > - > > Key: OFBIZ-11808 > URL: https://issues.apache.org/jira/browse/OFBIZ-11808 > Project: OFBiz > Issue Type: Improvement > Components: framework, framework/widget >Affects Versions: Trunk >Reporter: Nicolas Malin >Assignee: Nicolas Malin >Priority: Major > Labels: screen, widget > Fix For: Upcoming Branch > > > After different presentation on thinking about how improve the end user > experience on back office screen, we start a list of issues that cover the > minimum need. > [chapter > 1|https://lists.apache.org/thread.html/5dcc8cff9b5413070079d22833b6a10abee55bcfbfb0233019ed09b1%40%3Cdev.ofbiz.apache.org%3E] > > [chapter > 2|https://lists.apache.org/thread.html/r146f2814691e98e2cfc308ed3ac1db77fb6a356a2b73215517d300aa%40%3Cdev.ofbiz.apache.org%3E] > [chapter > 3|https://lists.apache.org/thread.html/ra5ed191eecbaf8096ddcdcf98048e70ea8c139fcab75c734ff30b6c0%40%3Cdev.ofbiz.apache.org%3E] > [Presentation slides|https://s.apache.org/EmpowerOFBizScreen] > Each improvement is designed to decrease the xml form definition, based on > functional concept out any technology (relaying to theme). -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Closed] (OFBIZ-12262) Execute a callback with parameters from the request
[
https://issues.apache.org/jira/browse/OFBIZ-12262?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gil Portenseigne closed OFBIZ-12262.
Fix Version/s: Upcoming Branch
Resolution: Fixed
> Execute a callback with parameters from the request
> ---
>
> Key: OFBIZ-12262
> URL: https://issues.apache.org/jira/browse/OFBIZ-12262
> Project: OFBiz
> Issue Type: Sub-task
> Components: framework/widget
>Affects Versions: Trunk
>Reporter: Nicolas Malin
>Assignee: Gil Portenseigne
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments:
> 0001-Execute-a-callback-with-parameters-from-the-request-.patch
>
>
> With the new element set-callback (OFBIZ-11812) we have the possibility to
> call a request with event and wait the success/error before continue and
> update an area.
> If the event generate a new value (createProduct, createPerson, ...) where we
> need it for update the area, we can't generate the call.
> A possible idea would be add a new parameter type when we define a callback
> to indicate that we will wait the event return to resolve the value. Like
> {code:java}
>
>
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (OFBIZ-12262) Execute a callback with parameters from the request
[
https://issues.apache.org/jira/browse/OFBIZ-12262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17411213#comment-17411213
]
Gil Portenseigne commented on OFBIZ-12262:
--
Thanks Nicolas for the review
> Execute a callback with parameters from the request
> ---
>
> Key: OFBIZ-12262
> URL: https://issues.apache.org/jira/browse/OFBIZ-12262
> Project: OFBiz
> Issue Type: Sub-task
> Components: framework/widget
>Affects Versions: Trunk
>Reporter: Nicolas Malin
>Assignee: Gil Portenseigne
>Priority: Minor
> Attachments:
> 0001-Execute-a-callback-with-parameters-from-the-request-.patch
>
>
> With the new element set-callback (OFBIZ-11812) we have the possibility to
> call a request with event and wait the success/error before continue and
> update an area.
> If the event generate a new value (createProduct, createPerson, ...) where we
> need it for update the area, we can't generate the call.
> A possible idea would be add a new parameter type when we define a callback
> to indicate that we will wait the event return to resolve the value. Like
> {code:java}
>
>
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Assigned] (OFBIZ-12262) Execute a callback with parameters from the request
[
https://issues.apache.org/jira/browse/OFBIZ-12262?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gil Portenseigne reassigned OFBIZ-12262:
Assignee: Gil Portenseigne (was: Nicolas Malin)
> Execute a callback with parameters from the request
> ---
>
> Key: OFBIZ-12262
> URL: https://issues.apache.org/jira/browse/OFBIZ-12262
> Project: OFBiz
> Issue Type: Sub-task
> Components: framework/widget
>Affects Versions: Trunk
>Reporter: Nicolas Malin
>Assignee: Gil Portenseigne
>Priority: Minor
> Attachments:
> 0001-Execute-a-callback-with-parameters-from-the-request-.patch
>
>
> With the new element set-callback (OFBIZ-11812) we have the possibility to
> call a request with event and wait the success/error before continue and
> update an area.
> If the event generate a new value (createProduct, createPerson, ...) where we
> need it for update the area, we can't generate the call.
> A possible idea would be add a new parameter type when we define a callback
> to indicate that we will wait the event return to resolve the value. Like
> {code:java}
>
>
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (OFBIZ-12262) Execute a callback with parameters from the request
[
https://issues.apache.org/jira/browse/OFBIZ-12262?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gil Portenseigne updated OFBIZ-12262:
-
Attachment: 0001-Execute-a-callback-with-parameters-from-the-request-.patch
> Execute a callback with parameters from the request
> ---
>
> Key: OFBIZ-12262
> URL: https://issues.apache.org/jira/browse/OFBIZ-12262
> Project: OFBiz
> Issue Type: Sub-task
> Components: framework/widget
>Affects Versions: Trunk
>Reporter: Nicolas Malin
>Assignee: Gil Portenseigne
>Priority: Minor
> Attachments:
> 0001-Execute-a-callback-with-parameters-from-the-request-.patch
>
>
> With the new element set-callback (OFBIZ-11812) we have the possibility to
> call a request with event and wait the success/error before continue and
> update an area.
> If the event generate a new value (createProduct, createPerson, ...) where we
> need it for update the area, we can't generate the call.
> A possible idea would be add a new parameter type when we define a callback
> to indicate that we will wait the event return to resolve the value. Like
> {code:java}
>
>
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Closed] (OFBIZ-12299) Jgrowl label are not well retrieved showing 'undefined' button
[ https://issues.apache.org/jira/browse/OFBIZ-12299?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gil Portenseigne closed OFBIZ-12299. Fix Version/s: Upcoming Branch Resolution: Fixed Push only in trunk yet since some improvment make it not trivial to backport on 18.12. > Jgrowl label are not well retrieved showing 'undefined' button > -- > > Key: OFBIZ-12299 > URL: https://issues.apache.org/jira/browse/OFBIZ-12299 > Project: OFBiz > Issue Type: Bug >Reporter: Gil Portenseigne >Assignee: Gil Portenseigne >Priority: Minor > Fix For: Upcoming Branch > > Attachments: > 0001-Jgrowl-label-are-not-well-retrieved-showing-undefine.patch, > image-2021-08-06-17-01-53-994.png > > > Thanks to Xin Wang comments in https://s.apache.org/trrkk we discover > that label retrieval for json is not working. To easily reproduce checkout > pr/318 and generate some errors : > !image-2021-08-06-17-01-53-994.png! > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-12299) Jgrowl label are not well retrieved showing 'undefined' button
[ https://issues.apache.org/jira/browse/OFBIZ-12299?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17394823#comment-17394823 ] Gil Portenseigne commented on OFBIZ-12299: -- I just join the patch of a fix, i let some time to review before commiting next week if ok. It can be applied above pr/318 to validate the fix. > Jgrowl label are not well retrieved showing 'undefined' button > -- > > Key: OFBIZ-12299 > URL: https://issues.apache.org/jira/browse/OFBIZ-12299 > Project: OFBiz > Issue Type: Bug >Reporter: Gil Portenseigne >Assignee: Gil Portenseigne >Priority: Minor > Attachments: > 0001-Jgrowl-label-are-not-well-retrieved-showing-undefine.patch, > image-2021-08-06-17-01-53-994.png > > > Thanks to Xin Wang comments in https://s.apache.org/trrkk we discover > that label retrieval for json is not working. To easily reproduce checkout > pr/318 and generate some errors : > !image-2021-08-06-17-01-53-994.png! > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OFBIZ-12299) Jgrowl label are not well retrieved showing 'undefined' button
[ https://issues.apache.org/jira/browse/OFBIZ-12299?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gil Portenseigne updated OFBIZ-12299: - Attachment: 0001-Jgrowl-label-are-not-well-retrieved-showing-undefine.patch > Jgrowl label are not well retrieved showing 'undefined' button > -- > > Key: OFBIZ-12299 > URL: https://issues.apache.org/jira/browse/OFBIZ-12299 > Project: OFBiz > Issue Type: Bug >Reporter: Gil Portenseigne >Assignee: Gil Portenseigne >Priority: Minor > Attachments: > 0001-Jgrowl-label-are-not-well-retrieved-showing-undefine.patch, > image-2021-08-06-17-01-53-994.png > > > Thanks to Xin Wang comments in https://s.apache.org/trrkk we discover > that label retrieval for json is not working. To easily reproduce checkout > pr/318 and generate some errors : > !image-2021-08-06-17-01-53-994.png! > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OFBIZ-12299) Jgrowl label are not well retrieved showing 'undefined' button
[ https://issues.apache.org/jira/browse/OFBIZ-12299?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gil Portenseigne updated OFBIZ-12299: - Attachment: (was: image-2021-08-06-16-02-13-516.png) > Jgrowl label are not well retrieved showing 'undefined' button > -- > > Key: OFBIZ-12299 > URL: https://issues.apache.org/jira/browse/OFBIZ-12299 > Project: OFBiz > Issue Type: Bug >Reporter: Gil Portenseigne >Assignee: Gil Portenseigne >Priority: Minor > Attachments: image-2021-08-06-17-01-53-994.png > > > Thanks to Xin Wang comments in https://s.apache.org/trrkk we discover > that label retrieval for json is not working. To easily reproduce checkout > pr/318 and generate some errors : > !image-2021-08-06-17-01-53-994.png! > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (OFBIZ-12299) Jgrowl label are not well retrieved showing 'undefined' button
Gil Portenseigne created OFBIZ-12299: Summary: Jgrowl label are not well retrieved showing 'undefined' button Key: OFBIZ-12299 URL: https://issues.apache.org/jira/browse/OFBIZ-12299 Project: OFBiz Issue Type: Bug Reporter: Gil Portenseigne Assignee: Gil Portenseigne Attachments: image-2021-08-06-17-01-53-994.png Thanks to Xin Wang comments in https://s.apache.org/trrkk we discover that label retrieval for json is not working. To easily reproduce checkout pr/318 and generate some errors : !image-2021-08-06-17-01-53-994.png! -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-12237) Improve rainbowstone theme
[ https://issues.apache.org/jira/browse/OFBIZ-12237?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17370657#comment-17370657 ] Gil Portenseigne commented on OFBIZ-12237: -- meh, LICENCE file was cleaned on my local repo by [~nmalin] :) Found it ! > Improve rainbowstone theme > -- > > Key: OFBIZ-12237 > URL: https://issues.apache.org/jira/browse/OFBIZ-12237 > Project: OFBiz > Issue Type: Improvement > Components: themes >Affects Versions: Trunk >Reporter: Nicolas Malin >Priority: Minor > Attachments: rainbow-new-s.jpg > > > The time changed and so did fashion, so we suggest a facelift for the default > ofbiz theme rainbowstone :) > The work is in progress here > ([https://labs.nereide.fr/10031/Communautaire/-/tree/rainbow-new)] and sure > available soon and for the teasing : !rainbow-new-s.jpg! -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-12237) Improve rainbowstone theme
[ https://issues.apache.org/jira/browse/OFBIZ-12237?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17370654#comment-17370654 ] Gil Portenseigne commented on OFBIZ-12237: -- Your memory is quite well :), ok if i understood well, i will commit the patch deleting woff files, and adding the import to rainbowstone themes. Just a doubt, i do not found the mention of SIL OFL anywhere other than in the readme file from the theme (non LICENCE file), so i guess you were talking about this one. > Improve rainbowstone theme > -- > > Key: OFBIZ-12237 > URL: https://issues.apache.org/jira/browse/OFBIZ-12237 > Project: OFBiz > Issue Type: Improvement > Components: themes >Affects Versions: Trunk >Reporter: Nicolas Malin >Priority: Minor > Attachments: rainbow-new-s.jpg > > > The time changed and so did fashion, so we suggest a facelift for the default > ofbiz theme rainbowstone :) > The work is in progress here > ([https://labs.nereide.fr/10031/Communautaire/-/tree/rainbow-new)] and sure > available soon and for the teasing : !rainbow-new-s.jpg! -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Comment Edited] (OFBIZ-12237) Improve rainbowstone theme
[ https://issues.apache.org/jira/browse/OFBIZ-12237?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17370472#comment-17370472 ] Gil Portenseigne edited comment on OFBIZ-12237 at 6/28/21, 7:49 AM: Hello, About the licence compatibility : [https://www.apache.org/legal/resolved.html] SIL OFL is copyleft, i.e. ask for Improvement and redistribution of modifications. So to be include in our project, is should be included as a binary. In our case, the font is retrieved from the css directly, so not included in the project. So it seems ok to me. Thanks for your feeback Jacques ! was (Author: gil portenseigne): Hello, About the licence compatibility : [https://www.apache.org/legal/resolved.html] SIL OFL is copyleft, i.e. ask for Improvement and redistribution of modifications. So to be include in our project, is should be included as a binary. In our case, the font is retrieved from the css directly, so not included in the project. So it seems ok to me. > Improve rainbowstone theme > -- > > Key: OFBIZ-12237 > URL: https://issues.apache.org/jira/browse/OFBIZ-12237 > Project: OFBiz > Issue Type: Improvement > Components: themes >Affects Versions: Trunk >Reporter: Nicolas Malin >Priority: Minor > Attachments: rainbow-new-s.jpg > > > The time changed and so did fashion, so we suggest a facelift for the default > ofbiz theme rainbowstone :) > The work is in progress here > ([https://labs.nereide.fr/10031/Communautaire/-/tree/rainbow-new)] and sure > available soon and for the teasing : !rainbow-new-s.jpg! -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-12237) Improve rainbowstone theme
[ https://issues.apache.org/jira/browse/OFBIZ-12237?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17370472#comment-17370472 ] Gil Portenseigne commented on OFBIZ-12237: -- Hello, About the licence compatibility : [https://www.apache.org/legal/resolved.html] SIL OFL is copyleft, i.e. ask for Improvement and redistribution of modifications. So to be include in our project, is should be included as a binary. In our case, the font is retrieved from the css directly, so not included in the project. So it seems ok to me. > Improve rainbowstone theme > -- > > Key: OFBIZ-12237 > URL: https://issues.apache.org/jira/browse/OFBIZ-12237 > Project: OFBiz > Issue Type: Improvement > Components: themes >Affects Versions: Trunk >Reporter: Nicolas Malin >Priority: Minor > Attachments: rainbow-new-s.jpg > > > The time changed and so did fashion, so we suggest a facelift for the default > ofbiz theme rainbowstone :) > The work is in progress here > ([https://labs.nereide.fr/10031/Communautaire/-/tree/rainbow-new)] and sure > available soon and for the teasing : !rainbow-new-s.jpg! -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OFBIZ-11812) New child element callback on link to go out information on dynamic navigation from form
[
https://issues.apache.org/jira/browse/OFBIZ-11812?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gil Portenseigne updated OFBIZ-11812:
-
Fix Version/s: Upcoming Branch
> New child element callback on link to go out information on dynamic
> navigation from form
>
>
> Key: OFBIZ-11812
> URL: https://issues.apache.org/jira/browse/OFBIZ-11812
> Project: OFBiz
> Issue Type: Sub-task
> Components: framework/widget
>Affects Versions: Trunk
>Reporter: Nicolas Malin
>Assignee: Gil Portenseigne
>Priority: Major
> Labels: screen, widget
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-11812.patch
>
>
> When a user realize an updating, creation, or run a complex tunneling
> process, if after that you need to refresh a screen area without reload all,
> the action form need to know what it want to update.
> {code:xml}
> target="AddProductStoreToGroup">
>
> ...
> event-type="submit" area-id="centerdiv">
> from-field="productStoreGroup.productStoreGroupId"/>
>
>
> {code}
> This create a dependency between the screen where is displaying information
> and the updating form. Instead create more complicate case to pilot the
> dynamic interaction between the displaying result and the updating action, we
> change the reasoning. A user want a good displaying after his operation is
> finished, so after he terminated his process.
> We introduce a new element, callback on the link. A user start a process in
> general after follow a link, and when is done, we follow the callback to call
> the area to refreah.
> {code:xml}
>
>
>
> from-field="parentProductCategoryId"/>
>
>
> {code}
> With this the developer is concentrate on the start and the end of a process.
> The form or the tunneling process isn't linked to the final screen.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Assigned] (OFBIZ-11812) New child element callback on link to go out information on dynamic navigation from form
[
https://issues.apache.org/jira/browse/OFBIZ-11812?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gil Portenseigne reassigned OFBIZ-11812:
Assignee: Gil Portenseigne
> New child element callback on link to go out information on dynamic
> navigation from form
>
>
> Key: OFBIZ-11812
> URL: https://issues.apache.org/jira/browse/OFBIZ-11812
> Project: OFBiz
> Issue Type: Sub-task
> Components: framework/widget
>Affects Versions: Trunk
>Reporter: Nicolas Malin
>Assignee: Gil Portenseigne
>Priority: Major
> Labels: screen, widget
> Attachments: OFBIZ-11812.patch
>
>
> When a user realize an updating, creation, or run a complex tunneling
> process, if after that you need to refresh a screen area without reload all,
> the action form need to know what it want to update.
> {code:xml}
> target="AddProductStoreToGroup">
>
> ...
> event-type="submit" area-id="centerdiv">
> from-field="productStoreGroup.productStoreGroupId"/>
>
>
> {code}
> This create a dependency between the screen where is displaying information
> and the updating form. Instead create more complicate case to pilot the
> dynamic interaction between the displaying result and the updating action, we
> change the reasoning. A user want a good displaying after his operation is
> finished, so after he terminated his process.
> We introduce a new element, callback on the link. A user start a process in
> general after follow a link, and when is done, we follow the callback to call
> the area to refreah.
> {code:xml}
>
>
>
> from-field="parentProductCategoryId"/>
>
>
> {code}
> With this the developer is concentrate on the start and the end of a process.
> The form or the tunneling process isn't linked to the final screen.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Closed] (OFBIZ-11812) New child element callback on link to go out information on dynamic navigation from form
[
https://issues.apache.org/jira/browse/OFBIZ-11812?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gil Portenseigne closed OFBIZ-11812.
Resolution: Fixed
> New child element callback on link to go out information on dynamic
> navigation from form
>
>
> Key: OFBIZ-11812
> URL: https://issues.apache.org/jira/browse/OFBIZ-11812
> Project: OFBiz
> Issue Type: Sub-task
> Components: framework/widget
>Affects Versions: Trunk
>Reporter: Nicolas Malin
>Assignee: Gil Portenseigne
>Priority: Major
> Labels: screen, widget
> Attachments: OFBIZ-11812.patch
>
>
> When a user realize an updating, creation, or run a complex tunneling
> process, if after that you need to refresh a screen area without reload all,
> the action form need to know what it want to update.
> {code:xml}
> target="AddProductStoreToGroup">
>
> ...
> event-type="submit" area-id="centerdiv">
> from-field="productStoreGroup.productStoreGroupId"/>
>
>
> {code}
> This create a dependency between the screen where is displaying information
> and the updating form. Instead create more complicate case to pilot the
> dynamic interaction between the displaying result and the updating action, we
> change the reasoning. A user want a good displaying after his operation is
> finished, so after he terminated his process.
> We introduce a new element, callback on the link. A user start a process in
> general after follow a link, and when is done, we follow the callback to call
> the area to refreah.
> {code:xml}
>
>
>
> from-field="parentProductCategoryId"/>
>
>
> {code}
> With this the developer is concentrate on the start and the end of a process.
> The form or the tunneling process isn't linked to the final screen.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (OFBIZ-11812) New child element callback on link to go out information on dynamic navigation from form
[
https://issues.apache.org/jira/browse/OFBIZ-11812?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gil Portenseigne updated OFBIZ-11812:
-
Attachment: OFBIZ-11812.patch
> New child element callback on link to go out information on dynamic
> navigation from form
>
>
> Key: OFBIZ-11812
> URL: https://issues.apache.org/jira/browse/OFBIZ-11812
> Project: OFBiz
> Issue Type: Sub-task
> Components: framework/widget
>Affects Versions: Trunk
>Reporter: Nicolas Malin
>Priority: Major
> Labels: screen, widget
> Attachments: OFBIZ-11812.patch
>
>
> When a user realize an updating, creation, or run a complex tunneling
> process, if after that you need to refresh a screen area without reload all,
> the action form need to know what it want to update.
> {code:xml}
> target="AddProductStoreToGroup">
>
> ...
> event-type="submit" area-id="centerdiv">
> from-field="productStoreGroup.productStoreGroupId"/>
>
>
> {code}
> This create a dependency between the screen where is displaying information
> and the updating form. Instead create more complicate case to pilot the
> dynamic interaction between the displaying result and the updating action, we
> change the reasoning. A user want a good displaying after his operation is
> finished, so after he terminated his process.
> We introduce a new element, callback on the link. A user start a process in
> general after follow a link, and when is done, we follow the callback to call
> the area to refreah.
> {code:xml}
>
>
>
> from-field="parentProductCategoryId"/>
>
>
> {code}
> With this the developer is concentrate on the start and the end of a process.
> The form or the tunneling process isn't linked to the final screen.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Comment Edited] (OFBIZ-12259) SeoConfigUtil does not maintaince char-replace-order
[ https://issues.apache.org/jira/browse/OFBIZ-12259?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17367445#comment-17367445 ] Gil Portenseigne edited comment on OFBIZ-12259 at 6/22/21, 3:32 PM: Commited in release18 and trunk, since 17.12.07 is the final release of release17 branch. Thanks was (Author: gil portenseigne): Commited in release18 and trunk, since 17.12.07 is the final released. Thanks > SeoConfigUtil does not maintaince char-replace-order > > > Key: OFBIZ-12259 > URL: https://issues.apache.org/jira/browse/OFBIZ-12259 > Project: OFBiz > Issue Type: Bug >Affects Versions: Release Branch 18.12, Release Branch 17.12, Trunk >Reporter: Ingo Wolfmayr >Assignee: Gil Portenseigne >Priority: Major > Fix For: 18.12.01, Upcoming Branch > > Attachments: ofbiz17x.patch, trunk.patch > > > Replacing chars must be done in the order it is configured in SeoConfig.xml. > If not the generic pattern will replace chars before the defined char filters > are applied. > I created a patch for trunk and version 17.12.x (same for 18.12.x). -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-12259) SeoConfigUtil does not maintaince char-replace-order
[ https://issues.apache.org/jira/browse/OFBIZ-12259?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17367445#comment-17367445 ] Gil Portenseigne commented on OFBIZ-12259: -- Commited in release18 and trunk, since 17.12.07 is the final released. Thanks > SeoConfigUtil does not maintaince char-replace-order > > > Key: OFBIZ-12259 > URL: https://issues.apache.org/jira/browse/OFBIZ-12259 > Project: OFBiz > Issue Type: Bug >Affects Versions: Release Branch 18.12, Release Branch 17.12, Trunk >Reporter: Ingo Wolfmayr >Assignee: Gil Portenseigne >Priority: Major > Fix For: 18.12.01, Upcoming Branch > > Attachments: ofbiz17x.patch, trunk.patch > > > Replacing chars must be done in the order it is configured in SeoConfig.xml. > If not the generic pattern will replace chars before the defined char filters > are applied. > I created a patch for trunk and version 17.12.x (same for 18.12.x). -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Closed] (OFBIZ-12259) SeoConfigUtil does not maintaince char-replace-order
[ https://issues.apache.org/jira/browse/OFBIZ-12259?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gil Portenseigne closed OFBIZ-12259. Resolution: Fixed > SeoConfigUtil does not maintaince char-replace-order > > > Key: OFBIZ-12259 > URL: https://issues.apache.org/jira/browse/OFBIZ-12259 > Project: OFBiz > Issue Type: Bug >Affects Versions: Release Branch 18.12, Release Branch 17.12, Trunk >Reporter: Ingo Wolfmayr >Assignee: Gil Portenseigne >Priority: Major > Fix For: 18.12.01, Upcoming Branch > > Attachments: ofbiz17x.patch, trunk.patch > > > Replacing chars must be done in the order it is configured in SeoConfig.xml. > If not the generic pattern will replace chars before the defined char filters > are applied. > I created a patch for trunk and version 17.12.x (same for 18.12.x). -- This message was sent by Atlassian Jira (v8.3.4#803005)
