[jira] [Commented] (OFBIZ-9572) Replace all "BigDecimal ZERO" by BigDecimal.ZERO
[ https://issues.apache.org/jira/browse/OFBIZ-9572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16125805#comment-16125805 ] Gil Portenseigne commented on OFBIZ-9572: - +1 on removing variable declaration and using BigDecimal.ZERO. On the setScale part, i find it awkward to define it on the class variable, or on the ZERO value... In any case, the setScale must be used when returning BigDecimal value from a method/service. > Replace all "BigDecimal ZERO" by BigDecimal.ZERO > > > Key: OFBIZ-9572 > URL: https://issues.apache.org/jira/browse/OFBIZ-9572 > Project: OFBiz > Issue Type: Improvement >Reporter: Jacques Le Roux > > Using "BigDecimal ZERO" instead of BigDecimal.ZERO does not add anything but > more useless code. They are both constants and the compiler will made them so. > This should not be done when setScale() is used on the ZERO constant -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Comment Edited] (OFBIZ-9572) Replace all "BigDecimal ZERO" by BigDecimal.ZERO
[ https://issues.apache.org/jira/browse/OFBIZ-9572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16125805#comment-16125805 ] Gil Portenseigne edited comment on OFBIZ-9572 at 8/14/17 3:30 PM: -- +1 on removing variable declaration and using BigDecimal.ZERO. On the setScale part, i find it awkward to define it on the class variable (=> FinAccountHelper.java), or on the ZERO value... In any case, the setScale must be used when returning BigDecimal value from a method/service. was (Author: gil portenseigne): +1 on removing variable declaration and using BigDecimal.ZERO. On the setScale part, i find it awkward to define it on the class variable, or on the ZERO value... In any case, the setScale must be used when returning BigDecimal value from a method/service. > Replace all "BigDecimal ZERO" by BigDecimal.ZERO > > > Key: OFBIZ-9572 > URL: https://issues.apache.org/jira/browse/OFBIZ-9572 > Project: OFBiz > Issue Type: Improvement >Reporter: Jacques Le Roux > > Using "BigDecimal ZERO" instead of BigDecimal.ZERO does not add anything but > more useless code. They are both constants and the compiler will made them so. > This should not be done when setScale() is used on the ZERO constant -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Created] (OFBIZ-9662) Header links in OFBiz new website seems broken
Gil Portenseigne created OFBIZ-9662: --- Summary: Header links in OFBiz new website seems broken Key: OFBIZ-9662 URL: https://issues.apache.org/jira/browse/OFBIZ-9662 Project: OFBiz Issue Type: Bug Environment: Firefox 55.0.2 (64 bits) Chrome : Version 60.0.3112.90 (Build officiel) (64 bits) Reporter: Gil Portenseigne -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (OFBIZ-9662) Header links in OFBiz new website seems broken
[ https://issues.apache.org/jira/browse/OFBIZ-9662?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gil Portenseigne updated OFBIZ-9662: Description: I cannot see carrousel, i cannot see the drop-down, even after clearing all caches and even changing firefox profile to a new one (to avoid addon issue). > Header links in OFBiz new website seems broken > -- > > Key: OFBIZ-9662 > URL: https://issues.apache.org/jira/browse/OFBIZ-9662 > Project: OFBiz > Issue Type: Bug > Environment: Firefox 55.0.2 (64 bits) > Chrome : Version 60.0.3112.90 (Build officiel) (64 bits) >Reporter: Gil Portenseigne > Attachments: screenshot-1.png > > > I cannot see carrousel, i cannot see the drop-down, even after clearing all > caches and even changing firefox profile to a new one (to avoid addon issue). -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (OFBIZ-9662) Header links in OFBiz new website seems broken
[ https://issues.apache.org/jira/browse/OFBIZ-9662?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gil Portenseigne updated OFBIZ-9662: Attachment: screenshot-1.png > Header links in OFBiz new website seems broken > -- > > Key: OFBIZ-9662 > URL: https://issues.apache.org/jira/browse/OFBIZ-9662 > Project: OFBiz > Issue Type: Bug > Environment: Firefox 55.0.2 (64 bits) > Chrome : Version 60.0.3112.90 (Build officiel) (64 bits) >Reporter: Gil Portenseigne > Attachments: screenshot-1.png > > > I cannot see carrousel, i cannot see the drop-down, even after clearing all > caches and even changing firefox profile to a new one (to avoid addon issue). -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (OFBIZ-9662) Header links in OFBiz new website seems broken
[ https://issues.apache.org/jira/browse/OFBIZ-9662?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16144961#comment-16144961 ] Gil Portenseigne commented on OFBIZ-9662: - !screenshot-1.png! There is the strange behaviour, there must be an issue somewhere, i'm investigating my local config... When i tested before the publication, i didnt see any issue > Header links in OFBiz new website seems broken > -- > > Key: OFBIZ-9662 > URL: https://issues.apache.org/jira/browse/OFBIZ-9662 > Project: OFBiz > Issue Type: Bug > Environment: Firefox 55.0.2 (64 bits) > Chrome : Version 60.0.3112.90 (Build officiel) (64 bits) >Reporter: Gil Portenseigne > Attachments: screenshot-1.png > > > I cannot see carrousel, i cannot see the drop-down, even after clearing all > caches and even changing firefox profile to a new one (to avoid addon issue). -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (OFBIZ-9662) Header links in OFBiz new website seems broken
[ https://issues.apache.org/jira/browse/OFBIZ-9662?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16144971#comment-16144971 ] Gil Portenseigne commented on OFBIZ-9662: - Tried it on Windows on another PC with internet explorer :D, same issue. After forcing refresh, i got a message like : Site only display secure data. I said I want to display unsecure, and got it working... (writing it down from my memory so not accurate) > Header links in OFBiz new website seems broken > -- > > Key: OFBIZ-9662 > URL: https://issues.apache.org/jira/browse/OFBIZ-9662 > Project: OFBiz > Issue Type: Bug > Environment: Firefox 55.0.2 (64 bits) > Chrome : Version 60.0.3112.90 (Build officiel) (64 bits) >Reporter: Gil Portenseigne > Attachments: screenshot-1.png > > > I cannot see carrousel, i cannot see the drop-down, even after clearing all > caches and even changing firefox profile to a new one (to avoid addon issue). -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (OFBIZ-9662) Header links in OFBiz new website seems broken
[ https://issues.apache.org/jira/browse/OFBIZ-9662?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16144974#comment-16144974 ] Gil Portenseigne commented on OFBIZ-9662: - Indeed the issue appears on : https://ofbiz.apache.org/ and not on http://ofbiz.apache.org/ > Header links in OFBiz new website seems broken > -- > > Key: OFBIZ-9662 > URL: https://issues.apache.org/jira/browse/OFBIZ-9662 > Project: OFBiz > Issue Type: Bug > Environment: Firefox 55.0.2 (64 bits) > Chrome : Version 60.0.3112.90 (Build officiel) (64 bits) >Reporter: Gil Portenseigne > Attachments: screenshot-1.png > > > I cannot see carrousel, i cannot see the drop-down, even after clearing all > caches and even changing firefox profile to a new one (to avoid addon issue). -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (OFBIZ-9662) Header links in OFBiz new website seems broken
[ https://issues.apache.org/jira/browse/OFBIZ-9662?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16144983#comment-16144983 ] Gil Portenseigne commented on OFBIZ-9662: - There must be unsecure content : https://support.mozilla.org/en-US/kb/mixed-content-blocking-firefox I just did an ssl check with these results : Done. Total pages crawled: 10 Pages with unsecure content: https://ofbiz.apache.org/ ? https://ofbiz.apache.org/index.html ? https://ofbiz.apache.org/source-repositories.html ? https://ofbiz.apache.org/mailing-lists.html ? https://ofbiz.apache.org/business-users.html ? https://ofbiz.apache.org/developers.html ? https://ofbiz.apache.org/getting-involved.html ? https://ofbiz.apache.org/download.html ? https://ofbiz.apache.org/faqs.html ? https://ofbiz.apache.org/ofbiz-demos.html ? > Header links in OFBiz new website seems broken > -- > > Key: OFBIZ-9662 > URL: https://issues.apache.org/jira/browse/OFBIZ-9662 > Project: OFBiz > Issue Type: Bug > Environment: Firefox 55.0.2 (64 bits) > Chrome : Version 60.0.3112.90 (Build officiel) (64 bits) >Reporter: Gil Portenseigne > Attachments: screenshot-1.png > > > I cannot see carrousel, i cannot see the drop-down, even after clearing all > caches and even changing firefox profile to a new one (to avoid addon issue). -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (OFBIZ-9662) Header links in OFBiz new website seems broken
[ https://issues.apache.org/jira/browse/OFBIZ-9662?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16145071#comment-16145071 ] Gil Portenseigne commented on OFBIZ-9662: - Looking with chrome console : Mixed Content: The page at 'https://ofbiz.apache.org/' was loaded over HTTPS, but requested an insecure stylesheet 'http://fonts.googleapis.com/css?family=Open+Sans:400,300,800'. This request has been blocked; the content must be served over HTTPS. (index):1 Mixed Content: The page at 'https://ofbiz.apache.org/' was loaded over HTTPS, but requested an insecure script 'http://ajax.googleapis.com/ajax/libs/jquery/1.8.2/jquery.min.js'. This request has been blocked; the content must be served over HTTPS. Here lies the issue, [~deepak.dixit], i didn't know about your way to fix the issue, thanks :) > Header links in OFBiz new website seems broken > -- > > Key: OFBIZ-9662 > URL: https://issues.apache.org/jira/browse/OFBIZ-9662 > Project: OFBiz > Issue Type: Bug > Environment: Firefox 55.0.2 (64 bits) > Chrome : Version 60.0.3112.90 (Build officiel) (64 bits) >Reporter: Gil Portenseigne > Attachments: screenshot-1.png > > > I cannot see carrousel, i cannot see the drop-down, even after clearing all > caches and even changing firefox profile to a new one (to avoid addon issue). -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Resolved] (OFBIZ-9662) Header links in OFBiz new website seems broken
[ https://issues.apache.org/jira/browse/OFBIZ-9662?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gil Portenseigne resolved OFBIZ-9662. - Resolution: Fixed > Header links in OFBiz new website seems broken > -- > > Key: OFBIZ-9662 > URL: https://issues.apache.org/jira/browse/OFBIZ-9662 > Project: OFBiz > Issue Type: Bug > Environment: Firefox 55.0.2 (64 bits) > Chrome : Version 60.0.3112.90 (Build officiel) (64 bits) >Reporter: Gil Portenseigne > Attachments: screenshot-1.png > > > I cannot see carrousel, i cannot see the drop-down, even after clearing all > caches and even changing firefox profile to a new one (to avoid addon issue). -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (OFBIZ-9662) Header links in OFBiz new website seems broken
[ https://issues.apache.org/jira/browse/OFBIZ-9662?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16145465#comment-16145465 ] Gil Portenseigne commented on OFBIZ-9662: - Thanks all, i will close this JIRA, since it's working now :) +1 [~toashishvijay] for the redirect rule > Header links in OFBiz new website seems broken > -- > > Key: OFBIZ-9662 > URL: https://issues.apache.org/jira/browse/OFBIZ-9662 > Project: OFBiz > Issue Type: Bug > Environment: Firefox 55.0.2 (64 bits) > Chrome : Version 60.0.3112.90 (Build officiel) (64 bits) >Reporter: Gil Portenseigne > Attachments: screenshot-1.png > > > I cannot see carrousel, i cannot see the drop-down, even after clearing all > caches and even changing firefox profile to a new one (to avoid addon issue). -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Closed] (OFBIZ-9662) Header links in OFBiz new website seems broken
[ https://issues.apache.org/jira/browse/OFBIZ-9662?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gil Portenseigne closed OFBIZ-9662. --- > Header links in OFBiz new website seems broken > -- > > Key: OFBIZ-9662 > URL: https://issues.apache.org/jira/browse/OFBIZ-9662 > Project: OFBiz > Issue Type: Bug > Environment: Firefox 55.0.2 (64 bits) > Chrome : Version 60.0.3112.90 (Build officiel) (64 bits) >Reporter: Gil Portenseigne > Attachments: screenshot-1.png > > > I cannot see carrousel, i cannot see the drop-down, even after clearing all > caches and even changing firefox profile to a new one (to avoid addon issue). -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (OFBIZ-9662) Header links in OFBiz new website seems broken
[ https://issues.apache.org/jira/browse/OFBIZ-9662?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16146702#comment-16146702 ] Gil Portenseigne commented on OFBIZ-9662: - Hi Jacques, the idea is to redirect to https protocol any user trying to join http://ofbiz.apache.org/.* with http. The question is why letting access throught http when https is available and working :) ? > Header links in OFBiz new website seems broken > -- > > Key: OFBIZ-9662 > URL: https://issues.apache.org/jira/browse/OFBIZ-9662 > Project: OFBiz > Issue Type: Bug > Environment: Firefox 55.0.2 (64 bits) > Chrome : Version 60.0.3112.90 (Build officiel) (64 bits) >Reporter: Gil Portenseigne > Attachments: screenshot-1.png > > > I cannot see carrousel, i cannot see the drop-down, even after clearing all > caches and even changing firefox profile to a new one (to avoid addon issue). -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (OFBIZ-9662) Header links in OFBiz new website seems broken
[ https://issues.apache.org/jira/browse/OFBIZ-9662?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16147017#comment-16147017 ] Gil Portenseigne commented on OFBIZ-9662: - I'm discovering HTST, and while doing it, i see no issue with using it instead of simple redirection, since it seems to protect from some attacks that redirection do not... > Header links in OFBiz new website seems broken > -- > > Key: OFBIZ-9662 > URL: https://issues.apache.org/jira/browse/OFBIZ-9662 > Project: OFBiz > Issue Type: Bug > Environment: Firefox 55.0.2 (64 bits) > Chrome : Version 60.0.3112.90 (Build officiel) (64 bits) >Reporter: Gil Portenseigne > Attachments: screenshot-1.png > > > I cannot see carrousel, i cannot see the drop-down, even after clearing all > caches and even changing firefox profile to a new one (to avoid addon issue). -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (OFBIZ-9800) French translation of ofbizwebsitre
[ https://issues.apache.org/jira/browse/OFBIZ-9800?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16191690#comment-16191690 ] Gil Portenseigne commented on OFBIZ-9800: - Hello Guys, [~jacques.le.roux] i tend to agree with your opinion. I'd rather start *simple* with two pages for the two kind of audience, to show that there is a french community around there :), to ease OFBiz access to French people that are not comfortable with english. Yet I'm not against an complete translation... I remember reading that the technology beneath the website might be going to change to freemarker, we surely have to redo the job, not a big deal though. I haven't seen any mail in dev/user ML about website translation ? Could it be a better place for this discussion to touch more people and gather more opinions/contributions ? Anyway, thanks for the initiative [~holivier] ! > French translation of ofbizwebsitre > --- > > Key: OFBIZ-9800 > URL: https://issues.apache.org/jira/browse/OFBIZ-9800 > Project: OFBiz > Issue Type: Improvement > Components: site >Reporter: Olivier Heintz >Priority: Minor > Attachments: 404.tpl.php, developers.html, developers.tpl.php, > getting-involved.html, getting-involved.tpl.php, header.tpl.php, > head.tpl.php, index.html, index.tpl.php, mailing-lists.html, > mailing-lists.tpl.php, scripts.tpl.php, source-repositories.html, > source-repositories.tpl.php > > > To evaluate the workload of translate all the ofbiz website page in french, > and so to maintain the translation when there are some modifications, I have > start to translate them. > There are between 10 and 15 page to translate, and translate one is between 1 > and 2 hours. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (OFBIZ-9800) French translation of OFBiz website
[ https://issues.apache.org/jira/browse/OFBIZ-9800?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gil Portenseigne updated OFBIZ-9800: Summary: French translation of OFBiz website (was: French translation of ofbizwebsitre) > French translation of OFBiz website > --- > > Key: OFBIZ-9800 > URL: https://issues.apache.org/jira/browse/OFBIZ-9800 > Project: OFBiz > Issue Type: Improvement > Components: site >Reporter: Olivier Heintz >Priority: Minor > Attachments: 404.tpl.php, developers.html, developers.tpl.php, > getting-involved.html, getting-involved.tpl.php, header.tpl.php, > head.tpl.php, index.html, index.tpl.php, mailing-lists.html, > mailing-lists.tpl.php, scripts.tpl.php, source-repositories.html, > source-repositories.tpl.php > > > To evaluate the workload of translate all the ofbiz website page in french, > and so to maintain the translation when there are some modifications, I have > start to translate them. > There are between 10 and 15 page to translate, and translate one is between 1 > and 2 hours. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (OFBIZ-9800) French translation of OFBiz website
[ https://issues.apache.org/jira/browse/OFBIZ-9800?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16193380#comment-16193380 ] Gil Portenseigne commented on OFBIZ-9800: - Woops indeed thanks Jacques ! > French translation of OFBiz website > --- > > Key: OFBIZ-9800 > URL: https://issues.apache.org/jira/browse/OFBIZ-9800 > Project: OFBiz > Issue Type: Improvement > Components: site >Reporter: Olivier Heintz >Priority: Minor > Attachments: 404.tpl.php, developers.html, developers.tpl.php, > getting-involved.html, getting-involved.tpl.php, header.tpl.php, > head.tpl.php, index.html, index.tpl.php, mailing-lists.html, > mailing-lists.tpl.php, scripts.tpl.php, source-repositories.html, > source-repositories.tpl.php > > > To evaluate the workload of translate all the ofbiz website page in french, > and so to maintain the translation when there are some modifications, I have > start to translate them. > There are between 10 and 15 page to translate, and translate one is between 1 > and 2 hours. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Created] (OFBIZ-10181) When completing communicationEvent through setCommEventComplete, if datetimeEnded is null, set it to nowTimestamp
Gil Portenseigne created OFBIZ-10181: Summary: When completing communicationEvent through setCommEventComplete, if datetimeEnded is null, set it to nowTimestamp Key: OFBIZ-10181 URL: https://issues.apache.org/jira/browse/OFBIZ-10181 Project: OFBiz Issue Type: Improvement Affects Versions: Upcoming Branch Reporter: Gil Portenseigne Assignee: Gil Portenseigne When completing communicationEvent through setCommEventComplete, if datetimeEnded is null, set it to nowTimestamp. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OFBIZ-10181) When completing communicationEvent through setCommEventComplete, if datetimeEnded is null, set it to nowTimestamp
[ https://issues.apache.org/jira/browse/OFBIZ-10181?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gil Portenseigne updated OFBIZ-10181: - Attachment: OFBIZ-10181.patch > When completing communicationEvent through setCommEventComplete, if > datetimeEnded is null, set it to nowTimestamp > - > > Key: OFBIZ-10181 > URL: https://issues.apache.org/jira/browse/OFBIZ-10181 > Project: OFBiz > Issue Type: Improvement >Affects Versions: Upcoming Branch >Reporter: Gil Portenseigne >Assignee: Gil Portenseigne >Priority: Minor > Attachments: OFBIZ-10181.patch > > > When completing communicationEvent through setCommEventComplete, if > datetimeEnded is null, set it to nowTimestamp. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Closed] (OFBIZ-10181) When completing communicationEvent through setCommEventComplete, if datetimeEnded is null, set it to nowTimestamp
[ https://issues.apache.org/jira/browse/OFBIZ-10181?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gil Portenseigne closed OFBIZ-10181. > When completing communicationEvent through setCommEventComplete, if > datetimeEnded is null, set it to nowTimestamp > - > > Key: OFBIZ-10181 > URL: https://issues.apache.org/jira/browse/OFBIZ-10181 > Project: OFBiz > Issue Type: Improvement >Affects Versions: Upcoming Branch >Reporter: Gil Portenseigne >Assignee: Gil Portenseigne >Priority: Minor > Fix For: Upcoming Branch > > Attachments: OFBIZ-10181.patch > > > When completing communicationEvent through setCommEventComplete, if > datetimeEnded is null, set it to nowTimestamp. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (OFBIZ-10188) Add new FileUtil methods for zip management
Gil Portenseigne created OFBIZ-10188: Summary: Add new FileUtil methods for zip management Key: OFBIZ-10188 URL: https://issues.apache.org/jira/browse/OFBIZ-10188 Project: OFBiz Issue Type: New Feature Reporter: Gil Portenseigne Assignee: Gil Portenseigne Fix For: Upcoming Branch Add new FileUtil methods for zip management. Add zipFileStream method that will zip FileStream to a zipped one. Add unzipFileToFolder method to unzip a given archive to a given Folder -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OFBIZ-10188) Add new FileUtil methods for zip management
[ https://issues.apache.org/jira/browse/OFBIZ-10188?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gil Portenseigne updated OFBIZ-10188: - Attachment: OFBIZ-10188.patch > Add new FileUtil methods for zip management > --- > > Key: OFBIZ-10188 > URL: https://issues.apache.org/jira/browse/OFBIZ-10188 > Project: OFBiz > Issue Type: New Feature >Reporter: Gil Portenseigne >Assignee: Gil Portenseigne >Priority: Minor > Fix For: Upcoming Branch > > Attachments: OFBIZ-10188.patch > > > Add new FileUtil methods for zip management. > Add zipFileStream method that will zip FileStream to a zipped one. > Add unzipFileToFolder method to unzip a given archive to a given Folder -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10188) Add new FileUtil methods for zip management
[ https://issues.apache.org/jira/browse/OFBIZ-10188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16345033#comment-16345033 ] Gil Portenseigne commented on OFBIZ-10188: -- I did write down a groovy test that zip README.md to runtime/tmp directory, then unzip it and compare resulting file with original one. Any feedback is welcome, i will commit it in a few days, if not objection > Add new FileUtil methods for zip management > --- > > Key: OFBIZ-10188 > URL: https://issues.apache.org/jira/browse/OFBIZ-10188 > Project: OFBiz > Issue Type: New Feature >Reporter: Gil Portenseigne >Assignee: Gil Portenseigne >Priority: Minor > Fix For: Upcoming Branch > > Attachments: OFBIZ-10188.patch > > > Add new FileUtil methods for zip management. > Add zipFileStream method that will zip FileStream to a zipped one. > Add unzipFileToFolder method to unzip a given archive to a given Folder -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10188) Add new FileUtil methods for zip management
[ https://issues.apache.org/jira/browse/OFBIZ-10188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16346384#comment-16346384 ] Gil Portenseigne commented on OFBIZ-10188: -- Thanks Jacques for the review, For formatting issues, i will use IDE formatting tool and republish the patch :) About the exception, indeed there are handled by the testing system, so no need to catch these within the test, i guess. (Thanks for the links) For the closing streams I double checked, no issue detected. > Add new FileUtil methods for zip management > --- > > Key: OFBIZ-10188 > URL: https://issues.apache.org/jira/browse/OFBIZ-10188 > Project: OFBiz > Issue Type: New Feature >Reporter: Gil Portenseigne >Assignee: Gil Portenseigne >Priority: Minor > Fix For: Upcoming Branch > > Attachments: OFBIZ-10188.patch > > > Add new FileUtil methods for zip management. > Add zipFileStream method that will zip FileStream to a zipped one. > Add unzipFileToFolder method to unzip a given archive to a given Folder -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OFBIZ-10188) Add new FileUtil methods for zip management
[ https://issues.apache.org/jira/browse/OFBIZ-10188?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gil Portenseigne updated OFBIZ-10188: - Attachment: OFBIZ_10188.patch > Add new FileUtil methods for zip management > --- > > Key: OFBIZ-10188 > URL: https://issues.apache.org/jira/browse/OFBIZ-10188 > Project: OFBiz > Issue Type: New Feature >Reporter: Gil Portenseigne >Assignee: Gil Portenseigne >Priority: Minor > Fix For: Upcoming Branch > > Attachments: OFBIZ-10188.patch, OFBIZ_10188.patch > > > Add new FileUtil methods for zip management. > Add zipFileStream method that will zip FileStream to a zipped one. > Add unzipFileToFolder method to unzip a given archive to a given Folder -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (OFBIZ-10195) Add the ability in performFind service to set OR search criteria
Gil Portenseigne created OFBIZ-10195: Summary: Add the ability in performFind service to set OR search criteria Key: OFBIZ-10195 URL: https://issues.apache.org/jira/browse/OFBIZ-10195 Project: OFBiz Issue Type: Improvement Reporter: Gil Portenseigne Assignee: Gil Portenseigne Fix For: Upcoming Branch When using performFind service for advanced entity search, we can meet the need to have search criteria that do not intersect between them, but make the union of the condition. To realize this improvement we propose to set a new suffix _grp. Thus using : Then the two search fields criteria will be unioned during the search by the OR operator. Several different keys can be used for several different unioned condition. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OFBIZ-10195) Add the ability in performFind service to set OR search criteria
[ https://issues.apache.org/jira/browse/OFBIZ-10195?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gil Portenseigne updated OFBIZ-10195: - Attachment: OFBIZ-10195.patch > Add the ability in performFind service to set OR search criteria > > > Key: OFBIZ-10195 > URL: https://issues.apache.org/jira/browse/OFBIZ-10195 > Project: OFBiz > Issue Type: Improvement >Reporter: Gil Portenseigne >Assignee: Gil Portenseigne >Priority: Minor > Fix For: Upcoming Branch > > Attachments: OFBIZ-10195.patch > > > When using performFind service for advanced entity search, we can meet the > need to have search criteria that do not intersect between them, but make the > union of the condition. > To realize this improvement we propose to set a new suffix _grp. > Thus using : > > > > > Then the two search fields criteria will be unioned during the search by the > OR operator. > Several different keys can be used for several different unioned condition. > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-9498) Improve DevOps using environment variable configuration
[ https://issues.apache.org/jira/browse/OFBIZ-9498?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16348773#comment-16348773 ] Gil Portenseigne commented on OFBIZ-9498: - Hi Jacques, we are still using it in our project but we haven't progress on the matter... I planned to analyse template system with gradle as discussed with Taher and Michael, but that's bottom my prio list :). > Improve DevOps using environment variable configuration > --- > > Key: OFBIZ-9498 > URL: https://issues.apache.org/jira/browse/OFBIZ-9498 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk >Reporter: Gil Portenseigne >Assignee: Gil Portenseigne >Priority: Minor > Attachments: OFBIZ-9498.patch > > > Discussed in thread : https://s.apache.org/Mh3q > This Jira will present the improvment proposal giving a way to configure > OFBiz using environment variable. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Comment Edited] (OFBIZ-9498) Improve DevOps using environment variable configuration
[ https://issues.apache.org/jira/browse/OFBIZ-9498?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16348773#comment-16348773 ] Gil Portenseigne edited comment on OFBIZ-9498 at 2/1/18 4:41 PM: - Hi Jacques, we are still using it in our project but we haven't progress on the matter... I planned to analyse template system with gradle as discussed with Taher and Michael, but that's low my prio list :). was (Author: gil portenseigne): Hi Jacques, we are still using it in our project but we haven't progress on the matter... I planned to analyse template system with gradle as discussed with Taher and Michael, but that's bottom my prio list :). > Improve DevOps using environment variable configuration > --- > > Key: OFBIZ-9498 > URL: https://issues.apache.org/jira/browse/OFBIZ-9498 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk >Reporter: Gil Portenseigne >Assignee: Gil Portenseigne >Priority: Minor > Attachments: OFBIZ-9498.patch > > > Discussed in thread : https://s.apache.org/Mh3q > This Jira will present the improvment proposal giving a way to configure > OFBiz using environment variable. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10188) Add new FileUtil methods for zip management
[
https://issues.apache.org/jira/browse/OFBIZ-10188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16350029#comment-16350029
]
Gil Portenseigne commented on OFBIZ-10188:
--
zos.setLevel(9) can be rewritten to
zos.setLevel(Deflater.{color:#9876aa}BEST_COMPRESSION{color}){color:#cc7832};
{color:#33}That will be clearer :), and the choice was made to optimize the
size of data. No strong opinion here either.{color}{color}
{color:#cc7832}{color:#33}Ok for the new byte[8192], thanks for the link, i
did some search about this and agree with you increasing the size of the buffer
!{color}{color}
{color:#cc7832} {color}
> Add new FileUtil methods for zip management
> ---
>
> Key: OFBIZ-10188
> URL: https://issues.apache.org/jira/browse/OFBIZ-10188
> Project: OFBiz
> Issue Type: New Feature
>Reporter: Gil Portenseigne
>Assignee: Gil Portenseigne
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-10188.patch, OFBIZ_10188.patch
>
>
> Add new FileUtil methods for zip management.
> Add zipFileStream method that will zip FileStream to a zipped one.
> Add unzipFileToFolder method to unzip a given archive to a given Folder
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Comment Edited] (OFBIZ-10188) Add new FileUtil methods for zip management
[
https://issues.apache.org/jira/browse/OFBIZ-10188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16350029#comment-16350029
]
Gil Portenseigne edited comment on OFBIZ-10188 at 2/2/18 9:29 AM:
--
zos.setLevel(9) can be rewritten to
zos.setLevel(Deflater.{color:#9876aa}BEST_COMPRESSION{color}){color:#cc7832};
That will be clearer :), and the choice was made to optimize the size of data.
No strong opinion here either.
Ok for the new byte[8192], thanks for the link, i did some search about this
and agree with you increasing the size of the buffer !
was (Author: gil portenseigne):
zos.setLevel(9) can be rewritten to
zos.setLevel(Deflater.{color:#9876aa}BEST_COMPRESSION{color}){color:#cc7832};
{color:#33}That will be clearer :), and the choice was made to optimize the
size of data. No strong opinion here either.{color}{color}
{color:#cc7832}{color:#33}Ok for the new byte[8192], thanks for the link, i
did some search about this and agree with you increasing the size of the buffer
!{color}{color}
{color:#cc7832} {color}
> Add new FileUtil methods for zip management
> ---
>
> Key: OFBIZ-10188
> URL: https://issues.apache.org/jira/browse/OFBIZ-10188
> Project: OFBiz
> Issue Type: New Feature
>Reporter: Gil Portenseigne
>Assignee: Gil Portenseigne
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-10188.patch, OFBIZ_10188.patch
>
>
> Add new FileUtil methods for zip management.
> Add zipFileStream method that will zip FileStream to a zipped one.
> Add unzipFileToFolder method to unzip a given archive to a given Folder
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (OFBIZ-10188) Add new FileUtil methods for zip management
[ https://issues.apache.org/jira/browse/OFBIZ-10188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16350494#comment-16350494 ] Gil Portenseigne commented on OFBIZ-10188: -- Sure, i forgot to say yes :) > Add new FileUtil methods for zip management > --- > > Key: OFBIZ-10188 > URL: https://issues.apache.org/jira/browse/OFBIZ-10188 > Project: OFBiz > Issue Type: New Feature >Reporter: Gil Portenseigne >Assignee: Gil Portenseigne >Priority: Minor > Fix For: Upcoming Branch > > Attachments: OFBIZ-10188.patch, OFBIZ_10188.patch > > > Add new FileUtil methods for zip management. > Add zipFileStream method that will zip FileStream to a zipped one. > Add unzipFileToFolder method to unzip a given archive to a given Folder -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Comment Edited] (OFBIZ-10188) Add new FileUtil methods for zip management
[ https://issues.apache.org/jira/browse/OFBIZ-10188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16350494#comment-16350494 ] Gil Portenseigne edited comment on OFBIZ-10188 at 2/8/18 10:28 AM: --- Actually, i'm not sure about the added value of getting a file system property from database... was (Author: gil portenseigne): Sure, i forgot to say yes :) > Add new FileUtil methods for zip management > --- > > Key: OFBIZ-10188 > URL: https://issues.apache.org/jira/browse/OFBIZ-10188 > Project: OFBiz > Issue Type: New Feature >Reporter: Gil Portenseigne >Assignee: Gil Portenseigne >Priority: Minor > Fix For: Upcoming Branch > > Attachments: OFBIZ-10188.patch, OFBIZ_10188.patch > > > Add new FileUtil methods for zip management. > Add zipFileStream method that will zip FileStream to a zipped one. > Add unzipFileToFolder method to unzip a given archive to a given Folder -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Closed] (OFBIZ-10188) Add new FileUtil methods for zip management
[ https://issues.apache.org/jira/browse/OFBIZ-10188?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gil Portenseigne closed OFBIZ-10188. > Add new FileUtil methods for zip management > --- > > Key: OFBIZ-10188 > URL: https://issues.apache.org/jira/browse/OFBIZ-10188 > Project: OFBiz > Issue Type: New Feature >Reporter: Gil Portenseigne >Assignee: Gil Portenseigne >Priority: Minor > Fix For: Upcoming Branch > > Attachments: OFBIZ-10188.patch, OFBIZ_10188.patch > > > Add new FileUtil methods for zip management. > Add zipFileStream method that will zip FileStream to a zipped one. > Add unzipFileToFolder method to unzip a given archive to a given Folder -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10188) Add new FileUtil methods for zip management
[
https://issues.apache.org/jira/browse/OFBIZ-10188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16357073#comment-16357073
]
Gil Portenseigne commented on OFBIZ-10188:
--
Ooops, sorry Michael to have closed the Jira, i miss your comment :)
I think that Jacques explains that {{EntityUtilProperties}} needs delegator as
a mandatory additional parameters, that will lead to have it on the calling
method...
> Add new FileUtil methods for zip management
> ---
>
> Key: OFBIZ-10188
> URL: https://issues.apache.org/jira/browse/OFBIZ-10188
> Project: OFBiz
> Issue Type: New Feature
>Reporter: Gil Portenseigne
>Assignee: Gil Portenseigne
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-10188.patch, OFBIZ_10188.patch
>
>
> Add new FileUtil methods for zip management.
> Add zipFileStream method that will zip FileStream to a zipped one.
> Add unzipFileToFolder method to unzip a given archive to a given Folder
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (OFBIZ-10195) Add the ability in performFind service to set OR search criteria
[
https://issues.apache.org/jira/browse/OFBIZ-10195?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16366699#comment-16366699
]
Gil Portenseigne commented on OFBIZ-10195:
--
Hello,
I completed the implementation like in [~taher]'s proposal :
[diff|[https://labs.nereide.fr/10031/Communautaire/compare/trunk...OFBIZ-10195]]
I made the choice to get the group-condition on every search-field widget
instead of on field level :
{code:java}
{code}
Let me know what you think about it :)
> Add the ability in performFind service to set OR search criteria
>
>
> Key: OFBIZ-10195
> URL: https://issues.apache.org/jira/browse/OFBIZ-10195
> Project: OFBiz
> Issue Type: Improvement
>Reporter: Gil Portenseigne
>Assignee: Gil Portenseigne
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-10195.patch
>
>
> When using performFind service for advanced entity search, we can meet the
> need to have search criteria that do not intersect between them, but make the
> union of the condition.
> To realize this improvement we propose to set a new suffix _grp.
> Thus using :
>
>
>
>
> Then the two search fields criteria will be unioned during the search by the
> OR operator.
> Several different keys can be used for several different unioned condition.
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (OFBIZ-10195) Add the ability in performFind service to set OR search criteria
[ https://issues.apache.org/jira/browse/OFBIZ-10195?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gil Portenseigne updated OFBIZ-10195: - Attachment: OFBIZ-10195.patch > Add the ability in performFind service to set OR search criteria > > > Key: OFBIZ-10195 > URL: https://issues.apache.org/jira/browse/OFBIZ-10195 > Project: OFBiz > Issue Type: Improvement >Reporter: Gil Portenseigne >Assignee: Gil Portenseigne >Priority: Minor > Fix For: Upcoming Branch > > Attachments: OFBIZ-10195.patch, OFBIZ-10195.patch > > > When using performFind service for advanced entity search, we can meet the > need to have search criteria that do not intersect between them, but make the > union of the condition. > To realize this improvement we propose to set a new suffix _grp. > Thus using : > > > > > Then the two search fields criteria will be unioned during the search by the > OR operator. > Several different keys can be used for several different unioned condition. > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (OFBIZ-10224) Add a way to add a specific condition to performFind service
Gil Portenseigne created OFBIZ-10224: Summary: Add a way to add a specific condition to performFind service Key: OFBIZ-10224 URL: https://issues.apache.org/jira/browse/OFBIZ-10224 Project: OFBiz Issue Type: Improvement Reporter: Gil Portenseigne Assignee: Gil Portenseigne Add andCondition optional hidden parameter within inputFields performFind parameter map. If present this condition will be added to default widget condition Add a unit test in PerformFindTests -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10224) Add a way to add a specific condition to performFind service
[ https://issues.apache.org/jira/browse/OFBIZ-10224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16366712#comment-16366712 ] Gil Portenseigne commented on OFBIZ-10224: -- Very simple but powerful improvment, patch attached. > Add a way to add a specific condition to performFind service > > > Key: OFBIZ-10224 > URL: https://issues.apache.org/jira/browse/OFBIZ-10224 > Project: OFBiz > Issue Type: Improvement >Reporter: Gil Portenseigne >Assignee: Gil Portenseigne >Priority: Minor > Attachments: OFBIZ-10224.patch > > > Add andCondition optional hidden parameter within inputFields performFind > parameter map. > If present this condition will be added to default widget condition > Add a unit test in PerformFindTests -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OFBIZ-10224) Add a way to add a specific condition to performFind service
[ https://issues.apache.org/jira/browse/OFBIZ-10224?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gil Portenseigne updated OFBIZ-10224: - Attachment: OFBIZ-10224.patch > Add a way to add a specific condition to performFind service > > > Key: OFBIZ-10224 > URL: https://issues.apache.org/jira/browse/OFBIZ-10224 > Project: OFBiz > Issue Type: Improvement >Reporter: Gil Portenseigne >Assignee: Gil Portenseigne >Priority: Minor > Attachments: OFBIZ-10224.patch > > > Add andCondition optional hidden parameter within inputFields performFind > parameter map. > If present this condition will be added to default widget condition > Add a unit test in PerformFindTests -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10195) Add the ability in performFind service to set OR search criteria
[ https://issues.apache.org/jira/browse/OFBIZ-10195?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16366717#comment-16366717 ] Gil Portenseigne commented on OFBIZ-10195: -- Thanks ! Also I just created OFBIZ-10224, giving another more specific way to use advanced condition. > Add the ability in performFind service to set OR search criteria > > > Key: OFBIZ-10195 > URL: https://issues.apache.org/jira/browse/OFBIZ-10195 > Project: OFBiz > Issue Type: Improvement >Reporter: Gil Portenseigne >Assignee: Gil Portenseigne >Priority: Minor > Fix For: Upcoming Branch > > Attachments: OFBIZ-10195.patch, OFBIZ-10195.patch > > > When using performFind service for advanced entity search, we can meet the > need to have search criteria that do not intersect between them, but make the > union of the condition. > To realize this improvement we propose to set a new suffix _grp. > Thus using : > > > > > Then the two search fields criteria will be unioned during the search by the > OR operator. > Several different keys can be used for several different unioned condition. > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10195) Add the ability in performFind service to set OR search criteria
[
https://issues.apache.org/jira/browse/OFBIZ-10195?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16368884#comment-16368884
]
Gil Portenseigne commented on OFBIZ-10195:
--
Hi Taher,
{quote}Putting the new attribute on the field level instead
{quote}
that was my first idea, but i wondered the use of such attribute in non-search
fields... So i choose to have it dedicated on search fields. Even if it
generated more code lines and redundancy...
What is the best to prioritize ? Avoid code redundancy or having dedicated
attribute that belongs only to search field-types.
For the renaming parts, i'm ok with it :)
Thanks Again
> Add the ability in performFind service to set OR search criteria
>
>
> Key: OFBIZ-10195
> URL: https://issues.apache.org/jira/browse/OFBIZ-10195
> Project: OFBiz
> Issue Type: Improvement
>Reporter: Gil Portenseigne
>Assignee: Gil Portenseigne
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-10195.patch, OFBIZ-10195.patch
>
>
> When using performFind service for advanced entity search, we can meet the
> need to have search criteria that do not intersect between them, but make the
> union of the condition.
> To realize this improvement we propose to set a new suffix _grp.
> Thus using :
>
>
>
>
> Then the two search fields criteria will be unioned during the search by the
> OR operator.
> Several different keys can be used for several different unioned condition.
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (OFBIZ-10195) Add the ability in performFind service to set OR search criteria
[ https://issues.apache.org/jira/browse/OFBIZ-10195?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16369815#comment-16369815 ] Gil Portenseigne commented on OFBIZ-10195: -- You make good points :), and I think about another one, we could use hidden or display, to force condition to the user, and the it'll be good to have the ability to group these conditions. So extend this ability to all fields is the way to go ! > Add the ability in performFind service to set OR search criteria > > > Key: OFBIZ-10195 > URL: https://issues.apache.org/jira/browse/OFBIZ-10195 > Project: OFBiz > Issue Type: Improvement >Reporter: Gil Portenseigne >Assignee: Gil Portenseigne >Priority: Minor > Fix For: Upcoming Branch > > Attachments: OFBIZ-10195.patch, OFBIZ-10195.patch > > > When using performFind service for advanced entity search, we can meet the > need to have search criteria that do not intersect between them, but make the > union of the condition. > To realize this improvement we propose to set a new suffix _grp. > Thus using : > > > > > Then the two search fields criteria will be unioned during the search by the > OR operator. > Several different keys can be used for several different unioned condition. > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OFBIZ-10195) Add the ability in performFind service to set OR search criteria
[ https://issues.apache.org/jira/browse/OFBIZ-10195?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gil Portenseigne updated OFBIZ-10195: - Attachment: OFBIZ-10195.patch > Add the ability in performFind service to set OR search criteria > > > Key: OFBIZ-10195 > URL: https://issues.apache.org/jira/browse/OFBIZ-10195 > Project: OFBiz > Issue Type: Improvement >Reporter: Gil Portenseigne >Assignee: Gil Portenseigne >Priority: Minor > Fix For: Upcoming Branch > > Attachments: OFBIZ-10195.patch, OFBIZ-10195.patch, OFBIZ-10195.patch > > > When using performFind service for advanced entity search, we can meet the > need to have search criteria that do not intersect between them, but make the > union of the condition. > To realize this improvement we propose to set a new suffix _grp. > Thus using : > > > > > Then the two search fields criteria will be unioned during the search by the > OR operator. > Several different keys can be used for several different unioned condition. > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10195) Add the ability in performFind service to set OR search criteria
[ https://issues.apache.org/jira/browse/OFBIZ-10195?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16370576#comment-16370576 ] Gil Portenseigne commented on OFBIZ-10195: -- Should be the good one, i'll commit it in two days if there is no more remarks :) In this last patch i switch the implementation to field level, and add hidden field management (not all fields since it makes no sense). > Add the ability in performFind service to set OR search criteria > > > Key: OFBIZ-10195 > URL: https://issues.apache.org/jira/browse/OFBIZ-10195 > Project: OFBiz > Issue Type: Improvement >Reporter: Gil Portenseigne >Assignee: Gil Portenseigne >Priority: Minor > Fix For: Upcoming Branch > > Attachments: OFBIZ-10195.patch, OFBIZ-10195.patch, OFBIZ-10195.patch > > > When using performFind service for advanced entity search, we can meet the > need to have search criteria that do not intersect between them, but make the > union of the condition. > To realize this improvement we propose to set a new suffix _grp. > Thus using : > > > > > Then the two search fields criteria will be unioned during the search by the > OR operator. > Several different keys can be used for several different unioned condition. > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Resolved] (OFBIZ-10195) Add the ability in performFind service to set OR search criteria
[ https://issues.apache.org/jira/browse/OFBIZ-10195?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gil Portenseigne resolved OFBIZ-10195. -- Resolution: Fixed Commited in trunk rev r1825350 Thanks [~taher] for the reviews and ideas ! > Add the ability in performFind service to set OR search criteria > > > Key: OFBIZ-10195 > URL: https://issues.apache.org/jira/browse/OFBIZ-10195 > Project: OFBiz > Issue Type: Improvement >Reporter: Gil Portenseigne >Assignee: Gil Portenseigne >Priority: Minor > Fix For: Upcoming Branch > > Attachments: OFBIZ-10195.patch, OFBIZ-10195.patch, OFBIZ-10195.patch > > > When using performFind service for advanced entity search, we can meet the > need to have search criteria that do not intersect between them, but make the > union of the condition. > To realize this improvement we propose to set a new suffix _grp. > Thus using : > > > > > Then the two search fields criteria will be unioned during the search by the > OR operator. > Several different keys can be used for several different unioned condition. > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Closed] (OFBIZ-10195) Add the ability in performFind service to set OR search criteria
[ https://issues.apache.org/jira/browse/OFBIZ-10195?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gil Portenseigne closed OFBIZ-10195. > Add the ability in performFind service to set OR search criteria > > > Key: OFBIZ-10195 > URL: https://issues.apache.org/jira/browse/OFBIZ-10195 > Project: OFBiz > Issue Type: Improvement >Reporter: Gil Portenseigne >Assignee: Gil Portenseigne >Priority: Minor > Fix For: Upcoming Branch > > Attachments: OFBIZ-10195.patch, OFBIZ-10195.patch, OFBIZ-10195.patch > > > When using performFind service for advanced entity search, we can meet the > need to have search criteria that do not intersect between them, but make the > union of the condition. > To realize this improvement we propose to set a new suffix _grp. > Thus using : > > > > > Then the two search fields criteria will be unioned during the search by the > OR operator. > Several different keys can be used for several different unioned condition. > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10195) Add the ability in performFind service to set OR search criteria
[ https://issues.apache.org/jira/browse/OFBIZ-10195?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16378220#comment-16378220 ] Gil Portenseigne commented on OFBIZ-10195: -- I cannot reproduce locally, what screen do you use ? Thanks > Add the ability in performFind service to set OR search criteria > > > Key: OFBIZ-10195 > URL: https://issues.apache.org/jira/browse/OFBIZ-10195 > Project: OFBiz > Issue Type: Improvement >Reporter: Gil Portenseigne >Assignee: Deepak Dixit >Priority: Minor > Fix For: Upcoming Branch > > Attachments: OFBIZ-10195.patch, OFBIZ-10195.patch, OFBIZ-10195.patch > > > When using performFind service for advanced entity search, we can meet the > need to have search criteria that do not intersect between them, but make the > union of the condition. > To realize this improvement we propose to set a new suffix _grp. > Thus using : > > > > > Then the two search fields criteria will be unioned during the search by the > OR operator. > Several different keys can be used for several different unioned condition. > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10195) Add the ability in performFind service to set OR search criteria
[ https://issues.apache.org/jira/browse/OFBIZ-10195?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16378236#comment-16378236 ] Gil Portenseigne commented on OFBIZ-10195: -- Thanks Deepak, now I can understand the miss :), nice ! > Add the ability in performFind service to set OR search criteria > > > Key: OFBIZ-10195 > URL: https://issues.apache.org/jira/browse/OFBIZ-10195 > Project: OFBiz > Issue Type: Improvement >Reporter: Gil Portenseigne >Assignee: Gil Portenseigne >Priority: Minor > Fix For: Upcoming Branch > > Attachments: OFBIZ-10195.patch, OFBIZ-10195.patch, OFBIZ-10195.patch > > > When using performFind service for advanced entity search, we can meet the > need to have search criteria that do not intersect between them, but make the > union of the condition. > To realize this improvement we propose to set a new suffix _grp. > Thus using : > > > > > Then the two search fields criteria will be unioned during the search by the > OR operator. > Several different keys can be used for several different unioned condition. > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Assigned] (OFBIZ-10244) french typo fix
[ https://issues.apache.org/jira/browse/OFBIZ-10244?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gil Portenseigne reassigned OFBIZ-10244: Assignee: Gil Portenseigne > french typo fix > --- > > Key: OFBIZ-10244 > URL: https://issues.apache.org/jira/browse/OFBIZ-10244 > Project: OFBiz > Issue Type: Bug > Components: order >Affects Versions: Trunk >Reporter: Gaudin Pierre >Assignee: Gil Portenseigne >Priority: Minor > Attachments: OFBIZ-10244.patch > > > A simple typo fix -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Resolved] (OFBIZ-10244) french typo fix
[ https://issues.apache.org/jira/browse/OFBIZ-10244?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gil Portenseigne resolved OFBIZ-10244. -- Resolution: Fixed Fix Version/s: 16.11.04 Upcoming Branch 17.12.01 Commited in : Trunk : r1825444 16.11 : r1825446 17.12 : r1825447 Thanks Pierre > french typo fix > --- > > Key: OFBIZ-10244 > URL: https://issues.apache.org/jira/browse/OFBIZ-10244 > Project: OFBiz > Issue Type: Bug > Components: order >Affects Versions: Trunk >Reporter: Gaudin Pierre >Assignee: Gil Portenseigne >Priority: Minor > Fix For: 17.12.01, Upcoming Branch, 16.11.04 > > Attachments: OFBIZ-10244.patch > > > A simple typo fix -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Assigned] (OFBIZ-10243) Error in service definition for deleteOrderHeaderWorkEffort
[ https://issues.apache.org/jira/browse/OFBIZ-10243?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gil Portenseigne reassigned OFBIZ-10243: Assignee: Gil Portenseigne > Error in service definition for deleteOrderHeaderWorkEffort > --- > > Key: OFBIZ-10243 > URL: https://issues.apache.org/jira/browse/OFBIZ-10243 > Project: OFBiz > Issue Type: Bug > Components: workeffort >Affects Versions: Trunk >Reporter: Gaudin Pierre >Assignee: Gil Portenseigne >Priority: Minor > Attachments: OFBIZ-10243.patch > > > There is an error into deleteOrderHeaderWorkEffort service definition. > The field "invoke" should be "delete" instead of "deleteOrderHeaderWorkEffort" -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Closed] (OFBIZ-10244) french typo fix
[ https://issues.apache.org/jira/browse/OFBIZ-10244?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gil Portenseigne closed OFBIZ-10244. > french typo fix > --- > > Key: OFBIZ-10244 > URL: https://issues.apache.org/jira/browse/OFBIZ-10244 > Project: OFBiz > Issue Type: Bug > Components: order >Affects Versions: Trunk >Reporter: Gaudin Pierre >Assignee: Gil Portenseigne >Priority: Minor > Fix For: 17.12.01, 16.11.04, Upcoming Branch > > Attachments: OFBIZ-10244.patch > > > A simple typo fix -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Closed] (OFBIZ-10243) Error in service definition for deleteOrderHeaderWorkEffort
[ https://issues.apache.org/jira/browse/OFBIZ-10243?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gil Portenseigne closed OFBIZ-10243. > Error in service definition for deleteOrderHeaderWorkEffort > --- > > Key: OFBIZ-10243 > URL: https://issues.apache.org/jira/browse/OFBIZ-10243 > Project: OFBiz > Issue Type: Bug > Components: workeffort >Affects Versions: Trunk >Reporter: Gaudin Pierre >Assignee: Gil Portenseigne >Priority: Minor > Fix For: 17.12.01, 16.11.05, Upcoming Branch > > Attachments: OFBIZ-10243.patch > > > There is an error into deleteOrderHeaderWorkEffort service definition. > The field "invoke" should be "delete" instead of "deleteOrderHeaderWorkEffort" -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Resolved] (OFBIZ-10243) Error in service definition for deleteOrderHeaderWorkEffort
[ https://issues.apache.org/jira/browse/OFBIZ-10243?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gil Portenseigne resolved OFBIZ-10243. -- Resolution: Fixed Fix Version/s: Upcoming Branch 16.11.05 17.12.01 Commited in Trunk r1825450 17.12 r1825451 16.11 r1825452 Thnks Pierre > Error in service definition for deleteOrderHeaderWorkEffort > --- > > Key: OFBIZ-10243 > URL: https://issues.apache.org/jira/browse/OFBIZ-10243 > Project: OFBiz > Issue Type: Bug > Components: workeffort >Affects Versions: Trunk >Reporter: Gaudin Pierre >Assignee: Gil Portenseigne >Priority: Minor > Fix For: 17.12.01, 16.11.05, Upcoming Branch > > Attachments: OFBIZ-10243.patch > > > There is an error into deleteOrderHeaderWorkEffort service definition. > The field "invoke" should be "delete" instead of "deleteOrderHeaderWorkEffort" -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (OFBIZ-10245) File transfer management with communicationEvent and new contactMech FTP_ADDRESS
Gil Portenseigne created OFBIZ-10245:
Summary: File transfer management with communicationEvent and new
contactMech FTP_ADDRESS
Key: OFBIZ-10245
URL: https://issues.apache.org/jira/browse/OFBIZ-10245
Project: OFBiz
Issue Type: Improvement
Components: content, party
Reporter: Gil Portenseigne
Assignee: Gil Portenseigne
This Jira introduce a new way to manage file transfer in OFBiz.
Inspired by mailing communication event management, a new
communicationEventTypeId is created ('FILE_TRANSFER_COMM').
Such commEvent with classics : partyIdFrom/partyIdTo/contactMechIdTo/entryDate
etc. are analysed by a job (like sendEmailDated), to send associated contents
to a configured FTP/SFTP/FTPS server. If failure happens, it is catched and
stored in communicationEvent, waiting for a new try.
For this purpose :
# A new contactMechTypeId is introduced (FtpAddress), with its corresponding
table. This contactMech store needed information for basic user/password
authentication (server url and protocol, port, username, password, etc.)
# A new service sendFileTransferDated (wip) that will look for pending file
transfer and call following service.
# A new service sendCommEventAsFtp that take a selected commEvent, check its
structure and manage its status after trying the associated content file
transfers
# A new service sendContentToFtp, that take a content and transfer it to a
given FtpAddress
# A seca createCommEventFromFtpTransfer on sendContentToFtp to manage plural
content file transfer, creating children communicationEvent to follow each
content transfer separately (only for several content transfers).
# A new Interface FtpClientInterface, with the 3 implementations of FTP, FTPS
(To be Done), SFTP clients to manage Ftp connection and transfer
# A new property file to enable and manage redirection for testing purpose
With this implementation, creating a communicationEvent, with a FtpAddress
contactMechIdTo, and sendFileTransferDated job planned :
* The file is transfered to the ftp : communication event status set to
COM_COMPLETE
* Error occured : communication event status set to COM_BOUNCED with error
message on communicationEvent note
The POC is working nicely for our customer, i adapted and tested it on trunk
here :
https://labs.nereide.fr/10031/Communautaire/compare/trunk...SendCommEventToFtp
(some more job to be done, but in a working state)
I can provide the current patch on demand but i will propose more polished work
in some days.
Looking forward reading you !
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (OFBIZ-10245) File transfer management with communicationEvent and new contactMech FTP_ADDRESS
[
https://issues.apache.org/jira/browse/OFBIZ-10245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16392549#comment-16392549
]
Gil Portenseigne commented on OFBIZ-10245:
--
Thanks [~rishisolankii] for your review, i'll sure take your nice remark :). I
didn't find the time to progress on it yet, but will do !
> File transfer management with communicationEvent and new contactMech
> FTP_ADDRESS
>
>
> Key: OFBIZ-10245
> URL: https://issues.apache.org/jira/browse/OFBIZ-10245
> Project: OFBiz
> Issue Type: Improvement
> Components: content, party
>Reporter: Gil Portenseigne
>Assignee: Gil Portenseigne
>Priority: Minor
>
> This Jira introduce a new way to manage file transfer in OFBiz.
> Inspired by mailing communication event management, a new
> communicationEventTypeId is created ('FILE_TRANSFER_COMM').
> Such commEvent with classics :
> partyIdFrom/partyIdTo/contactMechIdTo/entryDate etc. are analysed by a job
> (like sendEmailDated), to send associated contents to a configured
> FTP/SFTP/FTPS server. If failure happens, it is catched and stored in
> communicationEvent, waiting for a new try.
> For this purpose :
> # A new contactMechTypeId is introduced (FtpAddress), with its corresponding
> table. This contactMech store needed information for basic user/password
> authentication (server url and protocol, port, username, password, etc.)
> # A new service sendFileTransferDated (wip) that will look for pending file
> transfer and call following service.
> # A new service sendCommEventAsFtp that take a selected commEvent, check its
> structure and manage its status after trying the associated content file
> transfers
> # A new service sendContentToFtp, that take a content and transfer it to a
> given FtpAddress
> # A seca createCommEventFromFtpTransfer on sendContentToFtp to manage plural
> content file transfer, creating children communicationEvent to follow each
> content transfer separately (only for several content transfers).
> # A new Interface FtpClientInterface, with the 3 implementations of FTP,
> FTPS (To be Done), SFTP clients to manage Ftp connection and transfer
> # A new property file to enable and manage redirection for testing purpose
> With this implementation, creating a communicationEvent, with a FtpAddress
> contactMechIdTo, and sendFileTransferDated job planned :
> * The file is transfered to the ftp : communication event status set to
> COM_COMPLETE
> * Error occured : communication event status set to COM_BOUNCED with error
> message on communicationEvent note
> The POC is working nicely for our customer, i adapted and tested it on trunk
> here :
> https://labs.nereide.fr/10031/Communautaire/compare/trunk...SendCommEventToFtp
> (some more job to be done, but in a working state)
> I can provide the current patch on demand but i will propose more polished
> work in some days.
> Looking forward reading you !
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (OFBIZ-9800) French translation of OFBiz website
[ https://issues.apache.org/jira/browse/OFBIZ-9800?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16443678#comment-16443678 ] Gil Portenseigne commented on OFBIZ-9800: - Hello, i won't either. On this subject, I agree with Jacques opinion about a sum up static french website that will ease maintainability, and provide basic explanation to each kind of visitor with links to english contents. > French translation of OFBiz website > --- > > Key: OFBIZ-9800 > URL: https://issues.apache.org/jira/browse/OFBIZ-9800 > Project: OFBiz > Issue Type: Improvement > Components: site >Reporter: Olivier Heintz >Assignee: Deepak Dixit >Priority: Minor > Attachments: website-fr.tar, website-fr.tar, website-fr.tar.gz, > website-fr.tar.gz, website-fr.tar.gz, website-fr.tar.gz, website-fr.tar.gz > > > To evaluate the workload of translate all the ofbiz website page in french, > and so to maintain the translation when there are some modifications, I have > start to translate them. > There are between 10 and 15 page to translate, and translate one is between 1 > and 2 hours. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OFBIZ-10245) File transfer management with communicationEvent and new contactMech FTP_ADDRESS
[
https://issues.apache.org/jira/browse/OFBIZ-10245?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gil Portenseigne updated OFBIZ-10245:
-
Attachment: OFBIZ-10245.patch
> File transfer management with communicationEvent and new contactMech
> FTP_ADDRESS
>
>
> Key: OFBIZ-10245
> URL: https://issues.apache.org/jira/browse/OFBIZ-10245
> Project: OFBiz
> Issue Type: Improvement
> Components: content, party
>Reporter: Gil Portenseigne
>Assignee: Gil Portenseigne
>Priority: Minor
> Attachments: OFBIZ-10245.patch
>
>
> This Jira introduce a new way to manage file transfer in OFBiz.
> Inspired by mailing communication event management, a new
> communicationEventTypeId is created ('FILE_TRANSFER_COMM').
> Such commEvent with classics :
> partyIdFrom/partyIdTo/contactMechIdTo/entryDate etc. are analysed by a job
> (like sendEmailDated), to send associated contents to a configured
> FTP/SFTP/FTPS server. If failure happens, it is catched and stored in
> communicationEvent, waiting for a new try.
> For this purpose :
> # A new contactMechTypeId is introduced (FtpAddress), with its corresponding
> table. This contactMech store needed information for basic user/password
> authentication (server url and protocol, port, username, password, etc.)
> # A new service sendFileTransferDated (wip) that will look for pending file
> transfer and call following service.
> # A new service sendCommEventAsFtp that take a selected commEvent, check its
> structure and manage its status after trying the associated content file
> transfers
> # A new service sendContentToFtp, that take a content and transfer it to a
> given FtpAddress
> # A seca createCommEventFromFtpTransfer on sendContentToFtp to manage plural
> content file transfer, creating children communicationEvent to follow each
> content transfer separately (only for several content transfers).
> # A new Interface FtpClientInterface, with the 3 implementations of FTP,
> FTPS (To be Done), SFTP clients to manage Ftp connection and transfer
> # A new property file to enable and manage redirection for testing purpose
> With this implementation, creating a communicationEvent, with a FtpAddress
> contactMechIdTo, and sendFileTransferDated job planned :
> * The file is transfered to the ftp : communication event status set to
> COM_COMPLETE
> * Error occured : communication event status set to COM_BOUNCED with error
> message on communicationEvent note
> The POC is working nicely for our customer, i adapted and tested it on trunk
> here :
> https://labs.nereide.fr/10031/Communautaire/compare/trunk...SendCommEventToFtp
> (some more job to be done, but in a working state)
> I can provide the current patch on demand but i will propose more polished
> work in some days.
> Looking forward reading you !
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (OFBIZ-10245) File transfer management with communicationEvent and new contactMech FTP_ADDRESS
[
https://issues.apache.org/jira/browse/OFBIZ-10245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16454341#comment-16454341
]
Gil Portenseigne commented on OFBIZ-10245:
--
Hi [~rishisolankii],
I finally found the time to progress on the subject, i made a review, and now
can provide a patch with a better quality implementation.
I'll commit it in few days if there is no bad or "ask to wait" feedback about
it :)
> File transfer management with communicationEvent and new contactMech
> FTP_ADDRESS
>
>
> Key: OFBIZ-10245
> URL: https://issues.apache.org/jira/browse/OFBIZ-10245
> Project: OFBiz
> Issue Type: Improvement
> Components: content, party
>Reporter: Gil Portenseigne
>Assignee: Gil Portenseigne
>Priority: Minor
> Attachments: OFBIZ-10245.patch
>
>
> This Jira introduce a new way to manage file transfer in OFBiz.
> Inspired by mailing communication event management, a new
> communicationEventTypeId is created ('FILE_TRANSFER_COMM').
> Such commEvent with classics :
> partyIdFrom/partyIdTo/contactMechIdTo/entryDate etc. are analysed by a job
> (like sendEmailDated), to send associated contents to a configured
> FTP/SFTP/FTPS server. If failure happens, it is catched and stored in
> communicationEvent, waiting for a new try.
> For this purpose :
> # A new contactMechTypeId is introduced (FtpAddress), with its corresponding
> table. This contactMech store needed information for basic user/password
> authentication (server url and protocol, port, username, password, etc.)
> # A new service sendFileTransferDated (wip) that will look for pending file
> transfer and call following service.
> # A new service sendCommEventAsFtp that take a selected commEvent, check its
> structure and manage its status after trying the associated content file
> transfers
> # A new service sendContentToFtp, that take a content and transfer it to a
> given FtpAddress
> # A seca createCommEventFromFtpTransfer on sendContentToFtp to manage plural
> content file transfer, creating children communicationEvent to follow each
> content transfer separately (only for several content transfers).
> # A new Interface FtpClientInterface, with the 3 implementations of FTP,
> FTPS (To be Done), SFTP clients to manage Ftp connection and transfer
> # A new property file to enable and manage redirection for testing purpose
> With this implementation, creating a communicationEvent, with a FtpAddress
> contactMechIdTo, and sendFileTransferDated job planned :
> * The file is transfered to the ftp : communication event status set to
> COM_COMPLETE
> * Error occured : communication event status set to COM_BOUNCED with error
> message on communicationEvent note
> The POC is working nicely for our customer, i adapted and tested it on trunk
> here :
> https://labs.nereide.fr/10031/Communautaire/compare/trunk...SendCommEventToFtp
> (some more job to be done, but in a working state)
> I can provide the current patch on demand but i will propose more polished
> work in some days.
> Looking forward reading you !
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Created] (OFBIZ-10371) Add a link onto a crashed Job to reset it
Gil Portenseigne created OFBIZ-10371: Summary: Add a link onto a crashed Job to reset it Key: OFBIZ-10371 URL: https://issues.apache.org/jira/browse/OFBIZ-10371 Project: OFBiz Issue Type: Improvement Components: framework/webtools Affects Versions: Upcoming Branch Reporter: Gil Portenseigne Assignee: Gil Portenseigne Fix For: Upcoming Branch When a job crash due to OFBiz interruption, there is no easy way to replan it. Everything exists in the code base to do it, just adding a link onto crashed job in webtools. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OFBIZ-10371) Add a link onto a crashed Job to reset it
[ https://issues.apache.org/jira/browse/OFBIZ-10371?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gil Portenseigne updated OFBIZ-10371: - Attachment: OFBIZ-10371.patch > Add a link onto a crashed Job to reset it > - > > Key: OFBIZ-10371 > URL: https://issues.apache.org/jira/browse/OFBIZ-10371 > Project: OFBiz > Issue Type: Improvement > Components: framework/webtools >Affects Versions: Upcoming Branch >Reporter: Gil Portenseigne >Assignee: Gil Portenseigne >Priority: Minor > Fix For: Upcoming Branch > > Attachments: OFBIZ-10371.patch > > > When a job crash due to OFBiz interruption, there is no easy way to replan it. > Everything exists in the code base to do it, just adding a link onto crashed > job in webtools. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Resolved] (OFBIZ-10371) Add a link onto a crashed Job to reset it
[ https://issues.apache.org/jira/browse/OFBIZ-10371?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gil Portenseigne resolved OFBIZ-10371. -- Resolution: Implemented Commited in trunk rev : 1830236 > Add a link onto a crashed Job to reset it > - > > Key: OFBIZ-10371 > URL: https://issues.apache.org/jira/browse/OFBIZ-10371 > Project: OFBiz > Issue Type: Improvement > Components: framework/webtools >Affects Versions: Upcoming Branch >Reporter: Gil Portenseigne >Assignee: Gil Portenseigne >Priority: Minor > Fix For: Upcoming Branch > > Attachments: OFBIZ-10371.patch > > > When a job crash due to OFBiz interruption, there is no easy way to replan it. > Everything exists in the code base to do it, just adding a link onto crashed > job in webtools. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Closed] (OFBIZ-10371) Add a link onto a crashed Job to reset it
[ https://issues.apache.org/jira/browse/OFBIZ-10371?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gil Portenseigne closed OFBIZ-10371. > Add a link onto a crashed Job to reset it > - > > Key: OFBIZ-10371 > URL: https://issues.apache.org/jira/browse/OFBIZ-10371 > Project: OFBiz > Issue Type: Improvement > Components: framework/webtools >Affects Versions: Upcoming Branch >Reporter: Gil Portenseigne >Assignee: Gil Portenseigne >Priority: Minor > Fix For: Upcoming Branch > > Attachments: OFBIZ-10371.patch > > > When a job crash due to OFBiz interruption, there is no easy way to replan it. > Everything exists in the code base to do it, just adding a link onto crashed > job in webtools. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Reopened] (OFBIZ-10371) Add a link onto a crashed Job to reset it
[ https://issues.apache.org/jira/browse/OFBIZ-10371?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gil Portenseigne reopened OFBIZ-10371: -- Reverting the improvement, that should not be needed, since crashed job are to be rescheduled. The problem I met lies somewhere else. Thanks [~lektran] for the suggestion > Add a link onto a crashed Job to reset it > - > > Key: OFBIZ-10371 > URL: https://issues.apache.org/jira/browse/OFBIZ-10371 > Project: OFBiz > Issue Type: Improvement > Components: framework/webtools >Affects Versions: Upcoming Branch >Reporter: Gil Portenseigne >Assignee: Gil Portenseigne >Priority: Minor > Fix For: Upcoming Branch > > Attachments: OFBIZ-10371.patch > > > When a job crash due to OFBiz interruption, there is no easy way to replan it. > Everything exists in the code base to do it, just adding a link onto crashed > job in webtools. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Resolved] (OFBIZ-10371) Add a link onto a crashed Job to reset it
[ https://issues.apache.org/jira/browse/OFBIZ-10371?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gil Portenseigne resolved OFBIZ-10371. -- Resolution: Invalid > Add a link onto a crashed Job to reset it > - > > Key: OFBIZ-10371 > URL: https://issues.apache.org/jira/browse/OFBIZ-10371 > Project: OFBiz > Issue Type: Improvement > Components: framework/webtools >Affects Versions: Upcoming Branch >Reporter: Gil Portenseigne >Assignee: Gil Portenseigne >Priority: Minor > Fix For: Upcoming Branch > > Attachments: OFBIZ-10371.patch > > > When a job crash due to OFBiz interruption, there is no easy way to replan it. > Everything exists in the code base to do it, just adding a link onto crashed > job in webtools. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OFBIZ-6206) The "always" log level in minilang is logged as FATAL
[ https://issues.apache.org/jira/browse/OFBIZ-6206?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gil Portenseigne updated OFBIZ-6206: Attachment: OFBIZ-6206_Always-to-OFF.patch > The "always" log level in minilang is logged as FATAL > -- > > Key: OFBIZ-6206 > URL: https://issues.apache.org/jira/browse/OFBIZ-6206 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Release Branch 14.12, Trunk >Reporter: Jacques Le Roux >Assignee: Gil Portenseigne >Priority: Minor > Fix For: 17.12.01, 16.11.05, Upcoming Branch > > Attachments: OFBIZ-6206.patch, OFBIZ-6206_Always-to-OFF.patch > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Reopened] (OFBIZ-6206) The "always" log level in minilang is logged as FATAL
[
https://issues.apache.org/jira/browse/OFBIZ-6206?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gil Portenseigne reopened OFBIZ-6206:
-
Assignee: Gil Portenseigne (was: Nicolas Malin)
The issue still exist when using ALWAYS log level in minilang, or not
specifying it in Debug.log("my log").
I propose to use OFF level that is the highest rank level (not important in our
case, but the most logical)
[https://logging.apache.org/log4j/1.2/apidocs/org/apache/log4j/Level.html#OFF]
> The "always" log level in minilang is logged as FATAL
> --
>
> Key: OFBIZ-6206
> URL: https://issues.apache.org/jira/browse/OFBIZ-6206
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
>Affects Versions: Release Branch 14.12, Trunk
>Reporter: Jacques Le Roux
>Assignee: Gil Portenseigne
>Priority: Minor
> Fix For: 17.12.01, 16.11.05, Upcoming Branch
>
> Attachments: OFBIZ-6206.patch, OFBIZ-6206_Always-to-OFF.patch
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (OFBIZ-6206) The "always" log level in minilang is logged as FATAL
[
https://issues.apache.org/jira/browse/OFBIZ-6206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16479168#comment-16479168
]
Gil Portenseigne commented on OFBIZ-6206:
-
With the given patch and with no log active :
{quote} __ _
/ __ \/ / __ )(_)___
/ / / / /_ / __ / /_ /
/ /_/ / __/ / /_/ / / / /_
\/_/ /_/_/ /___/ is started and ready.
2018-05-17 16:40:09,515 |jsse-nio-8443-exec-3 |NoModule |O| Test Always log
{quote}
> The "always" log level in minilang is logged as FATAL
> --
>
> Key: OFBIZ-6206
> URL: https://issues.apache.org/jira/browse/OFBIZ-6206
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
>Affects Versions: Release Branch 14.12, Trunk
>Reporter: Jacques Le Roux
>Assignee: Gil Portenseigne
>Priority: Minor
> Fix For: 17.12.01, 16.11.05, Upcoming Branch
>
> Attachments: OFBIZ-6206.patch, OFBIZ-6206_Always-to-OFF.patch
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Closed] (OFBIZ-6206) The "always" log level in minilang is logged as FATAL
[ https://issues.apache.org/jira/browse/OFBIZ-6206?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gil Portenseigne closed OFBIZ-6206. --- > The "always" log level in minilang is logged as FATAL > -- > > Key: OFBIZ-6206 > URL: https://issues.apache.org/jira/browse/OFBIZ-6206 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Release Branch 14.12, Trunk >Reporter: Jacques Le Roux >Assignee: Gil Portenseigne >Priority: Minor > Fix For: 17.12.01, 16.11.05, Upcoming Branch > > Attachments: OFBIZ-6206.patch, OFBIZ-6206_Always-to-OFF.patch > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Resolved] (OFBIZ-6206) The "always" log level in minilang is logged as FATAL
[ https://issues.apache.org/jira/browse/OFBIZ-6206?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gil Portenseigne resolved OFBIZ-6206. - Resolution: Fixed Commited in trunk r1831788 17.12 r1831789 16.11 r1831790 > The "always" log level in minilang is logged as FATAL > -- > > Key: OFBIZ-6206 > URL: https://issues.apache.org/jira/browse/OFBIZ-6206 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Release Branch 14.12, Trunk >Reporter: Jacques Le Roux >Assignee: Gil Portenseigne >Priority: Minor > Fix For: 17.12.01, 16.11.05, Upcoming Branch > > Attachments: OFBIZ-6206.patch, OFBIZ-6206_Always-to-OFF.patch > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Closed] (OFBIZ-10245) File transfer management with communicationEvent and new contactMech FTP_ADDRESS
[
https://issues.apache.org/jira/browse/OFBIZ-10245?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gil Portenseigne closed OFBIZ-10245.
> File transfer management with communicationEvent and new contactMech
> FTP_ADDRESS
>
>
> Key: OFBIZ-10245
> URL: https://issues.apache.org/jira/browse/OFBIZ-10245
> Project: OFBiz
> Issue Type: Improvement
> Components: content, party
>Reporter: Gil Portenseigne
>Assignee: Gil Portenseigne
>Priority: Minor
> Attachments: OFBIZ-10245.patch
>
>
> This Jira introduce a new way to manage file transfer in OFBiz.
> Inspired by mailing communication event management, a new
> communicationEventTypeId is created ('FILE_TRANSFER_COMM').
> Such commEvent with classics :
> partyIdFrom/partyIdTo/contactMechIdTo/entryDate etc. are analysed by a job
> (like sendEmailDated), to send associated contents to a configured
> FTP/SFTP/FTPS server. If failure happens, it is catched and stored in
> communicationEvent, waiting for a new try.
> For this purpose :
> # A new contactMechTypeId is introduced (FtpAddress), with its corresponding
> table. This contactMech store needed information for basic user/password
> authentication (server url and protocol, port, username, password, etc.)
> # A new service sendFileTransferDated (wip) that will look for pending file
> transfer and call following service.
> # A new service sendCommEventAsFtp that take a selected commEvent, check its
> structure and manage its status after trying the associated content file
> transfers
> # A new service sendContentToFtp, that take a content and transfer it to a
> given FtpAddress
> # A seca createCommEventFromFtpTransfer on sendContentToFtp to manage plural
> content file transfer, creating children communicationEvent to follow each
> content transfer separately (only for several content transfers).
> # A new Interface FtpClientInterface, with the 3 implementations of FTP,
> FTPS (To be Done), SFTP clients to manage Ftp connection and transfer
> # A new property file to enable and manage redirection for testing purpose
> With this implementation, creating a communicationEvent, with a FtpAddress
> contactMechIdTo, and sendFileTransferDated job planned :
> * The file is transfered to the ftp : communication event status set to
> COM_COMPLETE
> * Error occured : communication event status set to COM_BOUNCED with error
> message on communicationEvent note
> The POC is working nicely for our customer, i adapted and tested it on trunk
> here :
> https://labs.nereide.fr/10031/Communautaire/compare/trunk...SendCommEventToFtp
> (some more job to be done, but in a working state)
> I can provide the current patch on demand but i will propose more polished
> work in some days.
> Looking forward reading you !
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (OFBIZ-5980) Have the ability to revoke (expire) roles of a party
[ https://issues.apache.org/jira/browse/OFBIZ-5980?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17441568#comment-17441568 ] Gil Portenseigne commented on OFBIZ-5980: - Thank you [~jleroux] for the sum up, i will send a mail this friday to open the discussion to the community member, if no one did it before.:) > Have the ability to revoke (expire) roles of a party > > > Key: OFBIZ-5980 > URL: https://issues.apache.org/jira/browse/OFBIZ-5980 > Project: OFBiz > Issue Type: Bug > Components: party >Affects Versions: Trunk >Reporter: Pierre Smits >Assignee: Pierre Smits >Priority: Major > Labels: roles > Fix For: Upcoming Branch > > > Currently it is only possible to delete a PartyRole record from a party. > Which leads to error messages, when that particular Partyrole record is > associated with records in other entities where the PartyRole entity is set > as a relation (through which is > applied as a foreign key relation in the underlying dbms ). > Examples of such related entities that are: > * entity-name="MarketingCampaignRole" > * entity-name="BudgetRole" > In order to avoid such, it is better to revoke the PartyRole record by > setting an expiration date (end date) on the record. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Commented] (OFBIZ-12183) Groovy script Product.groovy: java.util.NoSuchElementException
[ https://issues.apache.org/jira/browse/OFBIZ-12183?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17442630#comment-17442630 ] Gil Portenseigne commented on OFBIZ-12183: -- Hello [~Giulio_MpStyle] , Do the patch solved your issue ? Can we close the Jira ? Thanks, Gil > Groovy script Product.groovy: java.util.NoSuchElementException > --- > > Key: OFBIZ-12183 > URL: https://issues.apache.org/jira/browse/OFBIZ-12183 > Project: OFBiz > Issue Type: Bug > Components: ecommerce, order >Affects Versions: Release Branch 18.12, Trunk, 17.12.05 > Environment: Linux/Ubuntu 16.04, Linux/Ubuntu 18.04, OFBiz v13.07.03 >Reporter: Giulio Speri >Assignee: Nicolas Malin >Priority: Critical > Attachments: NoSuchElementException_Productgroovy.jpeg > > > Strange issue happens randomly (it seems) while loading ecommerce product > detail page and the groovy script Product.groovy > (order/webapp/ordermgr/WEB-INF/actions/entry/catalog/) is run. > The groovy script is loaded in the screen "product". > The error showed is kind of java.util.NoSuchElementException and I think that > could be something related to session/request attributes, since this could be > avoided with an incognito navigation session. > I saw this error a couple of times during local development also and I could > pass over it by manually deleting browser session cookies. > Unfortunately I was not able to reproduce it yet, so I cannot add more > details except hypothesis. > I also post here a screenshot of the error. > > !NoSuchElementException_Productgroovy.jpeg! -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Commented] (OFBIZ-12369) Security screen in Party component doesn't allow for searching for user login
[ https://issues.apache.org/jira/browse/OFBIZ-12369?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17442681#comment-17442681 ] Gil Portenseigne commented on OFBIZ-12369: -- Hello [~pierresmits] , i did not manage to reproduce the bug on branch 18.12 and trunk. Could you confirm ? Thanks > Security screen in Party component doesn't allow for searching for user login > - > > Key: OFBIZ-12369 > URL: https://issues.apache.org/jira/browse/OFBIZ-12369 > Project: OFBiz > Issue Type: Bug > Components: party >Affects Versions: Trunk, 18.12.01 >Reporter: Pierre Smits >Priority: Major > Labels: userlogin > > In [https://demo-stable.ofbiz.apache.org/partymgr/control/FindUserLogin] the > page shows the list of UserLogin records, but does not cater for searching > for such. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Comment Edited] (OFBIZ-12369) Security screen in Party component doesn't allow for searching for user login
[ https://issues.apache.org/jira/browse/OFBIZ-12369?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17442681#comment-17442681 ] Gil Portenseigne edited comment on OFBIZ-12369 at 11/12/21, 11:04 AM: -- -Hello- [~pierresmits] -, i did not manage to reproduce the bug on branch 18.12 and trunk. Could you confirm ?- Ok I missread the ticket, could you provide a patch fixig the issue ? Thanks was (Author: gil portenseigne): Hello [~pierresmits] , i did not manage to reproduce the bug on branch 18.12 and trunk. Could you confirm ? Thanks > Security screen in Party component doesn't allow for searching for user login > - > > Key: OFBIZ-12369 > URL: https://issues.apache.org/jira/browse/OFBIZ-12369 > Project: OFBiz > Issue Type: Bug > Components: party >Affects Versions: Trunk, 18.12.01 >Reporter: Pierre Smits >Priority: Major > Labels: userlogin > > In [https://demo-stable.ofbiz.apache.org/partymgr/control/FindUserLogin] the > page shows the list of UserLogin records, but does not cater for searching > for such. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Commented] (OFBIZ-9498) Improve DevOps using environment variable configuration
[ https://issues.apache.org/jira/browse/OFBIZ-9498?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17466789#comment-17466789 ] Gil Portenseigne commented on OFBIZ-9498: - Hello [~ieugen] , Thanks for your review, I work with [~marco_adeti] whom i gave the relay to animate the subject. He should make a first proposal about a new idea, in some times. About the current patch, no progress yet, it is usable, and used in several customer project in our side, feel free to experience. > Improve DevOps using environment variable configuration > --- > > Key: OFBIZ-9498 > URL: https://issues.apache.org/jira/browse/OFBIZ-9498 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk >Reporter: Gil Portenseigne >Assignee: Gil Portenseigne >Priority: Minor > Attachments: OFBIZ-9498.patch > > > Discussed in thread : https://s.apache.org/Mh3q > This Jira will present the improvment proposal giving a way to configure > OFBiz using environment variable. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Commented] (OFBIZ-9498) Improve DevOps using environment variable configuration
[ https://issues.apache.org/jira/browse/OFBIZ-9498?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17467881#comment-17467881 ] Gil Portenseigne commented on OFBIZ-9498: - I plan to complete the PR, and if no one oppose after last review, merge it. > Improve DevOps using environment variable configuration > --- > > Key: OFBIZ-9498 > URL: https://issues.apache.org/jira/browse/OFBIZ-9498 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk >Reporter: Gil Portenseigne >Assignee: Gil Portenseigne >Priority: Minor > Attachments: OFBIZ-9498.patch > > > Discussed in thread : https://s.apache.org/Mh3q > This Jira will present the improvment proposal giving a way to configure > OFBiz using environment variable. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Created] (OFBIZ-12612) Update sshd dependency and implementation
Gil Portenseigne created OFBIZ-12612: Summary: Update sshd dependency and implementation Key: OFBIZ-12612 URL: https://issues.apache.org/jira/browse/OFBIZ-12612 Project: OFBiz Issue Type: Improvement Reporter: Gil Portenseigne Assignee: Gil Portenseigne Updating sshd library used by SshFtpClient feature. In a customer project, we found out that the current implementation under heavy usage leads to redundant thread creation. This patch update the implementation using the last revision of the sshd mina librairy. -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Updated] (OFBIZ-12612) Update sshd dependency and implementation
[ https://issues.apache.org/jira/browse/OFBIZ-12612?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gil Portenseigne updated OFBIZ-12612: - Fix Version/s: Upcoming Branch > Update sshd dependency and implementation > -- > > Key: OFBIZ-12612 > URL: https://issues.apache.org/jira/browse/OFBIZ-12612 > Project: OFBiz > Issue Type: Improvement >Affects Versions: Upcoming Branch >Reporter: Gil Portenseigne >Assignee: Gil Portenseigne >Priority: Major > Fix For: Upcoming Branch > > > Updating sshd library used by SshFtpClient feature. > In a customer project, we found out that the current implementation under > heavy usage leads to redundant thread creation. > This patch update the implementation using the last revision of the sshd mina > librairy. -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Updated] (OFBIZ-12612) Update sshd dependency and implementation
[ https://issues.apache.org/jira/browse/OFBIZ-12612?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gil Portenseigne updated OFBIZ-12612: - Affects Version/s: Upcoming Branch > Update sshd dependency and implementation > -- > > Key: OFBIZ-12612 > URL: https://issues.apache.org/jira/browse/OFBIZ-12612 > Project: OFBiz > Issue Type: Improvement >Affects Versions: Upcoming Branch >Reporter: Gil Portenseigne >Assignee: Gil Portenseigne >Priority: Major > > Updating sshd library used by SshFtpClient feature. > In a customer project, we found out that the current implementation under > heavy usage leads to redundant thread creation. > This patch update the implementation using the last revision of the sshd mina > librairy. -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Closed] (OFBIZ-12612) Update sshd dependency and implementation
[ https://issues.apache.org/jira/browse/OFBIZ-12612?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gil Portenseigne closed OFBIZ-12612. Fix Version/s: 22.01.01 Resolution: Fixed This was commited in release22 since fixed an implementation issue. > Update sshd dependency and implementation > -- > > Key: OFBIZ-12612 > URL: https://issues.apache.org/jira/browse/OFBIZ-12612 > Project: OFBiz > Issue Type: Improvement >Affects Versions: Upcoming Branch >Reporter: Gil Portenseigne >Assignee: Gil Portenseigne >Priority: Major > Fix For: 22.01.01, Upcoming Branch > > > Updating sshd library used by SshFtpClient feature. > In a customer project, we found out that the current implementation under > heavy usage leads to redundant thread creation. > This patch update the implementation using the last revision of the sshd mina > librairy. -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Closed] (OFBIZ-12183) Groovy script Product.groovy: java.util.NoSuchElementException
[ https://issues.apache.org/jira/browse/OFBIZ-12183?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gil Portenseigne closed OFBIZ-12183. Resolution: Cannot Reproduce Closing since not reproducible. Thanks > Groovy script Product.groovy: java.util.NoSuchElementException > --- > > Key: OFBIZ-12183 > URL: https://issues.apache.org/jira/browse/OFBIZ-12183 > Project: OFBiz > Issue Type: Bug > Components: ecommerce, order >Affects Versions: Release Branch 18.12, Trunk, 17.12.05, Upcoming Branch > Environment: Linux/Ubuntu 16.04, Linux/Ubuntu 18.04, OFBiz v13.07.03 >Reporter: Giulio Speri >Assignee: Nicolas Malin >Priority: Critical > Attachments: NoSuchElementException_Productgroovy.jpeg > > > Strange issue happens randomly (it seems) while loading ecommerce product > detail page and the groovy script Product.groovy > (order/webapp/ordermgr/WEB-INF/actions/entry/catalog/) is run. > The groovy script is loaded in the screen "product". > The error showed is kind of java.util.NoSuchElementException and I think that > could be something related to session/request attributes, since this could be > avoided with an incognito navigation session. > I saw this error a couple of times during local development also and I could > pass over it by manually deleting browser session cookies. > Unfortunately I was not able to reproduce it yet, so I cannot add more > details except hypothesis. > I also post here a screenshot of the error. > > !NoSuchElementException_Productgroovy.jpeg! -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Commented] (OFBIZ-10692) Groovy DSL runService Exception Management
[
https://issues.apache.org/jira/browse/OFBIZ-10692?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17542922#comment-17542922
]
Gil Portenseigne commented on OFBIZ-10692:
--
This ticket was in stand-by, we added some integration tests, i will provide a
new patch soon.
> Groovy DSL runService Exception Management
> --
>
> Key: OFBIZ-10692
> URL: https://issues.apache.org/jira/browse/OFBIZ-10692
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
>Affects Versions: Trunk, Upcoming Branch
>Reporter: Leila Mekika
>Assignee: Gil Portenseigne
>Priority: Minor
> Labels: patch
> Attachments: OFBIZ-10692-TEST.patch, OFBIZ-10692.patch,
> Sélection_088.png, screenshot-1.png
>
>
> Like discussed in thread :
> [https://lists.apache.org/thread.html/5a8e1caed0bcf29889c6b88ec1916947cf092d6f99d7dfe27cbef8c0@%3Cdev.ofbiz.apache.org%3E]
>
> This ticket try to improve the way that errors are rendered when using {{run
> service}} groovy DSL method.
>
> To reproduce and test patch:
> apply the attached patch [^OFBIZ-10692-TEST.patch] (it adds a control on
> createUomConversionDated service) and try to create a conversion rate with a
> fromDate greater than the thruDate here:
> https://localhost:8443/accounting/control/viewFXConversions?organizationPartyId=Company
>
> You should then see the following error:
> The Following Errors Occurred: Error calling event:
> org.apache.ofbiz.webapp.event.EventHandlerException: Service invocation error
> (org.apache.ofbiz.service.ExecutionServiceException: Through date can't be
> same or smaller than from date)
>
> With [^OFBIZ-10692.patch] update, the error must be displayed like:
> The Following Errors Occurred: Through date can't be same or smaller
> than from date
>
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[jira] [Closed] (OFBIZ-10692) Groovy DSL runService Exception Management
[
https://issues.apache.org/jira/browse/OFBIZ-10692?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gil Portenseigne closed OFBIZ-10692.
Resolution: Fixed
Thanks [~mleila] , this is commited in trunk.
Regards,
Gil
> Groovy DSL runService Exception Management
> --
>
> Key: OFBIZ-10692
> URL: https://issues.apache.org/jira/browse/OFBIZ-10692
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
>Affects Versions: Trunk, Upcoming Branch
>Reporter: Leila Mekika
>Assignee: Gil Portenseigne
>Priority: Minor
> Labels: patch
> Attachments: OFBIZ-10692-TEST.patch, OFBIZ-10692.patch,
> Sélection_088.png, screenshot-1.png
>
>
> Like discussed in thread :
> [https://lists.apache.org/thread.html/5a8e1caed0bcf29889c6b88ec1916947cf092d6f99d7dfe27cbef8c0@%3Cdev.ofbiz.apache.org%3E]
>
> This ticket try to improve the way that errors are rendered when using {{run
> service}} groovy DSL method.
>
> To reproduce and test patch:
> apply the attached patch [^OFBIZ-10692-TEST.patch] (it adds a control on
> createUomConversionDated service) and try to create a conversion rate with a
> fromDate greater than the thruDate here:
> https://localhost:8443/accounting/control/viewFXConversions?organizationPartyId=Company
>
> You should then see the following error:
> The Following Errors Occurred: Error calling event:
> org.apache.ofbiz.webapp.event.EventHandlerException: Service invocation error
> (org.apache.ofbiz.service.ExecutionServiceException: Through date can't be
> same or smaller than from date)
>
> With [^OFBIZ-10692.patch] update, the error must be displayed like:
> The Following Errors Occurred: Through date can't be same or smaller
> than from date
>
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[jira] [Commented] (OFBIZ-11167) Use Codenarc to test Groovy code
[ https://issues.apache.org/jira/browse/OFBIZ-11167?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17561468#comment-17561468 ] Gil Portenseigne commented on OFBIZ-11167: -- Hello Folks, i dig up this subject and started to work on it actively, i will push my progress here [https://github.com/apache/ofbiz-framework/pull/517.] The Idea is to document each rule, and make one commit by rule on the pull request to ease the review and decide if a rule is worth keeping etc. > Use Codenarc to test Groovy code > > > Key: OFBIZ-11167 > URL: https://issues.apache.org/jira/browse/OFBIZ-11167 > Project: OFBiz > Issue Type: New Feature > Components: framework >Reporter: Jacques Le Roux >Assignee: Gil Portenseigne >Priority: Minor > Attachments: OFBIZ-11167.patch, main.html, test.html > > > Now that we use Groovy more and more, I think we should really have a look a > Codenarc > https://docs.gradle.org/current/userguide/codenarc_plugin.html > We already discussed it at https://markmail.org/message/uigcpnxqgizhd2oi and > https://markmail.org/message/rp6njoiohkkiodbe > We know it's a crucial task but not an easy but rather a long term one > Here are some interesting links (before I delete my FF tabs group about it) > http://codenarc.sourceforge.net/codenarc-other-tools-frameworks.html > http://codenarc.sourceforge.net/codenarc-creating-ruleset.html > https://github.com/gradle/gradle/tree/master/config > https://stackoverflow.com/questions/14358471/how-to-generate-codenarc-report-for-main-and-test-classes-using-different-rule-s > https://mrhaki.blogspot.com/2011/01/gradle-goodness-use-groovy-ruleset-file.html -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OFBIZ-11167) Use Codenarc to test Groovy code
[
https://issues.apache.org/jira/browse/OFBIZ-11167?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17561935#comment-17561935
]
Gil Portenseigne commented on OFBIZ-11167:
--
I wrote a little script to extract the rules in order of occurrence. I will
launch an email to the dev list to discuss about the rules to be respected, and
the implied changes.
There are the results :
||Number of occurence||Rule name and details||
|9883|UnnecessaryGString - String objects should be created with single quotes,
and GString objects created with double quotes. Creating normal String objects
with double quotes is confusing to readers.|
|4569|DuplicateStringLiteral - Code containing duplicate String literals can
usually be improved by declaring the String as a constant field. The
ignoreStrings property () can optionally specify a comma-separated list of
Strings to ignore.|
|4209|SpaceAroundMapEntryColon - Check for configured formatting of whitespace
around colons for literal Map entries. The characterBeforeColonRegex and
characterAfterColonRegex properties specify a regular expression that must
match the character before/after the colon.|
|1448|LineLength - Checks the maximum length for each line of source code. It
checks for number of characters, so lines that include tabs may appear longer
than the allowed number when viewing the file. The maximum line length can be
configured by setting the length property, which defaults to 120.|
|885|UnnecessaryGetter - Checks for explicit calls to getter/accessor methods
which can, for the most part, be replaced by property access. A getter is
defined as a method call that matches get[A-Z] but not getClass() or
get[A-Z][A-Z] such as getURL(). Getters do not take method arguments. The
ignoreMethodNames property (null) can specify method names that should be
ignored, optionally containing wildcard characters ('*' or '?').|
|601|NoDef - def should not be used. You should replace it with concrete type.|
|485|MethodReturnTypeRequired - Checks that method return types are not
dynamic, that is they are explicitly stated and different than def.|
|484|Indentation - Check indentation for class and method declarations, and
initial statements.|
|482|UnnecessaryReturnKeyword - In Groovy, the return keyword is often
optional. If a statement is the last line in a method or closure then you do
not need to have the return keyword.|
|407|UnnecessaryObjectReferences - Violations are triggered when an excessive
set of consecutive statements all reference the same variable. This can be made
more readable by using a with or identity block.|
|345|CompileStatic - Check that classes are explicitely annotated with either
@GrailsCompileStatic, @CompileStatic or @CompileDynamic|
|320|ExplicitCallToEqualsMethod - This rule detects when the equals(Object)
method is called directly in code instead of using the == or != operator. A
groovier way to express this: a.equals(b) is this: a == b and a groovier way to
express : !a.equals(b) is : a != b|
|235|IfStatementBraces - Use braces for if statements, even for a single
statement.|
|235|SpaceAroundOperator - Check that there is at least one space (blank) or
whitespace around each binary operator.|
|211|NestedBlockDepth - Checks for blocks or closures nested more than
maxNestedBlockDepth (5) levels deep.|
|201|TrailingWhitespace - Checks that no lines of source code end with
whitespace characters.|
|190|DuplicateNumberLiteral - Code containing number String literals can
usually be improved by declaring the number as a constant field. The
ignoreNumbers property (0,1) can optionally specify a comma-separated list of
numbers to ignore.|
|190|NoWildcardImports - Wildcard imports, static or otherwise, should not be
used.|
|173|TrailingComma - Check whether list and map literals contain optional
trailing comma.|
|167|InvertedCondition - An inverted condition is one where a constant
expression is used on the left hand side of the equals comparision. Such
conditions can be confusing especially when used in assertions where the
expected value is by convention placed on the right hand side of the
comparision.|
|167|JavadocEmptyReturnTag - Checks for empty @return tags within javadoc.|
|164|UnnecessarySetter - Checks for explicit calls to setter methods which can,
for the most part, be replaced by assignment to property. A setter is defined
as a method call that matches set[A-Z] but not set[A-Z][A-Z] such as setURL().
Setters take one method argument.|
|146|CouldBeElvis - Catch an if block that could be written as an elvis
expression.|
|142|UnusedImport - Imports for a class that is never referenced within the
source file is unnecessary.|
|141|AbcMetric - Checks the ABC size metric for methods/classes. A method (or
"closure field") with an ABC score greater than the maxMethodAbcScore property
(60) causes a violation. Likewise, a class that has
[jira] [Commented] (OFBIZ-11167) Use Codenarc to test Groovy code
[ https://issues.apache.org/jira/browse/OFBIZ-11167?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17648644#comment-17648644 ] Gil Portenseigne commented on OFBIZ-11167: -- Work still ongoing, i propose to remove rule TrailingComma : Check whether list and map literals contain optional trailing comma. > Use Codenarc to test Groovy code > > > Key: OFBIZ-11167 > URL: https://issues.apache.org/jira/browse/OFBIZ-11167 > Project: OFBiz > Issue Type: New Feature > Components: framework >Reporter: Jacques Le Roux >Assignee: Gil Portenseigne >Priority: Minor > Attachments: OFBIZ-11167.patch, main.html, test.html > > > Now that we use Groovy more and more, I think we should really have a look a > Codenarc > https://docs.gradle.org/current/userguide/codenarc_plugin.html > We already discussed it at https://markmail.org/message/uigcpnxqgizhd2oi and > https://markmail.org/message/rp6njoiohkkiodbe > We know it's a crucial task but not an easy but rather a long term one > Here are some interesting links (before I delete my FF tabs group about it) > http://codenarc.sourceforge.net/codenarc-other-tools-frameworks.html > http://codenarc.sourceforge.net/codenarc-creating-ruleset.html > https://github.com/gradle/gradle/tree/master/config > https://stackoverflow.com/questions/14358471/how-to-generate-codenarc-report-for-main-and-test-classes-using-different-rule-s > https://mrhaki.blogspot.com/2011/01/gradle-goodness-use-groovy-ruleset-file.html -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (OFBIZ-11167) Use Codenarc to test Groovy code
[ https://issues.apache.org/jira/browse/OFBIZ-11167?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gil Portenseigne updated OFBIZ-11167: - Description: Thread of community discussion about the rules to implement : https://www.mail-archive.com/search?l=dev%40ofbiz.apache.org&q=subject:%22Codenarc+integration%2C+rules+to+use.%22&o=newest&f=1 Now that we use Groovy more and more, I think we should really have a look a Codenarc [https://docs.gradle.org/current/userguide/codenarc_plugin.html] We already discussed it at [https://markmail.org/message/uigcpnxqgizhd2oi] and [https://markmail.org/message/rp6njoiohkkiodbe] We know it's a crucial task but not an easy but rather a long term one Here are some interesting links (before I delete my FF tabs group about it) [http://codenarc.sourceforge.net/codenarc-other-tools-frameworks.html] [http://codenarc.sourceforge.net/codenarc-creating-ruleset.html] [https://github.com/gradle/gradle/tree/master/config] [https://stackoverflow.com/questions/14358471/how-to-generate-codenarc-report-for-main-and-test-classes-using-different-rule-s] [https://mrhaki.blogspot.com/2011/01/gradle-goodness-use-groovy-ruleset-file.html] was: Now that we use Groovy more and more, I think we should really have a look a Codenarc https://docs.gradle.org/current/userguide/codenarc_plugin.html We already discussed it at https://markmail.org/message/uigcpnxqgizhd2oi and https://markmail.org/message/rp6njoiohkkiodbe We know it's a crucial task but not an easy but rather a long term one Here are some interesting links (before I delete my FF tabs group about it) http://codenarc.sourceforge.net/codenarc-other-tools-frameworks.html http://codenarc.sourceforge.net/codenarc-creating-ruleset.html https://github.com/gradle/gradle/tree/master/config https://stackoverflow.com/questions/14358471/how-to-generate-codenarc-report-for-main-and-test-classes-using-different-rule-s https://mrhaki.blogspot.com/2011/01/gradle-goodness-use-groovy-ruleset-file.html > Use Codenarc to test Groovy code > > > Key: OFBIZ-11167 > URL: https://issues.apache.org/jira/browse/OFBIZ-11167 > Project: OFBiz > Issue Type: New Feature > Components: framework >Reporter: Jacques Le Roux >Assignee: Gil Portenseigne >Priority: Minor > Attachments: OFBIZ-11167.patch, main.html, test.html > > > Thread of community discussion about the rules to implement : > https://www.mail-archive.com/search?l=dev%40ofbiz.apache.org&q=subject:%22Codenarc+integration%2C+rules+to+use.%22&o=newest&f=1 > > Now that we use Groovy more and more, I think we should really have a look a > Codenarc > [https://docs.gradle.org/current/userguide/codenarc_plugin.html] > We already discussed it at [https://markmail.org/message/uigcpnxqgizhd2oi] > and [https://markmail.org/message/rp6njoiohkkiodbe] > We know it's a crucial task but not an easy but rather a long term one > Here are some interesting links (before I delete my FF tabs group about it) > [http://codenarc.sourceforge.net/codenarc-other-tools-frameworks.html] > [http://codenarc.sourceforge.net/codenarc-creating-ruleset.html] > [https://github.com/gradle/gradle/tree/master/config] > [https://stackoverflow.com/questions/14358471/how-to-generate-codenarc-report-for-main-and-test-classes-using-different-rule-s] > [https://mrhaki.blogspot.com/2011/01/gradle-goodness-use-groovy-ruleset-file.html] -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OFBIZ-12725) Cannot expand tree of accounts in Navigate Accounts screen with Helveticus theme
[ https://issues.apache.org/jira/browse/OFBIZ-12725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17652186#comment-17652186 ] Gil Portenseigne commented on OFBIZ-12725: -- Hello [~jleroux] , [~marine] is the person you meant to contact I guess, I transfer the info to let her know :) Thanks > Cannot expand tree of accounts in Navigate Accounts screen with Helveticus > theme > > > Key: OFBIZ-12725 > URL: https://issues.apache.org/jira/browse/OFBIZ-12725 > Project: OFBiz > Issue Type: Sub-task > Components: accounting, themes/helveticus >Affects Versions: 22.01.01 >Reporter: Daniel Watford >Assignee: Jacques Le Roux >Priority: Major > Fix For: 22.01.01 > > > Viewing [OFBiz: Accounting Manager: Navigate Accounts > (apache.org)|https://demo-next.ofbiz.apache.org/accounting/control/GlAccountNavigate?trail=null], > it is not possible to expand the chart-of-accounts tree when the Helveticus > visual theme is used. > The Helveticus theme is the default theme for new deployments. > A workaround is to switch to a non-Helveticus theme. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (OFBIZ-12732) Error in BlackList to DenyList migration service
Gil Portenseigne created OFBIZ-12732: Summary: Error in BlackList to DenyList migration service Key: OFBIZ-12732 URL: https://issues.apache.org/jira/browse/OFBIZ-12732 Project: OFBiz Issue Type: Bug Affects Versions: 18.12.06, Upcoming Branch Reporter: Gil Portenseigne Assignee: Gil Portenseigne While reviewing groovy files for codenarc integration i stumbled upon OrderBlacklistServices.groovy that present some implementation issue. This Jira is about fixing the implementation of this service. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (OFBIZ-12732) Error in BlackList to DenyList migration service
[ https://issues.apache.org/jira/browse/OFBIZ-12732?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gil Portenseigne updated OFBIZ-12732: - Affects Version/s: (was: 18.12.06) > Error in BlackList to DenyList migration service > > > Key: OFBIZ-12732 > URL: https://issues.apache.org/jira/browse/OFBIZ-12732 > Project: OFBiz > Issue Type: Bug >Affects Versions: Upcoming Branch >Reporter: Gil Portenseigne >Assignee: Gil Portenseigne >Priority: Major > > While reviewing groovy files for codenarc integration i stumbled upon > OrderBlacklistServices.groovy that present some implementation issue. > > This Jira is about fixing the implementation of this service. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (OFBIZ-12732) Error in BlackList to DenyList migration service
[ https://issues.apache.org/jira/browse/OFBIZ-12732?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gil Portenseigne updated OFBIZ-12732: - Fix Version/s: 22.01.01 > Error in BlackList to DenyList migration service > > > Key: OFBIZ-12732 > URL: https://issues.apache.org/jira/browse/OFBIZ-12732 > Project: OFBiz > Issue Type: Bug >Affects Versions: Upcoming Branch >Reporter: Gil Portenseigne >Assignee: Gil Portenseigne >Priority: Major > Fix For: 22.01.01 > > > While reviewing groovy files for codenarc integration i stumbled upon > OrderBlacklistServices.groovy that present some implementation issue. > > This Jira is about fixing the implementation of this service. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Closed] (OFBIZ-12732) Error in BlackList to DenyList migration service
[ https://issues.apache.org/jira/browse/OFBIZ-12732?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gil Portenseigne closed OFBIZ-12732. Resolution: Fixed > Error in BlackList to DenyList migration service > > > Key: OFBIZ-12732 > URL: https://issues.apache.org/jira/browse/OFBIZ-12732 > Project: OFBiz > Issue Type: Bug >Affects Versions: Upcoming Branch >Reporter: Gil Portenseigne >Assignee: Gil Portenseigne >Priority: Major > Fix For: 22.01.01 > > > While reviewing groovy files for codenarc integration i stumbled upon > OrderBlacklistServices.groovy that present some implementation issue. > > This Jira is about fixing the implementation of this service. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OFBIZ-9984) Convert OrderServices.xml mini-lang to groovyDSL
[ https://issues.apache.org/jira/browse/OFBIZ-9984?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17687808#comment-17687808 ] Gil Portenseigne commented on OFBIZ-9984: - Hello Jacques, IIRW it was not complete, only partly done, as [~sberg] offers to continue the work, i stopped working on it and got on other subject. [~sberg] do you intent to continue ? Thanks Gil > Convert OrderServices.xml mini-lang to groovyDSL > > > Key: OFBIZ-9984 > URL: https://issues.apache.org/jira/browse/OFBIZ-9984 > Project: OFBiz > Issue Type: Sub-task > Components: order >Affects Versions: Trunk, Upcoming Branch >Reporter: Julien NICOLAS >Assignee: Gil Portenseigne >Priority: Minor > Labels: groovy, mini-lang > Attachments: OFBIZ-9984-v1.patch, OFBIZ-9984.patch > > > With the purpose to deprecate mini-lang OFBIZ-9350, I tried to convert some > mini-lang service to groovy script. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Closed] (OFBIZ-11167) Use Codenarc to test Groovy code
[ https://issues.apache.org/jira/browse/OFBIZ-11167?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gil Portenseigne closed OFBIZ-11167. Fix Version/s: 22.01.01 Upcoming Branch Resolution: Implemented > Use Codenarc to test Groovy code > > > Key: OFBIZ-11167 > URL: https://issues.apache.org/jira/browse/OFBIZ-11167 > Project: OFBiz > Issue Type: New Feature > Components: framework >Reporter: Jacques Le Roux >Assignee: Gil Portenseigne >Priority: Minor > Fix For: 22.01.01, Upcoming Branch > > Attachments: OFBIZ-11167.patch, main.html, test.html > > > Thread of community discussion about the rules to implement : > https://www.mail-archive.com/search?l=dev%40ofbiz.apache.org&q=subject:%22Codenarc+integration%2C+rules+to+use.%22&o=newest&f=1 > > Now that we use Groovy more and more, I think we should really have a look a > Codenarc > [https://docs.gradle.org/current/userguide/codenarc_plugin.html] > We already discussed it at [https://markmail.org/message/uigcpnxqgizhd2oi] > and [https://markmail.org/message/rp6njoiohkkiodbe] > We know it's a crucial task but not an easy but rather a long term one > Here are some interesting links (before I delete my FF tabs group about it) > [http://codenarc.sourceforge.net/codenarc-other-tools-frameworks.html] > [http://codenarc.sourceforge.net/codenarc-creating-ruleset.html] > [https://github.com/gradle/gradle/tree/master/config] > [https://stackoverflow.com/questions/14358471/how-to-generate-codenarc-report-for-main-and-test-classes-using-different-rule-s] > [https://mrhaki.blogspot.com/2011/01/gradle-goodness-use-groovy-ruleset-file.html] -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OFBIZ-12801) Error at CommunicationEventServices.groovy:489 due to OFBIZ-11167
[
https://issues.apache.org/jira/browse/OFBIZ-12801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17713934#comment-17713934
]
Gil Portenseigne commented on OFBIZ-12801:
--
For this case I agree that the fix should be returning success at the end of
the service implementation.
I personally wondered about success method that can return two different types
depending of the context (request vs service), and I agree that any groovy
script implementation using this method are only of one type.
But I think that this particular implementation was intentional to avoid the
dev to think about being in service or event, and using success() in any
situation. (same with error method).
Quote of the commit message from Jacopo :
{quote}these helper methods have been enhanced in order to be used by groovy
method executed as services or events in a transparent way.
{quote}
With that intent in mind, codenarc-disable was set, i'm yet not sure that we
should remove that intent, that technically do not cause any issue apart from
having NoDef best practice not respected.
I guess that should be discussed in another Jira / mailing list :)
> Error at CommunicationEventServices.groovy:489 due to OFBIZ-11167
> --
>
> Key: OFBIZ-12801
> URL: https://issues.apache.org/jira/browse/OFBIZ-12801
> Project: OFBiz
> Issue Type: Bug
> Components: projectmgr
>Affects Versions: Upcoming Branch
> Environment:
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Major
> Fix For: Upcoming Branch
>
>
> I get this error locally:
> The Following Errors Occurred:
> Service dispatcher threw an exception:Error running Groovy method
> [sendEmailDated] in Groovy file
> [component://party/groovyScripts/communication/CommunicationEventServices.groovy]:
> (Cannot cast object '[]' with class 'java.util.ArrayList' to class
> 'java.util.Map' due to: groovy.lang.GroovyRuntimeException: Could not find
> matching constructor for: java.util.Map())
> When I replace
> Map sendEmailDated() {
> by
> def sendEmailDated() {
> The error disappears
> I guess something better can be done, but I have not yet found what :)
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (OFBIZ-12801) Error at CommunicationEventServices.groovy:489 due to OFBIZ-11167
[
https://issues.apache.org/jira/browse/OFBIZ-12801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17719844#comment-17719844
]
Gil Portenseigne commented on OFBIZ-12801:
--
Hello Jacques, Daniel,
While the discussion continue about GroovyBaseScript in dev mailing list, i
think we can agree for this case to move the return success() out of the each
block ?
Thanks,
Gil
> Error at CommunicationEventServices.groovy:489 due to OFBIZ-11167
> --
>
> Key: OFBIZ-12801
> URL: https://issues.apache.org/jira/browse/OFBIZ-12801
> Project: OFBiz
> Issue Type: Bug
> Components: projectmgr
>Affects Versions: Upcoming Branch
> Environment:
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Major
> Fix For: Upcoming Branch
>
>
> I get this error locally:
> The Following Errors Occurred:
> Service dispatcher threw an exception:Error running Groovy method
> [sendEmailDated] in Groovy file
> [component://party/groovyScripts/communication/CommunicationEventServices.groovy]:
> (Cannot cast object '[]' with class 'java.util.ArrayList' to class
> 'java.util.Map' due to: groovy.lang.GroovyRuntimeException: Could not find
> matching constructor for: java.util.Map())
> When I replace
> Map sendEmailDated() {
> by
> def sendEmailDated() {
> The error disappears
> I guess something better can be done, but I have not yet found what :)
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Closed] (OFBIZ-12801) Error at CommunicationEventServices.groovy:489 due to OFBIZ-11167
[
https://issues.apache.org/jira/browse/OFBIZ-12801?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gil Portenseigne closed OFBIZ-12801.
Resolution: Fixed
> Error at CommunicationEventServices.groovy:489 due to OFBIZ-11167
> --
>
> Key: OFBIZ-12801
> URL: https://issues.apache.org/jira/browse/OFBIZ-12801
> Project: OFBiz
> Issue Type: Bug
> Components: projectmgr
>Affects Versions: Upcoming Branch
> Environment:
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Major
> Fix For: Upcoming Branch
>
>
> I get this error locally:
> The Following Errors Occurred:
> Service dispatcher threw an exception:Error running Groovy method
> [sendEmailDated] in Groovy file
> [component://party/groovyScripts/communication/CommunicationEventServices.groovy]:
> (Cannot cast object '[]' with class 'java.util.ArrayList' to class
> 'java.util.Map' due to: groovy.lang.GroovyRuntimeException: Could not find
> matching constructor for: java.util.Map())
> When I replace
> Map sendEmailDated() {
> by
> def sendEmailDated() {
> The error disappears
> I guess something better can be done, but I have not yet found what :)
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
