[jira] [Commented] (OFBIZ-12726) Running integration tests under Gradle 7.6 and JDK 17 fails
[
https://issues.apache.org/jira/browse/OFBIZ-12726?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17803255#comment-17803255
]
Ioan Eugen Stan commented on OFBIZ-12726:
-
I did a bit of research and found out that ./gradlew "ofbiz --test
suitename=entitytests" fails.
It might be the thing that fails the other tests.
I believe it's caused because xstream does not work with Java 17:
[https://github.com/x-stream/xstream/issues/262] .
The recommended way to fix it is to do:
{color:#6aab73}'--add-opens=java.base/java.util=ALL-UNNAMED'
{color}{color:#7a7e85}// OFBIZ-12726{color}
which we already do.
There does not seem to be a way around this other than replaxing xstream with
something else.
So I believe this issue can be closed and we can move forward.
We could open a new issue, related to this where we can consider dropping
xstream in place of something else.
But I guess we can do that at a later time.
No need to change if we have a workaround that seems ok so far.
cc [~jleroux] , [~pgil] wdyt?
```
| |No converter available Debugging information message : No
converter available type : java.util.Collections$UnmodifiableMap converter :
com.thoughtworks.xstream.converters.reflection.ReflectionConverter message[1] :
Unable to make field private static final long
java.util.Collections$UnmodifiableMap.serialVersionUID accessible: module
java.base does not "opens java.util" to unnamed module @75eeccf5
---
```
{{com.thoughtworks.xstream.converters.ConversionException: No converter
available}}
{{ Debugging information
}}
{{message : No converter available
}}
{{type:
java.util.Collections$UnmodifiableMap}}
{{converter :
com.thoughtworks.xstream.converters.reflection.ReflectionConverter
}}
{{message[1] : Unable to make field
private static final long
java.util.Collections$UnmodifiableMap.serialVersionUID accessible:
module java.base does not "opens java.util" to unnamed module @75eeccf5
}}
```|
> Running integration tests under Gradle 7.6 and JDK 17 fails
> ---
>
> Key: OFBIZ-12726
> URL: https://issues.apache.org/jira/browse/OFBIZ-12726
> Project: OFBiz
> Issue Type: Sub-task
> Components: ALL COMPONENTS
>Affects Versions: 22.01.01
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Blocker
> Attachments: image-2023-12-05-16-52-38-822.png,
> image-2023-12-12-18-10-16-016.png, image-2024-01-04-18-27-42-512.png,
> image-2024-01-04-18-28-27-910.png
>
>
> Following our discussion at
> https://lists.apache.org/thread/kr4v21lxx493byzgpdrzfbz3whhbm82m I ran the
> integration tests and found that we currently have 322 errors and 190
> failures :/
> It's a blocker for releasing...
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (OFBIZ-12726) Running integration tests under Gradle 7.6 and JDK 17 fails
[ https://issues.apache.org/jira/browse/OFBIZ-12726?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17803239#comment-17803239 ] Ioan Eugen Stan commented on OFBIZ-12726: - So I can confirm what [~pgil] found. Running test only a single component - that normally fails - makes the tests pass. This is the result for running: ./gradlew cleanAll loadAll "ofbiz --test suitename=accountingtests" As you can see the accountingtests pass. !image-2024-01-04-18-27-42-512.png! And this is the result for running: "./gradlew cleanAll loadAll testIntegration" . As you can see the accountingtests fail. !image-2024-01-04-18-28-27-910.png! > Running integration tests under Gradle 7.6 and JDK 17 fails > --- > > Key: OFBIZ-12726 > URL: https://issues.apache.org/jira/browse/OFBIZ-12726 > Project: OFBiz > Issue Type: Sub-task > Components: ALL COMPONENTS >Affects Versions: 22.01.01 >Reporter: Jacques Le Roux >Assignee: Jacques Le Roux >Priority: Blocker > Attachments: image-2023-12-05-16-52-38-822.png, > image-2023-12-12-18-10-16-016.png, image-2024-01-04-18-27-42-512.png, > image-2024-01-04-18-28-27-910.png > > > Following our discussion at > https://lists.apache.org/thread/kr4v21lxx493byzgpdrzfbz3whhbm82m I ran the > integration tests and found that we currently have 322 errors and 190 > failures :/ > It's a blocker for releasing... -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (OFBIZ-12726) Running integration tests under Gradle 7.6 and JDK 17 fails
[ https://issues.apache.org/jira/browse/OFBIZ-12726?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ioan Eugen Stan updated OFBIZ-12726: Attachment: image-2024-01-04-18-28-27-910.png > Running integration tests under Gradle 7.6 and JDK 17 fails > --- > > Key: OFBIZ-12726 > URL: https://issues.apache.org/jira/browse/OFBIZ-12726 > Project: OFBiz > Issue Type: Sub-task > Components: ALL COMPONENTS >Affects Versions: 22.01.01 >Reporter: Jacques Le Roux >Assignee: Jacques Le Roux >Priority: Blocker > Attachments: image-2023-12-05-16-52-38-822.png, > image-2023-12-12-18-10-16-016.png, image-2024-01-04-18-27-42-512.png, > image-2024-01-04-18-28-27-910.png > > > Following our discussion at > https://lists.apache.org/thread/kr4v21lxx493byzgpdrzfbz3whhbm82m I ran the > integration tests and found that we currently have 322 errors and 190 > failures :/ > It's a blocker for releasing... -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (OFBIZ-12726) Running integration tests under Gradle 7.6 and JDK 17 fails
[ https://issues.apache.org/jira/browse/OFBIZ-12726?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ioan Eugen Stan updated OFBIZ-12726: Attachment: image-2024-01-04-18-27-42-512.png > Running integration tests under Gradle 7.6 and JDK 17 fails > --- > > Key: OFBIZ-12726 > URL: https://issues.apache.org/jira/browse/OFBIZ-12726 > Project: OFBiz > Issue Type: Sub-task > Components: ALL COMPONENTS >Affects Versions: 22.01.01 >Reporter: Jacques Le Roux >Assignee: Jacques Le Roux >Priority: Blocker > Attachments: image-2023-12-05-16-52-38-822.png, > image-2023-12-12-18-10-16-016.png, image-2024-01-04-18-27-42-512.png > > > Following our discussion at > https://lists.apache.org/thread/kr4v21lxx493byzgpdrzfbz3whhbm82m I ran the > integration tests and found that we currently have 322 errors and 190 > failures :/ > It's a blocker for releasing... -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OFBIZ-12722) Fix Java 17 two warning issues
[
https://issues.apache.org/jira/browse/OFBIZ-12722?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17803224#comment-17803224
]
Ioan Eugen Stan commented on OFBIZ-12722:
-
[~jleroux] : Any idea why the code was done the way Daniel mentioned?
> Resolving the deprecation of GroovyTestCase might be a bit complicated.
> Groovy test suites test specifications are read in
> _ModelTestSuite#parseTestElements:_
> Fix Java 17 two warning issues
> --
>
> Key: OFBIZ-12722
> URL: https://issues.apache.org/jira/browse/OFBIZ-12722
> Project: OFBiz
> Issue Type: Sub-task
> Components: base, testtools
>Affects Versions: Upcoming Branch
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Minor
>
> AuthHelper.java:132: warning: [removal] AccessController in java.security has
> been deprecated and marked for removal
> return AccessController.doPrivileged(
>^
> GroovyScriptTestCase.java:29: warning: [deprecation] GroovyTestCase in
> groovy.util has been deprecated
> public class GroovyScriptTestCase extends GroovyTestCase {
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (OFBIZ-12722) Fix Java 17 two warning issues
[
https://issues.apache.org/jira/browse/OFBIZ-12722?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17803221#comment-17803221
]
Ioan Eugen Stan commented on OFBIZ-12722:
-
I took a look at fixing the groovy warning - no luck yet - the code there is
pretty complex.
If we have a solution for AuthHelper, we should try it out.
Maybe we can get this done for 24.01 ?!
> Fix Java 17 two warning issues
> --
>
> Key: OFBIZ-12722
> URL: https://issues.apache.org/jira/browse/OFBIZ-12722
> Project: OFBiz
> Issue Type: Sub-task
> Components: base, testtools
>Affects Versions: Upcoming Branch
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Minor
>
> AuthHelper.java:132: warning: [removal] AccessController in java.security has
> been deprecated and marked for removal
> return AccessController.doPrivileged(
>^
> GroovyScriptTestCase.java:29: warning: [deprecation] GroovyTestCase in
> groovy.util has been deprecated
> public class GroovyScriptTestCase extends GroovyTestCase {
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (OFBIZ-12868) Replace SvnCheckout in Gradle
[ https://issues.apache.org/jira/browse/OFBIZ-12868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17802286#comment-17802286 ] Ioan Eugen Stan commented on OFBIZ-12868: - [~jleroux] github might do a shallow clone : [https://github.blog/2020-12-21-get-up-to-speed-with-partial-clone-and-shallow-clone/] > Replace SvnCheckout in Gradle > - > > Key: OFBIZ-12868 > URL: https://issues.apache.org/jira/browse/OFBIZ-12868 > Project: OFBiz > Issue Type: Task > Components: GitHub, Gradle >Affects Versions: 22.01.01, Upcoming Branch, 18.12.10 >Reporter: Jacques Le Roux >Assignee: Jacques Le Roux >Priority: Blocker > Fix For: 22.01.01, Upcoming Branch, 18.12.12, 22.01 > > Attachments: OFBIZ-12868-README.patch, OFBIZ-12868-svncheckout.patch, > pullAllPluginsSource.bat, pullAllPluginsSource.sh, pullPluginSource.bat, > pullPluginSource.sh > > > As mentionned in > https://lists.apache.org/thread/on7n6nsbj0w237sqgmw7bfmw31116wcy > the SvnCheckout Gradle plugin will not be usable after January 8, 2024. > So we need a replacement and it's clearly suggested by GitHub in the link > above -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OFBIZ-12726) Running integration tests under Gradle 7.6 and JDK 17 fails
[ https://issues.apache.org/jira/browse/OFBIZ-12726?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17795933#comment-17795933 ] Ioan Eugen Stan commented on OFBIZ-12726: - Thank you [~pgil] , I have put a pause on this issue as I am waiting fro a review on [https://github.com/apache/ofbiz-framework/pull/678] . I believe building libraries from ofbiz pieces can help with clarify dependencies and after some time improve the testing support - my moving the code to more standard testing practices. Perhaps we could have an embedded in-memory ofbiz for testing - like we have now, but better defined in terms of dependencies. I believe now it's an all or nothing scenario. > Running integration tests under Gradle 7.6 and JDK 17 fails > --- > > Key: OFBIZ-12726 > URL: https://issues.apache.org/jira/browse/OFBIZ-12726 > Project: OFBiz > Issue Type: Sub-task > Components: ALL COMPONENTS >Affects Versions: 22.01.01 >Reporter: Jacques Le Roux >Assignee: Jacques Le Roux >Priority: Blocker > Attachments: image-2023-12-05-16-52-38-822.png, > image-2023-12-12-18-10-16-016.png > > > Following our discussion at > https://lists.apache.org/thread/kr4v21lxx493byzgpdrzfbz3whhbm82m I ran the > integration tests and found that we currently have 322 errors and 190 > failures :/ > It's a blocker for releasing... -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OFBIZ-12726) Running integration tests under Gradle 7.6 and JDK 17 fails
[ https://issues.apache.org/jira/browse/OFBIZ-12726?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17793932#comment-17793932 ] Ioan Eugen Stan commented on OFBIZ-12726: - Thank you. I managed to run it in debug. I am more used to right click inside test and select Run/Debug option. Maybe we can make this happen in the future. It's a nicer experience. > Running integration tests under Gradle 7.6 and JDK 17 fails > --- > > Key: OFBIZ-12726 > URL: https://issues.apache.org/jira/browse/OFBIZ-12726 > Project: OFBiz > Issue Type: Sub-task > Components: ALL COMPONENTS >Affects Versions: 22.01.01 >Reporter: Jacques Le Roux >Assignee: Jacques Le Roux >Priority: Blocker > Attachments: image-2023-12-05-16-52-38-822.png > > > Following our discussion at > https://lists.apache.org/thread/kr4v21lxx493byzgpdrzfbz3whhbm82m I ran the > integration tests and found that we currently have 322 errors and 190 > failures :/ > It's a blocker for releasing... -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OFBIZ-12308) Remove circular dependency between start and base components
[ https://issues.apache.org/jira/browse/OFBIZ-12308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17793756#comment-17793756 ] Ioan Eugen Stan commented on OFBIZ-12308: - A potential solution on how to approach this task is given in [https://github.com/apache/ofbiz-framework/pull/678] > Remove circular dependency between start and base components > > > Key: OFBIZ-12308 > URL: https://issues.apache.org/jira/browse/OFBIZ-12308 > Project: OFBiz > Issue Type: Sub-task > Components: base, start >Reporter: Ioan Eugen Stan >Priority: Major > > Right now start and base components depend one on the other. > This should be resolved so that only 1 component should depend on the other. > *Guidance needed.* > Not sure right now if start should depend on base or the reverse. > This was discovered as part of exploratory branch > [https://github.com/apache/ofbiz-framework/pull/319] . > I believe a logical dependency tree for components is needed. > This dependency tree will help guide people when needing to decide which > component should depend on which. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (OFBIZ-12870) Remove DES encryption from ofbiz crypto - insecure algorithm
Ioan Eugen Stan created OFBIZ-12870: --- Summary: Remove DES encryption from ofbiz crypto - insecure algorithm Key: OFBIZ-12870 URL: https://issues.apache.org/jira/browse/OFBIZ-12870 Project: OFBiz Issue Type: Bug Components: framework/base Reporter: Ioan Eugen Stan In my opinion OFBiz should remove or deprecate and remove the implementation for DES crypto - class org.apache.ofbiz.base.crypto.DesCrypt . DES encryption is broken and insecure to my knowledge [https://en.wikipedia.org/wiki/Data_Encryption_Standard] [https://www.techtarget.com/searchsecurity/tip/Expert-advice-Encryption-101-Triple-DES-explained] [https://docs.oracle.com/en/java/javase/11/docs/specs/security/standard-names.html] In my opinion - it should be removed from the code in new releases. If people have data encrypted with this they should migrate somehow. Probably via an export-import? -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Comment Edited] (OFBIZ-12726) Running integration tests under Gradle 7.6 and JDK 17 fails
[
https://issues.apache.org/jira/browse/OFBIZ-12726?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17793365#comment-17793365
]
Ioan Eugen Stan edited comment on OFBIZ-12726 at 12/5/23 5:19 PM:
--
I would like to know how to run the test from IDE as it's not very clear to me.
I have the this test failing
|[accountingtests|http://localhost:63342/1_accountingtests.html]|
[accounting-tests-data-load|http://localhost:63342/1_accountingtests.html#accounting-tests-data-load]|Error|
with the following error, but it does not tell me where in the code the test is
failing.
{noformat}
A transaction error occurred reading data
org.xml.sax.SAXException: A transaction error occurred
reading data
org.apache.ofbiz.entity.transaction.GenericTransactionException: The
current transaction is marked for rollback, not beginning a new
transaction and aborting current operation; the rollbackOnly was caused
by: Failure in create operation for entity [TestingCrypto]:
java.lang.IllegalStateException: This object has been flagged as
immutable (unchangeable), probably because it came from an Entity Engine
cache. Cannot modify an immutable entity object. Use the clone method
to create a mutable copy of this object.. Rolling back
transaction.java.lang.IllegalStateException: This object has been
flagged as immutable (unchangeable), probably because it came from an
Entity Engine cache. Cannot modify an immutable entity object. Use the
clone method to create a mutable copy of this object. (This object has
been flagged as immutable (unchangeable), probably because it came from
an Entity Engine cache. Cannot modify an immutable entity object. Use
the clone method to create a mutable copy of this object.)
at
org.apache.ofbiz.entity.util.EntitySaxReader.parse(EntitySaxReader.java:299)
at
org.apache.ofbiz.entity.util.EntitySaxReader.parse(EntitySaxReader.java:261)
at
org.apache.ofbiz.testtools.EntityXmlAssertTest.run(EntityXmlAssertTest.java:80)
at
org.apache.ofbiz.testtools.TestRunContainer.start(TestRunContainer.java:90)
at
org.apache.ofbiz.base.container.ContainerLoader.startLoadedContainers(ContainerLoader.java:153)
at
org.apache.ofbiz.base.container.ContainerLoader.load(ContainerLoader.java:77)
at
org.apache.ofbiz.base.start.StartupControlPanel.loadContainers(StartupControlPanel.java:146)
at
org.apache.ofbiz.base.start.StartupControlPanel.start(StartupControlPanel.java:70)
at
org.apache.ofbiz.base.start.Start.main(Start.java:89)
Caused by:
org.apache.ofbiz.entity.transaction.GenericTransactionException: The
current transaction is marked for rollback, not beginning a new
transaction and aborting current operation; the rollbackOnly was caused
by: Failure in create operation for entity [TestingCrypto]:
java.lang.IllegalStateException: This object has been flagged as
immutable (unchangeable), probably because it came from an Entity Engine
cache. Cannot modify an immutable entity object. Use the clone method
to create a mutable copy of this object.. Rolling back
transaction.java.lang.IllegalStateException: This object has been
flagged as immutable (unchangeable), probably because it came from an
Entity Engine cache. Cannot modify an immutable entity object. Use the
clone method to create a mutable copy of this object. (This object has
been flagged as immutable (unchangeable), probably because it came from
an Entity Engine cache. Cannot modify an immutable entity object. Use
the clone method to create a mutable copy of this object.)
at
org.apache.ofbiz.entity.transaction.TransactionUtil.begin(TransactionUtil.java:143)
at
org.apache.ofbiz.entity.util.EntitySaxReader.parse(EntitySaxReader.java:277)
Caused by: java.lang.IllegalStateException: This
object has been flagged as immutable (unchangeable), probably because
it came from an Entity Engine cache. Cannot modify an immutable entity
object. Use the clone method to create a mutable copy of this object.
at
org.apache.ofbiz.entity.GenericEntity.assertIsMutable(GenericEntity.java:165)
at
org.apache.ofbiz.entity.GenericEntity.setDelegator(GenericEntity.java:408)
at
org.apache.ofbiz.entity.GenericDelegator.create(GenericDelegator.java:890)
at
org.apache.ofbiz.entity.GenericDelegator.rollback(GenericDelegator.java:2715)
at
[jira] [Commented] (OFBIZ-12726) Running integration tests under Gradle 7.6 and JDK 17 fails
[
https://issues.apache.org/jira/browse/OFBIZ-12726?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17793365#comment-17793365
]
Ioan Eugen Stan commented on OFBIZ-12726:
-
I would like to know how to run the test from IDE as it's not very clear to me.
I have
{noformat}
A transaction error occurred reading data
org.xml.sax.SAXException: A transaction error occurred
reading data
org.apache.ofbiz.entity.transaction.GenericTransactionException: The
current transaction is marked for rollback, not beginning a new
transaction and aborting current operation; the rollbackOnly was caused
by: Failure in create operation for entity [TestingCrypto]:
java.lang.IllegalStateException: This object has been flagged as
immutable (unchangeable), probably because it came from an Entity Engine
cache. Cannot modify an immutable entity object. Use the clone method
to create a mutable copy of this object.. Rolling back
transaction.java.lang.IllegalStateException: This object has been
flagged as immutable (unchangeable), probably because it came from an
Entity Engine cache. Cannot modify an immutable entity object. Use the
clone method to create a mutable copy of this object. (This object has
been flagged as immutable (unchangeable), probably because it came from
an Entity Engine cache. Cannot modify an immutable entity object. Use
the clone method to create a mutable copy of this object.)
at
org.apache.ofbiz.entity.util.EntitySaxReader.parse(EntitySaxReader.java:299)
at
org.apache.ofbiz.entity.util.EntitySaxReader.parse(EntitySaxReader.java:261)
at
org.apache.ofbiz.testtools.EntityXmlAssertTest.run(EntityXmlAssertTest.java:80)
at
org.apache.ofbiz.testtools.TestRunContainer.start(TestRunContainer.java:90)
at
org.apache.ofbiz.base.container.ContainerLoader.startLoadedContainers(ContainerLoader.java:153)
at
org.apache.ofbiz.base.container.ContainerLoader.load(ContainerLoader.java:77)
at
org.apache.ofbiz.base.start.StartupControlPanel.loadContainers(StartupControlPanel.java:146)
at
org.apache.ofbiz.base.start.StartupControlPanel.start(StartupControlPanel.java:70)
at
org.apache.ofbiz.base.start.Start.main(Start.java:89)
Caused by:
org.apache.ofbiz.entity.transaction.GenericTransactionException: The
current transaction is marked for rollback, not beginning a new
transaction and aborting current operation; the rollbackOnly was caused
by: Failure in create operation for entity [TestingCrypto]:
java.lang.IllegalStateException: This object has been flagged as
immutable (unchangeable), probably because it came from an Entity Engine
cache. Cannot modify an immutable entity object. Use the clone method
to create a mutable copy of this object.. Rolling back
transaction.java.lang.IllegalStateException: This object has been
flagged as immutable (unchangeable), probably because it came from an
Entity Engine cache. Cannot modify an immutable entity object. Use the
clone method to create a mutable copy of this object. (This object has
been flagged as immutable (unchangeable), probably because it came from
an Entity Engine cache. Cannot modify an immutable entity object. Use
the clone method to create a mutable copy of this object.)
at
org.apache.ofbiz.entity.transaction.TransactionUtil.begin(TransactionUtil.java:143)
at
org.apache.ofbiz.entity.util.EntitySaxReader.parse(EntitySaxReader.java:277)
Caused by: java.lang.IllegalStateException: This
object has been flagged as immutable (unchangeable), probably because
it came from an Entity Engine cache. Cannot modify an immutable entity
object. Use the clone method to create a mutable copy of this object.
at
org.apache.ofbiz.entity.GenericEntity.assertIsMutable(GenericEntity.java:165)
at
org.apache.ofbiz.entity.GenericEntity.setDelegator(GenericEntity.java:408)
at
org.apache.ofbiz.entity.GenericDelegator.create(GenericDelegator.java:890)
at
org.apache.ofbiz.entity.GenericDelegator.rollback(GenericDelegator.java:2715)
at
org.apache.ofbiz.testtools.TestRunContainer.start(TestRunContainer.java:92){noformat}
> Running integration tests under Gradle 7.6 and JDK 17 fails
> ---
>
> Key: OFBIZ-12726
> URL: https://issues.apache.org/jira/browse/OFBIZ-12726
> Project: OFBiz
> Issue Type: Sub-task
>
[jira] [Commented] (OFBIZ-12726) Running integration tests under Gradle 7.6 and JDK 17 fails
[ https://issues.apache.org/jira/browse/OFBIZ-12726?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17793313#comment-17793313 ] Ioan Eugen Stan commented on OFBIZ-12726: - How can i see the tests failures? I ran ``` $ ./gradlew cleanAll loadAll testIntegration ``` and opened [http://localhost:63342/ofbiz/runtime/logs/test-results/html/index.html . |http://localhost:63342/ofbiz/runtime/logs/test-results/html/index.html?_ijt=ejmrh78bnvnoueqi03h7pqd2ut&_ij_reload=RELOAD_ON_SAVE] I got !image-2023-12-05-16-52-38-822.png! > Running integration tests under Gradle 7.6 and JDK 17 fails > --- > > Key: OFBIZ-12726 > URL: https://issues.apache.org/jira/browse/OFBIZ-12726 > Project: OFBiz > Issue Type: Sub-task > Components: ALL COMPONENTS >Affects Versions: 22.01.01 >Reporter: Jacques Le Roux >Assignee: Jacques Le Roux >Priority: Blocker > Attachments: image-2023-12-05-16-52-38-822.png > > > Following our discussion at > https://lists.apache.org/thread/kr4v21lxx493byzgpdrzfbz3whhbm82m I ran the > integration tests and found that we currently have 322 errors and 190 > failures :/ > It's a blocker for releasing... -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (OFBIZ-12726) Running integration tests under Gradle 7.6 and JDK 17 fails
[ https://issues.apache.org/jira/browse/OFBIZ-12726?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ioan Eugen Stan updated OFBIZ-12726: Attachment: image-2023-12-05-16-52-38-822.png > Running integration tests under Gradle 7.6 and JDK 17 fails > --- > > Key: OFBIZ-12726 > URL: https://issues.apache.org/jira/browse/OFBIZ-12726 > Project: OFBiz > Issue Type: Sub-task > Components: ALL COMPONENTS >Affects Versions: 22.01.01 >Reporter: Jacques Le Roux >Assignee: Jacques Le Roux >Priority: Blocker > Attachments: image-2023-12-05-16-52-38-822.png > > > Following our discussion at > https://lists.apache.org/thread/kr4v21lxx493byzgpdrzfbz3whhbm82m I ran the > integration tests and found that we currently have 322 errors and 190 > failures :/ > It's a blocker for releasing... -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OFBIZ-12721) Replace all occurrences of java.util.TimeZone by java.time.ZoneId
[
https://issues.apache.org/jira/browse/OFBIZ-12721?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17792605#comment-17792605
]
Ioan Eugen Stan commented on OFBIZ-12721:
-
Provided a PR [~jleroux] . I think we can close this one finally.
> Replace all occurrences of java.util.TimeZone by java.time.ZoneId
> -
>
> Key: OFBIZ-12721
> URL: https://issues.apache.org/jira/browse/OFBIZ-12721
> Project: OFBiz
> Issue Type: Sub-task
> Components: ALL COMPONENTS
>Affects Versions: Upcoming Branch
> Environment: Java 17
>Reporter: Jacques Le Roux
>Assignee: Ioan Eugen Stan
>Priority: Major
>
> Using JDK 17, we have this issue:
> {noformat}
> 2022-12-06 19:04:30,689 |sse-nio-8443-exec-10 |FreeMarkerWorker
> |E| null
> freemarker.core._TemplateModelException: Java method
> "sun.util.calendar.ZoneInfo.useDaylightTime()" threw an exception when
> invoked on sun.util.calendar.ZoneInfo object
> "sun.util.calendar.ZoneInfo[id=\"Europe/Paris\",offset=360,dstSa
> vings=360,useDaylight=true,transitions=184,lastRule=java.util.SimpleTimeZone[id=Europe/Paris,offset=360,dstSavings=360,useDaylight=true,startYear=0,startMode=2,startMonth=2,startDay=-1,startDayOfWeek=1,startTime=360,start
> TimeMode=2,endMode=2,endMonth=9,endDay=-1,endDayOfWeek=1,endTime=360,endTimeMode=2]]";
> see cause exception in the Java stack trace.
>
> FTL stack trace ("~" means nesting-related):
> - Failed at: ${timeZone.getDisplayName(timeZone.us... [in template
> "component://helveticus/template/includes/Footer.ftl" at line 21, column 98]
>
> at
> freemarker.ext.beans._MethodUtil.newInvocationTemplateModelException(_MethodUtil.java:292)
> ~[freemarker-2.3.31.jar:2.3.31]
> [...]
> Caused by: java.lang.IllegalAccessException: class
> freemarker.ext.beans.BeansWrapper cannot access class
> sun.util.calendar.ZoneInfo (in module java.base) because module java.base
> does not export sun.util.calendar to unnamed module @1c852c0f
> at
> jdk.internal.reflect.Reflection.newIllegalAccessException(Reflection.java:392)
> ~[?:?]
> at
> java.lang.reflect.AccessibleObject.checkAccess(AccessibleObject.java:674)
> ~[?:?]
> at java.lang.reflect.Method.invoke(Method.java:560) ~[?:?]
> at
> freemarker.ext.beans.BeansWrapper.invokeMethod(BeansWrapper.java:1552)
> ~[freemarker-2.3.31.jar:2.3.31]
> at
> freemarker.ext.beans.SimpleMethodModel.exec(SimpleMethodModel.java:73)
> ~[freemarker-2.3.31.jar:2.3.31]
> ... 85 more
> {noformat}
> [The var timeZone is accessible in screen
> context|https://cwiki.apache.org/confluence/display/OFBIZ/Variables+always+available+in+screen+context].
> The java.util.TimeZone class uses sun.util.calendar.ZoneInfo internally.
> It's no longer supported by Java 17. We need to replace all occurrences of
> java.util.TimeZone by java.time.ZoneId.
> An easy temporary solution is to set
> {{--add-exports=java.base/sun.util.calendar=ALL-UNNAMED}} in build.gradle:
> :
> ['-Xms128M','-Xmx1024M','-Djdk.serialFilter=maxarray=10;maxdepth=20;maxrefs=1000;maxbytes=50','--add-exports=java.base/sun.util.calendar=ALL-UNNAMED']
> It has no impact with JDK 11.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (OFBIZ-12721) Replace all occurrences of java.util.TimeZone by java.time.ZoneId
[
https://issues.apache.org/jira/browse/OFBIZ-12721?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17792603#comment-17792603
]
Ioan Eugen Stan commented on OFBIZ-12721:
-
Apparently this works:
${timeZone.toZoneId().getDisplayName(Static["java.time.format.TextStyle"].FULL,
locale)}
> Replace all occurrences of java.util.TimeZone by java.time.ZoneId
> -
>
> Key: OFBIZ-12721
> URL: https://issues.apache.org/jira/browse/OFBIZ-12721
> Project: OFBiz
> Issue Type: Sub-task
> Components: ALL COMPONENTS
>Affects Versions: Upcoming Branch
> Environment: Java 17
>Reporter: Jacques Le Roux
>Assignee: Ioan Eugen Stan
>Priority: Major
>
> Using JDK 17, we have this issue:
> {noformat}
> 2022-12-06 19:04:30,689 |sse-nio-8443-exec-10 |FreeMarkerWorker
> |E| null
> freemarker.core._TemplateModelException: Java method
> "sun.util.calendar.ZoneInfo.useDaylightTime()" threw an exception when
> invoked on sun.util.calendar.ZoneInfo object
> "sun.util.calendar.ZoneInfo[id=\"Europe/Paris\",offset=360,dstSa
> vings=360,useDaylight=true,transitions=184,lastRule=java.util.SimpleTimeZone[id=Europe/Paris,offset=360,dstSavings=360,useDaylight=true,startYear=0,startMode=2,startMonth=2,startDay=-1,startDayOfWeek=1,startTime=360,start
> TimeMode=2,endMode=2,endMonth=9,endDay=-1,endDayOfWeek=1,endTime=360,endTimeMode=2]]";
> see cause exception in the Java stack trace.
>
> FTL stack trace ("~" means nesting-related):
> - Failed at: ${timeZone.getDisplayName(timeZone.us... [in template
> "component://helveticus/template/includes/Footer.ftl" at line 21, column 98]
>
> at
> freemarker.ext.beans._MethodUtil.newInvocationTemplateModelException(_MethodUtil.java:292)
> ~[freemarker-2.3.31.jar:2.3.31]
> [...]
> Caused by: java.lang.IllegalAccessException: class
> freemarker.ext.beans.BeansWrapper cannot access class
> sun.util.calendar.ZoneInfo (in module java.base) because module java.base
> does not export sun.util.calendar to unnamed module @1c852c0f
> at
> jdk.internal.reflect.Reflection.newIllegalAccessException(Reflection.java:392)
> ~[?:?]
> at
> java.lang.reflect.AccessibleObject.checkAccess(AccessibleObject.java:674)
> ~[?:?]
> at java.lang.reflect.Method.invoke(Method.java:560) ~[?:?]
> at
> freemarker.ext.beans.BeansWrapper.invokeMethod(BeansWrapper.java:1552)
> ~[freemarker-2.3.31.jar:2.3.31]
> at
> freemarker.ext.beans.SimpleMethodModel.exec(SimpleMethodModel.java:73)
> ~[freemarker-2.3.31.jar:2.3.31]
> ... 85 more
> {noformat}
> [The var timeZone is accessible in screen
> context|https://cwiki.apache.org/confluence/display/OFBIZ/Variables+always+available+in+screen+context].
> The java.util.TimeZone class uses sun.util.calendar.ZoneInfo internally.
> It's no longer supported by Java 17. We need to replace all occurrences of
> java.util.TimeZone by java.time.ZoneId.
> An easy temporary solution is to set
> {{--add-exports=java.base/sun.util.calendar=ALL-UNNAMED}} in build.gradle:
> :
> ['-Xms128M','-Xmx1024M','-Djdk.serialFilter=maxarray=10;maxdepth=20;maxrefs=1000;maxbytes=50','--add-exports=java.base/sun.util.calendar=ALL-UNNAMED']
> It has no impact with JDK 11.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (OFBIZ-12721) Replace all occurrences of java.util.TimeZone by java.time.ZoneId
[
https://issues.apache.org/jira/browse/OFBIZ-12721?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17792602#comment-17792602
]
Ioan Eugen Stan commented on OFBIZ-12721:
-
The issue here is with the call to `useDaylightTime` which calls an internal
API: `sun.util.calendar.ZoneInfo` .
```
${timeZone.getDisplayName(timeZone.useDaylightTime(),
Static["java.util.TimeZone"].LONG, locale)}
```
The call is used when getting the display name for the timezone.
We can get the display name for the timezone in other ways to avoid the call to
useDaylightTime .
I used this code to convert to ZoneId which has an API for display name :
[https://docs.oracle.com/en/java/javase/17/docs/api/java.base/java/time/ZoneId.html#getDisplayName(java.time.format.TextStyle,java.util.Locale)]
.
```
${timeZone.toZoneId()}
```
However the API needs
[https://docs.oracle.com/en/java/javase/17/docs/api/java.base/java/time/format/TextStyle.html]
which I don't know how to use in FreeMarker :D .
Something like this ( I would setup a template helper method perhaps)
```
timeZone.toZoneId().getDisplayName(java.time.format.TextStyle.FULL, locale)
```
Running this code in jshell works
```
jshell>
java.util.TimeZone.getDefault().toZoneId().getDisplayName(java.time.format.TextStyle.FULL,
java.util.Locale.forLanguageTag("ro-RO"))
$2 ==> "Ora Europei de Est"
```
However, not going through the displayName is better IMO:
```
jshell> java.util.TimeZone.getDefault().toZoneId()
$1 ==> Europe/Bucharest
```
> Replace all occurrences of java.util.TimeZone by java.time.ZoneId
> -
>
> Key: OFBIZ-12721
> URL: https://issues.apache.org/jira/browse/OFBIZ-12721
> Project: OFBiz
> Issue Type: Sub-task
> Components: ALL COMPONENTS
>Affects Versions: Upcoming Branch
> Environment: Java 17
>Reporter: Jacques Le Roux
>Assignee: Ioan Eugen Stan
>Priority: Major
>
> Using JDK 17, we have this issue:
> {noformat}
> 2022-12-06 19:04:30,689 |sse-nio-8443-exec-10 |FreeMarkerWorker
> |E| null
> freemarker.core._TemplateModelException: Java method
> "sun.util.calendar.ZoneInfo.useDaylightTime()" threw an exception when
> invoked on sun.util.calendar.ZoneInfo object
> "sun.util.calendar.ZoneInfo[id=\"Europe/Paris\",offset=360,dstSa
> vings=360,useDaylight=true,transitions=184,lastRule=java.util.SimpleTimeZone[id=Europe/Paris,offset=360,dstSavings=360,useDaylight=true,startYear=0,startMode=2,startMonth=2,startDay=-1,startDayOfWeek=1,startTime=360,start
> TimeMode=2,endMode=2,endMonth=9,endDay=-1,endDayOfWeek=1,endTime=360,endTimeMode=2]]";
> see cause exception in the Java stack trace.
>
> FTL stack trace ("~" means nesting-related):
> - Failed at: ${timeZone.getDisplayName(timeZone.us... [in template
> "component://helveticus/template/includes/Footer.ftl" at line 21, column 98]
>
> at
> freemarker.ext.beans._MethodUtil.newInvocationTemplateModelException(_MethodUtil.java:292)
> ~[freemarker-2.3.31.jar:2.3.31]
> [...]
> Caused by: java.lang.IllegalAccessException: class
> freemarker.ext.beans.BeansWrapper cannot access class
> sun.util.calendar.ZoneInfo (in module java.base) because module java.base
> does not export sun.util.calendar to unnamed module @1c852c0f
> at
> jdk.internal.reflect.Reflection.newIllegalAccessException(Reflection.java:392)
> ~[?:?]
> at
> java.lang.reflect.AccessibleObject.checkAccess(AccessibleObject.java:674)
> ~[?:?]
> at java.lang.reflect.Method.invoke(Method.java:560) ~[?:?]
> at
> freemarker.ext.beans.BeansWrapper.invokeMethod(BeansWrapper.java:1552)
> ~[freemarker-2.3.31.jar:2.3.31]
> at
> freemarker.ext.beans.SimpleMethodModel.exec(SimpleMethodModel.java:73)
> ~[freemarker-2.3.31.jar:2.3.31]
> ... 85 more
> {noformat}
> [The var timeZone is accessible in screen
> context|https://cwiki.apache.org/confluence/display/OFBIZ/Variables+always+available+in+screen+context].
> The java.util.TimeZone class uses sun.util.calendar.ZoneInfo internally.
> It's no longer supported by Java 17. We need to replace all occurrences of
> java.util.TimeZone by java.time.ZoneId.
> An easy temporary solution is to set
> {{--add-exports=java.base/sun.util.calendar=ALL-UNNAMED}} in build.gradle:
> :
> ['-Xms128M','-Xmx1024M','-Djdk.serialFilter=maxarray=10;maxdepth=20;maxrefs=1000;maxbytes=50','--add-exports=java.base/sun.util.calendar=ALL-UNNAMED']
> It has no impact with JDK 11.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (OFBIZ-12400) Upgrade to gradle 7.6 - support JDK 11 -> 17
[ https://issues.apache.org/jira/browse/OFBIZ-12400?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17792598#comment-17792598 ] Ioan Eugen Stan commented on OFBIZ-12400: - Hi, What is the holdup with this issue? Java 21 is out so it's Java 17 is already old :) . I might get some time to look at ofbiz and try to build some datasets for Romanian - so I can use it. > Upgrade to gradle 7.6 - support JDK 11 -> 17 > > > Key: OFBIZ-12400 > URL: https://issues.apache.org/jira/browse/OFBIZ-12400 > Project: OFBiz > Issue Type: Task >Reporter: Ioan Eugen Stan >Assignee: Ioan Eugen Stan >Priority: Major > Attachments: OFBIZ-12400-windows-binary.patch > > > For working with Java 17, we need to upgrade to gradle 7.3 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OFBIZ-12726) Running integration tests under Gradle 7.6 and JDK 17 fails
[ https://issues.apache.org/jira/browse/OFBIZ-12726?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17650848#comment-17650848 ] Ioan Eugen Stan commented on OFBIZ-12726: - I did not have time to work on https://issues.apache.org/jira/browse/OFBIZ-12721 . I hope to get some time next week. Would love to see OFBiz with jdk17 > Running integration tests under Gradle 7.6 and JDK 17 fails > --- > > Key: OFBIZ-12726 > URL: https://issues.apache.org/jira/browse/OFBIZ-12726 > Project: OFBiz > Issue Type: Sub-task > Components: ALL COMPONENTS >Affects Versions: 22.01.01 >Reporter: Jacques Le Roux >Assignee: Jacques Le Roux >Priority: Blocker > Fix For: Upcoming Branch > > > Following our discussion at > https://lists.apache.org/thread/kr4v21lxx493byzgpdrzfbz3whhbm82m I ran the > integration tests and found that we currently have 322 errors and 190 > failures :/ > It's a blocker for releasing... -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OFBIZ-12721) Replace all occurrences of java.util.TimeZone by java.time.ZoneId
[
https://issues.apache.org/jira/browse/OFBIZ-12721?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17644691#comment-17644691
]
Ioan Eugen Stan commented on OFBIZ-12721:
-
Freemarker added a special variablefor time zone since 2.3.31
> Added new special variable, time_zone (referred like .time_zone, like all
> special variables), to retrieve the current value of the time_zone setting as
> a string.
Should we use that ?
[https://freemarker.apache.org/docs/versions_2_3_31.html] .
> Replace all occurrences of java.util.TimeZone by java.time.ZoneId
> -
>
> Key: OFBIZ-12721
> URL: https://issues.apache.org/jira/browse/OFBIZ-12721
> Project: OFBiz
> Issue Type: Sub-task
> Components: ALL COMPONENTS
>Affects Versions: Upcoming Branch
> Environment: Java 17
>Reporter: Jacques Le Roux
>Assignee: Ioan Eugen Stan
>Priority: Major
>
> Using JDK 17, we have this issue:
> {noformat}
> 2022-12-06 19:04:30,689 |sse-nio-8443-exec-10 |FreeMarkerWorker
> |E| null
> freemarker.core._TemplateModelException: Java method
> "sun.util.calendar.ZoneInfo.useDaylightTime()" threw an exception when
> invoked on sun.util.calendar.ZoneInfo object
> "sun.util.calendar.ZoneInfo[id=\"Europe/Paris\",offset=360,dstSa
> vings=360,useDaylight=true,transitions=184,lastRule=java.util.SimpleTimeZone[id=Europe/Paris,offset=360,dstSavings=360,useDaylight=true,startYear=0,startMode=2,startMonth=2,startDay=-1,startDayOfWeek=1,startTime=360,start
> TimeMode=2,endMode=2,endMonth=9,endDay=-1,endDayOfWeek=1,endTime=360,endTimeMode=2]]";
> see cause exception in the Java stack trace.
>
> FTL stack trace ("~" means nesting-related):
> - Failed at: ${timeZone.getDisplayName(timeZone.us... [in template
> "component://helveticus/template/includes/Footer.ftl" at line 21, column 98]
>
> at
> freemarker.ext.beans._MethodUtil.newInvocationTemplateModelException(_MethodUtil.java:292)
> ~[freemarker-2.3.31.jar:2.3.31]
> [...]
> Caused by: java.lang.IllegalAccessException: class
> freemarker.ext.beans.BeansWrapper cannot access class
> sun.util.calendar.ZoneInfo (in module java.base) because module java.base
> does not export sun.util.calendar to unnamed module @1c852c0f
> at
> jdk.internal.reflect.Reflection.newIllegalAccessException(Reflection.java:392)
> ~[?:?]
> at
> java.lang.reflect.AccessibleObject.checkAccess(AccessibleObject.java:674)
> ~[?:?]
> at java.lang.reflect.Method.invoke(Method.java:560) ~[?:?]
> at
> freemarker.ext.beans.BeansWrapper.invokeMethod(BeansWrapper.java:1552)
> ~[freemarker-2.3.31.jar:2.3.31]
> at
> freemarker.ext.beans.SimpleMethodModel.exec(SimpleMethodModel.java:73)
> ~[freemarker-2.3.31.jar:2.3.31]
> ... 85 more
> {noformat}
> [The var timeZone is accessible in screen
> context|https://cwiki.apache.org/confluence/display/OFBIZ/Variables+always+available+in+screen+context].
> The java.util.TimeZone class uses sun.util.calendar.ZoneInfo internally.
> It's no longer supported by Java 17. We need to replace all occurrences of
> java.util.TimeZone by java.time.ZoneId.
> An easy temporary solution is to set
> {{--add-exports=java.base/sun.util.calendar=ALL-UNNAMED}} in build.gradle:
> :
> ['-Xms128M','-Xmx1024M','-Djdk.serialFilter=maxarray=10;maxdepth=20;maxrefs=1000;maxbytes=50','--add-exports=java.base/sun.util.calendar=ALL-UNNAMED']
> It has no impact with JDK 11.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (OFBIZ-12721) Replace all occurrences of java.util.TimeZone by java.time.ZoneId
[
https://issues.apache.org/jira/browse/OFBIZ-12721?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17644690#comment-17644690
]
Ioan Eugen Stan commented on OFBIZ-12721:
-
I can take a look at this and prepare a PR.
Ok with that [~jleroux] ?
> Replace all occurrences of java.util.TimeZone by java.time.ZoneId
> -
>
> Key: OFBIZ-12721
> URL: https://issues.apache.org/jira/browse/OFBIZ-12721
> Project: OFBiz
> Issue Type: Sub-task
> Components: ALL COMPONENTS
>Affects Versions: Upcoming Branch
> Environment: Java 17
>Reporter: Jacques Le Roux
>Assignee: Ioan Eugen Stan
>Priority: Major
>
> Using JDK 17, we have this issue:
> {noformat}
> 2022-12-06 19:04:30,689 |sse-nio-8443-exec-10 |FreeMarkerWorker
> |E| null
> freemarker.core._TemplateModelException: Java method
> "sun.util.calendar.ZoneInfo.useDaylightTime()" threw an exception when
> invoked on sun.util.calendar.ZoneInfo object
> "sun.util.calendar.ZoneInfo[id=\"Europe/Paris\",offset=360,dstSa
> vings=360,useDaylight=true,transitions=184,lastRule=java.util.SimpleTimeZone[id=Europe/Paris,offset=360,dstSavings=360,useDaylight=true,startYear=0,startMode=2,startMonth=2,startDay=-1,startDayOfWeek=1,startTime=360,start
> TimeMode=2,endMode=2,endMonth=9,endDay=-1,endDayOfWeek=1,endTime=360,endTimeMode=2]]";
> see cause exception in the Java stack trace.
>
> FTL stack trace ("~" means nesting-related):
> - Failed at: ${timeZone.getDisplayName(timeZone.us... [in template
> "component://helveticus/template/includes/Footer.ftl" at line 21, column 98]
>
> at
> freemarker.ext.beans._MethodUtil.newInvocationTemplateModelException(_MethodUtil.java:292)
> ~[freemarker-2.3.31.jar:2.3.31]
> [...]
> Caused by: java.lang.IllegalAccessException: class
> freemarker.ext.beans.BeansWrapper cannot access class
> sun.util.calendar.ZoneInfo (in module java.base) because module java.base
> does not export sun.util.calendar to unnamed module @1c852c0f
> at
> jdk.internal.reflect.Reflection.newIllegalAccessException(Reflection.java:392)
> ~[?:?]
> at
> java.lang.reflect.AccessibleObject.checkAccess(AccessibleObject.java:674)
> ~[?:?]
> at java.lang.reflect.Method.invoke(Method.java:560) ~[?:?]
> at
> freemarker.ext.beans.BeansWrapper.invokeMethod(BeansWrapper.java:1552)
> ~[freemarker-2.3.31.jar:2.3.31]
> at
> freemarker.ext.beans.SimpleMethodModel.exec(SimpleMethodModel.java:73)
> ~[freemarker-2.3.31.jar:2.3.31]
> ... 85 more
> {noformat}
> [The var timeZone is accessible in screen
> context|https://cwiki.apache.org/confluence/display/OFBIZ/Variables+always+available+in+screen+context].
> The java.util.TimeZone class uses sun.util.calendar.ZoneInfo internally.
> It's no longer supported by Java 17. We need to replace all occurrences of
> java.util.TimeZone by java.time.ZoneId.
> An easy temporary solution is to set
> {{--add-exports=java.base/sun.util.calendar=ALL-UNNAMED}} in build.gradle:
> :
> ['-Xms128M','-Xmx1024M','-Djdk.serialFilter=maxarray=10;maxdepth=20;maxrefs=1000;maxbytes=50','--add-exports=java.base/sun.util.calendar=ALL-UNNAMED']
> It has no impact with JDK 11.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Assigned] (OFBIZ-12721) Replace all occurrences of java.util.TimeZone by java.time.ZoneId
[
https://issues.apache.org/jira/browse/OFBIZ-12721?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ioan Eugen Stan reassigned OFBIZ-12721:
---
Assignee: Ioan Eugen Stan
> Replace all occurrences of java.util.TimeZone by java.time.ZoneId
> -
>
> Key: OFBIZ-12721
> URL: https://issues.apache.org/jira/browse/OFBIZ-12721
> Project: OFBiz
> Issue Type: Sub-task
> Components: ALL COMPONENTS
>Affects Versions: Upcoming Branch
> Environment: Java 17
>Reporter: Jacques Le Roux
>Assignee: Ioan Eugen Stan
>Priority: Major
>
> Using JDK 17, we have this issue:
> {noformat}
> 2022-12-06 19:04:30,689 |sse-nio-8443-exec-10 |FreeMarkerWorker
> |E| null
> freemarker.core._TemplateModelException: Java method
> "sun.util.calendar.ZoneInfo.useDaylightTime()" threw an exception when
> invoked on sun.util.calendar.ZoneInfo object
> "sun.util.calendar.ZoneInfo[id=\"Europe/Paris\",offset=360,dstSa
> vings=360,useDaylight=true,transitions=184,lastRule=java.util.SimpleTimeZone[id=Europe/Paris,offset=360,dstSavings=360,useDaylight=true,startYear=0,startMode=2,startMonth=2,startDay=-1,startDayOfWeek=1,startTime=360,start
> TimeMode=2,endMode=2,endMonth=9,endDay=-1,endDayOfWeek=1,endTime=360,endTimeMode=2]]";
> see cause exception in the Java stack trace.
>
> FTL stack trace ("~" means nesting-related):
> - Failed at: ${timeZone.getDisplayName(timeZone.us... [in template
> "component://helveticus/template/includes/Footer.ftl" at line 21, column 98]
>
> at
> freemarker.ext.beans._MethodUtil.newInvocationTemplateModelException(_MethodUtil.java:292)
> ~[freemarker-2.3.31.jar:2.3.31]
> [...]
> Caused by: java.lang.IllegalAccessException: class
> freemarker.ext.beans.BeansWrapper cannot access class
> sun.util.calendar.ZoneInfo (in module java.base) because module java.base
> does not export sun.util.calendar to unnamed module @1c852c0f
> at
> jdk.internal.reflect.Reflection.newIllegalAccessException(Reflection.java:392)
> ~[?:?]
> at
> java.lang.reflect.AccessibleObject.checkAccess(AccessibleObject.java:674)
> ~[?:?]
> at java.lang.reflect.Method.invoke(Method.java:560) ~[?:?]
> at
> freemarker.ext.beans.BeansWrapper.invokeMethod(BeansWrapper.java:1552)
> ~[freemarker-2.3.31.jar:2.3.31]
> at
> freemarker.ext.beans.SimpleMethodModel.exec(SimpleMethodModel.java:73)
> ~[freemarker-2.3.31.jar:2.3.31]
> ... 85 more
> {noformat}
> [The var timeZone is accessible in screen
> context|https://cwiki.apache.org/confluence/display/OFBIZ/Variables+always+available+in+screen+context].
> The java.util.TimeZone class uses sun.util.calendar.ZoneInfo internally.
> It's no longer supported by Java 17. We need to replace all occurrences of
> java.util.TimeZone by java.time.ZoneId.
> An easy temporary solution is to set
> {{--add-exports=java.base/sun.util.calendar=ALL-UNNAMED}} in build.gradle:
> :
> ['-Xms128M','-Xmx1024M','-Djdk.serialFilter=maxarray=10;maxdepth=20;maxrefs=1000;maxbytes=50','--add-exports=java.base/sun.util.calendar=ALL-UNNAMED']
> It has no impact with JDK 11.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (OFBIZ-12400) Upgrade to gradle 7.6 - support jdk 11 -> 17
[ https://issues.apache.org/jira/browse/OFBIZ-12400?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17643471#comment-17643471 ] Ioan Eugen Stan commented on OFBIZ-12400: - [~jleroux] : > java.lang.IllegalArgumentException: Unsupported class file major version 61 This might require a version upgrade for Jersey to a version that supports Java 17 . Jersey seems to repackage ASM for bytecode transformations. The bundled version does not support Java 17 . An upgrade to jersey 2.37 should do the trick [https://github.com/eclipse-ee4j/jersey/releases/tag/2.37] . > Upgrade to gradle 7.6 - support jdk 11 -> 17 > > > Key: OFBIZ-12400 > URL: https://issues.apache.org/jira/browse/OFBIZ-12400 > Project: OFBiz > Issue Type: Sub-task >Reporter: Ioan Eugen Stan >Assignee: Ioan Eugen Stan >Priority: Major > Attachments: OFBIZ-12400-windows.patch > > > For working with Java 17, we need to upgrade to gradle 7.3 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OFBIZ-12399) Upgrade OFBiz to use Java JDK Version 17
[ https://issues.apache.org/jira/browse/OFBIZ-12399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17641550#comment-17641550 ] Ioan Eugen Stan commented on OFBIZ-12399: - Rebased on that commit. > Upgrade OFBiz to use Java JDK Version 17 > > > Key: OFBIZ-12399 > URL: https://issues.apache.org/jira/browse/OFBIZ-12399 > Project: OFBiz > Issue Type: Improvement >Reporter: Ioan Eugen Stan >Assignee: Jacques Le Roux >Priority: Major > Fix For: Upcoming Branch > > > We should have ofbiz owrking with JDK17. > This issue should track progress on making that happen. > One think we need to do is upgrade gradle to 7.3 . -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OFBIZ-10757) Upgrade OFBiz to use Java JDK Version 11
[ https://issues.apache.org/jira/browse/OFBIZ-10757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17640622#comment-17640622 ] Ioan Eugen Stan commented on OFBIZ-10757: - I managed to start ofbiz locally (not without some errors and warnings) with JDK17 using the PR in https://issues.apache.org/jira/browse/OFBIZ-12400 . As discussed on ML I think we can migrate to JDK17 and skip JDK 11 which was EOL'ed . > Upgrade OFBiz to use Java JDK Version 11 > > > Key: OFBIZ-10757 > URL: https://issues.apache.org/jira/browse/OFBIZ-10757 > Project: OFBiz > Issue Type: Improvement >Affects Versions: Trunk, Upcoming Branch >Reporter: Taher Alkhateeb >Priority: Minor > Attachments: OFBIZ-10757-framework.patch, > OFBIZ-10757-framework.patch, OFBIZ-10757-framework.patch, > OFBIZ-10757-framework.patch, OFBIZ-10757-plugins.patch, > OFBIZ-10757-plugins.patch, OFBIZ-10757_Fix-javadoc-build-for-OpenJDK-11.patch > > > To implement as per [Discussion > Thread|https://lists.apache.org/thread.html/71b8c1048f1dd4c5b3f104233c9af7b2cbc690863fe35b08ef91fcf5@%3Cdev.ofbiz.apache.org%3E] -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OFBIZ-12400) Upgrade to gradle 7.6 - support jdk 8 -> 17
[ https://issues.apache.org/jira/browse/OFBIZ-12400?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17640620#comment-17640620 ] Ioan Eugen Stan commented on OFBIZ-12400: - I've rebased my PR on latest trunk and bumped gradle to 7.6. I can start ofbiz locally with java 17 (see image in PR) [https://github.com/apache/ofbiz-framework/pull/354#issuecomment-1330424495] . The build passed. > Upgrade to gradle 7.6 - support jdk 8 -> 17 > --- > > Key: OFBIZ-12400 > URL: https://issues.apache.org/jira/browse/OFBIZ-12400 > Project: OFBiz > Issue Type: Sub-task >Reporter: Ioan Eugen Stan >Assignee: Ioan Eugen Stan >Priority: Major > > For working with Java 17, we need to upgrade to gradle 7.3 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (OFBIZ-12400) Upgrade to gradle 7.6 - support jdk 8 -> 17
[ https://issues.apache.org/jira/browse/OFBIZ-12400?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ioan Eugen Stan updated OFBIZ-12400: Summary: Upgrade to gradle 7.6 - support jdk 8 -> 17 (was: Upgrade to gradle 7.3 - support jdk 8 -> 17) > Upgrade to gradle 7.6 - support jdk 8 -> 17 > --- > > Key: OFBIZ-12400 > URL: https://issues.apache.org/jira/browse/OFBIZ-12400 > Project: OFBiz > Issue Type: Sub-task >Reporter: Ioan Eugen Stan >Assignee: Ioan Eugen Stan >Priority: Major > > For working with Java 17, we need to upgrade to gradle 7.3 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OFBIZ-12526) Maintenance (demo) dataset(s)
[ https://issues.apache.org/jira/browse/OFBIZ-12526?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17482564#comment-17482564 ] Ioan Eugen Stan commented on OFBIZ-12526: - By the way, I think you are doing a good job of adding demo data to OFBiz . It makes a great experience for first time users to explore the app that has data. I'll try to help as much as possible. > Maintenance (demo) dataset(s) > - > > Key: OFBIZ-12526 > URL: https://issues.apache.org/jira/browse/OFBIZ-12526 > Project: OFBiz > Issue Type: Improvement > Components: ALL APPLICATIONS >Affects Versions: Upcoming Branch >Reporter: Pierre Smits >Assignee: Pierre Smits >Priority: Major > Labels: consistency, usability, ux > Attachments: ofbiz-demo-data-count-by-tables.csv > > > Good (demo) data increases the appeal of OFBiz, making it easier for both > user and contributor to understand how particular functions like screens, > services, etc. (should) work. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Commented] (OFBIZ-12526) Maintenance (demo) dataset(s)
[
https://issues.apache.org/jira/browse/OFBIZ-12526?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17482560#comment-17482560
]
Ioan Eugen Stan commented on OFBIZ-12526:
-
Hello [~pierresmits] ,
I uploaded a CSV file [^ofbiz-demo-data-count-by-tables.csv] with the count for
all the entities in the database and also the select query that I used to get
that count (used Derby).
To get the data I did the follwoing:
Loaded the demo data with
{code:java}
./gradle cleanAll loadAll{code}
Ran the following Clojure code to export data from the embedded derby populated
from demo data:
{code:java}
(ns dev.ofbiz-play
"OFBiz related code - exploratory."
(:require [next.jdbc :as jdbc]
[next.jdbc.result-set :as rs]
[clojure.data.csv :as csv]
[clojure.java.io :as io])){code}
{code:java}
(comment ;; open jdbc connection to OFBiz derby embedded database loaded with
./gradle cleanAll loadAll
(let [db {:jdbcUrl
"jdbc:derby:/home/ieugen/proiecte/ofbiz/ofbiz-framework/runtime/data/derby/ofbiz"}
ds (jdbc/get-datasource db)]
(with-open [connection (jdbc/get-connection ds)]
;; read jdbc metadata for all tables
(let [metadata (.getMetaData connection)
rs (.getTables metadata nil nil nil (into-array ["TABLE" "VIEW"]))
;; get the table names from the metadata response
table-names (map :SYSTABLES/TABLE_NAME
(filter #(= "OFBIZ" (:SYSSCHEMAS/TABLE_SCHEM %))
(rs/datafiable-result-set rs ds)))
;; build the data we need by counting all fields from each tables
results (map (fn [t]
(let [query (str "select count(*) as COUNT from
OFBIZ." t)
data (:COUNT (first (jdbc/execute! ds
[query])))]
{:table-name t
:sql-query query
:data data})) table-names)
;; get only values from map as a vector
report-data (map (juxt :table-name :data :sql-query) results)
report-header ["table_name" "data" "sql-query"]]
(with-open [writer (io/writer "ofbiz-demo-data-count-by-tables.csv")]
(csv/write-csv writer
(concat [report-header] report-data))
0) {code}
with the dependencies listed bellow:
deps.edn
{code:java}
{:aliases {:dev {:extra-paths ["development/src" "development/resources"]
:extra-deps {org.apache.derby/derby {:mvn/version "10.15.2.0"}
org.clojure/clojure {:mvn/version "1.10.3"}
org.clojure/data.csv {:mvn/version "1.0.0"}} }}
}{code}
> Maintenance (demo) dataset(s)
> -
>
> Key: OFBIZ-12526
> URL: https://issues.apache.org/jira/browse/OFBIZ-12526
> Project: OFBiz
> Issue Type: Improvement
> Components: ALL APPLICATIONS
>Affects Versions: Upcoming Branch
>Reporter: Pierre Smits
>Assignee: Pierre Smits
>Priority: Major
> Labels: consistency, usability, ux
> Attachments: ofbiz-demo-data-count-by-tables.csv
>
>
> Good (demo) data increases the appeal of OFBiz, making it easier for both
> user and contributor to understand how particular functions like screens,
> services, etc. (should) work.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Updated] (OFBIZ-12526) Maintenance (demo) dataset(s)
[ https://issues.apache.org/jira/browse/OFBIZ-12526?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ioan Eugen Stan updated OFBIZ-12526: Attachment: ofbiz-demo-data-count-by-tables.csv > Maintenance (demo) dataset(s) > - > > Key: OFBIZ-12526 > URL: https://issues.apache.org/jira/browse/OFBIZ-12526 > Project: OFBiz > Issue Type: Improvement > Components: ALL APPLICATIONS >Affects Versions: Upcoming Branch >Reporter: Pierre Smits >Assignee: Pierre Smits >Priority: Major > Labels: consistency, usability, ux > Attachments: ofbiz-demo-data-count-by-tables.csv > > > Good (demo) data increases the appeal of OFBiz, making it easier for both > user and contributor to understand how particular functions like screens, > services, etc. (should) work. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Updated] (OFBIZ-12526) Maintenance (demo) dataset(s)
[ https://issues.apache.org/jira/browse/OFBIZ-12526?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ioan Eugen Stan updated OFBIZ-12526: Attachment: (was: ofbiz-demo-data-count-by-tables.csv) > Maintenance (demo) dataset(s) > - > > Key: OFBIZ-12526 > URL: https://issues.apache.org/jira/browse/OFBIZ-12526 > Project: OFBiz > Issue Type: Improvement > Components: ALL APPLICATIONS >Affects Versions: Upcoming Branch >Reporter: Pierre Smits >Assignee: Pierre Smits >Priority: Major > Labels: consistency, usability, ux > Attachments: ofbiz-demo-data-count-by-tables.csv > > > Good (demo) data increases the appeal of OFBiz, making it easier for both > user and contributor to understand how particular functions like screens, > services, etc. (should) work. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Updated] (OFBIZ-12526) Maintenance (demo) dataset(s)
[ https://issues.apache.org/jira/browse/OFBIZ-12526?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ioan Eugen Stan updated OFBIZ-12526: Attachment: ofbiz-demo-data-count-by-tables.csv > Maintenance (demo) dataset(s) > - > > Key: OFBIZ-12526 > URL: https://issues.apache.org/jira/browse/OFBIZ-12526 > Project: OFBiz > Issue Type: Improvement > Components: ALL APPLICATIONS >Affects Versions: Upcoming Branch >Reporter: Pierre Smits >Assignee: Pierre Smits >Priority: Major > Labels: consistency, usability, ux > Attachments: ofbiz-demo-data-count-by-tables.csv > > > Good (demo) data increases the appeal of OFBiz, making it easier for both > user and contributor to understand how particular functions like screens, > services, etc. (should) work. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Commented] (OFBIZ-9498) Improve DevOps using environment variable configuration
[ https://issues.apache.org/jira/browse/OFBIZ-9498?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17466855#comment-17466855 ] Ioan Eugen Stan commented on OFBIZ-9498: Thanks. I saw there is the PR here that can improve life in these situations. I did add some feedback there [https://github.com/apache/ofbiz-framework/pull/355] . Any plans to merge that now or later after more work? > Improve DevOps using environment variable configuration > --- > > Key: OFBIZ-9498 > URL: https://issues.apache.org/jira/browse/OFBIZ-9498 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk >Reporter: Gil Portenseigne >Assignee: Gil Portenseigne >Priority: Minor > Attachments: OFBIZ-9498.patch > > > Discussed in thread : https://s.apache.org/Mh3q > This Jira will present the improvment proposal giving a way to configure > OFBiz using environment variable. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Comment Edited] (OFBIZ-9498) Improve DevOps using environment variable configuration
[
https://issues.apache.org/jira/browse/OFBIZ-9498?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17466490#comment-17466490
]
Ioan Eugen Stan edited comment on OFBIZ-9498 at 12/29/21, 3:42 PM:
---
[~pgil] :
I would keep JVM options inside the default Java env variables:
JAVA_TOOLS_OPTIONS or JVM_OPTS (check this to be sure).
It's usually straight forward to pass those env vars to an app or a container.
I would NOT introduce new things like:
{noformat}
export OFB_MEM_XMS="-Xms256M"
export OFB_MEM_XMX="-Xmx2048M"{noformat}
For sensitive data (cc [~jleroux] ) , the practices for containers are to
support another an extension to env variable properties.
We add support for `OFB_POSTGRES_PASS` that will contain the actual secret and
support also `OFB_POSTGRES_PASS_FILE` that will contain a path to a file that
holds the sensitive data.
Files can be made accessible only to the running application on most modern OS's
Details of how this works for Docker Swarm is in the bellow document and other
places online: [https://docs.docker.com/engine/swarm/secrets/] .
Most container engines support handling secrets that are mounted as files in
special memory file systems that don't reach disk and are even protected /
encrypted (modern CPU's have this capability).
See docker swarm secrets, kubernetes secrets, etc.
was (Author: ieugen):
[~pgil] :
I would keep JVM options inside the default Java env variables:
JAVA_TOOLS_OPTIONS or JVM_OPTS (check this to be sure).
It's usually straight forward to pass those env vars to an app or a container.
I would NOT introduce new things like:
{noformat}
export OFB_MEM_XMS="-Xms256M"
export OFB_MEM_XMX="-Xmx2048M"{noformat}
For sensitive data (cc [~jleroux] ) , the practices for containers are to
support another an extension to env variable properties.
We add support for `OFB_POSTGRES_PASS` that will contain the actual secret and
support also `OFB_POSTGRES_PASS_FILE` that will contain the contents of the
secret in a file.
Details of how this works for Docker Swarm is in the bellow document and other
places online: [https://docs.docker.com/engine/swarm/secrets/] .
Most container engines support handling secrets that are mounted as files in
special memory file systems that don't reach disk and are even protected /
encrypted (modern CPU's have this capability).
> Improve DevOps using environment variable configuration
> ---
>
> Key: OFBIZ-9498
> URL: https://issues.apache.org/jira/browse/OFBIZ-9498
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
>Affects Versions: Trunk
>Reporter: Gil Portenseigne
>Assignee: Gil Portenseigne
>Priority: Minor
> Attachments: OFBIZ-9498.patch
>
>
> Discussed in thread : https://s.apache.org/Mh3q
> This Jira will present the improvment proposal giving a way to configure
> OFBiz using environment variable.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Comment Edited] (OFBIZ-9498) Improve DevOps using environment variable configuration
[
https://issues.apache.org/jira/browse/OFBIZ-9498?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17466490#comment-17466490
]
Ioan Eugen Stan edited comment on OFBIZ-9498 at 12/29/21, 3:40 PM:
---
[~pgil] :
I would keep JVM options inside the default Java env variables:
JAVA_TOOLS_OPTIONS or JVM_OPTS (check this to be sure).
It's usually straight forward to pass those env vars to an app or a container.
I would NOT introduce new things like:
{noformat}
export OFB_MEM_XMS="-Xms256M"
export OFB_MEM_XMX="-Xmx2048M"{noformat}
For sensitive data (cc [~jleroux] ) , the practices for containers are to
support another an extension to env variable properties.
We add support for `OFB_POSTGRES_PASS` that will contain the actual secret and
support also `OFB_POSTGRES_PASS_FILE` that will contain the contents of the
secret in a file.
Details of how this works for Docker Swarm is in the bellow document and other
places online: [https://docs.docker.com/engine/swarm/secrets/] .
Most container engines support handling secrets that are mounted as files in
special memory file systems that don't reach disk and are even protected /
encrypted (modern CPU's have this capability).
was (Author: ieugen):
[~pgil] :
I would keep JVM options inside the default Java env variables:
JAVA_TOOLS_OPTIONS or JVM_OPTS (check this to be sure).
It's usually straight forward to pass those env vars to an app or a container.
I would NOT introduce new things like:
{noformat}
export OFB_MEM_XMS="-Xms256M"
export OFB_MEM_XMX="-Xmx2048M"{noformat}
> Improve DevOps using environment variable configuration
> ---
>
> Key: OFBIZ-9498
> URL: https://issues.apache.org/jira/browse/OFBIZ-9498
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
>Affects Versions: Trunk
>Reporter: Gil Portenseigne
>Assignee: Gil Portenseigne
>Priority: Minor
> Attachments: OFBIZ-9498.patch
>
>
> Discussed in thread : https://s.apache.org/Mh3q
> This Jira will present the improvment proposal giving a way to configure
> OFBiz using environment variable.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Commented] (OFBIZ-9498) Improve DevOps using environment variable configuration
[
https://issues.apache.org/jira/browse/OFBIZ-9498?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17466490#comment-17466490
]
Ioan Eugen Stan commented on OFBIZ-9498:
[~pgil] :
I would keep JVM options inside the default Java env variables:
JAVA_TOOLS_OPTIONS or JVM_OPTS (check this to be sure).
It's usually straight forward to pass those env vars to an app or a container.
I would NOT introduce new things like:
{noformat}
export OFB_MEM_XMS="-Xms256M"
export OFB_MEM_XMX="-Xmx2048M"{noformat}
> Improve DevOps using environment variable configuration
> ---
>
> Key: OFBIZ-9498
> URL: https://issues.apache.org/jira/browse/OFBIZ-9498
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
>Affects Versions: Trunk
>Reporter: Gil Portenseigne
>Assignee: Gil Portenseigne
>Priority: Minor
> Attachments: OFBIZ-9498.patch
>
>
> Discussed in thread : https://s.apache.org/Mh3q
> This Jira will present the improvment proposal giving a way to configure
> OFBiz using environment variable.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Commented] (OFBIZ-9498) Improve DevOps using environment variable configuration
[ https://issues.apache.org/jira/browse/OFBIZ-9498?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17466489#comment-17466489 ] Ioan Eugen Stan commented on OFBIZ-9498: [~pgil] : Have you made any progress/changes on this? I would love to test it out in the near future, hopefully with a client use case (Docker deploy). That will bring valuable input and feedback that I would love to get back in OFBIz. > Improve DevOps using environment variable configuration > --- > > Key: OFBIZ-9498 > URL: https://issues.apache.org/jira/browse/OFBIZ-9498 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk >Reporter: Gil Portenseigne >Assignee: Gil Portenseigne >Priority: Minor > Attachments: OFBIZ-9498.patch > > > Discussed in thread : https://s.apache.org/Mh3q > This Jira will present the improvment proposal giving a way to configure > OFBiz using environment variable. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Commented] (OFBIZ-9498) Improve DevOps using environment variable configuration
[ https://issues.apache.org/jira/browse/OFBIZ-9498?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17461549#comment-17461549 ] Ioan Eugen Stan commented on OFBIZ-9498: I think it's a good evolution of the current situation. Related to this part of the code. I know I looked at UtilProperties some time and I noticed it pulls in dependency on UtilCache and that pulls in some other stuff. Ideally these would be composeable and replaceable. It would be nice to be able to swap in a more modern configuration management. Since UtilPropertiees is based on static methods, one way (the only way ?!) is to replace the class on the class path. This could be done if UtilProperties where in a `configuration-properties` module that we could replace during distribution assembly with `configuration-awesome-new` that contains a class with same binary signature. But having static initialized fields makes it hard to draw a clear boundary. > Improve DevOps using environment variable configuration > --- > > Key: OFBIZ-9498 > URL: https://issues.apache.org/jira/browse/OFBIZ-9498 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk >Reporter: Gil Portenseigne >Assignee: Gil Portenseigne >Priority: Minor > Attachments: OFBIZ-9498.patch > > > Discussed in thread : https://s.apache.org/Mh3q > This Jira will present the improvment proposal giving a way to configure > OFBiz using environment variable. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Updated] (OFBIZ-12400) Upgrade to gradle 7.3 - support jdk 8 -> 17
[ https://issues.apache.org/jira/browse/OFBIZ-12400?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ioan Eugen Stan updated OFBIZ-12400: Summary: Upgrade to gradle 7.3 - support jdk 8 -> 17 (was: Upgrade to gradle 7.3 ) > Upgrade to gradle 7.3 - support jdk 8 -> 17 > --- > > Key: OFBIZ-12400 > URL: https://issues.apache.org/jira/browse/OFBIZ-12400 > Project: OFBiz > Issue Type: Sub-task >Reporter: Ioan Eugen Stan >Assignee: Ioan Eugen Stan >Priority: Major > > For working with Java 17, we need to upgrade to gradle 7.3 -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Commented] (OFBIZ-3500) Umbrella issue for components dependency
[
https://issues.apache.org/jira/browse/OFBIZ-3500?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17450150#comment-17450150
]
Ioan Eugen Stan commented on OFBIZ-3500:
I have spent some time on figuring out how to break ofbiz into real gradle
projects and I got a good feel of how things are right now.
This is added as source sets dynamically.
We can break ofbiz first into:
* framework
* application
* themes
* plugins - should add plugins dynamically
{noformat}
getDirectoryInActiveComponentsIfExists lib []
getDirectoryInActiveComponentsIfExists src/main/java
[framework/base/src/main/java, framework/entity/src/main/java,
framework/security/src/main/java, framework/datafile/src/main/java,
framework/minilang/src/main/java, framework/common/src/main/java,
framework/service/src/main/java, framework/catalina/src/main/java,
framework/entityext/src/main/java, framework/webapp/src/main/java,
framework/widget/src/main/java, framework/testtools/src/main/java,
framework/webtools/src/main/java, applications/party/src/main/java,
applications/securityext/src/main/java, applications/content/src/main/java,
applications/workeffort/src/main/java, applications/product/src/main/java,
applications/manufacturing/src/main/java,
applications/accounting/src/main/java, applications/humanres/src/main/java,
applications/order/src/main/java, applications/marketing/src/main/java,
plugins/rest-api/src/main/java, framework/start/src/main/java]
getDirectoryInActiveComponentsIfExists src/main/groovy
[framework/service/src/main/groovy, framework/webtools/src/main/groovy,
applications/party/src/main/groovy, applications/content/src/main/groovy,
applications/product/src/main/groovy, applications/accounting/src/main/groovy,
applications/order/src/main/groovy, applications/marketing/src/main/groovy]
getDirectoryInActiveComponentsIfExists src/main/resources
[framework/base/src/main/resources, framework/entity/src/main/resources,
framework/minilang/src/main/resources, framework/common/src/main/resources,
framework/webapp/src/main/resources, framework/widget/src/main/resources,
framework/webtools/src/main/resources, applications/content/src/main/resources,
applications/product/src/main/resources, framework/start/src/main/resources]
getDirectoryInActiveComponentsIfExists config
[framework/base/config, framework/entity/config, framework/security/config,
framework/minilang/config, framework/common/config, framework/service/config,
framework/catalina/config, framework/entityext/config, framework/webapp/config,
framework/widget/config, framework/webtools/config, themes/netdavaofbiz/config,
themes/rainbowstone/config, themes/helveticus/config,
themes/common-theme/config, applications/party/config,
applications/securityext/config, applications/content/config,
applications/workeffort/config, applications/product/config,
applications/manufacturing/config, applications/accounting/config,
applications/humanres/config, applications/order/config,
applications/marketing/config, applications/commonext/config,
plugins/rest-api/config]
getDirectoryInActiveComponentsIfExists dtd
[framework/base/dtd, framework/entity/dtd, framework/security/dtd,
framework/datafile/dtd, framework/minilang/dtd, framework/service/dtd,
framework/webapp/dtd, framework/widget/dtd, framework/testtools/dtd,
applications/content/dtd, applications/product/dtd, plugins/rest-api/dtd]
getDirectoryInActiveComponentsIfExists src/test/java
[framework/base/src/test/java, framework/entity/src/test/java,
framework/security/src/test/java, framework/common/src/test/java,
framework/webapp/src/test/java, framework/widget/src/test/java,
framework/start/src/test/java]
getDirectoryInActiveComponentsIfExists src/test/groovy
[framework/base/src/test/groovy]
getDirectoryInActiveComponentsIfExists src/test/resources
[framework/base/src/test/resources]
getDirectoryInActiveComponentsIfExists groovyScripts
[framework/base/groovyScripts, framework/common/groovyScripts,
framework/entityext/groovyScripts, framework/webtools/groovyScripts,
applications/party/groovyScripts, applications/content/groovyScripts,
applications/workeffort/groovyScripts, applications/product/groovyScripts,
applications/manufacturing/groovyScripts,
applications/accounting/groovyScripts, applications/humanres/groovyScripts,
applications/order/groovyScripts, applications/marketing/groovyScripts,
applications/commonext/groovyScripts]
{noformat}
> Umbrella issue for components dependency
>
>
> Key: OFBIZ-3500
> URL: https://issues.apache.org/jira/browse/OFBIZ-3500
> Project: OFBiz
> Issue Type: Improvement
> Components: ALL COMPONENTS
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Priority: Major
> Attachments: dependencyCheck.groovy
>
>
> This issue is
[jira] [Closed] (OFBIZ-5976) Have the ability to configure SVN setup for scrum per tenant
[ https://issues.apache.org/jira/browse/OFBIZ-5976?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ioan Eugen Stan closed OFBIZ-5976. -- Resolution: Abandoned Closing as plugin does not seem to be used as much. Please reopen if renewed interest is found. > Have the ability to configure SVN setup for scrum per tenant > > > Key: OFBIZ-5976 > URL: https://issues.apache.org/jira/browse/OFBIZ-5976 > Project: OFBiz > Issue Type: Sub-task > Components: scrum >Affects Versions: Trunk >Reporter: Pierre Smits >Priority: Major > Labels: configuration, multi-tenant, scrum, svn > > The scrum has the ability to use svn for sprint revisions. > These configuration attributes (properties) are currently referenced in > /scrum/config/revision.properties. > However, this is unusable in a multi-tenant setup as each tenant will need > its own setup to be used. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Commented] (OFBIZ-12401) Improved OFBiz configuration management for containers
[ https://issues.apache.org/jira/browse/OFBIZ-12401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17450026#comment-17450026 ] Ioan Eugen Stan commented on OFBIZ-12401: - When running inside containers we need a way to easily configure "host-headers-allowed" "You need to set host-headers-allowed property in security.properties file. " It would be great to have this configured via environment variable for easy container configuration. The alternative right now is to mount a configuration file as a volume which is not very nice. > Improved OFBiz configuration management for containers > -- > > Key: OFBIZ-12401 > URL: https://issues.apache.org/jira/browse/OFBIZ-12401 > Project: OFBiz > Issue Type: Sub-task >Reporter: Ioan Eugen Stan >Priority: Major > > It's hard to use OFBiz with containers and other deployment scenarios because > the OFBiz configuration is intertwined with source files and there are a lot > of them. > We also need: > * the ability to override configuration properties > * load configs from a single / handful of files in a single location > * optionally load from multiple sources (files, db, configuration services > like kubernetes, consul ,etc) . > -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Closed] (OFBIZ-6498) Modal windows for lookup misses a close button
[ https://issues.apache.org/jira/browse/OFBIZ-6498?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ioan Eugen Stan closed OFBIZ-6498. -- Resolution: Not A Problem Old issue. Reopen if necessary. > Modal windows for lookup misses a close button > -- > > Key: OFBIZ-6498 > URL: https://issues.apache.org/jira/browse/OFBIZ-6498 > Project: OFBiz > Issue Type: Bug > Components: themes >Affects Versions: Bootstrap theme >Reporter: Pierre Smits >Priority: Major > > When opening the modal window to lookup products in manufacturing no function > is available to close the window. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Closed] (OFBIZ-6480) Update Jackrabbit branch because of CVE-2015-1833
[ https://issues.apache.org/jira/browse/OFBIZ-6480?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ioan Eugen Stan closed OFBIZ-6480. -- Resolution: Not A Problem I could not find any references to Jackrabbit so closing this. > Update Jackrabbit branch because of CVE-2015-1833 > - > > Key: OFBIZ-6480 > URL: https://issues.apache.org/jira/browse/OFBIZ-6480 > Project: OFBiz > Issue Type: Bug > Components: framework >Affects Versions: Jackrabbit >Reporter: Jacques Le Roux >Priority: Minor > > See https://web.nvd.nist.gov/view/vuln/detail?vulnId=CVE-2015-1833 > This is minor because it's only in the Jackrabbit stalled branch -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Closed] (OFBIZ-12136) Add extra classpath directories for ofbiz.tar/zip distribution
[
https://issues.apache.org/jira/browse/OFBIZ-12136?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ioan Eugen Stan closed OFBIZ-12136.
---
Resolution: Fixed
This has been implemented and merged.
> Add extra classpath directories for ofbiz.tar/zip distribution
> --
>
> Key: OFBIZ-12136
> URL: https://issues.apache.org/jira/browse/OFBIZ-12136
> Project: OFBiz
> Issue Type: Improvement
>Affects Versions: Trunk
>Reporter: Ioan Eugen Stan
>Assignee: Daniel Watford
>Priority: Major
>
> See
> [https://lists.apache.org/thread.html/r210c63f3f0d6efd0b4fe2e2141689ae501c518671cfe1e5d4f7a9417%40%3Cdev.ofbiz.apache.org%3E
>
> |https://lists.apache.org/thread.html/r210c63f3f0d6efd0b4fe2e2141689ae501c518671cfe1e5d4f7a9417%40%3Cdev.ofbiz.apache.org%3E]
> It would help to have the ability to add jars and configuration files to the
> classpath - since that is where ofbiz looks for.
>
> So the idea is to make it easy for people to add things at the BEGINING of
> the classpath so they can override ofbiz configurations (and / or libraries
> ?!)
>
> I believe this can achieved for both gradle deploy and binary (ofbiz.tar)
> deploy with minimal changes.
>
> If you could add the code snippet bellow to build.gradle then people can add
> files to config/ and lib-extra/ directories and they will be available for
> ofbiz when it starts.
>
> I've tested this and it works for my ofbiz docker build (I'm planning an
> article these next 2 days and will share it. Spoiler: it works on ARM -
> raspberry pi 4 ).
>
> I'm also adding the database drivers post build to lib-extra since gradle
> hardcodes the classpath at build. Adding new jars to lib/ does not do
> anything.
>
> That way I can keep the ofbiz source unchanged and still get what I need.
> {code:java}
> tasks.startScripts {
> doLast {
> // Alter the start script for Unix systems.
> unixScript.text =
>
> unixScript.text.replace('CLASSPATH=$APP_HOME/lib','CLASSPATH=$APP_HOME/config/:$APP_HOME/lib-extra/*:$APP_HOME/lib')
> // Alter the start script for Windows systems.
> //windowsScript.text =
> //windowsScript.text.replace('CLASSPATH=$APP_HOME/lib',
> // 'CLASSPATH=$APP_HOME\\conf\\:$APP_HOME/lib-extra/*:$APP_HOME/lib')
> }
> }
> {code}
>
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Commented] (OFBIZ-10407) create a docker image from the ofbiz system
[ https://issues.apache.org/jira/browse/OFBIZ-10407?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17449970#comment-17449970 ] Ioan Eugen Stan commented on OFBIZ-10407: - There are some things to solve in order to make a usable docker image for ofbiz: * script to initial load data when starting the ofbiz container app * a way to load data in the system - the rest plugin seems to be a good way to do this - Would be great to have this plugin included in main source code * a way to install plugins on the base image - right now the only way to have plugins in the docker image is to rebuild the image with the plugins - because ofbiz does not have a way to add binary plugins on top of an ofbiz image I recommend raising some issues to solve these. I have a branch and github action that builds docker images: [https://github.com/ieugen/ofbiz-framework/actions] with rest API plugin. Docker images are published [https://hub.docker.com/r/ieugen/ofbiz] Kubernetes chart is published [https://github.com/ieugen/charts |https://github.com/ieugen/chartsb] > create a docker image from the ofbiz system > --- > > Key: OFBIZ-10407 > URL: https://issues.apache.org/jira/browse/OFBIZ-10407 > Project: OFBiz > Issue Type: Improvement >Affects Versions: Trunk >Reporter: Hans Bakker >Assignee: Michael Brohl >Priority: Major > Labels: DevOps > Attachments: OFBIZ-10407_dockerfile.patch, docker.patch > > Time Spent: 10m > Remaining Estimate: 0h > > Attached an initial docker version from OFBiz copied from our GrowERP > production system translated to svn repositories. > I propose to create a docker directory in the ofbiz framework root of which a > patch is attached. > The image result is stored in hub.docker.com under the name ofbiz/full-trunk. > It can be started in a docker environment with the following command: > docker run -p 80:8080 -p 443:8443 ofbiz/full-trunk > and after about 30 seconds it can be show in the browser under: > [https://0.0.0.0/catalog/control/main] > the image can be created by executing this command in the ofbiz root when > the patch is applied: > docker build -t ofbiz/full-trunk docker > the password to the ofbiz account at hub.docker.com will be supplied upon > request. > > see the discussion in the mailinglist at > https://markmail.org/message/n7wcgroslj7v3gfe?q=docker+ofbiz > -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Commented] (OFBIZ-12399) Upgrade OFBiz to use Java JDK Version 17
[ https://issues.apache.org/jira/browse/OFBIZ-12399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17449463#comment-17449463 ] Ioan Eugen Stan commented on OFBIZ-12399: - We might need to upgrade to groovy 3.0.8 [https://github.com/gradle/gradle/issues/16857] > Upgrade OFBiz to use Java JDK Version 17 > > > Key: OFBIZ-12399 > URL: https://issues.apache.org/jira/browse/OFBIZ-12399 > Project: OFBiz > Issue Type: Improvement >Reporter: Ioan Eugen Stan >Priority: Major > > We should have ofbiz owrking with JDK17. > This issue should track progress on making that happen. > One think we need to do is upgrade gradle to 7.3 . -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Comment Edited] (OFBIZ-12400) Upgrade to gradle 7.3
[
https://issues.apache.org/jira/browse/OFBIZ-12400?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17449447#comment-17449447
]
Ioan Eugen Stan edited comment on OFBIZ-12400 at 11/26/21, 8:15 AM:
IMO there is no reason to wait.
Gradle 7.3 still works with Java 11. and Java 8 see
[https://docs.gradle.org/current/userguide/compatibility.html]
{noformat}
A Java version between 8 and 17 is required to execute Gradle. Java 18 and
later versions are not yet supported.{noformat}
Upgrading now should not break anything.
was (Author: ieugen):
IMO there is no reason to wait.
Gradle 7.3 still works with Java 11. and Java 8
Upgrading now should not break anything.
> Upgrade to gradle 7.3
> --
>
> Key: OFBIZ-12400
> URL: https://issues.apache.org/jira/browse/OFBIZ-12400
> Project: OFBiz
> Issue Type: Sub-task
>Reporter: Ioan Eugen Stan
>Assignee: Ioan Eugen Stan
>Priority: Major
>
> For working with Java 17, we need to upgrade to gradle 7.3
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Comment Edited] (OFBIZ-12400) Upgrade to gradle 7.3
[ https://issues.apache.org/jira/browse/OFBIZ-12400?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17449447#comment-17449447 ] Ioan Eugen Stan edited comment on OFBIZ-12400 at 11/26/21, 8:12 AM: IMO there is no reason to wait. Gradle 7.3 still works with Java 11. and Java 8 Upgrading now should not break anything. was (Author: ieugen): IMO there is no reason to wait. Gradle 7.3 still works with Java 11. Upgrading now should not break anything. > Upgrade to gradle 7.3 > -- > > Key: OFBIZ-12400 > URL: https://issues.apache.org/jira/browse/OFBIZ-12400 > Project: OFBiz > Issue Type: Sub-task >Reporter: Ioan Eugen Stan >Assignee: Ioan Eugen Stan >Priority: Major > > For working with Java 17, we need to upgrade to gradle 7.3 -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Commented] (OFBIZ-12400) Upgrade to gradle 7.3
[ https://issues.apache.org/jira/browse/OFBIZ-12400?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17449447#comment-17449447 ] Ioan Eugen Stan commented on OFBIZ-12400: - IMO there is no reason to wait. Gradle 7.3 still works with Java 11. Upgrading now should not break anything. > Upgrade to gradle 7.3 > -- > > Key: OFBIZ-12400 > URL: https://issues.apache.org/jira/browse/OFBIZ-12400 > Project: OFBiz > Issue Type: Sub-task >Reporter: Ioan Eugen Stan >Assignee: Ioan Eugen Stan >Priority: Major > > For working with Java 17, we need to upgrade to gradle 7.3 -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Commented] (OFBIZ-12401) Improved OFBiz configuration management for containers
[ https://issues.apache.org/jira/browse/OFBIZ-12401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17448821#comment-17448821 ] Ioan Eugen Stan commented on OFBIZ-12401: - [~pierresmits] : I'm talking about the configurations you normally need to restart the application for: * ports * database configuration (url, credentials, etc) * Some good libraries for this are: [https://github.com/lightbend/config] - 0 dependency configuration library [https://github.com/cfg4j/cfg4j] - nice feature set - but seems not to be maintained so I am worried I also looked at commons-configuration but I think it brings a lot of baggage. One question is how to migrate existing configurations? > Improved OFBiz configuration management for containers > -- > > Key: OFBIZ-12401 > URL: https://issues.apache.org/jira/browse/OFBIZ-12401 > Project: OFBiz > Issue Type: Sub-task >Reporter: Ioan Eugen Stan >Priority: Major > > It's hard to use OFBiz with containers and other deployment scenarios because > the OFBiz configuration is intertwined with source files and there are a lot > of them. > We also need: > * the ability to override configuration properties > * load configs from a single / handful of files in a single location > * optionally load from multiple sources (files, db, configuration services > like kubernetes, consul ,etc) . > -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Created] (OFBIZ-12401) Improved OFBiz configuration management for containers
Ioan Eugen Stan created OFBIZ-12401: --- Summary: Improved OFBiz configuration management for containers Key: OFBIZ-12401 URL: https://issues.apache.org/jira/browse/OFBIZ-12401 Project: OFBiz Issue Type: Sub-task Reporter: Ioan Eugen Stan It's hard to use OFBiz with containers and other deployment scenarios because the OFBiz configuration is intertwined with source files and there are a lot of them. We also need: * the ability to override configuration properties * load configs from a single / handful of files in a single location * optionally load from multiple sources (files, db, configuration services like kubernetes, consul ,etc) . -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Commented] (OFBIZ-6164) Improve configurability of OFBiz
[
https://issues.apache.org/jira/browse/OFBIZ-6164?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17448536#comment-17448536
]
Ioan Eugen Stan commented on OFBIZ-6164:
We need to improve configuration for deployment as container.
OFBiz has too many configuration files spread over many paths and intermingled
with source files.
This makes it very hard to deploy as containers.
We need configuration federation - ability to read configuration from multiple
sources - files, db, other configs.
It would be also good to have the option of loading configs from less / single
configuration file.
> Improve configurability of OFBiz
>
>
> Key: OFBIZ-6164
> URL: https://issues.apache.org/jira/browse/OFBIZ-6164
> Project: OFBiz
> Issue Type: Improvement
> Components: ALL APPLICATIONS, ALL COMPONENTS
>Affects Versions: Trunk
>Reporter: Pierre Smits
>Priority: Major
> Labels: configuration, multi-tenant
>
> The configuration of an OFBiz is determined by 2 aspects:
> # configuration settings required to successfully start the implementation
> # configuration settings required to have component functions work properly
> The latter involve default choices for various functions to cater to the
> usability of business processes (and therefore screen/forms and/or
> screens/templates.
> Several of these configuration settings are already loaded into the
> SystemProperty table in the underlying RDBMS, to enable adjustments of the
> systemPropertyValue while the implementation is in use. While it is not
> expected that these settings change often, it is possible that they are
> required to be changed during the lifespan of the company/organisation.
> However, it should not be required to go through a deployment process of
> regarding such changed configuration settings in the OFBiz production
> instance (which most - if not all - companies/organisations require when
> files are changes).
> Having all configuration settings of components in the SystemProperty table
> enhances the usability of OFBiz allowing system administrators to adjust the
> value(s) of system property records while the instance keeps running.
> Some examples of the latter kind of configuration settings expected to change
> during the lifespan of the company (and the production instance of OFBiz) are:
> {code:java}
> systemPropertyId="defaultFromEmailAddress"
> systemPropertyValue="ofbizt...@example.com" description="general default
> 'fromEmailAddress' can be overridden in: EmailTemplateSetting"/>
> systemPropertyId="mail.notifications.enabled" systemPropertyValue="N"
> description="mail notifications enabled (Y|N)"/>
> systemPropertyId="mail.smtp.relay.host" description="the default mail server
> to use"/>
> systemPropertyId="mail.smtp.auth.user" description="SMTP Auth username
> setting"/>
> systemPropertyId="mail.smtp.auth.password" description="SMTP Auth password
> setting"/>
> {code}
>
> Furthermore, in a multi-tenancy OFBiz setup, configurations can differ per
> tenant.
> This is a placeholder issue to capture related issues to improve the
> configurability of OFBiz.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Assigned] (OFBIZ-12400) Upgrade to gradle 7.3
[ https://issues.apache.org/jira/browse/OFBIZ-12400?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ioan Eugen Stan reassigned OFBIZ-12400: --- Assignee: Ioan Eugen Stan > Upgrade to gradle 7.3 > -- > > Key: OFBIZ-12400 > URL: https://issues.apache.org/jira/browse/OFBIZ-12400 > Project: OFBiz > Issue Type: Sub-task >Reporter: Ioan Eugen Stan >Assignee: Ioan Eugen Stan >Priority: Major > > For working with Java 17, we need to upgrade to gradle 7.3 -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Created] (OFBIZ-12400) Upgrade to gradle 7.3
Ioan Eugen Stan created OFBIZ-12400: --- Summary: Upgrade to gradle 7.3 Key: OFBIZ-12400 URL: https://issues.apache.org/jira/browse/OFBIZ-12400 Project: OFBiz Issue Type: Sub-task Reporter: Ioan Eugen Stan For working with Java 17, we need to upgrade to gradle 7.3 -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Created] (OFBIZ-12399) Upgrade OFBiz to use Java JDK Version 17
Ioan Eugen Stan created OFBIZ-12399: --- Summary: Upgrade OFBiz to use Java JDK Version 17 Key: OFBIZ-12399 URL: https://issues.apache.org/jira/browse/OFBIZ-12399 Project: OFBiz Issue Type: Improvement Reporter: Ioan Eugen Stan We should have ofbiz owrking with JDK17. This issue should track progress on making that happen. One think we need to do is upgrade gradle to 7.3 . -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Commented] (OFBIZ-5976) Have the ability to configure SVN setup for scrum per tenant
[ https://issues.apache.org/jira/browse/OFBIZ-5976?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17448487#comment-17448487 ] Ioan Eugen Stan commented on OFBIZ-5976: [~pierresmits] Is this relevant? If not maybe we should close it. > Have the ability to configure SVN setup for scrum per tenant > > > Key: OFBIZ-5976 > URL: https://issues.apache.org/jira/browse/OFBIZ-5976 > Project: OFBiz > Issue Type: Sub-task > Components: scrum >Affects Versions: Trunk >Reporter: Pierre Smits >Priority: Major > Labels: configuration, multi-tenant, scrum, svn > > The scrum has the ability to use svn for sprint revisions. > These configuration attributes (properties) are currently referenced in > /scrum/config/revision.properties. > However, this is unusable in a multi-tenant setup as each tenant will need > its own setup to be used. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Comment Edited] (OFBIZ-10757) Upgrade OFBiz to use Java JDK Version 11
[ https://issues.apache.org/jira/browse/OFBIZ-10757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17448471#comment-17448471 ] Ioan Eugen Stan edited comment on OFBIZ-10757 at 11/24/21, 9:34 AM: Can we make some progress on this? I'm looking into building and running ofbiz with jdk 17 and that will require a gradle upgrade - 7.3+ [https://docs.gradle.org/current/userguide/compatibility.html] was (Author: ieugen): Can we make some progress on this? I'm looking into building and running ofbiz with jdk 17 and that will require a gradle upgrade. > Upgrade OFBiz to use Java JDK Version 11 > > > Key: OFBIZ-10757 > URL: https://issues.apache.org/jira/browse/OFBIZ-10757 > Project: OFBiz > Issue Type: Improvement >Affects Versions: Trunk >Reporter: Taher Alkhateeb >Priority: Minor > Attachments: OFBIZ-10757-framework.patch, > OFBIZ-10757-framework.patch, OFBIZ-10757-framework.patch, > OFBIZ-10757-framework.patch, OFBIZ-10757-plugins.patch, > OFBIZ-10757-plugins.patch, OFBIZ-10757_Fix-javadoc-build-for-OpenJDK-11.patch > > > To implement as per [Discussion > Thread|https://lists.apache.org/thread.html/71b8c1048f1dd4c5b3f104233c9af7b2cbc690863fe35b08ef91fcf5@%3Cdev.ofbiz.apache.org%3E] -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Commented] (OFBIZ-10757) Upgrade OFBiz to use Java JDK Version 11
[ https://issues.apache.org/jira/browse/OFBIZ-10757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17448471#comment-17448471 ] Ioan Eugen Stan commented on OFBIZ-10757: - Can we make some progress on this? I'm looking into building and running ofbiz with jdk 17 and that will require a gradle upgrade. > Upgrade OFBiz to use Java JDK Version 11 > > > Key: OFBIZ-10757 > URL: https://issues.apache.org/jira/browse/OFBIZ-10757 > Project: OFBiz > Issue Type: Improvement >Affects Versions: Trunk >Reporter: Taher Alkhateeb >Priority: Minor > Attachments: OFBIZ-10757-framework.patch, > OFBIZ-10757-framework.patch, OFBIZ-10757-framework.patch, > OFBIZ-10757-framework.patch, OFBIZ-10757-plugins.patch, > OFBIZ-10757-plugins.patch, OFBIZ-10757_Fix-javadoc-build-for-OpenJDK-11.patch > > > To implement as per [Discussion > Thread|https://lists.apache.org/thread.html/71b8c1048f1dd4c5b3f104233c9af7b2cbc690863fe35b08ef91fcf5@%3Cdev.ofbiz.apache.org%3E] -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Assigned] (OFBIZ-12145) Setup Romania Tax Authority
[ https://issues.apache.org/jira/browse/OFBIZ-12145?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ioan Eugen Stan reassigned OFBIZ-12145: --- Assignee: Pierre Smits > Setup Romania Tax Authority > --- > > Key: OFBIZ-12145 > URL: https://issues.apache.org/jira/browse/OFBIZ-12145 > Project: OFBiz > Issue Type: Sub-task > Components: datamodel >Affects Versions: Trunk >Reporter: Ioan Eugen Stan >Assignee: Pierre Smits >Priority: Major > Labels: data, demo > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (OFBIZ-12345) Add state/provinces for Romania
[ https://issues.apache.org/jira/browse/OFBIZ-12345?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ioan Eugen Stan reassigned OFBIZ-12345: --- Assignee: Ioan Eugen Stan > Add state/provinces for Romania > --- > > Key: OFBIZ-12345 > URL: https://issues.apache.org/jira/browse/OFBIZ-12345 > Project: OFBiz > Issue Type: Sub-task >Reporter: Ioan Eugen Stan >Assignee: Ioan Eugen Stan >Priority: Major > > When creating new contact information we should be able to select the state / > provinces in Romania > Right now I get : > |State/Province|No States/Provinces exist | -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-12144) Setup Romania GeoData
[ https://issues.apache.org/jira/browse/OFBIZ-12144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17437359#comment-17437359 ] Ioan Eugen Stan commented on OFBIZ-12144: - Thanks. I will check to see if they are in the proper files and focus my efforts in adding the other pieces of data: Counties, cities, postal codes, etc. > Setup Romania GeoData > - > > Key: OFBIZ-12144 > URL: https://issues.apache.org/jira/browse/OFBIZ-12144 > Project: OFBiz > Issue Type: Sub-task >Reporter: Ioan Eugen Stan >Assignee: Ioan Eugen Stan >Priority: Major > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (OFBIZ-12141) Add support for Romania
[ https://issues.apache.org/jira/browse/OFBIZ-12141?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ioan Eugen Stan reassigned OFBIZ-12141: --- Assignee: Ioan Eugen Stan > Add support for Romania > --- > > Key: OFBIZ-12141 > URL: https://issues.apache.org/jira/browse/OFBIZ-12141 > Project: OFBiz > Issue Type: New Feature >Reporter: Ioan Eugen Stan >Assignee: Ioan Eugen Stan >Priority: Major > > I would like to add support for Romania to OFBiz: provinces, taxes and the > rest. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (OFBIZ-12144) Setup Romania GeoData
[ https://issues.apache.org/jira/browse/OFBIZ-12144?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ioan Eugen Stan reassigned OFBIZ-12144: --- Assignee: Ioan Eugen Stan > Setup Romania GeoData > - > > Key: OFBIZ-12144 > URL: https://issues.apache.org/jira/browse/OFBIZ-12144 > Project: OFBiz > Issue Type: Sub-task >Reporter: Ioan Eugen Stan >Assignee: Ioan Eugen Stan >Priority: Major > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-12345) Add state/provinces for Romania
[ https://issues.apache.org/jira/browse/OFBIZ-12345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17436700#comment-17436700 ] Ioan Eugen Stan commented on OFBIZ-12345: - I created some data and imported it but noticed the select menu for state province does not change. Romania does not have states or provinces but we use counties as an administrative subdivision. If I prepare an OFBIz installation for Romania State / Province will always be empty . An alternative would be to change that for Counties or to add counties to the list: State / Province / County and do the following algorithm: * Load states and provinces. * If the state/province list is empty - load counties Any recommendations on how to address this ? > Add state/provinces for Romania > --- > > Key: OFBIZ-12345 > URL: https://issues.apache.org/jira/browse/OFBIZ-12345 > Project: OFBiz > Issue Type: Sub-task >Reporter: Ioan Eugen Stan >Priority: Major > > When creating new contact information we should be able to select the state / > provinces in Romania > Right now I get : > |State/Province|No States/Provinces exist | -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OFBIZ-12347) Setup chart of accounts for Romania
[ https://issues.apache.org/jira/browse/OFBIZ-12347?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ioan Eugen Stan updated OFBIZ-12347: Description: As part of creating a company we need to setup the chart of accounts for our new company. We need to have a chart of accounts for Romania. The OFBiz Global Template is very US focused. was: As part of creating a company we need to setup the chart of accounts for our new company. We need to have a chart of accounts for Romania. > Setup chart of accounts for Romania > --- > > Key: OFBIZ-12347 > URL: https://issues.apache.org/jira/browse/OFBIZ-12347 > Project: OFBiz > Issue Type: Sub-task >Reporter: Ioan Eugen Stan >Priority: Major > > As part of creating a company we need to setup the chart of accounts for our > new company. > We need to have a chart of accounts for Romania. > > The OFBiz Global Template is very US focused. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (OFBIZ-12347) Setup chart of accounts for Romania
Ioan Eugen Stan created OFBIZ-12347: --- Summary: Setup chart of accounts for Romania Key: OFBIZ-12347 URL: https://issues.apache.org/jira/browse/OFBIZ-12347 Project: OFBiz Issue Type: Sub-task Reporter: Ioan Eugen Stan As part of creating a company we need to setup the chart of accounts for our new company. We need to have a chart of accounts for Romania. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (OFBIZ-12346) Add Romanian Tax Form - when creating a new Accounting company
Ioan Eugen Stan created OFBIZ-12346: --- Summary: Add Romanian Tax Form - when creating a new Accounting company Key: OFBIZ-12346 URL: https://issues.apache.org/jira/browse/OFBIZ-12346 Project: OFBiz Issue Type: Sub-task Reporter: Ioan Eugen Stan When creating a new Accounting company in OFBIz via Accounting / Organization GL Settings -> New accounting company, the field "Tax Form for Organization" contains only US values ( system initialized without demo data). We should find out what are the values for Romania and prepare data for them. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (OFBIZ-12345) Add state/provinces for Romania
Ioan Eugen Stan created OFBIZ-12345: --- Summary: Add state/provinces for Romania Key: OFBIZ-12345 URL: https://issues.apache.org/jira/browse/OFBIZ-12345 Project: OFBiz Issue Type: Sub-task Reporter: Ioan Eugen Stan When creating new contact information we should be able to select the state / provinces in Romania Right now I get : |State/Province|No States/Provinces exist | -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (OFBIZ-12309) Establish logical dependency tree for ofbiz components
Ioan Eugen Stan created OFBIZ-12309:
---
Summary: Establish logical dependency tree for ofbiz components
Key: OFBIZ-12309
URL: https://issues.apache.org/jira/browse/OFBIZ-12309
Project: OFBiz
Issue Type: Sub-task
Components: framework
Affects Versions: Trunk
Reporter: Ioan Eugen Stan
>From the exploratory branch
>[https://github.com/apache/ofbiz-framework/pull/319] I discovered there are a
>lot of circular dependencies between components (components depending on each
>other in order to build.
I believe it would be very useful to have a logical dependency tree between
components.
As a developer working to make OFBiz usable as a framework I need to solve
issues like circular dependencies between components (see
https://issues.apache.org/jira/browse/OFBIZ-12308 ) .
This should serve as a guide to help me decide how to solve the circular
dependency issue.
This is the current list of dependencies in framework (applications should be
in another issue IMO).
{noformat}
{noformat}
While working on https://issues.apache.org/jira/browse/OFBIZ-3500 for
[https://cwiki.apache.org/confluence/display/OFBIZ/Ofbiz+as+a+development+framework+-+release+9.04]
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Created] (OFBIZ-12308) Remove circular dependency between start and base components
Ioan Eugen Stan created OFBIZ-12308: --- Summary: Remove circular dependency between start and base components Key: OFBIZ-12308 URL: https://issues.apache.org/jira/browse/OFBIZ-12308 Project: OFBiz Issue Type: Sub-task Components: base, start Reporter: Ioan Eugen Stan Right now start and base components depend one on the other. This should be resolved so that only 1 component should depend on the other. *Guidance needed.* Not sure right now if start should depend on base or the reverse. This was discovered as part of exploratory branch [https://github.com/apache/ofbiz-framework/pull/319] . I believe a logical dependency tree for components is needed. This dependency tree will help guide people when needing to decide which component should depend on which. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OFBIZ-12302) Add Clojure service engine implementation
[ https://issues.apache.org/jira/browse/OFBIZ-12302?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ioan Eugen Stan updated OFBIZ-12302: Description: Add support for Clojure services. Implement Clojure Service engine. https://github.com/apache/ofbiz-framework/pull/317 was:Add support for Clojure services. Implement Clojure Service engine. > Add Clojure service engine implementation > - > > Key: OFBIZ-12302 > URL: https://issues.apache.org/jira/browse/OFBIZ-12302 > Project: OFBiz > Issue Type: New Feature > Components: framework, framework/service >Affects Versions: Trunk >Reporter: Ioan Eugen Stan >Priority: Minor > > Add support for Clojure services. Implement Clojure Service engine. > > https://github.com/apache/ofbiz-framework/pull/317 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (OFBIZ-12302) Add Clojure service engine implementation
Ioan Eugen Stan created OFBIZ-12302: --- Summary: Add Clojure service engine implementation Key: OFBIZ-12302 URL: https://issues.apache.org/jira/browse/OFBIZ-12302 Project: OFBiz Issue Type: New Feature Components: framework, framework/service Affects Versions: Trunk Reporter: Ioan Eugen Stan Add support for Clojure services. Implement Clojure Service engine. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-7536) Clean up commented out code
[ https://issues.apache.org/jira/browse/OFBIZ-7536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17377505#comment-17377505 ] Ioan Eugen Stan commented on OFBIZ-7536: I added 2 PR's for last issues. We can close this once all of them are merged. > Clean up commented out code > --- > > Key: OFBIZ-7536 > URL: https://issues.apache.org/jira/browse/OFBIZ-7536 > Project: OFBiz > Issue Type: Improvement > Components: ALL COMPONENTS >Reporter: Harsh Vijaywargiya >Assignee: Harsh Vijaywargiya >Priority: Major > > In our Re-Factor To-Do List one of the item is to clean up the commented out > code. > This is the parent ticket and I will further create sub tasks under it so > that we do not push large change in one commit. > This includes Java, Xml, Groovy and FTL files. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-8042) Clean up commented out code in Java source for Webapp component
[ https://issues.apache.org/jira/browse/OFBIZ-8042?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17377503#comment-17377503 ] Ioan Eugen Stan commented on OFBIZ-8042: PR available https://github.com/apache/ofbiz-framework/pull/312 > Clean up commented out code in Java source for Webapp component > --- > > Key: OFBIZ-8042 > URL: https://issues.apache.org/jira/browse/OFBIZ-8042 > Project: OFBiz > Issue Type: Sub-task > Components: framework >Reporter: Harsh Vijaywargiya >Assignee: Harsh Vijaywargiya >Priority: Minor > > Clean up commented out code in Java source for Webapp component -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-8043) Clean up commented out code in Java source for Webtools component
[ https://issues.apache.org/jira/browse/OFBIZ-8043?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17377502#comment-17377502 ] Ioan Eugen Stan commented on OFBIZ-8043: PR available https://github.com/apache/ofbiz-framework/pull/313/files > Clean up commented out code in Java source for Webtools component > - > > Key: OFBIZ-8043 > URL: https://issues.apache.org/jira/browse/OFBIZ-8043 > Project: OFBiz > Issue Type: Sub-task > Components: framework >Reporter: Harsh Vijaywargiya >Assignee: Harsh Vijaywargiya >Priority: Minor > > Clean up commented out code in Java source for Webtools component -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-8040) Clean up commented out code in Java source for Service component
[ https://issues.apache.org/jira/browse/OFBIZ-8040?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17376310#comment-17376310 ] Ioan Eugen Stan commented on OFBIZ-8040: PR available [https://github.com/apache/ofbiz-framework/pull/310] . > Clean up commented out code in Java source for Service component > > > Key: OFBIZ-8040 > URL: https://issues.apache.org/jira/browse/OFBIZ-8040 > Project: OFBiz > Issue Type: Sub-task > Components: framework >Reporter: Harsh Vijaywargiya >Assignee: Harsh Vijaywargiya >Priority: Minor > > Clean up commented out code in Java source for Service component -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-8040) Clean up commented out code in Java source for Service component
[ https://issues.apache.org/jira/browse/OFBIZ-8040?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17376268#comment-17376268 ] Ioan Eugen Stan commented on OFBIZ-8040: Started working on this one. > Clean up commented out code in Java source for Service component > > > Key: OFBIZ-8040 > URL: https://issues.apache.org/jira/browse/OFBIZ-8040 > Project: OFBiz > Issue Type: Sub-task > Components: framework >Reporter: Harsh Vijaywargiya >Assignee: Harsh Vijaywargiya >Priority: Minor > > Clean up commented out code in Java source for Service component -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-7536) Clean up commented out code
[ https://issues.apache.org/jira/browse/OFBIZ-7536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17373987#comment-17373987 ] Ioan Eugen Stan commented on OFBIZ-7536: I started working on this and issue a PR for Entity. Will find some time for the others. My proposal for minilang is to close the issue since it is going out and no need to waste time fixing comments. > Clean up commented out code > --- > > Key: OFBIZ-7536 > URL: https://issues.apache.org/jira/browse/OFBIZ-7536 > Project: OFBiz > Issue Type: Improvement > Components: ALL COMPONENTS >Reporter: Harsh Vijaywargiya >Assignee: Harsh Vijaywargiya >Priority: Major > > In our Re-Factor To-Do List one of the item is to clean up the commented out > code. > This is the parent ticket and I will further create sub tasks under it so > that we do not push large change in one commit. > This includes Java, Xml, Groovy and FTL files. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-8038) Clean up commented out code in Java source for Entity component
[ https://issues.apache.org/jira/browse/OFBIZ-8038?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17373984#comment-17373984 ] Ioan Eugen Stan commented on OFBIZ-8038: A PR is available for this [https://github.com/apache/ofbiz-framework/pull/308] . > Clean up commented out code in Java source for Entity component > --- > > Key: OFBIZ-8038 > URL: https://issues.apache.org/jira/browse/OFBIZ-8038 > Project: OFBiz > Issue Type: Sub-task > Components: framework >Reporter: Harsh Vijaywargiya >Assignee: Harsh Vijaywargiya >Priority: Minor > > Clean up commented out code in Java source for Entity component -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-8038) Clean up commented out code in Java source for Entity component
[ https://issues.apache.org/jira/browse/OFBIZ-8038?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17373986#comment-17373986 ] Ioan Eugen Stan commented on OFBIZ-8038: Some comments might be reverted. They seem to be used for debugging. I removed them to make them stand out for review. > Clean up commented out code in Java source for Entity component > --- > > Key: OFBIZ-8038 > URL: https://issues.apache.org/jira/browse/OFBIZ-8038 > Project: OFBiz > Issue Type: Sub-task > Components: framework >Reporter: Harsh Vijaywargiya >Assignee: Harsh Vijaywargiya >Priority: Minor > > Clean up commented out code in Java source for Entity component -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-8038) Clean up commented out code in Java source for Entity component
[ https://issues.apache.org/jira/browse/OFBIZ-8038?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17373975#comment-17373975 ] Ioan Eugen Stan commented on OFBIZ-8038: I checked org.apache.ofbiz.entity package , the XSD and xml for config dtd and entitydef. There is no outstanding commented code. Will continue with the other packages. > Clean up commented out code in Java source for Entity component > --- > > Key: OFBIZ-8038 > URL: https://issues.apache.org/jira/browse/OFBIZ-8038 > Project: OFBiz > Issue Type: Sub-task > Components: framework >Reporter: Harsh Vijaywargiya >Assignee: Harsh Vijaywargiya >Priority: Minor > > Clean up commented out code in Java source for Entity component -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Comment Edited] (OFBIZ-3500) Umbrella issue for components dependency
[
https://issues.apache.org/jira/browse/OFBIZ-3500?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17371694#comment-17371694
]
Ioan Eugen Stan edited comment on OFBIZ-3500 at 6/29/21, 10:33 PM:
---
I think this would be much simpler to see components if ofbiz used a
build.gradle file (subproject) per component.
Right now activateComponent scans directories and creates gradle projects
dynamically.
Why not use actual build.gradle configurations for the framework and
applications ?
Projects can use common dependencies:
[https://stackoverflow.com/questions/9547170/in-gradle-how-do-i-declare-common-dependencies-in-a-single-place]
:
{code:java}
libraries = [
spring: [ // Groovy list literal
"org.springframework:spring-core:3.1",
"org.springframework:spring-jdbc:3.1"
]
]
dependencies { compile libraries.spring }
{code}
By using real projects we could also publish a jar per component and those
could be used as libraries.
I would love to use OFBiz framework as a library (the entity layer is very
useful).
was (Author: ieugen):
I think this would be much simpler to see components if ofbiz used a
build.gradle file (subproject) per component.
Right now activateComponent scans the classpath and creates gradle projects
dynamically.
Why not use actual build.gradle configurations for the framework and
applications ?
Projects can use common dependencies:
[https://stackoverflow.com/questions/9547170/in-gradle-how-do-i-declare-common-dependencies-in-a-single-place]
:
{code:java}
libraries = [
spring: [ // Groovy list literal
"org.springframework:spring-core:3.1",
"org.springframework:spring-jdbc:3.1"
]
]
dependencies { compile libraries.spring }
{code}
By using real projects we could also publish a jar per component and those
could be used as libraries.
I would love to use OFBiz framework as a library (the entity layer is very
useful).
> Umbrella issue for components dependency
>
>
> Key: OFBIZ-3500
> URL: https://issues.apache.org/jira/browse/OFBIZ-3500
> Project: OFBiz
> Issue Type: Improvement
> Components: ALL COMPONENTS
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Priority: Major
> Attachments: dependencyCheck.groovy
>
>
> This issue is dedicated to group components dependency related issues.
> Chris Snow created [this related Wiki
> page|http://cwiki.apache.org/confluence/x/eIOJ]
> There is now a
> https://cwiki.apache.org/confluence/display/OFBIZ/Component+and+Component+Set+Dependencies
> wiki page which is more up to data (still small things to clean)
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (OFBIZ-3500) Umbrella issue for components dependency
[
https://issues.apache.org/jira/browse/OFBIZ-3500?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17371694#comment-17371694
]
Ioan Eugen Stan commented on OFBIZ-3500:
I think this would be much simpler to see components if ofbiz used a
build.gradle file (subproject) per component.
Right now activateComponent scans the classpath and creates gradle projects
dynamically.
Why not use actual build.gradle configurations for the framework and
applications ?
Projects can use common dependencies:
[https://stackoverflow.com/questions/9547170/in-gradle-how-do-i-declare-common-dependencies-in-a-single-place]
:
{code:java}
libraries = [
spring: [ // Groovy list literal
"org.springframework:spring-core:3.1",
"org.springframework:spring-jdbc:3.1"
]
]
dependencies { compile libraries.spring }
{code}
By using real projects we could also publish a jar per component and those
could be used as libraries.
I would love to use OFBiz framework as a library (the entity layer is very
useful).
> Umbrella issue for components dependency
>
>
> Key: OFBIZ-3500
> URL: https://issues.apache.org/jira/browse/OFBIZ-3500
> Project: OFBiz
> Issue Type: Improvement
> Components: ALL COMPONENTS
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Priority: Major
> Attachments: dependencyCheck.groovy
>
>
> This issue is dedicated to group components dependency related issues.
> Chris Snow created [this related Wiki
> page|http://cwiki.apache.org/confluence/x/eIOJ]
> There is now a
> https://cwiki.apache.org/confluence/display/OFBIZ/Component+and+Component+Set+Dependencies
> wiki page which is more up to data (still small things to clean)
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (OFBIZ-9235) The ecommerce webapp is broken in R14/15
[ https://issues.apache.org/jira/browse/OFBIZ-9235?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17371684#comment-17371684 ] Ioan Eugen Stan commented on OFBIZ-9235: This is also old and can be closed. R17 is out. > The ecommerce webapp is broken in R14/15 > > > Key: OFBIZ-9235 > URL: https://issues.apache.org/jira/browse/OFBIZ-9235 > Project: OFBiz > Issue Type: Bug > Components: ecommerce >Affects Versions: Release Branch 14.12, Release Branch 15.12 >Reporter: Jacques Le Roux >Priority: Major > > While working on OFBIZ-9234 I noticed that, when coming from catalog/product > or not, the ecommerce webapp is broken in R14/15 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-7155) Remove jce-jdk13-154.jar
[
https://issues.apache.org/jira/browse/OFBIZ-7155?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17371682#comment-17371682
]
Ioan Eugen Stan commented on OFBIZ-7155:
I checked the trunk lib directory and the library does not exist.
I think we can close this one.
> Remove jce-jdk13-154.jar
>
>
> Key: OFBIZ-7155
> URL: https://issues.apache.org/jira/browse/OFBIZ-7155
> Project: OFBiz
> Issue Type: Bug
> Components: framework
>Affects Versions: Release Branch 15.12, Trunk
>Reporter: Christian Geisert
>Assignee: Christian Geisert
>Priority: Major
>
> After updating our project to the latest release15.12 branch we got the
> following error when accessing OFBiz pages:
> {code}
> 2016-06-01 14:37:14,040 |http-nio-8443-exec-2 |NioEndpoint
> |E|
> java.lang.RuntimeException: Could not generate DH keypair
> at sun.security.ssl.Handshaker.checkThrown(Handshaker.java:1429)
> ~[?:1.8.0_77]
> ...
> Caused by: java.security.InvalidAlgorithmParameterException: parameter object
> not a ECParameterSpec
> at
> org.bouncycastle.jcajce.provider.asymmetric.ec.KeyPairGeneratorSpi$EC.initialize(Unknown
> Source) ~[jce-jdk13-154.jar:1.54.0]
> ...
> {code}
> It turned out that jce-jdk13-154.jar was the culprit. After removing this Jar
> everything worked as expected. As this jar is an optional dependency of
> PDFBox (which is used by Tika) and is only need for Java < 1.7 I propose to
> remove it from OFBiz.
> I'll wait a few days and if there are no objections I'll remove the jar
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (OFBIZ-7536) Clean up commented out code
[ https://issues.apache.org/jira/browse/OFBIZ-7536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17371660#comment-17371660 ] Ioan Eugen Stan commented on OFBIZ-7536: Is this still relevant? I might be able to help out. > Clean up commented out code > --- > > Key: OFBIZ-7536 > URL: https://issues.apache.org/jira/browse/OFBIZ-7536 > Project: OFBiz > Issue Type: Improvement > Components: ALL COMPONENTS >Reporter: Harsh Vijaywargiya >Assignee: Harsh Vijaywargiya >Priority: Major > > In our Re-Factor To-Do List one of the item is to clean up the commented out > code. > This is the parent ticket and I will further create sub tasks under it so > that we do not push large change in one commit. > This includes Java, Xml, Groovy and FTL files. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-12267) Cleanup: Remove svn related code from build
[ https://issues.apache.org/jira/browse/OFBIZ-12267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17370574#comment-17370574 ] Ioan Eugen Stan commented on OFBIZ-12267: - https://github.com/apache/ofbiz-framework/pull/305 > Cleanup: Remove svn related code from build > --- > > Key: OFBIZ-12267 > URL: https://issues.apache.org/jira/browse/OFBIZ-12267 > Project: OFBiz > Issue Type: Improvement >Reporter: Ioan Eugen Stan >Priority: Trivial > > Remove references to SVN from build.gradle . > As discussed today on ML. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OFBIZ-12267) Cleanup: Remove svn related code from build
[ https://issues.apache.org/jira/browse/OFBIZ-12267?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ioan Eugen Stan updated OFBIZ-12267: Summary: Cleanup: Remove svn related code from build (was: cleanu: Remove svn related code from build) > Cleanup: Remove svn related code from build > --- > > Key: OFBIZ-12267 > URL: https://issues.apache.org/jira/browse/OFBIZ-12267 > Project: OFBiz > Issue Type: Improvement >Reporter: Ioan Eugen Stan >Priority: Trivial > > Remove references to SVN from build.gradle . > As discussed today on ML. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (OFBIZ-12267) cleanu: Remove svn related code from build
Ioan Eugen Stan created OFBIZ-12267: --- Summary: cleanu: Remove svn related code from build Key: OFBIZ-12267 URL: https://issues.apache.org/jira/browse/OFBIZ-12267 Project: OFBiz Issue Type: Improvement Reporter: Ioan Eugen Stan Remove references to SVN from build.gradle . As discussed today on ML. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-12263) Cannot compile plugins with dependencies in other repositories - clojars repo
[ https://issues.apache.org/jira/browse/OFBIZ-12263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17370501#comment-17370501 ] Ioan Eugen Stan commented on OFBIZ-12263: - Thanks. It does not look very promising. People usually have little patience when trying out new things so it is good to make it easy to quickstart. I think plugins should be easy to develop so the user community grow and then the dev community will grow with it. Would people be open to change how ofbiz and plugins are built? I know not everyone is happy with OFBiz being built as a monolith app but I also know gradle has features that might allow us to have the cake and eat it. I'm looking at gradle composing builds: [https://docs.gradle.org/current/userguide/composite_builds.html] . Composite builds allow you to have a master build that includes other independent builds. We could split OFBiz into a few builds. Each build would be independent but reusable as source projects in other builds. Plugins could also be included like that and they could also include other ofbiz builds that they depend on (framework or even another app plugin ?!) I don't think this approach will cause significant user experience changes, but should make the project reusable / less monolithic. Would you support something like this? > Cannot compile plugins with dependencies in other repositories - clojars repo > - > > Key: OFBIZ-12263 > URL: https://issues.apache.org/jira/browse/OFBIZ-12263 > Project: OFBiz > Issue Type: New Feature >Reporter: Ioan Eugen Stan >Priority: Minor > > I would like to build a plugin that contains a dependency from Clojars > repository. > [https://github.com/netdava/ofbiz-clojure-repl] > Clojuras is not in the list of OFBiz repositories and the plugin fails to > build. > Adding clojars to the plugin repository configuration does not work. > > Adding clojars to the main gradle project (in subprojects repository) works. > However this approach leads to add all repos in main project and possibly > upstream. > > I think another approach is necessary for this. > A solution would be to make the plugins more independent from the main > project. > This could be achieved by using a BOM ? > [https://dzone.com/articles/gradle-goodness-use-bill-of-materials-bom-as-depen] > [https://docs.gradle.org/current/userguide/platforms.html#sub:using-platform-to-control-transitive-deps] > This will probably require to publish ofbiz binaries. > > ML discussion: [ > https://lists.apache.org/thread.html/rc8151611a7946b2e9be88755fd44b89af66356941613f4ddff9cdf17%40%3Cdev.ofbiz.apache.org%3E|https://lists.apache.org/thread.html/rc8151611a7946b2e9be88755fd44b89af66356941613f4ddff9cdf17%40%3Cdev.ofbiz.apache.org%3E] > [https://docs.gradle.org/current/userguide/declaring_repositories.html] > [https://discuss.gradle.org/t/repositories-in-subprojects/23596/2] > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-12263) Cannot compile plugins with dependencies in other repositories - clojars repo
[
https://issues.apache.org/jira/browse/OFBIZ-12263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17370206#comment-17370206
]
Ioan Eugen Stan commented on OFBIZ-12263:
-
Hi [~mbrohl] ,
Thanks for looking at this.
I don't understand what you are suggesting.
I tried adding clojars repository to my plugin in the `repositories {}` code
block but it does not work.
I researched a bit and did not find a solution.
I would like to distribute my plugin so people can use it but right now they
can't build it unless they make changes to OFBiz source code.
If you know of a way for me to solve this, please share and I will do my best
to document it.
But right now, IMO there is no clear way to develop plugins that have
dependencies outside the repositories currently used by OFBiz.
Hence the issue I created.
Thanks,
Eugen
> Cannot compile plugins with dependencies in other repositories - clojars repo
> -
>
> Key: OFBIZ-12263
> URL: https://issues.apache.org/jira/browse/OFBIZ-12263
> Project: OFBiz
> Issue Type: New Feature
>Reporter: Ioan Eugen Stan
>Priority: Minor
>
> I would like to build a plugin that contains a dependency from Clojars
> repository.
> [https://github.com/netdava/ofbiz-clojure-repl]
> Clojuras is not in the list of OFBiz repositories and the plugin fails to
> build.
> Adding clojars to the plugin repository configuration does not work.
>
> Adding clojars to the main gradle project (in subprojects repository) works.
> However this approach leads to add all repos in main project and possibly
> upstream.
>
> I think another approach is necessary for this.
> A solution would be to make the plugins more independent from the main
> project.
> This could be achieved by using a BOM ?
> [https://dzone.com/articles/gradle-goodness-use-bill-of-materials-bom-as-depen]
> [https://docs.gradle.org/current/userguide/platforms.html#sub:using-platform-to-control-transitive-deps]
> This will probably require to publish ofbiz binaries.
>
> ML discussion: [
> https://lists.apache.org/thread.html/rc8151611a7946b2e9be88755fd44b89af66356941613f4ddff9cdf17%40%3Cdev.ofbiz.apache.org%3E|https://lists.apache.org/thread.html/rc8151611a7946b2e9be88755fd44b89af66356941613f4ddff9cdf17%40%3Cdev.ofbiz.apache.org%3E]
> [https://docs.gradle.org/current/userguide/declaring_repositories.html]
> [https://discuss.gradle.org/t/repositories-in-subprojects/23596/2]
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (OFBIZ-12263) Cannot compile plugins with dependencies in other repositories - clojars repo
[ https://issues.apache.org/jira/browse/OFBIZ-12263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17367149#comment-17367149 ] Ioan Eugen Stan commented on OFBIZ-12263: - I've added a PR to fix the clojars issue but the underline issue remains unresolved: We don't have a clean way to develop plugins with private repositories / a way for plugins to decide the repositories they use for dependencies. https://github.com/apache/ofbiz-framework/pull/304/files > Cannot compile plugins with dependencies in other repositories - clojars repo > - > > Key: OFBIZ-12263 > URL: https://issues.apache.org/jira/browse/OFBIZ-12263 > Project: OFBiz > Issue Type: Bug >Reporter: Ioan Eugen Stan >Priority: Major > > I would like to build a plugin that contains a dependency from Clojars > repository. > [https://github.com/netdava/ofbiz-clojure-repl] > Clojuras is not in the list of OFBiz repositories and the plugin fails to > build. > Adding clojars to the plugin repository configuration does not work. > > Adding clojars to the main gradle project (in subprojects repository) works. > However this approach leads to add all repos in main project and possibly > upstream. > > I think another approach is necessary for this. > A solution would be to make the plugins more independent from the main > project. > This could be achieved by using a BOM ? > [https://dzone.com/articles/gradle-goodness-use-bill-of-materials-bom-as-depen] > [https://docs.gradle.org/current/userguide/platforms.html#sub:using-platform-to-control-transitive-deps] > This will probably require to publish ofbiz binaries. > > ML discussion: [ > https://lists.apache.org/thread.html/rc8151611a7946b2e9be88755fd44b89af66356941613f4ddff9cdf17%40%3Cdev.ofbiz.apache.org%3E|https://lists.apache.org/thread.html/rc8151611a7946b2e9be88755fd44b89af66356941613f4ddff9cdf17%40%3Cdev.ofbiz.apache.org%3E] > [https://docs.gradle.org/current/userguide/declaring_repositories.html] > [https://discuss.gradle.org/t/repositories-in-subprojects/23596/2] > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (OFBIZ-12263) Cannot compile plugins with dependencies in other repositories - clojars repo
Ioan Eugen Stan created OFBIZ-12263: --- Summary: Cannot compile plugins with dependencies in other repositories - clojars repo Key: OFBIZ-12263 URL: https://issues.apache.org/jira/browse/OFBIZ-12263 Project: OFBiz Issue Type: Bug Reporter: Ioan Eugen Stan I would like to build a plugin that contains a dependency from Clojars repository. [https://github.com/netdava/ofbiz-clojure-repl] Clojuras is not in the list of OFBiz repositories and the plugin fails to build. Adding clojars to the plugin repository configuration does not work. Adding clojars to the main gradle project (in subprojects repository) works. However this approach leads to add all repos in main project and possibly upstream. I think another approach is necessary for this. A solution would be to make the plugins more independent from the main project. This could be achieved by using a BOM ? [https://dzone.com/articles/gradle-goodness-use-bill-of-materials-bom-as-depen] [https://docs.gradle.org/current/userguide/platforms.html#sub:using-platform-to-control-transitive-deps] This will probably require to publish ofbiz binaries. ML discussion: [ https://lists.apache.org/thread.html/rc8151611a7946b2e9be88755fd44b89af66356941613f4ddff9cdf17%40%3Cdev.ofbiz.apache.org%3E|https://lists.apache.org/thread.html/rc8151611a7946b2e9be88755fd44b89af66356941613f4ddff9cdf17%40%3Cdev.ofbiz.apache.org%3E] [https://docs.gradle.org/current/userguide/declaring_repositories.html] [https://discuss.gradle.org/t/repositories-in-subprojects/23596/2] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-12141) Add support for Romania
[ https://issues.apache.org/jira/browse/OFBIZ-12141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17276972#comment-17276972 ] Ioan Eugen Stan commented on OFBIZ-12141: - Thank you for your feedback. After reading the comments on https://issues.apache.org/jira/browse/LEGAL-556 I think the best option would be to setup a script that can download the data at build / install /run time. That way we avoid any legal issues. > Add support for Romania > --- > > Key: OFBIZ-12141 > URL: https://issues.apache.org/jira/browse/OFBIZ-12141 > Project: OFBiz > Issue Type: New Feature >Reporter: Ioan Eugen Stan >Priority: Major > > I would like to add support for Romania to OFBiz: provinces, taxes and the > rest. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-12141) Add support for Romania
[ https://issues.apache.org/jira/browse/OFBIZ-12141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17272028#comment-17272028 ] Ioan Eugen Stan commented on OFBIZ-12141: - Hi [~jmclean] . Thank you for showing interest in this. The data is licensed under OGL-ROU: See [https://data.gov.ro/dataset/siruta/resource/ed3f9ec6-8c12-4ba6-8688-74cadc69f14b] , look for ||Licență|[OGL-ROU-1.0|https://data.gov.ro/pages/licence]| Note: Licență is License in Romanian. I'll check the ASF license pages you shared. I would like to process and transform (process) the CSV into a XML with cities/provinces for use and distribute with OFBiz. > Add support for Romania > --- > > Key: OFBIZ-12141 > URL: https://issues.apache.org/jira/browse/OFBIZ-12141 > Project: OFBiz > Issue Type: New Feature >Reporter: Ioan Eugen Stan >Priority: Major > > I would like to add support for Romania to OFBiz: provinces, taxes and the > rest. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11855) Convert RoutingServices.xml mini-lang to groovy
[ https://issues.apache.org/jira/browse/OFBIZ-11855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17268613#comment-17268613 ] Ioan Eugen Stan commented on OFBIZ-11855: - Cool. Once I get more familiar with the processes (and the code) I will be able to help more with this. Right now I'm working on setting up my first instance. > Convert RoutingServices.xml mini-lang to groovy > --- > > Key: OFBIZ-11855 > URL: https://issues.apache.org/jira/browse/OFBIZ-11855 > Project: OFBiz > Issue Type: Sub-task >Reporter: Wiebke Pätzold >Assignee: Yashwant Dhakad >Priority: Minor > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-12141) Add support for Romania
[ https://issues.apache.org/jira/browse/OFBIZ-12141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17268064#comment-17268064 ] Ioan Eugen Stan commented on OFBIZ-12141: - Thank you Jacques. I've opened and linked the issue in legal. I hope that is enough. Please Let me know if I need to send a message to the legal ML. > Add support for Romania > --- > > Key: OFBIZ-12141 > URL: https://issues.apache.org/jira/browse/OFBIZ-12141 > Project: OFBiz > Issue Type: New Feature >Reporter: Ioan Eugen Stan >Priority: Major > > I would like to add support for Romania to OFBiz: provinces, taxes and the > rest. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (OFBIZ-12145) Setup Romania Tax Authority
Ioan Eugen Stan created OFBIZ-12145: --- Summary: Setup Romania Tax Authority Key: OFBIZ-12145 URL: https://issues.apache.org/jira/browse/OFBIZ-12145 Project: OFBiz Issue Type: Sub-task Reporter: Ioan Eugen Stan -- This message was sent by Atlassian Jira (v8.3.4#803005)
