[jira] [Updated] (OFBIZ-13092) [SECURITY] (CVE-2024-36104) Path traversal leading to RCE

2024-06-03 Thread Jacques Le Roux (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-13092?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux updated OFBIZ-13092:

Summary: [SECURITY] (CVE-2024-36104) Path traversal leading to RCE  (was: 
Prevent special encoded characters sequences in URLs)

> [SECURITY] (CVE-2024-36104) Path traversal leading to RCE
> -
>
> Key: OFBIZ-13092
> URL: https://issues.apache.org/jira/browse/OFBIZ-13092
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: framework/webapp
>Affects Versions: 18.12.14
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Major
> Fix For: 18.12.14
>
>
> Better avoid special encoded characters sequences 



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Closed] (OFBIZ-13113) Upgrade to 2.3.33 FreeMarker release

2024-06-03 Thread Jacques Le Roux (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-13113?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux closed OFBIZ-13113.
---
Resolution: Implemented

> Upgrade to 2.3.33 FreeMarker release
> 
>
> Key: OFBIZ-13113
> URL: https://issues.apache.org/jira/browse/OFBIZ-13113
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL COMPONENTS
>Affects Versions: Upcoming Branch
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Major
> Fix For: Upcoming Branch
>
>
> This follows OFBIZ-12935 after 
> https://lists.apache.org/thread/bx41zsbyc8prccol8fkgpkqhsd3293so



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Created] (OFBIZ-13113) Upgrade to 2.3.33 FreeMarker release

2024-06-03 Thread Jacques Le Roux (Jira)
Jacques Le Roux created OFBIZ-13113:
---

 Summary: Upgrade to 2.3.33 FreeMarker release
 Key: OFBIZ-13113
 URL: https://issues.apache.org/jira/browse/OFBIZ-13113
 Project: OFBiz
  Issue Type: Improvement
  Components: ALL COMPONENTS
Affects Versions: Upcoming Branch
Reporter: Jacques Le Roux
Assignee: Jacques Le Roux
 Fix For: Upcoming Branch


This follows OFBIZ-12935 after 
https://lists.apache.org/thread/bx41zsbyc8prccol8fkgpkqhsd3293so



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (OFBIZ-13110) PartyFinancialHistory shows parentTypeId of invoice, not invoiceTypeId

2024-05-31 Thread Jacques Le Roux (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-13110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17851061#comment-17851061
 ] 

Jacques Le Roux commented on OFBIZ-13110:
-

For history sake, by error this has finally be handled at OFBIZ-13068

> PartyFinancialHistory shows parentTypeId of invoice, not invoiceTypeId
> --
>
> Key: OFBIZ-13110
> URL: https://issues.apache.org/jira/browse/OFBIZ-13110
> Project: OFBiz
>  Issue Type: Bug
>Reporter: Pierre Smits
>Priority: Major
>
> Currently the PartyFinancialHistory shows the description of the parentTypeId 
> of the invoices shown in the overviews. This must be description of the 
> invoiceTypeId.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Closed] (OFBIZ-13068) Accounts Payable Past Due Invoices doesn't show outstanding amount

2024-05-30 Thread Jacques Le Roux (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-13068?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux closed OFBIZ-13068.
---
Resolution: Fixed

> Accounts Payable Past Due Invoices doesn't show outstanding amount
> --
>
> Key: OFBIZ-13068
> URL: https://issues.apache.org/jira/browse/OFBIZ-13068
> Project: OFBiz
>  Issue Type: Bug
>  Components: accounting
>Affects Versions: Upcoming Branch
>Reporter: Pierre Smits
>Assignee: Jacques Le Roux
>Priority: Trivial
> Fix For: Upcoming Branch
>
> Attachments: Image 016.png, Screenshot 2024-04-29 at 11.52.07.png, 
> image-2024-04-29-09-05-28-760.png
>
>
> With recent changes via commit ec0adc02f102d75be15e1ee04062b75621219f0d 
> [ec0adc02f1] the field outstanding got replaced with amountToApply in grid 
> ListApReport.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Closed] (OFBIZ-12935) Test 2.3.33 FreeMarker release

2024-05-30 Thread Jacques Le Roux (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-12935?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux closed OFBIZ-12935.
---
Fix Version/s: Upcoming Branch
   Resolution: Done

This has been tested for almost 3 months on trunk demo. The vote is going on on 
Freemarker dev ML for 3 weeks with enough positive votes and should be soon 
closed. So the 2.3.33 release will be soon done, closing here.

> Test 2.3.33 FreeMarker release 
> ---
>
> Key: OFBIZ-12935
> URL: https://issues.apache.org/jira/browse/OFBIZ-12935
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: Freemarker
>Affects Versions: Upcoming Branch
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-12935-StringModel.patch, OFBIZ-12935.patch, 
> OFBIZ-12935.txt
>
>
> It's intended to test the 2.3.33 FreeMarker releases [as requested by the 
> FreeMarker 
> team|https://lists.apache.org/thread/t4c9z7wkcp3dbdokmnjd32fcptq8h9tz]
> I attach a patch based on the test requested above: [^OFBIZ-12935.patch] 



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Closed] (OFBIZ-13107) MainActionMenu not shown on findreturn screen

2024-05-29 Thread Jacques Le Roux (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-13107?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux closed OFBIZ-13107.
---
Fix Version/s: Upcoming Branch
 Assignee: Jacques Le Roux
   Resolution: Fixed

> MainActionMenu not shown on findreturn screen
> -
>
> Key: OFBIZ-13107
> URL: https://issues.apache.org/jira/browse/OFBIZ-13107
> Project: OFBiz
>  Issue Type: Bug
>  Components: order
>Reporter: Pierre Smits
>Assignee: Jacques Le Roux
>Priority: Major
> Fix For: Upcoming Branch
>
>
> The MainActionMenu of the order component is shown on various screens, but 
> not on the findreturn screen.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (OFBIZ-13101) Duplicate action trigger in Manufacturing

2024-05-28 Thread Jacques Le Roux (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-13101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17850042#comment-17850042
 ] 

Jacques Le Roux commented on OFBIZ-13101:
-

As Pierre mentions in description, it's handled, in 
ManufacturingMenus::MainActionMenu. Do we really need to duplicate this action 
trigger as Pierre call them? I'll start a discussion in dev ML about that, 
because there are much other places to check then...

> Duplicate action trigger in Manufacturing
> -
>
> Key: OFBIZ-13101
> URL: https://issues.apache.org/jira/browse/OFBIZ-13101
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: manufacturing
>Reporter: Pierre Smits
>Assignee: Jacques Le Roux
>Priority: Major
> Fix For: Upcoming Branch
>
>
> On the 'FndProductionRun' an action trigger to create something is shown.
> This links to CreateProductionRun. This action trigger is already available 
> via the MainActionMenu.
> Removing this duplicate also improves the experience for users with only VIEW 
> permissions, like auditor in the demo site.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (OFBIZ-11378) Convert createCommContentDataResource service from mini-lang to groovy DSL

2024-05-28 Thread Jacques Le Roux (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17850025#comment-17850025
 ] 

Jacques Le Roux commented on OFBIZ-11378:
-

Thanks!

> Convert createCommContentDataResource service from mini-lang to groovy DSL
> --
>
> Key: OFBIZ-11378
> URL: https://issues.apache.org/jira/browse/OFBIZ-11378
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: content
>Affects Versions: Trunk, Upcoming Branch
>Reporter: Devanshu Vyas
>Assignee: Nicolas Malin
>Priority: Minor
> Attachments: OFBIZ-11378.patch
>
>
> Convert createCommContentDataResource service code from mini-lang to groovy 
> DSL.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (OFBIZ-9984) Convert OrderServices.xml mini-lang to groovyDSL

2024-05-28 Thread Jacques Le Roux (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-9984?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17850010#comment-17850010
 ] 

Jacques Le Roux commented on OFBIZ-9984:


Hi [~pgil],

Would you mind takeover? It seems to me that [Sebastian is no longer working on 
OFBiz for almost a 
year|https://issues.apache.org/jira/secure/ViewProfile.jspa?name=sberg]

> Convert OrderServices.xml mini-lang to groovyDSL
> 
>
> Key: OFBIZ-9984
> URL: https://issues.apache.org/jira/browse/OFBIZ-9984
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: order
>Affects Versions: Trunk, Upcoming Branch
>Reporter: Julien NICOLAS
>Assignee: Gil Portenseigne
>Priority: Minor
>  Labels: groovy, mini-lang
> Attachments: OFBIZ-9984-v1.patch, OFBIZ-9984.patch
>
>
> With the purpose to deprecate mini-lang OFBIZ-9350, I tried to convert some 
> mini-lang service to groovy script.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (OFBIZ-11378) Convert createCommContentDataResource service from mini-lang to groovy DSL

2024-05-28 Thread Jacques Le Roux (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17850007#comment-17850007
 ] 

Jacques Le Roux commented on OFBIZ-11378:
-

Hi [~nmalin],

Is there reasons to not close this issue?

> Convert createCommContentDataResource service from mini-lang to groovy DSL
> --
>
> Key: OFBIZ-11378
> URL: https://issues.apache.org/jira/browse/OFBIZ-11378
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: content
>Affects Versions: Trunk, Upcoming Branch
>Reporter: Devanshu Vyas
>Assignee: Nicolas Malin
>Priority: Minor
> Attachments: OFBIZ-11378.patch
>
>
> Convert createCommContentDataResource service code from mini-lang to groovy 
> DSL.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Closed] (OFBIZ-13101) Duplicate action trigger in Manufacturing

2024-05-28 Thread Jacques Le Roux (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-13101?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux closed OFBIZ-13101.
---
Resolution: Implemented

Thanks Pierre for your clear explanation. I see now no reasons to not 
definitely close this Jira as I thought initially.

> Duplicate action trigger in Manufacturing
> -
>
> Key: OFBIZ-13101
> URL: https://issues.apache.org/jira/browse/OFBIZ-13101
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: manufacturing
>Reporter: Pierre Smits
>Assignee: Jacques Le Roux
>Priority: Major
> Fix For: Upcoming Branch
>
>
> On the 'FndProductionRun' an action trigger to create something is shown.
> This links to CreateProductionRun. This action trigger is already available 
> via the MainActionMenu.
> Removing this duplicate also improves the experience for users with only VIEW 
> permissions, like auditor in the demo site.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Comment Edited] (OFBIZ-13101) Duplicate action trigger in Manufacturing

2024-05-28 Thread Jacques Le Roux (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-13101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17849725#comment-17849725
 ] 

Jacques Le Roux edited comment on OFBIZ-13101 at 5/28/24 11:57 AM:
---

Hi [~jleroux] 

re:
{quote}So [~pierresmits], in what
Removing this duplicate also improves the experience for users with only VIEW 
permissions, like auditor in the demo site.
Could you please explain, that's the most important point IMO
{quote}
Given that action triggers to create, update, expire or delete something must 
be on permission conditions, a user with only VIEW permissions should not see 
such action triggers. Like the one in this PR, the majority of link definitions 
in screens xml files are without any kind of permission condition.  As such, 
they diminish the experience of such a user, as in most of those cases, the 
user will see the  screen/form to perform the action including the action 
trigger on the presented form. If and when the user then activates the trigger 
(add, updated, submit, etc.) on the form, that user is presented with '
{quote}The Following Errors Occurred:

You haven't the permission for the service createAgreementItem, reason : Access 
refused
{quote}
message. Which could lead to unnecessary call to the DEVOPS team (and wasted 
time/effort). Thus, it is preferred not to show such action triggers at all to 
that kind of user. IMO, the best user experience is based on process flows (and 
its screens/forms/etc. when there is no ambiguity.

I trust the above answers your question.

Best regards,


was (Author: pfm.smits):
Hi [~jleroux] 

re:
{quote}So [~pierresmits], in what
{quote}Removing this duplicate also improves the experience for users with only 
VIEW permissions, like auditor in the demo site.
{quote}
Could you please explain, that's the most important point IMO
{quote}
Given that action triggers to create, update, expire or delete something must 
be on permission conditions, a user with only VIEW permissions should not see 
such action triggers. Like the one in this PR, the majority of link definitions 
in screens xml files are without any kind of permission condition.  As such, 
they diminish the experience of such a user, as in most of those cases, the 
user will see the  screen/form to perform the action including the action 
trigger on the presented form. If and when the user then activates the trigger 
(add, updated, submit, etc.) on the form, that user is presented with '
{quote}The Following Errors Occurred:

You haven't the permission for the service createAgreementItem, reason : Access 
refused
{quote}
message. Which could lead to unnecessary call to the DEVOPS team (and wasted 
time/effort). Thus, it is preferred not to show such action triggers at all to 
that kind of user. IMO, the best user experience is based on process flows (and 
its screens/forms/etc. when there is no ambiguity.

I trust the above answers your question.

Best regards,

> Duplicate action trigger in Manufacturing
> -
>
> Key: OFBIZ-13101
> URL: https://issues.apache.org/jira/browse/OFBIZ-13101
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: manufacturing
>Reporter: Pierre Smits
>Assignee: Jacques Le Roux
>Priority: Major
> Fix For: Upcoming Branch
>
>
> On the 'FndProductionRun' an action trigger to create something is shown.
> This links to CreateProductionRun. This action trigger is already available 
> via the MainActionMenu.
> Removing this duplicate also improves the experience for users with only VIEW 
> permissions, like auditor in the demo site.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Comment Edited] (OFBIZ-13101) Duplicate action trigger in Manufacturing

2024-05-28 Thread Jacques Le Roux (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-13101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17849725#comment-17849725
 ] 

Jacques Le Roux edited comment on OFBIZ-13101 at 5/28/24 11:57 AM:
---

Hi [~jleroux] 

re:
{quote}So [~pierresmits], in what
<>
Could you please explain, that's the most important point IMO
{quote}
Given that action triggers to create, update, expire or delete something must 
be on permission conditions, a user with only VIEW permissions should not see 
such action triggers. Like the one in this PR, the majority of link definitions 
in screens xml files are without any kind of permission condition.  As such, 
they diminish the experience of such a user, as in most of those cases, the 
user will see the  screen/form to perform the action including the action 
trigger on the presented form. If and when the user then activates the trigger 
(add, updated, submit, etc.) on the form, that user is presented with '
{quote}The Following Errors Occurred:

You haven't the permission for the service createAgreementItem, reason : Access 
refused
{quote}
message. Which could lead to unnecessary call to the DEVOPS team (and wasted 
time/effort). Thus, it is preferred not to show such action triggers at all to 
that kind of user. IMO, the best user experience is based on process flows (and 
its screens/forms/etc. when there is no ambiguity.

I trust the above answers your question.

Best regards,


was (Author: pfm.smits):
Hi [~jleroux] 

re:
{quote}So [~pierresmits], in what
Removing this duplicate also improves the experience for users with only VIEW 
permissions, like auditor in the demo site.
Could you please explain, that's the most important point IMO
{quote}
Given that action triggers to create, update, expire or delete something must 
be on permission conditions, a user with only VIEW permissions should not see 
such action triggers. Like the one in this PR, the majority of link definitions 
in screens xml files are without any kind of permission condition.  As such, 
they diminish the experience of such a user, as in most of those cases, the 
user will see the  screen/form to perform the action including the action 
trigger on the presented form. If and when the user then activates the trigger 
(add, updated, submit, etc.) on the form, that user is presented with '
{quote}The Following Errors Occurred:

You haven't the permission for the service createAgreementItem, reason : Access 
refused
{quote}
message. Which could lead to unnecessary call to the DEVOPS team (and wasted 
time/effort). Thus, it is preferred not to show such action triggers at all to 
that kind of user. IMO, the best user experience is based on process flows (and 
its screens/forms/etc. when there is no ambiguity.

I trust the above answers your question.

Best regards,

> Duplicate action trigger in Manufacturing
> -
>
> Key: OFBIZ-13101
> URL: https://issues.apache.org/jira/browse/OFBIZ-13101
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: manufacturing
>Reporter: Pierre Smits
>Assignee: Jacques Le Roux
>Priority: Major
> Fix For: Upcoming Branch
>
>
> On the 'FndProductionRun' an action trigger to create something is shown.
> This links to CreateProductionRun. This action trigger is already available 
> via the MainActionMenu.
> Removing this duplicate also improves the experience for users with only VIEW 
> permissions, like auditor in the demo site.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Closed] (OFBIZ-11578) Convert PriceServices.xml minilang to groovy

2024-05-28 Thread Jacques Le Roux (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11578?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux closed OFBIZ-11578.
---
Fix Version/s: Upcoming Branch
   Resolution: Implemented

This was fixed by 
https://github.com/apache/ofbiz-framework/commit/80026c76c066f589a652bd00bb7699108cd66163

> Convert PriceServices.xml minilang to groovy
> 
>
> Key: OFBIZ-11578
> URL: https://issues.apache.org/jira/browse/OFBIZ-11578
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: product
>Affects Versions: Trunk, Upcoming Branch
>Reporter: Sebastian Berg
>Assignee: Nicolas Malin
>Priority: Minor
> Fix For: Upcoming Branch
>
>  Time Spent: 10m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (OFBIZ-12653) Sanitizer fail

2024-05-27 Thread Jacques Le Roux (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-12653?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17849710#comment-17849710
 ] 

Jacques Le Roux commented on OFBIZ-12653:
-

I know, I thought you had a better idea. Let's keep this issue closed ;)

> Sanitizer  fail
> ---
>
> Key: OFBIZ-12653
> URL: https://issues.apache.org/jira/browse/OFBIZ-12653
> Project: OFBiz
>  Issue Type: Bug
>  Components: content
>Affects Versions: Upcoming Branch
>Reporter: Ingo Wolfmayr
>Assignee: Jacques Le Roux
>Priority: Major
> Fix For: 22.01.01
>
> Attachments: CustomSafePolicy.patch, OFBIZ-12653.patch, 
> UtilCodec.patch
>
>
> I copied a text with multiple lines from a text editor into the Trumbowyg 
> Html field.The editor creates the Html structure using unclosed  elements.
> Unfortunately the sanitizer logic just takes . A security warning is 
> thrown and the content will not be stored.
> Issue also a request on Trumbowyg request list:
> [https://github.com/Alex-D/Trumbowyg/issues/1283]



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (OFBIZ-12653) Sanitizer fail

2024-05-27 Thread Jacques Le Roux (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-12653?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17849686#comment-17849686
 ] 

Jacques Le Roux commented on OFBIZ-12653:
-

Hi [~cshan],

Great, please create a PR for that.

> Sanitizer  fail
> ---
>
> Key: OFBIZ-12653
> URL: https://issues.apache.org/jira/browse/OFBIZ-12653
> Project: OFBiz
>  Issue Type: Bug
>  Components: content
>Affects Versions: Upcoming Branch
>Reporter: Ingo Wolfmayr
>Assignee: Jacques Le Roux
>Priority: Major
> Fix For: 22.01.01
>
> Attachments: CustomSafePolicy.patch, OFBIZ-12653.patch, 
> UtilCodec.patch
>
>
> I copied a text with multiple lines from a text editor into the Trumbowyg 
> Html field.The editor creates the Html structure using unclosed  elements.
> Unfortunately the sanitizer logic just takes . A security warning is 
> thrown and the content will not be stored.
> Issue also a request on Trumbowyg request list:
> [https://github.com/Alex-D/Trumbowyg/issues/1283]



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (OFBIZ-13101) Duplicate action trigger in Manufacturing

2024-05-26 Thread Jacques Le Roux (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-13101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17849562#comment-17849562
 ] 

Jacques Le Roux commented on OFBIZ-13101:
-

[~mbrohl],

Thinking about it, I should have asked a question to Pierre before pushing.

So [~pierresmits], in what
bq. Removing this duplicate also improves the experience for users with only 
VIEW permissions, like auditor in the demo site.
Could you please explain, that's the most important point IMO

> Duplicate action trigger in Manufacturing
> -
>
> Key: OFBIZ-13101
> URL: https://issues.apache.org/jira/browse/OFBIZ-13101
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: manufacturing
>Reporter: Pierre Smits
>Assignee: Jacques Le Roux
>Priority: Major
> Fix For: Upcoming Branch
>
>
> On the 'FndProductionRun' an action trigger to create something is shown.
> This links to CreateProductionRun. This action trigger is already available 
> via the MainActionMenu.
> Removing this duplicate also improves the experience for users with only VIEW 
> permissions, like auditor in the demo site.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Updated] (OFBIZ-13066) Remove duplicated menu main buttons

2024-05-26 Thread Jacques Le Roux (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-13066?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux updated OFBIZ-13066:

Parent: OFBIZ-13105
Issue Type: Sub-task  (was: Improvement)

> Remove duplicated menu main buttons
> ---
>
> Key: OFBIZ-13066
> URL: https://issues.apache.org/jira/browse/OFBIZ-13066
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: ALL APPLICATIONS, ALL PLUGINS
>Affects Versions: Upcoming Branch
>Reporter: Jacques Le Roux
>Priority: Major
>
> Since the almost generalised use of portal and portlet, and maybe before, 
> some apps show duplicated menu main buttons.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (OFBIZ-13099) PartyFinancialHistory throws a warning

2024-05-26 Thread Jacques Le Roux (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-13099?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17849503#comment-17849503
 ] 

Jacques Le Roux commented on OFBIZ-13099:
-

I was confronted with that some times ago and used the same technique. Weirdly 
I can't remember nor find it. I thought it was with SpotBugs but it uses 
exclude.xml. Anyway just for telling :)

> PartyFinancialHistory throws a warning
> --
>
> Key: OFBIZ-13099
> URL: https://issues.apache.org/jira/browse/OFBIZ-13099
> Project: OFBiz
>  Issue Type: Improvement
>  Components: party
>Affects Versions: Upcoming Branch
>Reporter: Pierre Smits
>Assignee: Jacques Le Roux
>Priority: Minor
> Fix For: Upcoming Branch
>
>
> When accessing the financial history screen in the partymgr application (e.g. 
> via 
> [https://localhost:8443/partymgr/control/PartyFinancialHistory?partyId=EuroSupplier]
>  following error multiple times are thrown:
> {code:java}
> 2024-05-24 10:17:35,821 |jsse-nio-8443-exec-2 |EntityListIterator            
> |W| For performance reasons do not use the EntityListIterator.hasNext() 
> method, just call next() until it returns null; see JavaDoc comments in the 
> EntityListIterator class for details and an example
> java.lang.Exception: null
>         at 
> org.apache.ofbiz.entity.util.EntityListIterator.hasNext(EntityListIterator.java:283)
>  [main/:?]
>         at java_util_ListIterator$hasNext.call(Unknown Source) [?:?]
>         at 
> org.codehaus.groovy.runtime.callsite.CallSiteArray.defaultCall(CallSiteArray.java:47)
>  [groovy-3.0.21.jar:3.0.21]
>         at 
> org.codehaus.groovy.runtime.callsite.AbstractCallSite.call(AbstractCallSite.java:125)
>  [groovy-3.0.21.jar:3.0.21]
>         at 
> org.codehaus.groovy.runtime.callsite.AbstractCallSite.call(AbstractCallSite.java:130)
>  [groovy-3.0.21.jar:3.0.21]
>         at 
> org.apache.ofbiz.party.party.UnAppliedInvoicesForParty.run(UnAppliedInvoicesForParty.groovy:49)
>  [script:?]
>         at 
> org.apache.ofbiz.base.util.GroovyUtil.runScriptAtLocation(GroovyUtil.java:213)
>  [main/:?]
>         at 
> org.apache.ofbiz.base.util.ScriptUtil.executeScript(ScriptUtil.java:312) 
> [main/:?]
>         at 
> org.apache.ofbiz.base.util.ScriptUtil.executeScript(ScriptUtil.java:295) 
> [main/:?]
>         at 
> org.apache.ofbiz.widget.model.AbstractModelAction$Script.runAction(AbstractModelAction.java:716)
>  [main/:?]
>         at 
> org.apache.ofbiz.widget.model.AbstractModelAction.runSubActions(AbstractModelAction.java:138)
>  [main/:?]
>         at 
> org.apache.ofbiz.widget.model.ModelForm.runFormActions(ModelForm.java:1816) 
> [main/:?]
>         at 
> org.apache.ofbiz.widget.renderer.FormRenderer.render(FormRenderer.java:265) 
> [main/:?]
>         at 
> org.apache.ofbiz.widget.model.ModelScreenWidget$Grid.renderWidgetString(ModelScreenWidget.java:1188)
>  [main/:?]
>         at 
> org.apache.ofbiz.widget.renderer.macro.MacroScreenRenderer.renderScreenletSubWidget(MacroScreenRenderer.java:736)
>  [main/:?]
>         at 
> org.apache.ofbiz.widget.model.ModelScreenWidget$Screenlet.renderWidgetString(ModelScreenWidget.java:631)
>  [main/:?]
>         at 
> org.apache.ofbiz.widget.model.ModelScreenWidget.renderSubWidgetsString(ModelScreenWidget.java:109)
>  [main/:?]
>         at 
> org.apache.ofbiz.widget.model.ModelScreenWidget$Section.renderWidgetString(ModelScreenWidget.java:297)
>  [main/:?]
>         at 
> org.apache.ofbiz.widget.model.ModelScreenWidget.renderSubWidgetsString(ModelScreenWidget.java:109)
>  [main/:?]
>         at 
> org.apache.ofbiz.widget.model.ModelScreenWidget$DecoratorSection.renderWidgetString(ModelScreenWidget.java:947)
>  [main/:?]
>         at 
> org.apache.ofbiz.widget.model.ModelScreenWidget$SectionsRenderer.render(ModelScreenWidget.java:142)
>  [main/:?]
>         at 
> org.apache.ofbiz.widget.model.ModelScreenWidget$DecoratorSectionInclude.renderWidgetString(ModelScreenWidget.java:986)
>  [main/:?]
>         at 
> org.apache.ofbiz.widget.model.ModelScreenWidget.renderSubWidgetsString(ModelScreenWidget.java:109)
>  [main/:?]
>         at 
> org.apache.ofbiz.widget.model.ModelScreenWidget$Section.renderWidgetString(ModelScreenWidget.java:297)
>  [main/:?]
>         at 
> org.apache.ofbiz.widget.model.ModelScreenWidget.renderSubWidgetsString(ModelScreenWidget.java:109)
>  [main/:?]
>         at 
> org.apache.ofbiz.widget.model.ModelScreenWidget$DecoratorSection.renderWidgetString(ModelScreenWidget.java:947)
>  [main/:?]
>         at 
> org.apache.ofbiz.widget.model.ModelScreenWidget$SectionsRenderer.render(ModelScreenWidget.java:142)
>  [main/:?]
>         at 
> org.apache.ofbiz.widget.model.ModelScreenWidget$DecoratorSectionInclude.renderWidgetString(ModelScreenWidget.java:986)
>  [main/:?]
>         at 
> 

[jira] [Commented] (OFBIZ-13104) 'Helveticus' theme,Abnormal display on the 'React Example' page

2024-05-26 Thread Jacques Le Roux (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-13104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17849498#comment-17849498
 ] 

Jacques Le Roux commented on OFBIZ-13104:
-

I clearly see it indeed.

> 'Helveticus' theme,Abnormal display on the 'React Example' page
> ---
>
> Key: OFBIZ-13104
> URL: https://issues.apache.org/jira/browse/OFBIZ-13104
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: example
>Affects Versions: Upcoming Branch
> Environment: 
> [https://demo-next.ofbiz.apache.org/example/control/ReactExample]
> https://demo-trunk.ofbiz.apache.org/example/control/ReactExample
>Reporter: gavinju
>Priority: Major
> Attachments: 20240526_124839.mp4
>
>
> In the 'Helveticus' theme style, when entering the Example module and 
> accessing 'React Example', the overall page will show scaling from large to 
> small.
> But in other theme styles, such as the 'Rainbowstone' theme, 'React Example' 
> displays normally.
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (OFBIZ-13104) 'Helveticus' theme,Abnormal display on the 'React Example' page

2024-05-25 Thread Jacques Le Roux (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-13104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17849431#comment-17849431
 ] 

Jacques Le Roux commented on OFBIZ-13104:
-

Hi [~gavinju],

I can't reproduce on Windows with Edge. What environment (OS, browser) are you 
using?

> 'Helveticus' theme,Abnormal display on the 'React Example' page
> ---
>
> Key: OFBIZ-13104
> URL: https://issues.apache.org/jira/browse/OFBIZ-13104
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: example
>Affects Versions: Upcoming Branch
> Environment: 
> [https://demo-next.ofbiz.apache.org/example/control/ReactExample]
> https://demo-trunk.ofbiz.apache.org/example/control/ReactExample
>Reporter: gavinju
>Priority: Major
>
> In the 'Helveticus' theme style, when entering the Example module and 
> accessing 'React Example', the overall page will show scaling from large to 
> small.
> But in other theme styles, such as the 'Rainbowstone' theme, 'React Example' 
> displays normally.
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Updated] (OFBIZ-13104) 'Helveticus' theme,Abnormal display on the 'React Example' page

2024-05-25 Thread Jacques Le Roux (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-13104?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux updated OFBIZ-13104:

Affects Version/s: (was: 22.01.01)
   (was: 22.01)

Removing 22.01 as it's abandonned

> 'Helveticus' theme,Abnormal display on the 'React Example' page
> ---
>
> Key: OFBIZ-13104
> URL: https://issues.apache.org/jira/browse/OFBIZ-13104
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: example
>Affects Versions: Upcoming Branch
> Environment: 
> [https://demo-next.ofbiz.apache.org/example/control/ReactExample]
> https://demo-trunk.ofbiz.apache.org/example/control/ReactExample
>Reporter: gavinju
>Priority: Major
>
> In the 'Helveticus' theme style, when entering the Example module and 
> accessing 'React Example', the overall page will show scaling from large to 
> small.
> But in other theme styles, such as the 'Rainbowstone' theme, 'React Example' 
> displays normally.
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Updated] (OFBIZ-13104) 'Helveticus' theme,Abnormal display on the 'React Example' page

2024-05-25 Thread Jacques Le Roux (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-13104?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux updated OFBIZ-13104:

Parent: OFBIZ-12276
Issue Type: Sub-task  (was: Bug)

> 'Helveticus' theme,Abnormal display on the 'React Example' page
> ---
>
> Key: OFBIZ-13104
> URL: https://issues.apache.org/jira/browse/OFBIZ-13104
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: example
>Affects Versions: 22.01.01, Upcoming Branch, 22.01
> Environment: 
> [https://demo-next.ofbiz.apache.org/example/control/ReactExample]
> https://demo-trunk.ofbiz.apache.org/example/control/ReactExample
>Reporter: gavinju
>Priority: Major
>
> In the 'Helveticus' theme style, when entering the Example module and 
> accessing 'React Example', the overall page will show scaling from large to 
> small.
> But in other theme styles, such as the 'Rainbowstone' theme, 'React Example' 
> displays normally.
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Closed] (OFBIZ-13099) PartyFinancialHistory throws a warning

2024-05-24 Thread Jacques Le Roux (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-13099?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux closed OFBIZ-13099.
---
Resolution: Implemented

> PartyFinancialHistory throws a warning
> --
>
> Key: OFBIZ-13099
> URL: https://issues.apache.org/jira/browse/OFBIZ-13099
> Project: OFBiz
>  Issue Type: Improvement
>  Components: party
>Affects Versions: Upcoming Branch
>Reporter: Pierre Smits
>Assignee: Jacques Le Roux
>Priority: Minor
> Fix For: Upcoming Branch
>
>
> When accessing the financial history screen in the partymgr application (e.g. 
> via 
> [https://localhost:8443/partymgr/control/PartyFinancialHistory?partyId=EuroSupplier]
>  following error multiple times are thrown:
> {code:java}
> 2024-05-24 10:17:35,821 |jsse-nio-8443-exec-2 |EntityListIterator            
> |W| For performance reasons do not use the EntityListIterator.hasNext() 
> method, just call next() until it returns null; see JavaDoc comments in the 
> EntityListIterator class for details and an example
> java.lang.Exception: null
>         at 
> org.apache.ofbiz.entity.util.EntityListIterator.hasNext(EntityListIterator.java:283)
>  [main/:?]
>         at java_util_ListIterator$hasNext.call(Unknown Source) [?:?]
>         at 
> org.codehaus.groovy.runtime.callsite.CallSiteArray.defaultCall(CallSiteArray.java:47)
>  [groovy-3.0.21.jar:3.0.21]
>         at 
> org.codehaus.groovy.runtime.callsite.AbstractCallSite.call(AbstractCallSite.java:125)
>  [groovy-3.0.21.jar:3.0.21]
>         at 
> org.codehaus.groovy.runtime.callsite.AbstractCallSite.call(AbstractCallSite.java:130)
>  [groovy-3.0.21.jar:3.0.21]
>         at 
> org.apache.ofbiz.party.party.UnAppliedInvoicesForParty.run(UnAppliedInvoicesForParty.groovy:49)
>  [script:?]
>         at 
> org.apache.ofbiz.base.util.GroovyUtil.runScriptAtLocation(GroovyUtil.java:213)
>  [main/:?]
>         at 
> org.apache.ofbiz.base.util.ScriptUtil.executeScript(ScriptUtil.java:312) 
> [main/:?]
>         at 
> org.apache.ofbiz.base.util.ScriptUtil.executeScript(ScriptUtil.java:295) 
> [main/:?]
>         at 
> org.apache.ofbiz.widget.model.AbstractModelAction$Script.runAction(AbstractModelAction.java:716)
>  [main/:?]
>         at 
> org.apache.ofbiz.widget.model.AbstractModelAction.runSubActions(AbstractModelAction.java:138)
>  [main/:?]
>         at 
> org.apache.ofbiz.widget.model.ModelForm.runFormActions(ModelForm.java:1816) 
> [main/:?]
>         at 
> org.apache.ofbiz.widget.renderer.FormRenderer.render(FormRenderer.java:265) 
> [main/:?]
>         at 
> org.apache.ofbiz.widget.model.ModelScreenWidget$Grid.renderWidgetString(ModelScreenWidget.java:1188)
>  [main/:?]
>         at 
> org.apache.ofbiz.widget.renderer.macro.MacroScreenRenderer.renderScreenletSubWidget(MacroScreenRenderer.java:736)
>  [main/:?]
>         at 
> org.apache.ofbiz.widget.model.ModelScreenWidget$Screenlet.renderWidgetString(ModelScreenWidget.java:631)
>  [main/:?]
>         at 
> org.apache.ofbiz.widget.model.ModelScreenWidget.renderSubWidgetsString(ModelScreenWidget.java:109)
>  [main/:?]
>         at 
> org.apache.ofbiz.widget.model.ModelScreenWidget$Section.renderWidgetString(ModelScreenWidget.java:297)
>  [main/:?]
>         at 
> org.apache.ofbiz.widget.model.ModelScreenWidget.renderSubWidgetsString(ModelScreenWidget.java:109)
>  [main/:?]
>         at 
> org.apache.ofbiz.widget.model.ModelScreenWidget$DecoratorSection.renderWidgetString(ModelScreenWidget.java:947)
>  [main/:?]
>         at 
> org.apache.ofbiz.widget.model.ModelScreenWidget$SectionsRenderer.render(ModelScreenWidget.java:142)
>  [main/:?]
>         at 
> org.apache.ofbiz.widget.model.ModelScreenWidget$DecoratorSectionInclude.renderWidgetString(ModelScreenWidget.java:986)
>  [main/:?]
>         at 
> org.apache.ofbiz.widget.model.ModelScreenWidget.renderSubWidgetsString(ModelScreenWidget.java:109)
>  [main/:?]
>         at 
> org.apache.ofbiz.widget.model.ModelScreenWidget$Section.renderWidgetString(ModelScreenWidget.java:297)
>  [main/:?]
>         at 
> org.apache.ofbiz.widget.model.ModelScreenWidget.renderSubWidgetsString(ModelScreenWidget.java:109)
>  [main/:?]
>         at 
> org.apache.ofbiz.widget.model.ModelScreenWidget$DecoratorSection.renderWidgetString(ModelScreenWidget.java:947)
>  [main/:?]
>         at 
> org.apache.ofbiz.widget.model.ModelScreenWidget$SectionsRenderer.render(ModelScreenWidget.java:142)
>  [main/:?]
>         at 
> org.apache.ofbiz.widget.model.ModelScreenWidget$DecoratorSectionInclude.renderWidgetString(ModelScreenWidget.java:986)
>  [main/:?]
>         at 
> org.apache.ofbiz.widget.model.ModelScreenWidget.renderSubWidgetsString(ModelScreenWidget.java:109)
>  [main/:?]
>         at 
> org.apache.ofbiz.widget.model.ModelScreenWidget$Container.renderWidgetString(ModelScreenWidget.java:481)

[jira] [Updated] (OFBIZ-13099) PartyFinancialHistory throws a warning

2024-05-24 Thread Jacques Le Roux (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-13099?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux updated OFBIZ-13099:

Summary: PartyFinancialHistory throws a warning  (was: 
PartyFinancialHistory throws an error)

> PartyFinancialHistory throws a warning
> --
>
> Key: OFBIZ-13099
> URL: https://issues.apache.org/jira/browse/OFBIZ-13099
> Project: OFBiz
>  Issue Type: Improvement
>  Components: party
>Affects Versions: Upcoming Branch
>Reporter: Pierre Smits
>Assignee: Jacques Le Roux
>Priority: Minor
> Fix For: Upcoming Branch
>
>
> When accessing the financial history screen in the partymgr application (e.g. 
> via 
> [https://localhost:8443/partymgr/control/PartyFinancialHistory?partyId=EuroSupplier]
>  following error multiple times are thrown:
> {code:java}
> 2024-05-24 10:17:35,821 |jsse-nio-8443-exec-2 |EntityListIterator            
> |W| For performance reasons do not use the EntityListIterator.hasNext() 
> method, just call next() until it returns null; see JavaDoc comments in the 
> EntityListIterator class for details and an example
> java.lang.Exception: null
>         at 
> org.apache.ofbiz.entity.util.EntityListIterator.hasNext(EntityListIterator.java:283)
>  [main/:?]
>         at java_util_ListIterator$hasNext.call(Unknown Source) [?:?]
>         at 
> org.codehaus.groovy.runtime.callsite.CallSiteArray.defaultCall(CallSiteArray.java:47)
>  [groovy-3.0.21.jar:3.0.21]
>         at 
> org.codehaus.groovy.runtime.callsite.AbstractCallSite.call(AbstractCallSite.java:125)
>  [groovy-3.0.21.jar:3.0.21]
>         at 
> org.codehaus.groovy.runtime.callsite.AbstractCallSite.call(AbstractCallSite.java:130)
>  [groovy-3.0.21.jar:3.0.21]
>         at 
> org.apache.ofbiz.party.party.UnAppliedInvoicesForParty.run(UnAppliedInvoicesForParty.groovy:49)
>  [script:?]
>         at 
> org.apache.ofbiz.base.util.GroovyUtil.runScriptAtLocation(GroovyUtil.java:213)
>  [main/:?]
>         at 
> org.apache.ofbiz.base.util.ScriptUtil.executeScript(ScriptUtil.java:312) 
> [main/:?]
>         at 
> org.apache.ofbiz.base.util.ScriptUtil.executeScript(ScriptUtil.java:295) 
> [main/:?]
>         at 
> org.apache.ofbiz.widget.model.AbstractModelAction$Script.runAction(AbstractModelAction.java:716)
>  [main/:?]
>         at 
> org.apache.ofbiz.widget.model.AbstractModelAction.runSubActions(AbstractModelAction.java:138)
>  [main/:?]
>         at 
> org.apache.ofbiz.widget.model.ModelForm.runFormActions(ModelForm.java:1816) 
> [main/:?]
>         at 
> org.apache.ofbiz.widget.renderer.FormRenderer.render(FormRenderer.java:265) 
> [main/:?]
>         at 
> org.apache.ofbiz.widget.model.ModelScreenWidget$Grid.renderWidgetString(ModelScreenWidget.java:1188)
>  [main/:?]
>         at 
> org.apache.ofbiz.widget.renderer.macro.MacroScreenRenderer.renderScreenletSubWidget(MacroScreenRenderer.java:736)
>  [main/:?]
>         at 
> org.apache.ofbiz.widget.model.ModelScreenWidget$Screenlet.renderWidgetString(ModelScreenWidget.java:631)
>  [main/:?]
>         at 
> org.apache.ofbiz.widget.model.ModelScreenWidget.renderSubWidgetsString(ModelScreenWidget.java:109)
>  [main/:?]
>         at 
> org.apache.ofbiz.widget.model.ModelScreenWidget$Section.renderWidgetString(ModelScreenWidget.java:297)
>  [main/:?]
>         at 
> org.apache.ofbiz.widget.model.ModelScreenWidget.renderSubWidgetsString(ModelScreenWidget.java:109)
>  [main/:?]
>         at 
> org.apache.ofbiz.widget.model.ModelScreenWidget$DecoratorSection.renderWidgetString(ModelScreenWidget.java:947)
>  [main/:?]
>         at 
> org.apache.ofbiz.widget.model.ModelScreenWidget$SectionsRenderer.render(ModelScreenWidget.java:142)
>  [main/:?]
>         at 
> org.apache.ofbiz.widget.model.ModelScreenWidget$DecoratorSectionInclude.renderWidgetString(ModelScreenWidget.java:986)
>  [main/:?]
>         at 
> org.apache.ofbiz.widget.model.ModelScreenWidget.renderSubWidgetsString(ModelScreenWidget.java:109)
>  [main/:?]
>         at 
> org.apache.ofbiz.widget.model.ModelScreenWidget$Section.renderWidgetString(ModelScreenWidget.java:297)
>  [main/:?]
>         at 
> org.apache.ofbiz.widget.model.ModelScreenWidget.renderSubWidgetsString(ModelScreenWidget.java:109)
>  [main/:?]
>         at 
> org.apache.ofbiz.widget.model.ModelScreenWidget$DecoratorSection.renderWidgetString(ModelScreenWidget.java:947)
>  [main/:?]
>         at 
> org.apache.ofbiz.widget.model.ModelScreenWidget$SectionsRenderer.render(ModelScreenWidget.java:142)
>  [main/:?]
>         at 
> org.apache.ofbiz.widget.model.ModelScreenWidget$DecoratorSectionInclude.renderWidgetString(ModelScreenWidget.java:986)
>  [main/:?]
>         at 
> org.apache.ofbiz.widget.model.ModelScreenWidget.renderSubWidgetsString(ModelScreenWidget.java:109)
>  [main/:?]
>         at 
> 

[jira] [Closed] (OFBIZ-13101) Duplicate action trigger in Manufacturing

2024-05-24 Thread Jacques Le Roux (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-13101?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux closed OFBIZ-13101.
---
Fix Version/s: Upcoming Branch
   Resolution: Implemented

Thanks Pierre

> Duplicate action trigger in Manufacturing
> -
>
> Key: OFBIZ-13101
> URL: https://issues.apache.org/jira/browse/OFBIZ-13101
> Project: OFBiz
>  Issue Type: Improvement
>  Components: manufacturing
>Reporter: Pierre Smits
>Assignee: Jacques Le Roux
>Priority: Major
> Fix For: Upcoming Branch
>
>
> On the 'FndProductionRun' an action trigger to create something is shown.
> This links to CreateProductionRun. This action trigger is already available 
> via the MainActionMenu.
> Removing this duplicate also improves the experience for users with only VIEW 
> permissions, like auditor in the demo site.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Assigned] (OFBIZ-13101) Duplicate action trigger in Manufacturing

2024-05-24 Thread Jacques Le Roux (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-13101?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux reassigned OFBIZ-13101:
---

Assignee: Jacques Le Roux

> Duplicate action trigger in Manufacturing
> -
>
> Key: OFBIZ-13101
> URL: https://issues.apache.org/jira/browse/OFBIZ-13101
> Project: OFBiz
>  Issue Type: Improvement
>  Components: manufacturing
>Reporter: Pierre Smits
>Assignee: Jacques Le Roux
>Priority: Major
>
> On the 'FndProductionRun' an action trigger to create something is shown.
> This links to CreateProductionRun. This action trigger is already available 
> via the MainActionMenu.
> Removing this duplicate also improves the experience for users with only VIEW 
> permissions, like auditor in the demo site.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (OFBIZ-13099) PartyFinancialHistory throws an error

2024-05-24 Thread Jacques Le Roux (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-13099?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17849322#comment-17849322
 ] 

Jacques Le Roux commented on OFBIZ-13099:
-

Also [~mleila] just pointed out to me that you made a typo at
bq. invoice = nvIterator.next()
it's 
bq. invoice = invIterator.next()

Looking forward for your fixes


> PartyFinancialHistory throws an error
> -
>
> Key: OFBIZ-13099
> URL: https://issues.apache.org/jira/browse/OFBIZ-13099
> Project: OFBiz
>  Issue Type: Improvement
>  Components: party
>Affects Versions: Upcoming Branch
>Reporter: Pierre Smits
>Assignee: Jacques Le Roux
>Priority: Minor
> Fix For: Upcoming Branch
>
>
> When accessing the financial history screen in the partymgr application (e.g. 
> via 
> [https://localhost:8443/partymgr/control/PartyFinancialHistory?partyId=EuroSupplier]
>  following error multiple times are thrown:
> {code:java}
> 2024-05-24 10:17:35,821 |jsse-nio-8443-exec-2 |EntityListIterator            
> |W| For performance reasons do not use the EntityListIterator.hasNext() 
> method, just call next() until it returns null; see JavaDoc comments in the 
> EntityListIterator class for details and an example
> java.lang.Exception: null
>         at 
> org.apache.ofbiz.entity.util.EntityListIterator.hasNext(EntityListIterator.java:283)
>  [main/:?]
>         at java_util_ListIterator$hasNext.call(Unknown Source) [?:?]
>         at 
> org.codehaus.groovy.runtime.callsite.CallSiteArray.defaultCall(CallSiteArray.java:47)
>  [groovy-3.0.21.jar:3.0.21]
>         at 
> org.codehaus.groovy.runtime.callsite.AbstractCallSite.call(AbstractCallSite.java:125)
>  [groovy-3.0.21.jar:3.0.21]
>         at 
> org.codehaus.groovy.runtime.callsite.AbstractCallSite.call(AbstractCallSite.java:130)
>  [groovy-3.0.21.jar:3.0.21]
>         at 
> org.apache.ofbiz.party.party.UnAppliedInvoicesForParty.run(UnAppliedInvoicesForParty.groovy:49)
>  [script:?]
>         at 
> org.apache.ofbiz.base.util.GroovyUtil.runScriptAtLocation(GroovyUtil.java:213)
>  [main/:?]
>         at 
> org.apache.ofbiz.base.util.ScriptUtil.executeScript(ScriptUtil.java:312) 
> [main/:?]
>         at 
> org.apache.ofbiz.base.util.ScriptUtil.executeScript(ScriptUtil.java:295) 
> [main/:?]
>         at 
> org.apache.ofbiz.widget.model.AbstractModelAction$Script.runAction(AbstractModelAction.java:716)
>  [main/:?]
>         at 
> org.apache.ofbiz.widget.model.AbstractModelAction.runSubActions(AbstractModelAction.java:138)
>  [main/:?]
>         at 
> org.apache.ofbiz.widget.model.ModelForm.runFormActions(ModelForm.java:1816) 
> [main/:?]
>         at 
> org.apache.ofbiz.widget.renderer.FormRenderer.render(FormRenderer.java:265) 
> [main/:?]
>         at 
> org.apache.ofbiz.widget.model.ModelScreenWidget$Grid.renderWidgetString(ModelScreenWidget.java:1188)
>  [main/:?]
>         at 
> org.apache.ofbiz.widget.renderer.macro.MacroScreenRenderer.renderScreenletSubWidget(MacroScreenRenderer.java:736)
>  [main/:?]
>         at 
> org.apache.ofbiz.widget.model.ModelScreenWidget$Screenlet.renderWidgetString(ModelScreenWidget.java:631)
>  [main/:?]
>         at 
> org.apache.ofbiz.widget.model.ModelScreenWidget.renderSubWidgetsString(ModelScreenWidget.java:109)
>  [main/:?]
>         at 
> org.apache.ofbiz.widget.model.ModelScreenWidget$Section.renderWidgetString(ModelScreenWidget.java:297)
>  [main/:?]
>         at 
> org.apache.ofbiz.widget.model.ModelScreenWidget.renderSubWidgetsString(ModelScreenWidget.java:109)
>  [main/:?]
>         at 
> org.apache.ofbiz.widget.model.ModelScreenWidget$DecoratorSection.renderWidgetString(ModelScreenWidget.java:947)
>  [main/:?]
>         at 
> org.apache.ofbiz.widget.model.ModelScreenWidget$SectionsRenderer.render(ModelScreenWidget.java:142)
>  [main/:?]
>         at 
> org.apache.ofbiz.widget.model.ModelScreenWidget$DecoratorSectionInclude.renderWidgetString(ModelScreenWidget.java:986)
>  [main/:?]
>         at 
> org.apache.ofbiz.widget.model.ModelScreenWidget.renderSubWidgetsString(ModelScreenWidget.java:109)
>  [main/:?]
>         at 
> org.apache.ofbiz.widget.model.ModelScreenWidget$Section.renderWidgetString(ModelScreenWidget.java:297)
>  [main/:?]
>         at 
> org.apache.ofbiz.widget.model.ModelScreenWidget.renderSubWidgetsString(ModelScreenWidget.java:109)
>  [main/:?]
>         at 
> org.apache.ofbiz.widget.model.ModelScreenWidget$DecoratorSection.renderWidgetString(ModelScreenWidget.java:947)
>  [main/:?]
>         at 
> org.apache.ofbiz.widget.model.ModelScreenWidget$SectionsRenderer.render(ModelScreenWidget.java:142)
>  [main/:?]
>         at 
> org.apache.ofbiz.widget.model.ModelScreenWidget$DecoratorSectionInclude.renderWidgetString(ModelScreenWidget.java:986)
>  [main/:?]
>         at 
> 

[jira] [Commented] (OFBIZ-13099) PartyFinancialHistory throws an error

2024-05-24 Thread Jacques Le Roux (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-13099?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17849314#comment-17849314
 ] 

Jacques Le Roux commented on OFBIZ-13099:
-

Redundant to what?

Maybe you confused with Groovy Iterator that are indeed AutoCloseable
https://docs.groovy-lang.org/latest/html/groovy-jdk/java/util/Iterator.html

But there we are using queryIterator and the documentation is clear (apart the 
BEACUSE typo :))

{quote}
Open Declaration   EntityListIterator 
org.apache.ofbiz.entity.util.EntityQuery.queryIterator() throws 
GenericEntityException
Executes the EntityQuery and returns an EntityListIterator representing the 
result of the query. NOTE: THAT THIS MUST BE CLOSED (preferably in a finally 
block) WHEN YOU ARE DONE WITH IT, AND DON'T LEAVE IT OPEN TOO LONG BEACUSE IT 
WILL MAINTAIN A DATABASE CONNECTION.
Returns:Returns an EntityListIterator representing the result of the 
queryThrows:GenericEntityException
{quote}

You don't need a finally block in Groovy but you need to use hasNext and close 
as it was before your changes. TIA


> PartyFinancialHistory throws an error
> -
>
> Key: OFBIZ-13099
> URL: https://issues.apache.org/jira/browse/OFBIZ-13099
> Project: OFBiz
>  Issue Type: Improvement
>  Components: party
>Affects Versions: Upcoming Branch
>Reporter: Pierre Smits
>Assignee: Jacques Le Roux
>Priority: Minor
> Fix For: Upcoming Branch
>
>
> When accessing the financial history screen in the partymgr application (e.g. 
> via 
> [https://localhost:8443/partymgr/control/PartyFinancialHistory?partyId=EuroSupplier]
>  following error multiple times are thrown:
> {code:java}
> 2024-05-24 10:17:35,821 |jsse-nio-8443-exec-2 |EntityListIterator            
> |W| For performance reasons do not use the EntityListIterator.hasNext() 
> method, just call next() until it returns null; see JavaDoc comments in the 
> EntityListIterator class for details and an example
> java.lang.Exception: null
>         at 
> org.apache.ofbiz.entity.util.EntityListIterator.hasNext(EntityListIterator.java:283)
>  [main/:?]
>         at java_util_ListIterator$hasNext.call(Unknown Source) [?:?]
>         at 
> org.codehaus.groovy.runtime.callsite.CallSiteArray.defaultCall(CallSiteArray.java:47)
>  [groovy-3.0.21.jar:3.0.21]
>         at 
> org.codehaus.groovy.runtime.callsite.AbstractCallSite.call(AbstractCallSite.java:125)
>  [groovy-3.0.21.jar:3.0.21]
>         at 
> org.codehaus.groovy.runtime.callsite.AbstractCallSite.call(AbstractCallSite.java:130)
>  [groovy-3.0.21.jar:3.0.21]
>         at 
> org.apache.ofbiz.party.party.UnAppliedInvoicesForParty.run(UnAppliedInvoicesForParty.groovy:49)
>  [script:?]
>         at 
> org.apache.ofbiz.base.util.GroovyUtil.runScriptAtLocation(GroovyUtil.java:213)
>  [main/:?]
>         at 
> org.apache.ofbiz.base.util.ScriptUtil.executeScript(ScriptUtil.java:312) 
> [main/:?]
>         at 
> org.apache.ofbiz.base.util.ScriptUtil.executeScript(ScriptUtil.java:295) 
> [main/:?]
>         at 
> org.apache.ofbiz.widget.model.AbstractModelAction$Script.runAction(AbstractModelAction.java:716)
>  [main/:?]
>         at 
> org.apache.ofbiz.widget.model.AbstractModelAction.runSubActions(AbstractModelAction.java:138)
>  [main/:?]
>         at 
> org.apache.ofbiz.widget.model.ModelForm.runFormActions(ModelForm.java:1816) 
> [main/:?]
>         at 
> org.apache.ofbiz.widget.renderer.FormRenderer.render(FormRenderer.java:265) 
> [main/:?]
>         at 
> org.apache.ofbiz.widget.model.ModelScreenWidget$Grid.renderWidgetString(ModelScreenWidget.java:1188)
>  [main/:?]
>         at 
> org.apache.ofbiz.widget.renderer.macro.MacroScreenRenderer.renderScreenletSubWidget(MacroScreenRenderer.java:736)
>  [main/:?]
>         at 
> org.apache.ofbiz.widget.model.ModelScreenWidget$Screenlet.renderWidgetString(ModelScreenWidget.java:631)
>  [main/:?]
>         at 
> org.apache.ofbiz.widget.model.ModelScreenWidget.renderSubWidgetsString(ModelScreenWidget.java:109)
>  [main/:?]
>         at 
> org.apache.ofbiz.widget.model.ModelScreenWidget$Section.renderWidgetString(ModelScreenWidget.java:297)
>  [main/:?]
>         at 
> org.apache.ofbiz.widget.model.ModelScreenWidget.renderSubWidgetsString(ModelScreenWidget.java:109)
>  [main/:?]
>         at 
> org.apache.ofbiz.widget.model.ModelScreenWidget$DecoratorSection.renderWidgetString(ModelScreenWidget.java:947)
>  [main/:?]
>         at 
> org.apache.ofbiz.widget.model.ModelScreenWidget$SectionsRenderer.render(ModelScreenWidget.java:142)
>  [main/:?]
>         at 
> org.apache.ofbiz.widget.model.ModelScreenWidget$DecoratorSectionInclude.renderWidgetString(ModelScreenWidget.java:986)
>  [main/:?]
>         at 
> org.apache.ofbiz.widget.model.ModelScreenWidget.renderSubWidgetsString(ModelScreenWidget.java:109)
>  [main/:?]
>         at 

[jira] [Closed] (OFBIZ-13103) Replace deprecated BigDecimal.ROUND_HALF by RoundingMode.HALF

2024-05-24 Thread Jacques Le Roux (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-13103?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux closed OFBIZ-13103.
---
Resolution: Done

> Replace deprecated BigDecimal.ROUND_HALF by  RoundingMode.HALF
> --
>
> Key: OFBIZ-13103
> URL: https://issues.apache.org/jira/browse/OFBIZ-13103
> Project: OFBiz
>  Issue Type: Improvement
>  Components: accounting, birt, party, product/catalog
>Affects Versions: Upcoming Branch
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Minor
> Fix For: Upcoming Branch
>
>
> Address this deprecation
> {quote}
> int java.math.BigDecimal.ROUND_HALF_UP
> Deprecated.  Use RoundingMode.HALF_UP instead.
> Rounding mode to round towards "nearest neighbor" unless both neighbors are 
> equidistant, in which case round up. Behaves as for ROUND_UP if the discarded 
> fraction is ≥ 0.5; otherwise, behaves as for ROUND_DOWN. Note that this is 
> the rounding mode that most of us were taught in grade school.
> {quote}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Created] (OFBIZ-13103) Replace deprecated BigDecimal.ROUND_HALF by RoundingMode.HALF

2024-05-24 Thread Jacques Le Roux (Jira)
Jacques Le Roux created OFBIZ-13103:
---

 Summary: Replace deprecated BigDecimal.ROUND_HALF by  
RoundingMode.HALF
 Key: OFBIZ-13103
 URL: https://issues.apache.org/jira/browse/OFBIZ-13103
 Project: OFBiz
  Issue Type: Improvement
  Components: accounting, birt, party, product/catalog
Affects Versions: Upcoming Branch
Reporter: Jacques Le Roux
Assignee: Jacques Le Roux
 Fix For: Upcoming Branch


Address this deprecation

{quote}
int java.math.BigDecimal.ROUND_HALF_UP
Deprecated.  Use RoundingMode.HALF_UP instead.

Rounding mode to round towards "nearest neighbor" unless both neighbors are 
equidistant, in which case round up. Behaves as for ROUND_UP if the discarded 
fraction is ≥ 0.5; otherwise, behaves as for ROUND_DOWN. Note that this is the 
rounding mode that most of us were taught in grade school.
{quote}




--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Reopened] (OFBIZ-13099) PartyFinancialHistory throws an error

2024-05-24 Thread Jacques Le Roux (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-13099?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux reopened OFBIZ-13099:
-

Pierre,

Reopening for this question:
Why did you remove the iterators closing?

> PartyFinancialHistory throws an error
> -
>
> Key: OFBIZ-13099
> URL: https://issues.apache.org/jira/browse/OFBIZ-13099
> Project: OFBiz
>  Issue Type: Improvement
>  Components: party
>Affects Versions: Upcoming Branch
>Reporter: Pierre Smits
>Assignee: Jacques Le Roux
>Priority: Minor
> Fix For: Upcoming Branch
>
>
> When accessing the financial history screen in the partymgr application (e.g. 
> via 
> [https://localhost:8443/partymgr/control/PartyFinancialHistory?partyId=EuroSupplier]
>  following error multiple times are thrown:
> {code:java}
> 2024-05-24 10:17:35,821 |jsse-nio-8443-exec-2 |EntityListIterator            
> |W| For performance reasons do not use the EntityListIterator.hasNext() 
> method, just call next() until it returns null; see JavaDoc comments in the 
> EntityListIterator class for details and an example
> java.lang.Exception: null
>         at 
> org.apache.ofbiz.entity.util.EntityListIterator.hasNext(EntityListIterator.java:283)
>  [main/:?]
>         at java_util_ListIterator$hasNext.call(Unknown Source) [?:?]
>         at 
> org.codehaus.groovy.runtime.callsite.CallSiteArray.defaultCall(CallSiteArray.java:47)
>  [groovy-3.0.21.jar:3.0.21]
>         at 
> org.codehaus.groovy.runtime.callsite.AbstractCallSite.call(AbstractCallSite.java:125)
>  [groovy-3.0.21.jar:3.0.21]
>         at 
> org.codehaus.groovy.runtime.callsite.AbstractCallSite.call(AbstractCallSite.java:130)
>  [groovy-3.0.21.jar:3.0.21]
>         at 
> org.apache.ofbiz.party.party.UnAppliedInvoicesForParty.run(UnAppliedInvoicesForParty.groovy:49)
>  [script:?]
>         at 
> org.apache.ofbiz.base.util.GroovyUtil.runScriptAtLocation(GroovyUtil.java:213)
>  [main/:?]
>         at 
> org.apache.ofbiz.base.util.ScriptUtil.executeScript(ScriptUtil.java:312) 
> [main/:?]
>         at 
> org.apache.ofbiz.base.util.ScriptUtil.executeScript(ScriptUtil.java:295) 
> [main/:?]
>         at 
> org.apache.ofbiz.widget.model.AbstractModelAction$Script.runAction(AbstractModelAction.java:716)
>  [main/:?]
>         at 
> org.apache.ofbiz.widget.model.AbstractModelAction.runSubActions(AbstractModelAction.java:138)
>  [main/:?]
>         at 
> org.apache.ofbiz.widget.model.ModelForm.runFormActions(ModelForm.java:1816) 
> [main/:?]
>         at 
> org.apache.ofbiz.widget.renderer.FormRenderer.render(FormRenderer.java:265) 
> [main/:?]
>         at 
> org.apache.ofbiz.widget.model.ModelScreenWidget$Grid.renderWidgetString(ModelScreenWidget.java:1188)
>  [main/:?]
>         at 
> org.apache.ofbiz.widget.renderer.macro.MacroScreenRenderer.renderScreenletSubWidget(MacroScreenRenderer.java:736)
>  [main/:?]
>         at 
> org.apache.ofbiz.widget.model.ModelScreenWidget$Screenlet.renderWidgetString(ModelScreenWidget.java:631)
>  [main/:?]
>         at 
> org.apache.ofbiz.widget.model.ModelScreenWidget.renderSubWidgetsString(ModelScreenWidget.java:109)
>  [main/:?]
>         at 
> org.apache.ofbiz.widget.model.ModelScreenWidget$Section.renderWidgetString(ModelScreenWidget.java:297)
>  [main/:?]
>         at 
> org.apache.ofbiz.widget.model.ModelScreenWidget.renderSubWidgetsString(ModelScreenWidget.java:109)
>  [main/:?]
>         at 
> org.apache.ofbiz.widget.model.ModelScreenWidget$DecoratorSection.renderWidgetString(ModelScreenWidget.java:947)
>  [main/:?]
>         at 
> org.apache.ofbiz.widget.model.ModelScreenWidget$SectionsRenderer.render(ModelScreenWidget.java:142)
>  [main/:?]
>         at 
> org.apache.ofbiz.widget.model.ModelScreenWidget$DecoratorSectionInclude.renderWidgetString(ModelScreenWidget.java:986)
>  [main/:?]
>         at 
> org.apache.ofbiz.widget.model.ModelScreenWidget.renderSubWidgetsString(ModelScreenWidget.java:109)
>  [main/:?]
>         at 
> org.apache.ofbiz.widget.model.ModelScreenWidget$Section.renderWidgetString(ModelScreenWidget.java:297)
>  [main/:?]
>         at 
> org.apache.ofbiz.widget.model.ModelScreenWidget.renderSubWidgetsString(ModelScreenWidget.java:109)
>  [main/:?]
>         at 
> org.apache.ofbiz.widget.model.ModelScreenWidget$DecoratorSection.renderWidgetString(ModelScreenWidget.java:947)
>  [main/:?]
>         at 
> org.apache.ofbiz.widget.model.ModelScreenWidget$SectionsRenderer.render(ModelScreenWidget.java:142)
>  [main/:?]
>         at 
> org.apache.ofbiz.widget.model.ModelScreenWidget$DecoratorSectionInclude.renderWidgetString(ModelScreenWidget.java:986)
>  [main/:?]
>         at 
> org.apache.ofbiz.widget.model.ModelScreenWidget.renderSubWidgetsString(ModelScreenWidget.java:109)
>  [main/:?]
>         at 
> 

[jira] [Closed] (OFBIZ-13099) PartyFinancialHistory throws an error

2024-05-24 Thread Jacques Le Roux (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-13099?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux closed OFBIZ-13099.
---
Fix Version/s: Upcoming Branch
 Assignee: Jacques Le Roux
   Resolution: Done

> PartyFinancialHistory throws an error
> -
>
> Key: OFBIZ-13099
> URL: https://issues.apache.org/jira/browse/OFBIZ-13099
> Project: OFBiz
>  Issue Type: Improvement
>  Components: party
>Affects Versions: Upcoming Branch
>Reporter: Pierre Smits
>Assignee: Jacques Le Roux
>Priority: Minor
> Fix For: Upcoming Branch
>
>
> When accessing the financial history screen in the partymgr application (e.g. 
> via 
> [https://localhost:8443/partymgr/control/PartyFinancialHistory?partyId=EuroSupplier]
>  following error multiple times are thrown:
> {code:java}
> 2024-05-24 10:17:35,821 |jsse-nio-8443-exec-2 |EntityListIterator            
> |W| For performance reasons do not use the EntityListIterator.hasNext() 
> method, just call next() until it returns null; see JavaDoc comments in the 
> EntityListIterator class for details and an example
> java.lang.Exception: null
>         at 
> org.apache.ofbiz.entity.util.EntityListIterator.hasNext(EntityListIterator.java:283)
>  [main/:?]
>         at java_util_ListIterator$hasNext.call(Unknown Source) [?:?]
>         at 
> org.codehaus.groovy.runtime.callsite.CallSiteArray.defaultCall(CallSiteArray.java:47)
>  [groovy-3.0.21.jar:3.0.21]
>         at 
> org.codehaus.groovy.runtime.callsite.AbstractCallSite.call(AbstractCallSite.java:125)
>  [groovy-3.0.21.jar:3.0.21]
>         at 
> org.codehaus.groovy.runtime.callsite.AbstractCallSite.call(AbstractCallSite.java:130)
>  [groovy-3.0.21.jar:3.0.21]
>         at 
> org.apache.ofbiz.party.party.UnAppliedInvoicesForParty.run(UnAppliedInvoicesForParty.groovy:49)
>  [script:?]
>         at 
> org.apache.ofbiz.base.util.GroovyUtil.runScriptAtLocation(GroovyUtil.java:213)
>  [main/:?]
>         at 
> org.apache.ofbiz.base.util.ScriptUtil.executeScript(ScriptUtil.java:312) 
> [main/:?]
>         at 
> org.apache.ofbiz.base.util.ScriptUtil.executeScript(ScriptUtil.java:295) 
> [main/:?]
>         at 
> org.apache.ofbiz.widget.model.AbstractModelAction$Script.runAction(AbstractModelAction.java:716)
>  [main/:?]
>         at 
> org.apache.ofbiz.widget.model.AbstractModelAction.runSubActions(AbstractModelAction.java:138)
>  [main/:?]
>         at 
> org.apache.ofbiz.widget.model.ModelForm.runFormActions(ModelForm.java:1816) 
> [main/:?]
>         at 
> org.apache.ofbiz.widget.renderer.FormRenderer.render(FormRenderer.java:265) 
> [main/:?]
>         at 
> org.apache.ofbiz.widget.model.ModelScreenWidget$Grid.renderWidgetString(ModelScreenWidget.java:1188)
>  [main/:?]
>         at 
> org.apache.ofbiz.widget.renderer.macro.MacroScreenRenderer.renderScreenletSubWidget(MacroScreenRenderer.java:736)
>  [main/:?]
>         at 
> org.apache.ofbiz.widget.model.ModelScreenWidget$Screenlet.renderWidgetString(ModelScreenWidget.java:631)
>  [main/:?]
>         at 
> org.apache.ofbiz.widget.model.ModelScreenWidget.renderSubWidgetsString(ModelScreenWidget.java:109)
>  [main/:?]
>         at 
> org.apache.ofbiz.widget.model.ModelScreenWidget$Section.renderWidgetString(ModelScreenWidget.java:297)
>  [main/:?]
>         at 
> org.apache.ofbiz.widget.model.ModelScreenWidget.renderSubWidgetsString(ModelScreenWidget.java:109)
>  [main/:?]
>         at 
> org.apache.ofbiz.widget.model.ModelScreenWidget$DecoratorSection.renderWidgetString(ModelScreenWidget.java:947)
>  [main/:?]
>         at 
> org.apache.ofbiz.widget.model.ModelScreenWidget$SectionsRenderer.render(ModelScreenWidget.java:142)
>  [main/:?]
>         at 
> org.apache.ofbiz.widget.model.ModelScreenWidget$DecoratorSectionInclude.renderWidgetString(ModelScreenWidget.java:986)
>  [main/:?]
>         at 
> org.apache.ofbiz.widget.model.ModelScreenWidget.renderSubWidgetsString(ModelScreenWidget.java:109)
>  [main/:?]
>         at 
> org.apache.ofbiz.widget.model.ModelScreenWidget$Section.renderWidgetString(ModelScreenWidget.java:297)
>  [main/:?]
>         at 
> org.apache.ofbiz.widget.model.ModelScreenWidget.renderSubWidgetsString(ModelScreenWidget.java:109)
>  [main/:?]
>         at 
> org.apache.ofbiz.widget.model.ModelScreenWidget$DecoratorSection.renderWidgetString(ModelScreenWidget.java:947)
>  [main/:?]
>         at 
> org.apache.ofbiz.widget.model.ModelScreenWidget$SectionsRenderer.render(ModelScreenWidget.java:142)
>  [main/:?]
>         at 
> org.apache.ofbiz.widget.model.ModelScreenWidget$DecoratorSectionInclude.renderWidgetString(ModelScreenWidget.java:986)
>  [main/:?]
>         at 
> org.apache.ofbiz.widget.model.ModelScreenWidget.renderSubWidgetsString(ModelScreenWidget.java:109)
>  [main/:?]
>         at 
> 

[jira] [Commented] (OFBIZ-13099) PartyFinancialHistory throws an error

2024-05-24 Thread Jacques Le Roux (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-13099?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17849275#comment-17849275
 ] 

Jacques Le Roux commented on OFBIZ-13099:
-

Thanks Pierre

> PartyFinancialHistory throws an error
> -
>
> Key: OFBIZ-13099
> URL: https://issues.apache.org/jira/browse/OFBIZ-13099
> Project: OFBiz
>  Issue Type: Improvement
>  Components: party
>Affects Versions: Upcoming Branch
>Reporter: Pierre Smits
>Priority: Minor
>
> When accessing the financial history screen in the partymgr application (e.g. 
> via 
> [https://localhost:8443/partymgr/control/PartyFinancialHistory?partyId=EuroSupplier]
>  following error multiple times are thrown:
> {code:java}
> 2024-05-24 10:17:35,821 |jsse-nio-8443-exec-2 |EntityListIterator            
> |W| For performance reasons do not use the EntityListIterator.hasNext() 
> method, just call next() until it returns null; see JavaDoc comments in the 
> EntityListIterator class for details and an example
> java.lang.Exception: null
>         at 
> org.apache.ofbiz.entity.util.EntityListIterator.hasNext(EntityListIterator.java:283)
>  [main/:?]
>         at java_util_ListIterator$hasNext.call(Unknown Source) [?:?]
>         at 
> org.codehaus.groovy.runtime.callsite.CallSiteArray.defaultCall(CallSiteArray.java:47)
>  [groovy-3.0.21.jar:3.0.21]
>         at 
> org.codehaus.groovy.runtime.callsite.AbstractCallSite.call(AbstractCallSite.java:125)
>  [groovy-3.0.21.jar:3.0.21]
>         at 
> org.codehaus.groovy.runtime.callsite.AbstractCallSite.call(AbstractCallSite.java:130)
>  [groovy-3.0.21.jar:3.0.21]
>         at 
> org.apache.ofbiz.party.party.UnAppliedInvoicesForParty.run(UnAppliedInvoicesForParty.groovy:49)
>  [script:?]
>         at 
> org.apache.ofbiz.base.util.GroovyUtil.runScriptAtLocation(GroovyUtil.java:213)
>  [main/:?]
>         at 
> org.apache.ofbiz.base.util.ScriptUtil.executeScript(ScriptUtil.java:312) 
> [main/:?]
>         at 
> org.apache.ofbiz.base.util.ScriptUtil.executeScript(ScriptUtil.java:295) 
> [main/:?]
>         at 
> org.apache.ofbiz.widget.model.AbstractModelAction$Script.runAction(AbstractModelAction.java:716)
>  [main/:?]
>         at 
> org.apache.ofbiz.widget.model.AbstractModelAction.runSubActions(AbstractModelAction.java:138)
>  [main/:?]
>         at 
> org.apache.ofbiz.widget.model.ModelForm.runFormActions(ModelForm.java:1816) 
> [main/:?]
>         at 
> org.apache.ofbiz.widget.renderer.FormRenderer.render(FormRenderer.java:265) 
> [main/:?]
>         at 
> org.apache.ofbiz.widget.model.ModelScreenWidget$Grid.renderWidgetString(ModelScreenWidget.java:1188)
>  [main/:?]
>         at 
> org.apache.ofbiz.widget.renderer.macro.MacroScreenRenderer.renderScreenletSubWidget(MacroScreenRenderer.java:736)
>  [main/:?]
>         at 
> org.apache.ofbiz.widget.model.ModelScreenWidget$Screenlet.renderWidgetString(ModelScreenWidget.java:631)
>  [main/:?]
>         at 
> org.apache.ofbiz.widget.model.ModelScreenWidget.renderSubWidgetsString(ModelScreenWidget.java:109)
>  [main/:?]
>         at 
> org.apache.ofbiz.widget.model.ModelScreenWidget$Section.renderWidgetString(ModelScreenWidget.java:297)
>  [main/:?]
>         at 
> org.apache.ofbiz.widget.model.ModelScreenWidget.renderSubWidgetsString(ModelScreenWidget.java:109)
>  [main/:?]
>         at 
> org.apache.ofbiz.widget.model.ModelScreenWidget$DecoratorSection.renderWidgetString(ModelScreenWidget.java:947)
>  [main/:?]
>         at 
> org.apache.ofbiz.widget.model.ModelScreenWidget$SectionsRenderer.render(ModelScreenWidget.java:142)
>  [main/:?]
>         at 
> org.apache.ofbiz.widget.model.ModelScreenWidget$DecoratorSectionInclude.renderWidgetString(ModelScreenWidget.java:986)
>  [main/:?]
>         at 
> org.apache.ofbiz.widget.model.ModelScreenWidget.renderSubWidgetsString(ModelScreenWidget.java:109)
>  [main/:?]
>         at 
> org.apache.ofbiz.widget.model.ModelScreenWidget$Section.renderWidgetString(ModelScreenWidget.java:297)
>  [main/:?]
>         at 
> org.apache.ofbiz.widget.model.ModelScreenWidget.renderSubWidgetsString(ModelScreenWidget.java:109)
>  [main/:?]
>         at 
> org.apache.ofbiz.widget.model.ModelScreenWidget$DecoratorSection.renderWidgetString(ModelScreenWidget.java:947)
>  [main/:?]
>         at 
> org.apache.ofbiz.widget.model.ModelScreenWidget$SectionsRenderer.render(ModelScreenWidget.java:142)
>  [main/:?]
>         at 
> org.apache.ofbiz.widget.model.ModelScreenWidget$DecoratorSectionInclude.renderWidgetString(ModelScreenWidget.java:986)
>  [main/:?]
>         at 
> org.apache.ofbiz.widget.model.ModelScreenWidget.renderSubWidgetsString(ModelScreenWidget.java:109)
>  [main/:?]
>         at 
> org.apache.ofbiz.widget.model.ModelScreenWidget$Container.renderWidgetString(ModelScreenWidget.java:481)
>  [main/:?]
>         at 
> 

[jira] [Commented] (OFBIZ-13099) PartyFinancialHistory throws an error

2024-05-24 Thread Jacques Le Roux (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-13099?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17849235#comment-17849235
 ] 

Jacques Le Roux commented on OFBIZ-13099:
-

Hi Pierre,

Locally in trunk as admin I see only a warning in log, so not really a bug, 
rather an improvement.

> PartyFinancialHistory throws an error
> -
>
> Key: OFBIZ-13099
> URL: https://issues.apache.org/jira/browse/OFBIZ-13099
> Project: OFBiz
>  Issue Type: Bug
>  Components: party
>Reporter: Pierre Smits
>Priority: Major
>
> When accessing the financial history screen in the partymgr application (e.g. 
> via 
> [https://localhost:8443/partymgr/control/PartyFinancialHistory?partyId=EuroSupplier]
>  following error multiple times are thrown:
> {code:java}
> 2024-05-24 10:17:35,821 |jsse-nio-8443-exec-2 |EntityListIterator            
> |W| For performance reasons do not use the EntityListIterator.hasNext() 
> method, just call next() until it returns null; see JavaDoc comments in the 
> EntityListIterator class for details and an example
> java.lang.Exception: null
>         at 
> org.apache.ofbiz.entity.util.EntityListIterator.hasNext(EntityListIterator.java:283)
>  [main/:?]
>         at java_util_ListIterator$hasNext.call(Unknown Source) [?:?]
>         at 
> org.codehaus.groovy.runtime.callsite.CallSiteArray.defaultCall(CallSiteArray.java:47)
>  [groovy-3.0.21.jar:3.0.21]
>         at 
> org.codehaus.groovy.runtime.callsite.AbstractCallSite.call(AbstractCallSite.java:125)
>  [groovy-3.0.21.jar:3.0.21]
>         at 
> org.codehaus.groovy.runtime.callsite.AbstractCallSite.call(AbstractCallSite.java:130)
>  [groovy-3.0.21.jar:3.0.21]
>         at 
> org.apache.ofbiz.party.party.UnAppliedInvoicesForParty.run(UnAppliedInvoicesForParty.groovy:49)
>  [script:?]
>         at 
> org.apache.ofbiz.base.util.GroovyUtil.runScriptAtLocation(GroovyUtil.java:213)
>  [main/:?]
>         at 
> org.apache.ofbiz.base.util.ScriptUtil.executeScript(ScriptUtil.java:312) 
> [main/:?]
>         at 
> org.apache.ofbiz.base.util.ScriptUtil.executeScript(ScriptUtil.java:295) 
> [main/:?]
>         at 
> org.apache.ofbiz.widget.model.AbstractModelAction$Script.runAction(AbstractModelAction.java:716)
>  [main/:?]
>         at 
> org.apache.ofbiz.widget.model.AbstractModelAction.runSubActions(AbstractModelAction.java:138)
>  [main/:?]
>         at 
> org.apache.ofbiz.widget.model.ModelForm.runFormActions(ModelForm.java:1816) 
> [main/:?]
>         at 
> org.apache.ofbiz.widget.renderer.FormRenderer.render(FormRenderer.java:265) 
> [main/:?]
>         at 
> org.apache.ofbiz.widget.model.ModelScreenWidget$Grid.renderWidgetString(ModelScreenWidget.java:1188)
>  [main/:?]
>         at 
> org.apache.ofbiz.widget.renderer.macro.MacroScreenRenderer.renderScreenletSubWidget(MacroScreenRenderer.java:736)
>  [main/:?]
>         at 
> org.apache.ofbiz.widget.model.ModelScreenWidget$Screenlet.renderWidgetString(ModelScreenWidget.java:631)
>  [main/:?]
>         at 
> org.apache.ofbiz.widget.model.ModelScreenWidget.renderSubWidgetsString(ModelScreenWidget.java:109)
>  [main/:?]
>         at 
> org.apache.ofbiz.widget.model.ModelScreenWidget$Section.renderWidgetString(ModelScreenWidget.java:297)
>  [main/:?]
>         at 
> org.apache.ofbiz.widget.model.ModelScreenWidget.renderSubWidgetsString(ModelScreenWidget.java:109)
>  [main/:?]
>         at 
> org.apache.ofbiz.widget.model.ModelScreenWidget$DecoratorSection.renderWidgetString(ModelScreenWidget.java:947)
>  [main/:?]
>         at 
> org.apache.ofbiz.widget.model.ModelScreenWidget$SectionsRenderer.render(ModelScreenWidget.java:142)
>  [main/:?]
>         at 
> org.apache.ofbiz.widget.model.ModelScreenWidget$DecoratorSectionInclude.renderWidgetString(ModelScreenWidget.java:986)
>  [main/:?]
>         at 
> org.apache.ofbiz.widget.model.ModelScreenWidget.renderSubWidgetsString(ModelScreenWidget.java:109)
>  [main/:?]
>         at 
> org.apache.ofbiz.widget.model.ModelScreenWidget$Section.renderWidgetString(ModelScreenWidget.java:297)
>  [main/:?]
>         at 
> org.apache.ofbiz.widget.model.ModelScreenWidget.renderSubWidgetsString(ModelScreenWidget.java:109)
>  [main/:?]
>         at 
> org.apache.ofbiz.widget.model.ModelScreenWidget$DecoratorSection.renderWidgetString(ModelScreenWidget.java:947)
>  [main/:?]
>         at 
> org.apache.ofbiz.widget.model.ModelScreenWidget$SectionsRenderer.render(ModelScreenWidget.java:142)
>  [main/:?]
>         at 
> org.apache.ofbiz.widget.model.ModelScreenWidget$DecoratorSectionInclude.renderWidgetString(ModelScreenWidget.java:986)
>  [main/:?]
>         at 
> org.apache.ofbiz.widget.model.ModelScreenWidget.renderSubWidgetsString(ModelScreenWidget.java:109)
>  [main/:?]
>         at 
> org.apache.ofbiz.widget.model.ModelScreenWidget$Container.renderWidgetString(ModelScreenWidget.java:481)
> 

[jira] [Updated] (OFBIZ-13099) PartyFinancialHistory throws an error

2024-05-24 Thread Jacques Le Roux (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-13099?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux updated OFBIZ-13099:

Affects Version/s: Upcoming Branch
   Issue Type: Improvement  (was: Bug)
 Priority: Minor  (was: Major)

> PartyFinancialHistory throws an error
> -
>
> Key: OFBIZ-13099
> URL: https://issues.apache.org/jira/browse/OFBIZ-13099
> Project: OFBiz
>  Issue Type: Improvement
>  Components: party
>Affects Versions: Upcoming Branch
>Reporter: Pierre Smits
>Priority: Minor
>
> When accessing the financial history screen in the partymgr application (e.g. 
> via 
> [https://localhost:8443/partymgr/control/PartyFinancialHistory?partyId=EuroSupplier]
>  following error multiple times are thrown:
> {code:java}
> 2024-05-24 10:17:35,821 |jsse-nio-8443-exec-2 |EntityListIterator            
> |W| For performance reasons do not use the EntityListIterator.hasNext() 
> method, just call next() until it returns null; see JavaDoc comments in the 
> EntityListIterator class for details and an example
> java.lang.Exception: null
>         at 
> org.apache.ofbiz.entity.util.EntityListIterator.hasNext(EntityListIterator.java:283)
>  [main/:?]
>         at java_util_ListIterator$hasNext.call(Unknown Source) [?:?]
>         at 
> org.codehaus.groovy.runtime.callsite.CallSiteArray.defaultCall(CallSiteArray.java:47)
>  [groovy-3.0.21.jar:3.0.21]
>         at 
> org.codehaus.groovy.runtime.callsite.AbstractCallSite.call(AbstractCallSite.java:125)
>  [groovy-3.0.21.jar:3.0.21]
>         at 
> org.codehaus.groovy.runtime.callsite.AbstractCallSite.call(AbstractCallSite.java:130)
>  [groovy-3.0.21.jar:3.0.21]
>         at 
> org.apache.ofbiz.party.party.UnAppliedInvoicesForParty.run(UnAppliedInvoicesForParty.groovy:49)
>  [script:?]
>         at 
> org.apache.ofbiz.base.util.GroovyUtil.runScriptAtLocation(GroovyUtil.java:213)
>  [main/:?]
>         at 
> org.apache.ofbiz.base.util.ScriptUtil.executeScript(ScriptUtil.java:312) 
> [main/:?]
>         at 
> org.apache.ofbiz.base.util.ScriptUtil.executeScript(ScriptUtil.java:295) 
> [main/:?]
>         at 
> org.apache.ofbiz.widget.model.AbstractModelAction$Script.runAction(AbstractModelAction.java:716)
>  [main/:?]
>         at 
> org.apache.ofbiz.widget.model.AbstractModelAction.runSubActions(AbstractModelAction.java:138)
>  [main/:?]
>         at 
> org.apache.ofbiz.widget.model.ModelForm.runFormActions(ModelForm.java:1816) 
> [main/:?]
>         at 
> org.apache.ofbiz.widget.renderer.FormRenderer.render(FormRenderer.java:265) 
> [main/:?]
>         at 
> org.apache.ofbiz.widget.model.ModelScreenWidget$Grid.renderWidgetString(ModelScreenWidget.java:1188)
>  [main/:?]
>         at 
> org.apache.ofbiz.widget.renderer.macro.MacroScreenRenderer.renderScreenletSubWidget(MacroScreenRenderer.java:736)
>  [main/:?]
>         at 
> org.apache.ofbiz.widget.model.ModelScreenWidget$Screenlet.renderWidgetString(ModelScreenWidget.java:631)
>  [main/:?]
>         at 
> org.apache.ofbiz.widget.model.ModelScreenWidget.renderSubWidgetsString(ModelScreenWidget.java:109)
>  [main/:?]
>         at 
> org.apache.ofbiz.widget.model.ModelScreenWidget$Section.renderWidgetString(ModelScreenWidget.java:297)
>  [main/:?]
>         at 
> org.apache.ofbiz.widget.model.ModelScreenWidget.renderSubWidgetsString(ModelScreenWidget.java:109)
>  [main/:?]
>         at 
> org.apache.ofbiz.widget.model.ModelScreenWidget$DecoratorSection.renderWidgetString(ModelScreenWidget.java:947)
>  [main/:?]
>         at 
> org.apache.ofbiz.widget.model.ModelScreenWidget$SectionsRenderer.render(ModelScreenWidget.java:142)
>  [main/:?]
>         at 
> org.apache.ofbiz.widget.model.ModelScreenWidget$DecoratorSectionInclude.renderWidgetString(ModelScreenWidget.java:986)
>  [main/:?]
>         at 
> org.apache.ofbiz.widget.model.ModelScreenWidget.renderSubWidgetsString(ModelScreenWidget.java:109)
>  [main/:?]
>         at 
> org.apache.ofbiz.widget.model.ModelScreenWidget$Section.renderWidgetString(ModelScreenWidget.java:297)
>  [main/:?]
>         at 
> org.apache.ofbiz.widget.model.ModelScreenWidget.renderSubWidgetsString(ModelScreenWidget.java:109)
>  [main/:?]
>         at 
> org.apache.ofbiz.widget.model.ModelScreenWidget$DecoratorSection.renderWidgetString(ModelScreenWidget.java:947)
>  [main/:?]
>         at 
> org.apache.ofbiz.widget.model.ModelScreenWidget$SectionsRenderer.render(ModelScreenWidget.java:142)
>  [main/:?]
>         at 
> org.apache.ofbiz.widget.model.ModelScreenWidget$DecoratorSectionInclude.renderWidgetString(ModelScreenWidget.java:986)
>  [main/:?]
>         at 
> org.apache.ofbiz.widget.model.ModelScreenWidget.renderSubWidgetsString(ModelScreenWidget.java:109)
>  [main/:?]
>         at 
> 

[jira] [Updated] (OFBIZ-13099) PartyFinancialHistory throws an error

2024-05-24 Thread Jacques Le Roux (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-13099?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux updated OFBIZ-13099:

Description: 
When accessing the financial history screen in the partymgr application (e.g. 
via 
[https://localhost:8443/partymgr/control/PartyFinancialHistory?partyId=EuroSupplier]
 following error multiple times are thrown:
{code:java}
2024-05-24 10:17:35,821 |jsse-nio-8443-exec-2 |EntityListIterator            
|W| For performance reasons do not use the EntityListIterator.hasNext() method, 
just call next() until it returns null; see JavaDoc comments in the 
EntityListIterator class for details and an example
java.lang.Exception: null
        at 
org.apache.ofbiz.entity.util.EntityListIterator.hasNext(EntityListIterator.java:283)
 [main/:?]
        at java_util_ListIterator$hasNext.call(Unknown Source) [?:?]
        at 
org.codehaus.groovy.runtime.callsite.CallSiteArray.defaultCall(CallSiteArray.java:47)
 [groovy-3.0.21.jar:3.0.21]
        at 
org.codehaus.groovy.runtime.callsite.AbstractCallSite.call(AbstractCallSite.java:125)
 [groovy-3.0.21.jar:3.0.21]
        at 
org.codehaus.groovy.runtime.callsite.AbstractCallSite.call(AbstractCallSite.java:130)
 [groovy-3.0.21.jar:3.0.21]
        at 
org.apache.ofbiz.party.party.UnAppliedInvoicesForParty.run(UnAppliedInvoicesForParty.groovy:49)
 [script:?]
        at 
org.apache.ofbiz.base.util.GroovyUtil.runScriptAtLocation(GroovyUtil.java:213) 
[main/:?]
        at 
org.apache.ofbiz.base.util.ScriptUtil.executeScript(ScriptUtil.java:312) 
[main/:?]
        at 
org.apache.ofbiz.base.util.ScriptUtil.executeScript(ScriptUtil.java:295) 
[main/:?]
        at 
org.apache.ofbiz.widget.model.AbstractModelAction$Script.runAction(AbstractModelAction.java:716)
 [main/:?]
        at 
org.apache.ofbiz.widget.model.AbstractModelAction.runSubActions(AbstractModelAction.java:138)
 [main/:?]
        at 
org.apache.ofbiz.widget.model.ModelForm.runFormActions(ModelForm.java:1816) 
[main/:?]
        at 
org.apache.ofbiz.widget.renderer.FormRenderer.render(FormRenderer.java:265) 
[main/:?]
        at 
org.apache.ofbiz.widget.model.ModelScreenWidget$Grid.renderWidgetString(ModelScreenWidget.java:1188)
 [main/:?]
        at 
org.apache.ofbiz.widget.renderer.macro.MacroScreenRenderer.renderScreenletSubWidget(MacroScreenRenderer.java:736)
 [main/:?]
        at 
org.apache.ofbiz.widget.model.ModelScreenWidget$Screenlet.renderWidgetString(ModelScreenWidget.java:631)
 [main/:?]
        at 
org.apache.ofbiz.widget.model.ModelScreenWidget.renderSubWidgetsString(ModelScreenWidget.java:109)
 [main/:?]
        at 
org.apache.ofbiz.widget.model.ModelScreenWidget$Section.renderWidgetString(ModelScreenWidget.java:297)
 [main/:?]
        at 
org.apache.ofbiz.widget.model.ModelScreenWidget.renderSubWidgetsString(ModelScreenWidget.java:109)
 [main/:?]
        at 
org.apache.ofbiz.widget.model.ModelScreenWidget$DecoratorSection.renderWidgetString(ModelScreenWidget.java:947)
 [main/:?]
        at 
org.apache.ofbiz.widget.model.ModelScreenWidget$SectionsRenderer.render(ModelScreenWidget.java:142)
 [main/:?]
        at 
org.apache.ofbiz.widget.model.ModelScreenWidget$DecoratorSectionInclude.renderWidgetString(ModelScreenWidget.java:986)
 [main/:?]
        at 
org.apache.ofbiz.widget.model.ModelScreenWidget.renderSubWidgetsString(ModelScreenWidget.java:109)
 [main/:?]
        at 
org.apache.ofbiz.widget.model.ModelScreenWidget$Section.renderWidgetString(ModelScreenWidget.java:297)
 [main/:?]
        at 
org.apache.ofbiz.widget.model.ModelScreenWidget.renderSubWidgetsString(ModelScreenWidget.java:109)
 [main/:?]
        at 
org.apache.ofbiz.widget.model.ModelScreenWidget$DecoratorSection.renderWidgetString(ModelScreenWidget.java:947)
 [main/:?]
        at 
org.apache.ofbiz.widget.model.ModelScreenWidget$SectionsRenderer.render(ModelScreenWidget.java:142)
 [main/:?]
        at 
org.apache.ofbiz.widget.model.ModelScreenWidget$DecoratorSectionInclude.renderWidgetString(ModelScreenWidget.java:986)
 [main/:?]
        at 
org.apache.ofbiz.widget.model.ModelScreenWidget.renderSubWidgetsString(ModelScreenWidget.java:109)
 [main/:?]
        at 
org.apache.ofbiz.widget.model.ModelScreenWidget$Container.renderWidgetString(ModelScreenWidget.java:481)
 [main/:?]
        at 
org.apache.ofbiz.widget.model.ModelScreenWidget.renderSubWidgetsString(ModelScreenWidget.java:109)
 [main/:?]
        at 
org.apache.ofbiz.widget.model.ModelScreenWidget$Section.renderWidgetString(ModelScreenWidget.java:297)
 [main/:?]
        at 
org.apache.ofbiz.widget.model.ModelScreenWidget.renderSubWidgetsString(ModelScreenWidget.java:109)
 [main/:?]
        at 
org.apache.ofbiz.widget.model.ModelScreenWidget$Container.renderWidgetString(ModelScreenWidget.java:481)
 [main/:?]
        at 
org.apache.ofbiz.widget.model.ModelScreenWidget.renderSubWidgetsString(ModelScreenWidget.java:109)
 [main/:?]
        at 

[jira] [Commented] (OFBIZ-12653) Sanitizer fail

2024-05-24 Thread Jacques Le Roux (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-12653?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17849199#comment-17849199
 ] 

Jacques Le Roux commented on OFBIZ-12653:
-

It was unrelated to this Jira but related to OFBIZ-12691. Improved with 
https://github.com/apache/ofbiz-framework/commit/98febce8c3594d0f8bb5e1fc7a6c09dadffd113d

> Sanitizer  fail
> ---
>
> Key: OFBIZ-12653
> URL: https://issues.apache.org/jira/browse/OFBIZ-12653
> Project: OFBiz
>  Issue Type: Bug
>  Components: content
>Affects Versions: Upcoming Branch
>Reporter: Ingo Wolfmayr
>Assignee: Jacques Le Roux
>Priority: Major
> Fix For: 22.01.01
>
> Attachments: CustomSafePolicy.patch, OFBIZ-12653.patch, 
> UtilCodec.patch
>
>
> I copied a text with multiple lines from a text editor into the Trumbowyg 
> Html field.The editor creates the Html structure using unclosed  elements.
> Unfortunately the sanitizer logic just takes . A security warning is 
> thrown and the content will not be stored.
> Issue also a request on Trumbowyg request list:
> [https://github.com/Alex-D/Trumbowyg/issues/1283]



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Comment Edited] (OFBIZ-12691) Extend HTML Sanitizer - style attribute

2024-05-24 Thread Jacques Le Roux (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-12691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17605242#comment-17605242
 ] 

Jacques Le Roux edited comment on OFBIZ-12691 at 5/24/24 6:31 AM:
--

Commit 71cf2a8b8d9a0beea5960442706320561351f1f6 in ofbiz-framework's branch 
refs/heads/release22.01 from Jacques Le Roux
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=71cf2a8b8d ]

Improved: Extend HTML Sanitizer - style attribute (OFBIZ-12691)

This is a no functional changes. It makes things clearer.

I initially wanted to rather do that and forgot. The idea is to no change the
sanitization done by HtmlSanitizer.Policy(). We just need to be sure that the
comparison with unescapeEcmaScriptAndHtml4 works.

Maybe later we will figure out that some more HTML entities will need to be
added to 
{noformat}
"" and ""
{noformat}
...



was (Author: jira-bot):
Commit 71cf2a8b8d9a0beea5960442706320561351f1f6 in ofbiz-framework's branch 
refs/heads/release22.01 from Jacques Le Roux
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=71cf2a8b8d ]

Improved: Extend HTML Sanitizer - style attribute (OFBIZ-12691)

This is a no functional changes. It makes things clearer.

I initially wanted to rather do that and forgot. The idea is to no change the
sanitization done by HtmlSanitizer.Policy(). We just need to be sure that the
comparison with unescapeEcmaScriptAndHtml4 works.

Maybe later we will figure out that some more HTML entities will need to be
added to "" and ""...


> Extend HTML Sanitizer - style attribute
> ---
>
> Key: OFBIZ-12691
> URL: https://issues.apache.org/jira/browse/OFBIZ-12691
> Project: OFBiz
>  Issue Type: Bug
>  Components: content
>Affects Versions: Upcoming Branch
>Reporter: Ingo Wolfmayr
>Assignee: Jacques Le Roux
>Priority: Major
> Fix For: 22.01.01
>
> Attachments: SanitizerStyle.patch
>
>
> Right now it is not possible to assign inline style to html content. 
> Trumbowyg Editor uses such tags for align paragraphs.
> style="text-align:right"
> It is necessary to remove space within the attribute and remove the trailing 
> semicolon in order to apply with OWASP filter rules.
> Create or open content with "Long text". Goto dataresource and edit HTML. Put 
> in some text and use the align icons (right, center ...) to format the text. 
> Save. You will get a security info.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Comment Edited] (OFBIZ-12691) Extend HTML Sanitizer - style attribute

2024-05-24 Thread Jacques Le Roux (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-12691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17605243#comment-17605243
 ] 

Jacques Le Roux edited comment on OFBIZ-12691 at 5/24/24 6:31 AM:
--

Commit c005971e4be56ef7928a6f7d0b7f438e4aa64765 in ofbiz-framework's branch 
refs/heads/trunk from Jacques Le Roux
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=c005971e4b ]

Improved: Extend HTML Sanitizer - style attribute (OFBIZ-12691)

This is a no functional changes. It makes things clearer.

I initially wanted to rather do that and forgot. The idea is to no change the
sanitization done by HtmlSanitizer.Policy(). We just need to be sure that the
comparison with unescapeEcmaScriptAndHtml4 works.

Maybe later we will figure out that some more HTML entities will need to be
added to 
{noformat}
"" and ""
{noformat}
...



was (Author: jira-bot):
Commit c005971e4be56ef7928a6f7d0b7f438e4aa64765 in ofbiz-framework's branch 
refs/heads/trunk from Jacques Le Roux
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=c005971e4b ]

Improved: Extend HTML Sanitizer - style attribute (OFBIZ-12691)

This is a no functional changes. It makes things clearer.

I initially wanted to rather do that and forgot. The idea is to no change the
sanitization done by HtmlSanitizer.Policy(). We just need to be sure that the
comparison with unescapeEcmaScriptAndHtml4 works.

Maybe later we will figure out that some more HTML entities will need to be
added to "" and ""...


> Extend HTML Sanitizer - style attribute
> ---
>
> Key: OFBIZ-12691
> URL: https://issues.apache.org/jira/browse/OFBIZ-12691
> Project: OFBiz
>  Issue Type: Bug
>  Components: content
>Affects Versions: Upcoming Branch
>Reporter: Ingo Wolfmayr
>Assignee: Jacques Le Roux
>Priority: Major
> Fix For: 22.01.01
>
> Attachments: SanitizerStyle.patch
>
>
> Right now it is not possible to assign inline style to html content. 
> Trumbowyg Editor uses such tags for align paragraphs.
> style="text-align:right"
> It is necessary to remove space within the attribute and remove the trailing 
> semicolon in order to apply with OWASP filter rules.
> Create or open content with "Long text". Goto dataresource and edit HTML. Put 
> in some text and use the align icons (right, center ...) to format the text. 
> Save. You will get a security info.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (OFBIZ-12653) Sanitizer fail

2024-05-23 Thread Jacques Le Roux (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-12653?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17849164#comment-17849164
 ] 

Jacques Le Roux commented on OFBIZ-12653:
-

BTW could you not replace exam...@example.com by example at example.com?

> Sanitizer  fail
> ---
>
> Key: OFBIZ-12653
> URL: https://issues.apache.org/jira/browse/OFBIZ-12653
> Project: OFBiz
>  Issue Type: Bug
>  Components: content
>Affects Versions: Upcoming Branch
>Reporter: Ingo Wolfmayr
>Assignee: Jacques Le Roux
>Priority: Major
> Fix For: 22.01.01
>
> Attachments: CustomSafePolicy.patch, OFBIZ-12653.patch, 
> UtilCodec.patch
>
>
> I copied a text with multiple lines from a text editor into the Trumbowyg 
> Html field.The editor creates the Html structure using unclosed  elements.
> Unfortunately the sanitizer logic just takes . A security warning is 
> thrown and the content will not be stored.
> Issue also a request on Trumbowyg request list:
> [https://github.com/Alex-D/Trumbowyg/issues/1283]



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (OFBIZ-12653) Sanitizer fail

2024-05-23 Thread Jacques Le Roux (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-12653?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17849163#comment-17849163
 ] 

Jacques Le Roux commented on OFBIZ-12653:
-

Hi Chenghu Shan,

When you say the last commit I guess you speak about the trunk? Because the 
22.01 branch has been somehow deprecated.

> Sanitizer  fail
> ---
>
> Key: OFBIZ-12653
> URL: https://issues.apache.org/jira/browse/OFBIZ-12653
> Project: OFBiz
>  Issue Type: Bug
>  Components: content
>Affects Versions: Upcoming Branch
>Reporter: Ingo Wolfmayr
>Assignee: Jacques Le Roux
>Priority: Major
> Fix For: 22.01.01
>
> Attachments: CustomSafePolicy.patch, OFBIZ-12653.patch, 
> UtilCodec.patch
>
>
> I copied a text with multiple lines from a text editor into the Trumbowyg 
> Html field.The editor creates the Html structure using unclosed  elements.
> Unfortunately the sanitizer logic just takes . A security warning is 
> thrown and the content will not be stored.
> Issue also a request on Trumbowyg request list:
> [https://github.com/Alex-D/Trumbowyg/issues/1283]



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Closed] (OFBIZ-13098) createTimesheetForThisWeek as admin fails

2024-05-23 Thread Jacques Le Roux (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-13098?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux closed OFBIZ-13098.
---
Fix Version/s: Upcoming Branch
 Assignee: Jacques Le Roux
   Resolution: Fixed

> createTimesheetForThisWeek as admin fails
> -
>
> Key: OFBIZ-13098
> URL: https://issues.apache.org/jira/browse/OFBIZ-13098
> Project: OFBiz
>  Issue Type: Bug
>  Components: workeffort/workeffort
>Affects Versions: Upcoming Branch
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Major
> Fix For: Upcoming Branch
>
>
> It works in 18.12
> Here is the error in UI:
> org.apache.ofbiz.webapp.control.RequestHandlerException: Unknown request 
> [createTimesheetForThisWeek]; this request does not exist or cannot be called 
> directly.
> In log:
> 2024-05-23 08:40:43,872 |jsse-nio-8443-exec-3 |ControlServlet
> |E| Error in request handler:
> org.apache.ofbiz.webapp.control.RequestHandlerException: Unknown request 
> [createTimesheetForThisWeek]; this request does not exist or cannot be called 
> directly.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (OFBIZ-13098) createTimesheetForThisWeek as admin fails

2024-05-23 Thread Jacques Le Roux (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-13098?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17848836#comment-17848836
 ] 

Jacques Le Roux commented on OFBIZ-13098:
-

It's seems rather due to OFBIZ-12262

> createTimesheetForThisWeek as admin fails
> -
>
> Key: OFBIZ-13098
> URL: https://issues.apache.org/jira/browse/OFBIZ-13098
> Project: OFBiz
>  Issue Type: Bug
>  Components: workeffort/workeffort
>Affects Versions: Upcoming Branch
>Reporter: Jacques Le Roux
>Priority: Major
>
> It works in 18.12
> Here is the error in UI:
> org.apache.ofbiz.webapp.control.RequestHandlerException: Unknown request 
> [createTimesheetForThisWeek]; this request does not exist or cannot be called 
> directly.
> In log:
> 2024-05-23 08:40:43,872 |jsse-nio-8443-exec-3 |ControlServlet
> |E| Error in request handler:
> org.apache.ofbiz.webapp.control.RequestHandlerException: Unknown request 
> [createTimesheetForThisWeek]; this request does not exist or cannot be called 
> directly.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (OFBIZ-13098) createTimesheetForThisWeek as admin fails

2024-05-23 Thread Jacques Le Roux (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-13098?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17848829#comment-17848829
 ] 

Jacques Le Roux commented on OFBIZ-13098:
-

It could be related to OFBIZ-13078, checking...

> createTimesheetForThisWeek as admin fails
> -
>
> Key: OFBIZ-13098
> URL: https://issues.apache.org/jira/browse/OFBIZ-13098
> Project: OFBiz
>  Issue Type: Bug
>  Components: workeffort/workeffort
>Affects Versions: Upcoming Branch
>Reporter: Jacques Le Roux
>Priority: Major
>
> It works in 18.12
> Here is the error in UI:
> org.apache.ofbiz.webapp.control.RequestHandlerException: Unknown request 
> [createTimesheetForThisWeek]; this request does not exist or cannot be called 
> directly.
> In log:
> 2024-05-23 08:40:43,872 |jsse-nio-8443-exec-3 |ControlServlet
> |E| Error in request handler:
> org.apache.ofbiz.webapp.control.RequestHandlerException: Unknown request 
> [createTimesheetForThisWeek]; this request does not exist or cannot be called 
> directly.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Created] (OFBIZ-13098) createTimesheetForThisWeek as admin fails

2024-05-23 Thread Jacques Le Roux (Jira)
Jacques Le Roux created OFBIZ-13098:
---

 Summary: createTimesheetForThisWeek as admin fails
 Key: OFBIZ-13098
 URL: https://issues.apache.org/jira/browse/OFBIZ-13098
 Project: OFBiz
  Issue Type: Bug
  Components: workeffort/workeffort
Affects Versions: Upcoming Branch
Reporter: Jacques Le Roux


It works in 18.12

Here is the error in UI:
org.apache.ofbiz.webapp.control.RequestHandlerException: Unknown request 
[createTimesheetForThisWeek]; this request does not exist or cannot be called 
directly.

In log:
2024-05-23 08:40:43,872 |jsse-nio-8443-exec-3 |ControlServlet
|E| Error in request handler:
org.apache.ofbiz.webapp.control.RequestHandlerException: Unknown request 
[createTimesheetForThisWeek]; this request does not exist or cannot be called 
directly.




--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (OFBIZ-5744) We need to upgrade Birt which uses Axis 1.4 because of CVE-2014-3596

2024-05-23 Thread Jacques Le Roux (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-5744?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17848827#comment-17848827
 ] 

Jacques Le Roux commented on OFBIZ-5744:


With the 2 attached necessary patches applied here is what I get w/o any 
changes:

{noformat}
> Task :compileJava
C:\projectsASF\Git\ofbiz-framework\plugins\birt\src\main\java\org\apache\ofbiz\birt\container\BirtContainer.java:26:
 error: cannot find symbol
import org.eclipse.birt.report.IBirtConstants;
  ^
  symbol:   class IBirtConstants
  location: package org.eclipse.birt.report
C:\projectsASF\Git\ofbiz-framework\plugins\birt\src\main\java\org\apache\ofbiz\birt\report\servlet\BirtViewerServlet.java:28:
 error: package org.eclipse.birt.report.context does not exist
import org.eclipse.birt.report.context.BirtContext;
  ^
C:\projectsASF\Git\ofbiz-framework\plugins\birt\src\main\java\org\apache\ofbiz\birt\report\servlet\BirtViewerServlet.java:29:
 error: package org.eclipse.birt.report.context does not exist
import org.eclipse.birt.report.context.IContext;
  ^
C:\projectsASF\Git\ofbiz-framework\plugins\birt\src\main\java\org\apache\ofbiz\birt\report\servlet\BirtViewerServlet.java:30:
 error: package org.eclipse.birt.report.service does not exist
import org.eclipse.birt.report.service.BirtReportServiceFactory;
  ^
C:\projectsASF\Git\ofbiz-framework\plugins\birt\src\main\java\org\apache\ofbiz\birt\report\servlet\BirtViewerServlet.java:31:
 error: package org.eclipse.birt.report.service does not exist
import org.eclipse.birt.report.service.ReportEngineService;
  ^
C:\projectsASF\Git\ofbiz-framework\plugins\birt\src\main\java\org\apache\ofbiz\birt\report\servlet\BirtViewerServlet.java:32:
 error: package org.eclipse.birt.report.servlet does not exist
import org.eclipse.birt.report.servlet.ViewerServlet;
  ^
C:\projectsASF\Git\ofbiz-framework\plugins\birt\src\main\java\org\apache\ofbiz\birt\report\servlet\BirtViewerServlet.java:33:
 error: package org.eclipse.birt.report.utility does not exist
import org.eclipse.birt.report.utility.ParameterAccessor;
  ^
C:\projectsASF\Git\ofbiz-framework\plugins\birt\src\main\java\org\apache\ofbiz\birt\report\servlet\BirtViewerServlet.java:38:
 error: cannot find symbol
public class BirtViewerServlet extends ViewerServlet {
   ^
  symbol: class ViewerServlet
C:\projectsASF\Git\ofbiz-framework\plugins\birt\src\main\java\org\apache\ofbiz\birt\report\servlet\BirtViewerServlet.java:43:
 error: cannot find symbol
protected IContext __getContext(HttpServletRequest request, 
HttpServletResponse response) throws BirtException {
  ^
  symbol:   class IContext
  location: class BirtViewerServlet
C:\projectsASF\Git\ofbiz-framework\plugins\birt\src\main\java\org\apache\ofbiz\birt\report\servlet\OfbizBirtEngineServlet.java:30:
 error: package org.eclipse.birt.report.context does not exist
import org.eclipse.birt.report.context.BirtContext;
  ^
C:\projectsASF\Git\ofbiz-framework\plugins\birt\src\main\java\org\apache\ofbiz\birt\report\servlet\OfbizBirtEngineServlet.java:31:
 error: package org.eclipse.birt.report.context does not exist
import org.eclipse.birt.report.context.IContext;
  ^
C:\projectsASF\Git\ofbiz-framework\plugins\birt\src\main\java\org\apache\ofbiz\birt\report\servlet\OfbizBirtEngineServlet.java:32:
 error: package org.eclipse.birt.report.service does not exist
import org.eclipse.birt.report.service.BirtReportServiceFactory;
  ^
C:\projectsASF\Git\ofbiz-framework\plugins\birt\src\main\java\org\apache\ofbiz\birt\report\servlet\OfbizBirtEngineServlet.java:33:
 error: package org.eclipse.birt.report.service does not exist
import org.eclipse.birt.report.service.ReportEngineService;
  ^
C:\projectsASF\Git\ofbiz-framework\plugins\birt\src\main\java\org\apache\ofbiz\birt\report\servlet\OfbizBirtEngineServlet.java:34:
 error: package org.eclipse.birt.report.utility does not exist
import org.eclipse.birt.report.utility.ParameterAccessor;
  ^
C:\projectsASF\Git\ofbiz-framework\plugins\birt\src\main\java\org\apache\ofbiz\birt\report\servlet\OfbizBirtEngineServlet.java:37:
 error: package org.eclipse.birt.report.servlet does not exist
public class OfbizBirtEngineServlet extends 
org.eclipse.birt.report.servlet.BirtEngineServlet {
   ^
C:\projectsASF\Git\ofbiz-framework\plugins\birt\src\main\java\org\apache\ofbiz\birt\report\servlet\OfbizBirtEngineServlet.java:40:
 error: cannot find symbol
protected 

[jira] [Updated] (OFBIZ-5744) We need to upgrade Birt which uses Axis 1.4 because of CVE-2014-3596

2024-05-23 Thread Jacques Le Roux (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-5744?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux updated OFBIZ-5744:
---
Attachment: OFBIZ-5744-birt-plugin.patch
OFBIZ-5744-framework.patch

> We need to upgrade Birt which uses Axis 1.4 because of CVE-2014-3596
> 
>
> Key: OFBIZ-5744
> URL: https://issues.apache.org/jira/browse/OFBIZ-5744
> Project: OFBiz
>  Issue Type: Bug
>  Components: birt
>Affects Versions: 11.04.06, 12.04.05, 14.12.01, 18.12.13
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Major
>  Labels: CVE
> Attachments: OFBIZ-5744-birt-plugin.patch, OFBIZ-5744-framework.patch
>
>
> https://web.nvd.nist.gov/view/vuln/detail?vulnId=CVE-2014-3596



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Updated] (OFBIZ-5744) We need to upgrade Birt which uses Axis 1.4 because of CVE-2014-3596

2024-05-23 Thread Jacques Le Roux (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-5744?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux updated OFBIZ-5744:
---
Affects Version/s: 18.12.13

> We need to upgrade Birt which uses Axis 1.4 because of CVE-2014-3596
> 
>
> Key: OFBIZ-5744
> URL: https://issues.apache.org/jira/browse/OFBIZ-5744
> Project: OFBiz
>  Issue Type: Bug
>  Components: birt
>Affects Versions: 11.04.06, 12.04.05, 14.12.01, 18.12.13
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Major
>  Labels: CVE
>
> https://web.nvd.nist.gov/view/vuln/detail?vulnId=CVE-2014-3596



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (OFBIZ-5744) We need to upgrade Birt which uses Axis 1.4 because of CVE-2014-3596

2024-05-23 Thread Jacques Le Roux (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-5744?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17848825#comment-17848825
 ] 

Jacques Le Roux commented on OFBIZ-5744:


With OFBIZ-12824 we disabled the Birt component in all branches (including 
trunk) because of CVE-2022-25371.

Recently with 
https://github.com/eclipse-birt/birt/issues/625#issuecomment-2118951488 it's 
maybe possible to upgrade the Birt component in OFBiz. Let's see what it 
needs...

> We need to upgrade Birt which uses Axis 1.4 because of CVE-2014-3596
> 
>
> Key: OFBIZ-5744
> URL: https://issues.apache.org/jira/browse/OFBIZ-5744
> Project: OFBiz
>  Issue Type: Bug
>  Components: birt
>Affects Versions: 11.04.06, 12.04.05, 14.12.01
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Major
>  Labels: CVE
>
> https://web.nvd.nist.gov/view/vuln/detail?vulnId=CVE-2014-3596



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Assigned] (OFBIZ-5744) We need to upgrade Birt which uses Axis 1.4 because of CVE-2014-3596

2024-05-23 Thread Jacques Le Roux (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-5744?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux reassigned OFBIZ-5744:
--

Assignee: Jacques Le Roux

> We need to upgrade Birt which uses Axis 1.4 because of CVE-2014-3596
> 
>
> Key: OFBIZ-5744
> URL: https://issues.apache.org/jira/browse/OFBIZ-5744
> Project: OFBiz
>  Issue Type: Bug
>  Components: birt
>Affects Versions: 11.04.06, 12.04.05, 14.12.01
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Major
>  Labels: CVE
>
> https://web.nvd.nist.gov/view/vuln/detail?vulnId=CVE-2014-3596



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (OFBIZ-13097) Have an XSD regarding portal records

2024-05-21 Thread Jacques Le Roux (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-13097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17848309#comment-17848309
 ] 

Jacques Le Roux commented on OFBIZ-13097:
-

Mmm, it's data but the use is to create widget, so seems better in widget. Not 
a big deal anyway.

> Have an XSD regarding portal records
> 
>
> Key: OFBIZ-13097
> URL: https://issues.apache.org/jira/browse/OFBIZ-13097
> Project: OFBiz
>  Issue Type: Sub-task
>Reporter: Pierre Smits
>Priority: Major
>
> Per suggestion by [~jleroux]:
> {quote}But we really miss the same for data used to define portals. So I 
> strongly suggest that we create a shema for *PortletData.xml files. It should 
> not be hard to create. It would help possible customers to create their own 
> portals with a bit of documentation that seriously lacks for now. 
> {quote}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (OFBIZ-13097) Have an XSD regarding portal records

2024-05-21 Thread Jacques Le Roux (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-13097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17848305#comment-17848305
 ] 

Jacques Le Roux commented on OFBIZ-13097:
-

Ha sorry, I did not see your comment. I think it's a kind of widget but also 
it's data, maybe in common? There is yet no DTD there.

We have all XSDs in site at https://ofbiz.apache.org/dtds/ 
We also put references to XSD in *-catalog.xml to use XSD files locally. See 
widget-catalog.xml for instance.

It's due to OASIS:
https://www.oasis-open.org/committees/entity/spec-2001-08-06.html
https://xmlcatalogs.org/

> Have an XSD regarding portal records
> 
>
> Key: OFBIZ-13097
> URL: https://issues.apache.org/jira/browse/OFBIZ-13097
> Project: OFBiz
>  Issue Type: Sub-task
>Reporter: Pierre Smits
>Priority: Major
>
> Per suggestion by [~jleroux]:
> {quote}But we really miss the same for data used to define portals. So I 
> strongly suggest that we create a shema for *PortletData.xml files. It should 
> not be hard to create. It would help possible customers to create their own 
> portals with a bit of documentation that seriously lacks for now. 
> {quote}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (OFBIZ-13097) Have an XSD regarding portal records

2024-05-21 Thread Jacques Le Roux (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-13097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17848291#comment-17848291
 ] 

Jacques Le Roux commented on OFBIZ-13097:
-

Thanks Pierre,

 

I can help, though I'll focus 1st on OFBIZ-12653

> Have an XSD regarding portal records
> 
>
> Key: OFBIZ-13097
> URL: https://issues.apache.org/jira/browse/OFBIZ-13097
> Project: OFBiz
>  Issue Type: Sub-task
>Reporter: Pierre Smits
>Priority: Major
>
> Per suggestion by [~jleroux]:
> {quote}But we really miss the same for data used to define portals. So I 
> strongly suggest that we create a shema for *PortletData.xml files. It should 
> not be hard to create. It would help possible customers to create their own 
> portals with a bit of documentation that seriously lacks for now. 
> {quote}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (OFBIZ-12653) Sanitizer fail

2024-05-21 Thread Jacques Le Roux (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-12653?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17848121#comment-17848121
 ] 

Jacques Le Roux commented on OFBIZ-12653:
-

Hi [~cshan] ,

I'll have a look...

> Sanitizer  fail
> ---
>
> Key: OFBIZ-12653
> URL: https://issues.apache.org/jira/browse/OFBIZ-12653
> Project: OFBiz
>  Issue Type: Bug
>  Components: content
>Affects Versions: Upcoming Branch
>Reporter: Ingo Wolfmayr
>Assignee: Jacques Le Roux
>Priority: Major
> Fix For: 22.01.01
>
> Attachments: CustomSafePolicy.patch, OFBIZ-12653.patch, 
> UtilCodec.patch
>
>
> I copied a text with multiple lines from a text editor into the Trumbowyg 
> Html field.The editor creates the Html structure using unclosed  elements.
> Unfortunately the sanitizer logic just takes . A security warning is 
> thrown and the content will not be stored.
> Issue also a request on Trumbowyg request list:
> [https://github.com/Alex-D/Trumbowyg/issues/1283]



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Closed] (OFBIZ-5377) Add ability to join entitites with parameterized conditions to other entities

2024-05-21 Thread Jacques Le Roux (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-5377?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux closed OFBIZ-5377.
--
Resolution: Abandoned

Ten years after ;), better close here

> Add ability to join entitites with parameterized conditions to other entities
> -
>
> Key: OFBIZ-5377
> URL: https://issues.apache.org/jira/browse/OFBIZ-5377
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework
>Reporter: Christian Carlow
>Assignee: Adam Heath
>Priority: Major
>
> OFBiz should be improved to allow entities with parameterized conditions to 
> be joined with other entities.
> I need to be able to apply a condition to the OrderShipment entity where 
> OrderShipment.shipmentId = parameters.shipmentId which might produce this 
> query:
> SELECT * ORDER_SHIPMENT WHERE SHIPMENT_ID = '1';
> Then I need to be able to take that query and join it to the 
> OrderItemShipGroupAssoc entity to product a query such as this:
> SELECT * FROM ORDER_ITEM_SHIP_GROUP_ASSOC OISGA LEFT JOIN (SELECT * FROM 
> ORDER_SHIPMENT WHERE SHIPMENT_ID = '1') OS ON OISGA.ORDER_ID = 
> OS.ORDER_ID AND OISGA.ORDER_ITEM_SEQ_ID = OS.ORDER_ITEM_SEQ_ID AND 
> OISGA.SHIP_GROUP_SEQ_ID = OS.SHIP_GROUP_SEQ_ID



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Closed] (OFBIZ-4153) Make entity engine a standalone database access tool/API

2024-05-21 Thread Jacques Le Roux (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-4153?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux closed OFBIZ-4153.
--
Resolution: Abandoned

Atlassian did that for Jira, seems to work well but not cheap

> Make entity engine a standalone database access tool/API
> 
>
> Key: OFBIZ-4153
> URL: https://issues.apache.org/jira/browse/OFBIZ-4153
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework
>Reporter: Raj Saini
>Assignee: Adam Heath
>Priority: Minor
>
> From the user mailing list:
> I was picturing the entity engine as a lower level artifact - like a jar 
> file. I don't have all of the details worked out yet, but what I picture is 
> this:
> 1. An application needs a database-agnostic data store.
> 2. The application accesses the data store though the entity engine API/ jar 
> library.
> Ofbiz has a very convenient way of defining databases, tables, and views as 
> XML files. Plus, it has the ability to create/modify table/index structures 
> during start-up. I believe that would be a very handy tool for anyone wanting 
> to create any application that requires data storage.
> Wrapping the entity engine jar file in an OSGI bundle would be trivial.
> If anyone is interested in exploring this further, then they should create a 
> Jira issue and we can take it from there. 



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Closed] (OFBIZ-5210) view-entity cannot be extended

2024-05-21 Thread Jacques Le Roux (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-5210?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux closed OFBIZ-5210.
--
Resolution: Abandoned

A valid request feature can always be reopened

> view-entity cannot be extended
> --
>
> Key: OFBIZ-5210
> URL: https://issues.apache.org/jira/browse/OFBIZ-5210
> Project: OFBiz
>  Issue Type: New Feature
>  Components: framework
>Affects Versions: Release Branch 12.04
> Environment: Windows / Linux
>Reporter: Skip Dever
>Assignee: Adam Heath
>Priority: Minor
>
> For example, add the following to the bottom of entitymodel_view.xml in 
> applications\workeffort\entitydef
> 
>  rel-entity-name="StatusItem">
> 
> 
> 
> 
> 
> 
> 
> 
> 
> Then, start Ofbiz and you will get an error in the log that 
> WorkEffortAndPartyAssign does not exist.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Closed] (OFBIZ-4811) Improving view-entity creation in both XML and DynamicViewEntity to exclude fields declared as Alias from the SQL Select strings

2024-05-21 Thread Jacques Le Roux (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-4811?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux closed OFBIZ-4811.
--
Resolution: Abandoned

> Improving view-entity creation in both XML and DynamicViewEntity to exclude 
> fields declared as Alias from the SQL Select strings
> 
>
> Key: OFBIZ-4811
> URL: https://issues.apache.org/jira/browse/OFBIZ-4811
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework
>Affects Versions: Trunk, Upcoming Branch
>Reporter: FooShyn
>Assignee: Adam Heath
>Priority: Major
>
> To have additional feature for view-entity creation so that
> - Alias can be excluded from the SQL Select strings. This feature is 
> particularly useful when working on reports that need aggregation on the data 
> with fields that need to be use as filter. E.g.: select a.salesman_id, 
> sum(b.sales) as total_sales from salesman a, daily_sales b where 
> a.salesman_id = b.salesman_id and b.sales_date < '02-02-2012' group by 
> a.salesman_id
> - To have constant values that can be use in view-link.
> E.g.
> 
> 
>  
> 
> This produces something like this:
> select * from a left join b on a.importSessionId = b.sessionId and
> status='ERROR'



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Closed] (OFBIZ-4870) Multithreading in GenericDAO / Delegator

2024-05-21 Thread Jacques Le Roux (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-4870?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux closed OFBIZ-4870.
--
Resolution: Abandoned

> Multithreading in GenericDAO / Delegator
> 
>
> Key: OFBIZ-4870
> URL: https://issues.apache.org/jira/browse/OFBIZ-4870
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework
>Reporter: Mirko Vogelsmeier
>Assignee: Adam Heath
>Priority: Major
>
> Hey there,
> some time ago there were some commits of Adam that brought in first ideas of 
> multi threaded delegator useage (r1139700).
> Depending on how intense the data useage or data size is, there are 
> performance issues we cannot scale by pure hardware and/or configuration as 
> there is just one Delegator object per datasource.
> I wanted to check on the progress of this very helpfull feature. Are there 
> any further thoughts to work on this?
> Greetings,
> Mirko



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Closed] (OFBIZ-5331) Change EntityComparisonOperator to use compareTo()

2024-05-21 Thread Jacques Le Roux (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-5331?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux closed OFBIZ-5331.
--
Resolution: Abandoned

> Change EntityComparisonOperator to use compareTo()
> --
>
> Key: OFBIZ-5331
> URL: https://issues.apache.org/jira/browse/OFBIZ-5331
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework
>Reporter: Joseph Eckard
>Assignee: Adam Heath
>Priority: Trivial
> Attachments: patch.txt
>
>
> The methods compareEqual() and compareNotEqual() both use equals() instead of 
> compareTo() which can be problematic when used to compare BigDecimal objects.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Closed] (OFBIZ-5712) New Delegator Container and GLOBAL_BATCH thread pool

2024-05-21 Thread Jacques Le Roux (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-5712?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux closed OFBIZ-5712.
--
Resolution: Abandoned

> New Delegator Container and GLOBAL_BATCH thread pool
> 
>
> Key: OFBIZ-5712
> URL: https://issues.apache.org/jira/browse/OFBIZ-5712
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework
>Affects Versions: Trunk, Upcoming Branch
>Reporter: Adam Heath
>Assignee: Adam Heath
>Priority: Major
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (OFBIZ-12897) Rework the log4j2.xml configuration to limit the number of log files generated

2024-05-20 Thread Jacques Le Roux (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-12897?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17847954#comment-17847954
 ] 

Jacques Le Roux commented on OFBIZ-12897:
-

Ah forgot, this was a wrong question
bq. how do you get access to the 166536 user?
Actually last time I tried sudoing as ofbizdocker user, forgot to exit (I'm not 
much working on *nix these last time)
So I simply needed to use {{<>}} on all demos instance 
(ie at :/home/ofbizdocker/demo-\*\*\*/logs) and it worked :)

Sorry to have call you about that

> Rework the log4j2.xml configuration to limit the number of log files generated
> --
>
> Key: OFBIZ-12897
> URL: https://issues.apache.org/jira/browse/OFBIZ-12897
> Project: OFBiz
>  Issue Type: Task
>  Components: framework
>Affects Versions: Upcoming Branch, 18.12.11
>Reporter: Daniel Watford
>Assignee: Daniel Watford
>Priority: Minor
> Fix For: Upcoming Branch, 18.12.13
>
>
> File lo4j2.xml configure log file rolling, but it does not appear to function 
> as perhaps intended.
> Log file rolling is configured to keep up to 10 log files. But the log file 
> naming convention appears to cause a maximum of 10 logs files to be kept for 
> each day.
> Rework the log4j2.xml configuration file to ensure that only 10 log files are 
> kept (for each appender) regardless of the date.
> Also, a limit of 1MB is quite small these days, particularly as text editors 
> can easily search through larger files without a noticeable performance 
> penalty (YMMV). I recommend raising the log file size limit to 10MB as this 
> would keep more log entries around without a corresponding increase in the 
> number of file.
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Closed] (OFBIZ-13094) Errors after creating a plugin

2024-05-20 Thread Jacques Le Roux (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-13094?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux closed OFBIZ-13094.
---
Fix Version/s: Upcoming Branch
   18.12.14
 Assignee: Jacques Le Roux
   Resolution: Fixed

In OFBIZ-13080 only trunk was concerned

> Errors after creating a plugin
> --
>
> Key: OFBIZ-13094
> URL: https://issues.apache.org/jira/browse/OFBIZ-13094
> Project: OFBiz
>  Issue Type: Bug
>  Components: Gradle
>Affects Versions: 18.12.14
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Major
> Fix For: Upcoming Branch, 18.12.14
>
>
> This is a generic task to handle the multiple errors that happen after 
> creating a plugin and trying to use it



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (OFBIZ-12897) Rework the log4j2.xml configuration to limit the number of log files generated

2024-05-20 Thread Jacques Le Roux (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-12897?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17847831#comment-17847831
 ] 

Jacques Le Roux commented on OFBIZ-12897:
-

OK, thanks Daniel, not a big deal.

> Rework the log4j2.xml configuration to limit the number of log files generated
> --
>
> Key: OFBIZ-12897
> URL: https://issues.apache.org/jira/browse/OFBIZ-12897
> Project: OFBiz
>  Issue Type: Task
>  Components: framework
>Affects Versions: Upcoming Branch, 18.12.11
>Reporter: Daniel Watford
>Assignee: Daniel Watford
>Priority: Minor
> Fix For: Upcoming Branch, 18.12.13
>
>
> File lo4j2.xml configure log file rolling, but it does not appear to function 
> as perhaps intended.
> Log file rolling is configured to keep up to 10 log files. But the log file 
> naming convention appears to cause a maximum of 10 logs files to be kept for 
> each day.
> Rework the log4j2.xml configuration file to ensure that only 10 log files are 
> kept (for each appender) regardless of the date.
> Also, a limit of 1MB is quite small these days, particularly as text editors 
> can easily search through larger files without a noticeable performance 
> penalty (YMMV). I recommend raising the log file size limit to 10MB as this 
> would keep more log entries around without a corresponding increase in the 
> number of file.
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Comment Edited] (OFBIZ-12897) Rework the log4j2.xml configuration to limit the number of log files generated

2024-05-20 Thread Jacques Le Roux (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-12897?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17847693#comment-17847693
 ] 

Jacques Le Roux edited comment on OFBIZ-12897 at 5/20/24 9:11 AM:
--

Hi Daniel,

Sorry, about next demos I see still  the \*2024\*.log files. The next demo is 
not of great interest at the moment, but will be when we will create the 24.xx 
branch. TIA, again not a hurry. BTW how do you get access to the 166536 user?


was (Author: jacques.le.roux):
Hi Daniel,

Sorry, about next demos I see still  the *2024*.log files. The next demo is not 
of great interest at the moment, but will be when we will create the 24.xx 
branch. TIA, again not a hurry. BTW how do you get access to the 166536 user?

> Rework the log4j2.xml configuration to limit the number of log files generated
> --
>
> Key: OFBIZ-12897
> URL: https://issues.apache.org/jira/browse/OFBIZ-12897
> Project: OFBiz
>  Issue Type: Task
>  Components: framework
>Affects Versions: Upcoming Branch, 18.12.11
>Reporter: Daniel Watford
>Assignee: Daniel Watford
>Priority: Minor
> Fix For: Upcoming Branch, 18.12.13
>
>
> File lo4j2.xml configure log file rolling, but it does not appear to function 
> as perhaps intended.
> Log file rolling is configured to keep up to 10 log files. But the log file 
> naming convention appears to cause a maximum of 10 logs files to be kept for 
> each day.
> Rework the log4j2.xml configuration file to ensure that only 10 log files are 
> kept (for each appender) regardless of the date.
> Also, a limit of 1MB is quite small these days, particularly as text editors 
> can easily search through larger files without a noticeable performance 
> penalty (YMMV). I recommend raising the log file size limit to 10MB as this 
> would keep more log entries around without a corresponding increase in the 
> number of file.
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Updated] (OFBIZ-13092) Prevent special encoded characters sequences in URLs

2024-05-20 Thread Jacques Le Roux (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-13092?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux updated OFBIZ-13092:

Parent: OFBIZ-1525
Issue Type: Sub-task  (was: Improvement)

> Prevent special encoded characters sequences in URLs
> 
>
> Key: OFBIZ-13092
> URL: https://issues.apache.org/jira/browse/OFBIZ-13092
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: framework/webapp
>Affects Versions: 18.12.14
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Major
> Fix For: 18.12.14
>
>
> Better avoid special encoded characters sequences 



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Closed] (OFBIZ-13092) Prevent special encoded characters sequences in URLs

2024-05-20 Thread Jacques Le Roux (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-13092?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux closed OFBIZ-13092.
---
Resolution: Fixed

> Prevent special encoded characters sequences in URLs
> 
>
> Key: OFBIZ-13092
> URL: https://issues.apache.org/jira/browse/OFBIZ-13092
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework/webapp
>Affects Versions: 18.12.14
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Major
> Fix For: 18.12.14
>
>
> Better avoid special encoded characters sequences 



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Closed] (OFBIZ-13095) The non ASCII language in UiLabels.xml are not correctly handled during plugin creation

2024-05-20 Thread Jacques Le Roux (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-13095?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux closed OFBIZ-13095.
---
Fix Version/s: Upcoming Branch
   Resolution: Fixed

> The non ASCII language in UiLabels.xml are not correctly handled during 
> plugin creation
> ---
>
> Key: OFBIZ-13095
> URL: https://issues.apache.org/jira/browse/OFBIZ-13095
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: Gradle
>Affects Versions: 18.12.14
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Major
> Fix For: Upcoming Branch
>
>
> You get this error:
> 2024-05-19 09:52:41,314 |jsse-nio-8443-exec-3 |UtilProperties
> |W| XML file for locale  could not be loaded.
> org.xml.sax.SAXParseException: Invalid byte 3 of 3-byte UTF-8 sequence.
> When removing ZH labels it works. We should keep only English languages or 
> amend the createPlugin Gradle task. In this issue I'll remove ZH labels and 
> put a comment as documentation about that for developers in 
> framework/resources/templates/UiLabels.xml



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (OFBIZ-12897) Rework the log4j2.xml configuration to limit the number of log files generated

2024-05-19 Thread Jacques Le Roux (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-12897?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17847693#comment-17847693
 ] 

Jacques Le Roux commented on OFBIZ-12897:
-

Hi Daniel,

Sorry, about next demos I see still  the *2024*.log files. The next demo is not 
of great interest at the moment, but will be when we will create the 24.xx 
branch. TIA, again not a hurry. BTW how do you get access to the 166536 user?

> Rework the log4j2.xml configuration to limit the number of log files generated
> --
>
> Key: OFBIZ-12897
> URL: https://issues.apache.org/jira/browse/OFBIZ-12897
> Project: OFBiz
>  Issue Type: Task
>  Components: framework
>Affects Versions: Upcoming Branch, 18.12.11
>Reporter: Daniel Watford
>Assignee: Daniel Watford
>Priority: Minor
> Fix For: Upcoming Branch, 18.12.13
>
>
> File lo4j2.xml configure log file rolling, but it does not appear to function 
> as perhaps intended.
> Log file rolling is configured to keep up to 10 log files. But the log file 
> naming convention appears to cause a maximum of 10 logs files to be kept for 
> each day.
> Rework the log4j2.xml configuration file to ensure that only 10 log files are 
> kept (for each appender) regardless of the date.
> Also, a limit of 1MB is quite small these days, particularly as text editors 
> can easily search through larger files without a noticeable performance 
> penalty (YMMV). I recommend raising the log file size limit to 10MB as this 
> would keep more log entries around without a corresponding increase in the 
> number of file.
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Updated] (OFBIZ-12897) Rework the log4j2.xml configuration to limit the number of log files generated

2024-05-19 Thread Jacques Le Roux (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-12897?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux updated OFBIZ-12897:

Fix Version/s: Upcoming Branch
   18.12.13

> Rework the log4j2.xml configuration to limit the number of log files generated
> --
>
> Key: OFBIZ-12897
> URL: https://issues.apache.org/jira/browse/OFBIZ-12897
> Project: OFBiz
>  Issue Type: Task
>  Components: framework
>Affects Versions: Upcoming Branch, 18.12.11
>Reporter: Daniel Watford
>Assignee: Daniel Watford
>Priority: Minor
> Fix For: Upcoming Branch, 18.12.13
>
>
> File lo4j2.xml configure log file rolling, but it does not appear to function 
> as perhaps intended.
> Log file rolling is configured to keep up to 10 log files. But the log file 
> naming convention appears to cause a maximum of 10 logs files to be kept for 
> each day.
> Rework the log4j2.xml configuration file to ensure that only 10 log files are 
> kept (for each appender) regardless of the date.
> Also, a limit of 1MB is quite small these days, particularly as text editors 
> can easily search through larger files without a noticeable performance 
> penalty (YMMV). I recommend raising the log file size limit to 10MB as this 
> would keep more log entries around without a corresponding increase in the 
> number of file.
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Closed] (OFBIZ-13096) Implement log rolling for access logs

2024-05-19 Thread Jacques Le Roux (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-13096?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux closed OFBIZ-13096.
---
  Assignee: Jacques Le Roux
Resolution: Fixed

Hi Daniel,

It was done with OFBIZ-13073. I also fixed the name with OFBIZ-13089

Thanks to care :)

> Implement log rolling for access logs
> -
>
> Key: OFBIZ-13096
> URL: https://issues.apache.org/jira/browse/OFBIZ-13096
> Project: OFBiz
>  Issue Type: Improvement
>Affects Versions: Upcoming Branch
>Reporter: Daniel Watford
>Assignee: Jacques Le Roux
>Priority: Minor
> Fix For: Upcoming Branch
>
>
> Similar to OFBIZ-12897, identify the component/configuration that affects 
> generation of access logs in the demo sites and introduce log rolling.
> OFBIZ-12897 introduced log rolling behaviour for the ofbiz and error logs, 
> but has not effect on the generation of access logs.
> Suitable log rolling of the access logs should be introduced so that we can 
> avoid needing to manually clean up these logs. In particular, this will help 
> with the maintenance of the demo sites.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Comment Edited] (OFBIZ-12897) Rework the log4j2.xml configuration to limit the number of log files generated

2024-05-19 Thread Jacques Le Roux (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-12897?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17847633#comment-17847633
 ] 

Jacques Le Roux edited comment on OFBIZ-12897 at 5/19/24 11:28 AM:
---

Hi Daniel,

Before we close here, I had a look at cleaning the demos logs. Nothing is 
needed in stable but next and trunk have a bunch of now old  \*2024\*.log 
files. I tried to remove them as ofbizdocker user but got a "Permission denied" 
error. They have been set has 166536 user properties. IIRW this is Docker. 
Could you remove them, maybe using docker-image.yaml or related? TIA


was (Author: jacques.le.roux):
Hi Daniel,

Before we close here, I had a look at cleaning the demos logs. Nothing is 
needed in stable but next and trunk have a bunch of now old  *2024*.log files. 
I tried to remove them as ofbizdocker user but got a "Permission denied" error. 
They have been set has 166536 user properties. IIRW this is Docker. Could you 
remove them, maybe using docker-image.yaml or related? TIA

> Rework the log4j2.xml configuration to limit the number of log files generated
> --
>
> Key: OFBIZ-12897
> URL: https://issues.apache.org/jira/browse/OFBIZ-12897
> Project: OFBiz
>  Issue Type: Task
>  Components: framework
>Affects Versions: Upcoming Branch, 18.12.11
>Reporter: Daniel Watford
>Assignee: Daniel Watford
>Priority: Minor
>
> File lo4j2.xml configure log file rolling, but it does not appear to function 
> as perhaps intended.
> Log file rolling is configured to keep up to 10 log files. But the log file 
> naming convention appears to cause a maximum of 10 logs files to be kept for 
> each day.
> Rework the log4j2.xml configuration file to ensure that only 10 log files are 
> kept (for each appender) regardless of the date.
> Also, a limit of 1MB is quite small these days, particularly as text editors 
> can easily search through larger files without a noticeable performance 
> penalty (YMMV). I recommend raising the log file size limit to 10MB as this 
> would keep more log entries around without a corresponding increase in the 
> number of file.
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (OFBIZ-12897) Rework the log4j2.xml configuration to limit the number of log files generated

2024-05-19 Thread Jacques Le Roux (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-12897?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17847665#comment-17847665
 ] 

Jacques Le Roux commented on OFBIZ-12897:
-

Thanks Daniel, no hurry.

> Rework the log4j2.xml configuration to limit the number of log files generated
> --
>
> Key: OFBIZ-12897
> URL: https://issues.apache.org/jira/browse/OFBIZ-12897
> Project: OFBiz
>  Issue Type: Task
>  Components: framework
>Affects Versions: Upcoming Branch, 18.12.11
>Reporter: Daniel Watford
>Assignee: Daniel Watford
>Priority: Minor
>
> File lo4j2.xml configure log file rolling, but it does not appear to function 
> as perhaps intended.
> Log file rolling is configured to keep up to 10 log files. But the log file 
> naming convention appears to cause a maximum of 10 logs files to be kept for 
> each day.
> Rework the log4j2.xml configuration file to ensure that only 10 log files are 
> kept (for each appender) regardless of the date.
> Also, a limit of 1MB is quite small these days, particularly as text editors 
> can easily search through larger files without a noticeable performance 
> penalty (YMMV). I recommend raising the log file size limit to 10MB as this 
> would keep more log entries around without a corresponding increase in the 
> number of file.
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (OFBIZ-13095) The non ASCII language in UiLabels.xml are not correctly handled during plugin creation

2024-05-19 Thread Jacques Le Roux (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-13095?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17847664#comment-17847664
 ] 

Jacques Le Roux commented on OFBIZ-13095:
-

Yes thanks, I remembered something about that but was unable to remember where. 
Anyway it's done now. It's committed but not yet pushed for other good reasons.
BTW, in such cases a good explanation in the Jira description can help... Will 
see later...

> The non ASCII language in UiLabels.xml are not correctly handled during 
> plugin creation
> ---
>
> Key: OFBIZ-13095
> URL: https://issues.apache.org/jira/browse/OFBIZ-13095
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: Gradle
>Affects Versions: 18.12.14
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Major
>
> You get this error:
> 2024-05-19 09:52:41,314 |jsse-nio-8443-exec-3 |UtilProperties
> |W| XML file for locale  could not be loaded.
> org.xml.sax.SAXParseException: Invalid byte 3 of 3-byte UTF-8 sequence.
> When removing ZH labels it works. We should keep only English languages or 
> amend the createPlugin Gradle task. In this issue I'll remove ZH labels and 
> put a comment as documentation about that for developers in 
> framework/resources/templates/UiLabels.xml



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (OFBIZ-13080) Duplicate main menu button after plugin creation

2024-05-19 Thread Jacques Le Roux (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-13080?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17847650#comment-17847650
 ] 

Jacques Le Roux commented on OFBIZ-13080:
-

Thans Sebastian,

I did not test in 18.12, I guess it's due to recent changes in trunk.

> Duplicate main menu button after plugin creation
> 
>
> Key: OFBIZ-13080
> URL: https://issues.apache.org/jira/browse/OFBIZ-13080
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: Gradle
>Affects Versions: Upcoming Branch
>Reporter: Sebastian Tschikin
>Assignee: Jacques Le Roux
>Priority: Minor
> Fix For: Upcoming Branch
>
>
> After creating a plugin with 'gradlew createPlugin -PpluginId=myplugin' there 
> is a duplicate main menu button in the backend menu of the new plugin.
> I am going to provide a fix for that.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Closed] (OFBIZ-13080) Duplicate main menu button after plugin creation

2024-05-19 Thread Jacques Le Roux (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-13080?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux closed OFBIZ-13080.
---
Resolution: Fixed

> Duplicate main menu button after plugin creation
> 
>
> Key: OFBIZ-13080
> URL: https://issues.apache.org/jira/browse/OFBIZ-13080
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: Gradle
>Affects Versions: Upcoming Branch
>Reporter: Sebastian Tschikin
>Assignee: Jacques Le Roux
>Priority: Minor
> Fix For: Upcoming Branch
>
>
> After creating a plugin with 'gradlew createPlugin -PpluginId=myplugin' there 
> is a duplicate main menu button in the backend menu of the new plugin.
> I am going to provide a fix for that.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Assigned] (OFBIZ-13080) Duplicate main menu button after plugin creation

2024-05-19 Thread Jacques Le Roux (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-13080?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux reassigned OFBIZ-13080:
---

  Component/s: Gradle
Fix Version/s: Upcoming Branch
Affects Version/s: Upcoming Branch
 Assignee: Jacques Le Roux  (was: Sebastian Tschikin)

> Duplicate main menu button after plugin creation
> 
>
> Key: OFBIZ-13080
> URL: https://issues.apache.org/jira/browse/OFBIZ-13080
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: Gradle
>Affects Versions: Upcoming Branch
>Reporter: Sebastian Tschikin
>Assignee: Jacques Le Roux
>Priority: Minor
> Fix For: Upcoming Branch
>
>
> After creating a plugin with 'gradlew createPlugin -PpluginId=myplugin' there 
> is a duplicate main menu button in the backend menu of the new plugin.
> I am going to provide a fix for that.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Updated] (OFBIZ-13080) Duplicate main menu button after plugin creation

2024-05-19 Thread Jacques Le Roux (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-13080?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux updated OFBIZ-13080:

Parent: OFBIZ-13094
Issue Type: Sub-task  (was: Bug)

> Duplicate main menu button after plugin creation
> 
>
> Key: OFBIZ-13080
> URL: https://issues.apache.org/jira/browse/OFBIZ-13080
> Project: OFBiz
>  Issue Type: Sub-task
>Reporter: Sebastian Tschikin
>Assignee: Sebastian Tschikin
>Priority: Minor
>
> After creating a plugin with 'gradlew createPlugin -PpluginId=myplugin' there 
> is a duplicate main menu button in the backend menu of the new plugin.
> I am going to provide a fix for that.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Updated] (OFBIZ-13095) The non ASCII language in UiLabels.xml are not correctly handled during plugin creation

2024-05-19 Thread Jacques Le Roux (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-13095?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux updated OFBIZ-13095:

Summary: The non ASCII language in UiLabels.xml are not correctly handled 
during plugin creation  (was: The non ASCII language in UiLabels.xml are not 
correctly handled during creation)

> The non ASCII language in UiLabels.xml are not correctly handled during 
> plugin creation
> ---
>
> Key: OFBIZ-13095
> URL: https://issues.apache.org/jira/browse/OFBIZ-13095
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: Gradle
>Affects Versions: 18.12.14
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Major
>
> You get this error:
> 2024-05-19 09:52:41,314 |jsse-nio-8443-exec-3 |UtilProperties
> |W| XML file for locale  could not be loaded.
> org.xml.sax.SAXParseException: Invalid byte 3 of 3-byte UTF-8 sequence.
> When removing ZH labels it works. We should keep only English languages or 
> amend the createPlugin Gradle task. In this issue I'll remove ZH labels and 
> put a comment as documentation about that for developers in 
> framework/resources/templates/UiLabels.xml



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Created] (OFBIZ-13095) The non ASCII language in UiLabels.xml are not correctly handled during creation

2024-05-19 Thread Jacques Le Roux (Jira)
Jacques Le Roux created OFBIZ-13095:
---

 Summary: The non ASCII language in UiLabels.xml are not correctly 
handled during creation
 Key: OFBIZ-13095
 URL: https://issues.apache.org/jira/browse/OFBIZ-13095
 Project: OFBiz
  Issue Type: Sub-task
  Components: Gradle
Affects Versions: 18.12.14
Reporter: Jacques Le Roux
Assignee: Jacques Le Roux


You get this error:

2024-05-19 09:52:41,314 |jsse-nio-8443-exec-3 |UtilProperties
|W| XML file for locale  could not be loaded.
org.xml.sax.SAXParseException: Invalid byte 3 of 3-byte UTF-8 sequence.

When removing ZH labels it works. We should keep only English languages or 
amend the createPlugin Gradle task. In this issue I'll remove ZH labels and put 
a comment as documentation about that for developers in 
framework/resources/templates/UiLabels.xml



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Updated] (OFBIZ-13094) Errors after creating a plugin

2024-05-19 Thread Jacques Le Roux (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-13094?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux updated OFBIZ-13094:

Description: This is a generic task to handle the multiple errors that 
happen after creating a plugin and trying to use it  (was: This is an generic 
task to handle the multiple errors that happen after creating a plugin and 
trying to use it)

> Errors after creating a plugin
> --
>
> Key: OFBIZ-13094
> URL: https://issues.apache.org/jira/browse/OFBIZ-13094
> Project: OFBiz
>  Issue Type: Bug
>  Components: Gradle
>Affects Versions: 18.12.14
>Reporter: Jacques Le Roux
>Priority: Major
>
> This is a generic task to handle the multiple errors that happen after 
> creating a plugin and trying to use it



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Created] (OFBIZ-13094) Errors after creating a plugin

2024-05-19 Thread Jacques Le Roux (Jira)
Jacques Le Roux created OFBIZ-13094:
---

 Summary: Errors after creating a plugin
 Key: OFBIZ-13094
 URL: https://issues.apache.org/jira/browse/OFBIZ-13094
 Project: OFBiz
  Issue Type: Bug
  Components: Gradle
Affects Versions: 18.12.14
Reporter: Jacques Le Roux


This is an generic task to handle the multiple errors that happen after 
creating a plugin and trying to use it



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Closed] (OFBIZ-8290) Disentangle unused Accounting labels

2024-05-19 Thread Jacques Le Roux (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-8290?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux closed OFBIZ-8290.
--
Fix Version/s: Upcoming Branch
   Resolution: Implemented

> Disentangle unused Accounting labels
> 
>
> Key: OFBIZ-8290
> URL: https://issues.apache.org/jira/browse/OFBIZ-8290
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: accounting
>Affects Versions: Trunk, Upcoming Branch
>Reporter: Pierre Smits
>Priority: Trivial
>  Labels: labels, refactoring
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-8290-AccountingUiLabels.xml.patch
>
>
> Disentanglement of unused labels from the accounting component makes the 
> component better.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Closed] (OFBIZ-10565) Clean Labels

2024-05-19 Thread Jacques Le Roux (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10565?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux closed OFBIZ-10565.
---
Fix Version/s: Upcoming Branch
 Assignee: Jacques Le Roux
   Resolution: Implemented

> Clean Labels
> 
>
> Key: OFBIZ-10565
> URL: https://issues.apache.org/jira/browse/OFBIZ-10565
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL COMPONENTS
>Affects Versions: Trunk, Upcoming Branch
>Reporter: Pierre Smits
>Assignee: Jacques Le Roux
>Priority: Minor
>  Labels: cleanup
> Fix For: Upcoming Branch
>
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> Labels get added when code changes are introduced. But it can also happen 
> that the (unused) label is forgotten while doing code clean-ups, refactoring 
> of the change before a patch submitted or a commit is executed. Or that 
> progressing insight leads to have the code change go into a different 
> component. Or that they came from a pre-ASF era and never got applied.
> This is an umbrella ticket, capturing (future) sub-tasks and should be 
> considered an ongoing effort to keep the code base as concise as possible.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Assigned] (OFBIZ-8290) Disentangle unused Accounting labels

2024-05-19 Thread Jacques Le Roux (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-8290?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux reassigned OFBIZ-8290:
--

Assignee: Jacques Le Roux

> Disentangle unused Accounting labels
> 
>
> Key: OFBIZ-8290
> URL: https://issues.apache.org/jira/browse/OFBIZ-8290
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: accounting
>Affects Versions: Trunk, Upcoming Branch
>Reporter: Pierre Smits
>Assignee: Jacques Le Roux
>Priority: Trivial
>  Labels: labels, refactoring
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-8290-AccountingUiLabels.xml.patch
>
>
> Disentanglement of unused labels from the accounting component makes the 
> component better.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Closed] (OFBIZ-8154) Some labels are considered not used by the Label Manager

2024-05-19 Thread Jacques Le Roux (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-8154?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux closed OFBIZ-8154.
--
Fix Version/s: Upcoming Branch
   Resolution: Implemented

> Some labels are considered not used by the Label Manager
> 
>
> Key: OFBIZ-8154
> URL: https://issues.apache.org/jira/browse/OFBIZ-8154
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: framework/webtools
>Affects Versions: Trunk, Upcoming Branch
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Minor
> Fix For: Upcoming Branch
>
>
> As I said in my r1759457 commit comment:
> bq. We have 5237 "Not Used Labels". I wondered if they were all real, I just 
> checked some an indeed, they were not used.  But there are also a huge bunch 
> of *.description.* labels which certainly make sense. I'll remove them from 
> the "Only Not Used Labels" result in another Jira I'll create
> Here is the promised Jira



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Assigned] (OFBIZ-8154) Some labels are considered not used by the Label Manager

2024-05-19 Thread Jacques Le Roux (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-8154?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux reassigned OFBIZ-8154:
--

Assignee: Jacques Le Roux

> Some labels are considered not used by the Label Manager
> 
>
> Key: OFBIZ-8154
> URL: https://issues.apache.org/jira/browse/OFBIZ-8154
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: framework/webtools
>Affects Versions: Trunk, Upcoming Branch
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Minor
>
> As I said in my r1759457 commit comment:
> bq. We have 5237 "Not Used Labels". I wondered if they were all real, I just 
> checked some an indeed, they were not used.  But there are also a huge bunch 
> of *.description.* labels which certainly make sense. I'll remove them from 
> the "Only Not Used Labels" result in another Jira I'll create
> Here is the promised Jira



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Closed] (OFBIZ-12951) CommonExt - Move from hard-code menu location to parameterized

2024-05-19 Thread Jacques Le Roux (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-12951?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux closed OFBIZ-12951.
---
Resolution: Implemented

> CommonExt - Move from hard-code menu location to parameterized
> --
>
> Key: OFBIZ-12951
> URL: https://issues.apache.org/jira/browse/OFBIZ-12951
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: commonext
>Affects Versions: Upcoming Branch
>Reporter: Pierre Smits
>Assignee: Jacques Le Roux
>Priority: Major
> Fix For: Upcoming Branch
>
> Attachments: Screenshot 2024-05-05 at 20.32.11.png, Screenshot 
> 2024-05-13 at 12.18.38.png
>
>
> Move the menu location in the various commonest screens from hard-coded to 
> parameterized.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (OFBIZ-12897) Rework the log4j2.xml configuration to limit the number of log files generated

2024-05-19 Thread Jacques Le Roux (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-12897?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17847633#comment-17847633
 ] 

Jacques Le Roux commented on OFBIZ-12897:
-

Hi Daniel,

Before we close here, I had a look at cleaning the demos logs. Nothing is 
needed in stable but next and trunk have a bunch of now old  *2024*.log files. 
I tried to remove them as ofbizdocker user but got a "Permission denied" error. 
They have been set has 166536 user properties. IIRW this is Docker. Could you 
remove them, maybe using docker-image.yaml or related? TIA

> Rework the log4j2.xml configuration to limit the number of log files generated
> --
>
> Key: OFBIZ-12897
> URL: https://issues.apache.org/jira/browse/OFBIZ-12897
> Project: OFBiz
>  Issue Type: Task
>  Components: framework
>Affects Versions: Upcoming Branch, 18.12.11
>Reporter: Daniel Watford
>Assignee: Daniel Watford
>Priority: Minor
>
> File lo4j2.xml configure log file rolling, but it does not appear to function 
> as perhaps intended.
> Log file rolling is configured to keep up to 10 log files. But the log file 
> naming convention appears to cause a maximum of 10 logs files to be kept for 
> each day.
> Rework the log4j2.xml configuration file to ensure that only 10 log files are 
> kept (for each appender) regardless of the date.
> Also, a limit of 1MB is quite small these days, particularly as text editors 
> can easily search through larger files without a noticeable performance 
> penalty (YMMV). I recommend raising the log file size limit to 10MB as this 
> would keep more log entries around without a corresponding increase in the 
> number of file.
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Updated] (OFBIZ-12391) Trustworthy OFBiz - audit capabilities

2024-05-19 Thread Jacques Le Roux (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-12391?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux updated OFBIZ-12391:

Fix Version/s: Upcoming Branch

> Trustworthy OFBiz - audit capabilities
> --
>
> Key: OFBIZ-12391
> URL: https://issues.apache.org/jira/browse/OFBIZ-12391
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL COMPONENTS, framework/entity
>Affects Versions: Trunk, Upcoming Branch
>Reporter: Pierre Smits
>Assignee: Pierre Smits
>Priority: Major
>  Labels: audit, entity, investigation, mvp, trust, usability
> Fix For: Upcoming Branch
>
>
> When potential adopters want to use OFBiz as their primary solution for 
> business critical ERP (and related) processes, they (or at least their 
> auditors) want to be sure that they can see:
>  # who created the record in the underlying rdbms,
>  # when that record was created,
>  # who was the last one to modify the record
>  # when the modification happened.
> Currently out of the 800+ entities defined in the various entity model files, 
> only a fraction of the entities have fields defined for
>  * createdDate (23)
>  * createdByUserLogin (30)
>  * lastModifiedDate (24)
>  * lastModifiedByUserLogin (29)
> which means that for crucial entities (for a business) in OFBiz entities 
> records can be created and changed (for nefarious reasons) without auditors 
> and other investigators being able to state anything regarding the above 4 
> points.
> Currently there are over 600 entity-auto services invoking 'create', and 
> approximately the same amount of services that invoke 'update', that could 
> automatically set the fields listed above. However it is not done, because 
> these have not been defined.
>  
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Closed] (OFBIZ-12391) Trustworthy OFBiz - audit capabilities

2024-05-19 Thread Jacques Le Roux (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-12391?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux closed OFBIZ-12391.
---
Resolution: Implemented

> Trustworthy OFBiz - audit capabilities
> --
>
> Key: OFBIZ-12391
> URL: https://issues.apache.org/jira/browse/OFBIZ-12391
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL COMPONENTS, framework/entity
>Affects Versions: Trunk, Upcoming Branch
>Reporter: Pierre Smits
>Assignee: Pierre Smits
>Priority: Major
>  Labels: audit, entity, investigation, mvp, trust, usability
>
> When potential adopters want to use OFBiz as their primary solution for 
> business critical ERP (and related) processes, they (or at least their 
> auditors) want to be sure that they can see:
>  # who created the record in the underlying rdbms,
>  # when that record was created,
>  # who was the last one to modify the record
>  # when the modification happened.
> Currently out of the 800+ entities defined in the various entity model files, 
> only a fraction of the entities have fields defined for
>  * createdDate (23)
>  * createdByUserLogin (30)
>  * lastModifiedDate (24)
>  * lastModifiedByUserLogin (29)
> which means that for crucial entities (for a business) in OFBiz entities 
> records can be created and changed (for nefarious reasons) without auditors 
> and other investigators being able to state anything regarding the above 4 
> points.
> Currently there are over 600 entity-auto services invoking 'create', and 
> approximately the same amount of services that invoke 'update', that could 
> automatically set the fields listed above. However it is not done, because 
> these have not been defined.
>  
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (OFBIZ-10476) Remove Compdoc functionality from content manager

2024-05-19 Thread Jacques Le Roux (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17847632#comment-17847632
 ] 

Jacques Le Roux commented on OFBIZ-10476:
-

Hi Michael,

Any chances for 18.12 before we release 18.12.14?

> Remove Compdoc functionality from content manager
> -
>
> Key: OFBIZ-10476
> URL: https://issues.apache.org/jira/browse/OFBIZ-10476
> Project: OFBiz
>  Issue Type: Improvement
>  Components: content
>Affects Versions: Release Branch 18.12, Trunk, Upcoming Branch
>Reporter: Dennis Balkir
>Assignee: Michael Brohl
>Priority: Major
>  Labels: backport-needed
>
> While creating a theme and looking for not correctly styled elements I came 
> across "some" not functional links and buttons in Compdoc.
> This module seems not to be finished or working properly, because most of the 
> times, the buttons inside the appbar produce errors or just empty pages.
> Even when searching for existing elements and then clicking on them to 
> examine or edit them will mostly create an error (example: go to compdoc, 
> search for template child, click edit on some random found element -> error).
> Sometimes the menu which is included inside the appbar, mostly the menu 
> called "tree", need the contentId for the buttons to work.
> Including this menu while creating a new entry will result in every button 
> not working and throwing an error, except the edit button, which will produce 
> a completely empty page.
> Those things appear all over the module, trying some button or clicking some 
> link resulted in an error screen more than it resulted in something actually 
> working.
> This should either be fixed or removed, if this doesn't has a real purpose at 
> all.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Closed] (OFBIZ-5170) Profiling OFBiz

2024-05-19 Thread Jacques Le Roux (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-5170?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux closed OFBIZ-5170.
--
Resolution: Implemented

> Profiling OFBiz
> ---
>
> Key: OFBIZ-5170
> URL: https://issues.apache.org/jira/browse/OFBIZ-5170
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL COMPONENTS
>Affects Versions: Trunk, Upcoming Branch
>Reporter: Adrian Crum
>Priority: Minor
> Attachments: HotSpotSettings.PNG, HotSpots_Rev_1464779.csv
>
>
> I will be using this issue to share the things I learn while profiling OFBiz 
> to study the impact of removing Javolution.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (OFBIZ-12951) CommonExt - Move from hard-code menu location to parameterized

2024-05-18 Thread Jacques Le Roux (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-12951?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17847568#comment-17847568
 ] 

Jacques Le Roux commented on OFBIZ-12951:
-

Hi Pierre,

It's not 79 but 795.

After applying this PR (795) as a patch in Eclipse I still get the same UI 
error message and this is in log running 
https://localhost:8443/ofbizsetup/control/login
2024-05-18 18:09:45,948 |jsse-nio-8443-exec-2 |ModelScreenWidget 
|E| Error rendering included menu named [MainActionMenu] at location 
[component://commonext/widget/ofbizsetup/Menus.xml]:
java.lang.IllegalArgumentException: Could not find menu with name 
[MainActionMenu] in location [component://commonext/widget/ofbizsetup/Menus.xml]
at 
org.apache.ofbiz.widget.model.MenuFactory.getMenuFromLocation(MenuFactory.java:122)
 ~[main/:?]

But then getting to https://localhost:8443/ofbizsetup/control/main works (all 
menus OK)

If I stop OFBiz and restart it, getting to https://localhost:8443/ofbizsetup 
fails again. But then using the visible menus works, weird. I did not get 
further.

> CommonExt - Move from hard-code menu location to parameterized
> --
>
> Key: OFBIZ-12951
> URL: https://issues.apache.org/jira/browse/OFBIZ-12951
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: commonext
>Affects Versions: Upcoming Branch
>Reporter: Pierre Smits
>Assignee: Jacques Le Roux
>Priority: Major
> Fix For: Upcoming Branch
>
> Attachments: Screenshot 2024-05-05 at 20.32.11.png, Screenshot 
> 2024-05-13 at 12.18.38.png
>
>
> Move the menu location in the various commonest screens from hard-coded to 
> parameterized.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Closed] (OFBIZ-12687) Installing OFBIZ.

2024-05-17 Thread Jacques Le Roux (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-12687?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux closed OFBIZ-12687.
---
  Assignee: Jacques Le Roux
Resolution: Information Provided

> Installing OFBIZ.
> -
>
> Key: OFBIZ-12687
> URL: https://issues.apache.org/jira/browse/OFBIZ-12687
> Project: OFBiz
>  Issue Type: Bug
>Reporter: raunak randhawa
>Assignee: Jacques Le Roux
>Priority: Major
> Attachments: image-2022-08-29-13-23-17-360.png, 
> image-2022-08-29-13-27-20-077.png, image-2022-08-29-14-29-21-246.png, 
> image-2022-08-29-14-33-53-234.png, image-2022-08-31-09-29-55-278.png
>
>
> OFBIZ verison 18.12.05:
> During the first step of installing the Gradle wrapper, it is returning the 
> an error. While running the init-gradle-wrapper as mentioned in the INSTALL 
> file but it returns an error.
> !image-2022-08-29-13-23-17-360.png!
>  
> !image-2022-08-29-14-29-21-246.png!
> Java Version:
> !image-2022-08-29-13-27-20-077.png!
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (OFBIZ-13077) Error when calling EntityQuery.from() with a dynamicView via groovy DSL

2024-05-15 Thread Jacques Le Roux (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-13077?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17846717#comment-17846717
 ] 

Jacques Le Roux commented on OFBIZ-13077:
-

Je ne vois pas de différence avec le trunk, donc pas besoin de backport :)

> Error when calling EntityQuery.from() with a dynamicView via groovy DSL
> ---
>
> Key: OFBIZ-13077
> URL: https://issues.apache.org/jira/browse/OFBIZ-13077
> Project: OFBiz
>  Issue Type: Bug
>  Components: ALL COMPONENTS
>Affects Versions: Upcoming Branch
>Reporter: Mekika Leila
>Assignee: Mekika Leila
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: DemoDataOFBIZ-13077.xml
>
>
> There is a "No signature of method " error when executing the script 
> FindInventoryItemsByLabels.groovy which use Groovy DSL syntax to call method 
> EntityQuery.from(DynamicViewEntity dve)
> This is due to the fact that the from() DSL is currently only defined for 
> calling the method with an entityName String.
> The purpose of this Jira is to add the Groovy DSL for 
> EntityQuery.from(DynamicViewEntity dve) so the FindInventoryItemsByLabels 
> will not fail and the dsl will be extended for other scripts
> *To reproduce*
> In a trunk ofbiz with demo data loaded, load file attached and go to 
> [SearchInventoryItemsByLabels 
> page|[https://localhost:8443/facility/control/SearchInventoryItemsByLabels?facilityId=WebStoreWarehouse]].
>  
> Then select 'Label test' and submit the search form



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (OFBIZ-13077) Error when calling EntityQuery.from() with a dynamicView via groovy DSL

2024-05-15 Thread Jacques Le Roux (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-13077?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17846715#comment-17846715
 ] 

Jacques Le Roux commented on OFBIZ-13077:
-

I'm not sure because I see no issue in log for 18.12 but I see no result on UI 
either.

> Error when calling EntityQuery.from() with a dynamicView via groovy DSL
> ---
>
> Key: OFBIZ-13077
> URL: https://issues.apache.org/jira/browse/OFBIZ-13077
> Project: OFBiz
>  Issue Type: Bug
>  Components: ALL COMPONENTS
>Affects Versions: Upcoming Branch
>Reporter: Mekika Leila
>Assignee: Mekika Leila
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: DemoDataOFBIZ-13077.xml
>
>
> There is a "No signature of method " error when executing the script 
> FindInventoryItemsByLabels.groovy which use Groovy DSL syntax to call method 
> EntityQuery.from(DynamicViewEntity dve)
> This is due to the fact that the from() DSL is currently only defined for 
> calling the method with an entityName String.
> The purpose of this Jira is to add the Groovy DSL for 
> EntityQuery.from(DynamicViewEntity dve) so the FindInventoryItemsByLabels 
> will not fail and the dsl will be extended for other scripts
> *To reproduce*
> In a trunk ofbiz with demo data loaded, load file attached and go to 
> [SearchInventoryItemsByLabels 
> page|[https://localhost:8443/facility/control/SearchInventoryItemsByLabels?facilityId=WebStoreWarehouse]].
>  
> Then select 'Label test' and submit the search form



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (OFBIZ-13077) Error when calling EntityQuery.from() with a dynamicView via groovy DSL

2024-05-15 Thread Jacques Le Roux (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-13077?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17846703#comment-17846703
 ] 

Jacques Le Roux commented on OFBIZ-13077:
-

Hi Leïla,

Should we not backport? I can do help if you want.

> Error when calling EntityQuery.from() with a dynamicView via groovy DSL
> ---
>
> Key: OFBIZ-13077
> URL: https://issues.apache.org/jira/browse/OFBIZ-13077
> Project: OFBiz
>  Issue Type: Bug
>  Components: ALL COMPONENTS
>Affects Versions: Upcoming Branch
>Reporter: Mekika Leila
>Assignee: Mekika Leila
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: DemoDataOFBIZ-13077.xml
>
>
> There is a "No signature of method " error when executing the script 
> FindInventoryItemsByLabels.groovy which use Groovy DSL syntax to call method 
> EntityQuery.from(DynamicViewEntity dve)
> This is due to the fact that the from() DSL is currently only defined for 
> calling the method with an entityName String.
> The purpose of this Jira is to add the Groovy DSL for 
> EntityQuery.from(DynamicViewEntity dve) so the FindInventoryItemsByLabels 
> will not fail and the dsl will be extended for other scripts
> *To reproduce*
> In a trunk ofbiz with demo data loaded, load file attached and go to 
> [SearchInventoryItemsByLabels 
> page|[https://localhost:8443/facility/control/SearchInventoryItemsByLabels?facilityId=WebStoreWarehouse]].
>  
> Then select 'Label test' and submit the search form



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


  1   2   3   4   5   6   7   8   9   10   >