[jira] [Comment Edited] (OFBIZ-7739) OFBIZ-7471: Improve all the service level error messages for missing required field for catalog component
[ https://issues.apache.org/jira/browse/OFBIZ-7739?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17092187#comment-17092187 ] Ratnesh Upadhyay edited comment on OFBIZ-7739 at 4/25/20, 11:44 AM: I quickly reviewed the patch and it looks good to me, thanks [~surajk] for the enhancement and patch for changes. was (Author: upadhyay.ratnesh): I quickly reviewed the patch and it looks to me, thanks [~surajk] for the enhancement and patch for changes. > OFBIZ-7471: Improve all the service level error messages for missing required > field for catalog component > - > > Key: OFBIZ-7739 > URL: https://issues.apache.org/jira/browse/OFBIZ-7739 > Project: OFBiz > Issue Type: Sub-task > Components: product >Affects Versions: 16.11.01 >Reporter: Ratnesh Upadhyay >Assignee: Suraj Khurana >Priority: Minor > Attachments: OFBIZ-7739.patch, OFBIZ-7739.patch > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Comment Edited] (OFBIZ-7739) OFBIZ-7471: Improve all the service level error messages for missing required field for catalog component
[ https://issues.apache.org/jira/browse/OFBIZ-7739?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17092187#comment-17092187 ] Ratnesh Upadhyay edited comment on OFBIZ-7739 at 4/25/20, 11:32 AM: I quickly reviewed the patch and it looks to me, thanks [~surajk] for the enhancement and patch for changes. was (Author: upadhyay.ratnesh): I quickly reviewed the patch and it looks to me, thanks [~surajk] for making all these changes. > OFBIZ-7471: Improve all the service level error messages for missing required > field for catalog component > - > > Key: OFBIZ-7739 > URL: https://issues.apache.org/jira/browse/OFBIZ-7739 > Project: OFBiz > Issue Type: Sub-task > Components: product >Affects Versions: 16.11.01 >Reporter: Ratnesh Upadhyay >Assignee: Suraj Khurana >Priority: Minor > Attachments: OFBIZ-7739.patch, OFBIZ-7739.patch > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-7739) OFBIZ-7471: Improve all the service level error messages for missing required field for catalog component
[ https://issues.apache.org/jira/browse/OFBIZ-7739?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17092187#comment-17092187 ] Ratnesh Upadhyay commented on OFBIZ-7739: - I quickly reviewed the patch and it looks to me, thanks [~surajk] for making all these changes. > OFBIZ-7471: Improve all the service level error messages for missing required > field for catalog component > - > > Key: OFBIZ-7739 > URL: https://issues.apache.org/jira/browse/OFBIZ-7739 > Project: OFBiz > Issue Type: Sub-task > Components: product >Affects Versions: 16.11.01 >Reporter: Ratnesh Upadhyay >Assignee: Suraj Khurana >Priority: Minor > Attachments: OFBIZ-7739.patch, OFBIZ-7739.patch > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (OFBIZ-11405) Create new quote button should be removed from new quote screen
Ratnesh Upadhyay created OFBIZ-11405: Summary: Create new quote button should be removed from new quote screen Key: OFBIZ-11405 URL: https://issues.apache.org/jira/browse/OFBIZ-11405 Project: OFBiz Issue Type: Improvement Components: order Affects Versions: Trunk Reporter: Ratnesh Upadhyay While reviewing OFBIZ-11221 noticed another issue. Steps to replicate the issue : * Go to ordermgr application. * On find quote screen clicks upon Create New Quote button. * System will navigate you to to create new quote screen. * On create new quote screen you will see Create New Quote button. It make sense on other menu/tab items of quote screen (as user can create new quote anytime from other quote screens) but it should not make any sense over create new quote screen. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11221) Wrong heading on creating quote under order component.
[ https://issues.apache.org/jira/browse/OFBIZ-11221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17042540#comment-17042540 ] Ratnesh Upadhyay commented on OFBIZ-11221: -- [~Pradyum] Thanks for your patch, I quickly reviewed your patch and I think instead of using common label you can use following, when there is quoteId present in parameters then display edit quote and if it is not present then display new quote. {code:java} {code} Please check and add the appropriate uiLabels for the same, if needed. Thanks! > Wrong heading on creating quote under order component. > -- > > Key: OFBIZ-11221 > URL: https://issues.apache.org/jira/browse/OFBIZ-11221 > Project: OFBiz > Issue Type: Bug > Components: order >Affects Versions: Trunk >Reporter: jai kumar raghuwanshi >Priority: Trivial > Attachments: OFBIZ-11221.patch, ordermgr.png > > > Steps to re-generate : > 1. Login with the username and password. > 2. Go to order component order. > 3. Click on Quotes > 4. Click on new quotes > Error: Edit quote is shown on the place of New quote. > Actual: New quote should be shown on the place of edit quote on UI. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-10974) Stock Watch List Report
[ https://issues.apache.org/jira/browse/OFBIZ-10974?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16827611#comment-16827611 ] Ratnesh Upadhyay commented on OFBIZ-10974: -- Thanks for your inputs [~pfm.smits]. No, we will not offer date filters it's always meant to return current stock/availability status against the listed products. To generate this report user has to select facility first. Currently this report is intended for merchandiser/sales manager/planners and if we move it to facility component then this set of role might not have the required permissions always. Thanks! > Stock Watch List Report > --- > > Key: OFBIZ-10974 > URL: https://issues.apache.org/jira/browse/OFBIZ-10974 > Project: OFBiz > Issue Type: New Feature > Components: product >Affects Versions: Trunk >Reporter: Ratnesh Upadhyay >Assignee: Ritesh Kumar >Priority: Major > > Add the Stock Watch List report to track the availability of items and > assortment. So that sales manager can keep a watch on current stock and sales > performance of all the product lines and can get their current inventory > status like Available, Low, Out of Stock and when the inbound shipment is > planned to receive. This information can help merchandiser to analyse > differentiation in fast moving and slow moving items. > Report should have following filters : > * User should be able to filter the report by availability status like > Available, Highly Available, Low, Out of Stock items. > * User should be able filter the products by category. > * User should be able to choose all or any of these filters to generate the > report. > Report Matrix should be- > lets say we have to product X in category Y in system that have multiple > variants like product-X has following size variants XS, S, M, L, XL in RED > colour.. And it also have same size variants in BLUE colour..then resultant > report should be like this.. > ||Product Name||XXS||XS||S||M||L||XL|| > ||Product-X (RED)||A||A+||L > ||O||A||A|| > ||Product-X (BLUE)||L||A||A+||A||O||L > || > > Availability Codes: > *(A) - Available* _i.e_. product has more number of quantity then safety > stock. > *(A+) - Highly Available* _i.e_ product has more number of quantities than > max limit. > *(L) - Low* _i.e._ product has less quantity than safety stock. > *(O) - Out of Stock* _i.e_ product is not in stock. > > Tagging [~swash78] -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (OFBIZ-10974) Stock Watch List Report
Ratnesh Upadhyay created OFBIZ-10974: Summary: Stock Watch List Report Key: OFBIZ-10974 URL: https://issues.apache.org/jira/browse/OFBIZ-10974 Project: OFBiz Issue Type: New Feature Components: product Affects Versions: Trunk Reporter: Ratnesh Upadhyay Add the Stock Watch List report to track the availability of items and assortment. So that sales manager can keep a watch on current stock and sales performance of all the product lines and can get their current inventory status like Available, Low, Out of Stock and when the inbound shipment is planned to receive. This information can help merchandiser to analyse differentiation in fast moving and slow moving items. Report should have following filters : * User should be able to filter the report by availability status like Available, Highly Available, Low, Out of Stock items. * User should be able filter the products by category. * User should be able to choose all or any of these filters to generate the report. Report Matrix should be- lets say we have to product X in category Y in system that have multiple variants like product-X has following size variants XS, S, M, L, XL in RED colour.. And it also have same size variants in BLUE colour..then resultant report should be like this.. ||Product Name||XXS||XS||S||M||L||XL|| ||Product-X (RED)||A||A+||L ||O||A||A|| ||Product-X (BLUE)||L||A||A+||A||O||L || Availability Codes: *(A) - Available* _i.e_. product has more number of quantity then safety stock. *(A+) - Highly Available* _i.e_ product has more number of quantities than max limit. *(L) - Low* _i.e._ product has less quantity than safety stock. *(O) - Out of Stock* _i.e_ product is not in stock. Tagging [~swash78] -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10859) Incorrect decorator being used over view all promotions and view promotion details screen causing back navigation
[ https://issues.apache.org/jira/browse/OFBIZ-10859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16816946#comment-16816946 ] Ratnesh Upadhyay commented on OFBIZ-10859: -- Thanks a lot [~rishisolankii]!! > Incorrect decorator being used over view all promotions and view promotion > details screen causing back navigation > - > > Key: OFBIZ-10859 > URL: https://issues.apache.org/jira/browse/OFBIZ-10859 > Project: OFBiz > Issue Type: Bug > Components: order >Affects Versions: Trunk >Reporter: Ratnesh Upadhyay >Assignee: Rishi Solanki >Priority: Major > Fix For: Upcoming Branch, Release Branch 17.12, Release Branch > 18.12 > > Attachments: OFBIZ-10859.patch > > > There is no back navigation available from view all promotions and show > promotion details screens instead it's showing cart and checkout options. > Steps to replicate the issue: > * Go to Order Manager > Order Entry > * Provide ordering details > * On create sales order screen, click upon 'View All Promotions' button > displayed under Special Offers button. > The same issue persist with _Adjustment_ - Promotion details button appeared > in order items section after adding GZ-2644 item to cart. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10857) Unable to 'Remove' the item from Shopping List
[ https://issues.apache.org/jira/browse/OFBIZ-10857?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16805825#comment-16805825 ] Ratnesh Upadhyay commented on OFBIZ-10857: -- Thanks [~swapnilmmane] for details, While reviewing other eCommerce screen I've also quickly verified that it's working as expected. I was successfully able to remove item from shopping list. [~Dikpal.Kanungo] Could you please let us know if you are experiencing this issue with any specific product? else we should be good to close this issue. Thanks! > Unable to 'Remove' the item from Shopping List > -- > > Key: OFBIZ-10857 > URL: https://issues.apache.org/jira/browse/OFBIZ-10857 > Project: OFBiz > Issue Type: Bug >Reporter: Dikpal Kanungo >Priority: Major > > Issue- > Unable to remove items from the Shopping list. > Expected- > When clicked on the remove button at Shopping List, the item should be > removed from the list > > Steps to regenerate- > Open the URL - [https://demo-trunk.ofbiz.apache.org/ecommerce/control/main] > Add the item to 'Shopping List' > Navigate to the Shopping list page and try removing the item. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10627) Submit button should not display when there is no item present over Quote Prices Screen
[ https://issues.apache.org/jira/browse/OFBIZ-10627?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16805747#comment-16805747 ] Ratnesh Upadhyay commented on OFBIZ-10627: -- Moved ticket to correct status, so that committers can review and push the changes, thanks [~Kumar Rahul]! > Submit button should not display when there is no item present over Quote > Prices Screen > --- > > Key: OFBIZ-10627 > URL: https://issues.apache.org/jira/browse/OFBIZ-10627 > Project: OFBiz > Issue Type: Improvement > Components: order >Affects Versions: Trunk >Reporter: Ratnesh Upadhyay >Priority: Major > Fix For: Trunk > > Attachments: OFBIZ-10627.patch, QuotePrices.png > > > Currently system is showing submit button even though there is no rows to > process. Ideally it should not display is there is nothing to submit. > Steps to replicate the issue: > * Create Quote from OrderMgr>Quotes screen. > * Navigate over Quote Prices Screen. > * In Quote Prices screenlet, here system is showing submit button even > though there is no quote items to process. > Please refer attached screenshot for quick details. > !QuotePrices.png! -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Assigned] (OFBIZ-10627) Submit button should not display when there is no item present over Quote Prices Screen
[ https://issues.apache.org/jira/browse/OFBIZ-10627?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ratnesh Upadhyay reassigned OFBIZ-10627: Assignee: (was: Kumar Rahul) > Submit button should not display when there is no item present over Quote > Prices Screen > --- > > Key: OFBIZ-10627 > URL: https://issues.apache.org/jira/browse/OFBIZ-10627 > Project: OFBiz > Issue Type: Improvement > Components: order >Affects Versions: Trunk >Reporter: Ratnesh Upadhyay >Priority: Major > Fix For: Trunk > > Attachments: OFBIZ-10627.patch, QuotePrices.png > > > Currently system is showing submit button even though there is no rows to > process. Ideally it should not display is there is nothing to submit. > Steps to replicate the issue: > * Create Quote from OrderMgr>Quotes screen. > * Navigate over Quote Prices Screen. > * In Quote Prices screenlet, here system is showing submit button even > though there is no quote items to process. > Please refer attached screenshot for quick details. > !QuotePrices.png! -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-7517) Checkbox and Radio buttons should get selected on clicking upon their labels.
[ https://issues.apache.org/jira/browse/OFBIZ-7517?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16805744#comment-16805744 ] Ratnesh Upadhyay commented on OFBIZ-7517: - Closing parent ticket as all the sub-tasks has been closed, thanks! > Checkbox and Radio buttons should get selected on clicking upon their labels. > - > > Key: OFBIZ-7517 > URL: https://issues.apache.org/jira/browse/OFBIZ-7517 > Project: OFBiz > Issue Type: Improvement > Components: ALL APPLICATIONS >Affects Versions: 16.11.01 >Reporter: Ratnesh Upadhyay >Assignee: Divesh Dutta >Priority: Major > > This is a placeholder ticket to change the interaction of check box and radio > button. We will create application wise sub task. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Closed] (OFBIZ-7517) Checkbox and Radio buttons should get selected on clicking upon their labels.
[ https://issues.apache.org/jira/browse/OFBIZ-7517?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ratnesh Upadhyay closed OFBIZ-7517. --- Resolution: Fixed > Checkbox and Radio buttons should get selected on clicking upon their labels. > - > > Key: OFBIZ-7517 > URL: https://issues.apache.org/jira/browse/OFBIZ-7517 > Project: OFBiz > Issue Type: Improvement > Components: ALL APPLICATIONS >Affects Versions: 16.11.01 >Reporter: Ratnesh Upadhyay >Assignee: Divesh Dutta >Priority: Major > > This is a placeholder ticket to change the interaction of check box and radio > button. We will create application wise sub task. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10859) Incorrect decorator being used over view all promotions and view promotion details screen causing back navigation
[ https://issues.apache.org/jira/browse/OFBIZ-10859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16788665#comment-16788665 ] Ratnesh Upadhyay commented on OFBIZ-10859: -- The issue is causing due to incorrect decorator used upon **showAllPromotions and showPromotionDetails. Patch attached to fix the issue. > Incorrect decorator being used over view all promotions and view promotion > details screen causing back navigation > - > > Key: OFBIZ-10859 > URL: https://issues.apache.org/jira/browse/OFBIZ-10859 > Project: OFBiz > Issue Type: Bug > Components: order >Affects Versions: Trunk >Reporter: Ratnesh Upadhyay >Assignee: Ratnesh Upadhyay >Priority: Major > Attachments: OFBIZ-10859.patch > > > There is no back navigation available from view all promotions and show > promotion details screens instead it's showing cart and checkout options. > Steps to replicate the issue: > * Go to Order Manager > Order Entry > * Provide ordering details > * On create sales order screen, click upon 'View All Promotions' button > displayed under Special Offers button. > The same issue persist with _Adjustment_ - Promotion details button appeared > in order items section after adding GZ-2644 item to cart. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Comment Edited] (OFBIZ-10859) Incorrect decorator being used over view all promotions and view promotion details screen causing back navigation
[ https://issues.apache.org/jira/browse/OFBIZ-10859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16788665#comment-16788665 ] Ratnesh Upadhyay edited comment on OFBIZ-10859 at 3/9/19 1:01 PM: -- The issue is causing due to incorrect decorator used upon "showAllPromotions" and "showPromotionDetails". Patch attached to fix the issue. was (Author: upadhyay.ratnesh): The issue is causing due to incorrect decorator used upon **showAllPromotions and showPromotionDetails. Patch attached to fix the issue. > Incorrect decorator being used over view all promotions and view promotion > details screen causing back navigation > - > > Key: OFBIZ-10859 > URL: https://issues.apache.org/jira/browse/OFBIZ-10859 > Project: OFBiz > Issue Type: Bug > Components: order >Affects Versions: Trunk >Reporter: Ratnesh Upadhyay >Assignee: Ratnesh Upadhyay >Priority: Major > Attachments: OFBIZ-10859.patch > > > There is no back navigation available from view all promotions and show > promotion details screens instead it's showing cart and checkout options. > Steps to replicate the issue: > * Go to Order Manager > Order Entry > * Provide ordering details > * On create sales order screen, click upon 'View All Promotions' button > displayed under Special Offers button. > The same issue persist with _Adjustment_ - Promotion details button appeared > in order items section after adding GZ-2644 item to cart. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OFBIZ-10859) Incorrect decorator being used over view all promotions and view promotion details screen causing back navigation
[ https://issues.apache.org/jira/browse/OFBIZ-10859?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ratnesh Upadhyay updated OFBIZ-10859: - Attachment: OFBIZ-10859.patch > Incorrect decorator being used over view all promotions and view promotion > details screen causing back navigation > - > > Key: OFBIZ-10859 > URL: https://issues.apache.org/jira/browse/OFBIZ-10859 > Project: OFBiz > Issue Type: Bug > Components: order >Affects Versions: Trunk >Reporter: Ratnesh Upadhyay >Assignee: Ratnesh Upadhyay >Priority: Major > Attachments: OFBIZ-10859.patch > > > There is no back navigation available from view all promotions and show > promotion details screens instead it's showing cart and checkout options. > Steps to replicate the issue: > * Go to Order Manager > Order Entry > * Provide ordering details > * On create sales order screen, click upon 'View All Promotions' button > displayed under Special Offers button. > The same issue persist with _Adjustment_ - Promotion details button appeared > in order items section after adding GZ-2644 item to cart. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OFBIZ-10859) Incorrect decorator being used over view all promotions and view promotion details screen causing back navigation
[ https://issues.apache.org/jira/browse/OFBIZ-10859?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ratnesh Upadhyay updated OFBIZ-10859: - Environment: (was: There is no back navigation available from view all promotions and show promotion details screens instead it's showing cart and checkout options. Steps to replicate the issue: * Go to Order Manager > Order Entry * Provide ordering details * On create sales order screen, click upon 'View All Promotions' button displayed under Special Offers button. The same issue persist with _Adjustment_ - Promotion details button appeared in order items section after adding GZ-2644 item to cart.) Description: There is no back navigation available from view all promotions and show promotion details screens instead it's showing cart and checkout options. Steps to replicate the issue: * Go to Order Manager > Order Entry * Provide ordering details * On create sales order screen, click upon 'View All Promotions' button displayed under Special Offers button. The same issue persist with _Adjustment_ - Promotion details button appeared in order items section after adding GZ-2644 item to cart. > Incorrect decorator being used over view all promotions and view promotion > details screen causing back navigation > - > > Key: OFBIZ-10859 > URL: https://issues.apache.org/jira/browse/OFBIZ-10859 > Project: OFBiz > Issue Type: Bug > Components: order >Affects Versions: Trunk >Reporter: Ratnesh Upadhyay >Assignee: Ratnesh Upadhyay >Priority: Major > > There is no back navigation available from view all promotions and show > promotion details screens instead it's showing cart and checkout options. > Steps to replicate the issue: > * Go to Order Manager > Order Entry > * Provide ordering details > * On create sales order screen, click upon 'View All Promotions' button > displayed under Special Offers button. > The same issue persist with _Adjustment_ - Promotion details button appeared > in order items section after adding GZ-2644 item to cart. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (OFBIZ-10859) Incorrect decorator being used over view all promotions and view promotion details screen causing back navigation
Ratnesh Upadhyay created OFBIZ-10859: Summary: Incorrect decorator being used over view all promotions and view promotion details screen causing back navigation Key: OFBIZ-10859 URL: https://issues.apache.org/jira/browse/OFBIZ-10859 Project: OFBiz Issue Type: Bug Components: order Affects Versions: Trunk Environment: There is no back navigation available from view all promotions and show promotion details screens instead it's showing cart and checkout options. Steps to replicate the issue: * Go to Order Manager > Order Entry * Provide ordering details * On create sales order screen, click upon 'View All Promotions' button displayed under Special Offers button. The same issue persist with _Adjustment_ - Promotion details button appeared in order items section after adding GZ-2644 item to cart. Reporter: Ratnesh Upadhyay Assignee: Ratnesh Upadhyay -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Comment Edited] (OFBIZ-10795) Product dropdown should be replaced with product lookup on Edit Price Rule screen
[ https://issues.apache.org/jira/browse/OFBIZ-10795?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16788513#comment-16788513 ] Ratnesh Upadhyay edited comment on OFBIZ-10795 at 3/9/19 6:05 AM: -- Thanks [~jacques.le.roux] for your inputs. IMO, we can add checks for party, product and party group member options, if the list size is grater then 20 then we will replace dropdown with lookup instead of replacing it for all the options OR using lookup for these options always. [~pradeep.choudhary1994] please check if this solution works for this case and there is no conflict with dependent select feature. was (Author: upadhyay.ratnesh): Thanks [~jacques.le.roux] for your inputs. IMO, we can add checks for party, product and party group member options, if the list size is grater then 20 then we will replace dropdown with lookup instead of replacing them for all the options or using lookup for these fields always. [~pradeep.choudhary1994] please check if this solution works for this case and there is no conflict with dependent select feature. > Product dropdown should be replaced with product lookup on Edit Price Rule > screen > - > > Key: OFBIZ-10795 > URL: https://issues.apache.org/jira/browse/OFBIZ-10795 > Project: OFBiz > Issue Type: Improvement > Components: product >Affects Versions: Trunk, Release Branch 16.11, Release Branch 17.12 >Reporter: Mohammad Kathawala >Assignee: Pradeep Choudhary >Priority: Minor > Fix For: Trunk, Release Branch 16.11, Release Branch 17.12 > > > On Edit Price Rule screen, all the products of the system are fetched in a > single dropdown. > If a system has thousands or more products, then it will take too much time > to load those products in the dropdown and screen loading time will increase > or even it can make the system down. > > We should have a product lookup here. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10795) Product dropdown should be replaced with product lookup on Edit Price Rule screen
[ https://issues.apache.org/jira/browse/OFBIZ-10795?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16788513#comment-16788513 ] Ratnesh Upadhyay commented on OFBIZ-10795: -- Thanks [~jacques.le.roux] for your inputs. IMO, we can add checks for party, product and party group member options, if the list size is grater then 20 then we will replace dropdown with lookup instead of replacing them for all the options or using lookup for these fields always. [~pradeep.choudhary1994] please check if this solution works for this case and there is no conflict with dependent select feature. > Product dropdown should be replaced with product lookup on Edit Price Rule > screen > - > > Key: OFBIZ-10795 > URL: https://issues.apache.org/jira/browse/OFBIZ-10795 > Project: OFBiz > Issue Type: Improvement > Components: product >Affects Versions: Trunk, Release Branch 16.11, Release Branch 17.12 >Reporter: Mohammad Kathawala >Assignee: Pradeep Choudhary >Priority: Minor > Fix For: Trunk, Release Branch 16.11, Release Branch 17.12 > > > On Edit Price Rule screen, all the products of the system are fetched in a > single dropdown. > If a system has thousands or more products, then it will take too much time > to load those products in the dropdown and screen loading time will increase > or even it can make the system down. > > We should have a product lookup here. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-7456) Introduce the option to add the new Customer/Supplier while placing the quotes in system if they don't exist already
[ https://issues.apache.org/jira/browse/OFBIZ-7456?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16727404#comment-16727404 ] Ratnesh Upadhyay commented on OFBIZ-7456: - FYI, As per the discussion with [~swash78] We have to only facilitate to add party group from quote screen. Also we can update shipping and billing address later on from party manager application. > Introduce the option to add the new Customer/Supplier while placing the > quotes in system if they don't exist already > > > Key: OFBIZ-7456 > URL: https://issues.apache.org/jira/browse/OFBIZ-7456 > Project: OFBiz > Issue Type: New Feature > Components: order >Affects Versions: 14.12.01, 15.12.01 >Reporter: Swapnil Shah >Assignee: Pradeep Choudhary >Priority: Major > > On numerous occasions while placing Sales or Purchase quote in system, the > business is conducted first time with given party and its quite possible that > given party don't pre-exist in system. > At that point of time user could be allowed to create the party in either > Customer or Supplier role by asking few primary details as follows: > # Party Name > # Billing/Shipping Address > Rest of the details can be later added/update with respect to added party > from Party screens. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (OFBIZ-10667) User should redirect to view cart page after adding the product from compare product screen
Ratnesh Upadhyay created OFBIZ-10667: Summary: User should redirect to view cart page after adding the product from compare product screen Key: OFBIZ-10667 URL: https://issues.apache.org/jira/browse/OFBIZ-10667 Project: OFBiz Issue Type: Bug Components: ecommerce Affects Versions: Trunk Reporter: Ratnesh Upadhyay Assignee: Kumar Rahul Currently user is navigating add item page instead of view cart page while adding product to cart from compare product screen. User gets stuck after navigating over add item page. Steps to replicate the issue: 1. Go to eCommerce application. 2. Click on add to compare button for the products - Round Gizmo and Tiny Chrome Widget. 3. Click on 'Compare Products' from right bar. 4. Click on 'Add to cart' over compare product screen. Expected behaviour : User should be redirected to view cart page instead of add item page. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10663) Amount field is editable at Product Detail Page
[ https://issues.apache.org/jira/browse/OFBIZ-10663?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16697689#comment-16697689 ] Ratnesh Upadhyay commented on OFBIZ-10663: -- [~Dikpal.Kanungo] Thanks for raising the issue, I have quickly reviewed the issue and to me it seems that the amount field should be applicable for gift card products only and it should appear when user choose the other amount option OR user want to reload existing gift card with different amount. I think we can modify the current implementation to show amount field for digital good type products OR gift card products only to resolve this issue. I hope it helps! > Amount field is editable at Product Detail Page > --- > > Key: OFBIZ-10663 > URL: https://issues.apache.org/jira/browse/OFBIZ-10663 > Project: OFBiz > Issue Type: Bug > Components: ecommerce >Reporter: Dikpal Kanungo >Priority: Major > Attachments: Editable amount.png, Missing Heading.png > > > The customer is able to enter the price of a product from the product detail > page which should not happen. > Steps to regenerate- > Open - ofbiz demo trunk for ecomm. > Click on the product - Tiny Gizmo > Try editing the Amount field. > -- > Click on product - .NIT Gizmo > Quantity text is missing and No value is coming in reference to Amount > heading. > Please have a look at the attached screenshots. > Cheers, > Dikpal !Missing Heading.png! > > > > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OFBIZ-10630) eCommerce - Return History Feature
[ https://issues.apache.org/jira/browse/OFBIZ-10630?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ratnesh Upadhyay updated OFBIZ-10630: - Description: While walk though the eCommerce application, noticed that we have Order History section there but we don't have Return History. So based upon community's approval we have to add support for "Return History" feature in eCommerce application. Items needs to be implemented under this ticket : - Add new navigation for return history. - Display list of returns submitted by the customer along with basic details. - Customer should be able to view return details by clicking upon view link OR returnID. Thanks to all the members for the discussion and approval. was: While walk though the eCommerce application, noticed that we have Order History section there but we don't have Return History. So based upon community's approval we have to add support for "Return History" feature in eCommerce application. Items needs to be implemented under this ticket : - Add new navigation for return history. - Display list of returns submitted by the customer along with basic details. - Customer should be able to view return details by clicking upon view link OR returnID. Thanks to all the members for the discussion and approval. > eCommerce - Return History Feature > -- > > Key: OFBIZ-10630 > URL: https://issues.apache.org/jira/browse/OFBIZ-10630 > Project: OFBiz > Issue Type: New Feature > Components: ecommerce >Affects Versions: Trunk >Reporter: Ratnesh Upadhyay >Assignee: Ratnesh Upadhyay >Priority: Major > Fix For: Trunk > > > While walk though the eCommerce application, noticed that we have Order > History section there but we don't have Return History. So based upon > community's approval we have to add support for "Return History" feature in > eCommerce application. > Items needs to be implemented under this ticket : > - Add new navigation for return history. > - Display list of returns submitted by the customer along with basic details. > - Customer should be able to view return details by clicking upon view link > OR returnID. > > Thanks to all the members for the discussion and approval. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (OFBIZ-10630) eCommerce - Return History Feature
Ratnesh Upadhyay created OFBIZ-10630: Summary: eCommerce - Return History Feature Key: OFBIZ-10630 URL: https://issues.apache.org/jira/browse/OFBIZ-10630 Project: OFBiz Issue Type: New Feature Components: ecommerce Affects Versions: Trunk Reporter: Ratnesh Upadhyay Assignee: Ratnesh Upadhyay Fix For: Trunk While walk though the eCommerce application, noticed that we have Order History section there but we don't have Return History. So based upon community's approval we have to add support for "Return History" feature in eCommerce application. Items needs to be implemented under this ticket : - Add new navigation for return history. - Display list of returns submitted by the customer along with basic details. - Customer should be able to view return details by clicking upon view link OR returnID. Thanks to all the members for the discussion and approval. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Assigned] (OFBIZ-10627) Submit button should not display when there is no item present over Quote Prices Screen
[ https://issues.apache.org/jira/browse/OFBIZ-10627?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ratnesh Upadhyay reassigned OFBIZ-10627: Assignee: kumar Rahul (was: Ratnesh Upadhyay) > Submit button should not display when there is no item present over Quote > Prices Screen > --- > > Key: OFBIZ-10627 > URL: https://issues.apache.org/jira/browse/OFBIZ-10627 > Project: OFBiz > Issue Type: Improvement > Components: order >Affects Versions: Trunk >Reporter: Ratnesh Upadhyay >Assignee: kumar Rahul >Priority: Major > Fix For: Trunk > > Attachments: QuotePrices.png > > > Currently system is showing submit button even though there is no rows to > process. Ideally it should not display is there is nothing to submit. > Steps to replicate the issue: > * Create Quote from OrderMgr>Quotes screen. > * Navigate over Quote Prices Screen. > * In Quote Prices screenlet, here system is showing submit button even > though there is no quote items to process. > Please refer attached screenshot for quick details. > !QuotePrices.png! -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (OFBIZ-10627) Submit button should not display when there is no item present over Quote Prices Screen
Ratnesh Upadhyay created OFBIZ-10627: Summary: Submit button should not display when there is no item present over Quote Prices Screen Key: OFBIZ-10627 URL: https://issues.apache.org/jira/browse/OFBIZ-10627 Project: OFBiz Issue Type: Improvement Components: order Affects Versions: Trunk Reporter: Ratnesh Upadhyay Assignee: Ratnesh Upadhyay Fix For: Trunk Attachments: QuotePrices.png Currently system is showing submit button even though there is no rows to process. Ideally it should not display is there is nothing to submit. Steps to replicate the issue: * Create Quote from OrderMgr>Quotes screen. * Navigate over Quote Prices Screen. * In Quote Prices screenlet, here system is showing submit button even though there is no quote items to process. Please refer attached screenshot for quick details. !QuotePrices.png! -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10387) Error on eCommerce Request Return Screen
[ https://issues.apache.org/jira/browse/OFBIZ-10387?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16457613#comment-16457613 ] Ratnesh Upadhyay commented on OFBIZ-10387: -- Soon, I'll provide patch to fix the reported issue. > Error on eCommerce Request Return Screen > > > Key: OFBIZ-10387 > URL: https://issues.apache.org/jira/browse/OFBIZ-10387 > Project: OFBiz > Issue Type: Bug > Components: ecommerce >Affects Versions: Trunk >Reporter: Ratnesh Upadhyay >Assignee: Ratnesh Upadhyay >Priority: Major > Attachments: RequestReturn.png > > > While browsing eCommerce application noticed following error on return > request screen. > {code:java} > An error has occurred when reading existing sub-variable "orderAdjustmentId"; > see cause exception! The type of the containing value was: > extended_hash+method+string (org.apache.ofbiz.entity.GenericValue wrapped > into f.e.b.MapModel) FTL stack trace ("~" means nesting-related): - > Failed at: #if !orderItem.orderAdjustmentId?has_... [in template > "component://ecommerce/template/order/RequestReturn.ftl" at line 60, column > 15] An error has occurred when reading existing sub-variable > "orderAdjustmentId"; see cause exception! The type of the containing value > was: extended_hash+method+string (org.apache.ofbiz.entity.GenericValue > wrapped into f.e.b.MapModel) FTL stack trace ("~" means > nesting-related): - Failed at: #if !orderItem.orderAdjustmentId?has_... [in > template "component://ecommerce/template/order/RequestReturn.ftl" at line 60, > column 15] An error has occurred when reading existing sub-variable > "orderAdjustmentId"; see cause exception! The type of the containing value > was: extended_hash+method+string (org.apache.ofbiz.entity.GenericValue > wrapped into f.e.b.MapModel) FTL stack trace ("~" means > nesting-related): - Failed at: #if !orderItem.orderAdjustmentId?has_... [in > template "component://ecommerce/template/order/RequestReturn.ftl" at line 60, > column 15] > } > {code} > Steps to replicate reported issue: > prerequisite : You should have completed order for demo customer in system. > 1. login to eCommerce application with DemoCustomer. > 2. Click upon Order History link displaying in top navigation bar. > 3. Click upon View button displaying against orders under order history > section. > 4. Click upon Request Return link to initiate return. > 5. You will see the reported error in Return Items section. > Please refer attached screenshot for further reference. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (OFBIZ-10387) Error on eCommerce Request Return Screen
Ratnesh Upadhyay created OFBIZ-10387: Summary: Error on eCommerce Request Return Screen Key: OFBIZ-10387 URL: https://issues.apache.org/jira/browse/OFBIZ-10387 Project: OFBiz Issue Type: Bug Components: ecommerce Affects Versions: Trunk Reporter: Ratnesh Upadhyay Assignee: Ratnesh Upadhyay Attachments: RequestReturn.png While browsing eCommerce application noticed following error on return request screen. {code:java} An error has occurred when reading existing sub-variable "orderAdjustmentId"; see cause exception! The type of the containing value was: extended_hash+method+string (org.apache.ofbiz.entity.GenericValue wrapped into f.e.b.MapModel) FTL stack trace ("~" means nesting-related): - Failed at: #if !orderItem.orderAdjustmentId?has_... [in template "component://ecommerce/template/order/RequestReturn.ftl" at line 60, column 15] An error has occurred when reading existing sub-variable "orderAdjustmentId"; see cause exception! The type of the containing value was: extended_hash+method+string (org.apache.ofbiz.entity.GenericValue wrapped into f.e.b.MapModel) FTL stack trace ("~" means nesting-related): - Failed at: #if !orderItem.orderAdjustmentId?has_... [in template "component://ecommerce/template/order/RequestReturn.ftl" at line 60, column 15] An error has occurred when reading existing sub-variable "orderAdjustmentId"; see cause exception! The type of the containing value was: extended_hash+method+string (org.apache.ofbiz.entity.GenericValue wrapped into f.e.b.MapModel) FTL stack trace ("~" means nesting-related): - Failed at: #if !orderItem.orderAdjustmentId?has_... [in template "component://ecommerce/template/order/RequestReturn.ftl" at line 60, column 15] } {code} Steps to replicate reported issue: prerequisite : You should have completed order for demo customer in system. 1. login to eCommerce application with DemoCustomer. 2. Click upon Order History link displaying in top navigation bar. 3. Click upon View button displaying against orders under order history section. 4. Click upon Request Return link to initiate return. 5. You will see the reported error in Return Items section. Please refer attached screenshot for further reference. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (OFBIZ-10208) Error on Add Item to Shopping List Screen
Ratnesh Upadhyay created OFBIZ-10208: Summary: Error on Add Item to Shopping List Screen Key: OFBIZ-10208 URL: https://issues.apache.org/jira/browse/OFBIZ-10208 Project: OFBiz Issue Type: Bug Components: party Affects Versions: 16.11.04 Reporter: Ratnesh Upadhyay While working on 16.11 branch, I noticed error when I try to add an item into shopping cart. Here are the steps to replicate the issue: # Go to Party Manager. # Select customer to navigate over profile page. # Click upon Shopping Lists tab. # Create new shopping list, if no one is persist. # Add an item to existing/new shopping list. As soon as you click to add on item you will see following error in list item and quick add to shopping list sections. {code:java} The following has evaluated to null or missing: ==> renderNextPrev [in template "component://common/template/includes/HtmlTemplate.ftl" at line 66, column 5] Tip: If the failing expression is known to be legally refer to something that's sometimes null or missing, either specify a default value like myOptionalVar!myDefault, or use <#if myOptionalVar??>when-present<#else>when-missing. (These only cover the last step of the expression; to cover the whole expression, use parenthesis: (myOptionalVar.foo)!myDefault, (myOptionalVar.foo)?? FTL stack trace ("~" means nesting-related): - Failed at: @renderNextPrev paginateStyle, pagina... [in template "component://common/template/includes/HtmlTemplate.ftl" in macro "nextPrev" at line 66, column 3] - Reached through: @nextPrev commonUrl=commonUrl ajaxEna... [in template "component://party/template/party/EditShoppingList.ftl" at line 187, column 9] {code} -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10171) Implement and Apply Return Lookup
[ https://issues.apache.org/jira/browse/OFBIZ-10171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16342153#comment-16342153 ] Ratnesh Upadhyay commented on OFBIZ-10171: -- [~yogesh.naroliya] Many thanks for verification and sharing detailed results. > Implement and Apply Return Lookup > - > > Key: OFBIZ-10171 > URL: https://issues.apache.org/jira/browse/OFBIZ-10171 > Project: OFBiz > Issue Type: New Feature > Components: order, party >Affects Versions: Trunk >Reporter: Ratnesh Upadhyay >Assignee: Rishi Solanki >Priority: Major > Attachments: OFBIZ-10171-ReturnLookup-FindResult-InvScreen.png, > OFBIZ-10171-ReturnLookup-Optn-CommScreen.png, > OFBIZ-10171-ReturnLookup-Optn-InvScreen.png, > OFBIZ-10171-ReturnLookup-Popup-CommScreen.png, > OFBIZ-10171-ReturnLookup-Popup-InvScreen.png, > OFBIZ-10171-ReturnLookup-SearchResult.png, > OFBIZ-10171-ReturnLookup-SetField-CommScreen.png, > OFBIZ-10171-ReturnLookup-SetField-InvScreen.png, OFBIZ-10171.patch > > > Implement Return Lookup and embed it over related forms where we need to > lookup return and set selected return information over form. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10171) Implement and Apply Return Lookup
[ https://issues.apache.org/jira/browse/OFBIZ-10171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16342119#comment-16342119 ] Ratnesh Upadhyay commented on OFBIZ-10171: -- *Closure Template:* Implemented new feature on trunk and provided patch to push the changes. *High Level Technical Summary:* 1. Implemented new screen LookupReturnHeader with lookup decorator pattern. 2. Implemented LookupReturnHeader and ListLookupReturnHeader forms to search and list return records to use further. 3. Used ReturnHeader, ReturnHeaderType, StatusItem and other related entities to filter and list returns. 4. Used performFind to fetch return records based upon supplied parameters. 5. Added required controller and view maps to render lookup form. 6. Applied newly implemented return lookup over AddCommReturn and SearchInventoryItemsDetailsParams forms. *Unit Testing:* 1. Verified that return lookup form is fetching return records based upon supplied fields. 2. Verified that return lookup is working as expected over add communication event to return form. 3. Verified that return lookup is working as expected over inventory item details screen. *Steps to test the feature :* *Applied on Add Communication Event Return Screen* 1. Go Party Manager > Communications > Find Communication > Select a CommunicationEventId 2. User landed on View Communication Event screen as soon as clicked upon any CommunicationEvent listed in result list. 3. Click upon Return Tab displayed over Communication Event Overview page to add selected communication with existing return. 4. You will see add communication to return form with return lookup. 5. Find return by returnId or select return from list displayed under return lookup form to add it with selected communication event. *Applied on Inventory Item Details Screen* 1.Create a sales order and complete it. 2. Create a return against this order in accepted status. 3. Go to Facility Manager > Select facility > Receive Return screen and receive the inventory against the return. 4. Click upon Inventory Item Detail tab and you will see return lookup form over find inventory item. 5. Find return by returnId or select return from list displayed under return lookup form to find inventory item details for selected return. I'll further review existing screens and apply lookup over there as needed. [~jacques.le.roux] Thanks for the feedback. > Implement and Apply Return Lookup > - > > Key: OFBIZ-10171 > URL: https://issues.apache.org/jira/browse/OFBIZ-10171 > Project: OFBiz > Issue Type: New Feature > Components: order, party >Affects Versions: Trunk >Reporter: Ratnesh Upadhyay >Assignee: Ratnesh Upadhyay >Priority: Major > Attachments: OFBIZ-10171.patch > > > Implement Return Lookup and embed it over related forms where we need to > lookup return and set selected return information over form. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OFBIZ-10171) Implement and Apply Return Lookup
[ https://issues.apache.org/jira/browse/OFBIZ-10171?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ratnesh Upadhyay updated OFBIZ-10171: - Attachment: OFBIZ-10171.patch > Implement and Apply Return Lookup > - > > Key: OFBIZ-10171 > URL: https://issues.apache.org/jira/browse/OFBIZ-10171 > Project: OFBiz > Issue Type: New Feature > Components: order, party >Affects Versions: Trunk >Reporter: Ratnesh Upadhyay >Assignee: Ratnesh Upadhyay >Priority: Major > Attachments: OFBIZ-10171.patch > > > Implement Return Lookup and embed it over related forms where we need to > lookup return and set selected return information over form. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (OFBIZ-10183) Error on My Portal > Request Overview Page
Ratnesh Upadhyay created OFBIZ-10183: Summary: Error on My Portal > Request Overview Page Key: OFBIZ-10183 URL: https://issues.apache.org/jira/browse/OFBIZ-10183 Project: OFBiz Issue Type: Bug Components: projectmgr Affects Versions: Trunk Reporter: Ratnesh Upadhyay While browsing through my portal app, I noticed this issue. Here are the steps to replicate the issue. # Go to My Portal > My Comms. # Click upon any customer request Id link to navigate on Request Overview page. Following error appeared on overview page as soon as user lands on this page. {code:java} Error rendering included template at location [component://projectmgr/webapp/projectmgr/request/OverViewRequestItems.ftl]: freemarker.template.TemplateNotFoundException: Template not found for name "component://projectmgr/webapp/projectmgr/request/OverViewRequestItems.ftl". The name was interpreted by this TemplateLoader: MultiTemplateLoader(loader1 = org.apache.ofbiz.base.util.template.FreeMarkerWorker$FlexibleTemplateLoader@49711524, loader2 = StringTemplateLoader(Map { })). {code} -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (OFBIZ-10173) Add/Modify Calender Event Screen is Broken
Ratnesh Upadhyay created OFBIZ-10173: Summary: Add/Modify Calender Event Screen is Broken Key: OFBIZ-10173 URL: https://issues.apache.org/jira/browse/OFBIZ-10173 Project: OFBiz Issue Type: Bug Components: humanres Affects Versions: Trunk Reporter: Ratnesh Upadhyay *Steps to reproduce the issue*: # Go HR component. # Click on Training Tab. # Click on any event listed over training calendar to navigate over modify event screen. Here is the error message appearing on page when user tried to navigate on any event from training calendar. {code:java} java.lang.IllegalArgumentException: Error running script at location [component:///workeffort/groovyScripts/ical/IsCalOwner.groovy]: org.codehaus.groovy.runtime.typehandling.GroovyCastException: Cannot cast object '[GenericEntity:WorkEffortPartyAssignment][assignedByUserLoginId,admin(java.lang.String)][availabilityStatusId,null()][comments,null()][createdStamp,2018-01-19 16:49:36.69(java.sql.Timestamp)][createdTxStamp,2018-01-19 16:49:36.616(java.sql.Timestamp)][delegateReasonEnumId,null()][expectationEnumId,null()][facilityId,null()][fromDate,2018-01-19 16:49:36.69(java.sql.Timestamp)][lastUpdatedStamp,2018-01-19 16:49:36.69(java.sql.Timestamp)][lastUpdatedTxStamp,2018-01-19 16:49:36.616(java.sql.Timestamp)][mustRsvp,null()][partyId,admin(java.lang.String)][roleTypeId,CAL_OWNER(java.lang.String)][statusDateTime,null()][statusId,PRTYASGN_ASSIGNED(java.lang.String)][thruDate,null()][workEffortId,10041(java.lang.String)]' with class 'org.apache.ofbiz.entity.GenericValue' to class 'java.util.List' due to: groovy.lang.GroovyRuntimeException: Could not find matching constructor for: java.util.List(org.apache.ofbiz.entity.GenericValue) {code} -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OFBIZ-10171) Implement and Apply Return Lookup
[ https://issues.apache.org/jira/browse/OFBIZ-10171?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ratnesh Upadhyay updated OFBIZ-10171: - Description: Implement Return Lookup and embed it over related forms where we need to lookup return and set selected return information over form. > Implement and Apply Return Lookup > - > > Key: OFBIZ-10171 > URL: https://issues.apache.org/jira/browse/OFBIZ-10171 > Project: OFBiz > Issue Type: New Feature > Components: order, party >Affects Versions: Trunk >Reporter: Ratnesh Upadhyay >Assignee: Ratnesh Upadhyay >Priority: Major > > Implement Return Lookup and embed it over related forms where we need to > lookup return and set selected return information over form. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (OFBIZ-10171) Implement and Apply Return Lookup
Ratnesh Upadhyay created OFBIZ-10171: Summary: Implement and Apply Return Lookup Key: OFBIZ-10171 URL: https://issues.apache.org/jira/browse/OFBIZ-10171 Project: OFBiz Issue Type: New Feature Components: order, party Affects Versions: Trunk Environment: Implement Return Lookup and embed it over related forms where we need to lookup return and set selected return information over form. Reporter: Ratnesh Upadhyay Assignee: Ratnesh Upadhyay -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OFBIZ-10171) Implement and Apply Return Lookup
[ https://issues.apache.org/jira/browse/OFBIZ-10171?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ratnesh Upadhyay updated OFBIZ-10171: - Environment: (was: Implement Return Lookup and embed it over related forms where we need to lookup return and set selected return information over form.) > Implement and Apply Return Lookup > - > > Key: OFBIZ-10171 > URL: https://issues.apache.org/jira/browse/OFBIZ-10171 > Project: OFBiz > Issue Type: New Feature > Components: order, party >Affects Versions: Trunk >Reporter: Ratnesh Upadhyay >Assignee: Ratnesh Upadhyay >Priority: Major > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OFBIZ-9911) Add ability to record Return Communication
[ https://issues.apache.org/jira/browse/OFBIZ-9911?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ratnesh Upadhyay updated OFBIZ-9911: Attachment: OFBIZ-9911.patch > Add ability to record Return Communication > -- > > Key: OFBIZ-9911 > URL: https://issues.apache.org/jira/browse/OFBIZ-9911 > Project: OFBiz > Issue Type: New Feature > Components: order, party >Reporter: Ratnesh Upadhyay >Assignee: Rishi Solanki > Attachments: OFBIZ-9911-CommunicationEventReturn-Entity.jpg, > OFBIZ-9911-FindCommByReturn-FilterRecords-Screen.jpg, > OFBIZ-9911-FindCommunicationByReturn-Screen.jpg, OFBIZ-9911.patch, > OFBIZ-9911.patch, OFBIZ-9911.patch > > > In OOTB we are having the ability to record order specific communication in > CommunicationEventOrder and the user can retrieve/review them from party > > communications screen but we don't have such support for return > communications. So It would be great to have an ability to record return > specific communication in the system. > We have to implement following items to establish this feature : > *Data Model Details:* > - We will have to create new entity CommunicationEventReturn to record return > communication. It should have returnId and communicationEventId along with > other necessary fields. > - We have to implement following view CommunicationEventAndReturn to fetch > return communications over screens as needed. > *New Implementation Details:* > - We have to add CRUD services for the new entity. > *Existing Implementation Details:* > - We have to extend createCommunicationEvent service definition with retunId > field and extend the existing implementation to create the record in > CommunicationEventReturn based on supplied returnId parameter. > - Also, we have to extend return related email services to provide returnId > in service context. > *User Interface Details:* > - In the current system we have Party > Communications > Find Communication > By Order screen, in the same way, we can add another screen to find > communication by return. > - We can add return communication screenlet over Order Manager > Return > > Return History screen or we can add communication tab under Order > Return > screen, this is just a thought still thinking on it. > - We can also provide communication tab in order component as well. > Thanks to [~jacques.le.roux], [~rishisolankii] and [~deepakddixit] for > discussion and inputs. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (OFBIZ-10129) Order Process Broken - Due to Missing Service Defination
[ https://issues.apache.org/jira/browse/OFBIZ-10129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16306289#comment-16306289 ] Ratnesh Upadhyay commented on OFBIZ-10129: -- Attached patch to fix reported issue, thanks! > Order Process Broken - Due to Missing Service Defination > > > Key: OFBIZ-10129 > URL: https://issues.apache.org/jira/browse/OFBIZ-10129 > Project: OFBiz > Issue Type: Bug > Components: order >Affects Versions: Trunk >Reporter: Ratnesh Upadhyay >Assignee: Rishi Solanki > Attachments: OFBIZ-10129.patch > > > Getting following error over screen while placing order : > {code} > ERROR rendering error page [/error/error.jsp], but here is the error text: > java.lang.IllegalArgumentException: Error running script at location > [component://order/groovyScripts/entry/BillSettings.groovy]: > org.apache.ofbiz.service.GenericServiceException: Cannot locate service by > name (getRelatedParties) > {code} > After further research it seems that service definition gets removed at > revision:1819138 under OFBIZ-9988 -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (OFBIZ-10129) Order Process Broken - Due to Missing Service Defination
[ https://issues.apache.org/jira/browse/OFBIZ-10129?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ratnesh Upadhyay updated OFBIZ-10129: - Attachment: OFBIZ-10129.patch > Order Process Broken - Due to Missing Service Defination > > > Key: OFBIZ-10129 > URL: https://issues.apache.org/jira/browse/OFBIZ-10129 > Project: OFBiz > Issue Type: Bug > Components: order >Affects Versions: Trunk >Reporter: Ratnesh Upadhyay >Assignee: Ratnesh Upadhyay > Attachments: OFBIZ-10129.patch > > > Getting following error over screen while placing order : > {code} > ERROR rendering error page [/error/error.jsp], but here is the error text: > java.lang.IllegalArgumentException: Error running script at location > [component://order/groovyScripts/entry/BillSettings.groovy]: > org.apache.ofbiz.service.GenericServiceException: Cannot locate service by > name (getRelatedParties) > {code} > After further research it seems that service definition gets removed at > revision:1819138 under OFBIZ-9988 -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Created] (OFBIZ-10129) Order Process Broken - Due to Missing Service Defination
Ratnesh Upadhyay created OFBIZ-10129: Summary: Order Process Broken - Due to Missing Service Defination Key: OFBIZ-10129 URL: https://issues.apache.org/jira/browse/OFBIZ-10129 Project: OFBiz Issue Type: Bug Components: order Affects Versions: Trunk Reporter: Ratnesh Upadhyay Assignee: Ratnesh Upadhyay Getting following error over screen while placing order : {code} ERROR rendering error page [/error/error.jsp], but here is the error text: java.lang.IllegalArgumentException: Error running script at location [component://order/groovyScripts/entry/BillSettings.groovy]: org.apache.ofbiz.service.GenericServiceException: Cannot locate service by name (getRelatedParties) {code} After further research it seems that service definition gets removed at revision:1819138 under OFBIZ-9988 -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (OFBIZ-9911) Add ability to record Return Communication
[ https://issues.apache.org/jira/browse/OFBIZ-9911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16298503#comment-16298503 ] Ratnesh Upadhyay commented on OFBIZ-9911: - *Closure Template:* This is new feature, now system should be able to record return communication in same way as we are recording it for order communications. *High Level Technical Summary:* - Added *CommunicationEventReturn* entity and *CommunicationEventAndReturn* view entity. - Added *createCommunicationEventReturn* and *removeCommunicationEventReturn* services to create and remove records from aforementioned entity. - Added required request map and view map in party controller. - Implemented *FindCommunicationByReturn* screen to wrap find/list communication by return forms. - Implemented *FindCommunicationByReturn* and *ListCommunicationByReturn* forms to find and list the return communications, used *performFind* service to filter the communication records on various fields. - Extended party menus with new menu item to navigate over *FindCommunicationByReturn* screen. - Extended definition of *createCommunicationEventInterface*, *createCommEventFromEmail* and *sendMailInterface* services. - Added support in *createCommunicationEvent* service to record return communication in *CommunicationEventReturn* entity. - Extended *sendReturnNotificationScreen* , *createCommEventFromEmail* methods to supply returnId to candidate services. - Extended *sendMail* service to keep returnId in result and returned it to caller method/service. *Unit Testing:* - Created sales order (for DemoCustomer) and ship it, Initiated return from order view page. Now select return items and accept return. Verified that Return Accepted email received and it's recorded in *CommunicationEvent*, *CommunicationEventReturn* entities and populating in *CommunicationEventAndReturn* view. - Verified *Find Communication By Return* tab started appearing in Party > Communication screen - Verified *Party > Find Communication* is intact and working as expected, there is no regression on this screen due to new changes. - Verified all the eturn communications are listing over *Party > Profile > Communications > Find Communication Screen* by clicking upon *Find* button. - Verified return communications are filtering based upon supplied *Search Options* like returnId and communicationEventId over *Find Communication By Return* screen. - Verified create and delete operation are executing successfully from webtools over *CommunicationEventReturn* entity and respective records/changes are reflecting in *Find Communication By Return* screen. Apart from this I've also attached updated patch with latest revision and functional and data transition screenshots for quick reference and verification, thanks! > Add ability to record Return Communication > -- > > Key: OFBIZ-9911 > URL: https://issues.apache.org/jira/browse/OFBIZ-9911 > Project: OFBiz > Issue Type: New Feature > Components: order, party >Reporter: Ratnesh Upadhyay >Assignee: Rishi Solanki > Attachments: OFBIZ-9911-CommunicationEventReturn-Entity.jpg, > OFBIZ-9911-FindCommByReturn-FilterRecords-Screen.jpg, > OFBIZ-9911-FindCommunicationByReturn-Screen.jpg, OFBIZ-9911.patch, > OFBIZ-9911.patch > > > In OOTB we are having the ability to record order specific communication in > CommunicationEventOrder and the user can retrieve/review them from party > > communications screen but we don't have such support for return > communications. So It would be great to have an ability to record return > specific communication in the system. > We have to implement following items to establish this feature : > *Data Model Details:* > - We will have to create new entity CommunicationEventReturn to record return > communication. It should have returnId and communicationEventId along with > other necessary fields. > - We have to implement following view CommunicationEventAndReturn to fetch > return communications over screens as needed. > *New Implementation Details:* > - We have to add CRUD services for the new entity. > *Existing Implementation Details:* > - We have to extend createCommunicationEvent service definition with retunId > field and extend the existing implementation to create the record in > CommunicationEventReturn based on supplied returnId parameter. > - Also, we have to extend return related email services to provide returnId > in service context. > *User Interface Details:* > - In the current system we have Party > Communications > Find Communication > By Order screen, in the same way, we can add another screen to find > communication by return. > - We can add return communication screenlet over Order Manager > Return > > Return History screen or we can add commu
[jira] [Updated] (OFBIZ-9911) Add ability to record Return Communication
[ https://issues.apache.org/jira/browse/OFBIZ-9911?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ratnesh Upadhyay updated OFBIZ-9911: Attachment: OFBIZ-9911.patch > Add ability to record Return Communication > -- > > Key: OFBIZ-9911 > URL: https://issues.apache.org/jira/browse/OFBIZ-9911 > Project: OFBiz > Issue Type: New Feature > Components: order, party >Reporter: Ratnesh Upadhyay >Assignee: Rishi Solanki > Attachments: OFBIZ-9911-CommunicationEventReturn-Entity.jpg, > OFBIZ-9911-FindCommByReturn-FilterRecords-Screen.jpg, > OFBIZ-9911-FindCommunicationByReturn-Screen.jpg, OFBIZ-9911.patch, > OFBIZ-9911.patch > > > In OOTB we are having the ability to record order specific communication in > CommunicationEventOrder and the user can retrieve/review them from party > > communications screen but we don't have such support for return > communications. So It would be great to have an ability to record return > specific communication in the system. > We have to implement following items to establish this feature : > *Data Model Details:* > - We will have to create new entity CommunicationEventReturn to record return > communication. It should have returnId and communicationEventId along with > other necessary fields. > - We have to implement following view CommunicationEventAndReturn to fetch > return communications over screens as needed. > *New Implementation Details:* > - We have to add CRUD services for the new entity. > *Existing Implementation Details:* > - We have to extend createCommunicationEvent service definition with retunId > field and extend the existing implementation to create the record in > CommunicationEventReturn based on supplied returnId parameter. > - Also, we have to extend return related email services to provide returnId > in service context. > *User Interface Details:* > - In the current system we have Party > Communications > Find Communication > By Order screen, in the same way, we can add another screen to find > communication by return. > - We can add return communication screenlet over Order Manager > Return > > Return History screen or we can add communication tab under Order > Return > screen, this is just a thought still thinking on it. > - We can also provide communication tab in order component as well. > Thanks to [~jacques.le.roux], [~rishisolankii] and [~deepakddixit] for > discussion and inputs. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (OFBIZ-9911) Add ability to record Return Communication
[ https://issues.apache.org/jira/browse/OFBIZ-9911?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ratnesh Upadhyay updated OFBIZ-9911: Attachment: OFBIZ-9911-CommunicationEventReturn-Entity.jpg > Add ability to record Return Communication > -- > > Key: OFBIZ-9911 > URL: https://issues.apache.org/jira/browse/OFBIZ-9911 > Project: OFBiz > Issue Type: New Feature > Components: order, party >Reporter: Ratnesh Upadhyay >Assignee: Rishi Solanki > Attachments: OFBIZ-9911-CommunicationEventReturn-Entity.jpg, > OFBIZ-9911-FindCommByReturn-FilterRecords-Screen.jpg, > OFBIZ-9911-FindCommunicationByReturn-Screen.jpg, OFBIZ-9911.patch > > > In OOTB we are having the ability to record order specific communication in > CommunicationEventOrder and the user can retrieve/review them from party > > communications screen but we don't have such support for return > communications. So It would be great to have an ability to record return > specific communication in the system. > We have to implement following items to establish this feature : > *Data Model Details:* > - We will have to create new entity CommunicationEventReturn to record return > communication. It should have returnId and communicationEventId along with > other necessary fields. > - We have to implement following view CommunicationEventAndReturn to fetch > return communications over screens as needed. > *New Implementation Details:* > - We have to add CRUD services for the new entity. > *Existing Implementation Details:* > - We have to extend createCommunicationEvent service definition with retunId > field and extend the existing implementation to create the record in > CommunicationEventReturn based on supplied returnId parameter. > - Also, we have to extend return related email services to provide returnId > in service context. > *User Interface Details:* > - In the current system we have Party > Communications > Find Communication > By Order screen, in the same way, we can add another screen to find > communication by return. > - We can add return communication screenlet over Order Manager > Return > > Return History screen or we can add communication tab under Order > Return > screen, this is just a thought still thinking on it. > - We can also provide communication tab in order component as well. > Thanks to [~jacques.le.roux], [~rishisolankii] and [~deepakddixit] for > discussion and inputs. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (OFBIZ-9911) Add ability to record Return Communication
[ https://issues.apache.org/jira/browse/OFBIZ-9911?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ratnesh Upadhyay updated OFBIZ-9911: Attachment: (was: OFBIZ-9911.jpg) > Add ability to record Return Communication > -- > > Key: OFBIZ-9911 > URL: https://issues.apache.org/jira/browse/OFBIZ-9911 > Project: OFBiz > Issue Type: New Feature > Components: order, party >Reporter: Ratnesh Upadhyay >Assignee: Rishi Solanki > Attachments: OFBIZ-9911-FindCommByReturn-FilterRecords-Screen.jpg, > OFBIZ-9911-FindCommunicationByReturn-Screen.jpg, OFBIZ-9911.patch > > > In OOTB we are having the ability to record order specific communication in > CommunicationEventOrder and the user can retrieve/review them from party > > communications screen but we don't have such support for return > communications. So It would be great to have an ability to record return > specific communication in the system. > We have to implement following items to establish this feature : > *Data Model Details:* > - We will have to create new entity CommunicationEventReturn to record return > communication. It should have returnId and communicationEventId along with > other necessary fields. > - We have to implement following view CommunicationEventAndReturn to fetch > return communications over screens as needed. > *New Implementation Details:* > - We have to add CRUD services for the new entity. > *Existing Implementation Details:* > - We have to extend createCommunicationEvent service definition with retunId > field and extend the existing implementation to create the record in > CommunicationEventReturn based on supplied returnId parameter. > - Also, we have to extend return related email services to provide returnId > in service context. > *User Interface Details:* > - In the current system we have Party > Communications > Find Communication > By Order screen, in the same way, we can add another screen to find > communication by return. > - We can add return communication screenlet over Order Manager > Return > > Return History screen or we can add communication tab under Order > Return > screen, this is just a thought still thinking on it. > - We can also provide communication tab in order component as well. > Thanks to [~jacques.le.roux], [~rishisolankii] and [~deepakddixit] for > discussion and inputs. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (OFBIZ-9911) Add ability to record Return Communication
[ https://issues.apache.org/jira/browse/OFBIZ-9911?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ratnesh Upadhyay updated OFBIZ-9911: Attachment: OFBIZ-9911.jpg > Add ability to record Return Communication > -- > > Key: OFBIZ-9911 > URL: https://issues.apache.org/jira/browse/OFBIZ-9911 > Project: OFBiz > Issue Type: New Feature > Components: order, party >Reporter: Ratnesh Upadhyay >Assignee: Rishi Solanki > Attachments: OFBIZ-9911-FindCommByReturn-FilterRecords-Screen.jpg, > OFBIZ-9911-FindCommunicationByReturn-Screen.jpg, OFBIZ-9911.patch > > > In OOTB we are having the ability to record order specific communication in > CommunicationEventOrder and the user can retrieve/review them from party > > communications screen but we don't have such support for return > communications. So It would be great to have an ability to record return > specific communication in the system. > We have to implement following items to establish this feature : > *Data Model Details:* > - We will have to create new entity CommunicationEventReturn to record return > communication. It should have returnId and communicationEventId along with > other necessary fields. > - We have to implement following view CommunicationEventAndReturn to fetch > return communications over screens as needed. > *New Implementation Details:* > - We have to add CRUD services for the new entity. > *Existing Implementation Details:* > - We have to extend createCommunicationEvent service definition with retunId > field and extend the existing implementation to create the record in > CommunicationEventReturn based on supplied returnId parameter. > - Also, we have to extend return related email services to provide returnId > in service context. > *User Interface Details:* > - In the current system we have Party > Communications > Find Communication > By Order screen, in the same way, we can add another screen to find > communication by return. > - We can add return communication screenlet over Order Manager > Return > > Return History screen or we can add communication tab under Order > Return > screen, this is just a thought still thinking on it. > - We can also provide communication tab in order component as well. > Thanks to [~jacques.le.roux], [~rishisolankii] and [~deepakddixit] for > discussion and inputs. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (OFBIZ-9911) Add ability to record Return Communication
[ https://issues.apache.org/jira/browse/OFBIZ-9911?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ratnesh Upadhyay updated OFBIZ-9911: Attachment: (was: OFBIZ-9911-CommunicationEventReturn-Entity.jpg) > Add ability to record Return Communication > -- > > Key: OFBIZ-9911 > URL: https://issues.apache.org/jira/browse/OFBIZ-9911 > Project: OFBiz > Issue Type: New Feature > Components: order, party >Reporter: Ratnesh Upadhyay >Assignee: Rishi Solanki > Attachments: OFBIZ-9911-FindCommByReturn-FilterRecords-Screen.jpg, > OFBIZ-9911-FindCommunicationByReturn-Screen.jpg, OFBIZ-9911.patch > > > In OOTB we are having the ability to record order specific communication in > CommunicationEventOrder and the user can retrieve/review them from party > > communications screen but we don't have such support for return > communications. So It would be great to have an ability to record return > specific communication in the system. > We have to implement following items to establish this feature : > *Data Model Details:* > - We will have to create new entity CommunicationEventReturn to record return > communication. It should have returnId and communicationEventId along with > other necessary fields. > - We have to implement following view CommunicationEventAndReturn to fetch > return communications over screens as needed. > *New Implementation Details:* > - We have to add CRUD services for the new entity. > *Existing Implementation Details:* > - We have to extend createCommunicationEvent service definition with retunId > field and extend the existing implementation to create the record in > CommunicationEventReturn based on supplied returnId parameter. > - Also, we have to extend return related email services to provide returnId > in service context. > *User Interface Details:* > - In the current system we have Party > Communications > Find Communication > By Order screen, in the same way, we can add another screen to find > communication by return. > - We can add return communication screenlet over Order Manager > Return > > Return History screen or we can add communication tab under Order > Return > screen, this is just a thought still thinking on it. > - We can also provide communication tab in order component as well. > Thanks to [~jacques.le.roux], [~rishisolankii] and [~deepakddixit] for > discussion and inputs. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (OFBIZ-9911) Add ability to record Return Communication
[ https://issues.apache.org/jira/browse/OFBIZ-9911?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ratnesh Upadhyay updated OFBIZ-9911: Attachment: OFBIZ-9911-CommunicationEventReturn-Entity.jpg OFBIZ-9911-FindCommunicationByReturn-Screen.jpg OFBIZ-9911-FindCommByReturn-FilterRecords-Screen.jpg > Add ability to record Return Communication > -- > > Key: OFBIZ-9911 > URL: https://issues.apache.org/jira/browse/OFBIZ-9911 > Project: OFBiz > Issue Type: New Feature > Components: order, party >Reporter: Ratnesh Upadhyay >Assignee: Rishi Solanki > Attachments: OFBIZ-9911-CommunicationEventReturn-Entity.jpg, > OFBIZ-9911-FindCommByReturn-FilterRecords-Screen.jpg, > OFBIZ-9911-FindCommunicationByReturn-Screen.jpg, OFBIZ-9911.patch > > > In OOTB we are having the ability to record order specific communication in > CommunicationEventOrder and the user can retrieve/review them from party > > communications screen but we don't have such support for return > communications. So It would be great to have an ability to record return > specific communication in the system. > We have to implement following items to establish this feature : > *Data Model Details:* > - We will have to create new entity CommunicationEventReturn to record return > communication. It should have returnId and communicationEventId along with > other necessary fields. > - We have to implement following view CommunicationEventAndReturn to fetch > return communications over screens as needed. > *New Implementation Details:* > - We have to add CRUD services for the new entity. > *Existing Implementation Details:* > - We have to extend createCommunicationEvent service definition with retunId > field and extend the existing implementation to create the record in > CommunicationEventReturn based on supplied returnId parameter. > - Also, we have to extend return related email services to provide returnId > in service context. > *User Interface Details:* > - In the current system we have Party > Communications > Find Communication > By Order screen, in the same way, we can add another screen to find > communication by return. > - We can add return communication screenlet over Order Manager > Return > > Return History screen or we can add communication tab under Order > Return > screen, this is just a thought still thinking on it. > - We can also provide communication tab in order component as well. > Thanks to [~jacques.le.roux], [~rishisolankii] and [~deepakddixit] for > discussion and inputs. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Comment Edited] (OFBIZ-9911) Add ability to record Return Communication
[ https://issues.apache.org/jira/browse/OFBIZ-9911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16265728#comment-16265728 ] Ratnesh Upadhyay edited comment on OFBIZ-9911 at 11/25/17 2:31 PM: --- *Quick Update:* I am done with the feature implementation, now system started recording return related communications. Also user should be able to find and view communication by return from newly added screen. Attached patch and will share technical summary and verification details soon. was (Author: upadhyay.ratnesh): *Quick Update:* I am done with the feature implementation, now system started recording return related communications. Also user should be able to find and view communication by return from newly added screen. I'll share technical summary and verification details soon. > Add ability to record Return Communication > -- > > Key: OFBIZ-9911 > URL: https://issues.apache.org/jira/browse/OFBIZ-9911 > Project: OFBiz > Issue Type: New Feature > Components: order, party >Reporter: Ratnesh Upadhyay >Assignee: Rishi Solanki > Attachments: OFBIZ-9911.patch > > > In OOTB we are having the ability to record order specific communication in > CommunicationEventOrder and the user can retrieve/review them from party > > communications screen but we don't have such support for return > communications. So It would be great to have an ability to record return > specific communication in the system. > We have to implement following items to establish this feature : > *Data Model Details:* > - We will have to create new entity CommunicationEventReturn to record return > communication. It should have returnId and communicationEventId along with > other necessary fields. > - We have to implement following view CommunicationEventAndReturn to fetch > return communications over screens as needed. > *New Implementation Details:* > - We have to add CRUD services for the new entity. > *Existing Implementation Details:* > - We have to extend createCommunicationEvent service definition with retunId > field and extend the existing implementation to create the record in > CommunicationEventReturn based on supplied returnId parameter. > - Also, we have to extend return related email services to provide returnId > in service context. > *User Interface Details:* > - In the current system we have Party > Communications > Find Communication > By Order screen, in the same way, we can add another screen to find > communication by return. > - We can add return communication screenlet over Order Manager > Return > > Return History screen or we can add communication tab under Order > Return > screen, this is just a thought still thinking on it. > - We can also provide communication tab in order component as well. > Thanks to [~jacques.le.roux], [~rishisolankii] and [~deepakddixit] for > discussion and inputs. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (OFBIZ-9911) Add ability to record Return Communication
[ https://issues.apache.org/jira/browse/OFBIZ-9911?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ratnesh Upadhyay updated OFBIZ-9911: Attachment: OFBIZ-9911.patch > Add ability to record Return Communication > -- > > Key: OFBIZ-9911 > URL: https://issues.apache.org/jira/browse/OFBIZ-9911 > Project: OFBiz > Issue Type: New Feature > Components: order, party >Reporter: Ratnesh Upadhyay >Assignee: Ratnesh Upadhyay > Attachments: OFBIZ-9911.patch > > > In OOTB we are having the ability to record order specific communication in > CommunicationEventOrder and the user can retrieve/review them from party > > communications screen but we don't have such support for return > communications. So It would be great to have an ability to record return > specific communication in the system. > We have to implement following items to establish this feature : > *Data Model Details:* > - We will have to create new entity CommunicationEventReturn to record return > communication. It should have returnId and communicationEventId along with > other necessary fields. > - We have to implement following view CommunicationEventAndReturn to fetch > return communications over screens as needed. > *New Implementation Details:* > - We have to add CRUD services for the new entity. > *Existing Implementation Details:* > - We have to extend createCommunicationEvent service definition with retunId > field and extend the existing implementation to create the record in > CommunicationEventReturn based on supplied returnId parameter. > - Also, we have to extend return related email services to provide returnId > in service context. > *User Interface Details:* > - In the current system we have Party > Communications > Find Communication > By Order screen, in the same way, we can add another screen to find > communication by return. > - We can add return communication screenlet over Order Manager > Return > > Return History screen or we can add communication tab under Order > Return > screen, this is just a thought still thinking on it. > - We can also provide communication tab in order component as well. > Thanks to [~jacques.le.roux], [~rishisolankii] and [~deepakddixit] for > discussion and inputs. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (OFBIZ-9911) Add ability to record Return Communication
[ https://issues.apache.org/jira/browse/OFBIZ-9911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16265728#comment-16265728 ] Ratnesh Upadhyay commented on OFBIZ-9911: - *Quick Update:* I am done with the feature implementation, now system started recording return related communications. Also user should be able to find and view communication by return from newly added screen. I'll share technical summary and verification details soon. > Add ability to record Return Communication > -- > > Key: OFBIZ-9911 > URL: https://issues.apache.org/jira/browse/OFBIZ-9911 > Project: OFBiz > Issue Type: New Feature > Components: order, party >Reporter: Ratnesh Upadhyay >Assignee: Ratnesh Upadhyay > Attachments: OFBIZ-9911.patch > > > In OOTB we are having the ability to record order specific communication in > CommunicationEventOrder and the user can retrieve/review them from party > > communications screen but we don't have such support for return > communications. So It would be great to have an ability to record return > specific communication in the system. > We have to implement following items to establish this feature : > *Data Model Details:* > - We will have to create new entity CommunicationEventReturn to record return > communication. It should have returnId and communicationEventId along with > other necessary fields. > - We have to implement following view CommunicationEventAndReturn to fetch > return communications over screens as needed. > *New Implementation Details:* > - We have to add CRUD services for the new entity. > *Existing Implementation Details:* > - We have to extend createCommunicationEvent service definition with retunId > field and extend the existing implementation to create the record in > CommunicationEventReturn based on supplied returnId parameter. > - Also, we have to extend return related email services to provide returnId > in service context. > *User Interface Details:* > - In the current system we have Party > Communications > Find Communication > By Order screen, in the same way, we can add another screen to find > communication by return. > - We can add return communication screenlet over Order Manager > Return > > Return History screen or we can add communication tab under Order > Return > screen, this is just a thought still thinking on it. > - We can also provide communication tab in order component as well. > Thanks to [~jacques.le.roux], [~rishisolankii] and [~deepakddixit] for > discussion and inputs. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Created] (OFBIZ-9911) Add ability to record Return Communication
Ratnesh Upadhyay created OFBIZ-9911: --- Summary: Add ability to record Return Communication Key: OFBIZ-9911 URL: https://issues.apache.org/jira/browse/OFBIZ-9911 Project: OFBiz Issue Type: New Feature Components: order, party Reporter: Ratnesh Upadhyay In OOTB we are having the ability to record order specific communication in CommunicationEventOrder and the user can retrieve/review them from party > communications screen but we don't have such support for return communications. So It would be great to have an ability to record return specific communication in the system. We have to implement following items to establish this feature : *Data Model Details:* - We will have to create new entity CommunicationEventReturn to record return communication. It should have returnId and communicationEventId along with other necessary fields. - We have to implement following view CommunicationEventAndReturn to fetch return communications over screens as needed. *New Implementation Details:* - We have to add CRUD services for the new entity. *Existing Implementation Details:* - We have to extend createCommunicationEvent service definition with retunId field and extend the existing implementation to create the record in CommunicationEventReturn based on supplied returnId parameter. - Also, we have to extend return related email services to provide returnId in service context. *User Interface Details:* - In the current system we have Party > Communications > Find Communication By Order screen, in the same way, we can add another screen to find communication by return. - We can add return communication screenlet over Order Manager > Return > Return History screen or we can add communication tab under Order > Return screen, this is just a thought still thinking on it. - We can also provide communication tab in order component as well. Thanks to [~jacques.le.roux], [~rishisolankii] and [~deepakddixit] for discussion and inputs. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Assigned] (OFBIZ-9911) Add ability to record Return Communication
[ https://issues.apache.org/jira/browse/OFBIZ-9911?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ratnesh Upadhyay reassigned OFBIZ-9911: --- Assignee: Ratnesh Upadhyay > Add ability to record Return Communication > -- > > Key: OFBIZ-9911 > URL: https://issues.apache.org/jira/browse/OFBIZ-9911 > Project: OFBiz > Issue Type: New Feature > Components: order, party >Reporter: Ratnesh Upadhyay >Assignee: Ratnesh Upadhyay > > In OOTB we are having the ability to record order specific communication in > CommunicationEventOrder and the user can retrieve/review them from party > > communications screen but we don't have such support for return > communications. So It would be great to have an ability to record return > specific communication in the system. > We have to implement following items to establish this feature : > *Data Model Details:* > - We will have to create new entity CommunicationEventReturn to record return > communication. It should have returnId and communicationEventId along with > other necessary fields. > - We have to implement following view CommunicationEventAndReturn to fetch > return communications over screens as needed. > *New Implementation Details:* > - We have to add CRUD services for the new entity. > *Existing Implementation Details:* > - We have to extend createCommunicationEvent service definition with retunId > field and extend the existing implementation to create the record in > CommunicationEventReturn based on supplied returnId parameter. > - Also, we have to extend return related email services to provide returnId > in service context. > *User Interface Details:* > - In the current system we have Party > Communications > Find Communication > By Order screen, in the same way, we can add another screen to find > communication by return. > - We can add return communication screenlet over Order Manager > Return > > Return History screen or we can add communication tab under Order > Return > screen, this is just a thought still thinking on it. > - We can also provide communication tab in order component as well. > Thanks to [~jacques.le.roux], [~rishisolankii] and [~deepakddixit] for > discussion and inputs. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (OFBIZ-9647) Missing Relationship from OrderHeader to WebSite
[ https://issues.apache.org/jira/browse/OFBIZ-9647?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16159952#comment-16159952 ] Ratnesh Upadhyay commented on OFBIZ-9647: - Thanks to the community for inputs. I further reviewed it and found that its better to cleaned it up instead of adding data WebSite record. So finally I've removed all the references of "OrderEntry" from demo and test data files, also removed the check from secas to make them work. Patch attached for review and resolution of the issue. > Missing Relationship from OrderHeader to WebSite > > > Key: OFBIZ-9647 > URL: https://issues.apache.org/jira/browse/OFBIZ-9647 > Project: OFBiz > Issue Type: Sub-task > Components: order >Affects Versions: Trunk >Reporter: Ratnesh Upadhyay >Assignee: Ratnesh Upadhyay > Attachments: OFBIZ-9647.patch > > > OrderHeader entity have webSiteId field but there is no relationship defined > for it with WebSite entity. It must have FK constraint from > OrderHeader.webSiteId to WebSite.webSiteId. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (OFBIZ-9647) Missing Relationship from OrderHeader to WebSite
[ https://issues.apache.org/jira/browse/OFBIZ-9647?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ratnesh Upadhyay updated OFBIZ-9647: Attachment: OFBIZ-9647.patch > Missing Relationship from OrderHeader to WebSite > > > Key: OFBIZ-9647 > URL: https://issues.apache.org/jira/browse/OFBIZ-9647 > Project: OFBiz > Issue Type: Sub-task > Components: order >Affects Versions: Trunk >Reporter: Ratnesh Upadhyay >Assignee: Ratnesh Upadhyay > Attachments: OFBIZ-9647.patch > > > OrderHeader entity have webSiteId field but there is no relationship defined > for it with WebSite entity. It must have FK constraint from > OrderHeader.webSiteId to WebSite.webSiteId. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Assigned] (OFBIZ-9647) Missing Relationship from OrderHeader to WebSite
[ https://issues.apache.org/jira/browse/OFBIZ-9647?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ratnesh Upadhyay reassigned OFBIZ-9647: --- Assignee: Ratnesh Upadhyay > Missing Relationship from OrderHeader to WebSite > > > Key: OFBIZ-9647 > URL: https://issues.apache.org/jira/browse/OFBIZ-9647 > Project: OFBiz > Issue Type: Improvement > Components: order >Affects Versions: Trunk >Reporter: Ratnesh Upadhyay >Assignee: Ratnesh Upadhyay > > OrderHeader entity have webSiteId field but there is no relationship defined > for it with WebSite entity. It must have FK constraint from > OrderHeader.webSiteId to WebSite.webSiteId. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (OFBIZ-9670) Party Communication Screen is broken
[ https://issues.apache.org/jira/browse/OFBIZ-9670?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ratnesh Upadhyay updated OFBIZ-9670: Attachment: OFBIZ-9670.patch Attached patch to fix the broken screen. Thanks!! > Party Communication Screen is broken > > > Key: OFBIZ-9670 > URL: https://issues.apache.org/jira/browse/OFBIZ-9670 > Project: OFBiz > Issue Type: Bug > Components: party >Affects Versions: Trunk >Reporter: Ratnesh Upadhyay >Assignee: Ratnesh Upadhyay > Attachments: OFBIZ-9670.patch > > > |E| XmlFileLoader: File > file:/home/ratnesh/sandbox/ofbiztrunklatest/applications/party/widget/partymgr/CommunicationEventScreens.xml > process fatal error. Line: 582. Error message: The value of attribute > "from-field" associated with an element type "set" must not contain the '<' > character. > It was due to missing closing quotes in from-field attribute of set field tag. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Created] (OFBIZ-9670) Party Communication Screen is broken
Ratnesh Upadhyay created OFBIZ-9670: --- Summary: Party Communication Screen is broken Key: OFBIZ-9670 URL: https://issues.apache.org/jira/browse/OFBIZ-9670 Project: OFBiz Issue Type: Bug Components: party Affects Versions: Trunk Reporter: Ratnesh Upadhyay Assignee: Ratnesh Upadhyay |E| XmlFileLoader: File file:/home/ratnesh/sandbox/ofbiztrunklatest/applications/party/widget/partymgr/CommunicationEventScreens.xml process fatal error. Line: 582. Error message: The value of attribute "from-field" associated with an element type "set" must not contain the '<' character. It was due to missing closing quotes in from-field attribute of set field tag. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (OFBIZ-9647) Missing Relationship from OrderHeader to WebSite
[ https://issues.apache.org/jira/browse/OFBIZ-9647?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16142831#comment-16142831 ] Ratnesh Upadhyay commented on OFBIZ-9647: - While working on this, I've noticed few things that needs to be discussed : 1. We have few order in DemoOrderTestData.xml and OrderTestData.xml that are having webSiteId="OrderEntry" but we don't have any record in WebSite entity for "OrderEntry" webSiteId. 2. We have "setCustRequestStatus" and "setCustRequestStatus" ecas where we are having following condition : Although we don't have this webSite record in entity then these ecas are no more of use as system never meet this condition. 3. There is no "webSiteId" is being set for orders placed from ordermgr application, so IMO we should setup webSiteId parameter in servletConetext of ordermgr app to get it setup. I can see its usage to get the information of orders placed from store front as well as from backend application. To apply FK constraint either we have to add record in WebSite entity or remove the references of "OrderEntry" webSiteId from order demo data. Also please let me know your thoughts to set webSiteId for backend apps. IMO, we should add record in WebSite entity for "OrderEntry". Discussion going on mailing list for the same. > Missing Relationship from OrderHeader to WebSite > > > Key: OFBIZ-9647 > URL: https://issues.apache.org/jira/browse/OFBIZ-9647 > Project: OFBiz > Issue Type: Improvement > Components: order >Affects Versions: Trunk >Reporter: Ratnesh Upadhyay > > OrderHeader entity have webSiteId field but there is no relationship defined > for it with WebSite entity. It must have FK constraint from > OrderHeader.webSiteId to WebSite.webSiteId. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (OFBIZ-9647) Missing Relationship from OrderHeader to WebSite
[ https://issues.apache.org/jira/browse/OFBIZ-9647?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16142666#comment-16142666 ] Ratnesh Upadhyay commented on OFBIZ-9647: - Soon, I'll provide patch to establish the relationship. > Missing Relationship from OrderHeader to WebSite > > > Key: OFBIZ-9647 > URL: https://issues.apache.org/jira/browse/OFBIZ-9647 > Project: OFBiz > Issue Type: Improvement > Components: order >Affects Versions: Trunk >Reporter: Ratnesh Upadhyay > > OrderHeader entity have webSiteId field but there is no relationship defined > for it with WebSite entity. It must have FK constraint from > OrderHeader.webSiteId to WebSite.webSiteId. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Created] (OFBIZ-9647) Missing Relationship from OrderHeader to WebSite
Ratnesh Upadhyay created OFBIZ-9647: --- Summary: Missing Relationship from OrderHeader to WebSite Key: OFBIZ-9647 URL: https://issues.apache.org/jira/browse/OFBIZ-9647 Project: OFBiz Issue Type: Improvement Components: order Affects Versions: Trunk Reporter: Ratnesh Upadhyay OrderHeader entity have webSiteId field but there is no relationship defined for it with WebSite entity. It must have FK constraint from OrderHeader.webSiteId to WebSite.webSiteId. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Created] (OFBIZ-8625) Footer text inconsistent in flat gray theme
Ratnesh Upadhyay created OFBIZ-8625: --- Summary: Footer text inconsistent in flat gray theme Key: OFBIZ-8625 URL: https://issues.apache.org/jira/browse/OFBIZ-8625 Project: OFBiz Issue Type: Bug Components: themes Affects Versions: Upcoming Branch Reporter: Ratnesh Upadhyay Priority: Minor Powered By : and other text is having inconsistent font color in flat grey theme. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (OFBIZ-8471) Remove uneccessary call of isNotEmpty() to validate not null generic value
[ https://issues.apache.org/jira/browse/OFBIZ-8471?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ratnesh Upadhyay updated OFBIZ-8471: Attachment: OFBIZ-8471.patch Attached patch to review and push the mentioned improvement. > Remove uneccessary call of isNotEmpty() to validate not null generic value > -- > > Key: OFBIZ-8471 > URL: https://issues.apache.org/jira/browse/OFBIZ-8471 > Project: OFBiz > Issue Type: Improvement > Components: ALL COMPONENTS >Affects Versions: Upcoming Branch >Reporter: Ratnesh Upadhyay > Attachments: OFBIZ-8471.patch > > > There are lots of places in code where we have used UtilValidate.isNotEmpty() > to validate GenericValue object. GenericValue will always be null or not > null, they will never empty. So instead of using utility method to validate > them we should be using native checks onwards. > Example: > Currently we are validating generic value in following ways > {code} > if (UtilValidate.isNotEmpty(acctgTransEntry)) { > {code} > instead we will using it in this way: > {code} > if (acctgTransEntry != null ) { > {code} > Basically these validation methods should preferably be used on Strings or > Lists and normal Maps. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (OFBIZ-8471) Remove uneccessary call of isNotEmpty() to validate not null generic value
Ratnesh Upadhyay created OFBIZ-8471: --- Summary: Remove uneccessary call of isNotEmpty() to validate not null generic value Key: OFBIZ-8471 URL: https://issues.apache.org/jira/browse/OFBIZ-8471 Project: OFBiz Issue Type: Improvement Components: ALL COMPONENTS Affects Versions: Upcoming Branch Reporter: Ratnesh Upadhyay There are lots of places in code where we have used UtilValidate.isNotEmpty() to validate GenericValue object. GenericValue will always be null or not null, they will never empty. So instead of using utility method to validate them we should be using native checks onwards. Example: Currently we are validating generic value in following ways {code} if (UtilValidate.isNotEmpty(acctgTransEntry)) { {code} instead we will using it in this way: {code} if (acctgTransEntry != null ) { {code} Basically these validation methods should preferably be used on Strings or Lists and normal Maps. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (OFBIZ-8255) OFBIZ-7649: Display From date with default now() on all screens under Order Application
Ratnesh Upadhyay created OFBIZ-8255: --- Summary: OFBIZ-7649: Display From date with default now() on all screens under Order Application Key: OFBIZ-8255 URL: https://issues.apache.org/jira/browse/OFBIZ-8255 Project: OFBiz Issue Type: Sub-task Components: order Affects Versions: Trunk Reporter: Ratnesh Upadhyay Priority: Minor Display From date with default now() on all screens under Order Application. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (OFBIZ-8029) OFBIZ-7649: Display From date with default now() on all screens under Facility Application
Ratnesh Upadhyay created OFBIZ-8029: --- Summary: OFBIZ-7649: Display From date with default now() on all screens under Facility Application Key: OFBIZ-8029 URL: https://issues.apache.org/jira/browse/OFBIZ-8029 Project: OFBiz Issue Type: Sub-task Components: product Affects Versions: Trunk Reporter: Ratnesh Upadhyay Display From date with default now() on all screens under Facility Application. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (OFBIZ-8028) OFBIZ-7649: Display From date with default now() on all screens under Accounting Application
Ratnesh Upadhyay created OFBIZ-8028: --- Summary: OFBIZ-7649: Display From date with default now() on all screens under Accounting Application Key: OFBIZ-8028 URL: https://issues.apache.org/jira/browse/OFBIZ-8028 Project: OFBiz Issue Type: Sub-task Components: accounting Affects Versions: Trunk Reporter: Ratnesh Upadhyay Display From date with default now() on all screens under Accounting Application. -- This message was sent by Atlassian JIRA (v6.3.4#6332)