Re: [PR] Improved: CommonExt - Move from hard-code menu location to parameterized (OFBIZ-12951) [ofbiz-framework]

2024-05-19 Thread via GitHub 


JacquesLeRoux merged PR #795:
URL: https://github.com/apache/ofbiz-framework/pull/795


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@ofbiz.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] Improved: CommonExt - Move from hard-code menu location to parameterized (OFBIZ-12951) [ofbiz-framework]

2024-05-18 Thread via GitHub 


sonarcloud[bot] commented on PR #795:
URL: https://github.com/apache/ofbiz-framework/pull/795#issuecomment-2118995653

   ## [![Quality Gate 
Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png
 'Quality Gate 
Passed')](https://sonarcloud.io/dashboard?id=apache_ofbiz-framework&pullRequest=795)
 **Quality Gate passed**  
   Issues  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png
 '') [0 New 
issues](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=795&resolved=false&sinceLeakPeriod=true)
  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/accepted-16px.png
 '') [0 Accepted 
issues](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=795&resolutions=WONTFIX)
   
   Measures  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png
 '') [0 Security 
Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework&pullRequest=795&resolved=false&sinceLeakPeriod=true)
  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/no-data-16px.png
 '') No data about Coverage  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png
 '') [0.0% Duplication on New 
Code](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework&pullRequest=795&metric=new_duplicated_lines_density&view=list)
  
 
   [See analysis details on 
SonarCloud](https://sonarcloud.io/dashboard?id=apache_ofbiz-framework&pullRequest=795)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@ofbiz.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] Improved: CommonExt - Move from hard-code menu location to parameterized (OFBIZ-12951) [ofbiz-framework]

2024-05-17 Thread via GitHub 


sonarcloud[bot] commented on PR #795:
URL: https://github.com/apache/ofbiz-framework/pull/795#issuecomment-2117462913

   ## [![Quality Gate 
Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png
 'Quality Gate 
Passed')](https://sonarcloud.io/dashboard?id=apache_ofbiz-framework&pullRequest=795)
 **Quality Gate passed**  
   Issues  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png
 '') [0 New 
issues](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=795&resolved=false&sinceLeakPeriod=true)
  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/accepted-16px.png
 '') [0 Accepted 
issues](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=795&resolutions=WONTFIX)
   
   Measures  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png
 '') [0 Security 
Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework&pullRequest=795&resolved=false&sinceLeakPeriod=true)
  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/no-data-16px.png
 '') No data about Coverage  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png
 '') [0.0% Duplication on New 
Code](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework&pullRequest=795&metric=new_duplicated_lines_density&view=list)
  
 
   [See analysis details on 
SonarCloud](https://sonarcloud.io/dashboard?id=apache_ofbiz-framework&pullRequest=795)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@ofbiz.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] Improved: CommonExt - Move from hard-code menu location to parameterized (OFBIZ-12951) [ofbiz-framework]

2024-05-04 Thread via GitHub 


JacquesLeRoux commented on PR #795:
URL: https://github.com/apache/ofbiz-framework/pull/795#issuecomment-2094120610

   Hi @PierreSmits ,
   
   After applying and a restart, I still get :+1: 
   ERROR MESSAGE
   
   java.lang.RuntimeException: Error rendering included menu named 
[MainActionMenu] at location 
[component://commonext/widget/ofbizsetup/Menus.xml]: 
java.lang.IllegalArgumentException: Could not find menu with name 
[MainActionMenu] in location [component://commonext/widget/ofbizsetup/Menus.xml]
   
   Obviously MainActionMenu is not profileMenuLocation.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@ofbiz.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] Improved: CommonExt - Move from hard-code menu location to parameterized (OFBIZ-12951) [ofbiz-framework]

2024-05-04 Thread via GitHub 


sonarcloud[bot] commented on PR #795:
URL: https://github.com/apache/ofbiz-framework/pull/795#issuecomment-2094095502

   ## [![Quality Gate 
Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png
 'Quality Gate 
Passed')](https://sonarcloud.io/dashboard?id=apache_ofbiz-framework&pullRequest=795)
 **Quality Gate passed**  
   Issues  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png
 '') [0 New 
issues](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=795&resolved=false&inNewCodePeriod=true)
  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/accepted-16px.png
 '') [0 Accepted 
issues](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework&pullRequest=795&metric=new_accepted_issues&view=list)
   
   Measures  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png
 '') [0 Security 
Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework&pullRequest=795&resolved=false&inNewCodePeriod=true)
  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/no-data-16px.png
 '') No data about Coverage  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png
 '') [0.0% Duplication on New 
Code](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework&pullRequest=795&metric=new_duplicated_lines_density&view=list)
  
 
   [See analysis details on 
SonarCloud](https://sonarcloud.io/dashboard?id=apache_ofbiz-framework&pullRequest=795)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@ofbiz.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[PR] Improved: CommonExt - Move from hard-code menu location to parameterized (OFBIZ-12951) [ofbiz-framework]

2024-05-04 Thread via GitHub 


PierreSmits opened a new pull request, #795:
URL: https://github.com/apache/ofbiz-framework/pull/795

   ofbizsetup uses profile screens from partymgr.
   
   modified web.xml
   - added profileMenuLocation


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@ofbiz.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] Improved: CommonExt - Move from hard-code menu location to parameterized (OFBIZ-12951) [ofbiz-framework]

2024-03-19 Thread via GitHub 


JacquesLeRoux merged PR #734:
URL: https://github.com/apache/ofbiz-framework/pull/734


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@ofbiz.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] Improved: CommonExt - Move from hard-code menu location to parameterized (OFBIZ-12951) [ofbiz-framework]

2024-03-18 Thread via GitHub 


sonarcloud[bot] commented on PR #734:
URL: https://github.com/apache/ofbiz-framework/pull/734#issuecomment-2004630898

   ## [![Quality Gate 
Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png
 'Quality Gate 
Passed')](https://sonarcloud.io/dashboard?id=apache_ofbiz-framework&pullRequest=734)
 **Quality Gate passed**  
   Issues  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png
 '') [0 New 
issues](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=734&resolved=false&inNewCodePeriod=true)
  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/accepted-16px.png
 '') [0 Accepted 
issues](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework&pullRequest=734&metric=new_accepted_issues&view=list)
   
   Measures  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png
 '') [0 Security 
Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework&pullRequest=734&resolved=false&inNewCodePeriod=true)
  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/no-data-16px.png
 '') No data about Coverage  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png
 '') [0.0% Duplication on New 
Code](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework&pullRequest=734&metric=new_duplicated_lines_density&view=list)
  
 
   [See analysis details on 
SonarCloud](https://sonarcloud.io/dashboard?id=apache_ofbiz-framework&pullRequest=734)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@ofbiz.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[PR] Improved: CommonExt - Move from hard-code menu location to parameterized (OFBIZ-12951) [ofbiz-framework]

2024-03-18 Thread via GitHub 


PierreSmits opened a new pull request, #734:
URL: https://github.com/apache/ofbiz-framework/pull/734

   Move the menu location in various commonext screens from hard-coded to 
parameterized.
   
   modified re ofbizsetup:
   - web.xml - added context-param for mainMenuLocation
   - CommonScreens.xml
   - SetupScreens.xml
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@ofbiz.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org