Re: [PR] Improved: Fix cross-app menu location issues (OFBIZ-13035) [ofbiz-plugins]

2024-04-22 Thread via GitHub


JacquesLeRoux merged PR #121:
URL: https://github.com/apache/ofbiz-plugins/pull/121


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@ofbiz.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Improved: Fix cross-app menu location issues (OFBIZ-13035) [ofbiz-plugins]

2024-04-22 Thread via GitHub


JacquesLeRoux commented on PR #121:
URL: https://github.com/apache/ofbiz-plugins/pull/121#issuecomment-2070016829

   Thanks, quite easier


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@ofbiz.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Improved: Fix cross-app menu location issues (OFBIZ-13035) [ofbiz-plugins]

2024-04-22 Thread via GitHub


PierreSmits commented on PR #121:
URL: https://github.com/apache/ofbiz-plugins/pull/121#issuecomment-2069989295

   As a mentioned in the commit message: re calendar screen of a fixed asset
   
   Here is a link in demo-trunk: 
https://demo-trunk.ofbiz.apache.org/assetmaint/control/calendar?fixedAssetId=DEMO_PROJECTOR


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@ofbiz.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Improved: Fix cross-app menu location issues (OFBIZ-13035) [ofbiz-plugins]

2024-04-22 Thread via GitHub


JacquesLeRoux commented on PR #121:
URL: https://github.com/apache/ofbiz-plugins/pull/121#issuecomment-2069961809

   Yes a link will be welcome...


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@ofbiz.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Improved: Fix cross-app menu location issues (OFBIZ-13035) [ofbiz-plugins]

2024-04-21 Thread via GitHub


mbrohl commented on PR #121:
URL: https://github.com/apache/ofbiz-plugins/pull/121#issuecomment-2068051824

   Where is this new parameter be used?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@ofbiz.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Improved: Fix cross-app menu location issues (OFBIZ-13035) [ofbiz-plugins]

2024-04-21 Thread via GitHub


sonarcloud[bot] commented on PR #121:
URL: https://github.com/apache/ofbiz-plugins/pull/121#issuecomment-2068050290

   ## [![Quality Gate 
Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png
 'Quality Gate 
Passed')](https://sonarcloud.io/dashboard?id=apache_ofbiz-plugins=121)
 **Quality Gate passed**  
   Issues  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png
 '') [0 New 
issues](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=121=false=true)
  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/accepted-16px.png
 '') [0 Accepted 
issues](https://sonarcloud.io/component_measures?id=apache_ofbiz-plugins=121=new_accepted_issues=list)
   
   Measures  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png
 '') [0 Security 
Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-plugins=121=false=true)
  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/no-data-16px.png
 '') No data about Coverage  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png
 '') [0.0% Duplication on New 
Code](https://sonarcloud.io/component_measures?id=apache_ofbiz-plugins=121=new_duplicated_lines_density=list)
  
 
   [See analysis details on 
SonarCloud](https://sonarcloud.io/dashboard?id=apache_ofbiz-plugins=121)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@ofbiz.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[PR] Improved: Fix cross-app menu location issues (OFBIZ-13035) [ofbiz-plugins]

2024-04-21 Thread via GitHub


PierreSmits opened a new pull request, #121:
URL: https://github.com/apache/ofbiz-plugins/pull/121

   address cross application menu-location issues.
   
   modified: assetmaint/web.xml
   - added context-param calendarMenuLocation (re calendar screen of a fixed 
asset)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@ofbiz.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Improved: fix cross-app menu location issues (OFBIZ-13035) [ofbiz-plugins]

2024-04-18 Thread via GitHub


JacquesLeRoux merged PR #112:
URL: https://github.com/apache/ofbiz-plugins/pull/112


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@ofbiz.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Improved: fix cross-app menu location issues (OFBIZ-13035) [ofbiz-plugins]

2024-04-17 Thread via GitHub


sonarcloud[bot] commented on PR #112:
URL: https://github.com/apache/ofbiz-plugins/pull/112#issuecomment-2060636990

   ## [![Quality Gate 
Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png
 'Quality Gate 
Passed')](https://sonarcloud.io/dashboard?id=apache_ofbiz-plugins=112)
 **Quality Gate passed**  
   Issues  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png
 '') [0 New 
issues](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=112=false=true)
  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/accepted-16px.png
 '') [0 Accepted 
issues](https://sonarcloud.io/component_measures?id=apache_ofbiz-plugins=112=new_accepted_issues=list)
   
   Measures  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png
 '') [0 Security 
Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-plugins=112=false=true)
  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/no-data-16px.png
 '') No data about Coverage  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png
 '') [0.0% Duplication on New 
Code](https://sonarcloud.io/component_measures?id=apache_ofbiz-plugins=112=new_duplicated_lines_density=list)
  
 
   [See analysis details on 
SonarCloud](https://sonarcloud.io/dashboard?id=apache_ofbiz-plugins=112)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@ofbiz.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[PR] Improved: fix cross-app menu location issues (OFBIZ-13035) [ofbiz-plugins]

2024-04-17 Thread via GitHub


PierreSmits opened a new pull request, #112:
URL: https://github.com/apache/ofbiz-plugins/pull/112

   modified: projectmgr/web.xml
   - added profileMenuLocation


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@ofbiz.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Improved: fix cross-app menu location issues (Ofbiz 13035) [ofbiz-plugins]

2024-04-17 Thread via GitHub


PierreSmits closed pull request #111: Improved: fix cross-app menu location 
issues (Ofbiz 13035)
URL: https://github.com/apache/ofbiz-plugins/pull/111


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@ofbiz.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Improved: fix cross-app menu location issues (Ofbiz 13035) [ofbiz-plugins]

2024-04-17 Thread via GitHub


PierreSmits commented on PR #111:
URL: https://github.com/apache/ofbiz-plugins/pull/111#issuecomment-2060493282

   HI @JacquesLeRoux 
   
   I will look into this. Please do not forget to review/merge related 
https://github.com/apache/ofbiz-framework/pull/771


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@ofbiz.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Improved: fix cross-app menu location issues (Ofbiz 13035) [ofbiz-plugins]

2024-04-16 Thread via GitHub


JacquesLeRoux commented on PR #111:
URL: https://github.com/apache/ofbiz-plugins/pull/111#issuecomment-2059460050

   @PierreSmits 
   
   C:\projectsASF\Git\ofbiz-framework\plugins>git pull
   Already up to date.
   
   C:\projectsASF\Git\ofbiz-framework\plugins>git apply ..\111.patch
   error: patch failed: scrum/webapp/scrum/WEB-INF/web.xml:39
   error: scrum/webapp/scrum/WEB-INF/web.xml: patch does not apply
   error: patch failed: projectmgr/webapp/projectmgr/WEB-INF/web.xml:42
   error: projectmgr/webapp/projectmgr/WEB-INF/web.xml: patch does not apply
   error: patch failed: myportal/webapp/myportal/WEB-INF/web.xml:53
   error: myportal/webapp/myportal/WEB-INF/web.xml: patch does not apply
   error: patch failed: projectmgr/webapp/projectmgr/WEB-INF/web.xml:47
   error: projectmgr/webapp/projectmgr/WEB-INF/web.xml: patch does not apply
   error: patch failed: projectmgr/widget/TimeSheetScreens.xml:231
   error: projectmgr/widget/TimeSheetScreens.xml: patch does not apply
   error: patch failed: scrum/webapp/scrum/WEB-INF/web.xml:44
   error: scrum/webapp/scrum/WEB-INF/web.xml: patch does not apply


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@ofbiz.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Improved: fix cross-app menu location issues (Ofbiz 13035) [ofbiz-plugins]

2024-04-16 Thread via GitHub


JacquesLeRoux commented on PR #111:
URL: https://github.com/apache/ofbiz-plugins/pull/111#issuecomment-2059452116

   Just see my comments at https://issues.apache.org/jira/browse/OFBIZ-13035
   I'll try to apply the patch with Git, not possible with Eclipse.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@ofbiz.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Improved: fix cross-app menu location issues (Ofbiz 13035) [ofbiz-plugins]

2024-04-16 Thread via GitHub


PierreSmits commented on PR #111:
URL: https://github.com/apache/ofbiz-plugins/pull/111#issuecomment-2059448838

   @JacquesLeRoux 
   This should be the last one in plugins (fingers crossed).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@ofbiz.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org