Re: [PR] Improved: HumanRes-Main page (OFBIZ-13050) [ofbiz-framework]
mbrohl closed pull request #779: Improved: HumanRes-Main page (OFBIZ-13050) URL: https://github.com/apache/ofbiz-framework/pull/779 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ofbiz.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Improved: HumanRes-Main page (OFBIZ-13050) [ofbiz-framework]
PierreSmits commented on PR #779: URL: https://github.com/apache/ofbiz-framework/pull/779#issuecomment-2072800179 HI Jacques, Thank you for your review and feedback. I can't tell why the screen separation is as it is. But if that is an issue: a new ticket is warranted. Testing the screen with leaves to the n-th power could be fun exercise (for someone...). Let's try not to make a mountain out of an anthill now. If there ever has been (is) an adopter that had/has that issue (and he/she reported it to this project), I am confident that: 1. that adopter can have an paid developer implementing a solution that fixes the issue. 2. if and when reported to the project, it can be addressed then via a new ticket. But I doubt that the project will ever have to address such. I expect the given adopter to be a SMB enterprise with a hierarchy as flat as possible. Would love to see someone come forward via one of the mailings and say: I have (or work for) a company that uses the HR component of OFBiz for 10s of departments having 10s of sub-departments, with each having 10s of other organizational units thereunder. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ofbiz.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Improved: HumanRes-Main page (OFBIZ-13050) [ofbiz-framework]
JacquesLeRoux commented on PR #779: URL: https://github.com/apache/ofbiz-framework/pull/779#issuecomment-2071653977 The screen separation is static. Did you think about the case where the tree would much grow? What will happen then? The need to see the leaves might be problematic. Even if a horizontal scroolbar appears (did you test that). Because then you have to scrool. I think it's the reason of all this empty space. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ofbiz.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Improved: HumanRes-Main page (OFBIZ-13050) [ofbiz-framework]
JacquesLeRoux commented on PR #779: URL: https://github.com/apache/ofbiz-framework/pull/779#issuecomment-2071645444 Hi Pierre, Sorry, I simply forgot import the data :/ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ofbiz.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Improved: HumanRes-Main page (OFBIZ-13050) [ofbiz-framework]
PierreSmits commented on PR #779: URL: https://github.com/apache/ofbiz-framework/pull/779#issuecomment-2070842051 HI Jacques, Did you clear your cache? Logging out and in again could also help. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ofbiz.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Improved: HumanRes-Main page (OFBIZ-13050) [ofbiz-framework]
JacquesLeRoux commented on PR #779: URL: https://github.com/apache/ofbiz-framework/pull/779#issuecomment-2069939651 Ha, maybe it needs PR121 1st, trying... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ofbiz.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Improved: HumanRes-Main page (OFBIZ-13050) [ofbiz-framework]
JacquesLeRoux commented on PR #779: URL: https://github.com/apache/ofbiz-framework/pull/779#issuecomment-2069927544 Hi @PierreSmits , When applying your PR as patch, I get: > java.lang.RuntimeException: Could not find PortalPage with portalPageId [] -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ofbiz.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Improved: HumanRes-Main page (OFBIZ-13050) [ofbiz-framework]
sonarcloud[bot] commented on PR #779: URL: https://github.com/apache/ofbiz-framework/pull/779#issuecomment-2068082116 ## [](https://sonarcloud.io/dashboard?id=apache_ofbiz-framework=779) **Quality Gate passed** Issues  [0 New issues](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=779=false=true)  [0 Accepted issues](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=779=new_accepted_issues=list) Measures  [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework=779=false=true)  No data about Coverage  [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=779=new_duplicated_lines_density=list) [See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_ofbiz-framework=779) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ofbiz.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] Improved: HumanRes-Main page (OFBIZ-13050) [ofbiz-framework]
PierreSmits opened a new pull request, #779: URL: https://github.com/apache/ofbiz-framework/pull/779 Current main page shows the OrgTree screen in a hard-coded way for about 50% of the available screen. modified: CommonScreens.xml/screen Main - added actions elements to work with PortalPage - added include-portal-page element - removed display conditio -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ofbiz.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
