Re: [PR] Improved: createPlugin - improve process and templates (OFBIZ-13048) [ofbiz-framework]
mbrohl closed pull request #807: Improved: createPlugin - improve process and templates (OFBIZ-13048) URL: https://github.com/apache/ofbiz-framework/pull/807 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ofbiz.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Improved: createPlugin - improve process and templates (OFBIZ-13048) [ofbiz-framework]
mbrohl commented on PR #807: URL: https://github.com/apache/ofbiz-framework/pull/807#issuecomment-2135198391 This needs more review, later... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ofbiz.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Improved: createPlugin - improve process and templates (OFBIZ-13048) [ofbiz-framework]
JacquesLeRoux commented on PR #807: URL: https://github.com/apache/ofbiz-framework/pull/807#issuecomment-2135119725 Hi Pierre, Thanks for your work. How is the > process to generate plugin.properties file from StaticProperties.properties template supposed to work when StaticProperties.properties is empty? There is a duplicate for mainDecoratorLocation in web.xml Please give more information about "the why" of: >added decorator-section 'pre-body', having reference to MainActionMenu and decoration-section-include Same question for Screens.xml Remove > modified: UiLabels.xml template > remove 'it' and 'zh*'' translations > updated 'en' translation for pluginCompanyName It's no longer needed (I'd certainly forgot that else) The rest seems fine to me -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ofbiz.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Improved: createPlugin - improve process and templates (OFBIZ-13048) [ofbiz-framework]
PierreSmits commented on PR #807: URL: https://github.com/apache/ofbiz-framework/pull/807#issuecomment-2133386292 Hi @JacquesLeRoux, I have done this new pr (and closed the previous one relating to the ticket), taking into account: - removal of minilang folder - addressing the UILabel.xml issues. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ofbiz.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Improved: createPlugin - improve process and templates (OFBIZ-13048) [ofbiz-framework]
sonarcloud[bot] commented on PR #807: URL: https://github.com/apache/ofbiz-framework/pull/807#issuecomment-2133386391 ## [](https://sonarcloud.io/dashboard?id=apache_ofbiz-framework=807) **Quality Gate passed** Issues  [0 New issues](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=807=false=true)  [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=807=WONTFIX) Measures  [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework=807=false=true)  No data about Coverage  [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=807=new_duplicated_lines_density=list) [See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_ofbiz-framework=807) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ofbiz.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] Improved: createPlugin - improve process and templates (OFBIZ-13048) [ofbiz-framework]
PierreSmits opened a new pull request, #807: URL: https://github.com/apache/ofbiz-framework/pull/807 With the parameterization of the menu location, improvements to the createPlugin templates are warranted. added: StaticProperties.properties template SystemPropertyData.xml template modified: build.gradle - removed 'minilang' folder, as minilang functions (XML) are deprecated in favour of groovy functions - added process to generate plugin.properties file from StaticProperties.properties template - added process to generate pluginSystemPropertyData.xml file from SystemPropertyData.xml template modified: web.xml template - context-param for mainMenuLocation - improved legibility of other context-params modified: ofbiz-component.xml template - added entity-resource loader for pluginSystemProperties.xml modified: CommonScreens.xml template - changed menu location - added decorator-section 'pre-body', having reference to MainActionMenu and decoration-section-include modified: Menus.xml template - added MainActionMenu modified: controller.xml template - added request-map and view-map for 'New' menu-item in MainActionMenu (Menus.xml template) modified: Screens.xml template - added pre-body decorator section too main screen - added 'New' screen modified: Forms.xml template - added 'New' form modified: UiLabels.xml template - remove 'it' and 'zh*'' translations - updated 'en' translation for pluginCompanyName modified: SecurityPermissionsSeedData.xml - reordering SecurityPermission record definitions modified: SecurityGroupDemoData.xml - changed permission of BIZADMIN groupId -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ofbiz.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Improved: createPlugin - improve process and templates (OFBIZ-13048) [ofbiz-framework]
PierreSmits closed pull request #778: Improved: createPlugin - improve process and templates (OFBIZ-13048) URL: https://github.com/apache/ofbiz-framework/pull/778 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ofbiz.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Improved: createPlugin - improve process and templates (OFBIZ-13048) [ofbiz-framework]
JacquesLeRoux commented on PR #778: URL: https://github.com/apache/ofbiz-framework/pull/778#issuecomment-2131023395 Note: I was started on this by trying to find documentation about createPlugin Gradle task. I did not find any but the explanation of the task itself. I have though to read 8 threads where I'll maybe get some ideas. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ofbiz.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Improved: createPlugin - improve process and templates (OFBIZ-13048) [ofbiz-framework]
JacquesLeRoux commented on PR #778: URL: https://github.com/apache/ofbiz-framework/pull/778#issuecomment-2131001527 Michael's comment has been already addressed with OFBIZ-12813 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ofbiz.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Improved: createPlugin - improve process and templates (OFBIZ-13048) [ofbiz-framework]
JacquesLeRoux commented on PR #778: URL: https://github.com/apache/ofbiz-framework/pull/778#issuecomment-2130989972 Hi Pierre, The 1st thing to do is to address Michael's comment: > Scripts is deprecated also, Groovy files are now in src. Then update your branch by uploading from trunk the changes made with OFBIZ-13094. I thought that by deleting UiLabels.xml in this PR it would resolve the conflicts when it actually much complicated them. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ofbiz.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Improved: createPlugin - improve process and templates (OFBIZ-13048) [ofbiz-framework]
PierreSmits commented on PR #778: URL: https://github.com/apache/ofbiz-framework/pull/778#issuecomment-2121098465 Hi @JacquesLeRoux , Your latest change did to resolve the conflict. For an explanation on choices made, see description of the ticket. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ofbiz.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Improved: createPlugin - improve process and templates (OFBIZ-13048) [ofbiz-framework]
sonarcloud[bot] commented on PR #778: URL: https://github.com/apache/ofbiz-framework/pull/778#issuecomment-2120953997 ## [](https://sonarcloud.io/dashboard?id=apache_ofbiz-framework=778) **Quality Gate passed** Issues  [0 New issues](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=778=false=true)  [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=778=WONTFIX) Measures  [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework=778=false=true)  No data about Coverage  [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=778=new_duplicated_lines_density=list) [See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_ofbiz-framework=778) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ofbiz.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Improved: createPlugin - improve process and templates (OFBIZ-13048) [ofbiz-framework]
JacquesLeRoux commented on PR #778: URL: https://github.com/apache/ofbiz-framework/pull/778#issuecomment-2067919750 Thanks @PierreSmits for your explanation -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ofbiz.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Improved: createPlugin - improve process and templates (OFBIZ-13048) [ofbiz-framework]
mbrohl commented on PR #778: URL: https://github.com/apache/ofbiz-framework/pull/778#issuecomment-2067812978 Please use correct commit according to the template. Scripts is deprecated also, Groovy files are now in src. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ofbiz.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Improved: createPlugin - improve process and templates (OFBIZ-13048) [ofbiz-framework]
PierreSmits commented on PR #778: URL: https://github.com/apache/ofbiz-framework/pull/778#issuecomment-2067782993 Hi @JacquesLeRoux, Thank you for your time to evaluate these changes, and your question. As you can see in https://github.com/apache/ofbiz-framework/pull/778/commits/5c2cdbeaf59e28edbed5ccd5129ed5e3009c818d in the UiLabels template I have changed the English description of - @component-resource-name@CompanyName, and - @component-resource-name@CompanySubtitle. As with these two improvements the translations in the other languages became void, I decided that, with English being the lingua franca for software developers in general and for contributors of ASF projects, it would be better to remove the non-English translations of the other labels too. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ofbiz.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Improved: createPlugin - improve process and templates (OFBIZ-13048) [ofbiz-framework]
JacquesLeRoux commented on PR #778: URL: https://github.com/apache/ofbiz-framework/pull/778#issuecomment-2067598059 Hi @PierreSmits, This is a nice initiative, but why removing other languages than English in framework/resources/templates/UiLabels.xml? They may help some people. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ofbiz.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Improved: createPlugin - improve process and templates (OFBIZ-13048) [ofbiz-framework]
sonarcloud[bot] commented on PR #778: URL: https://github.com/apache/ofbiz-framework/pull/778#issuecomment-2067597684 ## [](https://sonarcloud.io/dashboard?id=apache_ofbiz-framework=778) **Quality Gate passed** Issues  [0 New issues](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=778=false=true)  [0 Accepted issues](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=778=new_accepted_issues=list) Measures  [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework=778=false=true)  No data about Coverage  [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=778=new_duplicated_lines_density=list) [See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_ofbiz-framework=778) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ofbiz.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Improved: createPlugin - improve process and templates (OFBIZ-13048) [ofbiz-framework]
sonarcloud[bot] commented on PR #778: URL: https://github.com/apache/ofbiz-framework/pull/778#issuecomment-2067597091 ## [](https://sonarcloud.io/dashboard?id=apache_ofbiz-framework=778) **Quality Gate passed** Issues  [0 New issues](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=778=false=true)  [0 Accepted issues](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=778=new_accepted_issues=list) Measures  [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework=778=false=true)  No data about Coverage  [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=778=new_duplicated_lines_density=list) [See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_ofbiz-framework=778) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ofbiz.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Improved: createPlugin - improve process and templates (OFBIZ-13048) [ofbiz-framework]
sonarcloud[bot] commented on PR #778: URL: https://github.com/apache/ofbiz-framework/pull/778#issuecomment-2067596815 ## [](https://sonarcloud.io/dashboard?id=apache_ofbiz-framework=778) **Quality Gate passed** Issues  [0 New issues](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=778=false=true)  [0 Accepted issues](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=778=new_accepted_issues=list) Measures  [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework=778=false=true)  No data about Coverage  [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=778=new_duplicated_lines_density=list) [See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_ofbiz-framework=778) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ofbiz.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Improved: createPlugin - improve process and templates (OFBIZ-13048) [ofbiz-framework]
sonarcloud[bot] commented on PR #778: URL: https://github.com/apache/ofbiz-framework/pull/778#issuecomment-2066386712 ## [](https://sonarcloud.io/dashboard?id=apache_ofbiz-framework=778) **Quality Gate passed** Issues  [0 New issues](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=778=false=true)  [0 Accepted issues](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=778=new_accepted_issues=list) Measures  [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework=778=false=true)  No data about Coverage  [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=778=new_duplicated_lines_density=list) [See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_ofbiz-framework=778) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ofbiz.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] Improved: createPlugin - improve process and templates (OFBIZ-13048) [ofbiz-framework]
PierreSmits opened a new pull request, #778: URL: https://github.com/apache/ofbiz-framework/pull/778 With the parameterization of the menu location, improvements to the createPlugin templates are warranted. added: StaticProperties.properties template SystemPropertyData.xml template modified: build.gradle - renamed 'minilang' folder to 'scripts', as minilang functions (XML) are deprecated in favour of groovy functions - added process to generate plugin.properties file from StaticProperties.properties template - added process to generate pluginSystemPropertyData.xml file from SystemPropertyData.xml template modified: web.xml template - context-param for mainMenuLocation - improved legibility of other context-params modified: ofbiz-component.xml template - added entity-resource loader for pluginSystemProperties.xml - addd modified: CommonScreens.xml template - changed menu location - added decorator-section 'pre-body', having reference to MainActionMenu and decoration-section-include modified: Menus.xml template - added MainActionMenu modified: controller.xml template - added request-map and view-map for 'New' menu-item in MainActionMenu (Menus.xml template) modified: Screens.xml template - added pre-body decorator section too main screen - added 'New' screen modified: Forms.xml template - added 'New' form modified: UiLabels.xml template - remove 'it' and 'zh*'' translations - updated 'en' translation for pluginCompanyName modified: SecurityPermissionsSeedData.xml - reordering SecurityPermission record definitions modified: SecurityGroupDemoData.xml - changed permission of BIZADMIN groupId -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ofbiz.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
