[jira] [Closed] (OFBIZ-9846) Replace Inline js with External js in renderFormClose macro

2018-05-27 Thread Jacques Le Roux (JIRA) 

 [ 
https://issues.apache.org/jira/browse/OFBIZ-9846?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux closed OFBIZ-9846.
--
Resolution: Implemented

> Replace Inline js with External js in renderFormClose macro
> ---
>
> Key: OFBIZ-9846
> URL: https://issues.apache.org/jira/browse/OFBIZ-9846
> Project: OFBiz
>  Issue Type: Sub-task
>Affects Versions: Trunk
>Reporter: Aditya Sharma
>Assignee: Jacques Le Roux
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-9846.patch, OFBIZ-9846.patch
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Closed] (OFBIZ-9846) Replace Inline js with External js in renderFormClose macro

2018-05-27 Thread Jacques Le Roux (JIRA) 

 [ 
https://issues.apache.org/jira/browse/OFBIZ-9846?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux closed OFBIZ-9846.
--
Resolution: Fixed

Thanks Aditya,

My bad too, I could have found it while reviewing, but I also -sometimes- often 
forget the other macro libraries. Sometimes it passes unnoticed, but that's not 
better.

Anyway your patch is in revision: 1832365  and that's what's most important :)


> Replace Inline js with External js in renderFormClose macro
> ---
>
> Key: OFBIZ-9846
> URL: https://issues.apache.org/jira/browse/OFBIZ-9846
> Project: OFBiz
>  Issue Type: Sub-task
>Affects Versions: Trunk
>Reporter: Aditya Sharma
>Assignee: Aditya Sharma
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-9846.patch, OFBIZ-9846.patch
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Closed] (OFBIZ-9846) Replace Inline js with External js in renderFormClose macro

2018-05-26 Thread Jacques Le Roux (JIRA) 

 [ 
https://issues.apache.org/jira/browse/OFBIZ-9846?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux closed OFBIZ-9846.
--
   Resolution: Implemented
Fix Version/s: Upcoming Branch

Thanks Aditya,

Great job, took me a moment to review :) Also because I had some still pending 
(unrelated) changes.

Your silghtly modifed patch is in trunk at revision: 1832307  

I simply removed from rainbowstone HtmlMenuMacroLibrary.ftl 
<#--<#if parameterList?has_content>-->
<#--<#list parameterList as parameter>-->
<#--<#local params += ",'${parameter.name}': 
'${parameter.value}'">-->
<#>
<#>
Not sure why you kept it, I guess it was forgotten after working on it, please 
check

> Replace Inline js with External js in renderFormClose macro
> ---
>
> Key: OFBIZ-9846
> URL: https://issues.apache.org/jira/browse/OFBIZ-9846
> Project: OFBiz
>  Issue Type: Sub-task
>Affects Versions: Trunk
>Reporter: Aditya Sharma
>Assignee: Jacques Le Roux
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-9846.patch
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)