[jira] [Comment Edited] (OFBIZ-12405) Rename invoiceApplications menu-item label to Payments
[
https://issues.apache.org/jira/browse/OFBIZ-12405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17451102#comment-17451102
]
Pierre Smits edited comment on OFBIZ-12405 at 11/30/21, 1:30 PM:
-
Bon après-midi Jacques,
{noformat}
I finally think that Pierre's is right and we could simply use Payments there
rather than Applications and even "Payments applications" (could be
debated...){noformat}
So, finaly, you concede that I was correct. You doubted me, despite the fact
that I had told you way back when (even on OFBiz ML) that I did my studies in
accounting, worked for an CPA (auditing accounting books, etc.) and had a
career as a Financial Controller in sectors like retail, manufacturing and
project organisations… So I know the accounting lingo, having worked not only
in companies that used the Dutch variant, but also in international companies
using English and/or German.
But still, despite the fact that you gave in that I was correct about *Invoice
Payments* and thus my contribution was good ** , you still went ahead and
* changed the label in the invoiceSubTabBar to AccountingPaymentApplications.
* changed the label definition from AccountingApplications to
AccountingPaymentApplications, while at the same changing the translation for
English from Applications (which is correct) to Payments (which is incorrect,
applications != payments), and changed the French translation from
'Enregristrements' to Enrigestrements des Paiements'', which both translate to
'Registrations' and 'Registrations of Payments', not applications (in French:
l'application)
In PaymentsScreens.xml the use of the Label AccountingApplications was correct,
as in
{code:java}
{code}
With the change to
{code:java}
{code}
You didn't improved it. You made it worse.
A Payment can be applicable to more than just an invoice. It can be applicable
to a salary slip, a reimbursement of a voucher, etc.
What a waste of precious time you cost us both. Rendering perfectly good
commits and PR useless
And now with this [ 4aa2d71
|https://github.com/apache/ofbiz-framework/commit/4aa2d714328447787455abcd5887ca99bcbf1152]
, while together with Michael complaining at my address ‘repeatedly and
annoyingly’ in other tickets (and PRs), about mixing stuff (beyond a single
ticket and/or PR) in commits, you do exactly that.
was (Author: pfm.smits):
Bon après-midi Jacques,
{noformat}
I finally think that Pierre's is right and we could simply use Payments there
rather than Applications and even "Payments applications" (could be
debated...){noformat}
So, finaly, you concede that I was correct. You doubted me, despite the fact
that I had told you way back when (even on OFBiz ML) that I did my studies in
accounting, worked for an CPA (auditing accounting books, etc.) and had a
career as a Financial Controller in sectors like retail, manufacturing and
project organisations…
But still, despite the fact that you gave in that I was correct about *Invoice
Payments* and thus my contribution was good ** , you still went ahead and
* changed the label in the invoiceSubTabBar to AccountingPaymentApplications.
* changed the label definition from AccountingApplications to
AccountingPaymentApplications, while at the same changing the translation for
English from Applications (which is correct) to Payments (which is incorrect,
applications != payments), and changed the French translation from
'Enregristrements' to Enrigestrements des Paiements'', which both translate to
'Registrations' and 'Registrations of Payments', not applications (in French:
l'application)
In PaymentsScreens.xml the use of the Label AccountingApplications was correct,
as in
{code:java}
{code}
With the change to
{code:java}
{code}
You didn't improved it. You made it worse.
A Payment can be applicable to more than just an invoice. It can be applicable
to a salary slip, a reimbursement of a voucher, etc.
What a waste of precious time you cost us both. Rendering perfectly good
commits and PR useless
And now with this [ 4aa2d71
|https://github.com/apache/ofbiz-framework/commit/4aa2d714328447787455abcd5887ca99bcbf1152]
, while together with Michael complaining at my address ‘repeatedly and
annoyingly’ in other tickets (and PRs), about mixing stuff (beyond a single
ticket and/or PR) in commits, you do exactly that.
> Rename invoiceApplications menu-item label to Payments
> --
>
> Key: OFBIZ-12405
> URL: https://issues.apache.org/jira/browse/OFBIZ-12405
> Project: OFBiz
> Issue Type: Improvement
> Components: accounting
>Affects Versions: Trunk
>Reporter: Pierre Smits
>Assignee: Pierre Smits
>Priority: Major
> Labels: invoice, usability
>
> Application(s) is generic
[jira] [Comment Edited] (OFBIZ-12405) Rename invoiceApplications menu-item label to Payments
[ https://issues.apache.org/jira/browse/OFBIZ-12405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17451108#comment-17451108 ] Pierre Smits edited comment on OFBIZ-12405 at 11/30/21, 1:04 PM: - Please revert commit [4aa2d71|https://github.com/apache/ofbiz-framework/commit/4aa2d714328447787455abcd5887ca99bcbf1152] and merge the PR associated with this ticket. was (Author: pfm.smits): Please revert commit [ 4aa2d71 |https://github.com/apache/ofbiz-framework/commit/4aa2d714328447787455abcd5887ca99bcbf1152] > Rename invoiceApplications menu-item label to Payments > -- > > Key: OFBIZ-12405 > URL: https://issues.apache.org/jira/browse/OFBIZ-12405 > Project: OFBiz > Issue Type: Improvement > Components: accounting >Affects Versions: Trunk >Reporter: Pierre Smits >Assignee: Pierre Smits >Priority: Major > Labels: invoice, usability > > Application(s) is generic (also used within contexts elsewhere) in OFBiz. > Users have a better perception of context when looking at a menu-item > Payments in the screen of an invoice, than seeing Applications. > The additional benefit for developers is that with the implemented change the > tech come closer to the language of the user -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Comment Edited] (OFBIZ-12405) Rename invoiceApplications menu-item label to Payments
[
https://issues.apache.org/jira/browse/OFBIZ-12405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17449567#comment-17449567
]
Jacques Le Roux edited comment on OFBIZ-12405 at 11/26/21, 1:21 PM:
OK, it seems we have some time to spent on this.
A famous author asked this question: "What's in a name?". His answer was that
it's irrelevant* and I more than agree with that**.
What I mean is end users will never see the name of the label
(AccountingApplications). Only developpers will see it and that does not count
much. What end users will see, and is important, is the translation in their
languages. We should not confuse syntax (name) and semantic (content).
Now about the content, AccountingApplications is used in 3 places:
# menu-item name="editInvoiceApplications"
# Two containers in screen name="EditPayment" with respectively conditions:
vs
First let's analyze #1. You say
{quote}These translations would be more appropriate for a trigger (button,
menu-item in an menu for action to be performed) and thus for a specific label
(if not already present, I did not check), not for a menu-item intended to show
an overview of payments associated to an invoice.
{quote}
That's simply wrong. This menu-item does not show when an invoice has been paid
(ie all payments are applied to the invoice). It shows when no payments are
applied to the invoice. Depending on the status of the invoice (at least
Approved or In-Process) it respectively leads to
# a screen which title is: "Assign Payment to This Invoice". So "Payment
application" is appropriate there.-
# a screen which title is: "Possible payments to apply [payer] sent from
[recipient]" (combination of AccountingListPaymentsNotYetApplied and
AccountingPaymentSentForm labels) So "Payment application" is also appropriate
there.-
In both cases the mention "No applications found.." is shown
I let you analyse #2 and possibly #1 more. It seems to me we are going a bit
too deep for such a trivial issue, when there are much more important ones
waiting...
For AccountingApplicationSuccess, we need 1st to agree (or definitely not)
about what to do about AccountingApplications before speaking again about
that...
Don't expect more comments on this from me...
\* "That which we call a rose by any other name would smell just as sweet."
\** For the fun: my name is "Le Roux", it means "The Redhead", but my hairs are
black. Not only names (syntax) can be irrelevant but sometimes wrong. That's
not a problem, what's count is their content (semantic), here me :)
was (Author: jacques.le.roux):
OK, it seems we have some time to spent on this.
A famous author asked this question: "What's in a name?". His answer was that
it's irrelevant* and I more than agree with that**.
What I mean is end users will never see the name of the label
(AccountingApplications). Only developpers will see it and that does not count
much. What end users will see, and is important, is the translation in their
languages. We should not confuse syntax (name) and semantic (content).
Now about the content, AccountingApplications is used in 3 places:
# menu-item name="editInvoiceApplications"
# Two containers in screen name="EditPayment" with respectively conditions:
vs
First let's analyze #1. You say
{quote}These translations would be more appropriate for a trigger (button,
menu-item in an menu for action to be performed) and thus for a specific label
(if not already present, I did not check), not for a menu-item intended to show
an overview of payments associated to an invoice.
{quote}
That's simply wrong. This menu-item does not show when an invoice has been paid
(ie all payments are applied to the invoice). It shows when no payments are
applied to the invoice. Depending on the status of the invoice (at least
Approved or In-Process) it respectively leads to
# a screen which title is: "Assign Payment to This Invoice". So "Payment
application" is appropriate there.-
# a screen which title is: "Possible payments to apply [payer] sent from
[recipient]" (combination of AccountingListPaymentsNotYetApplied and
AccountingPaymentSentForm labels) So "Payment application" is also appropriate
there.-
In both cases the mention "No applications found.." is shown
I let you analyse #2 and possibly #1 more. It seems to me we are going a bit
too deep for such a trivial issue, when there are much more important ones
waiting...
For AccountingApplicationSuccess, we need 1st to agree (or definitely not)
about what to do about AccountingApplications before speaking again about
that...
Don't expect more comments on this from me...
* "That which we call a rose by any other name would smell just as sweet."
** For the fun: my name is "Le Roux", it means "The Redhead", but my hairs are
black. Not only names (syntax) can be irrelevant but sometimes wrong. That's
not a problem,
[jira] [Comment Edited] (OFBIZ-12405) Rename invoiceApplications menu-item label to Payments
[
https://issues.apache.org/jira/browse/OFBIZ-12405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17449475#comment-17449475
]
Jacques Le Roux edited comment on OFBIZ-12405 at 11/26/21, 9:23 AM:
Hi Pierre,
I don't know much about the terms used in English accounting. If I refer to
https://www.quora.com/What-is-the-difference-between-a-payment-application-invoice-and-Running-Accounts-Bill-in-construction-industry
I'm not sure we should change that this way. Quoting it:
bq. Payment application is when a received payment is applied to an account
balance.
For me, the payment alone is the action of a person sending some money to sold
out an invoice. Which is different from applying a received payment to an
account balance (aka an invoice for me).
So, since we are in nitpicking and I have all the time for that, I propose
rather to change the label to "Payment
application" in English and (eg) "Enregistrer un paiement" in French.
You may also want to check AccountingApplicationSuccess. There I propose
inFrench: "Enregistrer ${amountApplied?currency(${isoCode})} du paiement
[${paymentId}] � ${toMessage}"
HTH
was (Author: jacques.le.roux):
Hi Pierre,
I don't know much about the terms used in English accounting. If I refer to
https://www.quora.com/What-is-the-difference-between-a-payment-application-invoice-and-Running-Accounts-Bill-in-construction-industry
I'm not sure we should change that this way. Quoting it:
bq. Payment application is when a received payment is applied to an account
balance.
For mee, the payment alone is the action of a person sending some money to sold
out an invoice. Which is different from applying a received payment to an
account balance (aka an invoice for me).
So, since we are in nitpicking and I have all the time for that, I propose
rather to change the label to "Payment
application" in English and (eg) "Enregistrer un paiement" in French.
You may also want to check AccountingApplicationSuccess. There I propose
inFrench: "Enregistrer ${amountApplied?currency(${isoCode})} du paiement
[${paymentId}] � ${toMessage}"
HTH
> Rename invoiceApplications menu-item label to Payments
> --
>
> Key: OFBIZ-12405
> URL: https://issues.apache.org/jira/browse/OFBIZ-12405
> Project: OFBiz
> Issue Type: Improvement
> Components: accounting
>Affects Versions: Trunk
>Reporter: Pierre Smits
>Assignee: Pierre Smits
>Priority: Major
> Labels: invoice, usability
>
> Application(s) is generic (also used within contexts elsewhere) in OFBiz.
> Users have a better perception of context when looking at a menu-item
> Payments in the screen of an invoice, than seeing Applications.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
