[jira] [Commented] (OFBIZ-10215) Configure invoice templates for an organizational party
[
https://issues.apache.org/jira/browse/OFBIZ-10215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17675976#comment-17675976
]
ASF subversion and git services commented on OFBIZ-10215:
-
Commit 1765c311f60ee40190b1d4ae82b37252dde2f106 in ofbiz-framework's branch
refs/heads/release22.01 from Jacques Le Roux
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=1765c311f6 ]
Fixed: Accounting Invoice Overview - PDF failed (OFBIZ-12735)
>hen clicking “PDF” button in the invoice view, it failed with a StackOverflow
A quick fix in DocTypeTemplate.groovy:
in def getCustomScreenTemplate()
Change:
parentTypeValue = from(entityTypeName).where().cache().queryFirst().parentTypeId
To:
String parentTypeValue =
from(entityTypeName)
.where("invoiceTypeId", fieldTypeValue)
.cache()
.queryFirst()
.parentTypeId
jleroux: I noticed this Ingo's not applied patch at OFBIZ-10215:
https://issues.apache.org/jira/secure/attachment/13045313/DocTypeTemplate-1.patch
It's very similar to Yannong's but a bit more general. We don't need to worry
about the 3 types (invoice, order, quote). It's already handled.
I also formatted getCustomScreenTemplate()
Thanks: Yannong Huang for report a proposition fic
> Configure invoice templates for an organizational party
> ---
>
> Key: OFBIZ-10215
> URL: https://issues.apache.org/jira/browse/OFBIZ-10215
> Project: OFBiz
> Issue Type: Sub-task
> Components: accounting
>Affects Versions: Trunk, Upcoming Branch
>Reporter: Nicolas Malin
>Assignee: Nicolas Malin
>Priority: Minor
> Fix For: 22.01.01
>
> Attachments: CustomScreen.xml, DocTypeTemplate-1.patch,
> DocTypeTemplate.patch, InvQuoOrd.patch, InvoiceTemplate.patch,
> InvoiceTemplateWithTest.patch, OFBIZ-10215-1.patch, OFBIZ-10215.patch,
> PartyPrefDocTypeTpl.xml
>
>
> Possibility to select your invoice template from a custom screen.
> Implement three screen possibilities :
> * default : current InvoicePDF
> * content : import the template from a content
> * tax line : detail the tax related to an invoice line
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (OFBIZ-10215) Configure invoice templates for an organizational party
[
https://issues.apache.org/jira/browse/OFBIZ-10215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17675949#comment-17675949
]
ASF subversion and git services commented on OFBIZ-10215:
-
Commit 5f11ebad2d097d49d972b4a02bfa33380e6fb951 in ofbiz-framework's branch
refs/heads/trunk from Jacques Le Roux
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=5f11ebad2d ]
Fixed: Accounting Invoice Overview - PDF failed (OFBIZ-12735)
>hen clicking “PDF” button in the invoice view, it failed with a StackOverflow
A quick fix in DocTypeTemplate.groovy:
in def getCustomScreenTemplate()
Change:
parentTypeValue = from(entityTypeName).where().cache().queryFirst().parentTypeId
To:
String parentTypeValue =
from(entityTypeName)
.where("invoiceTypeId", fieldTypeValue)
.cache()
.queryFirst()
.parentTypeId
jleroux: I noticed this Ingo's not applied patch at OFBIZ-10215:
https://issues.apache.org/jira/secure/attachment/13045313/DocTypeTemplate-1.patch
It's very similar to Yannong's but a bit more general. We don't need to worry
about the 3 types (invoice, order, quote). It's already handled.
I also formatted getCustomScreenTemplate()
Thanks: Yannong Huang for report a proposition fic
> Configure invoice templates for an organizational party
> ---
>
> Key: OFBIZ-10215
> URL: https://issues.apache.org/jira/browse/OFBIZ-10215
> Project: OFBiz
> Issue Type: Sub-task
> Components: accounting
>Affects Versions: Trunk, Upcoming Branch
>Reporter: Nicolas Malin
>Assignee: Nicolas Malin
>Priority: Minor
> Fix For: 22.01.01
>
> Attachments: CustomScreen.xml, DocTypeTemplate-1.patch,
> DocTypeTemplate.patch, InvQuoOrd.patch, InvoiceTemplate.patch,
> InvoiceTemplateWithTest.patch, OFBIZ-10215-1.patch, OFBIZ-10215.patch,
> PartyPrefDocTypeTpl.xml
>
>
> Possibility to select your invoice template from a custom screen.
> Implement three screen possibilities :
> * default : current InvoicePDF
> * content : import the template from a content
> * tax line : detail the tax related to an invoice line
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (OFBIZ-10215) Configure invoice templates for an organizational party
[ https://issues.apache.org/jira/browse/OFBIZ-10215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17556395#comment-17556395 ] Ingo Wolfmayr commented on OFBIZ-10215: --- [~nmalin] There is a mistake in the groovy file. I create a patch. * Return null if parent is null. * Query for parent type ignores current type and takes the first > Configure invoice templates for an organizational party > --- > > Key: OFBIZ-10215 > URL: https://issues.apache.org/jira/browse/OFBIZ-10215 > Project: OFBiz > Issue Type: Sub-task > Components: accounting >Affects Versions: Trunk, Upcoming Branch >Reporter: Nicolas Malin >Assignee: Nicolas Malin >Priority: Minor > Fix For: 22.01.01 > > Attachments: CustomScreen.xml, DocTypeTemplate-1.patch, > DocTypeTemplate.patch, InvQuoOrd.patch, InvoiceTemplate.patch, > InvoiceTemplateWithTest.patch, OFBIZ-10215-1.patch, OFBIZ-10215.patch, > PartyPrefDocTypeTpl.xml > > > Possibility to select your invoice template from a custom screen. > Implement three screen possibilities : > * default : current InvoicePDF > * content : import the template from a content > * tax line : detail the tax related to an invoice line -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Commented] (OFBIZ-10215) Configure invoice templates for an organizational party
[ https://issues.apache.org/jira/browse/OFBIZ-10215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17542022#comment-17542022 ] ASF subversion and git services commented on OFBIZ-10215: - Commit 4d035a554bf01abfaf1cd99f485d6a1d28c0a647 in ofbiz-framework's branch refs/heads/trunk from Nicolas Malin [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=4d035a554b ] Implemented: Configure invoice, quote and order templates for an organizational party (OFBIZ-10215) (OFBIZ-10216) (OFBIZ-10217) Add the possibility to print invoice, quote and order as pdf from the organizational party configuration. With this you can define your own xslfo template connected to a custom screen and configure it for each organization through PartyPrefDocTypeTpl Thanks to Ingo Wolfmayr for patch submission > Configure invoice templates for an organizational party > --- > > Key: OFBIZ-10215 > URL: https://issues.apache.org/jira/browse/OFBIZ-10215 > Project: OFBiz > Issue Type: Sub-task > Components: accounting >Affects Versions: Trunk, Upcoming Branch >Reporter: Nicolas Malin >Assignee: Nicolas Malin >Priority: Minor > Fix For: 22.01.01 > > Attachments: CustomScreen.xml, DocTypeTemplate.patch, > InvQuoOrd.patch, InvoiceTemplate.patch, InvoiceTemplateWithTest.patch, > OFBIZ-10215-1.patch, OFBIZ-10215.patch, PartyPrefDocTypeTpl.xml > > > Possibility to select your invoice template from a custom screen. > Implement three screen possibilities : > * default : current InvoicePDF > * content : import the template from a content > * tax line : detail the tax related to an invoice line -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Commented] (OFBIZ-10215) Configure invoice templates for an organizational party
[ https://issues.apache.org/jira/browse/OFBIZ-10215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17542018#comment-17542018 ] ASF subversion and git services commented on OFBIZ-10215: - Commit 0af153a75046b3c307e5c6fe6f2361d3d1de8e4b in ofbiz-framework's branch refs/heads/release22.01 from Nicolas Malin [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=0af153a750 ] Implemented: Configure invoice, quote and order templates for an organizational party (OFBIZ-10215) (OFBIZ-10216) (OFBIZ-10217) Add the possibility to print invoice, quote and order as pdf from the organizational party configuration. With this you can define your own xslfo template connected to a custom screen and configure it for each organization through PartyPrefDocTypeTpl Thanks to Ingo Wolfmayr for patch submission > Configure invoice templates for an organizational party > --- > > Key: OFBIZ-10215 > URL: https://issues.apache.org/jira/browse/OFBIZ-10215 > Project: OFBiz > Issue Type: Sub-task > Components: accounting >Affects Versions: Trunk, Upcoming Branch >Reporter: Nicolas Malin >Assignee: Nicolas Malin >Priority: Minor > Attachments: CustomScreen.xml, DocTypeTemplate.patch, > InvQuoOrd.patch, InvoiceTemplate.patch, InvoiceTemplateWithTest.patch, > OFBIZ-10215-1.patch, OFBIZ-10215.patch, PartyPrefDocTypeTpl.xml > > > Possibility to select your invoice template from a custom screen. > Implement three screen possibilities : > * default : current InvoicePDF > * content : import the template from a content > * tax line : detail the tax related to an invoice line -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Commented] (OFBIZ-10215) Configure invoice templates for an organizational party
[ https://issues.apache.org/jira/browse/OFBIZ-10215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17540787#comment-17540787 ] Ingo Wolfmayr commented on OFBIZ-10215: --- Hello [~nmalin] , I think it is fine and can be pushed. Thanks for your effort! Ingo > Configure invoice templates for an organizational party > --- > > Key: OFBIZ-10215 > URL: https://issues.apache.org/jira/browse/OFBIZ-10215 > Project: OFBiz > Issue Type: Sub-task > Components: accounting >Affects Versions: Trunk, Upcoming Branch >Reporter: Nicolas Malin >Assignee: Nicolas Malin >Priority: Minor > Attachments: CustomScreen.xml, DocTypeTemplate.patch, > InvQuoOrd.patch, InvoiceTemplate.patch, InvoiceTemplateWithTest.patch, > OFBIZ-10215-1.patch, OFBIZ-10215.patch, PartyPrefDocTypeTpl.xml > > > Possibility to select your invoice template from a custom screen. > Implement three screen possibilities : > * default : current InvoicePDF > * content : import the template from a content > * tax line : detail the tax related to an invoice line -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Commented] (OFBIZ-10215) Configure invoice templates for an organizational party
[ https://issues.apache.org/jira/browse/OFBIZ-10215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17540210#comment-17540210 ] Nicolas Malin commented on OFBIZ-10215: --- Hello [~iwolf] , I review your patch and operate some correction : * move the script on commonext * fixe some issue on defaut screen way * FK failure on demo data With this all seems to be good. If it's ok for your part I can push it [^OFBIZ-10215.patch] > I think it would be a good idea to but the > "orderTypeId/quoteTypeId/invoiceTypeId" into a generic column (for example: > sourceTypeId). We could then add entries for request, shipmentmanifest, > packlist ... I don't think so, my view is a beautyfull bad good idea :) . By the past I realized this on generic system to link some element and in usage it became a nightmare to maintain and usage. I prefer to have new field for each document type that we would be manage and ensure the good FK link. Nicolas > Configure invoice templates for an organizational party > --- > > Key: OFBIZ-10215 > URL: https://issues.apache.org/jira/browse/OFBIZ-10215 > Project: OFBiz > Issue Type: Sub-task > Components: accounting >Affects Versions: Trunk, Upcoming Branch >Reporter: Nicolas Malin >Assignee: Nicolas Malin >Priority: Minor > Attachments: CustomScreen.xml, DocTypeTemplate.patch, > InvQuoOrd.patch, InvoiceTemplate.patch, InvoiceTemplateWithTest.patch, > OFBIZ-10215-1.patch, OFBIZ-10215.patch, PartyPrefDocTypeTpl.xml > > > Possibility to select your invoice template from a custom screen. > Implement three screen possibilities : > * default : current InvoicePDF > * content : import the template from a content > * tax line : detail the tax related to an invoice line -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Commented] (OFBIZ-10215) Configure invoice templates for an organizational party
[ https://issues.apache.org/jira/browse/OFBIZ-10215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17538736#comment-17538736 ] Ingo Wolfmayr commented on OFBIZ-10215: --- Hello [~nmalin] I created a patch including invoice/order/quote with the current logic. I think it would be a good idea to but the "orderTypeId/quoteTypeId/invoiceTypeId" into a generic column (for example: sourceTypeId). We could then add entries for request, shipmentmanifest, packlist ... I would also create a single DocTypeTemplate.groovy file instead of one file for each template (order, quote, invoice ...). What do you think. > Configure invoice templates for an organizational party > --- > > Key: OFBIZ-10215 > URL: https://issues.apache.org/jira/browse/OFBIZ-10215 > Project: OFBiz > Issue Type: Sub-task > Components: accounting >Affects Versions: Trunk, Upcoming Branch >Reporter: Nicolas Malin >Assignee: Nicolas Malin >Priority: Minor > Attachments: CustomScreen.xml, InvQuoOrd.patch, > InvoiceTemplate.patch, InvoiceTemplateWithTest.patch, OFBIZ-10215.patch, > PartyPrefDocTypeTpl.xml > > > Possibility to select your invoice template from a custom screen. > Implement three screen possibilities : > * default : current InvoicePDF > * content : import the template from a content > * tax line : detail the tax related to an invoice line -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Commented] (OFBIZ-10215) Configure invoice templates for an organizational party
[ https://issues.apache.org/jira/browse/OFBIZ-10215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17526420#comment-17526420 ] Ingo Wolfmayr commented on OFBIZ-10215: --- Hello @[~nmalin] thanks for reviewing. I can confirm that your patch works. > Configure invoice templates for an organizational party > --- > > Key: OFBIZ-10215 > URL: https://issues.apache.org/jira/browse/OFBIZ-10215 > Project: OFBiz > Issue Type: Sub-task > Components: accounting >Affects Versions: Trunk, Upcoming Branch >Reporter: Nicolas Malin >Assignee: Nicolas Malin >Priority: Minor > Attachments: CustomScreen.xml, InvoiceTemplate.patch, > InvoiceTemplateWithTest.patch, OFBIZ-10215.patch, PartyPrefDocTypeTpl.xml > > > Possibility to select your invoice template from a custom screen. > Implement three screen possibilities : > * default : current InvoicePDF > * content : import the template from a content > * tax line : detail the tax related to an invoice line -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Commented] (OFBIZ-10215) Configure invoice templates for an organizational party
[ https://issues.apache.org/jira/browse/OFBIZ-10215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17526398#comment-17526398 ] Nicolas Malin commented on OFBIZ-10215: --- Hello [~iwolf] Thanks for your proposal. I reviewed it and thinks it a good way. I rewrite some part to submit this on trunk [^OFBIZ-10215.patch] Just a remark, the CustomScreen entity manage the screen name and the screen location, it's not necessary to use a combined string. I correct this on my suggest patch > Configure invoice templates for an organizational party > --- > > Key: OFBIZ-10215 > URL: https://issues.apache.org/jira/browse/OFBIZ-10215 > Project: OFBiz > Issue Type: Sub-task > Components: accounting >Affects Versions: Trunk, Upcoming Branch >Reporter: Nicolas Malin >Assignee: Nicolas Malin >Priority: Minor > Attachments: CustomScreen.xml, InvoiceTemplate.patch, > InvoiceTemplateWithTest.patch, OFBIZ-10215.patch, PartyPrefDocTypeTpl.xml > > > Possibility to select your invoice template from a custom screen. > Implement three screen possibilities : > * default : current InvoicePDF > * content : import the template from a content > * tax line : detail the tax related to an invoice line -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Commented] (OFBIZ-10215) Configure invoice templates for an organizational party
[ https://issues.apache.org/jira/browse/OFBIZ-10215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17525602#comment-17525602 ] Ingo Wolfmayr commented on OFBIZ-10215: --- Hi, I have attached my code proposal for finding the invoice template using the PartyPrefDocyypeTpl screen logic that can be found here: /accounting/control/ListPartyPrefDocTypeTpl?partyId=company If no entry can be found, it uses the default screen - so for anyone not using this feature, nothing changes - it is just overriding the default. *For testing:* InvoiceTemplateWithTest.patch includes a test InvoicePDF template with missing headers just to see the difference. Test-entities for import: CustomScreen.xml PartyPrefDocTypeTpl.xml Best regards, Ingo > Configure invoice templates for an organizational party > --- > > Key: OFBIZ-10215 > URL: https://issues.apache.org/jira/browse/OFBIZ-10215 > Project: OFBiz > Issue Type: Sub-task > Components: accounting >Affects Versions: Trunk, Upcoming Branch >Reporter: Nicolas Malin >Assignee: Nicolas Malin >Priority: Minor > Attachments: CustomScreen.xml, InvoiceTemplate.patch, > InvoiceTemplateWithTest.patch, PartyPrefDocTypeTpl.xml > > > Possibility to select your invoice template from a custom screen. > Implement three screen possibilities : > * default : current InvoicePDF > * content : import the template from a content > * tax line : detail the tax related to an invoice line -- This message was sent by Atlassian Jira (v8.20.7#820007)
