[jira] [Commented] (OFBIZ-10317) Allowing XML-RPC and SOAP to pass GenericValue objects to services as IN fields

2018-03-24 Thread Rajesh Kumar Mallah (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-10317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16412515#comment-16412515
 ] 

Rajesh Kumar Mallah commented on OFBIZ-10317:
-

There is a  class Converters in package org.apache.ofbiz.base.conversion 
which is being consulted in the conversion attempt (and bailing out currently)

 

{{2018-03-24 15:57:07,914 |http-nio-8443-exec-2 |*Converters* |W| *** No 
converter found, converting from java.util.HashMap to 
org.apache.ofbiz.entity.Gen}}
{{ericValue. Please report this message to the developer community so a 
suitable converter can be created. ***}}
{{2018-03-24 15:57:07,914 |http-nio-8443-exec-2 |ObjectType |I| No type 
conversion available for java.util.HashMap to 
org.apache.ofbiz.entity.GenericVal}}
{{ue, returning original object.}}

 

 

> Allowing XML-RPC and SOAP to pass GenericValue objects to services as IN 
> fields
> ---
>
> Key: OFBIZ-10317
> URL: https://issues.apache.org/jira/browse/OFBIZ-10317
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework/webtools
>Affects Versions: 16.11.04
>Reporter: Rajesh Kumar Mallah
>Priority: Major
>
>  
> The existing framework allows invoking  various services via XMLRPC or SOAP 
> as per their argument expectations. However only basic types are handled
> like String , Boolean , Int etc. If a service is expecting a GenericValue eg: 
> 'calculateProductPrice'   it is not possible to invoke it via SOAP or XMLRPC.
> The reason being SOAP or XMLRPC can support Map and that is the closest 
> it can provide in lieu of any custom Object that a Service might be expecting.
> A generic solution needs to be found so that the full potential of the 
> plethora of 
> exportable services can be utilized by external systems that looks for 
> integrating and 
> banking upon OfBiz via XMLRPC or SOAP.
> h6. related Threads:
> [How to pass org.apache.ofbiz.entity.GenericValue using XMLRPC]
> [https://markmail.org/message/dwako4nsu4h3zgmu] [ dev ]
> [https://markmail.org/message/iuffmakor3ru2yce] [user]
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10317) Allowing XML-RPC and SOAP to pass GenericValue objects to services as IN fields

2018-03-27 Thread Taher Alkhateeb (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-10317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16415494#comment-16415494
 ] 

Taher Alkhateeb commented on OFBIZ-10317:
-

Hi Rajesh,

The first thing we need to do is create a test script to repeat the break. 
>From there we can start to find solutions.

So my recommendation to start on this task is to create a test script (in 
groovy or python or whatever) that utilizes XML RPC to generate the error. We 
can use that same script to test our solutions later on.

> Allowing XML-RPC and SOAP to pass GenericValue objects to services as IN 
> fields
> ---
>
> Key: OFBIZ-10317
> URL: https://issues.apache.org/jira/browse/OFBIZ-10317
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework/webtools
>Affects Versions: 16.11.04
>Reporter: Rajesh Kumar Mallah
>Priority: Major
>
>  
> The existing framework allows invoking  various services via XMLRPC or SOAP 
> as per their argument expectations. However only basic types are handled
> like String , Boolean , Int etc. If a service is expecting a GenericValue eg: 
> 'calculateProductPrice'   it is not possible to invoke it via SOAP or XMLRPC.
> The reason being SOAP or XMLRPC can support Map and that is the closest 
> it can provide in lieu of any custom Object that a Service might be expecting.
> A generic solution needs to be found so that the full potential of the 
> plethora of 
> exportable services can be utilized by external systems that looks for 
> integrating and 
> banking upon OfBiz via XMLRPC or SOAP.
> h6. related Threads:
> [How to pass org.apache.ofbiz.entity.GenericValue using XMLRPC]
> [https://markmail.org/message/dwako4nsu4h3zgmu] [ dev ]
> [https://markmail.org/message/iuffmakor3ru2yce] [user]
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10317) Allowing XML-RPC and SOAP to pass GenericValue objects to services as IN fields

2018-03-27 Thread Rajesh Kumar Mallah (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-10317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16415528#comment-16415528
 ] 

Rajesh Kumar Mallah commented on OFBIZ-10317:
-

Hello Mr Taher ,

Firstly Thanks for initiating this.

Sure i can craft the spanner .

One thing that i  miss is exported services in the demo trunk/stable. The demo 
trunk
goes a long way to serve as common reference when discussing a wide range of
issues , however to create test cases involving XML/SOAP we have to involve 
local configurations and the test scripts loose their universality. 

It would have been useful if it were possible to utilize the demo infra for such
cases also.

I guess the demo trunk is a sandbox that resets everyday probably we shall need
some persistence mechanisms there for config data.

regds
mallah.

 

 

 

> Allowing XML-RPC and SOAP to pass GenericValue objects to services as IN 
> fields
> ---
>
> Key: OFBIZ-10317
> URL: https://issues.apache.org/jira/browse/OFBIZ-10317
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework/webtools
>Affects Versions: 16.11.04
>Reporter: Rajesh Kumar Mallah
>Priority: Major
>
>  
> The existing framework allows invoking  various services via XMLRPC or SOAP 
> as per their argument expectations. However only basic types are handled
> like String , Boolean , Int etc. If a service is expecting a GenericValue eg: 
> 'calculateProductPrice'   it is not possible to invoke it via SOAP or XMLRPC.
> The reason being SOAP or XMLRPC can support Map and that is the closest 
> it can provide in lieu of any custom Object that a Service might be expecting.
> A generic solution needs to be found so that the full potential of the 
> plethora of 
> exportable services can be utilized by external systems that looks for 
> integrating and 
> banking upon OfBiz via XMLRPC or SOAP.
> h6. related Threads:
> [How to pass org.apache.ofbiz.entity.GenericValue using XMLRPC]
> [https://markmail.org/message/dwako4nsu4h3zgmu] [ dev ]
> [https://markmail.org/message/iuffmakor3ru2yce] [user]
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10317) Allowing XML-RPC and SOAP to pass GenericValue objects to services as IN fields

2018-03-27 Thread Taher Alkhateeb (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-10317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16415562#comment-16415562
 ] 

Taher Alkhateeb commented on OFBIZ-10317:
-

A simple patch would be sufficient for our work here. I prefer to keep the demo 
out of our experimentation.

Make it a minimal test case, just choose any service, make it exported, and 
then run your test script against that service, and get the error. This 
"repeatable" test would help us a lot in moving forward.

> Allowing XML-RPC and SOAP to pass GenericValue objects to services as IN 
> fields
> ---
>
> Key: OFBIZ-10317
> URL: https://issues.apache.org/jira/browse/OFBIZ-10317
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework/webtools
>Affects Versions: 16.11.04
>Reporter: Rajesh Kumar Mallah
>Priority: Major
>
>  
> The existing framework allows invoking  various services via XMLRPC or SOAP 
> as per their argument expectations. However only basic types are handled
> like String , Boolean , Int etc. If a service is expecting a GenericValue eg: 
> 'calculateProductPrice'   it is not possible to invoke it via SOAP or XMLRPC.
> The reason being SOAP or XMLRPC can support Map and that is the closest 
> it can provide in lieu of any custom Object that a Service might be expecting.
> A generic solution needs to be found so that the full potential of the 
> plethora of 
> exportable services can be utilized by external systems that looks for 
> integrating and 
> banking upon OfBiz via XMLRPC or SOAP.
> h6. related Threads:
> [How to pass org.apache.ofbiz.entity.GenericValue using XMLRPC]
> [https://markmail.org/message/dwako4nsu4h3zgmu] [ dev ]
> [https://markmail.org/message/iuffmakor3ru2yce] [user]
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10317) Allowing XML-RPC and SOAP to pass GenericValue objects to services as IN fields

2018-03-27 Thread Rajesh Kumar Mallah (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-10317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16415679#comment-16415679
 ] 

Rajesh Kumar Mallah commented on OFBIZ-10317:
-

Sure Taher ,

Pls allow some moments, I  will provide the repeatable case.

Regds
mallah

> Allowing XML-RPC and SOAP to pass GenericValue objects to services as IN 
> fields
> ---
>
> Key: OFBIZ-10317
> URL: https://issues.apache.org/jira/browse/OFBIZ-10317
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework/webtools
>Affects Versions: 16.11.04
>Reporter: Rajesh Kumar Mallah
>Priority: Major
>
>  
> The existing framework allows invoking  various services via XMLRPC or SOAP 
> as per their argument expectations. However only basic types are handled
> like String , Boolean , Int etc. If a service is expecting a GenericValue eg: 
> 'calculateProductPrice'   it is not possible to invoke it via SOAP or XMLRPC.
> The reason being SOAP or XMLRPC can support Map and that is the closest 
> it can provide in lieu of any custom Object that a Service might be expecting.
> A generic solution needs to be found so that the full potential of the 
> plethora of 
> exportable services can be utilized by external systems that looks for 
> integrating and 
> banking upon OfBiz via XMLRPC or SOAP.
> h6. related Threads:
> [How to pass org.apache.ofbiz.entity.GenericValue using XMLRPC]
> [https://markmail.org/message/dwako4nsu4h3zgmu] [ dev ]
> [https://markmail.org/message/iuffmakor3ru2yce] [user]
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10317) Allowing XML-RPC and SOAP to pass GenericValue objects to services as IN fields

2018-04-03 Thread Rajesh Kumar Mallah (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-10317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16424141#comment-16424141
 ] 

Rajesh Kumar Mallah commented on OFBIZ-10317:
-

 

 

Hi Taher ,

Below is one of the ways to replicate it using curl

 

 

below is a simple call to findPartiesById to ensure that the command below is a 
valid way of
invoking  a XML-RPC service.

{{$ curl -X POST -H "Content-Type: text/xml" -d @working.xml   
[https://ofbizhost.com/webtools/control/xmlrpc]}}

 

Below is an attempt  to invoke calculateProductPrice by sending a struct and it 
is expected to 
raise error in current state of software. please note  product ID *ENCHILADAS* 
is a part of current demo data set.

 $ curl -X POST  -H "Content-Type: text/xml"  -d @not-working.xml  
{{[https://ofbizhost.com/webtools/control/xmlrpc]}}

 

this currently responds with:

http://ws.apache.org/xmlrpc/namespaces/extensions";>faultCode0faultStringType
 check failed for field [calculateProductPrice.product]; expected type is 
[org.apache.ofbiz.entity.GenericValue]; actual type is 
[java.util.HashMap]

 

*Expected Result:* A XML representing the valid price of the the product.

 

[^working.xml]

[^not-working.xml]

> Allowing XML-RPC and SOAP to pass GenericValue objects to services as IN 
> fields
> ---
>
> Key: OFBIZ-10317
> URL: https://issues.apache.org/jira/browse/OFBIZ-10317
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework/webtools
>Affects Versions: 16.11.04
>Reporter: Rajesh Kumar Mallah
>Priority: Major
> Attachments: not-working.xml, working.xml
>
>
>  
> The existing framework allows invoking  various services via XMLRPC or SOAP 
> as per their argument expectations. However only basic types are handled
> like String , Boolean , Int etc. If a service is expecting a GenericValue eg: 
> 'calculateProductPrice'   it is not possible to invoke it via SOAP or XMLRPC.
> The reason being SOAP or XMLRPC can support Map and that is the closest 
> it can provide in lieu of any custom Object that a Service might be expecting.
> A generic solution needs to be found so that the full potential of the 
> plethora of 
> exportable services can be utilized by external systems that looks for 
> integrating and 
> banking upon OfBiz via XMLRPC or SOAP.
> h6. related Threads:
> [How to pass org.apache.ofbiz.entity.GenericValue using XMLRPC]
> [https://markmail.org/message/dwako4nsu4h3zgmu] [ dev ]
> [https://markmail.org/message/iuffmakor3ru2yce] [user]
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10317) Allowing XML-RPC and SOAP to pass GenericValue objects to services as IN fields

2018-04-07 Thread Taher Alkhateeb (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-10317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16429311#comment-16429311
 ] 

Taher Alkhateeb commented on OFBIZ-10317:
-

Excellent Rajesh, this example saves a lot of time and contrasts two scenarios 
(working and not working).

I'm investigating the code base now to see where we can resolve this. I'll 
update this Jira soon

> Allowing XML-RPC and SOAP to pass GenericValue objects to services as IN 
> fields
> ---
>
> Key: OFBIZ-10317
> URL: https://issues.apache.org/jira/browse/OFBIZ-10317
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework/webtools
>Affects Versions: 16.11.04
>Reporter: Rajesh Kumar Mallah
>Priority: Major
> Attachments: not-working.xml, working.xml
>
>
>  
> The existing framework allows invoking  various services via XMLRPC or SOAP 
> as per their argument expectations. However only basic types are handled
> like String , Boolean , Int etc. If a service is expecting a GenericValue eg: 
> 'calculateProductPrice'   it is not possible to invoke it via SOAP or XMLRPC.
> The reason being SOAP or XMLRPC can support Map and that is the closest 
> it can provide in lieu of any custom Object that a Service might be expecting.
> A generic solution needs to be found so that the full potential of the 
> plethora of 
> exportable services can be utilized by external systems that looks for 
> integrating and 
> banking upon OfBiz via XMLRPC or SOAP.
> h6. related Threads:
> [How to pass org.apache.ofbiz.entity.GenericValue using XMLRPC]
> [https://markmail.org/message/dwako4nsu4h3zgmu] [ dev ]
> [https://markmail.org/message/iuffmakor3ru2yce] [user]
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10317) Allowing XML-RPC and SOAP to pass GenericValue objects to services as IN fields

2018-04-07 Thread Taher Alkhateeb (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-10317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16429452#comment-16429452
 ] 

Taher Alkhateeb commented on OFBIZ-10317:
-

After lots of research, noting here that I suspect that maybe the best place to 
tackle this problem is in the conversion api located in package 
org.apache.ofbiz.base.conversion

More specifically, I suspect we can add the conversion from 
java.util.HashMap->org.apache.ofbiz.entity.GenericValue using the converter 
interface.

The logic to trace from is definitely in package 
org.apache.ofbiz.webapp.event.XmlRpcEventHandler. But it is relatively complex, 
I need to switch constantly between many classes (a major need of refactoring 
here!).

Anyway, Work In Progress, we'll see how it goes. The unit tests provided are 
extremely helpful.

> Allowing XML-RPC and SOAP to pass GenericValue objects to services as IN 
> fields
> ---
>
> Key: OFBIZ-10317
> URL: https://issues.apache.org/jira/browse/OFBIZ-10317
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework/webtools
>Affects Versions: 16.11.04
>Reporter: Rajesh Kumar Mallah
>Priority: Major
> Attachments: not-working.xml, working.xml
>
>
>  
> The existing framework allows invoking  various services via XMLRPC or SOAP 
> as per their argument expectations. However only basic types are handled
> like String , Boolean , Int etc. If a service is expecting a GenericValue eg: 
> 'calculateProductPrice'   it is not possible to invoke it via SOAP or XMLRPC.
> The reason being SOAP or XMLRPC can support Map and that is the closest 
> it can provide in lieu of any custom Object that a Service might be expecting.
> A generic solution needs to be found so that the full potential of the 
> plethora of 
> exportable services can be utilized by external systems that looks for 
> integrating and 
> banking upon OfBiz via XMLRPC or SOAP.
> h6. related Threads:
> [How to pass org.apache.ofbiz.entity.GenericValue using XMLRPC]
> [https://markmail.org/message/dwako4nsu4h3zgmu] [ dev ]
> [https://markmail.org/message/iuffmakor3ru2yce] [user]
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10317) Allowing XML-RPC and SOAP to pass GenericValue objects to services as IN fields

2018-04-07 Thread Rajesh Kumar Mallah (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-10317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16429488#comment-16429488
 ] 

Rajesh Kumar Mallah commented on OFBIZ-10317:
-

Hello Mr Taher ,

I am glad and grateful this issue got attention and priority. 
Please lemme know if i could be of further help . Ofcourse 
i keep an watch on this issue!

 

regds

mallah.

> Allowing XML-RPC and SOAP to pass GenericValue objects to services as IN 
> fields
> ---
>
> Key: OFBIZ-10317
> URL: https://issues.apache.org/jira/browse/OFBIZ-10317
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework/webtools
>Affects Versions: 16.11.04
>Reporter: Rajesh Kumar Mallah
>Priority: Major
> Attachments: not-working.xml, working.xml
>
>
>  
> The existing framework allows invoking  various services via XMLRPC or SOAP 
> as per their argument expectations. However only basic types are handled
> like String , Boolean , Int etc. If a service is expecting a GenericValue eg: 
> 'calculateProductPrice'   it is not possible to invoke it via SOAP or XMLRPC.
> The reason being SOAP or XMLRPC can support Map and that is the closest 
> it can provide in lieu of any custom Object that a Service might be expecting.
> A generic solution needs to be found so that the full potential of the 
> plethora of 
> exportable services can be utilized by external systems that looks for 
> integrating and 
> banking upon OfBiz via XMLRPC or SOAP.
> h6. related Threads:
> [How to pass org.apache.ofbiz.entity.GenericValue using XMLRPC]
> [https://markmail.org/message/dwako4nsu4h3zgmu] [ dev ]
> [https://markmail.org/message/iuffmakor3ru2yce] [user]
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10317) Allowing XML-RPC and SOAP to pass GenericValue objects to services as IN fields

2018-04-07 Thread Taher Alkhateeb (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-10317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16429508#comment-16429508
 ] 

Taher Alkhateeb commented on OFBIZ-10317:
-

Hi Rajesh,

You did a great job already with the test scripts. That saved me a lot of time 
in getting the environment setup for testing.

I wish I can tell you there is a quick solution, but it's not very simple. The 
logic is bigger than I expected, so I am still in "exploring" phase. I want to 
find a clean solution that works for hopefully all scenarios, not just XML-RPC. 
If we're stuck, however, then maybe we go for XML-RPC and SOAP event handlers 
only, not sure! I'll keep you posted.

> Allowing XML-RPC and SOAP to pass GenericValue objects to services as IN 
> fields
> ---
>
> Key: OFBIZ-10317
> URL: https://issues.apache.org/jira/browse/OFBIZ-10317
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework/webtools
>Affects Versions: 16.11.04
>Reporter: Rajesh Kumar Mallah
>Priority: Major
> Attachments: not-working.xml, working.xml
>
>
>  
> The existing framework allows invoking  various services via XMLRPC or SOAP 
> as per their argument expectations. However only basic types are handled
> like String , Boolean , Int etc. If a service is expecting a GenericValue eg: 
> 'calculateProductPrice'   it is not possible to invoke it via SOAP or XMLRPC.
> The reason being SOAP or XMLRPC can support Map and that is the closest 
> it can provide in lieu of any custom Object that a Service might be expecting.
> A generic solution needs to be found so that the full potential of the 
> plethora of 
> exportable services can be utilized by external systems that looks for 
> integrating and 
> banking upon OfBiz via XMLRPC or SOAP.
> h6. related Threads:
> [How to pass org.apache.ofbiz.entity.GenericValue using XMLRPC]
> [https://markmail.org/message/dwako4nsu4h3zgmu] [ dev ]
> [https://markmail.org/message/iuffmakor3ru2yce] [user]
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10317) Allowing XML-RPC and SOAP to pass GenericValue objects to services as IN fields

2018-04-07 Thread Rajesh Kumar Mallah (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-10317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16429514#comment-16429514
 ] 

Rajesh Kumar Mallah commented on OFBIZ-10317:
-

Kewl :)  it would really mean a lot for people like us who intend to use
ofbiz as a framework. I understand a proper "exploring" is really the gateway 
to the solution and sometimes the solution itself!

All the best!.

regds
mallah.

> Allowing XML-RPC and SOAP to pass GenericValue objects to services as IN 
> fields
> ---
>
> Key: OFBIZ-10317
> URL: https://issues.apache.org/jira/browse/OFBIZ-10317
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework/webtools
>Affects Versions: 16.11.04
>Reporter: Rajesh Kumar Mallah
>Priority: Major
> Attachments: not-working.xml, working.xml
>
>
>  
> The existing framework allows invoking  various services via XMLRPC or SOAP 
> as per their argument expectations. However only basic types are handled
> like String , Boolean , Int etc. If a service is expecting a GenericValue eg: 
> 'calculateProductPrice'   it is not possible to invoke it via SOAP or XMLRPC.
> The reason being SOAP or XMLRPC can support Map and that is the closest 
> it can provide in lieu of any custom Object that a Service might be expecting.
> A generic solution needs to be found so that the full potential of the 
> plethora of 
> exportable services can be utilized by external systems that looks for 
> integrating and 
> banking upon OfBiz via XMLRPC or SOAP.
> h6. related Threads:
> [How to pass org.apache.ofbiz.entity.GenericValue using XMLRPC]
> [https://markmail.org/message/dwako4nsu4h3zgmu] [ dev ]
> [https://markmail.org/message/iuffmakor3ru2yce] [user]
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10317) Allowing XML-RPC and SOAP to pass GenericValue objects to services as IN fields

2018-06-12 Thread Taher Alkhateeb (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16509887#comment-16509887
 ] 

Taher Alkhateeb commented on OFBIZ-10317:
-

Okay after thoroughly investigating this issue, I realized that the first step 
to attempt is to create a converter from a Map to GenericValue.

So I went ahead and implemented the code, the important part of which is listed 
below:
{code:java}
public static class MapToGenericValue extends AbstractConverter, GenericValue> {
    public MapToGenericValue() {
    super(Map.class, GenericValue.class);
    }

    public GenericValue convert(Map obj) throws 
ConversionException {
    GenericValue genericValue = new GenericValue();
    genericValue.putAll(UtilGenerics.checkMap(obj));
    return genericValue;
    }
    }{code}
The problem here of course is that the generic value is not linked to a 
ModelEntity. Why? Because we don't know what is the entity. We just received 
some data, we did not receive an actual Object. So if you run my above code, 
you will get an error:
{code:java}
java.lang.IllegalStateException: [GenericEntity.getModelEntity] could not find 
modelEntity for entityName null
{code}
So to convert XML-RPC data to a Java Object, we _must_ know what is the entity 
name (at the very least). In our example, the entity name is "Product" whereas 
the service parameter name is "product" which is not the same.

So, unless you have an idea for how to get the entity information for all 
existing services that take a GenericValue, I think this issue cannot be 
implemented successfully

> Allowing XML-RPC and SOAP to pass GenericValue objects to services as IN 
> fields
> ---
>
> Key: OFBIZ-10317
> URL: https://issues.apache.org/jira/browse/OFBIZ-10317
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework/webtools
>Affects Versions: 16.11.04
>Reporter: Rajesh Kumar Mallah
>Priority: Major
> Attachments: not-working.xml, working.xml
>
>
>  
> The existing framework allows invoking  various services via XMLRPC or SOAP 
> as per their argument expectations. However only basic types are handled
> like String , Boolean , Int etc. If a service is expecting a GenericValue eg: 
> 'calculateProductPrice'   it is not possible to invoke it via SOAP or XMLRPC.
> The reason being SOAP or XMLRPC can support Map and that is the closest 
> it can provide in lieu of any custom Object that a Service might be expecting.
> A generic solution needs to be found so that the full potential of the 
> plethora of 
> exportable services can be utilized by external systems that looks for 
> integrating and 
> banking upon OfBiz via XMLRPC or SOAP.
> h6. related Threads:
> [How to pass org.apache.ofbiz.entity.GenericValue using XMLRPC]
> [https://markmail.org/message/dwako4nsu4h3zgmu] [ dev ]
> [https://markmail.org/message/iuffmakor3ru2yce] [user]
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10317) Allowing XML-RPC and SOAP to pass GenericValue objects to services as IN fields

2018-06-12 Thread Rajesh Kumar Mallah (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16509935#comment-16509935
 ] 

Rajesh Kumar Mallah commented on OFBIZ-10317:
-

Hi Taher ,

 

Thanks for the effort once again.
while trying on my own before posting this issue in limited capacity I too hit 
the wall in want of entity. 
can we have a generic entity just for these kind of conversion ?

regds
mallah

> Allowing XML-RPC and SOAP to pass GenericValue objects to services as IN 
> fields
> ---
>
> Key: OFBIZ-10317
> URL: https://issues.apache.org/jira/browse/OFBIZ-10317
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework/webtools
>Affects Versions: 16.11.04
>Reporter: Rajesh Kumar Mallah
>Priority: Major
> Attachments: not-working.xml, working.xml
>
>
>  
> The existing framework allows invoking  various services via XMLRPC or SOAP 
> as per their argument expectations. However only basic types are handled
> like String , Boolean , Int etc. If a service is expecting a GenericValue eg: 
> 'calculateProductPrice'   it is not possible to invoke it via SOAP or XMLRPC.
> The reason being SOAP or XMLRPC can support Map and that is the closest 
> it can provide in lieu of any custom Object that a Service might be expecting.
> A generic solution needs to be found so that the full potential of the 
> plethora of 
> exportable services can be utilized by external systems that looks for 
> integrating and 
> banking upon OfBiz via XMLRPC or SOAP.
> h6. related Threads:
> [How to pass org.apache.ofbiz.entity.GenericValue using XMLRPC]
> [https://markmail.org/message/dwako4nsu4h3zgmu] [ dev ]
> [https://markmail.org/message/iuffmakor3ru2yce] [user]
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10317) Allowing XML-RPC and SOAP to pass GenericValue objects to services as IN fields

2018-06-12 Thread Taher Alkhateeb (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16509981#comment-16509981
 ] 

Taher Alkhateeb commented on OFBIZ-10317:
-

Be careful, the word GenericEntity is a class in OFBiz :) But I think I 
understand what you mean.

So the answer to your question is probably no. These services are expecting a 
very specific entity to operate on.That's why i said from the beginning that it 
was a pretty bad idea to include GenericServices are parameters in any service.

The best solution that I can think for you is to design adapter services in the 
middle that talk to the target services you want to use, if we create some kind 
of hack (like passing the entity name in the XML-RPC call) then our converters 
would _only_ work for XML-RPC, which is a pretty bad design anyway.

My recommendation is to close this Jira with "won't fix". The problem is not 
XML-RPC, the problem is badly designed services that expect or produce 
GenericValues.

 

> Allowing XML-RPC and SOAP to pass GenericValue objects to services as IN 
> fields
> ---
>
> Key: OFBIZ-10317
> URL: https://issues.apache.org/jira/browse/OFBIZ-10317
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework/webtools
>Affects Versions: 16.11.04
>Reporter: Rajesh Kumar Mallah
>Priority: Major
> Attachments: not-working.xml, working.xml
>
>
>  
> The existing framework allows invoking  various services via XMLRPC or SOAP 
> as per their argument expectations. However only basic types are handled
> like String , Boolean , Int etc. If a service is expecting a GenericValue eg: 
> 'calculateProductPrice'   it is not possible to invoke it via SOAP or XMLRPC.
> The reason being SOAP or XMLRPC can support Map and that is the closest 
> it can provide in lieu of any custom Object that a Service might be expecting.
> A generic solution needs to be found so that the full potential of the 
> plethora of 
> exportable services can be utilized by external systems that looks for 
> integrating and 
> banking upon OfBiz via XMLRPC or SOAP.
> h6. related Threads:
> [How to pass org.apache.ofbiz.entity.GenericValue using XMLRPC]
> [https://markmail.org/message/dwako4nsu4h3zgmu] [ dev ]
> [https://markmail.org/message/iuffmakor3ru2yce] [user]
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10317) Allowing XML-RPC and SOAP to pass GenericValue objects to services as IN fields

2018-06-12 Thread Rajesh Kumar Mallah (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16509993#comment-16509993
 ] 

Rajesh Kumar Mallah commented on OFBIZ-10317:
-

Hi Taher,

Yeah it was a ambiguous term to use. can't help though owing to my limit 
experience :)  shall try to be more careful.
Even if we close this issue it shall bite us back when creating 
inter-interoperability features like JSON based apis 
etc.

 
{quote}The best solution that I can think for you is to design adapter services 
in the middle that talk to the target services you want to use, if we create 
some kind of hack (like passing the entity name in the XML-RPC call) then our 
converters would _only_ work for XML-RPC, which is a pretty bad design anyway.
{quote}
would try to do the same. I already did so to keep the show running . 
please feel free to take a call on this issue.

 

regds
mallah

 

> Allowing XML-RPC and SOAP to pass GenericValue objects to services as IN 
> fields
> ---
>
> Key: OFBIZ-10317
> URL: https://issues.apache.org/jira/browse/OFBIZ-10317
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework/webtools
>Affects Versions: 16.11.04
>Reporter: Rajesh Kumar Mallah
>Priority: Major
> Attachments: not-working.xml, working.xml
>
>
>  
> The existing framework allows invoking  various services via XMLRPC or SOAP 
> as per their argument expectations. However only basic types are handled
> like String , Boolean , Int etc. If a service is expecting a GenericValue eg: 
> 'calculateProductPrice'   it is not possible to invoke it via SOAP or XMLRPC.
> The reason being SOAP or XMLRPC can support Map and that is the closest 
> it can provide in lieu of any custom Object that a Service might be expecting.
> A generic solution needs to be found so that the full potential of the 
> plethora of 
> exportable services can be utilized by external systems that looks for 
> integrating and 
> banking upon OfBiz via XMLRPC or SOAP.
> h6. related Threads:
> [How to pass org.apache.ofbiz.entity.GenericValue using XMLRPC]
> [https://markmail.org/message/dwako4nsu4h3zgmu] [ dev ]
> [https://markmail.org/message/iuffmakor3ru2yce] [user]
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10317) Allowing XML-RPC and SOAP to pass GenericValue objects to services as IN fields

2020-07-19 Thread Rajesh Kumar Mallah (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17160613#comment-17160613
 ] 

Rajesh Kumar Mallah commented on OFBIZ-10317:
-

Worth mentioning is the thread:

[https://markmail.org/message/scilivxk3m4sz723#query:+page:1+mid:puhon7gp7ajzl7wz+state:results]

 

regds

Rajesh.

 

> Allowing XML-RPC and SOAP to pass GenericValue objects to services as IN 
> fields
> ---
>
> Key: OFBIZ-10317
> URL: https://issues.apache.org/jira/browse/OFBIZ-10317
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework/webtools
>Affects Versions: 16.11.04
>Reporter: Rajesh Kumar Mallah
>Assignee: Taher Alkhateeb
>Priority: Major
> Attachments: not-working.xml, working.xml
>
>
>  
> The existing framework allows invoking  various services via XMLRPC or SOAP 
> as per their argument expectations. However only basic types are handled
> like String , Boolean , Int etc. If a service is expecting a GenericValue eg: 
> 'calculateProductPrice'   it is not possible to invoke it via SOAP or XMLRPC.
> The reason being SOAP or XMLRPC can support Map and that is the closest 
> it can provide in lieu of any custom Object that a Service might be expecting.
> A generic solution needs to be found so that the full potential of the 
> plethora of 
> exportable services can be utilized by external systems that looks for 
> integrating and 
> banking upon OfBiz via XMLRPC or SOAP.
> h6. related Threads:
> [How to pass org.apache.ofbiz.entity.GenericValue using XMLRPC]
> [https://markmail.org/message/dwako4nsu4h3zgmu] [ dev ]
> [https://markmail.org/message/iuffmakor3ru2yce] [user]
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)