[jira] [Commented] (OFBIZ-10386) Empty field is reflecting on Contact list section on Profile Page
[
https://issues.apache.org/jira/browse/OFBIZ-10386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17353761#comment-17353761
]
Jacques Le Roux commented on OFBIZ-10386:
-
Thanks guys,
{noformat}
I did not close because I found this in log after pushing:
2021-05-29 15:42:42,257 |jsse-nio-8443-exec-5 |ControlServlet
|T| [[[ecomseo::createContactListParty (Domain:https://localhost)] Request
Done- total:1.311,since last([ecomseo::createC...):1.311]]
2021-05-29 15:42:43,686 |OFBiz-JobQueue-0 |PersistedServiceJob
|I| Job [1622295761316] Id [11102] -- Next runtime: Thu Jan 01 00:59:59 CET
1970
2021-05-29 15:42:43,904 |OFBiz-JobQueue-0 |ScreenFactory
|I| Got 7 screens in 0.004s from:
file:/C:/projectsASF/Git/ofbiz-framework/plugins/ecommerce/widget/EmailContactListScreens.xml
2021-05-29 15:42:43,935 |OFBiz-JobQueue-0 |FreeMarkerWorker
|E| null
freemarker.core.InvalidReferenceException: The following has evaluated to null
or missing:
==> baseLocation [in template
"component://ecommerce/template/email/ContactListVerifyEmail.ftl" at line 35,
column 8]
Tip: If the failing expression is known to legally refer to something that's
sometimes null or missing, either specify a default value like
myOptionalVar!myDefault, or use <#if
myOptionalVar??>when-present<#else>when-missing. (Thes
e only cover the last step of the expression; to cover the whole expression,
use parenthesis: (myOptionalVar.foo)!myDefault, (myOptionalVar.foo)??
FTL stack trace ("~" means nesting-related):
- Failed at: #if baseLocation == "/ecomseo" [in template
"component://ecommerce/template/email/ContactListVerifyEmail.ftl" at line 35,
column 3]
{noformat}
I guess it's only because I locally used ecomseo instead of ecommerce. But
please could you have a look, confirm, and create a new patch for that? TIA
> Empty field is reflecting on Contact list section on Profile Page
> -
>
> Key: OFBIZ-10386
> URL: https://issues.apache.org/jira/browse/OFBIZ-10386
> Project: OFBiz
> Issue Type: Bug
> Environment: https://demo-trunk.ofbiz.apache.org/ecomseo/viewprofile
>Reporter: Archana Asthana
>Assignee: Devanshu Vyas
>Priority: Major
> Attachments: EmptyFields.png, ViewProfileV2.patch
>
>
> Steps to generate:
> Open https://demo-trunk.ofbiz.apache.org/ecomseo/viewprofile
> On the profile page, Go down to Contact list
> Empty fields are displaying before Verify Subscription button
> Expected: The field should have some specifications to be filled up
> Image is attached for reference
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (OFBIZ-10386) Empty field is reflecting on Contact list section on Profile Page
[ https://issues.apache.org/jira/browse/OFBIZ-10386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17353759#comment-17353759 ] ASF subversion and git services commented on OFBIZ-10386: - Commit e51dccb9bb49f5ed32df0af3f9fd2da88980df56 in ofbiz-plugins's branch refs/heads/trunk from Jacques Le Roux [ https://gitbox.apache.org/repos/asf?p=ofbiz-plugins.git;h=e51dccb ] Fixed: Empty field is reflecting on Contact list section on Profile Page (OFBIZ-10386) Steps to generate: Open https://demo-trunk.ofbiz.apache.org/ecomseo/viewprofile On the profile page, Go down to Contact list Empty fields are displaying before Verify Subscription button Expected: The field should have some specifications to be filled up Thanks: Archana Asthana for report, Devanshu Vyas for suggestion, Praveen Patil for patch and Thirumurugan for confirming > Empty field is reflecting on Contact list section on Profile Page > - > > Key: OFBIZ-10386 > URL: https://issues.apache.org/jira/browse/OFBIZ-10386 > Project: OFBiz > Issue Type: Bug > Environment: https://demo-trunk.ofbiz.apache.org/ecomseo/viewprofile >Reporter: Archana Asthana >Assignee: Devanshu Vyas >Priority: Major > Attachments: EmptyFields.png, ViewProfileV2.patch > > > Steps to generate: > Open https://demo-trunk.ofbiz.apache.org/ecomseo/viewprofile > On the profile page, Go down to Contact list > Empty fields are displaying before Verify Subscription button > Expected: The field should have some specifications to be filled up > Image is attached for reference -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-10386) Empty field is reflecting on Contact list section on Profile Page
[ https://issues.apache.org/jira/browse/OFBIZ-10386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17353758#comment-17353758 ] ASF subversion and git services commented on OFBIZ-10386: - Commit 485e3b89d712879ce3d96b27ae092a4e134b0bf0 in ofbiz-plugins's branch refs/heads/release18.12 from Jacques Le Roux [ https://gitbox.apache.org/repos/asf?p=ofbiz-plugins.git;h=485e3b8 ] Fixed: Empty field is reflecting on Contact list section on Profile Page (OFBIZ-10386) Steps to generate: Open https://demo-trunk.ofbiz.apache.org/ecomseo/viewprofile On the profile page, Go down to Contact list Empty fields are displaying before Verify Subscription button Expected: The field should have some specifications to be filled up Thanks: Archana Asthana for report, Devanshu Vyas for suggestion, Praveen Patil for patch and Thirumurugan for confirming > Empty field is reflecting on Contact list section on Profile Page > - > > Key: OFBIZ-10386 > URL: https://issues.apache.org/jira/browse/OFBIZ-10386 > Project: OFBiz > Issue Type: Bug > Environment: https://demo-trunk.ofbiz.apache.org/ecomseo/viewprofile >Reporter: Archana Asthana >Assignee: Devanshu Vyas >Priority: Major > Attachments: EmptyFields.png, ViewProfileV2.patch > > > Steps to generate: > Open https://demo-trunk.ofbiz.apache.org/ecomseo/viewprofile > On the profile page, Go down to Contact list > Empty fields are displaying before Verify Subscription button > Expected: The field should have some specifications to be filled up > Image is attached for reference -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-10386) Empty field is reflecting on Contact list section on Profile Page
[ https://issues.apache.org/jira/browse/OFBIZ-10386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17353757#comment-17353757 ] ASF subversion and git services commented on OFBIZ-10386: - Commit 2ba0afe458e51897b9a354fc3dddc49ad4e38b00 in ofbiz-plugins's branch refs/heads/release17.12 from Jacques Le Roux [ https://gitbox.apache.org/repos/asf?p=ofbiz-plugins.git;h=2ba0afe ] Fixed: Empty field is reflecting on Contact list section on Profile Page (OFBIZ-10386) Steps to generate: Open https://demo-trunk.ofbiz.apache.org/ecomseo/viewprofile On the profile page, Go down to Contact list Empty fields are displaying before Verify Subscription button Expected: The field should have some specifications to be filled up Thanks: Archana Asthana for report, Devanshu Vyas for suggestion, Praveen Patil for patch and Thirumurugan for confirming > Empty field is reflecting on Contact list section on Profile Page > - > > Key: OFBIZ-10386 > URL: https://issues.apache.org/jira/browse/OFBIZ-10386 > Project: OFBiz > Issue Type: Bug > Environment: https://demo-trunk.ofbiz.apache.org/ecomseo/viewprofile >Reporter: Archana Asthana >Assignee: Devanshu Vyas >Priority: Major > Attachments: EmptyFields.png, ViewProfileV2.patch > > > Steps to generate: > Open https://demo-trunk.ofbiz.apache.org/ecomseo/viewprofile > On the profile page, Go down to Contact list > Empty fields are displaying before Verify Subscription button > Expected: The field should have some specifications to be filled up > Image is attached for reference -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-10386) Empty field is reflecting on Contact list section on Profile Page
[ https://issues.apache.org/jira/browse/OFBIZ-10386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17352627#comment-17352627 ] Thirumurugan commented on OFBIZ-10386: -- [~praveen.patil] I tested the patch it's working fine. can you change the status to Patch Available > Empty field is reflecting on Contact list section on Profile Page > - > > Key: OFBIZ-10386 > URL: https://issues.apache.org/jira/browse/OFBIZ-10386 > Project: OFBiz > Issue Type: Bug > Environment: https://demo-trunk.ofbiz.apache.org/ecomseo/viewprofile >Reporter: Archana Asthana >Assignee: Devanshu Vyas >Priority: Major > Attachments: EmptyFields.png, ViewProfileV2.patch > > > Steps to generate: > Open https://demo-trunk.ofbiz.apache.org/ecomseo/viewprofile > On the profile page, Go down to Contact list > Empty fields are displaying before Verify Subscription button > Expected: The field should have some specifications to be filled up > Image is attached for reference -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-10386) Empty field is reflecting on Contact list section on Profile Page
[ https://issues.apache.org/jira/browse/OFBIZ-10386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17202593#comment-17202593 ] Praveen Patil commented on OFBIZ-10386: --- Attached the updated patch. [~devanshu] please have a look. > Empty field is reflecting on Contact list section on Profile Page > - > > Key: OFBIZ-10386 > URL: https://issues.apache.org/jira/browse/OFBIZ-10386 > Project: OFBiz > Issue Type: Bug > Environment: https://demo-trunk.ofbiz.apache.org/ecomseo/viewprofile >Reporter: Archana Asthana >Assignee: Devanshu Vyas >Priority: Major > Attachments: EmptyFields.png, ViewProfileV2.patch > > > Steps to generate: > Open https://demo-trunk.ofbiz.apache.org/ecomseo/viewprofile > On the profile page, Go down to Contact list > Empty fields are displaying before Verify Subscription button > Expected: The field should have some specifications to be filled up > Image is attached for reference -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-10386) Empty field is reflecting on Contact list section on Profile Page
[ https://issues.apache.org/jira/browse/OFBIZ-10386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17202576#comment-17202576 ] Archana Asthana commented on OFBIZ-10386: - Hello [~praveen.patil] I think marketing one will be more sensible, Please go ahead with this one. > Empty field is reflecting on Contact list section on Profile Page > - > > Key: OFBIZ-10386 > URL: https://issues.apache.org/jira/browse/OFBIZ-10386 > Project: OFBiz > Issue Type: Bug > Environment: https://demo-trunk.ofbiz.apache.org/ecomseo/viewprofile >Reporter: Archana Asthana >Assignee: Devanshu Vyas >Priority: Major > Attachments: EmptyFields.png, ViewProfile.patch > > > Steps to generate: > Open https://demo-trunk.ofbiz.apache.org/ecomseo/viewprofile > On the profile page, Go down to Contact list > Empty fields are displaying before Verify Subscription button > Expected: The field should have some specifications to be filled up > Image is attached for reference -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-10386) Empty field is reflecting on Contact list section on Profile Page
[ https://issues.apache.org/jira/browse/OFBIZ-10386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17202569#comment-17202569 ] Praveen Patil commented on OFBIZ-10386: --- Hi [~archana.asthana] as Devanshu said, there is a text field already available in what you are referring to as blank space, we just need the proper header name for that. The patch that I have provided has "_FormFieldTitle_optInVerifyCode_" label, can you just confirm which one is more suitable for the purpose out of Denanshu's suggestions. > Empty field is reflecting on Contact list section on Profile Page > - > > Key: OFBIZ-10386 > URL: https://issues.apache.org/jira/browse/OFBIZ-10386 > Project: OFBiz > Issue Type: Bug > Environment: https://demo-trunk.ofbiz.apache.org/ecomseo/viewprofile >Reporter: Archana Asthana >Assignee: Devanshu Vyas >Priority: Major > Attachments: EmptyFields.png, ViewProfile.patch > > > Steps to generate: > Open https://demo-trunk.ofbiz.apache.org/ecomseo/viewprofile > On the profile page, Go down to Contact list > Empty fields are displaying before Verify Subscription button > Expected: The field should have some specifications to be filled up > Image is attached for reference -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-10386) Empty field is reflecting on Contact list section on Profile Page
[ https://issues.apache.org/jira/browse/OFBIZ-10386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17202565#comment-17202565 ] Archana Asthana commented on OFBIZ-10386: - Thank you so much Praveen and Devanshu for your efforts. Yes, as you can refer to the image attached, the entire section seems empty with the header and the content missing in that field. So please provide the appropriate solution for this issue. I agree that there should be a header column to tell the purpose of the text boxes, before the Verify Subscription button. > Empty field is reflecting on Contact list section on Profile Page > - > > Key: OFBIZ-10386 > URL: https://issues.apache.org/jira/browse/OFBIZ-10386 > Project: OFBiz > Issue Type: Bug > Environment: https://demo-trunk.ofbiz.apache.org/ecomseo/viewprofile >Reporter: Archana Asthana >Assignee: Devanshu Vyas >Priority: Major > Attachments: EmptyFields.png, ViewProfile.patch > > > Steps to generate: > Open https://demo-trunk.ofbiz.apache.org/ecomseo/viewprofile > On the profile page, Go down to Contact list > Empty fields are displaying before Verify Subscription button > Expected: The field should have some specifications to be filled up > Image is attached for reference -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-10386) Empty field is reflecting on Contact list section on Profile Page
[ https://issues.apache.org/jira/browse/OFBIZ-10386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17202559#comment-17202559 ] Devanshu Vyas commented on OFBIZ-10386: --- Hello [~archana.asthana], I checked on the profile screen and found that there is a text box before the Verify Subscription button. Are you reporting the missing of the text box? OR as per the patch from [~praveen.patil], there should be a header/column for the text box. And in this case, I would suggest using _MarketingContactListOptInVerifyCode_ as the UiLabel instead of _FormFieldTitle_optInVerifyCode_. Let me know which is the case, so we can finalize on a solution. Cause we have both ready. > Empty field is reflecting on Contact list section on Profile Page > - > > Key: OFBIZ-10386 > URL: https://issues.apache.org/jira/browse/OFBIZ-10386 > Project: OFBiz > Issue Type: Bug > Environment: https://demo-trunk.ofbiz.apache.org/ecomseo/viewprofile >Reporter: Archana Asthana >Assignee: Devanshu Vyas >Priority: Major > Attachments: EmptyFields.png, ViewProfile.patch > > > Steps to generate: > Open https://demo-trunk.ofbiz.apache.org/ecomseo/viewprofile > On the profile page, Go down to Contact list > Empty fields are displaying before Verify Subscription button > Expected: The field should have some specifications to be filled up > Image is attached for reference -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-10386) Empty field is reflecting on Contact list section on Profile Page
[ https://issues.apache.org/jira/browse/OFBIZ-10386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17202529#comment-17202529 ] Praveen Patil commented on OFBIZ-10386: --- Hi, [~archana.asthana] I have attached the patch. Somehow I am not able to assign this ticket to me. > Empty field is reflecting on Contact list section on Profile Page > - > > Key: OFBIZ-10386 > URL: https://issues.apache.org/jira/browse/OFBIZ-10386 > Project: OFBiz > Issue Type: Bug > Environment: https://demo-trunk.ofbiz.apache.org/ecomseo/viewprofile >Reporter: Archana Asthana >Priority: Major > Attachments: EmptyFields.png, ViewProfile.patch > > > Steps to generate: > Open https://demo-trunk.ofbiz.apache.org/ecomseo/viewprofile > On the profile page, Go down to Contact list > Empty fields are displaying before Verify Subscription button > Expected: The field should have some specifications to be filled up > Image is attached for reference -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-10386) Empty field is reflecting on Contact list section on Profile Page
[ https://issues.apache.org/jira/browse/OFBIZ-10386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16603235#comment-16603235 ] Deepak Nigam commented on OFBIZ-10386: -- Hi [~archana.asthana] That blank field before the 'Verify Subscription' button is for entering optInVerifyCode, which we send to contacts in the subscription email. We can add the missing label here. Will provide the patch soon. > Empty field is reflecting on Contact list section on Profile Page > - > > Key: OFBIZ-10386 > URL: https://issues.apache.org/jira/browse/OFBIZ-10386 > Project: OFBiz > Issue Type: Bug > Environment: https://demo-trunk.ofbiz.apache.org/ecomseo/viewprofile >Reporter: Archana Asthana >Priority: Major > Attachments: EmptyFields.png > > > Steps to generate: > Open https://demo-trunk.ofbiz.apache.org/ecomseo/viewprofile > On the profile page, Go down to Contact list > Empty fields are displaying before Verify Subscription button > Expected: The field should have some specifications to be filled up > Image is attached for reference -- This message was sent by Atlassian JIRA (v7.6.3#76005)
