[jira] [Commented] (OFBIZ-10480) Refactoring and Reducing scope of variables in org.apache.ofbiz.common package
[ https://issues.apache.org/jira/browse/OFBIZ-10480?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17724196#comment-17724196 ] ASF subversion and git services commented on OFBIZ-10480: - Commit 388139fe4cc6a8c81489f6ceac379a6cda4f8b0d in ofbiz-framework's branch refs/heads/release22.01 from Jacques Le Roux [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=388139fe4c ] Fixed: Reducing scope of variables in common and base packages (OFBIZ-10477) (OFBIZ-10480) Following https://lists.apache.org/thread/g1z92gtlf9p1rxlc247yg2zqd6bczq7s conversation, this fixes SAFE util methods being transformed to private when obviously they should be public Thanks: Michael for spotting, reporting and confirming it's OK > Refactoring and Reducing scope of variables in org.apache.ofbiz.common package > -- > > Key: OFBIZ-10480 > URL: https://issues.apache.org/jira/browse/OFBIZ-10480 > Project: OFBiz > Issue Type: Sub-task >Affects Versions: 22.01.01, Upcoming Branch >Reporter: Pradhan Yash Sharma >Assignee: Jacques Le Roux >Priority: Minor > Fix For: 22.01.01, Upcoming Branch > > Attachments: OFBIZ-10480.patch > > > Updated summary of this ticket to include any code refactoring that can be > done on this package. Not to limit this ticket for only variable/method > scoping. > Please let me know if anyone has any issue and I will revert the update. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OFBIZ-10480) Refactoring and Reducing scope of variables in org.apache.ofbiz.common package
[ https://issues.apache.org/jira/browse/OFBIZ-10480?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17724189#comment-17724189 ] ASF subversion and git services commented on OFBIZ-10480: - Commit b034edd2ab59cfbcf4e28400358c6cd30af5b2dd in ofbiz-framework's branch refs/heads/trunk from Jacques Le Roux [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=b034edd2ab ] Fixed: Reducing scope of variables in common and base packages (OFBIZ-10477) (OFBIZ-10480) Following https://lists.apache.org/thread/g1z92gtlf9p1rxlc247yg2zqd6bczq7s conversation, this fixes SAFE util methods being transformed to private when obviously they should be public Thanks: Michael for spotting, reporting and confirming it's OK > Refactoring and Reducing scope of variables in org.apache.ofbiz.common package > -- > > Key: OFBIZ-10480 > URL: https://issues.apache.org/jira/browse/OFBIZ-10480 > Project: OFBiz > Issue Type: Sub-task >Affects Versions: 22.01.01, Upcoming Branch >Reporter: Pradhan Yash Sharma >Assignee: Jacques Le Roux >Priority: Minor > Fix For: Upcoming Branch > > Attachments: OFBIZ-10480.patch > > > Updated summary of this ticket to include any code refactoring that can be > done on this package. Not to limit this ticket for only variable/method > scoping. > Please let me know if anyone has any issue and I will revert the update. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OFBIZ-10480) Refactoring and Reducing scope of variables in org.apache.ofbiz.common package
[ https://issues.apache.org/jira/browse/OFBIZ-10480?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17724187#comment-17724187 ] ASF subversion and git services commented on OFBIZ-10480: - Commit 1786d92df3c1ab4d22d4e668307b5a5e1489293d in ofbiz-framework's branch refs/heads/release22.01 from Jacques Le Roux [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=1786d92df3 ] Fixed: Reducing scope of variables in common and base packages (OFBIZ-10477) (OFBIZ-10480) Following https://lists.apache.org/thread/g1z92gtlf9p1rxlc247yg2zqd6bczq7s conversation, this fixes SAFE util methods being transformed to private when obviously they should be public Thanks: Michael for spotting, reporting and confirming it's OK > Refactoring and Reducing scope of variables in org.apache.ofbiz.common package > -- > > Key: OFBIZ-10480 > URL: https://issues.apache.org/jira/browse/OFBIZ-10480 > Project: OFBiz > Issue Type: Sub-task >Affects Versions: 22.01.01, Upcoming Branch >Reporter: Pradhan Yash Sharma >Assignee: Jacques Le Roux >Priority: Minor > Fix For: Upcoming Branch > > Attachments: OFBIZ-10480.patch > > > Updated summary of this ticket to include any code refactoring that can be > done on this package. Not to limit this ticket for only variable/method > scoping. > Please let me know if anyone has any issue and I will revert the update. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OFBIZ-10480) Refactoring and Reducing scope of variables in org.apache.ofbiz.common package
[
https://issues.apache.org/jira/browse/OFBIZ-10480?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17609955#comment-17609955
]
Jacques Le Roux commented on OFBIZ-10480:
-
Commit 19676d430616a9d3be5228283f4381a37c3c8138 in ofbiz-framework's branch
refs/heads/trunk from Jacques Le Roux
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=19676d4306 ]
Improved: Reducing scope of variables in org.apache.ofbiz.commonpackage
(OFBIZ-10480)
jleroux: maybe because not all was applied or code changed, (or?) I had to
revert
public ScriptHelperImpl(ScriptContext context) {
+ ScriptHelperImpl(ScriptContext context) {
Thanks: Pradhan Yash Sharma for the patch
> Refactoring and Reducing scope of variables in org.apache.ofbiz.common package
> --
>
> Key: OFBIZ-10480
> URL: https://issues.apache.org/jira/browse/OFBIZ-10480
> Project: OFBiz
> Issue Type: Sub-task
>Affects Versions: 22.01.01, Upcoming Branch
>Reporter: Pradhan Yash Sharma
>Assignee: Jacques Le Roux
>Priority: Minor
> Attachments: OFBIZ-10480.patch
>
>
> Updated summary of this ticket to include any code refactoring that can be
> done on this package. Not to limit this ticket for only variable/method
> scoping.
> Please let me know if anyone has any issue and I will revert the update.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (OFBIZ-10480) Refactoring and Reducing scope of variables in org.apache.ofbiz.common package
[ https://issues.apache.org/jira/browse/OFBIZ-10480?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17609128#comment-17609128 ] Jacques Le Roux commented on OFBIZ-10480: - This patch is too old, does not apply. I'll close here in a week w/o an updated patch... Note that we can still apply hunks that pass. I think I'll do that before closing in any cases. > Refactoring and Reducing scope of variables in org.apache.ofbiz.common package > -- > > Key: OFBIZ-10480 > URL: https://issues.apache.org/jira/browse/OFBIZ-10480 > Project: OFBiz > Issue Type: Sub-task >Affects Versions: 22.01.01, Upcoming Branch >Reporter: Pradhan Yash Sharma >Assignee: Jacques Le Roux >Priority: Minor > Attachments: OFBIZ-10480.patch > > > Updated summary of this ticket to include any code refactoring that can be > done on this package. Not to limit this ticket for only variable/method > scoping. > Please let me know if anyone has any issue and I will revert the update. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OFBIZ-10480) Refactoring and Reducing scope of variables in org.apache.ofbiz.common package
[ https://issues.apache.org/jira/browse/OFBIZ-10480?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16614475#comment-16614475 ] Girish Vasmatkar commented on OFBIZ-10480: -- Thanks [~pfm.smits] for your review, Did you mean to restore the description of this ticket to its original value - "Reducing scope of variables in org.apache.ofbiz.common package". I, sure can do that, please let me know. Thanks. > Refactoring and Reducing scope of variables in org.apache.ofbiz.common package > -- > > Key: OFBIZ-10480 > URL: https://issues.apache.org/jira/browse/OFBIZ-10480 > Project: OFBiz > Issue Type: Sub-task >Affects Versions: Trunk >Reporter: Pradhan Yash Sharma >Assignee: Girish Vasmatkar >Priority: Minor > Fix For: Trunk > > Attachments: OFBIZ-10480.patch > > > Updated summary of this ticket to include any code refactoring that can be > done on this package. Not to limit this ticket for only variable/method > scoping. > Please let me know if anyone has any issue and I will revert the update. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10480) Refactoring and Reducing scope of variables in org.apache.ofbiz.common package
[
https://issues.apache.org/jira/browse/OFBIZ-10480?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16614415#comment-16614415
]
Pierre Smits commented on OFBIZ-10480:
--
HI [~gvasmatkar],
You changed the description of the ticket from
{quote}Reducing scope of variables in org.apache.ofbiz.common package
{quote}
to
{quote}Updated summary of this ticket to include any code refactoring that can
be done on this package. Not to limit this ticket for only variable/method
scoping.
Please let me know if anyone has any issue and I will revert the update.
{quote}
, but that doesn't provide anymore insights. As this is is a sub-task of an
master ticket, the master ticket should provide enough description to explain
the benefit, need, etc.
I suggest to update the description (of this ticket), as it will be - when the
code change is committed and made available via a release - the first thing an
adopter sees when he/she is perusing the release notes that accompany that
release.
> Refactoring and Reducing scope of variables in org.apache.ofbiz.common package
> --
>
> Key: OFBIZ-10480
> URL: https://issues.apache.org/jira/browse/OFBIZ-10480
> Project: OFBiz
> Issue Type: Sub-task
>Affects Versions: Trunk
>Reporter: Pradhan Yash Sharma
>Assignee: Girish Vasmatkar
>Priority: Minor
> Fix For: Trunk
>
> Attachments: OFBIZ-10480.patch
>
>
> Updated summary of this ticket to include any code refactoring that can be
> done on this package. Not to limit this ticket for only variable/method
> scoping.
> Please let me know if anyone has any issue and I will revert the update.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
