[jira] [Commented] (OFBIZ-11205) Move Groovy scripts from /groovyScripts/ to /src/main/groovy/
[
https://issues.apache.org/jira/browse/OFBIZ-11205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17028550#comment-17028550
]
Pierre Smits commented on OFBIZ-11205:
--
Nor should we priviledge third-party developers over adopters. Please keep in
mind that the business owners decide whether to adopt OFBiz (and hire
developers or system integrators to help them). or not.
> Move Groovy scripts from /groovyScripts/ to /src/main/groovy/
> --
>
> Key: OFBIZ-11205
> URL: https://issues.apache.org/jira/browse/OFBIZ-11205
> Project: OFBiz
> Issue Type: Improvement
> Components: ALL COMPONENTS
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Major
> Fix For: Upcoming Branch
>
>
> As mentioned in this discussion: https://markmail.org/message/2grqu63yvfpvxzz6
> {quote}
> Here is the (simple) plan:
> 1. We move all Groovy scripts from /groovyScripts/ to /src/main/groovy/
> 2. We add the necessary packages names
> 3. Devs can then open "gradlew --continuous" in a terminal and let it like
> that. It will continuously build on any changes in Gradle sourcesets
> So, if you modify a Groovy scripts while running an OFBiz instance, the
> changes will be reflected in the instance and you can check possible syntax
> or alike issues in the terminal running the continuous build. It's very fast
> since only changes have an impact on the build.
> I'm sure there are other benefits to follow "the common convention of putting
> groovy compiled sources in ${COMPONENT}/src/main/groovy.", as suggested
> Mathieu.
> {quote}
> [~paulfoxworthy] added
> bq. This will encourage and accelerate moving Java services to Groovy, I
> think.
> And [~gil portenseigne]:
> bq. The main advantage I see is, beside compilation, the integration in your
> IDE, that was not optimum, and the possibility to re-use methods from these
> script migrated to explicit classes.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (OFBIZ-11205) Move Groovy scripts from /groovyScripts/ to /src/main/groovy/
[
https://issues.apache.org/jira/browse/OFBIZ-11205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17028538#comment-17028538
]
Jacques Le Roux commented on OFBIZ-11205:
-
Thanks Mathieu, that's help for sure.
Pierre, yes that's right, I'd not mix dev and prod. And would certainly not
privilege prod at the expense of dev.
Anyway I'll try to collect all related information for everybody to get an idea
of the situation and the pro and cons...
> Move Groovy scripts from /groovyScripts/ to /src/main/groovy/
> --
>
> Key: OFBIZ-11205
> URL: https://issues.apache.org/jira/browse/OFBIZ-11205
> Project: OFBiz
> Issue Type: Improvement
> Components: ALL COMPONENTS
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Major
> Fix For: Upcoming Branch
>
>
> As mentioned in this discussion: https://markmail.org/message/2grqu63yvfpvxzz6
> {quote}
> Here is the (simple) plan:
> 1. We move all Groovy scripts from /groovyScripts/ to /src/main/groovy/
> 2. We add the necessary packages names
> 3. Devs can then open "gradlew --continuous" in a terminal and let it like
> that. It will continuously build on any changes in Gradle sourcesets
> So, if you modify a Groovy scripts while running an OFBiz instance, the
> changes will be reflected in the instance and you can check possible syntax
> or alike issues in the terminal running the continuous build. It's very fast
> since only changes have an impact on the build.
> I'm sure there are other benefits to follow "the common convention of putting
> groovy compiled sources in ${COMPONENT}/src/main/groovy.", as suggested
> Mathieu.
> {quote}
> [~paulfoxworthy] added
> bq. This will encourage and accelerate moving Java services to Groovy, I
> think.
> And [~gil portenseigne]:
> bq. The main advantage I see is, beside compilation, the integration in your
> IDE, that was not optimum, and the possibility to re-use methods from these
> script migrated to explicit classes.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (OFBIZ-11205) Move Groovy scripts from /groovyScripts/ to /src/main/groovy/
[
https://issues.apache.org/jira/browse/OFBIZ-11205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17028462#comment-17028462
]
Pierre Smits commented on OFBIZ-11205:
--
The latest comment by Mathieu highlights the differences between:
# what is good for the project and its contributors
# what is good for developers working for adopters
# what is good for adopters regarding their OFBiz production infrastructure.
It is clear that while doing development (aspect 1 & 2) the parties involved do
not want to wait on compilation cycles. Hence the advantages of being able to
see the effects of changes in groovy scripts immediately (e.g. in the log or
the browser).
On the other hand, adopters (the business using OFBiz as a strategic tool for
their sustainability) often have strict policies and procedures regarding
running, deploying into and upgrading the production environment.
There aspects like performance and reliability are key, and drive who can
perform specific actions.
> Move Groovy scripts from /groovyScripts/ to /src/main/groovy/
> --
>
> Key: OFBIZ-11205
> URL: https://issues.apache.org/jira/browse/OFBIZ-11205
> Project: OFBiz
> Issue Type: Improvement
> Components: ALL COMPONENTS
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Major
> Fix For: Upcoming Branch
>
>
> As mentioned in this discussion: https://markmail.org/message/2grqu63yvfpvxzz6
> {quote}
> Here is the (simple) plan:
> 1. We move all Groovy scripts from /groovyScripts/ to /src/main/groovy/
> 2. We add the necessary packages names
> 3. Devs can then open "gradlew --continuous" in a terminal and let it like
> that. It will continuously build on any changes in Gradle sourcesets
> So, if you modify a Groovy scripts while running an OFBiz instance, the
> changes will be reflected in the instance and you can check possible syntax
> or alike issues in the terminal running the continuous build. It's very fast
> since only changes have an impact on the build.
> I'm sure there are other benefits to follow "the common convention of putting
> groovy compiled sources in ${COMPONENT}/src/main/groovy.", as suggested
> Mathieu.
> {quote}
> [~paulfoxworthy] added
> bq. This will encourage and accelerate moving Java services to Groovy, I
> think.
> And [~gil portenseigne]:
> bq. The main advantage I see is, beside compilation, the integration in your
> IDE, that was not optimum, and the possibility to re-use methods from these
> script migrated to explicit classes.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (OFBIZ-11205) Move Groovy scripts from /groovyScripts/ to /src/main/groovy/
[
https://issues.apache.org/jira/browse/OFBIZ-11205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17028456#comment-17028456
]
Michael Brohl commented on OFBIZ-11205:
---
Thank you for the clarification, [~mthl] . Discussing the details does help to
have a good overall picture reagrding the pros and cons. Looking forward to
collect and discuss all aspects in the Wiki and on the dev mailing list.
> Move Groovy scripts from /groovyScripts/ to /src/main/groovy/
> --
>
> Key: OFBIZ-11205
> URL: https://issues.apache.org/jira/browse/OFBIZ-11205
> Project: OFBiz
> Issue Type: Improvement
> Components: ALL COMPONENTS
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Major
> Fix For: Upcoming Branch
>
>
> As mentioned in this discussion: https://markmail.org/message/2grqu63yvfpvxzz6
> {quote}
> Here is the (simple) plan:
> 1. We move all Groovy scripts from /groovyScripts/ to /src/main/groovy/
> 2. We add the necessary packages names
> 3. Devs can then open "gradlew --continuous" in a terminal and let it like
> that. It will continuously build on any changes in Gradle sourcesets
> So, if you modify a Groovy scripts while running an OFBiz instance, the
> changes will be reflected in the instance and you can check possible syntax
> or alike issues in the terminal running the continuous build. It's very fast
> since only changes have an impact on the build.
> I'm sure there are other benefits to follow "the common convention of putting
> groovy compiled sources in ${COMPONENT}/src/main/groovy.", as suggested
> Mathieu.
> {quote}
> [~paulfoxworthy] added
> bq. This will encourage and accelerate moving Java services to Groovy, I
> think.
> And [~gil portenseigne]:
> bq. The main advantage I see is, beside compilation, the integration in your
> IDE, that was not optimum, and the possibility to re-use methods from these
> script migrated to explicit classes.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (OFBIZ-11205) Move Groovy scripts from /groovyScripts/ to /src/main/groovy/
[
https://issues.apache.org/jira/browse/OFBIZ-11205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17028452#comment-17028452
]
Mathieu Lirzin commented on OFBIZ-11205:
Hello,
Having dynamic development capabilities and distributing code inside a jar are
not conflicting requirements as long as the loading mechanism can access the
source files. In a development environment you do not use a jar directly, the
build tool (gradle) use sub-directories inside the {{build}} directory and make
the classpath point to those directories. {{gradlew --continuous}} ensures that
the {{build}} directory is in sync with the source one which enable dynamic
development.
Having all the framework code and resources inside the jar is just a commodity
of distribution facilitating the execution and extension of OFBiz outside of
the context of the framework development.
Does it help understanding the absence of conflicts?
> Move Groovy scripts from /groovyScripts/ to /src/main/groovy/
> --
>
> Key: OFBIZ-11205
> URL: https://issues.apache.org/jira/browse/OFBIZ-11205
> Project: OFBiz
> Issue Type: Improvement
> Components: ALL COMPONENTS
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Major
> Fix For: Upcoming Branch
>
>
> As mentioned in this discussion: https://markmail.org/message/2grqu63yvfpvxzz6
> {quote}
> Here is the (simple) plan:
> 1. We move all Groovy scripts from /groovyScripts/ to /src/main/groovy/
> 2. We add the necessary packages names
> 3. Devs can then open "gradlew --continuous" in a terminal and let it like
> that. It will continuously build on any changes in Gradle sourcesets
> So, if you modify a Groovy scripts while running an OFBiz instance, the
> changes will be reflected in the instance and you can check possible syntax
> or alike issues in the terminal running the continuous build. It's very fast
> since only changes have an impact on the build.
> I'm sure there are other benefits to follow "the common convention of putting
> groovy compiled sources in ${COMPONENT}/src/main/groovy.", as suggested
> Mathieu.
> {quote}
> [~paulfoxworthy] added
> bq. This will encourage and accelerate moving Java services to Groovy, I
> think.
> And [~gil portenseigne]:
> bq. The main advantage I see is, beside compilation, the integration in your
> IDE, that was not optimum, and the possibility to re-use methods from these
> script migrated to explicit classes.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (OFBIZ-11205) Move Groovy scripts from /groovyScripts/ to /src/main/groovy/
[
https://issues.apache.org/jira/browse/OFBIZ-11205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17028424#comment-17028424
]
Jacques Le Roux commented on OFBIZ-11205:
-
I see, as Pierre suggested, in order to collect all the ideas/question/answer
in one place, we need to create a wiki page to discuss the pro and cons of
Mathieu's plan. I'll do ASAP...
> Move Groovy scripts from /groovyScripts/ to /src/main/groovy/
> --
>
> Key: OFBIZ-11205
> URL: https://issues.apache.org/jira/browse/OFBIZ-11205
> Project: OFBiz
> Issue Type: Improvement
> Components: ALL COMPONENTS
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Major
> Fix For: Upcoming Branch
>
>
> As mentioned in this discussion: https://markmail.org/message/2grqu63yvfpvxzz6
> {quote}
> Here is the (simple) plan:
> 1. We move all Groovy scripts from /groovyScripts/ to /src/main/groovy/
> 2. We add the necessary packages names
> 3. Devs can then open "gradlew --continuous" in a terminal and let it like
> that. It will continuously build on any changes in Gradle sourcesets
> So, if you modify a Groovy scripts while running an OFBiz instance, the
> changes will be reflected in the instance and you can check possible syntax
> or alike issues in the terminal running the continuous build. It's very fast
> since only changes have an impact on the build.
> I'm sure there are other benefits to follow "the common convention of putting
> groovy compiled sources in ${COMPONENT}/src/main/groovy.", as suggested
> Mathieu.
> {quote}
> [~paulfoxworthy] added
> bq. This will encourage and accelerate moving Java services to Groovy, I
> think.
> And [~gil portenseigne]:
> bq. The main advantage I see is, beside compilation, the integration in your
> IDE, that was not optimum, and the possibility to re-use methods from these
> script migrated to explicit classes.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (OFBIZ-11205) Move Groovy scripts from /groovyScripts/ to /src/main/groovy/
[
https://issues.apache.org/jira/browse/OFBIZ-11205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17028369#comment-17028369
]
Michael Brohl commented on OFBIZ-11205:
---
I wondered how it would work when you have all ressources (incl. Groovy
scripts) build into a single jar and deployed in an external appplication
server to run it as it is planned for the future and on the other hand want to
use the continuous feature and be able to change groovy scripts on-the-fly.
> Move Groovy scripts from /groovyScripts/ to /src/main/groovy/
> --
>
> Key: OFBIZ-11205
> URL: https://issues.apache.org/jira/browse/OFBIZ-11205
> Project: OFBiz
> Issue Type: Improvement
> Components: ALL COMPONENTS
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Major
> Fix For: Upcoming Branch
>
>
> As mentioned in this discussion: https://markmail.org/message/2grqu63yvfpvxzz6
> {quote}
> Here is the (simple) plan:
> 1. We move all Groovy scripts from /groovyScripts/ to /src/main/groovy/
> 2. We add the necessary packages names
> 3. Devs can then open "gradlew --continuous" in a terminal and let it like
> that. It will continuously build on any changes in Gradle sourcesets
> So, if you modify a Groovy scripts while running an OFBiz instance, the
> changes will be reflected in the instance and you can check possible syntax
> or alike issues in the terminal running the continuous build. It's very fast
> since only changes have an impact on the build.
> I'm sure there are other benefits to follow "the common convention of putting
> groovy compiled sources in ${COMPONENT}/src/main/groovy.", as suggested
> Mathieu.
> {quote}
> [~paulfoxworthy] added
> bq. This will encourage and accelerate moving Java services to Groovy, I
> think.
> And [~gil portenseigne]:
> bq. The main advantage I see is, beside compilation, the integration in your
> IDE, that was not optimum, and the possibility to re-use methods from these
> script migrated to explicit classes.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (OFBIZ-11205) Move Groovy scripts from /groovyScripts/ to /src/main/groovy/
[
https://issues.apache.org/jira/browse/OFBIZ-11205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17028316#comment-17028316
]
Jacques Le Roux commented on OFBIZ-11205:
-
What makes you ask this question with a bias in? Have you an idea about it?
bq. Aren't these goals conflicting each other?
Maybe [~mthl] could better answer your questions BTW?
> Move Groovy scripts from /groovyScripts/ to /src/main/groovy/
> --
>
> Key: OFBIZ-11205
> URL: https://issues.apache.org/jira/browse/OFBIZ-11205
> Project: OFBiz
> Issue Type: Improvement
> Components: ALL COMPONENTS
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Major
> Fix For: Upcoming Branch
>
>
> As mentioned in this discussion: https://markmail.org/message/2grqu63yvfpvxzz6
> {quote}
> Here is the (simple) plan:
> 1. We move all Groovy scripts from /groovyScripts/ to /src/main/groovy/
> 2. We add the necessary packages names
> 3. Devs can then open "gradlew --continuous" in a terminal and let it like
> that. It will continuously build on any changes in Gradle sourcesets
> So, if you modify a Groovy scripts while running an OFBiz instance, the
> changes will be reflected in the instance and you can check possible syntax
> or alike issues in the terminal running the continuous build. It's very fast
> since only changes have an impact on the build.
> I'm sure there are other benefits to follow "the common convention of putting
> groovy compiled sources in ${COMPONENT}/src/main/groovy.", as suggested
> Mathieu.
> {quote}
> [~paulfoxworthy] added
> bq. This will encourage and accelerate moving Java services to Groovy, I
> think.
> And [~gil portenseigne]:
> bq. The main advantage I see is, beside compilation, the integration in your
> IDE, that was not optimum, and the possibility to re-use methods from these
> script migrated to explicit classes.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (OFBIZ-11205) Move Groovy scripts from /groovyScripts/ to /src/main/groovy/
[
https://issues.apache.org/jira/browse/OFBIZ-11205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17028047#comment-17028047
]
Michael Brohl commented on OFBIZ-11205:
---
How does the idea behind this change interfere with the proposed goal to have
all ressources (incl. Groovy scripts) inside the ofbiz.jar to be deployed?
Aren't these goals conflicting each other?
> Move Groovy scripts from /groovyScripts/ to /src/main/groovy/
> --
>
> Key: OFBIZ-11205
> URL: https://issues.apache.org/jira/browse/OFBIZ-11205
> Project: OFBiz
> Issue Type: Improvement
> Components: ALL COMPONENTS
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Major
> Fix For: Upcoming Branch
>
>
> As mentioned in this discussion: https://markmail.org/message/2grqu63yvfpvxzz6
> {quote}
> Here is the (simple) plan:
> 1. We move all Groovy scripts from /groovyScripts/ to /src/main/groovy/
> 2. We add the necessary packages names
> 3. Devs can then open "gradlew --continuous" in a terminal and let it like
> that. It will continuously build on any changes in Gradle sourcesets
> So, if you modify a Groovy scripts while running an OFBiz instance, the
> changes will be reflected in the instance and you can check possible syntax
> or alike issues in the terminal running the continuous build. It's very fast
> since only changes have an impact on the build.
> I'm sure there are other benefits to follow "the common convention of putting
> groovy compiled sources in ${COMPONENT}/src/main/groovy.", as suggested
> Mathieu.
> {quote}
> [~paulfoxworthy] added
> bq. This will encourage and accelerate moving Java services to Groovy, I
> think.
> And [~gil portenseigne]:
> bq. The main advantage I see is, beside compilation, the integration in your
> IDE, that was not optimum, and the possibility to re-use methods from these
> script migrated to explicit classes.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (OFBIZ-11205) Move Groovy scripts from /groovyScripts/ to /src/main/groovy/
[
https://issues.apache.org/jira/browse/OFBIZ-11205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16935319#comment-16935319
]
Jacques Le Roux commented on OFBIZ-11205:
-
At revision: 1867344, I moved FetchLogs.groovy as a 1st step
> Move Groovy scripts from /groovyScripts/ to /src/main/groovy/
> --
>
> Key: OFBIZ-11205
> URL: https://issues.apache.org/jira/browse/OFBIZ-11205
> Project: OFBiz
> Issue Type: Improvement
> Components: ALL COMPONENTS
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Major
> Fix For: Upcoming Branch
>
>
> As mentioned in this discussion: https://markmail.org/message/2grqu63yvfpvxzz6
> {quote}
> Here is the (simple) plan:
> 1. We move all Groovy scripts from /groovyScripts/ to /src/main/groovy/
> 2. We add the necessary packages names
> 3. Devs can then open "gradlew --continuous" in a terminal and let it like
> that. It will continuously build on any changes in Gradle sourcesets
> So, if you modify a Groovy scripts while running an OFBiz instance, the
> changes will be reflected in the instance and you can check possible syntax
> or alike issues in the terminal running the continuous build. It's very fast
> since only changes have an impact on the build.
> I'm sure there are other benefits to follow "the common convention of putting
> groovy compiled sources in ${COMPONENT}/src/main/groovy.", as suggested
> Mathieu.
> {quote}
> [~paulfoxworthy] added
> bq. This will encourage and accelerate moving Java services to Groovy, I
> think.
> And [~gil portenseigne]:
> bq. The main advantage I see is, beside compilation, the integration in your
> IDE, that was not optimum, and the possibility to re-use methods from these
> script migrated to explicit classes.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
