[jira] [Commented] (OFBIZ-11211) Fix multi modal opening
[ https://issues.apache.org/jira/browse/OFBIZ-11211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16955109#comment-16955109 ] Jacques Le Roux commented on OFBIZ-11211: - Thanks Leila, Your patch is in trunk r1868615 R18 r1868616 I did not backport in R17 nor R16 because of tree conflicts > Fix multi modal opening > --- > > Key: OFBIZ-11211 > URL: https://issues.apache.org/jira/browse/OFBIZ-11211 > Project: OFBiz > Issue Type: Bug > Components: framework >Affects Versions: Trunk >Reporter: Demus Carl >Assignee: Jacques Le Roux >Priority: Minor > Fix For: 17.12.01, 18.12.01 > > Attachments: OFBIZ-11211-V2.patch, OFBIZ-11211.patch > > > The issue is that when closing the modal the div inside html dom is not > removed. Then opening a second time create another identical div. Since a > lookup is based on an unique id, this id is no more unique... > > This issue is link to my previous issue OFBIZ-11210 > Attached patch fix the issue -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11211) Fix multi modal opening
[ https://issues.apache.org/jira/browse/OFBIZ-11211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16954694#comment-16954694 ] Demus Carl commented on OFBIZ-11211: It's ok for me, it's more clear and simple so, i've no objection. > Fix multi modal opening > --- > > Key: OFBIZ-11211 > URL: https://issues.apache.org/jira/browse/OFBIZ-11211 > Project: OFBiz > Issue Type: Bug > Components: framework >Affects Versions: Trunk >Reporter: Demus Carl >Assignee: Jacques Le Roux >Priority: Minor > Fix For: 17.12.01, 18.12.01 > > Attachments: OFBIZ-11211-V2.patch, OFBIZ-11211.patch > > > The issue is that when closing the modal the div inside html dom is not > removed. Then opening a second time create another identical div. Since a > lookup is based on an unique id, this id is no more unique... > > This issue is link to my previous issue OFBIZ-11210 > Attached patch fix the issue -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11211) Fix multi modal opening
[ https://issues.apache.org/jira/browse/OFBIZ-11211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16954662#comment-16954662 ] Leila Mekika commented on OFBIZ-11211: -- Hello [~jleroux] , [~dcarl] I would like to suggest an update to simplify a little bit the current code. You can see this in the attached patch 'OFBIZ-11211-V2': what do you think of it ? > Fix multi modal opening > --- > > Key: OFBIZ-11211 > URL: https://issues.apache.org/jira/browse/OFBIZ-11211 > Project: OFBiz > Issue Type: Bug > Components: framework >Affects Versions: Trunk >Reporter: Demus Carl >Assignee: Jacques Le Roux >Priority: Minor > Fix For: 17.12.01, 18.12.01 > > Attachments: OFBIZ-11211-V2.patch, OFBIZ-11211.patch > > > The issue is that when closing the modal the div inside html dom is not > removed. Then opening a second time create another identical div. Since a > lookup is based on an unique id, this id is no more unique... > > This issue is link to my previous issue OFBIZ-11210 > Attached patch fix the issue -- This message was sent by Atlassian Jira (v8.3.4#803005)
