[jira] [Commented] (OFBIZ-11236) Add shipment notes
[ https://issues.apache.org/jira/browse/OFBIZ-11236?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17449530#comment-17449530 ] Gaudin Pierre commented on OFBIZ-11236: --- Thank you Devanshu and jacques for your pugnacity... Like many of us, I don't have enough time to get back into this ticket at the moment. If you are interested in continuing Devanshu, I thank you very much in advance. (y) > Add shipment notes > -- > > Key: OFBIZ-11236 > URL: https://issues.apache.org/jira/browse/OFBIZ-11236 > Project: OFBiz > Issue Type: New Feature > Components: product >Affects Versions: Trunk >Reporter: Gaudin Pierre >Priority: Minor > Labels: shipment > Attachments: OFBIZ-11236_shipmentNotesV3.patch, Screen Shot > 2020-02-11 at 08.53.37.png > > > Hello, > For many entities there are associated notes. However, there are no notes > associated with shipments. > The purpose of this patch is therefore to add notes to the shipments. > A new tab called "note" appears when displaying a shipment. From this tab it > is possible to add a note. From the shipment overview a section displays the > notes associated with the shipment. > For this new feature a "ShipmentNote" entity has been added. In the same way, > all the services allowing the management of notes have been associated. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Commented] (OFBIZ-11236) Add shipment notes
[ https://issues.apache.org/jira/browse/OFBIZ-11236?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17449301#comment-17449301 ] Jacques Le Roux commented on OFBIZ-11236: - Hi Devanshu, That would be quite great and much appreciated (y) > Add shipment notes > -- > > Key: OFBIZ-11236 > URL: https://issues.apache.org/jira/browse/OFBIZ-11236 > Project: OFBiz > Issue Type: New Feature > Components: product >Affects Versions: Trunk >Reporter: Gaudin Pierre >Priority: Minor > Labels: shipment > Attachments: OFBIZ-11236_shipmentNotesV3.patch, Screen Shot > 2020-02-11 at 08.53.37.png > > > Hello, > For many entities there are associated notes. However, there are no notes > associated with shipments. > The purpose of this patch is therefore to add notes to the shipments. > A new tab called "note" appears when displaying a shipment. From this tab it > is possible to add a note. From the shipment overview a section displays the > notes associated with the shipment. > For this new feature a "ShipmentNote" entity has been added. In the same way, > all the services allowing the management of notes have been associated. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Commented] (OFBIZ-11236) Add shipment notes
[ https://issues.apache.org/jira/browse/OFBIZ-11236?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17449271#comment-17449271 ] Devanshu Vyas commented on OFBIZ-11236: --- If [~gpierre] is not free to continue on this, I would like to offer my assistance and I can complete all the mentioned improvements and complete the feature. > Add shipment notes > -- > > Key: OFBIZ-11236 > URL: https://issues.apache.org/jira/browse/OFBIZ-11236 > Project: OFBiz > Issue Type: New Feature > Components: product >Affects Versions: Trunk >Reporter: Gaudin Pierre >Priority: Minor > Labels: shipment > Attachments: OFBIZ-11236_shipmentNotesV3.patch, Screen Shot > 2020-02-11 at 08.53.37.png > > > Hello, > For many entities there are associated notes. However, there are no notes > associated with shipments. > The purpose of this patch is therefore to add notes to the shipments. > A new tab called "note" appears when displaying a shipment. From this tab it > is possible to add a note. From the shipment overview a section displays the > notes associated with the shipment. > For this new feature a "ShipmentNote" entity has been added. In the same way, > all the services allowing the management of notes have been associated. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Commented] (OFBIZ-11236) Add shipment notes
[ https://issues.apache.org/jira/browse/OFBIZ-11236?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17435878#comment-17435878 ] Jacques Le Roux commented on OFBIZ-11236: - So, what is the situation here [~gpierre]? > Add shipment notes > -- > > Key: OFBIZ-11236 > URL: https://issues.apache.org/jira/browse/OFBIZ-11236 > Project: OFBiz > Issue Type: New Feature > Components: product >Affects Versions: Trunk >Reporter: Gaudin Pierre >Priority: Minor > Labels: shipment > Attachments: OFBIZ-11236_shipmentNotesV3.patch, Screen Shot > 2020-02-11 at 08.53.37.png > > > Hello, > For many entities there are associated notes. However, there are no notes > associated with shipments. > The purpose of this patch is therefore to add notes to the shipments. > A new tab called "note" appears when displaying a shipment. From this tab it > is possible to add a note. From the shipment overview a section displays the > notes associated with the shipment. > For this new feature a "ShipmentNote" entity has been added. In the same way, > all the services allowing the management of notes have been associated. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11236) Add shipment notes
[ https://issues.apache.org/jira/browse/OFBIZ-11236?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17189134#comment-17189134 ] Jacques Le Roux commented on OFBIZ-11236: - Hi Michael, Devanshu, I totally agree, I had an alert poping every week about that to complete the work. It's now every month :D > Add shipment notes > -- > > Key: OFBIZ-11236 > URL: https://issues.apache.org/jira/browse/OFBIZ-11236 > Project: OFBiz > Issue Type: New Feature > Components: product >Affects Versions: Trunk >Reporter: Gaudin Pierre >Priority: Minor > Labels: shipment > Attachments: OFBIZ-11236_shipmentNotesV3.patch, Screen Shot > 2020-02-11 at 08.53.37.png > > > Hello, > For many entities there are associated notes. However, there are no notes > associated with shipments. > The purpose of this patch is therefore to add notes to the shipments. > A new tab called "note" appears when displaying a shipment. From this tab it > is possible to add a note. From the shipment overview a section displays the > notes associated with the shipment. > For this new feature a "ShipmentNote" entity has been added. In the same way, > all the services allowing the management of notes have been associated. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11236) Add shipment notes
[ https://issues.apache.org/jira/browse/OFBIZ-11236?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17189106#comment-17189106 ] Devanshu Vyas commented on OFBIZ-11236: --- In my humble opinion, I think we should always give all the time to the contributor for the new functionality implementation if he/she is working on the task. And, if he/she is not available to work on it(maybe due to any no. of reasons) then we should as a community should help the person and pick the task up. Whenever the contributor comes back can share his/her opinion and we will honour those suggestions with consensus. Due to the unavailability of a contributor, a good feature should not be delayed in the project. We should all work together in harmony to bring any task to a closure. :) > Add shipment notes > -- > > Key: OFBIZ-11236 > URL: https://issues.apache.org/jira/browse/OFBIZ-11236 > Project: OFBiz > Issue Type: New Feature > Components: product >Affects Versions: Trunk >Reporter: Gaudin Pierre >Priority: Minor > Labels: shipment > Attachments: OFBIZ-11236_shipmentNotesV3.patch, Screen Shot > 2020-02-11 at 08.53.37.png > > > Hello, > For many entities there are associated notes. However, there are no notes > associated with shipments. > The purpose of this patch is therefore to add notes to the shipments. > A new tab called "note" appears when displaying a shipment. From this tab it > is possible to add a note. From the shipment overview a section displays the > notes associated with the shipment. > For this new feature a "ShipmentNote" entity has been added. In the same way, > all the services allowing the management of notes have been associated. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11236) Add shipment notes
[ https://issues.apache.org/jira/browse/OFBIZ-11236?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17064652#comment-17064652 ] Michael Brohl commented on OFBIZ-11236: --- For a new functionality I would set no date at all. Just let the contributor take his time. > Add shipment notes > -- > > Key: OFBIZ-11236 > URL: https://issues.apache.org/jira/browse/OFBIZ-11236 > Project: OFBiz > Issue Type: New Feature > Components: product >Affects Versions: Trunk >Reporter: Gaudin Pierre >Priority: Minor > Labels: shipment > Attachments: OFBIZ-11236_shipmentNotesV3.patch, Screen Shot > 2020-02-11 at 08.53.37.png > > > Hello, > For many entities there are associated notes. However, there are no notes > associated with shipments. > The purpose of this patch is therefore to add notes to the shipments. > A new tab called "note" appears when displaying a shipment. From this tab it > is possible to add a note. From the shipment overview a section displays the > notes associated with the shipment. > For this new feature a "ShipmentNote" entity has been added. In the same way, > all the services allowing the management of notes have been associated. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11236) Add shipment notes
[ https://issues.apache.org/jira/browse/OFBIZ-11236?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17064645#comment-17064645 ] Jacques Le Roux commented on OFBIZ-11236: - Michael, How long should we wait in your opinion? I already asked twice in soon 2 months. [~gpierre] maybe you pulled back because of PR#12? That's why I ask to take it over if we need to merge both, w/o missin any elements... > Add shipment notes > -- > > Key: OFBIZ-11236 > URL: https://issues.apache.org/jira/browse/OFBIZ-11236 > Project: OFBiz > Issue Type: New Feature > Components: product >Affects Versions: Trunk >Reporter: Gaudin Pierre >Priority: Minor > Labels: shipment > Attachments: OFBIZ-11236_shipmentNotesV3.patch, Screen Shot > 2020-02-11 at 08.53.37.png > > > Hello, > For many entities there are associated notes. However, there are no notes > associated with shipments. > The purpose of this patch is therefore to add notes to the shipments. > A new tab called "note" appears when displaying a shipment. From this tab it > is possible to add a note. From the shipment overview a section displays the > notes associated with the shipment. > For this new feature a "ShipmentNote" entity has been added. In the same way, > all the services allowing the management of notes have been associated. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11236) Add shipment notes
[ https://issues.apache.org/jira/browse/OFBIZ-11236?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17064642#comment-17064642 ] Michael Brohl commented on OFBIZ-11236: --- This is a new functionality, no need to put pressure on it. Pierre Gaudin reported it and provided the implementation patches. He should be regarded as the driving force behind the solution and should be the one who is in the driver's seat to manage the intereferences with the PR. > Add shipment notes > -- > > Key: OFBIZ-11236 > URL: https://issues.apache.org/jira/browse/OFBIZ-11236 > Project: OFBiz > Issue Type: New Feature > Components: product >Affects Versions: Trunk >Reporter: Gaudin Pierre >Priority: Minor > Labels: shipment > Attachments: OFBIZ-11236_shipmentNotesV3.patch, Screen Shot > 2020-02-11 at 08.53.37.png > > > Hello, > For many entities there are associated notes. However, there are no notes > associated with shipments. > The purpose of this patch is therefore to add notes to the shipments. > A new tab called "note" appears when displaying a shipment. From this tab it > is possible to add a note. From the shipment overview a section displays the > notes associated with the shipment. > For this new feature a "ShipmentNote" entity has been added. In the same way, > all the services allowing the management of notes have been associated. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11236) Add shipment notes
[ https://issues.apache.org/jira/browse/OFBIZ-11236?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17064636#comment-17064636 ] Jacques Le Roux commented on OFBIZ-11236: - Hi [~gpierre] Without answer in the week, I'll take care of the issue myself, in relation with https://github.com/apache/ofbiz-framework/pull/12 > Add shipment notes > -- > > Key: OFBIZ-11236 > URL: https://issues.apache.org/jira/browse/OFBIZ-11236 > Project: OFBiz > Issue Type: New Feature > Components: product >Affects Versions: Trunk >Reporter: Gaudin Pierre >Priority: Minor > Labels: shipment > Attachments: OFBIZ-11236_shipmentNotesV3.patch, Screen Shot > 2020-02-11 at 08.53.37.png > > > Hello, > For many entities there are associated notes. However, there are no notes > associated with shipments. > The purpose of this patch is therefore to add notes to the shipments. > A new tab called "note" appears when displaying a shipment. From this tab it > is possible to add a note. From the shipment overview a section displays the > notes associated with the shipment. > For this new feature a "ShipmentNote" entity has been added. In the same way, > all the services allowing the management of notes have been associated. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11236) Add shipment notes
[ https://issues.apache.org/jira/browse/OFBIZ-11236?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17051904#comment-17051904 ] Jacques Le Roux commented on OFBIZ-11236: - Hi Pierre, Any chances? I have this pending somehow, please let me know if you expect to do it "soon", TIA > Add shipment notes > -- > > Key: OFBIZ-11236 > URL: https://issues.apache.org/jira/browse/OFBIZ-11236 > Project: OFBiz > Issue Type: New Feature > Components: product >Affects Versions: Trunk >Reporter: Gaudin Pierre >Priority: Minor > Labels: shipment > Attachments: OFBIZ-11236_shipmentNotesV3.patch, Screen Shot > 2020-02-11 at 08.53.37.png > > > Hello, > For many entities there are associated notes. However, there are no notes > associated with shipments. > The purpose of this patch is therefore to add notes to the shipments. > A new tab called "note" appears when displaying a shipment. From this tab it > is possible to add a note. From the shipment overview a section displays the > notes associated with the shipment. > For this new feature a "ShipmentNote" entity has been added. In the same way, > all the services allowing the management of notes have been associated. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11236) Add shipment notes
[ https://issues.apache.org/jira/browse/OFBIZ-11236?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17035253#comment-17035253 ] Jacques Le Roux commented on OFBIZ-11236: - Thanks for clarification Devanshu, I agree with you > Add shipment notes > -- > > Key: OFBIZ-11236 > URL: https://issues.apache.org/jira/browse/OFBIZ-11236 > Project: OFBiz > Issue Type: New Feature > Components: product >Affects Versions: Trunk >Reporter: Gaudin Pierre >Priority: Minor > Labels: shipment > Attachments: OFBIZ-11236_shipmentNotesV3.patch, Screen Shot > 2020-02-11 at 08.53.37.png > > > Hello, > For many entities there are associated notes. However, there are no notes > associated with shipments. > The purpose of this patch is therefore to add notes to the shipments. > A new tab called "note" appears when displaying a shipment. From this tab it > is possible to add a note. From the shipment overview a section displays the > notes associated with the shipment. > For this new feature a "ShipmentNote" entity has been added. In the same way, > all the services allowing the management of notes have been associated. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11236) Add shipment notes
[ https://issues.apache.org/jira/browse/OFBIZ-11236?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17035073#comment-17035073 ] Devanshu Vyas commented on OFBIZ-11236: --- Guys, I think we are dragging this ticket a bit much. My humble opinion was to add a feature to edit/delete a note for user convenience, like if he/she added the note mistakenly or made a simple typo which could make the statement different to what was intended. Now, after listening to all the discussion here, I would like to rephrase my statement and to say that we should have a feature to at least expire a note so that an incorrect note should not be associated with the shipment. As for what [~pierresmits] said, "Many companies have strict policies regarding preserving the audit trail (for legal purposes)". I think CRUD services should be available in the system, but using them depends on the user/company. Agree with [~mbrohl] that time should not be a factor for reviewing a new feature and adding the complete set of CRUD services. > Add shipment notes > -- > > Key: OFBIZ-11236 > URL: https://issues.apache.org/jira/browse/OFBIZ-11236 > Project: OFBiz > Issue Type: New Feature > Components: product >Affects Versions: Trunk >Reporter: Gaudin Pierre >Priority: Minor > Labels: shipment > Attachments: OFBIZ-11236_shipmentNotesV3.patch, Screen Shot > 2020-02-11 at 08.53.37.png > > > Hello, > For many entities there are associated notes. However, there are no notes > associated with shipments. > The purpose of this patch is therefore to add notes to the shipments. > A new tab called "note" appears when displaying a shipment. From this tab it > is possible to add a note. From the shipment overview a section displays the > notes associated with the shipment. > For this new feature a "ShipmentNote" entity has been added. In the same way, > all the services allowing the management of notes have been associated. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11236) Add shipment notes
[ https://issues.apache.org/jira/browse/OFBIZ-11236?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17034567#comment-17034567 ] Gaudin Pierre commented on OFBIZ-11236: --- Thanks Jacques, I'll check it . > Add shipment notes > -- > > Key: OFBIZ-11236 > URL: https://issues.apache.org/jira/browse/OFBIZ-11236 > Project: OFBiz > Issue Type: New Feature > Components: product >Affects Versions: Trunk >Reporter: Gaudin Pierre >Priority: Minor > Labels: shipment > Attachments: OFBIZ-11236_shipmentNotesV3.patch, Screen Shot > 2020-02-11 at 08.53.37.png > > > Hello, > For many entities there are associated notes. However, there are no notes > associated with shipments. > The purpose of this patch is therefore to add notes to the shipments. > A new tab called "note" appears when displaying a shipment. From this tab it > is possible to add a note. From the shipment overview a section displays the > notes associated with the shipment. > For this new feature a "ShipmentNote" entity has been added. In the same way, > all the services allowing the management of notes have been associated. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11236) Add shipment notes
[ https://issues.apache.org/jira/browse/OFBIZ-11236?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17034530#comment-17034530 ] Jacques Le Roux commented on OFBIZ-11236: - Hi [~gpierre], Still my question remains (unrelated to the recent conversation): bq. But I see no notes at the bottom of shipment. Nor can I update or delete this note. I used shipmentId=9996 of Demo1002 order. Could I miss something? I see a note in [~pierresmits]'s image, I wonder why it did not work for me. I'll have a look when more pressent things will fade. Inthe meantime could you confirm it works for you with the shipmentId=9996 of Demo1002 order? Thanks in advance. > Add shipment notes > -- > > Key: OFBIZ-11236 > URL: https://issues.apache.org/jira/browse/OFBIZ-11236 > Project: OFBiz > Issue Type: New Feature > Components: product >Affects Versions: Trunk >Reporter: Gaudin Pierre >Priority: Minor > Labels: shipment > Attachments: OFBIZ-11236_shipmentNotesV3.patch, Screen Shot > 2020-02-11 at 08.53.37.png > > > Hello, > For many entities there are associated notes. However, there are no notes > associated with shipments. > The purpose of this patch is therefore to add notes to the shipments. > A new tab called "note" appears when displaying a shipment. From this tab it > is possible to add a note. From the shipment overview a section displays the > notes associated with the shipment. > For this new feature a "ShipmentNote" entity has been added. In the same way, > all the services allowing the management of notes have been associated. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11236) Add shipment notes
[
https://issues.apache.org/jira/browse/OFBIZ-11236?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17034468#comment-17034468
]
Michael Brohl commented on OFBIZ-11236:
---
{quote}As Jacques has told me a few times in the past 12 years (and I am
paraphrasing here): something done in less than 10 mins should be good enough
for the next step.
{quote}
I do not think that this is a formula which is valid. Time should not be a
factor when we talk about a *new feature*.
Quality, consistency and completeness should be the main factors to review for
new features. If a feature is committed in an incomplete state it is likely to
stay there in this state for a long time. We struggle with these from time to
time.
So if we have this new feature for shipment notes, it should be complete with
create/update/delete services and functionality in the UI to use them. It would
not be complete if it would only contain, say, a create shipment note
funtionality only.
This should be worked out as long as it takes to be complete.
> Add shipment notes
> --
>
> Key: OFBIZ-11236
> URL: https://issues.apache.org/jira/browse/OFBIZ-11236
> Project: OFBiz
> Issue Type: New Feature
> Components: product
>Affects Versions: Trunk
>Reporter: Gaudin Pierre
>Priority: Minor
> Labels: shipment
> Attachments: OFBIZ-11236_shipmentNotesV3.patch, Screen Shot
> 2020-02-11 at 08.53.37.png
>
>
> Hello,
> For many entities there are associated notes. However, there are no notes
> associated with shipments.
> The purpose of this patch is therefore to add notes to the shipments.
> A new tab called "note" appears when displaying a shipment. From this tab it
> is possible to add a note. From the shipment overview a section displays the
> notes associated with the shipment.
> For this new feature a "ShipmentNote" entity has been added. In the same way,
> all the services allowing the management of notes have been associated.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (OFBIZ-11236) Add shipment notes
[ https://issues.apache.org/jira/browse/OFBIZ-11236?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17034438#comment-17034438 ] Pierre Smits commented on OFBIZ-11236: -- Pierre, I totally have no issues with you doing your thing the way you want to do it. But consider this: Devanshu asked you to consider the delete function for this and you did a new contribution, and then Jacques brought up the other delete and update issue requiring more time to get this ticket closed. Both valid things to consider at another time. But before long another 'what about'-thing will be brought forward. And on and on And then this relatively small, but good, contribution will balloon into something even more time consuming. We should avoid that. As Jacques has told me a few times in the past 12 years (and I am paraphrasing here): something done in less than 10 mins should be good enough for the next step. We don't need to get perfect be the enemy of good enough. Best regards, Pierre > Add shipment notes > -- > > Key: OFBIZ-11236 > URL: https://issues.apache.org/jira/browse/OFBIZ-11236 > Project: OFBiz > Issue Type: New Feature > Components: product >Affects Versions: Trunk >Reporter: Gaudin Pierre >Priority: Minor > Labels: shipment > Attachments: OFBIZ-11236_shipmentNotesV3.patch, Screen Shot > 2020-02-11 at 08.53.37.png > > > Hello, > For many entities there are associated notes. However, there are no notes > associated with shipments. > The purpose of this patch is therefore to add notes to the shipments. > A new tab called "note" appears when displaying a shipment. From this tab it > is possible to add a note. From the shipment overview a section displays the > notes associated with the shipment. > For this new feature a "ShipmentNote" entity has been added. In the same way, > all the services allowing the management of notes have been associated. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11236) Add shipment notes
[ https://issues.apache.org/jira/browse/OFBIZ-11236?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17034425#comment-17034425 ] Gaudin Pierre commented on OFBIZ-11236: --- Hi Pierre, Faster or slower is not my preocupation. Thi is a contribution that you can inprove if you want but i just think, as [~devanshu.vyas] says, that the delete service should be added in the same commit as other services. > Add shipment notes > -- > > Key: OFBIZ-11236 > URL: https://issues.apache.org/jira/browse/OFBIZ-11236 > Project: OFBiz > Issue Type: New Feature > Components: product >Affects Versions: Trunk >Reporter: Gaudin Pierre >Priority: Minor > Labels: shipment > Attachments: OFBIZ-11236_shipmentNotesV3.patch, Screen Shot > 2020-02-11 at 08.53.37.png > > > Hello, > For many entities there are associated notes. However, there are no notes > associated with shipments. > The purpose of this patch is therefore to add notes to the shipments. > A new tab called "note" appears when displaying a shipment. From this tab it > is possible to add a note. From the shipment overview a section displays the > notes associated with the shipment. > For this new feature a "ShipmentNote" entity has been added. In the same way, > all the services allowing the management of notes have been associated. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11236) Add shipment notes
[ https://issues.apache.org/jira/browse/OFBIZ-11236?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17034423#comment-17034423 ] Pierre Smits commented on OFBIZ-11236: -- But I feel the available contributions are good enough for a first merge. Anything else can be done afterwards. > Add shipment notes > -- > > Key: OFBIZ-11236 > URL: https://issues.apache.org/jira/browse/OFBIZ-11236 > Project: OFBiz > Issue Type: New Feature > Components: product >Affects Versions: Trunk >Reporter: Gaudin Pierre >Priority: Minor > Labels: shipment > Attachments: OFBIZ-11236_shipmentNotesV3.patch, Screen Shot > 2020-02-11 at 08.53.37.png > > > Hello, > For many entities there are associated notes. However, there are no notes > associated with shipments. > The purpose of this patch is therefore to add notes to the shipments. > A new tab called "note" appears when displaying a shipment. From this tab it > is possible to add a note. From the shipment overview a section displays the > notes associated with the shipment. > For this new feature a "ShipmentNote" entity has been added. In the same way, > all the services allowing the management of notes have been associated. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11236) Add shipment notes
[ https://issues.apache.org/jira/browse/OFBIZ-11236?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17034413#comment-17034413 ] Pierre Smits commented on OFBIZ-11236: -- Hi Pierre, if you feel that doing so will aid in getting stuff into the codebase faster rather than slower, feel free to do so. > Add shipment notes > -- > > Key: OFBIZ-11236 > URL: https://issues.apache.org/jira/browse/OFBIZ-11236 > Project: OFBiz > Issue Type: New Feature > Components: product >Affects Versions: Trunk >Reporter: Gaudin Pierre >Assignee: Pierre Smits >Priority: Minor > Attachments: OFBIZ-11236_shipmentNotesV3.patch, Screen Shot > 2020-02-11 at 08.53.37.png > > > Hello, > For many entities there are associated notes. However, there are no notes > associated with shipments. > The purpose of this patch is therefore to add notes to the shipments. > A new tab called "note" appears when displaying a shipment. From this tab it > is possible to add a note. From the shipment overview a section displays the > notes associated with the shipment. > For this new feature a "ShipmentNote" entity has been added. In the same way, > all the services allowing the management of notes have been associated. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11236) Add shipment notes
[ https://issues.apache.org/jira/browse/OFBIZ-11236?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17034410#comment-17034410 ] Gaudin Pierre commented on OFBIZ-11236: --- Hi Pierre, Can we kepp this jira simple and add all the CRD's services at once? > Add shipment notes > -- > > Key: OFBIZ-11236 > URL: https://issues.apache.org/jira/browse/OFBIZ-11236 > Project: OFBiz > Issue Type: New Feature > Components: product >Affects Versions: Trunk >Reporter: Gaudin Pierre >Assignee: Pierre Smits >Priority: Minor > Attachments: OFBIZ-11236_shipmentNotesV3.patch, Screen Shot > 2020-02-11 at 08.53.37.png > > > Hello, > For many entities there are associated notes. However, there are no notes > associated with shipments. > The purpose of this patch is therefore to add notes to the shipments. > A new tab called "note" appears when displaying a shipment. From this tab it > is possible to add a note. From the shipment overview a section displays the > notes associated with the shipment. > For this new feature a "ShipmentNote" entity has been added. In the same way, > all the services allowing the management of notes have been associated. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11236) Add shipment notes
[ https://issues.apache.org/jira/browse/OFBIZ-11236?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17033961#comment-17033961 ] Pierre Smits commented on OFBIZ-11236: -- I > Add shipment notes > -- > > Key: OFBIZ-11236 > URL: https://issues.apache.org/jira/browse/OFBIZ-11236 > Project: OFBiz > Issue Type: New Feature > Components: product >Affects Versions: Trunk >Reporter: Gaudin Pierre >Assignee: Pierre Smits >Priority: Minor > Attachments: OFBIZ-11236_shipmentNotesV3.patch > > > Hello, > For many entities there are associated notes. However, there are no notes > associated with shipments. > The purpose of this patch is therefore to add notes to the shipments. > A new tab called "note" appears when displaying a shipment. From this tab it > is possible to add a note. From the shipment overview a section displays the > notes associated with the shipment. > For this new feature a "ShipmentNote" entity has been added. In the same way, > all the services allowing the management of notes have been associated. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11236) Add shipment notes
[ https://issues.apache.org/jira/browse/OFBIZ-11236?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17033959#comment-17033959 ] Pierre Smits commented on OFBIZ-11236: -- I have reworked the patch a bit, it is now available via https://github.com/apache/ofbiz-framework/pull/12 > Add shipment notes > -- > > Key: OFBIZ-11236 > URL: https://issues.apache.org/jira/browse/OFBIZ-11236 > Project: OFBiz > Issue Type: New Feature > Components: product >Affects Versions: Trunk >Reporter: Gaudin Pierre >Assignee: Pierre Smits >Priority: Minor > Attachments: OFBIZ-11236_shipmentNotesV3.patch > > > Hello, > For many entities there are associated notes. However, there are no notes > associated with shipments. > The purpose of this patch is therefore to add notes to the shipments. > A new tab called "note" appears when displaying a shipment. From this tab it > is possible to add a note. From the shipment overview a section displays the > notes associated with the shipment. > For this new feature a "ShipmentNote" entity has been added. In the same way, > all the services allowing the management of notes have been associated. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11236) Add shipment notes
[ https://issues.apache.org/jira/browse/OFBIZ-11236?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17033695#comment-17033695 ] Pierre Smits commented on OFBIZ-11236: -- It seems to me that you're sending confusing messages, Jacques. On the one hand you're saying you want to be able to delete stuff and on the other hand you're advocating that deletions should not be allowed. Let's leave this ticket simple, and have it only addressing the issue of adding notes. > Add shipment notes > -- > > Key: OFBIZ-11236 > URL: https://issues.apache.org/jira/browse/OFBIZ-11236 > Project: OFBiz > Issue Type: New Feature > Components: product >Affects Versions: Trunk >Reporter: Gaudin Pierre >Assignee: Jacques Le Roux >Priority: Minor > Attachments: OFBIZ-11236_shipmentNotesV3.patch > > > Hello, > For many entities there are associated notes. However, there are no notes > associated with shipments. > The purpose of this patch is therefore to add notes to the shipments. > A new tab called "note" appears when displaying a shipment. From this tab it > is possible to add a note. From the shipment overview a section displays the > notes associated with the shipment. > For this new feature a "ShipmentNote" entity has been added. In the same way, > all the services allowing the management of notes have been associated. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11236) Add shipment notes
[ https://issues.apache.org/jira/browse/OFBIZ-11236?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17033682#comment-17033682 ] Jacques Le Roux commented on OFBIZ-11236: - OK with me [~gpierre] , but what about my question: bq. But I see no notes at the bottom of shipment. Nor can I update or delete this note. I used shipmentId=9996 of Demo1002 order. Could I miss something? > Add shipment notes > -- > > Key: OFBIZ-11236 > URL: https://issues.apache.org/jira/browse/OFBIZ-11236 > Project: OFBiz > Issue Type: New Feature > Components: product >Affects Versions: Trunk >Reporter: Gaudin Pierre >Assignee: Jacques Le Roux >Priority: Minor > Attachments: OFBIZ-11236_shipmentNotesV3.patch > > > Hello, > For many entities there are associated notes. However, there are no notes > associated with shipments. > The purpose of this patch is therefore to add notes to the shipments. > A new tab called "note" appears when displaying a shipment. From this tab it > is possible to add a note. From the shipment overview a section displays the > notes associated with the shipment. > For this new feature a "ShipmentNote" entity has been added. In the same way, > all the services allowing the management of notes have been associated. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11236) Add shipment notes
[ https://issues.apache.org/jira/browse/OFBIZ-11236?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17033667#comment-17033667 ] Pierre Smits commented on OFBIZ-11236: -- +1 on leaving a specific control/function to others (3rd parties?). The 'delete' function can be regarded as such. In this case, I would have addressed it in a separate albeit a related ticket. And this ticket could remain to be all about the 'adding' notes functionality. > Add shipment notes > -- > > Key: OFBIZ-11236 > URL: https://issues.apache.org/jira/browse/OFBIZ-11236 > Project: OFBiz > Issue Type: New Feature > Components: product >Affects Versions: Trunk >Reporter: Gaudin Pierre >Assignee: Jacques Le Roux >Priority: Minor > Attachments: OFBIZ-11236_shipmentNotesV3.patch > > > Hello, > For many entities there are associated notes. However, there are no notes > associated with shipments. > The purpose of this patch is therefore to add notes to the shipments. > A new tab called "note" appears when displaying a shipment. From this tab it > is possible to add a note. From the shipment overview a section displays the > notes associated with the shipment. > For this new feature a "ShipmentNote" entity has been added. In the same way, > all the services allowing the management of notes have been associated. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11236) Add shipment notes
[ https://issues.apache.org/jira/browse/OFBIZ-11236?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17033654#comment-17033654 ] Gaudin Pierre commented on OFBIZ-11236: --- Hi I think it depends on the process, even if the shipment is closed or cancelled. So, as in many OFBiz screens, we show everything we can do in a general way and if someone wants a specific control, they can add it. > Add shipment notes > -- > > Key: OFBIZ-11236 > URL: https://issues.apache.org/jira/browse/OFBIZ-11236 > Project: OFBiz > Issue Type: New Feature > Components: product >Affects Versions: Trunk >Reporter: Gaudin Pierre >Assignee: Jacques Le Roux >Priority: Minor > Attachments: OFBIZ-11236_shipmentNotesV3.patch > > > Hello, > For many entities there are associated notes. However, there are no notes > associated with shipments. > The purpose of this patch is therefore to add notes to the shipments. > A new tab called "note" appears when displaying a shipment. From this tab it > is possible to add a note. From the shipment overview a section displays the > notes associated with the shipment. > For this new feature a "ShipmentNote" entity has been added. In the same way, > all the services allowing the management of notes have been associated. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11236) Add shipment notes
[ https://issues.apache.org/jira/browse/OFBIZ-11236?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17028776#comment-17028776 ] Jacques Le Roux commented on OFBIZ-11236: - Hi Pierre, You wrote: bq. Having a 'delete shipment note' function may not be right course to go. Many companies have strict policies regarding preserving the audit trail (for legal purposes). I think you somehow have a point there. I think this could depend on the status of the shipment. Deleting or modifying a shipped shipment should not be allowed, [~gpierre] could you please handle that? > Add shipment notes > -- > > Key: OFBIZ-11236 > URL: https://issues.apache.org/jira/browse/OFBIZ-11236 > Project: OFBiz > Issue Type: New Feature > Components: product >Affects Versions: Trunk >Reporter: Gaudin Pierre >Assignee: Jacques Le Roux >Priority: Minor > Attachments: OFBIZ-11236_shipmentNotesV3.patch > > > Hello, > For many entities there are associated notes. However, there are no notes > associated with shipments. > The purpose of this patch is therefore to add notes to the shipments. > A new tab called "note" appears when displaying a shipment. From this tab it > is possible to add a note. From the shipment overview a section displays the > notes associated with the shipment. > For this new feature a "ShipmentNote" entity has been added. In the same way, > all the services allowing the management of notes have been associated. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11236) Add shipment notes
[ https://issues.apache.org/jira/browse/OFBIZ-11236?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17028439#comment-17028439 ] Jacques Le Roux commented on OFBIZ-11236: - BTW, thank you Devanshu for your review :) > Add shipment notes > -- > > Key: OFBIZ-11236 > URL: https://issues.apache.org/jira/browse/OFBIZ-11236 > Project: OFBiz > Issue Type: New Feature > Components: product >Affects Versions: Trunk >Reporter: Gaudin Pierre >Assignee: Jacques Le Roux >Priority: Minor > Attachments: OFBIZ-11236_shipmentNotesV3.patch > > > Hello, > For many entities there are associated notes. However, there are no notes > associated with shipments. > The purpose of this patch is therefore to add notes to the shipments. > A new tab called "note" appears when displaying a shipment. From this tab it > is possible to add a note. From the shipment overview a section displays the > notes associated with the shipment. > For this new feature a "ShipmentNote" entity has been added. In the same way, > all the services allowing the management of notes have been associated. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11236) Add shipment notes
[
https://issues.apache.org/jira/browse/OFBIZ-11236?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17028438#comment-17028438
]
Jacques Le Roux commented on OFBIZ-11236:
-
Hi Pierre,
Thanks for your patch, I reviewed it, looks good to me. I loaded the entities,
tested, it seems to work for creating a note:
{noformat}
2020-02-02 14:26:51,116 |jsse-nio-8443-exec-3 |ServerHitBin
|I| Visit delegatorName=default, ServerHitBin delegatorName=default
2020-02-02 14:26:51,117 |jsse-nio-8443-exec-3 |ControlServlet
|T| [[[facility::ViewShipment (Domain:https://localhost)] Request Done-
total:2.203,since last([facility::ViewSh...):2.203]]
2020-02-02 14:27:11,276 |jsse-nio-8443-exec-4 |ControlServlet
|T| [[[facility::CreateShipmentNotes (Domain:https://localhost)] Request Begun,
encoding=[UTF-8]- total:0.0,since last(Begin):0.001]]
2020-02-02 14:27:11,347 |jsse-nio-8443-exec-4 |ConfigXMLReader
|I| controller loaded: 0.001s, 0 requests, 0 views in
file:/C:/projectsASF/Git/ofbiz-framework/framework/common/webcommon/WEB-INF/handlers-controller.xml
2020-02-02 14:27:11,347 |jsse-nio-8443-exec-4 |ConfigXMLReader
|I| controller loaded: 0.015s, 49 requests, 21 views in
file:/C:/projectsASF/Git/ofbiz-framework/framework/common/webcommon/WEB-INF/common-controller.xml
2020-02-02 14:27:11,364 |jsse-nio-8443-exec-4 |ConfigXMLReader
|I| controller loaded: 0.001s, 4 requests, 0 views in
file:/C:/projectsASF/Git/ofbiz-framework/applications/commonext/webapp/WEB-INF/controller.xml
2020-02-02 14:27:11,366 |jsse-nio-8443-exec-4 |ConfigXMLReader
|I| controller loaded: 0.054s, 243 requests, 94 views in
file:/C:/projectsASF/Git/ofbiz-framework/applications/product/webapp/facility/WEB-INF/controller.xml
2020-02-02 14:27:11,366 |jsse-nio-8443-exec-4 |ConfigXMLReader
|I| controller loaded: 0.073s, 6 requests, 7 views in
file:/C:/projectsASF/Git/ofbiz-framework/plugins/birt/webapp/facility/WEB-INF/controller.xml
2020-02-02 14:27:11,372 |jsse-nio-8443-exec-4 |RequestHandler
|I| Rendering View [CreateShipmentNotes]. Hidden sessionId by default.
2020-02-02 14:27:11,373 |jsse-nio-8443-exec-4 |ServiceDispatcher
|T| Sync service [facility/getUserPreferenceGroup] finished in [1] milliseconds
2020-02-02 14:27:11,384 |jsse-nio-8443-exec-4 |ScreenFactory
|I| Got 21 screens in 0.009s from:
file:/C:/projectsASF/Git/ofbiz-framework/applications/product/widget/facility/ShipmentScreens.xml
2020-02-02 14:27:11,390 |jsse-nio-8443-exec-4 |ScreenFactory
|I| Got 4 screens in 0.005s from:
file:/C:/projectsASF/Git/ofbiz-framework/applications/product/widget/facility/CommonScreens.xml
2020-02-02 14:27:11,396 |jsse-nio-8443-exec-4 |ScreenFactory
|I| Got 1 screens in 0.005s from:
file:/C:/projectsASF/Git/ofbiz-framework/applications/commonext/widget/CommonScreens.xml
2020-02-02 14:27:11,485 |jsse-nio-8443-exec-4 |ServiceDispatcher
|T| Sync service [facility/getLastSystemInfoNote] finished in [10] milliseconds
2020-02-02 14:27:11,498 |jsse-nio-8443-exec-4 |ScreenFactory
|I| Got 26 screens in 0.007s from:
file:/C:/projectsASF/Git/ofbiz-framework/framework/common/widget/CommonScreens.xml
2020-02-02 14:27:11,672 |jsse-nio-8443-exec-4 |ScreenFactory
|I| Got 25 screens in 0.006s from:
file:/C:/projectsASF/Git/ofbiz-framework/themes/common-theme/widget/CommonScreens.xml
2020-02-02 14:27:11,748 |jsse-nio-8443-exec-4 |ServerHitBin
|I| Visit delegatorName=default, ServerHitBin delegatorName=default
2020-02-02 14:27:11,749 |jsse-nio-8443-exec-4 |ControlServlet
|T| [[[facility::CreateShipmentNotes (Domain:https://localhost)] Request Done-
total:0.473,since last([facility::Create...):0.473]]
2020-02-02 14:27:30,865 |jsse-nio-8443-exec-5 |ControlServlet
|T| [[[facility::AddShipmentNotes (Domain:https://localhost)] Request Begun,
encoding=[UTF-8]- total:0.0,since last(Begin):0.0]]
2020-02-02 14:27:30,930 |jsse-nio-8443-exec-5 |ConfigXMLReader
|I| controller loaded: 0.0s, 0 requests, 0 views in
file:/C:/projectsASF/Git/ofbiz-framework/framework/common/webcommon/WEB-INF/handlers-controller.xml
2020-02-02 14:27:30,930 |jsse-nio-8443-exec-5 |ConfigXMLReader
|I| controller loaded: 0.014s, 49 requests, 21 views in
file:/C:/projectsASF/Git/ofbiz-framework/framework/common/webcommon/WEB-INF/common-controller.xml
2020-02-02 14:27:30,945 |jsse-nio-8443-exec-5 |ConfigXMLReader
|I| controller loaded: 0.0s, 4 requests, 0 views in
file:/C:/projectsASF/Git/ofbiz-framework/applications/commonext/webapp/WEB-INF/controller.xml
2020-02-02 14:27:30,947 |jsse-nio-8443-exec-5 |ConfigXMLReader
|I| controller loaded: 0.047s, 243 requests, 94 views in
[jira] [Commented] (OFBIZ-11236) Add shipment notes
[ https://issues.apache.org/jira/browse/OFBIZ-11236?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17028432#comment-17028432 ] Pierre Smits commented on OFBIZ-11236: -- Having a 'delete shipment note' function may not be right course to go. Many companies have strict policies regarding preserving the audit trail (for legal purposes). > Add shipment notes > -- > > Key: OFBIZ-11236 > URL: https://issues.apache.org/jira/browse/OFBIZ-11236 > Project: OFBiz > Issue Type: New Feature > Components: product >Affects Versions: Trunk >Reporter: Gaudin Pierre >Assignee: Jacques Le Roux >Priority: Minor > Attachments: OFBIZ-11236_shipmentNotesV3.patch > > > Hello, > For many entities there are associated notes. However, there are no notes > associated with shipments. > The purpose of this patch is therefore to add notes to the shipments. > A new tab called "note" appears when displaying a shipment. From this tab it > is possible to add a note. From the shipment overview a section displays the > notes associated with the shipment. > For this new feature a "ShipmentNote" entity has been added. In the same way, > all the services allowing the management of notes have been associated. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11236) Add shipment notes
[ https://issues.apache.org/jira/browse/OFBIZ-11236?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17020799#comment-17020799 ] Devanshu Vyas commented on OFBIZ-11236: --- I reviewed the patch and it looks good to me. Thanks [~gpierre]. > Add shipment notes > -- > > Key: OFBIZ-11236 > URL: https://issues.apache.org/jira/browse/OFBIZ-11236 > Project: OFBiz > Issue Type: New Feature > Components: product >Affects Versions: Trunk >Reporter: Gaudin Pierre >Assignee: Aditya Sharma >Priority: Minor > Attachments: OFBIZ-11236_shipmentNotesV3.patch > > > Hello, > For many entities there are associated notes. However, there are no notes > associated with shipments. > The purpose of this patch is therefore to add notes to the shipments. > A new tab called "note" appears when displaying a shipment. From this tab it > is possible to add a note. From the shipment overview a section displays the > notes associated with the shipment. > For this new feature a "ShipmentNote" entity has been added. In the same way, > all the services allowing the management of notes have been associated. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11236) Add shipment notes
[ https://issues.apache.org/jira/browse/OFBIZ-11236?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16945734#comment-16945734 ] Gaudin Pierre commented on OFBIZ-11236: --- Hello [~devanshu.vyas] Yes you right i will add the delete ShipmentNote entity-auto. Many thanks Pierre > Add shipment notes > -- > > Key: OFBIZ-11236 > URL: https://issues.apache.org/jira/browse/OFBIZ-11236 > Project: OFBiz > Issue Type: New Feature > Components: product >Affects Versions: Trunk >Reporter: Gaudin Pierre >Priority: Minor > Attachments: OFBIZ-11236_shipmentNotesV2.patch > > > Hello, > For many entities there are associated notes. However, there are no notes > associated with shipments. > The purpose of this patch is therefore to add notes to the shipments. > A new tab called "note" appears when displaying a shipment. From this tab it > is possible to add a note. From the shipment overview a section displays the > notes associated with the shipment. > For this new feature a "ShipmentNote" entity has been added. In the same way, > all the services allowing the management of notes have been associated. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11236) Add shipment notes
[ https://issues.apache.org/jira/browse/OFBIZ-11236?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16945716#comment-16945716 ] Devanshu Vyas commented on OFBIZ-11236: --- Hello [~gpierre], Thank you for the updated patch and it looks good. I have a small suggestion that there should be a support to either edit or delete a shipment note. This way user can update/delete a not so good note added on to the shipment(Like I did while testing :) ). > Add shipment notes > -- > > Key: OFBIZ-11236 > URL: https://issues.apache.org/jira/browse/OFBIZ-11236 > Project: OFBiz > Issue Type: New Feature > Components: product >Affects Versions: Trunk >Reporter: Gaudin Pierre >Priority: Minor > Attachments: OFBIZ-11236_shipmentNotesV2.patch > > > Hello, > For many entities there are associated notes. However, there are no notes > associated with shipments. > The purpose of this patch is therefore to add notes to the shipments. > A new tab called "note" appears when displaying a shipment. From this tab it > is possible to add a note. From the shipment overview a section displays the > notes associated with the shipment. > For this new feature a "ShipmentNote" entity has been added. In the same way, > all the services allowing the management of notes have been associated. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11236) Add shipment notes
[ https://issues.apache.org/jira/browse/OFBIZ-11236?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16945638#comment-16945638 ] Gaudin Pierre commented on OFBIZ-11236: --- I just recreated the patch. My apologies for the poor quality of the previous patch. > Add shipment notes > -- > > Key: OFBIZ-11236 > URL: https://issues.apache.org/jira/browse/OFBIZ-11236 > Project: OFBiz > Issue Type: New Feature > Components: product >Affects Versions: Trunk >Reporter: Gaudin Pierre >Priority: Minor > Attachments: OFBIZ-11236_shipmentNotesV2.patch > > > Hello, > For many entities there are associated notes. However, there are no notes > associated with shipments. > The purpose of this patch is therefore to add notes to the shipments. > A new tab called "note" appears when displaying a shipment. From this tab it > is possible to add a note. From the shipment overview a section displays the > notes associated with the shipment. > For this new feature a "ShipmentNote" entity has been added. In the same way, > all the services allowing the management of notes have been associated. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11236) Add shipment notes
[ https://issues.apache.org/jira/browse/OFBIZ-11236?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16945622#comment-16945622 ] Gaudin Pierre commented on OFBIZ-11236: --- Hi [~devanshu.vyas] Thank you for looking at my request. I'll check my patch and do it again. > Add shipment notes > -- > > Key: OFBIZ-11236 > URL: https://issues.apache.org/jira/browse/OFBIZ-11236 > Project: OFBiz > Issue Type: New Feature > Components: product >Affects Versions: Trunk >Reporter: Gaudin Pierre >Priority: Minor > Attachments: OFBIZ-11236_shipmentNotes.patch > > > Hello, > For many entities there are associated notes. However, there are no notes > associated with shipments. > The purpose of this patch is therefore to add notes to the shipments. > A new tab called "note" appears when displaying a shipment. From this tab it > is possible to add a note. From the shipment overview a section displays the > notes associated with the shipment. > For this new feature a "ShipmentNote" entity has been added. In the same way, > all the services allowing the management of notes have been associated. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11236) Add shipment notes
[
https://issues.apache.org/jira/browse/OFBIZ-11236?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16945598#comment-16945598
]
Devanshu Vyas commented on OFBIZ-11236:
---
Hi [~gpierre],
In the initial review of the patch, I noticed that there are a couple of
changes which seems to be from the older version of the files.
{code:java}
-
-
+
+
{code}
{code:java}
@@ -311,10 +309,9 @@
- Add shipment notes
> --
>
> Key: OFBIZ-11236
> URL: https://issues.apache.org/jira/browse/OFBIZ-11236
> Project: OFBiz
> Issue Type: New Feature
> Components: product
>Affects Versions: Trunk
>Reporter: Gaudin Pierre
>Priority: Minor
> Attachments: OFBIZ-11236_shipmentNotes.patch
>
>
> Hello,
> For many entities there are associated notes. However, there are no notes
> associated with shipments.
> The purpose of this patch is therefore to add notes to the shipments.
> A new tab called "note" appears when displaying a shipment. From this tab it
> is possible to add a note. From the shipment overview a section displays the
> notes associated with the shipment.
> For this new feature a "ShipmentNote" entity has been added. In the same way,
> all the services allowing the management of notes have been associated.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
