[jira] [Commented] (OFBIZ-11274) Cannot set property 'value' of null in lookup.js set_multivalues() function
[
https://issues.apache.org/jira/browse/OFBIZ-11274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17135682#comment-17135682
]
Aditya Sharma commented on OFBIZ-11274:
---
Thanks [~danwatford]! Closing the ticket
> Cannot set property 'value' of null in lookup.js set_multivalues() function
> ---
>
> Key: OFBIZ-11274
> URL: https://issues.apache.org/jira/browse/OFBIZ-11274
> Project: OFBiz
> Issue Type: Bug
> Components: themes
>Affects Versions: Trunk
>Reporter: Daniel Watford
>Assignee: Aditya Sharma
>Priority: Major
> Labels: pull-request-available
> Attachments: OFBIZ-11274-lookup-set-multi.patch
>
>
> Reference to the thread on dev list:
> [https://ofbiz.markmail.org/thread/3j7cndhig5oknknq]
> Attempts to call lookup.js function set_multivalues() from a lookup screen
> fail with the console logging error:
> {noformat}
> Uncaught TypeError: Cannot set property 'value' of null
> at set_multivalues (fieldlookup.js:769)
> at :1:1{noformat}
> No framework or plugins appear to currently use this function.
> The set_multivalues() function should be useful for populating multiple
> fields (e.g. a Postal Address) on a form from a lookup.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (OFBIZ-11274) Cannot set property 'value' of null in lookup.js set_multivalues() function
[
https://issues.apache.org/jira/browse/OFBIZ-11274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17129090#comment-17129090
]
Daniel Watford commented on OFBIZ-11274:
Hi [~adityasharma],
Per [#comment-16971213] I wasn't able to find a good use case for
set_multivalues and have switched to returning a single ID from Lookup Forms
which are then used to fetch additional information as needed.
I'd recommend closing this ticket if no appropriate use case is forthcoming.
> Cannot set property 'value' of null in lookup.js set_multivalues() function
> ---
>
> Key: OFBIZ-11274
> URL: https://issues.apache.org/jira/browse/OFBIZ-11274
> Project: OFBiz
> Issue Type: Bug
> Components: themes
>Affects Versions: Trunk
>Reporter: Daniel Watford
>Assignee: Aditya Sharma
>Priority: Major
> Labels: pull-request-available
> Attachments: OFBIZ-11274-lookup-set-multi.patch
>
>
> Reference to the thread on dev list:
> [https://ofbiz.markmail.org/thread/3j7cndhig5oknknq]
> Attempts to call lookup.js function set_multivalues() from a lookup screen
> fail with the console logging error:
> {noformat}
> Uncaught TypeError: Cannot set property 'value' of null
> at set_multivalues (fieldlookup.js:769)
> at :1:1{noformat}
> No framework or plugins appear to currently use this function.
> The set_multivalues() function should be useful for populating multiple
> fields (e.g. a Postal Address) on a form from a lookup.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (OFBIZ-11274) Cannot set property 'value' of null in lookup.js set_multivalues() function
[
https://issues.apache.org/jira/browse/OFBIZ-11274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17118573#comment-17118573
]
Aditya Sharma commented on OFBIZ-11274:
---
Hi [~danwatford],
Your patch seems promising but I still cannot think of any use case of setting
multiple values through a lookup. If possible, could you please add an example
in
[example|https://demo-stable.ofbiz.apache.org/example/control/FormWidgetExamples]
component that demonstrates its use case.
> Cannot set property 'value' of null in lookup.js set_multivalues() function
> ---
>
> Key: OFBIZ-11274
> URL: https://issues.apache.org/jira/browse/OFBIZ-11274
> Project: OFBiz
> Issue Type: Bug
> Components: themes
>Affects Versions: Trunk
>Reporter: Daniel Watford
>Assignee: Aditya Sharma
>Priority: Major
> Labels: pull-request-available
> Attachments: OFBIZ-11274-lookup-set-multi.patch
>
>
> Reference to the thread on dev list:
> [https://ofbiz.markmail.org/thread/3j7cndhig5oknknq]
> Attempts to call lookup.js function set_multivalues() from a lookup screen
> fail with the console logging error:
> {noformat}
> Uncaught TypeError: Cannot set property 'value' of null
> at set_multivalues (fieldlookup.js:769)
> at :1:1{noformat}
> No framework or plugins appear to currently use this function.
> The set_multivalues() function should be useful for populating multiple
> fields (e.g. a Postal Address) on a form from a lookup.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (OFBIZ-11274) Cannot set property 'value' of null in lookup.js set_multivalues() function
[
https://issues.apache.org/jira/browse/OFBIZ-11274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16971422#comment-16971422
]
Jacques Le Roux commented on OFBIZ-11274:
-
I had a look and even in
[R4|http://svn.apache.org/viewvc/ofbiz/branches/release4.0/] ie 2009,
set_multivalues was not used.
> Cannot set property 'value' of null in lookup.js set_multivalues() function
> ---
>
> Key: OFBIZ-11274
> URL: https://issues.apache.org/jira/browse/OFBIZ-11274
> Project: OFBiz
> Issue Type: Bug
> Components: themes
>Affects Versions: Trunk
>Reporter: Daniel Watford
>Priority: Major
> Labels: pull-request-available
> Attachments: OFBIZ-11274-lookup-set-multi.patch
>
>
> Reference to the thread on dev list:
> [https://ofbiz.markmail.org/thread/3j7cndhig5oknknq]
> Attempts to call lookup.js function set_multivalues() from a lookup screen
> fail with the console logging error:
> {noformat}
> Uncaught TypeError: Cannot set property 'value' of null
> at set_multivalues (fieldlookup.js:769)
> at :1:1{noformat}
> No framework or plugins appear to currently use this function.
> The set_multivalues() function should be useful for populating multiple
> fields (e.g. a Postal Address) on a form from a lookup.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (OFBIZ-11274) Cannot set property 'value' of null in lookup.js set_multivalues() function
[
https://issues.apache.org/jira/browse/OFBIZ-11274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16971311#comment-16971311
]
Aditya Sharma commented on OFBIZ-11274:
---
Give me some time, I will give it try.
> Cannot set property 'value' of null in lookup.js set_multivalues() function
> ---
>
> Key: OFBIZ-11274
> URL: https://issues.apache.org/jira/browse/OFBIZ-11274
> Project: OFBiz
> Issue Type: Bug
> Components: themes
>Affects Versions: Trunk
>Reporter: Daniel Watford
>Priority: Major
> Labels: pull-request-available
> Attachments: OFBIZ-11274-lookup-set-multi.patch
>
>
> Reference to the thread on dev list:
> [https://ofbiz.markmail.org/thread/3j7cndhig5oknknq]
> Attempts to call lookup.js function set_multivalues() from a lookup screen
> fail with the console logging error:
> {noformat}
> Uncaught TypeError: Cannot set property 'value' of null
> at set_multivalues (fieldlookup.js:769)
> at :1:1{noformat}
> No framework or plugins appear to currently use this function.
> The set_multivalues() function should be useful for populating multiple
> fields (e.g. a Postal Address) on a form from a lookup.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (OFBIZ-11274) Cannot set property 'value' of null in lookup.js set_multivalues() function
[
https://issues.apache.org/jira/browse/OFBIZ-11274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16971213#comment-16971213
]
Daniel Watford commented on OFBIZ-11274:
[~mthl] I've not been able to find a good candidate lookup that would benefit
from using set_multvalues. This might suggest it isn't really needed, or might
just be down to my lack of experience with the various ofbiz components.
Thinking on this further, perhaps having the lookup form specify the inputs to
be populated (as is the case with set_multivalues) would couple the lookup form
and calling page too tightly, and might be something to be discouraged.
Having lookup forms limited to calling set_value with with an ID value (and
possibly a description) might be enough. I can retrieve any other information
needed for display by hooking into the 'lookup:changed' jquery event fired when
a lookup field is updated.
I'm happy to close this ticket unless others have reason to explore
set_multivalues() further.
> Cannot set property 'value' of null in lookup.js set_multivalues() function
> ---
>
> Key: OFBIZ-11274
> URL: https://issues.apache.org/jira/browse/OFBIZ-11274
> Project: OFBiz
> Issue Type: Bug
> Components: themes
>Affects Versions: Trunk
>Reporter: Daniel Watford
>Priority: Major
> Labels: pull-request-available
> Attachments: OFBIZ-11274-lookup-set-multi.patch
>
>
> Attempts to call lookup.js function set_multivalues() from a lookup screen
> fail with the console logging error:
> {noformat}
> Uncaught TypeError: Cannot set property 'value' of null
> at set_multivalues (fieldlookup.js:769)
> at :1:1{noformat}
> No framework or plugins appear to currently use this function.
> The set_multivalues() function should be useful for populating multiple
> fields (e.g. a Postal Address) on a form from a lookup.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (OFBIZ-11274) Cannot set property 'value' of null in lookup.js set_multivalues() function
[
https://issues.apache.org/jira/browse/OFBIZ-11274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16968601#comment-16968601
]
Jacques Le Roux commented on OFBIZ-11274:
-
The 2 versions are similar but different. The version in webapp is more
general. 4 years ago, I commented the version now in theme :
/*
* If we decide to keep it (only used in Example, though it's needed also
* for Themes and Languages but not the same way)
*/
It seems things have changed since ant it's indeed no longer used, not even in
R16... That does not mean that's it's useless...
> Cannot set property 'value' of null in lookup.js set_multivalues() function
> ---
>
> Key: OFBIZ-11274
> URL: https://issues.apache.org/jira/browse/OFBIZ-11274
> Project: OFBiz
> Issue Type: Bug
> Components: themes
>Affects Versions: Trunk
>Reporter: Daniel Watford
>Priority: Major
> Labels: pull-request-available
> Attachments: OFBIZ-11274-lookup-set-multi.patch
>
>
> Attempts to call lookup.js function set_multivalues() from a lookup screen
> fail with the console logging error:
> {noformat}
> Uncaught TypeError: Cannot set property 'value' of null
> at set_multivalues (fieldlookup.js:769)
> at :1:1{noformat}
> No framework or plugins appear to currently use this function.
> The set_multivalues() function should be useful for populating multiple
> fields (e.g. a Postal Address) on a form from a lookup.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (OFBIZ-11274) Cannot set property 'value' of null in lookup.js set_multivalues() function
[
https://issues.apache.org/jira/browse/OFBIZ-11274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16968566#comment-16968566
]
Mathieu Lirzin commented on OFBIZ-11274:
Additonally I have noticed that
{{./themes/common-theme/template/includes/Lookup.ftl}} contains a copy of the
{{set_multivalues()}} method. What should we do about it?
> Cannot set property 'value' of null in lookup.js set_multivalues() function
> ---
>
> Key: OFBIZ-11274
> URL: https://issues.apache.org/jira/browse/OFBIZ-11274
> Project: OFBiz
> Issue Type: Bug
> Components: themes
>Affects Versions: Trunk
>Reporter: Daniel Watford
>Priority: Major
> Labels: pull-request-available
> Attachments: OFBIZ-11274-lookup-set-multi.patch
>
>
> Attempts to call lookup.js function set_multivalues() from a lookup screen
> fail with the console logging error:
> {noformat}
> Uncaught TypeError: Cannot set property 'value' of null
> at set_multivalues (fieldlookup.js:769)
> at :1:1{noformat}
> No framework or plugins appear to currently use this function.
> The set_multivalues() function should be useful for populating multiple
> fields (e.g. a Postal Address) on a form from a lookup.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (OFBIZ-11274) Cannot set property 'value' of null in lookup.js set_multivalues() function
[
https://issues.apache.org/jira/browse/OFBIZ-11274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16968563#comment-16968563
]
Mathieu Lirzin commented on OFBIZ-11274:
Hello Daniel,
The fact that this not used anywhere in the framework or plugins makes me think
that maybe we don't need it. In order to demonstrate the value of this code it
would be nice if you could make the framework use it in some appropriate place.
This would help reviewing the code too. Are you willing to do that? :-)
Thanks
> Cannot set property 'value' of null in lookup.js set_multivalues() function
> ---
>
> Key: OFBIZ-11274
> URL: https://issues.apache.org/jira/browse/OFBIZ-11274
> Project: OFBiz
> Issue Type: Bug
> Components: themes
>Affects Versions: Trunk
>Reporter: Daniel Watford
>Priority: Major
> Labels: pull-request-available
> Attachments: OFBIZ-11274-lookup-set-multi.patch
>
>
> Attempts to call lookup.js function set_multivalues() from a lookup screen
> fail with the console logging error:
> {noformat}
> Uncaught TypeError: Cannot set property 'value' of null
> at set_multivalues (fieldlookup.js:769)
> at :1:1{noformat}
> No framework or plugins appear to currently use this function.
> The set_multivalues() function should be useful for populating multiple
> fields (e.g. a Postal Address) on a form from a lookup.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
