[jira] [Commented] (OFBIZ-11340) Crashed Scheduled jobs are not getting rescheduled with temporal expression

2020-02-06 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17031717#comment-17031717
 ] 

ASF subversion and git services commented on OFBIZ-11340:
-

Commit 47e689b360f370bba4f512c314879711aee3d96d in ofbiz-framework's branch 
refs/heads/trunk from Nicolas Malin
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=47e689b ]

Fixed: Crashed Scheduled jobs are not getting rescheduled with temporal 
expression
(OFBIZ-11340)

When a OFBiz server are stopped or crashed with job on queued state,
at the start, they are restarted but without information on tempExprId and 
recurrenceInfoId

This causes a break for recurrence jobs to their planning

Thanks to Mohammed Rehan Khan for this issue and Scott Gray for the review.


> Crashed Scheduled jobs are not getting rescheduled with temporal expression
> ---
>
> Key: OFBIZ-11340
> URL: https://issues.apache.org/jira/browse/OFBIZ-11340
> Project: OFBiz
>  Issue Type: Bug
>  Components: framework
>Affects Versions: Trunk
>Reporter: Mohammed Rehan Khan
>Assignee: Nicolas Malin
>Priority: Major
> Attachments: OFBIZ-11340.patch, OFBIZ-11340.patch, OFBiz_ 
> JobSandbox_1.png, OFBiz_ JobSandbox_2.png
>
>
> *Scenario:*
>  # Import Schedule service data with temporal expression id.
>  # JobManager creates a child Job with temExprId in _pending_ status when the 
> imported Job is in _running_ status.
>  # Now the parent Job is in _running_ status and the child Job, which is in 
> _pending_ status, transitions to _queued_ status if Job Poll size is full. In 
> this scenario, if we restart the server then both Jobs are Crashed and 
> JobManager creates child Job without tempExprdId. 
>  
>  *Example:* Please refer to the attached screenshots.
>  # Job 32993100 is imported with TempExprId
>  # When Job 32993100 is in running status, then Job 32993101 is created with 
> TempExprId in pending status but job 32993101 is moved to Queued status if 
> job poll size is full.
>  # If we restart the server then JobPoller runs reloadCrashedJobs() and both 
> jobs are crashed and JobManager creates two child jobs (32993200, 32993201) 
> without TempExprId.
> So in this case of missing temporal expression id job manager will not be 
> able to schedule further jobs.
>   
>  *Expected:* If Queued Job (32993101) is crashed then its corresponding Job 
> (32993200) should have TempExprId to continue further scheduling. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11340) Crashed Scheduled jobs are not getting rescheduled with temporal expression

2020-02-06 Thread Nicolas Malin (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17031715#comment-17031715
 ] 

Nicolas Malin commented on OFBIZ-11340:
---

Thanks [~rehan.khan] for the quality of this issue and [~lektran]  for the 
review. I also detected this error on production site with huge jobs, where I 
didn't understand why I losted some jobs after a server crash without take the 
time to found the root cause.

> Crashed Scheduled jobs are not getting rescheduled with temporal expression
> ---
>
> Key: OFBIZ-11340
> URL: https://issues.apache.org/jira/browse/OFBIZ-11340
> Project: OFBiz
>  Issue Type: Bug
>  Components: framework
>Affects Versions: Trunk
>Reporter: Mohammed Rehan Khan
>Assignee: Nicolas Malin
>Priority: Major
> Attachments: OFBIZ-11340.patch, OFBIZ-11340.patch, OFBiz_ 
> JobSandbox_1.png, OFBiz_ JobSandbox_2.png
>
>
> *Scenario:*
>  # Import Schedule service data with temporal expression id.
>  # JobManager creates a child Job with temExprId in _pending_ status when the 
> imported Job is in _running_ status.
>  # Now the parent Job is in _running_ status and the child Job, which is in 
> _pending_ status, transitions to _queued_ status if Job Poll size is full. In 
> this scenario, if we restart the server then both Jobs are Crashed and 
> JobManager creates child Job without tempExprdId. 
>  
>  *Example:* Please refer to the attached screenshots.
>  # Job 32993100 is imported with TempExprId
>  # When Job 32993100 is in running status, then Job 32993101 is created with 
> TempExprId in pending status but job 32993101 is moved to Queued status if 
> job poll size is full.
>  # If we restart the server then JobPoller runs reloadCrashedJobs() and both 
> jobs are crashed and JobManager creates two child jobs (32993200, 32993201) 
> without TempExprId.
> So in this case of missing temporal expression id job manager will not be 
> able to schedule further jobs.
>   
>  *Expected:* If Queued Job (32993101) is crashed then its corresponding Job 
> (32993200) should have TempExprId to continue further scheduling. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11340) Crashed Scheduled jobs are not getting rescheduled with temporal expression

2020-02-06 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17031714#comment-17031714
 ] 

ASF subversion and git services commented on OFBIZ-11340:
-

Commit d0e2ebbb9889f64be47709ee22101a6c9fe02bc5 in ofbiz-framework's branch 
refs/heads/release18.12 from Nicolas Malin
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=d0e2ebb ]

Fixed: Crashed Scheduled jobs are not getting rescheduled with temporal 
expression
(OFBIZ-11340)

When a OFBiz server are stopped or crashed with job on queued state,
at the start, they are restarted but without information on tempExprId and 
recurrenceInfoId

This causes a break for recurrence jobs to their planning

Thanks to Mohammed Rehan Khan for this issue and Scott Gray for the review.


> Crashed Scheduled jobs are not getting rescheduled with temporal expression
> ---
>
> Key: OFBIZ-11340
> URL: https://issues.apache.org/jira/browse/OFBIZ-11340
> Project: OFBiz
>  Issue Type: Bug
>  Components: framework
>Affects Versions: Trunk
>Reporter: Mohammed Rehan Khan
>Assignee: Nicolas Malin
>Priority: Major
> Attachments: OFBIZ-11340.patch, OFBIZ-11340.patch, OFBiz_ 
> JobSandbox_1.png, OFBiz_ JobSandbox_2.png
>
>
> *Scenario:*
>  # Import Schedule service data with temporal expression id.
>  # JobManager creates a child Job with temExprId in _pending_ status when the 
> imported Job is in _running_ status.
>  # Now the parent Job is in _running_ status and the child Job, which is in 
> _pending_ status, transitions to _queued_ status if Job Poll size is full. In 
> this scenario, if we restart the server then both Jobs are Crashed and 
> JobManager creates child Job without tempExprdId. 
>  
>  *Example:* Please refer to the attached screenshots.
>  # Job 32993100 is imported with TempExprId
>  # When Job 32993100 is in running status, then Job 32993101 is created with 
> TempExprId in pending status but job 32993101 is moved to Queued status if 
> job poll size is full.
>  # If we restart the server then JobPoller runs reloadCrashedJobs() and both 
> jobs are crashed and JobManager creates two child jobs (32993200, 32993201) 
> without TempExprId.
> So in this case of missing temporal expression id job manager will not be 
> able to schedule further jobs.
>   
>  *Expected:* If Queued Job (32993101) is crashed then its corresponding Job 
> (32993200) should have TempExprId to continue further scheduling. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11340) Crashed Scheduled jobs are not getting rescheduled with temporal expression

2020-02-06 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17031716#comment-17031716
 ] 

ASF subversion and git services commented on OFBIZ-11340:
-

Commit 7c8fc080f30085b75d4b1ea783fc5b537124508e in ofbiz-framework's branch 
refs/heads/release17.12 from Nicolas Malin
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=7c8fc08 ]

Fixed: Crashed Scheduled jobs are not getting rescheduled with temporal 
expression
(OFBIZ-11340)

When a OFBiz server are stopped or crashed with job on queued state,
at the start, they are restarted but without information on tempExprId and 
recurrenceInfoId

This causes a break for recurrence jobs to their planning

Thanks to Mohammed Rehan Khan for this issue and Scott Gray for the review.


> Crashed Scheduled jobs are not getting rescheduled with temporal expression
> ---
>
> Key: OFBIZ-11340
> URL: https://issues.apache.org/jira/browse/OFBIZ-11340
> Project: OFBiz
>  Issue Type: Bug
>  Components: framework
>Affects Versions: Trunk
>Reporter: Mohammed Rehan Khan
>Assignee: Nicolas Malin
>Priority: Major
> Attachments: OFBIZ-11340.patch, OFBIZ-11340.patch, OFBiz_ 
> JobSandbox_1.png, OFBiz_ JobSandbox_2.png
>
>
> *Scenario:*
>  # Import Schedule service data with temporal expression id.
>  # JobManager creates a child Job with temExprId in _pending_ status when the 
> imported Job is in _running_ status.
>  # Now the parent Job is in _running_ status and the child Job, which is in 
> _pending_ status, transitions to _queued_ status if Job Poll size is full. In 
> this scenario, if we restart the server then both Jobs are Crashed and 
> JobManager creates child Job without tempExprdId. 
>  
>  *Example:* Please refer to the attached screenshots.
>  # Job 32993100 is imported with TempExprId
>  # When Job 32993100 is in running status, then Job 32993101 is created with 
> TempExprId in pending status but job 32993101 is moved to Queued status if 
> job poll size is full.
>  # If we restart the server then JobPoller runs reloadCrashedJobs() and both 
> jobs are crashed and JobManager creates two child jobs (32993200, 32993201) 
> without TempExprId.
> So in this case of missing temporal expression id job manager will not be 
> able to schedule further jobs.
>   
>  *Expected:* If Queued Job (32993101) is crashed then its corresponding Job 
> (32993200) should have TempExprId to continue further scheduling. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11340) Crashed Scheduled jobs are not getting rescheduled with temporal expression

2020-02-05 Thread Mohammed Rehan Khan (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17031313#comment-17031313
 ] 

Mohammed Rehan Khan commented on OFBIZ-11340:
-

Thank you so much [~lektran]. I have updated the patch with the suggested 
changes.

 

> Crashed Scheduled jobs are not getting rescheduled with temporal expression
> ---
>
> Key: OFBIZ-11340
> URL: https://issues.apache.org/jira/browse/OFBIZ-11340
> Project: OFBiz
>  Issue Type: Bug
>  Components: framework
>Affects Versions: Trunk
>Reporter: Mohammed Rehan Khan
>Assignee: Nicolas Malin
>Priority: Major
> Attachments: OFBIZ-11340.patch, OFBIZ-11340.patch, OFBiz_ 
> JobSandbox_1.png, OFBiz_ JobSandbox_2.png
>
>
> *Scenario:*
>  # Import Schedule service data with temporal expression id.
>  # JobManager creates a child Job with temExprId in _pending_ status when the 
> imported Job is in _running_ status.
>  # Now the parent Job is in _running_ status and the child Job, which is in 
> _pending_ status, transitions to _queued_ status if Job Poll size is full. In 
> this scenario, if we restart the server then both Jobs are Crashed and 
> JobManager creates child Job without tempExprdId. 
>  
>  *Example:* Please refer to the attached screenshots.
>  # Job 32993100 is imported with TempExprId
>  # When Job 32993100 is in running status, then Job 32993101 is created with 
> TempExprId in pending status but job 32993101 is moved to Queued status if 
> job poll size is full.
>  # If we restart the server then JobPoller runs reloadCrashedJobs() and both 
> jobs are crashed and JobManager creates two child jobs (32993200, 32993201) 
> without TempExprId.
> So in this case of missing temporal expression id job manager will not be 
> able to schedule further jobs.
>   
>  *Expected:* If Queued Job (32993101) is crashed then its corresponding Job 
> (32993200) should have TempExprId to continue further scheduling. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11340) Crashed Scheduled jobs are not getting rescheduled with temporal expression

2020-02-05 Thread Scott Gray (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17031146#comment-17031146
 ] 

Scott Gray commented on OFBIZ-11340:


Looks good to me [~rehan.khan], my only thought though is that whatever we do 
to `tempExprId`, we should also do to `recurrenceInfoId` since either field can 
be used to schedule a recurring job.  I imagine the same problem exists with 
that field

cc [~jacopoc]

> Crashed Scheduled jobs are not getting rescheduled with temporal expression
> ---
>
> Key: OFBIZ-11340
> URL: https://issues.apache.org/jira/browse/OFBIZ-11340
> Project: OFBiz
>  Issue Type: Bug
>  Components: framework
>Affects Versions: Trunk
>Reporter: Mohammed Rehan Khan
>Assignee: Nicolas Malin
>Priority: Major
> Attachments: OFBIZ-11340.patch, OFBiz_ JobSandbox_1.png, OFBiz_ 
> JobSandbox_2.png
>
>
> *Scenario:*
>  # Import Schedule service data with temporal expression id.
>  # JobManager creates a child Job with temExprId in _pending_ status when the 
> imported Job is in _running_ status.
>  # Now the parent Job is in _running_ status and the child Job, which is in 
> _pending_ status, transitions to _queued_ status if Job Poll size is full. In 
> this scenario, if we restart the server then both Jobs are Crashed and 
> JobManager creates child Job without tempExprdId. 
>  
>  *Example:* Please refer to the attached screenshots.
>  # Job 32993100 is imported with TempExprId
>  # When Job 32993100 is in running status, then Job 32993101 is created with 
> TempExprId in pending status but job 32993101 is moved to Queued status if 
> job poll size is full.
>  # If we restart the server then JobPoller runs reloadCrashedJobs() and both 
> jobs are crashed and JobManager creates two child jobs (32993200, 32993201) 
> without TempExprId.
> So in this case of missing temporal expression id job manager will not be 
> able to schedule further jobs.
>   
>  *Expected:* If Queued Job (32993101) is crashed then its corresponding Job 
> (32993200) should have TempExprId to continue further scheduling. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11340) Crashed Scheduled jobs are not getting rescheduled with temporal expression

2020-02-04 Thread Mohammed Rehan Khan (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17029853#comment-17029853
 ] 

Mohammed Rehan Khan commented on OFBIZ-11340:
-

Here is the patch for this issue.

> Crashed Scheduled jobs are not getting rescheduled with temporal expression
> ---
>
> Key: OFBIZ-11340
> URL: https://issues.apache.org/jira/browse/OFBIZ-11340
> Project: OFBiz
>  Issue Type: Bug
>  Components: framework
>Affects Versions: Trunk
>Reporter: Mohammed Rehan Khan
>Assignee: Mohammed Rehan Khan
>Priority: Major
> Attachments: OFBIZ-11340.patch, OFBiz_ JobSandbox_1.png, OFBiz_ 
> JobSandbox_2.png
>
>
> *Scenario:*
>  # Import Schedule service data with temporal expression id.
>  # JobManager creates a child Job with temExprId in _pending_ status when the 
> imported Job is in _running_ status.
>  # Now the parent Job is in _running_ status and the child Job, which is in 
> _pending_ status, transitions to _queued_ status if Job Poll size is full. In 
> this scenario, if we restart the server then both Jobs are Crashed and 
> JobManager creates child Job without tempExprdId. 
>  
>  *Example:* Please refer to the attached screenshots.
>  # Job 32993100 is imported with TempExprId
>  # When Job 32993100 is in running status, then Job 32993101 is created with 
> TempExprId in pending status but job 32993101 is moved to Queued status if 
> job poll size is full.
>  # If we restart the server then JobPoller runs reloadCrashedJobs() and both 
> jobs are crashed and JobManager creates two child jobs (32993200, 32993201) 
> without TempExprId.
> So in this case of missing temporal expression id job manager will not be 
> able to schedule further jobs.
>   
>  *Expected:* If Queued Job (32993101) is crashed then its corresponding Job 
> (32993200) should have TempExprId to continue further scheduling. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)