[jira] [Commented] (OFBIZ-11705) Rainbow theme: use the United Nations flag ad default flag

2020-05-31 Thread Jacques Le Roux (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11705?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17120480#comment-17120480
 ] 

Jacques Le Roux commented on OFBIZ-11705:
-

Thanks Pierre,

I closed the PR#154

> Rainbow theme: use the United Nations flag ad default flag
> --
>
> Key: OFBIZ-11705
> URL: https://issues.apache.org/jira/browse/OFBIZ-11705
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: themes
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Minor
>  Labels: usability
> Attachments: Screen Shot 2020-05-21 at 10.42.38.png, Screen Shot 
> 2020-05-21 at 10.43.09.png
>
>
> This follows OFBIZ-9866: we could use the [United Nations 
> flag|https://en.wikipedia.org/wiki/United_Nations#/media/File:Flag_of_the_United_Nations.svg]
>  as default flag



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11705) Rainbow theme: use the United Nations flag ad default flag

2020-05-31 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11705?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17120479#comment-17120479
 ] 

ASF subversion and git services commented on OFBIZ-11705:
-

Commit 51d91619ea582920e003849c5542f0d52b5c2b44 in ofbiz-framework's branch 
refs/heads/trunk from Jacques Le Roux
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=51d9161 ]

Improved: Rainbow theme: use the United Nations flag ad default flag 
(OFBIZ-11705)

Oops, I missed to add the un flag files


> Rainbow theme: use the United Nations flag ad default flag
> --
>
> Key: OFBIZ-11705
> URL: https://issues.apache.org/jira/browse/OFBIZ-11705
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: themes
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Minor
>  Labels: usability
> Attachments: Screen Shot 2020-05-21 at 10.42.38.png, Screen Shot 
> 2020-05-21 at 10.43.09.png
>
>
> This follows OFBIZ-9866: we could use the [United Nations 
> flag|https://en.wikipedia.org/wiki/United_Nations#/media/File:Flag_of_the_United_Nations.svg]
>  as default flag



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11705) Rainbow theme: use the United Nations flag ad default flag

2020-05-31 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11705?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17120477#comment-17120477
 ] 

ASF subversion and git services commented on OFBIZ-11705:
-

Commit 6c6f1e1135cba6a35ac4c5eb37bcc3db743c3817 in ofbiz-framework's branch 
refs/heads/trunk from Jacques Le Roux
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=6c6f1e1 ]

Improved: Rainbow theme: use the United Nations flag ad default flag 
(OFBIZ-11705)

This follows OFBIZ-9866: where I proposed to use the United Nations flag
as default flag

Pierre noticed that no flag shows when a meta language (like en) is chosen.

I noticed that some meta language have default values (gb, fr, zh, th). So I did
not apply Pierre's GH PR#154 to keep those, because that can be increased.

I added the un.svg flag from https://en.wikipedia.org/wiki/United_Nations
I did not adapt its size. Since it's SVG it should be OK in most cases
I also added the necessary change at the end of in flag-icon.min.css

Thanks: Pierre Smits for the initial patch


> Rainbow theme: use the United Nations flag ad default flag
> --
>
> Key: OFBIZ-11705
> URL: https://issues.apache.org/jira/browse/OFBIZ-11705
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: themes
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Minor
>  Labels: usability
> Attachments: Screen Shot 2020-05-21 at 10.42.38.png, Screen Shot 
> 2020-05-21 at 10.43.09.png
>
>
> This follows OFBIZ-9866: we could use the [United Nations 
> flag|https://en.wikipedia.org/wiki/United_Nations#/media/File:Flag_of_the_United_Nations.svg]
>  as default flag



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11705) Rainbow theme: use the United Nations flag ad default flag

2020-05-21 Thread Pierre Smits (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11705?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17112973#comment-17112973
 ] 

Pierre Smits commented on OFBIZ-11705:
--

The flag doesn't show when a meta language is chosen in the profile drop down. 

When I choose 'Nederlands [nl] the flag doesn't show, but when I choose 
'Nderlands (Nederland) - [nl-nl]' the flag is shown.

See attached screenshots

I suggest that for each meta language the United Nations flag is shown.

> Rainbow theme: use the United Nations flag ad default flag
> --
>
> Key: OFBIZ-11705
> URL: https://issues.apache.org/jira/browse/OFBIZ-11705
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: themes
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Priority: Minor
> Attachments: Screen Shot 2020-05-21 at 10.42.38.png, Screen Shot 
> 2020-05-21 at 10.43.09.png
>
>
> This follows OFBIZ-9866: we could use the [United Nations 
> flag|https://en.wikipedia.org/wiki/United_Nations#/media/File:Flag_of_the_United_Nations.svg]
>  as default flag



--
This message was sent by Atlassian Jira
(v8.3.4#803005)