[jira] [Commented] (OFBIZ-11805) Checkstyle formatting issues
[ https://issues.apache.org/jira/browse/OFBIZ-11805?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17154225#comment-17154225 ] ASF subversion and git services commented on OFBIZ-11805: - Commit 3bb22302c7a521ed179134cb5f9c359d0b13c64e in ofbiz-framework's branch refs/heads/trunk from Suraj Khurana [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=3bb2230 ] Improved: Corrected all checkstyle issues related to succeeding space for comma in framework directory. (OFBIZ-11805) Thanks Jacques and Ritesh Kumar for review. > Checkstyle formatting issues > > > Key: OFBIZ-11805 > URL: https://issues.apache.org/jira/browse/OFBIZ-11805 > Project: OFBiz > Issue Type: Sub-task > Components: ALL COMPONENTS >Affects Versions: Trunk >Reporter: Suraj Khurana >Assignee: Suraj Khurana >Priority: Major > Attachments: OFBIZ-11805-2.patch, OFBIZ-11805-plugins-2.patch, > OFBIZ-11805-plugins.patch, OFBIZ-11805.patch > > > As per discussion over dev ML, [https://markmail.org/message/cyagukb7emaxrhbj] > It is better to create component level patches for this enhancement. > In this ticket we have covered majorly succeeding space for comma -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11805) Checkstyle formatting issues
[ https://issues.apache.org/jira/browse/OFBIZ-11805?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17154221#comment-17154221 ] ASF subversion and git services commented on OFBIZ-11805: - Commit 6f264947c72da74fcc068849be2c34e49b3ce58e in ofbiz-plugins's branch refs/heads/trunk from Suraj Khurana [ https://gitbox.apache.org/repos/asf?p=ofbiz-plugins.git;h=6f26494 ] Improved: Corrected all checkstyle issues related to succeeding space for comma in plugins directory. (OFBIZ-11805) Thanks Jacques and Ritesh Kumar for review. > Checkstyle formatting issues > > > Key: OFBIZ-11805 > URL: https://issues.apache.org/jira/browse/OFBIZ-11805 > Project: OFBiz > Issue Type: Sub-task > Components: ALL COMPONENTS >Affects Versions: Trunk >Reporter: Suraj Khurana >Assignee: Suraj Khurana >Priority: Major > Attachments: OFBIZ-11805-2.patch, OFBIZ-11805-plugins-2.patch, > OFBIZ-11805-plugins.patch, OFBIZ-11805.patch > > > As per discussion over dev ML, [https://markmail.org/message/cyagukb7emaxrhbj] > It is better to create component level patches for this enhancement. > In this ticket we have covered majorly succeeding space for comma -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11805) Checkstyle formatting issues
[ https://issues.apache.org/jira/browse/OFBIZ-11805?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17154218#comment-17154218 ] ASF subversion and git services commented on OFBIZ-11805: - Commit 82ce4304ae99b5e320a76ee3ef9dbb14feb0acff in ofbiz-framework's branch refs/heads/trunk from Suraj Khurana [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=82ce430 ] Improved: Corrected all checkstyle issues related to succeeding space for comma in applications directory. (OFBIZ-11805) Thanks Jacques and Ritesh Kumar for review. > Checkstyle formatting issues > > > Key: OFBIZ-11805 > URL: https://issues.apache.org/jira/browse/OFBIZ-11805 > Project: OFBiz > Issue Type: Sub-task > Components: ALL COMPONENTS >Affects Versions: Trunk >Reporter: Suraj Khurana >Assignee: Suraj Khurana >Priority: Major > Attachments: OFBIZ-11805-2.patch, OFBIZ-11805-plugins-2.patch, > OFBIZ-11805-plugins.patch, OFBIZ-11805.patch > > > As per discussion over dev ML, [https://markmail.org/message/cyagukb7emaxrhbj] > It is better to create component level patches for this enhancement. > In this ticket we have covered majorly succeeding space for comma -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11805) Checkstyle formatting issues
[ https://issues.apache.org/jira/browse/OFBIZ-11805?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17152734#comment-17152734 ] Ritesh Kumar commented on OFBIZ-11805: -- Tested patches OFBIZ-11805-2.patch and OFBIZ-11805-plugins-2.patch, they are working fine. > Checkstyle formatting issues > > > Key: OFBIZ-11805 > URL: https://issues.apache.org/jira/browse/OFBIZ-11805 > Project: OFBiz > Issue Type: Sub-task > Components: ALL COMPONENTS >Affects Versions: Trunk >Reporter: Suraj Khurana >Assignee: Suraj Khurana >Priority: Major > Attachments: OFBIZ-11805-2.patch, OFBIZ-11805-plugins-2.patch, > OFBIZ-11805-plugins.patch, OFBIZ-11805.patch > > > As per discussion over dev ML, [https://markmail.org/message/cyagukb7emaxrhbj] > It is better to create component level patches for this enhancement. > In this ticket we have covered majorly succeeding space for comma -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11805) Checkstyle formatting issues
[
https://issues.apache.org/jira/browse/OFBIZ-11805?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17152675#comment-17152675
]
ASF subversion and git services commented on OFBIZ-11805:
-
Commit c5f9697e35e676cf5afa6e14dc3f420030961924 in ofbiz-framework's branch
refs/heads/trunk from Suraj Khurana
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=c5f9697 ]
Improved: Removed unused SuppressWarnings and added proper space after comma
and before { in LoginServices.java.
(OFBIZ-11805)
Thanks: Pawan Verma
Also updated tasks.checkstyleMain.maxErrors (-5).
> Checkstyle formatting issues
>
>
> Key: OFBIZ-11805
> URL: https://issues.apache.org/jira/browse/OFBIZ-11805
> Project: OFBiz
> Issue Type: Sub-task
> Components: ALL COMPONENTS
>Affects Versions: Trunk
>Reporter: Suraj Khurana
>Assignee: Suraj Khurana
>Priority: Major
> Attachments: OFBIZ-11805-2.patch, OFBIZ-11805-plugins-2.patch,
> OFBIZ-11805-plugins.patch, OFBIZ-11805.patch
>
>
> As per discussion over dev ML, [https://markmail.org/message/cyagukb7emaxrhbj]
> It is better to create component level patches for this enhancement.
> In this ticket we have covered majorly succeeding space for comma
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (OFBIZ-11805) Checkstyle formatting issues
[ https://issues.apache.org/jira/browse/OFBIZ-11805?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17152667#comment-17152667 ] Jacques Le Roux commented on OFBIZ-11805: - Thanks Suraj, Same than last time: +1 > Checkstyle formatting issues > > > Key: OFBIZ-11805 > URL: https://issues.apache.org/jira/browse/OFBIZ-11805 > Project: OFBiz > Issue Type: Sub-task > Components: ALL COMPONENTS >Affects Versions: Trunk >Reporter: Suraj Khurana >Assignee: Suraj Khurana >Priority: Major > Attachments: OFBIZ-11805-2.patch, OFBIZ-11805-plugins-2.patch, > OFBIZ-11805-plugins.patch, OFBIZ-11805.patch > > > As per discussion over dev ML, [https://markmail.org/message/cyagukb7emaxrhbj] > It is better to create component level patches for this enhancement. > In this ticket we have covered majorly succeeding space for comma -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11805) Checkstyle formatting issues
[ https://issues.apache.org/jira/browse/OFBIZ-11805?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17152639#comment-17152639 ] Suraj Khurana commented on OFBIZ-11805: --- Hello Jacques and Ritesh, Thanks for reviewing the earlier patches. I have attached 2 more patches which are covering same enhancements. Hopefully these will complete this ticket. I am planning to create separate tickets for other type of checkstyle issue correction. TIA. > Checkstyle formatting issues > > > Key: OFBIZ-11805 > URL: https://issues.apache.org/jira/browse/OFBIZ-11805 > Project: OFBiz > Issue Type: Sub-task > Components: ALL COMPONENTS >Affects Versions: Trunk >Reporter: Suraj Khurana >Assignee: Suraj Khurana >Priority: Major > Attachments: OFBIZ-11805-2.patch, OFBIZ-11805-plugins-2.patch, > OFBIZ-11805-plugins.patch, OFBIZ-11805.patch > > > As per discussion over dev ML, [https://markmail.org/message/cyagukb7emaxrhbj] > It is better to create component level patches for this enhancement. > In this ticket we have covered majorly succeeding space for comma -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11805) Checkstyle formatting issues
[ https://issues.apache.org/jira/browse/OFBIZ-11805?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17152608#comment-17152608 ] ASF subversion and git services commented on OFBIZ-11805: - Commit 749d4d6d94a4dcff9d80a7089e35d9cbbca9e7bd in ofbiz-framework's branch refs/heads/trunk from Suraj Khurana [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=749d4d6 ] Improved: Corrected remaining ', is not followed by whitespace' checkstyle errors in framework component. (OFBIZ-11805) > Checkstyle formatting issues > > > Key: OFBIZ-11805 > URL: https://issues.apache.org/jira/browse/OFBIZ-11805 > Project: OFBiz > Issue Type: Sub-task > Components: ALL COMPONENTS >Affects Versions: Trunk >Reporter: Suraj Khurana >Assignee: Suraj Khurana >Priority: Major > Attachments: OFBIZ-11805-plugins.patch, OFBIZ-11805.patch > > > As per discussion over dev ML, [https://markmail.org/message/cyagukb7emaxrhbj] > It is better to create component level patches for this enhancement. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11805) Checkstyle formatting issues
[ https://issues.apache.org/jira/browse/OFBIZ-11805?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17152604#comment-17152604 ] ASF subversion and git services commented on OFBIZ-11805: - Commit fc6b8a6ca301c074dedffd45543e68aeb437065a in ofbiz-framework's branch refs/heads/trunk from Suraj Khurana [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=fc6b8a6 ] Improved: Corrected remaining ', is not followed by whitespace' checkstyle errors in framework component. (OFBIZ-11805) > Checkstyle formatting issues > > > Key: OFBIZ-11805 > URL: https://issues.apache.org/jira/browse/OFBIZ-11805 > Project: OFBiz > Issue Type: Sub-task > Components: ALL COMPONENTS >Affects Versions: Trunk >Reporter: Suraj Khurana >Assignee: Suraj Khurana >Priority: Major > Attachments: OFBIZ-11805-plugins.patch, OFBIZ-11805.patch > > > As per discussion over dev ML, [https://markmail.org/message/cyagukb7emaxrhbj] > It is better to create component level patches for this enhancement. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11805) Checkstyle formatting issues
[ https://issues.apache.org/jira/browse/OFBIZ-11805?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17152596#comment-17152596 ] ASF subversion and git services commented on OFBIZ-11805: - Commit f8e17a5b00b6467c403c50348f3777a7b03dfdd1 in ofbiz-plugins's branch refs/heads/trunk from Suraj Khurana [ https://gitbox.apache.org/repos/asf?p=ofbiz-plugins.git;h=f8e17a5 ] Improved: Corrected remaining ', is not followed by whitespace' checkstyle errors in plugin component. (OFBIZ-11805) > Checkstyle formatting issues > > > Key: OFBIZ-11805 > URL: https://issues.apache.org/jira/browse/OFBIZ-11805 > Project: OFBiz > Issue Type: Sub-task > Components: ALL COMPONENTS >Affects Versions: Trunk >Reporter: Suraj Khurana >Assignee: Suraj Khurana >Priority: Major > Attachments: OFBIZ-11805-plugins.patch, OFBIZ-11805.patch > > > As per discussion over dev ML, [https://markmail.org/message/cyagukb7emaxrhbj] > It is better to create component level patches for this enhancement. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11805) Checkstyle formatting issues
[ https://issues.apache.org/jira/browse/OFBIZ-11805?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17151923#comment-17151923 ] ASF subversion and git services commented on OFBIZ-11805: - Commit bfe3adeae93ea3e62ebb71de37ae5acefa588389 in ofbiz-framework's branch refs/heads/trunk from Suraj Khurana [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=bfe3ade ] Improved: Corrected all 'if is not followed by whitespace' checkstyle errors. Also corrected few ', is not followed by whitespace' checkstyle errors in applications component. (OFBIZ-11805) Thanks Jacques Le Roux and Ritesh Kumar for review. > Checkstyle formatting issues > > > Key: OFBIZ-11805 > URL: https://issues.apache.org/jira/browse/OFBIZ-11805 > Project: OFBiz > Issue Type: Sub-task > Components: ALL COMPONENTS >Affects Versions: Trunk >Reporter: Suraj Khurana >Assignee: Suraj Khurana >Priority: Major > Attachments: OFBIZ-11805-plugins.patch, OFBIZ-11805.patch > > > As per discussion over dev ML, [https://markmail.org/message/cyagukb7emaxrhbj] > It is better to create component level patches for this enhancement. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11805) Checkstyle formatting issues
[ https://issues.apache.org/jira/browse/OFBIZ-11805?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17151922#comment-17151922 ] ASF subversion and git services commented on OFBIZ-11805: - Commit 4f53828beaaeaaf5a15111b884b5bd8c8052a031 in ofbiz-framework's branch refs/heads/trunk from Suraj Khurana [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=4f53828 ] Improved: Corrected all 'if is not followed by whitespace' checkstyle errors. Also corrected few ', is not followed by whitespace' checkstyle errors in framework component. (OFBIZ-11805) Thanks Jacques Le Roux and Ritesh Kumar for review. > Checkstyle formatting issues > > > Key: OFBIZ-11805 > URL: https://issues.apache.org/jira/browse/OFBIZ-11805 > Project: OFBiz > Issue Type: Sub-task > Components: ALL COMPONENTS >Affects Versions: Trunk >Reporter: Suraj Khurana >Assignee: Suraj Khurana >Priority: Major > Attachments: OFBIZ-11805-plugins.patch, OFBIZ-11805.patch > > > As per discussion over dev ML, [https://markmail.org/message/cyagukb7emaxrhbj] > It is better to create component level patches for this enhancement. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11805) Checkstyle formatting issues
[ https://issues.apache.org/jira/browse/OFBIZ-11805?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17151917#comment-17151917 ] ASF subversion and git services commented on OFBIZ-11805: - Commit c24db772c9013c0c89252160e4fb66f41d777657 in ofbiz-plugins's branch refs/heads/trunk from Suraj Khurana [ https://gitbox.apache.org/repos/asf?p=ofbiz-plugins.git;h=c24db77 ] Improved: Corrected all 'if is not followed by whitespace' checkstyle errors. Also corrected few ', is not followed by whitespace' checkstyle errors. (OFBIZ-11805) Thanks Jacques Le Roux and Ritesh Kumar for review. > Checkstyle formatting issues > > > Key: OFBIZ-11805 > URL: https://issues.apache.org/jira/browse/OFBIZ-11805 > Project: OFBiz > Issue Type: Sub-task > Components: ALL COMPONENTS >Affects Versions: Trunk >Reporter: Suraj Khurana >Assignee: Suraj Khurana >Priority: Major > Attachments: OFBIZ-11805-plugins.patch, OFBIZ-11805.patch > > > As per discussion over dev ML, [https://markmail.org/message/cyagukb7emaxrhbj] > It is better to create component level patches for this enhancement. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11805) Checkstyle formatting issues
[ https://issues.apache.org/jira/browse/OFBIZ-11805?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17151866#comment-17151866 ] Ritesh Kumar commented on OFBIZ-11805: -- I have tested the patch, it looks good to me. > Checkstyle formatting issues > > > Key: OFBIZ-11805 > URL: https://issues.apache.org/jira/browse/OFBIZ-11805 > Project: OFBiz > Issue Type: Sub-task > Components: ALL COMPONENTS >Affects Versions: Trunk >Reporter: Suraj Khurana >Assignee: Suraj Khurana >Priority: Major > Attachments: OFBIZ-11805-plugins.patch, OFBIZ-11805.patch > > > As per discussion over dev ML, [https://markmail.org/message/cyagukb7emaxrhbj] > It is better to create component level patches for this enhancement. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11805) Checkstyle formatting issues
[ https://issues.apache.org/jira/browse/OFBIZ-11805?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17151390#comment-17151390 ] Jacques Le Roux commented on OFBIZ-11805: - Thanks Suraj, After applyting both patches I just ran testIntegration, it's OK and that's enough for me to vote +1 > Checkstyle formatting issues > > > Key: OFBIZ-11805 > URL: https://issues.apache.org/jira/browse/OFBIZ-11805 > Project: OFBiz > Issue Type: Sub-task > Components: ALL COMPONENTS >Affects Versions: Trunk >Reporter: Suraj Khurana >Assignee: Suraj Khurana >Priority: Major > Attachments: OFBIZ-11805-plugins.patch, OFBIZ-11805.patch > > > As per discussion over dev ML, [https://markmail.org/message/cyagukb7emaxrhbj] > It is better to create component level patches for this enhancement. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11805) Checkstyle formatting issues
[ https://issues.apache.org/jira/browse/OFBIZ-11805?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17151277#comment-17151277 ] Suraj Khurana commented on OFBIZ-11805: --- Hello team, Added initial patch which fixes all "if is not followed by whitespace." checkstyle errors. Also I have fixed some ", is not followed by whitespace." errors. This was a simple but cautious find/replace from IDE. This patch fixed more than 250 issues. > Checkstyle formatting issues > > > Key: OFBIZ-11805 > URL: https://issues.apache.org/jira/browse/OFBIZ-11805 > Project: OFBiz > Issue Type: Sub-task > Components: ALL COMPONENTS >Affects Versions: Trunk >Reporter: Suraj Khurana >Assignee: Suraj Khurana >Priority: Major > Attachments: OFBIZ-11805-plugins.patch, OFBIZ-11805.patch > > > As per discussion over dev ML, [https://markmail.org/message/cyagukb7emaxrhbj] > It is better to create component level patches for this enhancement. -- This message was sent by Atlassian Jira (v8.3.4#803005)
