[jira] [Commented] (OFBIZ-11921) Checkstyle: Line is longer than 150 characters
[ https://issues.apache.org/jira/browse/OFBIZ-11921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17190591#comment-17190591 ] ASF subversion and git services commented on OFBIZ-11921: - Commit 26ddcc0c8e2189b0adb421fa4669b934b372407d in ofbiz-plugins's branch refs/heads/trunk from Suraj Khurana [ https://gitbox.apache.org/repos/asf?p=ofbiz-plugins.git;h=26ddcc0 ] Improved: Corrected line is longer than 150 characters checkstyle issues in plugins component. (OFBIZ-11921) Also fixed some other extra space and naming related checkstyle issues observed. Thanks Jacques for review. > Checkstyle: Line is longer than 150 characters > -- > > Key: OFBIZ-11921 > URL: https://issues.apache.org/jira/browse/OFBIZ-11921 > Project: OFBiz > Issue Type: Sub-task > Components: ALL COMPONENTS >Affects Versions: Trunk >Reporter: Suraj Khurana >Assignee: Suraj Khurana >Priority: Major > Attachments: OFBIZ-11921-2.patch, OFBIZ-11921-3.patch, > OFBIZ-11921-plugins-2.patch, OFBIZ-11921-plugins-3.patch, OFBIZ-11921.patch, > OFBIZ-plugins-11921.patch > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11921) Checkstyle: Line is longer than 150 characters
[ https://issues.apache.org/jira/browse/OFBIZ-11921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17190585#comment-17190585 ] ASF subversion and git services commented on OFBIZ-11921: - Commit bc5e945dedd25fbd7ffa8f45c1c05c9cf131fdd1 in ofbiz-framework's branch refs/heads/trunk from Suraj Khurana [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=bc5e945 ] Improved: Corrected line is longer than 150 characters checkstyle issues in framework component. (OFBIZ-11921) Also fixed some other extra space and naming related checkstyle issues observed. Thanks Jacques for review. > Checkstyle: Line is longer than 150 characters > -- > > Key: OFBIZ-11921 > URL: https://issues.apache.org/jira/browse/OFBIZ-11921 > Project: OFBiz > Issue Type: Sub-task > Components: ALL COMPONENTS >Affects Versions: Trunk >Reporter: Suraj Khurana >Assignee: Suraj Khurana >Priority: Major > Attachments: OFBIZ-11921-2.patch, OFBIZ-11921-3.patch, > OFBIZ-11921-plugins-2.patch, OFBIZ-11921-plugins-3.patch, OFBIZ-11921.patch, > OFBIZ-plugins-11921.patch > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11921) Checkstyle: Line is longer than 150 characters
[ https://issues.apache.org/jira/browse/OFBIZ-11921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17190583#comment-17190583 ] ASF subversion and git services commented on OFBIZ-11921: - Commit 5f021ce06b3ae593fb06f627a60168be01702c6a in ofbiz-framework's branch refs/heads/trunk from Suraj Khurana [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=5f021ce ] Improved: Corrected line is longer than 150 characters checkstyle issues in applications component. (OFBIZ-11921) Also fixed some other extra space and naming related checkstyle issues observed. Thanks Jacques for review. > Checkstyle: Line is longer than 150 characters > -- > > Key: OFBIZ-11921 > URL: https://issues.apache.org/jira/browse/OFBIZ-11921 > Project: OFBiz > Issue Type: Sub-task > Components: ALL COMPONENTS >Affects Versions: Trunk >Reporter: Suraj Khurana >Assignee: Suraj Khurana >Priority: Major > Attachments: OFBIZ-11921-2.patch, OFBIZ-11921-3.patch, > OFBIZ-11921-plugins-2.patch, OFBIZ-11921-plugins-3.patch, OFBIZ-11921.patch, > OFBIZ-plugins-11921.patch > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11921) Checkstyle: Line is longer than 150 characters
[ https://issues.apache.org/jira/browse/OFBIZ-11921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17190167#comment-17190167 ] Suraj Khurana commented on OFBIZ-11921: --- Build successful. All tests passed in testIntegration. > Checkstyle: Line is longer than 150 characters > -- > > Key: OFBIZ-11921 > URL: https://issues.apache.org/jira/browse/OFBIZ-11921 > Project: OFBiz > Issue Type: Sub-task > Components: ALL COMPONENTS >Affects Versions: Trunk >Reporter: Suraj Khurana >Assignee: Suraj Khurana >Priority: Major > Attachments: OFBIZ-11921-2.patch, OFBIZ-11921-3.patch, > OFBIZ-11921-plugins-2.patch, OFBIZ-11921-plugins-3.patch, OFBIZ-11921.patch, > OFBIZ-plugins-11921.patch > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11921) Checkstyle: Line is longer than 150 characters
[ https://issues.apache.org/jira/browse/OFBIZ-11921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17189957#comment-17189957 ] Jacques Le Roux commented on OFBIZ-11921: - Cursory review of plugins, looks good to me Survey review of framework, looks good to me Disclaimer: no compile tested > Checkstyle: Line is longer than 150 characters > -- > > Key: OFBIZ-11921 > URL: https://issues.apache.org/jira/browse/OFBIZ-11921 > Project: OFBiz > Issue Type: Sub-task > Components: ALL COMPONENTS >Affects Versions: Trunk >Reporter: Suraj Khurana >Assignee: Suraj Khurana >Priority: Major > Attachments: OFBIZ-11921-2.patch, OFBIZ-11921-3.patch, > OFBIZ-11921-plugins-2.patch, OFBIZ-11921-plugins-3.patch, OFBIZ-11921.patch, > OFBIZ-plugins-11921.patch > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11921) Checkstyle: Line is longer than 150 characters
[ https://issues.apache.org/jira/browse/OFBIZ-11921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17189929#comment-17189929 ] Suraj Khurana commented on OFBIZ-11921: --- Last patch for this ticket attached. > Checkstyle: Line is longer than 150 characters > -- > > Key: OFBIZ-11921 > URL: https://issues.apache.org/jira/browse/OFBIZ-11921 > Project: OFBiz > Issue Type: Sub-task > Components: ALL COMPONENTS >Affects Versions: Trunk >Reporter: Suraj Khurana >Assignee: Suraj Khurana >Priority: Major > Attachments: OFBIZ-11921-2.patch, OFBIZ-11921-3.patch, > OFBIZ-11921-plugins-2.patch, OFBIZ-11921-plugins-3.patch, OFBIZ-11921.patch, > OFBIZ-plugins-11921.patch > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11921) Checkstyle: Line is longer than 150 characters
[ https://issues.apache.org/jira/browse/OFBIZ-11921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17187776#comment-17187776 ] Suraj Khurana commented on OFBIZ-11921: --- Thanks Jacques for review. Both the patches are loaded into trunk and this fixed around *1020* checkstyle issues. > Checkstyle: Line is longer than 150 characters > -- > > Key: OFBIZ-11921 > URL: https://issues.apache.org/jira/browse/OFBIZ-11921 > Project: OFBiz > Issue Type: Sub-task > Components: ALL COMPONENTS >Affects Versions: Trunk >Reporter: Suraj Khurana >Assignee: Suraj Khurana >Priority: Major > Attachments: OFBIZ-11921-2.patch, OFBIZ-11921-plugins-2.patch, > OFBIZ-11921.patch, OFBIZ-plugins-11921.patch > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11921) Checkstyle: Line is longer than 150 characters
[ https://issues.apache.org/jira/browse/OFBIZ-11921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17187772#comment-17187772 ] ASF subversion and git services commented on OFBIZ-11921: - Commit 6dfc3c19e756dba7d0563d4fc8e920a72cc8bef9 in ofbiz-plugins's branch refs/heads/trunk from Suraj Khurana [ https://gitbox.apache.org/repos/asf?p=ofbiz-plugins.git;h=6dfc3c1 ] Improved: Corrected some extra spaces and naming conventions related checkstyle issues. (OFBIZ-11921) Also fixed some access modifiers for some private class members. Thanks Jacques Le Roux for review. > Checkstyle: Line is longer than 150 characters > -- > > Key: OFBIZ-11921 > URL: https://issues.apache.org/jira/browse/OFBIZ-11921 > Project: OFBiz > Issue Type: Sub-task > Components: ALL COMPONENTS >Affects Versions: Trunk >Reporter: Suraj Khurana >Assignee: Suraj Khurana >Priority: Major > Attachments: OFBIZ-11921-2.patch, OFBIZ-11921-plugins-2.patch, > OFBIZ-11921.patch, OFBIZ-plugins-11921.patch > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11921) Checkstyle: Line is longer than 150 characters
[ https://issues.apache.org/jira/browse/OFBIZ-11921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17187770#comment-17187770 ] ASF subversion and git services commented on OFBIZ-11921: - Commit ca9fa4fba49fe7391bd6b6e681729aaef66fc78f in ofbiz-framework's branch refs/heads/trunk from Suraj Khurana [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=ca9fa4f ] Improved: Corrected line is longer than 150 characters checkstyle issues in framework and applications component. (OFBIZ-11921) Also fixed some extra spaces and naming conventions related checkstyle issues. Thanks Jacques for review. > Checkstyle: Line is longer than 150 characters > -- > > Key: OFBIZ-11921 > URL: https://issues.apache.org/jira/browse/OFBIZ-11921 > Project: OFBiz > Issue Type: Sub-task > Components: ALL COMPONENTS >Affects Versions: Trunk >Reporter: Suraj Khurana >Assignee: Suraj Khurana >Priority: Major > Attachments: OFBIZ-11921-2.patch, OFBIZ-11921-plugins-2.patch, > OFBIZ-11921.patch, OFBIZ-plugins-11921.patch > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11921) Checkstyle: Line is longer than 150 characters
[ https://issues.apache.org/jira/browse/OFBIZ-11921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17187678#comment-17187678 ] Jacques Le Roux commented on OFBIZ-11921: - After a cursorily review of the framework patch: +1 for commit both > Checkstyle: Line is longer than 150 characters > -- > > Key: OFBIZ-11921 > URL: https://issues.apache.org/jira/browse/OFBIZ-11921 > Project: OFBiz > Issue Type: Sub-task > Components: ALL COMPONENTS >Affects Versions: Trunk >Reporter: Suraj Khurana >Assignee: Suraj Khurana >Priority: Major > Attachments: OFBIZ-11921-2.patch, OFBIZ-11921-plugins-2.patch, > OFBIZ-11921.patch, OFBIZ-plugins-11921.patch > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11921) Checkstyle: Line is longer than 150 characters
[ https://issues.apache.org/jira/browse/OFBIZ-11921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17187661#comment-17187661 ] Suraj Khurana commented on OFBIZ-11921: --- Yes, this one of plugins is kind of mixed and thus small, nothing major of same kind left in plugins. :) > Checkstyle: Line is longer than 150 characters > -- > > Key: OFBIZ-11921 > URL: https://issues.apache.org/jira/browse/OFBIZ-11921 > Project: OFBiz > Issue Type: Sub-task > Components: ALL COMPONENTS >Affects Versions: Trunk >Reporter: Suraj Khurana >Assignee: Suraj Khurana >Priority: Major > Attachments: OFBIZ-11921-2.patch, OFBIZ-11921-plugins-2.patch, > OFBIZ-11921.patch, OFBIZ-plugins-11921.patch > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11921) Checkstyle: Line is longer than 150 characters
[ https://issues.apache.org/jira/browse/OFBIZ-11921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17186911#comment-17186911 ] Jacques Le Roux commented on OFBIZ-11921: - Hi Suraj, Reading [^OFBIZ-11921-plugins-2.patch] I'm not sure it belongs to this Jira > Checkstyle: Line is longer than 150 characters > -- > > Key: OFBIZ-11921 > URL: https://issues.apache.org/jira/browse/OFBIZ-11921 > Project: OFBiz > Issue Type: Sub-task > Components: ALL COMPONENTS >Affects Versions: Trunk >Reporter: Suraj Khurana >Assignee: Suraj Khurana >Priority: Major > Attachments: OFBIZ-11921-2.patch, OFBIZ-11921-plugins-2.patch, > OFBIZ-11921.patch, OFBIZ-plugins-11921.patch > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11921) Checkstyle: Line is longer than 150 characters
[ https://issues.apache.org/jira/browse/OFBIZ-11921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17169721#comment-17169721 ] ASF subversion and git services commented on OFBIZ-11921: - Commit c6399ef668f24606e3a5cd7c76a666e09fd5aaaf in ofbiz-framework's branch refs/heads/trunk from Suraj Khurana [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=c6399ef ] Improved: Corrected some line is longer than 150 characters checkstyle issues in applications component. Also fixed some extra spaces and naming conventions related checkstyle issues. (OFBIZ-11921) > Checkstyle: Line is longer than 150 characters > -- > > Key: OFBIZ-11921 > URL: https://issues.apache.org/jira/browse/OFBIZ-11921 > Project: OFBiz > Issue Type: Sub-task > Components: ALL COMPONENTS >Affects Versions: Trunk >Reporter: Suraj Khurana >Assignee: Suraj Khurana >Priority: Major > Attachments: OFBIZ-11921.patch, OFBIZ-plugins-11921.patch > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11921) Checkstyle: Line is longer than 150 characters
[ https://issues.apache.org/jira/browse/OFBIZ-11921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17169718#comment-17169718 ] ASF subversion and git services commented on OFBIZ-11921: - Commit 7d82b17c726f91600d35e21940c74b3085d9e145 in ofbiz-framework's branch refs/heads/trunk from Suraj Khurana [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=7d82b17 ] Improved: Corrected some line is longer than 150 characters checkstyle issues in framework component. Also fixed some extra spaces and naming conventions related checkstyle issues. (OFBIZ-11921) > Checkstyle: Line is longer than 150 characters > -- > > Key: OFBIZ-11921 > URL: https://issues.apache.org/jira/browse/OFBIZ-11921 > Project: OFBiz > Issue Type: Sub-task > Components: ALL COMPONENTS >Affects Versions: Trunk >Reporter: Suraj Khurana >Assignee: Suraj Khurana >Priority: Major > Attachments: OFBIZ-11921.patch, OFBIZ-plugins-11921.patch > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11921) Checkstyle: Line is longer than 150 characters
[ https://issues.apache.org/jira/browse/OFBIZ-11921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17169714#comment-17169714 ] ASF subversion and git services commented on OFBIZ-11921: - Commit 30f796146c48bffe52e36136073f5cc80e7fb267 in ofbiz-plugins's branch refs/heads/trunk from Suraj Khurana [ https://gitbox.apache.org/repos/asf?p=ofbiz-plugins.git;h=30f7961 ] Improved: Corrected some line is longer than 150 characters checkstyle issues. Also fixed some extra spaces and naming conventions related checkstyle issues. (OFBIZ-11921) > Checkstyle: Line is longer than 150 characters > -- > > Key: OFBIZ-11921 > URL: https://issues.apache.org/jira/browse/OFBIZ-11921 > Project: OFBiz > Issue Type: Sub-task > Components: ALL COMPONENTS >Affects Versions: Trunk >Reporter: Suraj Khurana >Assignee: Suraj Khurana >Priority: Major > Attachments: OFBIZ-11921.patch, OFBIZ-plugins-11921.patch > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11921) Checkstyle: Line is longer than 150 characters
[ https://issues.apache.org/jira/browse/OFBIZ-11921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17169312#comment-17169312 ] Suraj Khurana commented on OFBIZ-11921: --- Attached initial patch, there will be some more for this changes. This patch fixes around *2150* checkstyle issues. Few general issues are also being take care in this patch > Checkstyle: Line is longer than 150 characters > -- > > Key: OFBIZ-11921 > URL: https://issues.apache.org/jira/browse/OFBIZ-11921 > Project: OFBiz > Issue Type: Sub-task > Components: ALL COMPONENTS >Affects Versions: Trunk >Reporter: Suraj Khurana >Assignee: Suraj Khurana >Priority: Major > Attachments: OFBIZ-11921.patch, OFBIZ-plugins-11921.patch > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11921) Checkstyle: Line is longer than 150 characters
[ https://issues.apache.org/jira/browse/OFBIZ-11921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17164916#comment-17164916 ] Jacques Le Roux commented on OFBIZ-11921: - So it will be a big manual process (ouch! 1215 Java files). That's fine with me, I see no other ways. > Checkstyle: Line is longer than 150 characters > -- > > Key: OFBIZ-11921 > URL: https://issues.apache.org/jira/browse/OFBIZ-11921 > Project: OFBiz > Issue Type: Sub-task > Components: ALL COMPONENTS >Affects Versions: Trunk >Reporter: Suraj Khurana >Assignee: Suraj Khurana >Priority: Major > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11921) Checkstyle: Line is longer than 150 characters
[ https://issues.apache.org/jira/browse/OFBIZ-11921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17164904#comment-17164904 ] Suraj Khurana commented on OFBIZ-11921: --- Yes, you are right Jacques. We have wrapping and braces setting in IntelliJ IDE ([https://www.jetbrains.com/help/phpstorm/settings-code-style-wrapping-and-braces-common.html]) and after proper settings when I re-format the source-code ([https://www.jetbrains.com/help/phpstorm/reformat-and-rearrange-code.html]), it works fine. Till now, I have applied this changes in some selected code and observed it works well, except some manual changes, like sometimes if leaves white space in the end which needs to be re-checked and removed with replace all option. Other than this, it works pretty well. > Checkstyle: Line is longer than 150 characters > -- > > Key: OFBIZ-11921 > URL: https://issues.apache.org/jira/browse/OFBIZ-11921 > Project: OFBiz > Issue Type: Sub-task > Components: ALL COMPONENTS >Affects Versions: Trunk >Reporter: Suraj Khurana >Assignee: Suraj Khurana >Priority: Major > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11921) Checkstyle: Line is longer than 150 characters
[ https://issues.apache.org/jira/browse/OFBIZ-11921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17164898#comment-17164898 ] Jacques Le Roux commented on OFBIZ-11921: - Hi Suraj, I guess this is a big one. How do yo intend to fix it? > Checkstyle: Line is longer than 150 characters > -- > > Key: OFBIZ-11921 > URL: https://issues.apache.org/jira/browse/OFBIZ-11921 > Project: OFBiz > Issue Type: Sub-task > Components: ALL COMPONENTS >Affects Versions: Trunk >Reporter: Suraj Khurana >Assignee: Suraj Khurana >Priority: Major > -- This message was sent by Atlassian Jira (v8.3.4#803005)
