[jira] [Commented] (OFBIZ-11985) Add a new NumberConverter to convert Integer to BigInteger
[
https://issues.apache.org/jira/browse/OFBIZ-11985?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17186279#comment-17186279
]
Jacques Le Roux commented on OFBIZ-11985:
-
Thanks Girish,
I was not aware of this specific condition for REST. I think we are OK to close
then.
> Add a new NumberConverter to convert Integer to BigInteger
> --
>
> Key: OFBIZ-11985
> URL: https://issues.apache.org/jira/browse/OFBIZ-11985
> Project: OFBiz
> Issue Type: Sub-task
> Components: ALL PLUGINS
>Affects Versions: Trunk
>Reporter: Girish Vasmatkar
>Assignee: Girish Vasmatkar
>Priority: Minor
>
> Create a new NumberConverter allowing conversion from java.lang.Integer to
> java.math.BigInteger.
> JSON number value is parsed as Integer by default and in order to pass the
> value to a service attribute defined as BigInteger, conversion is necessary
> in order to avoid type mismatch error.
> {code:java}
> java.lang.ClassNotFoundException: No converter found for
> java.lang.Integer->java.math.BigInteger
> at
> org.apache.ofbiz.base.conversion.Converters.getConverter(Converters.java:119)
> ~[main/:?]
> {code}
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (OFBIZ-11985) Add a new NumberConverter to convert Integer to BigInteger
[
https://issues.apache.org/jira/browse/OFBIZ-11985?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17186234#comment-17186234
]
Girish Vasmatkar commented on OFBIZ-11985:
--
Hi Jacques
I was not sure about backporting it because this looked to me an improvement
because it was very limited to REST. Internally if a developer tries to create
a valid context for a service that has an attribute defined as BigInteger, he
will always provide BigInteger.
JSON number passed in HTTP requests and when converted in Map will always have
an integer type and that's where I needed this conversion.
I think backporting will be harmless anyway even if this fix/improvement will
not be of much use in earlier releases. Please let me know accordingly. I just
did not backport based on above logic. If you think we should do it, I will be
happy to do it.
Thank you
-Girish
> Add a new NumberConverter to convert Integer to BigInteger
> --
>
> Key: OFBIZ-11985
> URL: https://issues.apache.org/jira/browse/OFBIZ-11985
> Project: OFBiz
> Issue Type: Sub-task
> Components: ALL PLUGINS
>Affects Versions: Trunk
>Reporter: Girish Vasmatkar
>Assignee: Girish Vasmatkar
>Priority: Minor
>
> Create a new NumberConverter allowing conversion from java.lang.Integer to
> java.math.BigInteger.
> JSON number value is parsed as Integer by default and in order to pass the
> value to a service attribute defined as BigInteger, conversion is necessary
> in order to avoid type mismatch error.
> {code:java}
> java.lang.ClassNotFoundException: No converter found for
> java.lang.Integer->java.math.BigInteger
> at
> org.apache.ofbiz.base.conversion.Converters.getConverter(Converters.java:119)
> ~[main/:?]
> {code}
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (OFBIZ-11985) Add a new NumberConverter to convert Integer to BigInteger
[
https://issues.apache.org/jira/browse/OFBIZ-11985?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17185998#comment-17185998
]
Jacques Le Roux commented on OFBIZ-11985:
-
Thanks Girish,
Should we not consider this has a bug, or at least backport it?
> Add a new NumberConverter to convert Integer to BigInteger
> --
>
> Key: OFBIZ-11985
> URL: https://issues.apache.org/jira/browse/OFBIZ-11985
> Project: OFBiz
> Issue Type: Sub-task
> Components: ALL PLUGINS
>Affects Versions: Trunk
>Reporter: Girish Vasmatkar
>Assignee: Girish Vasmatkar
>Priority: Minor
>
> Create a new NumberConverter allowing conversion from java.lang.Integer to
> java.math.BigInteger.
> JSON number value is parsed as Integer by default and in order to pass the
> value to a service attribute defined as BigInteger, conversion is necessary
> in order to avoid type mismatch error.
> {code:java}
> java.lang.ClassNotFoundException: No converter found for
> java.lang.Integer->java.math.BigInteger
> at
> org.apache.ofbiz.base.conversion.Converters.getConverter(Converters.java:119)
> ~[main/:?]
> {code}
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (OFBIZ-11985) Add a new NumberConverter to convert Integer to BigInteger
[
https://issues.apache.org/jira/browse/OFBIZ-11985?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17185966#comment-17185966
]
ASF subversion and git services commented on OFBIZ-11985:
-
Commit a79c6cc3a4dbb21ce9ede1fafa17679207390051 in ofbiz-framework's branch
refs/heads/trunk from Girish Vasmatkar
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=a79c6cc ]
Implemented: Added a new IntegerToBigInteger converter(OFBIZ-11985)
> Add a new NumberConverter to convert Integer to BigInteger
> --
>
> Key: OFBIZ-11985
> URL: https://issues.apache.org/jira/browse/OFBIZ-11985
> Project: OFBiz
> Issue Type: Sub-task
> Components: ALL PLUGINS
>Affects Versions: Trunk
>Reporter: Girish Vasmatkar
>Assignee: Girish Vasmatkar
>Priority: Minor
>
> Create a new NumberConverter allowing conversion from java.lang.Integer to
> java.math.BigInteger.
> JSON number value is parsed as Integer by default and in order to pass the
> value to a service attribute defined as BigInteger, conversion is necessary
> in order to avoid type mismatch error.
> {code:java}
> java.lang.ClassNotFoundException: No converter found for
> java.lang.Integer->java.math.BigInteger
> at
> org.apache.ofbiz.base.conversion.Converters.getConverter(Converters.java:119)
> ~[main/:?]
> {code}
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
