[jira] [Commented] (OFBIZ-12750) Product Image PNG - Black Background
[ https://issues.apache.org/jira/browse/OFBIZ-12750?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17684192#comment-17684192 ] Ingo Wolfmayr commented on OFBIZ-12750: --- Thanks Jacques!!! > Product Image PNG - Black Background > > > Key: OFBIZ-12750 > URL: https://issues.apache.org/jira/browse/OFBIZ-12750 > Project: OFBiz > Issue Type: Bug > Components: product/catalog >Affects Versions: Upcoming Branch >Reporter: Ingo Wolfmayr >Assignee: Jacques Le Roux >Priority: Major > Fix For: 22.01.01 > > Attachments: Lyke CF SE.png, png.patch > > > When uploading an png image to a product (default image), transparent > background becomes black. > [https://demo-trunk.ofbiz.apache.org/catalog/control/UploadProductImage?productId=WG-9943-B3_file_type=original] > Uploading the same image as content or via image management works. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OFBIZ-12750) Product Image PNG - Black Background
[ https://issues.apache.org/jira/browse/OFBIZ-12750?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17684165#comment-17684165 ] ASF subversion and git services commented on OFBIZ-12750: - Commit 34f0ad4080f9308ff09456b18bcf2ae8b772995e in ofbiz-framework's branch refs/heads/release22.01 from Jacques Le Roux [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=34f0ad4080 ] Fixed: Product Image PNG - Black Background (OFBIZ-12750) Fixes previous commit* in relation with this change: jleroux: in 22.01 I also made the file the same than in trunk. There were no reasons it should no be (no functional change but for transparent background and Windows usage). This will also make future possible backports easier imaging:1.0-alpha3 was needed * https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=c592382f57 > Product Image PNG - Black Background > > > Key: OFBIZ-12750 > URL: https://issues.apache.org/jira/browse/OFBIZ-12750 > Project: OFBiz > Issue Type: Bug > Components: product/catalog >Affects Versions: Upcoming Branch >Reporter: Ingo Wolfmayr >Assignee: Jacques Le Roux >Priority: Major > Fix For: 22.01.01 > > Attachments: Lyke CF SE.png, png.patch > > > When uploading an png image to a product (default image), transparent > background becomes black. > [https://demo-trunk.ofbiz.apache.org/catalog/control/UploadProductImage?productId=WG-9943-B3_file_type=original] > Uploading the same image as content or via image management works. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OFBIZ-12750) Product Image PNG - Black Background
[ https://issues.apache.org/jira/browse/OFBIZ-12750?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17684151#comment-17684151 ] ASF subversion and git services commented on OFBIZ-12750: - Commit c592382f57f50d0d671e657b24b16e1a9a61d77a in ofbiz-framework's branch refs/heads/release22.01 from Jacques Le Roux [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=c592382f57 ] Fixed: Product Image PNG - Black Background (OFBIZ-12750) When uploading a png image to a product via product/content, transparent background becomes black. Uploading the same image via content component or image management works. Thanks: Ingo jleroux: in 22.01 I also made the file the same than in trunk. There were no reasons it should no be (no functional change but for transparent background and Windows usage). This will also make future possible backports easier > Product Image PNG - Black Background > > > Key: OFBIZ-12750 > URL: https://issues.apache.org/jira/browse/OFBIZ-12750 > Project: OFBiz > Issue Type: Bug > Components: product/catalog >Affects Versions: Upcoming Branch >Reporter: Ingo Wolfmayr >Assignee: Jacques Le Roux >Priority: Major > Attachments: Lyke CF SE.png, png.patch > > > When uploading an png image to a product (default image), transparent > background becomes black. > [https://demo-trunk.ofbiz.apache.org/catalog/control/UploadProductImage?productId=WG-9943-B3_file_type=original] > Uploading the same image as content or via image management works. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OFBIZ-12750) Product Image PNG - Black Background
[ https://issues.apache.org/jira/browse/OFBIZ-12750?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17684152#comment-17684152 ] ASF subversion and git services commented on OFBIZ-12750: - Commit cba0e4b77ad3168674227007ae42d04f3a14daee in ofbiz-framework's branch refs/heads/trunk from Jacques Le Roux [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=cba0e4b77a ] Fixed: Product Image PNG - Black Background (OFBIZ-12750) When uploading a png image to a product via product/content, transparent background becomes black. Uploading the same image via content component or image management works. Thanks: Ingo > Product Image PNG - Black Background > > > Key: OFBIZ-12750 > URL: https://issues.apache.org/jira/browse/OFBIZ-12750 > Project: OFBiz > Issue Type: Bug > Components: product/catalog >Affects Versions: Upcoming Branch >Reporter: Ingo Wolfmayr >Assignee: Jacques Le Roux >Priority: Major > Attachments: Lyke CF SE.png, png.patch > > > When uploading an png image to a product (default image), transparent > background becomes black. > [https://demo-trunk.ofbiz.apache.org/catalog/control/UploadProductImage?productId=WG-9943-B3_file_type=original] > Uploading the same image as content or via image management works. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OFBIZ-12750) Product Image PNG - Black Background
[ https://issues.apache.org/jira/browse/OFBIZ-12750?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17684147#comment-17684147 ] Jacques Le Roux commented on OFBIZ-12750: - Ah I remember, I was confused because you said that it worked with "content or via image management". So I thought that you spoke about product/content upload. I understant now that you spoke about content component. There is still though something I need to check (unrelated to your patch). In all cases, I think SecuredUpload::imageMadeSafe should be called. I'll check after pushing your patch. > Product Image PNG - Black Background > > > Key: OFBIZ-12750 > URL: https://issues.apache.org/jira/browse/OFBIZ-12750 > Project: OFBiz > Issue Type: Improvement > Components: product/catalog >Affects Versions: Upcoming Branch >Reporter: Ingo Wolfmayr >Assignee: Jacques Le Roux >Priority: Major > Attachments: Lyke CF SE.png, png.patch > > > When uploading an png image to a product (default image), transparent > background becomes black. > [https://demo-trunk.ofbiz.apache.org/catalog/control/UploadProductImage?productId=WG-9943-B3_file_type=original] > Uploading the same image as content or via image management works. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OFBIZ-12750) Product Image PNG - Black Background
[ https://issues.apache.org/jira/browse/OFBIZ-12750?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17684141#comment-17684141 ] Jacques Le Roux commented on OFBIZ-12750: - Thank you Ingo, not sure what happened to me yesterday evening. Maybe I simply fogot to temporarily revert dark reader (though I remember I did). Anyway I commit soon... > Product Image PNG - Black Background > > > Key: OFBIZ-12750 > URL: https://issues.apache.org/jira/browse/OFBIZ-12750 > Project: OFBiz > Issue Type: Improvement > Components: product/catalog >Affects Versions: Upcoming Branch >Reporter: Ingo Wolfmayr >Assignee: Jacques Le Roux >Priority: Major > Attachments: Lyke CF SE.png, png.patch > > > When uploading an png image to a product (default image), transparent > background becomes black. > [https://demo-trunk.ofbiz.apache.org/catalog/control/UploadProductImage?productId=WG-9943-B3_file_type=original] > Uploading the same image as content or via image management works. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OFBIZ-12750) Product Image PNG - Black Background
[
https://issues.apache.org/jira/browse/OFBIZ-12750?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17683983#comment-17683983
]
Ingo Wolfmayr commented on OFBIZ-12750:
---
Hi
Jacques,[|https://demo-trunk.ofbiz.apache.org/catalog/control/EditProduct?productId=GZ-1001]
go to product GZ-1001 --> Content tab
[https://demo-trunk.ofbiz.apache.org/catalog/control/EditProductContent?productId=GZ-1001]
Upload the png file attached or any other png file with transparent background.
Problem is the following line:
BufferedImage sanitizedImage = new
BufferedImage(initialSizedImage.getWidth(null),
initialSizedImage.getHeight(null),BufferedImage.{color:#de350b}*TYPE_INT_RGB*{color});
> Product Image PNG - Black Background
>
>
> Key: OFBIZ-12750
> URL: https://issues.apache.org/jira/browse/OFBIZ-12750
> Project: OFBiz
> Issue Type: Improvement
> Components: product/catalog
>Affects Versions: Upcoming Branch
>Reporter: Ingo Wolfmayr
>Assignee: Jacques Le Roux
>Priority: Major
> Attachments: Lyke CF SE.png, png.patch
>
>
> When uploading an png image to a product (default image), transparent
> background becomes black.
> [https://demo-trunk.ofbiz.apache.org/catalog/control/UploadProductImage?productId=WG-9943-B3_file_type=original]
> Uploading the same image as content or via image management works.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (OFBIZ-12750) Product Image PNG - Black Background
[ https://issues.apache.org/jira/browse/OFBIZ-12750?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17683976#comment-17683976 ] Jacques Le Roux commented on OFBIZ-12750: - Hi Ingo, I'm not sure how to test that. Obviously the link your provided does not work. Please give us more information, TIA > Product Image PNG - Black Background > > > Key: OFBIZ-12750 > URL: https://issues.apache.org/jira/browse/OFBIZ-12750 > Project: OFBiz > Issue Type: Improvement > Components: product/catalog >Affects Versions: Upcoming Branch >Reporter: Ingo Wolfmayr >Assignee: Jacques Le Roux >Priority: Major > Attachments: Lyke CF SE.png, png.patch > > > When uploading an png image to a product (default image), transparent > background becomes black. > [https://demo-trunk.ofbiz.apache.org/catalog/control/UploadProductImage?productId=WG-9943-B3_file_type=original] > Uploading the same image as content or via image management works. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OFBIZ-12750) Product Image PNG - Black Background
[ https://issues.apache.org/jira/browse/OFBIZ-12750?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17682662#comment-17682662 ] Ingo Wolfmayr commented on OFBIZ-12750: --- Attached a patch to resolve the issue. > Product Image PNG - Black Background > > > Key: OFBIZ-12750 > URL: https://issues.apache.org/jira/browse/OFBIZ-12750 > Project: OFBiz > Issue Type: Improvement > Components: product/catalog >Affects Versions: Upcoming Branch >Reporter: Ingo Wolfmayr >Priority: Major > Attachments: Lyke CF SE.png, png.patch > > > When uploading an png image to a product (default image), transparent > background becomes black. > [https://demo-trunk.ofbiz.apache.org/catalog/control/UploadProductImage?productId=WG-9943-B3_file_type=original] > Uploading the same image as content or via image management works. -- This message was sent by Atlassian Jira (v8.20.10#820010)
