[jira] [Commented] (OFBIZ-12804) Replace jsgantt sources in common-theme with npm module in project plugin
[ https://issues.apache.org/jira/browse/OFBIZ-12804?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17736823#comment-17736823 ] ASF subversion and git services commented on OFBIZ-12804: - Commit e0ca4364cc939ff0b5708d42f2327b949c6c8460 in ofbiz-plugins's branch refs/heads/trunk from Jacques Le Roux [ https://gitbox.apache.org/repos/asf?p=ofbiz-plugins.git;h=e0ca4364c ] Improved: Replace jsgantt sources in common-theme with npm module in project plugin (OFBIZ-12804) Updates jsgantt > Replace jsgantt sources in common-theme with npm module in project plugin > - > > Key: OFBIZ-12804 > URL: https://issues.apache.org/jira/browse/OFBIZ-12804 > Project: OFBiz > Issue Type: Improvement > Components: projectmgr, themes >Affects Versions: Upcoming Branch >Reporter: Daniel Watford >Assignee: Daniel Watford >Priority: Minor > Fix For: Upcoming Branch > > Attachments: image-2023-04-18-16-39-30-913.png, > image-2023-04-18-16-40-55-215.png > > > As mentioned in OFBIZ-12789, we have externally sourced javascript modules > include in the ofbiz-framework sources. These sources are not maintained and > are highlighted in sonarcloud bug reporting. > This ticket covers the removal of jgantt sources from common-theme and > replacing those sources with an updated version of jgantt downloaded from npm > repositories at build time. > JGantt is only used by the project plugin. Retrieval and use of the > replacement jgantt npm module shall therefore be configured within the > project plugin. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OFBIZ-12804) Replace jsgantt sources in common-theme with npm module in project plugin
[ https://issues.apache.org/jira/browse/OFBIZ-12804?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17713638#comment-17713638 ] ASF subversion and git services commented on OFBIZ-12804: - Commit 841f84b4335c987d057fdd5d18dcba1b729c628e in ofbiz-plugins's branch refs/heads/trunk from Daniel Watford [ https://gitbox.apache.org/repos/asf?p=ofbiz-plugins.git;h=841f84b43 ] Improved: Reduced codenarc issues for Project plugin (OFBIZ-12804) Applied codenarc recommendations to groovy code used to produce data for rendering in a gantt chart. Also applied Groovy idioms to the code, hopefully improving readability. > Replace jsgantt sources in common-theme with npm module in project plugin > - > > Key: OFBIZ-12804 > URL: https://issues.apache.org/jira/browse/OFBIZ-12804 > Project: OFBiz > Issue Type: Improvement > Components: projectmgr, themes >Affects Versions: Upcoming Branch >Reporter: Daniel Watford >Assignee: Daniel Watford >Priority: Minor > Fix For: Upcoming Branch > > Attachments: image-2023-04-18-16-39-30-913.png, > image-2023-04-18-16-40-55-215.png > > > As mentioned in OFBIZ-12789, we have externally sourced javascript modules > include in the ofbiz-framework sources. These sources are not maintained and > are highlighted in sonarcloud bug reporting. > This ticket covers the removal of jgantt sources from common-theme and > replacing those sources with an updated version of jgantt downloaded from npm > repositories at build time. > JGantt is only used by the project plugin. Retrieval and use of the > replacement jgantt npm module shall therefore be configured within the > project plugin. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OFBIZ-12804) Replace jsgantt sources in common-theme with npm module in project plugin
[ https://issues.apache.org/jira/browse/OFBIZ-12804?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17713634#comment-17713634 ] Daniel Watford commented on OFBIZ-12804: I think the new JsGantt library is a visual improvement on the old one. Old library: !image-2023-04-18-16-39-30-913.png! New library: !image-2023-04-18-16-40-55-215.png! > Replace jsgantt sources in common-theme with npm module in project plugin > - > > Key: OFBIZ-12804 > URL: https://issues.apache.org/jira/browse/OFBIZ-12804 > Project: OFBiz > Issue Type: Improvement > Components: projectmgr, themes >Affects Versions: Upcoming Branch >Reporter: Daniel Watford >Assignee: Daniel Watford >Priority: Minor > Fix For: Upcoming Branch > > Attachments: image-2023-04-18-16-39-30-913.png, > image-2023-04-18-16-40-55-215.png > > > As mentioned in OFBIZ-12789, we have externally sourced javascript modules > include in the ofbiz-framework sources. These sources are not maintained and > are highlighted in sonarcloud bug reporting. > This ticket covers the removal of jgantt sources from common-theme and > replacing those sources with an updated version of jgantt downloaded from npm > repositories at build time. > JGantt is only used by the project plugin. Retrieval and use of the > replacement jgantt npm module shall therefore be configured within the > project plugin. -- This message was sent by Atlassian Jira (v8.20.10#820010)
