[jira] [Commented] (OFBIZ-12837) Log SQL statement in exceptions in EntitySQLProcessor

2023-07-22 Thread ASF subversion and git services (Jira) 


[ 
https://issues.apache.org/jira/browse/OFBIZ-12837?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17745881#comment-17745881
 ] 

ASF subversion and git services commented on OFBIZ-12837:
-

Commit 4ba4b965994ce39a0b64e08c40940a00bc5ff2c0 in ofbiz-framework's branch 
refs/heads/release22.01 from paul
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=4ba4b96599 ]

Fixed: Log SQL statement in exceptions in EntitySQLProcessor (OFBIZ-12837)

The combination of OFBIZ-11926 and OFBIZ-12386 means the field

   SQLProcessor.sql

is never set, but it was originally designed to cache the SQL command and is 
assumed to be there in several catches.

If an exception occurs, you'll get a "null" and not the statement that caused 
the exception.


> Log SQL statement in exceptions in EntitySQLProcessor
> -
>
> Key: OFBIZ-12837
> URL: https://issues.apache.org/jira/browse/OFBIZ-12837
> Project: OFBiz
>  Issue Type: Bug
>  Components: framework/entity
>Reporter: Paul Foxworthy
>Assignee: Paul Foxworthy
>Priority: Minor
> Attachments: 
> OFBIZ-12837_log_sql_statement_in_exceptions_in_EntitySQLProcessor-1.patch, 
> OFBIZ-12837_log_sql_statement_in_exceptions_in_EntitySQLProcessor.patch
>
>
> The combination of OFBIZ-11926 and OFBIZ-12386 means the field
>  
> {{SQLProcessor.sql}}
>  
> is never set, but it is assumed to be there in several catches - see the 
> patch.
>  
> If an exception occurs, you'll get a "null" and not the statement that caused 
> the exception.
>  
> I had a bit to say about how the problem arose in a comment on OFBIZ-11926.
>  
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (OFBIZ-12837) Log SQL statement in exceptions in EntitySQLProcessor

2023-07-22 Thread ASF subversion and git services (Jira) 


[ 
https://issues.apache.org/jira/browse/OFBIZ-12837?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17745878#comment-17745878
 ] 

ASF subversion and git services commented on OFBIZ-12837:
-

Commit 404cb9fd0260778c801f6b7edaf7d810e4324fec in ofbiz-framework's branch 
refs/heads/trunk from paul
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=404cb9fd02 ]

Fixed: Log SQL statement in exceptions in EntitySQLProcessor (OFBIZ-12837)

The combination of OFBIZ-11926 and OFBIZ-12386 means the field

   SQLProcessor.sql

is never set, but it was originally designed to cache the SQL command and is 
assumed to be there in several catches.

If an exception occurs, you'll get a "null" and not the statement that caused 
the exception.


> Log SQL statement in exceptions in EntitySQLProcessor
> -
>
> Key: OFBIZ-12837
> URL: https://issues.apache.org/jira/browse/OFBIZ-12837
> Project: OFBiz
>  Issue Type: Bug
>  Components: framework/entity
>Reporter: Paul Foxworthy
>Assignee: Paul Foxworthy
>Priority: Minor
> Attachments: 
> OFBIZ-12837_log_sql_statement_in_exceptions_in_EntitySQLProcessor-1.patch, 
> OFBIZ-12837_log_sql_statement_in_exceptions_in_EntitySQLProcessor.patch
>
>
> The combination of OFBIZ-11926 and OFBIZ-12386 means the field
>  
> {{SQLProcessor.sql}}
>  
> is never set, but it is assumed to be there in several catches - see the 
> patch.
>  
> If an exception occurs, you'll get a "null" and not the statement that caused 
> the exception.
>  
> I had a bit to say about how the problem arose in a comment on OFBIZ-11926.
>  
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (OFBIZ-12837) Log SQL statement in exceptions in EntitySQLProcessor

2023-07-19 Thread Paul Foxworthy (Jira) 


[ 
https://issues.apache.org/jira/browse/OFBIZ-12837?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17744826#comment-17744826
 ] 

Paul Foxworthy commented on OFBIZ-12837:


Yes, I'll commit

> Log SQL statement in exceptions in EntitySQLProcessor
> -
>
> Key: OFBIZ-12837
> URL: https://issues.apache.org/jira/browse/OFBIZ-12837
> Project: OFBiz
>  Issue Type: Bug
>  Components: framework/entity
>Reporter: Paul Foxworthy
>Assignee: Paul Foxworthy
>Priority: Minor
> Attachments: 
> OFBIZ-12837_log_sql_statement_in_exceptions_in_EntitySQLProcessor-1.patch, 
> OFBIZ-12837_log_sql_statement_in_exceptions_in_EntitySQLProcessor.patch
>
>
> The combination of OFBIZ-11926 and OFBIZ-12386 means the field
>  
> {{SQLProcessor.sql}}
>  
> is never set, but it is assumed to be there in several catches - see the 
> patch.
>  
> If an exception occurs, you'll get a "null" and not the statement that caused 
> the exception.
>  
> I had a bit to say about how the problem arose in a comment on OFBIZ-11926.
>  
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (OFBIZ-12837) Log SQL statement in exceptions in EntitySQLProcessor

2023-07-19 Thread Jacques Le Roux (Jira) 


[ 
https://issues.apache.org/jira/browse/OFBIZ-12837?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17744517#comment-17744517
 ] 

Jacques Le Roux commented on OFBIZ-12837:
-

Hi Paul,

Will you commit and backport (22.01) ? Else I can do it if you want.

> Log SQL statement in exceptions in EntitySQLProcessor
> -
>
> Key: OFBIZ-12837
> URL: https://issues.apache.org/jira/browse/OFBIZ-12837
> Project: OFBiz
>  Issue Type: Bug
>  Components: framework/entity
>Reporter: Paul Foxworthy
>Assignee: Paul Foxworthy
>Priority: Minor
> Attachments: 
> OFBIZ-12837_log_sql_statement_in_exceptions_in_EntitySQLProcessor-1.patch, 
> OFBIZ-12837_log_sql_statement_in_exceptions_in_EntitySQLProcessor.patch
>
>
> The combination of OFBIZ-11926 and OFBIZ-12386 means the field
>  
> {{SQLProcessor.sql}}
>  
> is never set, but it is assumed to be there in several catches - see the 
> patch.
>  
> If an exception occurs, you'll get a "null" and not the statement that caused 
> the exception.
>  
> I had a bit to say about how the problem arose in a comment on OFBIZ-11926.
>  
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (OFBIZ-12837) Log SQL statement in exceptions in EntitySQLProcessor

2023-07-16 Thread Paul Foxworthy (Jira) 


[ 
https://issues.apache.org/jira/browse/OFBIZ-12837?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17743591#comment-17743591
 ] 

Paul Foxworthy commented on OFBIZ-12837:


Thanks Jacques,

 

Yes, I have revised the patch.

> Log SQL statement in exceptions in EntitySQLProcessor
> -
>
> Key: OFBIZ-12837
> URL: https://issues.apache.org/jira/browse/OFBIZ-12837
> Project: OFBiz
>  Issue Type: Bug
>  Components: framework/entity
>Reporter: Paul Foxworthy
>Assignee: Paul Foxworthy
>Priority: Minor
> Attachments: 
> OFBIZ-12837_log_sql_statement_in_exceptions_in_EntitySQLProcessor-1.patch, 
> OFBIZ-12837_log_sql_statement_in_exceptions_in_EntitySQLProcessor.patch
>
>
> The combination of OFBIZ-11926 and OFBIZ-12386 means the field
>  
> {{SQLProcessor.sql}}
>  
> is never set, but it is assumed to be there in several catches - see the 
> patch.
>  
> If an exception occurs, you'll get a "null" and not the statement that caused 
> the exception.
>  
> I had a bit to say about how the problem arose in a comment on OFBIZ-11926.
>  
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (OFBIZ-12837) Log SQL statement in exceptions in EntitySQLProcessor

2023-07-14 Thread Jacques Le Roux (Jira) 


[ 
https://issues.apache.org/jira/browse/OFBIZ-12837?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17743211#comment-17743211
 ] 

Jacques Le Roux commented on OFBIZ-12837:
-

Thanks Paul,

Taking into account your comment in OFBIZ-11926 I totally agree with you.

Regarding your patch, it's also OK with me but the hunk {{[@@ -421,7 +423,7 
@@]}} that sounds useless to me.

> Log SQL statement in exceptions in EntitySQLProcessor
> -
>
> Key: OFBIZ-12837
> URL: https://issues.apache.org/jira/browse/OFBIZ-12837
> Project: OFBiz
>  Issue Type: Bug
>  Components: framework/entity
>Reporter: Paul Foxworthy
>Assignee: Paul Foxworthy
>Priority: Minor
> Attachments: 
> OFBIZ-12837_log_sql_statement_in_exceptions_in_EntitySQLProcessor.patch
>
>
> The combination of OFBIZ-11926 and OFBIZ-12386 means the field
>  
> {{SQLProcessor.sql}}
>  
> is never set, but it is assumed to be there in several catches - see the 
> patch.
>  
> If an exception occurs, you'll get a "null" and not the statement that caused 
> the exception.
>  
> I had a bit to say about how the problem arose in a comment on OFBIZ-11926.
>  
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)