[jira] [Commented] (OFBIZ-13017) invoiceOverview generates an error
[ https://issues.apache.org/jira/browse/OFBIZ-13017?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17839971#comment-17839971 ] ASF subversion and git services commented on OFBIZ-13017: - Commit edcf41917c3e6fbeaa832f63cd98daf78d3fd34a in ofbiz-framework's branch refs/heads/trunk from Mekika Leila [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=edcf41917c ] Fixed: invoiceOverview generates an error (OFBIZ-13017) (#780) Update fix to combine OFBIZ-12966 and OFBIZ-13011 updates with modifications brought by jira OFBIZ-12994 It brings back the changes introduced by OFBIZ-12994 and adapt it with the change of invoiceOverview screen name > invoiceOverview generates an error > -- > > Key: OFBIZ-13017 > URL: https://issues.apache.org/jira/browse/OFBIZ-13017 > Project: OFBiz > Issue Type: Bug > Components: accounting >Reporter: Pierre Smits >Assignee: Jacques Le Roux >Priority: Major > Fix For: Upcoming Branch > > > see > https://demo-trunk.ofbiz.apache.org/accounting/control/invoiceOverview?invoiceId=demo10001 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OFBIZ-13017) invoiceOverview generates an error
[ https://issues.apache.org/jira/browse/OFBIZ-13017?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17839199#comment-17839199 ] ASF subversion and git services commented on OFBIZ-13017: - Commit 4f1bde0540495b80cef25c9cf88c05a294af3800 in ofbiz-framework's branch refs/heads/trunk from Jacques Le Roux [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=4f1bde0540 ] Fixed: invoiceOverview generates an error (OFBIZ-13017) Fixes the problem by replacing replacing all invoiceOverview occurrences in OFBiz by ViewInvoice. There are no longer other occurrences of "invoiceOverview" This is a maybe temporary workaround. Possibly more is needed as we want to use AccountingInvoiceCpd.xml and related changes that were introduced with OFBIZ-12994. I suppose it's enough for the moment since it does not introduce other changes. As she proposed me, I have asked Leïla to have a look because she knows that more than me having worked on OFBIZ-12994. Maybe a complete refactor is needed. > invoiceOverview generates an error > -- > > Key: OFBIZ-13017 > URL: https://issues.apache.org/jira/browse/OFBIZ-13017 > Project: OFBiz > Issue Type: Bug > Components: accounting >Reporter: Pierre Smits >Priority: Major > > see > https://demo-trunk.ofbiz.apache.org/accounting/control/invoiceOverview?invoiceId=demo10001 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OFBIZ-13017) invoiceOverview generates an error
[ https://issues.apache.org/jira/browse/OFBIZ-13017?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17838874#comment-17838874 ] Jacques Le Roux commented on OFBIZ-13017: - Hi Pierre, Sincerely I prefer ViewInvoice in screen and viewInvoice in controller. It says what is done: you view an invoice. So no, I'll not change that.- This said there is more than my fast solution above. Because then we are not using AccountingInvoiceCpd.xml. I'll work on it now... > invoiceOverview generates an error > -- > > Key: OFBIZ-13017 > URL: https://issues.apache.org/jira/browse/OFBIZ-13017 > Project: OFBiz > Issue Type: Bug > Components: accounting >Reporter: Pierre Smits >Priority: Major > > see > https://demo-trunk.ofbiz.apache.org/accounting/control/invoiceOverview?invoiceId=demo10001 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OFBIZ-13017) invoiceOverview generates an error
[
https://issues.apache.org/jira/browse/OFBIZ-13017?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17838757#comment-17838757
]
Pierre Smits commented on OFBIZ-13017:
--
I suggest to use Invoice instead of ViewInvoice not only for screen name but
also for request-map and view-map.
Let's reserve names with a verb in It for request-maps that invoke services,
e.g.:
{code:java}
{code}
> invoiceOverview generates an error
> --
>
> Key: OFBIZ-13017
> URL: https://issues.apache.org/jira/browse/OFBIZ-13017
> Project: OFBiz
> Issue Type: Bug
> Components: accounting
>Reporter: Pierre Smits
>Priority: Major
>
> see
> https://demo-trunk.ofbiz.apache.org/accounting/control/invoiceOverview?invoiceId=demo10001
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (OFBIZ-13017) invoiceOverview generates an error
[ https://issues.apache.org/jira/browse/OFBIZ-13017?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17838743#comment-17838743 ] Jacques Le Roux commented on OFBIZ-13017: - Hi, Good news, I just made a very quick test. Just replacing by in InvoiceScreens.xml and replacing all invoiceOverview occurrences in accounting controller.xml by ViewInvoice fix the problem here. Of course there are some other invoiceOverview occurrences in accounting and other components (including AR an AP that should dissapear) but it seems (to be tested) that a simple complete replacement should be enough. I'll try that tmrw :) > invoiceOverview generates an error > -- > > Key: OFBIZ-13017 > URL: https://issues.apache.org/jira/browse/OFBIZ-13017 > Project: OFBiz > Issue Type: Bug > Components: accounting >Reporter: Pierre Smits >Priority: Major > > see > https://demo-trunk.ofbiz.apache.org/accounting/control/invoiceOverview?invoiceId=demo10001 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OFBIZ-13017) invoiceOverview generates an error
[ https://issues.apache.org/jira/browse/OFBIZ-13017?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17838626#comment-17838626 ] Mekika Leila commented on OFBIZ-13017: -- Thanks Jacques > invoiceOverview generates an error > -- > > Key: OFBIZ-13017 > URL: https://issues.apache.org/jira/browse/OFBIZ-13017 > Project: OFBiz > Issue Type: Bug > Components: accounting >Reporter: Pierre Smits >Priority: Major > > see > https://demo-trunk.ofbiz.apache.org/accounting/control/invoiceOverview?invoiceId=demo10001 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OFBIZ-13017) invoiceOverview generates an error
[ https://issues.apache.org/jira/browse/OFBIZ-13017?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17838514#comment-17838514 ] Mekika Leila commented on OFBIZ-13017: -- Hello [~jleroux], Sorry, I was talking about pursuing the discussion about the suggestions made by Pierre on OFBIZ-12994. I think corrections about the revert and broken invoiceOverview can still be made in this jira. Do you agree ? > invoiceOverview generates an error > -- > > Key: OFBIZ-13017 > URL: https://issues.apache.org/jira/browse/OFBIZ-13017 > Project: OFBiz > Issue Type: Bug > Components: accounting >Reporter: Pierre Smits >Priority: Major > > see > https://demo-trunk.ofbiz.apache.org/accounting/control/invoiceOverview?invoiceId=demo10001 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OFBIZ-13017) invoiceOverview generates an error
[ https://issues.apache.org/jira/browse/OFBIZ-13017?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17838214#comment-17838214 ] Jacques Le Roux commented on OFBIZ-13017: - Hi Leila, Pierre, Now that we know it's not specifically an error from OFBIZ-12994, I agree about working there. I'm still focused about totally closing OFBIZ-12928 though. I hate to let issues pending. > invoiceOverview generates an error > -- > > Key: OFBIZ-13017 > URL: https://issues.apache.org/jira/browse/OFBIZ-13017 > Project: OFBiz > Issue Type: Bug > Components: accounting >Reporter: Pierre Smits >Priority: Major > > see > https://demo-trunk.ofbiz.apache.org/accounting/control/invoiceOverview?invoiceId=demo10001 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OFBIZ-13017) invoiceOverview generates an error
[ https://issues.apache.org/jira/browse/OFBIZ-13017?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17838031#comment-17838031 ] Mekika Leila commented on OFBIZ-13017: -- Hello [~jleroux] and [~pierresmits], [~pierresmits] about your remarks, I also think that there is something that can be done with the menus but I didn't find the way to move it without impacting the AR/AP component (I didn't know then that they were to be remove) For the uri, it was my first thought to create new controller requests for 'entry point' but it would mean that we will have to keep both versions of the "same" screens and forms, so there was no more 'code reducing'. The goal was also to be transparent for the users (if you checkout the trunk at commit 'c7333c0c93940a8bfeaab78e282a447755be8ab8' you will see that the screens remained as close as possible as the previous ones. So are the controller request) If you both agree, I think the discussion can be pursued on jira OFBIZ-12994 instead of this one. For the current invoiceOverview screen error, I propose to work on a PR to resolve the conflicts between the three jiras. Tell me if you are interested > invoiceOverview generates an error > -- > > Key: OFBIZ-13017 > URL: https://issues.apache.org/jira/browse/OFBIZ-13017 > Project: OFBiz > Issue Type: Bug > Components: accounting >Reporter: Pierre Smits >Priority: Major > > see > https://demo-trunk.ofbiz.apache.org/accounting/control/invoiceOverview?invoiceId=demo10001 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OFBIZ-13017) invoiceOverview generates an error
[ https://issues.apache.org/jira/browse/OFBIZ-13017?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17837785#comment-17837785 ] Pierre Smits commented on OFBIZ-13017: -- Thanks for the reaction, [~jleroux] I would like to see the viewpoint of the (other) Nereide team-members also, given that they are the driving force behind this. > invoiceOverview generates an error > -- > > Key: OFBIZ-13017 > URL: https://issues.apache.org/jira/browse/OFBIZ-13017 > Project: OFBiz > Issue Type: Bug > Components: accounting >Reporter: Pierre Smits >Priority: Major > > see > https://demo-trunk.ofbiz.apache.org/accounting/control/invoiceOverview?invoiceId=demo10001 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OFBIZ-13017) invoiceOverview generates an error
[ https://issues.apache.org/jira/browse/OFBIZ-13017?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17837757#comment-17837757 ] Jacques Le Roux commented on OFBIZ-13017: - Thanks Pierre, I'll evaluate your proposed solutions as soon as I'll get enough time. > invoiceOverview generates an error > -- > > Key: OFBIZ-13017 > URL: https://issues.apache.org/jira/browse/OFBIZ-13017 > Project: OFBiz > Issue Type: Bug > Components: accounting >Reporter: Pierre Smits >Priority: Major > > see > https://demo-trunk.ofbiz.apache.org/accounting/control/invoiceOverview?invoiceId=demo10001 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OFBIZ-13017) invoiceOverview generates an error
[ https://issues.apache.org/jira/browse/OFBIZ-13017?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17837756#comment-17837756 ] Jacques Le Roux commented on OFBIZ-13017: - Thanks for the analysis and proposition Leila, I have not much time today, but I'll get back to it ASAP. > invoiceOverview generates an error > -- > > Key: OFBIZ-13017 > URL: https://issues.apache.org/jira/browse/OFBIZ-13017 > Project: OFBiz > Issue Type: Bug > Components: accounting >Reporter: Pierre Smits >Priority: Major > > see > https://demo-trunk.ofbiz.apache.org/accounting/control/invoiceOverview?invoiceId=demo10001 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OFBIZ-13017) invoiceOverview generates an error
[ https://issues.apache.org/jira/browse/OFBIZ-13017?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17837671#comment-17837671 ] Pierre Smits commented on OFBIZ-13017: -- On first look I like the modularization (and containment of controller and menu aspects) per screen. But some review in-depth is warranted. > invoiceOverview generates an error > -- > > Key: OFBIZ-13017 > URL: https://issues.apache.org/jira/browse/OFBIZ-13017 > Project: OFBiz > Issue Type: Bug > Components: accounting >Reporter: Pierre Smits >Priority: Major > > see > https://demo-trunk.ofbiz.apache.org/accounting/control/invoiceOverview?invoiceId=demo10001 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OFBIZ-13017) invoiceOverview generates an error
[ https://issues.apache.org/jira/browse/OFBIZ-13017?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17837631#comment-17837631 ] Pierre Smits commented on OFBIZ-13017: -- Hi [~mleila], [~jleroux] First of all, my apologies if my commits re OFBIZ-12966 and OFBIZ-13011 somehow reverted your commit(s) re invoiceOverview. It was NOT intentional. Given that we, since latest release and existing release branch(es), have gotten a lot of improvements regarding menu parameterization, VIEW-permission and other UI aspect in the main branch, may I suggest that we implement a (temporary) way to see both variants? I currently identify 2 options: # the CPD approach in a new feature branch to assess impact, with associated tickets regarding improvements; # have a new uri (for the CPD approach pointing to the main CPD invoice screen (named Invoice? Some of these CPD improvements I could identify after a cursory review, could be: * removal of the FindInvoicesMenuBar, as the search/Find feature is already available via the MainAppBar, and the AccountingInvoiceCreate menu item is already available in the MainActionMenu * further parameterization of hard-coded paths (and/or application of portlets) * simplification of file names (e.g. remove the 'Accounting' element) * move of the files from the Accounting subfolder to the widget folder * reduction of blank lines in the files As the CPD introduces a paradigm shift, and I have been told extensively and quite vehemently that even field title changes are forbidden because it breaks down-stream implementations, I wonder how we square this. > invoiceOverview generates an error > -- > > Key: OFBIZ-13017 > URL: https://issues.apache.org/jira/browse/OFBIZ-13017 > Project: OFBiz > Issue Type: Bug > Components: accounting >Reporter: Pierre Smits >Priority: Major > > see > https://demo-trunk.ofbiz.apache.org/accounting/control/invoiceOverview?invoiceId=demo10001 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OFBIZ-13017) invoiceOverview generates an error
[ https://issues.apache.org/jira/browse/OFBIZ-13017?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17837558#comment-17837558 ] Mekika Leila commented on OFBIZ-13017: -- Thank you for the alert: I check to fix the issue > invoiceOverview generates an error > -- > > Key: OFBIZ-13017 > URL: https://issues.apache.org/jira/browse/OFBIZ-13017 > Project: OFBiz > Issue Type: Bug > Components: accounting >Reporter: Pierre Smits >Priority: Major > > see > https://demo-trunk.ofbiz.apache.org/accounting/control/invoiceOverview?invoiceId=demo10001 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OFBIZ-13017) invoiceOverview generates an error
[ https://issues.apache.org/jira/browse/OFBIZ-13017?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17836969#comment-17836969 ] Jacques Le Roux commented on OFBIZ-13017: - As far as we know OFBIZ-12994 broke this issue, to be confirmed, TIA > invoiceOverview generates an error > -- > > Key: OFBIZ-13017 > URL: https://issues.apache.org/jira/browse/OFBIZ-13017 > Project: OFBiz > Issue Type: Bug > Components: accounting >Reporter: Pierre Smits >Priority: Major > > see > https://demo-trunk.ofbiz.apache.org/accounting/control/invoiceOverview?invoiceId=demo10001 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OFBIZ-13017) invoiceOverview generates an error
[ https://issues.apache.org/jira/browse/OFBIZ-13017?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17836938#comment-17836938 ] Jacques Le Roux commented on OFBIZ-13017: - OK, so OFBIZ-12994 broke it. > invoiceOverview generates an error > -- > > Key: OFBIZ-13017 > URL: https://issues.apache.org/jira/browse/OFBIZ-13017 > Project: OFBiz > Issue Type: Bug > Components: accounting >Reporter: Pierre Smits >Priority: Major > > see > https://demo-trunk.ofbiz.apache.org/accounting/control/invoiceOverview?invoiceId=demo10001 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OFBIZ-13017) invoiceOverview generates an error
[ https://issues.apache.org/jira/browse/OFBIZ-13017?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17836934#comment-17836934 ] Pierre Smits commented on OFBIZ-13017: -- History in GitHub shows that https://github.com/apache/ofbiz-framework/commit/c7333c0c93940a8bfeaab78e282a447755be8ab8 replaced working solution with led to the deterioration. I question such commits * without proper context in documentation, * without proper discussion regarding ** code changes required, its impact across applications, and ** benefits and drawbacks in ofbiz-dev as it present a paradigm shift for community members and those who have to do upgrades in their implementations. > invoiceOverview generates an error > -- > > Key: OFBIZ-13017 > URL: https://issues.apache.org/jira/browse/OFBIZ-13017 > Project: OFBiz > Issue Type: Bug > Components: accounting >Reporter: Pierre Smits >Priority: Major > > see > https://demo-trunk.ofbiz.apache.org/accounting/control/invoiceOverview?invoiceId=demo10001 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OFBIZ-13017) invoiceOverview generates an error
[ https://issues.apache.org/jira/browse/OFBIZ-13017?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17836922#comment-17836922 ] Jacques Le Roux commented on OFBIZ-13017: - That error does not exist in next > invoiceOverview generates an error > -- > > Key: OFBIZ-13017 > URL: https://issues.apache.org/jira/browse/OFBIZ-13017 > Project: OFBiz > Issue Type: Bug > Components: accounting >Reporter: Pierre Smits >Priority: Major > > see > https://demo-trunk.ofbiz.apache.org/accounting/control/invoiceOverview?invoiceId=demo10001 -- This message was sent by Atlassian Jira (v8.20.10#820010)
