[jira] [Commented] (OFBIZ-13068) Accounts Payable Past Due Invoices doesn't show outstanding amount

2024-05-30 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-13068?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17850721#comment-17850721
 ] 

ASF subversion and git services commented on OFBIZ-13068:
-

Commit a7afe3ccbd2ce69253fcacca0d8a34c1ec14b4bf in ofbiz-framework's branch 
refs/heads/trunk from Jacques Le Roux
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=a7afe3ccbd ]

Fixed: PartyFinancialHistory shows parentTypeId of invoice, not invoiceTypeId 
(OFBIZ-13068)

Thanks to Deepak's review (much appreciated see
https://lists.apache.org/thread/94xw3rpdr0o44n6sd2s7m250joy4c7q6)
this improves previous commit (6718c46)

This also removes few trailing blanks (Eclipse automation)


> Accounts Payable Past Due Invoices doesn't show outstanding amount
> --
>
> Key: OFBIZ-13068
> URL: https://issues.apache.org/jira/browse/OFBIZ-13068
> Project: OFBiz
>  Issue Type: Bug
>  Components: accounting
>Affects Versions: Upcoming Branch
>Reporter: Pierre Smits
>Assignee: Jacques Le Roux
>Priority: Trivial
> Fix For: Upcoming Branch
>
> Attachments: Image 016.png, Screenshot 2024-04-29 at 11.52.07.png, 
> image-2024-04-29-09-05-28-760.png
>
>
> With recent changes via commit ec0adc02f102d75be15e1ee04062b75621219f0d 
> [ec0adc02f1] the field outstanding got replaced with amountToApply in grid 
> ListApReport.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (OFBIZ-13068) Accounts Payable Past Due Invoices doesn't show outstanding amount

2024-05-30 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-13068?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17850659#comment-17850659
 ] 

ASF subversion and git services commented on OFBIZ-13068:
-

Commit 6718c4645dba7195317de3084cf2a24116f7dfdc in ofbiz-framework's branch 
refs/heads/trunk from Jacques Le Roux
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=6718c4645d ]

Fixed: PartyFinancialHistory shows parentTypeId of invoice, not invoiceTypeId 
(OFBIZ-13068)

This fixes an old bug (at least 8 years)


> Accounts Payable Past Due Invoices doesn't show outstanding amount
> --
>
> Key: OFBIZ-13068
> URL: https://issues.apache.org/jira/browse/OFBIZ-13068
> Project: OFBiz
>  Issue Type: Bug
>  Components: accounting
>Affects Versions: Upcoming Branch
>Reporter: Pierre Smits
>Assignee: Jacques Le Roux
>Priority: Trivial
> Fix For: Upcoming Branch
>
> Attachments: Image 016.png, Screenshot 2024-04-29 at 11.52.07.png, 
> image-2024-04-29-09-05-28-760.png
>
>
> With recent changes via commit ec0adc02f102d75be15e1ee04062b75621219f0d 
> [ec0adc02f1] the field outstanding got replaced with amountToApply in grid 
> ListApReport.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (OFBIZ-13068) Accounts Payable Past Due Invoices doesn't show outstanding amount

2024-04-29 Thread Pierre Smits (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-13068?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17841926#comment-17841926
 ] 

Pierre Smits commented on OFBIZ-13068:
--

Hi Jacques,

Thanks for showing the same screen as I did (from demo-trunk).

The following screen shows with PR#789 merged: 
https://issues.apache.org/jira/secure/attachment/13068529/Image%20016.png
Please scroll to the right to see the difference (the last column).

As was in my original commit 
https://github.com/apache/ofbiz-framework/commit/e740f56701a9e0a970f89415c962ac37ae2d5570
Which got changed with: 
https://github.com/apache/ofbiz-framework/commit/c7230e1006ee18a8c55e8295e57725d78c355e13



> Accounts Payable Past Due Invoices doesn't show outstanding amount
> --
>
> Key: OFBIZ-13068
> URL: https://issues.apache.org/jira/browse/OFBIZ-13068
> Project: OFBiz
>  Issue Type: Bug
>  Components: accounting
>Affects Versions: Upcoming Branch
>Reporter: Pierre Smits
>Assignee: Jacques Le Roux
>Priority: Trivial
> Fix For: Upcoming Branch
>
> Attachments: Image 016.png, Screenshot 2024-04-29 at 11.52.07.png, 
> image-2024-04-29-09-05-28-760.png
>
>
> With recent changes via commit ec0adc02f102d75be15e1ee04062b75621219f0d 
> [ec0adc02f1] the field outstanding got replaced with amountToApply in grid 
> ListApReport.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (OFBIZ-13068) Accounts Payable Past Due Invoices doesn't show outstanding amount

2024-04-29 Thread Jacques Le Roux (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-13068?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17841920#comment-17841920
 ] 

Jacques Le Roux commented on OFBIZ-13068:
-

This is what I see on my screen (image resized). All the information is there, 
no pb at all. !Image 016.png|width=1125,height=353!
And remember it's you that created this screen...

> Accounts Payable Past Due Invoices doesn't show outstanding amount
> --
>
> Key: OFBIZ-13068
> URL: https://issues.apache.org/jira/browse/OFBIZ-13068
> Project: OFBiz
>  Issue Type: Bug
>  Components: accounting
>Affects Versions: Upcoming Branch
>Reporter: Pierre Smits
>Assignee: Jacques Le Roux
>Priority: Trivial
> Fix For: Upcoming Branch
>
> Attachments: Image 016.png, image-2024-04-29-09-05-28-760.png
>
>
> With recent changes via commit ec0adc02f102d75be15e1ee04062b75621219f0d 
> [ec0adc02f1] the field outstanding got replaced with amountToApply in grid 
> ListApReport.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (OFBIZ-13068) Accounts Payable Past Due Invoices doesn't show outstanding amount

2024-04-29 Thread Pierre Smits (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-13068?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17841886#comment-17841886
 ] 

Pierre Smits commented on OFBIZ-13068:
--

I am not joking.

> Accounts Payable Past Due Invoices doesn't show outstanding amount
> --
>
> Key: OFBIZ-13068
> URL: https://issues.apache.org/jira/browse/OFBIZ-13068
> Project: OFBiz
>  Issue Type: Bug
>  Components: accounting
>Affects Versions: Upcoming Branch
>Reporter: Pierre Smits
>Assignee: Jacques Le Roux
>Priority: Trivial
> Fix For: Upcoming Branch
>
> Attachments: image-2024-04-29-09-05-28-760.png
>
>
> With recent changes via commit ec0adc02f102d75be15e1ee04062b75621219f0d 
> [ec0adc02f1] the field outstanding got replaced with amountToApply in grid 
> ListApReport.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (OFBIZ-13068) Accounts Payable Past Due Invoices doesn't show outstanding amount

2024-04-29 Thread Jacques Le Roux (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-13068?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17841883#comment-17841883
 ] 

Jacques Le Roux commented on OFBIZ-13068:
-

OK it's a joke, not a nice one. I have seen your last PR now 
https://github.com/apache/ofbiz-framework/pull/789.
You can keep this issue reopened and I'll not close your PR.

> Accounts Payable Past Due Invoices doesn't show outstanding amount
> --
>
> Key: OFBIZ-13068
> URL: https://issues.apache.org/jira/browse/OFBIZ-13068
> Project: OFBiz
>  Issue Type: Bug
>  Components: accounting
>Affects Versions: Upcoming Branch
>Reporter: Pierre Smits
>Assignee: Jacques Le Roux
>Priority: Trivial
> Fix For: Upcoming Branch
>
> Attachments: image-2024-04-29-09-05-28-760.png
>
>
> With recent changes via commit ec0adc02f102d75be15e1ee04062b75621219f0d 
> [ec0adc02f1] the field outstanding got replaced with amountToApply in grid 
> ListApReport.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (OFBIZ-13068) Accounts Payable Past Due Invoices doesn't show outstanding amount

2024-04-29 Thread Pierre Smits (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-13068?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17841869#comment-17841869
 ] 

Pierre Smits commented on OFBIZ-13068:
--

You're probable looking at the main page of the wrong application. Here is the 
image of the main page of accounting
!image-2024-04-29-09-05-28-760.png!

> Accounts Payable Past Due Invoices doesn't show outstanding amount
> --
>
> Key: OFBIZ-13068
> URL: https://issues.apache.org/jira/browse/OFBIZ-13068
> Project: OFBiz
>  Issue Type: Bug
>  Components: accounting
>Affects Versions: Upcoming Branch
>Reporter: Pierre Smits
>Assignee: Jacques Le Roux
>Priority: Trivial
> Fix For: Upcoming Branch
>
> Attachments: image-2024-04-29-09-05-28-760.png
>
>
> With recent changes via commit ec0adc02f102d75be15e1ee04062b75621219f0d 
> [ec0adc02f1] the field outstanding got replaced with amountToApply in grid 
> ListApReport.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (OFBIZ-13068) Accounts Payable Past Due Invoices doesn't show outstanding amount

2024-04-29 Thread Jacques Le Roux (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-13068?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17841866#comment-17841866
 ] 

Jacques Le Roux commented on OFBIZ-13068:
-

What to you mean? It's visible.

> Accounts Payable Past Due Invoices doesn't show outstanding amount
> --
>
> Key: OFBIZ-13068
> URL: https://issues.apache.org/jira/browse/OFBIZ-13068
> Project: OFBiz
>  Issue Type: Bug
>  Components: accounting
>Affects Versions: Upcoming Branch
>Reporter: Pierre Smits
>Assignee: Jacques Le Roux
>Priority: Trivial
> Fix For: Upcoming Branch
>
>
> With recent changes via commit ec0adc02f102d75be15e1ee04062b75621219f0d 
> [ec0adc02f1] the field outstanding got replaced with amountToApply in grid 
> ListApReport.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (OFBIZ-13068) Accounts Payable Past Due Invoices doesn't show outstanding amount

2024-04-28 Thread Jacques Le Roux (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-13068?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17841688#comment-17841688
 ] 

Jacques Le Roux commented on OFBIZ-13068:
-

It's a pity that, IIRW, you can't express yourself in the dev ML about this 
point.

> Accounts Payable Past Due Invoices doesn't show outstanding amount
> --
>
> Key: OFBIZ-13068
> URL: https://issues.apache.org/jira/browse/OFBIZ-13068
> Project: OFBiz
>  Issue Type: Bug
>  Components: accounting
>Affects Versions: Upcoming Branch
>Reporter: Pierre Smits
>Assignee: Jacques Le Roux
>Priority: Trivial
> Fix For: Upcoming Branch
>
>
> With recent changes via commit ec0adc02f102d75be15e1ee04062b75621219f0d 
> [ec0adc02f1] the field outstanding got replaced with amountToApply in grid 
> ListApReport.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (OFBIZ-13068) Accounts Payable Past Due Invoices doesn't show outstanding amount

2024-04-28 Thread Pierre Smits (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-13068?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17841630#comment-17841630
 ] 

Pierre Smits commented on OFBIZ-13068:
--

Hence my suggestion to put in the 2 new labels for the overviews.

> Accounts Payable Past Due Invoices doesn't show outstanding amount
> --
>
> Key: OFBIZ-13068
> URL: https://issues.apache.org/jira/browse/OFBIZ-13068
> Project: OFBiz
>  Issue Type: Bug
>  Components: accounting
>Affects Versions: Upcoming Branch
>Reporter: Pierre Smits
>Assignee: Jacques Le Roux
>Priority: Trivial
> Fix For: Upcoming Branch
>
>
> With recent changes via commit ec0adc02f102d75be15e1ee04062b75621219f0d 
> [ec0adc02f1] the field outstanding got replaced with amountToApply in grid 
> ListApReport.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (OFBIZ-13068) Accounts Payable Past Due Invoices doesn't show outstanding amount

2024-04-28 Thread Pierre Smits (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-13068?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17841610#comment-17841610
 ] 

Pierre Smits commented on OFBIZ-13068:
--

To make OFBiz more user friendly for the non accounting-savvy, we could 
introduce 2 new labels in accounting:
{code:java}

To Pay
 {code}
and
{code:java}

To Receive
 {code}

and apply those labels to the appropriate overview

> Accounts Payable Past Due Invoices doesn't show outstanding amount
> --
>
> Key: OFBIZ-13068
> URL: https://issues.apache.org/jira/browse/OFBIZ-13068
> Project: OFBiz
>  Issue Type: Bug
>  Components: accounting
>Affects Versions: Upcoming Branch
>Reporter: Pierre Smits
>Assignee: Jacques Le Roux
>Priority: Trivial
> Fix For: Upcoming Branch
>
>
> With recent changes via commit ec0adc02f102d75be15e1ee04062b75621219f0d 
> [ec0adc02f1] the field outstanding got replaced with amountToApply in grid 
> ListApReport.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (OFBIZ-13068) Accounts Payable Past Due Invoices doesn't show outstanding amount

2024-04-28 Thread Pierre Smits (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-13068?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17841609#comment-17841609
 ] 

Pierre Smits commented on OFBIZ-13068:
--

Hi Jacques,

Please keep in mind that 'Amount to apply' is only applicable for payments, and 
not for invoices.

As the screenlets in two overviews in Accounting main indicate:
 * for Accounts Receivable: the outstanding amount is 'to receive'
 * for Accounts Payable: the outstanding amount is 'to pay'

same applies for the individual invoices in those 2 overviews.

> Accounts Payable Past Due Invoices doesn't show outstanding amount
> --
>
> Key: OFBIZ-13068
> URL: https://issues.apache.org/jira/browse/OFBIZ-13068
> Project: OFBiz
>  Issue Type: Bug
>  Components: accounting
>Affects Versions: Upcoming Branch
>Reporter: Pierre Smits
>Assignee: Jacques Le Roux
>Priority: Trivial
> Fix For: Upcoming Branch
>
>
> With recent changes via commit ec0adc02f102d75be15e1ee04062b75621219f0d 
> [ec0adc02f1] the field outstanding got replaced with amountToApply in grid 
> ListApReport.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (OFBIZ-13068) Accounts Payable Past Due Invoices doesn't show outstanding amount

2024-04-28 Thread Jacques Le Roux (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-13068?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17841608#comment-17841608
 ] 

Jacques Le Roux commented on OFBIZ-13068:
-

Hi Pierre,

I totally agree about what you did with the content of 
https://github.com/apache/ofbiz-framework/commit/e740f56701 in 
AccountingUiLabels.xml.
It was a good initiative to differentiate the terms used for AP and AR. With 
the 2 last commits at OFBIZ-13063 I slightly changed things.

About the last commit above, at least in French there is a difference between 
invoice incoming and outcoming money. For incoming we use "Encours" for 
outcoming it should be "Solde dû". I just committed a change for the last. 

So we need to differentiate  <> from <>. I don't 
know for other languages. But at least I see that for nl something else than 
"Outstanding amount" is used: "Nog toe te wijzen" (translate to "Reste à 
attribuer" in French). According to Google Translate "Verschuldigd evenwicht" 
would be better.

So no, I'll not revert. We need the difference in French, and I guess for most 
languages.

> Accounts Payable Past Due Invoices doesn't show outstanding amount
> --
>
> Key: OFBIZ-13068
> URL: https://issues.apache.org/jira/browse/OFBIZ-13068
> Project: OFBiz
>  Issue Type: Bug
>  Components: accounting
>Affects Versions: Upcoming Branch
>Reporter: Pierre Smits
>Assignee: Jacques Le Roux
>Priority: Trivial
> Fix For: Upcoming Branch
>
>
> With recent changes via commit ec0adc02f102d75be15e1ee04062b75621219f0d 
> [ec0adc02f1] the field outstanding got replaced with amountToApply in grid 
> ListApReport.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (OFBIZ-13068) Accounts Payable Past Due Invoices doesn't show outstanding amount

2024-04-25 Thread Pierre Smits (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-13068?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17840804#comment-17840804
 ] 

Pierre Smits commented on OFBIZ-13068:
--

HI [~jleroux] 

In the accounting and financial control domain there is no subtle difference 
between Accounts Payable invoices and Accounts Receivable invoice as you 
describe.
In that domain
 # the outstanding amount on invoices in Accounts Payable is the amount of 
money you are owed to pay to others , and
 # the outstanding amount on invoices in Accounts Receivable is the amount of 
money others are owed to pay to you

In both cases the term 'Outstanding' is correct.

I suggest you do a search/find (on e.g google) on:
 # supplier invoice outstanding
 # supplier invoice to apply

I remember we had this discussion about this 'to apply' before.

Please revert this last change:
{code:java}
-        
+        
 {code}
 

> Accounts Payable Past Due Invoices doesn't show outstanding amount
> --
>
> Key: OFBIZ-13068
> URL: https://issues.apache.org/jira/browse/OFBIZ-13068
> Project: OFBiz
>  Issue Type: Bug
>  Components: accounting
>Affects Versions: Upcoming Branch
>Reporter: Pierre Smits
>Assignee: Jacques Le Roux
>Priority: Trivial
> Fix For: Upcoming Branch
>
>
> With recent changes via commit ec0adc02f102d75be15e1ee04062b75621219f0d 
> [ec0adc02f1] the field outstanding got replaced with amountToApply in grid 
> ListApReport.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (OFBIZ-13068) Accounts Payable Past Due Invoices doesn't show outstanding amount

2024-04-25 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-13068?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17840763#comment-17840763
 ] 

ASF subversion and git services commented on OFBIZ-13068:
-

Commit c7230e1006ee18a8c55e8295e57725d78c355e13 in ofbiz-framework's branch 
refs/heads/trunk from Jacques Le Roux
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=c7230e1006 ]

Improved: Accounts Payable Past Due Invoices doesn't show outstanding amount 
(OFBIZ-13068)

There is a subtle difference between "Accounts Receivable" and "Accounts 
Payable"

It's reflected in current AR and AP applications (currently replaced by the main
accounting page, WIP)

For a receivable payment we use "Outstanding amount", for payable payment
we use "Amount to apply"

This fixes it again and for a last time!-


> Accounts Payable Past Due Invoices doesn't show outstanding amount
> --
>
> Key: OFBIZ-13068
> URL: https://issues.apache.org/jira/browse/OFBIZ-13068
> Project: OFBiz
>  Issue Type: Improvement
>  Components: accounting
>Reporter: Pierre Smits
>Priority: Major
>
> With recent changes via commit ec0adc02f102d75be15e1ee04062b75621219f0d 
> [ec0adc02f1] the field outstanding got replaced with amountToApply in grid 
> ListApReport.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (OFBIZ-13068) Accounts Payable Past Due Invoices doesn't show outstanding amount

2024-04-25 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-13068?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17840757#comment-17840757
 ] 

ASF subversion and git services commented on OFBIZ-13068:
-

Commit 0c7823c3bf0f2359f14bab5d7d574847002649f2 in ofbiz-framework's branch 
refs/heads/trunk from Pierre Smits
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=0c7823c3bf ]

Fixed: Accounts Payable Past Due Invoices doesn't show outstanding amount 
(OFBIZ-13068) (#786)

With recent changes via commit ec0adc02f102d75be15e1ee04062b75621219f0d 
[ec0adc02f1] the field outstanding got replaced with amountToApply in grid 
ListApReport.

modified: InvoiceForms.xml
- replaced field amountToApply with outstanding in grid ListApReport
- corrected style of field total and outstanding in grid ListArReport
- corrected style of field total and outstanding in grid ListApReport

> Accounts Payable Past Due Invoices doesn't show outstanding amount
> --
>
> Key: OFBIZ-13068
> URL: https://issues.apache.org/jira/browse/OFBIZ-13068
> Project: OFBiz
>  Issue Type: Improvement
>  Components: accounting
>Reporter: Pierre Smits
>Priority: Major
>
> With recent changes via commit ec0adc02f102d75be15e1ee04062b75621219f0d 
> [ec0adc02f1] the field outstanding got replaced with amountToApply in grid 
> ListApReport.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)