[jira] [Commented] (OFBIZ-7610) Product Price set based on 'Purchase Price Agreement' isn't honored while same is used during ordering
[ https://issues.apache.org/jira/browse/OFBIZ-7610?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16870201#comment-16870201 ] Ankush Upadhyay commented on OFBIZ-7610: [~suraj.khurana], Thanks for the patch review and yes it is better to add check inside the service. I have updated patch by incorporating suggested changes. Please review it and let me know if this looks as expected and if we can commit it. > Product Price set based on 'Purchase Price Agreement' isn't honored while > same is used during ordering > -- > > Key: OFBIZ-7610 > URL: https://issues.apache.org/jira/browse/OFBIZ-7610 > Project: OFBiz > Issue Type: Bug > Components: order >Affects Versions: Trunk, Release Branch 16.11, Release Branch 17.12, > Release Branch 18.12 >Reporter: Swapnil Shah >Assignee: Suraj Khurana >Priority: Major > Attachments: OFBIZ-7610.patch, SA_1.png, SA_2.png, SA_3.png, > SA_4.png, SA_5.png > > > Once any Purchase Agreement is created with supplier for certain products at > pre-determined price, its get successfully transformed into SupplierProduct. > But at the time of Purchase order creation is same agreement is enforced then > agreement prices for products are ignored while setting the price on cart and > eventually on order itself. > Please refer to attached screenshot for reference. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-7610) Product Price set based on 'Purchase Price Agreement' isn't honored while same is used during ordering
[ https://issues.apache.org/jira/browse/OFBIZ-7610?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16843847#comment-16843847 ] Suraj Khurana commented on OFBIZ-7610: -- Hello [~ankush.upadhyay], Your patch looks good to me. IMO, better place to add this check could be inside the service 'getSuppliersForProduct' as other filter condition are already available inside the service. Please share your thoughts on the same. > Product Price set based on 'Purchase Price Agreement' isn't honored while > same is used during ordering > -- > > Key: OFBIZ-7610 > URL: https://issues.apache.org/jira/browse/OFBIZ-7610 > Project: OFBiz > Issue Type: Bug > Components: order >Affects Versions: Trunk, Release Branch 16.11, Release Branch 17.12, > Release Branch 18.12 >Reporter: Swapnil Shah >Assignee: Suraj Khurana >Priority: Major > Attachments: OFBIZ-7610.patch, SA_1.png, SA_2.png, SA_3.png, > SA_4.png, SA_5.png > > > Once any Purchase Agreement is created with supplier for certain products at > pre-determined price, its get successfully transformed into SupplierProduct. > But at the time of Purchase order creation is same agreement is enforced then > agreement prices for products are ignored while setting the price on cart and > eventually on order itself. > Please refer to attached screenshot for reference. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-7610) Product Price set based on 'Purchase Price Agreement' isn't honored while same is used during ordering
[ https://issues.apache.org/jira/browse/OFBIZ-7610?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16727433#comment-16727433 ] Ankush Upadhyay commented on OFBIZ-7610: Thanks Swapnil for reporting this. I debugged into the code and it seems that code is not honouring agreement applied to purchase order. Currently code fetch all supplier product records for given supplier and product and it filters records with condiition minimumOrderQuantity < = ordered quantity and finally sort the records by lastPrice in ascending order and get first record to set the price for this product so it never consider agreementId applied to honour supplier product for which agreement exist. To fix this issue, we can filter product supplier records based on agreementId to honour applied agreement in purchase order. This should apply valid price as per agreement and other existing workflow should work as is like If no agreement applied then code should work as it is working currently, en If minimumOrderQuantity requirement does not match then it should return return error "This product cannot be purchased from the chosen supplier for the given quantity and currency". Above mentioned same behaviour should persist for Quick Lookup screen. > Product Price set based on 'Purchase Price Agreement' isn't honored while > same is used during ordering > -- > > Key: OFBIZ-7610 > URL: https://issues.apache.org/jira/browse/OFBIZ-7610 > Project: OFBiz > Issue Type: Bug > Components: order >Affects Versions: Trunk >Reporter: Swapnil Shah >Assignee: Ankush Upadhyay >Priority: Major > Attachments: SA_1.png, SA_2.png, SA_3.png, SA_4.png, SA_5.png > > > Once any Purchase Agreement is created with supplier for certain products at > pre-determined price, its get successfully transformed into SupplierProduct. > But at the time of Purchase order creation is same agreement is enforced then > agreement prices for products are ignored while setting the price on cart and > eventually on order itself. > Please refer to attached screenshot for reference. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
