[jira] [Commented] (OFBIZ-8858) Unit test case for service - CreateReturnAndItemOrAdjustment

2019-05-25 Thread Mathieu Lirzin (JIRA) 


[ 
https://issues.apache.org/jira/browse/OFBIZ-8858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16848246#comment-16848246
 ] 

Mathieu Lirzin commented on OFBIZ-8858:
---

Hello [~suraj.khurana],I didn't notice any significant performance downside 
when using map literals in Groovy, but I don't have measurements to support 
this impression. :)

> Unit test case for service - CreateReturnAndItemOrAdjustment
> 
>
> Key: OFBIZ-8858
> URL: https://issues.apache.org/jira/browse/OFBIZ-8858
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: order
>Affects Versions: Trunk
>Reporter: Avnindra Sharma
>Assignee: Suraj Khurana
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-8858.patch, OFBIZ-8858.patch
>
>
> Unit test case for service - CreateReturnAndItemOrAdjustment



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (OFBIZ-8858) Unit test case for service - CreateReturnAndItemOrAdjustment

2019-05-25 Thread Suraj Khurana (JIRA) 


[ 
https://issues.apache.org/jira/browse/OFBIZ-8858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16848244#comment-16848244
 ] 

Suraj Khurana commented on OFBIZ-8858:
--

Hi [~mthl],

Thanks for your inputs.
I have no issue with your suggestion, could you please elaborate does it have 
any major impact on performance side as well?

Looking forward to your reply !!

> Unit test case for service - CreateReturnAndItemOrAdjustment
> 
>
> Key: OFBIZ-8858
> URL: https://issues.apache.org/jira/browse/OFBIZ-8858
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: order
>Affects Versions: Trunk
>Reporter: Avnindra Sharma
>Assignee: Suraj Khurana
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-8858.patch, OFBIZ-8858.patch
>
>
> Unit test case for service - CreateReturnAndItemOrAdjustment



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (OFBIZ-8858) Unit test case for service - CreateReturnAndItemOrAdjustment

2019-05-25 Thread Mathieu Lirzin (JIRA) 


[ 
https://issues.apache.org/jira/browse/OFBIZ-8858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16848233#comment-16848233
 ] 

Mathieu Lirzin commented on OFBIZ-8858:
---

I would recommend rewriting the following imperative code
{code:groovy}
Map serviceCtx = [:]
serviceCtx.orderId = 'DEMO10090'
serviceCtx.returnId = '1009'
serviceCtx.userLogin = 
EntityQuery.use(delegator).from('UserLogin').where('userLoginId', 
'system').cache().queryOne()
{code}
in a more declarative way with map literals
{code:groovy}
Map serviceCtx = [
orderId: 'DEMO10090',
returnId: '1009',
userLogin: 
EntityQuery.use(delegator).from('UserLogin').where('userLoginId',  
'system').cache().queryOne()
]
{code}

Thanks

> Unit test case for service - CreateReturnAndItemOrAdjustment
> 
>
> Key: OFBIZ-8858
> URL: https://issues.apache.org/jira/browse/OFBIZ-8858
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: order
>Affects Versions: Trunk
>Reporter: Avnindra Sharma
>Assignee: Suraj Khurana
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-8858.patch, OFBIZ-8858.patch
>
>
> Unit test case for service - CreateReturnAndItemOrAdjustment



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (OFBIZ-8858) Unit test case for service - CreateReturnAndItemOrAdjustment

2019-05-25 Thread Yogesh Naroliya (JIRA) 


[ 
https://issues.apache.org/jira/browse/OFBIZ-8858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16848144#comment-16848144
 ] 

Yogesh Naroliya commented on OFBIZ-8858:


Hello team,
I have updated patch for the unit test of *CreateReturnAndItemOrAdjustment* 
service from XML to DSL. 
Also verified the patch using the following command:
{code:java}
 ./gradlew "ofbiz --test component=order --test suitename=ordertests"
{code}
Please have a look and let me know in case of any concerns.
Thanks in advance !!

> Unit test case for service - CreateReturnAndItemOrAdjustment
> 
>
> Key: OFBIZ-8858
> URL: https://issues.apache.org/jira/browse/OFBIZ-8858
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: order
>Affects Versions: Trunk
>Reporter: Avnindra Sharma
>Assignee: Yogesh Naroliya
>Priority: Minor
> Attachments: OFBIZ-8858.patch, OFBIZ-8858.patch
>
>
> Unit test case for service - CreateReturnAndItemOrAdjustment



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)