[jira] [Commented] (OFBIZ-9323) Remove the birt.tld file and all related files and lines
[ https://issues.apache.org/jira/browse/OFBIZ-9323?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15972439#comment-15972439 ] Jacques Le Roux commented on OFBIZ-9323: I'll remove it in 5 days or so. Following https://eclipse.org/birt/documentation/integrating/viewer-setup.php to https://wiki.eclipse.org/Birt_3.7_Migration_Guide#BIRT_Viewer, I read: bq. *BIRT Viewer:* In addition, the Runtime contains a Java EE AJAX based viewer that uses the Report Engine API to run and render reports and supports pagination, table of contents, and exporting to all supported formats. This viewer is available as a WAR (BIRT.war) or in exploded format (WebViewerExample). Many of the features of the viewer can be customized by modifying JSP fragments and JavaScript files located in the webcontent directory. See below for deployment instructions for the new Viewer. And If I look at https://wiki.eclipse.org/BirtPOJO_Viewer_Tomcat_Deployment, we would clearly need to use the exploded format, and so have EPL v1 source code in OFBiz which is unacceptable (see LEGAL-296) *Note:* We already use Birt 3.7.1, so it seems to me that we already use the POJO viewer. But anyway the Birt viewer is unfortunately a dead end in OFBiz. As I said above we can suggest users to follow the easy steps documented by the Birt project and use the Birt viewer in their own OFBiz instances. > Remove the birt.tld file and all related files and lines > > > Key: OFBIZ-9323 > URL: https://issues.apache.org/jira/browse/OFBIZ-9323 > Project: OFBiz > Issue Type: Task > Components: birt >Affects Versions: Trunk >Reporter: Jacques Le Roux >Assignee: Jacques Le Roux > Fix For: Upcoming Release > > Attachments: OFBIZ-9323.patch > > > After LEGAL-296 and this thread https://s.apache.org/HdLV, it's clear we need > to clean Birt from wrong licensed files and related features. > Hopefully the same will apply to R16.11 branch. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (OFBIZ-9323) Remove the birt.tld file and all related files and lines
[ https://issues.apache.org/jira/browse/OFBIZ-9323?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15972378#comment-15972378 ] Taher Alkhateeb commented on OFBIZ-9323: I am not sure, this needs some homework and studying. I'm quite neck deep working on the plugin system nowadays so to me this is not a priority. Perhaps you can remove it or find other alternatives. > Remove the birt.tld file and all related files and lines > > > Key: OFBIZ-9323 > URL: https://issues.apache.org/jira/browse/OFBIZ-9323 > Project: OFBiz > Issue Type: Task > Components: birt >Affects Versions: Trunk >Reporter: Jacques Le Roux >Assignee: Jacques Le Roux > Fix For: Upcoming Release > > Attachments: OFBIZ-9323.patch > > > After LEGAL-296 and this thread https://s.apache.org/HdLV, it's clear we need > to clean Birt from wrong licensed files and related features. > Hopefully the same will apply to R16.11 branch. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (OFBIZ-9323) Remove the birt.tld file and all related files and lines
[ https://issues.apache.org/jira/browse/OFBIZ-9323?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15972149#comment-15972149 ] Jacques Le Roux commented on OFBIZ-9323: Hi Taher, bq. But is not the new POJO based API still using the EPL v1 license? Actually forget this question. Of course if we can include this new Birt version as a dependency in the birt gradle.build, we don't have to worry about that. So yes it's mostly about the work to upgrade. Anyway in the meantime we need to remove the birt viewer. BTW looking at http://download.eclipse.org/birt/downloads/build.php?build=R-R1-4.6.0-201606072112, I guess it means that we need to update birt-runtime-4.6.0-20160607, add birt-chart-4.6.0-20160607 and adapt the code, right? > Remove the birt.tld file and all related files and lines > > > Key: OFBIZ-9323 > URL: https://issues.apache.org/jira/browse/OFBIZ-9323 > Project: OFBiz > Issue Type: Task > Components: birt >Affects Versions: Trunk >Reporter: Jacques Le Roux >Assignee: Jacques Le Roux > Fix For: Upcoming Release > > Attachments: OFBIZ-9323.patch > > > After LEGAL-296 and this thread https://s.apache.org/HdLV, it's clear we need > to clean Birt from wrong licensed files and related features. > Hopefully the same will apply to R16.11 branch. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (OFBIZ-9323) Remove the birt.tld file and all related files and lines
[ https://issues.apache.org/jira/browse/OFBIZ-9323?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15970457#comment-15970457 ] Jacques Le Roux commented on OFBIZ-9323: Hi Taher, Yes indeed when I create the patch, either with ToirtoiseSvn (as here) or with Subclipse, or even svn di (which is actually used underneath by both before) the removed files are not in the patch. Why is explained here https://stackoverflow.com/questions/12124660/svn-diff-ignoring-deleted-files. But yes, as I have mentionned in the dev ML thread I intend to also remove all concernes files or folders (and their content), ie: birt/template birt/webapp/birt/WEB-INF/attachments birt.tld server-config.wsdd It would be great indeed if we could put back the Birt viewer. But is not the new POJO based API still using the EPL v1 license? Note though that if this is impossible, because of the license, we could still explain in a page in the wiki how to use the Birt viewer, even its both versions... I also read that the Eclipse fundation is working on a v2 of the EPL. But it's only to make it more compatible with the GPL not the ASL. So I see no chances with both EPL license versions to be integrated in an Apache released product. > Remove the birt.tld file and all related files and lines > > > Key: OFBIZ-9323 > URL: https://issues.apache.org/jira/browse/OFBIZ-9323 > Project: OFBiz > Issue Type: Task > Components: birt >Affects Versions: Trunk >Reporter: Jacques Le Roux >Assignee: Jacques Le Roux > Fix For: Upcoming Release > > Attachments: OFBIZ-9323.patch > > > After LEGAL-296 and this thread https://s.apache.org/HdLV, it's clear we need > to clean Birt from wrong licensed files and related features. > Hopefully the same will apply to R16.11 branch. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (OFBIZ-9323) Remove the birt.tld file and all related files and lines
[ https://issues.apache.org/jira/browse/OFBIZ-9323?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15970326#comment-15970326 ] Taher Alkhateeb commented on OFBIZ-9323: Hello, I don't see the removal of the tld file in this patch? It's unfortunate that we are going to remove some of the best demonstration features of eclipse due to this licensing issue, it seems upgrading to the newest version of the viewer might resolve this because the new API is POJO based, but there is some work to do to implement this integration. > Remove the birt.tld file and all related files and lines > > > Key: OFBIZ-9323 > URL: https://issues.apache.org/jira/browse/OFBIZ-9323 > Project: OFBiz > Issue Type: Task > Components: birt >Affects Versions: Trunk >Reporter: Jacques Le Roux >Assignee: Jacques Le Roux > Fix For: Upcoming Release > > Attachments: OFBIZ-9323.patch > > > After LEGAL-296 and this thread https://s.apache.org/HdLV, it's clear we need > to clean Birt from wrong licensed files and related features. > Hopefully the same will apply to R16.11 branch. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
