[jira] [Updated] (OFBIZ-9465) Replace Inline Javascript with External Javascript
[ https://issues.apache.org/jira/browse/OFBIZ-9465?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aditya Sharma updated OFBIZ-9465: - Attachment: OFBIZ-9465.patch Updated patch with respect to changes in OFBIZ-9138 > Replace Inline Javascript with External Javascript > --- > > Key: OFBIZ-9465 > URL: https://issues.apache.org/jira/browse/OFBIZ-9465 > Project: OFBiz > Issue Type: Improvement >Reporter: Aditya Sharma >Assignee: Deepak Dixit > Attachments: OFBIZ-9465_example.patch, OFBIZ-9465.patch, > OFBIZ-9465.patch, OFBIZ-9465.patch > > > As discussed in http://ofbiz.markmail.org/thread/ti54omjdt4fy662m inline > javascript for various macros like renderLookupField, > makeHyperlinkString,shortDateInput etc in HtmlFormMacroLibrary.ftl should be > replaced with a generic code written as external javascript. Generic > Javascript code should be written in OfbizUtil.js and appropriate classes or > identifiers should be used for applying that. Any additional data can be > passed with HTML 5 custom data attribute > (https://www.w3.org/TR/2011/WD-html5-20110525/elements.html#embedding-custom-non-visible-data-with-the-data-attributes). > As suggested by Jacques in https://s.apache.org/y8P1 will introduce > require.js for the split javascript files in a sub-task. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (OFBIZ-9465) Replace Inline Javascript with External Javascript
[ https://issues.apache.org/jira/browse/OFBIZ-9465?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aditya Sharma updated OFBIZ-9465: - Attachment: OFBIZ-9465.patch Updated patch with attribute selector as suggested by Deepak and improved class name of visula-editor. > Replace Inline Javascript with External Javascript > --- > > Key: OFBIZ-9465 > URL: https://issues.apache.org/jira/browse/OFBIZ-9465 > Project: OFBiz > Issue Type: Improvement >Reporter: Aditya Sharma >Assignee: Deepak Dixit >Priority: Major > Attachments: OFBIZ-9465.patch, OFBIZ-9465.patch, OFBIZ-9465.patch, > OFBIZ-9465.patch, OFBIZ-9465_example.patch > > > As discussed in http://ofbiz.markmail.org/thread/ti54omjdt4fy662m inline > javascript for various macros like renderLookupField, > makeHyperlinkString,shortDateInput etc in HtmlFormMacroLibrary.ftl should be > replaced with a generic code written as external javascript. Generic > Javascript code should be written in OfbizUtil.js and appropriate classes or > identifiers should be used for applying that. Any additional data can be > passed with HTML 5 custom data attribute > (https://www.w3.org/TR/2011/WD-html5-20110525/elements.html#embedding-custom-non-visible-data-with-the-data-attributes). > As suggested by Jacques in https://s.apache.org/y8P1 will introduce > require.js for the split javascript files in a sub-task. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (OFBIZ-9465) Replace Inline Javascript with External Javascript
[ https://issues.apache.org/jira/browse/OFBIZ-9465?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aditya Sharma updated OFBIZ-9465: - Attachment: OFBIZ-9465_example.patch Jacques, it seems that OFBIZ-9465_example.patch is partially committed at r1804027. I have updated the example patch. > Replace Inline Javascript with External Javascript > --- > > Key: OFBIZ-9465 > URL: https://issues.apache.org/jira/browse/OFBIZ-9465 > Project: OFBiz > Issue Type: Improvement >Reporter: Aditya Sharma >Assignee: Aditya Sharma >Priority: Major > Attachments: OFBIZ-9465.patch, OFBIZ-9465.patch, OFBIZ-9465.patch, > OFBIZ-9465.patch, OFBIZ-9465_example.patch, OFBIZ-9465_example.patch > > > As discussed in http://ofbiz.markmail.org/thread/ti54omjdt4fy662m inline > javascript for various macros like renderLookupField, > makeHyperlinkString,shortDateInput etc in HtmlFormMacroLibrary.ftl should be > replaced with a generic code written as external javascript. Generic > Javascript code should be written in OfbizUtil.js and appropriate classes or > identifiers should be used for applying that. Any additional data can be > passed with HTML 5 custom data attribute > (https://www.w3.org/TR/2011/WD-html5-20110525/elements.html#embedding-custom-non-visible-data-with-the-data-attributes). > As suggested by Jacques in https://s.apache.org/y8P1 will introduce > require.js for the split javascript files in a sub-task. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (OFBIZ-9465) Replace Inline Javascript with External Javascript
[ https://issues.apache.org/jira/browse/OFBIZ-9465?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacopo Cappellato updated OFBIZ-9465: - Fix Version/s: (was: 17.12.01) > Replace Inline Javascript with External Javascript > --- > > Key: OFBIZ-9465 > URL: https://issues.apache.org/jira/browse/OFBIZ-9465 > Project: OFBiz > Issue Type: Improvement >Reporter: Aditya Sharma >Assignee: Aditya Sharma >Priority: Major > Attachments: OFBIZ-9465.patch, OFBIZ-9465.patch, OFBIZ-9465.patch, > OFBIZ-9465.patch, OFBIZ-9465_example.patch, OFBIZ-9465_example.patch > > > As discussed in http://ofbiz.markmail.org/thread/ti54omjdt4fy662m inline > javascript for various macros like renderLookupField, > makeHyperlinkString,shortDateInput etc in HtmlFormMacroLibrary.ftl should be > replaced with a generic code written as external javascript. Generic > Javascript code should be written in OfbizUtil.js and appropriate classes or > identifiers should be used for applying that. Any additional data can be > passed with HTML 5 custom data attribute > (https://www.w3.org/TR/2011/WD-html5-20110525/elements.html#embedding-custom-non-visible-data-with-the-data-attributes). > As suggested by Jacques in https://s.apache.org/y8P1 will introduce > require.js for the split javascript files in a sub-task. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OFBIZ-9465) Replace Inline Javascript with External Javascript
[ https://issues.apache.org/jira/browse/OFBIZ-9465?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aditya Sharma updated OFBIZ-9465: - Description: As discussed in http://ofbiz.markmail.org/thread/ti54omjdt4fy662m inline javascript for various macros like renderLookupField, makeHyperlinkString,shortDateInput etc in HtmlFormMacroLibrary.ftl should be replaced with a generic code written as external javascript. Generic Javascript code should be written in OfbizUtil.js and appropriate classes or identifiers should be used for applying that. Any additional data can be passed with HTML 5 custom data attribute (https://www.w3.org/TR/2011/WD-html5-20110525/elements.html#embedding-custom-non-visible-data-with-the-data-attributes). As suggested by Jacques in https://s.apache.org/y8P1 will introduce require.js for the split javascript files in a sub-task. was: As discussed in http://ofbiz.markmail.org/thread/ti54omjdt4fy662m inline javascript for various macros like renderLookupField, makeHyperlinkString,shortDateInput etc in HtmlFormMacroLibrary.ftl should be replaced with a generic code written as external javascript. Generic Javascript code should be written in OfbizUtil.js and appropriate classes or identifiers should be used for applying that. Any additional data can be passed with HTML 5 custom data attribute (https://www.w3.org/TR/2011/WD-html5-20110525/elements.html#embedding-custom-non-visible-data-with-the-data-attributes). As suggested by Jacques in https://s.apache.org/y8P1 will introduce require.js for the split javascript files in a sub task. > Replace Inline Javascript with External Javascript > --- > > Key: OFBIZ-9465 > URL: https://issues.apache.org/jira/browse/OFBIZ-9465 > Project: OFBiz > Issue Type: Improvement >Reporter: Aditya Sharma >Assignee: Aditya Sharma > > As discussed in http://ofbiz.markmail.org/thread/ti54omjdt4fy662m inline > javascript for various macros like renderLookupField, > makeHyperlinkString,shortDateInput etc in HtmlFormMacroLibrary.ftl should be > replaced with a generic code written as external javascript. Generic > Javascript code should be written in OfbizUtil.js and appropriate classes or > identifiers should be used for applying that. Any additional data can be > passed with HTML 5 custom data attribute > (https://www.w3.org/TR/2011/WD-html5-20110525/elements.html#embedding-custom-non-visible-data-with-the-data-attributes). > As suggested by Jacques in https://s.apache.org/y8P1 will introduce > require.js for the split javascript files in a sub-task. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (OFBIZ-9465) Replace Inline Javascript with External Javascript
[ https://issues.apache.org/jira/browse/OFBIZ-9465?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aditya Sharma updated OFBIZ-9465: - Description: As discussed in http://ofbiz.markmail.org/thread/ti54omjdt4fy662m inline javascript for various macros like renderLookupField, makeHyperlinkString,shortDateInput etc in HtmlFormMacroLibrary.ftl should be replaced with a generic code written as external javascript. Generic Javascript code should be written in OfbizUtil.js and appropriate classes or identifiers should be used for applying that. Any additional data can be passed with HTML 5 custom data attribute (https://www.w3.org/TR/2011/WD-html5-20110525/elements.html#embedding-custom-non-visible-data-with-the-data-attributes). As suggested by Jacques in https://s.apache.org/y8P1 will introduce require.js for the split javascript files in a sub task. was:As discussed in http://ofbiz.markmail.org/thread/ti54omjdt4fy662m inline javascript for various macros like renderLookupField, makeHyperlinkString,shortDateInput etc in HtmlFormMacroLibrary.ftl should be replaced with a generic code written as external javascript. Generic Javascript code should be written in OfbizUtil.js and appropriate classes or identifiers should be used for applying that. Any additional data can be passed with HTML 5 custom data attribute (https://www.w3.org/TR/2011/WD-html5-20110525/elements.html#embedding-custom-non-visible-data-with-the-data-attributes). > Replace Inline Javascript with External Javascript > --- > > Key: OFBIZ-9465 > URL: https://issues.apache.org/jira/browse/OFBIZ-9465 > Project: OFBiz > Issue Type: Improvement >Reporter: Aditya Sharma >Assignee: Aditya Sharma > > As discussed in http://ofbiz.markmail.org/thread/ti54omjdt4fy662m inline > javascript for various macros like renderLookupField, > makeHyperlinkString,shortDateInput etc in HtmlFormMacroLibrary.ftl should be > replaced with a generic code written as external javascript. Generic > Javascript code should be written in OfbizUtil.js and appropriate classes or > identifiers should be used for applying that. Any additional data can be > passed with HTML 5 custom data attribute > (https://www.w3.org/TR/2011/WD-html5-20110525/elements.html#embedding-custom-non-visible-data-with-the-data-attributes). > As suggested by Jacques in https://s.apache.org/y8P1 will introduce > require.js for the split javascript files in a sub task. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (OFBIZ-9465) Replace Inline Javascript with External Javascript
[ https://issues.apache.org/jira/browse/OFBIZ-9465?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aditya Sharma updated OFBIZ-9465: - Attachment: OFBIZ-9465.patch OFBIZ-9465_example.patch Removed inline code for masking as well as added an example in Form Widget Examples. > Replace Inline Javascript with External Javascript > --- > > Key: OFBIZ-9465 > URL: https://issues.apache.org/jira/browse/OFBIZ-9465 > Project: OFBiz > Issue Type: Improvement >Reporter: Aditya Sharma >Assignee: Aditya Sharma > Attachments: OFBIZ-9465_example.patch, OFBIZ-9465.patch > > > As discussed in http://ofbiz.markmail.org/thread/ti54omjdt4fy662m inline > javascript for various macros like renderLookupField, > makeHyperlinkString,shortDateInput etc in HtmlFormMacroLibrary.ftl should be > replaced with a generic code written as external javascript. Generic > Javascript code should be written in OfbizUtil.js and appropriate classes or > identifiers should be used for applying that. Any additional data can be > passed with HTML 5 custom data attribute > (https://www.w3.org/TR/2011/WD-html5-20110525/elements.html#embedding-custom-non-visible-data-with-the-data-attributes). > As suggested by Jacques in https://s.apache.org/y8P1 will introduce > require.js for the split javascript files in a sub-task. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (OFBIZ-9465) Replace Inline Javascript with External Javascript
[ https://issues.apache.org/jira/browse/OFBIZ-9465?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aditya Sharma updated OFBIZ-9465: - Attachment: OFBIZ-9465.patch Adding a combined patch for mask and elrte (WYSISYG editor) . elrte editor can be tested on following page: [#https://localhost:8443/content/control/findForumMessages?forumGroupId=WebStoreFORUM&forumId=ASK] Steps: 1. Go to Content component (https://localhost:8443/content/control/main). 2. Click on Forum from submenu (https://localhost:8443/content/control/findForumGroups). 3. Click on forums link under Select column (https://localhost:8443/content/control/findForums?forumGroupId=WebStoreFORUM) 4. Click on messages link under Select column (https://localhost:8443/content/control/findForumMessages?forumGroupId=WebStoreFORUM&forumId=ASK) > Replace Inline Javascript with External Javascript > --- > > Key: OFBIZ-9465 > URL: https://issues.apache.org/jira/browse/OFBIZ-9465 > Project: OFBiz > Issue Type: Improvement >Reporter: Aditya Sharma >Assignee: Aditya Sharma > Attachments: OFBIZ-9465_example.patch, OFBIZ-9465.patch, > OFBIZ-9465.patch > > > As discussed in http://ofbiz.markmail.org/thread/ti54omjdt4fy662m inline > javascript for various macros like renderLookupField, > makeHyperlinkString,shortDateInput etc in HtmlFormMacroLibrary.ftl should be > replaced with a generic code written as external javascript. Generic > Javascript code should be written in OfbizUtil.js and appropriate classes or > identifiers should be used for applying that. Any additional data can be > passed with HTML 5 custom data attribute > (https://www.w3.org/TR/2011/WD-html5-20110525/elements.html#embedding-custom-non-visible-data-with-the-data-attributes). > As suggested by Jacques in https://s.apache.org/y8P1 will introduce > require.js for the split javascript files in a sub-task. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
