[GitHub] incubator-rya issue #288: RYA-485 Fixed issues with maven-shade-plugin.
Github user jdasch commented on the issue: https://github.com/apache/incubator-rya/pull/288 asfbot build ---
[GitHub] incubator-rya issue #288: RYA-485 Fixed issues with maven-shade-plugin.
Github user jdasch commented on the issue: https://github.com/apache/incubator-rya/pull/288 asfbot build ---
[GitHub] incubator-rya pull request #288: RYA-485 Fixed issues with maven-shade-plugi...
GitHub user jdasch opened a pull request: https://github.com/apache/incubator-rya/pull/288 RYA-485 Fixed issues with maven-shade-plugin. ## Description - Fixed issues with shade jars being built. - Removed the mr profile for the rya.mapreduce shade jar. Didn't make sense when we were automatically building all of the other shade jars. - fixed an issue where the rpm-maven-plugin didn't have a version. ### Tests N/A [Description of what tests were written] ### Links [Jira](https://issues.apache.org/jira/browse/RYA-485) ### Checklist - [ ] Code Review - [ ] Squash Commits People To Reivew [Add those who should review this] You can merge this pull request into a Git repository by running: $ git pull https://github.com/jdasch/incubator-rya candidate/RYA-485 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-rya/pull/288.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #288 commit b1d4790751b2547d1091687301f4419fe395ebf0 Author: jdasch <hcsadj@...> Date: 2018-04-12T12:41:31Z RYA-485 Fixed issues with maven-shade-plugin. ---
[GitHub] incubator-rya issue #282: RYA-443 Fixed Rya Streams Query Manager RPM versio...
Github user jdasch commented on the issue: https://github.com/apache/incubator-rya/pull/282 Interesting that you included the architecture type as part of the package name. Can you confirm the following command also works? ``` sudo yum install -y rya.streams.query-manager-3.2.13-incubating-0.201803161404-noarch.rpm sudo yum remove rya.streams.query-manager ``` Sigh, I'm looking forward to the day this package is called `rya-streams-query-manager`. ---
[GitHub] incubator-rya pull request #281: POM version fix
GitHub user jdasch opened a pull request: https://github.com/apache/incubator-rya/pull/281 POM version fix ## Description pom versioning bugfix ### Tests N/A People To Reivew @pujav65 @meiercaleb @DLotts You can merge this pull request into a Git repository by running: $ git pull https://github.com/jdasch/incubator-rya candidate/pom-version-fix Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-rya/pull/281.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #281 commit b099ce3b613c39b3e3055a5377c52f17e549ac5e Author: jdasch <hcsadj@...> Date: 2018-03-12T13:59:33Z POM version fix. ---
[GitHub] incubator-rya issue #274: Added giraph profile to resolve an incompatible li...
Github user jdasch commented on the issue: https://github.com/apache/incubator-rya/pull/274 Good idea. I just pinged their dev list. ---
[GitHub] incubator-rya pull request #274: Added giraph profile to resolve an incompat...
GitHub user jdasch opened a pull request: https://github.com/apache/incubator-rya/pull/274 Added giraph profile to resolve an incompatible license issue. ## Description Added a profile to make rya.giraph an optional module in the maven build. ### Tests N/A ### Checklist - [ ] Code Review - [ ] Squash Commits People To Review You can merge this pull request into a Git repository by running: $ git pull https://github.com/jdasch/incubator-rya candidate/giraph-profile Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-rya/pull/274.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #274 commit 5cdfae209d176585b40b7cedede4808ee5de9a22 Author: jdasch <hcsadj@...> Date: 2018-02-13T21:49:10Z Added giraph profile to resolve an incompatible license issue. ---
[GitHub] incubator-rya issue #270: Update readme.md
Github user jdasch commented on the issue: https://github.com/apache/incubator-rya/pull/270 asfbot build ---
[GitHub] incubator-rya pull request #252: RYA-410 Add geo profile dependency manageme...
Github user jdasch commented on a diff in the pull request: https://github.com/apache/incubator-rya/pull/252#discussion_r159702629 --- Diff: pom.xml --- @@ -144,7 +141,83 @@ under the License. true + + +geoindexing + +1.3.0-m1 +0.9.3 +1.13 + + --- End diff -- I'm not sure how I feel about this. On the one hand, it does a nice job of separating out geoindexing specific dependencies out of the dependencyManagement section. But this causes all sorts of eclipse pom parsing errors. These eclipse errors can be resolved by Right-Clicking the maven project, say rya.geo.common, in the Package Explorer: Maven > Select Maven profiles... and checking geoindexing. So that part is trivial enough. My larger concern is we might introduce a different tree of transitive dependencies by changing the project's dependencyManagement in this way, which could cause subtle transitive dependency versioning issues. IE. a non-geo function works one way if built with geoindexing profile, and works another way if not built with the geoindexing profile. Maybe @amihalik can weigh in on this. ---
[GitHub] incubator-rya pull request #256: RYA-414
Github user jdasch commented on a diff in the pull request:
https://github.com/apache/incubator-rya/pull/256#discussion_r159475679
--- Diff:
dao/mongodb.rya/src/main/java/org/apache/rya/mongodb/StatefulMongoDBRdfConfiguration.java
---
@@ -0,0 +1,102 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.rya.mongodb;
+
+import static java.util.Objects.requireNonNull;
+
+import java.util.ArrayList;
+import java.util.List;
+
+import org.apache.hadoop.conf.Configuration;
+
+import com.mongodb.MongoClient;
+
+import edu.umd.cs.findbugs.annotations.DefaultAnnotation;
+import edu.umd.cs.findbugs.annotations.NonNull;
+
+/**
+ * A {@link MongoDBRdfConfiguration} that is used to hold onto state that
is pass into Rya components that accept
+ * {@link Configuration} objects.
+ *
--- End diff --
should be p
---
[GitHub] incubator-rya pull request #256: RYA-414
Github user jdasch commented on a diff in the pull request:
https://github.com/apache/incubator-rya/pull/256#discussion_r159477148
--- Diff:
dao/mongodb.rya/src/main/java/org/apache/rya/mongodb/MongoDBRdfConfiguration.java
---
@@ -92,184 +93,162 @@ public MongoDBRdfConfiguration clone() {
return new MongoDBRdfConfiguration(this);
}
-public Authorizations getAuthorizations() {
-final String[] auths = getAuths();
-if (auths == null || auths.length == 0) {
-return MongoDbRdfConstants.ALL_AUTHORIZATIONS;
-}
-return new Authorizations(auths);
-}
-
/**
- * @return {@code true} if each statement added to the batch writer
should
- * be flushed and written right away to the datastore. {@code false}
if the
- * statements should be queued and written to the datastore when the
queue
- * is full or after enough time has passed without a write.
- * Defaults to {@code true} if nothing is specified.
+ * Set whether the Rya client should spin up an embedded MongoDB
instance and connect to that
+ * or if it should connect to a MongoDB Server that is running
somewhere.
+ *
+ * @param useMock - {@true} to use an embedded Mongo DB instance;
{@code false} to connect to a real server.
*/
-public boolean flushEachUpdate(){
-return getBoolean(CONF_FLUSH_EACH_UPDATE, true);
+public void setUseMock(final boolean useMock) {
+this.setBoolean(USE_MOCK_MONGO, useMock);
}
/**
- * Sets the {@link #CONF_FLUSH_EACH_UPDATE} property of the
configuration.
- * @param flush {@code true} if each statement added to the batch
writer
- * should be flushed and written right away to the datastore. {@code
false}
- * if the statements should be queued and written to the datastore
when the
- * queue is full or after enough time has passed without a write.
+ * Indicates whether the Rya client should spin up an embedded MongoDB
instance and connect to that
+ * or if it should connect to a MongoDB Server that is running
somewhere.
+ *
+ * @return {@true} to use an embedded Mongo DB instance; {@code false}
to connect to a real server.
--- End diff --
javadoc doesn't like {@true}
---
[GitHub] incubator-rya pull request #256: RYA-414
Github user jdasch commented on a diff in the pull request:
https://github.com/apache/incubator-rya/pull/256#discussion_r159477077
--- Diff:
dao/mongodb.rya/src/main/java/org/apache/rya/mongodb/MongoDBRdfConfiguration.java
---
@@ -92,184 +93,162 @@ public MongoDBRdfConfiguration clone() {
return new MongoDBRdfConfiguration(this);
}
-public Authorizations getAuthorizations() {
-final String[] auths = getAuths();
-if (auths == null || auths.length == 0) {
-return MongoDbRdfConstants.ALL_AUTHORIZATIONS;
-}
-return new Authorizations(auths);
-}
-
/**
- * @return {@code true} if each statement added to the batch writer
should
- * be flushed and written right away to the datastore. {@code false}
if the
- * statements should be queued and written to the datastore when the
queue
- * is full or after enough time has passed without a write.
- * Defaults to {@code true} if nothing is specified.
+ * Set whether the Rya client should spin up an embedded MongoDB
instance and connect to that
+ * or if it should connect to a MongoDB Server that is running
somewhere.
+ *
+ * @param useMock - {@true} to use an embedded Mongo DB instance;
{@code false} to connect to a real server.
--- End diff --
javadoc doesn't like {@true}
---
[GitHub] incubator-rya pull request #256: RYA-414
Github user jdasch commented on a diff in the pull request:
https://github.com/apache/incubator-rya/pull/256#discussion_r159484331
--- Diff:
extras/indexing/src/main/java/org/apache/rya/indexing/entity/update/mongo/MongoEntityIndexer.java
---
@@ -39,44 +35,16 @@
*/
@DefaultAnnotation(NonNull.class)
public class MongoEntityIndexer extends BaseEntityIndexer {
-private MongoClient client;
-
-@Override
-public EntityStorage getEntityStorage(final Configuration conf) throws
EntityStorageException {
-final MongoDBRdfConfiguration mongoConf =
(MongoDBRdfConfiguration) conf;
-if (client == null) {
-if(mongoConf.getMongoClient() != null) {
-client = mongoConf.getMongoClient();
-} else {
-client = MongoConnectorFactory.getMongoClient(conf);
-}
-}
-final String ryaInstanceName = new
MongoDBRdfConfiguration(conf).getMongoDBName();
-return new MongoEntityStorage(client, ryaInstanceName);
-}
-
-@Override
-public TypeStorage getTypeStorage(final Configuration conf) {
-final MongoDBRdfConfiguration mongoConf =
(MongoDBRdfConfiguration) conf;
-if (client == null) {
-if(mongoConf.getMongoClient() != null) {
-client = mongoConf.getMongoClient();
-} else {
-client = MongoConnectorFactory.getMongoClient(conf);
-}
-}
-final String ryaInstanceName = new
MongoDBRdfConfiguration(conf).getMongoDBName();
-return new MongoTypeStorage(client, ryaInstanceName);
-}
-
@Override
-public void init() {
-//nothing to init.
+public EntityStorage getEntityStorage() throws EntityStorageException {
+ final StatefulMongoDBRdfConfiguration conf =
super.configuration.get();
+return new MongoEntityStorage(conf.getMongoClient(),
conf.getRyaInstanceName());
}
@Override
-public void setClient(final MongoClient client) {
-this.client = client;
+public TypeStorage getTypeStorage() {
+ final StatefulMongoDBRdfConfiguration conf =
super.configuration.get();
--- End diff --
remove tab character
---
[GitHub] incubator-rya pull request #256: RYA-414
Github user jdasch commented on a diff in the pull request:
https://github.com/apache/incubator-rya/pull/256#discussion_r159484266
--- Diff:
extras/indexing/src/main/java/org/apache/rya/indexing/entity/update/mongo/MongoEntityIndexer.java
---
@@ -39,44 +35,16 @@
*/
@DefaultAnnotation(NonNull.class)
public class MongoEntityIndexer extends BaseEntityIndexer {
-private MongoClient client;
-
-@Override
-public EntityStorage getEntityStorage(final Configuration conf) throws
EntityStorageException {
-final MongoDBRdfConfiguration mongoConf =
(MongoDBRdfConfiguration) conf;
-if (client == null) {
-if(mongoConf.getMongoClient() != null) {
-client = mongoConf.getMongoClient();
-} else {
-client = MongoConnectorFactory.getMongoClient(conf);
-}
-}
-final String ryaInstanceName = new
MongoDBRdfConfiguration(conf).getMongoDBName();
-return new MongoEntityStorage(client, ryaInstanceName);
-}
-
-@Override
-public TypeStorage getTypeStorage(final Configuration conf) {
-final MongoDBRdfConfiguration mongoConf =
(MongoDBRdfConfiguration) conf;
-if (client == null) {
-if(mongoConf.getMongoClient() != null) {
-client = mongoConf.getMongoClient();
-} else {
-client = MongoConnectorFactory.getMongoClient(conf);
-}
-}
-final String ryaInstanceName = new
MongoDBRdfConfiguration(conf).getMongoDBName();
-return new MongoTypeStorage(client, ryaInstanceName);
-}
-
@Override
-public void init() {
-//nothing to init.
+public EntityStorage getEntityStorage() throws EntityStorageException {
+ final StatefulMongoDBRdfConfiguration conf =
super.configuration.get();
--- End diff --
remove tab character
---
[GitHub] incubator-rya pull request #256: RYA-414
Github user jdasch commented on a diff in the pull request: https://github.com/apache/incubator-rya/pull/256#discussion_r159478708 --- Diff: sail/src/main/java/org/apache/rya/rdftriplestore/RdfCloudTripleStore.java --- @@ -2,12 +2,6 @@ import static com.google.common.base.Preconditions.checkNotNull; -import org.openrdf.model.ValueFactory; -import org.openrdf.model.impl.ValueFactoryImpl; -import org.openrdf.sail.SailConnection; -import org.openrdf.sail.SailException; -import org.openrdf.sail.helpers.SailBase; - /* * Licensed to the Apache Software Foundation (ASF) under one --- End diff -- nit. move the header above the package line as was done in other files. ---
[GitHub] incubator-rya pull request #256: RYA-414
Github user jdasch commented on a diff in the pull request:
https://github.com/apache/incubator-rya/pull/256#discussion_r159479656
--- Diff:
extras/rya.geoindexing/geo.mongo/src/test/java/org/apache/rya/indexing/geotemporal/GeoTemporalProviderTest.java
---
@@ -36,7 +36,7 @@
import org.openrdf.model.ValueFactory;
import org.openrdf.model.impl.ValueFactoryImpl;
-public class GeoTemporalProviderTest extends GeoTemporalTestBase {
+public class GeoTemporalProviderTest extends GeoTemporalTestUtils {
--- End diff --
Do we still need to extend GeoTemporalTestUtils if all the functions are
now public static?
---
[GitHub] incubator-rya pull request #256: RYA-414
Github user jdasch commented on a diff in the pull request:
https://github.com/apache/incubator-rya/pull/256#discussion_r159477674
--- Diff:
dao/mongodb.rya/src/main/java/org/apache/rya/mongodb/AbstractMongoDBRdfConfigurationBuilder.java
---
@@ -120,7 +120,7 @@ public B setMongoDBName(String name) {
* Sets MongoDB Collection prefix. This parameter must be set to
connect to
* an instance of MongoDB and will default to "rya_" is no value is
* specified.
- *
+ *
* @param name - name of Collection to connect to
--- End diff --
should be @param prefix
---
[GitHub] incubator-rya pull request #256: RYA-414
Github user jdasch commented on a diff in the pull request:
https://github.com/apache/incubator-rya/pull/256#discussion_r159466471
--- Diff:
dao/mongodb.rya/src/main/java/org/apache/rya/mongodb/StatefulMongoDBRdfConfiguration.java
---
@@ -0,0 +1,102 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.rya.mongodb;
+
+import static java.util.Objects.requireNonNull;
+
+import java.util.ArrayList;
+import java.util.List;
+
+import org.apache.hadoop.conf.Configuration;
+
+import com.mongodb.MongoClient;
+
+import edu.umd.cs.findbugs.annotations.DefaultAnnotation;
+import edu.umd.cs.findbugs.annotations.NonNull;
+
+/**
+ * A {@link MongoDBRdfConfiguration} that is used to hold onto state that
is pass into Rya components that accept
+ * {@link Configuration} objects.
+ *
+ * HACK:
+ * This class is part of a hack to get around how Rya uses reflection to
initialize indexers, optimizers, etc.
--- End diff --
If this is a hack, can you document what the correct solution is, or
reference a JIRA that outlines what needs to change in Rya so this hack can be
removed.
---
[GitHub] incubator-rya pull request #256: RYA-414
Github user jdasch commented on a diff in the pull request:
https://github.com/apache/incubator-rya/pull/256#discussion_r159466978
--- Diff:
dao/mongodb.rya/src/main/java/org/apache/rya/mongodb/EmbeddedMongoFactory.java
---
@@ -79,19 +79,27 @@ private int findRandomOpenPortOnAllLocalInterfaces()
throws IOException {
/**
* Creates a new Mongo connection.
- *
+ *
--- End diff --
add @return
---
[GitHub] incubator-rya pull request #248: RYA-356 Added a Twill App for running the p...
Github user jdasch commented on a diff in the pull request:
https://github.com/apache/incubator-rya/pull/248#discussion_r148546455
--- Diff:
extras/periodic.notification/service/src/main/java/org/apache/rya/periodic/notification/application/PeriodicNotificationApplicationConfiguration.java
---
@@ -85,170 +85,170 @@ public
PeriodicNotificationApplicationConfiguration(Properties props) {
setPrunerThreads(Integer.parseInt(props.getProperty(PRUNER_THREADS,
"1")));
setCoordinatorThreads(Integer.parseInt(props.getProperty(COORDINATOR_THREADS,
"1")));
}
-
+
/**
* Sets the name of the Fluo Application
- * @param fluoAppName
+ * @param fluoAppName
*/
-public void setFluoAppName(String fluoAppName) {
-set(FLUO_APP_NAME, Preconditions.checkNotNull(fluoAppName));
+public void setFluoAppName(final String fluoAppName) {
+set(FLUO_APP_NAME, Objects.requireNonNull(fluoAppName));
--- End diff --
I see what you're saying (bonus points for finding char length irony!), but
the semantics of the public modifier are fixed and known. The method qualifier
could be anything, that's why I prefer to leave it in. Again, it is just a
preference and I'm happy to switch to a static import if this is a sticking
point.
---
[GitHub] incubator-rya pull request #248: RYA-356 Added a Twill App for running the p...
Github user jdasch commented on a diff in the pull request:
https://github.com/apache/incubator-rya/pull/248#discussion_r148272083
--- Diff:
extras/indexing/src/main/java/org/apache/rya/indexing/pcj/matching/AccumuloIndexSetProvider.java
---
@@ -155,9 +152,9 @@ public int size() throws Exception {
*/
private List getAccIndices() throws Exception {
-requireNonNull(conf);
-final String tablePrefix =
requireNonNull(conf.get(RdfCloudTripleStoreConfiguration.CONF_TBL_PREFIX));
-final Connector conn =
requireNonNull(ConfigUtils.getConnector(conf));
+Objects.requireNonNull(conf);
--- End diff --
Nothing really, but I prefer it leave it in for readability. Same as
comment below.
---
[GitHub] incubator-rya pull request #248: RYA-356 Added a Twill App for running the p...
Github user jdasch commented on a diff in the pull request:
https://github.com/apache/incubator-rya/pull/248#discussion_r148271883
--- Diff:
extras/periodic.notification/service/src/main/java/org/apache/rya/periodic/notification/application/PeriodicNotificationApplicationConfiguration.java
---
@@ -85,170 +85,170 @@ public
PeriodicNotificationApplicationConfiguration(Properties props) {
setPrunerThreads(Integer.parseInt(props.getProperty(PRUNER_THREADS,
"1")));
setCoordinatorThreads(Integer.parseInt(props.getProperty(COORDINATOR_THREADS,
"1")));
}
-
+
/**
* Sets the name of the Fluo Application
- * @param fluoAppName
+ * @param fluoAppName
*/
-public void setFluoAppName(String fluoAppName) {
-set(FLUO_APP_NAME, Preconditions.checkNotNull(fluoAppName));
+public void setFluoAppName(final String fluoAppName) {
+set(FLUO_APP_NAME, Objects.requireNonNull(fluoAppName));
--- End diff --
I generally prefer to leave the class name in. For only 7 characters you
get reduced ambiguity and increased readability.
---
[GitHub] incubator-rya pull request #248: RYA-356 Added a Twill App for running the p...
Github user jdasch commented on a diff in the pull request:
https://github.com/apache/incubator-rya/pull/248#discussion_r148271410
--- Diff:
extras/rya.pcj.fluo/pcj.fluo.integration/src/test/java/org/apache/rya/indexing/pcj/fluo/integration/KafkaExportIT.java
---
@@ -92,8 +89,8 @@ public void newResultsExportedTest() throws Exception {
// Create the PCJ in Fluo and load the statements into Rya.
final String pcjId = loadDataAndCreateQuery(sparql, statements);
-FluoITHelper.printFluoTable(super.getFluoConfiguration());
-
+//FluoITHelper.printFluoTable(super.getFluoConfiguration());
--- End diff --
Done.
---
[GitHub] incubator-rya pull request #248: RYA-356 Added a Twill App for running the p...
Github user jdasch commented on a diff in the pull request: https://github.com/apache/incubator-rya/pull/248#discussion_r148271436 --- Diff: extras/rya.benchmark/src/main/config/common.options --- @@ -0,0 +1,39 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +# + --- End diff -- Done. ---
[GitHub] incubator-rya pull request #248: RYA-356 Added a Twill App for running the p...
Github user jdasch commented on a diff in the pull request:
https://github.com/apache/incubator-rya/pull/248#discussion_r148271382
--- Diff:
extras/rya.pcj.fluo/pcj.fluo.integration/src/test/java/org/apache/rya/indexing/pcj/fluo/integration/KafkaExportIT.java
---
@@ -249,10 +246,10 @@ public void average() throws Exception {
// Create the PCJ in Fluo and load the statements into Rya.
final String pcjId = loadDataAndCreateQuery(sparql, statements);
-
-try(FluoClient fluo = new
FluoClientImpl(super.getFluoConfiguration())) {
-FluoITHelper.printFluoTable(fluo);
-}
+
+//try(FluoClient fluo = new
FluoClientImpl(super.getFluoConfiguration())) {
--- End diff --
Done.
---
[GitHub] incubator-rya pull request #248: RYA-356 Added a Twill App for running the p...
GitHub user jdasch opened a pull request: https://github.com/apache/incubator-rya/pull/248 RYA-356 Added a Twill App for running the periodic service ## Description >What Changed? [Brief Description of what changed] ### Tests >Coverage? [Description of what tests were written] ### Links [Jira](https://issues.apache.org/jira/browse/RYA-NUMBER) ### Checklist - [ ] Code Review - [ ] Squash Commits People To Reivew @amihalik @meiercaleb You can merge this pull request into a Git repository by running: $ git pull https://github.com/jdasch/incubator-rya RYA-356 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-rya/pull/248.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #248 commit cb6001d7fe515178742b8233368850fe969b48f0 Author: jdasch <hcs...@gmail.com> Date: 2017-09-07T20:57:13Z RYA-356 Added a Twill App for running the periodic service ---
[GitHub] incubator-rya pull request #244: RYA-358 Added checkstyle policy to build an...
GitHub user jdasch opened a pull request: https://github.com/apache/incubator-rya/pull/244 RYA-358 Added checkstyle policy to build and fixed problems. - Disabled snapshot repos since there are no snapshot dependencies. ## Description A number of classes use incorrect imports. - Added a checkstyle policy that fails the build if incorrect import statements are used - Fixed existing checkstyle violations. - Disabled third party snapshot repositories since this project has no third party snapshot dependencies. This will reduce the number of unnecessary http requests a build will require in some scenarios. ### Tests N/A ### Links [Jira RYA-358](https://issues.apache.org/jira/browse/RYA-358) ### Checklist - [ ] Code Review - [X] Squash Commits People To Reivew @meiercaleb @amihalik You can merge this pull request into a Git repository by running: $ git pull https://github.com/jdasch/incubator-rya RYA-358 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-rya/pull/244.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #244 commit 0c10a98e49de11445d6691f054710640cd1af0c6 Author: jdasch <hcs...@gmail.com> Date: 2017-10-13T02:28:28Z RYA-358 Added checkstyle policy to build and fixed problems. - Disabled snapshot repos since there are no snapshot dependencies. ---
[GitHub] incubator-rya pull request #243: RYA-401 Added findbugs policy to build, fix...
GitHub user jdasch opened a pull request: https://github.com/apache/incubator-rya/pull/243 RYA-401 Added findbugs policy to build, fixed all default charset bugs. ## Description - Added a findbugs policy for default encoding bugs - fixed all default encoding bugs - removed the maven-surefire-plugin's -Dfile.encoding=UTF-8 argLine ### Tests N/A ### Links [Jira RYA-401](https://issues.apache.org/jira/browse/RYA-401) ### Checklist - [ ] Code Review - [X] Squash Commits People To Reivew @meiercaleb @isper3at @amihalik You can merge this pull request into a Git repository by running: $ git pull https://github.com/jdasch/incubator-rya RYA-401 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-rya/pull/243.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #243 commit 55a23084afb9ca8a4f0c93ea9baedb6fbfeaf15c Author: jdasch <hcs...@gmail.com> Date: 2017-10-11T13:10:38Z RYA-401 Added findbugs policy to build, fixed all default charset bugs. - removed the maven-surefire-plugin's -Dfile.encoding=UTF-8 argLine ---
[GitHub] incubator-rya pull request #242: RYA-402 Create Kafka reusable test code pro...
Github user jdasch commented on a diff in the pull request: https://github.com/apache/incubator-rya/pull/242#discussion_r144007026 --- Diff: test/kafka/pom.xml --- @@ -0,0 +1,82 @@ + + +http://maven.apache.org/POM/4.0.0; xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance; xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd;> + + +org.apache.rya +rya.test.parent +3.2.12-incubating-SNAPSHOT + + +4.0.0 +rya.test.kafka + +Apache Rya Test Kafka + +This module contains the Rya Test Kakfa components that help write Kafka +based integration tests. + + + + + +org.apache.kafka +kafka-clients + + + +org.apache.kafka +kafka-clients +test + + + +org.apache.kafka +kafka_2.11 + + +slf4j-log4j12 +org.slf4j + + + + + +org.apache.kafka +kafka_2.11 +test +compile + + +slf4j-log4j12 +org.slf4j + + + + + + +junit +junit +4.12 --- End diff -- Not sure if you still need this version override. If you do, I'll take a wag at it when I tackle RYA-366. ---
[GitHub] incubator-rya issue #241: RYA-333 Added "-P coverage" to generate code cover...
Github user jdasch commented on the issue: https://github.com/apache/incubator-rya/pull/241 asfbot build ---
[GitHub] incubator-rya pull request #241: RYA-333 Added "-P coverage" to generate cod...
Github user jdasch commented on a diff in the pull request: https://github.com/apache/incubator-rya/pull/241#discussion_r143771929 --- Diff: pom.xml --- @@ -151,6 +151,54 @@ under the License. false + + + +coverage --- End diff -- I view code coverage as value added, especially since we are not enforcing a minimum coverage policy right now. There is a minor cost associated with running it and it is conceivable that you might not want to run it as part of the release build. ---
[GitHub] incubator-rya pull request #241: RYA-333 Added "-P coverage" to generate cod...
GitHub user jdasch opened a pull request: https://github.com/apache/incubator-rya/pull/241 RYA-333 Added "-P coverage" to generate code coverage reports. ## Description Added -P coverage for generating a code-coverage report removed unnecessary version override of the mycila license plugin removed unnecessary argLine for the maven-surefire-plugin ### Tests N/A ### Links [Jira RYA-333](https://issues.apache.org/jira/browse/RYA-333) ### Checklist - [ ] Code Review - [X] Squash Commits People To Review @meiercaleb @isper3at @kchilton2 You can merge this pull request into a Git repository by running: $ git pull https://github.com/jdasch/incubator-rya RYA-333 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-rya/pull/241.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #241 commit ed444a567b04746f75bf5f903e22c2d9cc681d28 Author: jdasch <hcs...@gmail.com> Date: 2017-10-10T13:51:51Z RYA-333 Added "-P coverage" to generate code coverage reports. ---
[GitHub] incubator-rya pull request #237: RYA-392-Datetime-Within
Github user jdasch commented on a diff in the pull request:
https://github.com/apache/incubator-rya/pull/237#discussion_r143750533
--- Diff:
common/rya.api/src/main/java/org/apache/rya/api/functions/DateTimeWithinPeriod.java
---
@@ -0,0 +1,130 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */package org.apache.rya.api.functions;
+
+import static com.google.common.base.Preconditions.checkArgument;
+import static com.google.common.base.Preconditions.checkNotNull;
+
+import java.time.Duration;
+import java.time.Instant;
+
+import org.openrdf.model.Literal;
+import org.openrdf.model.URI;
+import org.openrdf.model.Value;
+import org.openrdf.model.ValueFactory;
+import org.openrdf.model.datatypes.XMLDatatypeUtil;
+import org.openrdf.model.vocabulary.FN;
+import org.openrdf.model.vocabulary.XMLSchema;
+import org.openrdf.query.algebra.evaluation.ValueExprEvaluationException;
+import org.openrdf.query.algebra.evaluation.function.Function;
+
+/**
+ * This {@link Function} determines whether two {@link
XMLSchema#DATETIME}s occur within a specified period of time of
+ * one another. The method {@link Function#evaluate(ValueFactory,
Value...)} expects four values, where the first two
+ * values are the datetimes, the third value is an integer indicating the
period, and the fourth value is a URI
+ * indicating the time unit of the period. The URI must be of Type
DurationDescription in the OWL-Time ontology (see
+ * https://www.w3.org/TR/owl-time/;>https://www.w3.org/TR/owl-time/).
Examples of valid time unit URIs can
+ * be found in the class {@link OWLTime} and below
+ *
--- End diff --
Nit: As a user, I'd love a 5th optional argument that allows me to specify
exclusiveness or inclusiveness of the period.
---
[GitHub] incubator-rya pull request #237: RYA-392-Datetime-Within
Github user jdasch commented on a diff in the pull request:
https://github.com/apache/incubator-rya/pull/237#discussion_r143742559
--- Diff:
common/rya.api/src/main/java/org/apache/rya/api/functions/OWLTime.java ---
@@ -0,0 +1,111 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.rya.api.functions;
+
+import static com.google.common.base.Preconditions.checkArgument;
+import static com.google.common.base.Preconditions.checkNotNull;
+
+import java.time.temporal.ChronoUnit;
+import java.util.HashMap;
+import java.util.Map;
+import java.util.Optional;
+
+import org.openrdf.model.URI;
+import org.openrdf.model.ValueFactory;
+import org.openrdf.model.impl.ValueFactoryImpl;
+
+/**
+ * Constants for OWL-Time primitives in the OWL-Time namespace.
+ *
+ */
+public class OWLTime {
+
+private static final ValueFactory FACTORY =
ValueFactoryImpl.getInstance();
+
+/**
+ * Indicates namespace of OWL-Time ontology
+ */
+public static final String NAMESPACE = "http://www.w3.org/2006/time#;;
+/**
+ * Seconds class of type DurationDescription in OWL-Time ontology
+ */
+public static final URI SECONDS_URI = FACTORY.createURI(NAMESPACE,
"seconds");
+/**
+ * Minutes class of type DurationDescription in OWL-Time ontology
+ */
+public static final URI MINUTES_URI = FACTORY.createURI(NAMESPACE,
"minutes");
+/**
+ * Hours class of type DurationDescription in OWL-Time ontology
+ */
+public static final URI HOURS_URI = FACTORY.createURI(NAMESPACE,
"hours");
+/**
+ * Days class of type DurationDescription in OWL-Time ontology
+ */
+public static final URI DAYS_URI = FACTORY.createURI(NAMESPACE,
"days");
+/**
+ * Weeks class of type DurationDescription in OWL-Time ontology
+ */
+public static final URI WEEKS_URI = FACTORY.createURI(NAMESPACE,
"weeks");
+
+private static final Map<URI, ChronoUnit> DURATION_MAP = new
HashMap<>();
+
+static {
+DURATION_MAP.put(SECONDS_URI, ChronoUnit.SECONDS);
+DURATION_MAP.put(MINUTES_URI, ChronoUnit.MINUTES);
+DURATION_MAP.put(HOURS_URI, ChronoUnit.HOURS);
+DURATION_MAP.put(DAYS_URI, ChronoUnit.DAYS);
+DURATION_MAP.put(WEEKS_URI, ChronoUnit.WEEKS);
+}
+
+/**
+ * Verifies whether URI is a valid OWL-Time URI that is supported by
this class.
+ * @param durationURI - OWLTime URI indicating the time unit (not null)
+ * @return - {@code true} if this URI indicates a supported OWLTime
time unit
+ */
+public static boolean isValidDurationType(URI durationURI) {
+checkNotNull(durationURI);
--- End diff --
Nit: add user feedback message in the checkNotNull
---
[GitHub] incubator-rya pull request #237: RYA-392-Datetime-Within
Github user jdasch commented on a diff in the pull request:
https://github.com/apache/incubator-rya/pull/237#discussion_r143742007
--- Diff:
common/rya.api/src/main/java/org/apache/rya/api/functions/OWLTime.java ---
@@ -0,0 +1,111 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.rya.api.functions;
+
+import static com.google.common.base.Preconditions.checkArgument;
+import static com.google.common.base.Preconditions.checkNotNull;
+
+import java.time.temporal.ChronoUnit;
+import java.util.HashMap;
+import java.util.Map;
+import java.util.Optional;
+
+import org.openrdf.model.URI;
+import org.openrdf.model.ValueFactory;
+import org.openrdf.model.impl.ValueFactoryImpl;
+
+/**
+ * Constants for OWL-Time primitives in the OWL-Time namespace.
+ *
+ */
+public class OWLTime {
+
+private static final ValueFactory FACTORY =
ValueFactoryImpl.getInstance();
+
+/**
+ * Indicates namespace of OWL-Time ontology
+ */
+public static final String NAMESPACE = "http://www.w3.org/2006/time#;;
+/**
+ * Seconds class of type DurationDescription in OWL-Time ontology
+ */
+public static final URI SECONDS_URI = FACTORY.createURI(NAMESPACE,
"seconds");
+/**
+ * Minutes class of type DurationDescription in OWL-Time ontology
+ */
+public static final URI MINUTES_URI = FACTORY.createURI(NAMESPACE,
"minutes");
+/**
+ * Hours class of type DurationDescription in OWL-Time ontology
+ */
+public static final URI HOURS_URI = FACTORY.createURI(NAMESPACE,
"hours");
+/**
+ * Days class of type DurationDescription in OWL-Time ontology
+ */
+public static final URI DAYS_URI = FACTORY.createURI(NAMESPACE,
"days");
+/**
+ * Weeks class of type DurationDescription in OWL-Time ontology
+ */
+public static final URI WEEKS_URI = FACTORY.createURI(NAMESPACE,
"weeks");
+
+private static final Map<URI, ChronoUnit> DURATION_MAP = new
HashMap<>();
--- End diff --
Nit: Using an ImmutableMap would make your intent here clearer.
---
[GitHub] incubator-rya issue #239: Rya 398
Github user jdasch commented on the issue: https://github.com/apache/incubator-rya/pull/239 Oh, and this built for me fine. ---
[GitHub] incubator-rya issue #233: RYA-387 Restored Mongo IT's that were not being ex...
Github user jdasch commented on the issue: https://github.com/apache/incubator-rya/pull/233 merged in a2ebefe ---
[GitHub] incubator-rya pull request #233: RYA-387 Restored Mongo IT's that were not b...
Github user jdasch closed the pull request at: https://github.com/apache/incubator-rya/pull/233 ---
[GitHub] incubator-rya issue #239: Rya 398
Github user jdasch commented on the issue: https://github.com/apache/incubator-rya/pull/239 Caleb, RYA-353 handles the Test to IT refactor. ---
[GitHub] incubator-rya issue #239: Rya 398
Github user jdasch commented on the issue: https://github.com/apache/incubator-rya/pull/239 RYA-397 was the rename of mockmongo stuff, RYA-398 was fixing the `MongoEntityIndexTest` ---
[GitHub] incubator-rya issue #238: RYA-397 Renamed MockMongoSingleton/Factory to Embe...
Github user jdasch commented on the issue: https://github.com/apache/incubator-rya/pull/238 Oh, and this builds for me. yay. ---
[GitHub] incubator-rya pull request #237: RYA-392-Datetime-Within
Github user jdasch commented on a diff in the pull request:
https://github.com/apache/incubator-rya/pull/237#discussion_r143051442
--- Diff:
common/rya.api/src/main/java/org/apache/rya/api/functions/DateTimeWithinPeriod.java
---
@@ -0,0 +1,121 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */package org.apache.rya.api.functions;
+
+import org.apache.rya.api.functions.OWLTime.Duration;
+import org.openrdf.model.Literal;
+import org.openrdf.model.URI;
+import org.openrdf.model.Value;
+import org.openrdf.model.ValueFactory;
+import org.openrdf.model.datatypes.XMLDatatypeUtil;
+import org.openrdf.model.vocabulary.FN;
+import org.openrdf.model.vocabulary.XMLSchema;
+import org.openrdf.query.algebra.evaluation.ValueExprEvaluationException;
+import org.openrdf.query.algebra.evaluation.function.Function;
+
+import com.google.common.base.Preconditions;
+
+/**
+ * This {@link Function} determines whether two datetimes occur within a
specified period of time of one another. The
+ * method {@link Function#evaluate(ValueFactory, Value...)} expects four
values, where the first two values are the
+ * datetimes, the third value is an integer indicating the period, and the
fourth value is a URI indicating the time
+ * unit of the period. The URI must be of Type DurationDescription in the
OWL-Time ontology (see
+ * https://www.w3.org/TR/owl-time/;>https://www.w3.org/TR/owl-time/).
Examples of valid time unit URIs
+ * can be found in the class {@link OWLTime} and below
+ *
+ * http://www.w3.org/2006/time#days
+ * http://www.w3.org/2006/time#hours
+ * http://www.w3.org/2006/time#minutes
+ * http://www.w3.org/2006/time#seconds
+ *
+ *
+ */
+public class DateTimeWithinPeriod implements Function {
--- End diff --
Rename `DateTimeWithinPeriod` to `DateTimeWithin`
or
Rename `DateTimeWithinTest` to `DateTimeWithinPeriodTest`
---
[GitHub] incubator-rya pull request #237: RYA-392-Datetime-Within
Github user jdasch commented on a diff in the pull request:
https://github.com/apache/incubator-rya/pull/237#discussion_r143049674
--- Diff:
common/rya.api/src/main/java/org/apache/rya/api/functions/DateTimeWithinPeriod.java
---
@@ -0,0 +1,121 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */package org.apache.rya.api.functions;
+
+import org.apache.rya.api.functions.OWLTime.Duration;
+import org.openrdf.model.Literal;
+import org.openrdf.model.URI;
+import org.openrdf.model.Value;
+import org.openrdf.model.ValueFactory;
+import org.openrdf.model.datatypes.XMLDatatypeUtil;
+import org.openrdf.model.vocabulary.FN;
+import org.openrdf.model.vocabulary.XMLSchema;
+import org.openrdf.query.algebra.evaluation.ValueExprEvaluationException;
+import org.openrdf.query.algebra.evaluation.function.Function;
+
+import com.google.common.base.Preconditions;
+
+/**
+ * This {@link Function} determines whether two datetimes occur within a
specified period of time of one another. The
+ * method {@link Function#evaluate(ValueFactory, Value...)} expects four
values, where the first two values are the
+ * datetimes, the third value is an integer indicating the period, and the
fourth value is a URI indicating the time
+ * unit of the period. The URI must be of Type DurationDescription in the
OWL-Time ontology (see
+ * https://www.w3.org/TR/owl-time/;>https://www.w3.org/TR/owl-time/).
Examples of valid time unit URIs
+ * can be found in the class {@link OWLTime} and below
+ *
+ * http://www.w3.org/2006/time#days
+ * http://www.w3.org/2006/time#hours
+ * http://www.w3.org/2006/time#minutes
+ * http://www.w3.org/2006/time#seconds
+ *
+ *
+ */
+public class DateTimeWithinPeriod implements Function {
+
+private static final String DATE_TIME_WITHIN = "dateTimeWithin";
+
+@Override
+public String getURI() {
+return FN.NAMESPACE.toString() + DATE_TIME_WITHIN;
+}
+
--- End diff --
Change to
```
private static final String FUNCTION_URI = FN.NAMESPACE +
"dateTimeWithin";
@Override
public String getURI() {
return FUNCTION_URI;
}
```
---
[GitHub] incubator-rya pull request #237: RYA-392-Datetime-Within
Github user jdasch commented on a diff in the pull request:
https://github.com/apache/incubator-rya/pull/237#discussion_r143047847
--- Diff:
common/rya.api/src/main/java/org/apache/rya/api/functions/DateTimeWithinPeriod.java
---
@@ -0,0 +1,121 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */package org.apache.rya.api.functions;
+
+import org.apache.rya.api.functions.OWLTime.Duration;
+import org.openrdf.model.Literal;
+import org.openrdf.model.URI;
+import org.openrdf.model.Value;
+import org.openrdf.model.ValueFactory;
+import org.openrdf.model.datatypes.XMLDatatypeUtil;
+import org.openrdf.model.vocabulary.FN;
+import org.openrdf.model.vocabulary.XMLSchema;
+import org.openrdf.query.algebra.evaluation.ValueExprEvaluationException;
+import org.openrdf.query.algebra.evaluation.function.Function;
+
+import com.google.common.base.Preconditions;
+
+/**
+ * This {@link Function} determines whether two datetimes occur within a
specified period of time of one another. The
+ * method {@link Function#evaluate(ValueFactory, Value...)} expects four
values, where the first two values are the
+ * datetimes, the third value is an integer indicating the period, and the
fourth value is a URI indicating the time
+ * unit of the period. The URI must be of Type DurationDescription in the
OWL-Time ontology (see
+ * https://www.w3.org/TR/owl-time/;>https://www.w3.org/TR/owl-time/).
Examples of valid time unit URIs
+ * can be found in the class {@link OWLTime} and below
+ *
+ * http://www.w3.org/2006/time#days
+ * http://www.w3.org/2006/time#hours
+ * http://www.w3.org/2006/time#minutes
+ * http://www.w3.org/2006/time#seconds
+ *
+ *
+ */
+public class DateTimeWithinPeriod implements Function {
+
+private static final String DATE_TIME_WITHIN = "dateTimeWithin";
+
+@Override
+public String getURI() {
+return FN.NAMESPACE.toString() + DATE_TIME_WITHIN;
+}
+
+/**
+ * Determines whether two datetimes occur within a specified period of
time of one another. This method expects four
+ * values, where the first two values are the datetimes, the third
value is an integer indicating the period, and
+ * the fourth value is a URI indicating the time unit of the period.
The URI must be of Type DurationDescription in
+ * the OWL-Time ontology (see https://www.w3.org/TR/owl-time/;>https://www.w3.org/TR/owl-time/).
+ * Examples of valid time unit URIs can be found in the class {@link
OWLTime} and below
+ *
+ * http://www.w3.org/2006/time#days
+ * http://www.w3.org/2006/time#hours
+ * http://www.w3.org/2006/time#minutes
+ * http://www.w3.org/2006/time#seconds
+ *
+ *
+ * @param valueFactory - factory for creating values
+ * @param values - array of Value arguments for this Function.
+ */
+@Override
+public Value evaluate(ValueFactory valueFactory, Value... values)
throws ValueExprEvaluationException {
+
+// general validation of input
+Preconditions.checkArgument(values.length == 4);
--- End diff --
Do you want these to throw a ValueExprEvaluationException in order to
follow the Function interface contract?
---
[GitHub] incubator-rya pull request #237: RYA-392-Datetime-Within
Github user jdasch commented on a diff in the pull request:
https://github.com/apache/incubator-rya/pull/237#discussion_r143046845
--- Diff:
common/rya.api/src/main/java/org/apache/rya/api/functions/DateTimeWithinPeriod.java
---
@@ -0,0 +1,121 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */package org.apache.rya.api.functions;
+
+import org.apache.rya.api.functions.OWLTime.Duration;
+import org.openrdf.model.Literal;
+import org.openrdf.model.URI;
+import org.openrdf.model.Value;
+import org.openrdf.model.ValueFactory;
+import org.openrdf.model.datatypes.XMLDatatypeUtil;
+import org.openrdf.model.vocabulary.FN;
+import org.openrdf.model.vocabulary.XMLSchema;
+import org.openrdf.query.algebra.evaluation.ValueExprEvaluationException;
+import org.openrdf.query.algebra.evaluation.function.Function;
+
+import com.google.common.base.Preconditions;
+
+/**
+ * This {@link Function} determines whether two datetimes occur within a
specified period of time of one another. The
--- End diff --
change to XMLSchema.DATETIME
---
[GitHub] incubator-rya pull request #237: RYA-392-Datetime-Within
Github user jdasch commented on a diff in the pull request: https://github.com/apache/incubator-rya/pull/237#discussion_r143046217 --- Diff: common/rya.api/pom.xml --- @@ -95,5 +95,20 @@ under the License. test + + + +org.apache.rat +apache-rat-plugin + + + + src/main/resources/META-INF/services/org.openrdf.query.algebra.evaluation.function.Function --- End diff -- Remove this. Add the license to the service loader. # is the comment character http://docs.oracle.com/javase/7/docs/api/java/util/ServiceLoader.html ---
[GitHub] incubator-rya issue #238: RYA-397 Renamed MockMongoSingleton/Factory to Embe...
Github user jdasch commented on the issue: https://github.com/apache/incubator-rya/pull/238 Yay! I think you missed a couple classes though. `MongoITBase` and `MongoIndexerDeleteIT` have references. ---
[GitHub] incubator-rya pull request #233: RYA-387 Restored Mongo IT's that were not b...
GitHub user jdasch opened a pull request: https://github.com/apache/incubator-rya/pull/233 RYA-387 Restored Mongo IT's that were not being exercised. ## Description Moved `MongoGeoIndexerFilterIT` and `MongoIndexerDeleteIT` to the `rya.geo.mongo` project from the `rya.geoindexing` project which is now just a pom. These IT's got left behind in a previous PR. ### Tests See Description ### Links [Jira RYA-387](https://issues.apache.org/jira/browse/RYA-387) ### Checklist - [ ] Code Review - [X] Squash Commits People To Reivew @meiercaleb @DLotts @amihalik @isper3at You can merge this pull request into a Git repository by running: $ git pull https://github.com/jdasch/incubator-rya candidate/RYA-387 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-rya/pull/233.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #233 commit f147b0626b1a49a732fbc058fe72e219326fe27d Author: jdasch <hcs...@gmail.com> Date: 2017-10-03T16:43:28Z RYA-387 Restored Mongo IT's that were not being exercised. ---
[GitHub] incubator-rya pull request #227: RYA-372 Excluded org.json:json for incompat...
Github user jdasch commented on a diff in the pull request: https://github.com/apache/incubator-rya/pull/227#discussion_r139505373 --- Diff: extras/rya.giraph/pom.xml --- @@ -35,6 +35,13 @@ under the License. org.apache.giraph giraph-core 1.2.0 + + + +json +org.json + + --- End diff -- This change should be sufficient: ``` org.apache.giraph giraph-core 1.2.0 org.json json org.apache.giraph giraph-accumulo 1.2.0 org.json json ``` ---
[GitHub] incubator-rya issue #229: RYA-373 Make Benchmarks optional by profile
Github user jdasch commented on the issue: https://github.com/apache/incubator-rya/pull/229 asfbot build ---
[GitHub] incubator-rya issue #227: RYA-372 Excluded org.json:json for incompatible li...
Github user jdasch commented on the issue: https://github.com/apache/incubator-rya/pull/227 asfbot build ---
[GitHub] incubator-rya issue #227: RYA-372 Excluded org.json:json for incompatible li...
Github user jdasch commented on the issue: https://github.com/apache/incubator-rya/pull/227 asfbot build ---
[GitHub] incubator-rya issue #227: RYA-372 Excluded org.json:json for incompatible li...
Github user jdasch commented on the issue: https://github.com/apache/incubator-rya/pull/227 asfbot build ---
[GitHub] incubator-rya issue #227: RYA-372 Excluded org.json:json for incompatible li...
Github user jdasch commented on the issue: https://github.com/apache/incubator-rya/pull/227 asfbot build ---
[GitHub] incubator-rya pull request #226: RYA-342 RYA-321 Added documentation on the ...
GitHub user jdasch opened a pull request: https://github.com/apache/incubator-rya/pull/226 RYA-342 RYA-321 Added documentation on the shell and PCJ Updater ## Description Added documentation on the shell and PCJ Updater ### Tests N/A ### Links [Jira RYA-342](https://issues.apache.org/jira/browse/RYA-342) [Jira RYA-321](https://issues.apache.org/jira/browse/RYA-321) ### Checklist - [ ] Code Review - [X] Squash Commits People To Reivew @meiercaleb @amihalik @pujav65 You can merge this pull request into a Git repository by running: $ git pull https://github.com/jdasch/incubator-rya RYA-342_RYA-321 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-rya/pull/226.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #226 commit 25f950af60ae62b3f45767100e4f02f9eec6566c Author: jdasch <hcs...@gmail.com> Date: 2017-09-11T18:47:12Z RYA-342 RYA-321 Added documentation on the shell and PCJ Updater ---
[GitHub] incubator-rya issue #225: RYA-370 Improvements from review of 3.2.11-RC2
Github user jdasch commented on the issue: https://github.com/apache/incubator-rya/pull/225 asfbot build ---
[GitHub] incubator-rya pull request #225: RYA-370 Improvements from review of 3.2.11-...
GitHub user jdasch opened a pull request: https://github.com/apache/incubator-rya/pull/225 RYA-370 Improvements from review of 3.2.11-RC2 ## Description - Fixed a regression on the geoindexing profile in extras/pom.xml - Added a 'rya.' prefix to the new geo.* artifactIds to disambiguate generated artifacts. - Added pluginManagement definition for org.codehaus.mojo:license-maven-plugin for release auditing. - Specified an Xmx value for maven-failsafe-plugin for improved execution environment consistency on hosts with reduced memory. ### Tests N/A, but ITs should run more reliably on reduced memory systems. ### Links [JIRA RYA-370](https://issues.apache.org/jira/browse/RYA-370) ### Checklist - [ ] Code Review - [X] Squash Commits People To Reivew @meiercaleb @amihalik @pujav65 @isper3at @DLotts You can merge this pull request into a Git repository by running: $ git pull https://github.com/jdasch/incubator-rya candidate/RYA-370 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-rya/pull/225.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #225 commit 9142752a282e19a9e4b610d3a2b5eef7d42c3e8d Author: jdasch <hcs...@gmail.com> Date: 2017-09-13T18:23:44Z RYA-370 Improvements from review of 3.2.11-RC2 - Fixed a regression on the geoindexing profile in extras/pom.xml - Added a 'rya.' prefix to the new geo.* artifactIds to disambiguate generated artifacts. - Added pluginManagement definition for org.codehaus.mojo:license-maven-plugin for release auditing. - Specified an Xmx value for maven-failsafe-plugin for improved execution environment consistency on hosts with reduced memory. ---
[GitHub] incubator-rya issue #224: RYA-361 Remove JCalendar library from merge/copy/e...
Github user jdasch commented on the issue: https://github.com/apache/incubator-rya/pull/224 asfbot build ---
[GitHub] incubator-rya pull request #224: RYA-361 Remove JCalendar library from merge...
Github user jdasch commented on a diff in the pull request:
https://github.com/apache/incubator-rya/pull/224#discussion_r137833944
--- Diff:
extras/rya.export/export.client/src/main/java/org/apache/rya/export/client/conf/MergeConfigurationCLI.java
---
@@ -149,7 +145,12 @@ public static MergeToolConfiguration
createConfigurationFromFile(final File conf
throw new MergeConfigurationException("Failed to create a
config based on the provided configuration.", JAXBe);
}
}
-
+/**
+ * returns the time option and makes it required.
+ * This is for API and is not used internally as of v3.2.11
+ * @return
--- End diff --
Add description to return and throws. Make it clear that it returns a time
or throws an exception when no time is configured because time is required.
---
[GitHub] incubator-rya pull request #223: RYA-362 Improved UX for case where create-p...
GitHub user jdasch opened a pull request: https://github.com/apache/incubator-rya/pull/223 RYA-362 Improved UX for case where create-pcj is called without args. ## Description Improved UX for case where create-pcj is called without args. Also updated the order of operations so we fail for insufficient arguments before we prompt for the SPARQL query. ### Tests Added a test case to `RyaAdminCommandsTest` ### Links [Jira RYA-362](https://issues.apache.org/jira/browse/RYA-362) ### Checklist - [ ] Code Review - [X] Squash Commits People To Review @DLotts @meiercaleb @amihalik @pujav65 You can merge this pull request into a Git repository by running: $ git pull https://github.com/jdasch/incubator-rya RYA-362 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-rya/pull/223.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #223 commit 0d00743a7ecb8e3d87ebc008b74d2b416231c438 Author: jdasch <hcs...@gmail.com> Date: 2017-09-07T14:14:18Z RYA-362 Improved UX for case where create-pcj is called without args. ---
[GitHub] incubator-rya pull request #222: [WIP] RYA-360 Fixed licensing issues.
GitHub user jdasch opened a pull request: https://github.com/apache/incubator-rya/pull/222 [WIP] RYA-360 Fixed licensing issues. ## Description Corrected Copyright on the NOTICE file. Fixed a license header. Renamed some occurrences of Rya to Apache Rya in documentation. ### Tests N/A ### Links [Jira RYA-360](https://issues.apache.org/jira/browse/RYA-360) ### Checklist - [ ] Code Review - [X] Squash Commits People To Reivew You can merge this pull request into a Git repository by running: $ git pull https://github.com/jdasch/incubator-rya RYA-360 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-rya/pull/222.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #222 commit 13d76e1aaf702beed57432d5859263bd1bf859b2 Author: jdasch <hcs...@gmail.com> Date: 2017-09-06T17:56:59Z RYA-360 Fixed licensing issues. Corrected Copyright on the NOTICE file. Fixed a license header. Renamed some occurrences of Rya to Apache Rya in documentation. ---
[GitHub] incubator-rya issue #221: RYA-355 Refactored the periodic notification servi...
Github user jdasch commented on the issue: https://github.com/apache/incubator-rya/pull/221 asfbot build ---
[GitHub] incubator-rya pull request #221: RYA-355 Refactored the periodic notificatio...
GitHub user jdasch opened a pull request: https://github.com/apache/incubator-rya/pull/221 RYA-355 Refactored the periodic notification service structure. ## Description New artifactIds align better with code packaging, semantics. Light pom cleaning. Eliminates redundant text in file paths. Makes adding the twill app for RYA-356 a little cleaner. ### Tests N/A ### Links [Jira RYA-355](https://issues.apache.org/jira/browse/RYA-355) ### Checklist - [ ] Code Review - [X] Squash Commits People To Reivew @meiercaleb @isper3at @amihalik You can merge this pull request into a Git repository by running: $ git pull https://github.com/jdasch/incubator-rya candidate/RYA-355 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-rya/pull/221.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #221 commit ba3aa38d0da26aa1cdf2b4c79799b544cb14b146 Author: jdasch <hcs...@gmail.com> Date: 2017-09-02T00:51:25Z RYA-355 Refactored the periodic notification service structure. New artifactIds align better with code packaging, semantics. Light pom cleaning. Eliminates redundant text in file paths. Makes adding the twill app for RYA-356 a little cleaner. ---
[GitHub] incubator-rya pull request #220: Rya 319
Github user jdasch commented on a diff in the pull request:
https://github.com/apache/incubator-rya/pull/220#discussion_r136645046
--- Diff:
common/rya.api/src/main/java/org/apache/rya/api/client/CreatePeriodicPCJ.java
---
@@ -0,0 +1,39 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.rya.api.client;
+
+/**
+ * This class creates new PeriodicPCJ for a given Rya instance.
+ */
+public interface CreatePeriodicPCJ {
+
+/**
+ * Creates a new PeriodicPCJ for a given Rya instance. The provided
periodicTopic and bootStrapServers are used for
+ * registering new PeriodiNotifications with the underlying
notification registration service. Typically, the
+ * bootStrapServers are the IP for the KafkaBrokers.
+ *
+ * @param instanceName - Rya instance to connect to
+ * @param sparql - SPARQL query registered with the Periodic Service
+ * @param periodicTopic - Kafka topic that new PeriodicNotifications
are exported to for registration witht the
--- End diff --
Still seeing this on github. did it get fixed?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rya pull request #220: Rya 319
Github user jdasch commented on a diff in the pull request:
https://github.com/apache/incubator-rya/pull/220#discussion_r136571851
--- Diff:
extras/indexing/src/main/java/org/apache/rya/api/client/accumulo/AccumuloListIncrementalQueries.java
---
@@ -0,0 +1,97 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.rya.api.client.accumulo;
+
+import static java.util.Objects.requireNonNull;
+
+import java.util.List;
+
+import org.apache.accumulo.core.client.Connector;
+import org.apache.fluo.api.client.FluoClient;
+import org.apache.rya.api.client.GetInstanceDetails;
+import org.apache.rya.api.client.InstanceDoesNotExistException;
+import org.apache.rya.api.client.ListIncrementalQueries;
+import org.apache.rya.api.client.RyaClientException;
+import org.apache.rya.api.instance.RyaDetails;
+import org.apache.rya.api.instance.RyaDetails.PCJIndexDetails;
+import org.apache.rya.api.instance.RyaDetails.PCJIndexDetails.FluoDetails;
+import org.apache.rya.indexing.pcj.fluo.api.ListFluoQueries;
+
+import com.google.common.base.Joiner;
+import com.google.common.base.Optional;
+
+public class AccumuloListIncrementalQueries extends AccumuloCommand
implements ListIncrementalQueries {
--- End diff --
Did you want to add: @DefaultAnnotation(NonNull.class)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rya pull request #220: Rya 319
Github user jdasch commented on a diff in the pull request:
https://github.com/apache/incubator-rya/pull/220#discussion_r136571283
--- Diff:
extras/indexing/src/main/java/org/apache/rya/api/client/accumulo/AccumuloDeletePeriodicPCJ.java
---
@@ -0,0 +1,131 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.rya.api.client.accumulo;
+
+import static java.util.Objects.requireNonNull;
+
+import java.util.Properties;
+
+import org.apache.accumulo.core.client.Connector;
+import org.apache.fluo.api.client.FluoClient;
+import org.apache.kafka.clients.producer.KafkaProducer;
+import org.apache.kafka.clients.producer.ProducerConfig;
+import org.apache.kafka.common.serialization.StringSerializer;
+import org.apache.rya.api.client.DeletePeriodicPCJ;
+import org.apache.rya.api.client.GetInstanceDetails;
+import org.apache.rya.api.client.InstanceDoesNotExistException;
+import org.apache.rya.api.client.RyaClientException;
+import org.apache.rya.api.instance.RyaDetails;
+import org.apache.rya.api.instance.RyaDetails.PCJIndexDetails;
+import org.apache.rya.api.instance.RyaDetails.PCJIndexDetails.FluoDetails;
+import org.apache.rya.indexing.pcj.fluo.api.DeletePeriodicQuery;
+import
org.apache.rya.indexing.pcj.fluo.api.DeletePeriodicQuery.QueryDeletionException;
+import
org.apache.rya.indexing.pcj.fluo.app.query.UnsupportedQueryException;
+import org.apache.rya.indexing.pcj.storage.PeriodicQueryResultStorage;
+import
org.apache.rya.indexing.pcj.storage.accumulo.AccumuloPeriodicQueryResultStorage;
+import org.apache.rya.periodic.notification.api.PeriodicNotificationClient;
+import
org.apache.rya.periodic.notification.notification.CommandNotification;
+import
org.apache.rya.periodic.notification.registration.KafkaNotificationRegistrationClient;
+import
org.apache.rya.periodic.notification.serialization.CommandNotificationSerializer;
+import org.openrdf.query.MalformedQueryException;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import com.google.common.base.Optional;
+
+public class AccumuloDeletePeriodicPCJ extends AccumuloCommand implements
DeletePeriodicPCJ {
+private static final Logger log =
LoggerFactory.getLogger(AccumuloDeletePCJ.class);
+
+private final GetInstanceDetails getInstanceDetails;
+
+/**
+ * Constructs an instance of {@link AccumuloDeletePeriodicPCJ}.
+ *
+ * @param connectionDetails - Details about the values that were used
to create the connector to the cluster. (not null)
+ * @param connector - Provides programmatic access to the instance of
Accumulo that hosts Rya instance. (not null)
+ */
+public AccumuloDeletePeriodicPCJ(final AccumuloConnectionDetails
connectionDetails, final Connector connector) {
+super(connectionDetails, connector);
+getInstanceDetails = new
AccumuloGetInstanceDetails(connectionDetails, connector);
+}
+
+@Override
+public void deletePeriodicPCJ(final String instanceName, final String
pcjId, String topic, String brokers) throws InstanceDoesNotExistException,
RyaClientException {
+requireNonNull(instanceName);
+requireNonNull(pcjId);
+
+final Optional originalDetails =
getInstanceDetails.getDetails(instanceName);
+final boolean ryaInstanceExists = originalDetails.isPresent();
+if(!ryaInstanceExists) {
+throw new InstanceDoesNotExistException(String.format("The
'%s' instance of Rya does not exist.", instanceName));
+}
+
+final boolean pcjIndexingEnabled =
originalDetails.get().getPCJIndexDetails().isEnabled();
+if(!pcjIndexingEnabled) {
+throw new RyaClientException(String.format("The '%s' instance
of Rya does not have PCJ Indexing enabled.", instanceName));
+}
+
+// If the PCJ was being maintained by a F
[GitHub] incubator-rya pull request #220: Rya 319
Github user jdasch commented on a diff in the pull request:
https://github.com/apache/incubator-rya/pull/220#discussion_r136567933
--- Diff:
common/rya.api/src/main/java/org/apache/rya/api/client/CreatePCJ.java ---
@@ -44,7 +44,7 @@
* Application.
*
*/
-public static enum ExportStrategy{RYA, KAFKA, NO_OP_EXPORT};
+public static enum ExportStrategy{RYA_EXPORT, KAFKA_EXPORT,
NO_OP_EXPORT, PERIODIC_EXPORT};
--- End diff --
I feel like the `_EXPORT` suffix is a bit redundant given that the enum is
`ExportStrategy`. Also, the `NO_OP_EXPORT` could probably just be renamed to
`NONE`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rya pull request #220: Rya 319
Github user jdasch commented on a diff in the pull request: https://github.com/apache/incubator-rya/pull/220#discussion_r136359005 --- Diff: extras/rya.periodic.service/periodic.service.api/pom.xml --- @@ -0,0 +1,51 @@ +http://maven.apache.org/POM/4.0.0; xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance; xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd;> + + + 4.0.0 + +org.apache.rya +rya.periodic.service +3.2.11-incubating-SNAPSHOT + + + rya.periodic.service.api + + Apache Rya Periodic Service API + API for Periodic Service Application + + + + + com.google.code.gson + gson + 2.8.0 + compile + + + junit + junit --- End diff -- Should be test scope. Also, this file has tab characters in it. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-rya pull request #182: RYA-324, RYA-272 Geo refactoring and exampl...
Github user jdasch commented on a diff in the pull request: https://github.com/apache/incubator-rya/pull/182#discussion_r135881634 --- Diff: pom.xml --- @@ -137,6 +137,7 @@ under the License. 1.0-1 3.0.4 0.10.0.1 +4.9 --- End diff -- remove this line --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-rya pull request #182: RYA-324, RYA-272 Geo refactoring and exampl...
Github user jdasch commented on a diff in the pull request:
https://github.com/apache/incubator-rya/pull/182#discussion_r135877423
--- Diff:
extras/rya.geoindexing/geo.common/src/main/java/org/apache/rya/indexing/GeoIndexerType.java
---
@@ -31,31 +28,49 @@
/**
* Geo Mesa based indexer.
*/
-GEO_MESA(GeoMesaGeoIndexer.class),
+GEO_MESA("org.apache.rya.indexing.accumulo.geo.GeoMesaGeoIndexer"),
--- End diff --
JIRA didn't exist. Added RYA-354.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rya pull request #182: RYA-324, RYA-272 Geo refactoring and exampl...
Github user jdasch commented on a diff in the pull request: https://github.com/apache/incubator-rya/pull/182#discussion_r135169942 --- Diff: extras/rya.geoindexing/pom.xml --- @@ -62,6 +79,11 @@ org.apache.rya rya.prospector + +net.sf.jopt-simple +jopt-simple --- End diff -- I didn't dig in to see where this is getting used, but can we swap this dependency for JCommander? I'd prefer to standardize on a single CLI Parsing framework, and JCommander is used throughout Rya. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-rya issue #216: Rya-289 Mongo Singleton tests
Github user jdasch commented on the issue: https://github.com/apache/incubator-rya/pull/216 Moved my concerns with this PR to RYA-353 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-rya pull request #216: Rya-289 Mongo Singleton tests
Github user jdasch commented on a diff in the pull request:
https://github.com/apache/incubator-rya/pull/216#discussion_r135040081
--- Diff:
dao/mongodb.rya/src/test/java/org/apache/rya/mongodb/MongoDBRyaDAOIT.java ---
@@ -99,16 +102,16 @@ public void testDelete() throws RyaDAOException,
MongoException, IOException {
builder.setObject(new RyaURI("http://object.com;));
builder.setColumnVisibility(new DocumentVisibility("C").flatten());
final RyaStatement statement = builder.build();
-final MongoDatabase db =
mongoClient.getDatabase(configuration.get(MongoDBRdfConfiguration.MONGO_DB_NAME));
-final MongoCollection coll =
db.getCollection(configuration.getTriplesCollectionName());
+final MongoDatabase db =
client.getDatabase(conf.get(MongoDBRdfConfiguration.MONGO_DB_NAME));
+final MongoCollection coll =
db.getCollection(conf.getTriplesCollectionName());
dao.add(statement);
-assertEquals(coll.count(),1);
+assertEquals(1, coll.count());
-dao.delete(statement, configuration);
+dao.delete(statement, conf);
-assertEquals(coll.count(),0);
+assertEquals(0, coll.count());
--- End diff --
good catch
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rya pull request #216: Rya-289 Mongo Singleton tests
Github user jdasch commented on a diff in the pull request:
https://github.com/apache/incubator-rya/pull/216#discussion_r135036771
--- Diff:
dao/mongodb.rya/src/test/java/org/apache/rya/mongodb/MongoDBRyaDAOIT.java ---
@@ -41,34 +40,38 @@
import org.junit.Before;
import org.junit.Test;
+import com.mongodb.MongoClient;
import com.mongodb.MongoException;
import com.mongodb.client.MongoCollection;
import com.mongodb.client.MongoDatabase;
-public class MongoDBRyaDAOIT extends MongoRyaTestBase {
-
+public class MongoDBRyaDAOIT {
+private MongoClient client;
private MongoDBRyaDAO dao;
-private MongoDBRdfConfiguration configuration;
+private MongoDBRdfConfiguration conf;
+
+private static final String DB_NAME = "testInstance";
@Before
public void setUp() throws IOException, RyaDAOException{
-final Configuration conf = new Configuration();
-conf.set(MongoDBRdfConfiguration.MONGO_DB_NAME, getDbName());
+client = MockMongoSingleton.getInstance();
+client.dropDatabase(DB_NAME);
--- End diff --
I think this client.dropDatabase, and the DB_NAME could be pushed into a
JUnit `@Rule` similar to what RyaTestInstanceRule does. That way we don't
forget to do it if we're using the `@Rule`. Also cuts down on redundant code
in the tests that deals with singleton specific issues.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rya pull request #216: Rya-289 Mongo Singleton tests
Github user jdasch commented on a diff in the pull request:
https://github.com/apache/incubator-rya/pull/216#discussion_r135038577
--- Diff:
extras/indexing/src/test/java/org/apache/rya/indexing/entity/query/EntityQueryNodeTest.java
---
@@ -152,7 +153,7 @@ public void constructor_wrongType() throws Exception {
@Test
public void evaluate_constantSubject() throws Exception {
-final MongoClient client =
MockMongoFactory.newFactory().newMongoClient();
+final MongoClient client = MockMongoSingleton.getInstance();
--- End diff --
I think there could be value to accessing the MongoClient from MongoITBase
(instead of the MockMongoSingleton.getInstance()), or that `@Rule` I mentioned.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rya pull request #216: Rya-289 Mongo Singleton tests
Github user jdasch commented on a diff in the pull request:
https://github.com/apache/incubator-rya/pull/216#discussion_r135039213
--- Diff:
extras/indexing/src/test/java/org/apache/rya/indexing/mongo/MongoFreeTextIndexerTest.java
---
@@ -43,27 +44,36 @@
import org.openrdf.model.vocabulary.RDFS;
import com.google.common.collect.Sets;
+import com.mongodb.MongoClient;
import info.aduna.iteration.CloseableIteration;
-public class MongoFreeTextIndexerTest extends MongoRyaTestBase {
+public class MongoFreeTextIndexerTest {
--- End diff --
Agree. rename to MongoFreeTextIndexerIT
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rya pull request #216: Rya-289 Mongo Singleton tests
Github user jdasch commented on a diff in the pull request:
https://github.com/apache/incubator-rya/pull/216#discussion_r135038884
--- Diff:
extras/indexing/src/test/java/org/apache/rya/indexing/entity/query/EntityQueryNodeTest.java
---
@@ -53,7 +54,7 @@
/**
* Unit tests the methods of {@link EntityQueryNode}.
*/
-public class EntityQueryNodeTest {
+public class EntityQueryNodeTest extends MongoITBase {
--- End diff --
Rename to IT
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rya issue #212: RYA-332 rename integration tests
Github user jdasch commented on the issue: https://github.com/apache/incubator-rya/pull/212 Ditto. Looks good. Just need to fix this test: org.apache.rya.camel.cbsail.CbSailIT.testCbSail --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-rya pull request #214: [WIP] RYA-350 Added EmbeddedKafkaSingleton ...
GitHub user jdasch opened a pull request: https://github.com/apache/incubator-rya/pull/214 [WIP] RYA-350 Added EmbeddedKafkaSingleton and stabilized an IT. ## Description >What Changed? [Brief Description of what changed] ### Tests >Coverage? [Description of what tests were written] ### Links [Jira](https://issues.apache.org/jira/browse/RYA-NUMBER) ### Checklist - [ ] Code Review - [ ] Squash Commits People To Reivew [Add those who should review this] You can merge this pull request into a Git repository by running: $ git pull https://github.com/jdasch/incubator-rya RYA-350 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-rya/pull/214.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #214 commit a885851666942af81ce35ffd0663e3a7eeab Author: jdasch <jdasch@localhost.localdomain> Date: 2017-08-23T03:08:30Z RYA-350 Added EmbeddedKafkaSingleton and stabilized an IT. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-rya pull request #205: RYA-343 Fixed rya.api connection issue for ...
Github user jdasch commented on a diff in the pull request:
https://github.com/apache/incubator-rya/pull/205#discussion_r133458983
--- Diff:
common/rya.api/src/main/java/org/apache/rya/api/instance/RyaDetailsToConfiguration.java
---
@@ -53,14 +53,16 @@ public static void addRyaDetailsToConfiguration(final
RyaDetails details, final
checkAndSet(conf, ConfigurationFields.USE_FREETEXT,
details.getFreeTextIndexDetails().isEnabled());
//RYA-215checkAndSet(conf, ConfigurationFields.USE_GEO,
details.getGeoIndexDetails().isEnabled());
checkAndSet(conf, ConfigurationFields.USE_TEMPORAL,
details.getTemporalIndexDetails().isEnabled());
-PCJIndexDetails pcjDetails = details.getPCJIndexDetails();
- if (pcjDetails.isEnabled() &&
pcjDetails.getFluoDetails().isPresent()) {
- checkAndSet(conf, ConfigurationFields.USE_PCJ_UPDATER,
true);
- conf.set(ConfigurationFields.FLUO_APP_NAME,
pcjDetails.getFluoDetails().get().getUpdateAppName());
- conf.set(ConfigurationFields.PCJ_UPDATER_TYPE, "FLUO");
- } else {
- checkAndSet(conf, ConfigurationFields.USE_PCJ_UPDATER,
false);
- }
+final PCJIndexDetails pcjDetails = details.getPCJIndexDetails();
+if (pcjDetails.isEnabled() &&
pcjDetails.getFluoDetails().isPresent()) {
+checkAndSet(conf, ConfigurationFields.USE_PCJ_UPDATER, true);
+conf.set(ConfigurationFields.FLUO_APP_NAME,
pcjDetails.getFluoDetails().get().getUpdateAppName());
+conf.set(ConfigurationFields.PCJ_UPDATER_TYPE, "FLUO");
+conf.set(ConfigurationFields.PCJ_STORAGE_TYPE, "ACCUMULO");
+} else {
+checkAndSet(conf, ConfigurationFields.USE_PCJ_UPDATER, false);
+conf.set(ConfigurationFields.PCJ_UPDATER_TYPE, "NO_UPDATE");
--- End diff --
I completely agree with you on not using the String literals.
Unfortunately `PrecomputedJoinUpdaterType` is in rya.indexing and
`RyaDetailsToConfiguration` is in rya.api, so I can't access that type. I
believe (could be wrong) that Caleb had the action item to create (or
reference) a JIRA that would enhance the `PCJIndexDetails` class to have a
`PCJIndexDetails.getUpdaterType()` and `PCJIndexDetails.getStorageType()`
methods, or perhaps we might go in some other direction with the implementation.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rya issue #208: fix-mongo-tests
Github user jdasch commented on the issue: https://github.com/apache/incubator-rya/pull/208 asfbot build --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-rya issue #208: fix-mongo-tests
Github user jdasch commented on the issue: https://github.com/apache/incubator-rya/pull/208 asfbot build --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-rya issue #208: fix-mongo-tests
Github user jdasch commented on the issue: https://github.com/apache/incubator-rya/pull/208 asfbot build --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-rya issue #208: fix-mongo-tests
Github user jdasch commented on the issue: https://github.com/apache/incubator-rya/pull/208 asfbot build --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-rya issue #207: RYA-340 Added dependency filtering to rya.pcj.fluo...
Github user jdasch commented on the issue: https://github.com/apache/incubator-rya/pull/207 asfbot build --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-rya pull request #208: fix-mongo-tests
GitHub user jdasch opened a pull request: https://github.com/apache/incubator-rya/pull/208 fix-mongo-tests ## Description MongoGeoTemporalIndexIT and MongoGeoIndexerFilterIT had 5 tests failing between them. Updated to extend MongoITBase. Added unique mongoDBs for isolation. ### Tests MongoGeoTemporalIndexIT and MongoGeoIndexerFilterIT ### Checklist - [ ] Code Review - [ ] Squash Commits People To Reivew @amihalik @meiercaleb You can merge this pull request into a Git repository by running: $ git pull https://github.com/jdasch/incubator-rya fix-mongo-tests Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-rya/pull/208.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #208 commit b2303f7705304851d800f864cb0d46345dac827c Author: jdasch <jdasch@localhost.localdomain> Date: 2017-08-15T20:07:52Z Updated to extend MongoITBase. Added unique mongoDBs for isolation. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-rya pull request #207: RYA-340 Added dependency filtering to rya.p...
GitHub user jdasch opened a pull request: https://github.com/apache/incubator-rya/pull/207 RYA-340 Added dependency filtering to rya.pcj.fluo.app for deployments. ## Description - Added dependency filtering to rya.pcj.fluo.app for deployments. - Also improved scoping of dependencies and dependencyManagement. - Updated integration tests to use -Djava.net.preferIPv4Stack=true. ### Tests Minor IT improvements in pom. No code changes. ### Links [Jira RYA-340](https://issues.apache.org/jira/browse/RYA-340) ### Checklist - [ ] Code Review - [ ] Squash Commits People To Reivew @amihalik @meiercaleb You can merge this pull request into a Git repository by running: $ git pull https://github.com/jdasch/incubator-rya RYA-340 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-rya/pull/207.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #207 commit 17acdce7e3f0a71112e22971943243cfacf3b658 Author: jdasch <jdasch@localhost.localdomain> Date: 2017-08-14T20:18:42Z RYA-340 Added dependency filtering to rya.pcj.fluo.app for deployments. - Also improved scoping of dependencies and dependencyManagement. - Updated integration tests to use -Djava.net.preferIPv4Stack=true. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-rya pull request #205: RYA-343 Fixed rya.api connection issue for ...
GitHub user jdasch opened a pull request: https://github.com/apache/incubator-rya/pull/205 RYA-343 Fixed rya.api connection issue for PCJ-enabled rya table. ## Description Added a couple configs that weren't getting set and caused a regression. Purpose of this PR is to get a fix in place now. We should probably make a new JIRA to ensure this regression is captured by an IT and to expand PCJDetails to store/retrieve this information. ### Tests None. ### Links [Jira: RYA-343](https://issues.apache.org/jira/browse/RYA-343) ### Checklist - [ ] Code Review - [ ] Squash Commits People To Reivew @amihalik @meiercaleb You can merge this pull request into a Git repository by running: $ git pull https://github.com/jdasch/incubator-rya RYA-343 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-rya/pull/205.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #205 commit 81477c5815f3f54a3ccd5d32e87e6692461b32a9 Author: jdasch <jdasch@localhost.localdomain> Date: 2017-08-14T19:21:10Z RYA-343 Fixed rya.api connection issue for PCJ-enabled rya table. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-rya issue #202: [WIP] Rya 331
Github user jdasch commented on the issue: https://github.com/apache/incubator-rya/pull/202 asfbot build --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-rya issue #202: [WIP] Rya 331
Github user jdasch commented on the issue: https://github.com/apache/incubator-rya/pull/202 asfbot build --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-rya issue #202: [WIP] Rya 331
Github user jdasch commented on the issue: https://github.com/apache/incubator-rya/pull/202 asfbot builld --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-rya pull request #202: [WIP] Rya 331
GitHub user jdasch opened a pull request:
https://github.com/apache/incubator-rya/pull/202
[WIP] Rya 331
## Description
>What Changed?
Don't bother reviewing this right now. This PR is just a mechanism for
exercising the build servers.
### Tests
>Coverage?
[Description of what tests were written]
### Links
[Jira](https://issues.apache.org/jira/browse/RYA-NUMBER)
### Checklist
- [ ] Code Review
- [ ] Squash Commits
People To Reivew
[Add those who should review this]
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jdasch/incubator-rya RYA-331
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-rya/pull/202.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #202
commit 5ca17c7e8a832b040a33ee2ce8aa0aabaf5d083e
Author: jdasch <jdasch@localhost.localdomain>
Date: 2017-08-03T14:34:52Z
Improved IntegrationTest stability.
commit f4f4f02db73362bc9eb1997b9a391f5c0c1c5854
Author: jdasch <jdasch@localhost.localdomain>
Date: 2017-08-04T13:44:13Z
stash
commit ddeea3c56d6329a2215c4cc25fba58ddeb7ce4a0
Author: jdasch <jdasch@localhost.localdomain>
Date: 2017-08-04T19:04:49Z
stash
commit ef647ebf56c60d942bf30c3f9eeab43124f47dbb
Author: jdasch <jdasch@localhost.localdomain>
Date: 2017-08-07T12:50:17Z
stash
commit 3072ce496184a6c6b8c141f24b85e39379ef4973
Author: jdasch <jdasch@localhost.localdomain>
Date: 2017-08-07T12:51:12Z
stash
commit 1ac702dd3e5c01b766718d16c2efd726f43e4a14
Author: jdasch <jdasch@localhost.localdomain>
Date: 2017-08-07T15:55:00Z
stash
commit 7d828bd253fe7bf912cfde3b9fadaf74ce920794
Author: jdasch <jdasch@localhost.localdomain>
Date: 2017-08-07T17:34:28Z
added close
commit 10fce8cec5b3a2379b49bf93a2520f335705c183
Author: jdasch <jdasch@localhost.localdomain>
Date: 2017-08-07T17:47:01Z
stash
commit 24eb7cc17dfdec825fa732a4f993da3a0e561c74
Author: jdasch <jdasch@localhost.localdomain>
Date: 2017-08-07T20:28:02Z
stash
commit 26a12828d18d21a682ef0f121a3fb6a6420e6b7c
Author: jdasch <jdasch@localhost.localdomain>
Date: 2017-08-08T15:18:55Z
stash
commit 2b6f9412b3d72a22fee296293011992bbc8200a5
Author: jdasch <jdasch@localhost.localdomain>
Date: 2017-08-08T15:38:16Z
prevented blocking
commit fefc906c1dbfdd90969add65fc5c31b266cd4b9e
Author: jdasch <jdasch@localhost.localdomain>
Date: 2017-08-08T19:41:30Z
stash
commit d69b7db18ed95e7f57a5a182cfad915cb2641cda
Author: jdasch <jdasch@localhost.localdomain>
Date: 2017-08-08T21:00:17Z
stash - needs to be cleaned up.
commit d556f060e9e68f072a5feff394a797ca8e419c54
Author: jdasch <jdasch@localhost.localdomain>
Date: 2017-08-09T03:30:15Z
stash
commit 56c2eec09ebbed482d4dee192dc9e150bca7186d
Author: jdasch <jdasch@localhost.localdomain>
Date: 2017-08-09T12:20:26Z
ignored failing tests
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rya pull request #195: Temp it fix
GitHub user jdasch opened a pull request: https://github.com/apache/incubator-rya/pull/195 Temp it fix ## Description - Updated maven-failsafe-plugin to run IT's in separate forks until RYA-331 is finished. - Removed a duplicate dependency in the rya.pcj.fluo.test.base pom. ### Tests N/A ### Links [Jira](https://issues.apache.org/jira/browse/RYA-NUMBER) ### Checklist - [ ] Code Review - [ ] Squash Commits People To Reivew @amihalik @meiercaleb You can merge this pull request into a Git repository by running: $ git pull https://github.com/jdasch/incubator-rya temp-it-fix Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-rya/pull/195.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #195 commit f65792de57dab17c88125dbf57b7d19af40ff2da Author: jdasch <jdasch@localhost.localdomain> Date: 2017-08-03T20:25:30Z Added a temporary fix until RYA-331 is resolved. commit b4cfff32e52cf119e1b09c67f091fa532821e56d Author: jdasch <jdasch@localhost.localdomain> Date: 2017-08-03T20:26:30Z Removed duplicate dependency definition. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-rya pull request #193: Refactored the rya.periodic.notification.se...
Github user jdasch closed the pull request at: https://github.com/apache/incubator-rya/pull/193 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-rya issue #193: Refactored the rya.periodic.notification.service.
Github user jdasch commented on the issue: https://github.com/apache/incubator-rya/pull/193 Punting until RYA-283 gets merged. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-rya issue #193: Refactored the rya.periodic.notification.service.
Github user jdasch commented on the issue: https://github.com/apache/incubator-rya/pull/193 Mostly my OCD. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-rya pull request #194: RYA-325 Renamed rya.console to rya.shell.
Github user jdasch commented on a diff in the pull request: https://github.com/apache/incubator-rya/pull/194#discussion_r131241480 --- Diff: extras/pom.xml --- @@ -34,7 +34,7 @@ under the License. rya.prospector rya.manual rya.periodic.service -rya.console +shell --- End diff -- It makes filesystem navigation by shell faster and yields shorter, less redundant paths. If that convention was fully expanded, we would end up having: `incubator-rya/rya.extras/rya.shell` which is more rya's than I'd like to type. Does windows still have those long path limitations? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-rya issue #193: Refactored the rya.periodic.notification.service.
Github user jdasch commented on the issue: https://github.com/apache/incubator-rya/pull/193 asfbot build --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-rya pull request #193: Refactored the rya.periodic.notification.se...
GitHub user jdasch opened a pull request: https://github.com/apache/incubator-rya/pull/193 Refactored the rya.periodic.notification.service. ## Description >What Changed? - Light pom cleaning (removed overrides, renaming, wordsmithing) - Set maven-failsave-plugin reuseForks=false until RYA-331 is resolved - Eliminated redundant text in file paths - This makes adding the twill app for RYA-305 a little cleaner. ### Tests >Coverage? N/A ### Links [Jira](https://issues.apache.org/jira/browse/RYA-NUMBER) ### Checklist - [ ] Code Review - [ ] Squash Commits People To Reivew @meiercaleb @amihalik You can merge this pull request into a Git repository by running: $ git pull https://github.com/jdasch/incubator-rya refactored-rya-periodic-service Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-rya/pull/193.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #193 commit e2a26d8b060930c10fd6198a5b64afe85bfeb382 Author: jdasch <jdasch@localhost.localdomain> Date: 2017-08-03T13:47:47Z Refactored the rya.periodic.notification.service. - Light pom cleaning - Set maven-failsave-plugin reuseForks=false until RYA-331 is resolved - Eliminated redundant text in file paths --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-rya issue #182: RYA-324, RYA-272 Geo refactoring and examples
Github user jdasch commented on the issue: https://github.com/apache/incubator-rya/pull/182 Nit on artifact names. Please make them consistent with other artifacts: ``` [INFO] Reactor Build Order: [INFO] [INFO] Apache Rya Project [INFO] Apache Rya Common Projects [INFO] Apache Rya Common API [INFO] Apache Rya Provenance [INFO] Apache Rya DAO Projects [INFO] Apache Rya Accumulo DAO [INFO] Apache Rya MongoDB DAO [INFO] Apache Rya Extra Projects [INFO] Apache Rya Prospector [INFO] Apache Rya Manual [INFO] Apache Rya SAIL [INFO] Apache Rya PCJ Core [INFO] Apache Rya PCJ Fluo Parent [INFO] Apache Rya PCJ Fluo App [INFO] Apache Rya PCJ Fluo API [INFO] Apache Rya Secondary Indexing [INFO] Apache Rya Console [INFO] Apache Rya Secondary Indexing Example [INFO] Apache Rya MapReduce Tools [INFO] Apache Rya Reasoning [INFO] Apache Rya Vagrant VM [INFO] Apache Rya PCJ Fluo Client [INFO] Apache Rya PCJ Fluo Integration Tests [INFO] Apache Rya PCJ Fluo Demo [INFO] Apache Rya Export Parent [INFO] Apache Rya Export API [INFO] Apache Rya Export Accumulo [INFO] Apache Rya Export Mongo [INFO] Apache Rya Export Client [INFO] Apache Rya Export Integration Tests [INFO] Apache Rya Merge Tool [INFO] Apache Rya Giraph [INFO] Apache Rya Benchmarks [INFO] Geo indexing parent for multiple geo implementations [INFO] Apache Rya Geospatial Secondary Indexing (Optional) [INFO] Geo Indexing using GeoMesa [INFO] Geo indexing using GeoWave [INFO] Geo indexing for mongo [INFO] Apache Rya OSGI Bundle [INFO] Apache Rya ALX [INFO] Apache Rya ALX Console [INFO] Apache Rya Camel [INFO] Apache Rya Pig Projects [INFO] Apache Rya Accumulo Pig [INFO] Apache Rya Spark Support [INFO] Apache Rya Web Projects [INFO] Apache Rya Web Implementation ``` --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
