[jira] [Commented] (RYA-100) Update the build to us Maven animal-sniffer plugin.
[ https://issues.apache.org/jira/browse/RYA-100?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15435238#comment-15435238 ] ASF GitHub Bot commented on RYA-100: Github user kchilton2 closed the pull request at: https://github.com/apache/incubator-rya/pull/54 > Update the build to us Maven animal-sniffer plugin. > --- > > Key: RYA-100 > URL: https://issues.apache.org/jira/browse/RYA-100 > Project: Rya > Issue Type: Improvement > Components: build >Affects Versions: 3.2.10 >Reporter: Kevin Chilton >Assignee: Kevin Chilton > Fix For: 3.2.10 > > > Rya uses Java 1.7. If you are compiling on a machine using a 1.8 JDK, though, > the build succeeds when Java 1.8 features are used within the source. This is > a problem the animal-sniffer plugin fixes. Hook animal-sniffer:check into the > test phase of the build so that it will list where Java 1.8+ features are > being used and fail the build. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (RYA-100) Update the build to us Maven animal-sniffer plugin.
[ https://issues.apache.org/jira/browse/RYA-100?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15433902#comment-15433902 ] ASF GitHub Bot commented on RYA-100: Github user amihalik commented on the issue: https://github.com/apache/incubator-rya/pull/54 Merged. > Update the build to us Maven animal-sniffer plugin. > --- > > Key: RYA-100 > URL: https://issues.apache.org/jira/browse/RYA-100 > Project: Rya > Issue Type: Improvement > Components: build >Affects Versions: 3.2.10 >Reporter: Kevin Chilton >Assignee: Kevin Chilton > Fix For: 3.2.10 > > > Rya uses Java 1.7. If you are compiling on a machine using a 1.8 JDK, though, > the build succeeds when Java 1.8 features are used within the source. This is > a problem the animal-sniffer plugin fixes. Hook animal-sniffer:check into the > test phase of the build so that it will list where Java 1.8+ features are > being used and fail the build. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (RYA-100) Update the build to us Maven animal-sniffer plugin.
[ https://issues.apache.org/jira/browse/RYA-100?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15408658#comment-15408658 ] Kevin Chilton commented on RYA-100: --- https://github.com/apache/incubator-rya/pull/54 > Update the build to us Maven animal-sniffer plugin. > --- > > Key: RYA-100 > URL: https://issues.apache.org/jira/browse/RYA-100 > Project: Rya > Issue Type: Improvement > Components: build >Affects Versions: 3.2.10 >Reporter: Kevin Chilton >Assignee: Kevin Chilton > Fix For: 3.2.10 > > > Rya uses Java 1.7. If you are compiling on a machine using a 1.8 JDK, though, > the build succeeds when Java 1.8 features are used within the source. This is > a problem the animal-sniffer plugin fixes. Hook animal-sniffer:check into the > test phase of the build so that it will list where Java 1.8+ features are > being used and fail the build. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (RYA-100) Update the build to us Maven animal-sniffer plugin.
[ https://issues.apache.org/jira/browse/RYA-100?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15388308#comment-15388308 ] ASF GitHub Bot commented on RYA-100: Github user kchilton2 commented on the issue: https://github.com/apache/incubator-rya/pull/54 Updated to use Java 8 signatures. > Update the build to us Maven animal-sniffer plugin. > --- > > Key: RYA-100 > URL: https://issues.apache.org/jira/browse/RYA-100 > Project: Rya > Issue Type: Improvement > Components: build >Affects Versions: 3.2.10 >Reporter: Kevin Chilton >Assignee: Kevin Chilton > Fix For: 3.2.10 > > > Rya uses Java 1.7. If you are compiling on a machine using a 1.8 JDK, though, > the build succeeds when Java 1.8 features are used within the source. This is > a problem the animal-sniffer plugin fixes. Hook animal-sniffer:check into the > test phase of the build so that it will list where Java 1.8+ features are > being used and fail the build. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (RYA-100) Update the build to us Maven animal-sniffer plugin.
[ https://issues.apache.org/jira/browse/RYA-100?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15388253#comment-15388253 ] ASF GitHub Bot commented on RYA-100: Github user kchilton2 commented on a diff in the pull request: https://github.com/apache/incubator-rya/pull/54#discussion_r71769754 --- Diff: pom.xml --- @@ -562,6 +562,29 @@ under the License. 1.7 + + + +org.codehaus.mojo +animal-sniffer-maven-plugin +1.15 + + +org.codehaus.mojo.signature +java17 --- End diff -- I'll update the signature to be for Java 1.8. > Update the build to us Maven animal-sniffer plugin. > --- > > Key: RYA-100 > URL: https://issues.apache.org/jira/browse/RYA-100 > Project: Rya > Issue Type: Improvement > Components: build >Affects Versions: 3.2.10 >Reporter: Kevin Chilton >Assignee: Kevin Chilton > Fix For: 3.2.10 > > > Rya uses Java 1.7. If you are compiling on a machine using a 1.8 JDK, though, > the build succeeds when Java 1.8 features are used within the source. This is > a problem the animal-sniffer plugin fixes. Hook animal-sniffer:check into the > test phase of the build so that it will list where Java 1.8+ features are > being used and fail the build. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (RYA-100) Update the build to us Maven animal-sniffer plugin.
[ https://issues.apache.org/jira/browse/RYA-100?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15387600#comment-15387600 ] ASF GitHub Bot commented on RYA-100: Github user pujav65 commented on a diff in the pull request: https://github.com/apache/incubator-rya/pull/54#discussion_r71696281 --- Diff: pom.xml --- @@ -562,6 +562,29 @@ under the License. 1.7 + + + +org.codehaus.mojo +animal-sniffer-maven-plugin +1.15 + + +org.codehaus.mojo.signature +java17 --- End diff -- I think a later pull request upgrades rya back to java 8 (an upgrade that was lost somehow when we ported to apache). Can you update this accordingly? Then I will merge. > Update the build to us Maven animal-sniffer plugin. > --- > > Key: RYA-100 > URL: https://issues.apache.org/jira/browse/RYA-100 > Project: Rya > Issue Type: Improvement > Components: build >Affects Versions: 3.2.10 >Reporter: Kevin Chilton >Assignee: Kevin Chilton > Fix For: 3.2.10 > > > Rya uses Java 1.7. If you are compiling on a machine using a 1.8 JDK, though, > the build succeeds when Java 1.8 features are used within the source. This is > a problem the animal-sniffer plugin fixes. Hook animal-sniffer:check into the > test phase of the build so that it will list where Java 1.8+ features are > being used and fail the build. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (RYA-100) Update the build to us Maven animal-sniffer plugin.
[ https://issues.apache.org/jira/browse/RYA-100?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15355852#comment-15355852 ] ASF GitHub Bot commented on RYA-100: GitHub user kchilton2 opened a pull request: https://github.com/apache/incubator-rya/pull/54 RYA-100 Added Maven animal-sniffer plugin to build. You can merge this pull request into a Git repository by running: $ git pull https://github.com/kchilton2/incubator-rya animal-sniffer Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-rya/pull/54.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #54 commit c92e04daf98c340f16a8939a9fe141388b3bd6d5 Author: Kevin Chilton Date: 2016-06-29T21:44:19Z RYA-100 Added Maven animal-sniffer plugin to build. > Update the build to us Maven animal-sniffer plugin. > --- > > Key: RYA-100 > URL: https://issues.apache.org/jira/browse/RYA-100 > Project: Rya > Issue Type: Improvement > Components: build >Affects Versions: 3.2.10 >Reporter: Kevin Chilton >Assignee: Kevin Chilton > Fix For: 3.2.10 > > > Rya uses Java 1.7. If you are compiling on a machine using a 1.8 JDK, though, > the build succeeds when Java 1.8 features are used within the source. This is > a problem the animal-sniffer plugin fixes. Hook animal-sniffer:check into the > test phase of the build so that it will list where Java 1.8+ features are > being used and fail the build. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
