[jira] [Commented] (RYA-293) Implement owl:unionOf inference
[
https://issues.apache.org/jira/browse/RYA-293?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16128813#comment-16128813
]
ASF GitHub Bot commented on RYA-293:
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-rya/pull/180
> Implement owl:unionOf inference
> ---
>
> Key: RYA-293
> URL: https://issues.apache.org/jira/browse/RYA-293
> Project: Rya
> Issue Type: Sub-task
> Components: sail
>Reporter: Jesse Hatfield
>Assignee: Jesse Hatfield
>
> An *{{owl:unionOf}}* expression defines one type to be equivalent to the
> union of another set of types. If the ontology states that {{:Parent}} is the
> union of {{:Mother}} and {{:Father}}, then the inference engine should
> rewrite statement patterns of the form {{?x rdf:type :Parent}} to check for
> resources that are stated to be any of the types {{:Mother}}, {{:Father}}, or
> {{:Parent}}.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (RYA-293) Implement owl:unionOf inference
[
https://issues.apache.org/jira/browse/RYA-293?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16120158#comment-16120158
]
ASF GitHub Bot commented on RYA-293:
Github user jessehatfield commented on a diff in the pull request:
https://github.com/apache/incubator-rya/pull/180#discussion_r132230928
--- Diff:
sail/src/main/java/org/apache/rya/rdftriplestore/inference/InferenceEngine.java
---
@@ -142,6 +143,53 @@ public void refreshGraph() throws
InferenceEngineException {
}
}
+// Add unions to the subclass graph: if c owl:unionOf LIST(c1,
c2, ... cn), then any
+// instances of c1, c2, ... or cn are also instances of c,
meaning c is a superclass
+// of all the rest.
+// (In principle, an instance of c is likewise implied to be
at least one of the other
+// types, but this fact is ignored for now to avoid
nondeterministic reasoning.)
+iter = RyaDAOHelper.query(ryaDAO, null, OWL.UNIONOF, null,
conf);
+try {
+while (iter.hasNext()) {
+Statement st = iter.next();
+Value unionType = st.getSubject();
+// Traverse the list of types constituting the union
+Value current = st.getObject();
+while (current instanceof Resource &&
!RDF.NIL.equals(current)) {
+Resource listNode = (Resource) current;
+CloseableIteration listIter = RyaDAOHelper.query(ryaDAO,
+listNode, RDF.FIRST, null, conf);
+try {
+if (listIter.hasNext()) {
+Statement firstStatement = listIter.next();
+if (firstStatement.getObject() instanceof
Resource) {
+Resource subclass = (Resource)
firstStatement.getObject();
+Statement subclassStatement =
vf.createStatement(subclass, RDFS.SUBCLASSOF, unionType);
+addStatementEdge(graph,
RDFS.SUBCLASSOF.stringValue(), subclassStatement);
+}
+}
+} finally {
+listIter.close();
+}
+listIter = RyaDAOHelper.query(ryaDAO, listNode,
RDF.REST, null, conf);
+try {
+if (listIter.hasNext()) {
+current = listIter.next().getObject();
--- End diff --
Yep, a union is given as a linked list so we just walk down adding subclass
statements until we get to a node with no rdf:rest or with rdf:rest equal to
rdf:nil. If the list is poorly-formed or someone tries to express the union
using the wrong collection type ([describes unionOf
expression](https://www.w3.org/TR/owl2-rdf-based-semantics/#Semantic_Conditions_for_Boolean_Connectives)
| [gives interpretation of
sequence](https://www.w3.org/TR/owl2-rdf-based-semantics/#Semantic_Conditions))
then it won't work. In most cases that just means the intended union isn't
fully represented, but I suppose if it were somehow a cyclical list, we'd end
up in an infinite loop.
> Implement owl:unionOf inference
> ---
>
> Key: RYA-293
> URL: https://issues.apache.org/jira/browse/RYA-293
> Project: Rya
> Issue Type: Sub-task
> Components: sail
>Reporter: Jesse Hatfield
>Assignee: Jesse Hatfield
>
> An *{{owl:unionOf}}* expression defines one type to be equivalent to the
> union of another set of types. If the ontology states that {{:Parent}} is the
> union of {{:Mother}} and {{:Father}}, then the inference engine should
> rewrite statement patterns of the form {{?x rdf:type :Parent}} to check for
> resources that are stated to be any of the types {{:Mother}}, {{:Father}}, or
> {{:Parent}}.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (RYA-293) Implement owl:unionOf inference
[
https://issues.apache.org/jira/browse/RYA-293?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16120123#comment-16120123
]
ASF GitHub Bot commented on RYA-293:
Github user jessehatfield commented on the issue:
https://github.com/apache/incubator-rya/pull/180
So this is a case where a few different schema terms (rdfs:subClassOf,
owl:unionOf, and eventually owl:equivalentClass) end up being represented by
just one term internally (subclass/superclass relationships). We could
plausibly organize by either; my intuition is to use the internal
representation, since the internal graph being complete and accurate can matter
to the other rules. That would mean pulling the logic introduced here, plus the
logic introduced in [https://github.com/apache/incubator-rya/pull/184](PR 184)
, plus the logic for rdfs:subClassOf (which 184 incidentally simplifies to a
method call anyway) into some "refreshSubClassGraph" method. Thoughts on that
approach? Would probably do the same with subPropertyOfGraph for consistency
(though it's simpler because there's no equivalent to union).
> Implement owl:unionOf inference
> ---
>
> Key: RYA-293
> URL: https://issues.apache.org/jira/browse/RYA-293
> Project: Rya
> Issue Type: Sub-task
> Components: sail
>Reporter: Jesse Hatfield
>Assignee: Jesse Hatfield
>
> An *{{owl:unionOf}}* expression defines one type to be equivalent to the
> union of another set of types. If the ontology states that {{:Parent}} is the
> union of {{:Mother}} and {{:Father}}, then the inference engine should
> rewrite statement patterns of the form {{?x rdf:type :Parent}} to check for
> resources that are stated to be any of the types {{:Mother}}, {{:Father}}, or
> {{:Parent}}.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (RYA-293) Implement owl:unionOf inference
[
https://issues.apache.org/jira/browse/RYA-293?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16120060#comment-16120060
]
ASF GitHub Bot commented on RYA-293:
Github user meiercaleb commented on a diff in the pull request:
https://github.com/apache/incubator-rya/pull/180#discussion_r132213500
--- Diff:
sail/src/main/java/org/apache/rya/rdftriplestore/inference/InferenceEngine.java
---
@@ -142,6 +143,53 @@ public void refreshGraph() throws
InferenceEngineException {
}
}
+// Add unions to the subclass graph: if c owl:unionOf LIST(c1,
c2, ... cn), then any
+// instances of c1, c2, ... or cn are also instances of c,
meaning c is a superclass
+// of all the rest.
+// (In principle, an instance of c is likewise implied to be
at least one of the other
+// types, but this fact is ignored for now to avoid
nondeterministic reasoning.)
+iter = RyaDAOHelper.query(ryaDAO, null, OWL.UNIONOF, null,
conf);
+try {
+while (iter.hasNext()) {
+Statement st = iter.next();
+Value unionType = st.getSubject();
+// Traverse the list of types constituting the union
+Value current = st.getObject();
+while (current instanceof Resource &&
!RDF.NIL.equals(current)) {
+Resource listNode = (Resource) current;
+CloseableIteration listIter = RyaDAOHelper.query(ryaDAO,
+listNode, RDF.FIRST, null, conf);
+try {
+if (listIter.hasNext()) {
+Statement firstStatement = listIter.next();
+if (firstStatement.getObject() instanceof
Resource) {
+Resource subclass = (Resource)
firstStatement.getObject();
+Statement subclassStatement =
vf.createStatement(subclass, RDFS.SUBCLASSOF, unionType);
+addStatementEdge(graph,
RDFS.SUBCLASSOF.stringValue(), subclassStatement);
+}
+}
+} finally {
+listIter.close();
+}
+listIter = RyaDAOHelper.query(ryaDAO, listNode,
RDF.REST, null, conf);
+try {
+if (listIter.hasNext()) {
+current = listIter.next().getObject();
--- End diff --
Trying to follow the general logic here: Each list has an RDF.FIRST and
RDF.RESET property, where FIRST is a resource and REST is of type list. So if
the list has more than one element, current is set to the list obtained by the
RDF.REST query and we go through the loop again. Is this how all of the
SUBCLASSOF statements are created for the union?
> Implement owl:unionOf inference
> ---
>
> Key: RYA-293
> URL: https://issues.apache.org/jira/browse/RYA-293
> Project: Rya
> Issue Type: Sub-task
> Components: sail
>Reporter: Jesse Hatfield
>Assignee: Jesse Hatfield
>
> An *{{owl:unionOf}}* expression defines one type to be equivalent to the
> union of another set of types. If the ontology states that {{:Parent}} is the
> union of {{:Mother}} and {{:Father}}, then the inference engine should
> rewrite statement patterns of the form {{?x rdf:type :Parent}} to check for
> resources that are stated to be any of the types {{:Mother}}, {{:Father}}, or
> {{:Parent}}.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (RYA-293) Implement owl:unionOf inference
[
https://issues.apache.org/jira/browse/RYA-293?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16120059#comment-16120059
]
ASF GitHub Bot commented on RYA-293:
Github user meiercaleb commented on a diff in the pull request:
https://github.com/apache/incubator-rya/pull/180#discussion_r132207923
--- Diff:
sail/src/main/java/org/apache/rya/rdftriplestore/inference/InferenceEngine.java
---
@@ -142,6 +143,53 @@ public void refreshGraph() throws
InferenceEngineException {
}
}
+// Add unions to the subclass graph: if c owl:unionOf LIST(c1,
c2, ... cn), then any
--- End diff --
I thought that you were going to start breaking out any new logic that you
added to the refreshGraph() method into methods that were specific to the given
rule.
> Implement owl:unionOf inference
> ---
>
> Key: RYA-293
> URL: https://issues.apache.org/jira/browse/RYA-293
> Project: Rya
> Issue Type: Sub-task
> Components: sail
>Reporter: Jesse Hatfield
>Assignee: Jesse Hatfield
>
> An *{{owl:unionOf}}* expression defines one type to be equivalent to the
> union of another set of types. If the ontology states that {{:Parent}} is the
> union of {{:Mother}} and {{:Father}}, then the inference engine should
> rewrite statement patterns of the form {{?x rdf:type :Parent}} to check for
> resources that are stated to be any of the types {{:Mother}}, {{:Father}}, or
> {{:Parent}}.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (RYA-293) Implement owl:unionOf inference
[
https://issues.apache.org/jira/browse/RYA-293?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16118473#comment-16118473
]
ASF GitHub Bot commented on RYA-293:
Github user asfgit commented on the issue:
https://github.com/apache/incubator-rya/pull/180
Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/incubator-rya-master-with-optionals-pull-requests/367/
> Implement owl:unionOf inference
> ---
>
> Key: RYA-293
> URL: https://issues.apache.org/jira/browse/RYA-293
> Project: Rya
> Issue Type: Sub-task
> Components: sail
>Reporter: Jesse Hatfield
>Assignee: Jesse Hatfield
>
> An *{{owl:unionOf}}* expression defines one type to be equivalent to the
> union of another set of types. If the ontology states that {{:Parent}} is the
> union of {{:Mother}} and {{:Father}}, then the inference engine should
> rewrite statement patterns of the form {{?x rdf:type :Parent}} to check for
> resources that are stated to be any of the types {{:Mother}}, {{:Father}}, or
> {{:Parent}}.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (RYA-293) Implement owl:unionOf inference
[
https://issues.apache.org/jira/browse/RYA-293?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16118370#comment-16118370
]
ASF GitHub Bot commented on RYA-293:
Github user ejwhite922 commented on the issue:
https://github.com/apache/incubator-rya/pull/180
Looks good. Rebasing with master and pushing should fix the build issue.
> Implement owl:unionOf inference
> ---
>
> Key: RYA-293
> URL: https://issues.apache.org/jira/browse/RYA-293
> Project: Rya
> Issue Type: Sub-task
> Components: sail
>Reporter: Jesse Hatfield
>Assignee: Jesse Hatfield
>
> An *{{owl:unionOf}}* expression defines one type to be equivalent to the
> union of another set of types. If the ontology states that {{:Parent}} is the
> union of {{:Mother}} and {{:Father}}, then the inference engine should
> rewrite statement patterns of the form {{?x rdf:type :Parent}} to check for
> resources that are stated to be any of the types {{:Mother}}, {{:Father}}, or
> {{:Parent}}.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (RYA-293) Implement owl:unionOf inference
[
https://issues.apache.org/jira/browse/RYA-293?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16105891#comment-16105891
]
ASF GitHub Bot commented on RYA-293:
Github user jessehatfield commented on the issue:
https://github.com/apache/incubator-rya/pull/180
I'm not sure what caused those errors, but I agree they don't appear
related. Two are thrown by
[KafkaExportITBase.embeddedKafkaTest](https://github.com/apache/incubator-rya/blob/master/extras/rya.pcj.fluo/pcj.fluo.integration/src/test/java/org/apache/rya/indexing/pcj/fluo/KafkaExportITBase.java#L277),
whose documentation asserts that this doesn't indicate a problem with Rya
itself. I'm not seeing this exact error in any of the other currently failing
builds, though many are failing in the same vicinity. I'm less confident about
the MongoTemporalIndexerTest, but I haven't managed to reproduce that failure
locally.
> Implement owl:unionOf inference
> ---
>
> Key: RYA-293
> URL: https://issues.apache.org/jira/browse/RYA-293
> Project: Rya
> Issue Type: Sub-task
> Components: sail
>Reporter: Jesse Hatfield
>Assignee: Jesse Hatfield
>
> An *{{owl:unionOf}}* expression defines one type to be equivalent to the
> union of another set of types. If the ontology states that {{:Parent}} is the
> union of {{:Mother}} and {{:Father}}, then the inference engine should
> rewrite statement patterns of the form {{?x rdf:type :Parent}} to check for
> resources that are stated to be any of the types {{:Mother}}, {{:Father}}, or
> {{:Parent}}.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (RYA-293) Implement owl:unionOf inference
[
https://issues.apache.org/jira/browse/RYA-293?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16104287#comment-16104287
]
ASF GitHub Bot commented on RYA-293:
Github user pujav65 commented on the issue:
https://github.com/apache/incubator-rya/pull/180
hey @jessehatfield , it looks like there are test failures:
https://builds.apache.org/job/incubator-rya-fork/24/
Can you verify that these are false failures? They do not look like they
are related to your pull request.
> Implement owl:unionOf inference
> ---
>
> Key: RYA-293
> URL: https://issues.apache.org/jira/browse/RYA-293
> Project: Rya
> Issue Type: Sub-task
> Components: sail
>Reporter: Jesse Hatfield
>Assignee: Jesse Hatfield
>
> An *{{owl:unionOf}}* expression defines one type to be equivalent to the
> union of another set of types. If the ontology states that {{:Parent}} is the
> union of {{:Mother}} and {{:Father}}, then the inference engine should
> rewrite statement patterns of the form {{?x rdf:type :Parent}} to check for
> resources that are stated to be any of the types {{:Mother}}, {{:Father}}, or
> {{:Parent}}.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (RYA-293) Implement owl:unionOf inference
[
https://issues.apache.org/jira/browse/RYA-293?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16104181#comment-16104181
]
ASF GitHub Bot commented on RYA-293:
Github user pujav65 commented on the issue:
https://github.com/apache/incubator-rya/pull/180
looks good -- kicking of a build to merge
> Implement owl:unionOf inference
> ---
>
> Key: RYA-293
> URL: https://issues.apache.org/jira/browse/RYA-293
> Project: Rya
> Issue Type: Sub-task
> Components: sail
>Reporter: Jesse Hatfield
>Assignee: Jesse Hatfield
>
> An *{{owl:unionOf}}* expression defines one type to be equivalent to the
> union of another set of types. If the ontology states that {{:Parent}} is the
> union of {{:Mother}} and {{:Father}}, then the inference engine should
> rewrite statement patterns of the form {{?x rdf:type :Parent}} to check for
> resources that are stated to be any of the types {{:Mother}}, {{:Father}}, or
> {{:Parent}}.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (RYA-293) Implement owl:unionOf inference
[
https://issues.apache.org/jira/browse/RYA-293?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16095679#comment-16095679
]
ASF GitHub Bot commented on RYA-293:
Github user asfgit commented on the issue:
https://github.com/apache/incubator-rya/pull/180
Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/incubator-rya-master-with-optionals-pull-requests/272/Build
result: ABORTED[...truncated 6.52 MB...][INFO]
[INFO]
[INFO]
Building Apache Rya PCJ Fluo Demo 3.2.11-incubating-SNAPSHOT[INFO]
[INFO]
[INFO] --- maven-clean-plugin:2.5:clean (default-clean) @ rya.pcj.fluo.demo
---[WARNING] Failed to notify spy hudson.maven.Maven3Builder$JenkinsEventSpy:
java.util.concurrent.ExecutionException: Invalid object ID 12 iota=55[INFO]
[INFO] --- apache-rat-plugin:0.11:check (check-licenses) @ rya.pcj.fluo.demo
---[INFO] 51 implicit excludes (use -debug for more details).[INFO] Exclude:
**/resources/META-INF/services/**[INFO] 4 resources included (use -debug for
more details)[INFO] Rat check: Summary of files. Unapproved: 0 unknown: 0
generated: 0 approved: 4 licence.[WARNING] Failed to notify spy
hudson.maven.Maven3Builder$JenkinsEventSpy:
java.util.concurrent.ExecutionException: Invalid object ID 12 iota=55[INFO]
[INFO] --- maven-enforcer-plugin:1.3.1:enforce (enforce-mvn) @
rya.pcj.fluo.demo ---[WARNING] Failed to notify spy
hudson.maven.Maven3Builder$JenkinsEventSpy:
java.util.concurrent.ExecutionException: Invalid object ID 12 iota=55[INFO]
[INFO] --- maven-remote-resources-plugin:1.5:process (default) @
rya.pcj.fluo.demo ---Build was abortedchannel stoppedSetting status of
ee538a9b113312d29927b0e61bb7396e35e112c5 to FAILURE with url
https://builds.apache.org/job/incubator-rya-master-with-optionals-pull-requests/272/
and message: 'FAILURE 'Using context: Jenkins: clean package -Pgeoindexing
> Implement owl:unionOf inference
> ---
>
> Key: RYA-293
> URL: https://issues.apache.org/jira/browse/RYA-293
> Project: Rya
> Issue Type: Sub-task
> Components: sail
>Reporter: Jesse Hatfield
>Assignee: Jesse Hatfield
>
> An *{{owl:unionOf}}* expression defines one type to be equivalent to the
> union of another set of types. If the ontology states that {{:Parent}} is the
> union of {{:Mother}} and {{:Father}}, then the inference engine should
> rewrite statement patterns of the form {{?x rdf:type :Parent}} to check for
> resources that are stated to be any of the types {{:Mother}}, {{:Father}}, or
> {{:Parent}}.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
