[jira] [Commented] (RYA-94) Remove from secondary indexes when deleting from DAO
[ https://issues.apache.org/jira/browse/RYA-94?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16135356#comment-16135356 ] ASF GitHub Bot commented on RYA-94: --- Github user DLotts commented on the issue: https://github.com/apache/incubator-rya/pull/73 Already addressed elsewhere, closing! > Remove from secondary indexes when deleting from DAO > > > Key: RYA-94 > URL: https://issues.apache.org/jira/browse/RYA-94 > Project: Rya > Issue Type: Bug >Reporter: Andrew Smith >Assignee: David W. Lotts >Priority: Blocker > > Currently, if a delete is made from the DAO, the secondary indexers are not > explicitly notified. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (RYA-94) Remove from secondary indexes when deleting from DAO
[ https://issues.apache.org/jira/browse/RYA-94?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16135357#comment-16135357 ] ASF GitHub Bot commented on RYA-94: --- Github user DLotts closed the pull request at: https://github.com/apache/incubator-rya/pull/73 > Remove from secondary indexes when deleting from DAO > > > Key: RYA-94 > URL: https://issues.apache.org/jira/browse/RYA-94 > Project: Rya > Issue Type: Bug >Reporter: Andrew Smith >Assignee: David W. Lotts >Priority: Blocker > > Currently, if a delete is made from the DAO, the secondary indexers are not > explicitly notified. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (RYA-94) Remove from secondary indexes when deleting from DAO
[ https://issues.apache.org/jira/browse/RYA-94?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15523445#comment-15523445 ] ASF GitHub Bot commented on RYA-94: --- Github user DLotts commented on the issue: https://github.com/apache/incubator-rya/pull/73 It was blocked by another Mongo issue, but that was fixed and so this should be complete-able now. BTW: It's only an issue with Mongo. This method: /mongodb.rya/src/main/java/mvm/rya/mongodb/MongoDBRyaDAO.delete() needs a loop like this: for (RyaSecondaryIndexer index : secondaryIndexers) { index.delete(ryaStatement); } david. > Remove from secondary indexes when deleting from DAO > > > Key: RYA-94 > URL: https://issues.apache.org/jira/browse/RYA-94 > Project: Rya > Issue Type: Bug >Reporter: Andrew Smith >Assignee: David W. Lotts >Priority: Blocker > > Currently, if a delete is made from the DAO, the secondary indexers are not > explicitly notified. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (RYA-94) Remove from secondary indexes when deleting from DAO
[ https://issues.apache.org/jira/browse/RYA-94?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15523413#comment-15523413 ] ASF GitHub Bot commented on RYA-94: --- Github user pujav65 commented on the issue: https://github.com/apache/incubator-rya/pull/73 hey david, is this still in progress or was it made obsolete by another pull request? > Remove from secondary indexes when deleting from DAO > > > Key: RYA-94 > URL: https://issues.apache.org/jira/browse/RYA-94 > Project: Rya > Issue Type: Bug >Reporter: Andrew Smith >Assignee: David W. Lotts >Priority: Blocker > > Currently, if a delete is made from the DAO, the secondary indexers are not > explicitly notified. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (RYA-94) Remove from secondary indexes when deleting from DAO
[ https://issues.apache.org/jira/browse/RYA-94?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15438182#comment-15438182 ] ASF GitHub Bot commented on RYA-94: --- Github user amihalik commented on the issue: https://github.com/apache/incubator-rya/pull/73 Please change this to point to the apache master branch. > Remove from secondary indexes when deleting from DAO > > > Key: RYA-94 > URL: https://issues.apache.org/jira/browse/RYA-94 > Project: Rya > Issue Type: Bug >Reporter: Andrew Smith >Assignee: David W. Lotts >Priority: Blocker > > Currently, if a delete is made from the DAO, the secondary indexers are not > explicitly notified. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (RYA-94) Remove from secondary indexes when deleting from DAO
[ https://issues.apache.org/jira/browse/RYA-94?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15433403#comment-15433403 ] David W. Lotts commented on RYA-94: --- It's only an issue with Mongo. /mongodb.rya/src/main/java/mvm/rya/mongodb/MongoDBRyaDAO.delete() needs a loop like this: for (RyaSecondaryIndexer index : secondaryIndexers) { index.delete(ryaStatement); } > Remove from secondary indexes when deleting from DAO > > > Key: RYA-94 > URL: https://issues.apache.org/jira/browse/RYA-94 > Project: Rya > Issue Type: Bug >Reporter: Andrew Smith >Assignee: David W. Lotts >Priority: Blocker > > Currently, if a delete is made from the DAO, the secondary indexers are not > explicitly notified. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (RYA-94) Remove from secondary indexes when deleting from DAO
[ https://issues.apache.org/jira/browse/RYA-94?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15427389#comment-15427389 ] ASF GitHub Bot commented on RYA-94: --- Github user pujav65 commented on the issue: https://github.com/apache/incubator-rya/pull/73 hey david, Two things: 1. Merge to develop not master 2. Mark the Pull request as WIP if its not ready to be merged > Remove from secondary indexes when deleting from DAO > > > Key: RYA-94 > URL: https://issues.apache.org/jira/browse/RYA-94 > Project: Rya > Issue Type: Bug >Reporter: Andrew Smith >Assignee: David W. Lotts >Priority: Blocker > > Currently, if a delete is made from the DAO, the secondary indexers are not > explicitly notified. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (RYA-94) Remove from secondary indexes when deleting from DAO
[ https://issues.apache.org/jira/browse/RYA-94?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15407698#comment-15407698 ] Puja Valiyil commented on RYA-94: -- Is this for Mongo or for Accumulo too? > Remove from secondary indexes when deleting from DAO > > > Key: RYA-94 > URL: https://issues.apache.org/jira/browse/RYA-94 > Project: Rya > Issue Type: Bug >Reporter: Andrew Smith >Assignee: David W. Lotts > > Currently, if a delete is made from the DAO, the secondary indexers are not > explicitly notified. -- This message was sent by Atlassian JIRA (v6.3.4#6332)