Re: [PR] fix(6509): improve the test case coverage of saga module to 70% [incubator-seata]
codecov-commenter commented on PR #6647: URL: https://github.com/apache/incubator-seata/pull/6647#issuecomment-2211718808 ## [Codecov](https://app.codecov.io/gh/apache/incubator-seata/pull/6647?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report All modified and coverable lines are covered by tests :white_check_mark: > Project coverage is 50.24%. Comparing base [(`933b492`)](https://app.codecov.io/gh/apache/incubator-seata/commit/933b492da88e145ca2b7f152ed3b03693936b068?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to head [(`0e6d03a`)](https://app.codecov.io/gh/apache/incubator-seata/commit/0e6d03a03dd9b68d58077187b6cea68c1dac95f9?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). > Report is 27 commits behind head on 2.x. Additional details and impacted files [](https://app.codecov.io/gh/apache/incubator-seata/pull/6647?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) ```diff @@ Coverage Diff @@ ##2.x#6647 +/- ## - Coverage 51.13% 50.24% -0.90% - Complexity 5317 5596 +279 Files 950 1023 +73 Lines 3344835440+1992 Branches 4048 4216 +168 + Hits 1710317806 +703 - Misses1466615867+1201 - Partials 1679 1767 +88 ``` [see 122 files with indirect coverage changes](https://app.codecov.io/gh/apache/incubator-seata/pull/6647/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@seata.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@seata.apache.org For additional commands, e-mail: notifications-h...@seata.apache.org
Re: [PR] fix(6509): improve the test case coverage of saga module to 70% [incubator-seata]
xjlgod closed pull request #6646: fix(6509): improve the test case coverage of saga module to 70% URL: https://github.com/apache/incubator-seata/pull/6646 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@seata.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@seata.apache.org For additional commands, e-mail: notifications-h...@seata.apache.org
Re: [PR] fix(6509): improve the test case coverage of saga module to 70% [incubator-seata]
xjlgod closed pull request #6645: fix(6509): improve the test case coverage of saga module to 70% URL: https://github.com/apache/incubator-seata/pull/6645 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@seata.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@seata.apache.org For additional commands, e-mail: notifications-h...@seata.apache.org
Re: [PR] fix(6509): improve the test case coverage of saga module to 70% [incubator-seata]
codecov-commenter commented on PR #6645: URL: https://github.com/apache/incubator-seata/pull/6645#issuecomment-2211625178 ## [Codecov](https://app.codecov.io/gh/apache/incubator-seata/pull/6645?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report All modified and coverable lines are covered by tests :white_check_mark: > Project coverage is 50.23%. Comparing base [(`933b492`)](https://app.codecov.io/gh/apache/incubator-seata/commit/933b492da88e145ca2b7f152ed3b03693936b068?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to head [(`3c9924e`)](https://app.codecov.io/gh/apache/incubator-seata/commit/3c9924e8fab3bb886e13dba18812b13e79c393f7?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). > Report is 27 commits behind head on 2.x. Additional details and impacted files [](https://app.codecov.io/gh/apache/incubator-seata/pull/6645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) ```diff @@ Coverage Diff @@ ##2.x#6645 +/- ## - Coverage 51.13% 50.23% -0.90% - Complexity 5317 5595 +278 Files 950 1023 +73 Lines 3344835440+1992 Branches 4048 4218 +170 + Hits 1710317805 +702 - Misses1466615869+1203 - Partials 1679 1766 +87 ``` [see 122 files with indirect coverage changes](https://app.codecov.io/gh/apache/incubator-seata/pull/6645/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@seata.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@seata.apache.org For additional commands, e-mail: notifications-h...@seata.apache.org
Re: [PR] fix(6509): improve the test case coverage of saga module to 70% [incubator-seata]
xjlgod closed pull request #6519: fix(6509): improve the test case coverage of saga module to 70% URL: https://github.com/apache/incubator-seata/pull/6519 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@seata.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@seata.apache.org For additional commands, e-mail: notifications-h...@seata.apache.org
Re: [PR] fix(6509): improve the test case coverage of saga module to 70% [incubator-seata]
xjlgod closed pull request #6519: fix(6509): improve the test case coverage of saga module to 70% URL: https://github.com/apache/incubator-seata/pull/6519 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@seata.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@seata.apache.org For additional commands, e-mail: notifications-h...@seata.apache.org
Re: [PR] fix(6509): improve the test case coverage of saga module to 70% [incubator-seata]
xjlgod commented on code in PR #6519:
URL: https://github.com/apache/incubator-seata/pull/6519#discussion_r1632016974
##
changes/zh-cn/2.x.md:
##
@@ -155,6 +155,7 @@
- [[#6456](https://github.com/apache/incubator-seata/pull/6456)] 调整动态配置监听测试用例
- [[#6466](https://github.com/apache/incubator-seata/pull/6466)] 支持redis的集成测试
- [[#6484](https://github.com/apache/incubator-seata/pull/6484)]
修复FileConfigurationTest和MockServerTest失败
+- [[#6519](https://github.com/apache/incubator-seata/pull/6484)]
增加saga模块的测试用例覆盖率
Review Comment:
fix it.
##
saga/seata-saga-spring/src/test/java/org/apache/seata/saga/engine/expression/spel/SpringELExpressionFactoryTest.java:
##
@@ -0,0 +1,30 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.seata.saga.engine.expression.spel;
+
+import org.junit.jupiter.api.Test;
+
+/**
+ * SpringELExpressionFactoryTest
+ */
+public class SpringELExpressionFactoryTest {
+@Test
+public void testCreateExpression() {
+SpringELExpressionFactory factory = new
SpringELExpressionFactory(null);
+factory.createExpression("'Hello World'.concat('!')");
+}
Review Comment:
fix it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@seata.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: notifications-unsubscr...@seata.apache.org
For additional commands, e-mail: notifications-h...@seata.apache.org
Re: [PR] fix(6509): improve the test case coverage of saga module to 70% [incubator-seata]
lightClouds917 commented on code in PR #6519:
URL: https://github.com/apache/incubator-seata/pull/6519#discussion_r1627527406
##
changes/en-us/2.x.md:
##
@@ -158,6 +158,7 @@ Add changes here for all PR submitted to the 2.x branch.
- [[#6456](https://github.com/apache/incubator-seata/pull/6456)] adjust the
test cases related to dynamic configuration
- [[#6466](https://github.com/apache/incubator-seata/pull/6466)] support redis
integration testing
- [[#6484](https://github.com/apache/incubator-seata/pull/6484)] fix
FileConfigurationTest and MockServerTest fail
+- [[#6519](https://github.com/apache/incubator-seata/pull/6484)]
增加saga模块的测试用例覆盖率
Review Comment:
/pull/6484? 6519.
##
saga/seata-saga-spring/src/test/java/org/apache/seata/saga/engine/expression/spel/SpringELExpressionFactoryTest.java:
##
@@ -0,0 +1,30 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.seata.saga.engine.expression.spel;
+
+import org.junit.jupiter.api.Test;
+
+/**
+ * SpringELExpressionFactoryTest
+ */
+public class SpringELExpressionFactoryTest {
+@Test
+public void testCreateExpression() {
+SpringELExpressionFactory factory = new
SpringELExpressionFactory(null);
+factory.createExpression("'Hello World'.concat('!')");
+}
Review Comment:
need assert result,not only call method
##
changes/zh-cn/2.x.md:
##
@@ -155,6 +155,7 @@
- [[#6456](https://github.com/apache/incubator-seata/pull/6456)] 调整动态配置监听测试用例
- [[#6466](https://github.com/apache/incubator-seata/pull/6466)] 支持redis的集成测试
- [[#6484](https://github.com/apache/incubator-seata/pull/6484)]
修复FileConfigurationTest和MockServerTest失败
+- [[#6519](https://github.com/apache/incubator-seata/pull/6484)]
增加saga模块的测试用例覆盖率
Review Comment:
6519
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@seata.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: notifications-unsubscr...@seata.apache.org
For additional commands, e-mail: notifications-h...@seata.apache.org
Re: [PR] fix(6509): improve the test case coverage of saga module to 70% [incubator-seata]
funky-eyes commented on code in PR #6519: URL: https://github.com/apache/incubator-seata/pull/6519#discussion_r1615603491 ## .github/workflows/build.yml: ## @@ -53,6 +53,8 @@ jobs: - name: "Codecov" if: matrix.java == '8' uses: codecov/codecov-action@v3.1.4 Review Comment: ```suggestion uses: codecov/codecov-action@v4.0.1 ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@seata.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@seata.apache.org For additional commands, e-mail: notifications-h...@seata.apache.org
Re: [PR] fix(6509): improve the test case coverage of [saga] module to 70% [incubator-seata]
xjlgod closed pull request #6519: fix(6509): improve the test case coverage of [saga] module to 70% URL: https://github.com/apache/incubator-seata/pull/6519 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@seata.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@seata.apache.org For additional commands, e-mail: notifications-h...@seata.apache.org
Re: [PR] fix(6509): improve the test case coverage of [saga] module to 70% [incubator-seata]
codecov-commenter commented on PR #6519: URL: https://github.com/apache/incubator-seata/pull/6519#issuecomment-2131245075 ## [Codecov](https://app.codecov.io/gh/apache/incubator-seata/pull/6519?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report All modified and coverable lines are covered by tests :white_check_mark: > Project coverage is 52.39%. Comparing base [(`8b58f85`)](https://app.codecov.io/gh/apache/incubator-seata/commit/8b58f857867fef2d251d34f176c2eb813967f4c9?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to head [(`6ccff41`)](https://app.codecov.io/gh/apache/incubator-seata/commit/6ccff413d3a47d75007c1ae9def37c15dd079275?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). > Report is 14 commits behind head on 2.x. Additional details and impacted files [](https://app.codecov.io/gh/apache/incubator-seata/pull/6519?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) ```diff @@ Coverage Diff @@ ##2.x#6519 +/- ## + Coverage 50.02% 52.39% +2.37% - Complexity 5224 5449 +225 Files 950 950 Lines 3344733448 +1 Branches 4047 4048 +1 + Hits 1673217526 +794 + Misses1510414155 -949 - Partials 1611 1767 +156 ``` [see 70 files with indirect coverage changes](https://app.codecov.io/gh/apache/incubator-seata/pull/6519/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@seata.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@seata.apache.org For additional commands, e-mail: notifications-h...@seata.apache.org
Re: [PR] fix(6509): improve the test case coverage of [saga] module to 70% [incubator-seata]
xjlgod commented on code in PR #6519: URL: https://github.com/apache/incubator-seata/pull/6519#discussion_r1614640585 ## saga/seata-saga-processctrl/src/test/java/org/apache/seata/saga/proctrl/handler/DefaultRouterHandlerTest.java: ## @@ -0,0 +1,52 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.seata.saga.proctrl.handler; + +import org.apache.seata.common.exception.FrameworkException; +import org.apache.seata.saga.proctrl.ProcessRouter; +import org.apache.seata.saga.proctrl.ProcessType; +import org.apache.seata.saga.proctrl.impl.ProcessContextImpl; +import org.apache.seata.saga.proctrl.mock.MockProcessRouter; +import org.junit.jupiter.api.Assertions; +import org.junit.jupiter.api.Test; + +import java.util.HashMap; +import java.util.Map; + +/** + * @author jingliu_xi...@foxmail.com Review Comment: I have deleted it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@seata.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@seata.apache.org For additional commands, e-mail: notifications-h...@seata.apache.org
Re: [PR] fix(6509): improve the test case coverage of [saga] module to 70% [incubator-seata]
lightClouds917 commented on code in PR #6519: URL: https://github.com/apache/incubator-seata/pull/6519#discussion_r1614615477 ## saga/seata-saga-processctrl/src/test/java/org/apache/seata/saga/proctrl/handler/DefaultRouterHandlerTest.java: ## @@ -0,0 +1,52 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.seata.saga.proctrl.handler; + +import org.apache.seata.common.exception.FrameworkException; +import org.apache.seata.saga.proctrl.ProcessRouter; +import org.apache.seata.saga.proctrl.ProcessType; +import org.apache.seata.saga.proctrl.impl.ProcessContextImpl; +import org.apache.seata.saga.proctrl.mock.MockProcessRouter; +import org.junit.jupiter.api.Assertions; +import org.junit.jupiter.api.Test; + +import java.util.HashMap; +import java.util.Map; + +/** + * @author jingliu_xi...@foxmail.com Review Comment: delete the author infomation,as well as below -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@seata.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@seata.apache.org For additional commands, e-mail: notifications-h...@seata.apache.org
