[GitHub] [incubator-shardingsphere] haetao commented on a change in pull request #3824: Modify the way to identify Rule Configuration in Config Center
haetao commented on a change in pull request #3824: Modify the way to identify
Rule Configuration in Config Center
URL:
https://github.com/apache/incubator-shardingsphere/pull/3824#discussion_r361824668
##
File path:
sharding-orchestration/sharding-orchestration-core/src/main/java/org/apache/shardingsphere/orchestration/internal/registry/config/service/ConfigurationService.java
##
@@ -174,7 +174,13 @@ private boolean hasProperties() {
* @return is sharding rule or not
*/
public boolean isShardingRule(final String shardingSchemaName) {
-return
regCenter.getDirectly(configNode.getRulePath(shardingSchemaName)).contains("tables:\n");
+if
(regCenter.getDirectly(configNode.getRulePath(shardingSchemaName)).contains("encryptRule:\n"))
{
Review comment:
The rule configuration in registry center format is as follows when
sharding only.
```
tables:
t_address:
actualDataNodes: ds_${0..1}.t_address
logicTable: t_address
t_order:
actualDataNodes: ds_${0..1}.t_order_${0..1}
databaseStrategy:
inline:
algorithmExpression: ds_${user_id % 2}
shardingColumn: user_id
keyGenerator:
column: order_id
type: SNOWFLAKE
logicTable: t_order
tableStrategy:
inline:
algorithmExpression: t_order_${order_id % 2}
shardingColumn: order_id
t_order_item:
actualDataNodes: ds_${0..1}.t_order_item_${0..1}
databaseStrategy:
inline:
algorithmExpression: ds_${user_id % 2}
shardingColumn: user_id
keyGenerator:
column: order_id
type: SNOWFLAKE
logicTable: t_order_item
tableStrategy:
inline:
algorithmExpression: t_order_item_${order_id % 2}
shardingColumn: order_id
```
We just make sure the rule is not encrypt only. the encrypt only rule
configuration in registry center is as follows.
```
encryptors:
encryptor_aes:
type: aes
props:
aes.key.value: 123456abc
encryptor_md5:
type: md5
tables:
t_user:
columns:
user_name:
plainColumn: user_name
cipherColumn: user_name_plain
encryptor: encryptor_aes
```
The complex rule is as follows. it will be as shardingRule
```
tables:
t_user:
actualDataNodes: ds_${0..1}.t_user_${0..1}
databaseStrategy:
inline:
shardingColumn: user_id
algorithmExpression: ds_${user_id % 2}
tableStrategy:
inline:
shardingColumn: user_id
algorithmExpression: t_user_${user_id % 2}
keyGenerator:
type: SNOWFLAKE
column: user_id
defaultTableStrategy:
none:
defaultDatabaseStrategy:
none:
masterSlaveRules:
ds_0:
masterDataSourceName: ds_master_0
slaveDataSourceNames: [ds_master_0_slave_0, ds_master_0_slave_1]
loadBalanceAlgorithmType: ROUND_ROBIN
ds_1:
masterDataSourceName: ds_master_1
slaveDataSourceNames: [ds_master_1_slave_0, ds_master_1_slave_1]
loadBalanceAlgorithmType: ROUND_ROBIN
encryptRule:
encryptors:
encryptor_aes:
type: aes
props:
aes.key.value: 123456abc
tables:
t_user:
columns:
user_name:
plainColumn: user_name_plain
cipherColumn: user_name
encryptor: encryptor_aes
```
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[incubator-shardingsphere-benchmark] branch master updated: for performance
This is an automated email from the ASF dual-hosted git repository. zhaoyanan pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-shardingsphere-benchmark.git The following commit(s) were added to refs/heads/master by this push: new 461a7a0 for performance 461a7a0 is described below commit 461a7a02f15e38b327610a227bc884df98cdb899 Author: nancyzrh AuthorDate: Sun Dec 29 13:41:00 2019 +0800 for performance --- report/data/3.0_single_delete_merge.log_plot| 1 + report/data/3.0_single_insert_merge.log_plot| 1 + report/data/3.0_single_select_merge.log_plot| 1 + report/data/3.0_single_update_merge.log_plot| 1 + report/data/3.0_sp_delete_raw_merge.log_plot| 1 + report/data/3.0_sp_insert_raw_merge.log_plot| 1 + report/data/3.0_sp_select_raw_merge.log_plot| 1 + report/data/3.0_sp_update_raw_merge.log_plot| 1 + report/data/4.0_single_delete_merge.log_plot| 1 + report/data/4.0_single_insert_merge.log_plot| 1 + report/data/4.0_single_update_merge.log_plot| 1 + report/data/4.0_sp_delete_raw_merge.log_plot| 1 + report/data/4.0_sp_insert_raw_merge.log_plot| 1 + report/data/4.0_sp_update_raw_merge.log_plot| 1 + report/data/direct_delete_merge.log_plot| 1 + report/data/direct_update_merge.log_plot| 1 + report/data/encrypt/4.0_sp_delete_enc.log_plot | 1 + report/data/encrypt/4.0_sp_delete_enc_sharding.log_plot | 1 + report/data/encrypt/4.0_sp_insert_enc.log_plot | 1 + report/data/encrypt/4.0_sp_insert_enc_sharding.log_plot | 1 + report/data/encrypt/4.0_sp_update_enc.log_plot | 1 + report/data/encrypt/4.0_sp_update_enc_sharding.log_plot | 1 + report/data/jdbc/3.0_sj_ms_delete.log_plot | 1 + report/data/jdbc/3.0_sj_ms_insert.log_plot | 1 + report/data/jdbc/3.0_sj_ms_select.log_plot | 1 + report/data/jdbc/3.0_sj_ms_sharding_delete.log_plot | 1 + report/data/jdbc/3.0_sj_ms_sharding_insert.log_plot | 1 + report/data/jdbc/3.0_sj_ms_sharding_update.log_plot | 1 + report/data/jdbc/3.0_sj_sharding_delete.log_plot| 1 + report/data/jdbc/3.0_sj_sharding_insert.log_plot| 1 + report/data/jdbc/3.0_sj_sharding_update.log_plot| 1 + report/data/jdbc/4.0_sj_delete_raw.log_plot | 1 + report/data/jdbc/4.0_sj_enc_delete.log_plot | 1 + report/data/jdbc/4.0_sj_enc_delete_sharding.log_plot| 1 + report/data/jdbc/4.0_sj_enc_insert.log_plot | 1 + report/data/jdbc/4.0_sj_enc_insert_sharding.log_plot| 1 + report/data/jdbc/4.0_sj_enc_update.log_plot | 1 + report/data/jdbc/4.0_sj_enc_update_sharding.log_plot| 1 + report/data/jdbc/4.0_sj_insert_raw.log_plot | 1 + report/data/jdbc/4.0_sj_ms_delete.log_plot | 1 + report/data/jdbc/4.0_sj_ms_insert.log_plot | 1 + report/data/jdbc/4.0_sj_ms_sharding_delete.log_plot | 1 + report/data/jdbc/4.0_sj_ms_sharding_insert.log_plot | 1 + report/data/jdbc/4.0_sj_ms_sharding_update.log_plot | 1 + report/data/jdbc/4.0_sj_ms_update.log_plot | 1 + report/data/jdbc/4.0_sj_sharding_delete.log_plot| 1 + report/data/jdbc/4.0_sj_sharding_insert.log_plot| 1 + report/data/jdbc/4.0_sj_sharding_update.log_plot| 1 + report/data/jdbc/4.0_sj_update_raw.log_plot | 1 + report/data/master_slave/3.0_sp_delete_ms.log_plot | 1 + report/data/master_slave/3.0_sp_delete_ms_sharding.log_plot | 1 + report/data/master_slave/3.0_sp_insert_ms.log_plot | 1 + report/data/master_slave/3.0_sp_insert_ms_sharding.log_plot | 1 + report/data/master_slave/3.0_sp_select_ms.log_plot | 1 + report/data/master_slave/3.0_sp_select_ms_sharding.log_plot | 1 + report/data/master_slave/3.0_sp_update_ms.log_plot | 1 + report/data/master_slave/3.0_sp_update_ms_sharding.log_plot | 1 + report/data/master_slave/4.0_sp_delete_ms.log_plot | 1 + report/data/master_slave/4.0_sp_delete_ms_sharding.log_plot | 1 + report/data/master_slave/4.0_sp_insert_ms.log_plot | 1 + report/data/master_slave/4.0_sp_insert_ms_sharding.log_plot | 1 + report/data/master_slave/4.0_sp_update_ms.log_plot | 1 + report/data/master_slave/4.0_sp_update_ms_sharding.log_plot | 1 + report/jtl_json/full_route_test.json| 2 +- report/jtl_json/master_slave_encrypt_sharding_test.json | 2 +- report/jtl_json/single_route_test.json | 2 +- 66 files changed, 66 insertions(+), 3 deletions(-) diff --git
[GitHub] [incubator-shardingsphere] terrymanu merged pull request #3828: Upgrade antlr version
terrymanu merged pull request #3828: Upgrade antlr version URL: https://github.com/apache/incubator-shardingsphere/pull/3828 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] haetao commented on a change in pull request #3824: Modify the way to identify Rule Configuration in Config Center
haetao commented on a change in pull request #3824: Modify the way to identify
Rule Configuration in Config Center
URL:
https://github.com/apache/incubator-shardingsphere/pull/3824#discussion_r361824668
##
File path:
sharding-orchestration/sharding-orchestration-core/src/main/java/org/apache/shardingsphere/orchestration/internal/registry/config/service/ConfigurationService.java
##
@@ -174,7 +174,13 @@ private boolean hasProperties() {
* @return is sharding rule or not
*/
public boolean isShardingRule(final String shardingSchemaName) {
-return
regCenter.getDirectly(configNode.getRulePath(shardingSchemaName)).contains("tables:\n");
+if
(regCenter.getDirectly(configNode.getRulePath(shardingSchemaName)).contains("encryptRule:\n"))
{
Review comment:
The rule configuration in registry center format is as follows when
sharding only.
```
tables:
t_address:
actualDataNodes: ds_${0..1}.t_address
logicTable: t_address
t_order:
actualDataNodes: ds_${0..1}.t_order_${0..1}
databaseStrategy:
inline:
algorithmExpression: ds_${user_id % 2}
shardingColumn: user_id
keyGenerator:
column: order_id
type: SNOWFLAKE
logicTable: t_order
tableStrategy:
inline:
algorithmExpression: t_order_${order_id % 2}
shardingColumn: order_id
t_order_item:
actualDataNodes: ds_${0..1}.t_order_item_${0..1}
databaseStrategy:
inline:
algorithmExpression: ds_${user_id % 2}
shardingColumn: user_id
keyGenerator:
column: order_id
type: SNOWFLAKE
logicTable: t_order_item
tableStrategy:
inline:
algorithmExpression: t_order_item_${order_id % 2}
shardingColumn: order_id
```
We just make sure the rule is not encrypt only. the encrypt only rule
configuration in registry center is as follows.
```
encryptors:
encryptor_aes:
type: aes
props:
aes.key.value: 123456abc
encryptor_md5:
type: md5
tables:
t_user:
columns:
user_name:
plainColumn: user_name
cipherColumn: user_name_plain
encryptor: encryptor_aes
```
The complex rule is as follows. it will be as shardingRule
```
tables:
t_user:
actualDataNodes: ds_${0..1}.t_user_${0..1}
databaseStrategy:
inline:
shardingColumn: user_id
algorithmExpression: ds_${user_id % 2}
tableStrategy:
inline:
shardingColumn: user_id
algorithmExpression: t_user_${user_id % 2}
keyGenerator:
type: SNOWFLAKE
column: user_id
defaultTableStrategy:
none:
defaultDatabaseStrategy:
none:
masterSlaveRules:
ds_0:
masterDataSourceName: ds_master_0
slaveDataSourceNames: [ds_master_0_slave_0, ds_master_0_slave_1]
loadBalanceAlgorithmType: ROUND_ROBIN
ds_1:
masterDataSourceName: ds_master_1
slaveDataSourceNames: [ds_master_1_slave_0, ds_master_1_slave_1]
loadBalanceAlgorithmType: ROUND_ROBIN
encryptRule:
encryptors:
encryptor_aes:
type: aes
props:
aes.key.value: 123456abc
tables:
t_user:
columns:
user_name:
plainColumn: user_name_plain
cipherColumn: user_name
encryptor: encryptor_aes
```
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] HongJinFeng edited a comment on issue #3635: Must the table name be lowercase when set by sharding conifg?
HongJinFeng edited a comment on issue #3635: Must the table name be lowercase when set by sharding conifg? URL: https://github.com/apache/incubator-shardingsphere/issues/3635#issuecomment-569467557 After my investigation, The constructor method of class TableRule convert logic table name to lower case cause this issue, Can i ask the reason why convert logic table to lower case? What is the concern? It must has a reason that convert logic table to lower case. If not , just remove toLowerCase method will fix the issue.(Remove the logic of lower case logic table name, the unit tests of class TableRule all pass) @terrymanu This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] HongJinFeng edited a comment on issue #3635: Must the table name be lowercase when set by sharding conifg?
HongJinFeng edited a comment on issue #3635: Must the table name be lowercase when set by sharding conifg? URL: https://github.com/apache/incubator-shardingsphere/issues/3635#issuecomment-569467557 After my investigation, The constructor method of class TableRule convert logic table name to lower case cause this issue, Can i ask the reason why convert logic table to lower case? What is the concern? It must has a reason that convert logic table to lower case. If not , just remove toLowerCase method will fix the issue.(Remove the logic of lower case logic table, the unit tests of class TableRule all pass) @terrymanu This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] HongJinFeng edited a comment on issue #3635: Must the table name be lowercase when set by sharding conifg?
HongJinFeng edited a comment on issue #3635: Must the table name be lowercase when set by sharding conifg? URL: https://github.com/apache/incubator-shardingsphere/issues/3635#issuecomment-569467557 After my investigation, The constructor method of class TableRule convert logic table name to lower case cause this issue, Can i ask the reason why convert logic table to lower case? What is the concern? It must has a reason that convert logic table to lower case. If not , just remove toLowerCase method will fix the issue. @terrymanu This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] HongJinFeng edited a comment on issue #3635: Must the table name be lowercase when set by sharding conifg?
HongJinFeng edited a comment on issue #3635: Must the table name be lowercase when set by sharding conifg? URL: https://github.com/apache/incubator-shardingsphere/issues/3635#issuecomment-569467557 After my investigation, The constructor method of class TableRule convert logic table name to lower case cause this issue, Can i ask the reason? What is the concern? It must has a reason that convert logic table to lower case. If not , just remove toLowerCase method will fix the issue. @terrymanu This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] HongJinFeng edited a comment on issue #3635: Must the table name be lowercase when set by sharding conifg?
HongJinFeng edited a comment on issue #3635: Must the table name be lowercase when set by sharding conifg? URL: https://github.com/apache/incubator-shardingsphere/issues/3635#issuecomment-569467557 After my investigation, The constructor method of class TableRule convert logic table name to lower case cause this issue, Can i ask the reason? What is the concern? It must has a reason that convert logic table to lower case. @terrymanu This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] HongJinFeng commented on issue #3635: Must the table name be lowercase when set by sharding conifg?
HongJinFeng commented on issue #3635: Must the table name be lowercase when set by sharding conifg? URL: https://github.com/apache/incubator-shardingsphere/issues/3635#issuecomment-569467557 After my investigation, The constructor method of class TableRule convert logic table name to lower case, Can i ask the reason? What is the concern? It must has a reason that convert logic table to lower case. @terrymanu This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] coveralls commented on issue #3828: Upgrade antlr version
coveralls commented on issue #3828: Upgrade antlr version URL: https://github.com/apache/incubator-shardingsphere/pull/3828#issuecomment-569455599 ## Pull Request Test Coverage Report for [Build 1246](https://coveralls.io/builds/27829166) * **0** of **0** changed or added relevant lines in **0** files are covered. * No unchanged relevant lines lost coverage. * Overall coverage remained the same at **67.547%** --- | Totals | [](https://coveralls.io/builds/27829166) | | :-- | --: | | Change from base [Build 636](https://coveralls.io/builds/27826432): | 0.0% | | Covered Lines: | 11275 | | Relevant Lines: | 16692 | --- # - [Coveralls](https://coveralls.io) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] SteNicholas opened a new pull request #3828: Upgrade antlr version
SteNicholas opened a new pull request #3828: Upgrade antlr version URL: https://github.com/apache/incubator-shardingsphere/pull/3828 Latest version of Antlr4 maven repository is [4.7.2](https://mvnrepository.com/artifact/org.antlr/antlr4-runtime/4.7.2), and to follow the latest version. Changes proposed in this pull request: - Update the version of Antlr4 maven repository to 4.7.2 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] SteNicholas removed a comment on issue #3817: Sharding-Proxy starts up failed with Orchestration in scenario `sharding+encrypt+masterSlave`.
SteNicholas removed a comment on issue #3817: Sharding-Proxy starts up failed with Orchestration in scenario `sharding+encrypt+masterSlave`. URL: https://github.com/apache/incubator-shardingsphere/issues/3817#issuecomment-569218202 @haetao I don't understand the bug you said about. And Why the version sharding-proxy is RC4? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] SteNicholas commented on issue #3822: SQLParseEngine parse mysql update sql fail
SteNicholas commented on issue #3822: SQLParseEngine parse mysql update sql fail
URL:
https://github.com/apache/incubator-shardingsphere/issues/3822#issuecomment-569452195
@caszhou You should modify the SQL like
```
System.out.println(engine.parse("UPDATE tenant_vehicle SET
tenant_id=?,\nvin=?,\nsource=?,\ncreate_time=?,\nupdate_time=?,\nversion=?
WHERE id=? AND version=?", true));
```
or
```
System.out.println(engine.parse("UPDATE tenant_vehicle SET
tenant_id=?,'\n'vin=?,'\n'source=?,'\n''\n''\n'create_time=?,'\n'update_time=?,'\n'version=?
WHERE id=? AND version=?", true));
```
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] coveralls edited a comment on issue #3827: update jacoco to improve unit coverage
coveralls edited a comment on issue #3827: update jacoco to improve unit coverage URL: https://github.com/apache/incubator-shardingsphere/pull/3827#issuecomment-569425290 ## Pull Request Test Coverage Report for [Build 1245](https://coveralls.io/builds/27826261) * **0** of **0** changed or added relevant lines in **0** files are covered. * No unchanged relevant lines lost coverage. * Overall coverage increased (+**0.3%**) to **67.547%** --- | Totals | [](https://coveralls.io/builds/27826261) | | :-- | --: | | Change from base [Build 635](https://coveralls.io/builds/27825086): | 0.3% | | Covered Lines: | 11275 | | Relevant Lines: | 16692 | --- # - [Coveralls](https://coveralls.io) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu closed issue #3826: improve unit coverage by ignoring lombok code in jacoco
terrymanu closed issue #3826: improve unit coverage by ignoring lombok code in jacoco URL: https://github.com/apache/incubator-shardingsphere/issues/3826 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu merged pull request #3827: update jacoco to improve unit coverage
terrymanu merged pull request #3827: update jacoco to improve unit coverage URL: https://github.com/apache/incubator-shardingsphere/pull/3827 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] coveralls commented on issue #3827: update jacoco to improve unit coverage
coveralls commented on issue #3827: update jacoco to improve unit coverage URL: https://github.com/apache/incubator-shardingsphere/pull/3827#issuecomment-569425290 ## Pull Request Test Coverage Report for [Build 1243](https://coveralls.io/builds/27826047) * **0** of **0** changed or added relevant lines in **0** files are covered. * No unchanged relevant lines lost coverage. * Overall coverage increased (+**0.3%**) to **67.547%** --- | Totals | [](https://coveralls.io/builds/27826047) | | :-- | --: | | Change from base [Build 635](https://coveralls.io/builds/27825086): | 0.3% | | Covered Lines: | 11275 | | Relevant Lines: | 16692 | --- # - [Coveralls](https://coveralls.io) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] sluk3r opened a new pull request #3827: update jacoco to improve unit coverage
sluk3r opened a new pull request #3827: update jacoco to improve unit coverage URL: https://github.com/apache/incubator-shardingsphere/pull/3827 Fixes #3826. Changes proposed in this pull request: - update jacoco to 0.8.0, from original 0.7.9 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] sluk3r opened a new issue #3826: improve unit coverage by ignoring lombok code in jacoco
sluk3r opened a new issue #3826: improve unit coverage by ignoring lombok code in jacoco URL: https://github.com/apache/incubator-shardingsphere/issues/3826 It seems that, by ignoring lombok code in jacoco, we can improve unit coverage hugely. Demo example is [here](https://mp.weixin.qq.com/s/oLT7Kxm5fhl_nICeuMVJIg) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu merged pull request #3825: fix XA of sharding-jdbc could not compatible with postgresql
terrymanu merged pull request #3825: fix XA of sharding-jdbc could not compatible with postgresql URL: https://github.com/apache/incubator-shardingsphere/pull/3825 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu commented on a change in pull request #3824: Modify the way to identify Rule Configuration in Config Center
terrymanu commented on a change in pull request #3824: Modify the way to
identify Rule Configuration in Config Center
URL:
https://github.com/apache/incubator-shardingsphere/pull/3824#discussion_r361793479
##
File path:
sharding-orchestration/sharding-orchestration-core/src/main/java/org/apache/shardingsphere/orchestration/internal/registry/config/service/ConfigurationService.java
##
@@ -174,7 +174,13 @@ private boolean hasProperties() {
* @return is sharding rule or not
*/
public boolean isShardingRule(final String shardingSchemaName) {
-return
regCenter.getDirectly(configNode.getRulePath(shardingSchemaName)).contains("tables:\n");
+if
(regCenter.getDirectly(configNode.getRulePath(shardingSchemaName)).contains("encryptRule:\n"))
{
Review comment:
Incorrect if sharding only
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu merged pull request #3821: Add shadow rule for springboot starter
terrymanu merged pull request #3821: Add shadow rule for springboot starter URL: https://github.com/apache/incubator-shardingsphere/pull/3821 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
