[GitHub] [incubator-shardingsphere] SteNicholas merged pull request #4013: rename to booleanPrimary
SteNicholas merged pull request #4013: rename to booleanPrimary URL: https://github.com/apache/incubator-shardingsphere/pull/4013 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] darcydai commented on issue #3964: Hintmanager databaseShardingOnly problem
darcydai commented on issue #3964: Hintmanager databaseShardingOnly problem URL: https://github.com/apache/incubator-shardingsphere/issues/3964#issuecomment-575921675 maybe I have the same problem, in my case , I configuration is `spring.shardingsphere.datasource.names=house,shenyang,beijing spring.shardingsphere.datasource.house.type=com.zaxxer.hikari.HikariDataSource spring.shardingsphere.datasource.house.driver-class-name=com.mysql.jdbc.Driver spring.shardingsphere.datasource.house.jdbc-url=jdbc:mysql://localhost:21010/db_house?useSSL=false&useUnicode=true&characterEncoding=utf8 spring.shardingsphere.datasource.house.username=root spring.shardingsphere.datasource.house.password=aA11 spring.shardingsphere.datasource.shenyang.type=com.zaxxer.hikari.HikariDataSource spring.shardingsphere.datasource.shenyang.driver-class-name=com.mysql.jdbc.Driver spring.shardingsphere.datasource.shenyang.jdbc-url=jdbc:mysql://localhost:21010/db_shenyang?useSSL=false&useUnicode=true&characterEncoding=utf8 spring.shardingsphere.datasource.shenyang.username=root spring.shardingsphere.datasource.shenyang.password=aA11 spring.shardingsphere.datasource.beijing.type=com.zaxxer.hikari.HikariDataSource spring.shardingsphere.datasource.beijing.driver-class-name=com.mysql.jdbc.Driver spring.shardingsphere.datasource.beijing.jdbc-url=jdbc:mysql://localhost:21010/db_beijing?useSSL=false&useUnicode=true&characterEncoding=utf8 spring.shardingsphere.datasource.beijing.username=root spring.shardingsphere.datasource.beijing.password=aA11 spring.shardingsphere.sharding.default-database-strategy.hint.algorithm-class-name=com.mh.house.sharding.CityBaseHintShardingAlgorithm ` but the method trace never enters my defined HintShardingAlgorithm ->CityBaseHintShardingAlgorithm. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] darcydai commented on issue #3964: Hintmanager databaseShardingOnly problem
darcydai commented on issue #3964: Hintmanager databaseShardingOnly problem URL: https://github.com/apache/incubator-shardingsphere/issues/3964#issuecomment-575921776 maybe I have the same problem, in my case , I configuration is `spring.shardingsphere.datasource.names=house,shenyang,beijing spring.shardingsphere.datasource.house.type=com.zaxxer.hikari.HikariDataSource spring.shardingsphere.datasource.house.driver-class-name=com.mysql.jdbc.Driver spring.shardingsphere.datasource.house.jdbc-url=jdbc:mysql://localhost:21010/db_house?useSSL=false&useUnicode=true&characterEncoding=utf8 spring.shardingsphere.datasource.house.username=root spring.shardingsphere.datasource.house.password=aA11 spring.shardingsphere.datasource.shenyang.type=com.zaxxer.hikari.HikariDataSource spring.shardingsphere.datasource.shenyang.driver-class-name=com.mysql.jdbc.Driver spring.shardingsphere.datasource.shenyang.jdbc-url=jdbc:mysql://localhost:21010/db_shenyang?useSSL=false&useUnicode=true&characterEncoding=utf8 spring.shardingsphere.datasource.shenyang.username=root spring.shardingsphere.datasource.shenyang.password=aA11 spring.shardingsphere.datasource.beijing.type=com.zaxxer.hikari.HikariDataSource spring.shardingsphere.datasource.beijing.driver-class-name=com.mysql.jdbc.Driver spring.shardingsphere.datasource.beijing.jdbc-url=jdbc:mysql://localhost:21010/db_beijing?useSSL=false&useUnicode=true&characterEncoding=utf8 spring.shardingsphere.datasource.beijing.username=root spring.shardingsphere.datasource.beijing.password=aA11 spring.shardingsphere.sharding.default-database-strategy.hint.algorithm-class-name=com.mh.house.sharding.CityBaseHintShardingAlgorithm` but the method trace never enters my defined HintShardingAlgorithm ->CityBaseHintShardingAlgorithm. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] darcydai removed a comment on issue #3964: Hintmanager databaseShardingOnly problem
darcydai removed a comment on issue #3964: Hintmanager databaseShardingOnly problem URL: https://github.com/apache/incubator-shardingsphere/issues/3964#issuecomment-575921675 maybe I have the same problem, in my case , I configuration is `spring.shardingsphere.datasource.names=house,shenyang,beijing spring.shardingsphere.datasource.house.type=com.zaxxer.hikari.HikariDataSource spring.shardingsphere.datasource.house.driver-class-name=com.mysql.jdbc.Driver spring.shardingsphere.datasource.house.jdbc-url=jdbc:mysql://localhost:21010/db_house?useSSL=false&useUnicode=true&characterEncoding=utf8 spring.shardingsphere.datasource.house.username=root spring.shardingsphere.datasource.house.password=aA11 spring.shardingsphere.datasource.shenyang.type=com.zaxxer.hikari.HikariDataSource spring.shardingsphere.datasource.shenyang.driver-class-name=com.mysql.jdbc.Driver spring.shardingsphere.datasource.shenyang.jdbc-url=jdbc:mysql://localhost:21010/db_shenyang?useSSL=false&useUnicode=true&characterEncoding=utf8 spring.shardingsphere.datasource.shenyang.username=root spring.shardingsphere.datasource.shenyang.password=aA11 spring.shardingsphere.datasource.beijing.type=com.zaxxer.hikari.HikariDataSource spring.shardingsphere.datasource.beijing.driver-class-name=com.mysql.jdbc.Driver spring.shardingsphere.datasource.beijing.jdbc-url=jdbc:mysql://localhost:21010/db_beijing?useSSL=false&useUnicode=true&characterEncoding=utf8 spring.shardingsphere.datasource.beijing.username=root spring.shardingsphere.datasource.beijing.password=aA11 spring.shardingsphere.sharding.default-database-strategy.hint.algorithm-class-name=com.mh.house.sharding.CityBaseHintShardingAlgorithm ` but the method trace never enters my defined HintShardingAlgorithm ->CityBaseHintShardingAlgorithm. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] darcydai removed a comment on issue #3964: Hintmanager databaseShardingOnly problem
darcydai removed a comment on issue #3964: Hintmanager databaseShardingOnly problem URL: https://github.com/apache/incubator-shardingsphere/issues/3964#issuecomment-575921776 maybe I have the same problem, in my case , I configuration is `spring.shardingsphere.datasource.names=house,shenyang,beijing spring.shardingsphere.datasource.house.type=com.zaxxer.hikari.HikariDataSource spring.shardingsphere.datasource.house.driver-class-name=com.mysql.jdbc.Driver spring.shardingsphere.datasource.house.jdbc-url=jdbc:mysql://localhost:21010/db_house?useSSL=false&useUnicode=true&characterEncoding=utf8 spring.shardingsphere.datasource.house.username=root spring.shardingsphere.datasource.house.password=aA11 spring.shardingsphere.datasource.shenyang.type=com.zaxxer.hikari.HikariDataSource spring.shardingsphere.datasource.shenyang.driver-class-name=com.mysql.jdbc.Driver spring.shardingsphere.datasource.shenyang.jdbc-url=jdbc:mysql://localhost:21010/db_shenyang?useSSL=false&useUnicode=true&characterEncoding=utf8 spring.shardingsphere.datasource.shenyang.username=root spring.shardingsphere.datasource.shenyang.password=aA11 spring.shardingsphere.datasource.beijing.type=com.zaxxer.hikari.HikariDataSource spring.shardingsphere.datasource.beijing.driver-class-name=com.mysql.jdbc.Driver spring.shardingsphere.datasource.beijing.jdbc-url=jdbc:mysql://localhost:21010/db_beijing?useSSL=false&useUnicode=true&characterEncoding=utf8 spring.shardingsphere.datasource.beijing.username=root spring.shardingsphere.datasource.beijing.password=aA11 spring.shardingsphere.sharding.default-database-strategy.hint.algorithm-class-name=com.mh.house.sharding.CityBaseHintShardingAlgorithm` but the method trace never enters my defined HintShardingAlgorithm ->CityBaseHintShardingAlgorithm. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] darcydai commented on issue #3964: Hintmanager databaseShardingOnly problem
darcydai commented on issue #3964: Hintmanager databaseShardingOnly problem URL: https://github.com/apache/incubator-shardingsphere/issues/3964#issuecomment-575921857 maybe I have the same problem, in my case , I configuration is ` spring.shardingsphere.datasource.names=house,shenyang,beijing spring.shardingsphere.datasource.house.type=com.zaxxer.hikari.HikariDataSource spring.shardingsphere.datasource.house.driver-class-name=com.mysql.jdbc.Driver spring.shardingsphere.datasource.house.jdbc-url=jdbc:mysql://localhost:21010/db_house?useSSL=false&useUnicode=true&characterEncoding=utf8 spring.shardingsphere.datasource.house.username=root spring.shardingsphere.datasource.house.password=aA11 spring.shardingsphere.datasource.shenyang.type=com.zaxxer.hikari.HikariDataSource spring.shardingsphere.datasource.shenyang.driver-class-name=com.mysql.jdbc.Driver spring.shardingsphere.datasource.shenyang.jdbc-url=jdbc:mysql://localhost:21010/db_shenyang?useSSL=false&useUnicode=true&characterEncoding=utf8 spring.shardingsphere.datasource.shenyang.username=root spring.shardingsphere.datasource.shenyang.password=aA11 spring.shardingsphere.datasource.beijing.type=com.zaxxer.hikari.HikariDataSource spring.shardingsphere.datasource.beijing.driver-class-name=com.mysql.jdbc.Driver spring.shardingsphere.datasource.beijing.jdbc-url=jdbc:mysql://localhost:21010/db_beijing?useSSL=false&useUnicode=true&characterEncoding=utf8 spring.shardingsphere.datasource.beijing.username=root spring.shardingsphere.datasource.beijing.password=aA11 spring.shardingsphere.sharding.default-database-strategy.hint.algorithm-class-name=com.mh.house.sharding.CityBaseHintShardingAlgorithm ` but the method trace never enters my defined HintShardingAlgorithm ->CityBaseHintShardingAlgorithm. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] darcydai removed a comment on issue #3964: Hintmanager databaseShardingOnly problem
darcydai removed a comment on issue #3964: Hintmanager databaseShardingOnly problem URL: https://github.com/apache/incubator-shardingsphere/issues/3964#issuecomment-575921857 maybe I have the same problem, in my case , I configuration is ` spring.shardingsphere.datasource.names=house,shenyang,beijing spring.shardingsphere.datasource.house.type=com.zaxxer.hikari.HikariDataSource spring.shardingsphere.datasource.house.driver-class-name=com.mysql.jdbc.Driver spring.shardingsphere.datasource.house.jdbc-url=jdbc:mysql://localhost:21010/db_house?useSSL=false&useUnicode=true&characterEncoding=utf8 spring.shardingsphere.datasource.house.username=root spring.shardingsphere.datasource.house.password=aA11 spring.shardingsphere.datasource.shenyang.type=com.zaxxer.hikari.HikariDataSource spring.shardingsphere.datasource.shenyang.driver-class-name=com.mysql.jdbc.Driver spring.shardingsphere.datasource.shenyang.jdbc-url=jdbc:mysql://localhost:21010/db_shenyang?useSSL=false&useUnicode=true&characterEncoding=utf8 spring.shardingsphere.datasource.shenyang.username=root spring.shardingsphere.datasource.shenyang.password=aA11 spring.shardingsphere.datasource.beijing.type=com.zaxxer.hikari.HikariDataSource spring.shardingsphere.datasource.beijing.driver-class-name=com.mysql.jdbc.Driver spring.shardingsphere.datasource.beijing.jdbc-url=jdbc:mysql://localhost:21010/db_beijing?useSSL=false&useUnicode=true&characterEncoding=utf8 spring.shardingsphere.datasource.beijing.username=root spring.shardingsphere.datasource.beijing.password=aA11 spring.shardingsphere.sharding.default-database-strategy.hint.algorithm-class-name=com.mh.house.sharding.CityBaseHintShardingAlgorithm ` but the method trace never enters my defined HintShardingAlgorithm ->CityBaseHintShardingAlgorithm. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] darcydai commented on issue #3964: Hintmanager databaseShardingOnly problem
darcydai commented on issue #3964: Hintmanager databaseShardingOnly problem URL: https://github.com/apache/incubator-shardingsphere/issues/3964#issuecomment-575922280 maybe I have the same problem, in my case (springboot), I configuration is ``` spring.shardingsphere.datasource.names=house,shenyang,beijing spring.shardingsphere.datasource.house.type=com.zaxxer.hikari.HikariDataSource spring.shardingsphere.datasource.house.driver-class-name=com.mysql.jdbc.Driver spring.shardingsphere.datasource.house.jdbc-url=jdbc:mysql://localhost:21010/db_house?useSSL=false&useUnicode=true&characterEncoding=utf8 spring.shardingsphere.datasource.house.username=root spring.shardingsphere.datasource.house.password=aA11 spring.shardingsphere.datasource.shenyang.type=com.zaxxer.hikari.HikariDataSource spring.shardingsphere.datasource.shenyang.driver-class-name=com.mysql.jdbc.Driver spring.shardingsphere.datasource.shenyang.jdbc-url=jdbc:mysql://localhost:21010/db_shenyang?useSSL=false&useUnicode=true&characterEncoding=utf8 spring.shardingsphere.datasource.shenyang.username=root spring.shardingsphere.datasource.shenyang.password=aA11 spring.shardingsphere.datasource.beijing.type=com.zaxxer.hikari.HikariDataSource spring.shardingsphere.datasource.beijing.driver-class-name=com.mysql.jdbc.Driver spring.shardingsphere.datasource.beijing.jdbc-url=jdbc:mysql://localhost:21010/db_beijing?useSSL=false&useUnicode=true&characterEncoding=utf8 spring.shardingsphere.datasource.beijing.username=root spring.shardingsphere.datasource.beijing.password=aA11 spring.shardingsphere.sharding.default-database-strategy.hint.algorithm-class-name=com.mh.house.sharding.CityBaseHintShardingAlgorithm ``` but the method trace never enters my defined CityBaseHintShardingAlgorithm. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] darcydai commented on issue #3964: Hintmanager databaseShardingOnly problem
darcydai commented on issue #3964: Hintmanager databaseShardingOnly problem URL: https://github.com/apache/incubator-shardingsphere/issues/3964#issuecomment-575922419 > maybe I have the same problem, in my case (springboot), I configuration is > > ``` > spring.shardingsphere.datasource.names=house,shenyang,beijing > > spring.shardingsphere.datasource.house.type=com.zaxxer.hikari.HikariDataSource > spring.shardingsphere.datasource.house.driver-class-name=com.mysql.jdbc.Driver > spring.shardingsphere.datasource.house.jdbc-url=jdbc:mysql://localhost:21010/db_house?useSSL=false&useUnicode=true&characterEncoding=utf8 > spring.shardingsphere.datasource.house.username=root > spring.shardingsphere.datasource.house.password=aA11 > > spring.shardingsphere.datasource.shenyang.type=com.zaxxer.hikari.HikariDataSource > spring.shardingsphere.datasource.shenyang.driver-class-name=com.mysql.jdbc.Driver > spring.shardingsphere.datasource.shenyang.jdbc-url=jdbc:mysql://localhost:21010/db_shenyang?useSSL=false&useUnicode=true&characterEncoding=utf8 > spring.shardingsphere.datasource.shenyang.username=root > spring.shardingsphere.datasource.shenyang.password=aA11 > > spring.shardingsphere.datasource.beijing.type=com.zaxxer.hikari.HikariDataSource > spring.shardingsphere.datasource.beijing.driver-class-name=com.mysql.jdbc.Driver > spring.shardingsphere.datasource.beijing.jdbc-url=jdbc:mysql://localhost:21010/db_beijing?useSSL=false&useUnicode=true&characterEncoding=utf8 > spring.shardingsphere.datasource.beijing.username=root > spring.shardingsphere.datasource.beijing.password=aA11 > spring.shardingsphere.sharding.default-database-strategy.hint.algorithm-class-name=com.mh.house.sharding.CityBaseHintShardingAlgorithm > ``` > > but the method trace never enters my defined CityBaseHintShardingAlgorithm. and version is 4.0.0 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu opened a new pull request #4015: Complete projection assertion
terrymanu opened a new pull request #4015: Complete projection assertion URL: https://github.com/apache/incubator-shardingsphere/pull/4015 For #3947. Changes proposed in this pull request: - Complete generic projection assertion. - Complete shorthand projection assertion. - Complete column projection assertion. - Complete aggregation projection assertion. - Complete aggregation distinct projection assertion. - Complete expr projection assertion. - Complete top projection assertion. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] dongzl merged pull request #4015: Complete projection assertion
dongzl merged pull request #4015: Complete projection assertion URL: https://github.com/apache/incubator-shardingsphere/pull/4015 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] ssxlulu commented on issue #4014: Not support JDBC getCatalog
ssxlulu commented on issue #4014: Not support JDBC getCatalog URL: https://github.com/apache/incubator-shardingsphere/issues/4014#issuecomment-575956699 Yes, we haven't support the feature now. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] ssxlulu commented on issue #3970: Got many warn message: com.mysql.jdbc.jdbc2.optional.MysqlXAException: Undetermined error occurred in the underlying Connection -
ssxlulu commented on issue #3970: Got many warn message: com.mysql.jdbc.jdbc2.optional.MysqlXAException: Undetermined error occurred in the underlying Connection - check your data for consistency URL: https://github.com/apache/incubator-shardingsphere/issues/3970#issuecomment-575958327 @longzhihun Hi, It may be a communication failure that raise the distribution transaction exception. You can execute `XA RECOVER` in the mysql server to see the further information. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] coveralls commented on issue #4015: Complete projection assertion
coveralls commented on issue #4015: Complete projection assertion URL: https://github.com/apache/incubator-shardingsphere/pull/4015#issuecomment-575958769 ## Pull Request Test Coverage Report for [Build 1412](https://coveralls.io/builds/28192451) * **5** of **7** **(71.43%)** changed or added relevant lines in **3** files are covered. * No unchanged relevant lines lost coverage. * Overall coverage remained the same at **65.521%** --- | Changes Missing Coverage | Covered Lines | Changed/Added Lines | % | | :-|--||---: | | [shardingsphere-sql-parser/shardingsphere-sql-parser-engine/src/main/java/org/apache/shardingsphere/sql/parser/core/extractor/impl/dml/select/item/impl/TopProjectionExtractor.java](https://coveralls.io/builds/28192451/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-engine%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fcore%2Fextractor%2Fimpl%2Fdml%2Fselect%2Fitem%2Fimpl%2FTopProjectionExtractor.java#L58) | 0 | 2 | 0.0% | Totals | [](https://coveralls.io/builds/28192451) | | :-- | --: | | Change from base [Build 701](https://coveralls.io/builds/28187027): | 0.0% | | Covered Lines: | 10813 | | Relevant Lines: | 16503 | --- # 💛 - [Coveralls](https://coveralls.io) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] ssxlulu commented on issue #3963: ActualDataNodes must be configured if want to shard tables for logicTable xxxx
ssxlulu commented on issue #3963: ActualDataNodes must be configured if want to shard tables for logicTable URL: https://github.com/apache/incubator-shardingsphere/issues/3963#issuecomment-575959106 @KomachiSion Should we check the condition? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] KomachiSion commented on issue #3963: ActualDataNodes must be configured if want to shard tables for logicTable xxxx
KomachiSion commented on issue #3963: ActualDataNodes must be configured if want to shard tables for logicTable URL: https://github.com/apache/incubator-shardingsphere/issues/3963#issuecomment-575959420 It's true, if you want to do shard for table, you have to set actualNodes. Otherwise, the `availableTables` input to Algorithm maybe error. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] KomachiSion commented on issue #3963: ActualDataNodes must be configured if want to shard tables for logicTable xxxx
KomachiSion commented on issue #3963: ActualDataNodes must be configured if want to shard tables for logicTable URL: https://github.com/apache/incubator-shardingsphere/issues/3963#issuecomment-575959537 Refer issue #3680 . This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] ssxlulu commented on issue #3960: How to config sharding rule for dynamic capacity?
ssxlulu commented on issue #3960: How to config sharding rule for dynamic capacity? URL: https://github.com/apache/incubator-shardingsphere/issues/3960#issuecomment-575959600 In my opinion, reshard the data is a big work, and I think you should plan your data capacity in advance, like reserve storage for some years in advance. What's more, sharding-scaling module will help you dynamic scaling you data in the future. Sharding-scaling will be release in 5.x. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[incubator-shardingsphere-benchmark] branch master updated: for performance
This is an automated email from the ASF dual-hosted git repository.
zhaoyanan pushed a commit to branch master
in repository
https://gitbox.apache.org/repos/asf/incubator-shardingsphere-benchmark.git
The following commit(s) were added to refs/heads/master by this push:
new 6155279 for performance
6155279 is described below
commit 61552790262340927885942b1bbecea48a3e62a7
Author: nancyzrh
AuthorDate: Sun Jan 19 10:36:50 2020 +0800
for performance
---
report/jtl_json/full_route_test.json| 2 +-
report/jtl_json/master_slave_encrypt_sharding_test.json | 2 +-
report/jtl_json/master_slave_test.json | 2 +-
report/jtl_json/single_route_test.json | 2 +-
4 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/report/jtl_json/full_route_test.json
b/report/jtl_json/full_route_test.json
index d529458..c936e95 100644
--- a/report/jtl_json/full_route_test.json
+++ b/report/jtl_json/full_route_test.json
@@ -1 +1 @@
-{"SELECT": [{"data": [{"99.9th": "9", "Err": "0.0%", "95th": "2", "50th": "1",
"Max": "10", "Min": "0", "Throughout": "23036.87", "Samples": 4999, "Date":
"2019.12.19 02:35:57 ", "Avg": "0"}, {"99.9th": "9", "Err": "0.0%", "95th":
"2", "50th": "1", "Max": "9", "Min": "0", "Throughout": "22619.91", "Samples":
4999, "Date": "2019.12.20 13:34:47 ", "Avg": "0"}, {"99.9th": "9", "Err":
"0.0%", "95th": "2", "50th": "1", "Max": "9", "Min": "0", "Throughout":
"22931.19", "Samples": 4999, "Date": [...]
\ No newline at end of file
+{"SELECT": [{"data": [{"99.9th": "9", "Err": "0.0%", "95th": "2", "50th": "1",
"Max": "10", "Min": "0", "Throughout": "23036.87", "Samples": 4999, "Date":
"2019.12.19 02:35:57 ", "Avg": "0"}, {"99.9th": "9", "Err": "0.0%", "95th":
"2", "50th": "1", "Max": "9", "Min": "0", "Throughout": "22619.91", "Samples":
4999, "Date": "2019.12.20 13:34:47 ", "Avg": "0"}, {"99.9th": "9", "Err":
"0.0%", "95th": "2", "50th": "1", "Max": "9", "Min": "0", "Throughout":
"22931.19", "Samples": 4999, "Date": [...]
\ No newline at end of file
diff --git a/report/jtl_json/master_slave_encrypt_sharding_test.json
b/report/jtl_json/master_slave_encrypt_sharding_test.json
index 7abcefa..5d88667 100644
--- a/report/jtl_json/master_slave_encrypt_sharding_test.json
+++ b/report/jtl_json/master_slave_encrypt_sharding_test.json
@@ -1 +1 @@
-{"SELECT": [{"data": [{"99.9th": "16", "Err": "0.0%", "95th": "3", "50th":
"2", "Max": "66", "Min": "1", "Throughout": "9381.73", "Samples": 99,
"Date": "2019.12.19 02:40:33 ", "Avg": "2"}, {"99.9th": "16", "Err": "0.0%",
"95th": "3", "50th": "2", "Max": "62", "Min": "1", "Throughout": "9038.48",
"Samples": 99, "Date": "2019.12.20 13:39:23 ", "Avg": "2"}, {"99.9th":
"16", "Err": "0.0%", "95th": "3", "50th": "2", "Max": "63", "Min": "1",
"Throughout": "9071.44", "Samples": 99, [...]
\ No newline at end of file
+{"SELECT": [{"data": [{"99.9th": "16", "Err": "0.0%", "95th": "3", "50th":
"2", "Max": "66", "Min": "1", "Throughout": "9381.73", "Samples": 99,
"Date": "2019.12.19 02:40:33 ", "Avg": "2"}, {"99.9th": "16", "Err": "0.0%",
"95th": "3", "50th": "2", "Max": "62", "Min": "1", "Throughout": "9038.48",
"Samples": 99, "Date": "2019.12.20 13:39:23 ", "Avg": "2"}, {"99.9th":
"16", "Err": "0.0%", "95th": "3", "50th": "2", "Max": "63", "Min": "1",
"Throughout": "9071.44", "Samples": 99, [...]
\ No newline at end of file
diff --git a/report/jtl_json/master_slave_test.json
b/report/jtl_json/master_slave_test.json
index 8b60c21..47528fd 100644
--- a/report/jtl_json/master_slave_test.json
+++ b/report/jtl_json/master_slave_test.json
@@ -1 +1 @@
-{"INSERT+SELECT+DELETE": [{"data": [], "type": "Sharding-Proxy_3.1"}, {"data":
[{"99.9th": "38", "Err": "0.0%", "95th": "16", "50th": "11", "Max": "48",
"Min": "7", "Throughout": "1720.96", "Samples": 29709, "Date": "2020.01.01
02:49:45 ", "Avg": "11"}, {"99.9th": "27", "Err": "0.0%", "95th": "16", "50th":
"11", "Max": "37", "Min": "7", "Throughout": "1701.38", "Samples": 17218,
"Date": "2020.01.02 02:49:52 ", "Avg": "11"}, {"99.9th": "30", "Err": "0.0%",
"95th": "16", "50th": "11", "Max [...]
\ No newline at end of file
+{"INSERT+SELECT+DELETE": [{"data": [], "type": "Sharding-Proxy_3.1"}, {"data":
[{"99.9th": "38", "Err": "0.0%", "95th": "16", "50th": "11", "Max": "48",
"Min": "7", "Throughout": "1720.96", "Samples": 29709, "Date": "2020.01.01
02:49:45 ", "Avg": "11"}, {"99.9th": "27", "Err": "0.0%", "95th": "16", "50th":
"11", "Max": "37", "Min": "7", "Throughout": "1701.38", "Samples": 17218,
"Date": "2020.01.02 02:49:52 ", "Avg": "11"}, {"99.9th": "30", "Err": "0.0%",
"95th": "16", "50th": "11", "Max [...]
\ No newline at end of file
diff --git a/report/jtl_json/single_route_test.json
b/report/jtl_json/single_route_test.json
index 6cbc85f..f1f4890 100644
--- a/report/jtl_json/single_route_test.json
+++ b/report/jtl_json/single_route_test.json
@@ -1 +1 @@
-{"SELECT": [{"data": [], "type": "Sharding-Proxy_3.1"
[GitHub] [incubator-shardingsphere] Zze0 commented on issue #4002: Transactions cannot be rolled back properly when using local transaction.
Zze0 commented on issue #4002: Transactions cannot be rolled back properly when using local transaction. URL: https://github.com/apache/incubator-shardingsphere/issues/4002#issuecomment-575961548 Wish you a happy Spring Festival in advance ! Can someone solve my doubts? It’s very important for me. I still have a production problem to solve.  @KomachiSion @terrymanu @cherrylzhao This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] KomachiSion commented on issue #4002: Transactions cannot be rolled back properly when using local transaction.
KomachiSion commented on issue #4002: Transactions cannot be rolled back properly when using local transaction. URL: https://github.com/apache/incubator-shardingsphere/issues/4002#issuecomment-575962836 > After debugging, I found that excluding or not excluding JtaAutoConfiguration made a big difference. > > **Don’t exclude JtaAutoConfiguration, use JtaTransactionManager.** > > When commit： > 1、org.springframework.transaction.support.AbstractPlatformTransactionManager#commit > 2、org.springframework.transaction.jta.JtaTransactionManager#doCommit > 3、com.atomikos.icatch.jta.UserTransactionManager#commit > > **Exclude JtaAutoConfiguration, use DataSourceTransactionManager.** > > When commit： > 1、org.apache.shardingsphere.shardingjdbc.jdbc.core.connection.ShardingConnection#commit > 2、org.apache.shardingsphere.transaction.xa.XAShardingTransactionManager#commit > 3、com.atomikos.icatch.jta.UserTransactionManager#commit > > Does this mean that JtaAutoConfiguration must be excluded to ensure that sharding-jdbc controls the commit or rollback ? @cherrylzhao If you want to use ShardingSphere XA, you need to exclude `JtaTransactionManager`. Because `JtaTransactionManager` will shutdown the Transaction control of ShardingSphere. If use local or base of ShardingSphere, `JtaTransactionManager` can be excluded or not. > Currently, do we have to develop the @ShardingTransactionType aspect by ourselves? There is no need to develop @ShardingTransactionType by yourself. But only you should clone the `shardingsphere-spi-impl` repo and install by yourself. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] succeo opened a new issue #4016: SQL syntax error, expected token is 'EQ', actual token is 'IDENTIFIER', literals is 'contractsm0_'
succeo opened a new issue #4016: SQL syntax error, expected token is 'EQ', actual token is 'IDENTIFIER', literals is 'contractsm0_' URL: https://github.com/apache/incubator-shardingsphere/issues/4016 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] succeo commented on issue #4016: SQL syntax error, expected token is 'EQ', actual token is 'IDENTIFIER', literals is 'contractsm0_'
succeo commented on issue #4016: SQL syntax error, expected token is 'EQ', actual token is 'IDENTIFIER', literals is 'contractsm0_' URL: https://github.com/apache/incubator-shardingsphere/issues/4016#issuecomment-575964713 ```select taker.createdAt as takerCreatedAt, taker.userId, maker.price as makerPrice, maker.quantity as makerQuantity, maker.fee + taker.fee as sysFee from t_order taker left join t_order maker on taker.orderId = maker.counterOrderId and taker.counterOrderId = maker.orderId where taker.type = 'TAKER' and taker.createdAt between 157910400 and 1579251131120 and maker.createdAt between 157910400 and 1579251131120 order by taker.orderId asc,taker.counterOrderId asc limit 1000;``` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] succeo edited a comment on issue #4016: SQL syntax error, expected token is 'EQ', actual token is 'IDENTIFIER', literals is 'contractsm0_'
succeo edited a comment on issue #4016: SQL syntax error, expected token is 'EQ', actual token is 'IDENTIFIER', literals is 'contractsm0_' URL: https://github.com/apache/incubator-shardingsphere/issues/4016#issuecomment-575964713 ``` select taker.createdAt as takerCreatedAt, taker.userId, maker.price as makerPrice, maker.quantity as makerQuantity, maker.fee + taker.fee as sysFee from t_order taker left join t_order maker on taker.orderId = maker.counterOrderId and taker.counterOrderId = maker.orderId where taker.type = 'TAKER' and taker.createdAt between 157910400 and 1579251131120 and maker.createdAt between 157910400 and 1579251131120 order by taker.orderId asc,taker.counterOrderId asc limit 1000; ``` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] succeo commented on issue #4016: SQL syntax error, expected token is 'EQ', actual token is 'IDENTIFIER', literals is 'contractsm0_'
succeo commented on issue #4016: SQL syntax error, expected token is 'EQ', actual token is 'IDENTIFIER', literals is 'contractsm0_' URL: https://github.com/apache/incubator-shardingsphere/issues/4016#issuecomment-575964791 执行时会出现标题显示的问题，希望能帮忙处理一下 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu opened a new pull request #4017: Can skip long sql for parse test
terrymanu opened a new pull request #4017: Can skip long sql for parse test URL: https://github.com/apache/incubator-shardingsphere/pull/4017 For #3947. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu commented on issue #4016: SQL syntax error, expected token is 'EQ', actual token is 'IDENTIFIER', literals is 'contractsm0_'
terrymanu commented on issue #4016: SQL syntax error, expected token is 'EQ', actual token is 'IDENTIFIER', literals is 'contractsm0_' URL: https://github.com/apache/incubator-shardingsphere/issues/4016#issuecomment-575965461 What is your version? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu commented on issue #4016: SQL syntax error, expected token is 'EQ', actual token is 'IDENTIFIER', literals is 'contractsm0_'
terrymanu commented on issue #4016: SQL syntax error, expected token is 'EQ', actual token is 'IDENTIFIER', literals is 'contractsm0_' URL: https://github.com/apache/incubator-shardingsphere/issues/4016#issuecomment-575965456 > 执行时会出现标题显示的问题，希望能帮忙处理一下 Hi, for English only This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu closed issue #4006: Execute insert SQL error，columnNames size is 0,java.util.NoSuchElementException
terrymanu closed issue #4006: Execute insert SQL error，columnNames size is 0,java.util.NoSuchElementException URL: https://github.com/apache/incubator-shardingsphere/issues/4006 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu commented on issue #4006: Execute insert SQL error，columnNames size is 0,java.util.NoSuchElementException
terrymanu commented on issue #4006: Execute insert SQL error，columnNames size is 0,java.util.NoSuchElementException URL: https://github.com/apache/incubator-shardingsphere/issues/4006#issuecomment-575965533 Duplicate with #3962 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu commented on issue #3919: config datasource dynamic by program or outside order？
terrymanu commented on issue #3919: config datasource dynamic by program or outside order？ URL: https://github.com/apache/incubator-shardingsphere/issues/3919#issuecomment-575965624 You can try to use java API. FIY: https://shardingsphere.apache.org/document/current/en/manual/sharding-jdbc/configuration/config-java/ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu commented on issue #3901: sql bug:about "`"
terrymanu commented on issue #3901: sql bug:about "`" URL: https://github.com/apache/incubator-shardingsphere/issues/3901#issuecomment-575965747 Closed by no response anymore This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu closed issue #3901: sql bug:about "`"
terrymanu closed issue #3901: sql bug:about "`" URL: https://github.com/apache/incubator-shardingsphere/issues/3901 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu commented on issue #3908: Adapt db2
terrymanu commented on issue #3908: Adapt db2 URL: https://github.com/apache/incubator-shardingsphere/issues/3908#issuecomment-575965783 Closed because no volunteer wanted for this feature now. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] kimmking commented on issue #4014: Not support JDBC getCatalog
kimmking commented on issue #4014: Not support JDBC getCatalog URL: https://github.com/apache/incubator-shardingsphere/issues/4014#issuecomment-575965787 @shalousun Actually, mysql&oracle doesn’t support catalog. In a abstract Database model, a db instance contains several catalogs, each catalog contains several schema, every schema have many tables/views and other objects.Then we used to use Database in a specified case instead of the two concepts: catalog&schema. In mysql jdbc driver, the method connection.getCatalog will return databaseName string. We can use null or databaseName(mysql)/userName(oracle) instead of catalog in many methods like your above codes. Further more, sharding jdbc/proxy can wrap and route a logic database to more than one database, so we can't decide which db name should be returned to caller. So, then you will know as a result, sharding jdbc/proxy can't support the feature till now. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu closed issue #3908: Adapt db2
terrymanu closed issue #3908: Adapt db2 URL: https://github.com/apache/incubator-shardingsphere/issues/3908 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] kimmking edited a comment on issue #4014: Not support JDBC getCatalog
kimmking edited a comment on issue #4014: Not support JDBC getCatalog URL: https://github.com/apache/incubator-shardingsphere/issues/4014#issuecomment-575965787 @shalousun Actually, mysql&oracle doesn’t support catalog. In an abstract Database model, a db instance contains several catalogs, each catalog contains several schema, every schema have many tables/views and other objects.Then we used to use Database in a specified case instead of the two concepts: catalog&schema. In mysql jdbc driver, the method connection.getCatalog will return databaseName string. We can use null or databaseName(mysql)/userName(oracle) instead of catalog in many methods like your above codes. Further more, sharding jdbc/proxy can wrap and route a logic database to more than one database, so we can't decide which db name should be returned to caller. So, then you will know as a result, sharding jdbc/proxy can't support the feature till now. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu commented on issue #3987: How to handle JNDI datasource in spring namespace?
terrymanu commented on issue #3987: How to handle JNDI datasource in spring namespace? URL: https://github.com/apache/incubator-shardingsphere/issues/3987#issuecomment-575965962 Can you write the reason to close issue? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu closed issue #3210: ON DUPLICATE KEY UPDATE support incompletely on mybatis
terrymanu closed issue #3210: ON DUPLICATE KEY UPDATE support incompletely on mybatis URL: https://github.com/apache/incubator-shardingsphere/issues/3210 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu commented on issue #3210: ON DUPLICATE KEY UPDATE support incompletely on mybatis
terrymanu commented on issue #3210: ON DUPLICATE KEY UPDATE support incompletely on mybatis URL: https://github.com/apache/incubator-shardingsphere/issues/3210#issuecomment-575966015 Closed for no response anymore This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] cherrylzhao commented on issue #4002: Transactions cannot be rolled back properly when using local transaction.
cherrylzhao commented on issue #4002: Transactions cannot be rolled back properly when using local transaction. URL: https://github.com/apache/incubator-shardingsphere/issues/4002#issuecomment-575966099 ShardingSphere use local transaction interface to integrate distributed transaction(XA and BASE). from the spring perspective we only compatible with `DataSourceTransactionManager`，so JTA TransactionMananger will conflict with us. @ShardingTransactionType is a customer annotation, it should be handled by aspect class, you can use our code of SPI project or develop by yourself. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] Zze0 commented on issue #4002: Transactions cannot be rolled back properly when using local transaction.
Zze0 commented on issue #4002: Transactions cannot be rolled back properly when using local transaction. URL: https://github.com/apache/incubator-shardingsphere/issues/4002#issuecomment-575966318 @KomachiSion @cherrylzhao Thank you very much for your answer. My problem is solved. -- > If you want to use ShardingSphere XA, you need to exclude JtaTransactionManager. Because JtaTransactionManager will shutdown the Transaction control of ShardingSphere. In addition, I think you need to update your official documents on this point. Right here: https://shardingsphere.apache.org/document/current/en/manual/sharding-jdbc/usage/transaction/ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu commented on issue #4008: The insert statement reported an error
terrymanu commented on issue #4008: The insert statement reported an error URL: https://github.com/apache/incubator-shardingsphere/issues/4008#issuecomment-575966522 Hi, can you try to version 4.0.0? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] cherrylzhao commented on issue #4002: Transactions cannot be rolled back properly when using local transaction.
cherrylzhao commented on issue #4002: Transactions cannot be rolled back properly when using local transaction. URL: https://github.com/apache/incubator-shardingsphere/issues/4002#issuecomment-575966690 this is a constraint in spring side, you can try to PR for it to become our new contributor This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] Zze0 commented on issue #4002: Transactions cannot be rolled back properly when using local transaction.
Zze0 commented on issue #4002: Transactions cannot be rolled back properly when using local transaction. URL: https://github.com/apache/incubator-shardingsphere/issues/4002#issuecomment-575966887 > this is a constraint in spring side, you can try to PR for it to become our new contributor Ok, I will This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] Zze0 closed issue #4002: Transactions cannot be rolled back properly when using local transaction.
Zze0 closed issue #4002: Transactions cannot be rolled back properly when using local transaction. URL: https://github.com/apache/incubator-shardingsphere/issues/4002 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] tuohai666 merged pull request #4017: Can skip long sql for parse test
tuohai666 merged pull request #4017: Can skip long sql for parse test URL: https://github.com/apache/incubator-shardingsphere/pull/4017 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] coveralls commented on issue #4017: Can skip long sql for parse test
coveralls commented on issue #4017: Can skip long sql for parse test URL: https://github.com/apache/incubator-shardingsphere/pull/4017#issuecomment-575967225 ## Pull Request Test Coverage Report for [Build 1413](https://coveralls.io/builds/28193124) * **0** of **0** changed or added relevant lines in **0** files are covered. * No unchanged relevant lines lost coverage. * Overall coverage remained the same at **65.521%** --- | Totals | [](https://coveralls.io/builds/28193124) | | :-- | --: | | Change from base [Build 702](https://coveralls.io/builds/28192471): | 0.0% | | Covered Lines: | 10813 | | Relevant Lines: | 16503 | --- # 💛 - [Coveralls](https://coveralls.io) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] longjy commented on issue #3959: Get ciphertext column as a string
longjy commented on issue #3959: Get ciphertext column as a string
URL:
https://github.com/apache/incubator-shardingsphere/pull/3959#issuecomment-575967925
table
name | type
---|---
id | bigint
amount | varchar
bean
```
class Table{
private Long id;
private Bigdecimal amount;
}
```
ShardingEncryptor
```
//plaintext is Bigdecimal type
@Override
public String encrypt(Object plaintext) {
return "test" + plaintext.toString();
}
//ciphertext is string
@Override
public Object decrypt(String ciphertext) {
return new BigDecimal(ciphertext.replace("test", ""));
}
```
As shown above,amount is encrypted field,sql is
```
select * from table;
```
The original code will be
```
mergedResult.getValue(2, Bigdecimal.class);
```
but db amount column is "test";
throw exception:
```
java.sql.SQLDataException: Cannot determine value type from string
"testX"
```
If mergedResult.getValue(2, String.class) get ciphertext,then
ShardingEncryptor decrypt to Bigdecimal. will avoid this problem.
If the table column is encrypted without affecting the type modification in
the code, it will be easier for the user to access
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] succeo commented on issue #4016: SQL syntax error, expected token is 'EQ', actual token is 'IDENTIFIER', literals is 'contractsm0_'
succeo commented on issue #4016: SQL syntax error, expected token is 'EQ', actual token is 'IDENTIFIER', literals is 'contractsm0_' URL: https://github.com/apache/incubator-shardingsphere/issues/4016#issuecomment-575970471 sharding- jdbc version 3.0.0 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] kimmking commented on issue #4016: SQL syntax error, expected token is 'EQ', actual token is 'IDENTIFIER', literals is 'contractsm0_'
kimmking commented on issue #4016: SQL syntax error, expected token is 'EQ', actual token is 'IDENTIFIER', literals is 'contractsm0_' URL: https://github.com/apache/incubator-shardingsphere/issues/4016#issuecomment-575971044 > sharding- jdbc version 3.0.0 can you try it with sharding-jdbc 4.0.0 ? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] tristaZero commented on issue #3925: Solve the bug that the encryption result exception value is 'null' string when the encryption field value is null
tristaZero commented on issue #3925: Solve the bug that the encryption result exception value is 'null' string when the encryption field value is null URL: https://github.com/apache/incubator-shardingsphere/pull/3925#issuecomment-575972627 Hi @minghu-zhang, i thought your PR could be merged into ShardingSphere after some optimization, why do not you closed it? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] tristaZero edited a comment on issue #3925: Solve the bug that the encryption result exception value is 'null' string when the encryption field value is null
tristaZero edited a comment on issue #3925: Solve the bug that the encryption result exception value is 'null' string when the encryption field value is null URL: https://github.com/apache/incubator-shardingsphere/pull/3925#issuecomment-575972627 Hi @minghu-zhang, i thought your PR could be merged into ShardingSphere after some little changes, why did not you close it? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] tristaZero opened a new pull request #4018: add more tests for `insert set`
tristaZero opened a new pull request #4018: add more tests for `insert set` URL: https://github.com/apache/incubator-shardingsphere/pull/4018 #3914 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] yexufeijun opened a new issue #4019: oracle select page SQL error: Must have sharding column with subquery
yexufeijun opened a new issue #4019: oracle select page SQL error: Must have sharding column with subquery URL: https://github.com/apache/incubator-shardingsphere/issues/4019 ### Which version of ShardingSphere did you use? 4.0.0 ### Which project did you use? Sharding-JDBC or Sharding-Proxy? sharding-jdbc-spring-boot-starter ### SQL SQL: SELECT * FROM ( SELECT TMP.*, ROWNUM ROW_ID FROM ( SELECT id,sd_name FROM TEST_SHARDING_A ORDER BY id ASC ) TMP WHERE ROWNUM <=?) WHERE ROW_ID > ? ### Error org.mybatis.spring.MyBatisSystemException: nested exception is org.apache.ibatis.exceptions.PersistenceException: Error querying database. Cause: java.lang.IllegalStateException: Must have sharding column with subquery. The error may exist in com/example/sharding/mapper/TestShardingAMapper.java (best guess) The error may involve defaultParameterMap The error occurred while setting parameters SQL: SELECT * FROM ( SELECT TMP.*, ROWNUM ROW_ID FROM ( SELECT id,sd_name FROM TEST_SHARDING_A ORDER BY id ASC ) TMP WHERE ROWNUM <=?) WHERE ROW_ID > ? Cause: java.lang.IllegalStateException: Must have sharding column with subquery. at org.mybatis.spring.MyBatisExceptionTranslator.translateExceptionIfPossible(MyBatisExceptionTranslator.java:92) at org.mybatis.spring.SqlSessionTemplate$SqlSessionInterceptor.invoke(SqlSessionTemplate.java:440) at com.sun.proxy.$Proxy73.selectList(Unknown Source) at org.mybatis.spring.SqlSessionTemplate.selectList(SqlSessionTemplate.java:223) at com.baomidou.mybatisplus.core.override.MybatisMapperMethod.executeForIPage(MybatisMapperMethod.java:134) at com.baomidou.mybatisplus.core.override.MybatisMapperMethod.execute(MybatisMapperMethod.java:96) at com.baomidou.mybatisplus.core.override.MybatisMapperProxy.invoke(MybatisMapperProxy.java:96) at com.sun.proxy.$Proxy78.selectPage(Unknown Source) at com.example.sharding.ShardingATest.testSelectPage(ShardingATest.java:74) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke(Method.java:498) at org.junit.platform.commons.util.ReflectionUtils.invokeMethod(ReflectionUtils.java:675) at org.junit.jupiter.engine.execution.MethodInvocation.proceed(MethodInvocation.java:60) at org.junit.jupiter.engine.execution.InvocationInterceptorChain$ValidatingInvocation.proceed(InvocationInterceptorChain.java:125) at org.junit.jupiter.engine.extension.TimeoutExtension.intercept(TimeoutExtension.java:132) at org.junit.jupiter.engine.extension.TimeoutExtension.interceptTestableMethod(TimeoutExtension.java:124) at org.junit.jupiter.engine.extension.TimeoutExtension.interceptTestMethod(TimeoutExtension.java:74) at org.junit.jupiter.engine.execution.ExecutableInvoker$ReflectiveInterceptorCall.lambda$ofVoidMethod$0(ExecutableInvoker.java:115) at org.junit.jupiter.engine.execution.ExecutableInvoker.lambda$invoke$0(ExecutableInvoker.java:105) at org.junit.jupiter.engine.execution.InvocationInterceptorChain$InterceptedInvocation.proceed(InvocationInterceptorChain.java:104) at org.junit.jupiter.engine.execution.InvocationInterceptorChain.proceed(InvocationInterceptorChain.java:62) at org.junit.jupiter.engine.execution.InvocationInterceptorChain.chainAndInvoke(InvocationInterceptorChain.java:43) at org.junit.jupiter.engine.execution.InvocationInterceptorChain.invoke(InvocationInterceptorChain.java:35) at org.junit.jupiter.engine.execution.ExecutableInvoker.invoke(ExecutableInvoker.java:104) at org.junit.jupiter.engine.execution.ExecutableInvoker.invoke(ExecutableInvoker.java:98) at org.junit.jupiter.engine.descriptor.TestMethodTestDescriptor.lambda$invokeTestMethod$6(TestMethodTestDescriptor.java:202) at org.junit.platform.engine.support.hierarchical.ThrowableCollector.execute(ThrowableCollector.java:73) at org.junit.jupiter.engine.descriptor.TestMethodTestDescriptor.invokeTestMethod(TestMethodTestDescriptor.java:198) at org.junit.jupiter.engine.descriptor.TestMethodTestDescriptor.execute(TestMethodTestDescriptor.java:135) at org.junit.jupiter.engine.descriptor.TestMethodTestDescriptor.execute(TestMethodTestDescriptor.java:69) at org.junit.platform.engine.support.hierarchical.NodeTestTask.lambda$executeRecursively$5(NodeTestTask.java:135) at org.junit.platform.engine.support.hierarchical.ThrowableCollector.execute(ThrowableCollector.java:73) at org.junit.platform.engine.support.hierarchical.NodeTestTask.lambda$executeRecursively$7(Node
[GitHub] [incubator-shardingsphere] dongzl merged pull request #4018: add more tests for `insert set`
dongzl merged pull request #4018: add more tests for `insert set` URL: https://github.com/apache/incubator-shardingsphere/pull/4018 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] coveralls commented on issue #4018: add more tests for `insert set`
coveralls commented on issue #4018: add more tests for `insert set` URL: https://github.com/apache/incubator-shardingsphere/pull/4018#issuecomment-575976670 ## Pull Request Test Coverage Report for [Build 1414](https://coveralls.io/builds/28193934) * **0** of **0** changed or added relevant lines in **0** files are covered. * No unchanged relevant lines lost coverage. * Overall coverage remained the same at **65.521%** --- | Totals | [](https://coveralls.io/builds/28193934) | | :-- | --: | | Change from base [Build 703](https://coveralls.io/builds/28193273): | 0.0% | | Covered Lines: | 10813 | | Relevant Lines: | 16503 | --- # 💛 - [Coveralls](https://coveralls.io) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] nancyzrh opened a new pull request #4020: Optimize test
nancyzrh opened a new pull request #4020: Optimize test URL: https://github.com/apache/incubator-shardingsphere/pull/4020 For #3317 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
