[GitHub] [incubator-shardingsphere] SteNicholas opened a new pull request #4075: Encrypt statement IN operator contains space and line break

2020-01-23 Thread GitBox
SteNicholas opened a new pull request #4075: Encrypt statement IN operator 
contains space and line break
URL: https://github.com/apache/incubator-shardingsphere/pull/4075
 
 
   Fixes #4037.
   
   Encrypt statement IN operator contains space and line break could extraly 
append `(`, because method `extractInExpressionSegments` extracts first 
`ParameterMarkerExpressionSegment` start index not depend on `TerminalNodeImpl` 
`(`. Therefore, first `ParameterMarkerExpressionSegment` start index should be 
set with start index of `TerminalNodeImpl` `(`.
   
   Changes proposed in this pull request:
   - Method `extractInExpressionSegments` extracts first 
`ParameterMarkerExpressionSegment` start index with `TerminalNodeImpl` `(`.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-shardingsphere] SteNicholas merged pull request #4074: Remove useless condition assert from xml

2020-01-23 Thread GitBox
SteNicholas merged pull request #4074: Remove useless condition assert from xml
URL: https://github.com/apache/incubator-shardingsphere/pull/4074
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-shardingsphere] terrymanu opened a new pull request #4074: Remove useless condition assert from xml

2020-01-23 Thread GitBox
terrymanu opened a new pull request #4074: Remove useless condition assert from 
xml
URL: https://github.com/apache/incubator-shardingsphere/pull/4074
 
 
   For #3947.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-shardingsphere] tristaZero merged pull request #4073: Assert between predicate

2020-01-23 Thread GitBox
tristaZero merged pull request #4073: Assert between predicate
URL: https://github.com/apache/incubator-shardingsphere/pull/4073
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-shardingsphere] terrymanu opened a new pull request #4073: Assert between predicate

2020-01-23 Thread GitBox
terrymanu opened a new pull request #4073: Assert between predicate
URL: https://github.com/apache/incubator-shardingsphere/pull/4073
 
 
   For #3947.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[incubator-shardingsphere-benchmark] branch master updated: for performance

2020-01-23 Thread zhaoyanan
This is an automated email from the ASF dual-hosted git repository.

zhaoyanan pushed a commit to branch master
in repository 
https://gitbox.apache.org/repos/asf/incubator-shardingsphere-benchmark.git


The following commit(s) were added to refs/heads/master by this push:
 new c2e  for performance
c2e is described below

commit c2e590e3b26b476ce55be01938ced2a9978f
Author: nancyzrh 
AuthorDate: Fri Jan 24 08:58:37 2020 +0800

for performance
---
 report/jtl_json/full_route_test.json| 2 +-
 report/jtl_json/master_slave_encrypt_sharding_test.json | 2 +-
 report/jtl_json/master_slave_test.json  | 2 +-
 report/jtl_json/single_route_test.json  | 2 +-
 4 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/report/jtl_json/full_route_test.json 
b/report/jtl_json/full_route_test.json
index b94089e..71a749b 100644
--- a/report/jtl_json/full_route_test.json
+++ b/report/jtl_json/full_route_test.json
@@ -1 +1 @@
-{"SELECT": [{"data": [{"99.9th": "9", "Err": "0.0%", "95th": "2", "50th": "1", 
"Max": "10", "Min": "0", "Throughout": "23036.87", "Samples": 4999, "Date": 
"2019.12.19 02:35:57 ", "Avg": "0"}, {"99.9th": "9", "Err": "0.0%", "95th": 
"2", "50th": "1", "Max": "9", "Min": "0", "Throughout": "22619.91", "Samples": 
4999, "Date": "2019.12.20 13:34:47 ", "Avg": "0"}, {"99.9th": "9", "Err": 
"0.0%", "95th": "2", "50th": "1", "Max": "9", "Min": "0", "Throughout": 
"22931.19", "Samples": 4999, "Date": [...]
\ No newline at end of file
+{"SELECT": [{"data": [{"99.9th": "9", "Err": "0.0%", "95th": "2", "50th": "1", 
"Max": "10", "Min": "0", "Throughout": "23036.87", "Samples": 4999, "Date": 
"2019.12.19 02:35:57 ", "Avg": "0"}, {"99.9th": "9", "Err": "0.0%", "95th": 
"2", "50th": "1", "Max": "9", "Min": "0", "Throughout": "22619.91", "Samples": 
4999, "Date": "2019.12.20 13:34:47 ", "Avg": "0"}, {"99.9th": "9", "Err": 
"0.0%", "95th": "2", "50th": "1", "Max": "9", "Min": "0", "Throughout": 
"22931.19", "Samples": 4999, "Date": [...]
\ No newline at end of file
diff --git a/report/jtl_json/master_slave_encrypt_sharding_test.json 
b/report/jtl_json/master_slave_encrypt_sharding_test.json
index a2c8c79..f1279f1 100644
--- a/report/jtl_json/master_slave_encrypt_sharding_test.json
+++ b/report/jtl_json/master_slave_encrypt_sharding_test.json
@@ -1 +1 @@
-{"SELECT": [{"data": [{"99.9th": "16", "Err": "0.0%", "95th": "3", "50th": 
"2", "Max": "66", "Min": "1", "Throughout": "9381.73", "Samples": 99, 
"Date": "2019.12.19 02:40:33 ", "Avg": "2"}, {"99.9th": "16", "Err": "0.0%", 
"95th": "3", "50th": "2", "Max": "62", "Min": "1", "Throughout": "9038.48", 
"Samples": 99, "Date": "2019.12.20 13:39:23 ", "Avg": "2"}, {"99.9th": 
"16", "Err": "0.0%", "95th": "3", "50th": "2", "Max": "63", "Min": "1", 
"Throughout": "9071.44", "Samples": 99, [...]
\ No newline at end of file
+{"SELECT": [{"data": [{"99.9th": "16", "Err": "0.0%", "95th": "3", "50th": 
"2", "Max": "66", "Min": "1", "Throughout": "9381.73", "Samples": 99, 
"Date": "2019.12.19 02:40:33 ", "Avg": "2"}, {"99.9th": "16", "Err": "0.0%", 
"95th": "3", "50th": "2", "Max": "62", "Min": "1", "Throughout": "9038.48", 
"Samples": 99, "Date": "2019.12.20 13:39:23 ", "Avg": "2"}, {"99.9th": 
"16", "Err": "0.0%", "95th": "3", "50th": "2", "Max": "63", "Min": "1", 
"Throughout": "9071.44", "Samples": 99, [...]
\ No newline at end of file
diff --git a/report/jtl_json/master_slave_test.json 
b/report/jtl_json/master_slave_test.json
index 31abe0e..0cb54c9 100644
--- a/report/jtl_json/master_slave_test.json
+++ b/report/jtl_json/master_slave_test.json
@@ -1 +1 @@
-{"INSERT+SELECT+DELETE": [{"data": [], "type": "Sharding-Proxy_3.1"}, {"data": 
[{"99.9th": "38", "Err": "0.0%", "95th": "16", "50th": "11", "Max": "48", 
"Min": "7", "Throughout": "1720.96", "Samples": 29709, "Date": "2020.01.01 
02:49:45 ", "Avg": "11"}, {"99.9th": "27", "Err": "0.0%", "95th": "16", "50th": 
"11", "Max": "37", "Min": "7", "Throughout": "1701.38", "Samples": 17218, 
"Date": "2020.01.02 02:49:52 ", "Avg": "11"}, {"99.9th": "30", "Err": "0.0%", 
"95th": "16", "50th": "11", "Max [...]
\ No newline at end of file
+{"INSERT+SELECT+DELETE": [{"data": [], "type": "Sharding-Proxy_3.1"}, {"data": 
[{"99.9th": "38", "Err": "0.0%", "95th": "16", "50th": "11", "Max": "48", 
"Min": "7", "Throughout": "1720.96", "Samples": 29709, "Date": "2020.01.01 
02:49:45 ", "Avg": "11"}, {"99.9th": "27", "Err": "0.0%", "95th": "16", "50th": 
"11", "Max": "37", "Min": "7", "Throughout": "1701.38", "Samples": 17218, 
"Date": "2020.01.02 02:49:52 ", "Avg": "11"}, {"99.9th": "30", "Err": "0.0%", 
"95th": "16", "50th": "11", "Max [...]
\ No newline at end of file
diff --git a/report/jtl_json/single_route_test.json 
b/report/jtl_json/single_route_test.json
index 261171d..ddee667 100644
--- a/report/jtl_json/single_route_test.json
+++ b/report/jtl_json/single_route_test.json
@@ -1 +1 @@
-{"SELECT": [{"data": [], "type": "Sharding-Proxy_3.1"

[GitHub] [incubator-shardingsphere] SteNicholas merged pull request #4072: Assert in right value for predicate

2020-01-23 Thread GitBox
SteNicholas merged pull request #4072: Assert in right value for predicate
URL: https://github.com/apache/incubator-shardingsphere/pull/4072
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-shardingsphere] dongzl commented on issue #4072: Assert in right value for predicate

2020-01-23 Thread GitBox
dongzl commented on issue #4072: Assert in right value for predicate
URL: 
https://github.com/apache/incubator-shardingsphere/pull/4072#issuecomment-577923745
 
 
   /run ci


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-shardingsphere] dongzl removed a comment on issue #4072: Assert in right value for predicate

2020-01-23 Thread GitBox
dongzl removed a comment on issue #4072: Assert in right value for predicate
URL: 
https://github.com/apache/incubator-shardingsphere/pull/4072#issuecomment-577923745
 
 
   /run ci


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-shardingsphere] terrymanu opened a new pull request #4072: Assert in right value for predicate

2020-01-23 Thread GitBox
terrymanu opened a new pull request #4072: Assert in right value for predicate
URL: https://github.com/apache/incubator-shardingsphere/pull/4072
 
 
   For #3947.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-shardingsphere] tristaZero merged pull request #4071: Assert compare right value of predication

2020-01-23 Thread GitBox
tristaZero merged pull request #4071: Assert compare right value of predication
URL: https://github.com/apache/incubator-shardingsphere/pull/4071
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-shardingsphere] terrymanu opened a new pull request #4071: Assert compare right value of predication

2020-01-23 Thread GitBox
terrymanu opened a new pull request #4071: Assert compare right value of 
predication
URL: https://github.com/apache/incubator-shardingsphere/pull/4071
 
 
   For #3947.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-shardingsphere] coveralls commented on issue #4070: Add assert column right value for predicate

2020-01-23 Thread GitBox
coveralls commented on issue #4070: Add assert column right value for predicate
URL: 
https://github.com/apache/incubator-shardingsphere/pull/4070#issuecomment-577624497
 
 
   ## Pull Request Test Coverage Report for [Build 
1479](https://coveralls.io/builds/28279236)
   
   * **0** of **0**   changed or added relevant lines in **0** files are 
covered.
   * No unchanged relevant lines lost coverage.
   * Overall coverage remained the same at **66.648%**
   
   ---
   
   
   
   |  Totals | [![Coverage 
Status](https://coveralls.io/builds/28279236/badge)](https://coveralls.io/builds/28279236)
 |
   | :-- | --: |
   | Change from base [Build 732](https://coveralls.io/builds/28277148): |  
0.0% |
   | Covered Lines: | 10899 |
   | Relevant Lines: | 16353 |
   
   ---
   # 💛  - [Coveralls](https://coveralls.io)
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-shardingsphere] tuohai666 merged pull request #4070: Add assert column right value for predicate

2020-01-23 Thread GitBox
tuohai666 merged pull request #4070: Add assert column right value for predicate
URL: https://github.com/apache/incubator-shardingsphere/pull/4070
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-shardingsphere] terrymanu opened a new pull request #4070: Add assert column right value for predicate

2020-01-23 Thread GitBox
terrymanu opened a new pull request #4070: Add assert column right value for 
predicate
URL: https://github.com/apache/incubator-shardingsphere/pull/4070
 
 
   For #3947.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-shardingsphere] geyi commented on issue #4051: Actual SQL Missing parameters

2020-01-23 Thread GitBox
geyi commented on issue #4051: Actual SQL Missing parameters
URL: 
https://github.com/apache/incubator-shardingsphere/issues/4051#issuecomment-577580765
 
 
   > @geyi Does you mean that `DATE_ADD` doesn't support on dev branch? But I 
have already add this function unittest and the test worked well.
   
   yes, i clone dev branch, then execute mvn clean install -Prelease
   import 
sharding-distribution/sharding-jdbc-distribution/target/apache-shardingsphere-incubating-5.0.0-RC1-SNAPSHOT-sharding-jdbc-bin/lib
   exception log:
   2020-01-23 
16:31:01.406[]|10.0.0.5|debug|http-nio--exec-1|com.airing.dubbo.mapper.QuizMapper.insertOrderRef|==>
  Preparing: INSERT INTO t_quiz_order_ref (ID, ORDER_ID, QUESTION_ID, 
OP_ORDER_ID, START_TIME, EXPIRE_TIME) VALUES (?, ?, ?, ? ,date_add(now(), 
interval ? second) ,date_add(now(), interval ? second)) 
   2020-01-23 
16:31:01.407[]|10.0.0.5|debug|http-nio--exec-1|com.airing.dubbo.mapper.QuizMapper.insertOrderRef|==>
 Parameters: 10001001(Long), 616eff9eadc84b72a7be0b59855a7c8a(String), 
1(Integer), 8abe71763a6b4fc7b28bd7970751b14c(String), 3(Integer), 15(Integer)
   2020-01-23 16:31:01.515[]|10.0.0.5|info 
|http-nio--exec-1|ShardingSphere-SQL|Rule Type: sharding
   2020-01-23 16:31:01.515[]|10.0.0.5|info 
|http-nio--exec-1|ShardingSphere-SQL|Logic SQL: INSERT INTO t_quiz_order_ref
   (ID, ORDER_ID, QUESTION_ID, OP_ORDER_ID, START_TIME, EXPIRE_TIME)
   VALUES
 
   (?, ?, ?, ?
   ,date_add(now(), interval ? second)
   ,date_add(now(), interval ? second))
   2020-01-23 16:31:01.515[]|10.0.0.5|info 
|http-nio--exec-1|ShardingSphere-SQL|SQLStatement: 
InsertSQLStatementContext(super=CommonSQLStatementContext(sqlStatement=org.apache.shardingsphere.sql.parser.sql.statement.dml.InsertStatement@667b90ee,
 tablesContext=TablesContext(tables=[Table(name=t_quiz_order_ref, 
alias=Optional.absent())], schema=Optional.absent())), columnNames=[id, 
order_id, question_id, op_order_id, start_time, expire_time], 
insertValueContexts=[InsertValueContext(parametersCount=4, 
valueExpressions=[ParameterMarkerExpressionSegment(startIndex=142, 
stopIndex=142, parameterMarkerIndex=0), 
ParameterMarkerExpressionSegment(startIndex=145, stopIndex=145, 
parameterMarkerIndex=1), ParameterMarkerExpressionSegment(startIndex=148, 
stopIndex=148, parameterMarkerIndex=2), 
ParameterMarkerExpressionSegment(startIndex=151, stopIndex=151, 
parameterMarkerIndex=3), 
org.apache.shardingsphere.sql.parser.sql.segment.dml.item.ExpressionProjectionSegment@384b21df,
 
org.apache.shardingsphere.sql.parser.sql.segment.dml.item.ExpressionProjectionSegment@4cdd92e9],
 parameters=[10001001, 616eff9eadc84b72a7be0b59855a7c8a, 1, 
8abe71763a6b4fc7b28bd7970751b14c])])
   2020-01-23 16:31:01.515[]|10.0.0.5|info 
|http-nio--exec-1|ShardingSphere-SQL|Actual SQL: ds0 ::: INSERT INTO 
t_quiz_order_ref0
   (ID, ORDER_ID, QUESTION_ID, OP_ORDER_ID, START_TIME, EXPIRE_TIME)
   VALUES
 
   (?, ?, ?, ?, date_add(now(),interval?second), 
date_add(now(),interval?second)) ::: [10001001, 
616eff9eadc84b72a7be0b59855a7c8a, 1, 8abe71763a6b4fc7b28bd7970751b14c]


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-shardingsphere] tuohai666 merged pull request #4069: Add assertion for column predicates's left value

2020-01-23 Thread GitBox
tuohai666 merged pull request #4069: Add assertion for column predicates's left 
value
URL: https://github.com/apache/incubator-shardingsphere/pull/4069
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services