[GitHub] [incubator-shardingsphere] coveralls edited a comment on issue #4098: add antlr visitor for MySQL TCLStatement.
coveralls edited a comment on issue #4098: add antlr visitor for MySQL TCLStatement. URL: https://github.com/apache/incubator-shardingsphere/pull/4098#issuecomment-579238912 ## Pull Request Test Coverage Report for [Build 1524](https://coveralls.io/builds/28396382) * **0** of **5** **(0.0%)** changed or added relevant lines in **1** file are covered. * No unchanged relevant lines lost coverage. * Overall coverage decreased (**-0.02%**) to **66.296%** --- | Changes Missing Coverage | Covered Lines | Changed/Added Lines | % | | :-|--||---: | | [shardingsphere-sql-parser/shardingsphere-sql-parser-mysql/src/main/java/org/apache/shardingsphere/sql/parser/MySQLVisitor.java](https://coveralls.io/builds/28396382/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-mysql%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2FMySQLVisitor.java#L317) | 0 | 5 | 0.0% | Totals | [](https://coveralls.io/builds/28396382) | | :-- | --: | | Change from base [Build 757](https://coveralls.io/builds/28375068): | -0.02% | | Covered Lines: | 10899 | | Relevant Lines: | 16440 | --- # - [Coveralls](https://coveralls.io) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] coveralls commented on issue #4103: Move default branch from dev to master
coveralls commented on issue #4103: Move default branch from dev to master URL: https://github.com/apache/incubator-shardingsphere/pull/4103#issuecomment-579631524 ## Pull Request Test Coverage Report for [Build 1525](https://coveralls.io/builds/28396197) * **10899** of **16435** **(66.32%)** changed or added relevant lines in **986** files are covered. * No unchanged relevant lines lost coverage. * Overall coverage decreased (**-7.8%**) to **66.316%** --- | Changes Missing Coverage | Covered Lines | Changed/Added Lines | % | | :-|--||---: | | [encrypt-core/encrypt-core-common/src/main/java/org/apache/shardingsphere/encrypt/yaml/config/YamlEncryptColumnRuleConfiguration.java](https://coveralls.io/builds/28396197/source?filename=encrypt-core%2Fencrypt-core-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fencrypt%2Fyaml%2Fconfig%2FYamlEncryptColumnRuleConfiguration.java#L31) | 0 | 1 | 0.0% | [encrypt-core/encrypt-core-rewrite/src/main/java/org/apache/shardingsphere/encrypt/rewrite/condition/impl/EncryptEqualCondition.java](https://coveralls.io/builds/28396197/source?filename=encrypt-core%2Fencrypt-core-rewrite%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fencrypt%2Frewrite%2Fcondition%2Fimpl%2FEncryptEqualCondition.java#L84) | 21 | 22 | 95.45% | [encrypt-core/encrypt-core-rewrite/src/main/java/org/apache/shardingsphere/encrypt/rewrite/parameter/impl/EncryptInsertOnDuplicateKeyUpdateValueParameterRewriter.java](https://coveralls.io/builds/28396197/source?filename=encrypt-core%2Fencrypt-core-rewrite%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fencrypt%2Frewrite%2Fparameter%2Fimpl%2FEncryptInsertOnDuplicateKeyUpdateValueParameterRewriter.java#L58) | 22 | 23 | 95.65% | [encrypt-core/encrypt-core-rewrite/src/main/java/org/apache/shardingsphere/encrypt/rewrite/token/generator/impl/EncryptAssignmentTokenGenerator.java](https://coveralls.io/builds/28396197/source?filename=encrypt-core%2Fencrypt-core-rewrite%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fencrypt%2Frewrite%2Ftoken%2Fgenerator%2Fimpl%2FEncryptAssignmentTokenGenerator.java#L85) | 57 | 58 | 98.28% | [encrypt-core/encrypt-core-rewrite/src/main/java/org/apache/shardingsphere/encrypt/rewrite/token/pojo/EncryptPredicateInRightValueToken.java](https://coveralls.io/builds/28396197/source?filename=encrypt-core%2Fencrypt-core-rewrite%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fencrypt%2Frewrite%2Ftoken%2Fpojo%2FEncryptPredicateInRightValueToken.java#L59) | 15 | 16 | 93.75% | [master-slave-core/master-slave-core-route/src/main/java/org/apache/shardingsphere/masterslave/route/engine/impl/MasterVisitedManager.java](https://coveralls.io/builds/28396197/source?filename=master-slave-core%2Fmaster-slave-core-route%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fmasterslave%2Froute%2Fengine%2Fimpl%2FMasterVisitedManager.java#L27) | 7 | 8 | 87.5% | [sharding-core/database-time-service/src/main/java/org/apache/shardingsphere/route/time/TimeServiceConfiguration.java](https://coveralls.io/builds/28396197/source?filename=sharding-core%2Fdatabase-time-service%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Froute%2Ftime%2FTimeServiceConfiguration.java#L68) | 20 | 21 | 95.24% | [sharding-core/database-time-service/src/main/java/org/apache/shardingsphere/route/time/exception/NoDatabaseSQLEntrySupportException.java](https://coveralls.io/builds/28396197/source?filename=sharding-core%2Fdatabase-time-service%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Froute%2Ftime%2Fexception%2FNoDatabaseSQLEntrySupportException.java#L25) | 0 | 1 | 0.0% | [sharding-core/sharding-core-api/src/main/java/org/apache/shardingsphere/api/config/sharding/TableRuleConfiguration.java](https://coveralls.io/builds/28396197/source?filename=sharding-core%2Fsharding-core-api%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fapi%2Fconfig%2Fsharding%2FTableRuleConfiguration.java#L48) | 6 | 7 | 85.71% | [sharding-core/sharding-core-api/src/main/java/org/apache/shardingsphere/api/config/sharding/strategy/NoneShardingStrategyConfiguration.java](https://coveralls.io/builds/28396197/source?filename=sharding-core%2Fsharding-core-api%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fapi%2Fconfig%2Fsharding%2Fstrategy%2FNoneShardingStrategyConfiguration.java#L25) | 0 | 1 | 0.0% | Totals | [](https://coveralls.io/builds/28396197) | | :-- | --: | | Change from base [Build 6250](https://coveralls.io/builds/20888424): | -7.8% | | Covered Lines: | 10899 | | Relevant Lines: | 16435 | --- # - [Coveralls](https://coveralls.io) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go
[GitHub] [incubator-shardingsphere] coveralls commented on issue #4102: add tests for update sql
coveralls commented on issue #4102: add tests for update sql URL: https://github.com/apache/incubator-shardingsphere/pull/4102#issuecomment-579624889 ## Pull Request Test Coverage Report for [Build 1523](https://coveralls.io/builds/28395977) * **0** of **0** changed or added relevant lines in **0** files are covered. * No unchanged relevant lines lost coverage. * Overall coverage remained the same at **66.316%** --- | Totals | [](https://coveralls.io/builds/28395977) | | :-- | --: | | Change from base [Build 759](https://coveralls.io/builds/28395883): | 0.0% | | Covered Lines: | 10899 | | Relevant Lines: | 16435 | --- # - [Coveralls](https://coveralls.io) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] dongzl closed pull request #4098: add antlr visitor for MySQL TCLStatement.
dongzl closed pull request #4098: add antlr visitor for MySQL TCLStatement. URL: https://github.com/apache/incubator-shardingsphere/pull/4098 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] dongzl commented on issue #4098: add antlr visitor for MySQL TCLStatement.
dongzl commented on issue #4098: add antlr visitor for MySQL TCLStatement. URL: https://github.com/apache/incubator-shardingsphere/pull/4098#issuecomment-579623734 close this pr directly, submit a new pr on master branch. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu merged pull request #4103: Move default branch from dev to master
terrymanu merged pull request #4103: Move default branch from dev to master URL: https://github.com/apache/incubator-shardingsphere/pull/4103 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu opened a new pull request #4103: Move default branch from dev to master
terrymanu opened a new pull request #4103: Move default branch from dev to master URL: https://github.com/apache/incubator-shardingsphere/pull/4103 FIY: https://lists.apache.org/thread.html/r3543f5af3bc415d2a7b99cee1bce779355edbb1dbb12cf7c95d8b7d0%40%3Cdev.shardingsphere.apache.org%3E This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] dongzl commented on a change in pull request #4098: add antlr visitor for MySQL TCLStatement.
dongzl commented on a change in pull request #4098: add antlr visitor for MySQL
TCLStatement.
URL:
https://github.com/apache/incubator-shardingsphere/pull/4098#discussion_r372216412
##
File path:
shardingsphere-sql-parser/shardingsphere-sql-parser-mysql/src/main/java/org/apache/shardingsphere/sql/parser/MySQLVisitor.java
##
@@ -311,6 +327,31 @@ public ASTNode visitSetAutoCommit(final
SetAutoCommitContext ctx) {
return result;
}
+@Override
+public ASTNode visitAutoCommitValue(final AutoCommitValueContext ctx) {
Review comment:
done.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] coveralls commented on issue #4101: Finish accurate assert for alter table
coveralls commented on issue #4101: Finish accurate assert for alter table URL: https://github.com/apache/incubator-shardingsphere/pull/4101#issuecomment-579621003 ## Pull Request Test Coverage Report for [Build 1522](https://coveralls.io/builds/28395826) * **0** of **0** changed or added relevant lines in **0** files are covered. * No unchanged relevant lines lost coverage. * Overall coverage remained the same at **66.316%** --- | Totals | [](https://coveralls.io/builds/28395826) | | :-- | --: | | Change from base [Build 758](https://coveralls.io/builds/28395566): | 0.0% | | Covered Lines: | 10899 | | Relevant Lines: | 16435 | --- # - [Coveralls](https://coveralls.io) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu merged pull request #4102: add tests for update sql
terrymanu merged pull request #4102: add tests for update sql URL: https://github.com/apache/incubator-shardingsphere/pull/4102 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] tristaZero opened a new pull request #4102: add tests for update sql
tristaZero opened a new pull request #4102: add tests for update sql URL: https://github.com/apache/incubator-shardingsphere/pull/4102 #3914 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu commented on issue #4059: optimize test
terrymanu commented on issue #4059: optimize test URL: https://github.com/apache/incubator-shardingsphere/pull/4059#issuecomment-579615739 Closed because we change the default branch from dev to master. Please re-summit pr to master. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu closed pull request #3972: Determine if there is an encryption requirement according to all SQL tables
terrymanu closed pull request #3972: Determine if there is an encryption requirement according to all SQL tables URL: https://github.com/apache/incubator-shardingsphere/pull/3972 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu closed pull request #4059: optimize test
terrymanu closed pull request #4059: optimize test URL: https://github.com/apache/incubator-shardingsphere/pull/4059 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu commented on issue #3972: Determine if there is an encryption requirement according to all SQL tables
terrymanu commented on issue #3972: Determine if there is an encryption requirement according to all SQL tables URL: https://github.com/apache/incubator-shardingsphere/pull/3972#issuecomment-579615841 Closed because we change the default branch from dev to master. Please re-summit pr to master. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] SteNicholas merged pull request #4101: Finish accurate assert for alter table
SteNicholas merged pull request #4101: Finish accurate assert for alter table URL: https://github.com/apache/incubator-shardingsphere/pull/4101 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] SteNicholas closed pull request #4075: Encrypt statement IN operator contains space and line break
SteNicholas closed pull request #4075: Encrypt statement IN operator contains space and line break URL: https://github.com/apache/incubator-shardingsphere/pull/4075 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu opened a new pull request #4101: Finish accurate assert for alter table
terrymanu opened a new pull request #4101: Finish accurate assert for alter table URL: https://github.com/apache/incubator-shardingsphere/pull/4101 For #3947. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] coveralls commented on issue #4100: Finish accurate assert for alter table
coveralls commented on issue #4100: Finish accurate assert for alter table URL: https://github.com/apache/incubator-shardingsphere/pull/4100#issuecomment-579612117 ## Pull Request Test Coverage Report for [Build 1521](https://coveralls.io/builds/28395399) * **10899** of **16402** **(66.45%)** changed or added relevant lines in **985** files are covered. * No unchanged relevant lines lost coverage. * Overall coverage decreased (**-7.7%**) to **66.449%** --- | Changes Missing Coverage | Covered Lines | Changed/Added Lines | % | | :-|--||---: | | [encrypt-core/encrypt-core-common/src/main/java/org/apache/shardingsphere/encrypt/yaml/config/YamlEncryptColumnRuleConfiguration.java](https://coveralls.io/builds/28395399/source?filename=encrypt-core%2Fencrypt-core-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fencrypt%2Fyaml%2Fconfig%2FYamlEncryptColumnRuleConfiguration.java#L31) | 0 | 1 | 0.0% | [encrypt-core/encrypt-core-rewrite/src/main/java/org/apache/shardingsphere/encrypt/rewrite/condition/impl/EncryptEqualCondition.java](https://coveralls.io/builds/28395399/source?filename=encrypt-core%2Fencrypt-core-rewrite%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fencrypt%2Frewrite%2Fcondition%2Fimpl%2FEncryptEqualCondition.java#L84) | 21 | 22 | 95.45% | [encrypt-core/encrypt-core-rewrite/src/main/java/org/apache/shardingsphere/encrypt/rewrite/parameter/impl/EncryptInsertOnDuplicateKeyUpdateValueParameterRewriter.java](https://coveralls.io/builds/28395399/source?filename=encrypt-core%2Fencrypt-core-rewrite%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fencrypt%2Frewrite%2Fparameter%2Fimpl%2FEncryptInsertOnDuplicateKeyUpdateValueParameterRewriter.java#L58) | 22 | 23 | 95.65% | [encrypt-core/encrypt-core-rewrite/src/main/java/org/apache/shardingsphere/encrypt/rewrite/token/generator/impl/EncryptAssignmentTokenGenerator.java](https://coveralls.io/builds/28395399/source?filename=encrypt-core%2Fencrypt-core-rewrite%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fencrypt%2Frewrite%2Ftoken%2Fgenerator%2Fimpl%2FEncryptAssignmentTokenGenerator.java#L85) | 57 | 58 | 98.28% | [encrypt-core/encrypt-core-rewrite/src/main/java/org/apache/shardingsphere/encrypt/rewrite/token/pojo/EncryptPredicateInRightValueToken.java](https://coveralls.io/builds/28395399/source?filename=encrypt-core%2Fencrypt-core-rewrite%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fencrypt%2Frewrite%2Ftoken%2Fpojo%2FEncryptPredicateInRightValueToken.java#L59) | 15 | 16 | 93.75% | [master-slave-core/master-slave-core-route/src/main/java/org/apache/shardingsphere/masterslave/route/engine/impl/MasterVisitedManager.java](https://coveralls.io/builds/28395399/source?filename=master-slave-core%2Fmaster-slave-core-route%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fmasterslave%2Froute%2Fengine%2Fimpl%2FMasterVisitedManager.java#L27) | 7 | 8 | 87.5% | [sharding-core/database-time-service/src/main/java/org/apache/shardingsphere/route/time/TimeServiceConfiguration.java](https://coveralls.io/builds/28395399/source?filename=sharding-core%2Fdatabase-time-service%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Froute%2Ftime%2FTimeServiceConfiguration.java#L68) | 20 | 21 | 95.24% | [sharding-core/database-time-service/src/main/java/org/apache/shardingsphere/route/time/exception/NoDatabaseSQLEntrySupportException.java](https://coveralls.io/builds/28395399/source?filename=sharding-core%2Fdatabase-time-service%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Froute%2Ftime%2Fexception%2FNoDatabaseSQLEntrySupportException.java#L25) | 0 | 1 | 0.0% | [sharding-core/sharding-core-api/src/main/java/org/apache/shardingsphere/api/config/sharding/TableRuleConfiguration.java](https://coveralls.io/builds/28395399/source?filename=sharding-core%2Fsharding-core-api%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fapi%2Fconfig%2Fsharding%2FTableRuleConfiguration.java#L48) | 6 | 7 | 85.71% | [sharding-core/sharding-core-api/src/main/java/org/apache/shardingsphere/api/config/sharding/strategy/NoneShardingStrategyConfiguration.java](https://coveralls.io/builds/28395399/source?filename=sharding-core%2Fsharding-core-api%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fapi%2Fconfig%2Fsharding%2Fstrategy%2FNoneShardingStrategyConfiguration.java#L25) | 0 | 1 | 0.0% | Totals | [](https://coveralls.io/builds/28395399) | | :-- | --: | | Change from base [Build 6250](https://coveralls.io/builds/20888424): | -7.7% | | Covered Lines: | 10899 | | Relevant Lines: | 16402 | --- # - [Coveralls](https://coveralls.io) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go
[GitHub] [incubator-shardingsphere] terrymanu commented on issue #4100: Finish accurate assert for alter table
terrymanu commented on issue #4100: Finish accurate assert for alter table URL: https://github.com/apache/incubator-shardingsphere/pull/4100#issuecomment-579610670 Invalid because version control error This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] coveralls commented on issue #4099: rename rule name to escapedTableReference
coveralls commented on issue #4099: rename rule name to escapedTableReference URL: https://github.com/apache/incubator-shardingsphere/pull/4099#issuecomment-579609027 ## Pull Request Test Coverage Report for [Build 1520](https://coveralls.io/builds/28395195) * **0** of **1** **(0.0%)** changed or added relevant line in **1** file are covered. * No unchanged relevant lines lost coverage. * Overall coverage remained the same at **66.316%** --- | Changes Missing Coverage | Covered Lines | Changed/Added Lines | % | | :-|--||---: | | [shardingsphere-sql-parser/shardingsphere-sql-parser-mysql/src/main/java/org/apache/shardingsphere/sql/parser/MySQLVisitor.java](https://coveralls.io/builds/28395195/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-mysql%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2FMySQLVisitor.java#L257) | 0 | 1 | 0.0% | Totals | [](https://coveralls.io/builds/28395195) | | :-- | --: | | Change from base [Build 757](https://coveralls.io/builds/28375068): | 0.0% | | Covered Lines: | 10899 | | Relevant Lines: | 16435 | --- # - [Coveralls](https://coveralls.io) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] dongzl merged pull request #4099: rename rule name to escapedTableReference
dongzl merged pull request #4099: rename rule name to escapedTableReference URL: https://github.com/apache/incubator-shardingsphere/pull/4099 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu closed pull request #4100: Finish accurate assert for alter table
terrymanu closed pull request #4100: Finish accurate assert for alter table URL: https://github.com/apache/incubator-shardingsphere/pull/4100 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu opened a new pull request #4100: Finish accurate assert for alter table
terrymanu opened a new pull request #4100: Finish accurate assert for alter table URL: https://github.com/apache/incubator-shardingsphere/pull/4100 For #3947. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] tristaZero opened a new pull request #4099: rename rule name to escapedTableReference
tristaZero opened a new pull request #4099: rename rule name to escapedTableReference URL: https://github.com/apache/incubator-shardingsphere/pull/4099 #3914 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] tristaZero commented on a change in pull request #4098: add antlr visitor for MySQL TCLStatement.
tristaZero commented on a change in pull request #4098: add antlr visitor for
MySQL TCLStatement.
URL:
https://github.com/apache/incubator-shardingsphere/pull/4098#discussion_r372178455
##
File path:
shardingsphere-sql-parser/shardingsphere-sql-parser-mysql/src/main/java/org/apache/shardingsphere/sql/parser/MySQLVisitor.java
##
@@ -311,6 +327,31 @@ public ASTNode visitSetAutoCommit(final
SetAutoCommitContext ctx) {
return result;
}
+@Override
+public ASTNode visitAutoCommitValue(final AutoCommitValueContext ctx) {
Review comment:
Hi `AutoCommitSegment` is necessary for `SetAutoCommitStatement`
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[incubator-shardingsphere-benchmark] branch master updated: for performance
This is an automated email from the ASF dual-hosted git repository.
zhaoyanan pushed a commit to branch master
in repository
https://gitbox.apache.org/repos/asf/incubator-shardingsphere-benchmark.git
The following commit(s) were added to refs/heads/master by this push:
new 86d2474 for performance
86d2474 is described below
commit 86d24745b524a4bec51d526ece7d8ad75cbc19a9
Author: nancyzrh
AuthorDate: Wed Jan 29 08:58:53 2020 +0800
for performance
---
report/jtl_json/full_route_test.json| 2 +-
report/jtl_json/master_slave_encrypt_sharding_test.json | 2 +-
report/jtl_json/master_slave_test.json | 2 +-
report/jtl_json/single_route_test.json | 2 +-
4 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/report/jtl_json/full_route_test.json
b/report/jtl_json/full_route_test.json
index 689bdb5..bd4d9ef 100644
--- a/report/jtl_json/full_route_test.json
+++ b/report/jtl_json/full_route_test.json
@@ -1 +1 @@
-{"SELECT": [{"data": [{"99.9th": "9", "Err": "0.0%", "95th": "2", "50th": "1",
"Max": "10", "Min": "0", "Throughout": "23036.87", "Samples": 4999, "Date":
"2019.12.19 02:35:57 ", "Avg": "0"}, {"99.9th": "9", "Err": "0.0%", "95th":
"2", "50th": "1", "Max": "9", "Min": "0", "Throughout": "22619.91", "Samples":
4999, "Date": "2019.12.20 13:34:47 ", "Avg": "0"}, {"99.9th": "9", "Err":
"0.0%", "95th": "2", "50th": "1", "Max": "9", "Min": "0", "Throughout":
"22931.19", "Samples": 4999, "Date": [...]
\ No newline at end of file
+{"SELECT": [{"data": [{"99.9th": "9", "Err": "0.0%", "95th": "2", "50th": "1",
"Max": "10", "Min": "0", "Throughout": "23036.87", "Samples": 4999, "Date":
"2019.12.19 02:35:57 ", "Avg": "0"}, {"99.9th": "9", "Err": "0.0%", "95th":
"2", "50th": "1", "Max": "9", "Min": "0", "Throughout": "22619.91", "Samples":
4999, "Date": "2019.12.20 13:34:47 ", "Avg": "0"}, {"99.9th": "9", "Err":
"0.0%", "95th": "2", "50th": "1", "Max": "9", "Min": "0", "Throughout":
"22931.19", "Samples": 4999, "Date": [...]
\ No newline at end of file
diff --git a/report/jtl_json/master_slave_encrypt_sharding_test.json
b/report/jtl_json/master_slave_encrypt_sharding_test.json
index 8e7a39c..342ce69 100644
--- a/report/jtl_json/master_slave_encrypt_sharding_test.json
+++ b/report/jtl_json/master_slave_encrypt_sharding_test.json
@@ -1 +1 @@
-{"SELECT": [{"data": [{"99.9th": "16", "Err": "0.0%", "95th": "3", "50th":
"2", "Max": "66", "Min": "1", "Throughout": "9381.73", "Samples": 99,
"Date": "2019.12.19 02:40:33 ", "Avg": "2"}, {"99.9th": "16", "Err": "0.0%",
"95th": "3", "50th": "2", "Max": "62", "Min": "1", "Throughout": "9038.48",
"Samples": 99, "Date": "2019.12.20 13:39:23 ", "Avg": "2"}, {"99.9th":
"16", "Err": "0.0%", "95th": "3", "50th": "2", "Max": "63", "Min": "1",
"Throughout": "9071.44", "Samples": 99, [...]
\ No newline at end of file
+{"SELECT": [{"data": [{"99.9th": "16", "Err": "0.0%", "95th": "3", "50th":
"2", "Max": "66", "Min": "1", "Throughout": "9381.73", "Samples": 99,
"Date": "2019.12.19 02:40:33 ", "Avg": "2"}, {"99.9th": "16", "Err": "0.0%",
"95th": "3", "50th": "2", "Max": "62", "Min": "1", "Throughout": "9038.48",
"Samples": 99, "Date": "2019.12.20 13:39:23 ", "Avg": "2"}, {"99.9th":
"16", "Err": "0.0%", "95th": "3", "50th": "2", "Max": "63", "Min": "1",
"Throughout": "9071.44", "Samples": 99, [...]
\ No newline at end of file
diff --git a/report/jtl_json/master_slave_test.json
b/report/jtl_json/master_slave_test.json
index 7d0d6b4..a90dfef 100644
--- a/report/jtl_json/master_slave_test.json
+++ b/report/jtl_json/master_slave_test.json
@@ -1 +1 @@
-{"INSERT+SELECT+DELETE": [{"data": [], "type": "Sharding-Proxy_3.1"}, {"data":
[{"99.9th": "38", "Err": "0.0%", "95th": "16", "50th": "11", "Max": "48",
"Min": "7", "Throughout": "1720.96", "Samples": 29709, "Date": "2020.01.01
02:49:45 ", "Avg": "11"}, {"99.9th": "27", "Err": "0.0%", "95th": "16", "50th":
"11", "Max": "37", "Min": "7", "Throughout": "1701.38", "Samples": 17218,
"Date": "2020.01.02 02:49:52 ", "Avg": "11"}, {"99.9th": "30", "Err": "0.0%",
"95th": "16", "50th": "11", "Max [...]
\ No newline at end of file
+{"INSERT+SELECT+DELETE": [{"data": [], "type": "Sharding-Proxy_3.1"}, {"data":
[{"99.9th": "38", "Err": "0.0%", "95th": "16", "50th": "11", "Max": "48",
"Min": "7", "Throughout": "1720.96", "Samples": 29709, "Date": "2020.01.01
02:49:45 ", "Avg": "11"}, {"99.9th": "27", "Err": "0.0%", "95th": "16", "50th":
"11", "Max": "37", "Min": "7", "Throughout": "1701.38", "Samples": 17218,
"Date": "2020.01.02 02:49:52 ", "Avg": "11"}, {"99.9th": "30", "Err": "0.0%",
"95th": "16", "50th": "11", "Max [...]
\ No newline at end of file
diff --git a/report/jtl_json/single_route_test.json
b/report/jtl_json/single_route_test.json
index 755722b..43f50de 100644
--- a/report/jtl_json/single_route_test.json
+++ b/report/jtl_json/single_route_test.json
@@ -1 +1 @@
-{"SELECT": [{"data": [], "type":
[GitHub] [incubator-shardingsphere] coveralls edited a comment on issue #4098: add antlr visitor for MySQL TCLStatement.
coveralls edited a comment on issue #4098: add antlr visitor for MySQL TCLStatement. URL: https://github.com/apache/incubator-shardingsphere/pull/4098#issuecomment-579238912 ## Pull Request Test Coverage Report for [Build 1517](https://coveralls.io/builds/28376905) * **0** of **6** **(0.0%)** changed or added relevant lines in **1** file are covered. * No unchanged relevant lines lost coverage. * Overall coverage decreased (**-0.02%**) to **66.292%** --- | Changes Missing Coverage | Covered Lines | Changed/Added Lines | % | | :-|--||---: | | [shardingsphere-sql-parser/shardingsphere-sql-parser-mysql/src/main/java/org/apache/shardingsphere/sql/parser/MySQLVisitor.java](https://coveralls.io/builds/28376905/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-mysql%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2FMySQLVisitor.java#L318) | 0 | 6 | 0.0% | Totals | [](https://coveralls.io/builds/28376905) | | :-- | --: | | Change from base [Build 757](https://coveralls.io/builds/28375068): | -0.02% | | Covered Lines: | 10899 | | Relevant Lines: | 16441 | --- # - [Coveralls](https://coveralls.io) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] coveralls commented on issue #4098: add antlr visitor for MySQL TCLStatement.
coveralls commented on issue #4098: add antlr visitor for MySQL TCLStatement. URL: https://github.com/apache/incubator-shardingsphere/pull/4098#issuecomment-579238912 ## Pull Request Test Coverage Report for [Build 1515](https://coveralls.io/builds/28375900) * **0** of **16** **(0.0%)** changed or added relevant lines in **1** file are covered. * **126** unchanged lines in **1** file lost coverage. * Overall coverage increased (+**0.1%**) to **66.425%** --- | Changes Missing Coverage | Covered Lines | Changed/Added Lines | % | | :-|--||---: | | [shardingsphere-sql-parser/shardingsphere-sql-parser-mysql/src/main/java/org/apache/shardingsphere/sql/parser/MySQLVisitor.java](https://coveralls.io/builds/28375900/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-mysql%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2FMySQLVisitor.java#L318) | 0 | 16 | 0.0% | Files with Coverage Reduction | New Missed Lines | % | | :-|--|--: | | [shardingsphere-sql-parser/shardingsphere-sql-parser-mysql/src/main/java/org/apache/shardingsphere/sql/parser/MySQLVisitor.java](https://coveralls.io/builds/28375900/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-mysql%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2FMySQLVisitor.java#L124) | 126 | 0% | | Totals | [](https://coveralls.io/builds/28375900) | | :-- | --: | | Change from base [Build 757](https://coveralls.io/builds/28375068): | 0.1% | | Covered Lines: | 10899 | | Relevant Lines: | 16408 | --- # - [Coveralls](https://coveralls.io) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] dongzl commented on issue #4098: add antlr visitor for MySQL TCLStatement.
dongzl commented on issue #4098: add antlr visitor for MySQL TCLStatement. URL: https://github.com/apache/incubator-shardingsphere/pull/4098#issuecomment-579231529 /run ci This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] dongzl removed a comment on issue #4098: add antlr visitor for MySQL TCLStatement.
dongzl removed a comment on issue #4098: add antlr visitor for MySQL TCLStatement. URL: https://github.com/apache/incubator-shardingsphere/pull/4098#issuecomment-579231529 /run ci This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] dongzl opened a new pull request #4098: add antlr visitor for MySQL TCLStatement.
dongzl opened a new pull request #4098: add antlr visitor for MySQL TCLStatement. URL: https://github.com/apache/incubator-shardingsphere/pull/4098 For #3914 . Changes proposed in this pull request: - add antlr visitor for MySQL TCLStatement. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] dongzl merged pull request #4097: add antlr visitor for update sql
dongzl merged pull request #4097: add antlr visitor for update sql URL: https://github.com/apache/incubator-shardingsphere/pull/4097 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] coveralls commented on issue #4097: add antlr visitor for update sql
coveralls commented on issue #4097: add antlr visitor for update sql URL: https://github.com/apache/incubator-shardingsphere/pull/4097#issuecomment-579203466 ## Pull Request Test Coverage Report for [Build 1514](https://coveralls.io/builds/28373709) * **0** of **39** **(0.0%)** changed or added relevant lines in **2** files are covered. * No unchanged relevant lines lost coverage. * Overall coverage decreased (**-0.1%**) to **66.316%** --- | Changes Missing Coverage | Covered Lines | Changed/Added Lines | % | | :-|--||---: | | [shardingsphere-sql-parser/shardingsphere-sql-parser-engine/src/main/java/org/apache/shardingsphere/sql/parser/sql/value/ListValue.java](https://coveralls.io/builds/28373709/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-engine%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fsql%2Fvalue%2FListValue.java#L43) | 0 | 2 | 0.0% | [shardingsphere-sql-parser/shardingsphere-sql-parser-mysql/src/main/java/org/apache/shardingsphere/sql/parser/MySQLVisitor.java](https://coveralls.io/builds/28373709/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-mysql%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2FMySQLVisitor.java#L169) | 0 | 37 | 0.0% | Totals | [](https://coveralls.io/builds/28373709) | | :-- | --: | | Change from base [Build 756](https://coveralls.io/builds/28373006): | -0.1% | | Covered Lines: | 10899 | | Relevant Lines: | 16435 | --- # - [Coveralls](https://coveralls.io) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] tristaZero opened a new pull request #4097: add antlr visitor for update sql
tristaZero opened a new pull request #4097: add antlr visitor for update sql URL: https://github.com/apache/incubator-shardingsphere/pull/4097 #3914 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] dongzl merged pull request #4096: Add clause concept for assert
dongzl merged pull request #4096: Add clause concept for assert URL: https://github.com/apache/incubator-shardingsphere/pull/4096 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu opened a new pull request #4096: Add clause concept for assert
terrymanu opened a new pull request #4096: Add clause concept for assert URL: https://github.com/apache/incubator-shardingsphere/pull/4096 For #3947. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] coveralls commented on issue #4095: Add assert of insert set
coveralls commented on issue #4095: Add assert of insert set URL: https://github.com/apache/incubator-shardingsphere/pull/4095#issuecomment-579149476 ## Pull Request Test Coverage Report for [Build 1511](https://coveralls.io/builds/28371135) * **0** of **0** changed or added relevant lines in **0** files are covered. * No unchanged relevant lines lost coverage. * Overall coverage remained the same at **66.449%** --- | Totals | [](https://coveralls.io/builds/28371135) | | :-- | --: | | Change from base [Build 754](https://coveralls.io/builds/28370154): | 0.0% | | Covered Lines: | 10899 | | Relevant Lines: | 16402 | --- # - [Coveralls](https://coveralls.io) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] SteNicholas merged pull request #4095: Add assert of insert set
SteNicholas merged pull request #4095: Add assert of insert set URL: https://github.com/apache/incubator-shardingsphere/pull/4095 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu opened a new pull request #4095: Add assert of insert set
terrymanu opened a new pull request #4095: Add assert of insert set URL: https://github.com/apache/incubator-shardingsphere/pull/4095 For #3947. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] dongzl removed a comment on issue #4076: persist SchemaNames for getChildren.
dongzl removed a comment on issue #4076: persist SchemaNames for getChildren. URL: https://github.com/apache/incubator-shardingsphere/pull/4076#issuecomment-579132444 /run ci This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] coveralls commented on issue #4094: Redesign assignment and assignment value for jaxb domain and asserttion
coveralls commented on issue #4094: Redesign assignment and assignment value for jaxb domain and asserttion URL: https://github.com/apache/incubator-shardingsphere/pull/4094#issuecomment-579132440 ## Pull Request Test Coverage Report for [Build 1509](https://coveralls.io/builds/28370315) * **0** of **0** changed or added relevant lines in **0** files are covered. * No unchanged relevant lines lost coverage. * Overall coverage remained the same at **66.449%** --- | Totals | [](https://coveralls.io/builds/28370315) | | :-- | --: | | Change from base [Build 753](https://coveralls.io/builds/28369238): | 0.0% | | Covered Lines: | 10899 | | Relevant Lines: | 16402 | --- # - [Coveralls](https://coveralls.io) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] dongzl commented on issue #4076: persist SchemaNames for getChildren.
dongzl commented on issue #4076: persist SchemaNames for getChildren. URL: https://github.com/apache/incubator-shardingsphere/pull/4076#issuecomment-579132444 /run ci This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
