[GitHub] [incubator-shardingsphere] tristaZero opened a new issue #4365: Support `alter table add primary foreign key`
tristaZero opened a new issue #4365: Support `alter table add primary foreign key` URL: https://github.com/apache/incubator-shardingsphere/issues/4365 To make new sharding parser support sql `ALTER TABLE t_order_item ADD CONSTRAINT fk_order_id FOREIGN KEY (order_id) REFERENCES t_order (order_id) ON DELETE CASCADE` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] tristaZero closed issue #4363: Bugfix for new Visitor parser
tristaZero closed issue #4363: Bugfix for new Visitor parser URL: https://github.com/apache/incubator-shardingsphere/issues/4363 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] lklkxcxc commented on issue #4338: Sharding-Proxy output logs：readAddress(..) failed: Connection reset by peer
lklkxcxc commented on issue #4338: Sharding-Proxy output logs：readAddress(..) failed: Connection reset by peer URL: https://github.com/apache/incubator-shardingsphere/issues/4338#issuecomment-588069179 @kimmking Thank you very much! Let me close this problem This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] lklkxcxc closed issue #4338: Sharding-Proxy output logs：readAddress(..) failed: Connection reset by peer
lklkxcxc closed issue #4338: Sharding-Proxy output logs：readAddress(..) failed: Connection reset by peer URL: https://github.com/apache/incubator-shardingsphere/issues/4338 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] coveralls edited a comment on issue #4364: decouple find IndexSegment with SQLStatement
coveralls edited a comment on issue #4364: decouple find IndexSegment with SQLStatement URL: https://github.com/apache/incubator-shardingsphere/pull/4364#issuecomment-588062425 ## Pull Request Test Coverage Report for [Build 1806](https://coveralls.io/builds/28817800) * **12** of **12** **(100.0%)** changed or added relevant lines in **1** file are covered. * **1** unchanged line in **1** file lost coverage. * Overall coverage increased (+**0.01%**) to **57.364%** --- | Files with Coverage Reduction | New Missed Lines | % | | :-|--|--: | | [sharding-orchestration/sharding-orchestration-center/sharding-orchestration-center-apollo/src/main/java/org/apache/shardingsphere/orchestration/center/instance/ApolloInstance.java](https://coveralls.io/builds/28817800/source?filename=sharding-orchestration%2Fsharding-orchestration-center%2Fsharding-orchestration-center-apollo%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Forchestration%2Fcenter%2Finstance%2FApolloInstance.java#L117) | 1 | 59.46% | | Totals | [](https://coveralls.io/builds/28817800) | | :-- | --: | | Change from base [Build 880](https://coveralls.io/builds/28816932): | 0.01% | | Covered Lines: | 11069 | | Relevant Lines: | 19296 | --- # 💛 - [Coveralls](https://coveralls.io) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] coveralls commented on issue #4364: decouple find IndexSegment with SQLStatement
coveralls commented on issue #4364: decouple find IndexSegment with SQLStatement URL: https://github.com/apache/incubator-shardingsphere/pull/4364#issuecomment-588062425 ## Pull Request Test Coverage Report for [Build 9644](https://coveralls.io/builds/28817798) * **12** of **12** **(100.0%)** changed or added relevant lines in **1** file are covered. * **4** unchanged lines in **2** files lost coverage. * Overall coverage increased (+**0.007%**) to **57.359%** --- | Files with Coverage Reduction | New Missed Lines | % | | :-|--|--: | | [sharding-orchestration/sharding-orchestration-center/sharding-orchestration-center-apollo/src/main/java/org/apache/shardingsphere/orchestration/center/instance/ApolloInstance.java](https://coveralls.io/builds/28817798/source?filename=sharding-orchestration%2Fsharding-orchestration-center%2Fsharding-orchestration-center-apollo%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Forchestration%2Fcenter%2Finstance%2FApolloInstance.java#L117) | 1 | 59.46% | | [sharding-orchestration/sharding-orchestration-core/src/main/java/org/apache/shardingsphere/orchestration/internal/util/IpUtils.java](https://coveralls.io/builds/28817798/source?filename=sharding-orchestration%2Fsharding-orchestration-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Forchestration%2Finternal%2Futil%2FIpUtils.java#L63) | 3 | 76.0% | | Totals | [](https://coveralls.io/builds/28817798) | | :-- | --: | | Change from base [Build 880](https://coveralls.io/builds/28816932): | 0.007% | | Covered Lines: | 11068 | | Relevant Lines: | 19296 | --- # 💛 - [Coveralls](https://coveralls.io) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] codecov-io commented on issue #4364: decouple find IndexSegment with SQLStatement
codecov-io commented on issue #4364: decouple find IndexSegment with SQLStatement URL: https://github.com/apache/incubator-shardingsphere/pull/4364#issuecomment-588061068 # [Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4364?src=pr&el=h1) Report > Merging [#4364](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4364?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-shardingsphere/commit/6ce5057f10aa13129c070e10a1722ef15f461051?src=pr&el=desc) will **increase** coverage by `0.01%`. > The diff coverage is `100%`. [](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4364?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master #4364 +/- ## === + Coverage 53.88% 53.9% +0.01% Complexity 351 351 === Files 10471047 Lines 19288 19296 +8 Branches 35503553 +3 === + Hits 10393 10401 +8 Misses 82388238 Partials657 657 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4364?src=pr&el=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...rite/token/generator/impl/IndexTokenGenerator.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4364/diff?src=pr&el=tree#diff-c2hhcmRpbmctY29yZS9zaGFyZGluZy1jb3JlLXJld3JpdGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NoYXJkaW5nL3Jld3JpdGUvdG9rZW4vZ2VuZXJhdG9yL2ltcGwvSW5kZXhUb2tlbkdlbmVyYXRvci5qYXZh) | `100% <100%> (ø)` | `1 <0> (ø)` | :arrow_down: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4364?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4364?src=pr&el=footer). Last update [6ce5057...3b4d01e](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4364?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] tristaZero merged pull request #4364: decouple find IndexSegment with SQLStatement
tristaZero merged pull request #4364: decouple find IndexSegment with SQLStatement URL: https://github.com/apache/incubator-shardingsphere/pull/4364 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu opened a new pull request #4364: decouple find IndexSegment with SQLStatement
terrymanu opened a new pull request #4364: decouple find IndexSegment with SQLStatement URL: https://github.com/apache/incubator-shardingsphere/pull/4364 For #4342. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] kimmking commented on issue #4269: Version conflict ：sharding-orchestration-reg-zookeeper-curator-4.0.0
kimmking commented on issue #4269: Version conflict ：sharding-orchestration-reg-zookeeper-curator-4.0.0 URL: https://github.com/apache/incubator-shardingsphere/issues/4269#issuecomment-588044489 Hello @joinhappy81 You should find which dependency importing the wrong curator and exclude it. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] coveralls edited a comment on issue #4360: decouple find InsertValuesSegment with insert statement
coveralls edited a comment on issue #4360: decouple find InsertValuesSegment with insert statement URL: https://github.com/apache/incubator-shardingsphere/pull/4360#issuecomment-588040591 ## Pull Request Test Coverage Report for [Build 1805](https://coveralls.io/builds/28816921) * **5** of **6** **(83.33%)** changed or added relevant lines in **4** files are covered. * No unchanged relevant lines lost coverage. * Overall coverage remained the same at **57.347%** --- | Changes Missing Coverage | Covered Lines | Changed/Added Lines | % | | :-|--||---: | | [shadow-core/shadow-core-rewrite/src/main/java/org/apache/shardingsphere/shadow/rewrite/token/generator/impl/ShadowInsertValuesTokenGenerator.java](https://coveralls.io/builds/28816921/source?filename=shadow-core%2Fshadow-core-rewrite%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshadow%2Frewrite%2Ftoken%2Fgenerator%2Fimpl%2FShadowInsertValuesTokenGenerator.java#L52) | 0 | 1 | 0.0% | Totals | [](https://coveralls.io/builds/28816921) | | :-- | --: | | Change from base [Build 878](https://coveralls.io/builds/28801195): | 0.0% | | Covered Lines: | 11061 | | Relevant Lines: | 19288 | --- # 💛 - [Coveralls](https://coveralls.io) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] tristaZero commented on issue #4363: Bugfix for new Visitor parser
tristaZero commented on issue #4363: Bugfix for new Visitor parser URL: https://github.com/apache/incubator-shardingsphere/issues/4363#issuecomment-588040838 Fixed at #4337 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] tristaZero opened a new issue #4363: Bugfix for new Visitor parser
tristaZero opened a new issue #4363: Bugfix for new Visitor parser URL: https://github.com/apache/incubator-shardingsphere/issues/4363 - [ ] Add judgement for sub query used at select items. - [ ] Return corrent Segment for boolean value. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] coveralls commented on issue #4360: decouple find InsertValuesSegment with insert statement
coveralls commented on issue #4360: decouple find InsertValuesSegment with insert statement URL: https://github.com/apache/incubator-shardingsphere/pull/4360#issuecomment-588040591 ## Pull Request Test Coverage Report for [Build 9641](https://coveralls.io/builds/28816892) * **5** of **6** **(83.33%)** changed or added relevant lines in **4** files are covered. * **3** unchanged lines in **1** file lost coverage. * Overall coverage decreased (**-0.005%**) to **57.341%** --- | Changes Missing Coverage | Covered Lines | Changed/Added Lines | % | | :-|--||---: | | [shadow-core/shadow-core-rewrite/src/main/java/org/apache/shardingsphere/shadow/rewrite/token/generator/impl/ShadowInsertValuesTokenGenerator.java](https://coveralls.io/builds/28816892/source?filename=shadow-core%2Fshadow-core-rewrite%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshadow%2Frewrite%2Ftoken%2Fgenerator%2Fimpl%2FShadowInsertValuesTokenGenerator.java#L52) | 0 | 1 | 0.0% | Files with Coverage Reduction | New Missed Lines | % | | :-|--|--: | | [sharding-orchestration/sharding-orchestration-core/src/main/java/org/apache/shardingsphere/orchestration/internal/util/IpUtils.java](https://coveralls.io/builds/28816892/source?filename=sharding-orchestration%2Fsharding-orchestration-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Forchestration%2Finternal%2Futil%2FIpUtils.java#L63) | 3 | 76.0% | | Totals | [](https://coveralls.io/builds/28816892) | | :-- | --: | | Change from base [Build 878](https://coveralls.io/builds/28801195): | -0.005% | | Covered Lines: | 11060 | | Relevant Lines: | 19288 | --- # 💛 - [Coveralls](https://coveralls.io) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] tristaZero commented on issue #4362: Support parsing `DropIndex` and `CreateIndex` for PostgreSQL when using new ShardingParser
tristaZero commented on issue #4362: Support parsing `DropIndex` and `CreateIndex` for PostgreSQL when using new ShardingParser URL: https://github.com/apache/incubator-shardingsphere/issues/4362#issuecomment-588040181 Fixed at #4337 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] tristaZero closed issue #4362: Support parsing `DropIndex` and `CreateIndex` for PostgreSQL when using new ShardingParser
tristaZero closed issue #4362: Support parsing `DropIndex` and `CreateIndex` for PostgreSQL when using new ShardingParser URL: https://github.com/apache/incubator-shardingsphere/issues/4362 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] tristaZero opened a new issue #4362: Support parsing `DropIndex` and `CreateIndex` for PostgreSQL when using new ShardingParser
tristaZero opened a new issue #4362: Support parsing `DropIndex` and `CreateIndex` for PostgreSQL when using new ShardingParser URL: https://github.com/apache/incubator-shardingsphere/issues/4362 Add `DropIndex` and `CreateIndex` visitors for CreateIndexDDLVisitor. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] kimmking commented on issue #3697: Cannot find table rule and default data source with logic tables
kimmking commented on issue #3697: Cannot find table rule and default data source with logic tables URL: https://github.com/apache/incubator-shardingsphere/issues/3697#issuecomment-588039558 @menghaoranss Is duplicated? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] codecov-io commented on issue #4360: decouple find InsertValuesSegment with insert statement
codecov-io commented on issue #4360: decouple find InsertValuesSegment with insert statement URL: https://github.com/apache/incubator-shardingsphere/pull/4360#issuecomment-588039225 # [Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4360?src=pr&el=h1) Report > Merging [#4360](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4360?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-shardingsphere/commit/00f0db675f0f0ec0e622304b99a6d889446fd6c3?src=pr&el=desc) will **not change** coverage. > The diff coverage is `83.33%`. [](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4360?src=pr&el=tree) ```diff @@Coverage Diff@@ ## master#4360 +/- ## = Coverage 53.88% 53.88% Complexity 351 351 = Files 1047 1047 Lines 1928819288 Branches 3550 3550 = Hits 1039310393 Misses 8238 8238 Partials657 657 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4360?src=pr&el=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...nerator/impl/ShadowInsertValuesTokenGenerator.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4360/diff?src=pr&el=tree#diff-c2hhZG93LWNvcmUvc2hhZG93LWNvcmUtcmV3cml0ZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc2hhZG93L3Jld3JpdGUvdG9rZW4vZ2VuZXJhdG9yL2ltcGwvU2hhZG93SW5zZXJ0VmFsdWVzVG9rZW5HZW5lcmF0b3IuamF2YQ==) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: | | [...rator/impl/ShardingInsertValuesTokenGenerator.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4360/diff?src=pr&el=tree#diff-c2hhcmRpbmctY29yZS9zaGFyZGluZy1jb3JlLXJld3JpdGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NoYXJkaW5nL3Jld3JpdGUvdG9rZW4vZ2VuZXJhdG9yL2ltcGwvU2hhcmRpbmdJbnNlcnRWYWx1ZXNUb2tlbkdlbmVyYXRvci5qYXZh) | `86.95% <100%> (ø)` | `1 <0> (ø)` | :arrow_down: | | [...keygen/GeneratedKeyInsertValuesTokenGenerator.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4360/diff?src=pr&el=tree#diff-c2hhcmRpbmctY29yZS9zaGFyZGluZy1jb3JlLXJld3JpdGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NoYXJkaW5nL3Jld3JpdGUvdG9rZW4vZ2VuZXJhdG9yL2ltcGwva2V5Z2VuL0dlbmVyYXRlZEtleUluc2VydFZhbHVlc1Rva2VuR2VuZXJhdG9yLmphdmE=) | `90% <100%> (ø)` | `1 <0> (ø)` | :arrow_down: | | [...erator/impl/EncryptInsertValuesTokenGenerator.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4360/diff?src=pr&el=tree#diff-ZW5jcnlwdC1jb3JlL2VuY3J5cHQtY29yZS1yZXdyaXRlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9lbmNyeXB0L3Jld3JpdGUvdG9rZW4vZ2VuZXJhdG9yL2ltcGwvRW5jcnlwdEluc2VydFZhbHVlc1Rva2VuR2VuZXJhdG9yLmphdmE=) | `75.34% <100%> (ø)` | `1 <0> (ø)` | :arrow_down: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4360?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4360?src=pr&el=footer). Last update [00f0db6...00e1a56](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4360?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] tristaZero closed issue #4361: Support parsing `Add `BeginTransactionStatement` for new sharding parser` for SQLServer when using new ShardingParser
tristaZero closed issue #4361: Support parsing `Add `BeginTransactionStatement` for new sharding parser` for SQLServer when using new ShardingParser URL: https://github.com/apache/incubator-shardingsphere/issues/4361 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] tristaZero commented on issue #4361: Support parsing `Add `BeginTransactionStatement` for new sharding parser` for SQLServer when using new ShardingParser
tristaZero commented on issue #4361: Support parsing `Add `BeginTransactionStatement` for new sharding parser` for SQLServer when using new ShardingParser URL: https://github.com/apache/incubator-shardingsphere/issues/4361#issuecomment-588038657 Fixed at #4337 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] tristaZero opened a new issue #4361: Support parsing `Add `BeginTransactionStatement` for new sharding parser` for SQLServer when using new ShardingParser
tristaZero opened a new issue #4361: Support parsing `Add `BeginTransactionStatement` for new sharding parser` for SQLServer when using new ShardingParser URL: https://github.com/apache/incubator-shardingsphere/issues/4361 Add `BeginTransactionStatement` visitor for SQLServerTCLVisitor. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] tristaZero merged pull request #4360: decouple find InsertValuesSegment with insert statement
tristaZero merged pull request #4360: decouple find InsertValuesSegment with insert statement URL: https://github.com/apache/incubator-shardingsphere/pull/4360 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu merged pull request #4352: update docs of performance test
terrymanu merged pull request #4352: update docs of performance test URL: https://github.com/apache/incubator-shardingsphere/pull/4352 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu opened a new pull request #4360: decouple find InsertValuesSegment with insert statement
terrymanu opened a new pull request #4360: decouple find InsertValuesSegment with insert statement URL: https://github.com/apache/incubator-shardingsphere/pull/4360 For #4342. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] menghaoranss commented on issue #4276: No available sharding rule configuration in `logic_db` for orchestration.
menghaoranss commented on issue #4276: No available sharding rule configuration in `logic_db` for orchestration. URL: https://github.com/apache/incubator-shardingsphere/issues/4276#issuecomment-588005098 I tried this with the latest code，the following configuration can be supported **without** orchestration: `spring.shardingsphere.sharding.default-table-strategy.none=` see [#4043 ](https://github.com/apache/incubator-shardingsphere/issues/4043) But orchestration does not support empty table-strategy now. I will commit a PR later to try to fix it. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] coveralls edited a comment on issue #4352: update docs of performance test
coveralls edited a comment on issue #4352: update docs of performance test URL: https://github.com/apache/incubator-shardingsphere/pull/4352#issuecomment-587385589 ## Pull Request Test Coverage Report for [Build 9640](https://coveralls.io/builds/28814895) * **0** of **0** changed or added relevant lines in **0** files are covered. * **738** unchanged lines in **21** files lost coverage. * Overall coverage decreased (**-0.3%**) to **57.341%** --- | Files with Coverage Reduction | New Missed Lines | % | | :-|--|--: | | [sharding-proxy/sharding-proxy-backend/src/main/java/org/apache/shardingsphere/shardingproxy/backend/text/TextProtocolBackendHandlerFactory.java](https://coveralls.io/builds/28814895/source?filename=sharding-proxy%2Fsharding-proxy-backend%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingproxy%2Fbackend%2Ftext%2FTextProtocolBackendHandlerFactory.java#L108) | 1 | 79.31% | | [shardingsphere-sql-parser/shardingsphere-sql-parser-engine/src/main/java/org/apache/shardingsphere/sql/parser/core/extractor/SQLSegmentsExtractorEngine.java](https://coveralls.io/builds/28814895/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-engine%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fcore%2Fextractor%2FSQLSegmentsExtractorEngine.java#L33) | 1 | 0% | | [shardingsphere-sql-parser/shardingsphere-sql-parser-engine/src/main/java/org/apache/shardingsphere/sql/parser/sql/statement/dal/dialect/mysql/ShowIndexStatement.java](https://coveralls.io/builds/28814895/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-engine%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fsql%2Fstatement%2Fdal%2Fdialect%2Fmysql%2FShowIndexStatement.java#L33) | 2 | 0% | | [sharding-orchestration/sharding-orchestration-core/src/main/java/org/apache/shardingsphere/orchestration/internal/util/IpUtils.java](https://coveralls.io/builds/28814895/source?filename=sharding-orchestration%2Fsharding-orchestration-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Forchestration%2Finternal%2Futil%2FIpUtils.java#L63) | 3 | 76.0% | | [shardingsphere-sql-parser/shardingsphere-sql-parser-engine/src/main/java/org/apache/shardingsphere/sql/parser/sql/statement/dml/SelectStatement.java](https://coveralls.io/builds/28814895/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-engine%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fsql%2Fstatement%2Fdml%2FSelectStatement.java#L61) | 5 | 28.57% | | [sharding-proxy/sharding-proxy-frontend/sharding-proxy-frontend-mysql/src/main/java/org/apache/shardingsphere/shardingproxy/frontend/mysql/command/query/binary/prepare/MySQLComStmtPrepareExecutor.java](https://coveralls.io/builds/28814895/source?filename=sharding-proxy%2Fsharding-proxy-frontend%2Fsharding-proxy-frontend-mysql%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingproxy%2Ffrontend%2Fmysql%2Fcommand%2Fquery%2Fbinary%2Fprepare%2FMySQLComStmtPrepareExecutor.java#L40) | 8 | 0% | | [shardingsphere-sql-parser/shardingsphere-sql-parser-sqlserver/src/main/java/org/apache/shardingsphere/sql/parser/visitor/impl/SQLServerTCLVisitor.java](https://coveralls.io/builds/28814895/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-sqlserver%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fvisitor%2Fimpl%2FSQLServerTCLVisitor.java#L38) | 8 | 0% | | [shardingsphere-sql-parser/shardingsphere-sql-parser-engine/src/main/java/org/apache/shardingsphere/sql/parser/core/SQLParseKernel.java](https://coveralls.io/builds/28814895/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-engine%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fcore%2FSQLParseKernel.java#L45) | 10 | 0% | | [shardingsphere-sql-parser/shardingsphere-sql-parser-mysql/src/main/java/org/apache/shardingsphere/sql/parser/visitor/impl/MySQLDALVisitor.java](https://coveralls.io/builds/28814895/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-mysql%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fvisitor%2Fimpl%2FMySQLDALVisitor.java#L137) | 10 | 0% | | [shardingsphere-sql-parser/shardingsphere-sql-parser-engine/src/main/java/org/apache/shardingsphere/sql/parser/core/rule/registry/ParseRuleRegistry.java](https://coveralls.io/builds/28814895/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-engine%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fcore%2Frule%2Fregistry%2FParseRuleRegistry.java#L46) | 16 | 0% | | Totals | [](https://coveralls.io/builds/28814895) | | :-- | --: | | Change from base [Build 875](https://coveralls.io/builds/28793443): | -0.3% | | Covered Lines: | 11060 | | Relevant Lines: | 19288 | --- ##
[GitHub] [incubator-shardingsphere] coveralls edited a comment on issue #4352: update docs of performance test
coveralls edited a comment on issue #4352: update docs of performance test URL: https://github.com/apache/incubator-shardingsphere/pull/4352#issuecomment-587385589 ## Pull Request Test Coverage Report for [Build 1804](https://coveralls.io/builds/28814829) * **0** of **0** changed or added relevant lines in **0** files are covered. * **735** unchanged lines in **20** files lost coverage. * Overall coverage decreased (**-0.3%**) to **57.347%** --- | Files with Coverage Reduction | New Missed Lines | % | | :-|--|--: | | [sharding-proxy/sharding-proxy-backend/src/main/java/org/apache/shardingsphere/shardingproxy/backend/text/TextProtocolBackendHandlerFactory.java](https://coveralls.io/builds/28814829/source?filename=sharding-proxy%2Fsharding-proxy-backend%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingproxy%2Fbackend%2Ftext%2FTextProtocolBackendHandlerFactory.java#L108) | 1 | 79.31% | | [shardingsphere-sql-parser/shardingsphere-sql-parser-engine/src/main/java/org/apache/shardingsphere/sql/parser/core/extractor/SQLSegmentsExtractorEngine.java](https://coveralls.io/builds/28814829/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-engine%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fcore%2Fextractor%2FSQLSegmentsExtractorEngine.java#L33) | 1 | 0% | | [shardingsphere-sql-parser/shardingsphere-sql-parser-engine/src/main/java/org/apache/shardingsphere/sql/parser/sql/statement/dal/dialect/mysql/ShowIndexStatement.java](https://coveralls.io/builds/28814829/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-engine%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fsql%2Fstatement%2Fdal%2Fdialect%2Fmysql%2FShowIndexStatement.java#L33) | 2 | 0% | | [shardingsphere-sql-parser/shardingsphere-sql-parser-engine/src/main/java/org/apache/shardingsphere/sql/parser/sql/statement/dml/SelectStatement.java](https://coveralls.io/builds/28814829/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-engine%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fsql%2Fstatement%2Fdml%2FSelectStatement.java#L61) | 5 | 28.57% | | [sharding-proxy/sharding-proxy-frontend/sharding-proxy-frontend-mysql/src/main/java/org/apache/shardingsphere/shardingproxy/frontend/mysql/command/query/binary/prepare/MySQLComStmtPrepareExecutor.java](https://coveralls.io/builds/28814829/source?filename=sharding-proxy%2Fsharding-proxy-frontend%2Fsharding-proxy-frontend-mysql%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingproxy%2Ffrontend%2Fmysql%2Fcommand%2Fquery%2Fbinary%2Fprepare%2FMySQLComStmtPrepareExecutor.java#L40) | 8 | 0% | | [shardingsphere-sql-parser/shardingsphere-sql-parser-sqlserver/src/main/java/org/apache/shardingsphere/sql/parser/visitor/impl/SQLServerTCLVisitor.java](https://coveralls.io/builds/28814829/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-sqlserver%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fvisitor%2Fimpl%2FSQLServerTCLVisitor.java#L38) | 8 | 0% | | [shardingsphere-sql-parser/shardingsphere-sql-parser-engine/src/main/java/org/apache/shardingsphere/sql/parser/core/SQLParseKernel.java](https://coveralls.io/builds/28814829/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-engine%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fcore%2FSQLParseKernel.java#L45) | 10 | 0% | | [shardingsphere-sql-parser/shardingsphere-sql-parser-mysql/src/main/java/org/apache/shardingsphere/sql/parser/visitor/impl/MySQLDALVisitor.java](https://coveralls.io/builds/28814829/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-mysql%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fvisitor%2Fimpl%2FMySQLDALVisitor.java#L137) | 10 | 0% | | [shardingsphere-sql-parser/shardingsphere-sql-parser-engine/src/main/java/org/apache/shardingsphere/sql/parser/core/rule/registry/ParseRuleRegistry.java](https://coveralls.io/builds/28814829/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-engine%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fcore%2Frule%2Fregistry%2FParseRuleRegistry.java#L46) | 16 | 0% | | [shardingsphere-sql-parser/shardingsphere-sql-parser-sql92/src/main/java/org/apache/shardingsphere/sql/parser/visitor/SQL92Visitor.java](https://coveralls.io/builds/28814829/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-sql92%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fvisitor%2FSQL92Visitor.java#L334) | 31 | 0% | | Totals | [](https://coveralls.io/builds/28814829) | | :-- | --: | | Change from base [Build 875](https://coveralls.io/builds/28793443): | -0.3% | | Covered Lines: | 11061 | | Relevant Lines: | 19288 | ---
[GitHub] [incubator-shardingsphere] codecov-io commented on issue #4352: update docs of performance test
codecov-io commented on issue #4352: update docs of performance test URL: https://github.com/apache/incubator-shardingsphere/pull/4352#issuecomment-587996991 # [Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4352?src=pr&el=h1) Report > Merging [#4352](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4352?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-shardingsphere/commit/f26a0c22bc1265c4747ca77abc3969faaf44f751?src=pr&el=desc) will **decrease** coverage by `0.27%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4352?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master#4352 +/- ## - Coverage 54.16% 53.88% -0.28% + Complexity 352 351 -1 Files 1046 1047 +1 Lines 1923719288 +51 Branches 3536 3550 +14 - Hits 1041910393 -26 - Misses 8161 8238 +77 Partials657 657 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4352?src=pr&el=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...shardingsphere/sql/parser/core/SQLParseKernel.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4352/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLWVuZ2luZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc3FsL3BhcnNlci9jb3JlL1NRTFBhcnNlS2VybmVsLmphdmE=) | `0% <0%> (-100%)` | `0% <0%> (ø)` | | | [...l/parser/core/rule/registry/ParseRuleRegistry.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4352/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLWVuZ2luZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc3FsL3BhcnNlci9jb3JlL3J1bGUvcmVnaXN0cnkvUGFyc2VSdWxlUmVnaXN0cnkuamF2YQ==) | `0% <0%> (-55.56%)` | `0% <0%> (ø)` | | | [...ser/core/extractor/SQLSegmentsExtractorEngine.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4352/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLWVuZ2luZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc3FsL3BhcnNlci9jb3JlL2V4dHJhY3Rvci9TUUxTZWdtZW50c0V4dHJhY3RvckVuZ2luZS5qYXZh) | `0% <0%> (-9.1%)` | `0% <0%> (-1%)` | | | [...ackend/text/TextProtocolBackendHandlerFactory.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4352/diff?src=pr&el=tree#diff-c2hhcmRpbmctcHJveHkvc2hhcmRpbmctcHJveHktYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc2hhcmRpbmdwcm94eS9iYWNrZW5kL3RleHQvVGV4dFByb3RvY29sQmFja2VuZEhhbmRsZXJGYWN0b3J5LmphdmE=) | `72.41% <0%> (-6.9%)` | `0% <0%> (ø)` | | | [.../sql/parser/sql/statement/dml/SelectStatement.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4352/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLWVuZ2luZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc3FsL3BhcnNlci9zcWwvc3RhdGVtZW50L2RtbC9TZWxlY3RTdGF0ZW1lbnQuamF2YQ==) | `28.57% <0%> (-4.77%)` | `0% <0%> (ø)` | | | [...ingsphere/sql/parser/visitor/SQLServerVisitor.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4352/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLXNxbHNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc3FsL3BhcnNlci92aXNpdG9yL1NRTFNlcnZlclZpc2l0b3IuamF2YQ==) | `0% <0%> (ø)` | `0% <0%> (ø)` | :arrow_down: | | [...hardingsphere/sql/parser/visitor/MySQLVisitor.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4352/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLW15c3FsL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9zcWwvcGFyc2VyL3Zpc2l0b3IvTXlTUUxWaXNpdG9yLmphdmE=) | `0% <0%> (ø)` | `0% <0%> (ø)` | :arrow_down: | | [...phere/sql/parser/visitor/impl/MySQLDALVisitor.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4352/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLW15c3FsL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9zcWwvcGFyc2VyL3Zpc2l0b3IvaW1wbC9NeVNRTERBTFZpc2l0b3IuamF2YQ==) | `0% <0%> (ø)` | `0% <0%> (ø)` | :arrow_down: | | [...ngsphere/sql/parser/visitor/PostgreSQLVisitor.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4352/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLXBvc3RncmVzcWwvc3JjL21ha
[incubator-shardingsphere-benchmark] branch master updated: for performance
This is an automated email from the ASF dual-hosted git repository.
zhangyonglun pushed a commit to branch master
in repository
https://gitbox.apache.org/repos/asf/incubator-shardingsphere-benchmark.git
The following commit(s) were added to refs/heads/master by this push:
new 01311c3 for performance
01311c3 is described below
commit 01311c3257d20e12962cca8e3c5326b99671b0c2
Author: tuohai666
AuthorDate: Wed Feb 19 08:59:38 2020 +0800
for performance
---
report/jtl_json/full_route_test.json| 2 +-
report/jtl_json/master_slave_encrypt_sharding_test.json | 2 +-
report/jtl_json/master_slave_test.json | 2 +-
report/jtl_json/single_route_test.json | 2 +-
4 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/report/jtl_json/full_route_test.json
b/report/jtl_json/full_route_test.json
index 922e46b..f5dafc2 100644
--- a/report/jtl_json/full_route_test.json
+++ b/report/jtl_json/full_route_test.json
@@ -1 +1 @@
-{"SELECT": [{"data": [{"99.9th": "9", "Err": "0.0%", "95th": "2", "50th": "1",
"Max": "10", "Min": "0", "Throughout": "23036.87", "Samples": 4999, "Date":
"2019.12.19 02:35:57 ", "Avg": "0"}, {"99.9th": "9", "Err": "0.0%", "95th":
"2", "50th": "1", "Max": "9", "Min": "0", "Throughout": "22619.91", "Samples":
4999, "Date": "2019.12.20 13:34:47 ", "Avg": "0"}, {"99.9th": "9", "Err":
"0.0%", "95th": "2", "50th": "1", "Max": "9", "Min": "0", "Throughout":
"22931.19", "Samples": 4999, "Date": [...]
\ No newline at end of file
+{"SELECT": [{"data": [{"99.9th": "9", "Err": "0.0%", "95th": "2", "50th": "1",
"Max": "10", "Min": "0", "Throughout": "23036.87", "Samples": 4999, "Date":
"2019.12.19 02:35:57 ", "Avg": "0"}, {"99.9th": "9", "Err": "0.0%", "95th":
"2", "50th": "1", "Max": "9", "Min": "0", "Throughout": "22619.91", "Samples":
4999, "Date": "2019.12.20 13:34:47 ", "Avg": "0"}, {"99.9th": "9", "Err":
"0.0%", "95th": "2", "50th": "1", "Max": "9", "Min": "0", "Throughout":
"22931.19", "Samples": 4999, "Date": [...]
\ No newline at end of file
diff --git a/report/jtl_json/master_slave_encrypt_sharding_test.json
b/report/jtl_json/master_slave_encrypt_sharding_test.json
index 2167b57..b3a77c5 100644
--- a/report/jtl_json/master_slave_encrypt_sharding_test.json
+++ b/report/jtl_json/master_slave_encrypt_sharding_test.json
@@ -1 +1 @@
-{"SELECT": [{"data": [{"99.9th": "16", "Err": "0.0%", "95th": "3", "50th":
"2", "Max": "66", "Min": "1", "Throughout": "9381.73", "Samples": 99,
"Date": "2019.12.19 02:40:33 ", "Avg": "2"}, {"99.9th": "16", "Err": "0.0%",
"95th": "3", "50th": "2", "Max": "62", "Min": "1", "Throughout": "9038.48",
"Samples": 99, "Date": "2019.12.20 13:39:23 ", "Avg": "2"}, {"99.9th":
"16", "Err": "0.0%", "95th": "3", "50th": "2", "Max": "63", "Min": "1",
"Throughout": "9071.44", "Samples": 99, [...]
\ No newline at end of file
+{"SELECT": [{"data": [{"99.9th": "16", "Err": "0.0%", "95th": "3", "50th":
"2", "Max": "66", "Min": "1", "Throughout": "9381.73", "Samples": 99,
"Date": "2019.12.19 02:40:33 ", "Avg": "2"}, {"99.9th": "16", "Err": "0.0%",
"95th": "3", "50th": "2", "Max": "62", "Min": "1", "Throughout": "9038.48",
"Samples": 99, "Date": "2019.12.20 13:39:23 ", "Avg": "2"}, {"99.9th":
"16", "Err": "0.0%", "95th": "3", "50th": "2", "Max": "63", "Min": "1",
"Throughout": "9071.44", "Samples": 99, [...]
\ No newline at end of file
diff --git a/report/jtl_json/master_slave_test.json
b/report/jtl_json/master_slave_test.json
index 3a98a6d..1fca31f 100644
--- a/report/jtl_json/master_slave_test.json
+++ b/report/jtl_json/master_slave_test.json
@@ -1 +1 @@
-{"INSERT+SELECT+DELETE": [{"data": [], "type": "Sharding-Proxy_3.1"}, {"data":
[{"99.9th": "38", "Err": "0.0%", "95th": "16", "50th": "11", "Max": "48",
"Min": "7", "Throughout": "1720.96", "Samples": 29709, "Date": "2020.01.01
02:49:45 ", "Avg": "11"}, {"99.9th": "27", "Err": "0.0%", "95th": "16", "50th":
"11", "Max": "37", "Min": "7", "Throughout": "1701.38", "Samples": 17218,
"Date": "2020.01.02 02:49:52 ", "Avg": "11"}, {"99.9th": "30", "Err": "0.0%",
"95th": "16", "50th": "11", "Max [...]
\ No newline at end of file
+{"INSERT+SELECT+DELETE": [{"data": [], "type": "Sharding-Proxy_3.1"}, {"data":
[{"99.9th": "38", "Err": "0.0%", "95th": "16", "50th": "11", "Max": "48",
"Min": "7", "Throughout": "1720.96", "Samples": 29709, "Date": "2020.01.01
02:49:45 ", "Avg": "11"}, {"99.9th": "27", "Err": "0.0%", "95th": "16", "50th":
"11", "Max": "37", "Min": "7", "Throughout": "1701.38", "Samples": 17218,
"Date": "2020.01.02 02:49:52 ", "Avg": "11"}, {"99.9th": "30", "Err": "0.0%",
"95th": "16", "50th": "11", "Max [...]
\ No newline at end of file
diff --git a/report/jtl_json/single_route_test.json
b/report/jtl_json/single_route_test.json
index 5085c19..3bf9c93 100644
--- a/report/jtl_json/single_route_test.json
+++ b/report/jtl_json/single_route_test.json
@@ -1 +1 @@
-{"SELECT": [{"data": [], "type": "Sharding-Proxy_
[GitHub] [incubator-shardingsphere] ppourali commented on issue #4317: Use encrypt-raw-jdbc-example fails because of "Unsupport SQL of " error
ppourali commented on issue #4317: Use encrypt-raw-jdbc-example fails because of "Unsupport SQL of " error URL: https://github.com/apache/incubator-shardingsphere/issues/4317#issuecomment-587928211 Hi terrymanu, It's 4.0.0. I just cloned the master branch. As mentioned, only _select_ statements can be performed. Thanks, Parsa This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] saboluo commented on issue #4306: Why do distributed primary keys need to be retrieved in reverse order in ShardingGeneratedKeyInsertValueParameterRewriter.rewrite
saboluo commented on issue #4306: Why do distributed primary keys need to be retrieved in reverse order in ShardingGeneratedKeyInsertValueParameterRewriter.rewrite URL: https://github.com/apache/incubator-shardingsphere/issues/4306#issuecomment-587545007 right This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] kimmking commented on issue #4306: Why do distributed primary keys need to be retrieved in reverse order in ShardingGeneratedKeyInsertValueParameterRewriter.rewrite
kimmking commented on issue #4306: Why do distributed primary keys need to be retrieved in reverse order in ShardingGeneratedKeyInsertValueParameterRewriter.rewrite URL: https://github.com/apache/incubator-shardingsphere/issues/4306#issuecomment-587541189 you means this data should be insert into user0, but insert into user2 actually. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] kimmking commented on issue #4338: Sharding-Proxy output logs：readAddress(..) failed: Connection reset by peer
kimmking commented on issue #4338: Sharding-Proxy output logs：readAddress(..) failed: Connection reset by peer URL: https://github.com/apache/incubator-shardingsphere/issues/4338#issuecomment-587538810 I think we can ignore this message. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] coveralls edited a comment on issue #4353: #4255, use CAPI in stmt mode return incorrect response
coveralls edited a comment on issue #4353: #4255, use CAPI in stmt mode return incorrect response URL: https://github.com/apache/incubator-shardingsphere/pull/4353#issuecomment-587393669 ## Pull Request Test Coverage Report for [Build 1802](https://coveralls.io/builds/28801203) * **8** of **9** **(88.89%)** changed or added relevant lines in **3** files are covered. * **730** unchanged lines in **21** files lost coverage. * Overall coverage decreased (**-0.3%**) to **57.347%** --- | Changes Missing Coverage | Covered Lines | Changed/Added Lines | % | | :-|--||---: | | [sharding-proxy/sharding-proxy-frontend/sharding-proxy-frontend-mysql/src/main/java/org/apache/shardingsphere/shardingproxy/frontend/mysql/command/query/binary/prepare/MySQLComStmtPrepareExecutor.java](https://coveralls.io/builds/28801203/source?filename=sharding-proxy%2Fsharding-proxy-frontend%2Fsharding-proxy-frontend-mysql%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingproxy%2Ffrontend%2Fmysql%2Fcommand%2Fquery%2Fbinary%2Fprepare%2FMySQLComStmtPrepareExecutor.java#L60) | 0 | 1 | 0.0% | Files with Coverage Reduction | New Missed Lines | % | | :-|--|--: | | [sharding-proxy/sharding-proxy-backend/src/main/java/org/apache/shardingsphere/shardingproxy/backend/text/TextProtocolBackendHandlerFactory.java](https://coveralls.io/builds/28801203/source?filename=sharding-proxy%2Fsharding-proxy-backend%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingproxy%2Fbackend%2Ftext%2FTextProtocolBackendHandlerFactory.java#L108) | 1 | 79.31% | | [sharding-proxy/sharding-proxy-transport/sharding-proxy-transport-mysql/src/main/java/org/apache/shardingsphere/shardingproxy/transport/mysql/packet/command/query/MySQLColumnDefinition41Packet.java](https://coveralls.io/builds/28801203/source?filename=sharding-proxy%2Fsharding-proxy-transport%2Fsharding-proxy-transport-mysql%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingproxy%2Ftransport%2Fmysql%2Fpacket%2Fcommand%2Fquery%2FMySQLColumnDefinition41Packet.java#L37) | 1 | 98.0% | | [shardingsphere-sql-parser/shardingsphere-sql-parser-engine/src/main/java/org/apache/shardingsphere/sql/parser/core/extractor/SQLSegmentsExtractorEngine.java](https://coveralls.io/builds/28801203/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-engine%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fcore%2Fextractor%2FSQLSegmentsExtractorEngine.java#L33) | 1 | 0% | | [sharding-proxy/sharding-proxy-frontend/sharding-proxy-frontend-mysql/src/main/java/org/apache/shardingsphere/shardingproxy/frontend/mysql/command/query/binary/prepare/MySQLComStmtPrepareExecutor.java](https://coveralls.io/builds/28801203/source?filename=sharding-proxy%2Fsharding-proxy-frontend%2Fsharding-proxy-frontend-mysql%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingproxy%2Ffrontend%2Fmysql%2Fcommand%2Fquery%2Fbinary%2Fprepare%2FMySQLComStmtPrepareExecutor.java#L46) | 2 | 0% | | [shardingsphere-sql-parser/shardingsphere-sql-parser-engine/src/main/java/org/apache/shardingsphere/sql/parser/sql/statement/dal/dialect/mysql/ShowIndexStatement.java](https://coveralls.io/builds/28801203/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-engine%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fsql%2Fstatement%2Fdal%2Fdialect%2Fmysql%2FShowIndexStatement.java#L33) | 2 | 0% | | [shardingsphere-sql-parser/shardingsphere-sql-parser-engine/src/main/java/org/apache/shardingsphere/sql/parser/sql/statement/dml/SelectStatement.java](https://coveralls.io/builds/28801203/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-engine%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fsql%2Fstatement%2Fdml%2FSelectStatement.java#L61) | 5 | 28.57% | | [shardingsphere-sql-parser/shardingsphere-sql-parser-sqlserver/src/main/java/org/apache/shardingsphere/sql/parser/visitor/impl/SQLServerTCLVisitor.java](https://coveralls.io/builds/28801203/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-sqlserver%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fvisitor%2Fimpl%2FSQLServerTCLVisitor.java#L38) | 8 | 0% | | [shardingsphere-sql-parser/shardingsphere-sql-parser-engine/src/main/java/org/apache/shardingsphere/sql/parser/core/SQLParseKernel.java](https://coveralls.io/builds/28801203/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-engine%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fcore%2FSQLParseKernel.java#L45) | 10 | 0% | | [shardingsphere-sql-parser/shardingsphere-sql-parser-mysql/src/main/java/org/apache/shardingsphere/sql/parser/visitor/impl/MySQLDALVisitor.java](https://coveralls.io/builds/28801203/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-mysql%2Fsrc%2Fmain%2Fjava%2Forg%2Fapac
[GitHub] [incubator-shardingsphere] coveralls edited a comment on issue #4353: #4255, use CAPI in stmt mode return incorrect response
coveralls edited a comment on issue #4353: #4255, use CAPI in stmt mode return incorrect response URL: https://github.com/apache/incubator-shardingsphere/pull/4353#issuecomment-587393669 ## Pull Request Test Coverage Report for [Build 1803](https://coveralls.io/builds/28801172) * **6** of **7** **(85.71%)** changed or added relevant lines in **2** files are covered. * **729** unchanged lines in **20** files lost coverage. * Overall coverage decreased (**-0.3%**) to **57.352%** --- | Changes Missing Coverage | Covered Lines | Changed/Added Lines | % | | :-|--||---: | | [sharding-proxy/sharding-proxy-frontend/sharding-proxy-frontend-mysql/src/main/java/org/apache/shardingsphere/shardingproxy/frontend/mysql/command/query/binary/prepare/MySQLComStmtPrepareExecutor.java](https://coveralls.io/builds/28801172/source?filename=sharding-proxy%2Fsharding-proxy-frontend%2Fsharding-proxy-frontend-mysql%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingproxy%2Ffrontend%2Fmysql%2Fcommand%2Fquery%2Fbinary%2Fprepare%2FMySQLComStmtPrepareExecutor.java#L60) | 0 | 1 | 0.0% | Files with Coverage Reduction | New Missed Lines | % | | :-|--|--: | | [sharding-proxy/sharding-proxy-backend/src/main/java/org/apache/shardingsphere/shardingproxy/backend/text/TextProtocolBackendHandlerFactory.java](https://coveralls.io/builds/28801172/source?filename=sharding-proxy%2Fsharding-proxy-backend%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingproxy%2Fbackend%2Ftext%2FTextProtocolBackendHandlerFactory.java#L108) | 1 | 79.31% | | [shardingsphere-sql-parser/shardingsphere-sql-parser-engine/src/main/java/org/apache/shardingsphere/sql/parser/core/extractor/SQLSegmentsExtractorEngine.java](https://coveralls.io/builds/28801172/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-engine%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fcore%2Fextractor%2FSQLSegmentsExtractorEngine.java#L33) | 1 | 0% | | [sharding-proxy/sharding-proxy-frontend/sharding-proxy-frontend-mysql/src/main/java/org/apache/shardingsphere/shardingproxy/frontend/mysql/command/query/binary/prepare/MySQLComStmtPrepareExecutor.java](https://coveralls.io/builds/28801172/source?filename=sharding-proxy%2Fsharding-proxy-frontend%2Fsharding-proxy-frontend-mysql%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingproxy%2Ffrontend%2Fmysql%2Fcommand%2Fquery%2Fbinary%2Fprepare%2FMySQLComStmtPrepareExecutor.java#L46) | 2 | 0% | | [shardingsphere-sql-parser/shardingsphere-sql-parser-engine/src/main/java/org/apache/shardingsphere/sql/parser/sql/statement/dal/dialect/mysql/ShowIndexStatement.java](https://coveralls.io/builds/28801172/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-engine%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fsql%2Fstatement%2Fdal%2Fdialect%2Fmysql%2FShowIndexStatement.java#L33) | 2 | 0% | | [shardingsphere-sql-parser/shardingsphere-sql-parser-engine/src/main/java/org/apache/shardingsphere/sql/parser/sql/statement/dml/SelectStatement.java](https://coveralls.io/builds/28801172/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-engine%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fsql%2Fstatement%2Fdml%2FSelectStatement.java#L61) | 5 | 28.57% | | [shardingsphere-sql-parser/shardingsphere-sql-parser-sqlserver/src/main/java/org/apache/shardingsphere/sql/parser/visitor/impl/SQLServerTCLVisitor.java](https://coveralls.io/builds/28801172/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-sqlserver%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fvisitor%2Fimpl%2FSQLServerTCLVisitor.java#L38) | 8 | 0% | | [shardingsphere-sql-parser/shardingsphere-sql-parser-engine/src/main/java/org/apache/shardingsphere/sql/parser/core/SQLParseKernel.java](https://coveralls.io/builds/28801172/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-engine%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fcore%2FSQLParseKernel.java#L45) | 10 | 0% | | [shardingsphere-sql-parser/shardingsphere-sql-parser-mysql/src/main/java/org/apache/shardingsphere/sql/parser/visitor/impl/MySQLDALVisitor.java](https://coveralls.io/builds/28801172/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-mysql%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fvisitor%2Fimpl%2FMySQLDALVisitor.java#L137) | 10 | 0% | | [shardingsphere-sql-parser/shardingsphere-sql-parser-engine/src/main/java/org/apache/shardingsphere/sql/parser/core/rule/registry/ParseRuleRegistry.java](https://coveralls.io/builds/28801172/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-engine%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fcore%2Frule%2Fregistry%2FParseRuleRegistry.java#L46) | 16 | 0% |
[GitHub] [incubator-shardingsphere] coveralls edited a comment on issue #4337: Refactor sharding parser with Antlr visitor parser
coveralls edited a comment on issue #4337: Refactor sharding parser with Antlr visitor parser URL: https://github.com/apache/incubator-shardingsphere/pull/4337#issuecomment-587408455 ## Pull Request Test Coverage Report for [Build 1801](https://coveralls.io/builds/28800489) * **2** of **46** **(4.35%)** changed or added relevant lines in **14** files are covered. * **136** unchanged lines in **11** files lost coverage. * Overall coverage decreased (**-0.3%**) to **57.343%** --- | Changes Missing Coverage | Covered Lines | Changed/Added Lines | % | | :-|--||---: | | [shardingsphere-sql-parser/shardingsphere-sql-parser-engine/src/main/java/org/apache/shardingsphere/sql/parser/core/SQLParseKernel.java](https://coveralls.io/builds/28800489/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-engine%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fcore%2FSQLParseKernel.java#L49) | 0 | 1 | 0.0% | [shardingsphere-sql-parser/shardingsphere-sql-parser-sqlserver/src/main/java/org/apache/shardingsphere/sql/parser/visitor/impl/SQLServerTCLVisitor.java](https://coveralls.io/builds/28800489/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-sqlserver%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fvisitor%2Fimpl%2FSQLServerTCLVisitor.java#L54) | 0 | 1 | 0.0% | [shardingsphere-sql-parser/shardingsphere-sql-parser-mysql/src/main/java/org/apache/shardingsphere/sql/parser/visitor/MySQLVisitor.java](https://coveralls.io/builds/28800489/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-mysql%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fvisitor%2FMySQLVisitor.java#L355) | 0 | 2 | 0.0% | [shardingsphere-sql-parser/shardingsphere-sql-parser-oracle/src/main/java/org/apache/shardingsphere/sql/parser/visitor/OracleVisitor.java](https://coveralls.io/builds/28800489/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-oracle%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fvisitor%2FOracleVisitor.java#L336) | 0 | 2 | 0.0% | [shardingsphere-sql-parser/shardingsphere-sql-parser-oracle/src/main/java/org/apache/shardingsphere/sql/parser/visitor/impl/OracleDMLVisitor.java](https://coveralls.io/builds/28800489/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-oracle%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fvisitor%2Fimpl%2FOracleDMLVisitor.java#L344) | 0 | 2 | 0.0% | [shardingsphere-sql-parser/shardingsphere-sql-parser-postgresql/src/main/java/org/apache/shardingsphere/sql/parser/visitor/PostgreSQLVisitor.java](https://coveralls.io/builds/28800489/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-postgresql%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fvisitor%2FPostgreSQLVisitor.java#L338) | 0 | 2 | 0.0% | [shardingsphere-sql-parser/shardingsphere-sql-parser-postgresql/src/main/java/org/apache/shardingsphere/sql/parser/visitor/impl/PostgreSQLDMLVisitor.java](https://coveralls.io/builds/28800489/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-postgresql%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fvisitor%2Fimpl%2FPostgreSQLDMLVisitor.java#L353) | 0 | 2 | 0.0% | [shardingsphere-sql-parser/shardingsphere-sql-parser-sql92/src/main/java/org/apache/shardingsphere/sql/parser/visitor/SQL92Visitor.java](https://coveralls.io/builds/28800489/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-sql92%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fvisitor%2FSQL92Visitor.java#L327) | 0 | 2 | 0.0% | [shardingsphere-sql-parser/shardingsphere-sql-parser-sql92/src/main/java/org/apache/shardingsphere/sql/parser/visitor/impl/SQL92DMLVisitor.java](https://coveralls.io/builds/28800489/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-sql92%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fvisitor%2Fimpl%2FSQL92DMLVisitor.java#L314) | 0 | 2 | 0.0% | [shardingsphere-sql-parser/shardingsphere-sql-parser-sqlserver/src/main/java/org/apache/shardingsphere/sql/parser/visitor/SQLServerVisitor.java](https://coveralls.io/builds/28800489/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-sqlserver%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fvisitor%2FSQLServerVisitor.java#L337) | 0 | 2 | 0.0% | Files with Coverage Reduction | New Missed Lines | % | | :-|--|--: | | [sharding-proxy/sharding-proxy-backend/src/main/java/org/apache/shardingsphere/shardingproxy/backend/text/TextProtocolBackendHandlerFactory.java](https://coveralls.io/builds/28800489/source?filename=sharding-proxy%2Fsharding-proxy-backend%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingproxy%2Fbackend%2Ftext%2FTextProtocolBackendHandler
[GitHub] [incubator-shardingsphere] terrymanu merged pull request #4353: #4255, use CAPI in stmt mode return incorrect response
terrymanu merged pull request #4353: #4255, use CAPI in stmt mode return incorrect response URL: https://github.com/apache/incubator-shardingsphere/pull/4353 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu closed issue #4255: use CAPI in stmt mode , mysql_stmt_prepare and mysql_stmt_execute return incorrect response
terrymanu closed issue #4255: use CAPI in stmt mode ,mysql_stmt_prepare and mysql_stmt_execute return incorrect response URL: https://github.com/apache/incubator-shardingsphere/issues/4255 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu merged pull request #4337: Refactor sharding parser with Antlr visitor parser
terrymanu merged pull request #4337: Refactor sharding parser with Antlr visitor parser URL: https://github.com/apache/incubator-shardingsphere/pull/4337 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] tuohai666 commented on a change in pull request #4353: #4255, use CAPI in stmt mode return incorrect response
tuohai666 commented on a change in pull request #4353: #4255, use CAPI in stmt
mode return incorrect response
URL:
https://github.com/apache/incubator-shardingsphere/pull/4353#discussion_r380714127
##
File path:
sharding-proxy/sharding-proxy-frontend/sharding-proxy-frontend-mysql/src/main/java/org/apache/shardingsphere/shardingproxy/frontend/mysql/command/query/binary/prepare/MySQLComStmtPrepareExecutor.java
##
@@ -59,11 +55,9 @@ public MySQLComStmtPrepareExecutor(final
MySQLComStmtPreparePacket packet, final
SQLStatement sqlStatement =
logicSchema.getParseEngine().parse(packet.getSql(), true);
int parametersCount = sqlStatement.getParametersCount();
result.add(new MySQLComStmtPrepareOKPacket(++currentSequenceId,
PREPARED_STATEMENT_REGISTRY.register(packet.getSql(), parametersCount),
getNumColumns(), parametersCount, 0));
-TablesContext tablesContext = new TablesContext(sqlStatement);
for (int i = 0; i < parametersCount; i++) {
// TODO add column name
-result.add(new MySQLColumnDefinition41Packet(++currentSequenceId,
schemaName,
-tablesContext.isSingleTable() ?
tablesContext.getSingleTableName() : "", "", "", "", 100,
MySQLColumnType.MYSQL_TYPE_VARCHAR, 0));
+result.add(new MySQLColumnDefinition41Packet(++currentSequenceId,
"", "", "", "?", "", 0, MySQLColumnType.MYSQL_TYPE_VAR_STRING, 0));
Review comment:
OK. I'll add this in the reference issue.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu commented on a change in pull request #4353: #4255, use CAPI in stmt mode return incorrect response
terrymanu commented on a change in pull request #4353: #4255, use CAPI in stmt
mode return incorrect response
URL:
https://github.com/apache/incubator-shardingsphere/pull/4353#discussion_r380703126
##
File path:
sharding-proxy/sharding-proxy-frontend/sharding-proxy-frontend-mysql/src/main/java/org/apache/shardingsphere/shardingproxy/frontend/mysql/command/query/binary/prepare/MySQLComStmtPrepareExecutor.java
##
@@ -59,11 +55,9 @@ public MySQLComStmtPrepareExecutor(final
MySQLComStmtPreparePacket packet, final
SQLStatement sqlStatement =
logicSchema.getParseEngine().parse(packet.getSql(), true);
int parametersCount = sqlStatement.getParametersCount();
result.add(new MySQLComStmtPrepareOKPacket(++currentSequenceId,
PREPARED_STATEMENT_REGISTRY.register(packet.getSql(), parametersCount),
getNumColumns(), parametersCount, 0));
-TablesContext tablesContext = new TablesContext(sqlStatement);
for (int i = 0; i < parametersCount; i++) {
// TODO add column name
-result.add(new MySQLColumnDefinition41Packet(++currentSequenceId,
schemaName,
-tablesContext.isSingleTable() ?
tablesContext.getSingleTableName() : "", "", "", "", 100,
MySQLColumnType.MYSQL_TYPE_VARCHAR, 0));
+result.add(new MySQLColumnDefinition41Packet(++currentSequenceId,
"", "", "", "?", "", 0, MySQLColumnType.MYSQL_TYPE_VAR_STRING, 0));
Review comment:
We need to explain hard code with empty string
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu commented on a change in pull request #4359: for issue 4357
terrymanu commented on a change in pull request #4359: for issue 4357 URL: https://github.com/apache/incubator-shardingsphere/pull/4359#discussion_r380701578 ## File path: shardingsphere-sql-parser/shardingsphere-sql-parser-relation/src/test/java/org/apache/shardingsphere/sql/parser/relation/statement/SQLStatementContextFactoryTest.java ## @@ -1,3 +1,7 @@ + + + + Review comment: Please remove useless blank lines This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu commented on a change in pull request #4359: for issue 4357
terrymanu commented on a change in pull request #4359: for issue 4357 URL: https://github.com/apache/incubator-shardingsphere/pull/4359#discussion_r380700666 ## File path: shardingsphere-sql-parser/shardingsphere-sql-parser-relation/src/test/java/org/apache/shardingsphere/sql/parser/relation/statement/SQLStatementContextFactoryTest.java ## @@ -1,3 +1,7 @@ + + + + Review comment: Please remove useless blank lines This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] avalon566 merged pull request #4349: For#4286, Use source column metadata to avoid PG metadata problem
avalon566 merged pull request #4349: For#4286, Use source column metadata to avoid PG metadata problem URL: https://github.com/apache/incubator-shardingsphere/pull/4349 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] coveralls edited a comment on issue #4353: #4255, use CAPI in stmt mode return incorrect response
coveralls edited a comment on issue #4353: #4255, use CAPI in stmt mode return incorrect response URL: https://github.com/apache/incubator-shardingsphere/pull/4353#issuecomment-587393669 ## Pull Request Test Coverage Report for [Build 1800](https://coveralls.io/builds/28797403) * **6** of **7** **(85.71%)** changed or added relevant lines in **2** files are covered. * **109** unchanged lines in **6** files lost coverage. * Overall coverage decreased (**-0.02%**) to **57.615%** --- | Changes Missing Coverage | Covered Lines | Changed/Added Lines | % | | :-|--||---: | | [sharding-proxy/sharding-proxy-frontend/sharding-proxy-frontend-mysql/src/main/java/org/apache/shardingsphere/shardingproxy/frontend/mysql/command/query/binary/prepare/MySQLComStmtPrepareExecutor.java](https://coveralls.io/builds/28797403/source?filename=sharding-proxy%2Fsharding-proxy-frontend%2Fsharding-proxy-frontend-mysql%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingproxy%2Ffrontend%2Fmysql%2Fcommand%2Fquery%2Fbinary%2Fprepare%2FMySQLComStmtPrepareExecutor.java#L60) | 0 | 1 | 0.0% | Files with Coverage Reduction | New Missed Lines | % | | :-|--|--: | | [sharding-proxy/sharding-proxy-frontend/sharding-proxy-frontend-mysql/src/main/java/org/apache/shardingsphere/shardingproxy/frontend/mysql/command/query/binary/prepare/MySQLComStmtPrepareExecutor.java](https://coveralls.io/builds/28797403/source?filename=sharding-proxy%2Fsharding-proxy-frontend%2Fsharding-proxy-frontend-mysql%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingproxy%2Ffrontend%2Fmysql%2Fcommand%2Fquery%2Fbinary%2Fprepare%2FMySQLComStmtPrepareExecutor.java#L46) | 2 | 0% | | [shardingsphere-sql-parser/shardingsphere-sql-parser-engine/src/main/java/org/apache/shardingsphere/sql/parser/sql/statement/dal/dialect/mysql/ShowIndexStatement.java](https://coveralls.io/builds/28797403/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-engine%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fsql%2Fstatement%2Fdal%2Fdialect%2Fmysql%2FShowIndexStatement.java#L33) | 2 | 0% | | [shardingsphere-sql-parser/shardingsphere-sql-parser-engine/src/main/java/org/apache/shardingsphere/sql/parser/sql/statement/dml/SelectStatement.java](https://coveralls.io/builds/28797403/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-engine%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fsql%2Fstatement%2Fdml%2FSelectStatement.java#L61) | 5 | 28.57% | | [shardingsphere-sql-parser/shardingsphere-sql-parser-mysql/src/main/java/org/apache/shardingsphere/sql/parser/visitor/impl/MySQLDALVisitor.java](https://coveralls.io/builds/28797403/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-mysql%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fvisitor%2Fimpl%2FMySQLDALVisitor.java#L137) | 10 | 0% | | [shardingsphere-sql-parser/shardingsphere-sql-parser-postgresql/src/main/java/org/apache/shardingsphere/sql/parser/visitor/impl/PostgreSQLDMLVisitor.java](https://coveralls.io/builds/28797403/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-postgresql%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fvisitor%2Fimpl%2FPostgreSQLDMLVisitor.java#L281) | 44 | 0% | | [shardingsphere-sql-parser/shardingsphere-sql-parser-mysql/src/main/java/org/apache/shardingsphere/sql/parser/visitor/impl/MySQLDMLVisitor.java](https://coveralls.io/builds/28797403/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-mysql%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fvisitor%2Fimpl%2FMySQLDMLVisitor.java#L314) | 46 | 0% | | Totals | [](https://coveralls.io/builds/28797403) | | :-- | --: | | Change from base [Build 875](https://coveralls.io/builds/28793443): | -0.02% | | Covered Lines: | 11088 | | Relevant Lines: | 19245 | --- # 💛 - [Coveralls](https://coveralls.io) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] coveralls edited a comment on issue #4353: #4255, use CAPI in stmt mode return incorrect response
coveralls edited a comment on issue #4353: #4255, use CAPI in stmt mode return incorrect response URL: https://github.com/apache/incubator-shardingsphere/pull/4353#issuecomment-587393669 ## Pull Request Test Coverage Report for [Build 9634](https://coveralls.io/builds/28797369) * **6** of **7** **(85.71%)** changed or added relevant lines in **2** files are covered. * **112** unchanged lines in **7** files lost coverage. * Overall coverage decreased (**-0.02%**) to **57.61%** --- | Changes Missing Coverage | Covered Lines | Changed/Added Lines | % | | :-|--||---: | | [sharding-proxy/sharding-proxy-frontend/sharding-proxy-frontend-mysql/src/main/java/org/apache/shardingsphere/shardingproxy/frontend/mysql/command/query/binary/prepare/MySQLComStmtPrepareExecutor.java](https://coveralls.io/builds/28797369/source?filename=sharding-proxy%2Fsharding-proxy-frontend%2Fsharding-proxy-frontend-mysql%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingproxy%2Ffrontend%2Fmysql%2Fcommand%2Fquery%2Fbinary%2Fprepare%2FMySQLComStmtPrepareExecutor.java#L60) | 0 | 1 | 0.0% | Files with Coverage Reduction | New Missed Lines | % | | :-|--|--: | | [sharding-proxy/sharding-proxy-frontend/sharding-proxy-frontend-mysql/src/main/java/org/apache/shardingsphere/shardingproxy/frontend/mysql/command/query/binary/prepare/MySQLComStmtPrepareExecutor.java](https://coveralls.io/builds/28797369/source?filename=sharding-proxy%2Fsharding-proxy-frontend%2Fsharding-proxy-frontend-mysql%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingproxy%2Ffrontend%2Fmysql%2Fcommand%2Fquery%2Fbinary%2Fprepare%2FMySQLComStmtPrepareExecutor.java#L46) | 2 | 0% | | [shardingsphere-sql-parser/shardingsphere-sql-parser-engine/src/main/java/org/apache/shardingsphere/sql/parser/sql/statement/dal/dialect/mysql/ShowIndexStatement.java](https://coveralls.io/builds/28797369/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-engine%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fsql%2Fstatement%2Fdal%2Fdialect%2Fmysql%2FShowIndexStatement.java#L33) | 2 | 0% | | [sharding-orchestration/sharding-orchestration-core/src/main/java/org/apache/shardingsphere/orchestration/internal/util/IpUtils.java](https://coveralls.io/builds/28797369/source?filename=sharding-orchestration%2Fsharding-orchestration-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Forchestration%2Finternal%2Futil%2FIpUtils.java#L63) | 3 | 76.0% | | [shardingsphere-sql-parser/shardingsphere-sql-parser-engine/src/main/java/org/apache/shardingsphere/sql/parser/sql/statement/dml/SelectStatement.java](https://coveralls.io/builds/28797369/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-engine%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fsql%2Fstatement%2Fdml%2FSelectStatement.java#L61) | 5 | 28.57% | | [shardingsphere-sql-parser/shardingsphere-sql-parser-mysql/src/main/java/org/apache/shardingsphere/sql/parser/visitor/impl/MySQLDALVisitor.java](https://coveralls.io/builds/28797369/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-mysql%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fvisitor%2Fimpl%2FMySQLDALVisitor.java#L137) | 10 | 0% | | [shardingsphere-sql-parser/shardingsphere-sql-parser-postgresql/src/main/java/org/apache/shardingsphere/sql/parser/visitor/impl/PostgreSQLDMLVisitor.java](https://coveralls.io/builds/28797369/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-postgresql%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fvisitor%2Fimpl%2FPostgreSQLDMLVisitor.java#L281) | 44 | 0% | | [shardingsphere-sql-parser/shardingsphere-sql-parser-mysql/src/main/java/org/apache/shardingsphere/sql/parser/visitor/impl/MySQLDMLVisitor.java](https://coveralls.io/builds/28797369/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-mysql%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fvisitor%2Fimpl%2FMySQLDMLVisitor.java#L314) | 46 | 0% | | Totals | [](https://coveralls.io/builds/28797369) | | :-- | --: | | Change from base [Build 875](https://coveralls.io/builds/28793443): | -0.02% | | Covered Lines: | 11087 | | Relevant Lines: | 19245 | --- # 💛 - [Coveralls](https://coveralls.io) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] sluk3r opened a new pull request #4359: for issue 4357
sluk3r opened a new pull request #4359: for issue 4357 URL: https://github.com/apache/incubator-shardingsphere/pull/4359 Fixes #4357 Changes proposed in this pull request: - delete the unused line: when(insertStatement.findSQLSegment(LimitSegment.class)).thenReturn(Optional.of(new LimitSegment(0, 10, null, null))); - for InsertStatement object, use "new InsertStatement()" instead of "mock(InsertStatement.class)", and other mocked methods setup are also deleted. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] coveralls edited a comment on issue #4337: Refactor sharding parser with Antlr visitor parser
coveralls edited a comment on issue #4337: Refactor sharding parser with Antlr visitor parser URL: https://github.com/apache/incubator-shardingsphere/pull/4337#issuecomment-587408455 ## Pull Request Test Coverage Report for [Build 9633](https://coveralls.io/builds/28796824) * **4** of **50** **(8.0%)** changed or added relevant lines in **16** files are covered. * **139** unchanged lines in **12** files lost coverage. * Overall coverage decreased (**-0.3%**) to **57.331%** --- | Changes Missing Coverage | Covered Lines | Changed/Added Lines | % | | :-|--||---: | | [shardingsphere-sql-parser/shardingsphere-sql-parser-engine/src/main/java/org/apache/shardingsphere/sql/parser/core/SQLParseKernel.java](https://coveralls.io/builds/28796824/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-engine%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fcore%2FSQLParseKernel.java#L49) | 0 | 1 | 0.0% | [shardingsphere-sql-parser/shardingsphere-sql-parser-sqlserver/src/main/java/org/apache/shardingsphere/sql/parser/visitor/impl/SQLServerTCLVisitor.java](https://coveralls.io/builds/28796824/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-sqlserver%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fvisitor%2Fimpl%2FSQLServerTCLVisitor.java#L54) | 0 | 1 | 0.0% | [shardingsphere-sql-parser/shardingsphere-sql-parser-engine/src/main/java/org/apache/shardingsphere/sql/parser/core/parser/SQLParserFactory.java](https://coveralls.io/builds/28796824/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-engine%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fcore%2Fparser%2FSQLParserFactory.java#L39) | 0 | 2 | 0.0% | [shardingsphere-sql-parser/shardingsphere-sql-parser-mysql/src/main/java/org/apache/shardingsphere/sql/parser/visitor/MySQLVisitor.java](https://coveralls.io/builds/28796824/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-mysql%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fvisitor%2FMySQLVisitor.java#L355) | 0 | 2 | 0.0% | [shardingsphere-sql-parser/shardingsphere-sql-parser-oracle/src/main/java/org/apache/shardingsphere/sql/parser/visitor/OracleVisitor.java](https://coveralls.io/builds/28796824/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-oracle%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fvisitor%2FOracleVisitor.java#L336) | 0 | 2 | 0.0% | [shardingsphere-sql-parser/shardingsphere-sql-parser-oracle/src/main/java/org/apache/shardingsphere/sql/parser/visitor/impl/OracleDMLVisitor.java](https://coveralls.io/builds/28796824/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-oracle%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fvisitor%2Fimpl%2FOracleDMLVisitor.java#L344) | 0 | 2 | 0.0% | [shardingsphere-sql-parser/shardingsphere-sql-parser-postgresql/src/main/java/org/apache/shardingsphere/sql/parser/visitor/PostgreSQLVisitor.java](https://coveralls.io/builds/28796824/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-postgresql%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fvisitor%2FPostgreSQLVisitor.java#L338) | 0 | 2 | 0.0% | [shardingsphere-sql-parser/shardingsphere-sql-parser-postgresql/src/main/java/org/apache/shardingsphere/sql/parser/visitor/impl/PostgreSQLDMLVisitor.java](https://coveralls.io/builds/28796824/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-postgresql%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fvisitor%2Fimpl%2FPostgreSQLDMLVisitor.java#L353) | 0 | 2 | 0.0% | [shardingsphere-sql-parser/shardingsphere-sql-parser-sql92/src/main/java/org/apache/shardingsphere/sql/parser/visitor/SQL92Visitor.java](https://coveralls.io/builds/28796824/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-sql92%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fvisitor%2FSQL92Visitor.java#L327) | 0 | 2 | 0.0% | [shardingsphere-sql-parser/shardingsphere-sql-parser-sql92/src/main/java/org/apache/shardingsphere/sql/parser/visitor/impl/SQL92DMLVisitor.java](https://coveralls.io/builds/28796824/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-sql92%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fvisitor%2Fimpl%2FSQL92DMLVisitor.java#L314) | 0 | 2 | 0.0% | Files with Coverage Reduction | New Missed Lines | % | | :-|--|--: | | [sharding-proxy/sharding-proxy-backend/src/main/java/org/apache/shardingsphere/shardingproxy/backend/text/TextProtocolBackendHandlerFactory.java](https://coveralls.io/builds/28796824/source?filename=sharding-proxy%2Fsharding-proxy-backend%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingproxy%2Fbackend%2Ftext%2FTextProtocolBackendHandl
[GitHub] [incubator-shardingsphere] ancientelves commented on issue #4341: shardingsphere 4.0.0 retrive very slow that sql script
ancientelves commented on issue #4341: shardingsphere 4.0.0 retrive very slow that sql script URL: https://github.com/apache/incubator-shardingsphere/issues/4341#issuecomment-587434692 @kimmking Thanks for your suggestion.Then I will check my program and table again. BTW,don't modify this parameter to a higher value in your production env,if I set the param to 8 as your above,is it ok? or I should do a lower setup? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] tuohai666 opened a new issue #4358: Different MySQLColumnDefinition41Packet values for parameters between MySQL Connector/J and MySQL C API
tuohai666 opened a new issue #4358: Different MySQLColumnDefinition41Packet values for parameters between MySQL Connector/J and MySQL C API URL: https://github.com/apache/incubator-shardingsphere/issues/4358 Parameter type of char in MySQLColumnDefinition41Packet handled differently between MySQL Connector/J and MySQL C API. Connector/J accepts MYSQL_TYPE_VARCHAR, MYSQL_TYPE_VAR_STRING and MYSQL_TYPE_STRING. While C API checks strictly and only accept MYSQL_TYPE_VAR_STRING and MYSQL_TYPE_STRING, because column type will be stored in struct MYSQL_STMT (fields.type) but MYSQL_TYPE_VARCHAR is not allowed to bind result. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] codecov-io commented on issue #4337: Refactor sharding parser with Antlr visitor parser
codecov-io commented on issue #4337: Refactor sharding parser with Antlr visitor parser URL: https://github.com/apache/incubator-shardingsphere/pull/4337#issuecomment-587433147 # [Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4337?src=pr&el=h1) Report > :exclamation: No coverage uploaded for pull request base (`master@3e67055`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit). > The diff coverage is `39.32%`. [](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4337?src=pr&el=tree) ```diff @@Coverage Diff@@ ## master#4337 +/- ## = Coverage ? 53.87% Complexity? 351 = Files ? 1047 Lines ?19295 Branches ? 3551 = Hits ?10395 Misses? 8243 Partials ? 657 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4337?src=pr&el=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [.../sql/parser/visitor/impl/PostgreSQLDMLVisitor.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4337/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLXBvc3RncmVzcWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NxbC9wYXJzZXIvdmlzaXRvci9pbXBsL1Bvc3RncmVTUUxETUxWaXNpdG9yLmphdmE=) | `0% <0%> (ø)` | `0 <0> (?)` | | | [...shardingsphere/sql/parser/core/SQLParseKernel.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4337/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLWVuZ2luZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc3FsL3BhcnNlci9jb3JlL1NRTFBhcnNlS2VybmVsLmphdmE=) | `0% <0%> (ø)` | `0 <0> (?)` | | | [.../orchestration/center/instance/ApolloInstance.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4337/diff?src=pr&el=tree#diff-c2hhcmRpbmctb3JjaGVzdHJhdGlvbi9zaGFyZGluZy1vcmNoZXN0cmF0aW9uLWNlbnRlci9zaGFyZGluZy1vcmNoZXN0cmF0aW9uLWNlbnRlci1hcG9sbG8vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL29yY2hlc3RyYXRpb24vY2VudGVyL2luc3RhbmNlL0Fwb2xsb0luc3RhbmNlLmphdmE=) | `54.05% <0%> (ø)` | `0 <0> (?)` | | | [...mpl/dml/insert/OnDuplicateKeyColumnsExtractor.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4337/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLWVuZ2luZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc3FsL3BhcnNlci9jb3JlL2V4dHJhY3Rvci9pbXBsL2RtbC9pbnNlcnQvT25EdXBsaWNhdGVLZXlDb2x1bW5zRXh0cmFjdG9yLmphdmE=) | `16.66% <0%> (ø)` | `0 <0> (?)` | | | [...nerator/impl/RemoveShadowColumnTokenGenerator.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4337/diff?src=pr&el=tree#diff-c2hhZG93LWNvcmUvc2hhZG93LWNvcmUtcmV3cml0ZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc2hhZG93L3Jld3JpdGUvdG9rZW4vZ2VuZXJhdG9yL2ltcGwvUmVtb3ZlU2hhZG93Q29sdW1uVG9rZW5HZW5lcmF0b3IuamF2YQ==) | `0% <0%> (ø)` | `0 <0> (?)` | | | [...phere/sql/parser/visitor/impl/MySQLDMLVisitor.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4337/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLW15c3FsL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9zcWwvcGFyc2VyL3Zpc2l0b3IvaW1wbC9NeVNRTERNTFZpc2l0b3IuamF2YQ==) | `0% <0%> (ø)` | `0 <0> (?)` | | | [...l/parser/core/rule/registry/ParseRuleRegistry.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4337/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLWVuZ2luZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc3FsL3BhcnNlci9jb3JlL3J1bGUvcmVnaXN0cnkvUGFyc2VSdWxlUmVnaXN0cnkuamF2YQ==) | `0% <0%> (ø)` | `0 <0> (?)` | | | [...sphere/sql/parser/core/parser/SQLParserEngine.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4337/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLWVuZ2luZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc3FsL3BhcnNlci9jb3JlL3BhcnNlci9TUUxQYXJzZXJFbmdpbmUuamF2YQ==) | `0% <0%> (ø)` | `0 <0> (?)` | | | [...e/sql/parser/visitor/impl/SQLServerTCLVisitor.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4337/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLXNxbHNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc3FsL3BhcnNlci92aXNpdG9yL2ltcGwvU
[GitHub] [incubator-shardingsphere] coveralls edited a comment on issue #4337: Refactor sharding parser with Antlr visitor parser
coveralls edited a comment on issue #4337: Refactor sharding parser with Antlr visitor parser URL: https://github.com/apache/incubator-shardingsphere/pull/4337#issuecomment-587408455 ## Pull Request Test Coverage Report for [Build 1799](https://coveralls.io/builds/28796336) * **4** of **50** **(8.0%)** changed or added relevant lines in **16** files are covered. * **136** unchanged lines in **11** files lost coverage. * Overall coverage decreased (**-0.3%**) to **57.336%** --- | Changes Missing Coverage | Covered Lines | Changed/Added Lines | % | | :-|--||---: | | [shardingsphere-sql-parser/shardingsphere-sql-parser-engine/src/main/java/org/apache/shardingsphere/sql/parser/core/SQLParseKernel.java](https://coveralls.io/builds/28796336/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-engine%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fcore%2FSQLParseKernel.java#L49) | 0 | 1 | 0.0% | [shardingsphere-sql-parser/shardingsphere-sql-parser-sqlserver/src/main/java/org/apache/shardingsphere/sql/parser/visitor/impl/SQLServerTCLVisitor.java](https://coveralls.io/builds/28796336/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-sqlserver%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fvisitor%2Fimpl%2FSQLServerTCLVisitor.java#L54) | 0 | 1 | 0.0% | [shardingsphere-sql-parser/shardingsphere-sql-parser-engine/src/main/java/org/apache/shardingsphere/sql/parser/core/parser/SQLParserFactory.java](https://coveralls.io/builds/28796336/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-engine%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fcore%2Fparser%2FSQLParserFactory.java#L39) | 0 | 2 | 0.0% | [shardingsphere-sql-parser/shardingsphere-sql-parser-mysql/src/main/java/org/apache/shardingsphere/sql/parser/visitor/MySQLVisitor.java](https://coveralls.io/builds/28796336/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-mysql%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fvisitor%2FMySQLVisitor.java#L355) | 0 | 2 | 0.0% | [shardingsphere-sql-parser/shardingsphere-sql-parser-oracle/src/main/java/org/apache/shardingsphere/sql/parser/visitor/OracleVisitor.java](https://coveralls.io/builds/28796336/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-oracle%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fvisitor%2FOracleVisitor.java#L336) | 0 | 2 | 0.0% | [shardingsphere-sql-parser/shardingsphere-sql-parser-oracle/src/main/java/org/apache/shardingsphere/sql/parser/visitor/impl/OracleDMLVisitor.java](https://coveralls.io/builds/28796336/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-oracle%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fvisitor%2Fimpl%2FOracleDMLVisitor.java#L344) | 0 | 2 | 0.0% | [shardingsphere-sql-parser/shardingsphere-sql-parser-postgresql/src/main/java/org/apache/shardingsphere/sql/parser/visitor/PostgreSQLVisitor.java](https://coveralls.io/builds/28796336/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-postgresql%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fvisitor%2FPostgreSQLVisitor.java#L338) | 0 | 2 | 0.0% | [shardingsphere-sql-parser/shardingsphere-sql-parser-postgresql/src/main/java/org/apache/shardingsphere/sql/parser/visitor/impl/PostgreSQLDMLVisitor.java](https://coveralls.io/builds/28796336/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-postgresql%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fvisitor%2Fimpl%2FPostgreSQLDMLVisitor.java#L353) | 0 | 2 | 0.0% | [shardingsphere-sql-parser/shardingsphere-sql-parser-sql92/src/main/java/org/apache/shardingsphere/sql/parser/visitor/SQL92Visitor.java](https://coveralls.io/builds/28796336/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-sql92%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fvisitor%2FSQL92Visitor.java#L327) | 0 | 2 | 0.0% | [shardingsphere-sql-parser/shardingsphere-sql-parser-sql92/src/main/java/org/apache/shardingsphere/sql/parser/visitor/impl/SQL92DMLVisitor.java](https://coveralls.io/builds/28796336/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-sql92%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fvisitor%2Fimpl%2FSQL92DMLVisitor.java#L314) | 0 | 2 | 0.0% | Files with Coverage Reduction | New Missed Lines | % | | :-|--|--: | | [sharding-proxy/sharding-proxy-backend/src/main/java/org/apache/shardingsphere/shardingproxy/backend/text/TextProtocolBackendHandlerFactory.java](https://coveralls.io/builds/28796336/source?filename=sharding-proxy%2Fsharding-proxy-backend%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingproxy%2Fbackend%2Ftext%2FTextProtocolBackendHandl
[GitHub] [incubator-shardingsphere] sluk3r opened a new issue #4357: LimitSegment not suitable for InsertStatement in SQLStatementContextFactoryTest
sluk3r opened a new issue #4357: LimitSegment not suitable for InsertStatement in SQLStatementContextFactoryTest URL: https://github.com/apache/incubator-shardingsphere/issues/4357 For method of InsertStatement#findSQLSegment， it is not suitable to apply LimitSegment. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] coveralls edited a comment on issue #4337: Refactor sharding parser with Antlr visitor parser
coveralls edited a comment on issue #4337: Refactor sharding parser with Antlr visitor parser URL: https://github.com/apache/incubator-shardingsphere/pull/4337#issuecomment-587408455 ## Pull Request Test Coverage Report for [Build 1798](https://coveralls.io/builds/28795961) * **4** of **50** **(8.0%)** changed or added relevant lines in **16** files are covered. * **41** unchanged lines in **8** files lost coverage. * Overall coverage decreased (**-0.3%**) to **57.358%** --- | Changes Missing Coverage | Covered Lines | Changed/Added Lines | % | | :-|--||---: | | [shardingsphere-sql-parser/shardingsphere-sql-parser-engine/src/main/java/org/apache/shardingsphere/sql/parser/core/SQLParseKernel.java](https://coveralls.io/builds/28795961/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-engine%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fcore%2FSQLParseKernel.java#L49) | 0 | 1 | 0.0% | [shardingsphere-sql-parser/shardingsphere-sql-parser-sqlserver/src/main/java/org/apache/shardingsphere/sql/parser/visitor/impl/SQLServerTCLVisitor.java](https://coveralls.io/builds/28795961/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-sqlserver%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fvisitor%2Fimpl%2FSQLServerTCLVisitor.java#L54) | 0 | 1 | 0.0% | [shardingsphere-sql-parser/shardingsphere-sql-parser-engine/src/main/java/org/apache/shardingsphere/sql/parser/core/parser/SQLParserFactory.java](https://coveralls.io/builds/28795961/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-engine%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fcore%2Fparser%2FSQLParserFactory.java#L39) | 0 | 2 | 0.0% | [shardingsphere-sql-parser/shardingsphere-sql-parser-mysql/src/main/java/org/apache/shardingsphere/sql/parser/visitor/MySQLVisitor.java](https://coveralls.io/builds/28795961/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-mysql%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fvisitor%2FMySQLVisitor.java#L355) | 0 | 2 | 0.0% | [shardingsphere-sql-parser/shardingsphere-sql-parser-oracle/src/main/java/org/apache/shardingsphere/sql/parser/visitor/OracleVisitor.java](https://coveralls.io/builds/28795961/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-oracle%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fvisitor%2FOracleVisitor.java#L336) | 0 | 2 | 0.0% | [shardingsphere-sql-parser/shardingsphere-sql-parser-oracle/src/main/java/org/apache/shardingsphere/sql/parser/visitor/impl/OracleDMLVisitor.java](https://coveralls.io/builds/28795961/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-oracle%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fvisitor%2Fimpl%2FOracleDMLVisitor.java#L344) | 0 | 2 | 0.0% | [shardingsphere-sql-parser/shardingsphere-sql-parser-postgresql/src/main/java/org/apache/shardingsphere/sql/parser/visitor/PostgreSQLVisitor.java](https://coveralls.io/builds/28795961/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-postgresql%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fvisitor%2FPostgreSQLVisitor.java#L338) | 0 | 2 | 0.0% | [shardingsphere-sql-parser/shardingsphere-sql-parser-postgresql/src/main/java/org/apache/shardingsphere/sql/parser/visitor/impl/PostgreSQLDMLVisitor.java](https://coveralls.io/builds/28795961/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-postgresql%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fvisitor%2Fimpl%2FPostgreSQLDMLVisitor.java#L353) | 0 | 2 | 0.0% | [shardingsphere-sql-parser/shardingsphere-sql-parser-sql92/src/main/java/org/apache/shardingsphere/sql/parser/visitor/SQL92Visitor.java](https://coveralls.io/builds/28795961/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-sql92%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fvisitor%2FSQL92Visitor.java#L327) | 0 | 2 | 0.0% | [shardingsphere-sql-parser/shardingsphere-sql-parser-sql92/src/main/java/org/apache/shardingsphere/sql/parser/visitor/impl/SQL92DMLVisitor.java](https://coveralls.io/builds/28795961/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-sql92%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fvisitor%2Fimpl%2FSQL92DMLVisitor.java#L314) | 0 | 2 | 0.0% | Files with Coverage Reduction | New Missed Lines | % | | :-|--|--: | | [sharding-proxy/sharding-proxy-backend/src/main/java/org/apache/shardingsphere/shardingproxy/backend/text/TextProtocolBackendHandlerFactory.java](https://coveralls.io/builds/28795961/source?filename=sharding-proxy%2Fsharding-proxy-backend%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingproxy%2Fbackend%2Ftext%2FTextProtocolBackendHandler
[GitHub] [incubator-shardingsphere] coveralls commented on issue #4356: decouple find LimitSegment with select statement
coveralls commented on issue #4356: decouple find LimitSegment with select statement URL: https://github.com/apache/incubator-shardingsphere/pull/4356#issuecomment-587420765 ## Pull Request Test Coverage Report for [Build 1797](https://coveralls.io/builds/28795922) * **2** of **14** **(14.29%)** changed or added relevant lines in **6** files are covered. * **2** unchanged lines in **1** file lost coverage. * Overall coverage decreased (**-0.01%**) to **57.611%** --- | Changes Missing Coverage | Covered Lines | Changed/Added Lines | % | | :-|--||---: | | [shardingsphere-sql-parser/shardingsphere-sql-parser-engine/src/main/java/org/apache/shardingsphere/sql/parser/core/filler/impl/dml/LockFiller.java](https://coveralls.io/builds/28795922/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-engine%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fcore%2Ffiller%2Fimpl%2Fdml%2FLockFiller.java#L32) | 0 | 1 | 0.0% | [shardingsphere-sql-parser/shardingsphere-sql-parser-engine/src/main/java/org/apache/shardingsphere/sql/parser/sql/statement/dml/SelectStatement.java](https://coveralls.io/builds/28795922/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-engine%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fsql%2Fstatement%2Fdml%2FSelectStatement.java#L88) | 0 | 2 | 0.0% | [shardingsphere-sql-parser/shardingsphere-sql-parser-engine/src/main/java/org/apache/shardingsphere/sql/parser/core/filler/impl/dml/LimitFiller.java](https://coveralls.io/builds/28795922/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-engine%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fcore%2Ffiller%2Fimpl%2Fdml%2FLimitFiller.java#L32) | 1 | 4 | 25.0% | [shardingsphere-sql-parser/shardingsphere-sql-parser-mysql/src/main/java/org/apache/shardingsphere/sql/parser/visitor/impl/MySQLDMLVisitor.java](https://coveralls.io/builds/28795922/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-mysql%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fvisitor%2Fimpl%2FMySQLDMLVisitor.java#L313) | 0 | 3 | 0.0% | [shardingsphere-sql-parser/shardingsphere-sql-parser-postgresql/src/main/java/org/apache/shardingsphere/sql/parser/visitor/impl/PostgreSQLDMLVisitor.java](https://coveralls.io/builds/28795922/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-postgresql%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fvisitor%2Fimpl%2FPostgreSQLDMLVisitor.java#L280) | 0 | 3 | 0.0% | Files with Coverage Reduction | New Missed Lines | % | | :-|--|--: | | [sharding-orchestration/sharding-orchestration-core/src/main/java/org/apache/shardingsphere/orchestration/internal/util/IpUtils.java](https://coveralls.io/builds/28795922/source?filename=sharding-orchestration%2Fsharding-orchestration-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Forchestration%2Finternal%2Futil%2FIpUtils.java#L72) | 2 | 80.0% | | Totals | [](https://coveralls.io/builds/28795922) | | :-- | --: | | Change from base [Build 9624](https://coveralls.io/builds/28795366): | -0.01% | | Covered Lines: | 11089 | | Relevant Lines: | 19248 | --- # 💛 - [Coveralls](https://coveralls.io) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] coveralls edited a comment on issue #4353: #4255, use CAPI in stmt mode return incorrect response
coveralls edited a comment on issue #4353: #4255, use CAPI in stmt mode return incorrect response URL: https://github.com/apache/incubator-shardingsphere/pull/4353#issuecomment-587393669 ## Pull Request Test Coverage Report for [Build 9628](https://coveralls.io/builds/28795809) * **6** of **7** **(85.71%)** changed or added relevant lines in **2** files are covered. * **17** unchanged lines in **4** files lost coverage. * Overall coverage decreased (**-0.002%**) to **57.632%** --- | Changes Missing Coverage | Covered Lines | Changed/Added Lines | % | | :-|--||---: | | [sharding-proxy/sharding-proxy-frontend/sharding-proxy-frontend-mysql/src/main/java/org/apache/shardingsphere/shardingproxy/frontend/mysql/command/query/binary/prepare/MySQLComStmtPrepareExecutor.java](https://coveralls.io/builds/28795809/source?filename=sharding-proxy%2Fsharding-proxy-frontend%2Fsharding-proxy-frontend-mysql%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingproxy%2Ffrontend%2Fmysql%2Fcommand%2Fquery%2Fbinary%2Fprepare%2FMySQLComStmtPrepareExecutor.java#L60) | 0 | 1 | 0.0% | Files with Coverage Reduction | New Missed Lines | % | | :-|--|--: | | [sharding-proxy/sharding-proxy-frontend/sharding-proxy-frontend-mysql/src/main/java/org/apache/shardingsphere/shardingproxy/frontend/mysql/command/query/binary/prepare/MySQLComStmtPrepareExecutor.java](https://coveralls.io/builds/28795809/source?filename=sharding-proxy%2Fsharding-proxy-frontend%2Fsharding-proxy-frontend-mysql%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingproxy%2Ffrontend%2Fmysql%2Fcommand%2Fquery%2Fbinary%2Fprepare%2FMySQLComStmtPrepareExecutor.java#L46) | 2 | 0% | | [shardingsphere-sql-parser/shardingsphere-sql-parser-engine/src/main/java/org/apache/shardingsphere/sql/parser/sql/statement/dal/dialect/mysql/ShowIndexStatement.java](https://coveralls.io/builds/28795809/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-engine%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fsql%2Fstatement%2Fdal%2Fdialect%2Fmysql%2FShowIndexStatement.java#L33) | 2 | 0% | | [sharding-orchestration/sharding-orchestration-core/src/main/java/org/apache/shardingsphere/orchestration/internal/util/IpUtils.java](https://coveralls.io/builds/28795809/source?filename=sharding-orchestration%2Fsharding-orchestration-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Forchestration%2Finternal%2Futil%2FIpUtils.java#L63) | 3 | 76.0% | | [shardingsphere-sql-parser/shardingsphere-sql-parser-mysql/src/main/java/org/apache/shardingsphere/sql/parser/visitor/impl/MySQLDALVisitor.java](https://coveralls.io/builds/28795809/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-mysql%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fvisitor%2Fimpl%2FMySQLDALVisitor.java#L137) | 10 | 0% | | Totals | [](https://coveralls.io/builds/28795809) | | :-- | --: | | Change from base [Build 875](https://coveralls.io/builds/28793443): | -0.002% | | Covered Lines: | 11086 | | Relevant Lines: | 19236 | --- # 💛 - [Coveralls](https://coveralls.io) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] coveralls edited a comment on issue #4353: #4255, use CAPI in stmt mode return incorrect response
coveralls edited a comment on issue #4353: #4255, use CAPI in stmt mode return incorrect response URL: https://github.com/apache/incubator-shardingsphere/pull/4353#issuecomment-587393669 ## Pull Request Test Coverage Report for [Build 1795](https://coveralls.io/builds/28795632) * **6** of **7** **(85.71%)** changed or added relevant lines in **2** files are covered. * **14** unchanged lines in **3** files lost coverage. * Overall coverage increased (+**0.003%**) to **57.637%** --- | Changes Missing Coverage | Covered Lines | Changed/Added Lines | % | | :-|--||---: | | [sharding-proxy/sharding-proxy-frontend/sharding-proxy-frontend-mysql/src/main/java/org/apache/shardingsphere/shardingproxy/frontend/mysql/command/query/binary/prepare/MySQLComStmtPrepareExecutor.java](https://coveralls.io/builds/28795632/source?filename=sharding-proxy%2Fsharding-proxy-frontend%2Fsharding-proxy-frontend-mysql%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingproxy%2Ffrontend%2Fmysql%2Fcommand%2Fquery%2Fbinary%2Fprepare%2FMySQLComStmtPrepareExecutor.java#L60) | 0 | 1 | 0.0% | Files with Coverage Reduction | New Missed Lines | % | | :-|--|--: | | [sharding-proxy/sharding-proxy-frontend/sharding-proxy-frontend-mysql/src/main/java/org/apache/shardingsphere/shardingproxy/frontend/mysql/command/query/binary/prepare/MySQLComStmtPrepareExecutor.java](https://coveralls.io/builds/28795632/source?filename=sharding-proxy%2Fsharding-proxy-frontend%2Fsharding-proxy-frontend-mysql%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingproxy%2Ffrontend%2Fmysql%2Fcommand%2Fquery%2Fbinary%2Fprepare%2FMySQLComStmtPrepareExecutor.java#L46) | 2 | 0% | | [shardingsphere-sql-parser/shardingsphere-sql-parser-engine/src/main/java/org/apache/shardingsphere/sql/parser/sql/statement/dal/dialect/mysql/ShowIndexStatement.java](https://coveralls.io/builds/28795632/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-engine%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fsql%2Fstatement%2Fdal%2Fdialect%2Fmysql%2FShowIndexStatement.java#L33) | 2 | 0% | | [shardingsphere-sql-parser/shardingsphere-sql-parser-mysql/src/main/java/org/apache/shardingsphere/sql/parser/visitor/impl/MySQLDALVisitor.java](https://coveralls.io/builds/28795632/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-mysql%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fvisitor%2Fimpl%2FMySQLDALVisitor.java#L137) | 10 | 0% | | Totals | [](https://coveralls.io/builds/28795632) | | :-- | --: | | Change from base [Build 875](https://coveralls.io/builds/28793443): | 0.003% | | Covered Lines: | 11087 | | Relevant Lines: | 19236 | --- # 💛 - [Coveralls](https://coveralls.io) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] coveralls edited a comment on issue #4353: #4255, use CAPI in stmt mode return incorrect response
coveralls edited a comment on issue #4353: #4255, use CAPI in stmt mode return incorrect response URL: https://github.com/apache/incubator-shardingsphere/pull/4353#issuecomment-587393669 ## Pull Request Test Coverage Report for [Build 1794](https://coveralls.io/builds/28795440) * **6** of **7** **(85.71%)** changed or added relevant lines in **2** files are covered. * **14** unchanged lines in **3** files lost coverage. * Overall coverage increased (+**0.003%**) to **57.637%** --- | Changes Missing Coverage | Covered Lines | Changed/Added Lines | % | | :-|--||---: | | [sharding-proxy/sharding-proxy-frontend/sharding-proxy-frontend-mysql/src/main/java/org/apache/shardingsphere/shardingproxy/frontend/mysql/command/query/binary/prepare/MySQLComStmtPrepareExecutor.java](https://coveralls.io/builds/28795440/source?filename=sharding-proxy%2Fsharding-proxy-frontend%2Fsharding-proxy-frontend-mysql%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingproxy%2Ffrontend%2Fmysql%2Fcommand%2Fquery%2Fbinary%2Fprepare%2FMySQLComStmtPrepareExecutor.java#L60) | 0 | 1 | 0.0% | Files with Coverage Reduction | New Missed Lines | % | | :-|--|--: | | [sharding-proxy/sharding-proxy-frontend/sharding-proxy-frontend-mysql/src/main/java/org/apache/shardingsphere/shardingproxy/frontend/mysql/command/query/binary/prepare/MySQLComStmtPrepareExecutor.java](https://coveralls.io/builds/28795440/source?filename=sharding-proxy%2Fsharding-proxy-frontend%2Fsharding-proxy-frontend-mysql%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingproxy%2Ffrontend%2Fmysql%2Fcommand%2Fquery%2Fbinary%2Fprepare%2FMySQLComStmtPrepareExecutor.java#L46) | 2 | 0% | | [shardingsphere-sql-parser/shardingsphere-sql-parser-engine/src/main/java/org/apache/shardingsphere/sql/parser/sql/statement/dal/dialect/mysql/ShowIndexStatement.java](https://coveralls.io/builds/28795440/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-engine%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fsql%2Fstatement%2Fdal%2Fdialect%2Fmysql%2FShowIndexStatement.java#L33) | 2 | 0% | | [shardingsphere-sql-parser/shardingsphere-sql-parser-mysql/src/main/java/org/apache/shardingsphere/sql/parser/visitor/impl/MySQLDALVisitor.java](https://coveralls.io/builds/28795440/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-mysql%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fvisitor%2Fimpl%2FMySQLDALVisitor.java#L137) | 10 | 0% | | Totals | [](https://coveralls.io/builds/28795440) | | :-- | --: | | Change from base [Build 875](https://coveralls.io/builds/28793443): | 0.003% | | Covered Lines: | 11087 | | Relevant Lines: | 19236 | --- # 💛 - [Coveralls](https://coveralls.io) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] codecov-io commented on issue #4353: #4255, use CAPI in stmt mode return incorrect response
codecov-io commented on issue #4353: #4255, use CAPI in stmt mode return incorrect response URL: https://github.com/apache/incubator-shardingsphere/pull/4353#issuecomment-587416603 # [Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4353?src=pr&el=h1) Report > Merging [#4353](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4353?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-shardingsphere/commit/f26a0c22bc1265c4747ca77abc3969faaf44f751?src=pr&el=desc) will **increase** coverage by `<.01%`. > The diff coverage is `85.71%`. [](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4353?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master#4353 +/- ## + Coverage 54.16% 54.16% +<.01% Complexity 352 352 Files 1046 1046 Lines 1923719236 -1 Branches 3536 3535 -1 Hits 1041910419 + Misses 8161 8160 -1 Partials657 657 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4353?src=pr&el=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...ry/binary/prepare/MySQLComStmtPrepareExecutor.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4353/diff?src=pr&el=tree#diff-c2hhcmRpbmctcHJveHkvc2hhcmRpbmctcHJveHktZnJvbnRlbmQvc2hhcmRpbmctcHJveHktZnJvbnRlbmQtbXlzcWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NoYXJkaW5ncHJveHkvZnJvbnRlbmQvbXlzcWwvY29tbWFuZC9xdWVyeS9iaW5hcnkvcHJlcGFyZS9NeVNRTENvbVN0bXRQcmVwYXJlRXhlY3V0b3IuamF2YQ==) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: | | [...roxy/transport/mysql/constant/MySQLColumnType.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4353/diff?src=pr&el=tree#diff-c2hhcmRpbmctcHJveHkvc2hhcmRpbmctcHJveHktdHJhbnNwb3J0L3NoYXJkaW5nLXByb3h5LXRyYW5zcG9ydC1teXNxbC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc2hhcmRpbmdwcm94eS90cmFuc3BvcnQvbXlzcWwvY29uc3RhbnQvTXlTUUxDb2x1bW5UeXBlLmphdmE=) | `100% <100%> (ø)` | `0 <0> (ø)` | :arrow_down: | | [...phere/sql/parser/visitor/impl/MySQLDALVisitor.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4353/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLW15c3FsL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9zcWwvcGFyc2VyL3Zpc2l0b3IvaW1wbC9NeVNRTERBTFZpc2l0b3IuamF2YQ==) | `0% <0%> (ø)` | `0% <0%> (ø)` | :arrow_down: | | [...tatement/dal/dialect/mysql/ShowIndexStatement.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4353/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLWVuZ2luZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc3FsL3BhcnNlci9zcWwvc3RhdGVtZW50L2RhbC9kaWFsZWN0L215c3FsL1Nob3dJbmRleFN0YXRlbWVudC5qYXZh) | `0% <0%> (ø)` | `0% <0%> (ø)` | :arrow_down: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4353?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4353?src=pr&el=footer). Last update [f26a0c2...129495c](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4353?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] coveralls edited a comment on issue #4352: update performance test
coveralls edited a comment on issue #4352: update performance test URL: https://github.com/apache/incubator-shardingsphere/pull/4352#issuecomment-587385589 ## Pull Request Test Coverage Report for [Build 9619](https://coveralls.io/builds/28794808) * **0** of **0** changed or added relevant lines in **0** files are covered. * **15** unchanged lines in **3** files lost coverage. * Overall coverage decreased (**-0.01%**) to **57.623%** --- | Files with Coverage Reduction | New Missed Lines | % | | :-|--|--: | | [shardingsphere-sql-parser/shardingsphere-sql-parser-engine/src/main/java/org/apache/shardingsphere/sql/parser/sql/statement/dal/dialect/mysql/ShowIndexStatement.java](https://coveralls.io/builds/28794808/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-engine%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fsql%2Fstatement%2Fdal%2Fdialect%2Fmysql%2FShowIndexStatement.java#L33) | 2 | 0% | | [sharding-orchestration/sharding-orchestration-core/src/main/java/org/apache/shardingsphere/orchestration/internal/util/IpUtils.java](https://coveralls.io/builds/28794808/source?filename=sharding-orchestration%2Fsharding-orchestration-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Forchestration%2Finternal%2Futil%2FIpUtils.java#L63) | 3 | 76.0% | | [shardingsphere-sql-parser/shardingsphere-sql-parser-mysql/src/main/java/org/apache/shardingsphere/sql/parser/visitor/impl/MySQLDALVisitor.java](https://coveralls.io/builds/28794808/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-mysql%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fvisitor%2Fimpl%2FMySQLDALVisitor.java#L137) | 10 | 0% | | Totals | [](https://coveralls.io/builds/28794808) | | :-- | --: | | Change from base [Build 875](https://coveralls.io/builds/28793443): | -0.01% | | Covered Lines: | 11086 | | Relevant Lines: | 19239 | --- # 💛 - [Coveralls](https://coveralls.io) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] tristaZero merged pull request #4356: decouple find LimitSegment with select statement
tristaZero merged pull request #4356: decouple find LimitSegment with select statement URL: https://github.com/apache/incubator-shardingsphere/pull/4356 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] coveralls commented on issue #4354: decouple find SchemaSegment with show index statement
coveralls commented on issue #4354: decouple find SchemaSegment with show index statement URL: https://github.com/apache/incubator-shardingsphere/pull/4354#issuecomment-587409819 ## Pull Request Test Coverage Report for [Build 1790](https://coveralls.io/builds/28794565) * **0** of **2** **(0.0%)** changed or added relevant lines in **2** files are covered. * No unchanged relevant lines lost coverage. * Overall coverage decreased (**-0.006%**) to **57.628%** --- | Changes Missing Coverage | Covered Lines | Changed/Added Lines | % | | :-|--||---: | | [shardingsphere-sql-parser/shardingsphere-sql-parser-engine/src/main/java/org/apache/shardingsphere/sql/parser/sql/statement/dal/dialect/mysql/ShowIndexStatement.java](https://coveralls.io/builds/28794565/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-engine%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fsql%2Fstatement%2Fdal%2Fdialect%2Fmysql%2FShowIndexStatement.java#L45) | 0 | 1 | 0.0% | [shardingsphere-sql-parser/shardingsphere-sql-parser-mysql/src/main/java/org/apache/shardingsphere/sql/parser/visitor/impl/MySQLDALVisitor.java](https://coveralls.io/builds/28794565/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-mysql%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fvisitor%2Fimpl%2FMySQLDALVisitor.java#L137) | 0 | 1 | 0.0% | Totals | [](https://coveralls.io/builds/28794565) | | :-- | --: | | Change from base [Build 875](https://coveralls.io/builds/28793443): | -0.006% | | Covered Lines: | 11087 | | Relevant Lines: | 19239 | --- # 💛 - [Coveralls](https://coveralls.io) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu opened a new pull request #4356: decouple find LimitSegment with select statement
terrymanu opened a new pull request #4356: decouple find LimitSegment with select statement URL: https://github.com/apache/incubator-shardingsphere/pull/4356 For #4342. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] coveralls commented on issue #4337: Refactor sharding parser with Antlr visitor parser
coveralls commented on issue #4337: Refactor sharding parser with Antlr visitor parser URL: https://github.com/apache/incubator-shardingsphere/pull/4337#issuecomment-587408455 ## Pull Request Test Coverage Report for [Build 1792](https://coveralls.io/builds/28794499) * **4** of **50** **(8.0%)** changed or added relevant lines in **16** files are covered. * **187** unchanged lines in **17** files lost coverage. * Overall coverage decreased (**-1.03%**) to **56.601%** --- | Changes Missing Coverage | Covered Lines | Changed/Added Lines | % | | :-|--||---: | | [shardingsphere-sql-parser/shardingsphere-sql-parser-engine/src/main/java/org/apache/shardingsphere/sql/parser/core/SQLParseKernel.java](https://coveralls.io/builds/28794499/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-engine%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fcore%2FSQLParseKernel.java#L49) | 0 | 1 | 0.0% | [shardingsphere-sql-parser/shardingsphere-sql-parser-sqlserver/src/main/java/org/apache/shardingsphere/sql/parser/visitor/impl/SQLServerTCLVisitor.java](https://coveralls.io/builds/28794499/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-sqlserver%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fvisitor%2Fimpl%2FSQLServerTCLVisitor.java#L54) | 0 | 1 | 0.0% | [shardingsphere-sql-parser/shardingsphere-sql-parser-engine/src/main/java/org/apache/shardingsphere/sql/parser/core/parser/SQLParserFactory.java](https://coveralls.io/builds/28794499/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-engine%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fcore%2Fparser%2FSQLParserFactory.java#L39) | 0 | 2 | 0.0% | [shardingsphere-sql-parser/shardingsphere-sql-parser-mysql/src/main/java/org/apache/shardingsphere/sql/parser/visitor/MySQLVisitor.java](https://coveralls.io/builds/28794499/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-mysql%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fvisitor%2FMySQLVisitor.java#L355) | 0 | 2 | 0.0% | [shardingsphere-sql-parser/shardingsphere-sql-parser-oracle/src/main/java/org/apache/shardingsphere/sql/parser/visitor/OracleVisitor.java](https://coveralls.io/builds/28794499/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-oracle%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fvisitor%2FOracleVisitor.java#L336) | 0 | 2 | 0.0% | [shardingsphere-sql-parser/shardingsphere-sql-parser-oracle/src/main/java/org/apache/shardingsphere/sql/parser/visitor/impl/OracleDMLVisitor.java](https://coveralls.io/builds/28794499/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-oracle%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fvisitor%2Fimpl%2FOracleDMLVisitor.java#L344) | 0 | 2 | 0.0% | [shardingsphere-sql-parser/shardingsphere-sql-parser-postgresql/src/main/java/org/apache/shardingsphere/sql/parser/visitor/PostgreSQLVisitor.java](https://coveralls.io/builds/28794499/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-postgresql%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fvisitor%2FPostgreSQLVisitor.java#L338) | 0 | 2 | 0.0% | [shardingsphere-sql-parser/shardingsphere-sql-parser-postgresql/src/main/java/org/apache/shardingsphere/sql/parser/visitor/impl/PostgreSQLDMLVisitor.java](https://coveralls.io/builds/28794499/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-postgresql%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fvisitor%2Fimpl%2FPostgreSQLDMLVisitor.java#L353) | 0 | 2 | 0.0% | [shardingsphere-sql-parser/shardingsphere-sql-parser-sql92/src/main/java/org/apache/shardingsphere/sql/parser/visitor/SQL92Visitor.java](https://coveralls.io/builds/28794499/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-sql92%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fvisitor%2FSQL92Visitor.java#L327) | 0 | 2 | 0.0% | [shardingsphere-sql-parser/shardingsphere-sql-parser-sql92/src/main/java/org/apache/shardingsphere/sql/parser/visitor/impl/SQL92DMLVisitor.java](https://coveralls.io/builds/28794499/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-sql92%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fvisitor%2Fimpl%2FSQL92DMLVisitor.java#L314) | 0 | 2 | 0.0% | Files with Coverage Reduction | New Missed Lines | % | | :-|--|--: | | [sharding-core/sharding-core-rewrite/src/main/java/org/apache/shardingsphere/sharding/rewrite/token/generator/impl/TableTokenGenerator.java](https://coveralls.io/builds/28794499/source?filename=sharding-core%2Fsharding-core-rewrite%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsharding%2Frewrite%2Ftoken%2Fgenerator%2Fimpl%2FTableTokenGenerator.ja
[GitHub] [incubator-shardingsphere] tuohai666 opened a new issue #4355: Different ComStmtPrepare process between MySQL Connector/J and MySQL C API
tuohai666 opened a new issue #4355: Different ComStmtPrepare process between MySQL Connector/J and MySQL C API URL: https://github.com/apache/incubator-shardingsphere/issues/4355 Column type of char in response of ComStmtPrepare handled differently between MySQL Connector/J and MySQL C API. Connector/J accepts MYSQL_TYPE_VARCHAR, MYSQL_TYPE_VAR_STRING and MYSQL_TYPE_STRING. While C API checks strictly and only accept MYSQL_TYPE_VAR_STRING and MYSQL_TYPE_STRING, because column type will be stored in struct MYSQL_STMT (fields.type) but MYSQL_TYPE_VARCHAR is not allowed to bind result. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] coveralls commented on issue #4353: #4255, use CAPI in stmt mode return incorrect response
coveralls commented on issue #4353: #4255, use CAPI in stmt mode return incorrect response URL: https://github.com/apache/incubator-shardingsphere/pull/4353#issuecomment-587393669 ## Pull Request Test Coverage Report for [Build 1788](https://coveralls.io/builds/28794032) * **6** of **7** **(85.71%)** changed or added relevant lines in **2** files are covered. * **4** unchanged lines in **1** file lost coverage. * Overall coverage increased (+**0.008%**) to **57.642%** --- | Changes Missing Coverage | Covered Lines | Changed/Added Lines | % | | :-|--||---: | | [sharding-proxy/sharding-proxy-frontend/sharding-proxy-frontend-mysql/src/main/java/org/apache/shardingsphere/shardingproxy/frontend/mysql/command/query/binary/prepare/MySQLComStmtPrepareExecutor.java](https://coveralls.io/builds/28794032/source?filename=sharding-proxy%2Fsharding-proxy-frontend%2Fsharding-proxy-frontend-mysql%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingproxy%2Ffrontend%2Fmysql%2Fcommand%2Fquery%2Fbinary%2Fprepare%2FMySQLComStmtPrepareExecutor.java#L62) | 0 | 1 | 0.0% | Files with Coverage Reduction | New Missed Lines | % | | :-|--|--: | | [sharding-proxy/sharding-proxy-frontend/sharding-proxy-frontend-mysql/src/main/java/org/apache/shardingsphere/shardingproxy/frontend/mysql/command/query/binary/prepare/MySQLComStmtPrepareExecutor.java](https://coveralls.io/builds/28794032/source?filename=sharding-proxy%2Fsharding-proxy-frontend%2Fsharding-proxy-frontend-mysql%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingproxy%2Ffrontend%2Fmysql%2Fcommand%2Fquery%2Fbinary%2Fprepare%2FMySQLComStmtPrepareExecutor.java#L53) | 4 | 0% | | Totals | [](https://coveralls.io/builds/28794032) | | :-- | --: | | Change from base [Build 875](https://coveralls.io/builds/28793443): | 0.008% | | Covered Lines: | 11088 | | Relevant Lines: | 19236 | --- # 💛 - [Coveralls](https://coveralls.io) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] coveralls commented on issue #4352: update performance test
coveralls commented on issue #4352: update performance test URL: https://github.com/apache/incubator-shardingsphere/pull/4352#issuecomment-587385589 ## Pull Request Test Coverage Report for [Build 1787](https://coveralls.io/builds/28793751) * **0** of **0** changed or added relevant lines in **0** files are covered. * No unchanged relevant lines lost coverage. * Overall coverage remained the same at **57.634%** --- | Totals | [](https://coveralls.io/builds/28793751) | | :-- | --: | | Change from base [Build 875](https://coveralls.io/builds/28793443): | 0.0% | | Covered Lines: | 11087 | | Relevant Lines: | 19237 | --- # 💛 - [Coveralls](https://coveralls.io) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] tristaZero merged pull request #4354: decouple find SchemaSegment with show index statement
tristaZero merged pull request #4354: decouple find SchemaSegment with show index statement URL: https://github.com/apache/incubator-shardingsphere/pull/4354 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] kimmking commented on issue #4341: shardingsphere 4.0.0 retrive very slow that sql script
kimmking commented on issue #4341: shardingsphere 4.0.0 retrive very slow that sql script URL: https://github.com/apache/incubator-shardingsphere/issues/4341#issuecomment-587377554 @ancientelves After discuss with @terrymanu , I find the key point about this issue. The parameter `max.connections.size.per.query` in `server.yaml` is 1 by default. This means 16 sub query to each table one by one via a same connection. In my case, the cost is 250ms by proxy sharding, and came down to 90ms by set the parameter to 8, better than only one table. But a tip here : don't modify this parameter to a higher value in your production env, cause it maybeexhausted your jdbc connections in datasource pool. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] kimmking edited a comment on issue #4341: shardingsphere 4.0.0 retrive very slow that sql script
kimmking edited a comment on issue #4341: shardingsphere 4.0.0 retrive very slow that sql script URL: https://github.com/apache/incubator-shardingsphere/issues/4341#issuecomment-587377554 @ancientelves After discuss with @terrymanu , I find the key point about this issue. The parameter `max.connections.size.per.query` in `server.yaml` is 1 by default. This means 16 sub query to each table one by one via a same connection. In my case, the cost is 250ms by proxy sharding, and came down to 90ms by set the parameter to 8, better than only one table. And a tip here : don't modify this parameter to a higher value in your production env, cause it maybeexhausted your jdbc connections in datasource pool. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] coveralls commented on issue #4351: decouple find WhereSegment with select statement
coveralls commented on issue #4351: decouple find WhereSegment with select statement URL: https://github.com/apache/incubator-shardingsphere/pull/4351#issuecomment-587376938 ## Pull Request Test Coverage Report for [Build 1786](https://coveralls.io/builds/28793471) * **2** of **2** **(100.0%)** changed or added relevant lines in **2** files are covered. * No unchanged relevant lines lost coverage. * Overall coverage remained the same at **57.634%** --- | Totals | [](https://coveralls.io/builds/28793471) | | :-- | --: | | Change from base [Build 874](https://coveralls.io/builds/28792769): | 0.0% | | Covered Lines: | 11087 | | Relevant Lines: | 19237 | --- # 💛 - [Coveralls](https://coveralls.io) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu opened a new pull request #4354: decouple find SchemaSegment with show index statement
terrymanu opened a new pull request #4354: decouple find SchemaSegment with show index statement URL: https://github.com/apache/incubator-shardingsphere/pull/4354 For #4342. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] tuohai666 opened a new pull request #4353: #4255, use CAPI in stmt mode return incorrect response
tuohai666 opened a new pull request #4353: #4255, use CAPI in stmt mode return incorrect response URL: https://github.com/apache/incubator-shardingsphere/pull/4353 Fixes #4255. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu commented on issue #4352: update performance test
terrymanu commented on issue #4352: update performance test URL: https://github.com/apache/incubator-shardingsphere/pull/4352#issuecomment-587370274 Please change the title of this pr more accurate, using `update docs of performance test` instead of `update performance test` is better. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu commented on a change in pull request #4352: update performance test
terrymanu commented on a change in pull request #4352: update performance test URL: https://github.com/apache/incubator-shardingsphere/pull/4352#discussion_r380557853 ## File path: docs/document/content/features/test-engine/performance-test.cn.md ## @@ -348,6 +348,7 @@ DELETE FROM tbl1 WHERE id=? ```shell 参考https://github.com/apache/incubator-shardingsphere-benchmark/tree/master/shardingsphere-benchmark +注意阅读incubator-shardingsphere-benchmark/README.md中的Notes Review comment: Please do not mix using English and Chinese This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu commented on a change in pull request #4352: update performance test
terrymanu commented on a change in pull request #4352: update performance test URL: https://github.com/apache/incubator-shardingsphere/pull/4352#discussion_r380558670 ## File path: docs/document/content/features/test-engine/performance-test.cn.md ## @@ -348,6 +348,7 @@ DELETE FROM tbl1 WHERE id=? ```shell 参考https://github.com/apache/incubator-shardingsphere-benchmark/tree/master/shardingsphere-benchmark Review comment: Please use md format to display the html link. The format should be: ``` [xxx](https://xxx) ``` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] nancyzrh opened a new pull request #4352: update performance test
nancyzrh opened a new pull request #4352: update performance test URL: https://github.com/apache/incubator-shardingsphere/pull/4352 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] tristaZero merged pull request #4351: decouple find WhereSegment with select statement
tristaZero merged pull request #4351: decouple find WhereSegment with select statement URL: https://github.com/apache/incubator-shardingsphere/pull/4351 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu opened a new pull request #4351: decouple find WhereSegment with select statement
terrymanu opened a new pull request #4351: decouple find WhereSegment with select statement URL: https://github.com/apache/incubator-shardingsphere/pull/4351 For #4342. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] coveralls commented on issue #4350: decouple find WhereSegment with select statement
coveralls commented on issue #4350: decouple find WhereSegment with select statement URL: https://github.com/apache/incubator-shardingsphere/pull/4350#issuecomment-587359370 ## Pull Request Test Coverage Report for [Build 1785](https://coveralls.io/builds/28792736) * **1** of **1** **(100.0%)** changed or added relevant line in **1** file are covered. * No unchanged relevant lines lost coverage. * Overall coverage remained the same at **57.634%** --- | Totals | [](https://coveralls.io/builds/28792736) | | :-- | --: | | Change from base [Build 873](https://coveralls.io/builds/28791600): | 0.0% | | Covered Lines: | 11087 | | Relevant Lines: | 19237 | --- # 💛 - [Coveralls](https://coveralls.io) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[incubator-shardingsphere-benchmark] branch master updated: add notes
This is an automated email from the ASF dual-hosted git repository. zhaoyanan pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-shardingsphere-benchmark.git The following commit(s) were added to refs/heads/master by this push: new 288cb51 add notes 288cb51 is described below commit 288cb51fe16534a7ff15569f182511377555abff Author: nancyzrh AuthorDate: Tue Feb 18 17:10:39 2020 +0800 add notes --- README.md | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/README.md b/README.md index 22cd467..6a0d947 100644 --- a/README.md +++ b/README.md @@ -18,6 +18,8 @@ step 2: copy target jar to jmeter lib/ext # cp shardingsphere-benchmark-1.0-SNAPSHOT-jar-with-dependencies.jar apache-jmeter-**/lib/ext step 3: run jmeter test plan with target class - +# jmeter –n –t test_plan/test.jmx +# test.jmx example:https://github.com/apache/incubator-shardingsphere-benchmark/tree/master/report/script/test_plan/test.jmx +# Notes: test.jmx is just an example, you should change the name of class according to your performance code, and the ip/port in shardingsphere-benchmark should be modified to real machine. ```
[GitHub] [incubator-shardingsphere] tristaZero merged pull request #4350: decouple find WhereSegment with select statement
tristaZero merged pull request #4350: decouple find WhereSegment with select statement URL: https://github.com/apache/incubator-shardingsphere/pull/4350 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu opened a new pull request #4350: decouple find WhereSegment with select statement
terrymanu opened a new pull request #4350: decouple find WhereSegment with select statement URL: https://github.com/apache/incubator-shardingsphere/pull/4350 For #4342. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] KomachiSion opened a new pull request #4349: For#4286, Use source column metadata to avoid PG metadata problem
KomachiSion opened a new pull request #4349: For#4286, Use source column metadata to avoid PG metadata problem URL: https://github.com/apache/incubator-shardingsphere/pull/4349 For #4286 . This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] JackHuang0801 edited a comment on issue #4348: sharding-jdbc-core v 4.0.0 not support mybatis 3.5.2 about LocalDateTime handle?
JackHuang0801 edited a comment on issue #4348: sharding-jdbc-core v 4.0.0 not support mybatis 3.5.2 about LocalDateTime handle? URL: https://github.com/apache/incubator-shardingsphere/issues/4348#issuecomment-587334325 > You should define a typehanlder to convert datetime to localDateTime, cause ShardingSphere is in java7 but LocalDateTime is in java8. Ok, I got it, thx. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] coveralls edited a comment on issue #4347: Decouple find TopProjectionSegment with select statement
coveralls edited a comment on issue #4347: Decouple find TopProjectionSegment with select statement URL: https://github.com/apache/incubator-shardingsphere/pull/4347#issuecomment-587334885 ## Pull Request Test Coverage Report for [Build 1781](https://coveralls.io/builds/28791585) * **18** of **31** **(58.06%)** changed or added relevant lines in **14** files are covered. * **4** unchanged lines in **1** file lost coverage. * Overall coverage increased (+**0.006%**) to **57.634%** --- | Changes Missing Coverage | Covered Lines | Changed/Added Lines | % | | :-|--||---: | | [shardingsphere-sql-parser/shardingsphere-sql-parser-engine/src/main/java/org/apache/shardingsphere/sql/parser/core/filler/impl/dml/InsertColumnsFiller.java](https://coveralls.io/builds/28791585/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-engine%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fcore%2Ffiller%2Fimpl%2Fdml%2FInsertColumnsFiller.java#L32) | 0 | 1 | 0.0% | [shardingsphere-sql-parser/shardingsphere-sql-parser-engine/src/main/java/org/apache/shardingsphere/sql/parser/sql/statement/dml/InsertStatement.java](https://coveralls.io/builds/28791585/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-engine%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fsql%2Fstatement%2Fdml%2FInsertStatement.java#L62) | 1 | 2 | 50.0% | [shardingsphere-sql-parser/shardingsphere-sql-parser-mysql/src/main/java/org/apache/shardingsphere/sql/parser/visitor/impl/MySQLDMLVisitor.java](https://coveralls.io/builds/28791585/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-mysql%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fvisitor%2Fimpl%2FMySQLDMLVisitor.java#L135) | 0 | 1 | 0.0% | [shardingsphere-sql-parser/shardingsphere-sql-parser-oracle/src/main/java/org/apache/shardingsphere/sql/parser/visitor/impl/OracleDMLVisitor.java](https://coveralls.io/builds/28791585/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-oracle%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fvisitor%2Fimpl%2FOracleDMLVisitor.java#L110) | 0 | 1 | 0.0% | [shardingsphere-sql-parser/shardingsphere-sql-parser-postgresql/src/main/java/org/apache/shardingsphere/sql/parser/visitor/impl/PostgreSQLDMLVisitor.java](https://coveralls.io/builds/28791585/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-postgresql%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fvisitor%2Fimpl%2FPostgreSQLDMLVisitor.java#L116) | 0 | 1 | 0.0% | [shardingsphere-sql-parser/shardingsphere-sql-parser-relation/src/main/java/org/apache/shardingsphere/sql/parser/relation/segment/select/pagination/engine/PaginationContextEngine.java](https://coveralls.io/builds/28791585/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-relation%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Frelation%2Fsegment%2Fselect%2Fpagination%2Fengine%2FPaginationContextEngine.java#L68) | 5 | 6 | 83.33% | [shardingsphere-sql-parser/shardingsphere-sql-parser-sql92/src/main/java/org/apache/shardingsphere/sql/parser/visitor/impl/SQL92DMLVisitor.java](https://coveralls.io/builds/28791585/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-sql92%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fvisitor%2Fimpl%2FSQL92DMLVisitor.java#L104) | 0 | 1 | 0.0% | [shardingsphere-sql-parser/shardingsphere-sql-parser-sqlserver/src/main/java/org/apache/shardingsphere/sql/parser/visitor/impl/SQLServerDMLVisitor.java](https://coveralls.io/builds/28791585/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-sqlserver%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fvisitor%2Fimpl%2FSQLServerDMLVisitor.java#L105) | 0 | 1 | 0.0% | [shadow-core/shadow-core-rewrite/src/main/java/org/apache/shardingsphere/shadow/rewrite/token/generator/impl/RemoveShadowColumnTokenGenerator.java](https://coveralls.io/builds/28791585/source?filename=shadow-core%2Fshadow-core-rewrite%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshadow%2Frewrite%2Ftoken%2Fgenerator%2Fimpl%2FRemoveShadowColumnTokenGenerator.java#L41) | 0 | 5 | 0.0% | Files with Coverage Reduction | New Missed Lines | % | | :-|--|--: | | [shadow-core/shadow-core-rewrite/src/main/java/org/apache/shardingsphere/shadow/rewrite/token/generator/impl/RemoveShadowColumnTokenGenerator.java](https://coveralls.io/builds/28791585/source?filename=shadow-core%2Fshadow-core-rewrite%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshadow%2Frewrite%2Ftoken%2Fgenerator%2Fimpl%2FRemoveShadowColumnTokenGenerator.java#L37) | 4 | 0% | | Totals | [](https://coveralls.io/builds/28791585) | | :-- | -
[GitHub] [incubator-shardingsphere] coveralls commented on issue #4347: Decouple find TopProjectionSegment with select statement
coveralls commented on issue #4347: Decouple find TopProjectionSegment with select statement URL: https://github.com/apache/incubator-shardingsphere/pull/4347#issuecomment-587334885 ## Pull Request Test Coverage Report for [Build 9611](https://coveralls.io/builds/28791547) * **18** of **31** **(58.06%)** changed or added relevant lines in **14** files are covered. * **7** unchanged lines in **2** files lost coverage. * Overall coverage increased (+**0.0006%**) to **57.629%** --- | Changes Missing Coverage | Covered Lines | Changed/Added Lines | % | | :-|--||---: | | [shardingsphere-sql-parser/shardingsphere-sql-parser-engine/src/main/java/org/apache/shardingsphere/sql/parser/core/filler/impl/dml/InsertColumnsFiller.java](https://coveralls.io/builds/28791547/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-engine%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fcore%2Ffiller%2Fimpl%2Fdml%2FInsertColumnsFiller.java#L32) | 0 | 1 | 0.0% | [shardingsphere-sql-parser/shardingsphere-sql-parser-engine/src/main/java/org/apache/shardingsphere/sql/parser/sql/statement/dml/InsertStatement.java](https://coveralls.io/builds/28791547/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-engine%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fsql%2Fstatement%2Fdml%2FInsertStatement.java#L62) | 1 | 2 | 50.0% | [shardingsphere-sql-parser/shardingsphere-sql-parser-mysql/src/main/java/org/apache/shardingsphere/sql/parser/visitor/impl/MySQLDMLVisitor.java](https://coveralls.io/builds/28791547/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-mysql%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fvisitor%2Fimpl%2FMySQLDMLVisitor.java#L135) | 0 | 1 | 0.0% | [shardingsphere-sql-parser/shardingsphere-sql-parser-oracle/src/main/java/org/apache/shardingsphere/sql/parser/visitor/impl/OracleDMLVisitor.java](https://coveralls.io/builds/28791547/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-oracle%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fvisitor%2Fimpl%2FOracleDMLVisitor.java#L110) | 0 | 1 | 0.0% | [shardingsphere-sql-parser/shardingsphere-sql-parser-postgresql/src/main/java/org/apache/shardingsphere/sql/parser/visitor/impl/PostgreSQLDMLVisitor.java](https://coveralls.io/builds/28791547/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-postgresql%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fvisitor%2Fimpl%2FPostgreSQLDMLVisitor.java#L116) | 0 | 1 | 0.0% | [shardingsphere-sql-parser/shardingsphere-sql-parser-relation/src/main/java/org/apache/shardingsphere/sql/parser/relation/segment/select/pagination/engine/PaginationContextEngine.java](https://coveralls.io/builds/28791547/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-relation%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Frelation%2Fsegment%2Fselect%2Fpagination%2Fengine%2FPaginationContextEngine.java#L68) | 5 | 6 | 83.33% | [shardingsphere-sql-parser/shardingsphere-sql-parser-sql92/src/main/java/org/apache/shardingsphere/sql/parser/visitor/impl/SQL92DMLVisitor.java](https://coveralls.io/builds/28791547/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-sql92%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fvisitor%2Fimpl%2FSQL92DMLVisitor.java#L104) | 0 | 1 | 0.0% | [shardingsphere-sql-parser/shardingsphere-sql-parser-sqlserver/src/main/java/org/apache/shardingsphere/sql/parser/visitor/impl/SQLServerDMLVisitor.java](https://coveralls.io/builds/28791547/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-sqlserver%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fvisitor%2Fimpl%2FSQLServerDMLVisitor.java#L105) | 0 | 1 | 0.0% | [shadow-core/shadow-core-rewrite/src/main/java/org/apache/shardingsphere/shadow/rewrite/token/generator/impl/RemoveShadowColumnTokenGenerator.java](https://coveralls.io/builds/28791547/source?filename=shadow-core%2Fshadow-core-rewrite%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshadow%2Frewrite%2Ftoken%2Fgenerator%2Fimpl%2FRemoveShadowColumnTokenGenerator.java#L41) | 0 | 5 | 0.0% | Files with Coverage Reduction | New Missed Lines | % | | :-|--|--: | | [sharding-orchestration/sharding-orchestration-core/src/main/java/org/apache/shardingsphere/orchestration/internal/util/IpUtils.java](https://coveralls.io/builds/28791547/source?filename=sharding-orchestration%2Fsharding-orchestration-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Forchestration%2Finternal%2Futil%2FIpUtils.java#L63) | 3 | 76.0% | | [shadow-core/shadow-core-rewrite/src/main/java/org/apache/shardingsphere/shadow/rewrite/token/generator/impl/RemoveShadowColumnTokenGenerator.java](https://coveralls.io/b
[GitHub] [incubator-shardingsphere] JackHuang0801 closed issue #4348: sharding-jdbc-core v 4.0.0 not support mybatis 3.5.2 about LocalDateTime handle?
JackHuang0801 closed issue #4348: sharding-jdbc-core v 4.0.0 not support mybatis 3.5.2 about LocalDateTime handle? URL: https://github.com/apache/incubator-shardingsphere/issues/4348 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] JackHuang0801 commented on issue #4348: sharding-jdbc-core v 4.0.0 not support mybatis 3.5.2 about LocalDateTime handle?
JackHuang0801 commented on issue #4348: sharding-jdbc-core v 4.0.0 not support mybatis 3.5.2 about LocalDateTime handle? URL: https://github.com/apache/incubator-shardingsphere/issues/4348#issuecomment-587334325 > You should define a typehanlder to convert datetime to localDateTime, cause ShardingSphere is in java7 but LocalDateTime is in java8. Ok, I got it. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] kimmking commented on issue #4348: sharding-jdbc-core v 4.0.0 not support mybatis 3.5.2 about LocalDateTime handle?
kimmking commented on issue #4348: sharding-jdbc-core v 4.0.0 not support mybatis 3.5.2 about LocalDateTime handle? URL: https://github.com/apache/incubator-shardingsphere/issues/4348#issuecomment-587333464 You should define a typehanlder to convert datetime to localDateTime, cause ShardingSphere is in java7 but LocalDateTime is in java8. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] JackHuang0801 commented on issue #4348: sharding-jdbc-core v 4.0.0 not support mybatis 3.5.2 about LocalDateTime handle?
JackHuang0801 commented on issue #4348: sharding-jdbc-core v 4.0.0 not support
mybatis 3.5.2 about LocalDateTime handle?
URL:
https://github.com/apache/incubator-shardingsphere/issues/4348#issuecomment-587331958
I check the source code LocalDateTimeTypeHandler.java in mybatis 3.5.2
`public LocalDateTime getNullableResult(ResultSet rs, String columnName)
throws SQLException {
return (LocalDateTime)rs.getObject(columnName, LocalDateTime.class);
}`
And debug this part, it will call
org.apache.shardingsphere.shardingjdbc.jdbc.unsupported
AbstractUnsupportedOperationResultSet.java
`public final T getObject(String columnLabel, Class type) throws
SQLException {
throw new SQLFeatureNotSupportedException("getObject with type");
}`
I also use mybatis 3.5.0 and it is ok, no exception. Because 3.5.0 just
return timestamp not LocalDateTime, and 3.5.1 to upgrade the handle
LocalDateTime, change to use getObject() method.
So, it is sharding-jdbc 4.0.0 may be not compatible for mybatis 3.5.x?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
