[GitHub] [incubator-shardingsphere] bharathikannan-zarget commented on issue #4478: Is this possible to just shard databases with table rule configuration?
bharathikannan-zarget commented on issue #4478: Is this possible to just shard databases with table rule configuration? URL: https://github.com/apache/incubator-shardingsphere/issues/4478#issuecomment-594380477 Thanks @KomachiSion This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu closed issue #4586: move poweredby to users in doc
terrymanu closed issue #4586: move poweredby to users in doc URL: https://github.com/apache/incubator-shardingsphere/issues/4586 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu merged pull request #4587: move poweredby to users in doc
terrymanu merged pull request #4587: move poweredby to users in doc URL: https://github.com/apache/incubator-shardingsphere/pull/4587 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere-doc] hailinmo opened a new pull request #448: update homepage
hailinmo opened a new pull request #448: update homepage URL: https://github.com/apache/incubator-shardingsphere-doc/pull/448 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere-doc] terrymanu merged pull request #446: move poweredby to users
terrymanu merged pull request #446: move poweredby to users URL: https://github.com/apache/incubator-shardingsphere-doc/pull/446 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] coveralls commented on issue #4588: add alias for subquery grammar
coveralls commented on issue #4588: add alias for subquery grammar URL: https://github.com/apache/incubator-shardingsphere/pull/4588#issuecomment-594383248 ## Pull Request Test Coverage Report for [Build 1974](https://coveralls.io/builds/29118259) * **0** of **0** changed or added relevant lines in **0** files are covered. * **2** unchanged lines in **1** file lost coverage. * Overall coverage increased (+**0.006%**) to **57.804%** --- | Files with Coverage Reduction | New Missed Lines | % | | :-|--|--: | | [sharding-orchestration/sharding-orchestration-core/src/main/java/org/apache/shardingsphere/orchestration/internal/util/IpUtils.java](https://coveralls.io/builds/29118259/source?filename=sharding-orchestration%2Fsharding-orchestration-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Forchestration%2Finternal%2Futil%2FIpUtils.java#L72) | 2 | 80.0% | | Totals | [](https://coveralls.io/builds/29118259) | | :-- | --: | | Change from base [Build 10001](https://coveralls.io/builds/29118221): | 0.006% | | Covered Lines: | 10396 | | Relevant Lines: | 17985 | --- # 💛 - [Coveralls](https://coveralls.io) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] JasonKing168 opened a new pull request #4589: fix issue 4493-add curl&diff commands for comparing release resources with github tag in release guide
JasonKing168 opened a new pull request #4589: fix issue 4493-add curl&diff commands for comparing release resources with github tag in release guide URL: https://github.com/apache/incubator-shardingsphere/pull/4589 Fixes #4493. Changes proposed in this pull request: - - - This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] yanyzy merged pull request #4588: add alias for subquery grammar
yanyzy merged pull request #4588: add alias for subquery grammar URL: https://github.com/apache/incubator-shardingsphere/pull/4588 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere-doc] tristaZero merged pull request #448: update homepage
tristaZero merged pull request #448: update homepage URL: https://github.com/apache/incubator-shardingsphere-doc/pull/448 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] yanyzy opened a new pull request #4590: Fix failed to configure DataSource when use springboot + orchestration
yanyzy opened a new pull request #4590: Fix failed to configure DataSource when use springboot + orchestration URL: https://github.com/apache/incubator-shardingsphere/pull/4590 Fixes #4230. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu opened a new pull request #4591: Code style for ShardingScaling module
terrymanu opened a new pull request #4591: Code style for ShardingScaling module URL: https://github.com/apache/incubator-shardingsphere/pull/4591 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] coveralls edited a comment on issue #4588: add alias for subquery grammar
coveralls edited a comment on issue #4588: add alias for subquery grammar URL: https://github.com/apache/incubator-shardingsphere/pull/4588#issuecomment-594383248 ## Pull Request Test Coverage Report for [Build 10002](https://coveralls.io/builds/29118407) * **0** of **0** changed or added relevant lines in **0** files are covered. * No unchanged relevant lines lost coverage. * Overall coverage remained the same at **57.798%** --- | Totals | [](https://coveralls.io/builds/29118407) | | :-- | --: | | Change from base [Build 10001](https://coveralls.io/builds/29118221): | 0.0% | | Covered Lines: | 10395 | | Relevant Lines: | 17985 | --- # 💛 - [Coveralls](https://coveralls.io) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] KomachiSion merged pull request #4591: Code style for ShardingScaling module
KomachiSion merged pull request #4591: Code style for ShardingScaling module URL: https://github.com/apache/incubator-shardingsphere/pull/4591 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] geomonlin opened a new pull request #4592: update title in doc
geomonlin opened a new pull request #4592: update title in doc URL: https://github.com/apache/incubator-shardingsphere/pull/4592 Fixes #4586 . This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] KomachiSion opened a new pull request #4593: Remove unused files and dependence
KomachiSion opened a new pull request #4593: Remove unused files and dependence URL: https://github.com/apache/incubator-shardingsphere/pull/4593 For #4510 . This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] coveralls edited a comment on issue #4531: Add unit test case for sharding-orchestration-center-apollo module #4451
coveralls edited a comment on issue #4531: Add unit test case for sharding-orchestration-center-apollo module #4451 URL: https://github.com/apache/incubator-shardingsphere/pull/4531#issuecomment-592931755 ## Pull Request Test Coverage Report for [Build 10003](https://coveralls.io/builds/29118708) * **0** of **0** changed or added relevant lines in **0** files are covered. * No unchanged relevant lines lost coverage. * Overall coverage increased (+**0.006%**) to **57.804%** --- | Totals | [](https://coveralls.io/builds/29118708) | | :-- | --: | | Change from base [Build 10001](https://coveralls.io/builds/29118221): | 0.006% | | Covered Lines: | 10396 | | Relevant Lines: | 17985 | --- # 💛 - [Coveralls](https://coveralls.io) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] coveralls commented on issue #4590: Fix failed to configure DataSource when use springboot + orchestration
coveralls commented on issue #4590: Fix failed to configure DataSource when use springboot + orchestration URL: https://github.com/apache/incubator-shardingsphere/pull/4590#issuecomment-594402902 ## Pull Request Test Coverage Report for [Build 1975](https://coveralls.io/builds/29118929) * **0** of **0** changed or added relevant lines in **0** files are covered. * No unchanged relevant lines lost coverage. * Overall coverage increased (+**0.006%**) to **57.809%** --- | Totals | [](https://coveralls.io/builds/29118929) | | :-- | --: | | Change from base [Build 979](https://coveralls.io/builds/29118748): | 0.006% | | Covered Lines: | 10397 | | Relevant Lines: | 17985 | --- # 💛 - [Coveralls](https://coveralls.io) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere-doc] geomonlin opened a new pull request #449: update title
geomonlin opened a new pull request #449: update title URL: https://github.com/apache/incubator-shardingsphere-doc/pull/449 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] coveralls commented on issue #4589: fix issue 4493-add curl&diff commands for comparing release resources with github tag in release guide
coveralls commented on issue #4589: fix issue 4493-add curl&diff commands for comparing release resources with github tag in release guide URL: https://github.com/apache/incubator-shardingsphere/pull/4589#issuecomment-594405316 ## Pull Request Test Coverage Report for [Build 10005](https://coveralls.io/builds/29118971) * **0** of **0** changed or added relevant lines in **0** files are covered. * **3** unchanged lines in **1** file lost coverage. * Overall coverage decreased (**-0.006%**) to **57.798%** --- | Files with Coverage Reduction | New Missed Lines | % | | :-|--|--: | | [sharding-orchestration/sharding-orchestration-core/src/main/java/org/apache/shardingsphere/orchestration/internal/util/IpUtils.java](https://coveralls.io/builds/29118971/source?filename=sharding-orchestration%2Fsharding-orchestration-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Forchestration%2Finternal%2Futil%2FIpUtils.java#L63) | 3 | 76.0% | | Totals | [](https://coveralls.io/builds/29118971) | | :-- | --: | | Change from base [Build 978](https://coveralls.io/builds/29118580): | -0.006% | | Covered Lines: | 10395 | | Relevant Lines: | 17985 | --- # 💛 - [Coveralls](https://coveralls.io) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] KomachiSion closed issue #4028: If not hint values are set what's the routing behavior for HintShardingAlgorithm
KomachiSion closed issue #4028: If not hint values are set what's the routing behavior for HintShardingAlgorithm URL: https://github.com/apache/incubator-shardingsphere/issues/4028 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu merged pull request #4593: Remove unused files and dependence
terrymanu merged pull request #4593: Remove unused files and dependence URL: https://github.com/apache/incubator-shardingsphere/pull/4593 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere-doc] terrymanu merged pull request #449: update title
terrymanu merged pull request #449: update title URL: https://github.com/apache/incubator-shardingsphere-doc/pull/449 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu merged pull request #4592: update title in doc
terrymanu merged pull request #4592: update title in doc URL: https://github.com/apache/incubator-shardingsphere/pull/4592 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu opened a new issue #4594: Create database protocol module
terrymanu opened a new issue #4594: Create database protocol module URL: https://github.com/apache/incubator-shardingsphere/issues/4594 The sharding-proxy and sharding-scaling modules are both use MySQL protocol, there are lots of duplicated codes. It is better to create a new module to process database protocol. The tasks are: - [ ] Create shardingsphere-database-protocol module - [ ] Create shardingsphere-mysql-protocol submodule - [ ] Create shardingsphere-postgresql-protocol submodule - [ ] Merge sharding-proxy and sharding-scaling's mysql protocol part. - [ ] Move sharding-proxy's postgresql protocol part. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] codecov-io commented on issue #4590: Fix failed to configure DataSource when use springboot + orchestration
codecov-io commented on issue #4590: Fix failed to configure DataSource when use springboot + orchestration URL: https://github.com/apache/incubator-shardingsphere/pull/4590#issuecomment-594418280 # [Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4590?src=pr&el=h1) Report > Merging [#4590](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4590?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-shardingsphere/commit/263259442cbd9b6ff46becc5ba61e77cb56f4d33?src=pr&el=desc) will **not change** coverage. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4590?src=pr&el=tree) ```diff @@Coverage Diff@@ ## master#4590 +/- ## = Coverage 54.26% 54.26% Complexity 343 343 = Files 1001 1001 Lines 1798517985 Branches 3372 3372 = Hits 9759 9759 Misses 7602 7602 Partials624 624 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4590?src=pr&el=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...ing/boot/OrchestrationSpringBootConfiguration.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4590/diff?src=pr&el=tree#diff-c2hhcmRpbmctc3ByaW5nL3NoYXJkaW5nLWpkYmMtb3JjaGVzdHJhdGlvbi1zcHJpbmcvc2hhcmRpbmctamRiYy1vcmNoZXN0cmF0aW9uLXNwcmluZy1ib290LXN0YXJ0ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NoYXJkaW5namRiYy9vcmNoZXN0cmF0aW9uL3NwcmluZy9ib290L09yY2hlc3RyYXRpb25TcHJpbmdCb290Q29uZmlndXJhdGlvbi5qYXZh) | `88.37% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4590?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4590?src=pr&el=footer). Last update [2632594...c264a19](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4590?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu opened a new issue #4595: Consider about new name for ShardingScaling's concept
terrymanu opened a new issue #4595: Consider about new name for ShardingScaling's concept URL: https://github.com/apache/incubator-shardingsphere/issues/4595 The scope of current concept names of ShardingScaling are too big. `Reader` and `Writer` maybe not suitable names. We need to consider about the new name of them, for exmaple: `Source` and `Sink`. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu opened a new issue #4596: Keyword of SQL should be uppercase
terrymanu opened a new issue #4596: Keyword of SQL should be uppercase URL: https://github.com/apache/incubator-shardingsphere/issues/4596 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] kimmking commented on issue #4585: nested exception is java.lang.NoClassDefFoundError: org/apache/curator/connection/ConnectionHandlingPolicy
kimmking commented on issue #4585: nested exception is java.lang.NoClassDefFoundError: org/apache/curator/connection/ConnectionHandlingPolicy URL: https://github.com/apache/incubator-shardingsphere/issues/4585#issuecomment-594422400 Which vesion do you refer? And do you make mvn clean package install at first? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] kimmking edited a comment on issue #4585: nested exception is java.lang.NoClassDefFoundError: org/apache/curator/connection/ConnectionHandlingPolicy
kimmking edited a comment on issue #4585: nested exception is java.lang.NoClassDefFoundError: org/apache/curator/connection/ConnectionHandlingPolicy URL: https://github.com/apache/incubator-shardingsphere/issues/4585#issuecomment-594422400 Which vesion do you refer? And do you make `mvn clean package install at first? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] kimmking commented on issue #4586: move poweredby to users in doc
kimmking commented on issue #4586: move poweredby to users in doc URL: https://github.com/apache/incubator-shardingsphere/issues/4586#issuecomment-594423082 rename poweredby page to users page in doc module and web site? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] coveralls edited a comment on issue #4590: Fix failed to configure DataSource when use springboot + orchestration
coveralls edited a comment on issue #4590: Fix failed to configure DataSource when use springboot + orchestration URL: https://github.com/apache/incubator-shardingsphere/pull/4590#issuecomment-594402902 ## Pull Request Test Coverage Report for [Build 10007](https://coveralls.io/builds/29119778) * **0** of **0** changed or added relevant lines in **0** files are covered. * **3** unchanged lines in **1** file lost coverage. * Overall coverage decreased (**-0.006%**) to **57.798%** --- | Files with Coverage Reduction | New Missed Lines | % | | :-|--|--: | | [sharding-orchestration/sharding-orchestration-core/src/main/java/org/apache/shardingsphere/orchestration/internal/util/IpUtils.java](https://coveralls.io/builds/29119778/source?filename=sharding-orchestration%2Fsharding-orchestration-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Forchestration%2Finternal%2Futil%2FIpUtils.java#L63) | 3 | 76.0% | | Totals | [](https://coveralls.io/builds/29119778) | | :-- | --: | | Change from base [Build 979](https://coveralls.io/builds/29118748): | -0.006% | | Covered Lines: | 10395 | | Relevant Lines: | 17985 | --- # 💛 - [Coveralls](https://coveralls.io) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu closed issue #4493: add curl command to get the tag_dir in release guide document
terrymanu closed issue #4493: add curl command to get the tag_dir in release guide document URL: https://github.com/apache/incubator-shardingsphere/issues/4493 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu merged pull request #4589: fix issue 4493-add curl&diff commands for comparing release resources with github tag in release guide
terrymanu merged pull request #4589: fix issue 4493-add curl&diff commands for comparing release resources with github tag in release guide URL: https://github.com/apache/incubator-shardingsphere/pull/4589 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] kimmking commented on issue #4575: no viable alternative at input 'user_idinteger'
kimmking commented on issue #4575: no viable alternative at input 'user_idinteger' URL: https://github.com/apache/incubator-shardingsphere/issues/4575#issuecomment-594424056 maybe input incorrect. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] kimmking edited a comment on issue #4565: distinct returns wrong result
kimmking edited a comment on issue #4565: distinct returns wrong result URL: https://github.com/apache/incubator-shardingsphere/issues/4565#issuecomment-594426703 If table user ~ 2 databases and 3 tables of each. ``` 1.select distinct age from user => wrong 2.select distinct age from user group by age 3.select distinct age from user order by age 4.select distinct age from user group by age order by age 5.select distinct age from user group by name 6.select distinct age from user order by id 7.select distinct age from user group by name order by id 8.select distinct age from user group by 1 ``` All of above sqls will executed to right result except the first one. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] kimmking commented on issue #4565: distinct returns wrong result
kimmking commented on issue #4565: distinct returns wrong result URL: https://github.com/apache/incubator-shardingsphere/issues/4565#issuecomment-594426703 If table user ~ 2 databases and 3 tables of each. ``` 1. select distinct age from user => wrong 2.select distinct age from user group by age 3.select distinct age from user order by age 4.select distinct age from user group by age order by age 5.select distinct age from user group by name 6.select distinct age from user order by id 7.select distinct age from user group by name order by id 8.select distinct age from user group by 1 ``` All of above sqls will executed to right result except the first one. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] kimmking edited a comment on issue #4565: distinct returns wrong result
kimmking edited a comment on issue #4565: distinct returns wrong result URL: https://github.com/apache/incubator-shardingsphere/issues/4565#issuecomment-594426703 If table user ~ 2 databases and 3 tables of each. ``` 1.select distinct age from user => wrong 2.select distinct age from user group by age 3.select distinct age from user order by age 4.select distinct age from user group by age order by age 5.select distinct age from user group by name 6.select distinct age from user order by id 7.select distinct age from user group by name order by id 8.select distinct age from user group by 1 ``` All of above sqls will executed to right result except the first one. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] kimmking edited a comment on issue #4565: distinct returns wrong result
kimmking edited a comment on issue #4565: distinct returns wrong result URL: https://github.com/apache/incubator-shardingsphere/issues/4565#issuecomment-594426703 If table user ~ 2 databases and 3 tables of each. ``` **1.select distinct age from user => wrong** 2.select distinct age from user group by age 3.select distinct age from user order by age 4.select distinct age from user group by age order by age 5.select distinct age from user group by name 6.select distinct age from user order by id 7.select distinct age from user group by name order by id 8.select distinct age from user group by 1 ``` All of above sqls will executed to right result except the first one. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] dongzl commented on a change in pull request #4531: Add unit test case for sharding-orchestration-center-apollo module #4451
dongzl commented on a change in pull request #4531: Add unit test case for
sharding-orchestration-center-apollo module #4451
URL:
https://github.com/apache/incubator-shardingsphere/pull/4531#discussion_r387464779
##
File path:
sharding-orchestration/sharding-orchestration-center/sharding-orchestration-center-apollo/src/test/java/org/apache/shardingsphere/orchestration/center/instance/ApolloInstanceTest.java
##
@@ -67,12 +78,62 @@ public void assertGet() {
@Test
@SneakyThrows
public void assertWatch() {
+assertWatchUpdateChangedType("/test/children/1", "value3");
+}
+
+@Test
+@SneakyThrows
+public void assertGetWithNonExistentKey() {
+assertNull(configCenterRepository.get("/test/nonExistentKey"));
+}
+
+@Test
+@SneakyThrows
+public void assertUpdate() {
Review comment:
I suggest this method rename `assertWatchUpdateChangedTypeWithExistedKey`.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] dongzl merged pull request #4531: Add unit test case for sharding-orchestration-center-apollo module #4451
dongzl merged pull request #4531: Add unit test case for sharding-orchestration-center-apollo module #4451 URL: https://github.com/apache/incubator-shardingsphere/pull/4531 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] dongzl closed issue #4451: Add unit test case for sharding-orchestration-center-apollo module
dongzl closed issue #4451: Add unit test case for sharding-orchestration-center-apollo module URL: https://github.com/apache/incubator-shardingsphere/issues/4451 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] kimmking opened a new pull request #4597: fix #4565 for distinct bug
kimmking opened a new pull request #4597: fix #4565 for distinct bug URL: https://github.com/apache/incubator-shardingsphere/pull/4597 Fixes #4565 . Changes proposed in this pull request: - for fix distinct bug This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] kimmking commented on issue #4597: fix #4565 for distinct bug
kimmking commented on issue #4597: fix #4565 for distinct bug
URL:
https://github.com/apache/incubator-shardingsphere/pull/4597#issuecomment-594438291
[distinct.txt](https://github.com/apache/incubator-shardingsphere/files/4286703/distinct.txt)
Using 2 databases, 3 tables of each.
> insert into user(`name`,`age`) values
('name-11',11),('name-12',11),('name-13',11),('name-14',14),[INFO ] 2020-03-04
17:39:01,925 --main-- [ShardingSphere-SQL] Actual SQL: ds_0 ::: insert into
user2(`name`,`age`, id) values ('name-11', 11, 442017321611952128)
[INFO ] 2020-03-04 17:39:01,925 --main-- [ShardingSphere-SQL] Actual SQL:
ds_1 ::: insert into user0(`name`,`age`, id) values ('name-12', 11,
442017321611952129)
[INFO ] 2020-03-04 17:39:01,925 --main-- [ShardingSphere-SQL] Actual SQL:
ds_0 ::: insert into user1(`name`,`age`, id) values ('name-13', 11,
442017321611952130)
[INFO ] 2020-03-04 17:39:01,925 --main-- [ShardingSphere-SQL] Actual SQL:
ds_1 ::: insert into user2(`name`,`age`, id) values ('name-14', 14,
442017321611952131)
[INFO ] 2020-03-04 17:39:01,925 --main-- [ShardingSphere-SQL] Actual SQL:
ds_0 ::: insert into user0(`name`,`age`, id) values ('name-14', 15,
442017321611952132)
[INFO ] 2020-03-04 17:39:01,925 --main-- [ShardingSphere-SQL] Actual SQL:
ds_1 ::: insert into user1(`name`,`age`, id) values ('name-14', 10,
442017321611952133)
>
('name-21',11),('name-22',11),('name-23',12),('name-24',13),('name-14',15),('name-14',17)
[INFO ] 2020-03-04 17:39:02,092 --main-- [ShardingSphere-SQL] Actual SQL:
ds_1 ::: insert into user0(`name`,`age`, id) values ('name-21', 11,
442017322996072449)
[INFO ] 2020-03-04 17:39:02,092 --main-- [ShardingSphere-SQL] Actual SQL:
ds_0 ::: insert into user1(`name`,`age`, id) values ('name-22', 11,
442017322996072450)
[INFO ] 2020-03-04 17:39:02,092 --main-- [ShardingSphere-SQL] Actual SQL:
ds_1 ::: insert into user2(`name`,`age`, id) values ('name-23', 12,
442017322996072451)
[INFO ] 2020-03-04 17:39:02,092 --main-- [ShardingSphere-SQL] Actual SQL:
ds_0 ::: insert into user0(`name`,`age`, id) values ('name-24', 13,
442017322996072452)
[INFO ] 2020-03-04 17:39:02,092 --main-- [ShardingSphere-SQL] Actual SQL:
ds_1 ::: insert into user1(`name`,`age`, id) values ('name-14', 15,
442017322996072453)
[INFO ] 2020-03-04 17:39:02,092 --main-- [ShardingSphere-SQL] Actual SQL:
ds_0 ::: insert into user2(`name`,`age`, id) values ('name-14', 17,
442017322996072454)
>insert into user(`name`,`age`) values
('name-31',11),('name-32',12),('name-33',13),('name-34',14),('name-14',15),('name-14',16)
[INFO ] 2020-03-04 17:39:02,264 --main-- [ShardingSphere-SQL] Actual SQL:
ds_0 ::: insert into user2(`name`,`age`, id) values ('name-31', 11,
442017323713298432)
[INFO ] 2020-03-04 17:39:02,264 --main-- [ShardingSphere-SQL] Actual SQL:
ds_1 ::: insert into user0(`name`,`age`, id) values ('name-32', 12,
442017323713298433)
[INFO ] 2020-03-04 17:39:02,264 --main-- [ShardingSphere-SQL] Actual SQL:
ds_0 ::: insert into user1(`name`,`age`, id) values ('name-33', 13,
442017323713298434)
[INFO ] 2020-03-04 17:39:02,264 --main-- [ShardingSphere-SQL] Actual SQL:
ds_1 ::: insert into user2(`name`,`age`, id) values ('name-34', 14,
442017323713298435)
[INFO ] 2020-03-04 17:39:02,264 --main-- [ShardingSphere-SQL] Actual SQL:
ds_0 ::: insert into user0(`name`,`age`, id) values ('name-14', 15,
442017323713298436)
[INFO ] 2020-03-04 17:39:02,264 --main-- [ShardingSphere-SQL] Actual SQL:
ds_1 ::: insert into user1(`name`,`age`, id) values ('name-14', 16,
442017323713298437)
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] kimmking edited a comment on issue #4597: fix #4565 for distinct bug
kimmking edited a comment on issue #4597: fix #4565 for distinct bug URL: https://github.com/apache/incubator-shardingsphere/pull/4597#issuecomment-594438718 ``` = >Case1: distinct only > [INFO ] 2020-03-04 17:39:02,423 --main-- [ShardingSphere-SQL] Rule Type: sharding [INFO ] 2020-03-04 17:39:02,423 --main-- [ShardingSphere-SQL] Logic SQL: select distinct age from user [INFO ] 2020-03-04 17:39:02,423 --main-- [ShardingSphere-SQL] SQLStatement: SelectStatementContext(super=CommonSQLStatementContext(sqlStatement=org.apache.shardingsphere.sql.parser.sql.statement.dml.SelectStatement@4a29f290, tablesContext=org.apache.shardingsphere.sql.parser.relation.segment.table.TablesContext@4bee18dc), tablesContext=org.apache.shardingsphere.sql.parser.relation.segment.table.TablesContext@4bee18dc, projectionsContext=ProjectionsContext(startIndex=16, stopIndex=18, distinctRow=true, projections=[ColumnProjection(owner=null, name=age, alias=Optional.empty)], columnLabels=[age]), groupByContext=org.apache.shardingsphere.sql.parser.relation.segment.select.groupby.GroupByContext@44f3fe83, orderByContext=org.apache.shardingsphere.sql.parser.relation.segment.select.orderby.OrderByContext@44c5a16f, paginationContext=org.apache.shardingsphere.sql.parser.relation.segment.select.pagination.PaginationContext@417d6615, containsSubquery=false) [INFO ] 2020-03-04 17:39:02,423 --main-- [ShardingSphere-SQL] Actual SQL: ds_0 ::: select distinct age from user0 ORDER BY age ASC [INFO ] 2020-03-04 17:39:02,423 --main-- [ShardingSphere-SQL] Actual SQL: ds_0 ::: select distinct age from user1 ORDER BY age ASC [INFO ] 2020-03-04 17:39:02,423 --main-- [ShardingSphere-SQL] Actual SQL: ds_0 ::: select distinct age from user2 ORDER BY age ASC [INFO ] 2020-03-04 17:39:02,423 --main-- [ShardingSphere-SQL] Actual SQL: ds_1 ::: select distinct age from user0 ORDER BY age ASC [INFO ] 2020-03-04 17:39:02,423 --main-- [ShardingSphere-SQL] Actual SQL: ds_1 ::: select distinct age from user1 ORDER BY age ASC [INFO ] 2020-03-04 17:39:02,424 --main-- [ShardingSphere-SQL] Actual SQL: ds_1 ::: select distinct age from user2 ORDER BY age ASC [10] [11] [12] [13] [14] [15] [16] [17] ``` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] kimmking edited a comment on issue #4597: fix #4565 for distinct bug
kimmking edited a comment on issue #4597: fix #4565 for distinct bug URL: https://github.com/apache/incubator-shardingsphere/pull/4597#issuecomment-594438718 ``` = >Case1: distinct only > [INFO ] 2020-03-04 17:39:02,423 --main-- [ShardingSphere-SQL] Rule Type: sharding [INFO ] 2020-03-04 17:39:02,423 --main-- [ShardingSphere-SQL] Logic SQL: select distinct age from user [INFO ] 2020-03-04 17:39:02,423 --main-- [ShardingSphere-SQL] Actual SQL: ds_0 ::: select distinct age from user0 ORDER BY age ASC [INFO ] 2020-03-04 17:39:02,423 --main-- [ShardingSphere-SQL] Actual SQL: ds_0 ::: select distinct age from user1 ORDER BY age ASC [INFO ] 2020-03-04 17:39:02,423 --main-- [ShardingSphere-SQL] Actual SQL: ds_0 ::: select distinct age from user2 ORDER BY age ASC [INFO ] 2020-03-04 17:39:02,423 --main-- [ShardingSphere-SQL] Actual SQL: ds_1 ::: select distinct age from user0 ORDER BY age ASC [INFO ] 2020-03-04 17:39:02,423 --main-- [ShardingSphere-SQL] Actual SQL: ds_1 ::: select distinct age from user1 ORDER BY age ASC [INFO ] 2020-03-04 17:39:02,424 --main-- [ShardingSphere-SQL] Actual SQL: ds_1 ::: select distinct age from user2 ORDER BY age ASC [10] [11] [12] [13] [14] [15] [16] [17] ``` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] kimmking commented on issue #4597: fix #4565 for distinct bug
kimmking commented on issue #4597: fix #4565 for distinct bug URL: https://github.com/apache/incubator-shardingsphere/pull/4597#issuecomment-594438718 = >Case1: distinct only > [INFO ] 2020-03-04 17:39:02,423 --main-- [ShardingSphere-SQL] Rule Type: sharding [INFO ] 2020-03-04 17:39:02,423 --main-- [ShardingSphere-SQL] Logic SQL: select distinct age from user [INFO ] 2020-03-04 17:39:02,423 --main-- [ShardingSphere-SQL] Actual SQL: ds_0 ::: select distinct age from user0 ORDER BY age ASC [INFO ] 2020-03-04 17:39:02,423 --main-- [ShardingSphere-SQL] Actual SQL: ds_0 ::: select distinct age from user1 ORDER BY age ASC [INFO ] 2020-03-04 17:39:02,423 --main-- [ShardingSphere-SQL] Actual SQL: ds_0 ::: select distinct age from user2 ORDER BY age ASC [INFO ] 2020-03-04 17:39:02,423 --main-- [ShardingSphere-SQL] Actual SQL: ds_1 ::: select distinct age from user0 ORDER BY age ASC [INFO ] 2020-03-04 17:39:02,423 --main-- [ShardingSphere-SQL] Actual SQL: ds_1 ::: select distinct age from user1 ORDER BY age ASC [INFO ] 2020-03-04 17:39:02,424 --main-- [ShardingSphere-SQL] Actual SQL: ds_1 ::: select distinct age from user2 ORDER BY age ASC [10] [11] [12] [13] [14] [15] [16] [17] This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] kimmking commented on issue #4597: fix #4565 for distinct bug
kimmking commented on issue #4597: fix #4565 for distinct bug URL: https://github.com/apache/incubator-shardingsphere/pull/4597#issuecomment-594439066 ``` = >Case2: distinct with groupby > [INFO ] 2020-03-04 17:39:02,483 --main-- [ShardingSphere-SQL] Rule Type: sharding [INFO ] 2020-03-04 17:39:02,484 --main-- [ShardingSphere-SQL] Logic SQL: select distinct age from user group by age [INFO ] 2020-03-04 17:39:02,484 --main-- [ShardingSphere-SQL] SQLStatement: SelectStatementContext(super=CommonSQLStatementContext(sqlStatement=org.apache.shardingsphere.sql.parser.sql.statement.dml.SelectStatement@4ba89729, tablesContext=org.apache.shardingsphere.sql.parser.relation.segment.table.TablesContext@178270b2), tablesContext=org.apache.shardingsphere.sql.parser.relation.segment.table.TablesContext@178270b2, projectionsContext=ProjectionsContext(startIndex=16, stopIndex=18, distinctRow=true, projections=[ColumnProjection(owner=null, name=age, alias=Optional.empty)], columnLabels=[age]), groupByContext=org.apache.shardingsphere.sql.parser.relation.segment.select.groupby.GroupByContext@795fd838, orderByContext=org.apache.shardingsphere.sql.parser.relation.segment.select.orderby.OrderByContext@1b005a0b, paginationContext=org.apache.shardingsphere.sql.parser.relation.segment.select.pagination.PaginationContext@141e879d, containsSubquery=false) [INFO ] 2020-03-04 17:39:02,484 --main-- [ShardingSphere-SQL] Actual SQL: ds_0 ::: select distinct age from user0 group by age ORDER BY age ASC [INFO ] 2020-03-04 17:39:02,484 --main-- [ShardingSphere-SQL] Actual SQL: ds_0 ::: select distinct age from user1 group by age ORDER BY age ASC [INFO ] 2020-03-04 17:39:02,484 --main-- [ShardingSphere-SQL] Actual SQL: ds_0 ::: select distinct age from user2 group by age ORDER BY age ASC [INFO ] 2020-03-04 17:39:02,484 --main-- [ShardingSphere-SQL] Actual SQL: ds_1 ::: select distinct age from user0 group by age ORDER BY age ASC [INFO ] 2020-03-04 17:39:02,484 --main-- [ShardingSphere-SQL] Actual SQL: ds_1 ::: select distinct age from user1 group by age ORDER BY age ASC [INFO ] 2020-03-04 17:39:02,484 --main-- [ShardingSphere-SQL] Actual SQL: ds_1 ::: select distinct age from user2 group by age ORDER BY age ASC [10] [11] [12] [13] [14] [15] [16] [17] ``` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] kimmking commented on issue #4597: fix #4565 for distinct bug
kimmking commented on issue #4597: fix #4565 for distinct bug URL: https://github.com/apache/incubator-shardingsphere/pull/4597#issuecomment-594439299 ``` = >Case4: distinct with groupby&orderby > [INFO ] 2020-03-04 17:39:02,504 --main-- [ShardingSphere-SQL] Rule Type: sharding [INFO ] 2020-03-04 17:39:02,504 --main-- [ShardingSphere-SQL] Logic SQL: select distinct age from user group by age order by age [INFO ] 2020-03-04 17:39:02,504 --main-- [ShardingSphere-SQL] SQLStatement: SelectStatementContext(super=CommonSQLStatementContext(sqlStatement=org.apache.shardingsphere.sql.parser.sql.statement.dml.SelectStatement@39109136, tablesContext=org.apache.shardingsphere.sql.parser.relation.segment.table.TablesContext@27c04377), tablesContext=org.apache.shardingsphere.sql.parser.relation.segment.table.TablesContext@27c04377, projectionsContext=ProjectionsContext(startIndex=16, stopIndex=18, distinctRow=true, projections=[ColumnProjection(owner=null, name=age, alias=Optional.empty)], columnLabels=[age]), groupByContext=org.apache.shardingsphere.sql.parser.relation.segment.select.groupby.GroupByContext@34dc85a, orderByContext=org.apache.shardingsphere.sql.parser.relation.segment.select.orderby.OrderByContext@67403656, paginationContext=org.apache.shardingsphere.sql.parser.relation.segment.select.pagination.PaginationContext@5a6482a9, containsSubquery=false) [INFO ] 2020-03-04 17:39:02,504 --main-- [ShardingSphere-SQL] Actual SQL: ds_0 ::: select distinct age from user0 group by age order by age [INFO ] 2020-03-04 17:39:02,504 --main-- [ShardingSphere-SQL] Actual SQL: ds_0 ::: select distinct age from user1 group by age order by age [INFO ] 2020-03-04 17:39:02,504 --main-- [ShardingSphere-SQL] Actual SQL: ds_0 ::: select distinct age from user2 group by age order by age [INFO ] 2020-03-04 17:39:02,504 --main-- [ShardingSphere-SQL] Actual SQL: ds_1 ::: select distinct age from user0 group by age order by age [INFO ] 2020-03-04 17:39:02,504 --main-- [ShardingSphere-SQL] Actual SQL: ds_1 ::: select distinct age from user1 group by age order by age [INFO ] 2020-03-04 17:39:02,504 --main-- [ShardingSphere-SQL] Actual SQL: ds_1 ::: select distinct age from user2 group by age order by age [10] [11] [12] [13] [14] [15] [16] [17] ``` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] kimmking commented on issue #4597: fix #4565 for distinct bug
kimmking commented on issue #4597: fix #4565 for distinct bug URL: https://github.com/apache/incubator-shardingsphere/pull/4597#issuecomment-594439198 ``` = >Case3: distinct with orderby > [INFO ] 2020-03-04 17:39:02,495 --main-- [ShardingSphere-SQL] Rule Type: sharding [INFO ] 2020-03-04 17:39:02,495 --main-- [ShardingSphere-SQL] Logic SQL: select distinct age from user order by age [INFO ] 2020-03-04 17:39:02,495 --main-- [ShardingSphere-SQL] SQLStatement: SelectStatementContext(super=CommonSQLStatementContext(sqlStatement=org.apache.shardingsphere.sql.parser.sql.statement.dml.SelectStatement@99a78d7, tablesContext=org.apache.shardingsphere.sql.parser.relation.segment.table.TablesContext@31da6b2e), tablesContext=org.apache.shardingsphere.sql.parser.relation.segment.table.TablesContext@31da6b2e, projectionsContext=ProjectionsContext(startIndex=16, stopIndex=18, distinctRow=true, projections=[ColumnProjection(owner=null, name=age, alias=Optional.empty)], columnLabels=[age]), groupByContext=org.apache.shardingsphere.sql.parser.relation.segment.select.groupby.GroupByContext@61c76850, orderByContext=org.apache.shardingsphere.sql.parser.relation.segment.select.orderby.OrderByContext@70242f38, paginationContext=org.apache.shardingsphere.sql.parser.relation.segment.select.pagination.PaginationContext@2a22ad2b, containsSubquery=false) [INFO ] 2020-03-04 17:39:02,495 --main-- [ShardingSphere-SQL] Actual SQL: ds_0 ::: select distinct age from user0 order by age [INFO ] 2020-03-04 17:39:02,495 --main-- [ShardingSphere-SQL] Actual SQL: ds_0 ::: select distinct age from user1 order by age [INFO ] 2020-03-04 17:39:02,495 --main-- [ShardingSphere-SQL] Actual SQL: ds_0 ::: select distinct age from user2 order by age [INFO ] 2020-03-04 17:39:02,495 --main-- [ShardingSphere-SQL] Actual SQL: ds_1 ::: select distinct age from user0 order by age [INFO ] 2020-03-04 17:39:02,495 --main-- [ShardingSphere-SQL] Actual SQL: ds_1 ::: select distinct age from user1 order by age [INFO ] 2020-03-04 17:39:02,495 --main-- [ShardingSphere-SQL] Actual SQL: ds_1 ::: select distinct age from user2 order by age [10] [11] [12] [13] [14] [15] [16] [17] ``` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] kimmking commented on issue #4597: fix #4565 for distinct bug
kimmking commented on issue #4597: fix #4565 for distinct bug URL: https://github.com/apache/incubator-shardingsphere/pull/4597#issuecomment-594439567 ``` = >Case6: 2 columns for distinct only > [INFO ] 2020-03-04 17:39:02,561 --main-- [ShardingSphere-SQL] Rule Type: sharding [INFO ] 2020-03-04 17:39:02,561 --main-- [ShardingSphere-SQL] Logic SQL: select distinct age,name from user [INFO ] 2020-03-04 17:39:02,561 --main-- [ShardingSphere-SQL] SQLStatement: SelectStatementContext(super=CommonSQLStatementContext(sqlStatement=org.apache.shardingsphere.sql.parser.sql.statement.dml.SelectStatement@2f5c1332, tablesContext=org.apache.shardingsphere.sql.parser.relation.segment.table.TablesContext@7ec25216), tablesContext=org.apache.shardingsphere.sql.parser.relation.segment.table.TablesContext@7ec25216, projectionsContext=ProjectionsContext(startIndex=16, stopIndex=23, distinctRow=true, projections=[ColumnProjection(owner=null, name=age, alias=Optional.empty), ColumnProjection(owner=null, name=name, alias=Optional.empty)], columnLabels=[age, name]), groupByContext=org.apache.shardingsphere.sql.parser.relation.segment.select.groupby.GroupByContext@7cab1508, orderByContext=org.apache.shardingsphere.sql.parser.relation.segment.select.orderby.OrderByContext@6a84bc3f, paginationContext=org.apache.shardingsphere.sql.parser.relation.segment.select.pagination.PaginationContext@258ee7de, containsSubquery=false) [INFO ] 2020-03-04 17:39:02,561 --main-- [ShardingSphere-SQL] Actual SQL: ds_0 ::: select distinct age,name from user0 ORDER BY age ASC,name ASC [INFO ] 2020-03-04 17:39:02,561 --main-- [ShardingSphere-SQL] Actual SQL: ds_0 ::: select distinct age,name from user1 ORDER BY age ASC,name ASC [INFO ] 2020-03-04 17:39:02,561 --main-- [ShardingSphere-SQL] Actual SQL: ds_0 ::: select distinct age,name from user2 ORDER BY age ASC,name ASC [INFO ] 2020-03-04 17:39:02,561 --main-- [ShardingSphere-SQL] Actual SQL: ds_1 ::: select distinct age,name from user0 ORDER BY age ASC,name ASC [INFO ] 2020-03-04 17:39:02,561 --main-- [ShardingSphere-SQL] Actual SQL: ds_1 ::: select distinct age,name from user1 ORDER BY age ASC,name ASC [INFO ] 2020-03-04 17:39:02,561 --main-- [ShardingSphere-SQL] Actual SQL: ds_1 ::: select distinct age,name from user2 ORDER BY age ASC,name ASC [name-14, 10] [name-11, 11] [name-12, 11] [name-13, 11] [name-21, 11] [name-22, 11] [name-31, 11] [name-23, 12] [name-32, 12] [name-24, 13] [name-33, 13] [name-14, 14] [name-34, 14] [name-14, 15] [name-14, 16] [name-14, 17] ``` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] kimmking commented on issue #4597: fix #4565 for distinct bug
kimmking commented on issue #4597: fix #4565 for distinct bug URL: https://github.com/apache/incubator-shardingsphere/pull/4597#issuecomment-594439444 ``` = >Case5: distinct with groupby&orderby other columns > [INFO ] 2020-03-04 17:39:02,517 --main-- [ShardingSphere-SQL] Rule Type: sharding [INFO ] 2020-03-04 17:39:02,517 --main-- [ShardingSphere-SQL] Logic SQL: select distinct age from user group by name order by id [INFO ] 2020-03-04 17:39:02,517 --main-- [ShardingSphere-SQL] SQLStatement: SelectStatementContext(super=CommonSQLStatementContext(sqlStatement=org.apache.shardingsphere.sql.parser.sql.statement.dml.SelectStatement@1436a7ab, tablesContext=org.apache.shardingsphere.sql.parser.relation.segment.table.TablesContext@3b7b05a8), tablesContext=org.apache.shardingsphere.sql.parser.relation.segment.table.TablesContext@3b7b05a8, projectionsContext=ProjectionsContext(startIndex=16, stopIndex=18, distinctRow=true, projections=[ColumnProjection(owner=null, name=age, alias=Optional.empty), DerivedProjection(expression=name, alias=Optional[GROUP_BY_DERIVED_0]), DerivedProjection(expression=id, alias=Optional[ORDER_BY_DERIVED_0])], columnLabels=[age]), groupByContext=org.apache.shardingsphere.sql.parser.relation.segment.select.groupby.GroupByContext@3d36dff4, orderByContext=org.apache.shardingsphere.sql.parser.relation.segment.select.orderby.OrderByContext@7abe27bf, paginationContext=org.apache.shardingsphere.sql.parser.relation.segment.select.pagination.PaginationContext@5b94ccbc, containsSubquery=false) [INFO ] 2020-03-04 17:39:02,518 --main-- [ShardingSphere-SQL] Actual SQL: ds_0 ::: select distinct age , name AS GROUP_BY_DERIVED_0 , id AS ORDER_BY_DERIVED_0 from user0 group by name order by id [INFO ] 2020-03-04 17:39:02,518 --main-- [ShardingSphere-SQL] Actual SQL: ds_0 ::: select distinct age , name AS GROUP_BY_DERIVED_0 , id AS ORDER_BY_DERIVED_0 from user1 group by name order by id [INFO ] 2020-03-04 17:39:02,518 --main-- [ShardingSphere-SQL] Actual SQL: ds_0 ::: select distinct age , name AS GROUP_BY_DERIVED_0 , id AS ORDER_BY_DERIVED_0 from user2 group by name order by id [INFO ] 2020-03-04 17:39:02,518 --main-- [ShardingSphere-SQL] Actual SQL: ds_1 ::: select distinct age , name AS GROUP_BY_DERIVED_0 , id AS ORDER_BY_DERIVED_0 from user0 group by name order by id [INFO ] 2020-03-04 17:39:02,518 --main-- [ShardingSphere-SQL] Actual SQL: ds_1 ::: select distinct age , name AS GROUP_BY_DERIVED_0 , id AS ORDER_BY_DERIVED_0 from user1 group by name order by id [INFO ] 2020-03-04 17:39:02,518 --main-- [ShardingSphere-SQL] Actual SQL: ds_1 ::: select distinct age , name AS GROUP_BY_DERIVED_0 , id AS ORDER_BY_DERIVED_0 from user2 group by name order by id [11] [11] [11] [15] [11] [11] [12] [13] [11] [12] [13] [14] ``` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] KomachiSion opened a new pull request #4598: Refactor TestDecodingPlugin
KomachiSion opened a new pull request #4598: Refactor TestDecodingPlugin URL: https://github.com/apache/incubator-shardingsphere/pull/4598 For #4510 . This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] codecov-io commented on issue #4598: Refactor TestDecodingPlugin
codecov-io commented on issue #4598: Refactor TestDecodingPlugin URL: https://github.com/apache/incubator-shardingsphere/pull/4598#issuecomment-594462717 # [Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4598?src=pr&el=h1) Report > Merging [#4598](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4598?src=pr&el=desc) into [sharding-scaling](https://codecov.io/gh/apache/incubator-shardingsphere/commit/914f4c6dbb39298a4e9d232d1331ff765b1bf5be?src=pr&el=desc) will **increase** coverage by `0.05%`. > The diff coverage is `40.62%`. [](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4598?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## sharding-scaling#4598 +/- ## == + Coverage56.1% 56.15% +0.05% - Complexity394 398 +4 == Files1085 1085 Lines 2093020925 -5 Branches 3831 3832 +1 == + Hits1174211750 +8 + Misses 8444 8427 -17 - Partials 744 748 +4 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4598?src=pr&el=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...ling/postgresql/wal/decode/TestDecodingPlugin.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4598/diff?src=pr&el=tree#diff-c2hhcmRpbmctc2NhbGluZy9zaGFyZGluZy1zY2FsaW5nLXBvc3RncmVzcWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NoYXJkaW5nc2NhbGluZy9wb3N0Z3Jlc3FsL3dhbC9kZWNvZGUvVGVzdERlY29kaW5nUGx1Z2luLmphdmE=) | `71.55% <40.62%> (+9.56%)` | `31 <3> (+4)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4598?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4598?src=pr&el=footer). Last update [914f4c6...900920c](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4598?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] coveralls commented on issue #4598: Refactor TestDecodingPlugin
coveralls commented on issue #4598: Refactor TestDecodingPlugin URL: https://github.com/apache/incubator-shardingsphere/pull/4598#issuecomment-594466842 ## Pull Request Test Coverage Report for [Build 10018](https://coveralls.io/builds/29121747) * **20** of **32** **(62.5%)** changed or added relevant lines in **1** file are covered. * **1** unchanged line in **1** file lost coverage. * Overall coverage increased (+**0.07%**) to **59.785%** --- | Changes Missing Coverage | Covered Lines | Changed/Added Lines | % | | :-|--||---: | | [sharding-scaling/sharding-scaling-postgresql/src/main/java/org/apache/shardingsphere/shardingscaling/postgresql/wal/decode/TestDecodingPlugin.java](https://coveralls.io/builds/29121747/source?filename=sharding-scaling%2Fsharding-scaling-postgresql%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingscaling%2Fpostgresql%2Fwal%2Fdecode%2FTestDecodingPlugin.java#L49) | 20 | 32 | 62.5% | Files with Coverage Reduction | New Missed Lines | % | | :-|--|--: | | [sharding-scaling/sharding-scaling-postgresql/src/main/java/org/apache/shardingsphere/shardingscaling/postgresql/wal/decode/TestDecodingPlugin.java](https://coveralls.io/builds/29121747/source?filename=sharding-scaling%2Fsharding-scaling-postgresql%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingscaling%2Fpostgresql%2Fwal%2Fdecode%2FTestDecodingPlugin.java#L211) | 1 | 82.76% | | Totals | [](https://coveralls.io/builds/29121747) | | :-- | --: | | Change from base [Build 10012](https://coveralls.io/builds/29120238): | 0.07% | | Covered Lines: | 12510 | | Relevant Lines: | 20925 | --- # 💛 - [Coveralls](https://coveralls.io) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] coveralls edited a comment on issue #4598: Refactor TestDecodingPlugin
coveralls edited a comment on issue #4598: Refactor TestDecodingPlugin URL: https://github.com/apache/incubator-shardingsphere/pull/4598#issuecomment-594466842 ## Pull Request Test Coverage Report for [Build 1979](https://coveralls.io/builds/29121761) * **20** of **32** **(62.5%)** changed or added relevant lines in **1** file are covered. * **3** unchanged lines in **2** files lost coverage. * Overall coverage increased (+**0.1%**) to **59.828%** --- | Changes Missing Coverage | Covered Lines | Changed/Added Lines | % | | :-|--||---: | | [sharding-scaling/sharding-scaling-postgresql/src/main/java/org/apache/shardingsphere/shardingscaling/postgresql/wal/decode/TestDecodingPlugin.java](https://coveralls.io/builds/29121761/source?filename=sharding-scaling%2Fsharding-scaling-postgresql%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingscaling%2Fpostgresql%2Fwal%2Fdecode%2FTestDecodingPlugin.java#L49) | 20 | 32 | 62.5% | Files with Coverage Reduction | New Missed Lines | % | | :-|--|--: | | [sharding-scaling/sharding-scaling-postgresql/src/main/java/org/apache/shardingsphere/shardingscaling/postgresql/wal/decode/TestDecodingPlugin.java](https://coveralls.io/builds/29121761/source?filename=sharding-scaling%2Fsharding-scaling-postgresql%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingscaling%2Fpostgresql%2Fwal%2Fdecode%2FTestDecodingPlugin.java#L211) | 1 | 82.76% | | [sharding-orchestration/sharding-orchestration-core/src/main/java/org/apache/shardingsphere/orchestration/internal/util/IpUtils.java](https://coveralls.io/builds/29121761/source?filename=sharding-orchestration%2Fsharding-orchestration-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Forchestration%2Finternal%2Futil%2FIpUtils.java#L72) | 2 | 80.0% | | Totals | [](https://coveralls.io/builds/29121761) | | :-- | --: | | Change from base [Build 10012](https://coveralls.io/builds/29120238): | 0.1% | | Covered Lines: | 12519 | | Relevant Lines: | 20925 | --- # 💛 - [Coveralls](https://coveralls.io) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] menghaoranss opened a new pull request #4599: add unit tests for zookeeper orchestration center
menghaoranss opened a new pull request #4599: add unit tests for zookeeper orchestration center URL: https://github.com/apache/incubator-shardingsphere/pull/4599 For #4439 Changes proposed in this pull request: - add zookeeper unit tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] icuxika commented on issue #4575: no viable alternative at input 'user_idinteger'
icuxika commented on issue #4575: no viable alternative at input 'user_idinteger' URL: https://github.com/apache/incubator-shardingsphere/issues/4575#issuecomment-594483614 > maybe input incorrect. **I created a new project for the problem.** [https://github.com/icuxika/sharding-demo.git](url) ## MySQL version 8.0.17 ## Console log `Hibernate: create table t_address (address_id bigint not null, address_name varchar(255), primary key (address_id)) engine=InnoDB Hibernate: create table t_order (order_id bigint not null auto_increment, address_id bigint, status varchar(255), user_id integer, primary key (order_id)) engine=InnoDB **line 1:111 no viable alternative at input 'user_idinteger'** Hibernate: create table t_order_item (order_item_id bigint not null auto_increment, order_id bigint, status varchar(255), user_id integer, primary key (order_item_id)) engine=InnoDB **line 1:119 no viable alternative at input 'user_idinteger'** Hibernate: create table t_user (user_id bigint not null auto_increment, assisted_query_pwd varchar(255), pwd varchar(255), user_name varchar(255), user_name_plain varchar(255), primary key (user_id)) engine=InnoDB` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] EdwardWangYan opened a new issue #4600: shardingsphere 3.1.0.M1 sharding: props: sql.show: true 配置失效 在3.0.0 有用
EdwardWangYan opened a new issue #4600: shardingsphere 3.1.0.M1 sharding: props: sql.show: true 配置失效 在3.0.0 有用 URL: https://github.com/apache/incubator-shardingsphere/issues/4600 ## Bug Report **For English only**, other languages will not accept. Before report a bug, make sure you have: - Searched open and closed [GitHub issues](https://github.com/apache/incubator-shardingsphere/issues). - Read documentation: [ShardingSphere Doc](https://shardingsphere.apache.org/document/current/en/overview). Please pay attention on issues you submitted, because we maybe need more details. If no response **more than 7 days** and we cannot reproduce it on current information, we will **close it**. Please answer these questions before submitting your issue. Thanks! ### Which version of ShardingSphere did you use? ### Which project did you use? Sharding-JDBC or Sharding-Proxy? ### Expected behavior ### Actual behavior ### Reason analyze (If you can) ### Steps to reproduce the behavior, such as: SQL to execute, sharding rule configuration, when exception occur etc. ### Example codes for reproduce this issue (such as a github link). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] EdwardWangYan commented on issue #4600: Shardingsphere 3.1.0.m1: sharding.props. Sql.show =true configuration is invalid but useful in 3.0.0
EdwardWangYan commented on issue #4600: Shardingsphere 3.1.0.m1: sharding.props. Sql.show =true configuration is invalid but useful in 3.0.0 URL: https://github.com/apache/incubator-shardingsphere/issues/4600#issuecomment-594488537 Print SQL invalid on 3.1.0.m1 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] coveralls commented on issue #4599: add unit tests for zookeeper orchestration center
coveralls commented on issue #4599: add unit tests for zookeeper orchestration center URL: https://github.com/apache/incubator-shardingsphere/pull/4599#issuecomment-594491431 ## Pull Request Test Coverage Report for [Build 10019](https://coveralls.io/builds/29123031) * **0** of **0** changed or added relevant lines in **0** files are covered. * **3** unchanged lines in **1** file lost coverage. * Overall coverage increased (+**0.2%**) to **58.021%** --- | Files with Coverage Reduction | New Missed Lines | % | | :-|--|--: | | [sharding-orchestration/sharding-orchestration-core/src/main/java/org/apache/shardingsphere/orchestration/internal/util/IpUtils.java](https://coveralls.io/builds/29123031/source?filename=sharding-orchestration%2Fsharding-orchestration-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Forchestration%2Finternal%2Futil%2FIpUtils.java#L63) | 3 | 76.0% | | Totals | [](https://coveralls.io/builds/29123031) | | :-- | --: | | Change from base [Build 982](https://coveralls.io/builds/29120789): | 0.2% | | Covered Lines: | 10435 | | Relevant Lines: | 17985 | --- # 💛 - [Coveralls](https://coveralls.io) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] rohithbalaji123 opened a new pull request #4601: Replace mocks with instances in Unit Tests #4540
rohithbalaji123 opened a new pull request #4601: Replace mocks with instances
in Unit Tests #4540
URL: https://github.com/apache/incubator-shardingsphere/pull/4601
Fixes #4540.
The test cases rewritten are as follows:
- [x] ProjectionEngineTest
- [x] ProjectionsContextEngineTest
- [x] GroupByContextEngineTest
- [x] OrderByContextEngineTest
- [x] PaginationContextTest
- [x] PaginationContextEngineTest
- [x] RowNumberPaginationContextEngineTest
- [x] TopPaginationContextEngineTest
- [ ] SQLStatementContextFactoryTest
- [x] SelectStatementContextTest
Further Comments
- There is one reference in `SQLStatementContextFactoryTest` which mocks an
interface. I couldn't find a suitable implementation to replace it with. There
are few `TCL` type concerete classes implementing to `SQLStatement`, but it
looks too out of place to be included in the particular test case. So, I am
leaving the mock for it as such.
- Few assert conditions in
`GroupByContextEngineTest.assertCreateGroupByContextWithGroupBy` and
`OrderByContextEngineTest.assertCreateOrderByWithOrderBy` seemed redundant as a
previous assert condition verifying the list of items returned, already asserts
the matching of the indexes.
- Apart from the above two variations, everything else are straight-forward
changes.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu merged pull request #4598: Refactor TestDecodingPlugin
terrymanu merged pull request #4598: Refactor TestDecodingPlugin URL: https://github.com/apache/incubator-shardingsphere/pull/4598 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu closed issue #4230: Has error when use orchestration and mybatis-plus with springboot
terrymanu closed issue #4230: Has error when use orchestration and mybatis-plus with springboot URL: https://github.com/apache/incubator-shardingsphere/issues/4230 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu merged pull request #4590: Fix failed to configure DataSource when use springboot + orchestration
terrymanu merged pull request #4590: Fix failed to configure DataSource when use springboot + orchestration URL: https://github.com/apache/incubator-shardingsphere/pull/4590 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu commented on a change in pull request #4599: add unit tests for zookeeper orchestration center
terrymanu commented on a change in pull request #4599: add unit tests for
zookeeper orchestration center
URL:
https://github.com/apache/incubator-shardingsphere/pull/4599#discussion_r387768510
##
File path:
sharding-orchestration/sharding-orchestration-center/sharding-orchestration-center-zookeeper-curator/src/test/java/org/apache/shardingsphere/orchestration/center/instance/CuratorZookeeperInstanceTest.java
##
@@ -67,4 +83,114 @@ public void assertGetChildrenKeys() {
List childrenKeys =
curatorZookeeperInstance.getChildrenKeys("/test/children");
assertThat(childrenKeys.size(), is(3));
}
+
+@Test
+@SneakyThrows
+public void assertWatchUpdatedChangedType() {
+curatorZookeeperInstance.persist("/test/children/1", "value1");
+final SettableFuture future =
SettableFuture.create();
+curatorZookeeperInstance.watch("/test/children", dataChangedEvent ->
future.set(dataChangedEvent));
+curatorZookeeperInstance.persist("/test/children/1", "value2");
+DataChangedEvent dataChangedEvent = future.get(5, TimeUnit.SECONDS);
+assertNotNull(dataChangedEvent);
+assertThat(dataChangedEvent.getChangedType(),
is(DataChangedEvent.ChangedType.UPDATED));
+assertThat(dataChangedEvent.getKey(), is("/test/children/1"));
+assertThat(dataChangedEvent.getValue(), is("value2"));
+assertThat(curatorZookeeperInstance.get("/test/children/1"),
is("value2"));
+}
+
+@Test
+@SneakyThrows
+public void assertWatchDeletedChangedType() {
+curatorZookeeperInstance.persist("/test/children/5", "value5");
+final SettableFuture future =
SettableFuture.create();
+curatorZookeeperInstance.watch("/test/children/5", dataChangedEvent ->
future.set(dataChangedEvent));
+client.delete().forPath("/test/children/5");
+DataChangedEvent dataChangedEvent = future.get(5, TimeUnit.SECONDS);
+assertNotNull(dataChangedEvent);
+assertThat(dataChangedEvent.getChangedType(),
is(DataChangedEvent.ChangedType.DELETED));
+assertThat(dataChangedEvent.getKey(), is("/test/children/5"));
+assertThat(dataChangedEvent.getValue(), is("value5"));
+}
+
+@Test
+@SneakyThrows
+public void assertWatchAddedChangedType() {
+curatorZookeeperInstance.persist("/test/children/4", "value4");
+final AtomicReference actualDataChangedEvent = new
AtomicReference<>();
+curatorZookeeperInstance.watch("/test/children", dataChangedEvent ->
actualDataChangedEvent.set(dataChangedEvent));
+Thread.sleep(2000);
Review comment:
Please add `L` is the number is long type
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu commented on a change in pull request #4599: add unit tests for zookeeper orchestration center
terrymanu commented on a change in pull request #4599: add unit tests for
zookeeper orchestration center
URL:
https://github.com/apache/incubator-shardingsphere/pull/4599#discussion_r387766862
##
File path:
sharding-orchestration/sharding-orchestration-center/sharding-orchestration-center-zookeeper-curator/src/test/java/org/apache/shardingsphere/orchestration/center/instance/CuratorZookeeperInstanceTest.java
##
@@ -17,28 +17,44 @@
package org.apache.shardingsphere.orchestration.center.instance;
+import com.google.common.util.concurrent.SettableFuture;
+import lombok.SneakyThrows;
+import org.apache.curator.framework.CuratorFramework;
+import org.apache.curator.framework.CuratorFrameworkFactory;
+import org.apache.curator.retry.ExponentialBackoffRetry;
import
org.apache.shardingsphere.orchestration.center.configuration.InstanceConfiguration;
+import
org.apache.shardingsphere.orchestration.center.listener.DataChangedEvent;
import org.apache.shardingsphere.orchestration.center.util.EmbedTestingServer;
import org.junit.BeforeClass;
import org.junit.Test;
import java.util.List;
import java.util.Properties;
+import java.util.concurrent.TimeUnit;
+import java.util.concurrent.atomic.AtomicReference;
import static org.hamcrest.CoreMatchers.is;
+import static org.junit.Assert.assertNull;
+import static org.junit.Assert.assertNotNull;
import static org.junit.Assert.assertThat;
public class CuratorZookeeperInstanceTest {
Review comment:
Please add final if the class is not for extend
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu commented on a change in pull request #4599: add unit tests for zookeeper orchestration center
terrymanu commented on a change in pull request #4599: add unit tests for
zookeeper orchestration center
URL:
https://github.com/apache/incubator-shardingsphere/pull/4599#discussion_r387768015
##
File path:
sharding-orchestration/sharding-orchestration-center/sharding-orchestration-center-zookeeper-curator/src/test/java/org/apache/shardingsphere/orchestration/center/instance/CuratorZookeeperInstanceTest.java
##
@@ -67,4 +83,114 @@ public void assertGetChildrenKeys() {
List childrenKeys =
curatorZookeeperInstance.getChildrenKeys("/test/children");
assertThat(childrenKeys.size(), is(3));
}
+
+@Test
+@SneakyThrows
+public void assertWatchUpdatedChangedType() {
+curatorZookeeperInstance.persist("/test/children/1", "value1");
+final SettableFuture future =
SettableFuture.create();
+curatorZookeeperInstance.watch("/test/children", dataChangedEvent ->
future.set(dataChangedEvent));
+curatorZookeeperInstance.persist("/test/children/1", "value2");
+DataChangedEvent dataChangedEvent = future.get(5, TimeUnit.SECONDS);
+assertNotNull(dataChangedEvent);
+assertThat(dataChangedEvent.getChangedType(),
is(DataChangedEvent.ChangedType.UPDATED));
+assertThat(dataChangedEvent.getKey(), is("/test/children/1"));
+assertThat(dataChangedEvent.getValue(), is("value2"));
+assertThat(curatorZookeeperInstance.get("/test/children/1"),
is("value2"));
+}
+
+@Test
+@SneakyThrows
+public void assertWatchDeletedChangedType() {
+curatorZookeeperInstance.persist("/test/children/5", "value5");
+final SettableFuture future =
SettableFuture.create();
+curatorZookeeperInstance.watch("/test/children/5", dataChangedEvent ->
future.set(dataChangedEvent));
+client.delete().forPath("/test/children/5");
+DataChangedEvent dataChangedEvent = future.get(5, TimeUnit.SECONDS);
+assertNotNull(dataChangedEvent);
+assertThat(dataChangedEvent.getChangedType(),
is(DataChangedEvent.ChangedType.DELETED));
+assertThat(dataChangedEvent.getKey(), is("/test/children/5"));
+assertThat(dataChangedEvent.getValue(), is("value5"));
+}
+
+@Test
+@SneakyThrows
Review comment:
Just throw exception from method signature, @SneakyThrows should use only in
the situation for exception never occur
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu commented on issue #4600: Shardingsphere 3.1.0.m1: sharding.props. Sql.show =true configuration is invalid but useful in 3.0.0
terrymanu commented on issue #4600: Shardingsphere 3.1.0.m1: sharding.props. Sql.show =true configuration is invalid but useful in 3.0.0 URL: https://github.com/apache/incubator-shardingsphere/issues/4600#issuecomment-594632707 The version is out of service. Can you try to version 4.0.0? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu closed issue #4479: Insert speed is very slow
terrymanu closed issue #4479: Insert speed is very slow URL: https://github.com/apache/incubator-shardingsphere/issues/4479 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu closed issue #4447: insert operation ok but select operation return null point exception
terrymanu closed issue #4447: insert operation ok but select operation return null point exception URL: https://github.com/apache/incubator-shardingsphere/issues/4447 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] coveralls commented on issue #4601: Replace mocks with instances in Unit Tests
coveralls commented on issue #4601: Replace mocks with instances in Unit Tests URL: https://github.com/apache/incubator-shardingsphere/pull/4601#issuecomment-594650928 ## Pull Request Test Coverage Report for [Build 10021](https://coveralls.io/builds/29129242) * **0** of **0** changed or added relevant lines in **0** files are covered. * **6** unchanged lines in **3** files lost coverage. * Overall coverage increased (+**0.01%**) to **57.82%** --- | Files with Coverage Reduction | New Missed Lines | % | | :-|--|--: | | [shardingsphere-sql-parser/shardingsphere-sql-parser-relation/src/main/java/org/apache/shardingsphere/sql/parser/relation/statement/dml/SelectStatementContext.java](https://coveralls.io/builds/29129242/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-relation%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Frelation%2Fstatement%2Fdml%2FSelectStatementContext.java#L169) | 1 | 57.73% | | [sharding-spring/sharding-jdbc-orchestration-spring/sharding-jdbc-orchestration-spring-boot-starter/src/main/java/org/apache/shardingsphere/shardingjdbc/orchestration/spring/boot/OrchestrationSpringBootConfiguration.java](https://coveralls.io/builds/29129242/source?filename=sharding-spring%2Fsharding-jdbc-orchestration-spring%2Fsharding-jdbc-orchestration-spring-boot-starter%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingjdbc%2Forchestration%2Fspring%2Fboot%2FOrchestrationSpringBootConfiguration.java#L191) | 2 | 95.35% | | [sharding-orchestration/sharding-orchestration-core/src/main/java/org/apache/shardingsphere/orchestration/internal/util/IpUtils.java](https://coveralls.io/builds/29129242/source?filename=sharding-orchestration%2Fsharding-orchestration-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Forchestration%2Finternal%2Futil%2FIpUtils.java#L63) | 3 | 76.0% | | Totals | [](https://coveralls.io/builds/29129242) | | :-- | --: | | Change from base [Build 982](https://coveralls.io/builds/29120789): | 0.01% | | Covered Lines: | 10399 | | Relevant Lines: | 17985 | --- # 💛 - [Coveralls](https://coveralls.io) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[incubator-shardingsphere-benchmark] branch master updated: for performance
This is an automated email from the ASF dual-hosted git repository.
zhangyonglun pushed a commit to branch master
in repository
https://gitbox.apache.org/repos/asf/incubator-shardingsphere-benchmark.git
The following commit(s) were added to refs/heads/master by this push:
new 3fcb6a5 for performance
3fcb6a5 is described below
commit 3fcb6a5a80c5405670ef56b9527937091288c6bc
Author: tuohai666
AuthorDate: Thu Mar 5 08:55:26 2020 +0800
for performance
---
report/jtl_json/full_route_test.json| 2 +-
report/jtl_json/master_slave_encrypt_sharding_test.json | 2 +-
report/jtl_json/master_slave_test.json | 2 +-
report/jtl_json/single_route_test.json | 2 +-
4 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/report/jtl_json/full_route_test.json
b/report/jtl_json/full_route_test.json
index d05e73f..3675062 100644
--- a/report/jtl_json/full_route_test.json
+++ b/report/jtl_json/full_route_test.json
@@ -1 +1 @@
-{"SELECT": [{"data": [{"99.9th": "9", "Err": "0.0%", "95th": "2", "50th": "1",
"Max": "10", "Min": "0", "Throughout": "23036.87", "Samples": 4999, "Date":
"2019.12.19 02:35:57 ", "Avg": "0"}, {"99.9th": "9", "Err": "0.0%", "95th":
"2", "50th": "1", "Max": "9", "Min": "0", "Throughout": "22619.91", "Samples":
4999, "Date": "2019.12.20 13:34:47 ", "Avg": "0"}, {"99.9th": "9", "Err":
"0.0%", "95th": "2", "50th": "1", "Max": "9", "Min": "0", "Throughout":
"22931.19", "Samples": 4999, "Date": [...]
\ No newline at end of file
+{"SELECT": [{"data": [{"99.9th": "9", "Err": "0.0%", "95th": "2", "50th": "1",
"Max": "10", "Min": "0", "Throughout": "23036.87", "Samples": 4999, "Date":
"2019.12.19 02:35:57 ", "Avg": "0"}, {"99.9th": "9", "Err": "0.0%", "95th":
"2", "50th": "1", "Max": "9", "Min": "0", "Throughout": "22619.91", "Samples":
4999, "Date": "2019.12.20 13:34:47 ", "Avg": "0"}, {"99.9th": "9", "Err":
"0.0%", "95th": "2", "50th": "1", "Max": "9", "Min": "0", "Throughout":
"22931.19", "Samples": 4999, "Date": [...]
\ No newline at end of file
diff --git a/report/jtl_json/master_slave_encrypt_sharding_test.json
b/report/jtl_json/master_slave_encrypt_sharding_test.json
index e80b5de..6369a34 100644
--- a/report/jtl_json/master_slave_encrypt_sharding_test.json
+++ b/report/jtl_json/master_slave_encrypt_sharding_test.json
@@ -1 +1 @@
-{"SELECT": [{"data": [{"99.9th": "16", "Err": "0.0%", "95th": "3", "50th":
"2", "Max": "66", "Min": "1", "Throughout": "9381.73", "Samples": 99,
"Date": "2019.12.19 02:40:33 ", "Avg": "2"}, {"99.9th": "16", "Err": "0.0%",
"95th": "3", "50th": "2", "Max": "62", "Min": "1", "Throughout": "9038.48",
"Samples": 99, "Date": "2019.12.20 13:39:23 ", "Avg": "2"}, {"99.9th":
"16", "Err": "0.0%", "95th": "3", "50th": "2", "Max": "63", "Min": "1",
"Throughout": "9071.44", "Samples": 99, [...]
\ No newline at end of file
+{"SELECT": [{"data": [{"99.9th": "16", "Err": "0.0%", "95th": "3", "50th":
"2", "Max": "66", "Min": "1", "Throughout": "9381.73", "Samples": 99,
"Date": "2019.12.19 02:40:33 ", "Avg": "2"}, {"99.9th": "16", "Err": "0.0%",
"95th": "3", "50th": "2", "Max": "62", "Min": "1", "Throughout": "9038.48",
"Samples": 99, "Date": "2019.12.20 13:39:23 ", "Avg": "2"}, {"99.9th":
"16", "Err": "0.0%", "95th": "3", "50th": "2", "Max": "63", "Min": "1",
"Throughout": "9071.44", "Samples": 99, [...]
\ No newline at end of file
diff --git a/report/jtl_json/master_slave_test.json
b/report/jtl_json/master_slave_test.json
index bf0b092..5fb753a 100644
--- a/report/jtl_json/master_slave_test.json
+++ b/report/jtl_json/master_slave_test.json
@@ -1 +1 @@
-{"INSERT+SELECT+DELETE": [{"data": [], "type": "Sharding-Proxy_3.1"}, {"data":
[{"99.9th": "38", "Err": "0.0%", "95th": "16", "50th": "11", "Max": "48",
"Min": "7", "Throughout": "1720.96", "Samples": 29709, "Date": "2020.01.01
02:49:45 ", "Avg": "11"}, {"99.9th": "27", "Err": "0.0%", "95th": "16", "50th":
"11", "Max": "37", "Min": "7", "Throughout": "1701.38", "Samples": 17218,
"Date": "2020.01.02 02:49:52 ", "Avg": "11"}, {"99.9th": "30", "Err": "0.0%",
"95th": "16", "50th": "11", "Max [...]
\ No newline at end of file
+{"INSERT+SELECT+DELETE": [{"data": [], "type": "Sharding-Proxy_3.1"}, {"data":
[{"99.9th": "38", "Err": "0.0%", "95th": "16", "50th": "11", "Max": "48",
"Min": "7", "Throughout": "1720.96", "Samples": 29709, "Date": "2020.01.01
02:49:45 ", "Avg": "11"}, {"99.9th": "27", "Err": "0.0%", "95th": "16", "50th":
"11", "Max": "37", "Min": "7", "Throughout": "1701.38", "Samples": 17218,
"Date": "2020.01.02 02:49:52 ", "Avg": "11"}, {"99.9th": "30", "Err": "0.0%",
"95th": "16", "50th": "11", "Max [...]
\ No newline at end of file
diff --git a/report/jtl_json/single_route_test.json
b/report/jtl_json/single_route_test.json
index 5ff27d0..0e5a2eb 100644
--- a/report/jtl_json/single_route_test.json
+++ b/report/jtl_json/single_route_test.json
@@ -1 +1 @@
-{"SELECT": [{"data": [], "type": "Sharding-Proxy_3
[GitHub] [incubator-shardingsphere] KomachiSion closed issue #4510: Preparing to merge sharding-scaling branch into master branch
KomachiSion closed issue #4510: Preparing to merge sharding-scaling branch into master branch URL: https://github.com/apache/incubator-shardingsphere/issues/4510 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] nevereverever commented on issue #4565: distinct returns wrong result
nevereverever commented on issue #4565: distinct returns wrong result URL: https://github.com/apache/incubator-shardingsphere/issues/4565#issuecomment-594973561 Oh, I see what you're saying. This bug will be fixed in 5.0.0? @kimmking This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] nevereverever opened a new issue #4602: I suggest that sharding-proxy supports appoint divided items by "create table"
nevereverever opened a new issue #4602: I suggest that sharding-proxy supports appoint divided items by "create table" URL: https://github.com/apache/incubator-shardingsphere/issues/4602 version:4.0.0 such as ```sql create table test ( a int, b int, c char(20)) shardkey=a,shardingType=standard,shardingClass=xxx.xxx.xxx; ``` Will be a bright future. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] menghaoranss commented on a change in pull request #4599: add unit tests for zookeeper orchestration center
menghaoranss commented on a change in pull request #4599: add unit tests for
zookeeper orchestration center
URL:
https://github.com/apache/incubator-shardingsphere/pull/4599#discussion_r388048216
##
File path:
sharding-orchestration/sharding-orchestration-center/sharding-orchestration-center-zookeeper-curator/src/test/java/org/apache/shardingsphere/orchestration/center/instance/CuratorZookeeperInstanceTest.java
##
@@ -67,4 +83,114 @@ public void assertGetChildrenKeys() {
List childrenKeys =
curatorZookeeperInstance.getChildrenKeys("/test/children");
assertThat(childrenKeys.size(), is(3));
}
+
+@Test
+@SneakyThrows
+public void assertWatchUpdatedChangedType() {
+curatorZookeeperInstance.persist("/test/children/1", "value1");
+final SettableFuture future =
SettableFuture.create();
+curatorZookeeperInstance.watch("/test/children", dataChangedEvent ->
future.set(dataChangedEvent));
+curatorZookeeperInstance.persist("/test/children/1", "value2");
+DataChangedEvent dataChangedEvent = future.get(5, TimeUnit.SECONDS);
+assertNotNull(dataChangedEvent);
+assertThat(dataChangedEvent.getChangedType(),
is(DataChangedEvent.ChangedType.UPDATED));
+assertThat(dataChangedEvent.getKey(), is("/test/children/1"));
+assertThat(dataChangedEvent.getValue(), is("value2"));
+assertThat(curatorZookeeperInstance.get("/test/children/1"),
is("value2"));
+}
+
+@Test
+@SneakyThrows
+public void assertWatchDeletedChangedType() {
+curatorZookeeperInstance.persist("/test/children/5", "value5");
+final SettableFuture future =
SettableFuture.create();
+curatorZookeeperInstance.watch("/test/children/5", dataChangedEvent ->
future.set(dataChangedEvent));
+client.delete().forPath("/test/children/5");
+DataChangedEvent dataChangedEvent = future.get(5, TimeUnit.SECONDS);
+assertNotNull(dataChangedEvent);
+assertThat(dataChangedEvent.getChangedType(),
is(DataChangedEvent.ChangedType.DELETED));
+assertThat(dataChangedEvent.getKey(), is("/test/children/5"));
+assertThat(dataChangedEvent.getValue(), is("value5"));
+}
+
+@Test
+@SneakyThrows
+public void assertWatchAddedChangedType() {
+curatorZookeeperInstance.persist("/test/children/4", "value4");
+final AtomicReference actualDataChangedEvent = new
AtomicReference<>();
+curatorZookeeperInstance.watch("/test/children", dataChangedEvent ->
actualDataChangedEvent.set(dataChangedEvent));
+Thread.sleep(2000);
Review comment:
I will pay more attention next time.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu commented on issue #4601: Replace mocks with instances in Unit Tests
terrymanu commented on issue #4601: Replace mocks with instances in Unit Tests URL: https://github.com/apache/incubator-shardingsphere/pull/4601#issuecomment-594999203 Wonderful pull request, thank you very much. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu merged pull request #4601: Replace mocks with instances in Unit Tests
terrymanu merged pull request #4601: Replace mocks with instances in Unit Tests URL: https://github.com/apache/incubator-shardingsphere/pull/4601 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu closed issue #4540: Do not use mock on regular test cases
terrymanu closed issue #4540: Do not use mock on regular test cases URL: https://github.com/apache/incubator-shardingsphere/issues/4540 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] cherrylzhao opened a new pull request #4603: add branch name explain for release guide.
cherrylzhao opened a new pull request #4603: add branch name explain for
release guide.
URL: https://github.com/apache/incubator-shardingsphere/pull/4603
add this comment ` ${name} is the properly branch, e.g. master, dev-4.x`
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] rohithbalaji123 commented on issue #4540: Do not use mock on regular test cases
rohithbalaji123 commented on issue #4540: Do not use mock on regular test cases URL: https://github.com/apache/incubator-shardingsphere/issues/4540#issuecomment-595007585 @terrymanu , I have quite got the grasp of parser module while working on this issue. Please do assign me if anything pops up related to it or any other module. I'll keep a tab on the issues page as well. Thanks! This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] codecov-io commented on issue #4603: add branch name explain for release guide.
codecov-io commented on issue #4603: add branch name explain for release guide. URL: https://github.com/apache/incubator-shardingsphere/pull/4603#issuecomment-595008971 # [Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4603?src=pr&el=h1) Report > Merging [#4603](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4603?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-shardingsphere/commit/b87a85e88a88bc4e3e46c44ea45281e00ac6383f?src=pr&el=desc) will **not change** coverage. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4603?src=pr&el=tree) ```diff @@Coverage Diff@@ ## master#4603 +/- ## = Coverage 54.27% 54.27% Complexity 343 343 = Files 1001 1001 Lines 1798517985 Branches 3372 3372 = Hits 9761 9761 + Misses 7601 7598-3 - Partials623 626+3 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4603?src=pr&el=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...relation/statement/dml/SelectStatementContext.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4603/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLXJlbGF0aW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9zcWwvcGFyc2VyL3JlbGF0aW9uL3N0YXRlbWVudC9kbWwvU2VsZWN0U3RhdGVtZW50Q29udGV4dC5qYXZh) | `51.54% <0%> (-2.07%)` | `0% <0%> (ø)` | | | [...re/sql/parser/relation/metadata/RelationMetas.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4603/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLXJlbGF0aW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9zcWwvcGFyc2VyL3JlbGF0aW9uL21ldGFkYXRhL1JlbGF0aW9uTWV0YXMuamF2YQ==) | `0% <0%> (ø)` | `0% <0%> (ø)` | :arrow_down: | | [.../select/projection/impl/AggregationProjection.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4603/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLXJlbGF0aW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9zcWwvcGFyc2VyL3JlbGF0aW9uL3NlZ21lbnQvc2VsZWN0L3Byb2plY3Rpb24vaW1wbC9BZ2dyZWdhdGlvblByb2plY3Rpb24uamF2YQ==) | `100% <0%> (+66.66%)` | `0% <0%> (ø)` | :arrow_down: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4603?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4603?src=pr&el=footer). Last update [b87a85e...97e9ae9](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4603?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] ssxlulu commented on issue #4596: Keyword of SQL should be uppercase in the code
ssxlulu commented on issue #4596: Keyword of SQL should be uppercase in the code URL: https://github.com/apache/incubator-shardingsphere/issues/4596#issuecomment-595009069 Please assign me. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] coveralls commented on issue #4603: add branch name explain for release guide.
coveralls commented on issue #4603: add branch name explain for release guide. URL: https://github.com/apache/incubator-shardingsphere/pull/4603#issuecomment-595009826 ## Pull Request Test Coverage Report for [Build 10026](https://coveralls.io/builds/29141400) * **0** of **0** changed or added relevant lines in **0** files are covered. * No unchanged relevant lines lost coverage. * Overall coverage remained the same at **57.82%** --- | Totals | [](https://coveralls.io/builds/29141400) | | :-- | --: | | Change from base [Build 10025](https://coveralls.io/builds/29141192): | 0.0% | | Covered Lines: | 10399 | | Relevant Lines: | 17985 | --- # 💛 - [Coveralls](https://coveralls.io) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] dalong316 opened a new issue #4604: Too many tables loaded slowly
dalong316 opened a new issue #4604: Too many tables loaded slowly
URL: https://github.com/apache/incubator-shardingsphere/issues/4604
At present, I have more than 3000 sub tables. It takes too long to load
sharding at the start of the project. I have set the consistency check metadata
to "false" and it takes effect, but the time is still very long. I have located
the code part that takes a long time
private Map loadDefaultTables(final ShardingRule
shardingRule) throws SQLException {
Map result = new
HashMap<>(shardingRule.getTableRules().size(), 1);
Optional actualDefaultDataSourceName =
shardingRule.findActualDefaultDataSourceName();
if (actualDefaultDataSourceName.isPresent()) {
for (String each :
getAllTableNames(actualDefaultDataSourceName.get())) {
result.put(each, tableMetaDataLoader.load(each,
shardingRule));
}
}
return result;
}
tableMetaDataLoader.load(each, shardingRule)
*This part is the main reason
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] coveralls edited a comment on issue #4603: add branch name explain for release guide.
coveralls edited a comment on issue #4603: add branch name explain for release guide. URL: https://github.com/apache/incubator-shardingsphere/pull/4603#issuecomment-595009826 ## Pull Request Test Coverage Report for [Build 1982](https://coveralls.io/builds/29141811) * **0** of **0** changed or added relevant lines in **0** files are covered. * **2** unchanged lines in **1** file lost coverage. * Overall coverage increased (+**0.006%**) to **57.826%** --- | Files with Coverage Reduction | New Missed Lines | % | | :-|--|--: | | [sharding-orchestration/sharding-orchestration-core/src/main/java/org/apache/shardingsphere/orchestration/internal/util/IpUtils.java](https://coveralls.io/builds/29141811/source?filename=sharding-orchestration%2Fsharding-orchestration-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Forchestration%2Finternal%2Futil%2FIpUtils.java#L72) | 2 | 80.0% | | Totals | [](https://coveralls.io/builds/29141811) | | :-- | --: | | Change from base [Build 10025](https://coveralls.io/builds/29141192): | 0.006% | | Covered Lines: | 10400 | | Relevant Lines: | 17985 | --- # 💛 - [Coveralls](https://coveralls.io) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] KomachiSion opened a new pull request #4605: Merge sharding-scaling-ui into master branch
KomachiSion opened a new pull request #4605: Merge sharding-scaling-ui into master branch URL: https://github.com/apache/incubator-shardingsphere/pull/4605 Changes proposed in this pull request: - Add sharding-scaling page in shardingsphere-ui This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] KomachiSion opened a new pull request #4606: Merge sharding-scaling branch into master branch
KomachiSion opened a new pull request #4606: Merge sharding-scaling branch into master branch URL: https://github.com/apache/incubator-shardingsphere/pull/4606 Fixes #ISSUSE_ID. Changes proposed in this pull request: - Add sharding scaling feature into master branch This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu merged pull request #4606: Merge sharding-scaling branch into master branch
terrymanu merged pull request #4606: Merge sharding-scaling branch into master branch URL: https://github.com/apache/incubator-shardingsphere/pull/4606 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] kimmking commented on issue #4574: fix issue#4573
kimmking commented on issue #4574: fix issue#4573 URL: https://github.com/apache/incubator-shardingsphere/pull/4574#issuecomment-595020621 Closed it util an investigation completed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] kimmking closed pull request #4574: fix issue#4573
kimmking closed pull request #4574: fix issue#4573 URL: https://github.com/apache/incubator-shardingsphere/pull/4574 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] codecov-io commented on issue #4605: Merge sharding-scaling-ui into master branch
codecov-io commented on issue #4605: Merge sharding-scaling-ui into master branch URL: https://github.com/apache/incubator-shardingsphere/pull/4605#issuecomment-595021000 # [Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4605?src=pr&el=h1) Report > Merging [#4605](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4605?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-shardingsphere/commit/b87a85e88a88bc4e3e46c44ea45281e00ac6383f?src=pr&el=desc) will **not change** coverage. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4605?src=pr&el=tree) ```diff @@Coverage Diff@@ ## master#4605 +/- ## = Coverage 54.27% 54.27% Complexity 343 343 = Files 1001 1001 Lines 1798517985 Branches 3372 3372 = Hits 9761 9761 + Misses 7601 7598-3 - Partials623 626+3 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4605?src=pr&el=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...relation/statement/dml/SelectStatementContext.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4605/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLXJlbGF0aW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9zcWwvcGFyc2VyL3JlbGF0aW9uL3N0YXRlbWVudC9kbWwvU2VsZWN0U3RhdGVtZW50Q29udGV4dC5qYXZh) | `51.54% <0%> (-2.07%)` | `0% <0%> (ø)` | | | [...re/sql/parser/relation/metadata/RelationMetas.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4605/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLXJlbGF0aW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9zcWwvcGFyc2VyL3JlbGF0aW9uL21ldGFkYXRhL1JlbGF0aW9uTWV0YXMuamF2YQ==) | `0% <0%> (ø)` | `0% <0%> (ø)` | :arrow_down: | | [.../select/projection/impl/AggregationProjection.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4605/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLXJlbGF0aW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9zcWwvcGFyc2VyL3JlbGF0aW9uL3NlZ21lbnQvc2VsZWN0L3Byb2plY3Rpb24vaW1wbC9BZ2dyZWdhdGlvblByb2plY3Rpb24uamF2YQ==) | `100% <0%> (+66.66%)` | `0% <0%> (ø)` | :arrow_down: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4605?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4605?src=pr&el=footer). Last update [b87a85e...32564f6](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4605?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] coveralls commented on issue #4605: Merge sharding-scaling-ui into master branch
coveralls commented on issue #4605: Merge sharding-scaling-ui into master branch URL: https://github.com/apache/incubator-shardingsphere/pull/4605#issuecomment-595021904 ## Pull Request Test Coverage Report for [Build 10027](https://coveralls.io/builds/29142405) * **0** of **0** changed or added relevant lines in **0** files are covered. * No unchanged relevant lines lost coverage. * Overall coverage remained the same at **57.82%** --- | Totals | [](https://coveralls.io/builds/29142405) | | :-- | --: | | Change from base [Build 10025](https://coveralls.io/builds/29141192): | 0.0% | | Covered Lines: | 10399 | | Relevant Lines: | 17985 | --- # 💛 - [Coveralls](https://coveralls.io) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu merged pull request #4605: Merge sharding-scaling-ui into master branch
terrymanu merged pull request #4605: Merge sharding-scaling-ui into master branch URL: https://github.com/apache/incubator-shardingsphere/pull/4605 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] coveralls edited a comment on issue #4605: Merge sharding-scaling-ui into master branch
coveralls edited a comment on issue #4605: Merge sharding-scaling-ui into master branch URL: https://github.com/apache/incubator-shardingsphere/pull/4605#issuecomment-595021904 ## Pull Request Test Coverage Report for [Build 1983](https://coveralls.io/builds/29142756) * **0** of **0** changed or added relevant lines in **0** files are covered. * **2** unchanged lines in **1** file lost coverage. * Overall coverage increased (+**1.3%**) to **59.098%** --- | Files with Coverage Reduction | New Missed Lines | % | | :-|--|--: | | [sharding-orchestration/sharding-orchestration-core/src/main/java/org/apache/shardingsphere/orchestration/internal/util/IpUtils.java](https://coveralls.io/builds/29142756/source?filename=sharding-orchestration%2Fsharding-orchestration-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Forchestration%2Finternal%2Futil%2FIpUtils.java#L72) | 2 | 80.0% | | Totals | [](https://coveralls.io/builds/29142756) | | :-- | --: | | Change from base [Build 10025](https://coveralls.io/builds/29141192): | 1.3% | | Covered Lines: | 12075 | | Relevant Lines: | 20432 | --- # 💛 - [Coveralls](https://coveralls.io) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] lengyul commented on issue #4580: shardingsphere: Regarding routing to multiple data nodes, when querying with aggregate functions (count, max, avg ...), how to dea
lengyul commented on issue #4580: shardingsphere: Regarding routing to multiple
data nodes, when querying with aggregate functions (count, max, avg ...), how
to deal with the total statistics of multiple tables?
URL:
https://github.com/apache/incubator-shardingsphere/issues/4580#issuecomment-595028784
> Group query/aggregation is supported by ShardingSphere.
>
> In version 4.x, you can config precise algorithm for between statements.
>
> > We need to discuss this pull request:
> >
> > 1. For standard sharding strategy, user need config precise algorithm
(for =, IN) and range algorithm (for BETWEEN AND, <, >, >=, <=). If range
algorithm absent, the SQL contains BETWEEN should query all data nodes. That is
correct, because user know they do not config range algorithm explicitly;
> > 2. For inline sharding strategy, user only can config precise algorithm
via inline expression, and cannot config range algorithm. So throw exception
when SQL contains BETWEEN may better than query all data nodes. If query all
data nodes instead of explicit exception, user may missing the potential
performance issue.
>
> In version 5.x of master branch(not release yet), you can directly config
the follow parameter in server.yaml to allow between statement query in inline
sharding.
>
> > allow.range.query.with.inline.sharding: true
Ok thank you, the problem has been solved.
I use version 4.0.0 Implements the doSharding method provided by
RangeShardingAlgorithm.class.
However, some minor problems were found during use (not affecting my use),
the following
1. ROUND(AVG(column)，2) With function nesting，When routing multiple data
nodes for queries, the results (multiple results) of the respective tables are
returned instead of a total stat.
--
2.The SQL [order by $ {param}] param written by mybatis's mapper.xml is not
recognized, the specific error message is: bad SQL grammar []; nested exception
is java.sql.SQLException: No value specified for parameter x
Thanks again
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] kimmking commented on a change in pull request #4603: add branch name explain for release guide.
kimmking commented on a change in pull request #4603: add branch name explain
for release guide.
URL:
https://github.com/apache/incubator-shardingsphere/pull/4603#discussion_r388078571
##
File path: docs/community/content/contribute/release.cn.md
##
@@ -135,7 +135,8 @@
https://github.com/apache/incubator-shardingsphere/blob/master/RELEASE-NOTES.md
创建`${RELEASE.VERSION}-release`分支，接下来的操作都在该分支进行。
```shell
-git clone -b ${branch} https://github.com/apache/incubator-shardingsphere.git
~/incubator-shardingsphere
+## ${name}为源码所在分支，如：master，dev-4.x
+git clone --branch ${name}
https://github.com/apache/incubator-shardingsphere.git
~/incubator-shardingsphere
Review comment:
should add --depth=1?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] tristaZero opened a new issue #4607: Update download links
tristaZero opened a new issue #4607: Update download links URL: https://github.com/apache/incubator-shardingsphere/issues/4607 As `https://www.apache.org/dist/` has been deprecated, we need to update our website as well. - [ ] Update all URLs containing `https://www.apache.org/dist/` with `https://downloads.apache.org` - [ ] Check whether all updated ULRs run well. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] geomonlin commented on issue #4607: Update download links
geomonlin commented on issue #4607: Update download links URL: https://github.com/apache/incubator-shardingsphere/issues/4607#issuecomment-595032467 I'm interested This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] tristaZero opened a new issue #4608: Refactoring `ColumnProjectionSegment`
tristaZero opened a new issue #4608: Refactoring `ColumnProjectionSegment` URL: https://github.com/apache/incubator-shardingsphere/issues/4608 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
