[GitHub] [incubator-shardingsphere] kimmking commented on issue #4707: proxy-4.0.1 return error varchar in use hibernate.
kimmking commented on issue #4707: proxy-4.0.1 return error varchar in use hibernate. URL: https://github.com/apache/incubator-shardingsphere/issues/4707#issuecomment-597468300 The above infomation is not enough for profiling this issue. Can you make a simple demo to reproduce it? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] wangjing112 commented on issue #4707: proxy-4.0.1 return error varchar in use hibernate.
wangjing112 commented on issue #4707: proxy-4.0.1 return error varchar in use hibernate. URL: https://github.com/apache/incubator-shardingsphere/issues/4707#issuecomment-597463002 same 3 times querys from mysql return: query1 table 1: [{"chapterId":1,"gold":0,"id":36030446286411906,"openData":"[{\"id\":1,\"lv\":0}]","overData":"[]","roleId":36030446286411906,"status":0},{"chapterId":101,"gold":0,"id":36030446286411906,"openData":"[{\"id\":10101,\"lv\":0}]","overData":"[]","roleId":36030446286411906,"status":0},{"chapterId":102,"gold":0,"id":36030446286411906,"openData":"[{\"id\":10201,\"lv\":0}]","overData":"[]","roleId":36030446286411906,"status":0}] query2 table 2: [{"extData":"","id":36030446286411906,"packetData":"[{\"id\":10001,\"no\":1,\"st\":1,\"talent\":{\"groups\":[{\"args\":[],\"id\":101},{\"args\":[],\"id\":201},{\"args\":[],\"id\":301}]}},{\"id\":10002,\"no\":2,\"st\":1,\"talent\":{\"groups\":[{\"args\":[],\"id\":101},{\"args\":[],\"id\":202},{\"args\":[],\"id\":301}]}},{\"id\":10003,\"no\":3,\"st\":1,\"talent\":{\"groups\":[{\"args\":[],\"id\":102},{\"args\":[],\"id\":201},{\"args\":[],\"id\":302}]}},{\"id\":10006,\"no\":4,\"st\":1,\"talent\":{\"groups\":[{\"args\":[],\"id\":101},{\"args\":[],\"id\":201},{\"args\":[],\"id\":301}]}},{\"id\":10007,\"no\":5,\"st\":1,\"talent\":{\"groups\":[{\"args\":[],\"id\":101},{\"args\":[],\"id\":201},{\"args\":[],\"id\":301}]}},{\"id\":10008,\"no\":6,\"st\":1,\"talent\":{\"groups\":[{\"args\":[],\"id\":101},{\"args\":[],\"id\":201},{\"args\":[],\"id\":301}]}},{\"id\":10009,\"no\":7,\"st\":1,\"talent\":{\"groups\":[{\"args\":[],\"id\":101},{\"args\":[],\"id\":201},{\"args\":[],\"id\":301}]}},{\"id\":10014,\"no\":8,\"st\":1,\"talent\":{\"groups\":[{\"args\":[],\"id\":101},{\"args\":[],\"id\":201},{\"args\":[],\"id\":301}]}},{\"id\":10015,\"no\":9,\"st\":1,\"talent\":{\"groups\":[{\"args\":[],\"id\":101},{\"args\":[],\"id\":201},{\"args\":[],\"id\":301}]}},{\"id\":10016,\"no\":10,\"st\":1,\"talent\":{\"groups\":[{\"args\":[],\"id\":101},{\"args\":[],\"id\":201},{\"args\":[],\"id\":301}]}},{\"id\":10017,\"no\":11,\"st\":1,\"talent\":{\"groups\":[{\"args\":[],\"id\":101},{\"args\":[],\"id\":201},{\"args\":[],\"id\":301}]}},{\"id\":10018,\"no\":12,\"st\":1,\"talent\":{\"groups\":[{\"args\":[],\"id\":101},{\"args\":[],\"id\":201},{\"args\":[],\"id\":301}]}},{\"id\":10019,\"no\":13,\"st\":1,\"talent\":{\"groups\":[{\"args\":[],\"id\":101},{\"args\":[],\"id\":201},{\"args\":[],\"id\":301}]}},{\"id\":20001,\"no\":14,\"st\":1,\"talent\":{\"groups\":[{\"args\":[],\"id\":101},{\"args\":[],\"id\":201},{\"args\":[],\"id\":301}]}},{\"id\":20002,\"no\":15,\"st\":1,\"talent\":{\"groups\":[{\"args\":[],\"id\":101},{\"args\":[],\"id\":201},{\"args\":[],\"id\":301}]}},{\"id\":20003,\"no\":16,\"st\":1,\"talent\":{\"groups\":[{\"args\":[],\"id\":101},{\"args\":[],\"id\":201},{\"args\":[],\"id\":301}]}},{\"id\":20004,\"no\":17,\"st\":1,\"talent\":{\"groups\":[{\"args\":[],\"id\":101},{\"args\":[],\"id\":201},{\"args\":[],\"id\":301}]}},{\"id\":20005,\"no\":18,\"st\":1,\"talent\":{\"groups\":[{\"args\":[],\"id\":101},{\"args\":[],\"id\":201},{\"args\":[],\"id\":301}]}},{\"id\":20006,\"no\":19,\"st\":1,\"talent\":{\"groups\":[{\"args\":[],\"id\":101},{\"args\":[],\"id\":201},{\"args\":[],\"id\":301}]}},{\"id\":20007,\"no\":20,\"st\":1,\"talent\":{\"groups\":[{\"args\":[],\"id\":101},{\"args\":[],\"id\":201},{\"args\":[],\"id\":301}]}},{\"id\":20008,\"no\":21,\"st\":1,\"talent\":{\"groups\":[{\"args\":[],\"id\":101},{\"args\":[],\"id\":201},{\"args\":[],\"id\":301}]}},{\"id\":20009,\"no\":22,\"st\":1,\"talent\":{\"groups\":[{\"args\":[],\"id\":101},{\"args\":[],\"id\":201},{\"args\":[],\"id\":301}]}},{\"id\":20010,\"no\":23,\"st\":1,\"talent\":{\"groups\":[{\"args\":[],\"id\":101},{\"args\":[],\"id\":201},{\"args\":[],\"id\":301}]}},{\"id\":20011,\"no\":24,\"st\":1,\"talent\":{\"groups\":[{\"args\":[],\"id\":101},{\"args\":[],\"id\":201},{\"args\":[],\"id\":301}]}},{\"id\":20012,\"no\":25,\"st\":1,\"talent\":{\"groups\":[{\"args\":[],\"id\":101},{\"args\":[],\"id\":201},{\"args\":[],\"id\":301}]}},{\"id\":20013,\"no\":26,\"st\":1,\"talent\":{\"groups\":[{\"args\":[],\"id\":101},{\"args\":[],\"id\":201},{\"args\":[],\"id\":301}]}}]","roleId":36030446286411906,"size":0,"type":0},{"extData":"","id":36030446286411906,"packetData":"[{\"c\":10,\"i\":100},{\"c\":10,\"i\":101}]","roleId":36030446286411906,"size":0,"type":1},{"extData":"","id":36030446286411906,"packetData":"[{\"a\":\"2:2|4:4|3:2|5:2\",\"c\":1,\"i\":20001,\"ma\":\"1:1\",\"no\":1,\"set\":3},{\"a\":\"3:4|5:2|1:4|4:2\",\"c\":1,\"i\":20002,\"ma\":\"1:2\",\"no\":2,\"set\":3},{\"a\":\"1:3|2:4|3:2|4:2\",\"c\":1,\"i\":20003,\"ma\":\"1:3\",\"no\":3,\"set\":2},{\"a\":\"3:4|1:3|4:2|2:2\",\"c\":1,\"i\":20004,\"ma\":\"1:4\",\"no\":4,\"set\":1},{\"a\":\"1:3|4:3|5:2|3:3\",\"c\":1,\"i\":20005,\"ma\":\"1:5\",\"no\":5,\"set\":3},{\"a\":\"1:2|2:4|3:4|4:3\",\"c\":1,\"i\":20006,\"ma\":\"1:6\",\"no\":6,\"set\":1}]","roleI
[GitHub] [incubator-shardingsphere] wangjing112 opened a new issue #4707: proxy-4.0.1 return error varchar in use hibernate.
wangjing112 opened a new issue #4707: proxy-4.0.1 return error varchar in use hibernate. URL: https://github.com/apache/incubator-shardingsphere/issues/4707 sharding-proxy-4.0.1 when use hibernate query from 2 table1 like: ![image](https://user-images.githubusercontent.com/51982240/76387529-26800f80-63a2-11ea-9d2d-d53ffae1f26f.png) then 3 times querys from proxy return: query1 table1 [{"chapterId":1,"dailyData":"","gold":285212672,"id":36030446286411906,"openData":"{\"id\":1,\"lv\":0}]\u0002[]\u\u\u\u\u.1.65.103:61108\u^Β\u0001\u\u\u\u^Β\u0001\u\u\u\u�\u0003\u\u\u\u\u\u\u\u\u\u\u\u\u\u\u\u\u\u\u\u\u\u\u\u\u\u\u\u\u\u\u\u\u","overData":"","roleId":36030446286411906,"status":0},{"chapterId":101,"dailyData":"","gold":352321536,"id":36030446286411906,"openData":"{\"id\":10101,\"lv\":0}]\u0002[]\u\u\u\u\u5.103:61108\u^Β\u0001\u\u\u\u^Β\u0001\u\u\u\u�\u0003\u\u\u\u\u\u\u\u\u\u\u\u\u\u\u\u\u\u\u\u\u\u\u\u\u\u\u\u\u\u\u\u\u","overData":"","roleId":36030446286411906,"status":0},{"chapterId":102,"dailyData":"","gold":352321536,"id":36030446286411906,"openData":"{\"id\":10201,\"lv\":0}]\u0002[]\u\u\u\u\u5.103:61108\u^Β\u0001\u\u\u\u^Β\u0001\u\u\u\u�\u0003\u\u\u\u\u\u\u\u\u\u\u\u\u\u\u\u\u\u\u\u\u\u\u\u\u\u\u\u\u\u\u\u\u","overData":"","roleId":36030446286411906,"status":0}] query2 table2 [{"extData":"","id":36030446286411906,"packetData":"[{\"id\":10001,\"no\":1,\"st\":1,\"talent\":{\"groups\":[{\"args\":[],\"id\":101},{\"args\":[],\"id\":201},{\"args\":[],\"id\":301}]}},{\"id\":10002,\"no\":2,\"st\":1,\"talent\":{\"groups\":[{\"args\":[],\"id\":101},{\"args\":[],\"id\":202},{\"args\":[],\"id\":301}]}},{\"id\":10003,\"no\":3,\"st\":1,\"talent\":{\"groups\":[{\"args\":[],\"id\":102},{\"args\":[],\"id\":201},{\"args\":[],\"id\":302}]}},{\"id\":10006,\"no\":4,\"st\":1,\"talent\":{\"groups\":[{\"args\":[],\"id\":101},{\"args\":[],\"id\":201},{\"args\":[],\"id\":301}]}},{\"id\":10007,\"no\":5,\"st\":1,\"talent\":{\"groups\":[{\"args\":[],\"id\":101},{\"args\":[],\"id\":201},{\"args\":[],\"id\":301}]}},{\"id\":10008,\"no\":6,\"st\":1,\"talent\":{\"groups\":[{\"args\":[],\"id\":101},{\"args\":[],\"id\":201},{\"args\":[],\"id\":301}]}},{\"id\":10009,\"no\":7,\"st\":1,\"talent\":{\"groups\":[{\"args\":[],\"id\":101},{\"args\":[],\"id\":201},{\"args\":[],\"id\":301}]}},{\"id\":10014,\"no\":8,\"st\":1,\"talent\":{\"groups\":[{\"args\":[],\"id\":101},{\"args\":[],\"id\":201},{\"args\":[],\"id\":301}]}},{\"id\":10015,\"no\":9,\"st\":1,\"talent\":{\"groups\":[{\"args\":[],\"id\":101},{\"args\":[],\"id\":201},{\"args\":[],\"id\":301}]}},{\"id\":10016,\"no\":10,\"st\":1,\"talent\":{\"groups\":[{\"args\":[],\"id\":101},{\"args\":[],\"id\":201},{\"args\":[],\"id\":301}]}},{\"id\":10017,\"no\":11,\"st\":1,\"talent\":{\"groups\":[{\"args\":[],\"id\":101},{\"args\":[],\"id\":201},{\"args\":[],\"id\":301}]}},{\"id\":10018,\"no\":12,\"st\":1,\"talent\":{\"groups\":[{\"args\":[],\"id\":101},{\"args\":[],\"id\":201},{\"args\":[],\"id\":301}]}},{\"id\":10019,\"no\":13,\"st\":1,\"talent\":{\"groups\":[{\"args\":[],\"id\":101},{\"args\":[],\"id\":201},{\"args\":[],\"id\":301}]}},{\"id\":20001,\"no\":14,\"st\":1,\"talent\":{\"groups\":[{\"args\":[],\"id\":101},{\"args\":[],\"id\":201},{\"args\":[],\"id\":301}]}},{\"id\":20002,\"no\":15,\"st\":1,\"talent\":{\"groups\":[{\"args\":[],\"id\":101},{\"args\":[],\"id\":201},{\"args\":[],\"id\":301}]}},{\"id\":20003,\"no\":16,\"st\":1,\"talent\":{\"groups\":[{\"args\":[],\"id\":101},{\"args\":[],\"id\":201},{\"args\":[],\"id\":301}]}},{\"id\":20004,\"no\":17,\"st\":1,\"talent\":{\"groups\":[{\"args\":[],\"id\":101},{\"args\":[],\"id\":201},{\"args\":[],\"id\":301}]}},{\"id\":20005,\"no\":18,\"st\":1,\"talent\":{\"groups\":[{\"args\":[],\"id\":101},{\"args\":[],\"id\":201},{\"args\":[],\"id\":301}]}},{\"id\":20006,\"no\":19,\"st\":1,\"talent\":{\"groups\":[{\"args\":[],\"id\":101},{\"args\":[],\"id\":201},{\"args\":[],\"id\":301}]}},{\"id\":20007,\"no\":20,\"st\":1,\"talent\":{\"groups\":[{\"args\":[],\"id\":101},{\"args\":[],\"id\":201},{\"args\":[],\"id\":301}]}},{\"id\":20008,\"no\":21,\"st\":1,\"talent\":{\"groups\":[{\"args\":[],\"id\":101},{\"args\":[],\"id\":201},{\"args\":[],\"id\":301}]}},{\"id\":20009,\"no\":22,\"st\":1,\"talent\":{\"groups\":[{\"args\":[],\"id\":101},{\"args\":[],\"id\":201},{\"args\":[],\"id\":301}]}},{\"id\":20010,\"no\":23,\"st\":1,\"talent\":{\"groups\":[{\"args\":[],\"id\":101}
[GitHub] [incubator-shardingsphere] KomachiSion commented on issue #4698: In version 4.0.1, hintmanager.setdatabaseshardingvalue cannot be used. When will this problem be fixed
KomachiSion commented on issue #4698: In version 4.0.1, hintmanager.setdatabaseshardingvalue cannot be used. When will this problem be fixed URL: https://github.com/apache/incubator-shardingsphere/issues/4698#issuecomment-597451672 I think the problem is duplicated with #3964 . This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] coveralls commented on issue #4706: remove runtime-config.properties
coveralls commented on issue #4706: remove runtime-config.properties URL: https://github.com/apache/incubator-shardingsphere/pull/4706#issuecomment-597451295 ## Pull Request Test Coverage Report for [Build 2065](https://coveralls.io/builds/29267196) * **0** of **0** changed or added relevant lines in **0** files are covered. * No unchanged relevant lines lost coverage. * Overall coverage increased (+**0.07%**) to **59.101%** --- | Totals | [![Coverage Status](https://coveralls.io/builds/29267196/badge)](https://coveralls.io/builds/29267196) | | :-- | --: | | Change from base [Build 1045](https://coveralls.io/builds/29267158): | 0.07% | | Covered Lines: | 12160 | | Relevant Lines: | 20575 | --- # 💛 - [Coveralls](https://coveralls.io) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] cherrylzhao merged pull request #4706: remove runtime-config.properties
cherrylzhao merged pull request #4706: remove runtime-config.properties URL: https://github.com/apache/incubator-shardingsphere/pull/4706 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu opened a new pull request #4706: remove runtime-config.properties
terrymanu opened a new pull request #4706: remove runtime-config.properties URL: https://github.com/apache/incubator-shardingsphere/pull/4706 For #4426. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] tristaZero merged pull request #4704: #4482 Correct the DataTypeName for Oracle.
tristaZero merged pull request #4704: #4482 Correct the DataTypeName for Oracle. URL: https://github.com/apache/incubator-shardingsphere/pull/4704 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] tristaZero commented on issue #4704: #4482 Correct the DataTypeName for Oracle.
tristaZero commented on issue #4704: #4482 Correct the DataTypeName for Oracle. URL: https://github.com/apache/incubator-shardingsphere/pull/4704#issuecomment-597444311 @yuzel Good job. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] coveralls commented on issue #4704: #4482 Correct the DataTypeName for Oracle.
coveralls commented on issue #4704: #4482 Correct the DataTypeName for Oracle. URL: https://github.com/apache/incubator-shardingsphere/pull/4704#issuecomment-597443789 ## Pull Request Test Coverage Report for [Build 10171](https://coveralls.io/builds/29266892) * **0** of **0** changed or added relevant lines in **0** files are covered. * **18** unchanged lines in **3** files lost coverage. * Overall coverage decreased (**-0.08%**) to **59.023%** --- | Files with Coverage Reduction | New Missed Lines | % | | :-|--|--: | | [sharding-orchestration/sharding-orchestration-core/src/main/java/org/apache/shardingsphere/orchestration/internal/util/IpUtils.java](https://coveralls.io/builds/29266892/source?filename=sharding-orchestration%2Fsharding-orchestration-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Forchestration%2Finternal%2Futil%2FIpUtils.java#L63) | 3 | 76.0% | | [sharding-scaling/sharding-scaling-core/src/main/java/org/apache/shardingsphere/shardingscaling/core/synctask/history/HistoryDataSyncTask.java](https://coveralls.io/builds/29266892/source?filename=sharding-scaling%2Fsharding-scaling-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingscaling%2Fcore%2Fsynctask%2Fhistory%2FHistoryDataSyncTask.java#L116) | 7 | 76.47% | | [sharding-scaling/sharding-scaling-core/src/main/java/org/apache/shardingsphere/shardingscaling/core/execute/executor/channel/MemoryChannel.java](https://coveralls.io/builds/29266892/source?filename=sharding-scaling%2Fsharding-scaling-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingscaling%2Fcore%2Fexecute%2Fexecutor%2Fchannel%2FMemoryChannel.java#L61) | 8 | 51.85% | | Totals | [![Coverage Status](https://coveralls.io/builds/29266892/badge)](https://coveralls.io/builds/29266892) | | :-- | --: | | Change from base [Build 1043](https://coveralls.io/builds/29264643): | -0.08% | | Covered Lines: | 12144 | | Relevant Lines: | 20575 | --- # 💛 - [Coveralls](https://coveralls.io) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] tristaZero edited a comment on issue #3967: More parsed integrated tests are needed.
tristaZero edited a comment on issue #3967: More parsed integrated tests are needed. URL: https://github.com/apache/incubator-shardingsphere/issues/3967#issuecomment-597442882 A new idea came to mind, so this one is closed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] tristaZero commented on issue #3967: More parsed integrated tests are needed.
tristaZero commented on issue #3967: More parsed integrated tests are needed. URL: https://github.com/apache/incubator-shardingsphere/issues/3967#issuecomment-597442882 A new idea came to mind, so closed this one. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] codecov-io commented on issue #4704: #4482 Correct the DataTypeName for Oracle.
codecov-io commented on issue #4704: #4482 Correct the DataTypeName for Oracle. URL: https://github.com/apache/incubator-shardingsphere/pull/4704#issuecomment-597442800 # [Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4704?src=pr&el=h1) Report > Merging [#4704](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4704?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-shardingsphere/commit/5daaca24e0dd714d810551a31541335fbdfb71fe?src=pr&el=desc) will **increase** coverage by `0.02%`. > The diff coverage is `n/a`. [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4704/graphs/tree.svg?width=650&token=ZvlXpWa7so&height=150&src=pr)](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4704?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master#4704 +/- ## + Coverage 55.43% 55.46% +0.02% Complexity 426 426 Files 1136 1133 -3 Lines 2062420575 -49 Branches 3827 3819 -8 - Hits 1143211411 -21 + Misses 8470 8443 -27 + Partials722 721 -1 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4704?src=pr&el=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...c/jdbc/core/statement/ShadowPreparedStatement.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4704/diff?src=pr&el=tree#diff-c2hhcmRpbmctamRiYy9zaGFyZGluZy1qZGJjLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NoYXJkaW5namRiYy9qZGJjL2NvcmUvc3RhdGVtZW50L1NoYWRvd1ByZXBhcmVkU3RhdGVtZW50LmphdmE=) | `40.9% <0%> (-3.54%)` | `0% <0%> (ø)` | | | [...dingjdbc/jdbc/core/statement/EncryptStatement.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4704/diff?src=pr&el=tree#diff-c2hhcmRpbmctamRiYy9zaGFyZGluZy1qZGJjLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NoYXJkaW5namRiYy9qZGJjL2NvcmUvc3RhdGVtZW50L0VuY3J5cHRTdGF0ZW1lbnQuamF2YQ==) | `59.75% <0%> (-3.17%)` | `0% <0%> (ø)` | | | [...rdingjdbc/jdbc/core/statement/ShadowStatement.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4704/diff?src=pr&el=tree#diff-c2hhcmRpbmctamRiYy9zaGFyZGluZy1qZGJjLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NoYXJkaW5namRiYy9qZGJjL2NvcmUvc3RhdGVtZW50L1NoYWRvd1N0YXRlbWVudC5qYXZh) | `64.17% <0%> (-2.95%)` | `0% <0%> (ø)` | | | [.../jdbc/core/statement/EncryptPreparedStatement.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4704/diff?src=pr&el=tree#diff-c2hhcmRpbmctamRiYy9zaGFyZGluZy1qZGJjLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NoYXJkaW5namRiYy9qZGJjL2NvcmUvc3RhdGVtZW50L0VuY3J5cHRQcmVwYXJlZFN0YXRlbWVudC5qYXZh) | `79.8% <0%> (-1.28%)` | `0% <0%> (ø)` | | | [...impl/EncryptPredicateRightValueTokenGenerator.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4704/diff?src=pr&el=tree#diff-ZW5jcnlwdC1jb3JlL2VuY3J5cHQtY29yZS1yZXdyaXRlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9lbmNyeXB0L3Jld3JpdGUvdG9rZW4vZ2VuZXJhdG9yL2ltcGwvRW5jcnlwdFByZWRpY2F0ZVJpZ2h0VmFsdWVUb2tlbkdlbmVyYXRvci5qYXZh) | `93.33% <0%> (ø)` | `1% <0%> (ø)` | :arrow_down: | | [...ication/jdbc/wrapper/StatementExecutorWrapper.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4704/diff?src=pr&el=tree#diff-c2hhcmRpbmctcHJveHkvc2hhcmRpbmctcHJveHktYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc2hhcmRpbmdwcm94eS9iYWNrZW5kL2NvbW11bmljYXRpb24vamRiYy93cmFwcGVyL1N0YXRlbWVudEV4ZWN1dG9yV3JhcHBlci5qYXZh) | `1.61% <0%> (ø)` | `0% <0%> (ø)` | :arrow_down: | | [...ewrite/sql/token/generator/SQLTokenGenerators.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4704/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtdW5kZXJseWluZy9zaGFyZGluZ3NwaGVyZS1yZXdyaXRlL3NoYXJkaW5nc3BoZXJlLXJld3JpdGUtZW5naW5lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS91bmRlcmx5aW5nL3Jld3JpdGUvc3FsL3Rva2VuL2dlbmVyYXRvci9TUUxUb2tlbkdlbmVyYXRvcnMuamF2YQ==) | `21.87% <0%> (ø)` | `0% <0%> (ø)` | :arrow_down: | | [...tion/center/instance/CuratorZookeeperInstance.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4704/diff?src=pr&el=tree#diff-c2hhcmRpbmctb3JjaGVzdHJhdGlvbi9zaGFyZGluZy1vcmNoZXN0cmF0aW9uLWNlbnRlci9zaGFyZGluZy1vcmNoZXN0cmF0aW9uLWNlbnRlci16b29rZWVwZXItY3VyYXRvci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvb3JjaGVzdHJhdGlvbi9jZW50ZXIvaW5zdGFuY2UvQ3VyYXRvclpvb2tlZXBlckluc3RhbmNlLmphdmE=) | | | | | [...rlying/common/metadata/ShardingSphereMetaData.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4704/diff?src=pr&el=tree#diff-c2hhcmRpb
[GitHub] [incubator-shardingsphere] tristaZero closed issue #3967: More parsed integrated tests are needed.
tristaZero closed issue #3967: More parsed integrated tests are needed. URL: https://github.com/apache/incubator-shardingsphere/issues/3967 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] KomachiSion commented on issue #4698: In version 4.0.1, hintmanager.setdatabaseshardingvalue cannot be used. When will this problem be fixed
KomachiSion commented on issue #4698: In version 4.0.1, hintmanager.setdatabaseshardingvalue cannot be used. When will this problem be fixed URL: https://github.com/apache/incubator-shardingsphere/issues/4698#issuecomment-597440206 @joinhappy81 please provide more information like configuration, SQLs, table structure. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu merged pull request #4705: modify for orchestration refactoring
terrymanu merged pull request #4705: modify for orchestration refactoring URL: https://github.com/apache/incubator-shardingsphere/pull/4705 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] kimmking opened a new pull request #4705: modify for orchestration refactoring
kimmking opened a new pull request #4705: modify for orchestration refactoring URL: https://github.com/apache/incubator-shardingsphere/pull/4705 Changes proposed in this pull request: - modify for orchestration refactoring This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] yuzel opened a new pull request #4704: #4482 Correct the DataTypeName for Oracle.
yuzel opened a new pull request #4704: #4482 Correct the DataTypeName for Oracle. URL: https://github.com/apache/incubator-shardingsphere/pull/4704 ref #4482 Reference link - [dataType](https://docs.oracle.com/en/database/oracle/oracle-database/20/lnpls/plsql-data-types.html#GUID-239A89A6-4CBC-46F5-8A6A-10E8B465B7E8) - [plsql-predefined-data-types](https://docs.oracle.com/en/database/oracle/oracle-database/20/lnpls/plsql-predefined-data-types.html#GUID-1D28B7B6-15AE-454A-8134-F8724551AE8B) - [createType](https://docs.oracle.com/en/database/oracle/oracle-database/20/sqlrf/CREATE-TYPE.html#GUID-F9CE0CC3-13AE-4744-A43C-EAC7A71AAAB6) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] fantacy2001 commented on issue #4619: only sharding db, use pagehelper, report error: Must have sharding column with subquery
fantacy2001 commented on issue #4619: only sharding db, use pagehelper, report error: Must have sharding column with subquery URL: https://github.com/apache/incubator-shardingsphere/issues/4619#issuecomment-597432805 > We are doing the subquery now, so I just pending this issue after we finish the subquery. pagehelper use subquery , when i upgrade to 4.0.0-release, the exception not have reported This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] odyssey1816 opened a new issue #4703: OrchestrationShardingDataSource LOGIC_SCHEMA_NAME issue
odyssey1816 opened a new issue #4703: OrchestrationShardingDataSource LOGIC_SCHEMA_NAME issue URL: https://github.com/apache/incubator-shardingsphere/issues/4703 English description: When OrchestrationShardingDataSource is initialized, why did I go to zookeeper via ShardingConstant.LOGIC_SCHEMA_NAME to get the rules and data source instead of the name of the Add Schema I added in the sharding-ui management background? Where can I specify the Schema Name created in the background? 中文描述: OrchestrationShardingDataSource 初始化时, 为什么是通过ShardingConstant.LOGIC_SCHEMA_NAME去zookeeper获取规则和数据源, 而不是我在sharding-ui管理后台Add Schema的名称? 我在哪里可以指定我自己创建的Schema Name? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] mrnx2004 opened a new issue #4702: there is a "table doesn't exist" problem, even if i set the "defaultDataSourceName" property
mrnx2004 opened a new issue #4702: there is a "table doesn't exist" problem, even if i set the "defaultDataSourceName" property URL: https://github.com/apache/incubator-shardingsphere/issues/4702 ## there is a "table doesn't exist" problem, even if i set the "defaultDataSourceName" property I download the shardingSphere-proxy docker image by this command: **docker pull apache/sharding-proxy** Then, I put the "mysql-connector-java-5.1.47-bin.jar" into "/opt/sharding-proxy/lib". According to the documentation, my container run successfully. I use MySqlWorkbench to Connect ShardingSphere-Proxy. I can innsert and search data from the table that have configured in shardingRule. But when I try to operate other table in "sharding_db",there is a error like this: **Error Code:1146.Table 'sharding_db.tableName' doesn't exist.** But I have configured **defaultDataSourceName: ds0** in **config-sharding** file. I can see all the table in MysqlWorkBanch under sharding_db, But I can only read and write to the table Which have sharding rule. Here is my config-sharding.yaml content: ``` dataSources: ds0: url: jdbc:mysql://……?serverTimezone=UTC&useSSL=false&characterEnoding=utf8 username: password: connectionTimeoutMilliseconds: 3 idleTimeoutMilliseconds: 6 maxLifetimeMilliseconds: 180 maxPoolSize: 65 ds1: url: jdbc:mysql://……?serverTimezone=UTC&useSSL=false&characterEnoding=utf8 username: password: connectionTimeoutMilliseconds: 3 idleTimeoutMilliseconds: 6 maxLifetimeMilliseconds: 180 maxPoolSize: 65 shardingRule: tables: suite: actualDataNodes: ds${0..1}.suite${0..1} tableStrategy: inline: shardingColumn: project_id algorithmExpression: suite${project_id % 2} keyGenerator: type: SNOWFLAKE column: directory_id testcase: actualDataNodes: ds{0..1}.testcase${0..1} tableStrategy: inline: shardingColumn: suite_id algorithmExpression: testcase${suite_id % 2} keyGenerator: type: SNOWFLAKE column: testcase_sequence bindingTables: - suite,testcase defaultDataSourceName: ds0 defaultDatabaseStrategy: inline: shardingColumn: id algorithmExpression: ds${id % 2} defaultTableStrategy: none: ``` I don't konw why the default dataSource seems not really work. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] kimmking closed issue #4681: orchestration-refactoring phase 1
kimmking closed issue #4681: orchestration-refactoring phase 1 URL: https://github.com/apache/incubator-shardingsphere/issues/4681 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] ranjeet-floyd edited a comment on issue #4496: Replace 'mvn install' by './mvnw install' in release guide
ranjeet-floyd edited a comment on issue #4496: Replace 'mvn install' by './mvnw install' in release guide URL: https://github.com/apache/incubator-shardingsphere/issues/4496#issuecomment-597412836 @tuohai666 Can i take this ?. Thanks This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] ranjeet-floyd commented on issue #4496: Replace 'mvn install' by './mvnw install' in release guide
ranjeet-floyd commented on issue #4496: Replace 'mvn install' by './mvnw install' in release guide URL: https://github.com/apache/incubator-shardingsphere/issues/4496#issuecomment-597412836 @geomonlin Can i take this ?. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere-doc] cherrylzhao merged pull request #453: add 4.0.1 downloads link
cherrylzhao merged pull request #453: add 4.0.1 downloads link URL: https://github.com/apache/incubator-shardingsphere-doc/pull/453 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere-doc] geomonlin opened a new pull request #453: add 4.0.1 downloads link
geomonlin opened a new pull request #453: add 4.0.1 downloads link URL: https://github.com/apache/incubator-shardingsphere-doc/pull/453 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] ranjeet-floyd commented on issue #4645: Use YAML configuration instead of java configuration for DataSource test
ranjeet-floyd commented on issue #4645: Use YAML configuration instead of java configuration for DataSource test URL: https://github.com/apache/incubator-shardingsphere/issues/4645#issuecomment-597407746 @terrymanu Can i take this ?. Thanks This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
notifications@shardingsphere.apache.org
terrymanu merged pull request #4699: Refactor orchestration phase 1.2&1.3 URL: https://github.com/apache/incubator-shardingsphere/pull/4699 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[incubator-shardingsphere-benchmark] branch master updated: for performance
This is an automated email from the ASF dual-hosted git repository. zhangyonglun pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-shardingsphere-benchmark.git The following commit(s) were added to refs/heads/master by this push: new 8596c12 for performance 8596c12 is described below commit 8596c128bbd66690df6e911f647019e6e841e05f Author: tuohai666 AuthorDate: Wed Mar 11 08:56:11 2020 +0800 for performance --- report/jtl_json/full_route_test.json| 2 +- report/jtl_json/master_slave_encrypt_sharding_test.json | 2 +- report/jtl_json/master_slave_test.json | 2 +- report/jtl_json/single_route_test.json | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) diff --git a/report/jtl_json/full_route_test.json b/report/jtl_json/full_route_test.json index 756280f..d398dfe 100644 --- a/report/jtl_json/full_route_test.json +++ b/report/jtl_json/full_route_test.json @@ -1 +1 @@ -{"SELECT": [{"data": [{"99.9th": "9", "Err": "0.0%", "95th": "2", "50th": "1", "Max": "10", "Min": "0", "Throughout": "23036.87", "Samples": 4999, "Date": "2019.12.19 02:35:57 ", "Avg": "0"}, {"99.9th": "9", "Err": "0.0%", "95th": "2", "50th": "1", "Max": "9", "Min": "0", "Throughout": "22619.91", "Samples": 4999, "Date": "2019.12.20 13:34:47 ", "Avg": "0"}, {"99.9th": "9", "Err": "0.0%", "95th": "2", "50th": "1", "Max": "9", "Min": "0", "Throughout": "22931.19", "Samples": 4999, "Date": [...] \ No newline at end of file +{"SELECT": [{"data": [{"99.9th": "9", "Err": "0.0%", "95th": "2", "50th": "1", "Max": "10", "Min": "0", "Throughout": "23036.87", "Samples": 4999, "Date": "2019.12.19 02:35:57 ", "Avg": "0"}, {"99.9th": "9", "Err": "0.0%", "95th": "2", "50th": "1", "Max": "9", "Min": "0", "Throughout": "22619.91", "Samples": 4999, "Date": "2019.12.20 13:34:47 ", "Avg": "0"}, {"99.9th": "9", "Err": "0.0%", "95th": "2", "50th": "1", "Max": "9", "Min": "0", "Throughout": "22931.19", "Samples": 4999, "Date": [...] \ No newline at end of file diff --git a/report/jtl_json/master_slave_encrypt_sharding_test.json b/report/jtl_json/master_slave_encrypt_sharding_test.json index c6dba4b..074cae4 100644 --- a/report/jtl_json/master_slave_encrypt_sharding_test.json +++ b/report/jtl_json/master_slave_encrypt_sharding_test.json @@ -1 +1 @@ -{"SELECT": [{"data": [{"99.9th": "16", "Err": "0.0%", "95th": "3", "50th": "2", "Max": "66", "Min": "1", "Throughout": "9381.73", "Samples": 99, "Date": "2019.12.19 02:40:33 ", "Avg": "2"}, {"99.9th": "16", "Err": "0.0%", "95th": "3", "50th": "2", "Max": "62", "Min": "1", "Throughout": "9038.48", "Samples": 99, "Date": "2019.12.20 13:39:23 ", "Avg": "2"}, {"99.9th": "16", "Err": "0.0%", "95th": "3", "50th": "2", "Max": "63", "Min": "1", "Throughout": "9071.44", "Samples": 99, [...] \ No newline at end of file +{"SELECT": [{"data": [{"99.9th": "16", "Err": "0.0%", "95th": "3", "50th": "2", "Max": "66", "Min": "1", "Throughout": "9381.73", "Samples": 99, "Date": "2019.12.19 02:40:33 ", "Avg": "2"}, {"99.9th": "16", "Err": "0.0%", "95th": "3", "50th": "2", "Max": "62", "Min": "1", "Throughout": "9038.48", "Samples": 99, "Date": "2019.12.20 13:39:23 ", "Avg": "2"}, {"99.9th": "16", "Err": "0.0%", "95th": "3", "50th": "2", "Max": "63", "Min": "1", "Throughout": "9071.44", "Samples": 99, [...] \ No newline at end of file diff --git a/report/jtl_json/master_slave_test.json b/report/jtl_json/master_slave_test.json index 93e7680..3d7113f 100644 --- a/report/jtl_json/master_slave_test.json +++ b/report/jtl_json/master_slave_test.json @@ -1 +1 @@ -{"INSERT+SELECT+DELETE": [{"data": [], "type": "Sharding-Proxy_3.1"}, {"data": [{"99.9th": "38", "Err": "0.0%", "95th": "16", "50th": "11", "Max": "48", "Min": "7", "Throughout": "1720.96", "Samples": 29709, "Date": "2020.01.01 02:49:45 ", "Avg": "11"}, {"99.9th": "27", "Err": "0.0%", "95th": "16", "50th": "11", "Max": "37", "Min": "7", "Throughout": "1701.38", "Samples": 17218, "Date": "2020.01.02 02:49:52 ", "Avg": "11"}, {"99.9th": "30", "Err": "0.0%", "95th": "16", "50th": "11", "Max [...] \ No newline at end of file +{"INSERT+SELECT+DELETE": [{"data": [], "type": "Sharding-Proxy_3.1"}, {"data": [{"99.9th": "38", "Err": "0.0%", "95th": "16", "50th": "11", "Max": "48", "Min": "7", "Throughout": "1720.96", "Samples": 29709, "Date": "2020.01.01 02:49:45 ", "Avg": "11"}, {"99.9th": "27", "Err": "0.0%", "95th": "16", "50th": "11", "Max": "37", "Min": "7", "Throughout": "1701.38", "Samples": 17218, "Date": "2020.01.02 02:49:52 ", "Avg": "11"}, {"99.9th": "30", "Err": "0.0%", "95th": "16", "50th": "11", "Max [...] \ No newline at end of file diff --git a/report/jtl_json/single_route_test.json b/report/jtl_json/single_route_test.json index 2e5edf5..cdb71df 100644 --- a/report/jtl_json/single_route_test.json +++ b/report/jtl_json/single_route_test.json @@ -1 +1 @@ -{"SELECT": [{"data": [], "type": "Sharding-Proxy_
[GitHub] [incubator-shardingsphere] tristaZero closed issue #4691: Move table and column meta data to shardingsphere-sql-parser-binder module
tristaZero closed issue #4691: Move table and column meta data to shardingsphere-sql-parser-binder module URL: https://github.com/apache/incubator-shardingsphere/issues/4691 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] tristaZero merged pull request #4700: Move metadata to sql-parser-binder module
tristaZero merged pull request #4700: Move metadata to sql-parser-binder module URL: https://github.com/apache/incubator-shardingsphere/pull/4700 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
notifications@shardingsphere.apache.org
coveralls edited a comment on issue #4699: Refactor orchestration phase 1.2&1.3 URL: https://github.com/apache/incubator-shardingsphere/pull/4699#issuecomment-597200695 ## Pull Request Test Coverage Report for [Build 10168](https://coveralls.io/builds/29255876) * **31** of **34** **(91.18%)** changed or added relevant lines in **17** files are covered. * No unchanged relevant lines lost coverage. * Overall coverage increased (+**0.03%**) to **59.023%** --- | Changes Missing Coverage | Covered Lines | Changed/Added Lines | % | | :-|--||---: | | [sharding-jdbc/sharding-jdbc-orchestration/src/main/java/org/apache/shardingsphere/shardingjdbc/orchestration/api/yaml/YamlOrchestrationMasterSlaveDataSourceFactory.java](https://coveralls.io/builds/29255876/source?filename=sharding-jdbc%2Fsharding-jdbc-orchestration%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingjdbc%2Forchestration%2Fapi%2Fyaml%2FYamlOrchestrationMasterSlaveDataSourceFactory.java#L105) | 1 | 2 | 50.0% | [sharding-jdbc/sharding-jdbc-orchestration/src/main/java/org/apache/shardingsphere/shardingjdbc/orchestration/api/yaml/YamlOrchestrationShardingDataSourceFactory.java](https://coveralls.io/builds/29255876/source?filename=sharding-jdbc%2Fsharding-jdbc-orchestration%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingjdbc%2Forchestration%2Fapi%2Fyaml%2FYamlOrchestrationShardingDataSourceFactory.java#L105) | 1 | 2 | 50.0% | [sharding-orchestration/sharding-orchestration-center/sharding-orchestration-center-apollo/src/main/java/org/apache/shardingsphere/orchestration/center/instance/wrapper/ApolloOpenApiWrapper.java](https://coveralls.io/builds/29255876/source?filename=sharding-orchestration%2Fsharding-orchestration-center%2Fsharding-orchestration-center-apollo%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Forchestration%2Fcenter%2Finstance%2Fwrapper%2FApolloOpenApiWrapper.java#L44) | 0 | 1 | 0.0% | Totals | [![Coverage Status](https://coveralls.io/builds/29255876/badge)](https://coveralls.io/builds/29255876) | | :-- | --: | | Change from base [Build 10165](https://coveralls.io/builds/29246705): | 0.03% | | Covered Lines: | 12173 | | Relevant Lines: | 20624 | --- # 💛 - [Coveralls](https://coveralls.io) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] coveralls edited a comment on issue #4700: Move metadata to sql-parser-binder module
coveralls edited a comment on issue #4700: Move metadata to sql-parser-binder module URL: https://github.com/apache/incubator-shardingsphere/pull/4700#issuecomment-597196863 ## Pull Request Test Coverage Report for [Build 10167](https://coveralls.io/builds/29255467) * **52** of **74** **(70.27%)** changed or added relevant lines in **36** files are covered. * No unchanged relevant lines lost coverage. * Overall coverage decreased (**-0.0005%**) to **58.989%** --- | Changes Missing Coverage | Covered Lines | Changed/Added Lines | % | | :-|--||---: | | [shadow-core/shadow-core-rewrite/src/main/java/org/apache/shardingsphere/shadow/rewrite/context/ShadowSQLRewriteContextDecorator.java](https://coveralls.io/builds/29255467/source?filename=shadow-core%2Fshadow-core-rewrite%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshadow%2Frewrite%2Fcontext%2FShadowSQLRewriteContextDecorator.java#L35) | 0 | 1 | 0.0% | [sharding-core/sharding-core-rewrite/src/main/java/org/apache/shardingsphere/sharding/rewrite/parameter/ShardingParameterRewriterBuilder.java](https://coveralls.io/builds/29255467/source?filename=sharding-core%2Fsharding-core-rewrite%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsharding%2Frewrite%2Fparameter%2FShardingParameterRewriterBuilder.java#L63) | 2 | 3 | 66.67% | [sharding-proxy/sharding-proxy-backend/src/main/java/org/apache/shardingsphere/shardingproxy/backend/communication/jdbc/JDBCDatabaseCommunicationEngine.java](https://coveralls.io/builds/29255467/source?filename=sharding-proxy%2Fsharding-proxy-backend%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingproxy%2Fbackend%2Fcommunication%2Fjdbc%2FJDBCDatabaseCommunicationEngine.java#L144) | 0 | 1 | 0.0% | [shardingsphere-sql-parser/shardingsphere-sql-parser-binder/src/main/java/org/apache/shardingsphere/sql/parser/binder/segment/select/projection/engine/ProjectionEngine.java](https://coveralls.io/builds/29255467/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-binder%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fbinder%2Fsegment%2Fselect%2Fprojection%2Fengine%2FProjectionEngine.java#L127) | 1 | 2 | 50.0% | [shardingsphere-underlying/shardingsphere-rewrite/shardingsphere-rewrite-engine/src/main/java/org/apache/shardingsphere/underlying/rewrite/SQLRewriteEntry.java](https://coveralls.io/builds/29255467/source?filename=shardingsphere-underlying%2Fshardingsphere-rewrite%2Fshardingsphere-rewrite-engine%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Funderlying%2Frewrite%2FSQLRewriteEntry.java#L53) | 0 | 1 | 0.0% | [shardingsphere-underlying/shardingsphere-rewrite/shardingsphere-rewrite-engine/src/main/java/org/apache/shardingsphere/underlying/rewrite/context/SQLRewriteContext.java](https://coveralls.io/builds/29255467/source?filename=shardingsphere-underlying%2Fshardingsphere-rewrite%2Fshardingsphere-rewrite-engine%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Funderlying%2Frewrite%2Fcontext%2FSQLRewriteContext.java#L81) | 2 | 3 | 66.67% | [shardingsphere-underlying/shardingsphere-merge/src/main/java/org/apache/shardingsphere/underlying/merge/MergeEntry.java](https://coveralls.io/builds/29255467/source?filename=shardingsphere-underlying%2Fshardingsphere-merge%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Funderlying%2Fmerge%2FMergeEntry.java#L74) | 0 | 3 | 0.0% | [shardingsphere-underlying/shardingsphere-rewrite/shardingsphere-rewrite-engine/src/main/java/org/apache/shardingsphere/underlying/rewrite/sql/token/generator/SQLTokenGenerators.java](https://coveralls.io/builds/29255467/source?filename=shardingsphere-underlying%2Fshardingsphere-rewrite%2Fshardingsphere-rewrite-engine%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Funderlying%2Frewrite%2Fsql%2Ftoken%2Fgenerator%2FSQLTokenGenerators.java#L72) | 0 | 3 | 0.0% | [sharding-proxy/sharding-proxy-backend/src/main/java/org/apache/shardingsphere/shardingproxy/backend/communication/jdbc/wrapper/PreparedStatementExecutorWrapper.java](https://coveralls.io/builds/29255467/source?filename=sharding-proxy%2Fsharding-proxy-backend%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingproxy%2Fbackend%2Fcommunication%2Fjdbc%2Fwrapper%2FPreparedStatementExecutorWrapper.java#L99) | 0 | 5 | 0.0% | [sharding-proxy/sharding-proxy-backend/src/main/java/org/apache/shardingsphere/shardingproxy/backend/communication/jdbc/wrapper/StatementExecutorWrapper.java](https://coveralls.io/builds/29255467/source?filename=sharding-proxy%2Fsharding-proxy-backend%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingproxy%2Fbackend%2Fcommunication%2Fjdbc%2Fwrapper%2FStatementExecutorWrapper.java#L97) | 0 | 5 | 0.0% | Totals | [![Coverage Status](https://coveralls.io/builds/29255467/badge)](https://coveralls.io/builds/29255467) | | :-- | --: | | Change from base [Build 10165](https://c
[GitHub] [incubator-shardingsphere] codecov-io commented on issue #4700: Move metadata to sql-parser-binder module
codecov-io commented on issue #4700: Move metadata to sql-parser-binder module URL: https://github.com/apache/incubator-shardingsphere/pull/4700#issuecomment-597210735 # [Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4700?src=pr&el=h1) Report > Merging [#4700](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4700?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-shardingsphere/commit/5daaca24e0dd714d810551a31541335fbdfb71fe?src=pr&el=desc) will **increase** coverage by `<.01%`. > The diff coverage is `67.56%`. [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4700/graphs/tree.svg?width=650&token=ZvlXpWa7so&height=150&src=pr)](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4700?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master#4700 +/- ## + Coverage 55.43% 55.43% +<.01% Complexity 426 426 Files 1136 1133 -3 Lines 2062420575 -49 Branches 3827 3819 -8 - Hits 1143211405 -27 + Misses 8470 8450 -20 + Partials722 720 -2 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4700?src=pr&el=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...ngproxy/backend/schema/impl/MasterSlaveSchema.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4700/diff?src=pr&el=tree#diff-c2hhcmRpbmctcHJveHkvc2hhcmRpbmctcHJveHktYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc2hhcmRpbmdwcm94eS9iYWNrZW5kL3NjaGVtYS9pbXBsL01hc3RlclNsYXZlU2NoZW1hLmphdmE=) | `0% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: | | [...ardingjdbc/executor/AbstractStatementExecutor.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4700/diff?src=pr&el=tree#diff-c2hhcmRpbmctamRiYy9zaGFyZGluZy1qZGJjLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NoYXJkaW5namRiYy9leGVjdXRvci9BYnN0cmFjdFN0YXRlbWVudEV4ZWN1dG9yLmphdmE=) | `41.3% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: | | [...ngproxy/backend/schema/impl/TransparentSchema.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4700/diff?src=pr&el=tree#diff-c2hhcmRpbmctcHJveHkvc2hhcmRpbmctcHJveHktYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc2hhcmRpbmdwcm94eS9iYWNrZW5kL3NjaGVtYS9pbXBsL1RyYW5zcGFyZW50U2NoZW1hLmphdmE=) | `0% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: | | [...ardingproxy/backend/schema/impl/EncryptSchema.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4700/diff?src=pr&el=tree#diff-c2hhcmRpbmctcHJveHkvc2hhcmRpbmctcHJveHktYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc2hhcmRpbmdwcm94eS9iYWNrZW5kL3NjaGVtYS9pbXBsL0VuY3J5cHRTY2hlbWEuamF2YQ==) | `0% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: | | [...pt/metadata/loader/EncryptTableMetaDataLoader.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4700/diff?src=pr&el=tree#diff-ZW5jcnlwdC1jb3JlL2VuY3J5cHQtY29yZS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2VuY3J5cHQvbWV0YWRhdGEvbG9hZGVyL0VuY3J5cHRUYWJsZU1ldGFEYXRhTG9hZGVyLmphdmE=) | `0% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: | | [...e/encrypt/merge/dql/EncryptDQLResultDecorator.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4700/diff?src=pr&el=tree#diff-ZW5jcnlwdC1jb3JlL2VuY3J5cHQtY29yZS1tZXJnZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvZW5jcnlwdC9tZXJnZS9kcWwvRW5jcnlwdERRTFJlc3VsdERlY29yYXRvci5qYXZh) | `0% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: | | [...e/init/loader/impl/DefaultTableMetaDataLoader.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4700/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtdW5kZXJseWluZy9zaGFyZGluZ3NwaGVyZS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3VuZGVybHlpbmcvY29tbW9uL21ldGFkYXRhL3RhYmxlL2luaXQvbG9hZGVyL2ltcGwvRGVmYXVsdFRhYmxlTWV0YURhdGFMb2FkZXIuamF2YQ==) | `0% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: | | [...dingsphere/sharding/route/hook/SPIRoutingHook.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4700/diff?src=pr&el=tree#diff-c2hhcmRpbmctY29yZS9zaGFyZGluZy1jb3JlLXJvdXRlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9zaGFyZGluZy9yb3V0ZS9ob29rL1NQSVJvdXRpbmdIb29rLmphdmE=) | `100% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: | | [...ine/decorator/impl/TransparentResultDecorator.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4700/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtdW5kZXJseWluZy9zaGFyZGluZ3NwaGVyZS1tZXJnZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvdW5kZXJseWluZy9tZXJnZS9lbmdpbmUvZGVjb3JhdG9yL2ltcGwvVHJhbnNwYXJlbnRSZXN1bH
notifications@shardingsphere.apache.org
coveralls commented on issue #4699: Refactor orchestration phase 1.2&1.3 URL: https://github.com/apache/incubator-shardingsphere/pull/4699#issuecomment-597200695 ## Pull Request Test Coverage Report for [Build 2063](https://coveralls.io/builds/29254659) * **31** of **34** **(91.18%)** changed or added relevant lines in **17** files are covered. * **2** unchanged lines in **1** file lost coverage. * Overall coverage increased (+**0.1%**) to **59.101%** --- | Changes Missing Coverage | Covered Lines | Changed/Added Lines | % | | :-|--||---: | | [sharding-jdbc/sharding-jdbc-orchestration/src/main/java/org/apache/shardingsphere/shardingjdbc/orchestration/api/yaml/YamlOrchestrationMasterSlaveDataSourceFactory.java](https://coveralls.io/builds/29254659/source?filename=sharding-jdbc%2Fsharding-jdbc-orchestration%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingjdbc%2Forchestration%2Fapi%2Fyaml%2FYamlOrchestrationMasterSlaveDataSourceFactory.java#L105) | 1 | 2 | 50.0% | [sharding-jdbc/sharding-jdbc-orchestration/src/main/java/org/apache/shardingsphere/shardingjdbc/orchestration/api/yaml/YamlOrchestrationShardingDataSourceFactory.java](https://coveralls.io/builds/29254659/source?filename=sharding-jdbc%2Fsharding-jdbc-orchestration%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingjdbc%2Forchestration%2Fapi%2Fyaml%2FYamlOrchestrationShardingDataSourceFactory.java#L105) | 1 | 2 | 50.0% | [sharding-orchestration/sharding-orchestration-center/sharding-orchestration-center-apollo/src/main/java/org/apache/shardingsphere/orchestration/center/instance/wrapper/ApolloOpenApiWrapper.java](https://coveralls.io/builds/29254659/source?filename=sharding-orchestration%2Fsharding-orchestration-center%2Fsharding-orchestration-center-apollo%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Forchestration%2Fcenter%2Finstance%2Fwrapper%2FApolloOpenApiWrapper.java#L44) | 0 | 1 | 0.0% | Files with Coverage Reduction | New Missed Lines | % | | :-|--|--: | | [sharding-orchestration/sharding-orchestration-core/src/main/java/org/apache/shardingsphere/orchestration/internal/util/IpUtils.java](https://coveralls.io/builds/29254659/source?filename=sharding-orchestration%2Fsharding-orchestration-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Forchestration%2Finternal%2Futil%2FIpUtils.java#L72) | 2 | 80.0% | | Totals | [![Coverage Status](https://coveralls.io/builds/29254659/badge)](https://coveralls.io/builds/29254659) | | :-- | --: | | Change from base [Build 10165](https://coveralls.io/builds/29246705): | 0.1% | | Covered Lines: | 12189 | | Relevant Lines: | 20624 | --- # 💛 - [Coveralls](https://coveralls.io) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] coveralls commented on issue #4700: Move metadata to sql-parser-binder module
coveralls commented on issue #4700: Move metadata to sql-parser-binder module URL: https://github.com/apache/incubator-shardingsphere/pull/4700#issuecomment-597196863 ## Pull Request Test Coverage Report for [Build 2062](https://coveralls.io/builds/29254613) * **52** of **74** **(70.27%)** changed or added relevant lines in **36** files are covered. * **2** unchanged lines in **1** file lost coverage. * Overall coverage increased (+**0.08%**) to **59.067%** --- | Changes Missing Coverage | Covered Lines | Changed/Added Lines | % | | :-|--||---: | | [shadow-core/shadow-core-rewrite/src/main/java/org/apache/shardingsphere/shadow/rewrite/context/ShadowSQLRewriteContextDecorator.java](https://coveralls.io/builds/29254613/source?filename=shadow-core%2Fshadow-core-rewrite%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshadow%2Frewrite%2Fcontext%2FShadowSQLRewriteContextDecorator.java#L35) | 0 | 1 | 0.0% | [sharding-core/sharding-core-rewrite/src/main/java/org/apache/shardingsphere/sharding/rewrite/parameter/ShardingParameterRewriterBuilder.java](https://coveralls.io/builds/29254613/source?filename=sharding-core%2Fsharding-core-rewrite%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsharding%2Frewrite%2Fparameter%2FShardingParameterRewriterBuilder.java#L63) | 2 | 3 | 66.67% | [sharding-proxy/sharding-proxy-backend/src/main/java/org/apache/shardingsphere/shardingproxy/backend/communication/jdbc/JDBCDatabaseCommunicationEngine.java](https://coveralls.io/builds/29254613/source?filename=sharding-proxy%2Fsharding-proxy-backend%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingproxy%2Fbackend%2Fcommunication%2Fjdbc%2FJDBCDatabaseCommunicationEngine.java#L144) | 0 | 1 | 0.0% | [shardingsphere-sql-parser/shardingsphere-sql-parser-binder/src/main/java/org/apache/shardingsphere/sql/parser/binder/segment/select/projection/engine/ProjectionEngine.java](https://coveralls.io/builds/29254613/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-binder%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fbinder%2Fsegment%2Fselect%2Fprojection%2Fengine%2FProjectionEngine.java#L127) | 1 | 2 | 50.0% | [shardingsphere-underlying/shardingsphere-rewrite/shardingsphere-rewrite-engine/src/main/java/org/apache/shardingsphere/underlying/rewrite/SQLRewriteEntry.java](https://coveralls.io/builds/29254613/source?filename=shardingsphere-underlying%2Fshardingsphere-rewrite%2Fshardingsphere-rewrite-engine%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Funderlying%2Frewrite%2FSQLRewriteEntry.java#L53) | 0 | 1 | 0.0% | [shardingsphere-underlying/shardingsphere-rewrite/shardingsphere-rewrite-engine/src/main/java/org/apache/shardingsphere/underlying/rewrite/context/SQLRewriteContext.java](https://coveralls.io/builds/29254613/source?filename=shardingsphere-underlying%2Fshardingsphere-rewrite%2Fshardingsphere-rewrite-engine%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Funderlying%2Frewrite%2Fcontext%2FSQLRewriteContext.java#L81) | 2 | 3 | 66.67% | [shardingsphere-underlying/shardingsphere-merge/src/main/java/org/apache/shardingsphere/underlying/merge/MergeEntry.java](https://coveralls.io/builds/29254613/source?filename=shardingsphere-underlying%2Fshardingsphere-merge%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Funderlying%2Fmerge%2FMergeEntry.java#L74) | 0 | 3 | 0.0% | [shardingsphere-underlying/shardingsphere-rewrite/shardingsphere-rewrite-engine/src/main/java/org/apache/shardingsphere/underlying/rewrite/sql/token/generator/SQLTokenGenerators.java](https://coveralls.io/builds/29254613/source?filename=shardingsphere-underlying%2Fshardingsphere-rewrite%2Fshardingsphere-rewrite-engine%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Funderlying%2Frewrite%2Fsql%2Ftoken%2Fgenerator%2FSQLTokenGenerators.java#L72) | 0 | 3 | 0.0% | [sharding-proxy/sharding-proxy-backend/src/main/java/org/apache/shardingsphere/shardingproxy/backend/communication/jdbc/wrapper/PreparedStatementExecutorWrapper.java](https://coveralls.io/builds/29254613/source?filename=sharding-proxy%2Fsharding-proxy-backend%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingproxy%2Fbackend%2Fcommunication%2Fjdbc%2Fwrapper%2FPreparedStatementExecutorWrapper.java#L99) | 0 | 5 | 0.0% | [sharding-proxy/sharding-proxy-backend/src/main/java/org/apache/shardingsphere/shardingproxy/backend/communication/jdbc/wrapper/StatementExecutorWrapper.java](https://coveralls.io/builds/29254613/source?filename=sharding-proxy%2Fsharding-proxy-backend%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingproxy%2Fbackend%2Fcommunication%2Fjdbc%2Fwrapper%2FStatementExecutorWrapper.java#L97) | 0 | 5 | 0.0% | Files with Coverage Reduction | New Missed Lines | % | | :-|--|--: | | [sharding-orchestration/sharding-orchestration-core/src/main/java/org/apache/shardingsphere
[GitHub] [incubator-shardingsphere] kimmking opened a new issue #4701: orchestration-refactoring phase 2
kimmking opened a new issue #4701: orchestration-refactoring phase 2 URL: https://github.com/apache/incubator-shardingsphere/issues/4701 According to #4522 & #4681 , orchestration-refactoring begin now. 2.orchestration-refactoring phase 2 tasks: 2.1 configuration project (in progress) - [ ] Add configuration project - [ ] Extract existing code to configuration project - [ ] Improve unit tests 2.2 model design (todo) - [ ] Add model project - [ ] Extract existing code to model project - [ ] Refactoring model project code and design - [ ] Improve unit tests - [ ] Update references to other projects -- Other following tasks: 3. Metadata design (todo) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] kekerzzZ commented on issue #4698: In version 4.0.1, hintmanager.setdatabaseshardingvalue cannot be used. When will this problem be fixed
kekerzzZ commented on issue #4698: In version 4.0.1, hintmanager.setdatabaseshardingvalue cannot be used. When will this problem be fixed URL: https://github.com/apache/incubator-shardingsphere/issues/4698#issuecomment-597186368 In version 4.0.1, you should use `hintmanager.addDatabaseShardingValue()` or use `spring.shardingsphere.sharding.tables.tablename.table-strategy.hint.algorithm-class-name=` configuration. The current version uses Hint, and you need to configure separate tables. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu opened a new pull request #4700: Move metadata to sql-parser-binder module
terrymanu opened a new pull request #4700: Move metadata to sql-parser-binder module URL: https://github.com/apache/incubator-shardingsphere/pull/4700 Fixes #4691. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] kimmking commented on issue #4680: count(distinct col) renturn null
kimmking commented on issue #4680: count(distinct col) renturn null URL: https://github.com/apache/incubator-shardingsphere/issues/4680#issuecomment-597146240 I reproduced it. It's a bug. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] Zhumingj commented on issue #4697: Cannot find table rule and default data source with logic tables
Zhumingj commented on issue #4697: Cannot find table rule and default data source with logic tables URL: https://github.com/apache/incubator-shardingsphere/issues/4697#issuecomment-597117852 > You may try for inline expression, for example: `tb_order_$->{0...99}` it's not what i want. i just want to shard databases, but if there are many tables, do i have to config all of these tables for inline expression? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu edited a comment on issue #4669: ComplexKeysShardingAlgorithm && HintShardingAlgorithm
terrymanu edited a comment on issue #4669: ComplexKeysShardingAlgorithm && HintShardingAlgorithm URL: https://github.com/apache/incubator-shardingsphere/issues/4669#issuecomment-597112848 Can you change the title which make a whole sentence for search friendly? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu commented on issue #4669: ComplexKeysShardingAlgorithm && HintShardingAlgorithm
terrymanu commented on issue #4669: ComplexKeysShardingAlgorithm && HintShardingAlgorithm URL: https://github.com/apache/incubator-shardingsphere/issues/4669#issuecomment-597112848 Can you change the title for search firendly? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu edited a comment on issue #4669: ComplexKeysShardingAlgorithm && HintShardingAlgorithm
terrymanu edited a comment on issue #4669: ComplexKeysShardingAlgorithm && HintShardingAlgorithm URL: https://github.com/apache/incubator-shardingsphere/issues/4669#issuecomment-597112848 Can you change the title for search friendly? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu edited a comment on issue #4697: Cannot find table rule and default data source with logic tables
terrymanu edited a comment on issue #4697: Cannot find table rule and default data source with logic tables URL: https://github.com/apache/incubator-shardingsphere/issues/4697#issuecomment-597112131 You may try for inline expression, for example: `tb_order_$->{0...99}` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu commented on issue #4697: Cannot find table rule and default data source with logic tables
terrymanu commented on issue #4697: Cannot find table rule and default data source with logic tables URL: https://github.com/apache/incubator-shardingsphere/issues/4697#issuecomment-597112131 You may try for inline expression, for example: `$tb_order{0...99}` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu edited a comment on issue #4697: Cannot find table rule and default data source with logic tables
terrymanu edited a comment on issue #4697: Cannot find table rule and default data source with logic tables URL: https://github.com/apache/incubator-shardingsphere/issues/4697#issuecomment-597112131 You may try for inline expression, for example: `tb_order$->{0...99}` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu closed issue #3475: Establish SQL parser module development document adapt to various databases
terrymanu closed issue #3475: Establish SQL parser module development document adapt to various databases URL: https://github.com/apache/incubator-shardingsphere/issues/3475 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] tianbin1001 commented on issue #3475: Establish SQL parser module development document adapt to various databases
tianbin1001 commented on issue #3475: Establish SQL parser module development document adapt to various databases URL: https://github.com/apache/incubator-shardingsphere/issues/3475#issuecomment-597091362 Parser is changing, unable to write the document for the time being, This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[incubator-shardingsphere-benchmark] branch master updated: for performance
This is an automated email from the ASF dual-hosted git repository. zhangyonglun pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-shardingsphere-benchmark.git The following commit(s) were added to refs/heads/master by this push: new 2b04e5f for performance 2b04e5f is described below commit 2b04e5fd7d76936532a2579639a9756aa05b4e2b Author: tuohai666 AuthorDate: Tue Mar 10 21:28:39 2020 +0800 for performance --- report/jtl_json/full_route_test.json| 2 +- report/jtl_json/master_slave_encrypt_sharding_test.json | 2 +- report/jtl_json/master_slave_test.json | 2 +- report/jtl_json/single_route_test.json | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) diff --git a/report/jtl_json/full_route_test.json b/report/jtl_json/full_route_test.json index 6992030..756280f 100644 --- a/report/jtl_json/full_route_test.json +++ b/report/jtl_json/full_route_test.json @@ -1 +1 @@ -{"SELECT": [{"data": [{"99.9th": "9", "Err": "0.0%", "95th": "2", "50th": "1", "Max": "10", "Min": "0", "Throughout": "23036.87", "Samples": 4999, "Date": "2019.12.19 02:35:57 ", "Avg": "0"}, {"99.9th": "9", "Err": "0.0%", "95th": "2", "50th": "1", "Max": "9", "Min": "0", "Throughout": "22619.91", "Samples": 4999, "Date": "2019.12.20 13:34:47 ", "Avg": "0"}, {"99.9th": "9", "Err": "0.0%", "95th": "2", "50th": "1", "Max": "9", "Min": "0", "Throughout": "22931.19", "Samples": 4999, "Date": [...] \ No newline at end of file +{"SELECT": [{"data": [{"99.9th": "9", "Err": "0.0%", "95th": "2", "50th": "1", "Max": "10", "Min": "0", "Throughout": "23036.87", "Samples": 4999, "Date": "2019.12.19 02:35:57 ", "Avg": "0"}, {"99.9th": "9", "Err": "0.0%", "95th": "2", "50th": "1", "Max": "9", "Min": "0", "Throughout": "22619.91", "Samples": 4999, "Date": "2019.12.20 13:34:47 ", "Avg": "0"}, {"99.9th": "9", "Err": "0.0%", "95th": "2", "50th": "1", "Max": "9", "Min": "0", "Throughout": "22931.19", "Samples": 4999, "Date": [...] \ No newline at end of file diff --git a/report/jtl_json/master_slave_encrypt_sharding_test.json b/report/jtl_json/master_slave_encrypt_sharding_test.json index 6a06e5b..c6dba4b 100644 --- a/report/jtl_json/master_slave_encrypt_sharding_test.json +++ b/report/jtl_json/master_slave_encrypt_sharding_test.json @@ -1 +1 @@ -{"SELECT": [{"data": [{"99.9th": "16", "Err": "0.0%", "95th": "3", "50th": "2", "Max": "66", "Min": "1", "Throughout": "9381.73", "Samples": 99, "Date": "2019.12.19 02:40:33 ", "Avg": "2"}, {"99.9th": "16", "Err": "0.0%", "95th": "3", "50th": "2", "Max": "62", "Min": "1", "Throughout": "9038.48", "Samples": 99, "Date": "2019.12.20 13:39:23 ", "Avg": "2"}, {"99.9th": "16", "Err": "0.0%", "95th": "3", "50th": "2", "Max": "63", "Min": "1", "Throughout": "9071.44", "Samples": 99, [...] \ No newline at end of file +{"SELECT": [{"data": [{"99.9th": "16", "Err": "0.0%", "95th": "3", "50th": "2", "Max": "66", "Min": "1", "Throughout": "9381.73", "Samples": 99, "Date": "2019.12.19 02:40:33 ", "Avg": "2"}, {"99.9th": "16", "Err": "0.0%", "95th": "3", "50th": "2", "Max": "62", "Min": "1", "Throughout": "9038.48", "Samples": 99, "Date": "2019.12.20 13:39:23 ", "Avg": "2"}, {"99.9th": "16", "Err": "0.0%", "95th": "3", "50th": "2", "Max": "63", "Min": "1", "Throughout": "9071.44", "Samples": 99, [...] \ No newline at end of file diff --git a/report/jtl_json/master_slave_test.json b/report/jtl_json/master_slave_test.json index fef8620..93e7680 100644 --- a/report/jtl_json/master_slave_test.json +++ b/report/jtl_json/master_slave_test.json @@ -1 +1 @@ -{"INSERT+SELECT+DELETE": [{"data": [], "type": "Sharding-Proxy_3.1"}, {"data": [{"99.9th": "38", "Err": "0.0%", "95th": "16", "50th": "11", "Max": "48", "Min": "7", "Throughout": "1720.96", "Samples": 29709, "Date": "2020.01.01 02:49:45 ", "Avg": "11"}, {"99.9th": "27", "Err": "0.0%", "95th": "16", "50th": "11", "Max": "37", "Min": "7", "Throughout": "1701.38", "Samples": 17218, "Date": "2020.01.02 02:49:52 ", "Avg": "11"}, {"99.9th": "30", "Err": "0.0%", "95th": "16", "50th": "11", "Max [...] \ No newline at end of file +{"INSERT+SELECT+DELETE": [{"data": [], "type": "Sharding-Proxy_3.1"}, {"data": [{"99.9th": "38", "Err": "0.0%", "95th": "16", "50th": "11", "Max": "48", "Min": "7", "Throughout": "1720.96", "Samples": 29709, "Date": "2020.01.01 02:49:45 ", "Avg": "11"}, {"99.9th": "27", "Err": "0.0%", "95th": "16", "50th": "11", "Max": "37", "Min": "7", "Throughout": "1701.38", "Samples": 17218, "Date": "2020.01.02 02:49:52 ", "Avg": "11"}, {"99.9th": "30", "Err": "0.0%", "95th": "16", "50th": "11", "Max [...] \ No newline at end of file diff --git a/report/jtl_json/single_route_test.json b/report/jtl_json/single_route_test.json index d0977b0..2e5edf5 100644 --- a/report/jtl_json/single_route_test.json +++ b/report/jtl_json/single_route_test.json @@ -1 +1 @@ -{"SELECT": [{"data": [], "type": "Sharding-Proxy_
[GitHub] [incubator-shardingsphere] Zhumingj closed issue #4692: Cannot find table rule and default data source with logic tables
Zhumingj closed issue #4692: Cannot find table rule and default data source with logic tables URL: https://github.com/apache/incubator-shardingsphere/issues/4692 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] Zhumingj commented on issue #4697: Cannot find table rule and default data source with logic tables
Zhumingj commented on issue #4697: Cannot find table rule and default data source with logic tables URL: https://github.com/apache/incubator-shardingsphere/issues/4697#issuecomment-597059091 if i config nothing, when i query , the system will report an error:Cannot find table rule and default data source with logic table: 'tb_order' This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] wqzwh closed issue #3174: Warning when maven install for npm version issue
wqzwh closed issue #3174: Warning when maven install for npm version issue URL: https://github.com/apache/incubator-shardingsphere/issues/3174 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] kimmking commented on issue #4698: In version 4.0.1, hintmanager.setdatabaseshardingvalue cannot be used. When will this problem be fixed
kimmking commented on issue #4698: In version 4.0.1, hintmanager.setdatabaseshardingvalue cannot be used. When will this problem be fixed URL: https://github.com/apache/incubator-shardingsphere/issues/4698#issuecomment-597047402 Can you explain the details? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] kimmking commented on issue #4697: Cannot find table rule and default data source with logic tables
kimmking commented on issue #4697: Cannot find table rule and default data source with logic tables URL: https://github.com/apache/incubator-shardingsphere/issues/4697#issuecomment-597047106 Configuration is a one-time job, and if needn't shard, you can config nothing for them as default tables. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] kimmking commented on issue #4680: count(distinct col) renturn null
kimmking commented on issue #4680: count(distinct col) renturn null URL: https://github.com/apache/incubator-shardingsphere/issues/4680#issuecomment-597046368 I will try to reproduce this issue later, maybe tomorrow. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
notifications@shardingsphere.apache.org
kimmking opened a new pull request #4699: Refactor orchestration phase 1.2&1.3 URL: https://github.com/apache/incubator-shardingsphere/pull/4699 Changes proposed in this pull request: - refactor to extract model and configuration This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] juaihua commented on issue #4668: a issue about proxy cluster to implement HA servers to client
juaihua commented on issue #4668: a issue about proxy cluster to implement HA servers to client URL: https://github.com/apache/incubator-shardingsphere/issues/4668#issuecomment-597035838 > 1.Can you modify the title to English. > 2.You can deploy more than one proxy now, but a tip: if you modify db/table metadata, it can't automatically broadcast to other proxies now, you should reboot them manually. ok thank you , @kimmking This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] kimmking commented on issue #4692: Cannot find table rule and default data source with logic tables
kimmking commented on issue #4692: Cannot find table rule and default data source with logic tables URL: https://github.com/apache/incubator-shardingsphere/issues/4692#issuecomment-597034236 duplicated #4697 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] joinhappy81 opened a new issue #4698: In version 4.0.1, hintmanager.setdatabaseshardingvalue cannot be used. When will this problem be fixed
joinhappy81 opened a new issue #4698: In version 4.0.1, hintmanager.setdatabaseshardingvalue cannot be used. When will this problem be fixed URL: https://github.com/apache/incubator-shardingsphere/issues/4698 In version 4.0.1, hintmanager.setdatabaseshardingvalue cannot be used. When will this problem be fixed This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] coveralls edited a comment on issue #4687: Refactor orchestration phase 1.1.1
coveralls edited a comment on issue #4687: Refactor orchestration phase 1.1.1 URL: https://github.com/apache/incubator-shardingsphere/pull/4687#issuecomment-596925907 ## Pull Request Test Coverage Report for [Build 2060](https://coveralls.io/builds/29245895) * **6** of **8** **(75.0%)** changed or added relevant lines in **3** files are covered. * No unchanged relevant lines lost coverage. * Overall coverage increased (+**0.004%**) to **59.032%** --- | Changes Missing Coverage | Covered Lines | Changed/Added Lines | % | | :-|--||---: | | [sharding-orchestration/sharding-orchestration-core/src/main/java/org/apache/shardingsphere/orchestration/internal/registry/config/listener/SchemaChangedListener.java](https://coveralls.io/builds/29245895/source?filename=sharding-orchestration%2Fsharding-orchestration-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Forchestration%2Finternal%2Fregistry%2Fconfig%2Flistener%2FSchemaChangedListener.java#L95) | 2 | 4 | 50.0% | Totals | [![Coverage Status](https://coveralls.io/builds/29245895/badge)](https://coveralls.io/builds/29245895) | | :-- | --: | | Change from base [Build 1037](https://coveralls.io/builds/29241018): | 0.004% | | Covered Lines: | 12098 | | Relevant Lines: | 20494 | --- # 💛 - [Coveralls](https://coveralls.io) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu merged pull request #4695: Delete invalid assertion
terrymanu merged pull request #4695: Delete invalid assertion URL: https://github.com/apache/incubator-shardingsphere/pull/4695 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu closed issue #4694: Remove invalid assertion for parsing integrated tests
terrymanu closed issue #4694: Remove invalid assertion for parsing integrated tests URL: https://github.com/apache/incubator-shardingsphere/issues/4694 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu merged pull request #4689: Add support for shadow in proxy
terrymanu merged pull request #4689: Add support for shadow in proxy URL: https://github.com/apache/incubator-shardingsphere/pull/4689 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu merged pull request #4693: Refactor MySQL generic and auth protocol packets.
terrymanu merged pull request #4693: Refactor MySQL generic and auth protocol packets. URL: https://github.com/apache/incubator-shardingsphere/pull/4693 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu merged pull request #4687: Refactor orchestration phase 1.1.1
terrymanu merged pull request #4687: Refactor orchestration phase 1.1.1 URL: https://github.com/apache/incubator-shardingsphere/pull/4687 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] coveralls edited a comment on issue #4695: Delete invalid assertion
coveralls edited a comment on issue #4695: Delete invalid assertion URL: https://github.com/apache/incubator-shardingsphere/pull/4695#issuecomment-597013092 ## Pull Request Test Coverage Report for [Build 2058](https://coveralls.io/builds/29245697) * **0** of **0** changed or added relevant lines in **0** files are covered. * No unchanged relevant lines lost coverage. * Overall coverage increased (+**0.07%**) to **59.101%** --- | Totals | [![Coverage Status](https://coveralls.io/builds/29245697/badge)](https://coveralls.io/builds/29245697) | | :-- | --: | | Change from base [Build 1037](https://coveralls.io/builds/29241018): | 0.07% | | Covered Lines: | 12111 | | Relevant Lines: | 20492 | --- # 💛 - [Coveralls](https://coveralls.io) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] coveralls commented on issue #4695: Delete invalid assertion
coveralls commented on issue #4695: Delete invalid assertion URL: https://github.com/apache/incubator-shardingsphere/pull/4695#issuecomment-597013092 ## Pull Request Test Coverage Report for [Build 2059](https://coveralls.io/builds/29245723) * **0** of **0** changed or added relevant lines in **0** files are covered. * No unchanged relevant lines lost coverage. * Overall coverage increased (+**0.07%**) to **59.101%** --- | Totals | [![Coverage Status](https://coveralls.io/builds/29245723/badge)](https://coveralls.io/builds/29245723) | | :-- | --: | | Change from base [Build 1037](https://coveralls.io/builds/29241018): | 0.07% | | Covered Lines: | 12111 | | Relevant Lines: | 20492 | --- # 💛 - [Coveralls](https://coveralls.io) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] Zhumingj opened a new issue #4697: Cannot find table rule and default data source with logic tables
Zhumingj opened a new issue #4697: Cannot find table rule and default data source with logic tables URL: https://github.com/apache/incubator-shardingsphere/issues/4697 Please, when only databases need to shard and tables need not to shard, how can I omit the following configuration, such as: spring.shardingsphere.sharding.tables.tb_order.actual-data-nodes= If it has to be configured, if there are hundreds of tables, does it need to be configured hundreds of times? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] coveralls edited a comment on issue #4693: Refactor MySQL generic and auth protocol packets.
coveralls edited a comment on issue #4693: Refactor MySQL generic and auth protocol packets. URL: https://github.com/apache/incubator-shardingsphere/pull/4693#issuecomment-596992723 ## Pull Request Test Coverage Report for [Build 10158](https://coveralls.io/builds/29245486) * **80** of **81** **(98.77%)** changed or added relevant lines in **7** files are covered. * **3** unchanged lines in **1** file lost coverage. * Overall coverage increased (+**0.1%**) to **59.145%** --- | Changes Missing Coverage | Covered Lines | Changed/Added Lines | % | | :-|--||---: | | [shardingsphere-database-protocol/shardingsphere-database-protocol-mysql/src/main/java/org/apache/shardingsphere/database/protocol/mysql/packet/handshake/MySQLHandshakePacket.java](https://coveralls.io/builds/29245486/source?filename=shardingsphere-database-protocol%2Fshardingsphere-database-protocol-mysql%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fdatabase%2Fprotocol%2Fmysql%2Fpacket%2Fhandshake%2FMySQLHandshakePacket.java#L35) | 31 | 32 | 96.88% | Files with Coverage Reduction | New Missed Lines | % | | :-|--|--: | | [sharding-orchestration/sharding-orchestration-core/src/main/java/org/apache/shardingsphere/orchestration/internal/util/IpUtils.java](https://coveralls.io/builds/29245486/source?filename=sharding-orchestration%2Fsharding-orchestration-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Forchestration%2Finternal%2Futil%2FIpUtils.java#L63) | 3 | 76.0% | | Totals | [![Coverage Status](https://coveralls.io/builds/29245486/badge)](https://coveralls.io/builds/29245486) | | :-- | --: | | Change from base [Build 1037](https://coveralls.io/builds/29241018): | 0.1% | | Covered Lines: | 12156 | | Relevant Lines: | 20553 | --- # 💛 - [Coveralls](https://coveralls.io) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] tristaZero opened a new issue #4696: Make subquery parsing test work well
tristaZero opened a new issue #4696: Make subquery parsing test work well URL: https://github.com/apache/incubator-shardingsphere/issues/4696 To make the following subquery parsing test work well, we need to review the parsing process for subquery SQL. - Subquery in `./incubator-shardingsphere/sharding-sql-test/src/main/resources/sql/supported/dql/select.xml` - Subquery in `./incubator-shardingsphere/sharding-sql-test/src/main/resources/sql/supported/dql/select-sub-query.xml` - Subquery in `./incubator-shardingsphere/sharding-sql-test/src/main/resources/sql/supported/dql/select-pagination.xml` - Subquery in `./incubator-shardingsphere/sharding-sql-test/src/main/resources/sql/supported/dql/select-pagination-group-by-order-by.xml` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] codecov-io commented on issue #4693: Refactor MySQL generic and auth protocol packets.
codecov-io commented on issue #4693: Refactor MySQL generic and auth protocol packets. URL: https://github.com/apache/incubator-shardingsphere/pull/4693#issuecomment-597005560 # [Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4693?src=pr&el=h1) Report > Merging [#4693](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4693?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-shardingsphere/commit/6fcd9b4bc8d4747d85d28bb948c0d5fc0cec8ce0?src=pr&el=desc) will **increase** coverage by `0.1%`. > The diff coverage is `91.35%`. [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4693/graphs/tree.svg?width=650&token=ZvlXpWa7so&height=150&src=pr)](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4693?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master#4693 +/- ## === + Coverage 55.48% 55.58% +0.1% Complexity 426 426 === Files 1134 1135 +1 Lines 2049220553 +61 Branches 3799 3812 +13 === + Hits 1136911425 +56 Misses 8409 8409 - Partials714 719 +5 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4693?src=pr&el=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...abase/protocol/mysql/constant/MySQLStatusFlag.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4693/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtZGF0YWJhc2UtcHJvdG9jb2wvc2hhcmRpbmdzcGhlcmUtZGF0YWJhc2UtcHJvdG9jb2wtbXlzcWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2RhdGFiYXNlL3Byb3RvY29sL215c3FsL2NvbnN0YW50L015U1FMU3RhdHVzRmxhZy5qYXZh) | `100% <100%> (ø)` | `0 <0> (ø)` | :arrow_down: | | [...ocol/mysql/constant/MySQLAuthenticationMethod.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4693/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtZGF0YWJhc2UtcHJvdG9jb2wvc2hhcmRpbmdzcGhlcmUtZGF0YWJhc2UtcHJvdG9jb2wtbXlzcWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2RhdGFiYXNlL3Byb3RvY29sL215c3FsL2NvbnN0YW50L015U1FMQXV0aGVudGljYXRpb25NZXRob2QuamF2YQ==) | `100% <100%> (ø)` | `0 <0> (?)` | | | [...cket/handshake/MySQLHandshakeResponse41Packet.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4693/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtZGF0YWJhc2UtcHJvdG9jb2wvc2hhcmRpbmdzcGhlcmUtZGF0YWJhc2UtcHJvdG9jb2wtbXlzcWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2RhdGFiYXNlL3Byb3RvY29sL215c3FsL3BhY2tldC9oYW5kc2hha2UvTXlTUUxIYW5kc2hha2VSZXNwb25zZTQxUGFja2V0LmphdmE=) | `97.91% <100%> (+0.69%)` | `0 <0> (ø)` | :arrow_down: | | [.../protocol/mysql/packet/generic/MySQLEofPacket.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4693/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtZGF0YWJhc2UtcHJvdG9jb2wvc2hhcmRpbmdzcGhlcmUtZGF0YWJhc2UtcHJvdG9jb2wtbXlzcWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2RhdGFiYXNlL3Byb3RvY29sL215c3FsL3BhY2tldC9nZW5lcmljL015U1FMRW9mUGFja2V0LmphdmE=) | `84.61% <83.33%> (-1.1%)` | `0 <0> (ø)` | | | [...l/mysql/packet/handshake/MySQLHandshakePacket.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4693/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtZGF0YWJhc2UtcHJvdG9jb2wvc2hhcmRpbmdzcGhlcmUtZGF0YWJhc2UtcHJvdG9jb2wtbXlzcWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2RhdGFiYXNlL3Byb3RvY29sL215c3FsL3BhY2tldC9oYW5kc2hha2UvTXlTUUxIYW5kc2hha2VQYWNrZXQuamF2YQ==) | `88.88% <87.5%> (-0.59%)` | `1 <0> (ø)` | | | [.../protocol/mysql/packet/generic/MySQLErrPacket.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4693/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtZGF0YWJhc2UtcHJvdG9jb2wvc2hhcmRpbmdzcGhlcmUtZGF0YWJhc2UtcHJvdG9jb2wtbXlzcWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2RhdGFiYXNlL3Byb3RvY29sL215c3FsL3BhY2tldC9nZW5lcmljL015U1FMRXJyUGFja2V0LmphdmE=) | `88.23% <87.5%> (-0.66%)` | `0 <0> (ø)` | | | [...e/protocol/mysql/packet/generic/MySQLOKPacket.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4693/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtZGF0YWJhc2UtcHJvdG9jb2wvc2hhcmRpbmdzcGhlcmUtZGF0YWJhc2UtcHJvdG9jb2wtbXlzcWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2RhdGFiYXNlL3Byb3RvY29sL215c3FsL3BhY2tldC9nZW5lcmljL015U1FMT0tQYWNrZXQuamF2YQ==) | `90.9% <92.3%> (-1.4%)` | `0 <0> (ø)` | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4693?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by
[GitHub] [incubator-shardingsphere] tristaZero opened a new pull request #4695: Delete invalid assertion
tristaZero opened a new pull request #4695: Delete invalid assertion URL: https://github.com/apache/incubator-shardingsphere/pull/4695 Fixes #4694. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] tristaZero opened a new issue #4694: Remove invalid assertion for parsing integrated tests
tristaZero opened a new issue #4694: Remove invalid assertion for parsing integrated tests URL: https://github.com/apache/incubator-shardingsphere/issues/4694 The assertion in the following class is supposed to remove. - [ ] OrderByItemAssert - [ ] AssignmentValueAssert This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] KomachiSion commented on issue #4669: ComplexKeysShardingAlgorithm && HintShardingAlgorithm
KomachiSion commented on issue #4669: ComplexKeysShardingAlgorithm && HintShardingAlgorithm URL: https://github.com/apache/incubator-shardingsphere/issues/4669#issuecomment-596998624 I can't understand your problem, please change your issue title and description. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] jingshanglu commented on issue #4683: Refer to DB doc to review the rule definition in each g4 file
jingshanglu commented on issue #4683: Refer to DB doc to review the rule definition in each g4 file URL: https://github.com/apache/incubator-shardingsphere/issues/4683#issuecomment-596995941 I'll support This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] jingshanglu commented on issue #4671: Parsing more segments
jingshanglu commented on issue #4671: Parsing more segments URL: https://github.com/apache/incubator-shardingsphere/issues/4671#issuecomment-596995647 I'll support This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] coveralls commented on issue #4693: Refactor MySQL generic and auth protocol packets.
coveralls commented on issue #4693: Refactor MySQL generic and auth protocol packets. URL: https://github.com/apache/incubator-shardingsphere/pull/4693#issuecomment-596992723 ## Pull Request Test Coverage Report for [Build 2057](https://coveralls.io/builds/29244517) * **80** of **81** **(98.77%)** changed or added relevant lines in **7** files are covered. * No unchanged relevant lines lost coverage. * Overall coverage increased (+**0.2%**) to **59.222%** --- | Changes Missing Coverage | Covered Lines | Changed/Added Lines | % | | :-|--||---: | | [shardingsphere-database-protocol/shardingsphere-database-protocol-mysql/src/main/java/org/apache/shardingsphere/database/protocol/mysql/packet/handshake/MySQLHandshakePacket.java](https://coveralls.io/builds/29244517/source?filename=shardingsphere-database-protocol%2Fshardingsphere-database-protocol-mysql%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fdatabase%2Fprotocol%2Fmysql%2Fpacket%2Fhandshake%2FMySQLHandshakePacket.java#L35) | 31 | 32 | 96.88% | Totals | [![Coverage Status](https://coveralls.io/builds/29244517/badge)](https://coveralls.io/builds/29244517) | | :-- | --: | | Change from base [Build 1037](https://coveralls.io/builds/29241018): | 0.2% | | Covered Lines: | 12172 | | Relevant Lines: | 20553 | --- # 💛 - [Coveralls](https://coveralls.io) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere-doc] tristaZero merged pull request #452: adjust the link of community
tristaZero merged pull request #452: adjust the link of community URL: https://github.com/apache/incubator-shardingsphere-doc/pull/452 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere-doc] tristaZero closed issue #451: Adjust the link of Community
tristaZero closed issue #451: Adjust the link of Community URL: https://github.com/apache/incubator-shardingsphere-doc/issues/451 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] coveralls edited a comment on issue #4687: Refactor orchestration phase 1.1.1
coveralls edited a comment on issue #4687: Refactor orchestration phase 1.1.1 URL: https://github.com/apache/incubator-shardingsphere/pull/4687#issuecomment-596925907 ## Pull Request Test Coverage Report for [Build 10156](https://coveralls.io/builds/29244146) * **7** of **9** **(77.78%)** changed or added relevant lines in **4** files are covered. * **3** unchanged lines in **1** file lost coverage. * Overall coverage increased (+**0.001%**) to **59.029%** --- | Changes Missing Coverage | Covered Lines | Changed/Added Lines | % | | :-|--||---: | | [sharding-orchestration/sharding-orchestration-core/src/main/java/org/apache/shardingsphere/orchestration/internal/registry/config/listener/SchemaChangedListener.java](https://coveralls.io/builds/29244146/source?filename=sharding-orchestration%2Fsharding-orchestration-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Forchestration%2Finternal%2Fregistry%2Fconfig%2Flistener%2FSchemaChangedListener.java#L95) | 1 | 3 | 33.33% | Files with Coverage Reduction | New Missed Lines | % | | :-|--|--: | | [sharding-orchestration/sharding-orchestration-core/src/main/java/org/apache/shardingsphere/orchestration/internal/util/IpUtils.java](https://coveralls.io/builds/29244146/source?filename=sharding-orchestration%2Fsharding-orchestration-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Forchestration%2Finternal%2Futil%2FIpUtils.java#L63) | 3 | 76.0% | | Totals | [![Coverage Status](https://coveralls.io/builds/29244146/badge)](https://coveralls.io/builds/29244146) | | :-- | --: | | Change from base [Build 1037](https://coveralls.io/builds/29241018): | 0.001% | | Covered Lines: | 12098 | | Relevant Lines: | 20495 | --- # 💛 - [Coveralls](https://coveralls.io) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] geomonlin commented on issue #4690: Add start-index and stop-index assertion for ColumnOrderByItemSegment
geomonlin commented on issue #4690: Add start-index and stop-index assertion for ColumnOrderByItemSegment URL: https://github.com/apache/incubator-shardingsphere/issues/4690#issuecomment-596984079 I'm interested. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] codecov-io commented on issue #4687: Refactor orchestration phase 1.1.1
codecov-io commented on issue #4687: Refactor orchestration phase 1.1.1 URL: https://github.com/apache/incubator-shardingsphere/pull/4687#issuecomment-596981551 # [Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4687?src=pr&el=h1) Report > Merging [#4687](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4687?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-shardingsphere/commit/6fcd9b4bc8d4747d85d28bb948c0d5fc0cec8ce0?src=pr&el=desc) will **increase** coverage by `<.01%`. > The diff coverage is `77.77%`. [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4687/graphs/tree.svg?width=650&token=ZvlXpWa7so&height=150&src=pr)](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4687?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master#4687 +/- ## + Coverage 55.48% 55.48% +<.01% Complexity 426 426 Files 1134 1135 +1 Lines 2049220495 +3 Branches 3799 3799 + Hits 1136911372 +3 Misses 8409 8409 Partials714 714 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4687?src=pr&el=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [.../orchestration/center/instance/ApolloInstance.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4687/diff?src=pr&el=tree#diff-c2hhcmRpbmctb3JjaGVzdHJhdGlvbi9zaGFyZGluZy1vcmNoZXN0cmF0aW9uLWNlbnRlci9zaGFyZGluZy1vcmNoZXN0cmF0aW9uLWNlbnRlci1hcG9sbG8vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL29yY2hlc3RyYXRpb24vY2VudGVyL2luc3RhbmNlL0Fwb2xsb0luc3RhbmNlLmphdmE=) | `59.45% <100%> (ø)` | `0 <0> (ø)` | :arrow_down: | | [...ngsphere/orchestration/internal/util/MapUtils.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4687/diff?src=pr&el=tree#diff-c2hhcmRpbmctb3JjaGVzdHJhdGlvbi9zaGFyZGluZy1vcmNoZXN0cmF0aW9uLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL29yY2hlc3RyYXRpb24vaW50ZXJuYWwvdXRpbC9NYXBVdGlscy5qYXZh) | `100% <100%> (ø)` | `0 <0> (?)` | | | [.../registry/config/service/ConfigurationService.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4687/diff?src=pr&el=tree#diff-c2hhcmRpbmctb3JjaGVzdHJhdGlvbi9zaGFyZGluZy1vcmNoZXN0cmF0aW9uLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL29yY2hlc3RyYXRpb24vaW50ZXJuYWwvcmVnaXN0cnkvY29uZmlnL3NlcnZpY2UvQ29uZmlndXJhdGlvblNlcnZpY2UuamF2YQ==) | `76% <100%> (ø)` | `0 <0> (ø)` | :arrow_down: | | [...egistry/config/listener/SchemaChangedListener.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4687/diff?src=pr&el=tree#diff-c2hhcmRpbmctb3JjaGVzdHJhdGlvbi9zaGFyZGluZy1vcmNoZXN0cmF0aW9uLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL29yY2hlc3RyYXRpb24vaW50ZXJuYWwvcmVnaXN0cnkvY29uZmlnL2xpc3RlbmVyL1NjaGVtYUNoYW5nZWRMaXN0ZW5lci5qYXZh) | `71.42% <33.33%> (ø)` | `0 <0> (ø)` | :arrow_down: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4687?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4687?src=pr&el=footer). Last update [6fcd9b4...d2710b0](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4687?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] KomachiSion opened a new pull request #4693: Refactor MySQL generic and auth protocol packets.
KomachiSion opened a new pull request #4693: Refactor MySQL generic and auth protocol packets. URL: https://github.com/apache/incubator-shardingsphere/pull/4693 For #4594 . Changes proposed in this pull request: - Refactor MySQL generic protocol packets - Refactor MySQL auth protocol packets. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] Zhumingj opened a new issue #4692: Cannot find table rule and default data source with logic tables
Zhumingj opened a new issue #4692: Cannot find table rule and default data source with logic tables URL: https://github.com/apache/incubator-shardingsphere/issues/4692 请问,在只分库不分表的时候,怎么避免如下配置: spring.shardingsphere.sharding.tables.tb_order.actual-data-nodes= 如果必须配置, 那如果有几百张表,难道需要配置几百次吗? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] coveralls commented on issue #4689: Add support for shadow in proxy
coveralls commented on issue #4689: Add support for shadow in proxy URL: https://github.com/apache/incubator-shardingsphere/pull/4689#issuecomment-596950171 ## Pull Request Test Coverage Report for [Build 2056](https://coveralls.io/builds/29242539) * **8** of **71** **(11.27%)** changed or added relevant lines in **6** files are covered. * **5** unchanged lines in **3** files lost coverage. * Overall coverage decreased (**-0.09%**) to **58.942%** --- | Changes Missing Coverage | Covered Lines | Changed/Added Lines | % | | :-|--||---: | | [sharding-proxy/sharding-proxy-backend/src/main/java/org/apache/shardingsphere/shardingproxy/backend/schema/LogicSchemaFactory.java](https://coveralls.io/builds/29242539/source?filename=sharding-proxy%2Fsharding-proxy-backend%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingproxy%2Fbackend%2Fschema%2FLogicSchemaFactory.java#L64) | 0 | 2 | 0.0% | [sharding-proxy/sharding-proxy-bootstrap/src/main/java/org/apache/shardingsphere/shardingproxy/Bootstrap.java](https://coveralls.io/builds/29242539/source?filename=sharding-proxy%2Fsharding-proxy-bootstrap%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingproxy%2FBootstrap.java#L150) | 0 | 4 | 0.0% | [sharding-proxy/sharding-proxy-backend/src/main/java/org/apache/shardingsphere/shardingproxy/backend/schema/impl/ShadowSchema.java](https://coveralls.io/builds/29242539/source?filename=sharding-proxy%2Fsharding-proxy-backend%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingproxy%2Fbackend%2Fschema%2Fimpl%2FShadowSchema.java#L58) | 0 | 15 | 0.0% | [sharding-proxy/sharding-proxy-backend/src/main/java/org/apache/shardingsphere/shardingproxy/backend/communication/jdbc/wrapper/PreparedStatementExecutorWrapper.java](https://coveralls.io/builds/29242539/source?filename=sharding-proxy%2Fsharding-proxy-backend%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingproxy%2Fbackend%2Fcommunication%2Fjdbc%2Fwrapper%2FPreparedStatementExecutorWrapper.java#L84) | 0 | 21 | 0.0% | [sharding-proxy/sharding-proxy-backend/src/main/java/org/apache/shardingsphere/shardingproxy/backend/communication/jdbc/wrapper/StatementExecutorWrapper.java](https://coveralls.io/builds/29242539/source?filename=sharding-proxy%2Fsharding-proxy-backend%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingproxy%2Fbackend%2Fcommunication%2Fjdbc%2Fwrapper%2FStatementExecutorWrapper.java#L81) | 0 | 21 | 0.0% | Files with Coverage Reduction | New Missed Lines | % | | :-|--|--: | | [sharding-proxy/sharding-proxy-backend/src/main/java/org/apache/shardingsphere/shardingproxy/backend/schema/LogicSchemaFactory.java](https://coveralls.io/builds/29242539/source?filename=sharding-proxy%2Fsharding-proxy-backend%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingproxy%2Fbackend%2Fschema%2FLogicSchemaFactory.java#L67) | 1 | 0% | | [sharding-proxy/sharding-proxy-backend/src/main/java/org/apache/shardingsphere/shardingproxy/backend/communication/jdbc/wrapper/PreparedStatementExecutorWrapper.java](https://coveralls.io/builds/29242539/source?filename=sharding-proxy%2Fsharding-proxy-backend%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingproxy%2Fbackend%2Fcommunication%2Fjdbc%2Fwrapper%2FPreparedStatementExecutorWrapper.java#L87) | 2 | 1.54% | | [sharding-proxy/sharding-proxy-backend/src/main/java/org/apache/shardingsphere/shardingproxy/backend/communication/jdbc/wrapper/StatementExecutorWrapper.java](https://coveralls.io/builds/29242539/source?filename=sharding-proxy%2Fsharding-proxy-backend%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingproxy%2Fbackend%2Fcommunication%2Fjdbc%2Fwrapper%2FStatementExecutorWrapper.java#L84) | 2 | 1.61% | | Totals | [![Coverage Status](https://coveralls.io/builds/29242539/badge)](https://coveralls.io/builds/29242539) | | :-- | --: | | Change from base [Build 1037](https://coveralls.io/builds/29241018): | -0.09% | | Covered Lines: | 12119 | | Relevant Lines: | 20561 | --- # 💛 - [Coveralls](https://coveralls.io) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu opened a new issue #4691: Move database and table meta data to shardingsphere-sql-parser-binder module
terrymanu opened a new issue #4691: Move database and table meta data to shardingsphere-sql-parser-binder module URL: https://github.com/apache/incubator-shardingsphere/issues/4691 The current meta data is in shardingsphere-common module. The meta data is the base information of binder module. The sql-parser module is the infra of ShardingSphere, so it is better for shardingsphere-common dependent shardingsphere-sql-parser module, but shardingsphere-sql-parser module do not care about who are using. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] tristaZero opened a new issue #4690: Add start-index and stop-index assertion for ColumnOrderByItemSegment
tristaZero opened a new issue #4690: Add start-index and stop-index assertion for ColumnOrderByItemSegment URL: https://github.com/apache/incubator-shardingsphere/issues/4690 This issue is to count the `start-index` and `stop-index` to assert `ColumnOrderByItemSegment ` ### How to find the targets to be fixed? 1. Open class `OrderByItemAssert` and clear the comment of `SQLSegmentAssert.assertIs(assertContext, actual, expected)` in `assertColumnOrderByItem`. 2. run `SQLParserParameterizedTest` 3. All the SQL cases which have the error assertion results are our targets to be fixed. ### How to fix the above assertion results? 1. Look at the exception log and find the corresponding `SQL Case ID` and `SQL`. 2. Find out the `parsing result` of this `SQL Case ID` in `./incubator-shardingsphere/shardingsphere-sql-parser/shardingsphere-sql-parser-test/src/test/resources/sql/dml` 3. Calculate the correct `start-index` and `stop-index` of `order-by` segment of this `SQL`. 4. Add the calculated `start-index` and `stop-index` labels of `order-by` segment to `parsing result` of this `SQL Case ID`, like ``` ``` 5. Add the correct `literal-start-index` and `literal-stop-index` of `order-by` segment to `parsing result` of this `SQL Case ID` when it is necessary, like ``` ``` 6. Run `SQLParserParameterizedTest` again to check whether this `SQL Case ID` does not stay in the list of `SQL` with `bad assertion result`. ### Note 1. What is the difference between `literal-start-index` and `start-index`? When a SQL does not contain parameter maker, i.e.,`?`, this SQL only has one form; Otherwise, you will see two forms of this SQL, i.e, a SQL form filled with parameter and a SQL form only with parameter marks. For instance, ``` Case1 One SQL without parameter mark, select * from table where id = 1; Case2 One SQL with parameter mark, Original SQL: select * from table where id = ?; SQL filled with Parameter: select * from table where id = 1; ``` Replace `the parameter mark` with `the actual parameter` will change the position of the segment. Therefore we need to add `start-index` to represent the start position of a segment for `Original SQL`, and `literal-start-index` is used to represent the start position of a segment for `SQL filled with Parameter`. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] yanyzy opened a new pull request #4689: Add support for shadow in proxy
yanyzy opened a new pull request #4689: Add support for shadow in proxy URL: https://github.com/apache/incubator-shardingsphere/pull/4689 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu opened a new issue #4688: Split shardingsphere-sql-parser-engine module to engine
terrymanu opened a new issue #4688: Split shardingsphere-sql-parser-engine module to engine URL: https://github.com/apache/incubator-shardingsphere/issues/4688 ## Bug Report **For English only**, other languages will not accept. Before report a bug, make sure you have: - Searched open and closed [GitHub issues](https://github.com/apache/incubator-shardingsphere/issues). - Read documentation: [ShardingSphere Doc](https://shardingsphere.apache.org/document/current/en/overview). Please pay attention on issues you submitted, because we maybe need more details. If no response **more than 7 days** and we cannot reproduce it on current information, we will **close it**. Please answer these questions before submitting your issue. Thanks! ### Which version of ShardingSphere did you use? ### Which project did you use? Sharding-JDBC or Sharding-Proxy? ### Expected behavior ### Actual behavior ### Reason analyze (If you can) ### Steps to reproduce the behavior, such as: SQL to execute, sharding rule configuration, when exception occur etc. ### Example codes for reproduce this issue (such as a github link). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services