[GitHub] [incubator-shardingsphere] fantacy2001 commented on issue #4861: two tables left join with different routing rules are not supported
fantacy2001 commented on issue #4861: two tables left join with different routing rules are not supported URL: https://github.com/apache/incubator-shardingsphere/issues/4861#issuecomment-604263642 > When the shardingsphere route the sql, it does not find the table b's sharding key, so it will cause a full route. > To avoid it, you may add the table b's sharding key after where condition.And now shardingsphere may not use the condition after 'on' clause. In the future，Whether shardingsphere can be considered ‘on’ after join? because by convention, For old system upgrades， only write main table's sharding value after 'where' 。 or add config like bindtables ，to achieve this function This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] ssxlulu commented on issue #4861: two tables left join with different routing rules are not supported
ssxlulu commented on issue #4861: two tables left join with different routing rules are not supported URL: https://github.com/apache/incubator-shardingsphere/issues/4861#issuecomment-604267702 > > When the shardingsphere route the sql, it does not find the table b's sharding key, so it will cause a full route. > > To avoid it, you may add the table b's sharding key after where condition.And now shardingsphere may not use the condition after 'on' clause. > > In the future，Whether shardingsphere can be considered ‘on’ after join? because by convention, For old system upgrades， only write main table's sharding value after 'where' 。 > or add config like bindtables ，to achieve this function It depends on requirement and the implementation of the route algorithm. In my opinion, shardingsphere may not considered the 'on' clause for routing. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] zjls007 opened a new issue #4954: how i use sharding-jdbc-spring-boot-starter with spring-jdbc use seata-at, your example is
zjls007 opened a new issue #4954: how i use sharding-jdbc-spring-boot-starter with spring-jdbc use seata-at,your example is URL: https://github.com/apache/incubator-shardingsphere/issues/4954 ## Question **For English only**, other languages will not accept. Before asking a question, make sure you have: - Googled your question. - Searched open and closed [GitHub issues](https://github.com/apache/incubator-shardingsphere/issues). - Read documentation: [ShardingSphere Doc](https://shardingsphere.apache.org/document/current/en/overview). Please pay attention on issues you submitted, because we maybe need more details. If no response **more than 7 days** and we cannot reproduce it on current information, we will **close it**. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] zjls007 commented on issue #4954: how i use sharding-jdbc-spring-boot-starter with spring-jdbc use seata-at, your example is raw-jdbc, can you help me
zjls007 commented on issue #4954: how i use sharding-jdbc-spring-boot-starter with spring-jdbc use seata-at,your example is raw-jdbc, can you help me URL: https://github.com/apache/incubator-shardingsphere/issues/4954#issuecomment-604269747 also can replease spring-jdbc to mybatis This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] kimmking commented on issue #4947: Is there any way to traverse tables in the specified order by Schema & Table Route
kimmking commented on issue #4947: Is there any way to traverse tables in the specified order by Schema & Table Route URL: https://github.com/apache/incubator-shardingsphere/issues/4947#issuecomment-604282336 I think we should broadcast to all sharding tables and merge results. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] kimmking commented on issue #4953: Can we specify some specific database operations without parsing through the shardingsphere framework
kimmking commented on issue #4953: Can we specify some specific database operations without parsing through the shardingsphere framework URL: https://github.com/apache/incubator-shardingsphere/issues/4953#issuecomment-604283083 > ## Question > We used shardingsphere v5.0.0 > > There may be some instability now. We want to go around > > When we use shardingsphere framework for sub database > > Can we specify some specific database operations without parsing through the shardingsphere framework？ > > Some places are uncontrollable. We hope to directly perform DB operations through mybatis instead of shardingsphere, I misunderstand `Some places are uncontrollable`. Can you show a certain case？ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] kimmking commented on issue #4954: how i use sharding-jdbc-spring-boot-starter with spring-jdbc use seata-at, your example is raw-jdbc, can you help me
kimmking commented on issue #4954: how i use sharding-jdbc-spring-boot-starter with spring-jdbc use seata-at,your example is raw-jdbc, can you help me URL: https://github.com/apache/incubator-shardingsphere/issues/4954#issuecomment-604284699 [SpringBoot2.x 集成ShardingSphere+Seata+Mybatis-Plus+DruidDataSource](https://www.jianshu.com/p/41ebdaf403c8) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] phoema commented on issue #4953: Can we specify some specific database operations without parsing through the shardingsphere framework
phoema commented on issue #4953: Can we specify some specific database operations without parsing through the shardingsphere framework URL: https://github.com/apache/incubator-shardingsphere/issues/4953#issuecomment-604284837 example: we have some complex sqls like many join tables and with functions but now shardingsphere Support not well， so we want to go around only excute the sql with out shardingsphere parse。 is have any way to do this? func_inc_var_session is our customer function select `func_inc_var_session`(`t`.`procinsid`,`t`.`task_def_key`,0) AS `rownum`, from `act_hi_taskinst` `a` left join `act_hi_procinst` on((`a`.`PROC_INST_ID_` = `act_hi_procinst`.`ID_`))) left join `flow_extend` on((`act_hi_procinst`.`BUSINESS_KEY_` = `flow_extend`.`id`))) left join `case_info` on((`flow_extend`.`case_id` = `case_info`.`id`))) left join `flow_define` on((`flow_extend`.`flow_def_id` = `flow_define`.`id`))) where (`a`.`ASSIGNEE_` is not null) order by `a`.`PROC_INST_ID_`,`a`.`TASK_DEF_KEY_`,`a`.`START_TIME_` desc) `t` join (select `func_inc_var_session`(NULL,NULL,1) AS `func_inc_var_session(null,null,1)`) `b`) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] phoema commented on issue #4953: Can we specify some specific database operations without parsing through the shardingsphere framework
phoema commented on issue #4953: Can we specify some specific database operations without parsing through the shardingsphere framework URL: https://github.com/apache/incubator-shardingsphere/issues/4953#issuecomment-604285385 when we excute this sql shardingsphere can not know which database can excute so it excute with default database but we want to excute a special tenant This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu commented on issue #4953: Can we specify some specific database operations without parsing through the shardingsphere framework
terrymanu commented on issue #4953: Can we specify some specific database operations without parsing through the shardingsphere framework URL: https://github.com/apache/incubator-shardingsphere/issues/4953#issuecomment-604288621 No. SQL parser is the basic workflow with ShardingSphere. It is unnecessary using ShardingSphere if user do not need SQL parser. It is the production design with ShardingSphere. So user may do not use ShardingSphere if feature without SQL parser. ShardingSphere is not the only way to process business logic in the middle layer. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu edited a comment on issue #4953: Can we specify some specific database operations without parsing through the shardingsphere framework
terrymanu edited a comment on issue #4953: Can we specify some specific database operations without parsing through the shardingsphere framework URL: https://github.com/apache/incubator-shardingsphere/issues/4953#issuecomment-604288621 No. SQL parser is the basic workflow with ShardingSphere. It is unnecessary using ShardingSphere if user do not need SQL parser. It is the production design with ShardingSphere. So user may do not use ShardingSphere if feature without SQL parser. ShardingSphere is not the only way to process business logic in the middle layer. Even the SQL parser is not perfect for now, we still need to do the SQL parse. The project is still in dev mode, so we need to continue to improve the SQL parser engine. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu edited a comment on issue #4953: Can we specify some specific database operations without parsing through the shardingsphere framework
terrymanu edited a comment on issue #4953: Can we specify some specific database operations without parsing through the shardingsphere framework URL: https://github.com/apache/incubator-shardingsphere/issues/4953#issuecomment-604288621 No. SQL parser is the basic workflow with ShardingSphere. It is unnecessary to use ShardingSphere if user do not need SQL parser. It is the production design with ShardingSphere. So user may do not use ShardingSphere if feature without SQL parser. ShardingSphere is not the only way to process business logic in the middle layer. Even the SQL parser is not perfect for now, we still need to do the SQL parse. The project is still in dev mode, so we need to continue to improve the SQL parser engine. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] kimmking commented on issue #4953: Can we specify some specific database operations without parsing through the shardingsphere framework
kimmking commented on issue #4953: Can we specify some specific database operations without parsing through the shardingsphere framework URL: https://github.com/apache/incubator-shardingsphere/issues/4953#issuecomment-604289147 Configure two DataSource, one is ShardingDataSource of ShardingSphere, one is a native DataSource of Hikari or Druid. Inject the first one when you want to sharding databases&tables. Inject the following one when you want to directly pass through native sql. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] GolderGao commented on issue #4947: Is there any way to traverse tables in the specified order by Schema & Table Route
GolderGao commented on issue #4947: Is there any way to traverse tables in the specified order by Schema & Table Route URL: https://github.com/apache/incubator-shardingsphere/issues/4947#issuecomment-604289488 @kimmking I have two questions, would like to consult shardingjdbc how to deal with? 1. If I create a table every month in 2020, and each table stores the data for that month, I just want to find the table with the data, and the table without the data will not query. 2. It is now march, and I only have 3 tables to store data, namely table_1,table_2, and table_3. The other 9 tables do not store data (table_4...).Table_12, I want to query data, first from the current month, and then to the previous month query, there is no data table query This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu edited a comment on issue #4953: Can we specify some specific database operations without parsing through the shardingsphere framework
terrymanu edited a comment on issue #4953: Can we specify some specific database operations without parsing through the shardingsphere framework URL: https://github.com/apache/incubator-shardingsphere/issues/4953#issuecomment-604288621 No. SQL parser is the basic workflow with ShardingSphere. It is unnecessary to use ShardingSphere if user do not need SQL parser. It is the production design with ShardingSphere. So user may do not use ShardingSphere if the requirement without SQL parser. ShardingSphere is not the only way to process business logic in the middle layer. Even the SQL parser is not perfect for now, we still need to do the SQL parse. The project is still in dev mode, so we need to continue to improve the SQL parser engine. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] phoema commented on issue #4953: Can we specify some specific database operations without parsing through the shardingsphere framework
phoema commented on issue #4953: Can we specify some specific database operations without parsing through the shardingsphere framework URL: https://github.com/apache/incubator-shardingsphere/issues/4953#issuecomment-604289638 > Configure two DataSource, one is ShardingDataSource of ShardingSphere, one is a native DataSource of Hikari or Druid. > > Inject the first one when you want to sharding databases&tables. > Inject the following one when you want to directly pass through native sql. I will try it. thanks! This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu closed issue #4953: Can we specify some specific database operations without parsing through the shardingsphere framework
terrymanu closed issue #4953: Can we specify some specific database operations without parsing through the shardingsphere framework URL: https://github.com/apache/incubator-shardingsphere/issues/4953 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] yu199195 opened a new pull request #4955: lambda code modify.
yu199195 opened a new pull request #4955: lambda code modify. URL: https://github.com/apache/incubator-shardingsphere/pull/4955 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu commented on a change in pull request #4955: lambda code modify.
terrymanu commented on a change in pull request #4955: lambda code modify.
URL:
https://github.com/apache/incubator-shardingsphere/pull/4955#discussion_r398395061
##
File path:
shardingsphere-underlying/shardingsphere-common/src/main/java/org/apache/shardingsphere/underlying/common/database/type/DatabaseTypes.java
##
@@ -60,40 +61,29 @@ public static DatabaseType getTrunkDatabaseType(final
String name) {
/**
* Get actual database type.
+ * @param name database name
*
- * @param name database name
* @return actual database type
*/
public static DatabaseType getActualDatabaseType(final String name) {
-Preconditions.checkState(DATABASE_TYPES.containsKey(name),
"Unsupported database: '%s'", name);
-return DATABASE_TYPES.get(name);
+return Optional.ofNullable(DATABASE_TYPES.get(name)).orElseThrow(() ->
new ShardingSphereException("Unsupported database:'%s'", name));
}
/**
* Get database type by URL.
- *
* @param url database URL
+ *
Review comment:
Please do not modify original javadoc
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu commented on a change in pull request #4955: lambda code modify.
terrymanu commented on a change in pull request #4955: lambda code modify. URL: https://github.com/apache/incubator-shardingsphere/pull/4955#discussion_r398394707 ## File path: shardingsphere-underlying/shardingsphere-common/src/main/java/org/apache/shardingsphere/underlying/common/database/type/DatabaseTypes.java ## @@ -40,8 +41,8 @@ /** * Get name of trunk database type. - * * @param databaseType database type + * Review comment: Please do not modify original javadoc This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu commented on a change in pull request #4955: lambda code modify.
terrymanu commented on a change in pull request #4955: lambda code modify.
URL:
https://github.com/apache/incubator-shardingsphere/pull/4955#discussion_r398394882
##
File path:
shardingsphere-underlying/shardingsphere-common/src/main/java/org/apache/shardingsphere/underlying/common/database/type/DatabaseTypes.java
##
@@ -60,40 +61,29 @@ public static DatabaseType getTrunkDatabaseType(final
String name) {
/**
* Get actual database type.
+ * @param name database name
Review comment:
Please do not modify original javadoc
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu commented on a change in pull request #4955: lambda code modify.
terrymanu commented on a change in pull request #4955: lambda code modify.
URL:
https://github.com/apache/incubator-shardingsphere/pull/4955#discussion_r398394818
##
File path:
shardingsphere-underlying/shardingsphere-common/src/main/java/org/apache/shardingsphere/underlying/common/database/type/DatabaseTypes.java
##
@@ -50,8 +51,8 @@ public static String getTrunkDatabaseTypeName(final
DatabaseType databaseType) {
/**
* Get trunk database type.
+ * @param name database name
Review comment:
Please do not modify original javadoc
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] tristaZero opened a new pull request #4956: modify dockerfile
tristaZero opened a new pull request #4956: modify dockerfile URL: https://github.com/apache/incubator-shardingsphere/pull/4956 Refs #4919. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] kimmking commented on a change in pull request #4955: lambda code modify.
kimmking commented on a change in pull request #4955: lambda code modify.
URL:
https://github.com/apache/incubator-shardingsphere/pull/4955#discussion_r398398738
##
File path:
sharding-proxy/sharding-proxy-common/src/main/java/org/apache/shardingsphere/shardingproxy/config/ShardingConfigurationLoader.java
##
@@ -64,10 +64,7 @@ public ShardingConfiguration load(final String path) throws
IOException {
});
}
Preconditions.checkState(!ruleConfigurations.isEmpty() || null !=
serverConfig.getOrchestration(), "Can not find any sharding rule configuration
file in path `%s`.", configPath.getPath());
-Map ruleConfigurationMap = new
HashMap<>(ruleConfigurations.size(), 1);
-for (YamlProxyRuleConfiguration each : ruleConfigurations) {
-ruleConfigurationMap.put(each.getSchemaName(), each);
-}
+Map ruleConfigurationMap =
ruleConfigurations.stream().collect(Collectors.toMap(YamlProxyRuleConfiguration::getSchemaName,
each -> each));
return new ShardingConfiguration(serverConfig, ruleConfigurationMap);
Review comment:
can combine one line
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] wuguowei19880907 commented on issue #4952: Add operations on cursors to EncryptResultSet(Suitable for a single data source) by originalResultSet
wuguowei19880907 commented on issue #4952: Add operations on cursors to
EncryptResultSet(Suitable for a single data source) by originalResultSet
URL:
https://github.com/apache/incubator-shardingsphere/pull/4952#issuecomment-604305029
> Please inline the return value
Did you say "xxx" like this:
```
@Override
public boolean isFirst() throws SQLException {
boolean first = originalResultSet.isFirst();
return first;
}
```
change to ->
```
@Override
public boolean isFirst() throws SQLException {
return originalResultSet.isFirst();
}
```
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] wuguowei19880907 edited a comment on issue #4952: Add operations on cursors to EncryptResultSet(Suitable for a single data source) by originalResultSet
wuguowei19880907 edited a comment on issue #4952: Add operations on cursors to
EncryptResultSet(Suitable for a single data source) by originalResultSet
URL:
https://github.com/apache/incubator-shardingsphere/pull/4952#issuecomment-604305029
> Please inline the return value
Did you say **inline the return value** like this:
```
@Override
public boolean isFirst() throws SQLException {
boolean first = originalResultSet.isFirst();
return first;
}
```
change to ->
```
@Override
public boolean isFirst() throws SQLException {
return originalResultSet.isFirst();
}
```
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu opened a new pull request #4957: Add routed rewrite engine
terrymanu opened a new pull request #4957: Add routed rewrite engine URL: https://github.com/apache/incubator-shardingsphere/pull/4957 For #4935. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] dongzl merged pull request #4957: Add standard interface for routed rewrite engine
dongzl merged pull request #4957: Add standard interface for routed rewrite engine URL: https://github.com/apache/incubator-shardingsphere/pull/4957 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] wuguowei19880907 edited a comment on issue #4952: Add operations on cursors to EncryptResultSet(Suitable for a single data source) by originalResultSet
wuguowei19880907 edited a comment on issue #4952: Add operations on cursors to
EncryptResultSet(Suitable for a single data source) by originalResultSet
URL:
https://github.com/apache/incubator-shardingsphere/pull/4952#issuecomment-604305029
> Please inline the return value
@terrymanu
Did you say **inline the return value** like this:
```
@Override
public boolean isFirst() throws SQLException {
boolean first = originalResultSet.isFirst();
return first;
}
```
change to ->
```
@Override
public boolean isFirst() throws SQLException {
return originalResultSet.isFirst();
}
```
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] kimmking commented on issue #4947: Is there any way to traverse tables in the specified order by Schema & Table Route
kimmking commented on issue #4947: Is there any way to traverse tables in the specified order by Schema & Table Route URL: https://github.com/apache/incubator-shardingsphere/issues/4947#issuecomment-604309108 1. How to know which one with data, and which one without data? If you know the data with its month is 3, you can direct query with `select * from t_msg_20_3 where ...`, ShardingSphere support this sql. 2. The 12 sharding tables is the same to ShardingSphere engine, no one is specially prior of others. If in your business semantics, they have an order to process one by one, I suggestion in native sql way. And Actually broadcasting 12 sharding tables will be parallelly query and merged, it's faster than one by one queries for several times. In our further plan, query optimization is big blueprint. As your case above, I recommend optimization by rewriting `union all` with the same database rather than `broadcast` or `one by one query`. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] kimmking edited a comment on issue #4947: Is there any way to traverse tables in the specified order by Schema & Table Route
kimmking edited a comment on issue #4947: Is there any way to traverse tables in the specified order by Schema & Table Route URL: https://github.com/apache/incubator-shardingsphere/issues/4947#issuecomment-604309108 @GolderGao 1. How to know which one with data, and which one without data? If you know the data with its month is 3, you can direct query with `select * from t_msg_20_3 where ...`, ShardingSphere support this sql. 2. The 12 sharding tables is the same to ShardingSphere engine, no one is specially prior of others. If in your business semantics, they have an order to process one by one, I suggestion in native sql way. And Actually broadcasting 12 sharding tables will be parallelly query and merged, it's faster than one by one queries for several times. In our further plan, query optimization is a big blueprint. As your case above, I recommend optimization by rewriting `union all` with the same database rather than `broadcast` or `one by one query`. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere-doc] hailinmo opened a new pull request #457: update homepage
hailinmo opened a new pull request #457: update homepage URL: https://github.com/apache/incubator-shardingsphere-doc/pull/457 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] coveralls commented on issue #4956: modify dockerfile
coveralls commented on issue #4956: modify dockerfile URL: https://github.com/apache/incubator-shardingsphere/pull/4956#issuecomment-604314689 ## Pull Request Test Coverage Report for [Build 2241](https://coveralls.io/builds/29628361) * **0** of **0** changed or added relevant lines in **0** files are covered. * No unchanged relevant lines lost coverage. * Overall coverage remained the same at **58.051%** --- | Totals | [](https://coveralls.io/builds/29628361) | | :-- | --: | | Change from base [Build 1175](https://coveralls.io/builds/29625455): | 0.0% | | Covered Lines: | 11890 | | Relevant Lines: | 20482 | --- # 💛 - [Coveralls](https://coveralls.io) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] coveralls commented on issue #4957: Add standard interface for routed rewrite engine
coveralls commented on issue #4957: Add standard interface for routed rewrite engine URL: https://github.com/apache/incubator-shardingsphere/pull/4957#issuecomment-604319542 ## Pull Request Test Coverage Report for [Build 2242](https://coveralls.io/builds/29628454) * **33** of **82** **(40.24%)** changed or added relevant lines in **17** files are covered. * **15** unchanged lines in **2** files lost coverage. * Overall coverage decreased (**-0.2%**) to **57.81%** --- | Changes Missing Coverage | Covered Lines | Changed/Added Lines | % | | :-|--||---: | | [sharding-core/sharding-core-rewrite/src/main/java/org/apache/shardingsphere/sharding/rewrite/context/ShardingSQLRewriteContextDecorator.java](https://coveralls.io/builds/29628454/source?filename=sharding-core%2Fsharding-core-rewrite%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsharding%2Frewrite%2Fcontext%2FShardingSQLRewriteContextDecorator.java#L34) | 1 | 2 | 50.0% | [shardingsphere-underlying/shardingsphere-rewrite/shardingsphere-rewrite-engine/src/main/java/org/apache/shardingsphere/underlying/rewrite/engine/SQLRewriteEngine.java](https://coveralls.io/builds/29628454/source?filename=shardingsphere-underlying%2Fshardingsphere-rewrite%2Fshardingsphere-rewrite-engine%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Funderlying%2Frewrite%2Fengine%2FSQLRewriteEngine.java#L26) | 0 | 2 | 0.0% | [sharding-proxy/sharding-proxy-backend/src/main/java/org/apache/shardingsphere/shardingproxy/backend/communication/jdbc/wrapper/PreparedStatementExecutorWrapper.java](https://coveralls.io/builds/29628454/source?filename=sharding-proxy%2Fsharding-proxy-backend%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingproxy%2Fbackend%2Fcommunication%2Fjdbc%2Fwrapper%2FPreparedStatementExecutorWrapper.java#L97) | 0 | 3 | 0.0% | [sharding-proxy/sharding-proxy-backend/src/main/java/org/apache/shardingsphere/shardingproxy/backend/communication/jdbc/wrapper/StatementExecutorWrapper.java](https://coveralls.io/builds/29628454/source?filename=sharding-proxy%2Fsharding-proxy-backend%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingproxy%2Fbackend%2Fcommunication%2Fjdbc%2Fwrapper%2FStatementExecutorWrapper.java#L94) | 0 | 3 | 0.0% | [sharding-core/sharding-core-common/src/main/java/org/apache/shardingsphere/core/rule/ShardingRule.java](https://coveralls.io/builds/29628454/source?filename=sharding-core%2Fsharding-core-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fcore%2Frule%2FShardingRule.java#L487) | 0 | 4 | 0.0% | [shardingsphere-underlying/shardingsphere-rewrite/shardingsphere-rewrite-engine/src/main/java/org/apache/shardingsphere/underlying/rewrite/sql/impl/RouteSQLBuilder.java](https://coveralls.io/builds/29628454/source?filename=shardingsphere-underlying%2Fshardingsphere-rewrite%2Fshardingsphere-rewrite-engine%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Funderlying%2Frewrite%2Fsql%2Fimpl%2FRouteSQLBuilder.java#L33) | 0 | 6 | 0.0% | [sharding-core/sharding-core-common/src/main/java/org/apache/shardingsphere/core/rule/BindingTableRule.java](https://coveralls.io/builds/29628454/source?filename=sharding-core%2Fsharding-core-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fcore%2Frule%2FBindingTableRule.java#L88) | 1 | 8 | 12.5% | [shardingsphere-underlying/shardingsphere-rewrite/shardingsphere-rewrite-engine/src/main/java/org/apache/shardingsphere/underlying/rewrite/engine/SQLRouteRewriteEngine.java](https://coveralls.io/builds/29628454/source?filename=shardingsphere-underlying%2Fshardingsphere-rewrite%2Fshardingsphere-rewrite-engine%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Funderlying%2Frewrite%2Fengine%2FSQLRouteRewriteEngine.java#L38) | 0 | 23 | 0.0% | Files with Coverage Reduction | New Missed Lines | % | | :-|--|--: | | [sharding-scaling/sharding-scaling-core/src/main/java/org/apache/shardingsphere/shardingscaling/core/synctask/history/HistoryDataSyncTask.java](https://coveralls.io/builds/29628454/source?filename=sharding-scaling%2Fsharding-scaling-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingscaling%2Fcore%2Fsynctask%2Fhistory%2FHistoryDataSyncTask.java#L116) | 7 | 76.47% | | [sharding-scaling/sharding-scaling-core/src/main/java/org/apache/shardingsphere/shardingscaling/core/execute/executor/channel/MemoryChannel.java](https://coveralls.io/builds/29628454/source?filename=sharding-scaling%2Fsharding-scaling-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingscaling%2Fcore%2Fexecute%2Fexecutor%2Fchannel%2FMemoryChannel.java#L61) | 8 | 51.85% | | Totals | [](https://coveralls.io/builds/29628454) | | :-- | --: | | Change from base [Build 1175](https://coveralls.io/builds/29625455): | -0.2% | | Covered Lines: | 11847 | | Relev
[GitHub] [incubator-shardingsphere] kimmking commented on issue #4892: cannot create directory due to Filename too long in Win10
kimmking commented on issue #4892: cannot create directory due to Filename too long in Win10 URL: https://github.com/apache/incubator-shardingsphere/issues/4892#issuecomment-604321732 I had modify FAQ with https://github.com/apache/incubator-shardingsphere/pull/4949 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] fantacy2001 edited a comment on issue #4861: two tables left join with different routing rules are not supported
fantacy2001 edited a comment on issue #4861: two tables left join with
different routing rules are not supported
URL:
https://github.com/apache/incubator-shardingsphere/issues/4861#issuecomment-604187682
> What is your sharding rule configuration?
sharding rule:
in the db and table ShardingAlgorithm, i mapping the dbs and tables by
columns 'col', like:
Map dbMap = new HashMap();
static{
dbMap.put("123","db_01");
dbMap.put("125","db_02")
}
Map tableMap = new HashMap();
static{
tableMap.put("123","table_001");
tableMap.put("125","table_002")
}
i mean on the join condition, Whether the sharding key after "on" should
be transitive？
I didn't find it in the source code.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] fantacy2001 edited a comment on issue #4861: two tables left join with different routing rules are not supported
fantacy2001 edited a comment on issue #4861: two tables left join with
different routing rules are not supported
URL:
https://github.com/apache/incubator-shardingsphere/issues/4861#issuecomment-604187682
> What is your sharding rule configuration?
sharding rule:
```xml
```
in the db and table ShardingAlgorithm, i mapping the dbs and tables by
columns 'col', like:
```java
Map dbMap = new HashMap();
static{
dbMap.put("123","db_01");
dbMap.put("125","db_02")
}
Map tableMap = new HashMap();
static{
tableMap.put("123","table_001");
tableMap.put("125","table_002")
}
```
i mean on the join condition, Whether the sharding key after "on" should
be transitive？
I didn't find it in the source code.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] yu199195 closed pull request #4955: lambda code modify.
yu199195 closed pull request #4955: lambda code modify. URL: https://github.com/apache/incubator-shardingsphere/pull/4955 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] yu199195 opened a new pull request #4958: lambda modify.
yu199195 opened a new pull request #4958: lambda modify. URL: https://github.com/apache/incubator-shardingsphere/pull/4958 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu commented on issue #4861: two tables left join with different routing rules are not supported
terrymanu commented on issue #4861: two tables left join with different routing rules are not supported URL: https://github.com/apache/incubator-shardingsphere/issues/4861#issuecomment-604329727 @fantacy2001 The current route result is correct. What is your expected? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] gchhy commented on issue #1617: Solve data lean problem when using DefaultKeyGenerator with low TPS
gchhy commented on issue #1617: Solve data lean problem when using DefaultKeyGenerator with low TPS URL: https://github.com/apache/incubator-shardingsphere/issues/1617#issuecomment-604330668 shadring-jdbc发现一个问题，java8以上版本，3.1.0版本查询时候，会报空指针异常，跟进源码发现实际问题是java.lang.ClassNotFoundException: javax.xml.bind.JAXBContext，应该是jdk版本问题，希望能 兼容上，而且在解析语句的时候直接trycatch，导致问题无法直接暴露，是否能优化 。 private final ParsingRuleRegistry parsingRuleRegistry = ParsingRuleRegistry.getInstance();这个方法在init的时候异常 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] gchhy removed a comment on issue #1617: Solve data lean problem when using DefaultKeyGenerator with low TPS
gchhy removed a comment on issue #1617: Solve data lean problem when using DefaultKeyGenerator with low TPS URL: https://github.com/apache/incubator-shardingsphere/issues/1617#issuecomment-604330668 shadring-jdbc发现一个问题，java8以上版本，3.1.0版本查询时候，会报空指针异常，跟进源码发现实际问题是java.lang.ClassNotFoundException: javax.xml.bind.JAXBContext，应该是jdk版本问题，希望能 兼容上，而且在解析语句的时候直接trycatch，导致问题无法直接暴露，是否能优化 。 private final ParsingRuleRegistry parsingRuleRegistry = ParsingRuleRegistry.getInstance();这个方法在init的时候异常 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] gchhy opened a new issue #4959: jdk兼容问题，jdk8以上版本异常
gchhy opened a new issue #4959: jdk兼容问题，jdk8以上版本异常 URL: https://github.com/apache/incubator-shardingsphere/issues/4959 ## Bug Report shadring-jdbc发现一个问题，java8以上版本，3.1.0版本查询时候，会报空指针异常，跟进源码发现实际问题是java.lang.ClassNotFoundException: javax.xml.bind.JAXBContext，应该是jdk版本问题，希望能 兼容上。而且在解析语句的时候直接trycatch，导致问题无法直接暴露，是否能优化 。 private final ParsingRuleRegistry parsingRuleRegistry = ParsingRuleRegistry.getInstance();这个方法在init的时候异常 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu commented on issue #4959: jdk兼容问题，jdk8以上版本异常
terrymanu commented on issue #4959: jdk兼容问题，jdk8以上版本异常 URL: https://github.com/apache/incubator-shardingsphere/issues/4959#issuecomment-604331696 **For English only**, other languages will not accept. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu closed issue #4959: jdk兼容问题，jdk8以上版本异常
terrymanu closed issue #4959: jdk兼容问题，jdk8以上版本异常 URL: https://github.com/apache/incubator-shardingsphere/issues/4959 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu commented on issue #4936: execute statement what is "create database testName" error in sharding-proxy module
terrymanu commented on issue #4936: execute statement what is "create database testName" error in sharding-proxy module URL: https://github.com/apache/incubator-shardingsphere/issues/4936#issuecomment-604332686 The picture is invalid This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu closed issue #4936: execute statement what is "create database testName" error in sharding-proxy module
terrymanu closed issue #4936: execute statement what is "create database testName" error in sharding-proxy module URL: https://github.com/apache/incubator-shardingsphere/issues/4936 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu commented on issue #4936: execute statement what is "create database testName" error in sharding-proxy module
terrymanu commented on issue #4936: execute statement what is "create database testName" error in sharding-proxy module URL: https://github.com/apache/incubator-shardingsphere/issues/4936#issuecomment-60497 Can not support `CREATE DATABASE test_db` because ShardingSphere using logic schema to process sharded data sources This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu closed issue #4901: proxool pool , jdbc yaml can't run proxy.ProxoolDataSource cannot be cast to YamlDataSourceParameter
terrymanu closed issue #4901: proxool pool ,jdbc yaml can't run proxy.ProxoolDataSource cannot be cast to YamlDataSourceParameter URL: https://github.com/apache/incubator-shardingsphere/issues/4901 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu commented on issue #4901: proxool pool , jdbc yaml can't run proxy.ProxoolDataSource cannot be cast to YamlDataSourceParameter
terrymanu commented on issue #4901: proxool pool ,jdbc yaml can't run proxy.ProxoolDataSource cannot be cast to YamlDataSourceParameter URL: https://github.com/apache/incubator-shardingsphere/issues/4901#issuecomment-604333766 Wrong configuration, please check document or example This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu closed issue #4882: How to integrate sharding-proxy with seata
terrymanu closed issue #4882: How to integrate sharding-proxy with seata URL: https://github.com/apache/incubator-shardingsphere/issues/4882 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu commented on issue #4795: Does ShardingScaling still need to support the MySQL JSON data type?
terrymanu commented on issue #4795: Does ShardingScaling still need to support the MySQL JSON data type? URL: https://github.com/apache/incubator-shardingsphere/issues/4795#issuecomment-604334911 Maybe low priority for json type This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu commented on issue #4784: Throw NPE when INSERT column and values mismatch
terrymanu commented on issue #4784: Throw NPE when INSERT column and values mismatch URL: https://github.com/apache/incubator-shardingsphere/issues/4784#issuecomment-604335626 @ranjeet-floyd You can write a wrong SQL with mismatched count of insert columns and values, and then you can find the NPE entry. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu commented on issue #4760: Setting SQL timeout time in mybatis does not take effect after sharding- JDBC 4.0.0-RC2 is used
terrymanu commented on issue #4760: Setting SQL timeout time in mybatis does not take effect after sharding- JDBC 4.0.0-RC2 is used URL: https://github.com/apache/incubator-shardingsphere/issues/4760#issuecomment-604337021 @ma1562013338 Hi, maybe we misunderstand each other. What I mean is we have no plan to implement this feature (because it is not a major issue). So we need to find a volunteer to do this feature. Do you interest to develop this feature? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] coveralls edited a comment on issue #4956: modify dockerfile
coveralls edited a comment on issue #4956: modify dockerfile URL: https://github.com/apache/incubator-shardingsphere/pull/4956#issuecomment-604314689 ## Pull Request Test Coverage Report for [Build 10593](https://coveralls.io/builds/29629243) * **0** of **0** changed or added relevant lines in **0** files are covered. * **68** unchanged lines in **9** files lost coverage. * Overall coverage decreased (**-0.2%**) to **57.805%** --- | Files with Coverage Reduction | New Missed Lines | % | | :-|--|--: | | [sharding-core/sharding-core-entry/src/main/java/org/apache/shardingsphere/core/shard/BaseShardingEngine.java](https://coveralls.io/builds/29629243/source?filename=sharding-core%2Fsharding-core-entry%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fcore%2Fshard%2FBaseShardingEngine.java#L144) | 1 | 93.48% | | [sharding-core/sharding-core-rewrite/src/main/java/org/apache/shardingsphere/sharding/rewrite/context/ShardingSQLRewriteContextDecorator.java](https://coveralls.io/builds/29629243/source?filename=sharding-core%2Fsharding-core-rewrite%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsharding%2Frewrite%2Fcontext%2FShardingSQLRewriteContextDecorator.java#L34) | 1 | 87.5% | | [shardingsphere-underlying/shardingsphere-rewrite/shardingsphere-rewrite-engine/src/main/java/org/apache/shardingsphere/underlying/rewrite/engine/SQLRewriteEngine.java](https://coveralls.io/builds/29629243/source?filename=shardingsphere-underlying%2Fshardingsphere-rewrite%2Fshardingsphere-rewrite-engine%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Funderlying%2Frewrite%2Fengine%2FSQLRewriteEngine.java#L26) | 2 | 0% | | [sharding-orchestration/sharding-orchestration-core/sharding-orchestration-core-registrycenter/src/main/java/org/apache/shardingsphere/orchestration/core/registrycenter/util/IpUtils.java](https://coveralls.io/builds/29629243/source?filename=sharding-orchestration%2Fsharding-orchestration-core%2Fsharding-orchestration-core-registrycenter%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Forchestration%2Fcore%2Fregistrycenter%2Futil%2FIpUtils.java#L63) | 3 | 76.0% | | [sharding-core/sharding-core-common/src/main/java/org/apache/shardingsphere/core/rule/BindingTableRule.java](https://coveralls.io/builds/29629243/source?filename=sharding-core%2Fsharding-core-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fcore%2Frule%2FBindingTableRule.java#L88) | 7 | 73.08% | | [sharding-scaling/sharding-scaling-core/src/main/java/org/apache/shardingsphere/shardingscaling/core/synctask/history/HistoryDataSyncTask.java](https://coveralls.io/builds/29629243/source?filename=sharding-scaling%2Fsharding-scaling-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingscaling%2Fcore%2Fsynctask%2Fhistory%2FHistoryDataSyncTask.java#L116) | 7 | 76.47% | | [sharding-scaling/sharding-scaling-core/src/main/java/org/apache/shardingsphere/shardingscaling/core/execute/executor/channel/MemoryChannel.java](https://coveralls.io/builds/29629243/source?filename=sharding-scaling%2Fsharding-scaling-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingscaling%2Fcore%2Fexecute%2Fexecutor%2Fchannel%2FMemoryChannel.java#L61) | 8 | 51.85% | | [sharding-core/sharding-core-common/src/main/java/org/apache/shardingsphere/core/rule/ShardingRule.java](https://coveralls.io/builds/29629243/source?filename=sharding-core%2Fsharding-core-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fcore%2Frule%2FShardingRule.java#L375) | 16 | 82.88% | | [shardingsphere-underlying/shardingsphere-rewrite/shardingsphere-rewrite-engine/src/main/java/org/apache/shardingsphere/underlying/rewrite/engine/SQLRouteRewriteEngine.java](https://coveralls.io/builds/29629243/source?filename=shardingsphere-underlying%2Fshardingsphere-rewrite%2Fshardingsphere-rewrite-engine%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Funderlying%2Frewrite%2Fengine%2FSQLRouteRewriteEngine.java#L38) | 23 | 0% | | Totals | [](https://coveralls.io/builds/29629243) | | :-- | --: | | Change from base [Build 1175](https://coveralls.io/builds/29625455): | -0.2% | | Covered Lines: | 11846 | | Relevant Lines: | 20493 | --- # 💛 - [Coveralls](https://coveralls.io) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu closed issue #3697: Cannot find table rule and default data source with logic tables
terrymanu closed issue #3697: Cannot find table rule and default data source with logic tables URL: https://github.com/apache/incubator-shardingsphere/issues/3697 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] kimmking edited a comment on issue #4947: Is there any way to traverse tables in the specified order by Schema & Table Route
kimmking edited a comment on issue #4947: Is there any way to traverse tables in the specified order by Schema & Table Route URL: https://github.com/apache/incubator-shardingsphere/issues/4947#issuecomment-604309108 @GolderGao @Akigaze 1. How to know which one with data, and which one without data? If you know the data with its month is 3, you can direct query with `select * from t_msg_20_3 where ...`, ShardingSphere support this sql. 2. As a middleware for generic usage&scenario, each one of 12 sharding tables is the same to ShardingSphere engine, no one is specially prior of others. If in your business semantics, they have an order to process one by one, I suggestion in native sql way. And Actually broadcasting 12 sharding tables will be parallelly query and merged, it's faster than one by one queries for several times. In our further plan, query optimization is a big blueprint. As your case above, I recommend optimization by rewriting `union all` with the same database rather than `broadcast` or `one by one query`. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] gchhy opened a new issue #4960: the bug about jdk8.0+ Compatibility
gchhy opened a new issue #4960: the bug about jdk8.0+ Compatibility URL: https://github.com/apache/incubator-shardingsphere/issues/4960 ## Bug Report ### Which version of ShardingSphere did you use? 3.1.0 ### Which project did you use? Sharding-JDBC or Sharding-Proxy? Sharding-JDBC ### Expected behavior Cause: java.lang.NullPointerException] with root cause java.lang.NullPointerException: null at io.shardingsphere.shardingjdbc.jdbc.core.statement.ShardingPreparedStatement.execute(ShardingPreparedStatement.java:139) ### Actual behavior java.lang.ClassNotFoundException: javax.xml.bind.JAXBContext ### Reason analyze (If you can) the 9 or 9+jdk will not support javax.xml.bind.JAXBContext I hope you are compatible I don't know why try catch the proplem, This leads to It's hard to find problems This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] kimmking commented on issue #4960: the bug about jdk8.0+ Compatibility
kimmking commented on issue #4960: the bug about jdk8.0+ Compatibility URL: https://github.com/apache/incubator-shardingsphere/issues/4960#issuecomment-604341821 Since jdk9+, java is a modularized platform. You need add some javax.* module to your project dependencies. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] kimmking commented on issue #4960: the bug about jdk8.0+ Compatibility
kimmking commented on issue #4960: the bug about jdk8.0+ Compatibility URL: https://github.com/apache/incubator-shardingsphere/issues/4960#issuecomment-604343649 BTW, strongly recommend upgrade to 4.0.1 or incoming 4.1.0(officially support java8 in sourcecode&compile level) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] gchhy commented on issue #4960: the bug about jdk8.0+ Compatibility
gchhy commented on issue #4960: the bug about jdk8.0+ Compatibility URL: https://github.com/apache/incubator-shardingsphere/issues/4960#issuecomment-604347026 > Since jdk9+, java is a modularized platform. > You need add some javax.* module to your project dependencies. yes,i know the question, It took me half an hour to find out the problem。so I hope you can mark or introduce the corresponding jar package。It's a better experience。 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] fantacy2001 commented on issue #4861: two tables left join with different routing rules are not supported
fantacy2001 commented on issue #4861: two tables left join with different routing rules are not supported URL: https://github.com/apache/incubator-shardingsphere/issues/4861#issuecomment-604351181 > @fantacy2001 The current route result is correct. What is your expected? i expected the sharding key in the condition 'on' after 'join', able to transmit sharding value in where condition ，Instead of writing it again in where condition This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] geomonlin commented on issue #4832: insert...ON DUPLICATE KEY UPDATE error
geomonlin commented on issue #4832: insert...ON DUPLICATE KEY UPDATE error URL: https://github.com/apache/incubator-shardingsphere/issues/4832#issuecomment-604353780 > @geomonlin @fantacy2001 > So What's the conclusion? Sorry, didn't notice the message, This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] geomonlin commented on issue #4832: insert...ON DUPLICATE KEY UPDATE error
geomonlin commented on issue #4832: insert...ON DUPLICATE KEY UPDATE error URL: https://github.com/apache/incubator-shardingsphere/issues/4832#issuecomment-604355890 > > > > @geomonlin Hi, could you give this issue a simple test whether the SQL mentioned can run well in our `Sharding-example` project? > > > > > > > > > this sql has modified: > > > ON DUPLICATE KEY > > > UPDATE > > > qty = values(qty) + 1 > > > success. > > > I also tested it successful. So Can close this issue? > > please close it ，thank you！ What's the cause of the error? Is it convenient to tell me This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu closed issue #4960: the bug about jdk8.0+ Compatibility
terrymanu closed issue #4960: the bug about jdk8.0+ Compatibility URL: https://github.com/apache/incubator-shardingsphere/issues/4960 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere-doc] tristaZero merged pull request #457: update homepage
tristaZero merged pull request #457: update homepage URL: https://github.com/apache/incubator-shardingsphere-doc/pull/457 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] kimmking commented on issue #4960: the bug about jdk8.0+ Compatibility
kimmking commented on issue #4960: the bug about jdk8.0+ Compatibility URL: https://github.com/apache/incubator-shardingsphere/issues/4960#issuecomment-604357996 @gchhy I don't think so. Everyone upgrade his/her projects to jdk9+, should make an investigation what and how to do. Whatever, it's no matter about ShardingSphere. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] kimmking edited a comment on issue #4960: the bug about jdk8.0+ Compatibility
kimmking edited a comment on issue #4960: the bug about jdk8.0+ Compatibility URL: https://github.com/apache/incubator-shardingsphere/issues/4960#issuecomment-604357996 @gchhy I don't think so. Everyone upgrade his/her projects(use ShardingSphere or not) to jdk9+, should make an investigation what and how to do. Whatever, it's no matter about ShardingSphere. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] kimmking commented on issue #4960: the bug about jdk8.0+ Compatibility
kimmking commented on issue #4960: the bug about jdk8.0+ Compatibility URL: https://github.com/apache/incubator-shardingsphere/issues/4960#issuecomment-604360287 BTW2: java9 is not a LTS version, suggest use java11 instead. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] jingshanglu opened a new pull request #4961: fix selectStatement contained tableReferences for other db
jingshanglu opened a new pull request #4961: fix selectStatement contained tableReferences for other db URL: https://github.com/apache/incubator-shardingsphere/pull/4961 ref #4885 . Changes proposed in this pull request: - fix selectStatement contained tableReferences for other db This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] kimmking opened a new pull request #4962: remove mermaid
kimmking opened a new pull request #4962: remove mermaid URL: https://github.com/apache/incubator-shardingsphere/pull/4962 Changes proposed in this pull request: - remove mermaid in docs This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] phoema opened a new issue #4963: Single
phoema opened a new issue #4963: Single URL: https://github.com/apache/incubator-shardingsphere/issues/4963 ## Bug Report V5.0.0-RC1 SELECT COUNT(1) FROM ( SELECT assignee, flow_def_id, task_def_key, count(*) AS total FROM v_flow_history_dis WHERE (task_end_time BETWEEN ? AND ? AND rownum = ? AND case_id IS NOT NULL) GROUP BY assignee, flow_def_id, task_def_key ORDER BY assignee ASC, flow_def_id ASC, task_def_key ASC ) TOTAL this sql is a single table query but it can not parse when I make a hitmanger This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere-doc] hailinmo opened a new pull request #458: fix homepage
hailinmo opened a new pull request #458: fix homepage URL: https://github.com/apache/incubator-shardingsphere-doc/pull/458 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] kimmking commented on issue #4963: Single table query can not parse with sharding
kimmking commented on issue #4963: Single table query can not parse with sharding URL: https://github.com/apache/incubator-shardingsphere/issues/4963#issuecomment-604385221 @phoema Change the title for friendly search, please. Subquery is not supported well now. See https://github.com/apache/incubator-shardingsphere/issues/4696 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] kimmking edited a comment on issue #4963: Single table query can not parse with sharding
kimmking edited a comment on issue #4963: Single table query can not parse with sharding URL: https://github.com/apache/incubator-shardingsphere/issues/4963#issuecomment-604385221 @phoema Change the title for friendly search, please. Subquery support is in progress now. See https://github.com/apache/incubator-shardingsphere/issues/4696 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] phoema commented on issue #4963: Single table query with subquery can not parse with sharding
phoema commented on issue #4963: Single table query with subquery can not parse with sharding URL: https://github.com/apache/incubator-shardingsphere/issues/4963#issuecomment-604386731 can I write some other sqls when it does not work well and link 4696? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere-doc] tristaZero merged pull request #458: fix homepage
tristaZero merged pull request #458: fix homepage URL: https://github.com/apache/incubator-shardingsphere-doc/pull/458 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] tristaZero closed issue #4928: Make official website prominent in Apache way.
tristaZero closed issue #4928: Make official website prominent in Apache way. URL: https://github.com/apache/incubator-shardingsphere/issues/4928 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] tristaZero commented on issue #4928: Make official website prominent in Apache way.
tristaZero commented on issue #4928: Make official website prominent in Apache way. URL: https://github.com/apache/incubator-shardingsphere/issues/4928#issuecomment-604392312 [#458](https://github.com/apache/incubator-shardingsphere-doc/pull/458) finished this one. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] gchhy commented on issue #4960: the bug about jdk8.0+ Compatibility
gchhy commented on issue #4960: the bug about jdk8.0+ Compatibility URL: https://github.com/apache/incubator-shardingsphere/issues/4960#issuecomment-604395955 > BTW2: java9 is not a LTS version, suggest use java11 instead. java11 the same question. I think the biggest problem is that bugs are hidden too deep .It's not on the document，It's confusing for some novices。I just thought it would be better，And I think the shading-jdbc is great。 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] zjcnb commented on issue #4781: Add start-index and stop-index assertion for LiteralExpressionSegment
zjcnb commented on issue #4781: Add start-index and stop-index assertion for LiteralExpressionSegment URL: https://github.com/apache/incubator-shardingsphere/issues/4781#issuecomment-604398511 hi, i hava a question! sql is : update t_order set status = 'update' where order_id = 1000 and user_id = 10 xml is: What's wrong? Can you correct that? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] zjcnb edited a comment on issue #4781: Add start-index and stop-index assertion for LiteralExpressionSegment
zjcnb edited a comment on issue #4781: Add start-index and stop-index assertion for LiteralExpressionSegment URL: https://github.com/apache/incubator-shardingsphere/issues/4781#issuecomment-604398511 hi, i hava a question! sql is : update t_order set status = 'update' where order_id = 1000 and user_id = 10 xml is: ` ` What's wrong? Can you correct that? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] coveralls commented on issue #4962: remove mermaid
coveralls commented on issue #4962: remove mermaid URL: https://github.com/apache/incubator-shardingsphere/pull/4962#issuecomment-604406579 ## Pull Request Test Coverage Report for [Build 2243](https://coveralls.io/builds/29632079) * **0** of **0** changed or added relevant lines in **0** files are covered. * No unchanged relevant lines lost coverage. * Overall coverage increased (+**0.07%**) to **57.883%** --- | Totals | [](https://coveralls.io/builds/29632079) | | :-- | --: | | Change from base [Build 1177](https://coveralls.io/builds/29628541): | 0.07% | | Covered Lines: | 11862 | | Relevant Lines: | 20493 | --- # 💛 - [Coveralls](https://coveralls.io) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] dongzl opened a new pull request #4964: Fixes insensitive for DESC table for encrypt.
dongzl opened a new pull request #4964: Fixes insensitive for DESC table for encrypt. URL: https://github.com/apache/incubator-shardingsphere/pull/4964 Fixes #4770 . Changes proposed in this pull request: - Get column encrypt field from SchemaMetaData instead of EncryptRule. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] coveralls edited a comment on issue #4962: remove mermaid
coveralls edited a comment on issue #4962: remove mermaid URL: https://github.com/apache/incubator-shardingsphere/pull/4962#issuecomment-604406579 ## Pull Request Test Coverage Report for [Build 10604](https://coveralls.io/builds/29632799) * **0** of **0** changed or added relevant lines in **0** files are covered. * **3** unchanged lines in **1** file lost coverage. * Overall coverage decreased (**-0.005%**) to **57.805%** --- | Files with Coverage Reduction | New Missed Lines | % | | :-|--|--: | | [sharding-orchestration/sharding-orchestration-core/sharding-orchestration-core-registrycenter/src/main/java/org/apache/shardingsphere/orchestration/core/registrycenter/util/IpUtils.java](https://coveralls.io/builds/29632799/source?filename=sharding-orchestration%2Fsharding-orchestration-core%2Fsharding-orchestration-core-registrycenter%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Forchestration%2Fcore%2Fregistrycenter%2Futil%2FIpUtils.java#L63) | 3 | 76.0% | | Totals | [](https://coveralls.io/builds/29632799) | | :-- | --: | | Change from base [Build 1177](https://coveralls.io/builds/29628541): | -0.005% | | Covered Lines: | 11846 | | Relevant Lines: | 20493 | --- # 💛 - [Coveralls](https://coveralls.io) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] coveralls commented on issue #4958: lambda modify.
coveralls commented on issue #4958: lambda modify. URL: https://github.com/apache/incubator-shardingsphere/pull/4958#issuecomment-604431509 ## Pull Request Test Coverage Report for [Build 10605](https://coveralls.io/builds/29633399) * **8** of **8** **(100.0%)** changed or added relevant lines in **4** files are covered. * **3** unchanged lines in **1** file lost coverage. * Overall coverage decreased (**-0.04%**) to **57.766%** --- | Files with Coverage Reduction | New Missed Lines | % | | :-|--|--: | | [sharding-orchestration/sharding-orchestration-core/sharding-orchestration-core-registrycenter/src/main/java/org/apache/shardingsphere/orchestration/core/registrycenter/util/IpUtils.java](https://coveralls.io/builds/29633399/source?filename=sharding-orchestration%2Fsharding-orchestration-core%2Fsharding-orchestration-core-registrycenter%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Forchestration%2Fcore%2Fregistrycenter%2Futil%2FIpUtils.java#L63) | 3 | 76.0% | | Totals | [](https://coveralls.io/builds/29633399) | | :-- | --: | | Change from base [Build 1177](https://coveralls.io/builds/29628541): | -0.04% | | Covered Lines: | 11827 | | Relevant Lines: | 20474 | --- # 💛 - [Coveralls](https://coveralls.io) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] coveralls commented on issue #4964: Fixes insensitive for DESC table for encrypt.
coveralls commented on issue #4964: Fixes insensitive for DESC table for encrypt. URL: https://github.com/apache/incubator-shardingsphere/pull/4964#issuecomment-604433643 ## Pull Request Test Coverage Report for [Build 2244](https://coveralls.io/builds/29633549) * **1** of **28** **(3.57%)** changed or added relevant lines in **4** files are covered. * No unchanged relevant lines lost coverage. * Overall coverage decreased (**-0.05%**) to **57.765%** --- | Changes Missing Coverage | Covered Lines | Changed/Added Lines | % | | :-|--||---: | | [encrypt-core/encrypt-core-merge/src/main/java/org/apache/shardingsphere/encrypt/merge/EncryptResultDecoratorEngine.java](https://coveralls.io/builds/29633549/source?filename=encrypt-core%2Fencrypt-core-merge%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fencrypt%2Fmerge%2FEncryptResultDecoratorEngine.java#L46) | 0 | 1 | 0.0% | [encrypt-core/encrypt-core-merge/src/main/java/org/apache/shardingsphere/encrypt/merge/dal/EncryptDALResultDecorator.java](https://coveralls.io/builds/29633549/source?filename=encrypt-core%2Fencrypt-core-merge%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fencrypt%2Fmerge%2Fdal%2FEncryptDALResultDecorator.java#L45) | 0 | 1 | 0.0% | [encrypt-core/encrypt-core-merge/src/main/java/org/apache/shardingsphere/encrypt/merge/dal/impl/EncryptColumnsMergedResult.java](https://coveralls.io/builds/29633549/source?filename=encrypt-core%2Fencrypt-core-merge%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fencrypt%2Fmerge%2Fdal%2Fimpl%2FEncryptColumnsMergedResult.java#L47) | 0 | 25 | 0.0% | Totals | [](https://coveralls.io/builds/29633549) | | :-- | --: | | Change from base [Build 1177](https://coveralls.io/builds/29628541): | -0.05% | | Covered Lines: | 11847 | | Relevant Lines: | 20509 | --- # 💛 - [Coveralls](https://coveralls.io) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] coveralls edited a comment on issue #4956: modify dockerfile
coveralls edited a comment on issue #4956: modify dockerfile URL: https://github.com/apache/incubator-shardingsphere/pull/4956#issuecomment-604314689 ## Pull Request Test Coverage Report for [Build 2245](https://coveralls.io/builds/29633750) * **0** of **0** changed or added relevant lines in **0** files are covered. * **50** unchanged lines in **6** files lost coverage. * Overall coverage decreased (**-0.2%**) to **57.883%** --- | Files with Coverage Reduction | New Missed Lines | % | | :-|--|--: | | [sharding-core/sharding-core-entry/src/main/java/org/apache/shardingsphere/core/shard/BaseShardingEngine.java](https://coveralls.io/builds/29633750/source?filename=sharding-core%2Fsharding-core-entry%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fcore%2Fshard%2FBaseShardingEngine.java#L144) | 1 | 93.48% | | [sharding-core/sharding-core-rewrite/src/main/java/org/apache/shardingsphere/sharding/rewrite/context/ShardingSQLRewriteContextDecorator.java](https://coveralls.io/builds/29633750/source?filename=sharding-core%2Fsharding-core-rewrite%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsharding%2Frewrite%2Fcontext%2FShardingSQLRewriteContextDecorator.java#L34) | 1 | 87.5% | | [shardingsphere-underlying/shardingsphere-rewrite/shardingsphere-rewrite-engine/src/main/java/org/apache/shardingsphere/underlying/rewrite/engine/SQLRewriteEngine.java](https://coveralls.io/builds/29633750/source?filename=shardingsphere-underlying%2Fshardingsphere-rewrite%2Fshardingsphere-rewrite-engine%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Funderlying%2Frewrite%2Fengine%2FSQLRewriteEngine.java#L26) | 2 | 0% | | [sharding-core/sharding-core-common/src/main/java/org/apache/shardingsphere/core/rule/BindingTableRule.java](https://coveralls.io/builds/29633750/source?filename=sharding-core%2Fsharding-core-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fcore%2Frule%2FBindingTableRule.java#L88) | 7 | 73.08% | | [sharding-core/sharding-core-common/src/main/java/org/apache/shardingsphere/core/rule/ShardingRule.java](https://coveralls.io/builds/29633750/source?filename=sharding-core%2Fsharding-core-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fcore%2Frule%2FShardingRule.java#L375) | 16 | 82.88% | | [shardingsphere-underlying/shardingsphere-rewrite/shardingsphere-rewrite-engine/src/main/java/org/apache/shardingsphere/underlying/rewrite/engine/SQLRouteRewriteEngine.java](https://coveralls.io/builds/29633750/source?filename=shardingsphere-underlying%2Fshardingsphere-rewrite%2Fshardingsphere-rewrite-engine%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Funderlying%2Frewrite%2Fengine%2FSQLRouteRewriteEngine.java#L38) | 23 | 0% | | Totals | [](https://coveralls.io/builds/29633750) | | :-- | --: | | Change from base [Build 1175](https://coveralls.io/builds/29625455): | -0.2% | | Covered Lines: | 11862 | | Relevant Lines: | 20493 | --- # 💛 - [Coveralls](https://coveralls.io) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] coveralls edited a comment on issue #4956: modify dockerfile
coveralls edited a comment on issue #4956: modify dockerfile URL: https://github.com/apache/incubator-shardingsphere/pull/4956#issuecomment-604314689 ## Pull Request Test Coverage Report for [Build 2246](https://coveralls.io/builds/29634156) * **0** of **0** changed or added relevant lines in **0** files are covered. * **50** unchanged lines in **6** files lost coverage. * Overall coverage decreased (**-0.2%**) to **57.883%** --- | Files with Coverage Reduction | New Missed Lines | % | | :-|--|--: | | [sharding-core/sharding-core-entry/src/main/java/org/apache/shardingsphere/core/shard/BaseShardingEngine.java](https://coveralls.io/builds/29634156/source?filename=sharding-core%2Fsharding-core-entry%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fcore%2Fshard%2FBaseShardingEngine.java#L144) | 1 | 93.48% | | [sharding-core/sharding-core-rewrite/src/main/java/org/apache/shardingsphere/sharding/rewrite/context/ShardingSQLRewriteContextDecorator.java](https://coveralls.io/builds/29634156/source?filename=sharding-core%2Fsharding-core-rewrite%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsharding%2Frewrite%2Fcontext%2FShardingSQLRewriteContextDecorator.java#L34) | 1 | 87.5% | | [shardingsphere-underlying/shardingsphere-rewrite/shardingsphere-rewrite-engine/src/main/java/org/apache/shardingsphere/underlying/rewrite/engine/SQLRewriteEngine.java](https://coveralls.io/builds/29634156/source?filename=shardingsphere-underlying%2Fshardingsphere-rewrite%2Fshardingsphere-rewrite-engine%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Funderlying%2Frewrite%2Fengine%2FSQLRewriteEngine.java#L26) | 2 | 0% | | [sharding-core/sharding-core-common/src/main/java/org/apache/shardingsphere/core/rule/BindingTableRule.java](https://coveralls.io/builds/29634156/source?filename=sharding-core%2Fsharding-core-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fcore%2Frule%2FBindingTableRule.java#L88) | 7 | 73.08% | | [sharding-core/sharding-core-common/src/main/java/org/apache/shardingsphere/core/rule/ShardingRule.java](https://coveralls.io/builds/29634156/source?filename=sharding-core%2Fsharding-core-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fcore%2Frule%2FShardingRule.java#L375) | 16 | 82.88% | | [shardingsphere-underlying/shardingsphere-rewrite/shardingsphere-rewrite-engine/src/main/java/org/apache/shardingsphere/underlying/rewrite/engine/SQLRouteRewriteEngine.java](https://coveralls.io/builds/29634156/source?filename=shardingsphere-underlying%2Fshardingsphere-rewrite%2Fshardingsphere-rewrite-engine%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Funderlying%2Frewrite%2Fengine%2FSQLRouteRewriteEngine.java#L38) | 23 | 0% | | Totals | [](https://coveralls.io/builds/29634156) | | :-- | --: | | Change from base [Build 1175](https://coveralls.io/builds/29625455): | -0.2% | | Covered Lines: | 11862 | | Relevant Lines: | 20493 | --- # 💛 - [Coveralls](https://coveralls.io) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] coveralls edited a comment on issue #4964: Fixes insensitive for DESC table for encrypt.
coveralls edited a comment on issue #4964: Fixes insensitive for DESC table for encrypt. URL: https://github.com/apache/incubator-shardingsphere/pull/4964#issuecomment-604433643 ## Pull Request Test Coverage Report for [Build 10606](https://coveralls.io/builds/29634518) * **1** of **28** **(3.57%)** changed or added relevant lines in **4** files are covered. * **3** unchanged lines in **1** file lost coverage. * Overall coverage decreased (**-0.05%**) to **57.76%** --- | Changes Missing Coverage | Covered Lines | Changed/Added Lines | % | | :-|--||---: | | [encrypt-core/encrypt-core-merge/src/main/java/org/apache/shardingsphere/encrypt/merge/EncryptResultDecoratorEngine.java](https://coveralls.io/builds/29634518/source?filename=encrypt-core%2Fencrypt-core-merge%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fencrypt%2Fmerge%2FEncryptResultDecoratorEngine.java#L46) | 0 | 1 | 0.0% | [encrypt-core/encrypt-core-merge/src/main/java/org/apache/shardingsphere/encrypt/merge/dal/EncryptDALResultDecorator.java](https://coveralls.io/builds/29634518/source?filename=encrypt-core%2Fencrypt-core-merge%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fencrypt%2Fmerge%2Fdal%2FEncryptDALResultDecorator.java#L45) | 0 | 1 | 0.0% | [encrypt-core/encrypt-core-merge/src/main/java/org/apache/shardingsphere/encrypt/merge/dal/impl/EncryptColumnsMergedResult.java](https://coveralls.io/builds/29634518/source?filename=encrypt-core%2Fencrypt-core-merge%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fencrypt%2Fmerge%2Fdal%2Fimpl%2FEncryptColumnsMergedResult.java#L47) | 0 | 25 | 0.0% | Files with Coverage Reduction | New Missed Lines | % | | :-|--|--: | | [sharding-orchestration/sharding-orchestration-core/sharding-orchestration-core-registrycenter/src/main/java/org/apache/shardingsphere/orchestration/core/registrycenter/util/IpUtils.java](https://coveralls.io/builds/29634518/source?filename=sharding-orchestration%2Fsharding-orchestration-core%2Fsharding-orchestration-core-registrycenter%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Forchestration%2Fcore%2Fregistrycenter%2Futil%2FIpUtils.java#L63) | 3 | 76.0% | | Totals | [](https://coveralls.io/builds/29634518) | | :-- | --: | | Change from base [Build 1177](https://coveralls.io/builds/29628541): | -0.05% | | Covered Lines: | 11846 | | Relevant Lines: | 20509 | --- # 💛 - [Coveralls](https://coveralls.io) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] codecov-io commented on issue #4956: modify dockerfile
codecov-io commented on issue #4956: modify dockerfile URL: https://github.com/apache/incubator-shardingsphere/pull/4956#issuecomment-604468180 # [Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4956?src=pr&el=h1) Report > Merging [#4956](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4956?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-shardingsphere/commit/4d53d222d3195f78ad1054c3f530f43c764452b6&el=desc) will **decrease** coverage by `0.15%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4956?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master#4956 +/- ## - Coverage 54.45% 54.30% -0.16% Complexity 440 440 Files 1140 1140 Lines 2048220493 +11 Branches 3765 3765 - Hits 1115411129 -25 - Misses 8620 8659 +39 + Partials708 705 -3 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4956?src=pr&el=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...che/shardingsphere/core/rule/BindingTableRule.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4956/diff?src=pr&el=tree#diff-c2hhcmRpbmctY29yZS9zaGFyZGluZy1jb3JlLWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvY29yZS9ydWxlL0JpbmRpbmdUYWJsZVJ1bGUuamF2YQ==) | `73.07% <0.00%> (-26.93%)` | `0.00% <0.00%> (ø%)` | | | [.../apache/shardingsphere/core/rule/ShardingRule.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4956/diff?src=pr&el=tree#diff-c2hhcmRpbmctY29yZS9zaGFyZGluZy1jb3JlLWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvY29yZS9ydWxlL1NoYXJkaW5nUnVsZS5qYXZh) | `77.39% <0.00%> (-2.19%)` | `0.00% <0.00%> (ø%)` | | | [...rite/token/generator/impl/IndexTokenGenerator.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4956/diff?src=pr&el=tree#diff-c2hhcmRpbmctY29yZS9zaGFyZGluZy1jb3JlLXJld3JpdGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NoYXJkaW5nL3Jld3JpdGUvdG9rZW4vZ2VuZXJhdG9yL2ltcGwvSW5kZXhUb2tlbkdlbmVyYXRvci5qYXZh) | `87.50% <0.00%> (ø)` | `1.00% <0.00%> (ø%)` | | | [...rding/rewrite/engine/ShardingSQLRewriteEngine.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4956/diff?src=pr&el=tree#diff-c2hhcmRpbmctY29yZS9zaGFyZGluZy1jb3JlLXJld3JpdGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NoYXJkaW5nL3Jld3JpdGUvZW5naW5lL1NoYXJkaW5nU1FMUmV3cml0ZUVuZ2luZS5qYXZh) | | | | | [...e/token/pojo/impl/GeneratedKeyAssignmentToken.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4956/diff?src=pr&el=tree#diff-c2hhcmRpbmctY29yZS9zaGFyZGluZy1jb3JlLXJld3JpdGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NoYXJkaW5nL3Jld3JpdGUvdG9rZW4vcG9qby9pbXBsL0dlbmVyYXRlZEtleUFzc2lnbm1lbnRUb2tlbi5qYXZh) | | | | | [...sharding/rewrite/token/pojo/impl/OrderByToken.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4956/diff?src=pr&el=tree#diff-c2hhcmRpbmctY29yZS9zaGFyZGluZy1jb3JlLXJld3JpdGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NoYXJkaW5nL3Jld3JpdGUvdG9rZW4vcG9qby9pbXBsL09yZGVyQnlUb2tlbi5qYXZh) | | | | | [...rite/token/pojo/impl/AggregationDistinctToken.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4956/diff?src=pr&el=tree#diff-c2hhcmRpbmctY29yZS9zaGFyZGluZy1jb3JlLXJld3JpdGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NoYXJkaW5nL3Jld3JpdGUvdG9rZW4vcG9qby9pbXBsL0FnZ3JlZ2F0aW9uRGlzdGluY3RUb2tlbi5qYXZh) | | | | | [...ding/rewrite/token/pojo/impl/ProjectionsToken.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4956/diff?src=pr&el=tree#diff-c2hhcmRpbmctY29yZS9zaGFyZGluZy1jb3JlLXJld3JpdGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NoYXJkaW5nL3Jld3JpdGUvdG9rZW4vcG9qby9pbXBsL1Byb2plY3Rpb25zVG9rZW4uamF2YQ==) | | | | | [...token/pojo/impl/GeneratedKeyInsertColumnToken.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4956/diff?src=pr&el=tree#diff-c2hhcmRpbmctY29yZS9zaGFyZGluZy1jb3JlLXJld3JpdGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NoYXJkaW5nL3Jld3JpdGUvdG9rZW4vcG9qby9pbXBsL0dlbmVyYXRlZEtleUluc2VydENvbHVtblRva2VuLmphdmE=) | | | | | [.../pojo/impl/LiteralGeneratedKeyAssignmentToken.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4956/diff?src=pr&el=tree#diff-c2hhcmRpbmctY29yZS9zaGFyZGluZy1jb3JlLXJld3JpdGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL
[GitHub] [incubator-shardingsphere] coveralls edited a comment on issue #4956: modify dockerfile
coveralls edited a comment on issue #4956: modify dockerfile URL: https://github.com/apache/incubator-shardingsphere/pull/4956#issuecomment-604314689 ## Pull Request Test Coverage Report for [Build 10608](https://coveralls.io/builds/29635460) * **0** of **0** changed or added relevant lines in **0** files are covered. * **68** unchanged lines in **9** files lost coverage. * Overall coverage decreased (**-0.2%**) to **57.805%** --- | Files with Coverage Reduction | New Missed Lines | % | | :-|--|--: | | [sharding-core/sharding-core-entry/src/main/java/org/apache/shardingsphere/core/shard/BaseShardingEngine.java](https://coveralls.io/builds/29635460/source?filename=sharding-core%2Fsharding-core-entry%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fcore%2Fshard%2FBaseShardingEngine.java#L144) | 1 | 93.48% | | [sharding-core/sharding-core-rewrite/src/main/java/org/apache/shardingsphere/sharding/rewrite/context/ShardingSQLRewriteContextDecorator.java](https://coveralls.io/builds/29635460/source?filename=sharding-core%2Fsharding-core-rewrite%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsharding%2Frewrite%2Fcontext%2FShardingSQLRewriteContextDecorator.java#L34) | 1 | 87.5% | | [shardingsphere-underlying/shardingsphere-rewrite/shardingsphere-rewrite-engine/src/main/java/org/apache/shardingsphere/underlying/rewrite/engine/SQLRewriteEngine.java](https://coveralls.io/builds/29635460/source?filename=shardingsphere-underlying%2Fshardingsphere-rewrite%2Fshardingsphere-rewrite-engine%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Funderlying%2Frewrite%2Fengine%2FSQLRewriteEngine.java#L26) | 2 | 0% | | [sharding-orchestration/sharding-orchestration-core/sharding-orchestration-core-registrycenter/src/main/java/org/apache/shardingsphere/orchestration/core/registrycenter/util/IpUtils.java](https://coveralls.io/builds/29635460/source?filename=sharding-orchestration%2Fsharding-orchestration-core%2Fsharding-orchestration-core-registrycenter%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Forchestration%2Fcore%2Fregistrycenter%2Futil%2FIpUtils.java#L63) | 3 | 76.0% | | [sharding-core/sharding-core-common/src/main/java/org/apache/shardingsphere/core/rule/BindingTableRule.java](https://coveralls.io/builds/29635460/source?filename=sharding-core%2Fsharding-core-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fcore%2Frule%2FBindingTableRule.java#L88) | 7 | 73.08% | | [sharding-scaling/sharding-scaling-core/src/main/java/org/apache/shardingsphere/shardingscaling/core/synctask/history/HistoryDataSyncTask.java](https://coveralls.io/builds/29635460/source?filename=sharding-scaling%2Fsharding-scaling-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingscaling%2Fcore%2Fsynctask%2Fhistory%2FHistoryDataSyncTask.java#L116) | 7 | 76.47% | | [sharding-scaling/sharding-scaling-core/src/main/java/org/apache/shardingsphere/shardingscaling/core/execute/executor/channel/MemoryChannel.java](https://coveralls.io/builds/29635460/source?filename=sharding-scaling%2Fsharding-scaling-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingscaling%2Fcore%2Fexecute%2Fexecutor%2Fchannel%2FMemoryChannel.java#L61) | 8 | 51.85% | | [sharding-core/sharding-core-common/src/main/java/org/apache/shardingsphere/core/rule/ShardingRule.java](https://coveralls.io/builds/29635460/source?filename=sharding-core%2Fsharding-core-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fcore%2Frule%2FShardingRule.java#L375) | 16 | 82.88% | | [shardingsphere-underlying/shardingsphere-rewrite/shardingsphere-rewrite-engine/src/main/java/org/apache/shardingsphere/underlying/rewrite/engine/SQLRouteRewriteEngine.java](https://coveralls.io/builds/29635460/source?filename=shardingsphere-underlying%2Fshardingsphere-rewrite%2Fshardingsphere-rewrite-engine%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Funderlying%2Frewrite%2Fengine%2FSQLRouteRewriteEngine.java#L38) | 23 | 0% | | Totals | [](https://coveralls.io/builds/29635460) | | :-- | --: | | Change from base [Build 1175](https://coveralls.io/builds/29625455): | -0.2% | | Covered Lines: | 11846 | | Relevant Lines: | 20493 | --- # 💛 - [Coveralls](https://coveralls.io) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu merged pull request #4962: remove mermaid
terrymanu merged pull request #4962: remove mermaid URL: https://github.com/apache/incubator-shardingsphere/pull/4962 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu commented on a change in pull request #4952: Add operations on cursors to EncryptResultSet(Suitable for a single data source) by originalResultSet
terrymanu commented on a change in pull request #4952: Add operations on
cursors to EncryptResultSet(Suitable for a single data source) by
originalResultSet
URL:
https://github.com/apache/incubator-shardingsphere/pull/4952#discussion_r398687563
##
File path:
sharding-jdbc/sharding-jdbc-core/src/test/java/org/apache/shardingsphere/shardingjdbc/jdbc/core/resultset/EncryptResultSetTest.java
##
@@ -0,0 +1,32 @@
+package org.apache.shardingsphere.shardingjdbc.jdbc.core.resultset;
+
+import
org.apache.shardingsphere.shardingjdbc.common.base.AbstractEncryptJDBCDatabaseAndTableTest;
+import org.junit.Test;
+
+import java.sql.ResultSet;
+import java.sql.SQLException;
+import java.sql.Statement;
+
+import static org.junit.Assert.assertEquals;
+import static org.junit.Assert.assertTrue;
+
+public class EncryptResultSetTest extends
AbstractEncryptJDBCDatabaseAndTableTest {
+
+private static final String SELECT_SQL_TO_ASSERT = "SELECT id, cipher_pwd,
plain_pwd FROM t_encrypt";
+
+@Test
+public void assertResultSetIsBeforeFirst() throws SQLException {
+try (Statement statement =
getEncryptConnection().createStatement(ResultSet.TYPE_SCROLL_INSENSITIVE,
+ResultSet.CONCUR_READ_ONLY)) {
+ResultSet resultSet = statement.executeQuery(SELECT_SQL_TO_ASSERT);
+assertTrue(resultSet.isBeforeFirst());
+resultSet.next();
+assertEquals(1, resultSet.getRow());
+resultSet.afterLast();
+assertTrue(resultSet.isAfterLast());
+resultSet.beforeFirst();
+assertTrue(resultSet.isBeforeFirst());
Review comment:
This test method test more than one case, let's separate it to multiple
methods.
Just follow SRP.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu commented on a change in pull request #4952: Add operations on cursors to EncryptResultSet(Suitable for a single data source) by originalResultSet
terrymanu commented on a change in pull request #4952: Add operations on
cursors to EncryptResultSet(Suitable for a single data source) by
originalResultSet
URL:
https://github.com/apache/incubator-shardingsphere/pull/4952#discussion_r398686092
##
File path:
sharding-jdbc/sharding-jdbc-core/src/test/java/org/apache/shardingsphere/shardingjdbc/jdbc/core/resultset/EncryptResultSetTest.java
##
@@ -0,0 +1,32 @@
+package org.apache.shardingsphere.shardingjdbc.jdbc.core.resultset;
+
+import
org.apache.shardingsphere.shardingjdbc.common.base.AbstractEncryptJDBCDatabaseAndTableTest;
+import org.junit.Test;
+
+import java.sql.ResultSet;
+import java.sql.SQLException;
+import java.sql.Statement;
+
+import static org.junit.Assert.assertEquals;
+import static org.junit.Assert.assertTrue;
+
+public class EncryptResultSetTest extends
AbstractEncryptJDBCDatabaseAndTableTest {
+
+private static final String SELECT_SQL_TO_ASSERT = "SELECT id, cipher_pwd,
plain_pwd FROM t_encrypt";
+
+@Test
+public void assertResultSetIsBeforeFirst() throws SQLException {
+try (Statement statement =
getEncryptConnection().createStatement(ResultSet.TYPE_SCROLL_INSENSITIVE,
+ResultSet.CONCUR_READ_ONLY)) {
+ResultSet resultSet = statement.executeQuery(SELECT_SQL_TO_ASSERT);
+assertTrue(resultSet.isBeforeFirst());
+resultSet.next();
+assertEquals(1, resultSet.getRow());
+resultSet.afterLast();
+assertTrue(resultSet.isAfterLast());
+resultSet.beforeFirst();
+assertTrue(resultSet.isBeforeFirst());
+}
+}
+
Review comment:
please remove useless blank line
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu commented on issue #4952: Add operations on cursors to EncryptResultSet(Suitable for a single data source) by originalResultSet
terrymanu commented on issue #4952: Add operations on cursors to
EncryptResultSet(Suitable for a single data source) by originalResultSet
URL:
https://github.com/apache/incubator-shardingsphere/pull/4952#issuecomment-604513580
> > Please inline the return value
>
> @terrymanu
> Did you say **inline the return value** like this:
>
> ```
> @Override
> public boolean isFirst() throws SQLException {
> boolean first = originalResultSet.isFirst();
> return first;
> }
> ```
>
> change to ->
>
> ```
> @Override
> public boolean isFirst() throws SQLException {
> return originalResultSet.isFirst();
> }
> ```
Yes, you catch the point.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu merged pull request #4956: modify dockerfile
terrymanu merged pull request #4956: modify dockerfile URL: https://github.com/apache/incubator-shardingsphere/pull/4956 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu commented on a change in pull request #4964: Fixes insensitive for DESC table for encrypt.
terrymanu commented on a change in pull request #4964: Fixes insensitive for
DESC table for encrypt.
URL:
https://github.com/apache/incubator-shardingsphere/pull/4964#discussion_r398691661
##
File path:
encrypt-core/encrypt-core-merge/src/main/java/org/apache/shardingsphere/encrypt/merge/dal/impl/EncryptColumnsMergedResult.java
##
@@ -66,19 +70,50 @@ public final boolean next() throws SQLException {
return true;
}
+private Collection getAssistedQueryColumns() {
+return
getTableEncryptColumnMetaDatas().stream().map(EncryptColumnMetaData::getAssistedQueryColumnName)
+.collect(Collectors.toList());
+}
+
+private Collection getPlainColumns() {
+return
getTableEncryptColumnMetaDatas().stream().map(EncryptColumnMetaData::getPlainColumnName)
+.collect(Collectors.toList());
+}
+
+private Collection getTableEncryptColumnMetaDatas()
{
+Collection result = new LinkedList<>();
+for (Map.Entry entry :
schemaMetaData.get(tableName).getColumns().entrySet()) {
Review comment:
Please do not use `Map.Entry`, just use `Entry`
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu commented on a change in pull request #4964: Fixes insensitive for DESC table for encrypt.
terrymanu commented on a change in pull request #4964: Fixes insensitive for
DESC table for encrypt.
URL:
https://github.com/apache/incubator-shardingsphere/pull/4964#discussion_r398693301
##
File path:
encrypt-core/encrypt-core-merge/src/main/java/org/apache/shardingsphere/encrypt/merge/dal/impl/EncryptColumnsMergedResult.java
##
@@ -66,19 +70,50 @@ public final boolean next() throws SQLException {
return true;
}
+private Collection getAssistedQueryColumns() {
+return
getTableEncryptColumnMetaDatas().stream().map(EncryptColumnMetaData::getAssistedQueryColumnName)
+.collect(Collectors.toList());
+}
+
+private Collection getPlainColumns() {
+return
getTableEncryptColumnMetaDatas().stream().map(EncryptColumnMetaData::getPlainColumnName)
+.collect(Collectors.toList());
+}
+
+private Collection getTableEncryptColumnMetaDatas()
{
+Collection result = new LinkedList<>();
+for (Map.Entry entry :
schemaMetaData.get(tableName).getColumns().entrySet()) {
+if (!(entry.getValue() instanceof EncryptColumnMetaData)) {
+continue;
+}
+result.add((EncryptColumnMetaData) entry.getValue());
+}
+return result;
+}
+
@Override
public final Object getValue(final int columnIndex, final Class type)
throws SQLException {
if (1 == columnIndex) {
String columnName = getOriginalValue(columnIndex, type).toString();
-Optional encryptTable =
encryptRule.findEncryptTable(tableName);
-if (encryptTable.isPresent() &&
encryptTable.get().getCipherColumns().contains(columnName)) {
-return encryptTable.get().getLogicColumnOfCipher(columnName);
-}
-return columnName;
+Optional logicColumn = getLogicColumnOfCipher(columnName);
+return logicColumn.isPresent() ? logicColumn.get() : columnName;
}
return getOriginalValue(columnIndex, type);
}
+private Optional getLogicColumnOfCipher(final String cipherColumn)
{
+for (Map.Entry entry :
schemaMetaData.get(tableName).getColumns().entrySet()) {
Review comment:
Please do not use `Map.Entry`, just use `Entry`
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu commented on a change in pull request #4964: Fixes insensitive for DESC table for encrypt.
terrymanu commented on a change in pull request #4964: Fixes insensitive for
DESC table for encrypt.
URL:
https://github.com/apache/incubator-shardingsphere/pull/4964#discussion_r398692427
##
File path:
encrypt-core/encrypt-core-merge/src/main/java/org/apache/shardingsphere/encrypt/merge/dal/impl/EncryptColumnsMergedResult.java
##
@@ -66,19 +70,50 @@ public final boolean next() throws SQLException {
return true;
}
+private Collection getAssistedQueryColumns() {
+return
getTableEncryptColumnMetaDatas().stream().map(EncryptColumnMetaData::getAssistedQueryColumnName)
+.collect(Collectors.toList());
+}
+
+private Collection getPlainColumns() {
+return
getTableEncryptColumnMetaDatas().stream().map(EncryptColumnMetaData::getPlainColumnName)
+.collect(Collectors.toList());
+}
+
+private Collection getTableEncryptColumnMetaDatas()
{
+Collection result = new LinkedList<>();
+for (Map.Entry entry :
schemaMetaData.get(tableName).getColumns().entrySet()) {
+if (!(entry.getValue() instanceof EncryptColumnMetaData)) {
+continue;
+}
+result.add((EncryptColumnMetaData) entry.getValue());
Review comment:
It is better to change to:
```java
if (entry.getValue() instanceof EncryptColumnMetaData) {
result.add((EncryptColumnMetaData) entry.getValue());
}
```
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
