[GitHub] [incubator-shardingsphere] kimmking commented on issue #4991: make ShardingDataSource compatible with Seata in micro-service distribution transaction
kimmking commented on issue #4991: make ShardingDataSource compatible with Seata in micro-service distribution transaction URL: https://github.com/apache/incubator-shardingsphere/issues/4991#issuecomment-605603672 `enable.client.transaction.in.seata.at` is better? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] kimmking commented on issue #4986: if field name of table is "call", encrypt not work.
kimmking commented on issue #4986: if field name of table is "call",encrypt not work. URL: https://github.com/apache/incubator-shardingsphere/issues/4986#issuecomment-605604132 `call` is in MySQL `Keywords and Reserved Words`. You can try: ``` `call` ``` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu opened a new pull request #4992: Add MergeEngine to decouple merge and rules
terrymanu opened a new pull request #4992: Add MergeEngine to decouple merge and rules URL: https://github.com/apache/incubator-shardingsphere/pull/4992 For #3691. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] tristaZero merged pull request #4992: Add MergeEngine to decouple merge and rules
tristaZero merged pull request #4992: Add MergeEngine to decouple merge and rules URL: https://github.com/apache/incubator-shardingsphere/pull/4992 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] lennonn closed issue #4986: if field name of table is "call", encrypt not work.
lennonn closed issue #4986: if field name of table is "call",encrypt not work. URL: https://github.com/apache/incubator-shardingsphere/issues/4986 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] lennonn commented on issue #4986: if field name of table is "call", encrypt not work.
lennonn commented on issue #4986: if field name of table is "call",encrypt not work. URL: https://github.com/apache/incubator-shardingsphere/issues/4986#issuecomment-605612024 It is not a keywords in oracle, This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] coveralls commented on issue #4992: Add MergeEngine to decouple merge and rules
coveralls commented on issue #4992: Add MergeEngine to decouple merge and rules URL: https://github.com/apache/incubator-shardingsphere/pull/4992#issuecomment-605612268 ## Pull Request Test Coverage Report for [Build 10685](https://coveralls.io/builds/29687799) * **49** of **103** **(47.57%)** changed or added relevant lines in **19** files are covered. * **1** unchanged line in **1** file lost coverage. * Overall coverage decreased (**-0.1%**) to **57.394%** --- | Changes Missing Coverage | Covered Lines | Changed/Added Lines | % | | :-|--||---: | | [sharding-jdbc/sharding-jdbc-core/src/main/java/org/apache/shardingsphere/shardingjdbc/jdbc/core/statement/ShardingPreparedStatement.java](https://coveralls.io/builds/29687799/source?filename=sharding-jdbc%2Fsharding-jdbc-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingjdbc%2Fjdbc%2Fcore%2Fstatement%2FShardingPreparedStatement.java#L135) | 9 | 10 | 90.0% | [sharding-proxy/sharding-proxy-bootstrap/src/main/java/org/apache/shardingsphere/shardingproxy/Bootstrap.java](https://coveralls.io/builds/29687799/source?filename=sharding-proxy%2Fsharding-proxy-bootstrap%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingproxy%2FBootstrap.java#L104) | 0 | 2 | 0.0% | [shardingsphere-underlying/shardingsphere-route/src/main/java/org/apache/shardingsphere/underlying/route/DataNodeRouter.java](https://coveralls.io/builds/29687799/source?filename=shardingsphere-underlying%2Fshardingsphere-route%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Funderlying%2Froute%2FDataNodeRouter.java#L62) | 0 | 2 | 0.0% | [encrypt-core/encrypt-core-merge/src/main/java/org/apache/shardingsphere/encrypt/merge/EncryptResultDecoratorEngine.java](https://coveralls.io/builds/29687799/source?filename=encrypt-core%2Fencrypt-core-merge%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fencrypt%2Fmerge%2FEncryptResultDecoratorEngine.java#L38) | 0 | 3 | 0.0% | [sharding-proxy/sharding-proxy-backend/src/main/java/org/apache/shardingsphere/shardingproxy/backend/communication/jdbc/JDBCDatabaseCommunicationEngine.java](https://coveralls.io/builds/29687799/source?filename=sharding-proxy%2Fsharding-proxy-backend%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingproxy%2Fbackend%2Fcommunication%2Fjdbc%2FJDBCDatabaseCommunicationEngine.java#L131) | 0 | 3 | 0.0% | [sharding-jdbc/sharding-jdbc-core/src/main/java/org/apache/shardingsphere/shardingjdbc/jdbc/core/statement/ShardingStatement.java](https://coveralls.io/builds/29687799/source?filename=sharding-jdbc%2Fsharding-jdbc-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingjdbc%2Fjdbc%2Fcore%2Fstatement%2FShardingStatement.java#L111) | 16 | 20 | 80.0% | [shardingsphere-underlying/shardingsphere-merge/src/main/java/org/apache/shardingsphere/underlying/merge/MergeEntry.java](https://coveralls.io/builds/29687799/source?filename=shardingsphere-underlying%2Fshardingsphere-merge%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Funderlying%2Fmerge%2FMergeEntry.java#L63) | 0 | 4 | 0.0% | [shardingsphere-sql-parser/shardingsphere-sql-parser-binder/src/main/java/org/apache/shardingsphere/sql/parser/binder/segment/table/TablesContext.java](https://coveralls.io/builds/29687799/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-binder%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fbinder%2Fsegment%2Ftable%2FTablesContext.java#L81) | 3 | 8 | 37.5% | [shardingsphere-underlying/shardingsphere-pluggable/src/main/java/org/apache/shardingsphere/underlying/pluggble/merge/MergeEngine.java](https://coveralls.io/builds/29687799/source?filename=shardingsphere-underlying%2Fshardingsphere-pluggable%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Funderlying%2Fpluggble%2Fmerge%2FMergeEngine.java#L43) | 0 | 6 | 0.0% | [shardingsphere-underlying/shardingsphere-merge/src/main/java/org/apache/shardingsphere/underlying/merge/registry/ResultProcessEngineRegistry.java](https://coveralls.io/builds/29687799/source?filename=shardingsphere-underlying%2Fshardingsphere-merge%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Funderlying%2Fmerge%2Fregistry%2FResultProcessEngineRegistry.java#L36) | 0 | 11 | 0.0% | Files with Coverage Reduction | New Missed Lines | % | | :-|--|--: | | [sharding-proxy/sharding-proxy-bootstrap/src/main/java/org/apache/shardingsphere/shardingproxy/Bootstrap.java](https://coveralls.io/builds/29687799/source?filename=sharding-proxy%2Fsharding-proxy-bootstrap%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingproxy%2FBootstrap.java#L106) | 1 | 0% | | Totals | [](https://coveralls.io/builds/29687799) | | :-- | --: | | Change from base [Build 10684](https://coveralls.io/builds/29685725): | -0.1% | | Covered Lines: | 11
[GitHub] [incubator-shardingsphere] lennonn edited a comment on issue #4986: if field name of table is "call", encrypt not work.
lennonn edited a comment on issue #4986: if field name of table is "call",encrypt not work. URL: https://github.com/apache/incubator-shardingsphere/issues/4986#issuecomment-605612024 It is not a keywords in oracle, Seems to be handled as a keyword This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] lennonn edited a comment on issue #4986: if field name of table is "call", encrypt not work.
lennonn edited a comment on issue #4986: if field name of table is "call",encrypt not work. URL: https://github.com/apache/incubator-shardingsphere/issues/4986#issuecomment-605612024 It is not a keywords in oracle, seems to be handled as a keyword, encryption failed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] tristaZero opened a new issue #4993: Update statement has wrong parameter count
tristaZero opened a new issue #4993: Update statement has wrong parameter count URL: https://github.com/apache/incubator-shardingsphere/issues/4993 SQL: > UPDATE t_order SET status = status - ? WHERE order_id = ? AND user_id = ? Expected parameter count: 3 Actual parameter count: 2 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] tristaZero opened a new pull request #4994: bugfix for update statement
tristaZero opened a new pull request #4994: bugfix for update statement URL: https://github.com/apache/incubator-shardingsphere/pull/4994 Fixes #4993. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] lennonn edited a comment on issue #4986: if field name of table is "call", encrypt not work.
lennonn edited a comment on issue #4986: if field name of table is "call",encrypt not work. URL: https://github.com/apache/incubator-shardingsphere/issues/4986#issuecomment-605612024 It is not a keywords in oracle, seems to be handled as a keyword, encryption failed. So,avoid using keywords as a solution This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] tristaZero opened a new issue #4995: Add parsing integrated test for `update` query SQL
tristaZero opened a new issue #4995: Add parsing integrated test for `update` query SQL URL: https://github.com/apache/incubator-shardingsphere/issues/4995 **Content**: Add two parsing integrated tests for `update` query SQL. **Difficulty rating**: ★ ### How to do 1. Add the following SQL cases to `/Users/trista/Documents/sharding-code-trista/incubator-shardingsphere/sharding-sql-test/src/main/resources/sql/supported/dml/update.xml` **SQL case ID**: update_with_set_calculation > UPDATE t_order SET status = status - ? WHERE order_id = ? AND user_id = ? parameters: 1, 2, 3 **SQL case ID**: update_with_where_calculation > UPDATE t_order SET status = status WHERE order_id = order_id - ? AND user_id = ? parameter: 1, 2, 3 2. Calculate the parsing results of the above SQL cases and add those parsing results to `./incubator-shardingsphere/shardingsphere-sql-parser/shardingsphere-sql-parser-test/src/test/resources/sql/dml/update.xml` **Tip**: You can refer to the parsing result of SQL case ID `update_without_alias` in the same directory. 3. Run `SQLParserParameterizedTest` to test your SQL cases. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] tristaZero commented on issue #4995: Add parsing integrated test for `update` query SQL
tristaZero commented on issue #4995: Add parsing integrated test for `update` query SQL URL: https://github.com/apache/incubator-shardingsphere/issues/4995#issuecomment-605615581 Here is a good first issue for the community, welcome your join. :) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] codecov-io commented on issue #4994: bugfix for update statement
codecov-io commented on issue #4994: bugfix for update statement URL: https://github.com/apache/incubator-shardingsphere/pull/4994#issuecomment-605616328 # [Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4994?src=pr&el=h1) Report > Merging [#4994](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4994?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-shardingsphere/commit/fec78b9b80028d75f1f892d0d7d3c85e752982ff&el=desc) will **decrease** coverage by `0.17%`. > The diff coverage is `0.00%`. [](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4994?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master#4994 +/- ## - Coverage 54.02% 53.85% -0.18% Complexity 442 442 Files 1146 1145 -1 Lines 2046520469 +4 Branches 3744 3745 +1 - Hits 1105711023 -34 - Misses 8704 8744 +40 + Partials704 702 -2 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4994?src=pr&el=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...gsphere/sql/parser/mysql/visitor/MySQLVisitor.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4994/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLWRpYWxlY3Qvc2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci1teXNxbC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc3FsL3BhcnNlci9teXNxbC92aXNpdG9yL015U1FMVmlzaXRvci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | | | [...phere/sql/parser/oracle/visitor/OracleVisitor.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4994/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLWRpYWxlY3Qvc2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci1vcmFjbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NxbC9wYXJzZXIvb3JhY2xlL3Zpc2l0b3IvT3JhY2xlVmlzaXRvci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | | | [...l/parser/postgresql/visitor/PostgreSQLVisitor.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4994/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLWRpYWxlY3Qvc2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci1wb3N0Z3Jlc3FsL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9zcWwvcGFyc2VyL3Bvc3RncmVzcWwvdmlzaXRvci9Qb3N0Z3JlU1FMVmlzaXRvci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | | | [...gsphere/sql/parser/sql92/visitor/SQL92Visitor.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4994/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLWRpYWxlY3Qvc2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci1zcWw5Mi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc3FsL3BhcnNlci9zcWw5Mi92aXNpdG9yL1NRTDkyVmlzaXRvci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | | | [...sql/parser/sqlserver/visitor/SQLServerVisitor.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4994/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLWRpYWxlY3Qvc2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci1zcWxzZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NxbC9wYXJzZXIvc3Fsc2VydmVyL3Zpc2l0b3IvU1FMU2VydmVyVmlzaXRvci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | | | [...sql/parser/binder/segment/table/TablesContext.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4994/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLWJpbmRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc3FsL3BhcnNlci9iaW5kZXIvc2VnbWVudC90YWJsZS9UYWJsZXNDb250ZXh0LmphdmE=) | `62.96% <0.00%> (-14.31%)` | `0.00% <0.00%> (ø%)` | | | [...ingjdbc/jdbc/core/statement/ShardingStatement.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4994/diff?src=pr&el=tree#diff-c2hhcmRpbmctamRiYy9zaGFyZGluZy1qZGJjLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NoYXJkaW5namRiYy9qZGJjL2NvcmUvc3RhdGVtZW50L1NoYXJkaW5nU3RhdGVtZW50LmphdmE=) | `61.29% <0.00%> (-3.23%)` | `0.00% <0.00%> (ø%)` | | | [...dingjdbc/jdbc/core/resultset/EncryptResultSet.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4994/diff?src=pr&el=tree#diff-c2hhcmRpbmctamRiYy9zaGFyZGluZy1qZGJjLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NoYXJkaW5namRiYy9qZGJjL2NvcmUvcmVzdWx0c2V0L0VuY3J5cHRSZXN1bHRTZXQuamF2YQ==) | `27.20% <0.00%> (-1.15%)` | `0.00% <0.00%> (ø%)` | | | [
[GitHub] [incubator-shardingsphere] coveralls commented on issue #4994: bugfix for update statement
coveralls commented on issue #4994: bugfix for update statement URL: https://github.com/apache/incubator-shardingsphere/pull/4994#issuecomment-605616722 ## Pull Request Test Coverage Report for [Build 10687](https://coveralls.io/builds/29688048) * **0** of **19** **(0.0%)** changed or added relevant lines in **5** files are covered. * **5** unchanged lines in **5** files lost coverage. * Overall coverage decreased (**-0.05%**) to **57.34%** --- | Changes Missing Coverage | Covered Lines | Changed/Added Lines | % | | :-|--||---: | | [shardingsphere-sql-parser/shardingsphere-sql-parser-dialect/shardingsphere-sql-parser-oracle/src/main/java/org/apache/shardingsphere/sql/parser/oracle/visitor/OracleVisitor.java](https://coveralls.io/builds/29688048/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-dialect%2Fshardingsphere-sql-parser-oracle%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Foracle%2Fvisitor%2FOracleVisitor.java#L359) | 0 | 3 | 0.0% | [shardingsphere-sql-parser/shardingsphere-sql-parser-dialect/shardingsphere-sql-parser-postgresql/src/main/java/org/apache/shardingsphere/sql/parser/postgresql/visitor/PostgreSQLVisitor.java](https://coveralls.io/builds/29688048/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-dialect%2Fshardingsphere-sql-parser-postgresql%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fpostgresql%2Fvisitor%2FPostgreSQLVisitor.java#L361) | 0 | 3 | 0.0% | [shardingsphere-sql-parser/shardingsphere-sql-parser-dialect/shardingsphere-sql-parser-sqlserver/src/main/java/org/apache/shardingsphere/sql/parser/sqlserver/visitor/SQLServerVisitor.java](https://coveralls.io/builds/29688048/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-dialect%2Fshardingsphere-sql-parser-sqlserver%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fsqlserver%2Fvisitor%2FSQLServerVisitor.java#L360) | 0 | 3 | 0.0% | [shardingsphere-sql-parser/shardingsphere-sql-parser-dialect/shardingsphere-sql-parser-mysql/src/main/java/org/apache/shardingsphere/sql/parser/mysql/visitor/MySQLVisitor.java](https://coveralls.io/builds/29688048/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-dialect%2Fshardingsphere-sql-parser-mysql%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fmysql%2Fvisitor%2FMySQLVisitor.java#L378) | 0 | 5 | 0.0% | [shardingsphere-sql-parser/shardingsphere-sql-parser-dialect/shardingsphere-sql-parser-sql92/src/main/java/org/apache/shardingsphere/sql/parser/sql92/visitor/SQL92Visitor.java](https://coveralls.io/builds/29688048/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-dialect%2Fshardingsphere-sql-parser-sql92%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fsql92%2Fvisitor%2FSQL92Visitor.java#L351) | 0 | 5 | 0.0% | Files with Coverage Reduction | New Missed Lines | % | | :-|--|--: | | [shardingsphere-sql-parser/shardingsphere-sql-parser-dialect/shardingsphere-sql-parser-mysql/src/main/java/org/apache/shardingsphere/sql/parser/mysql/visitor/MySQLVisitor.java](https://coveralls.io/builds/29688048/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-dialect%2Fshardingsphere-sql-parser-mysql%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fmysql%2Fvisitor%2FMySQLVisitor.java#L379) | 1 | 0% | | [shardingsphere-sql-parser/shardingsphere-sql-parser-dialect/shardingsphere-sql-parser-oracle/src/main/java/org/apache/shardingsphere/sql/parser/oracle/visitor/OracleVisitor.java](https://coveralls.io/builds/29688048/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-dialect%2Fshardingsphere-sql-parser-oracle%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Foracle%2Fvisitor%2FOracleVisitor.java#L360) | 1 | 0% | | [shardingsphere-sql-parser/shardingsphere-sql-parser-dialect/shardingsphere-sql-parser-postgresql/src/main/java/org/apache/shardingsphere/sql/parser/postgresql/visitor/PostgreSQLVisitor.java](https://coveralls.io/builds/29688048/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-dialect%2Fshardingsphere-sql-parser-postgresql%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fpostgresql%2Fvisitor%2FPostgreSQLVisitor.java#L362) | 1 | 0% | | [shardingsphere-sql-parser/shardingsphere-sql-parser-dialect/shardingsphere-sql-parser-sql92/src/main/java/org/apache/shardingsphere/sql/parser/sql92/visitor/SQL92Visitor.java](https://coveralls.io/builds/29688048/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-dialect%2Fshardingsphere-sql-parser-sql92%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fsql92%2Fvisitor%2FSQL92Visitor.java#L352) | 1 | 0% | | [shardingsphere-sql-parser/shardingsphere-sql-parser-dialect/shardingsphere-
[GitHub] [incubator-shardingsphere] tristaZero commented on issue #4994: bugfix for update statement
tristaZero commented on issue #4994: bugfix for update statement URL: https://github.com/apache/incubator-shardingsphere/pull/4994#issuecomment-605617065 This PR needs any committer merging, thx. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu merged pull request #4994: bugfix for update statement
terrymanu merged pull request #4994: bugfix for update statement URL: https://github.com/apache/incubator-shardingsphere/pull/4994 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu closed issue #4993: Update statement has wrong parameter count
terrymanu closed issue #4993: Update statement has wrong parameter count URL: https://github.com/apache/incubator-shardingsphere/issues/4993 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] strongduanmu commented on issue #4995: Add parsing integrated test for `update` query SQL
strongduanmu commented on issue #4995: Add parsing integrated test for `update` query SQL URL: https://github.com/apache/incubator-shardingsphere/issues/4995#issuecomment-605623514 I want to solve this issue, please assign to me! This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] cherrylzhao commented on issue #4991: make ShardingDataSource compatible with Seata in micro-service distribution transaction
cherrylzhao commented on issue #4991: make ShardingDataSource compatible with Seata in micro-service distribution transaction URL: https://github.com/apache/incubator-shardingsphere/issues/4991#issuecomment-605624611 kimmking, thanks for suggestion. sharding-transaction-base-seata-at module only worked in none-microservice mode since it invoke the seata global transaction api directly, so I want to add a switcher to disable it if user want to introduce seata global transaction in microservice. also I'm consider about better way to implement that This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] cherrylzhao commented on issue #4991: make ShardingDataSource compatible with Seata in micro-service distribution transaction
cherrylzhao commented on issue #4991: make ShardingDataSource compatible with
Seata in micro-service distribution transaction
URL:
https://github.com/apache/incubator-shardingsphere/issues/4991#issuecomment-605626684
here is the config for integrating seata-at currently in shardingspehre side
```
client {
application.id = test
transaction.service.group = my_test_tx_group
}
```
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] cherrylzhao commented on issue #4991: make ShardingDataSource compatible with Seata in micro-service distribution transaction
cherrylzhao commented on issue #4991: make ShardingDataSource compatible with
Seata in micro-service distribution transaction
URL:
https://github.com/apache/incubator-shardingsphere/issues/4991#issuecomment-605627436
how about this ?
```
sharding.transaction.seata.at.enable = true
client {
application.id = test
transaction.service.group = my_test_tx_group
}
```
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] strongduanmu commented on issue #4995: Add parsing integrated test for `update` query SQL
strongduanmu commented on issue #4995: Add parsing integrated test for `update` query SQL URL: https://github.com/apache/incubator-shardingsphere/issues/4995#issuecomment-605634845 SQL case ID: update_with_where_calculation > UPDATE t_order SET status = status WHERE order_id = order_id - ? AND user_id = ? parameter: 1, 2, 3 The sql case above has three parameters, but only two placeholders. Is it right? @tristaZero This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] cherrylzhao opened a new pull request #4996: add sharding.transaction.seata.at.enable config to compatible with se…
cherrylzhao opened a new pull request #4996: add sharding.transaction.seata.at.enable config to compatible with se… URL: https://github.com/apache/incubator-shardingsphere/pull/4996 when `sharding.transaction.seata.at.enable = false`, `SeataATShardingTransactionManager` will be disabled, in this way original seata global transaction across services will compatible with shardingsphere since `TransactionalSQLExecutionHook` can transport global txId in multi-threads. user should pay attention that `@ShardingTransactionType(TransactionType.BASE)` should not been introduced in original seata global transaction across services This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu opened a new pull request #4997: Use SPI for route & rewrite & merge
terrymanu opened a new pull request #4997: Use SPI for route & rewrite & merge URL: https://github.com/apache/incubator-shardingsphere/pull/4997 For #3691. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] tristaZero merged pull request #4997: Use SPI for route & rewrite & merge
tristaZero merged pull request #4997: Use SPI for route & rewrite & merge URL: https://github.com/apache/incubator-shardingsphere/pull/4997 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] cherrylzhao commented on issue #4991: make ShardingDataSource compatible with Seata in micro-service distribution transaction
cherrylzhao commented on issue #4991: make ShardingDataSource compatible with Seata in micro-service distribution transaction URL: https://github.com/apache/incubator-shardingsphere/issues/4991#issuecomment-605644192 I have submitted a PR for this config see #4996 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] codecov-io commented on issue #4996: add sharding.transaction.seata.at.enable config to compatible with se…
codecov-io commented on issue #4996: add sharding.transaction.seata.at.enable config to compatible with se… URL: https://github.com/apache/incubator-shardingsphere/pull/4996#issuecomment-605645136 # [Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4996?src=pr&el=h1) Report > Merging [#4996](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4996?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-shardingsphere/commit/74c4e287e0175f3ac413c3a977ff939e47ef6356&el=desc) will **increase** coverage by `0.01%`. > The diff coverage is `95.00%`. [](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4996?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master#4996 +/- ## + Coverage 53.85% 53.86% +0.01% Complexity 442 442 Files 1145 1145 Lines 2046920477 +8 Branches 3745 3746 +1 + Hits 1102311030 +7 Misses 8744 8744 - Partials702 703 +1 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4996?src=pr&el=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...se/seata/at/SeataATShardingTransactionManager.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4996/diff?src=pr&el=tree#diff-c2hhcmRpbmctdHJhbnNhY3Rpb24vc2hhcmRpbmctdHJhbnNhY3Rpb24tYmFzZS9zaGFyZGluZy10cmFuc2FjdGlvbi1iYXNlLXNlYXRhLWF0L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS90cmFuc2FjdGlvbi9iYXNlL3NlYXRhL2F0L1NlYXRhQVRTaGFyZGluZ1RyYW5zYWN0aW9uTWFuYWdlci5qYXZh) | `95.74% <95.00%> (-1.70%)` | `0.00 <0.00> (ø)` | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4996?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4996?src=pr&el=footer). Last update [74c4e28...ac36182](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4996?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] coveralls commented on issue #4996: add sharding.transaction.seata.at.enable config to compatible with se…
coveralls commented on issue #4996: add sharding.transaction.seata.at.enable config to compatible with se… URL: https://github.com/apache/incubator-shardingsphere/pull/4996#issuecomment-605645263 ## Pull Request Test Coverage Report for [Build 10689](https://coveralls.io/builds/29690446) * **20** of **20** **(100.0%)** changed or added relevant lines in **1** file are covered. * No unchanged relevant lines lost coverage. * Overall coverage increased (+**0.02%**) to **57.357%** --- | Totals | [](https://coveralls.io/builds/29690446) | | :-- | --: | | Change from base [Build 10688](https://coveralls.io/builds/29688405): | 0.02% | | Covered Lines: | 11745 | | Relevant Lines: | 20477 | --- # 💛 - [Coveralls](https://coveralls.io) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] codecov-io edited a comment on issue #4996: add sharding.transaction.seata.at.enable config to compatible with se…
codecov-io edited a comment on issue #4996: add sharding.transaction.seata.at.enable config to compatible with se… URL: https://github.com/apache/incubator-shardingsphere/pull/4996#issuecomment-605645136 # [Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4996?src=pr&el=h1) Report > Merging [#4996](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4996?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-shardingsphere/commit/74c4e287e0175f3ac413c3a977ff939e47ef6356&el=desc) will **decrease** coverage by `0.07%`. > The diff coverage is `95.00%`. [](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4996?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master#4996 +/- ## - Coverage 53.85% 53.77% -0.08% Complexity 442 442 Files 1145 1143 -2 Lines 2046920488 +19 Branches 3745 3749 +4 - Hits 1102311017 -6 - Misses 8744 8770 +26 + Partials702 701 -1 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4996?src=pr&el=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...se/seata/at/SeataATShardingTransactionManager.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4996/diff?src=pr&el=tree#diff-c2hhcmRpbmctdHJhbnNhY3Rpb24vc2hhcmRpbmctdHJhbnNhY3Rpb24tYmFzZS9zaGFyZGluZy10cmFuc2FjdGlvbi1iYXNlLXNlYXRhLWF0L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS90cmFuc2FjdGlvbi9iYXNlL3NlYXRhL2F0L1NlYXRhQVRTaGFyZGluZ1RyYW5zYWN0aW9uTWFuYWdlci5qYXZh) | `95.74% <95.00%> (-1.70%)` | `0.00 <0.00> (ø)` | | | [...ere/sharding/merge/ShardingResultMergerEngine.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4996/diff?src=pr&el=tree#diff-c2hhcmRpbmctY29yZS9zaGFyZGluZy1jb3JlLW1lcmdlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9zaGFyZGluZy9tZXJnZS9TaGFyZGluZ1Jlc3VsdE1lcmdlckVuZ2luZS5qYXZh) | `85.71% <0.00%> (-14.29%)` | `0.00% <0.00%> (ø%)` | | | [...ite/context/EncryptSQLRewriteContextDecorator.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4996/diff?src=pr&el=tree#diff-ZW5jcnlwdC1jb3JlL2VuY3J5cHQtY29yZS1yZXdyaXRlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9lbmNyeXB0L3Jld3JpdGUvY29udGV4dC9FbmNyeXB0U1FMUmV3cml0ZUNvbnRleHREZWNvcmF0b3IuamF2YQ==) | `88.88% <0.00%> (-11.12%)` | `0.00% <0.00%> (ø%)` | | | [...te/context/ShardingSQLRewriteContextDecorator.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4996/diff?src=pr&el=tree#diff-c2hhcmRpbmctY29yZS9zaGFyZGluZy1jb3JlLXJld3JpdGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NoYXJkaW5nL3Jld3JpdGUvY29udGV4dC9TaGFyZGluZ1NRTFJld3JpdGVDb250ZXh0RGVjb3JhdG9yLmphdmE=) | `77.77% <0.00%> (-9.73%)` | `1.00% <0.00%> (ø%)` | | | [...jdbc/core/statement/ShardingPreparedStatement.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4996/diff?src=pr&el=tree#diff-c2hhcmRpbmctamRiYy9zaGFyZGluZy1qZGJjLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NoYXJkaW5namRiYy9qZGJjL2NvcmUvc3RhdGVtZW50L1NoYXJkaW5nUHJlcGFyZWRTdGF0ZW1lbnQuamF2YQ==) | `71.30% <0.00%> (-8.70%)` | `0.00% <0.00%> (ø%)` | | | [...ingjdbc/jdbc/core/statement/ShardingStatement.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4996/diff?src=pr&el=tree#diff-c2hhcmRpbmctamRiYy9zaGFyZGluZy1qZGJjLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NoYXJkaW5namRiYy9qZGJjL2NvcmUvc3RhdGVtZW50L1NoYXJkaW5nU3RhdGVtZW50LmphdmE=) | `53.00% <0.00%> (-8.30%)` | `0.00% <0.00%> (ø%)` | | | [...rslave/route/engine/MasterSlaveRouteDecorator.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4996/diff?src=pr&el=tree#diff-bWFzdGVyLXNsYXZlLWNvcmUvbWFzdGVyLXNsYXZlLWNvcmUtcm91dGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL21hc3RlcnNsYXZlL3JvdXRlL2VuZ2luZS9NYXN0ZXJTbGF2ZVJvdXRlRGVjb3JhdG9yLmphdmE=) | `94.44% <0.00%> (-5.56%)` | `0.00% <0.00%> (ø%)` | | | [...gjdbc/jdbc/core/datasource/ShardingDataSource.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4996/diff?src=pr&el=tree#diff-c2hhcmRpbmctamRiYy9zaGFyZGluZy1qZGJjLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NoYXJkaW5namRiYy9qZGJjL2NvcmUvZGF0YXNvdXJjZS9TaGFyZGluZ0RhdGFTb3VyY2UuamF2YQ==) | `92.85% <0.00%> (-1.27%)` | `0.00% <0.00%> (ø%)` | | | [.../sharding/route/engine/ShardingRouteDecorator.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4996/diff?src=pr&el=tree#diff-c2hhcmRp
[GitHub] [incubator-shardingsphere] coveralls edited a comment on issue #4996: add sharding.transaction.seata.at.enable config to compatible with se…
coveralls edited a comment on issue #4996: add sharding.transaction.seata.at.enable config to compatible with se… URL: https://github.com/apache/incubator-shardingsphere/pull/4996#issuecomment-605645263 ## Pull Request Test Coverage Report for [Build 10690](https://coveralls.io/builds/29690675) * **20** of **20** **(100.0%)** changed or added relevant lines in **1** file are covered. * **153** unchanged lines in **13** files lost coverage. * Overall coverage decreased (**-0.09%**) to **57.253%** --- | Files with Coverage Reduction | New Missed Lines | % | | :-|--|--: | | [encrypt-core/encrypt-core-merge/src/main/java/org/apache/shardingsphere/encrypt/merge/EncryptResultDecoratorEngine.java](https://coveralls.io/builds/29690675/source?filename=encrypt-core%2Fencrypt-core-merge%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fencrypt%2Fmerge%2FEncryptResultDecoratorEngine.java#L55) | 1 | 0% | | [encrypt-core/encrypt-core-rewrite/src/main/java/org/apache/shardingsphere/encrypt/rewrite/context/EncryptSQLRewriteContextDecorator.java](https://coveralls.io/builds/29690675/source?filename=encrypt-core%2Fencrypt-core-rewrite%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fencrypt%2Frewrite%2Fcontext%2FEncryptSQLRewriteContextDecorator.java#L48) | 1 | 88.89% | | [master-slave-core/master-slave-core-route/src/main/java/org/apache/shardingsphere/masterslave/route/engine/MasterSlaveRouteDecorator.java](https://coveralls.io/builds/29690675/source?filename=master-slave-core%2Fmaster-slave-core-route%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fmasterslave%2Froute%2Fengine%2FMasterSlaveRouteDecorator.java#L63) | 1 | 94.44% | | [shadow-core/shadow-core-rewrite/src/main/java/org/apache/shardingsphere/shadow/rewrite/context/ShadowSQLRewriteContextDecorator.java](https://coveralls.io/builds/29690675/source?filename=shadow-core%2Fshadow-core-rewrite%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshadow%2Frewrite%2Fcontext%2FShadowSQLRewriteContextDecorator.java#L46) | 1 | 0% | | [sharding-core/sharding-core-merge/src/main/java/org/apache/shardingsphere/sharding/merge/ShardingResultMergerEngine.java](https://coveralls.io/builds/29690675/source?filename=sharding-core%2Fsharding-core-merge%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsharding%2Fmerge%2FShardingResultMergerEngine.java#L50) | 1 | 85.71% | | [sharding-core/sharding-core-rewrite/src/main/java/org/apache/shardingsphere/sharding/rewrite/context/ShardingSQLRewriteContextDecorator.java](https://coveralls.io/builds/29690675/source?filename=sharding-core%2Fsharding-core-rewrite%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsharding%2Frewrite%2Fcontext%2FShardingSQLRewriteContextDecorator.java#L52) | 1 | 77.78% | | [sharding-core/sharding-core-route/src/main/java/org/apache/shardingsphere/sharding/route/engine/ShardingRouteDecorator.java](https://coveralls.io/builds/29690675/source?filename=sharding-core%2Fsharding-core-route%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsharding%2Froute%2Fengine%2FShardingRouteDecorator.java#L157) | 1 | 31.58% | | [sharding-jdbc/sharding-jdbc-core/src/main/java/org/apache/shardingsphere/shardingjdbc/jdbc/core/datasource/EncryptDataSource.java](https://coveralls.io/builds/29690675/source?filename=sharding-jdbc%2Fsharding-jdbc-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingjdbc%2Fjdbc%2Fcore%2Fdatasource%2FEncryptDataSource.java#L36) | 1 | 88.89% | | [shardingsphere-underlying/shardingsphere-pluggable/src/main/java/org/apache/shardingsphere/underlying/pluggble/merge/MergeEngine.java](https://coveralls.io/builds/29690675/source?filename=shardingsphere-underlying%2Fshardingsphere-pluggable%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Funderlying%2Fpluggble%2Fmerge%2FMergeEngine.java#L48) | 16 | 0% | | [sharding-jdbc/sharding-jdbc-core/src/main/java/org/apache/shardingsphere/shardingjdbc/jdbc/core/statement/ShardingPreparedStatement.java](https://coveralls.io/builds/29690675/source?filename=sharding-jdbc%2Fsharding-jdbc-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingjdbc%2Fjdbc%2Fcore%2Fstatement%2FShardingPreparedStatement.java#L130) | 23 | 74.78% | | Totals | [](https://coveralls.io/builds/29690675) | | :-- | --: | | Change from base [Build 10688](https://coveralls.io/builds/29688405): | -0.09% | | Covered Lines: | 11730 | | Relevant Lines: | 20488 | --- # 💛 - [Coveralls](https://coveralls.io) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Ap
[GitHub] [incubator-shardingsphere] TaoZhiMLND commented on a change in pull request #4945: make key-generator as a spring bean on spring namespace.
TaoZhiMLND commented on a change in pull request #4945: make key-generator as a
spring bean on spring namespace.
URL:
https://github.com/apache/incubator-shardingsphere/pull/4945#discussion_r399813763
##
File path:
sharding-core/sharding-core-api/src/main/java/org/apache/shardingsphere/api/config/sharding/KeyGeneratorConfiguration.java
##
@@ -20,27 +20,21 @@
import com.google.common.base.Preconditions;
import com.google.common.base.Strings;
import lombok.Getter;
-import
org.apache.shardingsphere.underlying.common.config.TypeBasedSPIConfiguration;
-
-import java.util.Properties;
+import org.apache.shardingsphere.spi.keygen.ShardingKeyGenerator;
/**
* Key generator configuration.
*/
@Getter
-public final class KeyGeneratorConfiguration extends TypeBasedSPIConfiguration
{
+public final class KeyGeneratorConfiguration {
private final String column;
-public KeyGeneratorConfiguration(final String type, final String column) {
-super(type);
-Preconditions.checkArgument(!Strings.isNullOrEmpty(column), "Column is
required.");
-this.column = column;
-}
+private final ShardingKeyGenerator keyGenerator;
Review comment:
ShardingKeyGenerator has renamed to KeyGenerateAlgorithm.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] TaoZhiMLND commented on a change in pull request #4945: make key-generator as a spring bean on spring namespace.
TaoZhiMLND commented on a change in pull request #4945: make key-generator as a
spring bean on spring namespace.
URL:
https://github.com/apache/incubator-shardingsphere/pull/4945#discussion_r399813872
##
File path:
sharding-core/sharding-core-api/src/main/java/org/apache/shardingsphere/api/config/sharding/KeyGeneratorConfiguration.java
##
@@ -20,27 +20,21 @@
import com.google.common.base.Preconditions;
import com.google.common.base.Strings;
import lombok.Getter;
-import
org.apache.shardingsphere.underlying.common.config.TypeBasedSPIConfiguration;
-
-import java.util.Properties;
+import org.apache.shardingsphere.spi.keygen.ShardingKeyGenerator;
/**
* Key generator configuration.
*/
@Getter
-public final class KeyGeneratorConfiguration extends TypeBasedSPIConfiguration
{
+public final class KeyGeneratorConfiguration {
private final String column;
-public KeyGeneratorConfiguration(final String type, final String column) {
-super(type);
-Preconditions.checkArgument(!Strings.isNullOrEmpty(column), "Column is
required.");
-this.column = column;
-}
+private final ShardingKeyGenerator keyGenerator;
Review comment:
> here we should rename ShardingKeyGenerator SPI to KeyGenerateAlgorithm.
> Be care about modifying all sub class of ShardingKeyGenerator
ShardingKeyGenerator has renamed to KeyGenerateAlgorithm.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] TaoZhiMLND commented on a change in pull request #4945: make key-generator as a spring bean on spring namespace.
TaoZhiMLND commented on a change in pull request #4945: make key-generator as a
spring bean on spring namespace.
URL:
https://github.com/apache/incubator-shardingsphere/pull/4945#discussion_r399813872
##
File path:
sharding-core/sharding-core-api/src/main/java/org/apache/shardingsphere/api/config/sharding/KeyGeneratorConfiguration.java
##
@@ -20,27 +20,21 @@
import com.google.common.base.Preconditions;
import com.google.common.base.Strings;
import lombok.Getter;
-import
org.apache.shardingsphere.underlying.common.config.TypeBasedSPIConfiguration;
-
-import java.util.Properties;
+import org.apache.shardingsphere.spi.keygen.ShardingKeyGenerator;
/**
* Key generator configuration.
*/
@Getter
-public final class KeyGeneratorConfiguration extends TypeBasedSPIConfiguration
{
+public final class KeyGeneratorConfiguration {
private final String column;
-public KeyGeneratorConfiguration(final String type, final String column) {
-super(type);
-Preconditions.checkArgument(!Strings.isNullOrEmpty(column), "Column is
required.");
-this.column = column;
-}
+private final ShardingKeyGenerator keyGenerator;
Review comment:
> here we should rename ShardingKeyGenerator SPI to KeyGenerateAlgorithm.
> Be care about modifying all sub class of ShardingKeyGenerator
ShardingKeyGenerator has renamed to KeyGenerateAlgorithm.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] TaoZhiMLND commented on a change in pull request #4945: make key-generator as a spring bean on spring namespace.
TaoZhiMLND commented on a change in pull request #4945: make key-generator as a
spring bean on spring namespace.
URL:
https://github.com/apache/incubator-shardingsphere/pull/4945#discussion_r399813763
##
File path:
sharding-core/sharding-core-api/src/main/java/org/apache/shardingsphere/api/config/sharding/KeyGeneratorConfiguration.java
##
@@ -20,27 +20,21 @@
import com.google.common.base.Preconditions;
import com.google.common.base.Strings;
import lombok.Getter;
-import
org.apache.shardingsphere.underlying.common.config.TypeBasedSPIConfiguration;
-
-import java.util.Properties;
+import org.apache.shardingsphere.spi.keygen.ShardingKeyGenerator;
/**
* Key generator configuration.
*/
@Getter
-public final class KeyGeneratorConfiguration extends TypeBasedSPIConfiguration
{
+public final class KeyGeneratorConfiguration {
private final String column;
-public KeyGeneratorConfiguration(final String type, final String column) {
-super(type);
-Preconditions.checkArgument(!Strings.isNullOrEmpty(column), "Column is
required.");
-this.column = column;
-}
+private final ShardingKeyGenerator keyGenerator;
Review comment:
ShardingKeyGenerator has renamed to KeyGenerateAlgorithm.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] TaoZhiMLND commented on a change in pull request #4945: make key-generator as a spring bean on spring namespace.
TaoZhiMLND commented on a change in pull request #4945: make key-generator as a
spring bean on spring namespace.
URL:
https://github.com/apache/incubator-shardingsphere/pull/4945#discussion_r399814767
##
File path:
sharding-core/sharding-core-api/src/main/java/org/apache/shardingsphere/api/config/sharding/KeyGeneratorConfiguration.java
##
@@ -20,27 +20,21 @@
import com.google.common.base.Preconditions;
import com.google.common.base.Strings;
import lombok.Getter;
-import
org.apache.shardingsphere.underlying.common.config.TypeBasedSPIConfiguration;
-
-import java.util.Properties;
+import org.apache.shardingsphere.spi.keygen.ShardingKeyGenerator;
/**
* Key generator configuration.
*/
@Getter
-public final class KeyGeneratorConfiguration extends TypeBasedSPIConfiguration
{
+public final class KeyGeneratorConfiguration {
private final String column;
-public KeyGeneratorConfiguration(final String type, final String column) {
-super(type);
-Preconditions.checkArgument(!Strings.isNullOrEmpty(column), "Column is
required.");
-this.column = column;
-}
+private final ShardingKeyGenerator keyGenerator;
Review comment:
> here we should rename ShardingKeyGenerator SPI to KeyGenerateAlgorithm.
> Be care about modifying all sub class of ShardingKeyGenerator
ShardingKeyGenerator has renamed to KeyGenerateAlgorithm, including all sub
class of ShardingKeyGenerator and ShardingKeyGeneratorServiceLoader.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] geomonlin opened a new issue #4998: update user order by registration date
geomonlin opened a new issue #4998: update user order by registration date URL: https://github.com/apache/incubator-shardingsphere/issues/4998 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] geomonlin opened a new pull request #4999: update users order by registration date
geomonlin opened a new pull request #4999: update users order by registration date URL: https://github.com/apache/incubator-shardingsphere/pull/4999 Fixes #4998. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] codecov-io edited a comment on issue #4945: make key-generator as a spring bean on spring namespace.
codecov-io edited a comment on issue #4945: make key-generator as a spring bean on spring namespace. URL: https://github.com/apache/incubator-shardingsphere/pull/4945#issuecomment-604251543 # [Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4945?src=pr&el=h1) Report > Merging [#4945](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4945?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-shardingsphere/commit/1aa9cd7c5eb592fbc922158f3b417c97f2909f29&el=desc) will **increase** coverage by `0.02%`. > The diff coverage is `92.85%`. [](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4945?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master#4945 +/- ## + Coverage 53.75% 53.78% +0.02% - Complexity 442 444 +2 Files 1143 1144 +1 Lines 2048020479 -1 Branches 3748 3747 -1 + Hits 1101011015 +5 + Misses 8770 8765 -5 + Partials700 699 -1 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4945?src=pr&el=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [.../apache/shardingsphere/core/rule/ShardingRule.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4945/diff?src=pr&el=tree#diff-c2hhcmRpbmctY29yZS9zaGFyZGluZy1jb3JlLWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvY29yZS9ydWxlL1NoYXJkaW5nUnVsZS5qYXZh) | `74.00% <80.00%> (ø)` | `0.00 <0.00> (ø)` | | | [...org/apache/shardingsphere/core/rule/TableRule.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4945/diff?src=pr&el=tree#diff-c2hhcmRpbmctY29yZS9zaGFyZGluZy1jb3JlLWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvY29yZS9ydWxlL1RhYmxlUnVsZS5qYXZh) | `84.09% <80.00%> (ø)` | `1.00 <0.00> (ø)` | | | [...api/config/sharding/KeyGeneratorConfiguration.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4945/diff?src=pr&el=tree#diff-c2hhcmRpbmctY29yZS9zaGFyZGluZy1jb3JlLWFwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvYXBpL2NvbmZpZy9zaGFyZGluZy9LZXlHZW5lcmF0b3JDb25maWd1cmF0aW9uLmphdmE=) | `100.00% <100.00%> (+50.00%)` | `0.00 <0.00> (ø)` | | | [...strategy/keygen/SnowflakeKeyGenerateAlgorithm.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4945/diff?src=pr&el=tree#diff-c2hhcmRpbmctY29yZS9zaGFyZGluZy1jb3JlLWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvY29yZS9zdHJhdGVneS9rZXlnZW4vU25vd2ZsYWtlS2V5R2VuZXJhdGVBbGdvcml0aG0uamF2YQ==) | `93.18% <100.00%> (ø)` | `0.00 <0.00> (?)` | | | [...core/strategy/keygen/UUIDKeyGenerateAlgorithm.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4945/diff?src=pr&el=tree#diff-c2hhcmRpbmctY29yZS9zaGFyZGluZy1jb3JlLWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvY29yZS9zdHJhdGVneS9rZXlnZW4vVVVJREtleUdlbmVyYXRlQWxnb3JpdGhtLmphdmE=) | `100.00% <100.00%> (ø)` | `0.00 <0.00> (?)` | | | [.../swapper/KeyGeneratorConfigurationYamlSwapper.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4945/diff?src=pr&el=tree#diff-c2hhcmRpbmctY29yZS9zaGFyZGluZy1jb3JlLWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvY29yZS95YW1sL3N3YXBwZXIvS2V5R2VuZXJhdG9yQ29uZmlndXJhdGlvbllhbWxTd2FwcGVyLmphdmE=) | `100.00% <100.00%> (ø)` | `0.00 <0.00> (ø)` | | | [...ithm/keygen/KeyGenerateAlgorithmServiceLoader.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4945/diff?src=pr&el=tree#diff-c2hhcmRpbmctY29yZS9zaGFyZGluZy1jb3JlLWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc3BpL2FsZ29yaXRobS9rZXlnZW4vS2V5R2VuZXJhdGVBbGdvcml0aG1TZXJ2aWNlTG9hZGVyLmphdmE=) | `100.00% <100.00%> (ø)` | `0.00 <0.00> (?)` | | | [...e/factorybean/KeyGenerateAlgorithmFactoryBean.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4945/diff?src=pr&el=tree#diff-c2hhcmRpbmctc3ByaW5nL3NoYXJkaW5nLWpkYmMtc3ByaW5nL3NoYXJkaW5nLWpkYmMtc3ByaW5nLW5hbWVzcGFjZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc2hhcmRpbmdqZGJjL3NwcmluZy9uYW1lc3BhY2UvZmFjdG9yeWJlYW4vS2V5R2VuZXJhdGVBbGdvcml0aG1GYWN0b3J5QmVhbi5qYXZh) | `100.00% <100.00%> (ø)` | `2.00 <2.00> (?)` | | | [...space/parser/KeyGeneratorBeanDefinitionParser.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4945/diff?src=pr&el=tree#diff-c2hhcmRpbmctc3ByaW5nL3NoYXJkaW5nLWpkYmMtc3ByaW5nL3NoYXJkaW5nLWpkYmMtc3ByaW5nLW5hbWVzcGFjZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc2hhcmRpbmdqZGJjL3NwcmluZy9uY
[GitHub] [incubator-shardingsphere] coveralls edited a comment on issue #4945: make key-generator as a spring bean on spring namespace.
coveralls edited a comment on issue #4945: make key-generator as a spring bean on spring namespace. URL: https://github.com/apache/incubator-shardingsphere/pull/4945#issuecomment-604253200 ## Pull Request Test Coverage Report for [Build 10693](https://coveralls.io/builds/29691293) * **28** of **28** **(100.0%)** changed or added relevant lines in **9** files are covered. * No unchanged relevant lines lost coverage. * Overall coverage increased (+**0.02%**) to **57.259%** --- | Totals | [](https://coveralls.io/builds/29691293) | | :-- | --: | | Change from base [Build 10692](https://coveralls.io/builds/29690884): | 0.02% | | Covered Lines: | 11726 | | Relevant Lines: | 20479 | --- # 💛 - [Coveralls](https://coveralls.io) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] coveralls commented on issue #4999: update users order by registration date
coveralls commented on issue #4999: update users order by registration date URL: https://github.com/apache/incubator-shardingsphere/pull/4999#issuecomment-605660902 ## Pull Request Test Coverage Report for [Build 10694](https://coveralls.io/builds/29691476) * **0** of **0** changed or added relevant lines in **0** files are covered. * No unchanged relevant lines lost coverage. * Overall coverage remained the same at **57.236%** --- | Totals | [](https://coveralls.io/builds/29691476) | | :-- | --: | | Change from base [Build 10692](https://coveralls.io/builds/29690884): | 0.0% | | Covered Lines: | 11722 | | Relevant Lines: | 20480 | --- # 💛 - [Coveralls](https://coveralls.io) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu merged pull request #4999: update users order by registration date
terrymanu merged pull request #4999: update users order by registration date URL: https://github.com/apache/incubator-shardingsphere/pull/4999 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu closed issue #4998: update user order by registration date in doc
terrymanu closed issue #4998: update user order by registration date in doc URL: https://github.com/apache/incubator-shardingsphere/issues/4998 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] masankin commented on issue #4256: hintManager.setDatabaseShardingValue do not work.
masankin commented on issue #4256: hintManager.setDatabaseShardingValue do not work. URL: https://github.com/apache/incubator-shardingsphere/issues/4256#issuecomment-605669368 > duplicate with #3964 . How long could it to be released to the next version This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] masankin edited a comment on issue #4256: hintManager.setDatabaseShardingValue do not work.
masankin edited a comment on issue #4256: hintManager.setDatabaseShardingValue do not work. URL: https://github.com/apache/incubator-shardingsphere/issues/4256#issuecomment-605669368 > duplicate with #3964 . How long could it to be release to the next version This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[incubator-shardingsphere-benchmark] branch master updated: for performance
This is an automated email from the ASF dual-hosted git repository.
zhangyonglun pushed a commit to branch master
in repository
https://gitbox.apache.org/repos/asf/incubator-shardingsphere-benchmark.git
The following commit(s) were added to refs/heads/master by this push:
new 76958f6 for performance
76958f6 is described below
commit 76958f6d0133ac45874dc6ccac9ce8a60080127b
Author: tuohai666
AuthorDate: Mon Mar 30 04:52:29 2020 +0800
for performance
---
report/jtl_json/full_route_test.json| 2 +-
report/jtl_json/master_slave_encrypt_sharding_test.json | 2 +-
report/jtl_json/master_slave_test.json | 2 +-
report/jtl_json/single_route_test.json | 2 +-
4 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/report/jtl_json/full_route_test.json
b/report/jtl_json/full_route_test.json
index 491bcc0..262ce47 100644
--- a/report/jtl_json/full_route_test.json
+++ b/report/jtl_json/full_route_test.json
@@ -1 +1 @@
-{"SELECT": [{"data": [{"99.9th": "9", "Err": "0.0%", "95th": "2", "50th": "1",
"Max": "10", "Min": "0", "Throughout": "23036.87", "Samples": 4999, "Date":
"2019.12.19 02:35:57 ", "Avg": "0"}, {"99.9th": "9", "Err": "0.0%", "95th":
"2", "50th": "1", "Max": "9", "Min": "0", "Throughout": "22619.91", "Samples":
4999, "Date": "2019.12.20 13:34:47 ", "Avg": "0"}, {"99.9th": "9", "Err":
"0.0%", "95th": "2", "50th": "1", "Max": "9", "Min": "0", "Throughout":
"22931.19", "Samples": 4999, "Date": [...]
\ No newline at end of file
+{"SELECT": [{"data": [{"99.9th": "9", "Err": "0.0%", "95th": "2", "50th": "1",
"Max": "10", "Min": "0", "Throughout": "23036.87", "Samples": 4999, "Date":
"2019.12.19 02:35:57 ", "Avg": "0"}, {"99.9th": "9", "Err": "0.0%", "95th":
"2", "50th": "1", "Max": "9", "Min": "0", "Throughout": "22619.91", "Samples":
4999, "Date": "2019.12.20 13:34:47 ", "Avg": "0"}, {"99.9th": "9", "Err":
"0.0%", "95th": "2", "50th": "1", "Max": "9", "Min": "0", "Throughout":
"22931.19", "Samples": 4999, "Date": [...]
\ No newline at end of file
diff --git a/report/jtl_json/master_slave_encrypt_sharding_test.json
b/report/jtl_json/master_slave_encrypt_sharding_test.json
index b652a61..9839048 100644
--- a/report/jtl_json/master_slave_encrypt_sharding_test.json
+++ b/report/jtl_json/master_slave_encrypt_sharding_test.json
@@ -1 +1 @@
-{"SELECT": [{"data": [{"99.9th": "16", "Err": "0.0%", "95th": "3", "50th":
"2", "Max": "66", "Min": "1", "Throughout": "9381.73", "Samples": 99,
"Date": "2019.12.19 02:40:33 ", "Avg": "2"}, {"99.9th": "16", "Err": "0.0%",
"95th": "3", "50th": "2", "Max": "62", "Min": "1", "Throughout": "9038.48",
"Samples": 99, "Date": "2019.12.20 13:39:23 ", "Avg": "2"}, {"99.9th":
"16", "Err": "0.0%", "95th": "3", "50th": "2", "Max": "63", "Min": "1",
"Throughout": "9071.44", "Samples": 99, [...]
\ No newline at end of file
+{"SELECT": [{"data": [{"99.9th": "16", "Err": "0.0%", "95th": "3", "50th":
"2", "Max": "66", "Min": "1", "Throughout": "9381.73", "Samples": 99,
"Date": "2019.12.19 02:40:33 ", "Avg": "2"}, {"99.9th": "16", "Err": "0.0%",
"95th": "3", "50th": "2", "Max": "62", "Min": "1", "Throughout": "9038.48",
"Samples": 99, "Date": "2019.12.20 13:39:23 ", "Avg": "2"}, {"99.9th":
"16", "Err": "0.0%", "95th": "3", "50th": "2", "Max": "63", "Min": "1",
"Throughout": "9071.44", "Samples": 99, [...]
\ No newline at end of file
diff --git a/report/jtl_json/master_slave_test.json
b/report/jtl_json/master_slave_test.json
index 6d9e906..96d9d39 100644
--- a/report/jtl_json/master_slave_test.json
+++ b/report/jtl_json/master_slave_test.json
@@ -1 +1 @@
-{"INSERT+SELECT+DELETE": [{"data": [], "type": "Sharding-Proxy_3.1"}, {"data":
[{"99.9th": "38", "Err": "0.0%", "95th": "16", "50th": "11", "Max": "48",
"Min": "7", "Throughout": "1720.96", "Samples": 29709, "Date": "2020.01.01
02:49:45 ", "Avg": "11"}, {"99.9th": "27", "Err": "0.0%", "95th": "16", "50th":
"11", "Max": "37", "Min": "7", "Throughout": "1701.38", "Samples": 17218,
"Date": "2020.01.02 02:49:52 ", "Avg": "11"}, {"99.9th": "30", "Err": "0.0%",
"95th": "16", "50th": "11", "Max [...]
\ No newline at end of file
+{"INSERT+SELECT+DELETE": [{"data": [], "type": "Sharding-Proxy_3.1"}, {"data":
[{"99.9th": "38", "Err": "0.0%", "95th": "16", "50th": "11", "Max": "48",
"Min": "7", "Throughout": "1720.96", "Samples": 29709, "Date": "2020.01.01
02:49:45 ", "Avg": "11"}, {"99.9th": "27", "Err": "0.0%", "95th": "16", "50th":
"11", "Max": "37", "Min": "7", "Throughout": "1701.38", "Samples": 17218,
"Date": "2020.01.02 02:49:52 ", "Avg": "11"}, {"99.9th": "30", "Err": "0.0%",
"95th": "16", "50th": "11", "Max [...]
\ No newline at end of file
diff --git a/report/jtl_json/single_route_test.json
b/report/jtl_json/single_route_test.json
index 54a9f38..c4d9240 100644
--- a/report/jtl_json/single_route_test.json
+++ b/report/jtl_json/single_route_test.json
@@ -1 +1 @@
-{"SELECT": [{"data": [], "type": "Sharding-Proxy_
[GitHub] [incubator-shardingsphere] KomachiSion opened a new pull request #5000: Fix picture url error in scaling documents
KomachiSion opened a new pull request #5000: Fix picture url error in scaling documents URL: https://github.com/apache/incubator-shardingsphere/pull/5000 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] codecov-io commented on issue #5000: Fix picture url error in scaling documents
codecov-io commented on issue #5000: Fix picture url error in scaling documents URL: https://github.com/apache/incubator-shardingsphere/pull/5000#issuecomment-605740660 # [Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5000?src=pr&el=h1) Report > Merging [#5000](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5000?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-shardingsphere/commit/a2b639c6a4b0de01929d57ff7cf2ac48f0b25ec2&el=desc) will **not change** coverage by `%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5000?src=pr&el=tree) ```diff @@Coverage Diff@@ ## master#5000 +/- ## = Coverage 53.75% 53.75% Complexity 442 442 = Files 1143 1143 Lines 2048020480 Branches 3748 3748 = Hits 1101011010 Misses 8770 8770 Partials700 700 ``` -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5000?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5000?src=pr&el=footer). Last update [a2b639c...4566c98](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5000?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] coveralls commented on issue #5000: Fix picture url error in scaling documents
coveralls commented on issue #5000: Fix picture url error in scaling documents URL: https://github.com/apache/incubator-shardingsphere/pull/5000#issuecomment-605741799 ## Pull Request Test Coverage Report for [Build 10696](https://coveralls.io/builds/29697292) * **0** of **0** changed or added relevant lines in **0** files are covered. * No unchanged relevant lines lost coverage. * Overall coverage remained the same at **57.236%** --- | Totals | [](https://coveralls.io/builds/29697292) | | :-- | --: | | Change from base [Build 10695](https://coveralls.io/builds/29692040): | 0.0% | | Covered Lines: | 11722 | | Relevant Lines: | 20480 | --- # 💛 - [Coveralls](https://coveralls.io) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] tristaZero commented on issue #4995: Add parsing integrated test for `update` query SQL
tristaZero commented on issue #4995: Add parsing integrated test for `update` query SQL URL: https://github.com/apache/incubator-shardingsphere/issues/4995#issuecomment-605756484 @strongduanmu Sorry, it is a typo and I fixed it. Please give it a look. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] kimmking commented on issue #4991: make ShardingDataSource compatible with Seata in micro-service distribution transaction
kimmking commented on issue #4991: make ShardingDataSource compatible with Seata in micro-service distribution transaction URL: https://github.com/apache/incubator-shardingsphere/issues/4991#issuecomment-605759167 it's awesome This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] kimmking commented on a change in pull request #4996: add sharding.transaction.seata.at.enable config to compatible with se…
kimmking commented on a change in pull request #4996: add
sharding.transaction.seata.at.enable config to compatible with se…
URL:
https://github.com/apache/incubator-shardingsphere/pull/4996#discussion_r399905912
##
File path:
sharding-transaction/sharding-transaction-base/sharding-transaction-base-seata-at/src/main/java/org/apache/shardingsphere/transaction/base/seata/at/SeataATShardingTransactionManager.java
##
@@ -47,34 +47,56 @@
private final Map dataSourceMap = new HashMap<>();
-private final FileConfiguration configuration = new
FileConfiguration("seata.conf");
+private final String applicationId;
+
+private final String transactionServiceGroup;
+
+private final boolean enableSeataAT;
+
+public SeataATShardingTransactionManager() {
+FileConfiguration configuration = new FileConfiguration("seata.conf");
+enableSeataAT =
configuration.getBoolean("sharding.transaction.seata.at.enable", true);
Review comment:
Constant for literal？
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] kimmking commented on a change in pull request #4996: add sharding.transaction.seata.at.enable config to compatible with se…
kimmking commented on a change in pull request #4996: add
sharding.transaction.seata.at.enable config to compatible with se…
URL:
https://github.com/apache/incubator-shardingsphere/pull/4996#discussion_r399906632
##
File path:
sharding-transaction/sharding-transaction-base/sharding-transaction-base-seata-at/src/main/java/org/apache/shardingsphere/transaction/base/seata/at/SeataATShardingTransactionManager.java
##
@@ -47,34 +47,56 @@
private final Map dataSourceMap = new HashMap<>();
-private final FileConfiguration configuration = new
FileConfiguration("seata.conf");
+private final String applicationId;
+
+private final String transactionServiceGroup;
+
+private final boolean enableSeataAT;
+
+public SeataATShardingTransactionManager() {
+FileConfiguration configuration = new FileConfiguration("seata.conf");
+enableSeataAT =
configuration.getBoolean("sharding.transaction.seata.at.enable", true);
+applicationId = configuration.getConfig("client.application.id");
+transactionServiceGroup =
configuration.getConfig("client.transaction.service.group", "default");
+}
@Override
public void init(final DatabaseType databaseType, final
Collection resourceDataSources) {
-initSeataRPCClient();
-for (ResourceDataSource each : resourceDataSources) {
-dataSourceMap.put(each.getOriginalName(), new
DataSourceProxy(each.getDataSource()));
+if (enableSeataAT) {
Review comment:
If turn off this flag, seata client is not initialized and seat-at is
disabled?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] strongduanmu commented on issue #4995: Add parsing integrated test for `update` query SQL
strongduanmu commented on issue #4995: Add parsing integrated test for `update` query SQL URL: https://github.com/apache/incubator-shardingsphere/issues/4995#issuecomment-605762553 > @strongduanmu Sorry, it is a typo and I fixed it. Please give it a look. Thank you! :smile: This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu merged pull request #4996: add sharding.transaction.seata.at.enable config to compatible with se…
terrymanu merged pull request #4996: add sharding.transaction.seata.at.enable config to compatible with se… URL: https://github.com/apache/incubator-shardingsphere/pull/4996 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu merged pull request #5000: Fix picture url error in scaling documents
terrymanu merged pull request #5000: Fix picture url error in scaling documents URL: https://github.com/apache/incubator-shardingsphere/pull/5000 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere-doc] tuohai666 closed pull request #462: update website
tuohai666 closed pull request #462: update website URL: https://github.com/apache/incubator-shardingsphere-doc/pull/462 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere-doc] tuohai666 opened a new pull request #462: update website
tuohai666 opened a new pull request #462: update website URL: https://github.com/apache/incubator-shardingsphere-doc/pull/462 Create from jenkins This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere-doc] tuohai666 opened a new pull request #463: update website
tuohai666 opened a new pull request #463: update website URL: https://github.com/apache/incubator-shardingsphere-doc/pull/463 Create from jenkins This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere-doc] tuohai666 closed pull request #463: update website
tuohai666 closed pull request #463: update website URL: https://github.com/apache/incubator-shardingsphere-doc/pull/463 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere-doc] tuohai666 opened a new pull request #464: update website
tuohai666 opened a new pull request #464: update website URL: https://github.com/apache/incubator-shardingsphere-doc/pull/464 Create from jenkins This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] coveralls edited a comment on issue #4961: fix selectStatement contained tableReferences for other db
coveralls edited a comment on issue #4961: fix selectStatement contained tableReferences for other db URL: https://github.com/apache/incubator-shardingsphere/pull/4961#issuecomment-604846960 ## Pull Request Test Coverage Report for [Build 10701](https://coveralls.io/builds/29699367) * **1** of **191** **(0.52%)** changed or added relevant lines in **6** files are covered. * **729** unchanged lines in **39** files lost coverage. * Overall coverage decreased (**-0.6%**) to **57.178%** --- | Changes Missing Coverage | Covered Lines | Changed/Added Lines | % | | :-|--||---: | | [shardingsphere-sql-parser/shardingsphere-sql-parser-statement/src/main/java/org/apache/shardingsphere/sql/parser/sql/statement/dml/SelectStatement.java](https://coveralls.io/builds/29699367/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-statement%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fsql%2Fstatement%2Fdml%2FSelectStatement.java#L110) | 0 | 2 | 0.0% | [shardingsphere-sql-parser/shardingsphere-sql-parser-dialect/shardingsphere-sql-parser-sql92/src/main/java/org/apache/shardingsphere/sql/parser/sql92/visitor/impl/SQL92DMLVisitor.java](https://coveralls.io/builds/29699367/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-dialect%2Fshardingsphere-sql-parser-sql92%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fsql92%2Fvisitor%2Fimpl%2FSQL92DMLVisitor.java#L139) | 0 | 44 | 0.0% | [shardingsphere-sql-parser/shardingsphere-sql-parser-dialect/shardingsphere-sql-parser-oracle/src/main/java/org/apache/shardingsphere/sql/parser/oracle/visitor/impl/OracleDMLVisitor.java](https://coveralls.io/builds/29699367/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-dialect%2Fshardingsphere-sql-parser-oracle%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Foracle%2Fvisitor%2Fimpl%2FOracleDMLVisitor.java#L145) | 0 | 48 | 0.0% | [shardingsphere-sql-parser/shardingsphere-sql-parser-dialect/shardingsphere-sql-parser-postgresql/src/main/java/org/apache/shardingsphere/sql/parser/postgresql/visitor/impl/PostgreSQLDMLVisitor.java](https://coveralls.io/builds/29699367/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-dialect%2Fshardingsphere-sql-parser-postgresql%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fpostgresql%2Fvisitor%2Fimpl%2FPostgreSQLDMLVisitor.java#L151) | 0 | 48 | 0.0% | [shardingsphere-sql-parser/shardingsphere-sql-parser-dialect/shardingsphere-sql-parser-sqlserver/src/main/java/org/apache/shardingsphere/sql/parser/sqlserver/visitor/impl/SQLServerDMLVisitor.java](https://coveralls.io/builds/29699367/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-dialect%2Fshardingsphere-sql-parser-sqlserver%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fsqlserver%2Fvisitor%2Fimpl%2FSQLServerDMLVisitor.java#L140) | 0 | 48 | 0.0% | Files with Coverage Reduction | New Missed Lines | % | | :-|--|--: | | [encrypt-core/encrypt-core-rewrite/src/main/java/org/apache/shardingsphere/encrypt/rewrite/context/EncryptSQLRewriteContextDecorator.java](https://coveralls.io/builds/29699367/source?filename=encrypt-core%2Fencrypt-core-rewrite%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fencrypt%2Frewrite%2Fcontext%2FEncryptSQLRewriteContextDecorator.java#L48) | 1 | 88.89% | | [master-slave-core/master-slave-core-route/src/main/java/org/apache/shardingsphere/masterslave/route/engine/MasterSlaveRouteDecorator.java](https://coveralls.io/builds/29699367/source?filename=master-slave-core%2Fmaster-slave-core-route%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fmasterslave%2Froute%2Fengine%2FMasterSlaveRouteDecorator.java#L63) | 1 | 94.44% | | [shadow-core/shadow-core-rewrite/src/main/java/org/apache/shardingsphere/shadow/rewrite/context/ShadowSQLRewriteContextDecorator.java](https://coveralls.io/builds/29699367/source?filename=shadow-core%2Fshadow-core-rewrite%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshadow%2Frewrite%2Fcontext%2FShadowSQLRewriteContextDecorator.java#L46) | 1 | 0% | | [sharding-core/sharding-core-merge/src/main/java/org/apache/shardingsphere/sharding/merge/ShardingResultMergerEngine.java](https://coveralls.io/builds/29699367/source?filename=sharding-core%2Fsharding-core-merge%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsharding%2Fmerge%2FShardingResultMergerEngine.java#L50) | 1 | 85.71% | | [sharding-core/sharding-core-rewrite/src/main/java/org/apache/shardingsphere/sharding/rewrite/context/ShardingSQLRewriteContextDecorator.java](https://coveralls.io/builds/29699367/source?filename=sharding-core%2Fsharding-core-rewrite%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsharding%2Frewrite%2Fcontext%2FShardingSQLRewriteContextDecorator.java#L52) | 1 | 77.78% | | [sha
[GitHub] [incubator-shardingsphere] KomachiSion closed issue #3655: The work flow and roadmap of sharding-scaling
KomachiSion closed issue #3655: The work flow and roadmap of sharding-scaling URL: https://github.com/apache/incubator-shardingsphere/issues/3655 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] KomachiSion commented on issue #3655: The work flow and roadmap of sharding-scaling
KomachiSion commented on issue #3655: The work flow and roadmap of sharding-scaling URL: https://github.com/apache/incubator-shardingsphere/issues/3655#issuecomment-605796443 Update in document https://shardingsphere.apache.org/document/current/en/features/sharding-scaling/ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] KomachiSion closed issue #4594: Create database protocol module
KomachiSion closed issue #4594: Create database protocol module URL: https://github.com/apache/incubator-shardingsphere/issues/4594 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere-doc] tuohai666 closed pull request #464: update website
tuohai666 closed pull request #464: update website URL: https://github.com/apache/incubator-shardingsphere-doc/pull/464 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] tristaZero opened a new issue #5001: The task summary of SQL parse module
tristaZero opened a new issue #5001: The task summary of SQL parse module URL: https://github.com/apache/incubator-shardingsphere/issues/5001 Remaining todo list for SQL parse module - [ ] Parse `joinTable` Query SQL(#4885) - [ ] Support `TOP()` (#4867) - [ ] Support pagination (#4887) - [ ] Make subquery parsing test work well (#4696) - [ ] Move predicateBuilder from `Parser module` to `Bind module` - [ ] Check test coverage of Sharding Parse and analysis SQL cases to improve this coverage - [ ] Collate SQL grammar definitions (#4683) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] tristaZero commented on issue #5001: The task summary of SQL parse module
tristaZero commented on issue #5001: The task summary of SQL parse module URL: https://github.com/apache/incubator-shardingsphere/issues/5001#issuecomment-605815781 @jingshanglu Hi This issue is a summary of the remaining tasks for sharding parser, which needs your hand, our veteran. :) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
